Page MenuHomePhabricator

saudi (Sylvain Audi)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 16 2019, 1:22 PM (86 w, 5 d)

Recent Activity

Mon, May 17

saudi requested review of D102633: [clang-scan-deps] Improvements to thread usage.
Mon, May 17, 8:27 AM · Restricted Project, Restricted Project
saudi committed rG6052a8a53559: [clang] In DependencyCollector on Windows, ignore case and separators when… (authored by saudi).
[clang] In DependencyCollector on Windows, ignore case and separators when…
Mon, May 17, 7:34 AM
saudi closed D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths..
Mon, May 17, 7:34 AM · Restricted Project

May 13 2021

saudi updated the diff for D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths..

Updated for comments from @rnk, except for the canonicalization part.

May 13 2021, 7:04 AM · Restricted Project

May 12 2021

saudi requested review of D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths..
May 12 2021, 10:58 AM · Restricted Project

Apr 21 2021

saudi added a reverting change for rG199c39748292: Revert "[clang-scan-deps] Add support for clang-cl": rG8c16c8b7ef7b: Reland "[clang-scan-deps] Add support for clang-cl".
Apr 21 2021, 5:17 AM
saudi committed rG8c16c8b7ef7b: Reland "[clang-scan-deps] Add support for clang-cl" (authored by saudi).
Reland "[clang-scan-deps] Add support for clang-cl"
Apr 21 2021, 5:17 AM

Mar 8 2021

saudi added inline comments to D97387: propose Chocolately as package manager for Windows.
Mar 8 2021, 7:02 AM · Restricted Project

Feb 1 2021

saudi added a comment to D95099: [clang-scan-deps] : Support -- in clang command lines..

Ping!

Feb 1 2021, 12:57 PM · Restricted Project

Jan 22 2021

saudi updated the diff for D92191: [clang-scan-deps] Add support for clang-cl.

Applied the suggestions from the parent patch D95099

Jan 22 2021, 9:29 AM · Restricted Project

Jan 21 2021

saudi added inline comments to D95099: [clang-scan-deps] : Support -- in clang command lines..
Jan 21 2021, 1:40 PM · Restricted Project
saudi updated the diff for D95099: [clang-scan-deps] : Support -- in clang command lines..

Updated for suggested modifications

Jan 21 2021, 1:39 PM · Restricted Project
saudi added inline comments to D92191: [clang-scan-deps] Add support for clang-cl.
Jan 21 2021, 10:06 AM · Restricted Project
saudi updated the diff for D92191: [clang-scan-deps] Add support for clang-cl.

Removed the support for "--" command lines, it was extracted to patch D95099.
Applied suggested fixes.

Jan 21 2021, 10:01 AM · Restricted Project
saudi updated the diff for D95099: [clang-scan-deps] : Support -- in clang command lines..

Bugfixes on the use of the iterator.

Jan 21 2021, 8:04 AM · Restricted Project

Jan 20 2021

saudi requested review of D95099: [clang-scan-deps] : Support -- in clang command lines..
Jan 20 2021, 2:48 PM · Restricted Project

Jan 19 2021

saudi added a comment to D92191: [clang-scan-deps] Add support for clang-cl.

Ping!
Would anybody have a chance to take a look at this? I'd like to submit this before the LLVM 12 branch, if possible? Thanks in advance!

Jan 19 2021, 8:51 AM · Restricted Project

Jan 14 2021

saudi added a comment to D92136: [clang] Enhanced test for --relocatable-pch, and corresponding fixes for Windows.

Ping!

Jan 14 2021, 1:58 PM · Restricted Project, Restricted Project
saudi requested review of D92191: [clang-scan-deps] Add support for clang-cl.
Jan 14 2021, 1:35 PM · Restricted Project
saudi reopened D92191: [clang-scan-deps] Add support for clang-cl.
Jan 14 2021, 1:35 PM · Restricted Project
saudi updated the diff for D92191: [clang-scan-deps] Add support for clang-cl.

Updated the tests for clang-cl command lines:
I moved the input files to end of command line, with --, to avoid linux-style paths conflict with clang-cl arguments.

Jan 14 2021, 1:35 PM · Restricted Project

Dec 14 2020

saudi added a reverting change for rG640ad769110f: [clang-scan-deps] Support clang-cl: rG5f53d28fa681: Revert "[clang-scan-deps] Support clang-cl".
Dec 14 2020, 10:33 AM
saudi committed rG5f53d28fa681: Revert "[clang-scan-deps] Support clang-cl" (authored by saudi).
Revert "[clang-scan-deps] Support clang-cl"
Dec 14 2020, 10:33 AM
saudi added a reverting change for D92191: [clang-scan-deps] Add support for clang-cl: rG5f53d28fa681: Revert "[clang-scan-deps] Support clang-cl".
Dec 14 2020, 10:33 AM · Restricted Project
saudi committed rG640ad769110f: [clang-scan-deps] Support clang-cl (authored by saudi).
[clang-scan-deps] Support clang-cl
Dec 14 2020, 9:08 AM
saudi closed D92191: [clang-scan-deps] Add support for clang-cl.
Dec 14 2020, 9:07 AM · Restricted Project

Dec 9 2020

saudi added a comment to D92191: [clang-scan-deps] Add support for clang-cl.

Ping!

Dec 9 2020, 9:23 AM · Restricted Project

Dec 1 2020

saudi updated the diff for D92191: [clang-scan-deps] Add support for clang-cl.

Rebase after https://reviews.llvm.org/D92330.
Also, improved the detection of target obj file.

Dec 1 2020, 2:16 PM · Restricted Project
saudi committed rG79ba7967f481: [clang-scan-deps] Improve argument parsing to find target object file path. (authored by saudi).
[clang-scan-deps] Improve argument parsing to find target object file path.
Dec 1 2020, 12:04 PM
saudi closed D92330: [clang-scan-deps] Improve argument parsing to find target object file path..
Dec 1 2020, 12:04 PM · Restricted Project

Nov 30 2020

saudi added a reviewer for D92136: [clang] Enhanced test for --relocatable-pch, and corresponding fixes for Windows: dblaikie.
Nov 30 2020, 12:19 PM · Restricted Project, Restricted Project
saudi requested review of D92330: [clang-scan-deps] Improve argument parsing to find target object file path..
Nov 30 2020, 9:12 AM · Restricted Project

Nov 27 2020

saudi updated the diff for D92191: [clang-scan-deps] Add support for clang-cl.

Removed /Fo option. -o is also supported by clang-cl and overrides /Fo options that are found earlier in the command line.

Nov 27 2020, 8:44 AM · Restricted Project

Nov 26 2020

saudi requested review of D92191: [clang-scan-deps] Add support for clang-cl.
Nov 26 2020, 10:35 AM · Restricted Project
saudi updated the diff for D92136: [clang] Enhanced test for --relocatable-pch, and corresponding fixes for Windows.

Update patch : clang-format fixes.

Nov 26 2020, 6:29 AM · Restricted Project, Restricted Project

Nov 25 2020

saudi requested review of D92136: [clang] Enhanced test for --relocatable-pch, and corresponding fixes for Windows.
Nov 25 2020, 1:57 PM · Restricted Project, Restricted Project

Nov 12 2020

saudi committed rG79105e464429: [clang-scan-deps] Fix for input file given as relative path in compilation… (authored by saudi).
[clang-scan-deps] Fix for input file given as relative path in compilation…
Nov 12 2020, 5:48 AM
saudi closed D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry.
Nov 12 2020, 5:48 AM · Restricted Project

Nov 11 2020

saudi updated the diff for D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry.

Simplified the RealFS initialization, as suggested

Nov 11 2020, 2:03 PM · Restricted Project
saudi added inline comments to D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry.
Nov 11 2020, 1:25 PM · Restricted Project
saudi updated the diff for D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry.

Removed use of ProxyFileSystem

Nov 11 2020, 1:16 PM · Restricted Project

Nov 10 2020

saudi retitled D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry from [[clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry to [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry.
Nov 10 2020, 2:09 PM · Restricted Project
saudi updated the diff for D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry.

Updated the patch.

Nov 10 2020, 2:08 PM · Restricted Project
saudi requested review of D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry.
Nov 10 2020, 1:25 PM · Restricted Project

Oct 13 2020

saudi added inline comments to D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields.
Oct 13 2020, 9:09 AM · Restricted Project
saudi added inline comments to D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields.
Oct 13 2020, 8:55 AM · Restricted Project

Jul 20 2020

saudi committed rG3a108ab256db: [LLD][COFF] Skip computation of the undefined symbols references that are not… (authored by saudi).
[LLD][COFF] Skip computation of the undefined symbols references that are not…
Jul 20 2020, 9:17 PM
saudi closed D83510: [LLD][COFF] Skip computation of the undefined symbols references that are not shown.
Jul 20 2020, 9:17 PM · Restricted Project, lld
saudi added a comment to D83510: [LLD][COFF] Skip computation of the undefined symbols references that are not shown.

LGTM (but maybe wait for a bit to see if someone else might have more opinions)

FWIW, I think this codepath exists in a fairly similar form in the ELF backend, that might benefit from a similar optimization.

Jul 20 2020, 9:16 PM · Restricted Project, lld

Jul 10 2020

saudi updated the diff for D83510: [LLD][COFF] Skip computation of the undefined symbols references that are not shown.

Updated the test, adding an LTO obj file.

Jul 10 2020, 8:10 AM · Restricted Project, lld

Jul 9 2020

saudi created D83510: [LLD][COFF] Skip computation of the undefined symbols references that are not shown.
Jul 9 2020, 2:30 PM · Restricted Project, lld

Jun 11 2020

saudi added inline comments to D80006: [Clang][DebugInfo] Make DIFile filename and directory native to target architecture.
Jun 11 2020, 8:46 AM · debug-info, Restricted Project

May 21 2020

saudi added inline comments to D80006: [Clang][DebugInfo] Make DIFile filename and directory native to target architecture.
May 21 2020, 1:32 PM · debug-info, Restricted Project

May 15 2020

saudi created D80006: [Clang][DebugInfo] Make DIFile filename and directory native to target architecture.
May 15 2020, 7:00 AM · debug-info, Restricted Project

May 13 2020

saudi closed D76869: [Clang] Restore replace_path_prefix instead of startswith .

Commited - 7a8edcb2124b60941ef6ea4bb4b38a9eb0d70137

May 13 2020, 2:42 PM · Restricted Project, Restricted Project
saudi committed rG7a8edcb2124b: [Clang] Restore replace_path_prefix instead of startswith (authored by saudi).
[Clang] Restore replace_path_prefix instead of startswith
May 13 2020, 10:52 AM

May 12 2020

saudi added inline comments to D76869: [Clang] Restore replace_path_prefix instead of startswith .
May 12 2020, 11:49 AM · Restricted Project, Restricted Project
saudi added a comment to D76869: [Clang] Restore replace_path_prefix instead of startswith .

Ping! @MaskRay you are a blocking reviewer, would you mind taking a final look please?

May 12 2020, 9:07 AM · Restricted Project, Restricted Project

May 6 2020

saudi added a comment to D76869: [Clang] Restore replace_path_prefix instead of startswith .

LGTM. Thanks.

I'm less worried about the details of style (like camel casing), since I have the impression things are changing. In general, stick to prevalent style of the file when it's discernable. My issue with PrefixStyle was that the name could be confusing.

May 6 2020, 9:07 AM · Restricted Project, Restricted Project
saudi updated the diff for D76869: [Clang] Restore replace_path_prefix instead of startswith .

(missed rename PrefixStyle to style in comment)

May 6 2020, 7:30 AM · Restricted Project, Restricted Project
saudi updated the diff for D76869: [Clang] Restore replace_path_prefix instead of startswith .

Renamed the argument PrefixStyle to style.

May 6 2020, 7:29 AM · Restricted Project, Restricted Project

May 5 2020

saudi updated the diff for D76869: [Clang] Restore replace_path_prefix instead of startswith .

Added Style parameter to replace_path_prefix, as suggested.
This allowed to make the replace_path_prefix unit-test platform independent, removing a #ifdef _WIN32 that I added in a previous version of the patch.

May 5 2020, 12:58 PM · Restricted Project, Restricted Project
saudi updated the diff for D77223: [LLVM] sys::path::replace_path_prefix fix and simplifications.

Added Style parameter to replace_path_prefix, as suggested.
This allowed to make the replace_path_prefix unit-test platform independent, removing a #ifdef _WIN32 that I added in a previous version of the patch.

May 5 2020, 9:41 AM · Restricted Project

Apr 30 2020

saudi committed rG226489715cb8: [clang] Disable check for system sanitizer blacklists files if -fno-sanitizer… (authored by saudi).
[clang] Disable check for system sanitizer blacklists files if -fno-sanitizer…
Apr 30 2020, 1:27 PM
saudi closed D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified.
Apr 30 2020, 1:27 PM · Restricted Project, Restricted Project
saudi updated the diff for D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified.

Removed -fno-system-blacklist argument, as suggested in comment.

Apr 30 2020, 9:02 AM · Restricted Project, Restricted Project
saudi added inline comments to D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified.
Apr 30 2020, 6:46 AM · Restricted Project, Restricted Project

Apr 29 2020

saudi added a comment to D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified.

Are you sure you want the remote build to succeed without the CFI system blacklist?

The diagnostic was added in https://reviews.llvm.org/D46403 because broken binaries were being built due to lack of the system blacklist.

Apr 29 2020, 2:00 PM · Restricted Project, Restricted Project
saudi updated the diff for D76869: [Clang] Restore replace_path_prefix instead of startswith .

rebase, and apply suggestions (removed regex matching in test file_test_windows.c test).

Apr 29 2020, 11:16 AM · Restricted Project, Restricted Project
saudi updated the diff for D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified.

Update for suggestions in comments:

  • added -fno-system-sanitize-blacklist driver argument
  • added test for system blacklist files deactivation in the cc1 command line
Apr 29 2020, 9:38 AM · Restricted Project, Restricted Project
saudi added a comment to D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified.

Hmm, one more thought - maybe we should add a new driver option (fno_system_sanitize_blacklist?) as otherwise we are getting kind of confusing CLI with combination of -fno-sanitize-blacklist and -fsanitize-blacklist.

Imagine:

clang -fsanitize=cfi -fno-sanitize-blacklist -fsanitize-blacklist=/tmp/blacklist.txt foo.c

It feels kind of unintuitive.

What do you think?

Apr 29 2020, 8:00 AM · Restricted Project, Restricted Project
saudi added inline comments to D76869: [Clang] Restore replace_path_prefix instead of startswith .
Apr 29 2020, 7:28 AM · Restricted Project, Restricted Project

Apr 28 2020

saudi updated subscribers of D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified.
Apr 28 2020, 2:34 PM · Restricted Project, Restricted Project
saudi updated the summary of D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified.
Apr 28 2020, 2:34 PM · Restricted Project, Restricted Project
saudi created D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified.
Apr 28 2020, 2:34 PM · Restricted Project, Restricted Project
Herald added a project to D76869: [Clang] Restore replace_path_prefix instead of startswith : Restricted Project.

Ping - @MaskRay would you have time to take a quick look, please?

Apr 28 2020, 11:50 AM · Restricted Project, Restricted Project

Apr 22 2020

saudi added a comment to D55153: [ThinLTO] Implement index-based WPD.

Our project is built clang-cl, with options -flto=thin and -Xclang -fwhole-program-vtables, andl links with pre-compiled libs that are built with MSVC.
Without -fwhole-program-vtables the bug disappears.

Are you building with -fno-split-lto-unit? If not, you are getting hybrid regular/Thin LTO devirtualization, and this patch doesn't really apply. By default with -fwhole-program-vtables and -flto=thin, the LTO units are split into regular and thin portions, and all vtables are in the regular portion. This patch simply extended WPD to work without splitting, hence ThinLTO "index only" - i.e. no regular LTO and no IR, and only kicks in with -fno-split-lto-unit on top of the other options. The original hybrid ThinLTO WPD was implemented by @pcc, who may have some ideas as well.

Apr 22 2020, 12:30 PM · Restricted Project

Apr 16 2020

saudi added a comment to D76869: [Clang] Restore replace_path_prefix instead of startswith .

I had to do some modifications after the patch was accepted, since a test was broken. See the comment with my last update.

Apr 16 2020, 6:43 AM · Restricted Project, Restricted Project

Apr 14 2020

saudi added a comment to D55153: [ThinLTO] Implement index-based WPD.

When switching from clang 9 to clang 10, we encountered a freeze in one of our games built with thin-LTO.
git bisect pointed to this commit.
Unfortunately, it is a pretty large project, and I couldn't repro that behavior in other -smaller- contexts.

Apr 14 2020, 2:39 PM · Restricted Project

Apr 9 2020

saudi requested review of D76869: [Clang] Restore replace_path_prefix instead of startswith .
Apr 9 2020, 8:07 AM · Restricted Project, Restricted Project
saudi updated the diff for D76869: [Clang] Restore replace_path_prefix instead of startswith .

Update patch after the simplifications done in D77223.

Apr 9 2020, 8:07 AM · Restricted Project, Restricted Project

Apr 3 2020

saudi committed rGe4ae0a2e9751: [Support/Path] sys::path::replace_path_prefix fix and simplifications (authored by saudi).
[Support/Path] sys::path::replace_path_prefix fix and simplifications
Apr 3 2020, 11:20 AM
saudi closed D77223: [LLVM] sys::path::replace_path_prefix fix and simplifications.
Apr 3 2020, 11:20 AM · Restricted Project

Apr 1 2020

saudi created D77223: [LLVM] sys::path::replace_path_prefix fix and simplifications.
Apr 1 2020, 8:47 AM · Restricted Project

Mar 31 2020

saudi updated the diff for D76869: [Clang] Restore replace_path_prefix instead of startswith .

Added checks for empty map to avoid unneeded string copies.

Mar 31 2020, 10:33 AM · Restricted Project, Restricted Project
saudi updated the diff for D76869: [Clang] Restore replace_path_prefix instead of startswith .

Update patch, where I removed the change of behavior (not using the strict mode of replace_path_prefix).
We can change that behavior separately in a later commit.

Mar 31 2020, 9:57 AM · Restricted Project, Restricted Project

Mar 26 2020

saudi added a reviewer for D76869: [Clang] Restore replace_path_prefix instead of startswith : thakis.
Mar 26 2020, 3:14 PM · Restricted Project, Restricted Project
saudi added a comment to D76869: [Clang] Restore replace_path_prefix instead of startswith .

Well C:\hello match both C:/hello and c:\hello but not C:\helloa? This behavior will look reasonable to me, though I should note that GCC does something similar to startswith.

Maybe we should tell them (https://gcc.gnu.org/pipermail/gcc/2020-March/) that we will match path components.

Mar 26 2020, 3:14 PM · Restricted Project, Restricted Project
saudi created D76869: [Clang] Restore replace_path_prefix instead of startswith .
Mar 26 2020, 10:50 AM · Restricted Project, Restricted Project
saudi added a reverting change for rG3bb24bf25767: Fix tests on Windows after D49466: D76869: [Clang] Restore replace_path_prefix instead of startswith .
Mar 26 2020, 10:50 AM

Mar 24 2020

saudi committed rGb91905a26378: [lld-link] Support /map option, matching link.exe 's /map output format (authored by saudi).
[lld-link] Support /map option, matching link.exe 's /map output format
Mar 24 2020, 6:57 AM
saudi closed D70557: [lld][COFF] Add support for /map.
Mar 24 2020, 6:57 AM · Restricted Project, lld

Mar 20 2020

saudi committed rGf75f19c23748: [Clang][test] Add .i files for test discovery (authored by saudi).
[Clang][test] Add .i files for test discovery
Mar 20 2020, 3:45 PM
saudi closed D75853: [Clang][test] Add .i files for test discovery.
Mar 20 2020, 3:45 PM · Restricted Project

Mar 10 2020

saudi added inline comments to D70557: [lld][COFF] Add support for /map.
Mar 10 2020, 10:52 AM · Restricted Project, lld

Mar 9 2020

saudi updated the summary of D75853: [Clang][test] Add .i files for test discovery.
Mar 9 2020, 10:46 AM · Restricted Project
saudi created D75853: [Clang][test] Add .i files for test discovery.
Mar 9 2020, 9:08 AM · Restricted Project

Mar 6 2020

saudi updated the diff for D70557: [lld][COFF] Add support for /map.
Mar 6 2020, 11:01 AM · Restricted Project, lld
saudi added inline comments to D70557: [lld][COFF] Add support for /map.
Mar 6 2020, 11:01 AM · Restricted Project, lld
saudi updated the diff for D70557: [lld][COFF] Add support for /map.

Updated diff for one missing fix

Mar 6 2020, 11:01 AM · Restricted Project, lld