- User Since
- Oct 16 2019, 1:22 PM (215 w, 5 d)
Aug 28 2023
Applied suggestion in comment (making RuntimeCallInserter use an RAII approach)
Aug 25 2023
Updated to address comments.
- Changed std::optional to use a bool instead
- Removed changes for __asan_* calls that don't apply to Windows EH handling scenarios (module ctor/dtor, globals array)
- Added compiler-rt test
- Improved the test for more coverage
Aug 18 2023
Rebased on main.
Jul 27 2023
Feb 10 2023
Feb 8 2023
Feb 1 2023
Dec 21 2022
Followed @aganea's suggestion, it's indeed clearer, thanks!
Dec 20 2022
Dec 19 2022
Dec 12 2022
Dec 9 2022
Dec 8 2022
Nov 30 2022
Nov 24 2022
Nov 22 2022
Small update: improve comments, remove empty line modification
Nov 21 2022
Added support for empty MBB: ensures 2-byte nop is inserted, to make the function patchable.
This should also support the requirement for the functions not to jump to the first instruction.
Nov 18 2022
Nov 14 2022
Nov 11 2022
Simplified init of config->argv
Nov 10 2022
I found new related crashes, I will investigate.
Perform the argument list filtering in the driver, to use the result of parsed arguments.
Updated pdb-linker-module.test, checking that the object file is indeed discarded.
Nov 9 2022
Added release note
Nov 8 2022
Update: cleanup lambda (remove capture, fix const correctness)
Apr 6 2022
I was curious whether it would be good to remove the notion of GUID validity from the tests, since we now have support for collision whatever the GUIDs are.
I just noticed it, but it was already the case in D122372, so it might be for a separate patch if we want that.
Mar 29 2022
Mar 24 2022
Nice! It's much more straightforward now, the reverse iteration was pretty confusing.
Mar 22 2022
Sorry, I flagged this as "accepted", but I'm not sure I am allowed to do that...
It is indeed much cleaner this way`, thanks!
The tests are not anymore the same for clang-cl as for clang, but I agree what needs testing is the clang-cl specific behaviors, not having the same tests redone as a clang-cl flavor.
Nov 29 2021
I understand, making clang-cl -Wall behave differently than `/Wall' is indeed confusing.
We'll take different steps for setting up the warnings in our Build System.
Nov 26 2021
Nov 1 2021
Oct 19 2021
Oct 8 2021
Oct 6 2021
Oct 5 2021
May 17 2021
May 13 2021
Updated for comments from @rnk, except for the canonicalization part.
May 12 2021
Apr 21 2021
Mar 8 2021
Feb 1 2021
Jan 22 2021
Applied the suggestions from the parent patch D95099
Jan 21 2021
Updated for suggested modifications
Removed the support for "--" command lines, it was extracted to patch D95099.
Applied suggested fixes.
Bugfixes on the use of the iterator.
Jan 20 2021
Jan 19 2021
Would anybody have a chance to take a look at this? I'd like to submit this before the LLVM 12 branch, if possible? Thanks in advance!
Jan 14 2021
Updated the tests for clang-cl command lines:
I moved the input files to end of command line, with --, to avoid linux-style paths conflict with clang-cl arguments.
Dec 14 2020
Dec 9 2020
Dec 1 2020
Rebase after https://reviews.llvm.org/D92330.
Also, improved the detection of target obj file.
Nov 30 2020
Nov 27 2020
Removed /Fo option. -o is also supported by clang-cl and overrides /Fo options that are found earlier in the command line.
Nov 26 2020
Update patch : clang-format fixes.
Nov 25 2020
Nov 12 2020
Nov 11 2020
Simplified the RealFS initialization, as suggested
Removed use of ProxyFileSystem
Nov 10 2020
Updated the patch.