Page MenuHomePhabricator

aganea (Alexandre Ganea)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 6 2017, 1:24 PM (121 w, 6 d)

Recent Activity

Mon, Mar 30

aganea accepted D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}.

LGTM, thanks! Maybe wait a bit in case there are other comments.

Mon, Mar 30, 2:44 PM · Restricted Project
aganea updated subscribers of D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}.

Thanks for the quick changes! Just a few more things and I think it should be good to go.

Mon, Mar 30, 11:56 AM · Restricted Project
aganea added inline comments to D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}.
Mon, Mar 30, 10:16 AM · Restricted Project
aganea added inline comments to D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}.
Mon, Mar 30, 7:33 AM · Restricted Project

Sun, Mar 29

aganea updated subscribers of D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}.
Sun, Mar 29, 8:20 PM · Restricted Project
aganea committed rG42dc667db248: [LLD][ELF] Put back rounding which was lost in… (authored by aganea).
[LLD][ELF] Put back rounding which was lost in…
Sun, Mar 29, 7:16 PM

Sat, Mar 28

aganea committed rG3ab3f3c5d582: After 09158252f777c2e2f06a86b154c44abcbcf9bb74, fix build when… (authored by aganea).
After 09158252f777c2e2f06a86b154c44abcbcf9bb74, fix build when…
Sat, Mar 28, 11:17 AM
aganea added a comment to D75153: [ThinLTO] Allow usage of all SMT threads in the system.

This patch seems to break when disabling threading (aka LLVM_ENABLE_THREADS == 0) as get_threadpool_strategy is undefined therefore creating linker failures in clang. (Tested on Windows)

Sat, Mar 28, 11:17 AM · Restricted Project, Restricted Project
aganea added a comment to D75153: [ThinLTO] Allow usage of all SMT threads in the system.

This patch seems to break when disabling threading (aka LLVM_ENABLE_THREADS == 0) as get_threadpool_strategy is undefined therefore creating linker failures in clang. (Tested on Windows)

Sat, Mar 28, 9:07 AM · Restricted Project, Restricted Project

Fri, Mar 27

aganea added inline comments to D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}.
Fri, Mar 27, 10:17 AM · Restricted Project
aganea added inline comments to D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}.
Fri, Mar 27, 10:16 AM · Restricted Project
aganea committed rG667781592a44: [mlir] On Windows, silence warning on functions definition (authored by aganea).
[mlir] On Windows, silence warning on functions definition
Fri, Mar 27, 9:43 AM
aganea closed D76654: [mlir] On Windows, silence warning on functions definition.
Fri, Mar 27, 9:42 AM · Restricted Project
aganea committed rG4bc8882b89c1: Fix build after 09158252f777c2e2f06a86b154c44abcbcf9bb74 (authored by aganea).
Fix build after 09158252f777c2e2f06a86b154c44abcbcf9bb74
Fri, Mar 27, 8:31 AM
aganea committed rG09158252f777: [ThinLTO] Allow usage of all hardware threads in the system (authored by aganea).
[ThinLTO] Allow usage of all hardware threads in the system
Fri, Mar 27, 7:40 AM
aganea closed D75153: [ThinLTO] Allow usage of all SMT threads in the system.
Fri, Mar 27, 7:37 AM · Restricted Project, Restricted Project

Thu, Mar 26

aganea added a comment to D76654: [mlir] On Windows, silence warning on functions definition.

Any further comments here? Can I go ahead with this?

Thu, Mar 26, 8:06 AM · Restricted Project

Wed, Mar 25

aganea added inline comments to D18487: [ThinLTO] Add optional import message and statistics.
Wed, Mar 25, 3:43 PM
aganea updated subscribers of D75153: [ThinLTO] Allow usage of all SMT threads in the system.

Does taskset -c 0-3 lld -flavor ... restrict the number of cores?

cpu_set_t cpu;
sched_getaffinity(0, sizeof(cpu), &cpu);
CPU_COUNT(&cpu)
Wed, Mar 25, 3:11 PM · Restricted Project, Restricted Project
aganea committed rG934d4feab1f5: [ThinLTO] Don't rely on debug output for thinlto_samplepgo_icp3 test (authored by aganea).
[ThinLTO] Don't rely on debug output for thinlto_samplepgo_icp3 test
Wed, Mar 25, 11:54 AM
aganea closed D76775: [ThinLTO] Don't rely on debug output for thinlto_samplepgo_icp3 test.
Wed, Mar 25, 11:54 AM · Restricted Project
aganea updated the diff for D76775: [ThinLTO] Don't rely on debug output for thinlto_samplepgo_icp3 test.

As requested.

Wed, Mar 25, 9:43 AM · Restricted Project
aganea created D76775: [ThinLTO] Don't rely on debug output for thinlto_samplepgo_icp3 test.
Wed, Mar 25, 8:04 AM · Restricted Project

Tue, Mar 24

aganea added inline comments to D18487: [ThinLTO] Add optional import message and statistics.
Tue, Mar 24, 1:28 PM

Mon, Mar 23

aganea updated the diff for D76654: [mlir] On Windows, silence warning on functions definition.

Updated as requested.

Mon, Mar 23, 5:59 PM · Restricted Project
aganea created D76654: [mlir] On Windows, silence warning on functions definition.
Mon, Mar 23, 5:26 PM · Restricted Project
aganea committed rG5896e2df45da: [Clang] Fix HIP tests when running on Windows with the LLVM toolchain is in the… (authored by aganea).
[Clang] Fix HIP tests when running on Windows with the LLVM toolchain is in the…
Mon, Mar 23, 2:12 PM
aganea closed D76631: [Clang] Fix HIP tests when running on Windows with the LLVM toolchain in the path.
Mon, Mar 23, 2:11 PM · Restricted Project
aganea added a comment to D76631: [Clang] Fix HIP tests when running on Windows with the LLVM toolchain in the path.

I am curious why opt and llc is not affected

Mon, Mar 23, 1:38 PM · Restricted Project
aganea created D76631: [Clang] Fix HIP tests when running on Windows with the LLVM toolchain in the path.
Mon, Mar 23, 10:55 AM · Restricted Project
aganea committed rGc1f8595fe5b8: [Support] Silence warning in Path unittests when compiling with clang-cl (authored by aganea).
[Support] Silence warning in Path unittests when compiling with clang-cl
Mon, Mar 23, 9:49 AM
aganea accepted D76544: [Support] Fix clang warning in widenPath NFC.

Looks good, thanks!

Mon, Mar 23, 7:03 AM · Restricted Project

Fri, Mar 20

aganea added inline comments to rGe6f6c551213a: [Support] Improve Windows widenPath and add support for long UNC paths.
Fri, Mar 20, 7:00 AM

Tue, Mar 17

aganea added a comment to D76295: [clang][AST] Use 64 bit integers for bit offsets inside AST file.

Hello Dmitry! Could we use varints instead of uint64_t if size on disk is a concern?

Tue, Mar 17, 10:43 AM · Restricted Project

Fri, Mar 13

aganea added a comment to D76099: [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a compiler crash.

Looks like the latest build passed: https://ci.chromium.org/p/chromium/builders/ci/ToTLinux%20%28dbg%29/11585

Fri, Mar 13, 2:36 PM · Restricted Project, Restricted Project
aganea added a comment to D76099: [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a compiler crash.

@thakis: Wasn't that issue fixed by rG18eae3312297cb197a3131f3ad9ca2bebb217415 ?

Fri, Mar 13, 2:01 PM · Restricted Project, Restricted Project
aganea committed rGa7325298e1f3: [CodeView] Align type records on 4-bytes when emitting PDBs (authored by aganea).
[CodeView] Align type records on 4-bytes when emitting PDBs
Fri, Mar 13, 9:40 AM
aganea closed D75081: [CodeView] Align type records on 4-bytes when emitting PDBs.
Fri, Mar 13, 9:40 AM · Restricted Project
aganea added a comment to D76099: [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a compiler crash.

Looks like there's a memory corruption detected by ASAN, but I'm not sure it's related to my change. Maybe someone with a more expert eye could tell?

Fri, Mar 13, 7:28 AM · Restricted Project, Restricted Project
aganea added a comment to D75081: [CodeView] Align type records on 4-bytes when emitting PDBs.

Thanks for the feedback Adrian!

Fri, Mar 13, 7:28 AM · Restricted Project
aganea committed rG28ad9fc20823: [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a… (authored by aganea).
[Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a…
Fri, Mar 13, 5:47 AM
aganea closed D76099: [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a compiler crash.
Fri, Mar 13, 5:46 AM · Restricted Project, Restricted Project

Thu, Mar 12

aganea created D76099: [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a compiler crash.
Thu, Mar 12, 2:39 PM · Restricted Project, Restricted Project

Wed, Mar 11

aganea updated the diff for D75081: [CodeView] Align type records on 4-bytes when emitting PDBs.

I find the assert messages and some of the comments mildly misleading.

Fixed, please check the updated diff. Let me know if that's better.

Wed, Mar 11, 1:01 PM · Restricted Project
aganea added inline comments to D75081: [CodeView] Align type records on 4-bytes when emitting PDBs.
Wed, Mar 11, 1:01 PM · Restricted Project
aganea added a comment to D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation.

Looking at the issue now, it should be a straightforward fix. Will send a patch ASAP.

Wed, Mar 11, 10:09 AM · Restricted Project, Restricted Project
aganea added a comment to D75081: [CodeView] Align type records on 4-bytes when emitting PDBs.

Thanks for reviewing this Reid!

Wed, Mar 11, 6:51 AM · Restricted Project
aganea added a comment to D75853: [Clang][test] Add .i files for test discovery.

I've asked Chris commit access for Sylvain. I'd like him to be able to commit directly, we have quite a few other things coming along :)
Sylvain is working on issues related to debugging cross-compiled executables on Linux (when compiled on Windows) and also debugging builds made from OBJs compiled on other machines. This is related to Nico's post about deterministic builds, however things don't work the same with Fastbuild (which is P2P) and there are a few issues we'd like to address.

Wed, Mar 11, 5:44 AM · Restricted Project

Tue, Mar 10

aganea updated the diff for D75081: [CodeView] Align type records on 4-bytes when emitting PDBs.

Updated with better test.
I've moved the test in LLD because I can't find a codepath in LLVM that uses the TypeStreamMerger with OBJs as inputs and outputting into a PDB. The closest is llvm-pdbutil merge ... but that only takes TypeServer PDBs as inputs.

Tue, Mar 10, 2:46 PM · Restricted Project

Mar 4 2020

aganea added a comment to D75153: [ThinLTO] Allow usage of all SMT threads in the system.

Thanks Reid! I will leave this open for a few days, in case there are any other feedbacks.

Mar 4 2020, 2:37 PM · Restricted Project, Restricted Project
aganea updated the diff for D75153: [ThinLTO] Allow usage of all SMT threads in the system.

Simplify. Revert to previous behavior, where any number of threads can be specified on the cmd-line, as suggested by @mehdi_amini. See the updated Summary for cmd-line usage.

Mar 4 2020, 11:47 AM · Restricted Project, Restricted Project

Mar 2 2020

aganea committed rG7e77cf473ac9: [Clang] Fix Hurd toolchain test on a two-stage build with ThinLTO (authored by aganea).
[Clang] Fix Hurd toolchain test on a two-stage build with ThinLTO
Mar 2 2020, 12:56 PM
aganea closed D75373: [Clang] Fix Hurd toolchain class hierarchy.
Mar 2 2020, 12:55 PM · Restricted Project
aganea added a comment to D75201: [ThinLTO/LowerTypeTests] Handle unpromoted local type ids.

Just FYI, I'm also getting the following crash when doing ninja check-clang with the repro specified in: https://reviews.llvm.org/D73242#1881924
It appeared at about the same time as the bug described by Eugene above (it is probably the same thing).
This happens on many clang tests. I am at latest trunk.

Mar 2 2020, 12:03 PM · Restricted Project
aganea added a comment to D75201: [ThinLTO/LowerTypeTests] Handle unpromoted local type ids.

Shouldn't we add -D[CMAKE_C_FLAGS|CMAKE_CXX_FLAGS]="-fwhole-program-vtables" , or better -O3 -fwhole-program-vtables -fstrict-aliasing on the ThinLTO bots, on stage 3 & 4, so we can catch these issues?

Mar 2 2020, 8:35 AM · Restricted Project

Mar 1 2020

aganea updated the diff for D75373: [Clang] Fix Hurd toolchain class hierarchy.

The patch did not make sense conceptually. Hurd is not Linux. I think now it makes more sense.

Mar 1 2020, 7:39 PM · Restricted Project
aganea added a comment to D75153: [ThinLTO] Allow usage of all SMT threads in the system.

@mehdi_amini Agreed. In that case, I just need to slightly change this function to ensure threads are equally dispatched on all CPU sockets regardless of the thread strategy.

Mar 1 2020, 10:09 AM · Restricted Project, Restricted Project
aganea added a reviewer for D75153: [ThinLTO] Allow usage of all SMT threads in the system: mehdi_amini.
Mar 1 2020, 9:42 AM · Restricted Project, Restricted Project

Feb 28 2020

aganea updated the diff for D75373: [Clang] Fix Hurd toolchain class hierarchy.

Fix clang-formatting.

Feb 28 2020, 7:23 PM · Restricted Project
aganea added a comment to D75201: [ThinLTO/LowerTypeTests] Handle unpromoted local type ids.

Tested & works. This patch fixes the issue initially reported here: https://reviews.llvm.org/D73242#1881924
Thanks @tejohnson !

Feb 28 2020, 7:14 PM · Restricted Project
aganea added a comment to D75373: [Clang] Fix Hurd toolchain class hierarchy.

@hans, do you think this could be included in 10.0?

Feb 28 2020, 11:12 AM · Restricted Project
aganea created D75373: [Clang] Fix Hurd toolchain class hierarchy.
Feb 28 2020, 11:12 AM · Restricted Project

Feb 27 2020

aganea added a comment to D75153: [ThinLTO] Allow usage of all SMT threads in the system.

If a simpler (more yucky?) patch is needed to fix what @thakis was suggesting in https://reviews.llvm.org/D71775#1891709, and if we don't want this extra new flag, we can also check the CPU brand for "AMD Opteron", and keep the old behavior in that case.

Feb 27 2020, 6:28 AM · Restricted Project, Restricted Project
aganea updated the summary of D75153: [ThinLTO] Allow usage of all SMT threads in the system.
Feb 27 2020, 6:24 AM · Restricted Project, Restricted Project
aganea added a comment to D74846: fix -fcodegen-modules code when used with PCH (PR44953).

Thanks @hans! Nevertheless I think this is a good change and we should push it for 11.0. I was indeed seeing better timings on our end with what @llunak was proposing, we are heavy users of PCH headers (and migrating to modules is not trivial in our case, lots of code branching & integrations)

Feb 27 2020, 6:14 AM · Restricted Project

Feb 26 2020

aganea added a comment to D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP.

FYI I have reproduced the failure, and am starting to debug.

I see what is going on and have a simple fix, just need to create a test case. Expect to send a patch to fix this today, hopefully this morning.

Feb 26 2020, 8:51 AM · Restricted Project, Restricted Project
aganea added inline comments to D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups.
Feb 26 2020, 8:32 AM · Restricted Project, Restricted Project

Feb 25 2020

aganea updated the summary of D75153: [ThinLTO] Allow usage of all SMT threads in the system.
Feb 25 2020, 8:26 PM · Restricted Project, Restricted Project
aganea created D75153: [ThinLTO] Allow usage of all SMT threads in the system.
Feb 25 2020, 8:20 PM · Restricted Project, Restricted Project
aganea added a comment to D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups.

@thakis I think this is a side-effect of implementing computeHostNumPhysicalCores() for Windows, which previously returned -1, which in turn made llvm::heavyweight_hardware_concurrency() previously behave like llvm::hardware_concurrency() (on Windows only).
At first sight, Linux seems to report the same thing as Windows (2 cores per "module"). If I read this correctly, the behavior on Linux for a AMD Opteron is/was the same as it is currently on Windows after this patch, that is, only one core out of two would be used for llvm::heavyweight_hardware_concurrency().

Feb 25 2020, 12:14 PM · Restricted Project, Restricted Project
aganea added a comment to D71547: Resubmit "[Alignment][NFC] Deprecate CreateMemCpy/CreateMemMove".

! In D71547#1891256, @gchatelet wrote:
I'm not sure how far the reduced example is from the real code but I suspect that using an auto& instead of auto for the foreach variable will fix the issue.

Using auto& does indeed fix the assert, I forgot to mention that :-)

Feb 25 2020, 6:46 AM · Restricted Project
aganea added a comment to D71786: RFC: [Support] On Windows, add optional support for rpmalloc.

Adding more to the discussion: LLVM compilation times on Linux shown in the article below, seem to indicate the same compilation times variability as between Windows versions.
While I haven't got time to test on these systems, part of the variability could come from the default heap allocator.
See https://www.phoronix.com/scan.php?page=article&item=3990x-freebsd-bsd&num=3

Feb 25 2020, 6:12 AM · Restricted Project
aganea added a comment to D74846: fix -fcodegen-modules code when used with PCH (PR44953).

@llunak Do you have time to address this patch this week? If not, I can finish it and land it. Please let me know. We'd like to see it merged into 10.0.

Feb 25 2020, 6:09 AM · Restricted Project

Feb 24 2020

aganea added inline comments to D75081: [CodeView] Align type records on 4-bytes when emitting PDBs.
Feb 24 2020, 2:47 PM · Restricted Project
aganea created D75081: [CodeView] Align type records on 4-bytes when emitting PDBs.
Feb 24 2020, 2:38 PM · Restricted Project
aganea updated subscribers of D71547: Resubmit "[Alignment][NFC] Deprecate CreateMemCpy/CreateMemMove".

Reduced to:

// a.cpp
#include <vector>
struct SP {
  void WeakAddRef();
  void WeakRelease();
};
template <typename T> struct PtrBase {
  T *volatile P;
  ~PtrBase() {
    if (R)
      R->WeakRelease();
  }
  PtrBase(const PtrBase &O) : R(O.R) {
    if (R)
      R->WeakAddRef();
  }
  SP *R;
  bool IsValid() const { return P != nullptr; }
};
struct alignas(16) VectorSIMD4f {
  float V;
};
unsigned __int64 countAF() {
  class AF {
    VectorSIMD4f B;
  };
  struct PD {
    PtrBase<AF> P;
  };
  std::vector<PD> AFs;
  unsigned __int64 C = 0;
  for (auto A : AFs) {
    if (A.P.IsValid())
      ++C;
  }
  return C;
}

Build with:

clang-cl a.cpp /c /O1

Please see the message just above for the cmake command to build clang.

Feb 24 2020, 11:25 AM · Restricted Project

Feb 21 2020

aganea added a comment to D74846: fix -fcodegen-modules code when used with PCH (PR44953).

@llunak Small typo: your patch fixes PR44953, not PR44958.

Feb 21 2020, 12:27 PM · Restricted Project
aganea added a reviewer for D74846: fix -fcodegen-modules code when used with PCH (PR44953): rsmith.

I've tested this patch and it solves our original issue.

Feb 21 2020, 11:00 AM · Restricted Project
aganea committed rG5125803d344b: [mlir] Silence error: call to constructor of 'llvm::APInt' is ambiguous (authored by aganea).
[mlir] Silence error: call to constructor of 'llvm::APInt' is ambiguous
Feb 21 2020, 7:10 AM

Feb 18 2020

aganea added a comment to D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP.

There seems to be still an issue with this patch, when linking the LLVM unit tests on a two-stage build, it ends with:

FAILED: tools/clang/unittests/StaticAnalyzer/StaticAnalysisTests.exe
cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E vs_link_exe --intdir=tools\clang\unittests\StaticAnalyzer\CMakeFiles\StaticAnalysisTests.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100183~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100183~1.0\x64\mt.exe --manifests  -- D:\llvm-project\buildninjaRel\bin\lld-link.exe /nologo tools\clang\unittests\StaticAnalyzer\CMakeFiles\StaticAnalysisTests.dir\AnalyzerOptionsTest.cpp.obj tools\clang\unittests\StaticAnalyzer\CMakeFiles\StaticAnalysisTests.dir\CallDescriptionTest.cpp.obj tools\clang\unittests\StaticAnalyzer\CMakeFiles\StaticAnalysisTests.dir\StoreTest.cpp.obj tools\clang\unittests\StaticAnalyzer\CMakeFiles\StaticAnalysisTests.dir\RegisterCustomCheckersTest.cpp.obj tools\clang\unittests\StaticAnalyzer\CMakeFiles\StaticAnalysisTests.dir\SymbolReaperTest.cpp.obj tools\clang\unittests\StaticAnalyzer\CMakeFiles\StaticAnalysisTests.dir\D_\llvm-project\llvm\resources\windows_version_resource.rc.res  /out:tools\clang\unittests\StaticAnalyzer\StaticAnalysisTests.exe /implib:tools\clang\unittests\StaticAnalyzer\StaticAnalysisTests.lib /pdb:tools\clang\unittests\StaticAnalyzer\StaticAnalysisTests.pdb /version:0.0  /machine:x64 -fuse-ld=lld /STACK:10000000 /DEBUG /OPT:REF /OPT:ICF /lldltocache:D:/llvm-project/buildninjaRelMiMalloc/lto.cache /INCREMENTAL:NO /subsystem:console  lib\LLVMSupport.lib  lib\LLVMSupport.lib  lib\gtest_main.lib  lib\gtest.lib  lib\clangBasic.lib  lib\clangAnalysis.lib  lib\clangAST.lib  lib\clangASTMatchers.lib  lib\clangCrossTU.lib  lib\clangFrontend.lib  lib\clangSerialization.lib  lib\clangStaticAnalyzerCore.lib  lib\clangStaticAnalyzerFrontend.lib  lib\clangTooling.lib  lib\clangStaticAnalyzerCheckers.lib  lib\clangStaticAnalyzerCore.lib  lib\clangCrossTU.lib  lib\clangIndex.lib  lib\clangFrontend.lib  lib\clangParse.lib  lib\clangSerialization.lib  lib\clangSema.lib  lib\clangAnalysis.lib  lib\clangASTMatchers.lib  lib\clangEdit.lib  lib\clangDriver.lib  version.lib  lib\LLVMOption.lib  lib\clangFormat.lib  lib\clangToolingInclusions.lib  lib\clangToolingCore.lib  lib\clangAST.lib  lib\LLVMFrontendOpenMP.lib  lib\LLVMTransformUtils.lib  lib\LLVMAnalysis.lib  lib\LLVMProfileData.lib  lib\LLVMObject.lib  lib\LLVMBitReader.lib  lib\LLVMMCParser.lib  lib\LLVMTextAPI.lib  lib\clangRewrite.lib  lib\clangLex.lib  lib\clangBasic.lib  lib\LLVMCore.lib  lib\LLVMRemarks.lib  lib\LLVMBitstreamReader.lib  lib\LLVMMC.lib  lib\LLVMBinaryFormat.lib  lib\LLVMDebugInfoCodeView.lib  lib\LLVMDebugInfoMSF.lib  lib\LLVMSupport.lib  psapi.lib  shell32.lib  ole32.lib  uuid.lib  advapi32.lib  delayimp.lib  -delayload:shell32.dll  -delayload:ole32.dll  lib\LLVMDemangle.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
LINK: command "D:\llvm-project\buildninjaRel\bin\lld-link.exe /nologo tools\clang\unittests\StaticAnalyzer\CMakeFiles\StaticAnalysisTests.dir\AnalyzerOptionsTest.cpp.obj tools\clang\unittests\StaticAnalyzer\CMakeFiles\StaticAnalysisTests.dir\CallDescriptionTest.cpp.obj tools\clang\unittests\StaticAnalyzer\CMakeFiles\StaticAnalysisTests.dir\StoreTest.cpp.obj tools\clang\unittests\StaticAnalyzer\CMakeFiles\StaticAnalysisTests.dir\RegisterCustomCheckersTest.cpp.obj tools\clang\unittests\StaticAnalyzer\CMakeFiles\StaticAnalysisTests.dir\SymbolReaperTest.cpp.obj tools\clang\unittests\StaticAnalyzer\CMakeFiles\StaticAnalysisTests.dir\D_\llvm-project\llvm\resources\windows_version_resource.rc.res /out:tools\clang\unittests\StaticAnalyzer\StaticAnalysisTests.exe /implib:tools\clang\unittests\StaticAnalyzer\StaticAnalysisTests.lib /pdb:tools\clang\unittests\StaticAnalyzer\StaticAnalysisTests.pdb /version:0.0 /machine:x64 -fuse-ld=lld /STACK:10000000 /DEBUG /OPT:REF /OPT:ICF /lldltocache:D:/llvm-project/buildninjaRelMiMalloc/lto.cache /INCREMENTAL:NO /subsystem:console lib\LLVMSupport.lib lib\LLVMSupport.lib lib\gtest_main.lib lib\gtest.lib lib\clangBasic.lib lib\clangAnalysis.lib lib\clangAST.lib lib\clangASTMatchers.lib lib\clangCrossTU.lib lib\clangFrontend.lib lib\clangSerialization.lib lib\clangStaticAnalyzerCore.lib lib\clangStaticAnalyzerFrontend.lib lib\clangTooling.lib lib\clangStaticAnalyzerCheckers.lib lib\clangStaticAnalyzerCore.lib lib\clangCrossTU.lib lib\clangIndex.lib lib\clangFrontend.lib lib\clangParse.lib lib\clangSerialization.lib lib\clangSema.lib lib\clangAnalysis.lib lib\clangASTMatchers.lib lib\clangEdit.lib lib\clangDriver.lib version.lib lib\LLVMOption.lib lib\clangFormat.lib lib\clangToolingInclusions.lib lib\clangToolingCore.lib lib\clangAST.lib lib\LLVMFrontendOpenMP.lib lib\LLVMTransformUtils.lib lib\LLVMAnalysis.lib lib\LLVMProfileData.lib lib\LLVMObject.lib lib\LLVMBitReader.lib lib\LLVMMCParser.lib lib\LLVMTextAPI.lib lib\clangRewrite.lib lib\clangLex.lib lib\clangBasic.lib lib\LLVMCore.lib lib\LLVMRemarks.lib lib\LLVMBitstreamReader.lib lib\LLVMMC.lib lib\LLVMBinaryFormat.lib lib\LLVMDebugInfoCodeView.lib lib\LLVMDebugInfoMSF.lib lib\LLVMSupport.lib psapi.lib shell32.lib ole32.lib uuid.lib advapi32.lib delayimp.lib -delayload:shell32.dll -delayload:ole32.dll lib\LLVMDemangle.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:tools\clang\unittests\StaticAnalyzer\StaticAnalysisTests.exe.manifest" failed (exit code 0) with the following output:
lld-link: warning: ignoring unknown argument '-fuse-ld=lld'
LLVM ERROR: Second argument of llvm.type.test must be a metadata string
Stack dump:
0.      Running pass 'Lower type metadata' on module 'tools\clang\unittests\StaticAnalyzer\CMakeFiles\StaticAnalysisTests.dir\RegisterCustomCheckersTest.cpp.obj'.
 #0 0x00007ff62cc8f056 HandleAbort D:\llvm-project\llvm\lib\Support\Windows\Signals.inc:408:0
 #1 0x00007ff62f6912f1 raise D:\llvm-project\buildninjaRel\minkernel\crts\ucrt\src\appcrt\misc\signal.cpp:547:0
 #2 0x00007ff62f687c08 abort D:\llvm-project\buildninjaRel\minkernel\crts\ucrt\src\appcrt\startup\abort.cpp:71:0
 #3 0x00007ff62cc88e98 llvm::report_fatal_error(class llvm::Twine const &, bool) D:\llvm-project\llvm\lib\Support\ErrorHandling.cpp:126:0
 #4 0x00007ff62cc88cb1 llvm::report_fatal_error(char const *, bool) D:\llvm-project\llvm\lib\Support\ErrorHandling.cpp:83:0
 #5 0x00007ff62ec3db75 `anonymous namespace'::LowerTypeTestsModule::lower D:\llvm-project\llvm\lib\Transforms\IPO\LowerTypeTests.cpp:0:0
 #6 0x00007ff62ec3e0ce `anonymous namespace'::LowerTypeTests::runOnModule D:\llvm-project\llvm\lib\Transforms\IPO\LowerTypeTests.cpp:539:0
 #7 0x00007ff62d3d6f82 llvm::legacy::PassManagerImpl::run(class llvm::Module &) D:\llvm-project\llvm\lib\IR\LegacyPassManager.cpp:1695:0
 #8 0x00007ff62d6350c0 `anonymous namespace'::opt D:\llvm-project\llvm\lib\LTO\LTOBackend.cpp:314:0
 #9 0x00007ff62d637a48 llvm::lto::thinBackend(struct llvm::lto::Config const &, unsigned int, class std::function<(unsigned int)>, class llvm::Module &, class llvm::ModuleSummaryIndex const &, class llvm::StringMap<class std::unordered_set<unsigned __int64, struct std::hash<unsigned __int64>, struct std::equal_to<unsigned __int64>, class std::allocator<unsigned __int64>>, class llvm::MallocAllocator> const &, class llvm::DenseMap<unsigned __int64, class llvm::GlobalValueSummary *, struct llvm::DenseMapInfo<unsigned __int64>, struct llvm::detail::DenseMapPair<unsigned __int64, class llvm::GlobalValueSummary *>> const &, class llvm::MapVector<class llvm::StringRef, class llvm::BitcodeModule, class llvm::DenseMap<class llvm::StringRef, unsigned int, struct llvm::DenseMapInfo<class llvm::StringRef>, struct llvm::detail::DenseMapPair<class llvm::StringRef, unsigned int>>, class std::vector<struct std::pair<class llvm::StringRef, class llvm::BitcodeModule>, class std::allocator<struct std::pair<class llvm::StringRef, class llvm::BitcodeModule>>>> &) D:\llvm-project\llvm\lib\LTO\LTOBackend.cpp:555:0
#10 0x00007ff62cefc945 `anonymous namespace'::InProcessThinBackend::runThinLTOBackendThread::<unnamed-tag>::operator() D:\llvm-project\llvm\lib\LTO\LTO.cpp:1124:0
#11 0x00007ff62cefc7d3 std::_Func_impl_no_alloc<std::_Binder<std::_Unforced,`lambda at D:\llvm-project\llvm\lib\LTO\LTO.cpp:1157:9',llvm::BitcodeModule &,std::reference_wrapper<llvm::ModuleSummaryIndex>,std::reference_wrapper<const llvm::StringMap<std::unordered_set<unsigned long long,std::hash<unsigned long long>,std::equal_to<unsigned long long>,std::allocator<unsigned long long> >,llvm::MallocAllocator> >,std::reference_wrapper<const llvm::DenseSet<llvm::ValueInfo,llvm::DenseMapInfo<llvm::ValueInfo> > >,std::reference_wrapper<const std::map<unsigned long long,llvm::GlobalValue::LinkageTypes,std::less<unsigned long long>,std::allocator<std::pair<const unsigned long long,llvm::GlobalValue::LinkageTypes> > > >,std::reference_wrapper<const llvm::DenseMap<unsigned long long,llvm::GlobalValueSummary *,llvm::DenseMapInfo<unsigned long long>,llvm::detail::DenseMapPair<unsigned long long,llvm::GlobalValueSummary *> > >,std::reference_wrapper<llvm::MapVector<llvm::StringRef,llvm::BitcodeModule,llvm::DenseMap<llvm::StringRef,unsigned int,llvm::DenseMapInfo<llvm::StringRef>,llvm::detail::DenseMapPair<llvm::StringRef,unsigned int> >,std::vector<std::pair<llvm::StringRef,llvm::BitcodeModule>,std::allocator<std::pair<llvm::StringRef,llvm::BitcodeModule> > > > > >,void>::_Do_call C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.24.28314\include\functional:926:0
#12 0x00007ff62d63d427 std::packaged_task<(void)>::operator()(void) C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.24.28314\include\future:1394:0
#13 0x00007ff62d63d33d std::thread::_Invoke<std::tuple<`lambda at D:\llvm-project\llvm\lib\Support\ThreadPool.cpp:30:26'>,0> C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.24.28314\include\thread:43:0
#14 0x00007ff62f682f04 thread_start<unsigned int (__cdecl*)(void *),1> D:\llvm-project\buildninjaRel\minkernel\crts\ucrt\src\appcrt\startup\thread.cpp:97:0
#15 0x00007ffa95737bd4 (C:\WINDOWS\System32\KERNEL32.DLL+0x17bd4)
#16 0x00007ffa972eced1 (C:\WINDOWS\SYSTEM32\ntdll.dll+0x6ced1)
[4617/4685] Linking CXX executable tools\clang\unittests\Analysis\ClangAnalysisTests.exe
lld-link: warning: ignoring unknown argument '-fuse-ld=lld'
ninja: build stopped: subcommand failed.

I'm at rG6f846c85045ca814b57ee495d9f85a7b0496e947. Building on Windows 10 version 1909, on a VS2019 cmd shell, version 16.4.4. The first stage is built with LLVM 9.0.1.

Feb 18 2020, 6:48 PM · Restricted Project, Restricted Project
aganea committed rG6f846c85045c: Improve comments after 8404aeb56a73ab24f9b295111de3b37a37f0b841. (authored by aganea).
Improve comments after 8404aeb56a73ab24f9b295111de3b37a37f0b841.
Feb 18 2020, 11:30 AM

Feb 15 2020

aganea committed rGb25fc4123c77: [Support] In tests, fix warning: variable ‘Threads’ set but not used (authored by aganea).
[Support] In tests, fix warning: variable ‘Threads’ set but not used
Feb 15 2020, 6:09 AM
aganea added a comment to D71786: RFC: [Support] On Windows, add optional support for rpmalloc.
In D71786#1871211, @rnk wrote:
  • Try raising BumpPtrAllocator "slab" size above 4096, that seems too small. Most AST nodes are allocated with BumpPtrAllocator.
  • I agree that 4K is too small. Virtual memory is cheap so we should just allocate large slabs. That said in my experiments increasing the slab size had no measurable impact in itself (at least for clang with -fsyntax-only). What did have a meaningful impact is using large pages (5%-6% in -fsyntax-only on all of Boost, obviously hardware dependent). Additionally I suspect, but have no data, that the improvement will be comparatively larger in a normal compilation because typically the DTLB and STLB are shared between the logical threads on each core.
Feb 15 2020, 5:59 AM · Restricted Project

Feb 14 2020

aganea committed rG0d2ba6577d87: Fix compilation breakage introduced by 8404aeb56a73ab24f9b295111de3b37a37f0b841. (authored by aganea).
Fix compilation breakage introduced by 8404aeb56a73ab24f9b295111de3b37a37f0b841.
Feb 14 2020, 8:23 AM
aganea committed rG8404aeb56a73: [Support] On Windows, ensure hardware_concurrency() extends to all CPU sockets… (authored by aganea).
[Support] On Windows, ensure hardware_concurrency() extends to all CPU sockets…
Feb 14 2020, 7:28 AM
aganea committed rGd9049e871f30: [clang-scan-deps] Switch to using a ThreadPool (authored by aganea).
[clang-scan-deps] Switch to using a ThreadPool
Feb 14 2020, 7:28 AM
aganea committed rGd110c3a9f525: [ADT] Support BitVector as a key in DenseSet/Map (authored by aganea).
[ADT] Support BitVector as a key in DenseSet/Map
Feb 14 2020, 7:28 AM
aganea closed D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups.
Feb 14 2020, 7:28 AM · Restricted Project, Restricted Project
aganea closed D74569: [clang-scan-deps] Switch to using a ThreadPool.
Feb 14 2020, 7:28 AM · Restricted Project, Restricted Project

Feb 13 2020

aganea added a comment to D74569: [clang-scan-deps] Switch to using a ThreadPool.

Thanks for the quick response!

Feb 13 2020, 12:05 PM · Restricted Project, Restricted Project
aganea committed rG47abb43fc364: [clang-tidy] Fix performance-noexcept-move-constructor-fix test on non-English… (authored by aganea).
[clang-tidy] Fix performance-noexcept-move-constructor-fix test on non-English…
Feb 13 2020, 11:47 AM
aganea closed D74498: [clang-tidy] Fix performance-noexcept-move-constructor-fix.cpp on non-English locale.
Feb 13 2020, 11:47 AM · Restricted Project
aganea updated the diff for D74569: [clang-scan-deps] Switch to using a ThreadPool.
Feb 13 2020, 10:33 AM · Restricted Project, Restricted Project
aganea created D74569: [clang-scan-deps] Switch to using a ThreadPool.
Feb 13 2020, 10:33 AM · Restricted Project, Restricted Project
aganea updated the summary of D74498: [clang-tidy] Fix performance-noexcept-move-constructor-fix.cpp on non-English locale.
Feb 13 2020, 9:56 AM · Restricted Project

Feb 12 2020

aganea added a comment to D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation.

Hello @plotfi and @hctim -- rG20f1abe306d0 should solve the initial issues you were seeing, please let me know if it doesn't.

Feb 12 2020, 2:24 PM · Restricted Project, Restricted Project
aganea committed rG20f1abe306d0: [Clang] Limit -fintegrated-cc1 to only one TU (authored by aganea).
[Clang] Limit -fintegrated-cc1 to only one TU
Feb 12 2020, 2:06 PM
aganea committed rG60cba345ca39: [Clang] When -ftime-trace is used, clean CompilerInstance::OutputFiles before… (authored by aganea).
[Clang] When -ftime-trace is used, clean CompilerInstance::OutputFiles before…
Feb 12 2020, 2:06 PM
aganea closed D74490: [Clang] Limit -fintegrated-cc1 to only one TU.
Feb 12 2020, 2:06 PM · Restricted Project
aganea updated the diff for D74498: [clang-tidy] Fix performance-noexcept-move-constructor-fix.cpp on non-English locale.

Better fix.

Feb 12 2020, 12:06 PM · Restricted Project