Page MenuHomePhabricator

aganea (Alexandre Ganea)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 6 2017, 1:24 PM (163 w, 3 d)

Recent Activity

Fri, Jan 22

aganea accepted D95256: [RGT] Don't use EXPECT* macros in a test subprcess that exits by signalling..

LGTM, thanks Paul!

Fri, Jan 22, 12:55 PM · Restricted Project

Tue, Jan 19

aganea added inline comments to D94555: [LLD][COFF] Avoid std::vector resizes during type merging.
Tue, Jan 19, 12:53 PM · Restricted Project
aganea added inline comments to D94555: [LLD][COFF] Avoid std::vector resizes during type merging.
Tue, Jan 19, 12:41 PM · Restricted Project

Sat, Jan 16

aganea committed rG25c1578a46ff: Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable (authored by jplayer-nv).
Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable
Sat, Jan 16, 6:37 AM
aganea closed D93510: Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable.
Sat, Jan 16, 6:37 AM · Restricted Project

Fri, Jan 15

aganea added a comment to D93510: Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable.

I can do that. Let me test the patch on my end and I'll commit.

Fri, Jan 15, 10:49 AM · Restricted Project

Thu, Jan 14

aganea committed rG4fcb25583c3c: Re-land [Support] On Windows, take the affinity mask into account (authored by aganea).
Re-land [Support] On Windows, take the affinity mask into account
Thu, Jan 14, 2:03 PM
aganea added inline comments to D93510: Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable.
Thu, Jan 14, 12:58 PM · Restricted Project
aganea updated subscribers of D93510: Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable.
Thu, Jan 14, 5:41 AM · Restricted Project
aganea added a reverting change for rG854f0984f0b7: Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable: rG6abbba3fca9f: Revert "Fix llvm::Optional build breaks in MSVC using std….
Thu, Jan 14, 5:37 AM
aganea committed rG6abbba3fca9f: Revert "Fix llvm::Optional build breaks in MSVC using std… (authored by aganea).
Revert "Fix llvm::Optional build breaks in MSVC using std…
Thu, Jan 14, 5:37 AM
aganea added a reverting change for D93510: Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable: rG6abbba3fca9f: Revert "Fix llvm::Optional build breaks in MSVC using std….
Thu, Jan 14, 5:37 AM · Restricted Project

Wed, Jan 13

aganea added inline comments to D93510: Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable.
Wed, Jan 13, 8:07 PM · Restricted Project
aganea added a reverting change for rG336ab2d51dfd: [Support] On Windows, take the affinity mask into account: rGeec856848ccc: Revert "[Support] On Windows, take the affinity mask into account".
Wed, Jan 13, 6:35 PM
aganea committed rGeec856848ccc: Revert "[Support] On Windows, take the affinity mask into account" (authored by aganea).
Revert "[Support] On Windows, take the affinity mask into account"
Wed, Jan 13, 6:35 PM
aganea added a reverting change for D92419: [Support] On Windows, take the affinity mask into account: rGeec856848ccc: Revert "[Support] On Windows, take the affinity mask into account".
Wed, Jan 13, 6:35 PM · Restricted Project
aganea committed rG336ab2d51dfd: [Support] On Windows, take the affinity mask into account (authored by aganea).
[Support] On Windows, take the affinity mask into account
Wed, Jan 13, 6:00 PM
aganea closed D92419: [Support] On Windows, take the affinity mask into account.
Wed, Jan 13, 6:00 PM · Restricted Project
aganea added a comment to D92419: [Support] On Windows, take the affinity mask into account.

Thank you for your time! :)

Wed, Jan 13, 5:23 PM · Restricted Project
aganea added inline comments to D43002: [CodeView] Emit S_OBJNAME record.
Wed, Jan 13, 11:46 AM · Restricted Project, Restricted Project
aganea committed rGe7a371f9fd00: [LLD][COFF] Avoid std::vector resizes during type merging (authored by aganea).
[LLD][COFF] Avoid std::vector resizes during type merging
Wed, Jan 13, 11:35 AM
aganea closed D94555: [LLD][COFF] Avoid std::vector resizes during type merging.
Wed, Jan 13, 11:35 AM · Restricted Project
aganea updated the diff for D92419: [Support] On Windows, take the affinity mask into account.

As suggested by Adrian.

Wed, Jan 13, 10:17 AM · Restricted Project

Tue, Jan 12

aganea updated the diff for D94555: [LLD][COFF] Avoid std::vector resizes during type merging.

Simplify.

Tue, Jan 12, 6:48 PM · Restricted Project
aganea updated the summary of D94555: [LLD][COFF] Avoid std::vector resizes during type merging.
Tue, Jan 12, 2:32 PM · Restricted Project
aganea updated the summary of D94555: [LLD][COFF] Avoid std::vector resizes during type merging.
Tue, Jan 12, 2:31 PM · Restricted Project
aganea requested review of D94555: [LLD][COFF] Avoid std::vector resizes during type merging.
Tue, Jan 12, 2:28 PM · Restricted Project
aganea added a comment to D94267: [PDB] Defer relocating .debug$S until commit time and parallelize it.
In D94267#2491787, @rnk wrote:

This is mostly caused by contention when page faulting on either mmap'ed files or zero-pages. KeYieldProcessorEx is spinning while waiting for a lock for bringing pages into the 'working set'.

Interesting, I've heard similar things about LLD ELF. I wonder how much of this is IO and how much of this is locks around modifying the process page directory.

In my case at least, it's exclusively due to virtual page management. There's no disk IO, everything was already in cache. Only the two spikes at the end, which is the deferred System write of the PDB & the EXE.

Tue, Jan 12, 2:02 PM · Restricted Project

Mon, Jan 11

aganea added inline comments to D87805: [PDB] Merge types in parallel when using ghashing.
Mon, Jan 11, 4:03 PM · Restricted Project
aganea added a comment to D94267: [PDB] Defer relocating .debug$S until commit time and parallelize it.

FWIW, it looks like we're spending more than half of the CPU time in the NT kernel (running on Windows 10 version 2004).

Mon, Jan 11, 3:39 PM · Restricted Project
aganea accepted D94267: [PDB] Defer relocating .debug$S until commit time and parallelize it.

I've checked several of our binaries, compared the PDB symbol stream, and except for extra S_SKIP records, it's all the same.

Mon, Jan 11, 1:03 PM · Restricted Project

Fri, Jan 8

aganea added a comment to D94324: [InitLLVM] Ensure SIGPIPE handler installed before sigaction().

What are the exact conditions to repro Nick's failure? On Fedora 32, I ran py llvm-lit sigpipe-handling.c before this patch and before rGbf401256edd00e921a5d3a0bf4cf6ee66ae51cd6 , the test suceeds, it should not, should it?

Fri, Jan 8, 12:20 PM · Restricted Project, Restricted Project
aganea added a comment to D94324: [InitLLVM] Ensure SIGPIPE handler installed before sigaction().

Do you think it would be possible to add test coverage in Clang by using Nick's test?

Fri, Jan 8, 11:23 AM · Restricted Project, Restricted Project
aganea added a comment to rG9a3f892d0182: [Signal] Allow one-shot SIGPIPE handler to be reached.

Seems good to me too! Thank you!

Fri, Jan 8, 10:28 AM
aganea added a comment to D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is).
  • With scudo all lit tests (generally) pass, but there are some intermittent failures (Access Violation) on the following tests:

ExecutionEngine/MCJIT/test-global-init-nonzero-sm-pic.ll
ExecutionEngine/MCJIT/test-ptr-reloc-sm-pic.ll
ExecutionEngine/MCJIT/multi-module-sm-pic-a.ll

This happens with VS2019 or clang-cl as the toolchain. I've run multiple times without scudo and don't see these. Unfortunately I haven't been able to get this to fail in a debugger.

Fri, Jan 8, 8:29 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jan 7

aganea committed rGb14ad90b1379: [LLD][COFF] Simplify function. NFC. (authored by aganea).
[LLD][COFF] Simplify function. NFC.
Thu, Jan 7, 7:37 PM
aganea committed rG6acfc3a78210: Fix build after eaadb41db6233cf1c9e882d74a31c1f9d6e211ff when the MSVC libs are… (authored by aganea).
Fix build after eaadb41db6233cf1c9e882d74a31c1f9d6e211ff when the MSVC libs are…
Thu, Jan 7, 3:52 PM
aganea added a comment to D94267: [PDB] Defer relocating .debug$S until commit time and parallelize it.

This is really cool. I'll take a look at this tomorrow!

Thu, Jan 7, 2:53 PM · Restricted Project
aganea committed rGeaadb41db623: [LLD][COFF] When using PCH.OBJ, ensure func_id records indices are remapped… (authored by aganea).
[LLD][COFF] When using PCH.OBJ, ensure func_id records indices are remapped…
Thu, Jan 7, 2:27 PM
aganea closed D93732: [LLD][COFF] When using PCH.OBJ, ensure func_id records indices are remapped under /DEBUG:GHASH.
Thu, Jan 7, 2:27 PM · Restricted Project
aganea committed rGce7f30b2a874: [llvm-pdbutil] Don't crash when printing unknown CodeView type records (authored by aganea).
[llvm-pdbutil] Don't crash when printing unknown CodeView type records
Thu, Jan 7, 12:45 PM
aganea closed D93720: [llvm-pdbutil] Don't crash when printing unknown CodeView type records.
Thu, Jan 7, 12:45 PM · Restricted Project
aganea committed rG3854b81b0fd2: [Clang][Driver] Fix read-after-free when using /clang: (authored by aganea).
[Clang][Driver] Fix read-after-free when using /clang:
Thu, Jan 7, 12:15 PM
aganea closed D93772: [Clang][Driver] Fix read-after-free when using /clang:.
Thu, Jan 7, 12:15 PM · Restricted Project
aganea committed rGd0154456e61c: Silence warning: comparison of integers of different signs: 'const unsigned… (authored by aganea).
Silence warning: comparison of integers of different signs: 'const unsigned…
Thu, Jan 7, 10:01 AM

Tue, Jan 5

aganea added a comment to D93732: [LLD][COFF] When using PCH.OBJ, ensure func_id records indices are remapped under /DEBUG:GHASH.

Thanks for looking at this!

Tue, Jan 5, 5:40 PM · Restricted Project

Dec 23 2020

aganea committed rG69132d12deae: [Clang] Reverse test to save on indentation. NFC. (authored by aganea).
[Clang] Reverse test to save on indentation. NFC.
Dec 23 2020, 4:25 PM
aganea requested review of D93772: [Clang][Driver] Fix read-after-free when using /clang:.
Dec 23 2020, 12:44 PM · Restricted Project

Dec 22 2020

aganea requested review of D93732: [LLD][COFF] When using PCH.OBJ, ensure func_id records indices are remapped under /DEBUG:GHASH.
Dec 22 2020, 2:14 PM · Restricted Project
aganea requested review of D93720: [llvm-pdbutil] Don't crash when printing unknown CodeView type records.
Dec 22 2020, 11:22 AM · Restricted Project

Dec 18 2020

aganea added inline comments to rG0978c83e6fcc: Basic: Initialize FileEntry's fields inline, almost NFC.
Dec 18 2020, 10:40 AM

Dec 10 2020

aganea updated subscribers of rG0f1f13fcb17f: Re-land: [lit] Support running tests on Windows without GnuWin32.

Doh! @zturner I forgot to do the git commit --amend thing to credit you before pushing. Really sorry about that :-(

Dec 10 2020, 6:51 PM
aganea added a comment to D88850: [lit, windows] Fix the search for git tools on Windows to check the path first.

I've re-landed @zturner's patch and included this fix into rG0f1f13fcb17fbc8c93d505da989a04ab5cbd9ed3.

Dec 10 2020, 6:44 PM · Restricted Project
aganea committed rG0f1f13fcb17f: Re-land: [lit] Support running tests on Windows without GnuWin32 (authored by aganea).
Re-land: [lit] Support running tests on Windows without GnuWin32
Dec 10 2020, 6:42 PM
aganea retitled D43002: [CodeView] Emit S_OBJNAME record from Emit S_OBJNAME symbol in CodeView to [CodeView] Emit S_OBJNAME record.
Dec 10 2020, 8:03 AM · Restricted Project, Restricted Project

Dec 8 2020

aganea added a comment to D43002: [CodeView] Emit S_OBJNAME record.

Ping!

Dec 8 2020, 9:29 AM · Restricted Project, Restricted Project

Dec 7 2020

aganea added a comment to D92705: [llvm] Update WinMsvc.cmake's fms-compatability to match llvm's prereqs.
In D92705#2437806, @rnk wrote:

We should raise the default _MSC_VER, but IMO that's separable, and I wouldn't rely on it. For cross-compilation, I would recommend setting an explicit version. Otherwise, the very host-specific auto-detection logic could run, and it might produce strange results on a Linux system.

Dec 7 2020, 3:28 PM · Restricted Project

Dec 3 2020

aganea added a comment to D92271: Implement computeHostNumHardwareThreads() for FreeBSD.

It would be nice if this was covered by a test. I essentially did what you did, but for Windows and added a test in D92419. @dim do you think that test makes sense for Unix as well? (it would need the 'AffinityMask' to be implemented in llvm/lib/Support/Unix/Program.inc)

Dec 3 2020, 12:13 PM · Restricted Project
aganea added a comment to D91418: [LLD][ELF] Rename lld port driver entry function to a consistent name.

I think changing from main to to avoids an issue and adds a new issue. We should fix the issues all together, and this requires consensus from others ports to proceed.

Is the new issue, the clash with lld::*::link and if so, then ideally we should replace link from all the ports to linkerMain?

lldMain?

Dec 3 2020, 11:52 AM · Restricted Project
aganea accepted D91418: [LLD][ELF] Rename lld port driver entry function to a consistent name.

This is consistent with the other drivers, LGTM.
Do you have commit access? Please ask for it if you're planning more changes in the future. Otherwise I can land it for you.

Dec 3 2020, 5:23 AM · Restricted Project

Dec 2 2020

aganea accepted D92515: Bump MSVC required version to 19.14.
Dec 2 2020, 5:17 PM · Restricted Project

Dec 1 2020

aganea requested review of D92419: [Support] On Windows, take the affinity mask into account.
Dec 1 2020, 12:27 PM · Restricted Project

Nov 30 2020

aganea added a reviewer for D92330: [clang-scan-deps] Improve argument parsing to find target object file path.: dexonsmith.
Nov 30 2020, 10:26 AM · Restricted Project

Nov 26 2020

aganea added reviewers for D92191: [clang-scan-deps] Add support for clang-cl: dexonsmith, hans.
Nov 26 2020, 10:40 AM · Restricted Project

Nov 18 2020

aganea added a comment to D43002: [CodeView] Emit S_OBJNAME record.

Ping.

Nov 18 2020, 6:20 AM · Restricted Project, Restricted Project

Nov 13 2020

aganea added a comment to D91418: [LLD][ELF] Rename lld port driver entry function to a consistent name.

However I was under the impression that it was a non-goal to make the current version of lld usable as a library. I mean it make very heavy use of globals as well as things like early process exiting doesn't it? Have the goals changed recently?

Nov 13 2020, 10:35 AM · Restricted Project

Nov 12 2020

aganea committed rGec63dfe368f7: [LLD] Fix include following 45b8a741fbbf271e0fb71294cb7cdce3ad4b9bf3 (authored by aganea).
[LLD] Fix include following 45b8a741fbbf271e0fb71294cb7cdce3ad4b9bf3
Nov 12 2020, 5:32 AM
aganea committed rG45b8a741fbbf: [LLD][COFF] When using LLD-as-a-library, always prevent re-entrance on failures (authored by aganea).
[LLD][COFF] When using LLD-as-a-library, always prevent re-entrance on failures
Nov 12 2020, 5:15 AM
aganea closed D88348: [LLD][COFF] When using LLD-as-a-library, always prevent re-entrance on failures.
Nov 12 2020, 5:14 AM · Restricted Project, lld

Nov 11 2020

aganea added a comment to D83025: [clang] Include type specifiers in typo correction when checking isCXXDeclarationSpecifiers..

We're seeing the same issue mentionned in PR45498, but with the repro below. git bisect points to this patch. Could anyone please possibly confirm? Simply build clang with -DLLVM_ENABLE_ASSERTIONS=ON.

// compile with: clang-cl /c a.cpp
template < a > struct b;
template < bool a, class > using c = b< a >;
template < class > using d = void ;
template < class, class, class = void >
bool e template < class f, class g >
bool e< f, g, d< decltype(h(g())) > > template < class f, class g >
void i(f, g ) {
  e< f, g >
}
template < class _BidIt2, c< e< _BidIt, _BidIt2 >, int > = 0 >
void h(_BidIt2) short do_tolower__Last {
  i(do_tolower__First, do_tolower__Last)
}

thanks for the testcase. I'm not sure the patch is the root cause -- from the Bugzilla thread, the issue was reported in April which is prior to this patch.

btw, the issue seems to be gone on the trunk, I don't reproduce them with clang building from the trunk, I guess it might be fixed by some patches after llvm-11.

Nov 11 2020, 1:40 PM · Restricted Project
aganea added a comment to D83025: [clang] Include type specifiers in typo correction when checking isCXXDeclarationSpecifiers..

We're seeing the same issue mentionned in PR45498, but with the repro below. git bisect points to this patch. Could anyone please possibly confirm? Simply build clang with -DLLVM_ENABLE_ASSERTIONS=ON.

// compile with: clang-cl /c a.cpp
template < a > struct b;
template < bool a, class > using c = b< a >;
template < class > using d = void ;
template < class, class, class = void >
bool e template < class f, class g >
bool e< f, g, d< decltype(h(g())) > > template < class f, class g >
void i(f, g ) {
  e< f, g >
}
template < class _BidIt2, c< e< _BidIt, _BidIt2 >, int > = 0 >
void h(_BidIt2) short do_tolower__Last {
  i(do_tolower__First, do_tolower__Last)
}
Nov 11 2020, 9:45 AM · Restricted Project
aganea added a comment to D88348: [LLD][COFF] When using LLD-as-a-library, always prevent re-entrance on failures.

Will this land soon? We are eagerly anticipating its arrival :)

Nov 11 2020, 6:32 AM · Restricted Project, lld

Nov 10 2020

aganea updated the diff for D43002: [CodeView] Emit S_OBJNAME record.

Simplify.
Added coverage when using clang-cl since this is a MSVC-specific feature.
When -fdebug-compilation-dir=. is used, relative paths are now emitted in the S_OBJNAME record.

Nov 10 2020, 5:54 PM · Restricted Project, Restricted Project

Nov 2 2020

aganea accepted D78899: [Driver] Add callback to Command execution.

LGTM, thanks!

Nov 2 2020, 11:34 AM · Restricted Project

Oct 21 2020

aganea added a comment to D88348: [LLD][COFF] When using LLD-as-a-library, always prevent re-entrance on failures.

I'd like to fix the lld.ELF/invalid::symtab-sh-info.s that fails for a while, and this patch has the fix.

Oct 21 2020, 6:41 AM · Restricted Project, lld

Oct 19 2020

aganea committed rG89b72209ad9b: [LLDB][TestSuite] Improve skipIfWindowsAndNonEnglish in decorators.py (authored by aganea).
[LLDB][TestSuite] Improve skipIfWindowsAndNonEnglish in decorators.py
Oct 19 2020, 11:28 AM
aganea closed D89716: [LLDB][TestSuite] Improve skipIfWindowsAndNonEnglish in decorators.py.
Oct 19 2020, 11:28 AM · Restricted Project
aganea requested review of D89716: [LLDB][TestSuite] Improve skipIfWindowsAndNonEnglish in decorators.py.
Oct 19 2020, 10:38 AM · Restricted Project

Oct 16 2020

aganea added inline comments to D70378: [LLD][COFF] Cover usage of LLD as a library.
Oct 16 2020, 4:03 PM · Restricted Project, lld, Restricted Project

Oct 14 2020

aganea added a comment to D84380: [lit] Support running tests on Windows without GnuWin32..

I ask because I'm still trying to figure out why 899 LLDB tests started failing for me on Friday. (Actually, it was 936 tests, but I fixed 37 of them with a fix to a line that was introduced almost a year ago. I have not idea why the problems just started appearing on the 9th.)

Oct 14 2020, 1:23 PM · Restricted Project
aganea updated subscribers of D80833: [CodeView] Add full repro to LF_BUILDINFO record.
Oct 14 2020, 7:58 AM · Restricted Project, Restricted Project
aganea planned changes to D80833: [CodeView] Add full repro to LF_BUILDINFO record.
Oct 14 2020, 7:57 AM · Restricted Project, Restricted Project
aganea reopened D80833: [CodeView] Add full repro to LF_BUILDINFO record.
Oct 14 2020, 7:56 AM · Restricted Project, Restricted Project

Oct 13 2020

aganea added a reverting change for rG9b5b3050237d: Temporarily revert "[ThinLTO] Re-order modules for optimal multi-threaded…: rG617d64f6c5f8: Re-land [ThinLTO] Re-order modules for optimal multi-threaded processing.
Oct 13 2020, 6:54 PM
aganea committed rG617d64f6c5f8: Re-land [ThinLTO] Re-order modules for optimal multi-threaded processing (authored by aganea).
Re-land [ThinLTO] Re-order modules for optimal multi-threaded processing
Oct 13 2020, 6:54 PM
aganea added a comment to D87966: [ThinLTO] Re-order modules for optimal multi-threaded processing.

@tejohnson I added the test in LLD, since the gold tests only run on Linux, which is harder for me to test & debug. The test fails when the following block is removed: if (BackendProc->getThreadCount() == 1) { ... }.

Great, thanks! LGTM with request for comment as described below.

This test also implictly covers the "InProcessThinBackend" codepath with /opt:lldltojobs=1 which I don't see how to cover explicitly otherwise.

I don't see how this test covers that code path since it isn't using in process backends, but I'm not really sure how to test this case effectively - like the original patch, it is just a performance change on the in process backends case.

Oct 13 2020, 6:54 PM · Restricted Project
aganea closed D87966: [ThinLTO] Re-order modules for optimal multi-threaded processing.
Oct 13 2020, 6:54 PM · Restricted Project
aganea added a comment to D87966: [ThinLTO] Re-order modules for optimal multi-threaded processing.

@tejohnson I added the test in LLD, since the gold tests only run on Linux, which is harder for me to test & debug. The test fails when the following block is removed: if (BackendProc->getThreadCount() == 1) { ... }.
This test also implictly covers the "InProcessThinBackend" codepath with /opt:lldltojobs=1 which I don't see how to cover explicitly otherwise.

Oct 13 2020, 3:15 PM · Restricted Project
aganea updated the diff for D87966: [ThinLTO] Re-order modules for optimal multi-threaded processing.

Simplify & address comments.

Oct 13 2020, 3:15 PM · Restricted Project
aganea added a comment to D88348: [LLD][COFF] When using LLD-as-a-library, always prevent re-entrance on failures.
In D88348#2328425, @rnk wrote:

The code changes seem fine, but I haven't figured out why we need to sprinkle LLD_IN_TEST=1 for every LLD invocation we expect to error. What goes wrong exactly? I thought the point of your change is that, we *won't* re-run LLD when LLD_IN_TEST=2 after it reports an error.

Oct 13 2020, 2:14 PM · Restricted Project, lld
aganea added a comment to D84380: [lit] Support running tests on Windows without GnuWin32..

Also, worth nothing that C:\Program Files\Git\usr\bin is not enough to run the lldb tests, which need make and maybe other things.
I'm not sure if that was part of your original goal, but since clang changes can affect lldb behavior, that means developers would still need some additionnal tools along Git for Windows.

Oct 13 2020, 10:04 AM · Restricted Project
aganea requested review of D87966: [ThinLTO] Re-order modules for optimal multi-threaded processing.
Oct 13 2020, 8:21 AM · Restricted Project
aganea reopened D87966: [ThinLTO] Re-order modules for optimal multi-threaded processing.
Oct 13 2020, 8:21 AM · Restricted Project
aganea updated the diff for D87966: [ThinLTO] Re-order modules for optimal multi-threaded processing.

Check for WriteIndexesThinBackend before re-ordering modules.

Oct 13 2020, 8:20 AM · Restricted Project
aganea committed rG1dbf05f5b44d: [ThinLTO][Documentation] Mention possible values for concurrency flags (authored by aganea).
[ThinLTO][Documentation] Mention possible values for concurrency flags
Oct 13 2020, 6:58 AM
aganea closed D89309: [ThinLTO] In documentation, mention possible values for concurrency flags.
Oct 13 2020, 6:58 AM · Restricted Project
aganea updated the diff for D89309: [ThinLTO] In documentation, mention possible values for concurrency flags.

As suggested by @hans.

Oct 13 2020, 6:44 AM · Restricted Project
aganea retitled D89309: [ThinLTO] In documentation, mention possible values for concurrency flags from [ThinLTO] In documentation, mention possible value for concurrency flags to [ThinLTO] In documentation, mention possible values for concurrency flags.
Oct 13 2020, 5:21 AM · Restricted Project
aganea requested review of D89309: [ThinLTO] In documentation, mention possible values for concurrency flags.
Oct 13 2020, 5:21 AM · Restricted Project

Oct 8 2020

aganea added a comment to rG9c1baa23526c: re-land [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark….

Sorry for the very late answer. The crash above was induced by something else commited at that time, not related to this patch.
I've re-landed again in https://reviews.llvm.org/rG66face6aa0f5

Oct 8 2020, 5:53 PM