Page MenuHomePhabricator

aganea (Alexandre Ganea)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 6 2017, 1:24 PM (93 w, 21 h)

Recent Activity

Fri, Sep 6

aganea created D67283: [GCOV] Skip artificial functions from being emitted.
Fri, Sep 6, 9:00 AM · Restricted Project
aganea added a reverting change for D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial: D67283: [GCOV] Skip artificial functions from being emitted.
Fri, Sep 6, 9:00 AM · Restricted Project, debug-info, Restricted Project
aganea added inline comments to D66625: [X86] Print register names in .seh_* directives.
Fri, Sep 6, 8:20 AM · Restricted Project

Thu, Sep 5

aganea committed rG318177311671: Revert: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark… (authored by aganea).
Revert: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark…
Thu, Sep 5, 1:14 PM
aganea committed rL371113: Revert: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark….
Revert: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark…
Thu, Sep 5, 1:11 PM
aganea committed rG32e7773fd509: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as… (authored by aganea).
[DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as…
Thu, Sep 5, 8:27 AM
aganea committed rL371080: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as….
[DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as…
Thu, Sep 5, 8:27 AM
aganea closed D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial.
Thu, Sep 5, 8:26 AM · Restricted Project, debug-info, Restricted Project

Tue, Sep 3

aganea committed rL370834: Request commit access for aganea.
Request commit access for aganea
Tue, Sep 3, 6:22 PM
aganea added inline comments to D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial.
Tue, Sep 3, 12:32 PM · Restricted Project, debug-info, Restricted Project
aganea added inline comments to D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial.
Tue, Sep 3, 12:26 PM · Restricted Project, debug-info, Restricted Project
aganea updated the diff for D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial.
Tue, Sep 3, 12:26 PM · Restricted Project, debug-info, Restricted Project

Thu, Aug 29

aganea updated the diff for D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial.

More tagging functions as artificial.

Thu, Aug 29, 1:57 PM · Restricted Project, debug-info, Restricted Project

Wed, Aug 28

aganea added a comment to D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings.

rL370219 and rG3c307370c8f8

Wed, Aug 28, 8:21 AM · Restricted Project, Restricted Project
aganea committed rG3c307370c8f8: Try fixing CRLF issues in Git with [clang-scan-deps] Minimizer: Correctly… (authored by aganea).
Try fixing CRLF issues in Git with [clang-scan-deps] Minimizer: Correctly…
Wed, Aug 28, 8:14 AM
aganea committed rL370219: Try fixing CRLF issues in Git with [clang-scan-deps] Minimizer: Correctly….
Try fixing CRLF issues in Git with [clang-scan-deps] Minimizer: Correctly…
Wed, Aug 28, 8:13 AM
aganea added a comment to D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings.
In D66556#1648109, @rnk wrote:

I'm not sure what happens, but I see you added .gitattributes. I'd commit it as is. Buildbots using svn will keep working. You can check that the monorepo has the right line endings afterwards, and try again if not.

SGTM.

This broke users of the monorepo, where the file would show up as having changed locally, and with no way to reset it. I'm guessing that's because it was checked in with LF endings and then because of the .gitattributes file, it changes at checkout. I think the correct solution would be to check in the file with CRLF endings and not set any attributes or stuff. (Though this is all super confusing and I might have got it wrong.)

I've deleted the test file in r370175 to unblock development in the meantime.

Wed, Aug 28, 6:05 AM · Restricted Project, Restricted Project

Tue, Aug 27

aganea committed rG57b4e107e43a: Re-land [clang-scan-deps] Minimizer: Correctly handle multi-line content with… (authored by aganea).
Re-land [clang-scan-deps] Minimizer: Correctly handle multi-line content with…
Tue, Aug 27, 5:05 PM
aganea committed rL370129: Re-land [clang-scan-deps] Minimizer: Correctly handle multi-line content with….
Re-land [clang-scan-deps] Minimizer: Correctly handle multi-line content with…
Tue, Aug 27, 5:02 PM
aganea closed D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings.
Tue, Aug 27, 5:02 PM · Restricted Project, Restricted Project
aganea updated the diff for D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings.

Will the git monorepo handle svn:eol-style correctly?

Other files in the repo already use svn:eol-style. I'm not sure what happens with SVN properties when commits are replicated in git. @jyknight @rnk ? I've added .gitattributes to ensure these files are checked out from git with the proper line ending.

Tue, Aug 27, 4:36 PM · Restricted Project, Restricted Project
aganea added a comment to D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial.

I don't see a test for the __cxx_global_array_dtor case?

Tue, Aug 27, 7:46 AM · Restricted Project, debug-info, Restricted Project

Mon, Aug 26

aganea requested review of D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial.
Mon, Aug 26, 7:57 PM · Restricted Project, debug-info, Restricted Project
aganea updated the diff for D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial.
Mon, Aug 26, 7:57 PM · Restricted Project, debug-info, Restricted Project
aganea reopened D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial.

Re-opening this because the previous commit broke Chromium.

Mon, Aug 26, 7:57 PM · Restricted Project, debug-info, Restricted Project
aganea requested review of D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings.
Mon, Aug 26, 6:25 PM · Restricted Project, Restricted Project
aganea reopened D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings.
Mon, Aug 26, 6:25 PM · Restricted Project, Restricted Project
aganea updated the diff for D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings.

This failed the build - I've changed unix2dos to svn:eol-style CRLF instead.

Mon, Aug 26, 6:25 PM · Restricted Project, Restricted Project
aganea committed rGe6561e00684e: [clang-scan-deps] Skip UTF-8 BOM in source minimizer (authored by aganea).
[clang-scan-deps] Skip UTF-8 BOM in source minimizer
Mon, Aug 26, 5:14 PM
aganea committed rL369993: [clang-scan-deps] Skip UTF-8 BOM in source minimizer.
[clang-scan-deps] Skip UTF-8 BOM in source minimizer
Mon, Aug 26, 5:14 PM
aganea closed D66511: [clang-scan-deps] Skip UTF-8 BOM in source minimizer.
Mon, Aug 26, 5:13 PM · Restricted Project, Restricted Project
aganea committed rG6137cecf87cc: [clang-scan-deps] Minimizer: Correctly skip over double slashes in angle… (authored by aganea).
[clang-scan-deps] Minimizer: Correctly skip over double slashes in angle…
Mon, Aug 26, 4:32 PM
aganea committed rL369988: [clang-scan-deps] Minimizer: Correctly skip over double slashes in angle….
[clang-scan-deps] Minimizer: Correctly skip over double slashes in angle…
Mon, Aug 26, 4:32 PM
aganea closed D66550: [clang-scan-deps] Minimizer: Correctly skip over double slashes in angle bracket #include.
Mon, Aug 26, 4:28 PM · Restricted Project, Restricted Project
aganea committed rG2abca4f06cfe: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF… (authored by aganea).
[clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF…
Mon, Aug 26, 4:19 PM
aganea committed rL369986: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF….
[clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF…
Mon, Aug 26, 4:19 PM
aganea closed D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings.
Mon, Aug 26, 4:19 PM · Restricted Project, Restricted Project
aganea added a comment to D66431: [PDB] Fix bug when using multiple PCH header objects with the same name..

Finally got around to trying to commit this.

Creating svn staging directory: (.git\llvm-upstream-svn)
svn staging area ready in '.git\llvm-upstream-svn'
Pushing 1 monorepo commit:
  29ff148f662 [PDB] Fix bug when using multiple PCH header objects with the same name.
`svn update --depth=files lld lld/trunk 'lld/trunk\test' 'lld/trunk\COFF' 'lld/trunk\test/COFF' 'lld/trunk\test/COFF/Inputs' 'lld/trunk\test/COFF/Inputs/precompb' 'lld/trunk\test/COFF/Inputs/precompa'` returned 1
svn: E170013: Unable to connect to a repository at URL 'https://llvm.org/svn/llvm-project'
svn: E175012: Connection timed out

Is git llvm push a thing of the past? Should I be using a new workflow?

Mon, Aug 26, 10:13 AM · Restricted Project
aganea updated the diff for D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings.

Fixed unit tests.

Mon, Aug 26, 9:35 AM · Restricted Project, Restricted Project

Sun, Aug 25

aganea updated the diff for D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings.

As requested.

Sun, Aug 25, 11:18 AM · Restricted Project, Restricted Project

Sat, Aug 24

aganea added a comment to rL369633: Revert r369458 "[DebugInfo] Add debug location to dynamic atexit destructor".

Reduced to:

template <class, class = int> class a;
class b {
public:
  b(char *);
  ~b();
};
template <class, class> class a {
public:
  ~a();
};
struct {
  b c;
  b f;
  const a<a<float>> &d;
} e[]{"", "", {}};

Will take a look.

Sat, Aug 24, 11:21 AM
aganea added a comment to D66431: [PDB] Fix bug when using multiple PCH header objects with the same name..

Is this only for cl.exe-created pch files? Those create special obj files iirc. Or does it affect clang-cl-built pch obj files as well? (If it's cl.exe-only, please mention that in the patch description.)

Yes, this code is only for MSVC PCH.OBJ files. Clang does not generate LF_PRECOMP records.

Sat, Aug 24, 10:53 AM · Restricted Project
aganea added inline comments to D66511: [clang-scan-deps] Skip UTF-8 BOM in source minimizer.
Sat, Aug 24, 10:29 AM · Restricted Project, Restricted Project

Wed, Aug 21

aganea abandoned D65906: [clang-scan-deps] Fix edge cases in the minimizer.

Please see the other reviews I've sent.

Wed, Aug 21, 1:58 PM · Restricted Project
aganea updated the diff for D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings.

Use proper test file.

Wed, Aug 21, 1:58 PM · Restricted Project, Restricted Project
aganea created D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings.
Wed, Aug 21, 1:55 PM · Restricted Project, Restricted Project
aganea retitled D66550: [clang-scan-deps] Minimizer: Correctly skip over double slashes in angle bracket #include from [clang-scan-deps] Correctly skip over double slashes in angle bracket #include to [clang-scan-deps] Minimizer: Correctly skip over double slashes in angle bracket #include.
Wed, Aug 21, 1:28 PM · Restricted Project, Restricted Project
aganea created D66550: [clang-scan-deps] Minimizer: Correctly skip over double slashes in angle bracket #include.
Wed, Aug 21, 1:28 PM · Restricted Project, Restricted Project
aganea accepted D66471: [Support] Improve readNativeFile(Slice) interface.

LGTM, just a missing include (see below).

Wed, Aug 21, 11:40 AM · Restricted Project

Tue, Aug 20

aganea created D66511: [clang-scan-deps] Skip UTF-8 BOM in source minimizer.
Tue, Aug 20, 6:42 PM · Restricted Project, Restricted Project
aganea added a comment to rGed757305b848: Add triple to new test to try to pacify bots.

Thanks! It somehow got lost in translation :-( I am not receiving bots notifications anymore, anything I should do?

Tue, Aug 20, 6:29 PM
aganea committed rG21e96030301e: [Sanitizer] Remove unused functions (authored by aganea).
[Sanitizer] Remove unused functions
Tue, Aug 20, 4:03 PM
aganea committed rL369468: [Sanitizer] Remove unused functions.
[Sanitizer] Remove unused functions
Tue, Aug 20, 3:55 PM
aganea closed D66503: [Sanitizer] Remove unused functions.
Tue, Aug 20, 3:55 PM · Restricted Project
aganea created D66503: [Sanitizer] Remove unused functions.
Tue, Aug 20, 3:51 PM · Restricted Project
aganea committed rGbe6c07941975: [DebugInfo] Add debug location to dynamic atexit destructor (authored by aganea).
[DebugInfo] Add debug location to dynamic atexit destructor
Tue, Aug 20, 3:11 PM
aganea committed rL369458: [DebugInfo] Add debug location to dynamic atexit destructor.
[DebugInfo] Add debug location to dynamic atexit destructor
Tue, Aug 20, 3:08 PM
aganea closed D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial.
Tue, Aug 20, 3:08 PM · Restricted Project, debug-info, Restricted Project
aganea added a comment to D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial.

Thank you!

Tue, Aug 20, 3:06 PM · Restricted Project, debug-info, Restricted Project
aganea added a comment to D63648: [Preprocessor] Honor absolute paths in diagnostics.
  • Does fastbuild have something like distcc-pump?

Fastbuild works like plain distcc and unfortunately it does not have pump mode.

Tue, Aug 20, 1:55 PM · Restricted Project
aganea added inline comments to D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial.
Tue, Aug 20, 1:37 PM · Restricted Project, debug-info, Restricted Project
aganea updated the diff for D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial.
Tue, Aug 20, 1:37 PM · Restricted Project, debug-info, Restricted Project

Aug 20 2019

aganea added inline comments to D66471: [Support] Improve readNativeFile(Slice) interface.
Aug 20 2019, 11:22 AM · Restricted Project
aganea added inline comments to D66471: [Support] Improve readNativeFile(Slice) interface.
Aug 20 2019, 8:48 AM · Restricted Project
aganea added inline comments to D66471: [Support] Improve readNativeFile(Slice) interface.
Aug 20 2019, 8:06 AM · Restricted Project
aganea added inline comments to D66471: [Support] Improve readNativeFile(Slice) interface.
Aug 20 2019, 7:42 AM · Restricted Project

Aug 19 2019

aganea updated the diff for D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial.

As requested.

Aug 19 2019, 7:46 PM · Restricted Project, debug-info, Restricted Project
aganea added inline comments to D66431: [PDB] Fix bug when using multiple PCH header objects with the same name..
Aug 19 2019, 5:35 PM · Restricted Project
aganea added a comment to D66431: [PDB] Fix bug when using multiple PCH header objects with the same name..

Ugh nevermind, you can't because of the binary files. Fineeeeee.

Aug 19 2019, 3:37 PM · Restricted Project
aganea accepted D66431: [PDB] Fix bug when using multiple PCH header objects with the same name..

Thanks for fixing this Zachary! Our precomp files are named after their project, ie. Engine.pch.obj

Aug 19 2019, 3:20 PM · Restricted Project
aganea accepted D66344: Filesystem/Windows: fix inconsistency in readNativeFileSlice API.

LGTM!

Aug 19 2019, 5:35 AM · Restricted Project

Aug 17 2019

aganea added inline comments to D66344: Filesystem/Windows: fix inconsistency in readNativeFileSlice API.
Aug 17 2019, 12:42 PM · Restricted Project
aganea added inline comments to D66344: Filesystem/Windows: fix inconsistency in readNativeFileSlice API.
Aug 17 2019, 10:56 AM · Restricted Project

Aug 16 2019

aganea added inline comments to D66344: Filesystem/Windows: fix inconsistency in readNativeFileSlice API.
Aug 16 2019, 8:16 AM · Restricted Project
aganea added inline comments to D63453: [Support] Move llvm::MemoryBuffer to sys::fs::file_t.
Aug 16 2019, 7:59 AM · Restricted Project

Aug 15 2019

aganea updated the summary of D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial.
Aug 15 2019, 7:28 PM · Restricted Project, debug-info, Restricted Project
aganea created D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial.
Aug 15 2019, 7:28 PM · Restricted Project, debug-info, Restricted Project

Aug 9 2019

aganea added a comment to D65906: [clang-scan-deps] Fix edge cases in the minimizer.

@aganea These are not just any invisible characters that you have, this is the UTF8 BOM. Clang's Lexer skips over them if they're in the beginning of the file (Lexer::InitLexer). The minimizer should do the same thing, so ideally you would factor out the BOM detection and teach the minimizer to skip past it.

Aug 9 2019, 7:02 AM · Restricted Project

Aug 8 2019

aganea added a comment to D65906: [clang-scan-deps] Fix edge cases in the minimizer.

Regarding the invisible characters before #ifdef, are you sure that's the right behavior?

Should we then copy these invisible characters to the minimized output? Believe it or not, these characters are there in our codebase since 2013, and never clang has complained about it :)

Aug 8 2019, 11:24 AM · Restricted Project

Aug 7 2019

Herald updated subscribers of D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations.
Aug 7 2019, 2:50 PM · Restricted Project, Restricted Project
aganea created D65906: [clang-scan-deps] Fix edge cases in the minimizer.
Aug 7 2019, 2:25 PM · Restricted Project

Aug 6 2019

aganea accepted D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources.

LGTM, thank you!

Aug 6 2019, 11:51 AM · Restricted Project, Restricted Project
aganea added a comment to D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources.

Thanks for the update Alex! Just a few more comments and we should be good to go:

Aug 6 2019, 8:35 AM · Restricted Project, Restricted Project

Aug 1 2019

aganea added inline comments to D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources.
Aug 1 2019, 9:26 AM · Restricted Project, Restricted Project

Jul 31 2019

aganea added inline comments to D65511: Delay emitting dllexport explicitly defaulted members until the class is fully parsed (PR40006).
Jul 31 2019, 11:42 AM · Restricted Project
aganea updated subscribers of D65511: Delay emitting dllexport explicitly defaulted members until the class is fully parsed (PR40006).
Jul 31 2019, 6:59 AM · Restricted Project

Jul 30 2019

aganea updated subscribers of D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources.
Jul 30 2019, 9:15 AM · Restricted Project, Restricted Project

Jul 23 2019

aganea added a comment to D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources.

I will take a look next week when I get back!

Jul 23 2019, 6:09 PM · Restricted Project, Restricted Project

Jul 18 2019

aganea added a comment to D63648: [Preprocessor] Honor absolute paths in diagnostics.

It totally makes sense, thanks for the explanation Nico! Let's forget about cl compatibility, that wasn't my initial intent.

Jul 18 2019, 7:01 AM · Restricted Project

Jul 17 2019

aganea added a comment to D63648: [Preprocessor] Honor absolute paths in diagnostics.

The problem is that it is not cl.exe's behavior - it always makes paths absolute:

F:\svn\test>cl /c test.cc /showIncludes
Microsoft (R) C/C++ Optimizing Compiler Version 19.16.27031.1 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.
Jul 17 2019, 11:33 AM · Restricted Project
aganea added a comment to D63648: [Preprocessor] Honor absolute paths in diagnostics.

Thanks for getting back Hans!

Jul 17 2019, 9:34 AM · Restricted Project
aganea added a comment to D52193: RFC: [clang] Multithreaded compilation support -- NOT FOR SUBMIT.

Do you have any plans to make this PR compatible with trunk? Now MSVC with /MP builds much faster than clang-cl (at least 2x faster for our project)...

I'll get back to this after the vacation (somewhere in August)

Jul 17 2019, 9:07 AM · Restricted Project, Restricted Project

Jul 16 2019

aganea added a comment to D63648: [Preprocessor] Honor absolute paths in diagnostics.

Ping!

Jul 16 2019, 9:17 AM · Restricted Project

Jul 9 2019

aganea added a comment to D64301: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source.
Jul 9 2019, 11:26 AM · Restricted Project
aganea added a comment to D64301: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source.
In D64301#1574304, @rnk wrote:

I think @zturner wanted to teach lit to completely remove the Output/ directory for every test so we don't have to deal with stale files from previous tests hanging around. I remember objecting that we can't do that on startup since it's slow and not parallelized. However, I think we could probably add it as an early step to TestRunner.executeShTest so we don't have to add these extra 'rm' commands anymore.

Just a reminder, the DeleteFile API, and thus rm on Windows are async. See this. Occasionally, the tests are failing locally on my PC because of that (maybe 1 out of 50 times).

Jul 9 2019, 11:25 AM · Restricted Project

Jun 27 2019

aganea committed rGfa36593f4c0f: Convert line endings to LF. (authored by aganea).
Convert line endings to LF.
Jun 27 2019, 1:47 PM
aganea committed rL364590: Convert line endings to LF..
Convert line endings to LF.
Jun 27 2019, 1:46 PM

Jun 26 2019

aganea updated subscribers of D63681: [clang-scan-deps] Introduce the DependencyScanning library with the thread worker code and better error handling.

A bit more detail on what we're seeing on our end (specs in the post above). The 'Count' column represents the number of 1ms samples taken in that function. The 'Weight' column is cumulated times for all cores, for a given process, in ms.

Jun 26 2019, 11:57 AM · Restricted Project, Restricted Project
aganea committed rGd1a34f314d0d: [xray] Remove usage of procid_t (authored by aganea).
[xray] Remove usage of procid_t
Jun 26 2019, 8:44 AM
aganea committed rL364439: [xray] Remove usage of procid_t.
[xray] Remove usage of procid_t
Jun 26 2019, 8:43 AM