Page MenuHomePhabricator

aganea (Alexandre Ganea)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 6 2017, 1:24 PM (145 w, 3 d)

Recent Activity

Yesterday

aganea updated the summary of D87966: [ThinLTO] Re-order modules for optimal multi-threaded processing.
Sat, Sep 19, 8:38 AM · Restricted Project
aganea updated the summary of D87966: [ThinLTO] Re-order modules for optimal multi-threaded processing.
Sat, Sep 19, 8:32 AM · Restricted Project
aganea requested review of D87966: [ThinLTO] Re-order modules for optimal multi-threaded processing.
Sat, Sep 19, 8:31 AM · Restricted Project
aganea added a comment to D87805: [PDB] Merge types in parallel when using ghashing.
In D87805#2283132, @rnk wrote:

Truly, I think I haven't done enough validation. But, the resulting PDB should actually be identical: it should contain the same type records, in the same order as before.

I suppose a simple way could be to temporarily retain the old algorithm and have them both run side-by-side and assert if things are different.

Sat, Sep 19, 7:54 AM · Restricted Project

Fri, Sep 18

aganea added a comment to D87805: [PDB] Merge types in parallel when using ghashing.

Thanks a lot for working on this Reid, really neat!

Fri, Sep 18, 1:49 PM · Restricted Project

Thu, Sep 17

aganea accepted D87736: [PDB] Split TypeServerSource and extend type index map lifetime.

Looks great, thanks!

Thu, Sep 17, 11:30 AM · Restricted Project
aganea added a comment to D87736: [PDB] Split TypeServerSource and extend type index map lifetime.

Just a few more things and we should be good to go:

Thu, Sep 17, 6:31 AM · Restricted Project
aganea updated subscribers of D87187: [Driver] Perform Linux distribution detection just once.

Please install & run git clang-format before uploading the patch.

Thu, Sep 17, 5:54 AM · Restricted Project
aganea accepted D87765: [llvm][lldb] Add optimal ThreadPool concurrency.

Side-note: @dmantipov Could you please use git diff -U99999 when creating patches? This allows reviewers to quickly browse through other parts of the file(s) in Phabricator. That would fix the "Context not available." message.

Thu, Sep 17, 5:33 AM · Restricted Project, Restricted Project

Wed, Sep 16

aganea added a comment to D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is).

I didn't try to make the Exclusive version work, mostly because I was using the Windows TLS API and the Shared fit right in with those, but it would get rid of a lot of the contention.

That sounds good. Right now, the delta between rpmalloc/mimalloc/snmalloc is less than 5 sec (for a run of 2 min 15 sec), I would assume with the Exclusive mode, SCUDO would fall in the same ballpark. Any other allocator that I've tried that does some level of locking (Hoard, ptmalloc, tcmalloc2) does not scale (is much slower) on many-cores machines.

Wed, Sep 16, 12:28 PM · Restricted Project, Restricted Project, Restricted Project
aganea updated subscribers of D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is).

I guess using scudo as a general purpose allocator that could set a limit on the number of cores that can be used at once as @aganea found. Would there be any problem with making this very small (e.g. a couple of GB)?

You can reduce the size of the Primary for Windows with an additional define in the platform file. You probably want to make sure there is at least a few gigs per region (eg: the total size could be 256G).

Once again the memory is reserved but not committed, and this is on a per-process basis. There shouldn't be more than one Primary, and as such we shouldn't run out of VA space. We could possibly run out of memory if we allocate past the amount of RAM (+swap), but this is the committed amount.

Wed, Sep 16, 11:28 AM · Restricted Project, Restricted Project, Restricted Project
aganea added a comment to D87736: [PDB] Split TypeServerSource and extend type index map lifetime.

I like a lot the change, it makes the API and the ownership more clear. But I am wondering: why not simply remove the CVIndexMap type? Do we need this extra indirection now? We could simply use a TpiSource API, instead of doing the if (indexMap->isTypeServerMap) in PDB.cpp? e.g. class TpiSource { ... virtual ArrayRef<TypeIndex> indexMap()/typeMap(); }.

Wed, Sep 16, 10:18 AM · Restricted Project

Tue, Sep 15

aganea committed rG50ee05ab65db: [llvm][cmake] Change LLVM_INTEGRATED_CRT_ALLOC to a path instead of a boolean (authored by aganea).
[llvm][cmake] Change LLVM_INTEGRATED_CRT_ALLOC to a path instead of a boolean
Tue, Sep 15, 4:19 PM
aganea closed D87609: [Suport][cmake] Change LLVM_INTEGRATED_CRT_ALLOC to a path instead of a boolean.
Tue, Sep 15, 4:19 PM · Restricted Project
aganea added a comment to D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is).

@russell.gallop I see a lots of failing tests when running ninja check-all on a Scudo-enabled build (stage 2). Do you see the same thing on your end?

==89136==ERROR: Scudo failed to allocate 0x10000 (65536) bytes of memory at address 0x4c0090e00 (error code: 1455)
==89136==Dumping process modules:
ERROR: Failed to mmap

If 4.4 TB of virtual pages are mapped in each process (this happens on startup), then we quickly exaust the 48-bit (256 TB) addressable space with 72+ programs running (on a 36-core). Any idea where this 4.4 TB mapping comes from?

Tue, Sep 15, 5:13 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Sep 14

aganea added a comment to D60495: Load balancing for LTO.

Hello @david2050! Are you still planning on working on this? If no, can I take over the patch and land it?

Mon, Sep 14, 5:11 PM · Restricted Project
aganea requested review of D87609: [Suport][cmake] Change LLVM_INTEGRATED_CRT_ALLOC to a path instead of a boolean.
Mon, Sep 14, 6:57 AM · Restricted Project
aganea accepted D87471: [Support] Make building with snmalloc work.

LGTM.

Mon, Sep 14, 5:19 AM · Restricted Project

Sun, Sep 13

aganea added a comment to D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is).

Thanks for working on this @russell.gallop!

Sun, Sep 13, 6:20 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Sep 11

aganea added a comment to D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is).

@russell.gallop Do you think you can upload the patch again by setting the Repository to "Monorepo"?

Fri, Sep 11, 3:39 PM · Restricted Project, Restricted Project, Restricted Project
aganea set the repository for D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is) to rG LLVM Github Monorepo.
Fri, Sep 11, 3:37 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Sep 10

aganea updated subscribers of D82883: [LLD][COFF] Deduplicate .pdata entries.

I've digged a bit more. The issue is that the ICF improperly folds .text$x sections (catch funclets) but not always the "associated" .pdata and .xdata records, in part because those additional sections are attached to .text$mn not to .text$x. This occurs only with MSVC-cl built OBJs, Clang does not create separate .text$x sections for catch functlets (rather, they are merged into the function .text). I'm seeing the bug when linking with the FBX SDK 2016.1 VS2015 (lib\vs2015\x64\release\libfbxsdk-mt.lib).

Thu, Sep 10, 3:42 PM · Restricted Project
aganea added a comment to D87471: [Support] Make building with snmalloc work.

Please take a look. See https://reviews.llvm.org/D71786#2265789 for details.

Tested, works for me, thanks!

Thu, Sep 10, 2:44 PM · Restricted Project

Wed, Sep 2

aganea added a comment to D70378: [LLD][COFF] Cover usage of LLD as a library.

@MaskRay Thank you!

Wed, Sep 2, 9:42 AM · Restricted Project, lld, Restricted Project
aganea added a comment to D70378: [LLD][COFF] Cover usage of LLD as a library.

Ping! @MaskRay any further comments?

Wed, Sep 2, 7:50 AM · Restricted Project, lld, Restricted Project

Mon, Aug 31

aganea added a comment to D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.

@xgupta Thanks for the report! Please see rG9026d3b2f942db81b0d8588fd0990d389669dc55

Mon, Aug 31, 5:09 AM · Restricted Project
aganea committed rG9026d3b2f942: Fix sphinx documentation after a6a37a2fcd2a8048a75bd0d8280497ed89d73224 (authored by aganea).
Fix sphinx documentation after a6a37a2fcd2a8048a75bd0d8280497ed89d73224
Mon, Aug 31, 5:06 AM

Fri, Aug 28

aganea added a comment to D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.

@hans Fixed in rGb9b954b8bbf0feed1aecde78cb6976134e460e91. Since the x86 versions of the LLVM tools are limited in terms of memory, I think it's not worth supporting LLVM_INTEGRATED_CRT_ALLOC on x86.

Fri, Aug 28, 8:01 AM · Restricted Project
aganea committed rGb9b954b8bbf0: Fix Windows x86 compilation after a6a37a2fcd2a8048a75bd0d8280497ed89d73224 (authored by aganea).
Fix Windows x86 compilation after a6a37a2fcd2a8048a75bd0d8280497ed89d73224
Fri, Aug 28, 7:53 AM

Thu, Aug 27

aganea added inline comments to D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.
Thu, Aug 27, 8:10 AM · Restricted Project
aganea committed rGa6a37a2fcd2a: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc} (authored by aganea).
[Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}
Thu, Aug 27, 8:10 AM
aganea closed D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.
Thu, Aug 27, 8:10 AM · Restricted Project

Wed, Aug 26

aganea added a comment to D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.

From my point of view, I think it would be fine to only support rpmalloc in this patch. One aspect that Russell touched on is that if we support a bunch of options, it's not clear how well that support will be tested. Supporting only rpmalloc would also simplify the patch a little, and small incremental change is always good I think.

Wed, Aug 26, 2:37 PM · Restricted Project
aganea retitled D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc} from RFC: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc} to [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.
Wed, Aug 26, 2:35 PM · Restricted Project
aganea updated the diff for D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.

Address build issues.
Document the new flag.
Add more validations in cmake.

Wed, Aug 26, 2:34 PM · Restricted Project
aganea added a comment to rG33ce275fc156: [Clang] Fix tests following rG087047144210.

No worries!

Wed, Aug 26, 8:41 AM
aganea added a comment to D86622: Fix failing tests after VCTOOLSDIR change.

I've pushed one more fix: rG33ce275fc156c8b015acfad918937028b2cc235c

Wed, Aug 26, 8:33 AM · Restricted Project
aganea committed rG33ce275fc156: [Clang] Fix tests following rG087047144210 (authored by aganea).
[Clang] Fix tests following rG087047144210
Wed, Aug 26, 8:33 AM
aganea committed rGa7da7e421c54: [Support] Allow printing the stack trace only for a given depth (authored by dibya001).
[Support] Allow printing the stack trace only for a given depth
Wed, Aug 26, 6:28 AM
aganea closed D85458: Adding functionality to Stack Tracing.
Wed, Aug 26, 6:27 AM · Restricted Project
aganea added inline comments to D70378: [LLD][COFF] Cover usage of LLD as a library.
Wed, Aug 26, 6:19 AM · Restricted Project, lld, Restricted Project
aganea updated the diff for D70378: [LLD][COFF] Cover usage of LLD as a library.

Address comments.
Added a CrashRecoveryTest.

Wed, Aug 26, 6:19 AM · Restricted Project, lld, Restricted Project

Tue, Aug 25

aganea updated the diff for D70378: [LLD][COFF] Cover usage of LLD as a library.

Rebase.
Address @MaskRay's suggestions.
Made safeLldLink a public API and made it possible to provide user-defined stdout/stderr streams.

Tue, Aug 25, 12:26 PM · Restricted Project, lld, Restricted Project
aganea added a comment to D86496: [not][test] Fix disable-symbolization.test when 'printenv' is not available.

@thakis Do you think you can add printenv.exe into https://commondatastorage.googleapis.com/chromium-browser-clang/tools/gnuwin-XX.zip so we can enable the test again on Windows? Please see https://reviews.llvm.org/D86170#inline-799301

We have env as a lit builtin. Can we just use that? What's the not --crash supposed to do here? Why would env crash anyway? I miss context on what this test wants to do.

Tue, Aug 25, 7:28 AM · Restricted Project

Mon, Aug 24

aganea added a comment to D86496: [not][test] Fix disable-symbolization.test when 'printenv' is not available.

@thakis Do you think you can add printenv.exe into https://commondatastorage.googleapis.com/chromium-browser-clang/tools/gnuwin-XX.zip so we can enable the test again on Windows? Please see https://reviews.llvm.org/D86170#inline-799301

Mon, Aug 24, 6:59 PM · Restricted Project
aganea added a comment to D86496: [not][test] Fix disable-symbolization.test when 'printenv' is not available.

This breaks check-llvm on windows: http://45.33.8.238/win/22625/step_11.txt

Please take a look and revert for now if it takes a while to fix.

(I'm guessing it was failing under cmd previously and fails in msys/gig bash now?)

It worked in a GnuWin32 environment previously but a Chromium (which did not install full GnuWin32) bot was unhappy. So I created this patch. Glad that Alexandre will handle it. Thanks!
Looks like GnuWin32 'env' is not conformant...

Mon, Aug 24, 6:57 PM · Restricted Project
aganea committed rG1f04678f875e: Disable 'not' test on Windows because 'env' from GnuWin32 cannot be used… (authored by aganea).
Disable 'not' test on Windows because 'env' from GnuWin32 cannot be used…
Mon, Aug 24, 6:56 PM
aganea added a comment to D86496: [not][test] Fix disable-symbolization.test when 'printenv' is not available.

I'll fix it.

Mon, Aug 24, 6:46 PM · Restricted Project
aganea added inline comments to D86170: PrintStackTrace: don't symbolize if LLVM_DISABLE_SYMBOLIZATION is set.
Mon, Aug 24, 6:16 PM · Restricted Project
aganea added inline comments to D86170: PrintStackTrace: don't symbolize if LLVM_DISABLE_SYMBOLIZATION is set.
Mon, Aug 24, 4:54 PM · Restricted Project
aganea added inline comments to D86170: PrintStackTrace: don't symbolize if LLVM_DISABLE_SYMBOLIZATION is set.
Mon, Aug 24, 4:38 PM · Restricted Project
aganea added a comment to D70378: [LLD][COFF] Cover usage of LLD as a library.

@MaskRay Thanks will do - I still have one last issue I don't understand, maybe you can help?

Mon, Aug 24, 12:48 PM · Restricted Project, lld, Restricted Project
aganea added a comment to D70378: [LLD][COFF] Cover usage of LLD as a library.

Just fwiw, a smaller patch on the same topic was just committed a few days ago, from D86401. This looks like a bigger and more complete fix for the same issue - but before completing it, pay attention to pick up/remove the fix from D86401 (I see that the same vector already gets cleared by this patch as well).

Mon, Aug 24, 12:13 PM · Restricted Project, lld, Restricted Project
aganea added a comment to D86401: [LLD][COFF] Reset outputSections for successive runs.

Cherry-picked to 11.x as 0c37a9165611880b99b1f9632179864ecb3f2e13.

I'm curious about the background here, though. When would lld::coff::link be called successively? Could we have a test for this?

Mon, Aug 24, 12:12 PM · Restricted Project
aganea added inline comments to D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain.
Mon, Aug 24, 10:52 AM · Restricted Project
aganea added a comment to D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain.

Thanks, one more minor thing and it should be good to go.

Mon, Aug 24, 9:56 AM · Restricted Project
aganea added inline comments to D70378: [LLD][COFF] Cover usage of LLD as a library.
Mon, Aug 24, 7:58 AM · Restricted Project, lld, Restricted Project

Fri, Aug 21

aganea added a comment to D86351: WIP: llvm-buildozer 1/3 [llvm part].

When you extended the thread pool for high cores counts for Windows, I thought the other way around. I want to you use the distributed thinlto locally. Then each ninja job is single threaded and ninja can schedule everything. This probably won't be a desirable solution for Windows.

This has been suggested by Bruce Dawson here: https://github.com/ninja-build/ninja/issues/1638 - although I haven't seen the prototype he mentions nor any figures. I feel that the direct and indirect costs for context switching between a pool of processes would be higher vs. a pool of threads in a single ongoing process, and that would increase with the number of cores. But I remain open to any idea, as long as it improves build times on Windows.

Fri, Aug 21, 3:49 PM
aganea added inline comments to D70378: [LLD][COFF] Cover usage of LLD as a library.
Fri, Aug 21, 3:29 PM · Restricted Project, lld, Restricted Project
aganea updated the diff for D70378: [LLD][COFF] Cover usage of LLD as a library.

As suggested.

Fri, Aug 21, 3:28 PM · Restricted Project, lld, Restricted Project
aganea added inline comments to D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain.
Fri, Aug 21, 3:22 PM · Restricted Project
aganea updated subscribers of D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain.

The build system strives to be deterministic

When you say build system, you mean MSBuild? Other? For example, Fastbuild purposely calls CreateProcess with an empty environment block (not null) to avoid determinism issues. Is that your case? We are also using -nostdinc to avoid any compiler-generated include paths, even in cases where you need to repro something in a VS cmd shell.

Fri, Aug 21, 2:53 PM · Restricted Project
aganea added a comment to D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain.

Could you please explain a little bit more what motivated this change? You can achieve almost the same with env VCToolsInstallDir=F:\Your_Path\ clang-cl .... You would also want to pass -fmsc-version=... to avoid extracting the version from cl.exe. If you're seeing many file and registry accesses, then clang-cl probably runs without a call to vcvarsall.bat before?

Fri, Aug 21, 12:14 PM · Restricted Project
aganea accepted D86170: PrintStackTrace: don't symbolize if LLVM_DISABLE_SYMBOLIZATION is set.
Fri, Aug 21, 10:22 AM · Restricted Project

Aug 21 2020

aganea requested review of D86353: WIP: llvm-buildozer 3/3 [lld part].
Aug 21 2020, 8:11 AM
aganea retitled D86352: WIP: llvm-buildozer 2/3 [clang part] from WIP: llvm-buildozer 1/3 [clang part] to WIP: llvm-buildozer 2/3 [clang part].
Aug 21 2020, 8:10 AM
aganea requested review of D86352: WIP: llvm-buildozer 2/3 [clang part].
Aug 21 2020, 8:10 AM
aganea retitled D86351: WIP: llvm-buildozer 1/3 [llvm part] from WIP: llvm-buildozer 1/3 to WIP: llvm-buildozer 1/3 [llvm part].
Aug 21 2020, 8:09 AM
aganea requested review of D86351: WIP: llvm-buildozer 1/3 [llvm part].
Aug 21 2020, 8:08 AM
aganea added a comment to D86170: PrintStackTrace: don't symbolize if LLVM_DISABLE_SYMBOLIZATION is set.

I don't see any measureable improvement in terms of execution time on a 36-core Windows with ninja check-llvm Release with assertions (164 sec both with & without the patch). However there's a measurable saving on a 6-core: 820 sec without patch -> 784 sec with patch, median times after a few runs.

Aug 21 2020, 6:41 AM · Restricted Project

Aug 20 2020

aganea added inline comments to D86170: PrintStackTrace: don't symbolize if LLVM_DISABLE_SYMBOLIZATION is set.
Aug 20 2020, 6:21 AM · Restricted Project
aganea added inline comments to D86170: PrintStackTrace: don't symbolize if LLVM_DISABLE_SYMBOLIZATION is set.
Aug 20 2020, 6:10 AM · Restricted Project

Aug 19 2020

aganea updated subscribers of D70378: [LLD][COFF] Cover usage of LLD as a library.
Aug 19 2020, 2:44 PM · Restricted Project, lld, Restricted Project
aganea added a comment to D70378: [LLD][COFF] Cover usage of LLD as a library.

Thanks for the feedback @MaskRay @grimar!

Aug 19 2020, 2:42 PM · Restricted Project, lld, Restricted Project
aganea updated the diff for D70378: [LLD][COFF] Cover usage of LLD as a library.

As suggested,

  • Set LLD_IN_TEST=2 (still enabled for COFF only)
  • Remove stdout & stderr for all iterations but the last one.
Aug 19 2020, 2:37 PM · Restricted Project, lld, Restricted Project

Aug 17 2020

aganea committed rG98e01f56b0a1: Revert "Re-Re-land: [CodeView] Add full repro to LF_BUILDINFO record" (authored by aganea).
Revert "Re-Re-land: [CodeView] Add full repro to LF_BUILDINFO record"
Aug 17 2020, 12:49 PM
aganea added a reverting change for rGa3036b386383: Re-Re-land: [CodeView] Add full repro to LF_BUILDINFO record: rG98e01f56b0a1: Revert "Re-Re-land: [CodeView] Add full repro to LF_BUILDINFO record".
Aug 17 2020, 12:49 PM
aganea added a reverting change for D80833: [CodeView] Add full repro to LF_BUILDINFO record: rG98e01f56b0a1: Revert "Re-Re-land: [CodeView] Add full repro to LF_BUILDINFO record".
Aug 17 2020, 12:49 PM · Restricted Project, Restricted Project
aganea added a comment to D80833: [CodeView] Add full repro to LF_BUILDINFO record.

This seems to be breaking determinism on Windows builds, see https://crbug.com/1117026. Can this be reverted and fixed?

Aug 17 2020, 11:20 AM · Restricted Project, Restricted Project

Aug 14 2020

aganea updated the diff for D70378: [LLD][COFF] Cover usage of LLD as a library.

Fix clang-(format|tidy)

Aug 14 2020, 3:32 PM · Restricted Project, lld, Restricted Project
aganea updated the summary of D70378: [LLD][COFF] Cover usage of LLD as a library.
Aug 14 2020, 2:54 PM · Restricted Project, lld, Restricted Project
aganea updated the diff for D70378: [LLD][COFF] Cover usage of LLD as a library.

Add support for testing LLD as a library, by running the driver several times in a row when LLD_IN_TEST is defined. The value of LLD_IN_TEST tells how many times LLD should loop (3 times right now).

Aug 14 2020, 2:51 PM · Restricted Project, lld, Restricted Project
aganea accepted D85993: [lldb] Set the access property on member function decls.
Aug 14 2020, 1:58 PM
aganea added a comment to D85993: [lldb] Set the access property on member function decls.

LGTM.

Aug 14 2020, 1:58 PM

Aug 12 2020

aganea added a comment to D85458: Adding functionality to Stack Tracing.

As I don't have commit access, could someone please help in merging it?

Aug 12 2020, 7:58 AM · Restricted Project
aganea added a comment to D85669: Fix "last accessed time" test failing on Windows.

Okay, thanks. Looks like there's more values than are actually documented. Out of interest, what does fsutil behavior disablelastaccess say for you?

D:\llvm-project>fsutil behavior query disablelastaccess
DisableLastAccess = 2  (Géré par le système, désactivé)

Despite NtfsDisableLastAccessUpdate being 0x80000002 in the registry. This link has more information about the meaning of the value: https://dfir.ru/2018/12/08/the-last-access-updates-are-almost-back/

Aug 12 2020, 4:58 AM · Restricted Project

Aug 11 2020

aganea added a comment to D85669: Fix "last accessed time" test failing on Windows.

Hi @jhenderson!
I had NtfsDisableLastAccessUpdate = 0x80000002. With this, touch -a -t 199505050555.55 %t.1.o fails to update the "Last access time" to the requested date.
Setting it to 0x80000003 or 3 or 1 works (ie. touch succeeds)
I'm not sure exactly what is going on here, maybe NTFS sets the "Last access time" when the handle is closed, and thus overrides what touch does?
The bottom line is that other users could be in the same situation: the test will succeed or fail depending on the settings on their machine.

Aug 11 2020, 10:31 AM · Restricted Project
aganea accepted D85458: Adding functionality to Stack Tracing.

Change LGTM, do you have commit access? You should perhaps request it if you're planning on further patches.

Aug 11 2020, 9:12 AM · Restricted Project
aganea added inline comments to D85458: Adding functionality to Stack Tracing.
Aug 11 2020, 8:29 AM · Restricted Project
aganea added a comment to D85458: Adding functionality to Stack Tracing.

Thanks for the update, almost good, see below.
Also, could you please explain what is your practical application for chopping the callstack?

Aug 11 2020, 8:29 AM · Restricted Project

Aug 10 2020

aganea closed D85669: Fix "last accessed time" test failing on Windows.

Commited as rGa680ea2c720751a3d724fd8282515924acb3bd32

Aug 10 2020, 2:55 PM · Restricted Project
aganea added a comment to D85458: Adding functionality to Stack Tracing.

Code looks good, but I'm still wondering if we could add test coverage? Can we test for PrintStackTrace(StrOS, 1); and validate that only one line is emitted? You could add such a test in one of the files in llvm/unittests/Support/ - or add a new test file if it doesn't fit anywhere. Also don't forget to skip Windows OS (see the Host.cpp test for an example).

Aug 10 2020, 2:05 PM · Restricted Project
aganea committed rGa680ea2c7207: Fix "last accessed time" test failing on Windows (authored by aganea).
Fix "last accessed time" test failing on Windows
Aug 10 2020, 1:03 PM
aganea added a comment to D85669: Fix "last accessed time" test failing on Windows.

I'm OK with this.

In an ideal world, it would be nice to ensure stripping preserves other the Windows creation timestamp while updating the last modification timestamp.

Aug 10 2020, 1:00 PM · Restricted Project
aganea added inline comments to D85458: Adding functionality to Stack Tracing.
Aug 10 2020, 11:09 AM · Restricted Project
aganea retitled D85669: Fix "last accessed time" test failing on Windows from Fix "accessed timestamp" test failing on Windows to Fix "last accessed time" test failing on Windows.
Aug 10 2020, 10:45 AM · Restricted Project
aganea requested review of D85669: Fix "last accessed time" test failing on Windows.
Aug 10 2020, 10:44 AM · Restricted Project
aganea committed rGa3036b386383: Re-Re-land: [CodeView] Add full repro to LF_BUILDINFO record (authored by aganea).
Re-Re-land: [CodeView] Add full repro to LF_BUILDINFO record
Aug 10 2020, 10:37 AM
aganea added a comment to D85458: Adding functionality to Stack Tracing.

Hello @dibya001! Thanks for the patch!

Aug 10 2020, 10:18 AM · Restricted Project
aganea added inline comments to D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores().
Aug 10 2020, 8:25 AM · Restricted Project