Page MenuHomePhabricator

aganea (Alexandre Ganea)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 6 2017, 1:24 PM (83 w, 5 d)

Recent Activity

Tue, Jul 9

aganea added a comment to D64301: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source.
Tue, Jul 9, 11:26 AM · Restricted Project
aganea added a comment to D64301: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source.
In D64301#1574304, @rnk wrote:

I think @zturner wanted to teach lit to completely remove the Output/ directory for every test so we don't have to deal with stale files from previous tests hanging around. I remember objecting that we can't do that on startup since it's slow and not parallelized. However, I think we could probably add it as an early step to TestRunner.executeShTest so we don't have to add these extra 'rm' commands anymore.

Just a reminder, the DeleteFile API, and thus rm on Windows are async. See this. Occasionally, the tests are failing locally on my PC because of that (maybe 1 out of 50 times).

Tue, Jul 9, 11:25 AM · Restricted Project

Thu, Jun 27

aganea committed rGfa36593f4c0f: Convert line endings to LF. (authored by aganea).
Convert line endings to LF.
Thu, Jun 27, 1:47 PM
aganea committed rL364590: Convert line endings to LF..
Convert line endings to LF.
Thu, Jun 27, 1:46 PM

Wed, Jun 26

aganea updated subscribers of D63681: [clang-scan-deps] Introduce the DependencyScanning library with the thread worker code and better error handling.

A bit more detail on what we're seeing on our end (specs in the post above). The 'Count' column represents the number of 1ms samples taken in that function. The 'Weight' column is cumulated times for all cores, for a given process, in ms.

Wed, Jun 26, 11:57 AM · Restricted Project, Restricted Project
aganea committed rGd1a34f314d0d: [xray] Remove usage of procid_t (authored by aganea).
[xray] Remove usage of procid_t
Wed, Jun 26, 8:44 AM
aganea committed rL364439: [xray] Remove usage of procid_t.
[xray] Remove usage of procid_t
Wed, Jun 26, 8:43 AM
aganea closed D61946: [xray] Remove usage of procid_t.
Wed, Jun 26, 8:43 AM · Restricted Project
aganea committed rG90079977ac55: [LLD][COFF] Case insensitive compares for /nodefaultlib (authored by aganea).
[LLD][COFF] Case insensitive compares for /nodefaultlib
Wed, Jun 26, 8:43 AM
aganea committed rL364438: [LLD][COFF] Case insensitive compares for /nodefaultlib.
[LLD][COFF] Case insensitive compares for /nodefaultlib
Wed, Jun 26, 8:40 AM
aganea closed D63775: [LLD][COFF] Case insensitive compares for /nodefaultlib.
Wed, Jun 26, 8:40 AM · Restricted Project, lld

Tue, Jun 25

aganea accepted D63681: [clang-scan-deps] Introduce the DependencyScanning library with the thread worker code and better error handling.
Tue, Jun 25, 5:49 PM · Restricted Project, Restricted Project
aganea added a comment to D63681: [clang-scan-deps] Introduce the DependencyScanning library with the thread worker code and better error handling.

Some quick stats on our end (running Windows 10 on a Intel W-2135, 6-core, 3.7 GHz, NVMe SSD): on a large .SLN compiling approx. 16,000 .CPP files through 600 unity .CPPs and 23,000 .H files, out of 86 secs spent in ClangScanDeps, about 32 secs are spent in DirectoryLookup::LookUpFile.

Tue, Jun 25, 5:49 PM · Restricted Project, Restricted Project
aganea updated the diff for D63775: [LLD][COFF] Case insensitive compares for /nodefaultlib.

Case-insensitive on Linux as requested.

Tue, Jun 25, 3:09 PM · Restricted Project, lld
aganea added a comment to D61946: [xray] Remove usage of procid_t.

Thank you! :)

Tue, Jun 25, 2:38 PM · Restricted Project
aganea added a reviewer for D61946: [xray] Remove usage of procid_t: rnk.

Ping!

Tue, Jun 25, 11:06 AM · Restricted Project
aganea updated the diff for D63775: [LLD][COFF] Case insensitive compares for /nodefaultlib.

Updated test.

Tue, Jun 25, 9:09 AM · Restricted Project, lld
aganea created D63775: [LLD][COFF] Case insensitive compares for /nodefaultlib.
Tue, Jun 25, 9:05 AM · Restricted Project, lld

Fri, Jun 21

aganea accepted D63579: [clang-scan-deps] print the dependencies to stdout and remove the need to use -MD options in the CDB.

LGTM! Thank you!

Fri, Jun 21, 6:54 AM · Restricted Project, Restricted Project
aganea updated subscribers of D63648: [Preprocessor] Honor absolute paths in diagnostics.
Fri, Jun 21, 6:36 AM · Restricted Project
aganea created D63648: [Preprocessor] Honor absolute paths in diagnostics.
Fri, Jun 21, 6:32 AM · Restricted Project

Thu, Jun 20

aganea added inline comments to D63579: [clang-scan-deps] print the dependencies to stdout and remove the need to use -MD options in the CDB.
Thu, Jun 20, 1:51 PM · Restricted Project, Restricted Project
aganea added inline comments to D63579: [clang-scan-deps] print the dependencies to stdout and remove the need to use -MD options in the CDB.
Thu, Jun 20, 8:15 AM · Restricted Project, Restricted Project

Wed, Jun 19

aganea accepted D63453: [Support] Move llvm::MemoryBuffer to sys::fs::file_t.

In D63453#1550865, @rnk wrote:
Still, I don't think that's a good reason not to do this change, although I certainly have less motivation now.

Wed, Jun 19, 2:17 PM · Restricted Project
aganea accepted D63290: Unify DependencyFileGenerator class and DependencyCollector interface.

LGTM.

Wed, Jun 19, 7:46 AM · Restricted Project, Restricted Project

Tue, Jun 18

aganea added inline comments to D63453: [Support] Move llvm::MemoryBuffer to sys::fs::file_t.
Tue, Jun 18, 7:29 PM · Restricted Project
aganea added inline comments to D63453: [Support] Move llvm::MemoryBuffer to sys::fs::file_t.
Tue, Jun 18, 10:43 AM · Restricted Project

Mon, Jun 17

aganea added inline comments to D63453: [Support] Move llvm::MemoryBuffer to sys::fs::file_t.
Mon, Jun 17, 2:57 PM · Restricted Project
aganea added a reviewer for D63290: Unify DependencyFileGenerator class and DependencyCollector interface: benlangmuir.
Mon, Jun 17, 1:44 PM · Restricted Project, Restricted Project

Jun 10 2019

aganea accepted D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database.
Jun 10 2019, 2:47 PM · Restricted Project, Restricted Project

Jun 7 2019

aganea added inline comments to D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database.
Jun 7 2019, 7:31 AM · Restricted Project, Restricted Project
aganea accepted D61914: [Support][Test] Time profiler: add regression test.

Thanks Anton!

Jun 7 2019, 5:49 AM · Restricted Project, Restricted Project

Jun 4 2019

aganea committed rG4b7bdcd31842: [LLD][COFF] Don't take into account the 'age' when looking for PDB type server (authored by aganea).
[LLD][COFF] Don't take into account the 'age' when looking for PDB type server
Jun 4 2019, 7:01 PM
aganea committed rL362572: [LLD][COFF] Don't take into account the 'age' when looking for PDB type server.
[LLD][COFF] Don't take into account the 'age' when looking for PDB type server
Jun 4 2019, 7:01 PM
aganea closed D62837: [LLD][COFF] Don't take into account the 'age' when looking for PDB type server.
Jun 4 2019, 7:01 PM · Restricted Project, lld
aganea added a comment to D62837: [LLD][COFF] Don't take into account the 'age' when looking for PDB type server.

Maybe Reid was talking about this icon, was it there before?

Jun 4 2019, 6:44 PM · Restricted Project, lld
aganea updated the diff for D62837: [LLD][COFF] Don't take into account the 'age' when looking for PDB type server.

@thakis : Updated the existing test to fail without this patch.

Jun 4 2019, 4:37 PM · Restricted Project, lld
aganea added a comment to D60095: [LLD][COFF] Early load PDB type server files.
Jun 4 2019, 2:13 PM · Restricted Project
aganea updated the summary of D62837: [LLD][COFF] Don't take into account the 'age' when looking for PDB type server.
Jun 4 2019, 6:44 AM · Restricted Project, lld
aganea added a reviewer for D62837: [LLD][COFF] Don't take into account the 'age' when looking for PDB type server: thakis.
Jun 4 2019, 6:41 AM · Restricted Project, lld

Jun 3 2019

aganea created D62837: [LLD][COFF] Don't take into account the 'age' when looking for PDB type server.
Jun 3 2019, 7:40 PM · Restricted Project, lld
aganea added a comment to D60095: [LLD][COFF] Early load PDB type server files.

You're right, there's indeed an issue, checking now.

Jun 3 2019, 4:50 PM · Restricted Project
aganea added a comment to D60095: [LLD][COFF] Early load PDB type server files.
In D60095#1528125, @rnk wrote:

I'm seeing a lot of LNK4099 warnings after this change, and Chromium links with -Werror. I also saw a fair number while doing some local testing with asan. I'll collect some more information, but I wanted to give a heads up that this might be problematic.

Jun 3 2019, 3:53 PM · Restricted Project
aganea added a comment to D60095: [LLD][COFF] Early load PDB type server files.
In D60095#1528125, @rnk wrote:

I'm seeing a lot of LNK4099 warnings after this change, and Chromium links with -Werror. I also saw a fair number while doing some local testing with asan. I'll collect some more information, but I wanted to give a heads up that this might be problematic.

Jun 3 2019, 3:49 PM · Restricted Project
aganea committed rG18ca8a2233a4: Silence 'warning C4305: 'initializing': truncation from 'double' to 'float''… (authored by aganea).
Silence 'warning C4305: 'initializing': truncation from 'double' to 'float''…
Jun 3 2019, 11:48 AM
aganea committed rL362437: Silence 'warning C4305: 'initializing': truncation from 'double' to 'float''….
Silence 'warning C4305: 'initializing': truncation from 'double' to 'float''…
Jun 3 2019, 11:48 AM
aganea added a comment to D60095: [LLD][COFF] Early load PDB type server files.

Just for the record, the lldb tests issues above were caused first by a missing SWIG installation on my PC, then by using wrong SWIG version (4 instead if 3), and then my locale being fr_CA (which still causes a few tests to fail).

Jun 3 2019, 5:48 AM · Restricted Project
aganea committed rG9c78db600537: Re-land [LLD][COFF] Early load PDB type server files (authored by aganea).
Re-land [LLD][COFF] Early load PDB type server files
Jun 3 2019, 5:41 AM
aganea committed rL362393: Re-land [LLD][COFF] Early load PDB type server files.
Re-land [LLD][COFF] Early load PDB type server files
Jun 3 2019, 5:41 AM

Jun 2 2019

aganea abandoned D62785: Fix compilation following r362280.

Will be fixed by D62772

Jun 2 2019, 1:16 PM · Restricted Project
aganea added inline comments to D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames.
Jun 2 2019, 7:04 AM · Restricted Project, Restricted Project

Jun 1 2019

aganea edited reviewers for D62785: Fix compilation following r362280, added: stella.stamenova; removed: tstellar.
Jun 1 2019, 2:54 PM · Restricted Project
aganea created D62785: Fix compilation following r362280.
Jun 1 2019, 2:54 PM · Restricted Project
aganea committed rG5a2a054028c2: Silence 'warning: extra ‘;’ [-Wpedantic]' with GCC 7.3 (authored by aganea).
Silence 'warning: extra ‘;’ [-Wpedantic]' with GCC 7.3
Jun 1 2019, 2:48 PM
aganea committed rL362306: Silence 'warning: extra ‘;’ [-Wpedantic]' with GCC 7.3.
Silence 'warning: extra ‘;’ [-Wpedantic]' with GCC 7.3
Jun 1 2019, 2:47 PM
aganea added inline comments to D62701: [PDB] Copy inlinee lines records into the PDB.
Jun 1 2019, 7:29 AM · Restricted Project
aganea accepted D62701: [PDB] Copy inlinee lines records into the PDB.

LGTM! I'm less sure about the yaml->assembly change, but we could continue that offline :)
Maybe in a subsequent patch it'd be nice to fix obj2yaml IL part to avoid relying on SectionDatas.

Jun 1 2019, 7:23 AM · Restricted Project

May 31 2019

aganea added inline comments to D62701: [PDB] Copy inlinee lines records into the PDB.
May 31 2019, 1:52 PM · Restricted Project
aganea added inline comments to D62701: [PDB] Copy inlinee lines records into the PDB.
May 31 2019, 1:35 PM · Restricted Project
aganea added a comment to D62701: [PDB] Copy inlinee lines records into the PDB.

I've noticed btw that obj2yaml/yaml2obj doesn't preserve the BinaryAnnotations if SectionData values are skimmed out of the .yaml (to reduce size). There's also something missing for S_FRAMEPROC in that regard:

May 31 2019, 8:15 AM · Restricted Project

May 28 2019

aganea committed rGccc1fa5e1d2d: Revert r361842 as it breaks LLDB :: tools/lldb-mi/exec/exec-finish.test (authored by aganea).
Revert r361842 as it breaks LLDB :: tools/lldb-mi/exec/exec-finish.test
May 28 2019, 1:56 PM
aganea committed rLLD361876: Revert r361842 as it breaks LLDB :: tools/lldb-mi/exec/exec-finish.test.
Revert r361842 as it breaks LLDB :: tools/lldb-mi/exec/exec-finish.test
May 28 2019, 1:56 PM
aganea committed rL361876: Revert r361842 as it breaks LLDB :: tools/lldb-mi/exec/exec-finish.test.
Revert r361842 as it breaks LLDB :: tools/lldb-mi/exec/exec-finish.test
May 28 2019, 1:55 PM
aganea added a comment to D60095: [LLD][COFF] Early load PDB type server files.

@stella.stamenova : I'll have to revert it, I'm not sure what's going on. When I run the tests on my Windows PC, many tests are tagged as 'unsupported', I don't know why:

Unsupported Tests  : 796

Whereas on your build bot, there are no 'unsupported' tests:

Expected Passes    : 1596
Expected Failures  : 11
Unsupported Tests  : 46

If I try to manually run the test that fails on the bot: C:\Users\aganea\AppData\Local\Programs\Python\Python37-32\python.exe F:/svn/buildninja/./bin/llvm-lit.py -sv -vv -a F:\svn\lldb\lit\tools\lldb-mi\exec\exec-finish.test, I also get:

UNSUPPORTED: LLDB :: tools/lldb-mi/exec/exec-finish.test (1 of 1)
Test is unsupported

If I run the commands in the test manually, I get to a point where lldb-mi doesn't want to run:

F:\svn\buildninja\tools\lldb\lit>f:\svn\buildninja\bin\lldb-mi.exe
MI: Error: Driver. LLDB Debugger.
MI: Error: Driver Manager. Driver 'Machine Interface Driver Version: 1.0.0.9' (ID:'MIDriver') initialise failed. Driver. LLDB Debugger.

Any suggestions? I'll revert the patch in the meanwhile.

May 28 2019, 1:55 PM · Restricted Project
aganea added a comment to D60095: [LLD][COFF] Early load PDB type server files.

Looking now.

May 28 2019, 12:35 PM · Restricted Project
aganea committed rG2076fb28f180: Fix 'warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling… (authored by aganea).
Fix 'warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling…
May 28 2019, 11:38 AM
aganea committed rGcf950b46c8ca: Fix 'warning: format specifies type 'int' but the argument has type 'MIuint'… (authored by aganea).
Fix 'warning: format specifies type 'int' but the argument has type 'MIuint'…
May 28 2019, 11:38 AM
aganea committed rL361862: Fix 'warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling….
Fix 'warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling…
May 28 2019, 11:37 AM
aganea committed rLLDB361862: Fix 'warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling….
Fix 'warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling…
May 28 2019, 11:37 AM
aganea committed rLLDB361861: Fix 'warning: format specifies type 'int' but the argument has type 'MIuint'….
Fix 'warning: format specifies type 'int' but the argument has type 'MIuint'…
May 28 2019, 11:33 AM
aganea committed rL361861: Fix 'warning: format specifies type 'int' but the argument has type 'MIuint'….
Fix 'warning: format specifies type 'int' but the argument has type 'MIuint'…
May 28 2019, 11:33 AM
aganea committed rGebe22a1774ed: [LLD][COFF] Early load PDB type server files (authored by aganea).
[LLD][COFF] Early load PDB type server files
May 28 2019, 8:36 AM
aganea committed rLLD361842: [LLD][COFF] Early load PDB type server files.
[LLD][COFF] Early load PDB type server files
May 28 2019, 8:32 AM
aganea committed rL361842: [LLD][COFF] Early load PDB type server files.
[LLD][COFF] Early load PDB type server files
May 28 2019, 8:32 AM
aganea closed D60095: [LLD][COFF] Early load PDB type server files.
May 28 2019, 8:32 AM · Restricted Project
aganea committed rG756565d47079: Fix 'warning: comparison is always true due to limited range of data type… (authored by aganea).
Fix 'warning: comparison is always true due to limited range of data type…
May 28 2019, 8:31 AM
aganea committed rLLD361840: Fix 'warning: comparison is always true due to limited range of data type….
Fix 'warning: comparison is always true due to limited range of data type…
May 28 2019, 8:31 AM
aganea committed rL361840: Fix 'warning: comparison is always true due to limited range of data type….
Fix 'warning: comparison is always true due to limited range of data type…
May 28 2019, 8:31 AM
aganea committed rG9bf766c57343: Revert r361826, as it still breaks LLDB. (authored by aganea).
Revert r361826, as it still breaks LLDB.
May 28 2019, 8:03 AM
aganea committed rL361837: Revert r361826, as it still breaks LLDB..
Revert r361826, as it still breaks LLDB.
May 28 2019, 8:03 AM
aganea committed rGc4eee4054aa2: [CMake] Default options for faster executables on MSVC (authored by aganea).
[CMake] Default options for faster executables on MSVC
May 28 2019, 7:13 AM
aganea committed rL361826: [CMake] Default options for faster executables on MSVC.
[CMake] Default options for faster executables on MSVC
May 28 2019, 7:12 AM
aganea closed D55056: [CMake] Default options for faster executables on MSVC.
May 28 2019, 7:12 AM · Restricted Project
aganea added a comment to D60095: [LLD][COFF] Early load PDB type server files.

Thank you!

May 28 2019, 6:08 AM · Restricted Project

May 27 2019

aganea added a comment to D60095: [LLD][COFF] Early load PDB type server files.

Ping @ruiu

May 27 2019, 4:09 AM · Restricted Project

May 24 2019

aganea added inline comments to D62422: [COFF] Add ImportChunkThunk, simplify, deduplicate.
May 24 2019, 2:25 PM · Restricted Project
aganea accepted D62422: [COFF] Add ImportChunkThunk, simplify, deduplicate.

Looks good, thanks!

May 24 2019, 2:18 PM · Restricted Project
aganea added a comment to D62356: [COFF] Replace OutputSection* with uint16_t index in Chunk.

The Interop.Dia2Lib.dll and the msdiaXXX.dll have to match. Try regsvr32.exe "C:\Program Files (x86)\Microsoft Visual Studio 12.0\Common7\Packages\Debugger\msdia120.dll" (or look for msdia120.dll on your PC).

May 24 2019, 1:50 PM · Restricted Project
aganea added a comment to D62347: [Support] Modernize process launching API.

The "modernized" api is a good chunk wordier. Can you outline how composing launching would look like with and without this change?

You're right, I'll reduce it. There are a few unrelated changes that could be done after. I'll have to get back to you regarding the "without this change".

May 24 2019, 12:17 PM · Restricted Project
aganea accepted D62362: [COFF] De-virtualize Chunk and SectionChunk.
May 24 2019, 12:03 PM · Restricted Project
aganea added a comment to D62356: [COFF] Replace OutputSection* with uint16_t index in Chunk.

Thanks, I built it, but when I try to use it to load lld.pdb, it raises a "class not registered" exception, despite the fact that I followed the README.md instructions and registered msdia120.dll. DIA registration seems to be a continuing pain point in the Windows development world. :( I'll mess around with it.

May 24 2019, 11:55 AM · Restricted Project
aganea added inline comments to D62362: [COFF] De-virtualize Chunk and SectionChunk.
May 24 2019, 9:23 AM · Restricted Project
aganea added inline comments to D62356: [COFF] Replace OutputSection* with uint16_t index in Chunk.
May 24 2019, 9:11 AM · Restricted Project
aganea added a comment to D62356: [COFF] Replace OutputSection* with uint16_t index in Chunk.

Great stuff, thanks for doing this Reid! :) Inherently, this should make things a bit faster, it will also reduce cache misses.
We use a neat tool called Crunchersharp to have a broader overview:

May 24 2019, 8:42 AM · Restricted Project

May 23 2019

aganea created D62347: [Support] Modernize process launching API.
May 23 2019, 2:34 PM · Restricted Project
aganea updated the diff for D55056: [CMake] Default options for faster executables on MSVC.

If using -DLLVM_TOOL_LLDB_BUILD it now displays "Using /MD as required by LLDB."
If using -DLLVM_TOOL_LLDB_BUILD -DLLVM_USE_CRT_RELEASE=MT it displays "Disabling /MT as required by LLDB."
Otherwise /MT is the new default.

May 23 2019, 1:00 PM · Restricted Project
aganea requested review of D55056: [CMake] Default options for faster executables on MSVC.
May 23 2019, 1:00 PM · Restricted Project
aganea added a comment to D55056: [CMake] Default options for faster executables on MSVC.
In D55056#1514451, @rnk wrote:

Previously I passed LLVM_USE_CRT_RELEASE=MT explicitly as part of my build, and I ran into the same problems with LLDB that you did. I'll try to modify this once it lands to warn when the user tries to do that. At the time, I couldn't see how to do it easily.

May 23 2019, 12:00 PM · Restricted Project
aganea added inline comments to D55056: [CMake] Default options for faster executables on MSVC.
May 23 2019, 10:50 AM · Restricted Project
aganea updated the diff for D55056: [CMake] Default options for faster executables on MSVC.
May 23 2019, 10:50 AM · Restricted Project