User Details
- User Since
- Dec 6 2017, 1:24 PM (163 w, 3 d)
Fri, Jan 22
LGTM, thanks Paul!
Tue, Jan 19
Sat, Jan 16
Fri, Jan 15
I can do that. Let me test the patch on my end and I'll commit.
Thu, Jan 14
Wed, Jan 13
Thank you for your time! :)
As suggested by Adrian.
Tue, Jan 12
Simplify.
In my case at least, it's exclusively due to virtual page management. There's no disk IO, everything was already in cache. Only the two spikes at the end, which is the deferred System write of the PDB & the EXE.
Mon, Jan 11
FWIW, it looks like we're spending more than half of the CPU time in the NT kernel (running on Windows 10 version 2004).
I've checked several of our binaries, compared the PDB symbol stream, and except for extra S_SKIP records, it's all the same.
Fri, Jan 8
What are the exact conditions to repro Nick's failure? On Fedora 32, I ran py llvm-lit sigpipe-handling.c before this patch and before rGbf401256edd00e921a5d3a0bf4cf6ee66ae51cd6 , the test suceeds, it should not, should it?
Do you think it would be possible to add test coverage in Clang by using Nick's test?
Seems good to me too! Thank you!
Thu, Jan 7
This is really cool. I'll take a look at this tomorrow!
Tue, Jan 5
Thanks for looking at this!
Dec 23 2020
Dec 22 2020
Dec 18 2020
Dec 10 2020
Doh! @zturner I forgot to do the git commit --amend thing to credit you before pushing. Really sorry about that :-(
I've re-landed @zturner's patch and included this fix into rG0f1f13fcb17fbc8c93d505da989a04ab5cbd9ed3.
Dec 8 2020
Ping!
Dec 7 2020
Dec 3 2020
It would be nice if this was covered by a test. I essentially did what you did, but for Windows and added a test in D92419. @dim do you think that test makes sense for Unix as well? (it would need the 'AffinityMask' to be implemented in llvm/lib/Support/Unix/Program.inc)
This is consistent with the other drivers, LGTM.
Do you have commit access? Please ask for it if you're planning more changes in the future. Otherwise I can land it for you.
Dec 2 2020
Dec 1 2020
Nov 30 2020
Nov 26 2020
Nov 18 2020
Ping.
Nov 13 2020
Nov 12 2020
Nov 11 2020
We're seeing the same issue mentionned in PR45498, but with the repro below. git bisect points to this patch. Could anyone please possibly confirm? Simply build clang with -DLLVM_ENABLE_ASSERTIONS=ON.
// compile with: clang-cl /c a.cpp template < a > struct b; template < bool a, class > using c = b< a >; template < class > using d = void ; template < class, class, class = void > bool e template < class f, class g > bool e< f, g, d< decltype(h(g())) > > template < class f, class g > void i(f, g ) { e< f, g > } template < class _BidIt2, c< e< _BidIt, _BidIt2 >, int > = 0 > void h(_BidIt2) short do_tolower__Last { i(do_tolower__First, do_tolower__Last) }
Nov 10 2020
Simplify.
Added coverage when using clang-cl since this is a MSVC-specific feature.
When -fdebug-compilation-dir=. is used, relative paths are now emitted in the S_OBJNAME record.
Nov 2 2020
LGTM, thanks!
Oct 21 2020
I'd like to fix the lld.ELF/invalid::symtab-sh-info.s that fails for a while, and this patch has the fix.
Oct 19 2020
Oct 16 2020
Oct 14 2020
Oct 13 2020
@tejohnson I added the test in LLD, since the gold tests only run on Linux, which is harder for me to test & debug. The test fails when the following block is removed: if (BackendProc->getThreadCount() == 1) { ... }.
This test also implictly covers the "InProcessThinBackend" codepath with /opt:lldltojobs=1 which I don't see how to cover explicitly otherwise.
Simplify & address comments.
Check for WriteIndexesThinBackend before re-ordering modules.
As suggested by @hans.
Oct 8 2020
Sorry for the very late answer. The crash above was induced by something else commited at that time, not related to this patch.
I've re-landed again in https://reviews.llvm.org/rG66face6aa0f5