Page MenuHomePhabricator

akhuang (Amy Huang)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 7 2019, 2:10 PM (32 w, 6 d)

Recent Activity

Mon, Oct 21

akhuang updated the diff for D69136: Add an instruction marker field to the ExtraInfo in MachineInstrs..

Clang format

Mon, Oct 21, 10:18 AM · Restricted Project
akhuang updated the diff for D69136: Add an instruction marker field to the ExtraInfo in MachineInstrs..

-Moved the logic for editing extra info for machine instrs into a separate function.
-Moved label creation code into CodeViewDebug.
-Remove now unused heapallocsite vector from MachineFunction.

Mon, Oct 21, 10:16 AM · Restricted Project

Thu, Oct 17

akhuang created D69136: Add an instruction marker field to the ExtraInfo in MachineInstrs..
Thu, Oct 17, 2:00 PM · Restricted Project

Wed, Oct 16

akhuang added a comment to D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr..

@DarkShadow44 Thanks for finding this bug! I haven't had time to look at this for a while but will start working on it soon.

Wed, Oct 16, 5:01 PM · Restricted Project, Restricted Project
akhuang accepted D69068: [codeview] Workaround for PR43479, don't re-emit instr labels.

Thanks; I also tried compiling something with SLH the other day and I think it already doesn't do tail duplication there.

Wed, Oct 16, 1:27 PM · Restricted Project

Tue, Oct 15

akhuang updated the diff for D67723: [DebugInfo] Add option to disable inline line tables..

Address comment about bad decrementing iterator.

Tue, Oct 15, 1:19 PM · debug-info, Restricted Project, Restricted Project

Mon, Oct 14

akhuang updated the diff for D67723: [DebugInfo] Add option to disable inline line tables..
  • Fixes for DbgInfoIntrinsic type and change test cmd

Reverted the line 0 change - I wasn't sure if it would be an issue since
the debugger doesn't step through those lines.

Mon, Oct 14, 2:51 PM · debug-info, Restricted Project, Restricted Project
akhuang updated the diff for D67723: [DebugInfo] Add option to disable inline line tables..
  • Set inlined locations to line 0
  • Fix to remove all debug info intrinsics
Mon, Oct 14, 11:58 AM · debug-info, Restricted Project, Restricted Project

Fri, Oct 11

akhuang updated the diff for D67723: [DebugInfo] Add option to disable inline line tables..
  • Set location to line 0 with getMergedLocation
Fri, Oct 11, 4:51 PM · debug-info, Restricted Project, Restricted Project
akhuang updated the diff for D67723: [DebugInfo] Add option to disable inline line tables..

Fix code so that -gno-inline-line-tables works when not codeview

Fri, Oct 11, 3:29 PM · debug-info, Restricted Project, Restricted Project
akhuang retitled D67723: [DebugInfo] Add option to disable inline line tables. from [CodeView] Add option to disable inline line tables. to [DebugInfo] Add option to disable inline line tables..
Fri, Oct 11, 3:29 PM · debug-info, Restricted Project, Restricted Project
akhuang updated the diff for D67723: [DebugInfo] Add option to disable inline line tables..
  • Remove extra ifs.
Fri, Oct 11, 2:59 PM · debug-info, Restricted Project, Restricted Project
akhuang updated the diff for D67723: [DebugInfo] Add option to disable inline line tables..

-Remove intrinsics debug info
-Add inliner test
-Add to function attribute description

Fri, Oct 11, 2:31 PM · debug-info, Restricted Project, Restricted Project

Thu, Oct 10

akhuang committed rGc9428a04fc18: Change test case so that it accepts backslashes in file path, in the case that… (authored by akhuang).
Change test case so that it accepts backslashes in file path, in the case that…
Thu, Oct 10, 4:36 PM
akhuang committed rL374473: Change test case so that it accepts backslashes in file path, in the case that….
Change test case so that it accepts backslashes in file path, in the case that…
Thu, Oct 10, 4:35 PM

Wed, Oct 9

akhuang accepted D68747: [codeview] Try to avoid emitting .cv_loc with line zero.

lgtm-

Wed, Oct 9, 5:54 PM · Restricted Project

Mon, Oct 7

akhuang committed rG6bdfe3aeba8b: Fix for expanding __pragmas in macro arguments (authored by akhuang).
Fix for expanding __pragmas in macro arguments
Mon, Oct 7, 10:18 PM
akhuang committed rL373950: Fix for expanding __pragmas in macro arguments.
Fix for expanding __pragmas in macro arguments
Mon, Oct 7, 10:18 PM
akhuang closed D68114: Fix for expanding __pragmas in macro arguments.
Mon, Oct 7, 10:18 PM · Restricted Project, Restricted Project

Fri, Oct 4

akhuang updated the diff for D68114: Fix for expanding __pragmas in macro arguments.
  • move TokenCollector out of function
Fri, Oct 4, 11:22 AM · Restricted Project, Restricted Project

Mon, Sep 30

akhuang updated the summary of D68114: Fix for expanding __pragmas in macro arguments.
Mon, Sep 30, 11:27 AM · Restricted Project, Restricted Project
akhuang updated the diff for D68114: Fix for expanding __pragmas in macro arguments.

comments/whitespace/test

Mon, Sep 30, 11:20 AM · Restricted Project, Restricted Project

Thu, Sep 26

akhuang created D68114: Fix for expanding __pragmas in macro arguments.
Thu, Sep 26, 5:43 PM · Restricted Project, Restricted Project

Sep 18 2019

akhuang committed rG68eae4985995: Add AutoUpgrade function to add new address space datalayout string to existing… (authored by akhuang).
Add AutoUpgrade function to add new address space datalayout string to existing…
Sep 18 2019, 3:15 PM
akhuang committed rL372267: Add AutoUpgrade function to add new address space datalayout string to existing….
Add AutoUpgrade function to add new address space datalayout string to existing…
Sep 18 2019, 3:15 PM
akhuang closed D67631: Add AutoUpgrade function to add new address space datalayout string to existing datalayouts..
Sep 18 2019, 3:15 PM · Restricted Project
akhuang updated the diff for D67631: Add AutoUpgrade function to add new address space datalayout string to existing datalayouts..

clang format

Sep 18 2019, 3:15 PM · Restricted Project
akhuang updated the diff for D67723: [DebugInfo] Add option to disable inline line tables..
  • Address comments
Sep 18 2019, 3:01 PM · debug-info, Restricted Project, Restricted Project
akhuang added inline comments to D67631: Add AutoUpgrade function to add new address space datalayout string to existing datalayouts..
Sep 18 2019, 2:21 PM · Restricted Project
akhuang updated the diff for D67631: Add AutoUpgrade function to add new address space datalayout string to existing datalayouts..
  • Add unittests
  • Change return type to std::string
Sep 18 2019, 2:04 PM · Restricted Project
akhuang created D67723: [DebugInfo] Add option to disable inline line tables..
Sep 18 2019, 10:49 AM · debug-info, Restricted Project, Restricted Project

Sep 17 2019

akhuang updated the diff for D67631: Add AutoUpgrade function to add new address space datalayout string to existing datalayouts..
  • Address comments
Sep 17 2019, 5:09 PM · Restricted Project
akhuang added inline comments to D67631: Add AutoUpgrade function to add new address space datalayout string to existing datalayouts..
Sep 17 2019, 5:09 PM · Restricted Project

Sep 16 2019

akhuang updated the diff for D67631: Add AutoUpgrade function to add new address space datalayout string to existing datalayouts..

Add test cases

Sep 16 2019, 1:46 PM · Restricted Project
akhuang created D67631: Add AutoUpgrade function to add new address space datalayout string to existing datalayouts..
Sep 16 2019, 1:08 PM · Restricted Project

Sep 13 2019

akhuang added a comment to D66843: Change datalayout compatibility check for X86 to allow datalayouts without the new address spaces..

I really do think you should just upgrade old layouts to include the address space.

Sep 13 2019, 11:43 AM · Restricted Project
akhuang added a comment to D66843: Change datalayout compatibility check for X86 to allow datalayouts without the new address spaces..
In D66843#1669803, @rnk wrote:

If this is only being used for clang-cl (or -fms-compatibility) mode only, is it possible to limit it to just that rather than it affecting pretty much everything?

We decided we'd rather not do that. There needs to be some way to upgrade the x86 datalayout. It can't be frozen in stone forever.

Of course, we need to support the use case of linking old bitcode with new bitcode. Doing that probably requires adding an autoupgrade to replace the old data layout with the new one when loading bitcode. We already have x86-specific intrinsic upgrades in llvm/lib/IR/AutoUpgrade.cpp, so it seems reasonable to add this there, even though it is x86 specific, and remove the X86TargetMachine change.

Sep 13 2019, 11:00 AM · Restricted Project

Sep 12 2019

akhuang committed rG227d85956b20: [COFF] Fix to not add archive name to buffer identifiers when they come from… (authored by akhuang).
[COFF] Fix to not add archive name to buffer identifiers when they come from…
Sep 12 2019, 3:08 PM
akhuang committed rL371778: [COFF] Fix to not add archive name to buffer identifiers when they come.
[COFF] Fix to not add archive name to buffer identifiers when they come
Sep 12 2019, 3:04 PM
akhuang closed D67295: [COFF] Fix to not add archive name to buffer identifiers when they come from thin archives..
Sep 12 2019, 3:03 PM · Restricted Project
akhuang updated the diff for D67295: [COFF] Fix to not add archive name to buffer identifiers when they come from thin archives..

rebase

Sep 12 2019, 3:03 PM · Restricted Project

Sep 11 2019

akhuang added a comment to D66843: Change datalayout compatibility check for X86 to allow datalayouts without the new address spaces..

Commited in https://reviews.llvm.org/rL371568

Sep 11 2019, 8:44 AM · Restricted Project

Sep 10 2019

akhuang committed rG7b1d793713cf: Reland "Change the X86 datalayout to add three address spaces for 32 bit… (authored by akhuang).
Reland "Change the X86 datalayout to add three address spaces for 32 bit…
Sep 10 2019, 4:20 PM
akhuang added a reverting change for rG57076d3199fc: Revert "Change the X86 datalayout to add three address spaces for 32 bit signed…: rG7b1d793713cf: Reland "Change the X86 datalayout to add three address spaces for 32 bit….
Sep 10 2019, 4:20 PM
akhuang committed rL371568: Reland "Change the X86 datalayout to add three address spaces.
Reland "Change the X86 datalayout to add three address spaces
Sep 10 2019, 4:19 PM

Sep 6 2019

akhuang abandoned D66767: Add binary filename to the bitcode filename when using -thinlto-index-only.
Sep 6 2019, 12:00 PM · Restricted Project
akhuang created D67295: [COFF] Fix to not add archive name to buffer identifiers when they come from thin archives..
Sep 6 2019, 11:13 AM · Restricted Project

Sep 4 2019

akhuang committed rL370999: Add my github username mapping..
Add my github username mapping.
Sep 4 2019, 4:16 PM
akhuang updated the diff for D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr..
  • Change existing tests so they still pass
  • Fix so that it parses all the __ptr32/64 attributes instead of just the last one
Sep 4 2019, 3:09 PM · Restricted Project, Restricted Project
akhuang added a comment to D67141: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator..

What is the reason for this change? The test case and comment changes don't seem related to the actual code change, which would affect DIGlobalVariables.

Sep 4 2019, 11:23 AM · Restricted Project, Restricted Project

Aug 29 2019

akhuang added inline comments to D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr..
Aug 29 2019, 11:03 AM · Restricted Project, Restricted Project
akhuang updated the diff for D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr..
  • Test that codegen adds the correct address spaces
  • Modify microsoft mangling to match microsoft mangling.
  • add comment for overloading
Aug 29 2019, 11:00 AM · Restricted Project, Restricted Project

Aug 27 2019

akhuang added a comment to rG1299945b8128: Change the X86 datalayout to add three address spaces for 32 bit signed, 32 bit….

Yes, I am working on a fix in https://reviews.llvm.org/D66843

Aug 27 2019, 5:27 PM
akhuang created D66843: Change datalayout compatibility check for X86 to allow datalayouts without the new address spaces..
Aug 27 2019, 4:06 PM · Restricted Project
akhuang created D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr..
Aug 27 2019, 1:05 PM · Restricted Project, Restricted Project
akhuang committed rL370083: Change the X86 datalayout to add three address spaces for 32 bit signed,.
Change the X86 datalayout to add three address spaces for 32 bit signed,
Aug 27 2019, 11:30 AM
akhuang committed rG1299945b8128: Change the X86 datalayout to add three address spaces for 32 bit signed, 32 bit… (authored by akhuang).
Change the X86 datalayout to add three address spaces for 32 bit signed, 32 bit…
Aug 27 2019, 11:03 AM
akhuang closed D64931: Change X86 datalayout for three address spaces that specify pointer sizes..

Commited in r370083

Aug 27 2019, 11:01 AM · Restricted Project, Restricted Project

Aug 26 2019

akhuang updated the diff for D64931: Change X86 datalayout for three address spaces that specify pointer sizes..

Rebase

Aug 26 2019, 4:25 PM · Restricted Project, Restricted Project
akhuang added a comment to D64931: Change X86 datalayout for three address spaces that specify pointer sizes..

Pinging reviewers -- are there any other concerns on this patch?

Aug 26 2019, 4:11 PM · Restricted Project, Restricted Project
akhuang updated the summary of D64931: Change X86 datalayout for three address spaces that specify pointer sizes..
Aug 26 2019, 4:00 PM · Restricted Project, Restricted Project
akhuang created D66767: Add binary filename to the bitcode filename when using -thinlto-index-only.
Aug 26 2019, 2:00 PM · Restricted Project

Aug 23 2019

akhuang updated the diff for D64931: Change X86 datalayout for three address spaces that specify pointer sizes..
  • Change datalayout in lld test cases.
Aug 23 2019, 10:26 AM · Restricted Project, Restricted Project

Aug 22 2019

akhuang committed rGa1c022c791b5: [COFF] Add libcall symbols to the link when LTO is being used (authored by akhuang).
[COFF] Add libcall symbols to the link when LTO is being used
Aug 22 2019, 12:41 PM
akhuang committed rL369694: [COFF] Add libcall symbols to the link when LTO is being used.
[COFF] Add libcall symbols to the link when LTO is being used
Aug 22 2019, 12:41 PM

Aug 19 2019

akhuang added inline comments to D66355: [COFF] Add libcall symbols to the link when LTO is being used..
Aug 19 2019, 3:05 PM · Restricted Project

Aug 16 2019

akhuang updated the diff for D66355: [COFF] Add libcall symbols to the link when LTO is being used..
  • Move libcall check inside while loop
  • Remove find()
Aug 16 2019, 2:41 PM · Restricted Project
akhuang added a comment to D64931: Change X86 datalayout for three address spaces that specify pointer sizes..

Address space have backend defined semantics, and aren’t really reserved for front end use. I think the fact that non-0 address spaces on X86 codegen the same as address space 0 and could be used for something by a front end is an accident of how SelectionDAG is implemented. If X86 wants to reserve address space ranges for frontend use, that would need to be decided and documented. You don’t necessarily get the current behavior for free in GlobalISel since pointer types are distinct, so this would specifically need to be implemented.

Aug 16 2019, 1:48 PM · Restricted Project, Restricted Project
akhuang updated the diff for D66355: [COFF] Add libcall symbols to the link when LTO is being used..
  • Check that file is bitcode
  • Change test to look at lld map
Aug 16 2019, 1:15 PM · Restricted Project
akhuang created D66355: [COFF] Add libcall symbols to the link when LTO is being used..
Aug 16 2019, 10:33 AM · Restricted Project

Aug 15 2019

akhuang updated the summary of D64931: Change X86 datalayout for three address spaces that specify pointer sizes..
Aug 15 2019, 11:54 AM · Restricted Project, Restricted Project
akhuang updated the diff for D64931: Change X86 datalayout for three address spaces that specify pointer sizes..
  • Change the datalayout strings in test cases for x86 so they match the new datalayout and tests pass.
  • Change the address space numbers, mostly so I don't have to change the fact that currently address spaces under

256 don't do anything.

Aug 15 2019, 11:54 AM · Restricted Project, Restricted Project

Aug 8 2019

akhuang added a comment to D64931: Change X86 datalayout for three address spaces that specify pointer sizes..

Can you post a reproducer?

Turns out I just didn't have assertions enabled. With assertions the changed test cases should fail.

Aug 8 2019, 5:17 PM · Restricted Project, Restricted Project
akhuang added a comment to D64931: Change X86 datalayout for three address spaces that specify pointer sizes..

@lebedev.ri The test case datalayout strings were changed because somewhere llvm asserts that the string in the IR matches the backend datalayout. I don't know why I wasn't getting the assert error now, but I think they'll all have to be changed if we change the X86 datalayout?

Aug 8 2019, 3:43 PM · Restricted Project, Restricted Project
akhuang updated the diff for D64931: Change X86 datalayout for three address spaces that specify pointer sizes..

Remove test case changes.

Aug 8 2019, 11:54 AM · Restricted Project, Restricted Project
akhuang added a comment to D64931: Change X86 datalayout for three address spaces that specify pointer sizes..

For some reason the tests were failing before without the datalayout change? I'm not sure why, but I changed them back and they're fine.

Aug 8 2019, 11:54 AM · Restricted Project, Restricted Project
akhuang added a comment to D64931: Change X86 datalayout for three address spaces that specify pointer sizes..

The llvm-dev discussion is here http://lists.llvm.org/pipermail/llvm-dev/2019-July/134035.html
I think the consensus is that it should be fine to change the data layout.

Aug 8 2019, 10:54 AM · Restricted Project, Restricted Project
akhuang closed D65023: [MS] Pass S_HEAPALLOCSITE metadata through SelectionDAG.

Committed in https://reviews.llvm.org/rL368230

Aug 8 2019, 9:09 AM · Restricted Project

Aug 7 2019

akhuang committed rG0b870b969fcb: Recommit "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" with a fix to… (authored by akhuang).
Recommit "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" with a fix to…
Aug 7 2019, 3:52 PM
akhuang committed rL368230: Recommit "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG".
Recommit "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG"
Aug 7 2019, 3:52 PM
akhuang updated the summary of D65023: [MS] Pass S_HEAPALLOCSITE metadata through SelectionDAG.
Aug 7 2019, 3:35 PM · Restricted Project
akhuang updated the diff for D65023: [MS] Pass S_HEAPALLOCSITE metadata through SelectionDAG.
  • Add clear to the SDNode map when Selection DAG is cleared
Aug 7 2019, 3:19 PM · Restricted Project

Aug 6 2019

akhuang updated the summary of D65023: [MS] Pass S_HEAPALLOCSITE metadata through SelectionDAG.
Aug 6 2019, 2:08 PM · Restricted Project
akhuang added inline comments to D65023: [MS] Pass S_HEAPALLOCSITE metadata through SelectionDAG.
Aug 6 2019, 2:06 PM · Restricted Project
akhuang updated the diff for D65023: [MS] Pass S_HEAPALLOCSITE metadata through SelectionDAG.

Remove tail call metadata; update test

Aug 6 2019, 1:49 PM · Restricted Project

Aug 5 2019

akhuang updated the diff for D65023: [MS] Pass S_HEAPALLOCSITE metadata through SelectionDAG.

clang format

Aug 5 2019, 1:47 PM · Restricted Project
akhuang updated the diff for D65023: [MS] Pass S_HEAPALLOCSITE metadata through SelectionDAG.
  • Revert "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" and
  • Recommit "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG"
Aug 5 2019, 1:42 PM · Restricted Project

Jul 31 2019

akhuang committed rG153f20057c2f: Revert "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" and and partial… (authored by akhuang).
Revert "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" and and partial…
Jul 31 2019, 5:00 PM
akhuang added a reverting change for rG53da7ca94343: [MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG: rG153f20057c2f: Revert "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" and and partial….
Jul 31 2019, 5:00 PM
akhuang committed rL367496: Revert "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" and.
Revert "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" and
Jul 31 2019, 4:59 PM
akhuang committed rG27a73dd02c26: Fix to r367374 "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" after… (authored by akhuang).
Fix to r367374 "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" after…
Jul 31 2019, 2:06 PM
akhuang committed rL367483: Fix to r367374 "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG".
Fix to r367374 "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG"
Jul 31 2019, 2:03 PM

Jul 30 2019

akhuang committed rG53da7ca94343: [MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG (authored by akhuang).
[MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG
Jul 30 2019, 5:19 PM
akhuang committed rL367374: [MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG.
[MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG
Jul 30 2019, 5:18 PM
akhuang closed D61105: [MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG.
Jul 30 2019, 5:18 PM · Restricted Project
akhuang updated the diff for D61105: [MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG.

Add nullptr to struct declaration

Jul 30 2019, 5:13 PM · Restricted Project

Jul 22 2019

akhuang updated the diff for D61105: [MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG.

It seems there is now an SDNode map in SelectionDAG for CallSiteInfo.
I merged the HeapAllocSite map with the CallSiteInfo map so that we don't have
two maps that use SDNodes as keys.

Jul 22 2019, 5:26 PM · Restricted Project

Jul 19 2019

akhuang planned changes to D61105: [MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG.

There is now a new patch that attaches the metadata to a call operand-- https://reviews.llvm.org/D65023.

Jul 19 2019, 2:58 PM · Restricted Project
akhuang created D65023: [MS] Pass S_HEAPALLOCSITE metadata through SelectionDAG.
Jul 19 2019, 2:55 PM · Restricted Project

Jul 18 2019

akhuang committed rGf332fe642cc5: [COFF] Change a variable type to be const in the HeapAllocSite map. (authored by akhuang).
[COFF] Change a variable type to be const in the HeapAllocSite map.
Jul 18 2019, 11:26 AM