Page MenuHomePhabricator

akhuang (Amy Huang)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 7 2019, 2:10 PM (109 w, 2 d)

Recent Activity

Wed, Apr 7

akhuang added a comment to D99994: [CodeView] Add CodeView support for PGO debug information.

think this looks good overall; maybe it should also have an IR to codeview test?

Wed, Apr 7, 11:21 AM · Restricted Project, Restricted Project

Tue, Apr 6

akhuang added a comment to D98750: Apply [[standalone_debug]] to some types in the STL..

I've updated the ./libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp test so that it runs with constructor homing enabled. One of the cases in the test was already failing, but everything else seems to work. (It only passes if it's run with a version clang that includes my __attribute__((standalone_debug)) change, though).

Tue, Apr 6, 5:50 PM · Restricted Project
akhuang updated the diff for D98750: Apply [[standalone_debug]] to some types in the STL..

Update a test case to test the use of this attribute.

Tue, Apr 6, 5:48 PM · Restricted Project

Mon, Apr 5

akhuang added a comment to D99879: [clang][cli] Ensure plugin args are generated in deterministic order.

also just confirming that this fixes the issue we were seeing in Chrome

Mon, Apr 5, 12:47 PM · Restricted Project

Fri, Apr 2

akhuang added a comment to D97462: [clang][cli] Round-trip cc1 arguments in assert builds.

In Chrome we noticed that plugin flags are not being roundtripped (and build fails with error: Generated arguments do not match in round-trip):

Fri, Apr 2, 9:22 AM · Restricted Project

Thu, Apr 1

akhuang added a comment to D98750: Apply [[standalone_debug]] to some types in the STL..

It looks like there's already a pretty printer test in libc++ (./libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp). It currently fails on my machine for some reason before running the actual tests, but in theory if it worked, it would catch the issues when -fuse-ctor-homing is enabled.

Thu, Apr 1, 9:30 AM · Restricted Project

Wed, Mar 31

akhuang added a comment to D98750: Apply [[standalone_debug]] to some types in the STL..

It feels like I've done that before (if so please refresh my memory), but here's a patch trying to remove the UB we have in std::list: https://reviews.llvm.org/D99624. Could you please try it out and see if it fixes the issues you were seeing with __list_node? If it does, then I believe we can apply similar fixes to the other types and fix the underlying problem instead of applying this attribute which will only hide the issue.

Thanks! I tried out the other patch and it does fix the issues with __list_node.

Thanks for trying it out. Depending on the outcome of the discussion currently happening on D99624, I would suggest that we follow a similar path for the other types instead of "hiding" the issue with the attribute.

If it is instead the case that D99624 isn't actually fixing any UB (see discussion over there), then I believe it would be OK to move forward with this patch.

Also, how do you reproduce the issue you're fixing here? Is there a reasonably easy way to do that so we could add something to the test suite?

Wed, Mar 31, 11:26 AM · Restricted Project

Tue, Mar 30

akhuang added a comment to D98750: Apply [[standalone_debug]] to some types in the STL..

It feels like I've done that before (if so please refresh my memory), but here's a patch trying to remove the UB we have in std::list: https://reviews.llvm.org/D99624. Could you please try it out and see if it fixes the issues you were seeing with __list_node? If it does, then I believe we can apply similar fixes to the other types and fix the underlying problem instead of applying this attribute which will only hide the issue.

Tue, Mar 30, 4:20 PM · Restricted Project
akhuang added a comment to D98750: Apply [[standalone_debug]] to some types in the STL..

ping?

Tue, Mar 30, 11:06 AM · Restricted Project

Mon, Mar 29

akhuang added a reverting change for rG7ce9a3e9a91b: [COFF] Only consider associated EH sections during ICF: rG5127da029194: Revert "[COFF] Only consider associated EH sections during ICF".
Mon, Mar 29, 7:16 PM
akhuang committed rG5127da029194: Revert "[COFF] Only consider associated EH sections during ICF" (authored by akhuang).
Revert "[COFF] Only consider associated EH sections during ICF"
Mon, Mar 29, 7:16 PM
akhuang added a reverting change for D98993: [COFF] Only consider associated EH sections during ICF: rG5127da029194: Revert "[COFF] Only consider associated EH sections during ICF".
Mon, Mar 29, 7:16 PM · Restricted Project
akhuang added a comment to D98993: [COFF] Only consider associated EH sections during ICF.

Gonna revert this for now--

Mon, Mar 29, 7:16 PM · Restricted Project

Mon, Mar 22

akhuang added a comment to D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete..

Hmm - is that type used in a way that invokes Undefined Behavior? Or is this a gap/bug in the ctor homing? I thought there was already a special case for constexpr ctors that opted them out of ctor homing.

Right, I think the constexpr is only used in >c++17 for some reason, so doesn't apply here. I looked around a bit but still not sure how/where allocators are constructed.

Fair enough - guess that's a discussion to have on a separate thread/when we talk about adding the attribute to libc++/or when bugfixing the ctor homing, if it turns out/looks like a gap in ctor homing to address there. (happy to discuss it whenever - email/chat/etc)

Mon, Mar 22, 5:23 PM · Restricted Project
akhuang added a comment to D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete..

Hmm - is that type used in a way that invokes Undefined Behavior? Or is this a gap/bug in the ctor homing? I thought there was already a special case for constexpr ctors that opted them out of ctor homing.

Mon, Mar 22, 11:50 AM · Restricted Project

Fri, Mar 19

akhuang added a comment to D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete..

I started looking into some diffs of debug info in libc++ tests, but it's pretty hard to tell what's different - as far as I can see, there are just a bunch of __hash_value_types and __value_types.

This is a job for.... llvm-dva! See the preliminary patch at D88661, although it's getting a bit old and might not apply/build cleanly.

(llvm-dva is undergoing an internal review at the moment, we hope to have a proper reviewable patch series up soon-ish.)

Fri, Mar 19, 2:05 PM · Restricted Project

Wed, Mar 17

akhuang updated the diff for D98750: Apply [[standalone_debug]] to some types in the STL..

Change macro name to LIBCPP_STANDALONE_DEBUG

Wed, Mar 17, 1:31 PM · Restricted Project
akhuang removed 1 blocking reviewer(s) for D98750: Apply [[standalone_debug]] to some types in the STL.: Restricted Project.
Wed, Mar 17, 1:30 PM · Restricted Project
akhuang removed 1 blocking reviewer(s) for D98750: Apply [[standalone_debug]] to some types in the STL.: Restricted Project.
Wed, Mar 17, 1:30 PM · Restricted Project

Tue, Mar 16

akhuang requested review of D98750: Apply [[standalone_debug]] to some types in the STL..
Tue, Mar 16, 4:30 PM · Restricted Project

Mon, Mar 15

akhuang committed rGf5352dd9dab1: Emit inline implementation of __builtin__wmemchr on MSVCRT platforms. (authored by akhuang).
Emit inline implementation of __builtin__wmemchr on MSVCRT platforms.
Mon, Mar 15, 3:33 PM
akhuang closed D98472: Emit inline implementation of __builtin__wmemchr on MSVCRT platforms..
Mon, Mar 15, 3:32 PM · Restricted Project
akhuang updated the diff for D98472: Emit inline implementation of __builtin__wmemchr on MSVCRT platforms..

add CHECK line to test

Mon, Mar 15, 3:30 PM · Restricted Project

Fri, Mar 12

akhuang committed rGd7cd208f08af: [DebugInfo] Add an attribute to force type info to be emitted for types that… (authored by akhuang).
[DebugInfo] Add an attribute to force type info to be emitted for types that…
Fri, Mar 12, 12:30 PM
akhuang closed D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete..
Fri, Mar 12, 12:30 PM · Restricted Project
akhuang updated the summary of D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete..
Fri, Mar 12, 12:29 PM · Restricted Project
akhuang updated the diff for D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete..

add allowInC to attribute

Fri, Mar 12, 12:26 PM · Restricted Project
akhuang updated the diff for D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete..

update test case

Fri, Mar 12, 11:26 AM · Restricted Project

Mar 11 2021

akhuang requested review of D98472: Emit inline implementation of __builtin__wmemchr on MSVCRT platforms..
Mar 11 2021, 5:21 PM · Restricted Project
akhuang added a reviewer for D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.: EricWF.

@EricWF, comments on using this attribute in libc++ vs fixing the code otherwise?

Mar 11 2021, 10:21 AM · Restricted Project

Mar 2 2021

akhuang added a comment to D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete..

I think they're all singular types, like __hash_node. Actually, __tree_node might not be problematic.

Mar 2 2021, 5:09 PM · Restricted Project
akhuang added a comment to D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete..

I don't have an opinion about the attribute itself. I do have an opinion about using that attribute in libc++ instead of fixing the underlying issue (I think we shouldn't do it). Can you confirm what the problematic types are? In another patch I saw __hash_node, __hash_value_type, __tree_node and __value_type. Is that it?

Not entirely sure - those were pointed out as types with missing debug info, but there might be more. I tried looking for types in libc++ that have a value_type member, since those seem to follow a similar pattern. Possibly __forward_list_node?

Since we'll need to identify this list of types either way (to attribute or to fix) might be worth making the list - I'd guess building all the libc++ tests with/without ctor homing and seeing which types go missing as a result might be informative?

Mar 2 2021, 2:44 PM · Restricted Project

Mar 1 2021

akhuang added a comment to D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete..

I don't have an opinion about the attribute itself. I do have an opinion about using that attribute in libc++ instead of fixing the underlying issue (I think we shouldn't do it). Can you confirm what the problematic types are? In another patch I saw __hash_node, __hash_value_type, __tree_node and __value_type. Is that it?

Mar 1 2021, 11:20 AM · Restricted Project

Feb 26 2021

akhuang updated the diff for D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete..

address comments

Feb 26 2021, 1:24 PM · Restricted Project
akhuang added a comment to D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete..

Thanks! I am still curious about the forward declare/redeclaration behavior and whether that is a situation that makes sense or not. I suspect this case may make sense (and likely already works):

// Should test redeclaration behavior.
struct [[clang::standalone_debug]] redecl;
struct redecl {};

but I'm not certain if this case makes sense:

struct [[clang::standalone_debug]] S; // Does this make sense on forward declare that's never defined?
Feb 26 2021, 1:22 PM · Restricted Project
akhuang updated the diff for D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete..

-Add documentation
-Add more test cases and semantics tests

Feb 26 2021, 10:29 AM · Restricted Project

Feb 25 2021

akhuang updated the diff for D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete..

-Add LangOpts[CPlusPlus] to the attribute
-Maybe change the attribute to also override required complete types and change name to standalone_debug

Feb 25 2021, 10:36 AM · Restricted Project
akhuang updated subscribers of D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete..

@ldionne Do you think it'd be reasonable to add this debug info attribute to some types in libc++? (For types that have constructors but don't call them; some previous discussion in https://reviews.llvm.org/D90719).

Feb 25 2021, 10:34 AM · Restricted Project
akhuang abandoned D93070: [asan] Search for llvm-symbolizer in the executable's directory instead of only searching in PATH..
Feb 25 2021, 10:21 AM · Restricted Project
akhuang added inline comments to D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete..
Feb 25 2021, 10:02 AM · Restricted Project
akhuang added a comment to D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete..

Oh, that might be a bit different again - if the type isn't required to be complete in this translation unit, should this attribute override the "required to be complete" homing strategy? (that's the oldest standing strategy - if the type isn't required to be complete, the definition is omitted) I'd have thought this should override that behavior too. Perhaps the type is never dereferenced, but is somehow still useful (eg: you might have one translation unit that only uses handles, and another translation unit that never has a variable of that type (maybe deals with void*) and casts to the defined type and dereferences it - that would break the "required to be complete" homing strategy (though it's unlikely/weird - if you're passing around void* it's unlikely your caller would somehow see and use the declared type anyway))

Feb 25 2021, 9:28 AM · Restricted Project

Feb 24 2021

akhuang requested review of D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete..
Feb 24 2021, 1:13 PM · Restricted Project

Feb 12 2021

akhuang committed rG60a55337e012: Fix test in external_symbolizer_path.cpp, by adding a REQUIRES: static-lib. (authored by akhuang).
Fix test in external_symbolizer_path.cpp, by adding a REQUIRES: static-lib.
Feb 12 2021, 2:05 PM
akhuang committed rG1e92b1730f46: Fix test failure for external_symbolizer_path.cpp (authored by akhuang).
Fix test failure for external_symbolizer_path.cpp
Feb 12 2021, 12:52 PM
akhuang committed rG5815b71eacef: Disable test in external_symbolizer_path.cpp temporarily to debug test failures. (authored by akhuang).
Disable test in external_symbolizer_path.cpp temporarily to debug test failures.
Feb 12 2021, 11:52 AM
akhuang added a comment to D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..

I'm not entirely sure why the buildbots are failing - I think I'll just disable the test everywhere for now.

Feb 12 2021, 11:50 AM · Restricted Project
akhuang added a reverting change for rG1b5c2915a231: [DebugInfo] Add an attribute to force type info to be emitted for: rG3fe465fb2cd6: Revert "[DebugInfo] Add an attribute to force type info to be emitted for".
Feb 12 2021, 10:19 AM
akhuang committed rG3fe465fb2cd6: Revert "[DebugInfo] Add an attribute to force type info to be emitted for" (authored by akhuang).
Revert "[DebugInfo] Add an attribute to force type info to be emitted for"
Feb 12 2021, 10:19 AM
akhuang committed rG394913fdb96a: Try to fix external_symbolizer_path.cpp test to stop breaking on buildbots. (authored by akhuang).
Try to fix external_symbolizer_path.cpp test to stop breaking on buildbots.
Feb 12 2021, 10:17 AM
akhuang committed rG1b5c2915a231: [DebugInfo] Add an attribute to force type info to be emitted for (authored by akhuang).
[DebugInfo] Add an attribute to force type info to be emitted for
Feb 12 2021, 10:17 AM

Feb 5 2021

akhuang committed rG34f3249abdff: [DebugInfo] Fix error from D95893, where I accidentally used an (authored by akhuang).
[DebugInfo] Fix error from D95893, where I accidentally used an
Feb 5 2021, 10:26 AM
akhuang committed rGa740af4de970: [CodeView][DebugInfo] Update the code for removing template arguments from the… (authored by akhuang).
[CodeView][DebugInfo] Update the code for removing template arguments from the…
Feb 5 2021, 9:49 AM
akhuang closed D95893: [CodeView][DebugInfo] Update the code for removing template arguments from the display name of a codeview function id..
Feb 5 2021, 9:49 AM · Restricted Project

Feb 4 2021

akhuang updated the diff for D95893: [CodeView][DebugInfo] Update the code for removing template arguments from the display name of a codeview function id..

Add to comment

Feb 4 2021, 5:35 PM · Restricted Project
akhuang committed rG8d7d2deb3790: Fix test case from D94563. (authored by akhuang).
Fix test case from D94563.
Feb 4 2021, 4:35 PM
akhuang committed rG4737aab53d7f: Fix a test case after committing D94563. (authored by akhuang).
Fix a test case after committing D94563.
Feb 4 2021, 4:08 PM
akhuang committed rG9ba623c655e9: [asan] Add %d variable to external_symbolizer_path option, so that user can… (authored by akhuang).
[asan] Add %d variable to external_symbolizer_path option, so that user can…
Feb 4 2021, 3:45 PM
akhuang closed D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..
Feb 4 2021, 3:45 PM · Restricted Project
akhuang added a comment to D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..

thanks for helping / reviewing!

Feb 4 2021, 2:47 PM · Restricted Project
akhuang updated the diff for D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..

address comments

Feb 4 2021, 12:56 PM · Restricted Project
akhuang updated the diff for D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..

fix some typos

Feb 4 2021, 10:45 AM · Restricted Project
akhuang updated the diff for D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..

address comments

Feb 4 2021, 10:11 AM · Restricted Project

Feb 3 2021

akhuang committed rG26e9c99010b6: [Docs] Add some documentation for constructor homing, a debug info optimization… (authored by akhuang).
[Docs] Add some documentation for constructor homing, a debug info optimization…
Feb 3 2021, 3:27 PM
akhuang closed D95911: [Docs] Add some documentation for constructor homing, a debug info optimization (-fuse-ctor-homing).
Feb 3 2021, 3:27 PM · Restricted Project
akhuang added a comment to D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..

Sounds good, I added the substitution to SubstituteForFlagValue, and am still calling that from the symbolizer code.

Feb 3 2021, 9:00 AM · Restricted Project
akhuang updated the diff for D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..

Move substitution into SubstituteForFlagValue.

Feb 3 2021, 8:59 AM · Restricted Project

Feb 2 2021

akhuang requested review of D95911: [Docs] Add some documentation for constructor homing, a debug info optimization (-fuse-ctor-homing).
Feb 2 2021, 5:46 PM · Restricted Project
akhuang added a comment to D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..

I ended up not moving things into SubstituteForFlagValue because there are apparently other flags that can contain things like '%p' that shouldn't be substituted.

Feb 2 2021, 5:00 PM · Restricted Project
akhuang updated the diff for D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..

Use %env_tools_opt in test case, change to %d for consistency

Feb 2 2021, 4:58 PM · Restricted Project
akhuang requested review of D95893: [CodeView][DebugInfo] Update the code for removing template arguments from the display name of a codeview function id..
Feb 2 2021, 12:52 PM · Restricted Project

Feb 1 2021

akhuang added a comment to D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..

I think we should handle symbolizer path next to RegisterIncludeFlags in a similar way.
Having that we have %b we should not add @BINARY_DIR with a same meaning.

%b is not quite the same, though, it's just the name of the binary without the path. And looks like the include flags are handled differently from things like the symbolizer_path flag. We could use a similar naming scheme, like %d or something?

Feb 1 2021, 3:04 PM · Restricted Project
akhuang added a comment to D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..

I was going to advise to move substitution into flags.cpp and spotted SubstituteForFlagValue
But it does not work as-is, I didn't yet checked why.

have you looked at this? Maybe we need tiny fix to make existing stuff.

Feb 1 2021, 12:39 PM · Restricted Project

Jan 28 2021

akhuang committed rG7ef79bb8e240: Fix typo in "[DebugInfo][CodeView] Use <lambda_n> as the display name for… (authored by akhuang).
Fix typo in "[DebugInfo][CodeView] Use <lambda_n> as the display name for…
Jan 28 2021, 7:04 PM
akhuang added a reverting change for rG9b21d4b9434d: Revert "[DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas.": rGd5f5deee9ee9: Reland "[DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas".
Jan 28 2021, 6:45 PM
akhuang committed rGd5f5deee9ee9: Reland "[DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas" (authored by akhuang).
Reland "[DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas"
Jan 28 2021, 6:45 PM
akhuang closed D95187: [DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas..
Jan 28 2021, 6:45 PM · Restricted Project
akhuang updated the diff for D95187: [DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas..

Fix test / string code after test failures

Jan 28 2021, 6:43 PM · Restricted Project
akhuang reopened D95187: [DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas..
Jan 28 2021, 6:43 PM · Restricted Project
akhuang added a reverting change for rGd73564c51003: [DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas.: rG9b21d4b9434d: Revert "[DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas.".
Jan 28 2021, 4:42 PM
akhuang committed rG9b21d4b9434d: Revert "[DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas." (authored by akhuang).
Revert "[DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas."
Jan 28 2021, 4:42 PM
akhuang added a reverting change for D95187: [DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas.: rG9b21d4b9434d: Revert "[DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas.".
Jan 28 2021, 4:42 PM · Restricted Project
akhuang committed rGd73564c51003: [DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas. (authored by akhuang).
[DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas.
Jan 28 2021, 4:31 PM
akhuang closed D95187: [DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas..
Jan 28 2021, 4:31 PM · Restricted Project
akhuang added inline comments to D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..
Jan 28 2021, 2:07 PM · Restricted Project
akhuang updated the diff for D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..

Update test

Jan 28 2021, 2:07 PM · Restricted Project

Jan 27 2021

akhuang updated the diff for D95187: [DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas..

make function return lambda string, and add test for lambda in function parameters

Jan 27 2021, 2:04 PM · Restricted Project

Jan 26 2021

akhuang added inline comments to D95187: [DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas..
Jan 26 2021, 2:36 PM · Restricted Project
akhuang updated the diff for D95187: [DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas..

Avoid using getLambdaId function

Jan 26 2021, 12:23 PM · Restricted Project
akhuang added inline comments to D95187: [DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas..
Jan 26 2021, 12:22 PM · Restricted Project
akhuang updated the diff for D95187: [DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas..

change to function returning a number, fill in ItaniumMangle function

Jan 26 2021, 10:49 AM · Restricted Project

Jan 25 2021

akhuang added inline comments to D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..
Jan 25 2021, 5:05 PM · Restricted Project
akhuang updated the diff for D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..

address comments

Jan 25 2021, 5:05 PM · Restricted Project

Jan 22 2021

akhuang updated the diff for D95187: [DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas..

-add to comment
-Add externally visible lambda to test case

Jan 22 2021, 2:58 PM · Restricted Project
akhuang added inline comments to D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..
Jan 22 2021, 11:36 AM · Restricted Project
akhuang updated the diff for D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..

-change string len to use ARRAY_SIZE
-move test to sanitizer_common

Jan 22 2021, 11:30 AM · Restricted Project

Jan 21 2021

akhuang requested review of D95187: [DebugInfo][CodeView] Use <lambda_n> as the display name for lambdas..
Jan 21 2021, 5:08 PM · Restricted Project

Jan 20 2021

akhuang updated the diff for D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..

clean up string code

Jan 20 2021, 1:15 PM · Restricted Project
akhuang committed rGa3d7cee7f9bd: [CodeView] Emit function types in -gline-tables-only. (authored by akhuang).
[CodeView] Emit function types in -gline-tables-only.
Jan 20 2021, 12:49 PM
akhuang closed D95001: [CodeView] Emit function types in -gline-tables-only..
Jan 20 2021, 12:48 PM · Restricted Project
akhuang updated the diff for D95001: [CodeView] Emit function types in -gline-tables-only..

Add comments describing reason for emitting types

Jan 20 2021, 12:42 PM · Restricted Project