Page MenuHomePhabricator

akhuang (Amy Huang)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 7 2019, 2:10 PM (23 w, 3 d)

Recent Activity

Fri, Aug 16

akhuang updated the diff for D66355: [COFF] Add libcall symbols to the link when LTO is being used..
  • Move libcall check inside while loop
  • Remove find()
Fri, Aug 16, 2:41 PM · Restricted Project
akhuang added a comment to D64931: Change X86 datalayout for three address spaces that specify pointer sizes..

Address space have backend defined semantics, and aren’t really reserved for front end use. I think the fact that non-0 address spaces on X86 codegen the same as address space 0 and could be used for something by a front end is an accident of how SelectionDAG is implemented. If X86 wants to reserve address space ranges for frontend use, that would need to be decided and documented. You don’t necessarily get the current behavior for free in GlobalISel since pointer types are distinct, so this would specifically need to be implemented.

Fri, Aug 16, 1:48 PM · Restricted Project, Restricted Project
akhuang updated the diff for D66355: [COFF] Add libcall symbols to the link when LTO is being used..
  • Check that file is bitcode
  • Change test to look at lld map
Fri, Aug 16, 1:15 PM · Restricted Project
akhuang created D66355: [COFF] Add libcall symbols to the link when LTO is being used..
Fri, Aug 16, 10:33 AM · Restricted Project

Thu, Aug 15

akhuang updated the summary of D64931: Change X86 datalayout for three address spaces that specify pointer sizes..
Thu, Aug 15, 11:54 AM · Restricted Project, Restricted Project
akhuang updated the diff for D64931: Change X86 datalayout for three address spaces that specify pointer sizes..
  • Change the datalayout strings in test cases for x86 so they match the new datalayout and tests pass.
  • Change the address space numbers, mostly so I don't have to change the fact that currently address spaces under

256 don't do anything.

Thu, Aug 15, 11:54 AM · Restricted Project, Restricted Project

Thu, Aug 8

akhuang added a comment to D64931: Change X86 datalayout for three address spaces that specify pointer sizes..

Can you post a reproducer?

Turns out I just didn't have assertions enabled. With assertions the changed test cases should fail.

Thu, Aug 8, 5:17 PM · Restricted Project, Restricted Project
akhuang added a comment to D64931: Change X86 datalayout for three address spaces that specify pointer sizes..

@lebedev.ri The test case datalayout strings were changed because somewhere llvm asserts that the string in the IR matches the backend datalayout. I don't know why I wasn't getting the assert error now, but I think they'll all have to be changed if we change the X86 datalayout?

Thu, Aug 8, 3:43 PM · Restricted Project, Restricted Project
akhuang updated the diff for D64931: Change X86 datalayout for three address spaces that specify pointer sizes..

Remove test case changes.

Thu, Aug 8, 11:54 AM · Restricted Project, Restricted Project
akhuang added a comment to D64931: Change X86 datalayout for three address spaces that specify pointer sizes..

For some reason the tests were failing before without the datalayout change? I'm not sure why, but I changed them back and they're fine.

Thu, Aug 8, 11:54 AM · Restricted Project, Restricted Project
akhuang added a comment to D64931: Change X86 datalayout for three address spaces that specify pointer sizes..

The llvm-dev discussion is here http://lists.llvm.org/pipermail/llvm-dev/2019-July/134035.html
I think the consensus is that it should be fine to change the data layout.

Thu, Aug 8, 10:54 AM · Restricted Project, Restricted Project
akhuang closed D65023: [MS] Pass S_HEAPALLOCSITE metadata through SelectionDAG.

Committed in https://reviews.llvm.org/rL368230

Thu, Aug 8, 9:09 AM · Restricted Project

Wed, Aug 7

akhuang committed rG0b870b969fcb: Recommit "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" with a fix to… (authored by akhuang).
Recommit "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" with a fix to…
Wed, Aug 7, 3:52 PM
akhuang committed rL368230: Recommit "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG".
Recommit "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG"
Wed, Aug 7, 3:52 PM
akhuang updated the summary of D65023: [MS] Pass S_HEAPALLOCSITE metadata through SelectionDAG.
Wed, Aug 7, 3:35 PM · Restricted Project
akhuang updated the diff for D65023: [MS] Pass S_HEAPALLOCSITE metadata through SelectionDAG.
  • Add clear to the SDNode map when Selection DAG is cleared
Wed, Aug 7, 3:19 PM · Restricted Project

Tue, Aug 6

akhuang updated the summary of D65023: [MS] Pass S_HEAPALLOCSITE metadata through SelectionDAG.
Tue, Aug 6, 2:08 PM · Restricted Project
akhuang added inline comments to D65023: [MS] Pass S_HEAPALLOCSITE metadata through SelectionDAG.
Tue, Aug 6, 2:06 PM · Restricted Project
akhuang updated the diff for D65023: [MS] Pass S_HEAPALLOCSITE metadata through SelectionDAG.

Remove tail call metadata; update test

Tue, Aug 6, 1:49 PM · Restricted Project

Mon, Aug 5

akhuang updated the diff for D65023: [MS] Pass S_HEAPALLOCSITE metadata through SelectionDAG.

clang format

Mon, Aug 5, 1:47 PM · Restricted Project
akhuang updated the diff for D65023: [MS] Pass S_HEAPALLOCSITE metadata through SelectionDAG.
  • Revert "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" and
  • Recommit "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG"
Mon, Aug 5, 1:42 PM · Restricted Project

Wed, Jul 31

akhuang committed rG153f20057c2f: Revert "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" and and partial… (authored by akhuang).
Revert "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" and and partial…
Wed, Jul 31, 5:00 PM
akhuang added a reverting change for rG53da7ca94343: [MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG: rG153f20057c2f: Revert "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" and and partial….
Wed, Jul 31, 5:00 PM
akhuang committed rL367496: Revert "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" and.
Revert "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" and
Wed, Jul 31, 4:59 PM
akhuang committed rG27a73dd02c26: Fix to r367374 "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" after… (authored by akhuang).
Fix to r367374 "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" after…
Wed, Jul 31, 2:06 PM
akhuang committed rL367483: Fix to r367374 "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG".
Fix to r367374 "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG"
Wed, Jul 31, 2:03 PM

Tue, Jul 30

akhuang committed rG53da7ca94343: [MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG (authored by akhuang).
[MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG
Tue, Jul 30, 5:19 PM
akhuang committed rL367374: [MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG.
[MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG
Tue, Jul 30, 5:18 PM
akhuang closed D61105: [MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG.
Tue, Jul 30, 5:18 PM · Restricted Project
akhuang updated the diff for D61105: [MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG.

Add nullptr to struct declaration

Tue, Jul 30, 5:13 PM · Restricted Project

Mon, Jul 22

akhuang updated the diff for D61105: [MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG.

It seems there is now an SDNode map in SelectionDAG for CallSiteInfo.
I merged the HeapAllocSite map with the CallSiteInfo map so that we don't have
two maps that use SDNodes as keys.

Mon, Jul 22, 5:26 PM · Restricted Project

Jul 19 2019

akhuang planned changes to D61105: [MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG.

There is now a new patch that attaches the metadata to a call operand-- https://reviews.llvm.org/D65023.

Jul 19 2019, 2:58 PM · Restricted Project
akhuang created D65023: [MS] Pass S_HEAPALLOCSITE metadata through SelectionDAG.
Jul 19 2019, 2:55 PM · Restricted Project

Jul 18 2019

akhuang committed rGf332fe642cc5: [COFF] Change a variable type to be const in the HeapAllocSite map. (authored by akhuang).
[COFF] Change a variable type to be const in the HeapAllocSite map.
Jul 18 2019, 11:26 AM
akhuang committed rL366479: [COFF] Change a variable type to be const in the HeapAllocSite map..
[COFF] Change a variable type to be const in the HeapAllocSite map.
Jul 18 2019, 11:23 AM
akhuang created D64931: Change X86 datalayout for three address spaces that specify pointer sizes..
Jul 18 2019, 9:47 AM · Restricted Project, Restricted Project

Jul 8 2019

akhuang committed rGb5a5238b6b83: Replace temporary variable matches in test since r363952 causes an extra… (authored by akhuang).
Replace temporary variable matches in test since r363952 causes an extra…
Jul 8 2019, 10:36 AM
akhuang committed rL365357: Replace temporary variable matches in test since r363952 causes an.
Replace temporary variable matches in test since r363952 causes an
Jul 8 2019, 10:35 AM

Jun 20 2019

akhuang accepted D63625: [CodeGen][test] Use -fno-discard-value-names for better test support.

lgtm

Jun 20 2019, 3:19 PM · Restricted Project
akhuang added a comment to D63625: [CodeGen][test] Use -fno-discard-value-names for better test support.

Why isn't this using FileCheck variable matching in the first place? That's the least fragile solution.

No reason, just something I overlooked when I wrote it-

Jun 20 2019, 2:50 PM · Restricted Project
akhuang added a comment to D63625: [CodeGen][test] Use -fno-discard-value-names for better test support.

Looks good, alternatively I think we can just change %result.ptr into a variable match?

Jun 20 2019, 2:43 PM · Restricted Project
akhuang committed rL363952: Store a pointer to the return value in a static alloca and let the debugger use….
Store a pointer to the return value in a static alloca and let the debugger use…
Jun 20 2019, 10:44 AM
akhuang committed rG7fac5c8d940c: Store a pointer to the return value in a static alloca and let the debugger use… (authored by akhuang).
Store a pointer to the return value in a static alloca and let the debugger use…
Jun 20 2019, 10:14 AM
akhuang closed D63361: Pretend NRVO variables are references so they can be found by debug info.
Jun 20 2019, 10:13 AM · debug-info, Restricted Project, Restricted Project

Jun 19 2019

akhuang added inline comments to D63361: Pretend NRVO variables are references so they can be found by debug info.
Jun 19 2019, 4:54 PM · debug-info, Restricted Project, Restricted Project
akhuang updated the diff for D63361: Pretend NRVO variables are references so they can be found by debug info.
  • fix alignment of pointer in inalloca case
  • make existing tests stop failing by changing some and adding a check for existing return value alloca (I think?) before adding the ReturnValuePointer alloca
Jun 19 2019, 4:52 PM · debug-info, Restricted Project, Restricted Project
akhuang added inline comments to D63361: Pretend NRVO variables are references so they can be found by debug info.
Jun 19 2019, 11:25 AM · debug-info, Restricted Project, Restricted Project
akhuang updated the diff for D63361: Pretend NRVO variables are references so they can be found by debug info.
  • Add clang and llvm tests, and windows debuginfo test
  • Use GEP as returnValuePointer in inalloca case
  • Add bool parameter for EmitDeclare when pointer is being used
Jun 19 2019, 11:25 AM · debug-info, Restricted Project, Restricted Project
akhuang added a reviewer for D63361: Pretend NRVO variables are references so they can be found by debug info: inglorion.
Jun 19 2019, 11:07 AM · debug-info, Restricted Project, Restricted Project
akhuang added inline comments to D63361: Pretend NRVO variables are references so they can be found by debug info.
Jun 19 2019, 9:44 AM · debug-info, Restricted Project, Restricted Project

Jun 18 2019

akhuang updated the diff for D63361: Pretend NRVO variables are references so they can be found by debug info.
  • add semicolon
Jun 18 2019, 9:58 AM · debug-info, Restricted Project, Restricted Project
akhuang added inline comments to D63361: Pretend NRVO variables are references so they can be found by debug info.
Jun 18 2019, 9:57 AM · debug-info, Restricted Project, Restricted Project
akhuang updated the diff for D63361: Pretend NRVO variables are references so they can be found by debug info.

Now creates a pointer to the return location in the function prolog, whenever sret is being used.

Jun 18 2019, 9:57 AM · debug-info, Restricted Project, Restricted Project

Jun 17 2019

akhuang added a comment to D62635: Add enums as global variables in the IR metadata..

They should all be there, but emitting the unused enums makes the binary sizes larger. (I think around 6% increase? I forget the size difference for only emitting used enums)

Jun 17 2019, 4:56 PM · Restricted Project, Restricted Project
akhuang added a comment to D62635: Add enums as global variables in the IR metadata..

I think the main issue was keeping track of which enums are used?

Jun 17 2019, 4:23 PM · Restricted Project, Restricted Project

Jun 14 2019

akhuang updated the diff for D63361: Pretend NRVO variables are references so they can be found by debug info.
  • fix test case
Jun 14 2019, 4:21 PM · debug-info, Restricted Project, Restricted Project
akhuang retitled D63361: Pretend NRVO variables are references so they can be found by debug info from Pretend NRVO variables are references so that CodeView can get their value to Pretend NRVO variables are references so they can be found by debug info.
Jun 14 2019, 3:11 PM · debug-info, Restricted Project, Restricted Project
akhuang created D63361: Pretend NRVO variables are references so they can be found by debug info.
Jun 14 2019, 2:50 PM · debug-info, Restricted Project, Restricted Project

Jun 13 2019

akhuang committed rG49275272e3ec: Use fully qualified name when printing S_CONSTANT records (authored by akhuang).
Use fully qualified name when printing S_CONSTANT records
Jun 13 2019, 3:51 PM
akhuang committed rL363335: Use fully qualified name when printing S_CONSTANT records.
Use fully qualified name when printing S_CONSTANT records
Jun 13 2019, 3:50 PM
akhuang closed D63012: Use fully qualified name when printing S_CONSTANT records.
Jun 13 2019, 3:50 PM · Restricted Project, Restricted Project

Jun 11 2019

akhuang updated the diff for D63012: Use fully qualified name when printing S_CONSTANT records.

Change to not emit DIGlobalVariable for enums when they are defined in a class, which
matches MSVC's behavior and gets around the issue of having to create a name with scope.

Jun 11 2019, 12:56 PM · Restricted Project, Restricted Project
akhuang committed rG9970817c57f7: Deduplicate S_CONSTANTs in LLD. (authored by akhuang).
Deduplicate S_CONSTANTs in LLD.
Jun 11 2019, 11:01 AM
akhuang committed rL363089: Deduplicate S_CONSTANTs in LLD..
Deduplicate S_CONSTANTs in LLD.
Jun 11 2019, 11:01 AM
akhuang closed D63151: Deduplicate S_CONSTANTs in LLD..
Jun 11 2019, 11:01 AM · Restricted Project
akhuang created D63151: Deduplicate S_CONSTANTs in LLD..
Jun 11 2019, 10:41 AM · Restricted Project

Jun 10 2019

akhuang added inline comments to D63012: Use fully qualified name when printing S_CONSTANT records.
Jun 10 2019, 1:58 PM · Restricted Project, Restricted Project

Jun 7 2019

akhuang added inline comments to D63012: Use fully qualified name when printing S_CONSTANT records.
Jun 7 2019, 4:59 PM · Restricted Project, Restricted Project
akhuang updated the diff for D63012: Use fully qualified name when printing S_CONSTANT records.

Add case for enums in classes.

Jun 7 2019, 1:17 PM · Restricted Project, Restricted Project
akhuang created D63012: Use fully qualified name when printing S_CONSTANT records.
Jun 7 2019, 9:38 AM · Restricted Project, Restricted Project

Jun 6 2019

akhuang committed rG980d3645df45: Add cdb test for global constants (authored by akhuang).
Add cdb test for global constants
Jun 6 2019, 1:21 PM
akhuang committed rL362745: Add cdb test for global constants.
Add cdb test for global constants
Jun 6 2019, 1:20 PM
akhuang closed D62974: Add cdb test for global constants.
Jun 6 2019, 1:20 PM · Restricted Project
akhuang updated the diff for D62974: Add cdb test for global constants.
  • add comment
Jun 6 2019, 1:15 PM · Restricted Project
akhuang created D62974: Add cdb test for global constants.
Jun 6 2019, 12:35 PM · Restricted Project

May 30 2019

akhuang committed rGdd3a9caf477a: Add enums as global variables in the IR metadata. (authored by akhuang).
Add enums as global variables in the IR metadata.
May 30 2019, 3:02 PM
akhuang committed rL362166: Add enums as global variables in the IR metadata..
Add enums as global variables in the IR metadata.
May 30 2019, 3:01 PM
akhuang closed D62635: Add enums as global variables in the IR metadata..
May 30 2019, 3:01 PM · Restricted Project, Restricted Project

May 29 2019

akhuang created D62635: Add enums as global variables in the IR metadata..
May 29 2019, 4:43 PM · Restricted Project, Restricted Project
akhuang committed rG325003be02bf: CodeView - add static data members to global variable debug info. (authored by akhuang).
CodeView - add static data members to global variable debug info.
May 29 2019, 2:44 PM
akhuang committed rC362038: CodeView - add static data members to global variable debug info..
CodeView - add static data members to global variable debug info.
May 29 2019, 2:42 PM
akhuang committed rL362038: CodeView - add static data members to global variable debug info..
CodeView - add static data members to global variable debug info.
May 29 2019, 2:42 PM
akhuang closed D62167: CodeView - add static data members to global variable debug info..
May 29 2019, 2:42 PM · Restricted Project, Restricted Project
akhuang updated the diff for D62167: CodeView - add static data members to global variable debug info..

Append class name to static data member debug info name.

May 29 2019, 12:59 PM · Restricted Project, Restricted Project
akhuang added a comment to rC361670: Default arguments are potentially constant evaluated..

This causes the chromium build to fail with

FAILED: obj/third_party/blink/renderer/bindings/core/v8/bindings_core_impl/v8_feature_policy.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/blink/renderer/bindings/core/v8/bindings_core_impl/v8_feature_policy.o.d -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -DCR_CLANG_REVISION=\"361677-bede937b-0\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DCOMPONENT_BUILD -D_LIBCPP_ABI_UNSTABLE -D_LIBCPP_ABI_VERSION=Cr -D_LIBCPP_ENABLE_NODISCARD -DCR_LIBCXX_REVISION=361348 -DCR_SYSROOT_HASH=e7c53f04bd88d29d075bfd1f62b073aeb69cbe09 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DBLINK_CORE_IMPLEMENTATION=1 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DWEBP_EXTERN=extern -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DVK_NO_PROTOTYPES -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DBORINGSSL_SHARED_LIBRARY -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -DABSL_ALLOCATOR_NOTHROW=1 -DNO_MAIN_THREAD_WRAPPING -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DPROTOBUF_USE_DLLS -DSK_GL -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_USER_CONFIG_HEADER=\"../../skia/config/SkUserConfig.h\" -DSK_HAS_JPEG_LIBRARY -DSK_VULKAN_HEADER=\"../../skia/config/SkVulkanConfig.h\" -DSK_VULKAN=1 -DSKIA_DLL -DSKCMS_API=__attribute__\(\(visibility\(\"default\"\)\)\) -DSK_SUPPORT_GPU=1 -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\" -DVK_NO_PROTOTYPES -DUSING_V8_SHARED -DV8_DEPRECATION_WARNINGS -DLEVELDB_PLATFORM_CHROMIUM=1 -DLEVELDB_PLATFORM_CHROMIUM=1 -DLEVELDB_SHARED_LIBRARY -DWTF_USE_WEBAUDIO_FFMPEG=1 -DSUPPORT_WEBGL2_COMPUTE_CONTEXT=1 -DUSE_LIBJPEG_TURBO=1 -DUSING_V8_SHARED -DV8_DEPRECATION_WARNINGS -DLIBXSLT_STATIC -I../.. -Igen -I../../third_party/libyuv/include -I../../third_party/libwebp/src -I../../third_party/khronos -I../../gpu -I../../third_party/vulkan/include -Igen/third_party/dawn -I../../third_party/dawn/src/include -I../../third_party/boringssl/src/include -I../../third_party/webrtc_overrides -I../../third_party/webrtc -Igen/third_party/webrtc -I../../third_party/abseil-cpp -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/protobuf/src -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/skia -I../../third_party/vulkan/include -I../../third_party/skia/third_party/vulkanmemoryallocator -I../../third_party/vulkan/include -I../../third_party/angle/include -I../../third_party/angle/src/common/third_party/base -Igen/angle -I../../third_party/angle/include -I../../v8/include -Igen/v8/include -I../../third_party/libwebm/source -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -I../../third_party/libjpeg_turbo -I../../third_party/iccjpeg -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/ots/include -I../../v8/include -Igen/v8/include -I../../third_party/libxml/src/include -I../../third_party/libxml/linux/include -I../../third_party/libxslt/src -I../../third_party/snappy/src -I../../third_party/snappy/linux -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -fmerge-all-constants -fcrash-diagnostics-dir=../../tools/clang/crashreports -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -fcomplete-member-pointers -m64 -march=x86-64 -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -Xclang -fdebug-compilation-dir -Xclang . -no-canonical-prefixes -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wextra-semi -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-ignored-pragma-optimize -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -fvisibility=hidden -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors -Xclang -add-plugin -Xclang blink-gc-plugin -Wglobal-constructors -g2 -ggnu-pubnames -isystem../../build/linux/debian_sid_amd64-sysroot/usr/include/glib-2.0 -isystem../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wconversion -Wno-float-conversion -Wno-sign-conversion -Wno-implicit-float-conversion -Wno-implicit-int-conversion -Wno-shorten-64-to-32 -Wno-header-guard -isystem../../build/linux/debian_sid_amd64-sysroot/usr/include/nss -isystem../../build/linux/debian_sid_amd64-sysroot/usr/include/nspr -DLIBXML_STATIC= -std=c++14 -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_sid_amd64-sysroot -fvisibility-inlines-hidden -c gen/third_party/blink/renderer/bindings/core/v8/v8_feature_policy.cc -o obj/third_party/blink/renderer/bindings/core/v8/bindings_core_impl/v8_feature_policy.o
In file included from gen/third_party/blink/renderer/bindings/core/v8/v8_feature_policy.cc:11:
In file included from gen/third_party/blink/renderer/bindings/core/v8/v8_feature_policy.h:14:
In file included from ../../third_party/blink/renderer/bindings/core/v8/generated_code_helper.h:14:
In file included from ../../third_party/blink/renderer/bindings/core/v8/script_promise.h:34:
../../base/memory/scoped_refptr.h:291:6: error: member access into incomplete type 'const blink::SecurityOrigin'
  ptr->AddRef();
     ^
../../base/memory/scoped_refptr.h:177:7: note: in instantiation of member function 'scoped_refptr<const blink::SecurityOrigin>::AddRef' requested here
      AddRef(ptr_);
      ^
../../third_party/blink/renderer/platform/bindings/dom_wrapper_world.h:50:7: note: forward declaration of 'blink::SecurityOrigin'
class SecurityOrigin;
      ^
1 error generated.
May 29 2019, 10:47 AM

May 24 2019

akhuang added inline comments to D62167: CodeView - add static data members to global variable debug info..
May 24 2019, 3:29 PM · Restricted Project, Restricted Project

May 23 2019

akhuang added inline comments to D62167: CodeView - add static data members to global variable debug info..
May 23 2019, 10:11 AM · Restricted Project, Restricted Project
akhuang updated the diff for D62167: CodeView - add static data members to global variable debug info..

Add llvm IR test.

May 23 2019, 10:00 AM · Restricted Project, Restricted Project

May 22 2019

akhuang committed rG63305c8fbba7: Combine two if cases because the second one is never reached. (authored by akhuang).
Combine two if cases because the second one is never reached.
May 22 2019, 8:48 AM
akhuang committed rC361400: Combine two if cases because the second one is never reached..
Combine two if cases because the second one is never reached.
May 22 2019, 8:46 AM
akhuang committed rL361400: Combine two if cases because the second one is never reached..
Combine two if cases because the second one is never reached.
May 22 2019, 8:46 AM
akhuang closed D62214: Remove extra if case..
May 22 2019, 8:46 AM · Restricted Project, Restricted Project

May 21 2019

akhuang updated subscribers of D62167: CodeView - add static data members to global variable debug info..
May 21 2019, 3:53 PM · Restricted Project, Restricted Project
akhuang created D62214: Remove extra if case..
May 21 2019, 11:46 AM · Restricted Project, Restricted Project

May 20 2019

akhuang created D62167: CodeView - add static data members to global variable debug info..
May 20 2019, 5:23 PM · Restricted Project, Restricted Project

May 16 2019

akhuang committed rGc2029068bc5d: Emit global variables as S_CONSTANT records for codeview debug info. (authored by akhuang).
Emit global variables as S_CONSTANT records for codeview debug info.
May 16 2019, 3:30 PM
akhuang committed rL360948: Emit global variables as S_CONSTANT records for codeview debug info..
Emit global variables as S_CONSTANT records for codeview debug info.
May 16 2019, 3:30 PM
akhuang closed D61926: Emit global variables as S_CONSTANT records for codeview debug info..
May 16 2019, 3:30 PM · Restricted Project
akhuang updated the diff for D61926: Emit global variables as S_CONSTANT records for codeview debug info..

whitespace

May 16 2019, 1:50 PM · Restricted Project
akhuang updated the diff for D61926: Emit global variables as S_CONSTANT records for codeview debug info..

nits

May 16 2019, 1:47 PM · Restricted Project