Page MenuHomePhabricator

akhuang (Amy Huang)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 7 2019, 2:10 PM (168 w, 1 d)

Recent Activity

Apr 5 2022

akhuang added a comment to D123151: [llvm-symbolizer] Fix line offset for inline site..

Oh, I see, looks good then!

Apr 5 2022, 5:12 PM · Restricted Project, Restricted Project
akhuang accepted D123151: [llvm-symbolizer] Fix line offset for inline site..

I think this looks good, although I don't entirely remember how these work-- what's the situation where the "current line offset is actually for next range"?

Apr 5 2022, 4:38 PM · Restricted Project, Restricted Project

Jan 26 2022

akhuang updated the diff for D110450: [LLD] Remove global state in lld/COFF.

some more ctx.config -> config->

Jan 26 2022, 10:10 AM · Restricted Project

Jan 21 2022

akhuang updated the diff for D110450: [LLD] Remove global state in lld/COFF.

config. to config->

Jan 21 2022, 7:16 PM · Restricted Project
akhuang added inline comments to D110450: [LLD] Remove global state in lld/COFF.
Jan 21 2022, 7:16 PM · Restricted Project
akhuang updated the diff for D110450: [LLD] Remove global state in lld/COFF.

further cleanup

Jan 21 2022, 5:47 PM · Restricted Project
akhuang updated the diff for D110450: [LLD] Remove global state in lld/COFF.

cleanup and fix stuff that got messed during rebase

Jan 21 2022, 12:27 PM · Restricted Project

Jan 20 2022

akhuang updated the diff for D110450: [LLD] Remove global state in lld/COFF.

Address comments

Jan 20 2022, 5:22 PM · Restricted Project
akhuang added a comment to D110450: [LLD] Remove global state in lld/COFF.

@aganea Ah, right, I can take a look at the comments today

Jan 20 2022, 12:28 PM · Restricted Project

Jan 10 2022

akhuang added a comment to D116766: [SCEV] Sequential/in-order `UMin` expression.

Hi, this change caused clang to crash in chromium arm builds; could you take a look?

Jan 10 2022, 4:50 PM · Restricted Project

Jan 7 2022

akhuang committed rG28d2977ff236: [-fms-extensions] Make some exception specification warnings/errors compatible… (authored by akhuang).
[-fms-extensions] Make some exception specification warnings/errors compatible…
Jan 7 2022, 2:42 PM
akhuang closed D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does.
Jan 7 2022, 2:42 PM · Restricted Project

Jan 6 2022

akhuang updated the diff for D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does.

Add std=c++17 to the test.

Jan 6 2022, 10:21 AM · Restricted Project

Jan 5 2022

akhuang added a comment to D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does.

Thanks for the patch! This looks roughly right to me.

Maybe the list of ESTs that are allowed to be mismatched should be opt-in instead of opt-out? (i.e. instead of checking for "not EST_BasicNoexcept / EST_DependentNoexcept", check for EST_NoThrow (I think?) Not sure which way is better.

(Looks like the old code was added for https://llvm.org/PR25265)

Could you check that we still emit the warning on line 5 in https://godbolt.org/z/bxfx8jsjd ? The test is mostly from https://docs.microsoft.com/en-us/cpp/build/reference/zc-noexcepttypes?view=msvc-170 -- it feels like we might want to have different behavior in c++17 (and later) and c++14 (and earlier) for some of the diags, possibly. Looks like MSVC also has an error on line 15 by default (with /std:c++17, it seems to accept it with /std:c++14), while we only warn.

(I'm a bit surprised the noexcept bit doesn't make it into the mangled name in the ms abi, but we're consistent with msvc about this so that's all good.)

Jan 5 2022, 5:56 PM · Restricted Project
akhuang updated the diff for D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does.

Fix warning behavior

Jan 5 2022, 5:48 PM · Restricted Project

Dec 23 2021

akhuang requested review of D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does.
Dec 23 2021, 3:24 PM · Restricted Project

Nov 11 2021

akhuang planned changes to D113629: Add path to lower addrspacecasts in constant exprs for __ptr32/__ptr64..
Nov 11 2021, 11:22 AM · Restricted Project

Nov 10 2021

akhuang requested review of D113629: Add path to lower addrspacecasts in constant exprs for __ptr32/__ptr64..
Nov 10 2021, 4:41 PM · Restricted Project

Nov 3 2021

akhuang accepted D112710: [Support] [Windows] Use RemoveFileOnSignal if unable to use the delete-on-close flag.

lgtm!

Nov 3 2021, 11:33 AM · Restricted Project

Oct 26 2021

akhuang accepted D111875: [Support] [Windows] Manually clean up temp files on network shares.

lgtm!

Oct 26 2021, 4:05 PM · Restricted Project
akhuang added a comment to D112376: [Support] [Windows] Use the regular RemoveFileOnSignal() mechanism on Windows too.

I think on Windows the RemoveFileOnSignal path doesn't always work when the process is killed, which causes temp files to be left sometimes (see https://reviews.llvm.org/D102736)

Oct 26 2021, 11:58 AM · Restricted Project

Oct 20 2021

akhuang added a comment to D111875: [Support] [Windows] Manually clean up temp files on network shares.

This also appears to fix another llvm bug filed on a windows ram drive issue (https://bugs.llvm.org/show_bug.cgi?id=52080), which is cool.

Oct 20 2021, 1:12 PM · Restricted Project

Oct 5 2021

akhuang committed rGc7104e506619: [Sema] Allow comparisons between different ms ptr size address space types. (authored by akhuang).
[Sema] Allow comparisons between different ms ptr size address space types.
Oct 5 2021, 10:56 AM
akhuang closed D110670: [Sema] Allow comparisons between different ms ptr size address space types..
Oct 5 2021, 10:56 AM · Restricted Project

Oct 4 2021

akhuang updated the diff for D110670: [Sema] Allow comparisons between different ms ptr size address space types..

add test

Oct 4 2021, 10:08 AM · Restricted Project

Sep 30 2021

akhuang added inline comments to D110670: [Sema] Allow comparisons between different ms ptr size address space types..
Sep 30 2021, 2:54 PM · Restricted Project
akhuang added a comment to D71539: [SCEV] Look through trivial PHIs..

Hi, I saw a similar crash in chrome windows pgo builds that was caused by this change

Sep 30 2021, 11:30 AM · Restricted Project, Restricted Project

Sep 29 2021

akhuang committed rG0cd9d8a48bdd: Revert "[clang-cl] Accept `#pragma warning(disable : N)` for some N" (authored by akhuang).
Revert "[clang-cl] Accept `#pragma warning(disable : N)` for some N"
Sep 29 2021, 6:50 PM
akhuang added a comment to D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N.

Seems like there are also errors in chrome builds and the llvm compiler-rt build, will just revert it for now --

Sep 29 2021, 6:47 PM · Restricted Project, Restricted Project
akhuang added inline comments to D110670: [Sema] Allow comparisons between different ms ptr size address space types..
Sep 29 2021, 3:12 PM · Restricted Project

Sep 28 2021

akhuang requested review of D110670: [Sema] Allow comparisons between different ms ptr size address space types..
Sep 28 2021, 5:29 PM · Restricted Project
akhuang added inline comments to D110450: [LLD] Remove global state in lld/COFF.
Sep 28 2021, 3:05 PM · Restricted Project

Sep 24 2021

akhuang added reviewers for D110450: [LLD] Remove global state in lld/COFF: aganea, MaskRay.
Sep 24 2021, 5:09 PM · Restricted Project
akhuang requested review of D110450: [LLD] Remove global state in lld/COFF.
Sep 24 2021, 3:47 PM · Restricted Project

Sep 20 2021

akhuang committed rG6e994a833e8b: [lld] Remove timers.ll because inconsistent timers behavior causes the test to… (authored by akhuang).
[lld] Remove timers.ll because inconsistent timers behavior causes the test to…
Sep 20 2021, 9:57 AM
akhuang added a comment to D109904: [lld] Add test to check for timer output.

Hm, a timer won't print out if the time is 0, and it seems like it's inconsistent when a timer will have no time on it.. I think I'll just remove the test for now.

Sep 20 2021, 9:53 AM · Restricted Project

Sep 17 2021

akhuang committed rG724a1dff8a8e: [lld] Fix small error in previous commit (authored by akhuang).
[lld] Fix small error in previous commit
Sep 17 2021, 5:47 PM
akhuang added a reverting change for rGa2fd05ada903: Temporarily revert "[LLD] Remove global state in lld/COFF" and "[lld] Add test…: rG6f7483b1ece4: Reland "[LLD] Remove global state in lld/COFF" after fixing asan and msan test….
Sep 17 2021, 5:19 PM
akhuang committed rG6f7483b1ece4: Reland "[LLD] Remove global state in lld/COFF" after fixing asan and msan test… (authored by akhuang).
Reland "[LLD] Remove global state in lld/COFF" after fixing asan and msan test…
Sep 17 2021, 5:19 PM

Sep 16 2021

akhuang added a reverting change for rGb4fa71eed34d: [LLD] Remove global state in lld/COFF: rGa2fd05ada903: Temporarily revert "[LLD] Remove global state in lld/COFF" and "[lld] Add test….
Sep 16 2021, 11:59 AM
akhuang added a reverting change for D109634: [LLD] Remove global state in lld/COFF: rGa2fd05ada903: Temporarily revert "[LLD] Remove global state in lld/COFF" and "[lld] Add test….
Sep 16 2021, 11:59 AM · Restricted Project
akhuang added a reverting change for D109904: [lld] Add test to check for timer output: rGa2fd05ada903: Temporarily revert "[LLD] Remove global state in lld/COFF" and "[lld] Add test….
Sep 16 2021, 11:59 AM · Restricted Project
akhuang added a reverting change for rGe03c7e367adb: [lld] Add test to check for timer output: rGa2fd05ada903: Temporarily revert "[LLD] Remove global state in lld/COFF" and "[lld] Add test….
Sep 16 2021, 11:59 AM
akhuang committed rGa2fd05ada903: Temporarily revert "[LLD] Remove global state in lld/COFF" and "[lld] Add test… (authored by akhuang).
Temporarily revert "[LLD] Remove global state in lld/COFF" and "[lld] Add test…
Sep 16 2021, 11:59 AM
akhuang committed rGe03c7e367adb: [lld] Add test to check for timer output (authored by akhuang).
[lld] Add test to check for timer output
Sep 16 2021, 11:37 AM
akhuang closed D109904: [lld] Add test to check for timer output.
Sep 16 2021, 11:37 AM · Restricted Project
akhuang requested review of D109904: [lld] Add test to check for timer output.
Sep 16 2021, 11:23 AM · Restricted Project
akhuang committed rGb4fa71eed34d: [LLD] Remove global state in lld/COFF (authored by akhuang).
[LLD] Remove global state in lld/COFF
Sep 16 2021, 11:03 AM
akhuang closed D109634: [LLD] Remove global state in lld/COFF.
Sep 16 2021, 11:02 AM · Restricted Project

Sep 14 2021

akhuang updated the diff for D109634: [LLD] Remove global state in lld/COFF.

move all timers into COFFLinkerContext class,
modify Timer class and print function so it no longer uses a static root timer

Sep 14 2021, 6:36 PM · Restricted Project
akhuang added inline comments to D109634: [LLD] Remove global state in lld/COFF.
Sep 14 2021, 6:32 PM · Restricted Project
akhuang added a comment to D108850: [LLD] Remove global state in lldCommon.

seems like everyone's happy with the direction and there are no more comments -- perhaps this is good to be committed now?

Sep 14 2021, 2:31 PM · Restricted Project, Restricted Project, lld
akhuang updated the diff for D109634: [LLD] Remove global state in lld/COFF.

move a timer to local scope instead of class member

Sep 14 2021, 11:51 AM · Restricted Project
akhuang updated the diff for D109634: [LLD] Remove global state in lld/COFF.

Move Timers into local/class scope; modify the Timer class so the root timer
isn't a static class member.

Sep 14 2021, 10:26 AM · Restricted Project

Sep 10 2021

akhuang updated the diff for D109634: [LLD] Remove global state in lld/COFF.

address comments, move order of COFFLinkerContext in argument lists

Sep 10 2021, 4:43 PM · Restricted Project
akhuang added inline comments to D109634: [LLD] Remove global state in lld/COFF.
Sep 10 2021, 4:42 PM · Restricted Project
akhuang requested review of D109634: [LLD] Remove global state in lld/COFF.
Sep 10 2021, 3:04 PM · Restricted Project

Sep 3 2021

akhuang added a comment to D109217: [llvm-dwarfdump] Fix unsigned overflow when calculating stats.

no other comments, thanks for the fix!

Sep 3 2021, 10:39 AM · Restricted Project, debug-info

Sep 1 2021

akhuang added a comment to D108850: [LLD] Remove global state in lldCommon.

This is cool, I was also looking at refactoring out some of the globals in lldCOFF (for now just trying to move some globals into existing classes and passing the classes around). Looks good to me, although I'm not very familiar with structuring code in this way / making things work with threads.

Sep 1 2021, 3:27 PM · Restricted Project, Restricted Project, lld

Aug 19 2021

akhuang added a comment to D108201: [AggressiveInstCombine] Add logical shift right instr to `TruncInstCombine` DAG.

looks like this caused a crash in some chromium code

Aug 19 2021, 4:20 PM · Restricted Project

Aug 13 2021

akhuang updated the diff for D107921: [Modules] Fix bug where header resolution in modules doesn't work when compiling with relative paths..

undo previous change

Aug 13 2021, 1:30 PM · Restricted Project

Aug 12 2021

akhuang updated the diff for D107921: [Modules] Fix bug where header resolution in modules doesn't work when compiling with relative paths..

add case for include_nexts; I don't entirely understand this part of the code so not sure if it's what we want, but it seems to make building with -no-canonical-prefixes happier

Aug 12 2021, 5:24 PM · Restricted Project
akhuang added a reverting change for rG6de1dbbd09c1: [InstCombine] factorize min/max intrinsic ops with common operand: rG427520a8fa09: Revert "[InstCombine] factorize min/max intrinsic ops with common operand".
Aug 12 2021, 12:37 PM
akhuang committed rG427520a8fa09: Revert "[InstCombine] factorize min/max intrinsic ops with common operand" (authored by akhuang).
Revert "[InstCombine] factorize min/max intrinsic ops with common operand"
Aug 12 2021, 12:36 PM
akhuang added a comment to rG6de1dbbd09c1: [InstCombine] factorize min/max intrinsic ops with common operand.

Looks like this is causing compiler crashes in chromium - currently making a reduced test case

Aug 12 2021, 12:30 PM

Aug 11 2021

akhuang added reviewers for D107921: [Modules] Fix bug where header resolution in modules doesn't work when compiling with relative paths.: rsmith, rnk.
Aug 11 2021, 12:31 PM · Restricted Project
akhuang requested review of D107921: [Modules] Fix bug where header resolution in modules doesn't work when compiling with relative paths..
Aug 11 2021, 11:24 AM · Restricted Project

Jul 26 2021

akhuang committed rG1a3bf2953a92: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor)… (authored by akhuang).
[DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor)…
Jul 26 2021, 5:25 PM
akhuang closed D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled.
Jul 26 2021, 5:25 PM · debug-info, Restricted Project, Restricted Project
akhuang added a comment to D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled.

yep, should be good now - I'll commit it soon

Jul 26 2021, 4:30 PM · debug-info, Restricted Project, Restricted Project

Jul 22 2021

akhuang committed rG3e2ad26b08a2: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing (authored by akhuang).
[DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing
Jul 22 2021, 2:53 PM
akhuang closed D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing.
Jul 22 2021, 2:53 PM · Restricted Project
akhuang updated subscribers of D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing.

Looks alright to me. (bit awkward having a documented cc1 option - since the cc1 options aren't meant to be user facing - hadn't really thought about/noticed that when reviewing the documentation originally in D95911)

Oh, true. Since we're making ctor homing default maybe I should just make them user facing flags.

I have mixed feelings - on the one hand, yeah, we're changing the behavior of -fno-standalone-debug and giving people a tool to undo that change if it's problematic is good (less chance we have to churn through reverting the change, fixing, reapplying, etc, if there's a way to opt-out, at least in the short term). But equally I don't want to proliferate various rather arbitrary buckets of debug info type homing - I really want to encourage people to think of it as a fairly all-or-nothing situation, because I don't think there's a good way to explain/improve/modify/use the feature if it's "whatever is good enough for my use case". Especially now that there's the standalone_debug attribute that can be used to fix particular use cases where a type is needed across a -g0 boundary.

So... eh. Could go either way - your call, really. Though if we make it a full driver option, maybe a caveat that we may remove the functionality in the future (but that'll mean probably having to leave the flag in as a no-op/with some deprecation warning for some time after removing the functionality).

Jul 22 2021, 2:12 PM · Restricted Project
akhuang added a comment to D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing.

Looks alright to me. (bit awkward having a documented cc1 option - since the cc1 options aren't meant to be user facing - hadn't really thought about/noticed that when reviewing the documentation originally in D95911)

Jul 22 2021, 12:56 PM · Restricted Project
akhuang updated the diff for D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing.

add actual flag

Jul 22 2021, 12:29 PM · Restricted Project
akhuang added a comment to D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled.

David wrote:

think what I'm missing here: If -fno-standalone-debug is already in use/the default and is causing missing types because parts of the program are bulit without debug info, then I'm not sure what the rationale is for slicing -fstandalone-debug into a "has ctor homing" and a "doesn't have ctor homing" strategy. The same general design philosophy applies - that in both cases (about 4 cases in total now: types that aren't required to be complete, explicitly instantiated templates, vtables, and now ctor homing) the whole program must be compiled with debug info enabled for these DWARF size optimizations to be sound.

It's a matter of degree:

  • Some types go missing, but due to the dllimport mechanism mentioned, all the important ones are retained,
  • Switching to -fstandalone-debug increases the amount of DWARF by ~50% in experiments I've run, which for a {single-file-recompile, link, load-into-debugger} round trip will translate to an almost 50% increase in round-trip-time. (What with DWARF being the major part of linking and debugger-loading).

Thus the status quo (-fno-standalone-debug and closed-source libraries) hasn't been conceptually sounds, but it's given a "good enough" debugging experience without major round-trip-time penalty.

Jul 22 2021, 12:25 PM · debug-info, Restricted Project, Restricted Project
akhuang requested review of D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing.
Jul 22 2021, 12:23 PM · Restricted Project
akhuang updated the diff for D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled.

Remove fno-use-ctor-homing flag

Jul 22 2021, 12:05 PM · debug-info, Restricted Project, Restricted Project
akhuang added inline comments to D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled.
Jul 22 2021, 12:04 PM · debug-info, Restricted Project, Restricted Project

Jul 21 2021

akhuang added a comment to D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled.

Realized it's probably a good idea to add an opt out flag (counterpart to fuse-ctor-homing). Also, maybe in a separate patch, maybe should make these clang flags instead of cc1 flags-

Jul 21 2021, 3:50 PM · debug-info, Restricted Project, Restricted Project
akhuang updated the diff for D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled.

Add an opt out flag: fno-use-ctor-homing

Jul 21 2021, 3:27 PM · debug-info, Restricted Project, Restricted Project

Jul 19 2021

akhuang added a reverting change for rGc305557acdaa: [llvm][sve] Lowering for VLS truncating stores: rGfd972bb9fd78: Revert "[llvm][sve] Lowering for VLS truncating stores" because it.
Jul 19 2021, 11:04 AM
akhuang committed rGfd972bb9fd78: Revert "[llvm][sve] Lowering for VLS truncating stores" because it (authored by akhuang).
Revert "[llvm][sve] Lowering for VLS truncating stores" because it
Jul 19 2021, 11:03 AM
akhuang added a reverting change for D104471: [llvm][sve] Lowering for VLS truncating stores: rGfd972bb9fd78: Revert "[llvm][sve] Lowering for VLS truncating stores" because it.
Jul 19 2021, 11:03 AM · Restricted Project
akhuang added a comment to D104471: [llvm][sve] Lowering for VLS truncating stores.

will revert this for now

Jul 19 2021, 10:40 AM · Restricted Project
akhuang added a comment to D104471: [llvm][sve] Lowering for VLS truncating stores.

Seems like this change caused a seg fault in chrome android PGO builds.

Jul 19 2021, 9:51 AM · Restricted Project

Jul 15 2021

akhuang added a reviewer for D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled: dblaikie.
Jul 15 2021, 11:06 AM · debug-info, Restricted Project, Restricted Project
akhuang added a project to D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled: debug-info.
Jul 15 2021, 11:00 AM · debug-info, Restricted Project, Restricted Project
akhuang requested review of D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled.
Jul 15 2021, 11:00 AM · debug-info, Restricted Project, Restricted Project

Jun 9 2021

akhuang committed rGcf11d9585afd: Fix to Windows temp file change. (authored by akhuang).
Fix to Windows temp file change.
Jun 9 2021, 4:24 PM
akhuang added inline comments to D102736: Fix tmp files being left on Windows builds..
Jun 9 2021, 4:14 PM · Restricted Project, Restricted Project

Jun 8 2021

akhuang added a comment to D102736: Fix tmp files being left on Windows builds..

yep, I'll look into it, probably sometime tomorrow--

Jun 8 2021, 5:22 PM · Restricted Project, Restricted Project
akhuang added a comment to D89353: Enable overriding `__libcpp_debug_function` invocation.

thought I'd updated this patch but apparently I hadn't--

Jun 8 2021, 2:29 PM · Restricted Project
akhuang updated the diff for D89353: Enable overriding `__libcpp_debug_function` invocation.

Remove parens from macro and add test case

Jun 8 2021, 2:28 PM · Restricted Project

Jun 4 2021

akhuang closed D102736: Fix tmp files being left on Windows builds..

Committed in 9d070b2f4889887f9ce497592ef01df7b9601a1c

Jun 4 2021, 1:52 PM · Restricted Project, Restricted Project

Jun 2 2021

akhuang added a reverting change for rG20797b129f84: Revert "Fix tmp files being left on Windows builds." for now;: rG9d070b2f4889: Recommit "Fix tmp files being left on Windows builds." with a fix for.
Jun 2 2021, 4:51 PM
akhuang committed rG9d070b2f4889: Recommit "Fix tmp files being left on Windows builds." with a fix for (authored by akhuang).
Recommit "Fix tmp files being left on Windows builds." with a fix for
Jun 2 2021, 4:51 PM

Jun 1 2021

akhuang added a reverting change for rG7daa18215905: Fix tmp files being left on Windows builds.: rG20797b129f84: Revert "Fix tmp files being left on Windows builds." for now;.
Jun 1 2021, 7:52 PM
akhuang committed rG20797b129f84: Revert "Fix tmp files being left on Windows builds." for now; (authored by akhuang).
Revert "Fix tmp files being left on Windows builds." for now;
Jun 1 2021, 7:52 PM
akhuang added a reverting change for D102876: Fix tmp files being left on Windows builds.: rG20797b129f84: Revert "Fix tmp files being left on Windows builds." for now;.
Jun 1 2021, 7:52 PM · Restricted Project, Restricted Project