Page MenuHomePhabricator

akhuang (Amy Huang)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 7 2019, 2:10 PM (45 w, 2 d)

Recent Activity

Thu, Jan 16

akhuang added a comment to D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue.

@akhuang can you confirm this fixes your issue? I've tested locally and it works fine on my side.

Thu, Jan 16, 2:24 PM · Restricted Project

Wed, Jan 15

akhuang committed rG44560762c62d: Revert "Further implement CWG 2292" (authored by akhuang).
Revert "Further implement CWG 2292"
Wed, Jan 15, 3:48 PM
akhuang added a reverting change for rGee0f1f1edc3e: Further implement CWG 2292: rG44560762c62d: Revert "Further implement CWG 2292".
Wed, Jan 15, 3:48 PM
akhuang added a comment to rGee0f1f1edc3e: Further implement CWG 2292.

reverted in 44560762c62d72a103bdceff49ffa70451efd5f8

Wed, Jan 15, 3:48 PM
akhuang added a comment to rGee0f1f1edc3e: Further implement CWG 2292.

This caused a new error in chromium code which I think is valid.
Reduced repro below:

$ cat t.cpp
namespace p {
class B {
  ~B();
};
}
class A {
public:
  using B = p::B;
};
A::B::~B() = default;
$ clang t.cpp
t.cpp:10:7: error: destructor cannot be declared using a type alias 'A::B' (aka 'p::B') of the class name
A::B::~B() = default;
Wed, Jan 15, 3:34 PM
akhuang committed rG3d210ed3d188: Revert "Allow system header to provide their own implementation of some builtin" (authored by akhuang).
Revert "Allow system header to provide their own implementation of some builtin"
Wed, Jan 15, 3:05 PM
akhuang added a reverting change for rG921f871ac438: Allow system header to provide their own implementation of some builtin: rG3d210ed3d188: Revert "Allow system header to provide their own implementation of some builtin".
Wed, Jan 15, 3:05 PM
akhuang added a comment to D71082: Allow system header to provide their own implementation of some builtin.

Reverted in 3d210ed3d1880c615776b07d1916edb400c245a6

Wed, Jan 15, 3:05 PM · Restricted Project
akhuang added a comment to D71082: Allow system header to provide their own implementation of some builtin.

This caused a linker error in chromium:

ld.lld: error: undefined symbol: __warn_memset_zero_len

Apparently now that the glibc memset is being used, __warn_memset_zero_len gets called from libc++ code (https://github.com/llvm/llvm-project/blob/b72a8c65e4e34779b6bc9e466203f553f5294486/libcxx/include/__bit_reference#L371).

Wed, Jan 15, 2:37 PM · Restricted Project

Tue, Jan 14

akhuang committed rG651128f55722: [DebugInfo] Add option to clang to limit debug info that is emitted for classes. (authored by akhuang).
[DebugInfo] Add option to clang to limit debug info that is emitted for classes.
Tue, Jan 14, 12:50 PM
akhuang closed D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes..
Tue, Jan 14, 12:50 PM · debug-info, Restricted Project

Mon, Jan 13

akhuang updated the diff for D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes..

-Remove redundant test case
-Committed refactoring part

Mon, Jan 13, 4:22 PM · debug-info, Restricted Project
akhuang reopened D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes..
Mon, Jan 13, 4:22 PM · debug-info, Restricted Project
akhuang added a comment to D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes..

Committed debug info kind refactoring bit in fe7cda2e.

Mon, Jan 13, 4:13 PM · debug-info, Restricted Project
akhuang committed rG53539bb032d1: [DebugInfo] Add another level to DebugInfoKind called Constructor (authored by akhuang).
[DebugInfo] Add another level to DebugInfoKind called Constructor
Mon, Jan 13, 4:04 PM
akhuang closed D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes..
Mon, Jan 13, 4:03 PM · debug-info, Restricted Project
akhuang committed rG328e0f3dcac5: Revert "[DWARF5][DebugInfo]: Added support for DebugInfo generation for auto… (authored by akhuang).
Revert "[DWARF5][DebugInfo]: Added support for DebugInfo generation for auto…
Mon, Jan 13, 2:02 PM
akhuang added a reverting change for rGc958639098a8: [DWARF5][DebugInfo]: Added support for DebugInfo generation for auto return…: rG328e0f3dcac5: Revert "[DWARF5][DebugInfo]: Added support for DebugInfo generation for auto….
Mon, Jan 13, 2:02 PM
akhuang added a comment to D70524: Support DebugInfo generation for auto return type for C++ functions..

Looks like the first commit c958639098a8 is also causing a crash in chromium code, so I will revert that as well.
I got a reduced test case:

Mon, Jan 13, 2:02 PM · debug-info, Restricted Project, Restricted Project

Fri, Jan 10

akhuang updated the diff for D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes..

Address comments

  • Removed driver option
  • Simplified test cases
  • Changed name of limited debug info from isFullDebug to hasReducedDebugInfo, which is maybe

slightly less misleading

Fri, Jan 10, 12:05 PM · debug-info, Restricted Project
akhuang added inline comments to D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes..
Fri, Jan 10, 11:36 AM · debug-info, Restricted Project
akhuang added inline comments to D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes..
Fri, Jan 10, 10:12 AM · debug-info, Restricted Project

Thu, Jan 9

akhuang added a comment to D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes..

What's the plan for this? Is it still in an experimental stage, with the intent to investigate the types that are no longer emitted unedr the flag & explain why they're missing (& either have a justification for why that's acceptable, or work on additional heuristics to address the gaps?)?

If so, I'd probably rather this not be a full driver flag - if it's a reliable way to reduce debug info size (like the existing heuristics under -fstandalone-debug*) it should be rolled into -fno-standalone-debug behavior, and if it's not fully fleshed out yet, I think an -Xclang flag would be more suitable for the experimental phase.

Pretty much, I think the plan is to investigate further and maybe have more people try it. The -Xclang flag seems reasonable. Do you have thoughts on whether the added DebugInfoKind level makes sense?

Thu, Jan 9, 1:22 PM · debug-info, Restricted Project

Wed, Jan 8

akhuang created D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes..
Wed, Jan 8, 4:51 PM · debug-info, Restricted Project

Dec 18 2019

akhuang committed rGe3fa4604076d: Change triple in test case to not include triples the test shouldn't pass. This… (authored by akhuang).
Change triple in test case to not include triples the test shouldn't pass. This…
Dec 18 2019, 1:22 PM
akhuang committed rGa85f5efd9597: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr. (authored by akhuang).
Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.
Dec 18 2019, 10:45 AM
akhuang closed D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr..
Dec 18 2019, 10:45 AM · Restricted Project
akhuang committed rG7513e662d3c5: Address comments (authored by akhuang).
Address comments
Dec 18 2019, 9:03 AM
akhuang committed rGa999b9dc69f8: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr. (authored by akhuang).
Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.
Dec 18 2019, 9:03 AM

Dec 16 2019

akhuang added inline comments to D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr..
Dec 16 2019, 1:05 PM · Restricted Project
akhuang updated the diff for D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr..
  • Added docs for ptr32, ptr64, sptr, utr
  • Moved some functions into ASTContext
  • and addressed other comments
Dec 16 2019, 1:05 PM · Restricted Project

Dec 5 2019

akhuang accepted D71098: Handle two corner cases in creduce-clang-crash.py.

lgtm

Dec 5 2019, 4:23 PM · Restricted Project
akhuang committed rG23e63a906d03: Use diff -b on zlib tests so they pass on Windows (authored by akhuang).
Use diff -b on zlib tests so they pass on Windows
Dec 5 2019, 11:40 AM
akhuang closed D71036: Use diff -b on zlib tests so they pass on Windows.
Dec 5 2019, 11:40 AM · Restricted Project
akhuang abandoned D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr..

I split this into two reviews-- the backend part is landed and the frontend part is at https://reviews.llvm.org/D71039.

Dec 5 2019, 11:21 AM · Restricted Project, Restricted Project
akhuang added a reviewer for D71036: Use diff -b on zlib tests so they pass on Windows: rnk.
Dec 5 2019, 11:11 AM · Restricted Project

Dec 4 2019

akhuang created D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr..
Dec 4 2019, 4:50 PM · Restricted Project
akhuang created D71036: Use diff -b on zlib tests so they pass on Windows.
Dec 4 2019, 2:57 PM · Restricted Project
akhuang committed rGd6cbc9528d46: Add --strip-trailing-cr to compression tests so they pass on Windows. (authored by akhuang).
Add --strip-trailing-cr to compression tests so they pass on Windows.
Dec 4 2019, 1:24 PM
akhuang committed rG9e978bb01cea: Add support for lowering 32-bit/64-bit pointers (authored by akhuang).
Add support for lowering 32-bit/64-bit pointers
Dec 4 2019, 11:40 AM
akhuang closed D69639: Add support for lowering 32-bit/64-bit pointers.
Dec 4 2019, 11:40 AM · Restricted Project

Dec 3 2019

akhuang updated the diff for D69639: Add support for lowering 32-bit/64-bit pointers.

Address comment

Dec 3 2019, 3:05 PM · Restricted Project
akhuang added a comment to D69639: Add support for lowering 32-bit/64-bit pointers.

ping!

Dec 3 2019, 2:27 PM · Restricted Project

Nov 13 2019

akhuang committed rG840845a1eeae: Fix merge issues in b288f7d6bb8fdd21d27ba755302db194c181fdaf (authored by akhuang).
Fix merge issues in b288f7d6bb8fdd21d27ba755302db194c181fdaf
Nov 13 2019, 2:22 PM
akhuang added a comment to D69536: Recommit "Add a heap alloc site marker field to the ExtraInfo in MachineInstrs".

I get a build error with this patch (b288f7d6bb8fdd21d27ba755302db194c181fdaf) It looks like what got committed is a little different from above. The committed patch partially changed updateCallSiteInfo with moveCallSiteInfo

/local/mnt/workspace/tmp/tipcheck/llvm-project/llvm/lib/CodeGen/MachineFunction.cpp:825:23: error: 
      out-of-line definition of 'moveCallSiteInfo' does not match any declaration in
      'llvm::MachineFunction'; did you mean 'updateCallSiteInfo'?
void MachineFunction::moveCallSiteInfo(const MachineInstr *Old,
                      ^~~~~~~~~~~~~~~~
                      updateCallSiteInfo
Nov 13 2019, 1:56 PM · Restricted Project
akhuang abandoned D70102: Try to make rG742043047c973999eac7734e53f7872973933f24 not break the ABI for release/9.x.
Nov 13 2019, 1:47 PM · Restricted Project
akhuang added inline comments to D69639: Add support for lowering 32-bit/64-bit pointers.
Nov 13 2019, 11:24 AM · Restricted Project
akhuang committed rGb288f7d6bb8f: [codeview] Fix for PR43479 (authored by akhuang).
[codeview] Fix for PR43479
Nov 13 2019, 10:34 AM

Nov 11 2019

akhuang created D70102: Try to make rG742043047c973999eac7734e53f7872973933f24 not break the ABI for release/9.x.
Nov 11 2019, 4:36 PM · Restricted Project

Nov 7 2019

akhuang accepted D69924: [codeview] Reference types in type parent scopes.

lgtm thanks!

Nov 7 2019, 1:47 PM · Restricted Project

Nov 5 2019

akhuang committed rGa078c77d7208: [MIR] Add MIR parsing for heap alloc site instruction markers (authored by akhuang).
[MIR] Add MIR parsing for heap alloc site instruction markers
Nov 5 2019, 1:06 PM
akhuang closed D69864: [MIR] Add MIR parsing for heap alloc site instruction markers.
Nov 5 2019, 1:06 PM · Restricted Project
akhuang updated the diff for D69864: [MIR] Add MIR parsing for heap alloc site instruction markers.

formatting

Nov 5 2019, 11:34 AM · Restricted Project
akhuang created D69864: [MIR] Add MIR parsing for heap alloc site instruction markers.
Nov 5 2019, 11:34 AM · Restricted Project

Nov 4 2019

akhuang updated the diff for D69639: Add support for lowering 32-bit/64-bit pointers.

-Edit logic for when to do address space casts to allow for casting
between ptr32/ptr64 and arbitrary other address spaces; add tests
-Remove unnecessary stuff from test

Nov 4 2019, 11:36 AM · Restricted Project
akhuang added inline comments to D69639: Add support for lowering 32-bit/64-bit pointers.
Nov 4 2019, 11:36 AM · Restricted Project
akhuang committed rGab76cfdd200d: Recommit "[CodeView] Add option to disable inline line tables." (authored by akhuang).
Recommit "[CodeView] Add option to disable inline line tables."
Nov 4 2019, 9:22 AM
akhuang added a reverting change for rG004ed2b0d1b8: Revert "[CodeView] Add option to disable inline line tables." because it breaks…: rGab76cfdd200d: Recommit "[CodeView] Add option to disable inline line tables.".
Nov 4 2019, 9:22 AM

Oct 31 2019

akhuang committed rGfdd0815eacb4: Fix initialization-order-fiasco error in "Add a heap alloc site marker field to… (authored by akhuang).
Fix initialization-order-fiasco error in "Add a heap alloc site marker field to…
Oct 31 2019, 10:58 AM

Oct 30 2019

akhuang committed rG004ed2b0d1b8: Revert "[CodeView] Add option to disable inline line tables." because it breaks… (authored by akhuang).
Revert "[CodeView] Add option to disable inline line tables." because it breaks…
Oct 30 2019, 5:42 PM
akhuang added a reverting change for rG6d0389038451: [CodeView] Add option to disable inline line tables.: rG004ed2b0d1b8: Revert "[CodeView] Add option to disable inline line tables." because it breaks….
Oct 30 2019, 5:42 PM
akhuang committed rG6d0389038451: [CodeView] Add option to disable inline line tables. (authored by akhuang).
[CodeView] Add option to disable inline line tables.
Oct 30 2019, 5:00 PM
akhuang closed D67723: [DebugInfo] Add option to disable inline line tables..
Oct 30 2019, 4:59 PM · debug-info, Restricted Project, Restricted Project
akhuang added a comment to D67723: [DebugInfo] Add option to disable inline line tables..

Seems like this is good to be committed then. And it sounds like implementing more thresholds would be useful to do in the future.

Oct 30 2019, 4:59 PM · debug-info, Restricted Project, Restricted Project
akhuang added a comment to D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr..

I split off the backend changes into a separate patch -> https://reviews.llvm.org/D69639
The issue with passing 0 for a pointer should be fixed there.

Oct 30 2019, 3:45 PM · Restricted Project, Restricted Project
akhuang created D69639: Add support for lowering 32-bit/64-bit pointers.
Oct 30 2019, 1:34 PM · Restricted Project

Oct 28 2019

akhuang committed rG742043047c97: Recommit "Add a heap alloc site marker field to the ExtraInfo in MachineInstrs" (authored by akhuang).
Recommit "Add a heap alloc site marker field to the ExtraInfo in MachineInstrs"
Oct 28 2019, 5:53 PM
akhuang closed D69536: Recommit "Add a heap alloc site marker field to the ExtraInfo in MachineInstrs".
Oct 28 2019, 5:53 PM · Restricted Project
akhuang updated the diff for D69536: Recommit "Add a heap alloc site marker field to the ExtraInfo in MachineInstrs".

Remove bogus class wrapper

Oct 28 2019, 4:01 PM · Restricted Project
akhuang added inline comments to D69536: Recommit "Add a heap alloc site marker field to the ExtraInfo in MachineInstrs".
Oct 28 2019, 4:00 PM · Restricted Project
akhuang created D69536: Recommit "Add a heap alloc site marker field to the ExtraInfo in MachineInstrs".
Oct 28 2019, 3:12 PM · Restricted Project

Oct 25 2019

akhuang committed rG64c1f6602a02: Revert "Add an instruction marker field to the ExtraInfo in MachineInstrs." (authored by akhuang).
Revert "Add an instruction marker field to the ExtraInfo in MachineInstrs."
Oct 25 2019, 12:47 PM
akhuang added a comment to D69441: Remove tests that cause llvm to run out of memory.

Actually, I think something else in the patch is causing buildbot failures so I'll just revert the whole thing for now. Thanks for looking into this--

Oct 25 2019, 12:47 PM · Restricted Project
akhuang committed rGb85b4e5a6f85: Add an instruction marker field to the ExtraInfo in MachineInstrs. (authored by akhuang).
Add an instruction marker field to the ExtraInfo in MachineInstrs.
Oct 25 2019, 9:30 AM
akhuang closed D69136: Add a heap alloc site marker field to the ExtraInfo in MachineInstrs..
Oct 25 2019, 9:29 AM · Restricted Project
akhuang updated the diff for D69136: Add a heap alloc site marker field to the ExtraInfo in MachineInstrs..

-remove unnecessary assert, rebase

Oct 25 2019, 8:43 AM · Restricted Project

Oct 24 2019

akhuang retitled D69136: Add a heap alloc site marker field to the ExtraInfo in MachineInstrs. from Add an instruction marker field to the ExtraInfo in MachineInstrs. to Add a heap alloc site marker field to the ExtraInfo in MachineInstrs..
Oct 24 2019, 4:12 PM · Restricted Project
akhuang added a comment to D69136: Add a heap alloc site marker field to the ExtraInfo in MachineInstrs..

Sounds good. I also realized that the logic for the "Should never have only a single symbol allocated out-of-line!" is wrong now. I added a parameter to the function to keep track of whether the assert should happen. Or do you think it can just be removed?

Oct 24 2019, 4:12 PM · Restricted Project
akhuang updated the diff for D69136: Add a heap alloc site marker field to the ExtraInfo in MachineInstrs..
  • Add unit tests for MachineInstr extra info
  • Fix logic for the assert in setExtraInfo
Oct 24 2019, 4:12 PM · Restricted Project

Oct 21 2019

akhuang updated the diff for D69136: Add a heap alloc site marker field to the ExtraInfo in MachineInstrs..

Clang format

Oct 21 2019, 10:18 AM · Restricted Project
akhuang updated the diff for D69136: Add a heap alloc site marker field to the ExtraInfo in MachineInstrs..

-Moved the logic for editing extra info for machine instrs into a separate function.
-Moved label creation code into CodeViewDebug.
-Remove now unused heapallocsite vector from MachineFunction.

Oct 21 2019, 10:16 AM · Restricted Project

Oct 17 2019

akhuang created D69136: Add a heap alloc site marker field to the ExtraInfo in MachineInstrs..
Oct 17 2019, 2:00 PM · Restricted Project

Oct 16 2019

akhuang added a comment to D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr..

@DarkShadow44 Thanks for finding this bug! I haven't had time to look at this for a while but will start working on it soon.

Oct 16 2019, 5:01 PM · Restricted Project, Restricted Project
akhuang accepted D69068: [codeview] Workaround for PR43479, don't re-emit instr labels.

Thanks; I also tried compiling something with SLH the other day and I think it already doesn't do tail duplication there.

Oct 16 2019, 1:27 PM · Restricted Project

Oct 15 2019

akhuang updated the diff for D67723: [DebugInfo] Add option to disable inline line tables..

Address comment about bad decrementing iterator.

Oct 15 2019, 1:19 PM · debug-info, Restricted Project, Restricted Project

Oct 14 2019

akhuang updated the diff for D67723: [DebugInfo] Add option to disable inline line tables..
  • Fixes for DbgInfoIntrinsic type and change test cmd

Reverted the line 0 change - I wasn't sure if it would be an issue since
the debugger doesn't step through those lines.

Oct 14 2019, 2:51 PM · debug-info, Restricted Project, Restricted Project
akhuang updated the diff for D67723: [DebugInfo] Add option to disable inline line tables..
  • Set inlined locations to line 0
  • Fix to remove all debug info intrinsics
Oct 14 2019, 11:58 AM · debug-info, Restricted Project, Restricted Project

Oct 11 2019

akhuang updated the diff for D67723: [DebugInfo] Add option to disable inline line tables..
  • Set location to line 0 with getMergedLocation
Oct 11 2019, 4:51 PM · debug-info, Restricted Project, Restricted Project
akhuang updated the diff for D67723: [DebugInfo] Add option to disable inline line tables..

Fix code so that -gno-inline-line-tables works when not codeview

Oct 11 2019, 3:29 PM · debug-info, Restricted Project, Restricted Project
akhuang retitled D67723: [DebugInfo] Add option to disable inline line tables. from [CodeView] Add option to disable inline line tables. to [DebugInfo] Add option to disable inline line tables..
Oct 11 2019, 3:29 PM · debug-info, Restricted Project, Restricted Project
akhuang updated the diff for D67723: [DebugInfo] Add option to disable inline line tables..
  • Remove extra ifs.
Oct 11 2019, 2:59 PM · debug-info, Restricted Project, Restricted Project
akhuang updated the diff for D67723: [DebugInfo] Add option to disable inline line tables..

-Remove intrinsics debug info
-Add inliner test
-Add to function attribute description

Oct 11 2019, 2:31 PM · debug-info, Restricted Project, Restricted Project

Oct 10 2019

akhuang committed rGc9428a04fc18: Change test case so that it accepts backslashes in file path, in the case that… (authored by akhuang).
Change test case so that it accepts backslashes in file path, in the case that…
Oct 10 2019, 4:36 PM
akhuang committed rL374473: Change test case so that it accepts backslashes in file path, in the case that….
Change test case so that it accepts backslashes in file path, in the case that…
Oct 10 2019, 4:35 PM

Oct 9 2019

akhuang accepted D68747: [codeview] Try to avoid emitting .cv_loc with line zero.

lgtm-

Oct 9 2019, 5:54 PM · Restricted Project

Oct 7 2019

akhuang committed rG6bdfe3aeba8b: Fix for expanding __pragmas in macro arguments (authored by akhuang).
Fix for expanding __pragmas in macro arguments
Oct 7 2019, 10:18 PM
akhuang committed rL373950: Fix for expanding __pragmas in macro arguments.
Fix for expanding __pragmas in macro arguments
Oct 7 2019, 10:18 PM
akhuang closed D68114: Fix for expanding __pragmas in macro arguments.
Oct 7 2019, 10:18 PM · Restricted Project, Restricted Project

Oct 4 2019

akhuang updated the diff for D68114: Fix for expanding __pragmas in macro arguments.
  • move TokenCollector out of function
Oct 4 2019, 11:22 AM · Restricted Project, Restricted Project

Sep 30 2019

akhuang updated the summary of D68114: Fix for expanding __pragmas in macro arguments.
Sep 30 2019, 11:27 AM · Restricted Project, Restricted Project