- User Since
- Mar 7 2019, 2:10 PM (109 w, 2 d)
Wed, Apr 7
think this looks good overall; maybe it should also have an IR to codeview test?
Tue, Apr 6
I've updated the ./libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp test so that it runs with constructor homing enabled. One of the cases in the test was already failing, but everything else seems to work. (It only passes if it's run with a version clang that includes my __attribute__((standalone_debug)) change, though).
Update a test case to test the use of this attribute.
Mon, Apr 5
also just confirming that this fixes the issue we were seeing in Chrome
Fri, Apr 2
In Chrome we noticed that plugin flags are not being roundtripped (and build fails with error: Generated arguments do not match in round-trip):
Thu, Apr 1
Wed, Mar 31
Tue, Mar 30
Mon, Mar 29
Gonna revert this for now--
Mon, Mar 22
Hmm - is that type used in a way that invokes Undefined Behavior? Or is this a gap/bug in the ctor homing? I thought there was already a special case for constexpr ctors that opted them out of ctor homing.
Fri, Mar 19
Wed, Mar 17
Change macro name to LIBCPP_STANDALONE_DEBUG
Tue, Mar 16
Mon, Mar 15
add CHECK line to test
Fri, Mar 12
add allowInC to attribute
update test case
Mar 11 2021
@EricWF, comments on using this attribute in libc++ vs fixing the code otherwise?
Mar 2 2021
I think they're all singular types, like __hash_node. Actually, __tree_node might not be problematic.
Mar 1 2021
Feb 26 2021
-Add more test cases and semantics tests
Feb 25 2021
-Add LangOpts[CPlusPlus] to the attribute
-Maybe change the attribute to also override required complete types and change name to standalone_debug
@ldionne Do you think it'd be reasonable to add this debug info attribute to some types in libc++? (For types that have constructors but don't call them; some previous discussion in https://reviews.llvm.org/D90719).
Feb 24 2021
Feb 12 2021
I'm not entirely sure why the buildbots are failing - I think I'll just disable the test everywhere for now.
Feb 5 2021
Feb 4 2021
Add to comment
thanks for helping / reviewing!
fix some typos
Feb 3 2021
Sounds good, I added the substitution to SubstituteForFlagValue, and am still calling that from the symbolizer code.
Move substitution into SubstituteForFlagValue.
Feb 2 2021
I ended up not moving things into SubstituteForFlagValue because there are apparently other flags that can contain things like '%p' that shouldn't be substituted.
Use %env_tools_opt in test case, change to %d for consistency
Feb 1 2021
I think we should handle symbolizer path next to RegisterIncludeFlags in a similar way.
Having that we have %b we should not add @BINARY_DIR with a same meaning.
%b is not quite the same, though, it's just the name of the binary without the path. And looks like the include flags are handled differently from things like the symbolizer_path flag. We could use a similar naming scheme, like %d or something?
Jan 28 2021
Fix test / string code after test failures
Jan 27 2021
make function return lambda string, and add test for lambda in function parameters
Jan 26 2021
Avoid using getLambdaId function
change to function returning a number, fill in ItaniumMangle function
Jan 25 2021
Jan 22 2021
-add to comment
-Add externally visible lambda to test case
-change string len to use ARRAY_SIZE
-move test to sanitizer_common
Jan 21 2021
Jan 20 2021
clean up string code
Add comments describing reason for emitting types