- User Since
- Mar 7 2019, 2:10 PM (84 w, 4 d)
Change findSymbolByAddress call
on the failing asan tests: I assume the symbolizer is doing the correct thing (since the native and DIA implementations do the same thing), so I think I'll just update the tests to accept the extra line. I was wondering why we don't get this line on Linux, though, so I looked at where the address is in the calloc function in assembly, and it seems to be in a different part of the function on Windows and Linux.
clean up code
Fri, Oct 16
I noticed that stack traces on Windows aren't getting printed out nicely anymore. Apparently there are often errors in the clang stack traces on windows because it can't find certain PDBs. it looks like in llvm/lib/Support/Signals.cpp we don't try to format the stack trace if the exit code is non-zero.
Wed, Oct 14
update test case and add check for dependent values
Mon, Oct 12
Fri, Oct 9
Ok, as far as I can tell, all of the asan tests are failing for the same reason-- the symbolizer now outputs an extra line for __sanitizer::BufferedStackTrace::Unwind.
#0 0x7ff6f9fa7e64 in __sanitizer::BufferedStackTrace::Unwind C:\src\llvm-project\compiler-rt\lib\sanitizer_common\sanitizer_stacktrace.h:124 #1 0x7ff6f9fa7e64 in malloc C:\src\llvm-project\compiler-rt\lib\asan\asan_malloc_win.cpp:98
Doesn't it also have function names? The asan tests will also be providing some test coverage for this.
-Add cpp source for the test binaries
-Fixed some of the lint errors (mostly adding consts), but some of the formatting ones conflict with git clang-format.
Thu, Oct 8
Update clang test for static data members, and make it test the general cases
on the windows target as well.
Wed, Oct 7
This change causes about 30 asan tests to fail, so I still have to fix those.
Tue, Sep 29
Thu, Sep 24
Add to comment for lambdas.
Wed, Sep 23
Add comments to tests, and add a test for non instantiated trivial ctor and one for lambdas.
Tue, Sep 22
Update ctor homing check, and add some test cases.
Mon, Sep 21
Sep 18 2020
Sep 16 2020
whoops, sorry for weird formatting in the previous comment.
This is causing a link error in the windows chromium build:
Sep 14 2020
Ah, yeah. I'm not really sure if there could be cases where there is no size. If there are, I guess we shouldn't make any changes here.
Sep 3 2020
Sep 2 2020
remove assert; edit test case
Sep 1 2020
ah sorry, this was relanded in b1009ee84fc0242bcebd07889306bf39d9b7170f.
Aug 25 2020
just reopening to update the diff.
Aug 24 2020
unfortunately not any thorough testing :) I just happened to notice it the last time I looked at this code
Aug 21 2020
Simplify test and add comments.
Aug 20 2020
Add unit test and comment.
Aug 19 2020
I think that makes sense.
Aug 18 2020
Aug 17 2020
Aug 14 2020
Oh no, I'll upload the file here since I'm not sure how to make the bug visible again: https://reviews.llvm.org/F12619177
Aug 13 2020
Ok, I think the actual object file diff comes from this file: https://github.com/chromium/chromium/blob/master/sandbox/linux/syscall_broker/broker_command.cc
I checked that the test fails if I only build this object file with this change.
Actually, I've looked into it more and I think that isn't the correct object file. I'm bisecting to figure out which object file change causes the test failure. Sorry about that!
Sorry, I was hoping the object file diff would be clearer. If it could be reverted in the meantime, that would be helpful. I'm not sure if I'll be able to make an actual reproducer, but I'll at least try to narrow down the object file change.
I haven't been able to make a simple reproducer, but I attached a reproducer for compiling the object file here: https://crbug.com/1114852.
Aug 12 2020
Add more extensive check that -fuse-ctor-homing only does something when -debug-info-kind=limited
Yep, just added a line to the existing ctor homing test case.
Add test case.
This is causing test failures / crashes in several chromium android tests (https://crbug.com/1114852). I'm not really familiar with this code, but it seems like after this change, there are some lines missing in the assembly.