Page MenuHomePhabricator

[Xtensa 5/10] Add Xtensa MCTargetDescr initial functionality.
Needs ReviewPublic

Authored by andreisfr on Jul 16 2019, 3:22 PM.

Details

Reviewers
jyknight
ivanbaev

Diff Detail

Event Timeline

andreisfr created this revision.Jul 16 2019, 3:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 16 2019, 3:22 PM
andreisfr updated this revision to Diff 212685.Jul 31 2019, 3:53 PM

Register names are capitalized.

andreisfr updated this revision to Diff 242212.Feb 3 2020, 3:16 PM

Patch is updated according to latest upstream version. Updated licenses, added CFI encoding for Xtensa target

andreisfr updated this revision to Diff 328697.EditedMar 5 2021, 4:45 PM

Patch is updated according to LLVM upstream version and latest Xtensa backend version.

craig.topper added inline comments.
llvm/lib/Target/Xtensa/MCTargetDesc/XtensaAsmBackend.cpp
91

This should maybe be a report_fatal_error? llvm_unreachable will be optimized out of release builds so if this is something a user can trigger the fatal error would be better.

llvm/lib/Target/Xtensa/MCTargetDesc/XtensaMCCodeEmitter.cpp
16

I think this typically comes after the includes

87

maybe fatal_error?

andreisfr updated this revision to Diff 335953.Wed, Apr 7, 4:50 PM

Correct instruction descriptions, format descriptions and instruction operands according to common style for *.td files. The llvm_unreachable is substituted to report_fatal_error.

andreisfr added inline comments.Wed, Apr 7, 4:52 PM
llvm/lib/Target/Xtensa/MCTargetDesc/XtensaAsmBackend.cpp
91

I substituted llvm_unreachable to report_fatal_error everywhere, in other patches also

llvm/lib/Target/Xtensa/MCTargetDesc/XtensaMCCodeEmitter.cpp
16

Corrected

87

Corrected