Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People andreisfr

andreisfr (Andrei Safronov)
User

Projects

User does not belong to any projects.

User Details

User Since: Jul 16 2019, 2:20 PM (218 w, 6 d)

Recent Activity
View All

Jul 27 2023

andreisfr updated the diff for D145660: [Xtensa] Codegen support for memory operations.

Added minimal support for stack operations like storeRegToStackSlot/loadRegFromStackSlot/eliminateFrameIndex functions to make possible implement different tests. Added test for load/store operations on stack.

Jul 27 2023, 1:10 AM · Restricted Project, Restricted Project

andreisfr updated the diff for D145658: [Xtensa] Initial support of the ALU operations..

Corrected according to comments. Added test with code generation for ALU operations

Jul 27 2023, 1:04 AM · Restricted Project, Restricted Project

Mar 27 2023

andreisfr added reviewers for D146957: [Xtensa] Implement support for the BranchRelaxation: jyknight, saugustine, MaskRay, arsenm, barannikov88.

Mar 27 2023, 5:00 PM · Restricted Project, Restricted Project

andreisfr added reviewers for D146956: [Xtensa] Implement branch analysis: jyknight, saugustine, MaskRay, arsenm, barannikov88.

Mar 27 2023, 4:59 PM · Restricted Project, Restricted Project

andreisfr added reviewers for D146955: [Xtensa] Implement volatile load/store.: jyknight, saugustine, MaskRay, arsenm, barannikov88.

Mar 27 2023, 4:58 PM · Restricted Project, Restricted Project

andreisfr added reviewers for D146954: [Xtensa] Add basic support for inline asm constraints: jyknight, saugustine, MaskRay, arsenm, barannikov88.

Mar 27 2023, 4:58 PM · Restricted Project, Restricted Project

andreisfr added reviewers for D146953: [Xtensa] Support for address intrinsics.: jyknight, saugustine, MaskRay, arsenm, barannikov88.

Mar 27 2023, 4:57 PM · Restricted Project, Restricted Project

andreisfr added reviewers for D146952: [Xtensa] Implement lowering BR_JT operation: jyknight, saugustine, MaskRay, arsenm, barannikov88.

Mar 27 2023, 4:57 PM · Restricted Project, Restricted Project

andreisfr added reviewers for D146951: [Xtensa] Support for variable arguments: jyknight, saugustine, MaskRay, arsenm, barannikov88.

Mar 27 2023, 4:56 PM · Restricted Project, Restricted Project

andreisfr added reviewers for D146950: [Xtensa] Implement load pseudo operations and patterns.: jyknight, saugustine, MaskRay, arsenm, barannikov88.

Mar 27 2023, 4:55 PM · Restricted Project, Restricted Project

andreisfr added reviewers for D146949: [Xtensa] Lower SHIFT PARTS and shift operations.: jyknight, saugustine, MaskRay, arsenm, barannikov88.

Mar 27 2023, 4:55 PM · Restricted Project, Restricted Project

andreisfr added reviewers for D146948: [Xtensa] Support for a variety of additional LLVM IR constructs.: jyknight, saugustine, MaskRay, arsenm, barannikov88.

Mar 27 2023, 4:54 PM · Restricted Project, Restricted Project

andreisfr added reviewers for D145668: [Xtensa] Implement lowering SELECT_CC, SETCC: jyknight, saugustine, MaskRay, arsenm, barannikov88.

Mar 27 2023, 4:53 PM · Restricted Project, Restricted Project

andreisfr added reviewers for D145667: [Xtensa] Lower stack operations.: jyknight, saugustine, MaskRay, arsenm, barannikov88.

Mar 27 2023, 4:52 PM · Restricted Project, Restricted Project

andreisfr added reviewers for D145666: [Xtensa] Implement emitPrologue/emitEpilogue: jyknight, saugustine, MaskRay, arsenm, barannikov88.

Mar 27 2023, 4:52 PM · Restricted Project, Restricted Project

andreisfr added reviewers for D145665: [Xtensa] Implement lowering ConstantPool and address operations.: jyknight, saugustine, MaskRay, arsenm, barannikov88.

Mar 27 2023, 4:51 PM · Restricted Project, Restricted Project

andreisfr added reviewers for D145664: [Xtensa] Add support of the Xtensa function calls: jyknight, saugustine, MaskRay, arsenm, barannikov88.

Mar 27 2023, 4:50 PM · Restricted Project, Restricted Project

andreisfr added reviewers for D145663: [Xtensa] Implement lowering constants.: jyknight, saugustine, MaskRay, arsenm, barannikov88.

Mar 27 2023, 4:50 PM · Restricted Project, Restricted Project

andreisfr added reviewers for D145662: [Xtensa] Implement asm representation of the Constant Pool.: jyknight, saugustine, MaskRay, arsenm, barannikov88.

Mar 27 2023, 4:44 PM · Restricted Project, Restricted Project

andreisfr added reviewers for D145661: [Xtensa] Add Constant Pool: jyknight, saugustine, MaskRay, arsenm, barannikov88.

Mar 27 2023, 4:43 PM · Restricted Project, Restricted Project

andreisfr added reviewers for D145660: [Xtensa] Codegen support for memory operations: jyknight, saugustine, arsenm, MaskRay, barannikov88.

Mar 27 2023, 4:42 PM · Restricted Project, Restricted Project

andreisfr added a comment to D145660: [Xtensa] Codegen support for memory operations.

Hi @myhsu, thank you for your comment. We have plans to add also some tests to the current functionality.

Mar 27 2023, 4:41 PM · Restricted Project, Restricted Project

andreisfr added reviewers for D145658: [Xtensa] Initial support of the ALU operations.: jyknight, saugustine, MaskRay, arsenm, barannikov88.

Mar 27 2023, 4:35 PM · Restricted Project, Restricted Project

andreisfr updated the summary of D145658: [Xtensa] Initial support of the ALU operations..

Mar 27 2023, 4:09 PM · Restricted Project, Restricted Project

andreisfr updated the summary of D145668: [Xtensa] Implement lowering SELECT_CC, SETCC.

Mar 27 2023, 3:23 PM · Restricted Project, Restricted Project

andreisfr updated the summary of D145666: [Xtensa] Implement emitPrologue/emitEpilogue.

Mar 27 2023, 3:21 PM · Restricted Project, Restricted Project

andreisfr updated the summary of D145660: [Xtensa] Codegen support for memory operations.

Mar 27 2023, 3:16 PM · Restricted Project, Restricted Project

andreisfr updated the summary of D145661: [Xtensa] Add Constant Pool.

Mar 27 2023, 12:53 PM · Restricted Project, Restricted Project

andreisfr requested review of D146957: [Xtensa] Implement support for the BranchRelaxation.

Mar 27 2023, 5:43 AM · Restricted Project, Restricted Project

andreisfr requested review of D146956: [Xtensa] Implement branch analysis.

Mar 27 2023, 5:42 AM · Restricted Project, Restricted Project

andreisfr requested review of D146955: [Xtensa] Implement volatile load/store..

Mar 27 2023, 5:41 AM · Restricted Project, Restricted Project

andreisfr requested review of D146954: [Xtensa] Add basic support for inline asm constraints.

Mar 27 2023, 5:39 AM · Restricted Project, Restricted Project

andreisfr requested review of D146953: [Xtensa] Support for address intrinsics..

Mar 27 2023, 5:39 AM · Restricted Project, Restricted Project

andreisfr requested review of D146952: [Xtensa] Implement lowering BR_JT operation.

Mar 27 2023, 5:37 AM · Restricted Project, Restricted Project

andreisfr requested review of D146951: [Xtensa] Support for variable arguments.

Mar 27 2023, 5:35 AM · Restricted Project, Restricted Project

andreisfr requested review of D146950: [Xtensa] Implement load pseudo operations and patterns..

Mar 27 2023, 5:34 AM · Restricted Project, Restricted Project

andreisfr requested review of D146949: [Xtensa] Lower SHIFT PARTS and shift operations..

Mar 27 2023, 5:28 AM · Restricted Project, Restricted Project

andreisfr requested review of D146948: [Xtensa] Support for a variety of additional LLVM IR constructs..

Mar 27 2023, 5:24 AM · Restricted Project, Restricted Project

andreisfr updated the diff for D145668: [Xtensa] Implement lowering SELECT_CC, SETCC.

Minor code formatting

Mar 27 2023, 5:08 AM · Restricted Project, Restricted Project

andreisfr updated the diff for D145667: [Xtensa] Lower stack operations..

Minor code formatting

Mar 27 2023, 5:07 AM · Restricted Project, Restricted Project

andreisfr updated the diff for D145666: [Xtensa] Implement emitPrologue/emitEpilogue.

Minor code formatting

Mar 27 2023, 5:06 AM · Restricted Project, Restricted Project

andreisfr updated the diff for D145665: [Xtensa] Implement lowering ConstantPool and address operations..

Minor code formatting

Mar 27 2023, 5:05 AM · Restricted Project, Restricted Project

andreisfr updated the diff for D145664: [Xtensa] Add support of the Xtensa function calls.

Minor code formatting

Mar 27 2023, 5:03 AM · Restricted Project, Restricted Project

andreisfr updated the diff for D145663: [Xtensa] Implement lowering constants..

Minor code formatting

Mar 27 2023, 5:03 AM · Restricted Project, Restricted Project

andreisfr updated the diff for D145662: [Xtensa] Implement asm representation of the Constant Pool..

Minor code formatting

Mar 27 2023, 5:00 AM · Restricted Project, Restricted Project

andreisfr updated the diff for D145661: [Xtensa] Add Constant Pool.

Minor code formatting.

Mar 27 2023, 4:49 AM · Restricted Project, Restricted Project

andreisfr updated the diff for D145660: [Xtensa] Codegen support for memory operations.

Minor code formatting.

Mar 27 2023, 4:43 AM · Restricted Project, Restricted Project

andreisfr updated the diff for D145658: [Xtensa] Initial support of the ALU operations..

Minor code formatting.

Mar 27 2023, 4:31 AM · Restricted Project, Restricted Project

Mar 9 2023

andreisfr requested review of D145668: [Xtensa] Implement lowering SELECT_CC, SETCC.

Mar 9 2023, 12:21 AM · Restricted Project, Restricted Project

andreisfr requested review of D145667: [Xtensa] Lower stack operations..

Mar 9 2023, 12:21 AM · Restricted Project, Restricted Project

andreisfr requested review of D145666: [Xtensa] Implement emitPrologue/emitEpilogue.

Mar 9 2023, 12:20 AM · Restricted Project, Restricted Project

andreisfr requested review of D145665: [Xtensa] Implement lowering ConstantPool and address operations..

Mar 9 2023, 12:19 AM · Restricted Project, Restricted Project

andreisfr requested review of D145664: [Xtensa] Add support of the Xtensa function calls.

Mar 9 2023, 12:18 AM · Restricted Project, Restricted Project

andreisfr requested review of D145663: [Xtensa] Implement lowering constants..

Mar 9 2023, 12:17 AM · Restricted Project, Restricted Project

andreisfr requested review of D145662: [Xtensa] Implement asm representation of the Constant Pool..

Mar 9 2023, 12:16 AM · Restricted Project, Restricted Project

andreisfr requested review of D145661: [Xtensa] Add Constant Pool.

Mar 9 2023, 12:15 AM · Restricted Project, Restricted Project

andreisfr requested review of D145660: [Xtensa] Codegen support for memory operations.

Mar 9 2023, 12:13 AM · Restricted Project, Restricted Project

andreisfr requested review of D145658: [Xtensa] Initial support of the ALU operations..

Mar 9 2023, 12:01 AM · Restricted Project, Restricted Project

Dec 26 2022

andreisfr added inline comments to D64834: [Xtensa 8/10] Add support of the Xtensa shift/load/store/move and processor control instructions..

Dec 26 2022, 6:23 AM · Restricted Project, Restricted Project

andreisfr added inline comments to D64834: [Xtensa 8/10] Add support of the Xtensa shift/load/store/move and processor control instructions..

Dec 26 2022, 5:40 AM · Restricted Project, Restricted Project

Dec 25 2022

andreisfr updated the diff for D64836: [Xtensa 10/10] Add relaxations and fixups. Add rest part of Xtensa Core Instructions..

Added fixes according to comments

Dec 25 2022, 4:38 PM · Restricted Project, Restricted Project

andreisfr added inline comments to D64835: [Xtensa 9/10] Add basic support of Xtensa disassembler..

Dec 25 2022, 4:37 PM · Restricted Project, Restricted Project

andreisfr updated the diff for D64835: [Xtensa 9/10] Add basic support of Xtensa disassembler..

Added fixes according to comments

Dec 25 2022, 4:37 PM · Restricted Project, Restricted Project

andreisfr added inline comments to D64834: [Xtensa 8/10] Add support of the Xtensa shift/load/store/move and processor control instructions..

Dec 25 2022, 4:37 PM · Restricted Project, Restricted Project

andreisfr updated the diff for D64834: [Xtensa 8/10] Add support of the Xtensa shift/load/store/move and processor control instructions..

Added fixes according to comments

Dec 25 2022, 4:35 PM · Restricted Project, Restricted Project

andreisfr added a comment to D64833: [Xtensa 7/10] Add Xtensa instruction printer..

@MaskRay , I changed Xtensa tests structure according to your suggestions, PTAL.

Dec 25 2022, 4:35 PM · Restricted Project, Restricted Project

andreisfr added inline comments to D64833: [Xtensa 7/10] Add Xtensa instruction printer..

Dec 25 2022, 4:33 PM · Restricted Project, Restricted Project

andreisfr updated the diff for D64833: [Xtensa 7/10] Add Xtensa instruction printer..

Added fixes according to comments

Dec 25 2022, 4:32 PM · Restricted Project, Restricted Project

andreisfr added inline comments to D64832: [Xtensa 6/10] Add Xtensa basic assembler parser..

Dec 25 2022, 4:32 PM · Restricted Project, Restricted Project

andreisfr updated the diff for D64832: [Xtensa 6/10] Add Xtensa basic assembler parser..

Added fixes according to comments

Dec 25 2022, 4:30 PM · Restricted Project, Restricted Project

andreisfr updated the diff for D64831: [Xtensa 5/10] Add Xtensa MCTargetDescr initial functionality..

Added fixes according to comments

Dec 25 2022, 4:30 PM · Restricted Project, Restricted Project

andreisfr added inline comments to D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description..

Dec 25 2022, 4:29 PM · Restricted Project, Restricted Project

andreisfr updated the diff for D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description..

Added fixes according to comments

Dec 25 2022, 4:29 PM · Restricted Project, Restricted Project

andreisfr added inline comments to D64829: [Xtensa 3/10] Add initial version of the Xtensa backend..

Dec 25 2022, 4:28 PM · Restricted Project, Restricted Project

andreisfr updated the diff for D64829: [Xtensa 3/10] Add initial version of the Xtensa backend..

Added fixes according to comments

Dec 25 2022, 4:23 PM · Restricted Project, Restricted Project

andreisfr updated the diff for D64827: [Xtensa 2/10] Add Xtensa ELF definitions..

Updated according to latest changes in upstream source code

Dec 25 2022, 4:20 PM · Restricted Project, Restricted Project

andreisfr updated the diff for D64826: [Xtensa 1/10] Recognize Xtensa in triple parsing code..

Updated according to latest changes in upstream source code

Dec 25 2022, 4:20 PM · Restricted Project, Restricted Project

Dec 19 2022

andreisfr added inline comments to D64833: [Xtensa 7/10] Add Xtensa instruction printer..

Dec 19 2022, 3:42 PM · Restricted Project, Restricted Project

andreisfr updated the diff for D64833: [Xtensa 7/10] Add Xtensa instruction printer..

Fixed "elf-header.s" test according to comments

Dec 19 2022, 3:41 PM · Restricted Project, Restricted Project

andreisfr updated the diff for D64831: [Xtensa 5/10] Add Xtensa MCTargetDescr initial functionality..

Updated according to latest changes in upstream source code

Dec 19 2022, 3:40 PM · Restricted Project, Restricted Project

andreisfr updated the diff for D64829: [Xtensa 3/10] Add initial version of the Xtensa backend..

Updated according to latest changes in upstream source code

Dec 19 2022, 3:39 PM · Restricted Project, Restricted Project

andreisfr updated the diff for D64827: [Xtensa 2/10] Add Xtensa ELF definitions..

Updated according to latest changes in upstream source code

Dec 19 2022, 3:38 PM · Restricted Project, Restricted Project

andreisfr updated the diff for D64826: [Xtensa 1/10] Recognize Xtensa in triple parsing code..

Updated according to latest changes in upstream source code

Dec 19 2022, 3:38 PM · Restricted Project, Restricted Project

Oct 10 2022

andreisfr added a comment to D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description..

@aykevl , @jyknight , @ivanbaev , I have a good news about Xtensa ISA documentation. Cadence makes documentation publicly available https://www.cadence.com/content/dam/cadence-www/global/en_US/documents/tools/ip/tensilica-ip/isa-summary.pdf

Oct 10 2022, 7:11 AM · Restricted Project, Restricted Project

Oct 5 2022

andreisfr added a comment to D64835: [Xtensa 9/10] Add basic support of Xtensa disassembler..

@saugustine , we added to the our plans implementation of the ".xt.insn" section. Is it suitable solution to resolve the issue with "nop" operation in this patch?

Oct 5 2022, 4:01 AM · Restricted Project, Restricted Project

Sep 26 2022

andreisfr added a comment to D64833: [Xtensa 7/10] Add Xtensa instruction printer..

@MaskRay , may I ask you about new test structure of the instructions set? I divided test file xtensa-valid.s to several files by instructions groups. Whether such division matches to your suggestions?

Sep 26 2022, 2:42 PM · Restricted Project, Restricted Project