Page MenuHomePhabricator

andreisfr (Andrei Safronov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2019, 2:20 PM (168 w, 2 d)

Recent Activity

Wed, Oct 5

andreisfr added a comment to D64835: [Xtensa 9/10] Add basic support of Xtensa disassembler..

@saugustine , we added our plans implementation of the ".xt.insn" section. Is it suitable solution to resolve the issue with "nop" operation in this patch?

Wed, Oct 5, 4:01 AM · Restricted Project, Restricted Project

Mon, Sep 26

andreisfr added a comment to D64833: [Xtensa 7/10] Add Xtensa instruction printer..

@MaskRay , may I ask you about new test structure of the instructions set? I divided test file xtensa-valid.s to several files by instructions groups. Whether such division matches to your suggestions?

Mon, Sep 26, 2:42 PM · Restricted Project, Restricted Project

Sun, Sep 18

andreisfr updated the diff for D64836: [Xtensa 10/10] Add relaxations and fixups. Add rest part of Xtensa Core Instructions..

Test file "xtensa-valid.s" is splitted to several files according to instructions groups.

Sun, Sep 18, 6:49 PM · Restricted Project, Restricted Project
andreisfr added inline comments to D64835: [Xtensa 9/10] Add basic support of Xtensa disassembler..
Sun, Sep 18, 6:46 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64835: [Xtensa 9/10] Add basic support of Xtensa disassembler..

Corrected comment. The "array_lengthof" changed to "std::size".

Sun, Sep 18, 6:46 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64834: [Xtensa 8/10] Add support of the Xtensa shift/load/store/move and processor control instructions..

Minor source code corrections. Test file xtensa-valid.s is splitted to several files.

Sun, Sep 18, 6:44 PM · Restricted Project, Restricted Project
andreisfr added inline comments to D64833: [Xtensa 7/10] Add Xtensa instruction printer..
Sun, Sep 18, 6:37 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64833: [Xtensa 7/10] Add Xtensa instruction printer..

Remove xtensa-valid.s

Sun, Sep 18, 6:35 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64833: [Xtensa 7/10] Add Xtensa instruction printer..

Minor code corrections. Test file xtensa-valid.s is splitted to several files by instructions groups.

Sun, Sep 18, 6:21 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64831: [Xtensa 5/10] Add Xtensa MCTargetDescr initial functionality..

Updated according to latest changes in upstream source code

Sun, Sep 18, 6:19 PM · Restricted Project, Restricted Project
andreisfr added inline comments to D64827: [Xtensa 2/10] Add Xtensa ELF definitions..
Sun, Sep 18, 6:17 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64827: [Xtensa 2/10] Add Xtensa ELF definitions..

Corrected comment

Sun, Sep 18, 6:16 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64826: [Xtensa 1/10] Recognize Xtensa in triple parsing code..

Updated according to latest changes in upstream source code

Sun, Sep 18, 6:15 PM · Restricted Project, Restricted Project

Aug 24 2022

andreisfr added inline comments to D64833: [Xtensa 7/10] Add Xtensa instruction printer..
Aug 24 2022, 6:19 PM · Restricted Project, Restricted Project
andreisfr added inline comments to D64831: [Xtensa 5/10] Add Xtensa MCTargetDescr initial functionality..
Aug 24 2022, 6:18 PM · Restricted Project, Restricted Project
andreisfr added a comment to D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description..

@saugustine , thank you very much for your comments!

Aug 24 2022, 6:17 PM · Restricted Project, Restricted Project
andreisfr added inline comments to D64827: [Xtensa 2/10] Add Xtensa ELF definitions..
Aug 24 2022, 6:12 PM · Restricted Project, Restricted Project
andreisfr added inline comments to D64826: [Xtensa 1/10] Recognize Xtensa in triple parsing code..
Aug 24 2022, 6:11 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64836: [Xtensa 10/10] Add relaxations and fixups. Add rest part of Xtensa Core Instructions..

Update according to latest changes in upstream version

Aug 24 2022, 6:10 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64834: [Xtensa 8/10] Add support of the Xtensa shift/load/store/move and processor control instructions..

Update according to changes in MEMW, EXTW, DSYNC, ESYNC, ISYNC and RSYNC instruction descriptions

Aug 24 2022, 6:06 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64833: [Xtensa 7/10] Add Xtensa instruction printer..

Minor changes: corrected comment

Aug 24 2022, 6:00 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64831: [Xtensa 5/10] Add Xtensa MCTargetDescr initial functionality..

Minor changes, corrected NOP data in XtensaMCAsmBackend::writeNopData function

Aug 24 2022, 5:58 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description..

Corrected MEMW, EXTW, DSYNC, ESYNC, ISYNC and RSYNC instruction descriptions

Aug 24 2022, 5:56 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64829: [Xtensa 3/10] Add initial version of the Xtensa backend..

Minor changes: corrected comment

Aug 24 2022, 5:53 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64827: [Xtensa 2/10] Add Xtensa ELF definitions..

Minor changes, added a comment to the Xtensa ELF relocations file.

Aug 24 2022, 5:52 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64826: [Xtensa 1/10] Recognize Xtensa in triple parsing code..

Minor changes: corrected comment.

Aug 24 2022, 5:51 PM · Restricted Project, Restricted Project

May 19 2022

andreisfr added a comment to D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description..

What's the current state of this patch? :)

May 19 2022, 1:06 AM · Restricted Project, Restricted Project
andreisfr updated the diff for D64835: [Xtensa 9/10] Add basic support of Xtensa disassembler..

Patch is updated according to LLVM upstream version

May 19 2022, 12:20 AM · Restricted Project, Restricted Project
andreisfr updated the diff for D64834: [Xtensa 8/10] Add support of the Xtensa shift/load/store/move and processor control instructions..

Minor corrections, changed argument names in the XtensaInstPrinter::printMemOperand function.

May 19 2022, 12:19 AM · Restricted Project, Restricted Project

Apr 27 2022

pilotniq awarded D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description. a Like token.
Apr 27 2022, 3:14 AM · Restricted Project, Restricted Project

Apr 25 2022

andreisfr updated the diff for D64836: [Xtensa 10/10] Add relaxations and fixups. Add rest part of Xtensa Core Instructions..

Patch is updated according to LLVM upstream version

Apr 25 2022, 5:20 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64835: [Xtensa 9/10] Add basic support of Xtensa disassembler..

Patch is updated according to LLVM upstream version

Apr 25 2022, 5:18 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64834: [Xtensa 8/10] Add support of the Xtensa shift/load/store/move and processor control instructions..

Patch is updated according to LLVM upstream version

Apr 25 2022, 5:18 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64833: [Xtensa 7/10] Add Xtensa instruction printer..

Patch is updated according to LLVM upstream version

Apr 25 2022, 5:17 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64832: [Xtensa 6/10] Add Xtensa basic assembler parser..

Patch is updated according to LLVM upstream version

Apr 25 2022, 5:16 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64831: [Xtensa 5/10] Add Xtensa MCTargetDescr initial functionality..

Patch is updated according to LLVM upstream version

Apr 25 2022, 5:15 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64827: [Xtensa 2/10] Add Xtensa ELF definitions..

Patch is updated according to LLVM upstream version

Apr 25 2022, 5:13 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64826: [Xtensa 1/10] Recognize Xtensa in triple parsing code..

Patch is updated according to LLVM upstream version

Apr 25 2022, 5:12 PM · Restricted Project, Restricted Project

Nov 25 2021

andreisfr updated the diff for D64836: [Xtensa 10/10] Add relaxations and fixups. Add rest part of Xtensa Core Instructions..

Patch is updated according to LLVM upstream version.

Nov 25 2021, 12:33 AM · Restricted Project, Restricted Project
andreisfr updated the diff for D64835: [Xtensa 9/10] Add basic support of Xtensa disassembler..

Patch is updated according to LLVM upstream version.

Nov 25 2021, 12:32 AM · Restricted Project, Restricted Project
andreisfr updated the diff for D64834: [Xtensa 8/10] Add support of the Xtensa shift/load/store/move and processor control instructions..

Patch is updated according to LLVM upstream version.

Nov 25 2021, 12:32 AM · Restricted Project, Restricted Project
andreisfr updated the diff for D64833: [Xtensa 7/10] Add Xtensa instruction printer..

Patch is updated according to LLVM upstream version.

Nov 25 2021, 12:31 AM · Restricted Project, Restricted Project
andreisfr updated the diff for D64832: [Xtensa 6/10] Add Xtensa basic assembler parser..

Patch is updated according to LLVM upstream version.

Nov 25 2021, 12:31 AM · Restricted Project, Restricted Project
andreisfr updated the diff for D64831: [Xtensa 5/10] Add Xtensa MCTargetDescr initial functionality..

Patch is updated according to LLVM upstream version.

Nov 25 2021, 12:30 AM · Restricted Project, Restricted Project
andreisfr updated the diff for D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description..

Patch is updated according to LLVM upstream version.

Nov 25 2021, 12:29 AM · Restricted Project, Restricted Project
andreisfr updated the diff for D64829: [Xtensa 3/10] Add initial version of the Xtensa backend..

Patch is updated according to LLVM upstream version.

Nov 25 2021, 12:28 AM · Restricted Project, Restricted Project
andreisfr updated the diff for D64827: [Xtensa 2/10] Add Xtensa ELF definitions..

Patch is updated according to LLVM upstream version and latest Xtensa backend version.

Nov 25 2021, 12:24 AM · Restricted Project, Restricted Project
andreisfr updated the diff for D64826: [Xtensa 1/10] Recognize Xtensa in triple parsing code..

Patch is updated according to LLVM upstream version

Nov 25 2021, 12:22 AM · Restricted Project, Restricted Project

Jun 11 2021

andreisfr added a comment to D64836: [Xtensa 10/10] Add relaxations and fixups. Add rest part of Xtensa Core Instructions..

@jrtc27 ,thank you very much for comments.

Jun 11 2021, 5:51 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64836: [Xtensa 10/10] Add relaxations and fixups. Add rest part of Xtensa Core Instructions..

Remove whitespaces and parentheses.

Jun 11 2021, 5:44 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64834: [Xtensa 8/10] Add support of the Xtensa shift/load/store/move and processor control instructions..

Remove redundant whitespaces

Jun 11 2021, 5:42 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64833: [Xtensa 7/10] Add Xtensa instruction printer..

Remove redundant whitespaces.

Jun 11 2021, 5:40 PM · Restricted Project, Restricted Project

Apr 9 2021

andreisfr added inline comments to D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description..
Apr 9 2021, 6:09 AM · Restricted Project, Restricted Project
andreisfr updated the diff for D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description..

Corrected indentation, removed blank line

Apr 9 2021, 6:09 AM · Restricted Project, Restricted Project

Apr 7 2021

andreisfr updated the diff for D64836: [Xtensa 10/10] Add relaxations and fixups. Add rest part of Xtensa Core Instructions..

Correct instruction descriptions, format descriptions and instruction operands according to common style for *.td files. The llvm_unreachable is substituted to report_fatal_error.

Apr 7 2021, 4:57 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64835: [Xtensa 9/10] Add basic support of Xtensa disassembler..

Correct instruction descriptions, format descriptions and instruction operands according to common style for *.td files. The llvm_unreachable is substituted to report_fatal_error.

Apr 7 2021, 4:56 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64834: [Xtensa 8/10] Add support of the Xtensa shift/load/store/move and processor control instructions..

Correct instruction descriptions, format descriptions and instruction operands according to common style for *.td files. The llvm_unreachable is substituted to report_fatal_error.

Apr 7 2021, 4:55 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64833: [Xtensa 7/10] Add Xtensa instruction printer..

The llvm_unreachable is substituted to report_fatal_error

Apr 7 2021, 4:55 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64832: [Xtensa 6/10] Add Xtensa basic assembler parser..

The llvm_unreachable is substituted to report_fatal_error

Apr 7 2021, 4:54 PM · Restricted Project, Restricted Project
andreisfr added inline comments to D64831: [Xtensa 5/10] Add Xtensa MCTargetDescr initial functionality..
Apr 7 2021, 4:52 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64831: [Xtensa 5/10] Add Xtensa MCTargetDescr initial functionality..

Correct instruction descriptions, format descriptions and instruction operands according to common style for *.td files. The llvm_unreachable is substituted to report_fatal_error.

Apr 7 2021, 4:50 PM · Restricted Project, Restricted Project
andreisfr added a comment to D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description..

@craig.topper , thank you very much for comments!

Apr 7 2021, 4:48 PM · Restricted Project, Restricted Project
andreisfr added inline comments to D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description..
Apr 7 2021, 4:47 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description..

Correct instruction descriptions, format descriptions and instruction operands according to common style for *.td files.

Apr 7 2021, 4:40 PM · Restricted Project, Restricted Project

Apr 1 2021

andreisfr added inline comments to D64827: [Xtensa 2/10] Add Xtensa ELF definitions..
Apr 1 2021, 3:16 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64827: [Xtensa 2/10] Add Xtensa ELF definitions..

Removed spaces in macro calls in Xtensa.def. Also removed extra indentation in xtensa-header-flags.test.

Apr 1 2021, 3:15 PM · Restricted Project, Restricted Project

Mar 26 2021

andreisfr added inline comments to D64827: [Xtensa 2/10] Add Xtensa ELF definitions..
Mar 26 2021, 1:12 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64827: [Xtensa 2/10] Add Xtensa ELF definitions..

Corrected llvm-readobj test

Mar 26 2021, 1:07 PM · Restricted Project, Restricted Project

Mar 25 2021

andreisfr added inline comments to D64827: [Xtensa 2/10] Add Xtensa ELF definitions..
Mar 25 2021, 5:47 PM · Restricted Project, Restricted Project
andreisfr added inline comments to D64827: [Xtensa 2/10] Add Xtensa ELF definitions..
Mar 25 2021, 5:41 PM · Restricted Project, Restricted Project
andreisfr added inline comments to D64827: [Xtensa 2/10] Add Xtensa ELF definitions..
Mar 25 2021, 5:40 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64827: [Xtensa 2/10] Add Xtensa ELF definitions..

Corrected according to review comments

Mar 25 2021, 5:34 PM · Restricted Project, Restricted Project

Mar 9 2021

andreisfr added inline comments to D64827: [Xtensa 2/10] Add Xtensa ELF definitions..
Mar 9 2021, 5:01 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64836: [Xtensa 10/10] Add relaxations and fixups. Add rest part of Xtensa Core Instructions..

Patch is updated according to LLVM upstream version and latest Xtensa backend version.

Mar 9 2021, 4:52 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64833: [Xtensa 7/10] Add Xtensa instruction printer..

Patch is updated according to LLVM upstream version and latest Xtensa backend version.

Mar 9 2021, 4:51 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64829: [Xtensa 3/10] Add initial version of the Xtensa backend..

Patch is updated according to LLVM upstream version and latest Xtensa backend version.

Mar 9 2021, 4:50 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64827: [Xtensa 2/10] Add Xtensa ELF definitions..

Patch is updated according to LLVM upstream version and latest Xtensa backend version.

Mar 9 2021, 4:48 PM · Restricted Project, Restricted Project

Mar 5 2021

andreisfr updated the diff for D64836: [Xtensa 10/10] Add relaxations and fixups. Add rest part of Xtensa Core Instructions..

Patch is updated according to latest upstream version

Mar 5 2021, 4:47 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64835: [Xtensa 9/10] Add basic support of Xtensa disassembler..

Patch is updated according to LLVM upstream version and latest Xtensa backend version.

Mar 5 2021, 4:47 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64834: [Xtensa 8/10] Add support of the Xtensa shift/load/store/move and processor control instructions..

Patch is updated according to LLVM upstream version and latest Xtensa backend version.

Mar 5 2021, 4:47 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64833: [Xtensa 7/10] Add Xtensa instruction printer..

Patch is updated according to latest upstream version

Mar 5 2021, 4:46 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64832: [Xtensa 6/10] Add Xtensa basic assembler parser..

Patch is updated according to LLVM upstream version and latest Xtensa backend version.

Mar 5 2021, 4:46 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64831: [Xtensa 5/10] Add Xtensa MCTargetDescr initial functionality..

Patch is updated according to LLVM upstream version and latest Xtensa backend version.

Mar 5 2021, 4:45 PM · Restricted Project, Restricted Project
andreisfr added inline comments to D64827: [Xtensa 2/10] Add Xtensa ELF definitions..
Mar 5 2021, 4:45 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description..

Patch is updated according to LLVM upstream version and latest Xtensa backend version.

Mar 5 2021, 4:44 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64829: [Xtensa 3/10] Add initial version of the Xtensa backend..

Patch is updated according to latest upstream version.

Mar 5 2021, 4:43 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64827: [Xtensa 2/10] Add Xtensa ELF definitions..

Patch is updated according to latest upstream version. Added llvm-readobj test.

Mar 5 2021, 4:39 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64826: [Xtensa 1/10] Recognize Xtensa in triple parsing code..

Patch is updated according to LLVM upstream version and latest Xtensa backend version.. Also updated CODE_OWNERS.txt.

Mar 5 2021, 4:03 PM · Restricted Project, Restricted Project

Mar 4 2021

andreisfr added a comment to D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description..

@aykevl , I prepared new version of patches and I will update them in 1 day.

Mar 4 2021, 4:53 PM · Restricted Project, Restricted Project

Jan 24 2021

andreisfr added a comment to D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description..

@brainstorm , @tonic , @tstellar , thank you very much for your help!

Jan 24 2021, 5:14 PM · Restricted Project, Restricted Project

Feb 28 2020

andreisfr added inline comments to D64827: [Xtensa 2/10] Add Xtensa ELF definitions..
Feb 28 2020, 4:25 PM · Restricted Project, Restricted Project
andreisfr added inline comments to D64827: [Xtensa 2/10] Add Xtensa ELF definitions..
Feb 28 2020, 4:07 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64827: [Xtensa 2/10] Add Xtensa ELF definitions..

Correct relocations test for the Xtensa target

Feb 28 2020, 4:07 PM · Restricted Project, Restricted Project

Feb 19 2020

andreisfr added inline comments to D64827: [Xtensa 2/10] Add Xtensa ELF definitions..
Feb 19 2020, 3:46 AM · Restricted Project, Restricted Project
andreisfr updated the diff for D64827: [Xtensa 2/10] Add Xtensa ELF definitions..

Correction of comments and Xtensa ELF flags test.

Feb 19 2020, 3:21 AM · Restricted Project, Restricted Project

Feb 16 2020

andreisfr added inline comments to D64827: [Xtensa 2/10] Add Xtensa ELF definitions..
Feb 16 2020, 4:13 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64827: [Xtensa 2/10] Add Xtensa ELF definitions..

Correct Xtensa ELF flag test

Feb 16 2020, 3:55 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64827: [Xtensa 2/10] Add Xtensa ELF definitions..

Change EF_XTENSA_MACH_BASE to EF_XTENSA_MACH_NONE, it seems this is closer to ELF flag naming style used for AMDGPU and MIPS.

Feb 16 2020, 3:10 PM · Restricted Project, Restricted Project

Feb 12 2020

andreisfr added inline comments to D64827: [Xtensa 2/10] Add Xtensa ELF definitions..
Feb 12 2020, 12:52 PM · Restricted Project, Restricted Project
andreisfr updated the diff for D64827: [Xtensa 2/10] Add Xtensa ELF definitions..

Correction of the llvm/test/Object/obj2yaml.test, now Xtensa test uses yaml2obj instead of pre-built binary trivial-object-test.elf-xtensa.

Feb 12 2020, 12:52 PM · Restricted Project, Restricted Project