Page MenuHomePhabricator

saugustine (Sterling Augustine)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 6 2015, 10:28 AM (180 w, 6 d)

Recent Activity

Tue, Apr 23

saugustine added a comment to D60285: Make calls into the pthread library use weak symbols..

Hi Nick--hope your vacation was good.

Tue, Apr 23, 3:59 PM · Restricted Project

Mon, Apr 15

saugustine added a comment to D60285: Make calls into the pthread library use weak symbols..

@kledzik

Nick, what do you think about adding weak symbols just for achieving this?

Mon, Apr 15, 2:07 PM · Restricted Project

Tue, Apr 9

saugustine added a comment to D60285: Make calls into the pthread library use weak symbols..

ping?

Tue, Apr 9, 4:14 PM · Restricted Project

Fri, Apr 5

saugustine added inline comments to D60285: Make calls into the pthread library use weak symbols..
Fri, Apr 5, 1:51 PM · Restricted Project
saugustine added a comment to D60285: Make calls into the pthread library use weak symbols..

This is better than a no-op RWMutex because then the same binary works both when the application is multi-threaded and when it isn't. Therefore the build doesn't have to distinguish between the two cases.

Fri, Apr 5, 11:26 AM · Restricted Project

Thu, Apr 4

saugustine created D60285: Make calls into the pthread library use weak symbols..
Thu, Apr 4, 2:10 PM · Restricted Project

Mar 26 2019

saugustine added inline comments to D59841: [Gnu Driver] If -pie and -static-pie are both passed, let -static-pie win..
Mar 26 2019, 2:06 PM · Restricted Project

Mar 21 2019

saugustine committed rG7642289780b3: This test assumes that -rtlib defaults to libgcc. But that isn't true in the… (authored by saugustine).
This test assumes that -rtlib defaults to libgcc. But that isn't true in the…
Mar 21 2019, 4:30 PM
saugustine committed rC356724: This test assumes that -rtlib defaults to libgcc. But that isn't true in the….
This test assumes that -rtlib defaults to libgcc. But that isn't true in the…
Mar 21 2019, 4:29 PM
saugustine committed rL356724: This test assumes that -rtlib defaults to libgcc. But that isn't true in the….
This test assumes that -rtlib defaults to libgcc. But that isn't true in the…
Mar 21 2019, 4:29 PM
saugustine closed D59674: This test assumes that -rtlib defaults to libgcc. But that isn't true in the face of -DCLANG_DEFAULT_RTLIB=compiler-rt..
Mar 21 2019, 4:29 PM · Restricted Project
saugustine added a reviewer for D59674: This test assumes that -rtlib defaults to libgcc. But that isn't true in the face of -DCLANG_DEFAULT_RTLIB=compiler-rt.: rdhindsa.
Mar 21 2019, 4:29 PM · Restricted Project
saugustine created D59674: This test assumes that -rtlib defaults to libgcc. But that isn't true in the face of -DCLANG_DEFAULT_RTLIB=compiler-rt..
Mar 21 2019, 4:14 PM · Restricted Project

Mar 20 2019

saugustine committed rG86724e40bfa5: Make __cpu_model a hidden symbol, to match libgcc. Also hide… (authored by saugustine).
Make __cpu_model a hidden symbol, to match libgcc. Also hide…
Mar 20 2019, 10:37 AM
saugustine committed rCRT356581: Make __cpu_model a hidden symbol, to match libgcc..
Make __cpu_model a hidden symbol, to match libgcc.
Mar 20 2019, 10:37 AM
saugustine committed rL356581: Make __cpu_model a hidden symbol, to match libgcc..
Make __cpu_model a hidden symbol, to match libgcc.
Mar 20 2019, 10:37 AM
saugustine closed D59561: Make __cpu_model a hidden symbol, to match libgcc..
Mar 20 2019, 10:37 AM · Restricted Project
saugustine added a comment to D59561: Make __cpu_model a hidden symbol, to match libgcc..

Thanks. I've hidden a couple more symbols Please take another look.

Mar 20 2019, 10:10 AM · Restricted Project
saugustine updated the diff for D59561: Make __cpu_model a hidden symbol, to match libgcc..

Make cpu_model a hidden symbol, to match libgcc.
Also
cpu_features2 and __cpu_indicator_init.

Mar 20 2019, 10:10 AM · Restricted Project
saugustine updated the diff for D59561: Make __cpu_model a hidden symbol, to match libgcc..
  • Also hide __cpu_inicator_init for similar reasons.
Mar 20 2019, 9:52 AM · Restricted Project

Mar 19 2019

saugustine created D59561: Make __cpu_model a hidden symbol, to match libgcc..
Mar 19 2019, 2:05 PM · Restricted Project
saugustine added reviewers for D59561: Make __cpu_model a hidden symbol, to match libgcc.: asbirlea, echristo.
Mar 19 2019, 2:05 PM · Restricted Project
saugustine committed rG6271606969e2: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2] (authored by saugustine).
Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]
Mar 19 2019, 1:01 PM
saugustine committed rC356508: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]
Mar 19 2019, 1:01 PM
saugustine committed rL356508: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]
Mar 19 2019, 1:01 PM
saugustine closed D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Mar 19 2019, 1:00 PM · Restricted Project
saugustine added inline comments to D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Mar 19 2019, 12:57 PM · Restricted Project

Mar 18 2019

saugustine added a comment to D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].

I have now switched it to use --unwindlib=[libgcc|libunwind]

Mar 18 2019, 2:25 PM · Restricted Project
saugustine updated the diff for D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
  • Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]
  • Change option argument --unwindlib= from "compiler-rt" to "libunwind".
  • Fix tests syntax and driver checks for --unwindlib=
Mar 18 2019, 2:19 PM · Restricted Project
saugustine updated the diff for D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
  • Undo cpu model change.
Mar 18 2019, 11:31 AM · Restricted Project
saugustine updated the diff for D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Mar 18 2019, 11:25 AM · Restricted Project

Mar 14 2019

saugustine accepted D59387: Make getFullyQualifiedName qualify both the pointee and class type for member ptr types.

This looks correct to me, thanks for the fix.

Mar 14 2019, 2:54 PM · Restricted Project, Restricted Project

Mar 13 2019

saugustine added a comment to D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].

rsmith: Do you have any comments on the naming here?

Mar 13 2019, 10:08 AM · Restricted Project

Mar 11 2019

saugustine added inline comments to D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Mar 11 2019, 3:37 PM · Restricted Project

Mar 8 2019

saugustine added inline comments to D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Mar 8 2019, 11:32 AM · Restricted Project

Mar 7 2019

saugustine added reviewers for D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]: rsmith, phosek, kristina, mstorsjo, uabelho.
Mar 7 2019, 2:13 PM · Restricted Project
saugustine created D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Mar 7 2019, 2:06 PM · Restricted Project

Feb 20 2019

saugustine accepted D58307: [Clang Driver] Add support for "-static-pie" argument to the Clang driver..
Feb 20 2019, 10:39 AM · Restricted Project, Restricted Project

Jan 29 2019

saugustine committed rL352524: Rollback unwindlib patch..
Rollback unwindlib patch.
Jan 29 2019, 10:29 AM
saugustine committed rC352524: Rollback unwindlib patch..
Rollback unwindlib patch.
Jan 29 2019, 10:29 AM
saugustine added a comment to D57128: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=.

This was rolled back with r352524. I'll work out something better.

Jan 29 2019, 10:29 AM
saugustine added a comment to D57128: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=.

Sorry for the breakage everyone, I'm preparing a rollback now.

Jan 29 2019, 8:50 AM

Jan 28 2019

saugustine committed rL352405: Correct help text for --unwindlib options..
Correct help text for --unwindlib options.
Jan 28 2019, 10:56 AM
saugustine committed rC352405: Correct help text for --unwindlib options..
Correct help text for --unwindlib options.
Jan 28 2019, 10:56 AM
saugustine committed rL352404: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=.
Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=
Jan 28 2019, 10:56 AM
saugustine committed rC352404: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=.
Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=
Jan 28 2019, 10:56 AM
saugustine closed D57128: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=.
Jan 28 2019, 10:56 AM

Jan 25 2019

saugustine added inline comments to D57128: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=.
Jan 25 2019, 3:07 PM
saugustine updated the diff for D57128: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=.
  • Correct help text for --unwindlib options.
Jan 25 2019, 3:07 PM

Jan 23 2019

saugustine created D57128: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=.
Jan 23 2019, 5:07 PM

Jan 10 2019

saugustine committed rC350900: Properly support -shared-libgcc..
Properly support -shared-libgcc.
Jan 10 2019, 2:30 PM
saugustine committed rL350900: Properly support -shared-libgcc..
Properly support -shared-libgcc.
Jan 10 2019, 2:30 PM
saugustine closed D55016: Correctly support -shared-libgcc..

Committed with r350900.

Jan 10 2019, 2:30 PM

Nov 28 2018

saugustine created D55016: Correctly support -shared-libgcc..
Nov 28 2018, 12:00 PM

Nov 26 2018

saugustine closed D54492: Notify the linker when a TU compiled with split-stack has a functionwithout a prologue.There is more context here:https://go-review.googlesource.com/c/go/+/148819/.
Nov 26 2018, 3:30 PM
saugustine added a comment to D54492: Notify the linker when a TU compiled with split-stack has a functionwithout a prologue.There is more context here:https://go-review.googlesource.com/c/go/+/148819/.

Committed as r347614.

Nov 26 2018, 3:29 PM
saugustine committed rL347614: Notify the linker when a TU compiled with split-stack has a function without a….
Notify the linker when a TU compiled with split-stack has a function without a…
Nov 26 2018, 3:29 PM
saugustine updated the diff for D54492: Notify the linker when a TU compiled with split-stack has a functionwithout a prologue.There is more context here:https://go-review.googlesource.com/c/go/+/148819/.

Add a test case.

Nov 26 2018, 3:18 PM

Nov 15 2018

saugustine added inline comments to D54497: [ELF] --gdb-index: extract entities from .debug_info when .debug_gnu_pubnames is absent.
Nov 15 2018, 11:06 AM

Nov 13 2018

saugustine retitled D54492: Notify the linker when a TU compiled with split-stack has a functionwithout a prologue.There is more context here:https://go-review.googlesource.com/c/go/+/148819/ from Notify the linker when a TU compiled with split-stack has a function without a prologue. There is more context here: https://go-review.googlesource.com/c/go/+/148819/ to Notify the linker when a TU compiled with split-stack has a functionwithout a prologue.There is more context here:https://go-review.googlesource.com/c/go/+/148819/.
Nov 13 2018, 1:25 PM
saugustine created D54492: Notify the linker when a TU compiled with split-stack has a functionwithout a prologue.There is more context here:https://go-review.googlesource.com/c/go/+/148819/.
Nov 13 2018, 1:20 PM

Sep 4 2018

saugustine committed rL341408: When a relocation to an undefined symbol is an R_X86_64_PC32, an input.
When a relocation to an undefined symbol is an R_X86_64_PC32, an input
Sep 4 2018, 2:09 PM
saugustine committed rLLD341408: When a relocation to an undefined symbol is an R_X86_64_PC32, an input.
When a relocation to an undefined symbol is an R_X86_64_PC32, an input
Sep 4 2018, 2:09 PM

Aug 31 2018

saugustine committed rC341231: Refactor Addlibgcc to make the when and what logic more straightfoward..
Refactor Addlibgcc to make the when and what logic more straightfoward.
Aug 31 2018, 11:02 AM
saugustine committed rL341231: Refactor Addlibgcc to make the when and what logic more straightfoward..
Refactor Addlibgcc to make the when and what logic more straightfoward.
Aug 31 2018, 11:02 AM
saugustine closed D51521: Refactor Addlibgcc to make the when and what logic more straightfoward..

commited as r341231.

Aug 31 2018, 11:01 AM

Aug 30 2018

saugustine created D51521: Refactor Addlibgcc to make the when and what logic more straightfoward..
Aug 30 2018, 3:59 PM
saugustine committed rL341114: Revert r341107. That change breaks lto-android in a way is untested..
Revert r341107. That change breaks lto-android in a way is untested.
Aug 30 2018, 1:44 PM
saugustine committed rC341114: Revert r341107. That change breaks lto-android in a way is untested..
Revert r341107. That change breaks lto-android in a way is untested.
Aug 30 2018, 1:43 PM
saugustine committed rL341107: Refactor Addlibgcc to make the when and what logic more straightfoward..
Refactor Addlibgcc to make the when and what logic more straightfoward.
Aug 30 2018, 1:08 PM
saugustine committed rC341107: Refactor Addlibgcc to make the when and what logic more straightfoward..
Refactor Addlibgcc to make the when and what logic more straightfoward.
Aug 30 2018, 1:08 PM
saugustine closed D51007: Test the cross-product of options that affect how libgcc-related arguments are passed to the linker..

Committed as rL341083

Aug 30 2018, 9:39 AM
saugustine committed rC341083: Test the cross-product of how libgcc-related arguments are passed to the linker..
Test the cross-product of how libgcc-related arguments are passed to the linker.
Aug 30 2018, 9:38 AM
saugustine committed rL341083: Test the cross-product of how libgcc-related arguments are passed to the linker..
Test the cross-product of how libgcc-related arguments are passed to the linker.
Aug 30 2018, 9:38 AM

Aug 20 2018

saugustine added a comment to D51007: Test the cross-product of options that affect how libgcc-related arguments are passed to the linker..

I am refactoring the code that does this, in preparation for adding support for -shared-libgcc, and, after that, shared compiler-rt. These tests are to defend against mistakes in that refactoring and prepare for correct handling of the other cases.

Aug 20 2018, 4:16 PM
saugustine created D51007: Test the cross-product of options that affect how libgcc-related arguments are passed to the linker..
Aug 20 2018, 4:15 PM

Aug 13 2018

saugustine closed D50371: Split-stack support for cross-linking shared-libraries..

Committed as rLLD339626

Aug 13 2018, 3:33 PM
saugustine committed rLLD339626: Support shared objects for split stack..
Support shared objects for split stack.
Aug 13 2018, 3:31 PM
saugustine committed rL339626: Support shared objects for split stack..
Support shared objects for split stack.
Aug 13 2018, 3:31 PM

Aug 9 2018

saugustine updated the diff for D50371: Split-stack support for cross-linking shared-libraries..

Further minimize the test case.

Aug 9 2018, 2:46 PM
saugustine added a comment to D50371: Split-stack support for cross-linking shared-libraries..

Thanks for the review. I apologize for not producing something sufficiently minimal on the previous round.

Aug 9 2018, 2:45 PM

Aug 8 2018

saugustine added a comment to D50371: Split-stack support for cross-linking shared-libraries..

ping?

Aug 8 2018, 4:02 PM

Aug 7 2018

saugustine updated the diff for D50371: Split-stack support for cross-linking shared-libraries..

Cleanup test case.

Aug 7 2018, 10:57 AM
saugustine added a comment to D50371: Split-stack support for cross-linking shared-libraries..

Thanks for the feedback, please take another look if you would.

Aug 7 2018, 10:56 AM

Aug 6 2018

saugustine added reviewers for D50371: Split-stack support for cross-linking shared-libraries.: ruiu, grimar.
Aug 6 2018, 5:31 PM
saugustine created D50371: Split-stack support for cross-linking shared-libraries..
Aug 6 2018, 5:30 PM

Aug 1 2018

saugustine updated the diff for D49926: Update split stack support to handle more generic prologues. Improve error handling. Add test file for better code-coverage. Update tests to be more complete..

Fix a typo.

Aug 1 2018, 4:26 PM
saugustine added a comment to D49926: Update split stack support to handle more generic prologues. Improve error handling. Add test file for better code-coverage. Update tests to be more complete..

Thanks.

Aug 1 2018, 4:26 PM
saugustine updated the diff for D49926: Update split stack support to handle more generic prologues. Improve error handling. Add test file for better code-coverage. Update tests to be more complete..

Yet another round.

Aug 1 2018, 11:56 AM
saugustine added a comment to D49926: Update split stack support to handle more generic prologues. Improve error handling. Add test file for better code-coverage. Update tests to be more complete..

Thanks again. Hopefully this is the last round, but happy to make other changes.

Aug 1 2018, 11:56 AM

Jul 31 2018

saugustine added a comment to D49926: Update split stack support to handle more generic prologues. Improve error handling. Add test file for better code-coverage. Update tests to be more complete..

Thanks for the reviews. I think I've addressed them.

Jul 31 2018, 4:22 PM
saugustine updated the diff for D49926: Update split stack support to handle more generic prologues. Improve error handling. Add test file for better code-coverage. Update tests to be more complete..

Update for comments.

Jul 31 2018, 4:21 PM

Jul 30 2018

saugustine added a comment to D49926: Update split stack support to handle more generic prologues. Improve error handling. Add test file for better code-coverage. Update tests to be more complete..

ruiu, do you have any thoughts on this?

Jul 30 2018, 2:05 PM

Jul 27 2018

saugustine created D49926: Update split stack support to handle more generic prologues. Improve error handling. Add test file for better code-coverage. Update tests to be more complete..
Jul 27 2018, 12:02 PM
saugustine abandoned D49326: Update ClangASTContext for the new DependentVector type..
Jul 27 2018, 11:55 AM
saugustine abandoned D49814: When getting an error location, don't assume that all sections prior to a given offset can be cast to an InputSection.
Jul 27 2018, 11:54 AM

Jul 25 2018

saugustine created D49814: When getting an error location, don't assume that all sections prior to a given offset can be cast to an InputSection.
Jul 25 2018, 11:46 AM
saugustine abandoned D49812: When getting an error location, don't assume that all sections prior to a given offset can be cast to an InputSection..
Jul 25 2018, 11:44 AM
saugustine created D49812: When getting an error location, don't assume that all sections prior to a given offset can be cast to an InputSection..
Jul 25 2018, 11:43 AM

Jul 17 2018

saugustine committed rLLD337340: Workaround warning bug in old versions of gcc..
Workaround warning bug in old versions of gcc.
Jul 17 2018, 5:38 PM