Page MenuHomePhabricator

saugustine (Sterling Augustine)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 6 2015, 10:28 AM (254 w, 2 d)

Recent Activity

Thu, Sep 10

saugustine abandoned D85231: Protect against filenames with no extension at all..
Thu, Sep 10, 9:46 AM · Restricted Project

Wed, Sep 2

saugustine accepted D86768: [libunwind] Replace chain-of-ifdefs for dl_iterate_phdr.

I am going to accept this, since no one else seems to be able to review it. But the problem here is that no one really knows what a simplified ifdef chain with the same functionality looks like. I tried a couple of times and failed miserably.

Wed, Sep 2, 5:03 PM · Unknown Object (Project), Restricted Project

Aug 19 2020

saugustine accepted D86254: [libunwind] Minor fixes in libunwind.

Looks good from the FrameHeaderCache side.

Aug 19 2020, 5:19 PM · Unknown Object (Project), Restricted Project

Aug 18 2020

saugustine committed rGa20f5fe70810: Default to disabling the libunwind frameheader cache. (authored by saugustine).
Default to disabling the libunwind frameheader cache.
Aug 18 2020, 2:38 PM
saugustine closed D86163: Default to disabling the libunwind frameheader cache.
Aug 18 2020, 2:38 PM · Unknown Object (Project), Restricted Project
saugustine retitled D86163: Default to disabling the libunwind frameheader cache from Allow enabling the libunwind frameheader cache at configure time. to Default to disabling the libunwind frameheader cache.
Aug 18 2020, 2:36 PM · Unknown Object (Project), Restricted Project
saugustine updated the diff for D86163: Default to disabling the libunwind frameheader cache.

Update for comment.

Aug 18 2020, 2:35 PM · Unknown Object (Project), Restricted Project
saugustine added a comment to D86163: Default to disabling the libunwind frameheader cache.

Now just waiting on a libunwind group reviewer.

Aug 18 2020, 2:24 PM · Unknown Object (Project), Restricted Project
saugustine updated the diff for D86163: Default to disabling the libunwind frameheader cache.

Rework to match bsd workaround.

Aug 18 2020, 2:18 PM · Unknown Object (Project), Restricted Project
saugustine added reviewers for D86163: Default to disabling the libunwind frameheader cache: hans, jgorbe.
Aug 18 2020, 12:09 PM · Unknown Object (Project), Restricted Project
saugustine requested review of D86163: Default to disabling the libunwind frameheader cache.
Aug 18 2020, 12:08 PM · Unknown Object (Project), Restricted Project
saugustine added a comment to D75954: Cache uwnind frame headers as they are found..
In D75954#2219870, @dim wrote:

It looks like the need for some locking in this FrameHeaderCache was completely overlooked? Or at least, having a cache per thread would make locking unnecessary, but it would cost more memory.

Well, not _completely_ overlooked. Looks like glibc locks things and other libc's don't. Should be easy to add a lock here for non glibc targets.

Sterling, do you think this will be fixed soon so we can get it in the llvm 11 release?

Aug 18 2020, 9:25 AM · Unknown Object (Project), Restricted Project, Restricted Project

Aug 16 2020

saugustine added a comment to D75954: Cache uwnind frame headers as they are found..
In D75954#2219870, @dim wrote:

It looks like the need for some locking in this FrameHeaderCache was completely overlooked? Or at least, having a cache per thread would make locking unnecessary, but it would cost more memory.

Aug 16 2020, 12:51 PM · Unknown Object (Project), Restricted Project, Restricted Project

Aug 6 2020

saugustine added a comment to D85145: Use syntax highlighting also in gui mode.

This change has a subtle isse with wattr_get and friends: saved_opts isn't actually used, and the documentation for them says to always pass a nullptr. "The parameter opts is reserved for future use, applications must supply a null pointer."

Aug 6 2020, 10:26 AM · Restricted Project
saugustine committed rG9dbdaea9a0e6: Remove unused variable "saved_opts". (authored by saugustine).
Remove unused variable "saved_opts".
Aug 6 2020, 10:21 AM

Aug 4 2020

saugustine added a comment to D85231: Protect against filenames with no extension at all..

The darwin-dsymutil.c tests this code path right now on line 33. I found this error by running it under asan; otherwise it was fully latent.

Aug 4 2020, 1:42 PM · Restricted Project
saugustine requested review of D85231: Protect against filenames with no extension at all..
Aug 4 2020, 11:27 AM · Restricted Project

Jul 17 2020

saugustine added a comment to D84058: Pass -rtlib=libgcc in tests conditioned on the default..

This is a reasonable workaround, as it seems to be checking the position of various arguments, and as things work today, lgcc and the compiler-rt variants appear in exactly the same places.

Jul 17 2020, 11:33 AM · Restricted Project

Jul 14 2020

saugustine committed rG77ee4b4c9be5: Desugar class type for iterator lookup. (authored by saugustine).
Desugar class type for iterator lookup.
Jul 14 2020, 11:38 AM
saugustine closed D83732: Desugar class type for iterator lookup..
Jul 14 2020, 11:38 AM · Restricted Project

Jul 13 2020

saugustine added a reviewer for D83732: Desugar class type for iterator lookup.: tamur.
Jul 13 2020, 5:24 PM · Restricted Project
Herald added a reviewer for D83732: Desugar class type for iterator lookup.: Restricted Project.
Jul 13 2020, 5:21 PM · Restricted Project

Jun 15 2020

saugustine abandoned D81683: llc doesn't recognize "-debug" without asserts enabled..
Jun 15 2020, 9:46 AM · Restricted Project

Jun 12 2020

saugustine committed rGe64059828f19: Revert "[analyzer][NFC] Don't allow dependency checkers to emit diagnostics" (authored by saugustine).
Revert "[analyzer][NFC] Don't allow dependency checkers to emit diagnostics"
Jun 12 2020, 12:36 PM
saugustine added a reverting change for rG33fb9cbe211d: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics: rGe64059828f19: Revert "[analyzer][NFC] Don't allow dependency checkers to emit diagnostics".
Jun 12 2020, 12:36 PM
saugustine closed D81752: Revert "[analyzer][NFC] Don't allow dependency checkers to emit diagnostics".
Jun 12 2020, 12:35 PM · Restricted Project
saugustine added a comment to rG33fb9cbe211d: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics.

Thanks for the quick response and easy deal. Looking forward to this relanding--it's a good change for sure.

Jun 12 2020, 12:35 PM
saugustine added a reverting change for rG33fb9cbe211d: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics: D81752: Revert "[analyzer][NFC] Don't allow dependency checkers to emit diagnostics".
Jun 12 2020, 11:30 AM
saugustine created D81752: Revert "[analyzer][NFC] Don't allow dependency checkers to emit diagnostics".
Jun 12 2020, 11:28 AM · Restricted Project
saugustine added inline comments to D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics.
Jun 12 2020, 10:52 AM · Restricted Project

Jun 11 2020

saugustine created D81683: llc doesn't recognize "-debug" without asserts enabled..
Jun 11 2020, 12:41 PM · Restricted Project

Jun 9 2020

saugustine committed rGccd192204da4: Fix variables used only in asserts. (authored by saugustine).
Fix variables used only in asserts.
Jun 9 2020, 5:43 PM
saugustine closed D81522: Fix variables used only in asserts..
Jun 9 2020, 5:43 PM · Restricted Project
saugustine updated the summary of D81522: Fix variables used only in asserts..
Jun 9 2020, 5:42 PM · Restricted Project
saugustine added a comment to D80286: [Analyzer] Allow creation of stack frame for functions without definition.

Unfortunately, after this change there are several variables only used in asserts, which creates build failures when assertions are disabled.

Jun 9 2020, 5:42 PM · Restricted Project
saugustine created D81522: Fix variables used only in asserts..
Jun 9 2020, 5:42 PM · Restricted Project

Jun 8 2020

saugustine committed rGf07b3d41e739: Add #includes so that ROCm.h is compilable stand-alone. (authored by saugustine).
Add #includes so that ROCm.h is compilable stand-alone.
Jun 8 2020, 2:26 PM
saugustine closed D81432: Add #includes so that ROCm.h is compilable stand-alone..
Jun 8 2020, 2:26 PM · Restricted Project
saugustine added a comment to D81432: Add #includes so that ROCm.h is compilable stand-alone..

For post-commit review.

Jun 8 2020, 2:25 PM · Restricted Project
saugustine created D81432: Add #includes so that ROCm.h is compilable stand-alone..
Jun 8 2020, 2:25 PM · Restricted Project
saugustine added reviewers for D81432: Add #includes so that ROCm.h is compilable stand-alone.: jyknight, echristo.
Jun 8 2020, 2:25 PM · Restricted Project

Jun 1 2020

saugustine committed rGf027cfa37e67: For --relativenames, ignore directory 0, which is the comp_dir. (authored by saugustine).
For --relativenames, ignore directory 0, which is the comp_dir.
Jun 1 2020, 1:34 PM
saugustine closed D80168: For --relativenames, handle dwarf absolute include directories similarly to compilation directories..
Jun 1 2020, 1:33 PM · Restricted Project

May 29 2020

saugustine added a comment to D80168: For --relativenames, handle dwarf absolute include directories similarly to compilation directories..

I have added the necessary debug info to the .s file--it is a fairly minimal set. I have also removed the checked in binary.

May 29 2020, 2:14 PM · Restricted Project
saugustine updated the diff for D80168: For --relativenames, handle dwarf absolute include directories similarly to compilation directories..

Address upstream concerns about a checked-in binary for the test case.

May 29 2020, 2:14 PM · Restricted Project

May 28 2020

saugustine added a comment to D80168: For --relativenames, handle dwarf absolute include directories similarly to compilation directories..

Yeah, I'm kind of inclined to agree with @aprantl here - when the client asks for relative names I could see how that'd be reasonable to say "don't add the compilation dir" but I'm not sure what it means for other paths/doesn't necessarily seem reasonable for it to mean "give me back the unqualified name" even if it's relative to some other/unknown directory.

How would the client then know where to find this name relative to?

May 28 2020, 10:59 AM · Restricted Project
saugustine updated the diff for D80168: For --relativenames, handle dwarf absolute include directories similarly to compilation directories..

Update for upstream comments.

May 28 2020, 10:23 AM · Restricted Project

May 26 2020

saugustine added a comment to D79924: [gdb] Decay type before passing into printer.

This is puzzling to me, as we use this internally at Google all over the place, and it seems to work just fine. So I'm surprised we haven't noticed anything.

May 26 2020, 10:16 AM

May 21 2020

saugustine added inline comments to D80168: For --relativenames, handle dwarf absolute include directories similarly to compilation directories..
May 21 2020, 10:15 AM · Restricted Project
saugustine updated the diff for D80168: For --relativenames, handle dwarf absolute include directories similarly to compilation directories..

Address comments

May 21 2020, 10:15 AM · Restricted Project

May 19 2020

saugustine added a comment to D80168: For --relativenames, handle dwarf absolute include directories similarly to compilation directories..

Ping on this?

May 19 2020, 6:43 PM · Restricted Project

May 18 2020

saugustine created D80168: For --relativenames, handle dwarf absolute include directories similarly to compilation directories..
May 18 2020, 4:17 PM · Restricted Project

Apr 28 2020

saugustine committed rG3421d1ede4c1: Make getCompileUnitForAddress public. (authored by saugustine).
Make getCompileUnitForAddress public.
Apr 28 2020, 5:18 PM
saugustine closed D79048: Make getCompileUnitForAddress public..
Apr 28 2020, 5:18 PM · Restricted Project
saugustine created D79048: Make getCompileUnitForAddress public..
Apr 28 2020, 3:40 PM · Restricted Project
saugustine added reviewers for D79048: Make getCompileUnitForAddress public.: dblaikie, echristo.
Apr 28 2020, 3:40 PM · Restricted Project

Apr 23 2020

saugustine added inline comments to D70416: [Driver] Make -static-libgcc imply static libunwind.
Apr 23 2020, 4:52 PM · Restricted Project

Apr 17 2020

saugustine committed rGa4b88c044980: Revert "Implement _ExtInt as an extended int type specifier." (authored by saugustine).
Revert "Implement _ExtInt as an extended int type specifier."
Apr 17 2020, 10:48 AM
saugustine added a reverting change for rG61ba1481e200: Implement _ExtInt as an extended int type specifier.: rGa4b88c044980: Revert "Implement _ExtInt as an extended int type specifier.".
Apr 17 2020, 10:48 AM
saugustine added a comment to D73967: Implement _ExtInt as an extended int type specifier..

Reverted in a4b88c044980337bb14390be654fe76864aa60ec. Happy to approve an updated change.

Apr 17 2020, 10:47 AM · Restricted Project
saugustine added a comment to D73967: Implement _ExtInt as an extended int type specifier..

This change breaks the lldb build with

Apr 17 2020, 10:14 AM · Restricted Project

Apr 16 2020

saugustine added a comment to D77353: [WebAssembly] Add DW_OP_WASM_location_int.

Appreciate the quick fix. Thanks.

Apr 16 2020, 7:30 PM · debug-info, Restricted Project
saugustine added a comment to D77353: [WebAssembly] Add DW_OP_WASM_location_int.

The comparison on lines 81 and 82 of InputChunks.cpp is always true.

Apr 16 2020, 5:50 PM · debug-info, Restricted Project

Apr 15 2020

saugustine committed rGbf94c960071d: Write ignored output to stdout, so this test runs on read-only filesystems. (authored by saugustine).
Write ignored output to stdout, so this test runs on read-only filesystems.
Apr 15 2020, 10:57 AM
saugustine added a comment to D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.

The test in this commit writes to a local file (which it ignores). This makes it so the test can't run on a read-only file system. I have committed bf94c960071d338b7157ac7dee8120df50d5600f to fix.

Apr 15 2020, 10:56 AM · Restricted Project

Apr 13 2020

saugustine committed rG215e6bfcfb5a: Use a temporary file, to allow running on read-only file systems (authored by saugustine).
Use a temporary file, to allow running on read-only file systems
Apr 13 2020, 2:09 PM
saugustine added a comment to D77580: [llvm-objdump] Fix incomplete relocation output for -D -r mode .

As written, this test writes to the current directory, which assumes that the current directory is writable, but that is not true in all builds. I have committed 215e6bfcfb5af7713ec348f679c7be4d2f32dc82 to fix.

Apr 13 2020, 2:08 PM · Restricted Project

Apr 7 2020

saugustine accepted D77679: [libunwind] Fix UB in EHHeaderParser::findFDE.

Nice catch. Probably should wait for an unwind owner to accept though.

Apr 7 2020, 2:42 PM · Unknown Object (Project), Restricted Project

Apr 2 2020

saugustine added a comment to D77099: Exit unwinding early when at the top of the stack and additional info won't be found..

Don't know why Phab thinks compnerd's accepting the revision March 1, at 9:54 left it in an unaccepted state. Happy to revert it if necessary, but I don't think so.

Apr 2 2020, 12:28 PM · Unknown Object (Project), Restricted Project
saugustine committed rG71fbd6e40632: Exit unwinding early when at the top of the stack and additional info won't be… (authored by saugustine).
Exit unwinding early when at the top of the stack and additional info won't be…
Apr 2 2020, 11:23 AM
saugustine closed D77099: Exit unwinding early when at the top of the stack and additional info won't be found..
Apr 2 2020, 11:23 AM · Unknown Object (Project), Restricted Project

Mar 31 2020

saugustine committed rG21d9d0855be1: New symbolizer option to print files relative to the compilation directory. (authored by saugustine).
New symbolizer option to print files relative to the compilation directory.
Mar 31 2020, 10:00 AM
saugustine closed D76733: New symbolizer option to print files relative to the compilation directory..
Mar 31 2020, 10:00 AM · Restricted Project

Mar 30 2020

saugustine added a comment to D77099: Exit unwinding early when at the top of the stack and additional info won't be found..

The harbormaster failures can't possibly be related. For example, the failure below has nothing whatever to do with this change.

Mar 30 2020, 4:57 PM · Unknown Object (Project), Restricted Project
saugustine updated the diff for D76733: New symbolizer option to print files relative to the compilation directory..

Thanks for the comments, I think this catches them all.

Mar 30 2020, 4:24 PM · Restricted Project
saugustine added a comment to D76733: New symbolizer option to print files relative to the compilation directory..

updated for all comments.

Mar 30 2020, 4:24 PM · Restricted Project
saugustine added reviewers for D77099: Exit unwinding early when at the top of the stack and additional info won't be found.: jgorbe, mstorsjo, compnerd, miyuki, mclow.lists.
Mar 30 2020, 3:51 PM · Unknown Object (Project), Restricted Project
saugustine created D77099: Exit unwinding early when at the top of the stack and additional info won't be found..
Mar 30 2020, 3:51 PM · Unknown Object (Project), Restricted Project

Mar 26 2020

saugustine updated the diff for D76733: New symbolizer option to print files relative to the compilation directory..

clang-format fix

Mar 26 2020, 3:47 PM · Restricted Project
saugustine updated the diff for D76733: New symbolizer option to print files relative to the compilation directory..

Add missing file.

Mar 26 2020, 2:42 PM · Restricted Project
saugustine updated the diff for D76733: New symbolizer option to print files relative to the compilation directory..

Add documentation and otherwise address upstream comments.

Mar 26 2020, 2:08 PM · Restricted Project
saugustine committed rG6c6fba8808e6: Correctly handle using foo = std::foo inside namespaces. (authored by saugustine).
Correctly handle using foo = std::foo inside namespaces.
Mar 26 2020, 11:26 AM
saugustine closed D76816: Correctly handle using foo = std::foo inside namespaces..
Mar 26 2020, 11:25 AM · Restricted Project

Mar 25 2020

saugustine created D76816: Correctly handle using foo = std::foo inside namespaces..
Mar 25 2020, 6:25 PM · Restricted Project
saugustine added a reviewer for D76816: Correctly handle using foo = std::foo inside namespaces.: EricWF.
Mar 25 2020, 6:25 PM · Restricted Project

Mar 24 2020

saugustine updated the diff for D76733: New symbolizer option to print files relative to the compilation directory..

Remove short option. It only existed to be parallel to "-s", but conflicts
with options in gnu addr2line.

Mar 24 2020, 5:30 PM · Restricted Project
saugustine added a comment to D76733: New symbolizer option to print files relative to the compilation directory..

The clang-format recommendations would change the new options to not match the format of old ones. Not sure the best thing to do there.

Mar 24 2020, 3:39 PM · Restricted Project
saugustine added a comment to D76733: New symbolizer option to print files relative to the compilation directory..

This change looks good to me. My mere concern is about the option naming. In GNU addr2line, -r has a different meaning, and llvm-symbolizer can be used as llvm-addr2line (it is a crunched executable). If it does not cause too much inconvenience, I will hope we can make llvm-symbolizer and llvm-addr2line have consistent option names.

Mar 24 2020, 3:39 PM · Restricted Project
saugustine created D76733: New symbolizer option to print files relative to the compilation directory..
Mar 24 2020, 3:06 PM · Restricted Project

Mar 20 2020

saugustine committed rG5de4ba1770f4: Cleanup the plumbing for DILineInfoSpecifier. [NFC - Try 2] (authored by saugustine).
Cleanup the plumbing for DILineInfoSpecifier. [NFC - Try 2]
Mar 20 2020, 10:51 AM

Mar 19 2020

saugustine committed rG6343526d6400: Revert "Cleanup the plumbing for DILineInfoSpecifier. [NFC]" (authored by saugustine).
Revert "Cleanup the plumbing for DILineInfoSpecifier. [NFC]"
Mar 19 2020, 5:35 PM
saugustine added a reverting change for rG98ff6eb679cd: Cleanup the plumbing for DILineInfoSpecifier. [NFC]: rG6343526d6400: Revert "Cleanup the plumbing for DILineInfoSpecifier. [NFC]".
Mar 19 2020, 5:35 PM
saugustine committed rG98ff6eb679cd: Cleanup the plumbing for DILineInfoSpecifier. [NFC] (authored by saugustine).
Cleanup the plumbing for DILineInfoSpecifier. [NFC]
Mar 19 2020, 5:02 PM
saugustine closed D76394: Cleanup the plumbing for DILineInfoSpecifier. [NFC].
Mar 19 2020, 5:02 PM · Restricted Project

Mar 18 2020

saugustine created D76394: Cleanup the plumbing for DILineInfoSpecifier. [NFC].
Mar 18 2020, 4:19 PM · Restricted Project

Mar 12 2020

saugustine committed rG3758b858ef3b: Only run frameheader_cache_test.pass.cpp on x86_64. (authored by saugustine).
Only run frameheader_cache_test.pass.cpp on x86_64.
Mar 12 2020, 6:21 PM
saugustine committed rG3eef58991b26: Add a catch-all else case so any unanticipated configs pass this test. (authored by saugustine).
Add a catch-all else case so any unanticipated configs pass this test.
Mar 12 2020, 11:59 AM
saugustine committed rGc53c2058ffb8: Cache uwnind frame headers as they are found. (authored by saugustine).
Cache uwnind frame headers as they are found.
Mar 12 2020, 11:24 AM
saugustine closed D75954: Cache uwnind frame headers as they are found..
Mar 12 2020, 11:24 AM · Unknown Object (Project), Restricted Project, Restricted Project
saugustine updated the diff for D75954: Cache uwnind frame headers as they are found..

fix comment

Mar 12 2020, 9:13 AM · Restricted Project, Restricted Project, Restricted Project