Page MenuHomePhabricator

saugustine (Sterling Augustine)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 6 2015, 10:28 AM (201 w, 6 d)

Recent Activity

Yesterday

saugustine closed D67785: Use getTargetConstant for BLENDI, and add a test to catch it..
Thu, Sep 19, 7:38 PM · Restricted Project
saugustine committed rG52621307bcab: Use getTargetConstant for BLENDI, and add a test to catch it. (authored by saugustine).
Use getTargetConstant for BLENDI, and add a test to catch it.
Thu, Sep 19, 7:37 PM
saugustine committed rL372366: Use getTargetConstant for BLENDI, and add a test to catch it..
Use getTargetConstant for BLENDI, and add a test to catch it.
Thu, Sep 19, 7:35 PM
saugustine added a comment to rL372338: Reapply r372285 "GlobalISel: Don't materialize immarg arguments to intrinsics".

I fixed our problem with r372366.

Thu, Sep 19, 7:32 PM
saugustine added a comment to D67785: Use getTargetConstant for BLENDI, and add a test to catch it..

The x86isellowering change is great, see if you can't remove some of the branches before committing?

Thu, Sep 19, 7:32 PM · Restricted Project
saugustine added a comment to D67785: Use getTargetConstant for BLENDI, and add a test to catch it..

Committed as r372366.

Thu, Sep 19, 7:32 PM · Restricted Project
saugustine updated the diff for D67785: Use getTargetConstant for BLENDI, and add a test to catch it..
  • Tighten up the test case.
Thu, Sep 19, 7:26 PM · Restricted Project
saugustine created D67785: Use getTargetConstant for BLENDI, and add a test to catch it..
Thu, Sep 19, 6:59 PM · Restricted Project
saugustine added a comment to rL372338: Reapply r372285 "GlobalISel: Don't materialize immarg arguments to intrinsics".

Just a note that Google is seeing problems with this patch and may need to revert it. I'm working to get a sharable test case.

Thu, Sep 19, 5:12 PM

Wed, Sep 18

saugustine added a comment to D67315: [SimplifyCFG] mergeConditionalStoreToAddress(): consider cost, not instruction count.

When running test/Transforms/SimplifyCFG/merge-cond-stores-2.ll.test under address sanitizer, this revision creates a stack-use-after-scope failure at llvm/lib/Transforms/Utils/SimplifyCFG.cpp:3008:13:

Wed, Sep 18, 4:38 PM · Restricted Project
saugustine accepted D67733: Fix gdb_pretty_printer_test on python3.

Thanks so much for fixing this. Really appreciate it.

Wed, Sep 18, 2:03 PM · Restricted Project

Mon, Sep 16

saugustine added a comment to rL372009: [SimplifyCFG] FoldTwoEntryPHINode(): consider *total* speculation cost, not per….

I believe this change caused the failure below, but I think because the test should be updated, rather than a problem with the code. I would fix it, but I'm not sure what the right fix is.

Mon, Sep 16, 12:20 PM

Thu, Sep 5

saugustine added a comment to D67238: Add gdb pretty printers for a wide variety of libc++ data structures (take 2)..

Committed as r371131.

Thu, Sep 5, 2:52 PM · Restricted Project
saugustine committed rG3270941f1e7a: Add gdb pretty printers for a wide variety of libc++ data structures (take 2). (authored by saugustine).
Add gdb pretty printers for a wide variety of libc++ data structures (take 2).
Thu, Sep 5, 2:35 PM
saugustine committed rGa12779561729: Don't assume libcxx_gdb is always set. (authored by saugustine).
Don't assume libcxx_gdb is always set.
Thu, Sep 5, 2:35 PM
saugustine committed rL371131: Add gdb pretty printers for a wide variety of libc++ data structures (take 2)..
Add gdb pretty printers for a wide variety of libc++ data structures (take 2).
Thu, Sep 5, 2:35 PM
saugustine closed D67238: Add gdb pretty printers for a wide variety of libc++ data structures (take 2)..
Thu, Sep 5, 2:35 PM · Restricted Project
saugustine committed rL371130: Don't assume libcxx_gdb is always set..
Don't assume libcxx_gdb is always set.
Thu, Sep 5, 2:35 PM
saugustine created D67238: Add gdb pretty printers for a wide variety of libc++ data structures (take 2)..
Thu, Sep 5, 2:26 PM · Restricted Project
saugustine committed rGbf7602b261c7: Add testing infrastructure to check if gdb is available for testing. (authored by saugustine).
Add testing infrastructure to check if gdb is available for testing.
Thu, Sep 5, 1:45 PM
saugustine committed rL371120: Add testing infrastructure to check if gdb is available for testing..
Add testing infrastructure to check if gdb is available for testing.
Thu, Sep 5, 1:45 PM
saugustine added a comment to D67194: Add testing infrastructure to check if gdb is available for testing..

Thanks. Committed as r371120.

Thu, Sep 5, 1:44 PM · Restricted Project
saugustine closed D67194: Add testing infrastructure to check if gdb is available for testing..
Thu, Sep 5, 1:44 PM · Restricted Project

Wed, Sep 4

saugustine created D67194: Add testing infrastructure to check if gdb is available for testing..
Wed, Sep 4, 3:18 PM · Restricted Project

Fri, Aug 30

saugustine committed rG33e17db59105: Revert "Add gdb pretty printers for a wide variety of libc++ data structures." (authored by saugustine).
Revert "Add gdb pretty printers for a wide variety of libc++ data structures."
Fri, Aug 30, 5:06 PM
saugustine committed rL370553: Revert "Add gdb pretty printers for a wide variety of libc++ data structures.".
Revert "Add gdb pretty printers for a wide variety of libc++ data structures."
Fri, Aug 30, 5:00 PM
saugustine added a comment to D65609: Add gdb pretty printers for a wide variety of libc++ data structures..

Reverted because it broke some buildbots. Looking into why.

Fri, Aug 30, 5:00 PM · Restricted Project
saugustine committed rGd21a3e41a4cf: Add gdb pretty printers for a wide variety of libc++ data structures. (authored by saugustine).
Add gdb pretty printers for a wide variety of libc++ data structures.
Fri, Aug 30, 4:45 PM
saugustine added a comment to D65609: Add gdb pretty printers for a wide variety of libc++ data structures..

Thanks. Commited as r370551

Fri, Aug 30, 4:42 PM · Restricted Project
saugustine committed rL370551: Add gdb pretty printers for a wide variety of libc++ data structures..
Add gdb pretty printers for a wide variety of libc++ data structures.
Fri, Aug 30, 4:42 PM
saugustine closed D65609: Add gdb pretty printers for a wide variety of libc++ data structures..
Fri, Aug 30, 4:42 PM · Restricted Project

Mon, Aug 26

saugustine added a comment to D65609: Add gdb pretty printers for a wide variety of libc++ data structures..

Would someone please accept this patch, or let me know what else there is to be done?

Mon, Aug 26, 3:24 PM · Restricted Project

Aug 12 2019

saugustine added a comment to D65609: Add gdb pretty printers for a wide variety of libc++ data structures..

Anyone have any remaining thoughts?

Aug 12 2019, 12:11 PM · Restricted Project

Aug 5 2019

saugustine added a comment to D65609: Add gdb pretty printers for a wide variety of libc++ data structures..

wow. This is a fantastic amount of work. Thank you. No longer will libc++ accidentally break the pretty printers!

Aug 5 2019, 2:44 PM · Restricted Project
saugustine updated the diff for D65609: Add gdb pretty printers for a wide variety of libc++ data structures..
  • Run a pep8 formatter.
  • Address other comments from code review.
Aug 5 2019, 2:44 PM · Restricted Project

Aug 1 2019

saugustine added reviewers for D65609: Add gdb pretty printers for a wide variety of libc++ data structures.: rdhindsa, tamur.
Aug 1 2019, 2:59 PM · Restricted Project
saugustine added reviewers for D65609: Add gdb pretty printers for a wide variety of libc++ data structures.: dexonsmith, ldionne, thomasanderson.
Aug 1 2019, 2:59 PM · Restricted Project
saugustine created D65609: Add gdb pretty printers for a wide variety of libc++ data structures..
Aug 1 2019, 2:56 PM · Restricted Project

Jul 13 2019

saugustine added a comment to D64062: Remove __VERSION__.

From the failure mode I was seeing, any value at all for VERSION will be fine, as long as it is a valid preprocessor string.

Jul 13 2019, 10:43 AM · Restricted Project, Restricted Project

Jul 12 2019

saugustine added reviewers for D64687: [clang] Revert "Remove __VERSION__": rnk, dexonsmith, sylvestre.ledru.
Jul 12 2019, 7:46 PM · Restricted Project
saugustine added a comment to D64062: Remove __VERSION__.

The revert is at https://reviews.llvm.org/D64687, which I will commit shortly if there are no objections.

Jul 12 2019, 7:46 PM · Restricted Project, Restricted Project
saugustine created D64687: [clang] Revert "Remove __VERSION__".
Jul 12 2019, 7:46 PM · Restricted Project
saugustine added a comment to D64062: Remove __VERSION__.

This revision breaks python 2.7.16 builds, which are still supported by upstream python for a few more months. I'm preparing a revert.

Jul 12 2019, 7:28 PM · Restricted Project, Restricted Project
saugustine added a comment to rL365920: [IndVars] Use exit count reasoning to discharge obviously untaken exits.

After this revision lib/Transforms/Scalar/IndVarSimplify.cpp:2630 defines "Latch" which is only used inside an assert. This makes builds with -DNDEBUG fail with unused variable warnings.

Jul 12 2019, 11:53 AM
saugustine committed rG6d75a9e87365: The variable "Latch" is only used in an assert, which makes builds that use "… (authored by saugustine).
The variable "Latch" is only used in an assert, which makes builds that use "…
Jul 12 2019, 11:52 AM
saugustine committed rL365943: The variable "Latch" is only used in an assert, which makes builds that use "….
The variable "Latch" is only used in an assert, which makes builds that use "…
Jul 12 2019, 11:50 AM
saugustine closed D64654: The variable "Latch" is only used in an assert, which makes builds that use "-DNDEBUG" fail with unused variable messages..
Jul 12 2019, 11:50 AM · Restricted Project
saugustine created D64654: The variable "Latch" is only used in an assert, which makes builds that use "-DNDEBUG" fail with unused variable messages..
Jul 12 2019, 11:50 AM · Restricted Project

Jul 10 2019

saugustine committed rG05630a37455f: rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h… (authored by saugustine).
rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h…
Jul 10 2019, 4:39 PM
saugustine added a comment to D64541: rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h:108 but CompilationDatabase is only forward declared. This makes the header not compile standalone, because unique_ptrs expect to have the full-definition of the....

Committed as r365713.

Jul 10 2019, 4:38 PM · Restricted Project
saugustine committed rL365713: rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h….
rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h…
Jul 10 2019, 4:37 PM
saugustine updated the diff for D64541: rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h:108 but CompilationDatabase is only forward declared. This makes the header not compile standalone, because unique_ptrs expect to have the full-definition of the....

Remove other forward declaration also in the added header.

Jul 10 2019, 4:33 PM · Restricted Project
saugustine added a reviewer for D64541: rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h:108 but CompilationDatabase is only forward declared. This makes the header not compile standalone, because unique_ptrs expect to have the full-definition of the...: sammccall.
Jul 10 2019, 4:18 PM · Restricted Project
saugustine created D64541: rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h:108 but CompilationDatabase is only forward declared. This makes the header not compile standalone, because unique_ptrs expect to have the full-definition of the....
Jul 10 2019, 4:14 PM · Restricted Project

Jul 9 2019

saugustine added a comment to D64197: [HardwareLoops] NFC - move hardware loop checking code to isHardwareLoopProfitable().

This revision violates some rules about the build structure.

Jul 9 2019, 10:42 AM · Restricted Project

Jun 10 2019

saugustine added a comment to D62088: [compiler-rt][builtins] Scaled Integer log10().

I am absolutely not the right person to review the math. I think we need to trust that the author has it correct. The logic looks reasonable and the tests look basically thorough. I am inclined to accept it.

Jun 10 2019, 5:31 PM · Restricted Project, Restricted Project

May 30 2019

saugustine added a comment to D62088: [compiler-rt][builtins] Scaled Integer log10().

The number is the argument count plus one for return value. So this function should be named

May 30 2019, 1:47 PM · Restricted Project, Restricted Project
saugustine added a comment to D62088: [compiler-rt][builtins] Scaled Integer log10().

I can't speak to how useful this would be and for whom, but I'm not opposed to including it if Fuschia has a use for it.

May 30 2019, 1:43 PM · Restricted Project, Restricted Project

May 21 2019

saugustine accepted D59841: [Gnu Driver] Let -static-pie win if it is specified along with -pie or -static..
May 21 2019, 1:35 PM · Restricted Project

May 13 2019

saugustine committed rUNW360610: Add a new LIBUNWIND_WEAK_PTHREAD Cmake option to force.
Add a new LIBUNWIND_WEAK_PTHREAD Cmake option to force
May 13 2019, 12:26 PM
saugustine committed rG7981a28d9d30: Add a new LIBUNWIND_WEAK_PTHREAD Cmake option to force calls into the pthread… (authored by saugustine).
Add a new LIBUNWIND_WEAK_PTHREAD Cmake option to force calls into the pthread…
May 13 2019, 11:45 AM
saugustine committed rL360610: Add a new LIBUNWIND_WEAK_PTHREAD Cmake option to force.
Add a new LIBUNWIND_WEAK_PTHREAD Cmake option to force
May 13 2019, 11:44 AM
saugustine closed D60285: Make calls into the pthread library use weak symbols..
May 13 2019, 11:44 AM · Restricted Project

May 10 2019

saugustine added a comment to D60285: Make calls into the pthread library use weak symbols..

Any of the previous reviewers have a comment before I commit?

May 10 2019, 2:45 PM · Restricted Project

May 9 2019

saugustine updated the diff for D60285: Make calls into the pthread library use weak symbols..
  • Make LIBUNWIND_WEAK_PTHREAD a formal Cmake option.
May 9 2019, 3:38 PM · Restricted Project

May 8 2019

saugustine accepted D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++.
May 8 2019, 3:09 PM · Restricted Project, Restricted Project, Restricted Project
saugustine added a comment to D60285: Make calls into the pthread library use weak symbols..

I've now put the weak-reference version behind a non-default build option. Is this acceptable?

May 8 2019, 1:41 PM · Restricted Project
saugustine updated the diff for D60285: Make calls into the pthread library use weak symbols..
  • Add an option to make pthread symbol references weak.
May 8 2019, 1:40 PM · Restricted Project

Apr 23 2019

saugustine added a comment to D60285: Make calls into the pthread library use weak symbols..

Hi Nick--hope your vacation was good.

Apr 23 2019, 3:59 PM · Restricted Project

Apr 15 2019

saugustine added a comment to D60285: Make calls into the pthread library use weak symbols..

@kledzik

Nick, what do you think about adding weak symbols just for achieving this?

Apr 15 2019, 2:07 PM · Restricted Project

Apr 9 2019

saugustine added a comment to D60285: Make calls into the pthread library use weak symbols..

ping?

Apr 9 2019, 4:14 PM · Restricted Project

Apr 5 2019

saugustine added inline comments to D60285: Make calls into the pthread library use weak symbols..
Apr 5 2019, 1:51 PM · Restricted Project
saugustine added a comment to D60285: Make calls into the pthread library use weak symbols..

This is better than a no-op RWMutex because then the same binary works both when the application is multi-threaded and when it isn't. Therefore the build doesn't have to distinguish between the two cases.

Apr 5 2019, 11:26 AM · Restricted Project

Apr 4 2019

saugustine created D60285: Make calls into the pthread library use weak symbols..
Apr 4 2019, 2:10 PM · Restricted Project

Mar 26 2019

saugustine added inline comments to D59841: [Gnu Driver] Let -static-pie win if it is specified along with -pie or -static..
Mar 26 2019, 2:06 PM · Restricted Project

Mar 21 2019

saugustine committed rG7642289780b3: This test assumes that -rtlib defaults to libgcc. But that isn't true in the… (authored by saugustine).
This test assumes that -rtlib defaults to libgcc. But that isn't true in the…
Mar 21 2019, 4:30 PM
saugustine committed rC356724: This test assumes that -rtlib defaults to libgcc. But that isn't true in the….
This test assumes that -rtlib defaults to libgcc. But that isn't true in the…
Mar 21 2019, 4:29 PM
saugustine committed rL356724: This test assumes that -rtlib defaults to libgcc. But that isn't true in the….
This test assumes that -rtlib defaults to libgcc. But that isn't true in the…
Mar 21 2019, 4:29 PM
saugustine closed D59674: This test assumes that -rtlib defaults to libgcc. But that isn't true in the face of -DCLANG_DEFAULT_RTLIB=compiler-rt..
Mar 21 2019, 4:29 PM · Restricted Project
saugustine added a reviewer for D59674: This test assumes that -rtlib defaults to libgcc. But that isn't true in the face of -DCLANG_DEFAULT_RTLIB=compiler-rt.: rdhindsa.
Mar 21 2019, 4:29 PM · Restricted Project
saugustine created D59674: This test assumes that -rtlib defaults to libgcc. But that isn't true in the face of -DCLANG_DEFAULT_RTLIB=compiler-rt..
Mar 21 2019, 4:14 PM · Restricted Project

Mar 20 2019

saugustine committed rG86724e40bfa5: Make __cpu_model a hidden symbol, to match libgcc. Also hide… (authored by saugustine).
Make __cpu_model a hidden symbol, to match libgcc. Also hide…
Mar 20 2019, 10:37 AM
saugustine committed rCRT356581: Make __cpu_model a hidden symbol, to match libgcc..
Make __cpu_model a hidden symbol, to match libgcc.
Mar 20 2019, 10:37 AM
saugustine committed rL356581: Make __cpu_model a hidden symbol, to match libgcc..
Make __cpu_model a hidden symbol, to match libgcc.
Mar 20 2019, 10:37 AM
saugustine closed D59561: Make __cpu_model a hidden symbol, to match libgcc..
Mar 20 2019, 10:37 AM · Restricted Project
saugustine added a comment to D59561: Make __cpu_model a hidden symbol, to match libgcc..

Thanks. I've hidden a couple more symbols Please take another look.

Mar 20 2019, 10:10 AM · Restricted Project
saugustine updated the diff for D59561: Make __cpu_model a hidden symbol, to match libgcc..

Make cpu_model a hidden symbol, to match libgcc.
Also
cpu_features2 and __cpu_indicator_init.

Mar 20 2019, 10:10 AM · Restricted Project
saugustine updated the diff for D59561: Make __cpu_model a hidden symbol, to match libgcc..
  • Also hide __cpu_inicator_init for similar reasons.
Mar 20 2019, 9:52 AM · Restricted Project

Mar 19 2019

saugustine created D59561: Make __cpu_model a hidden symbol, to match libgcc..
Mar 19 2019, 2:05 PM · Restricted Project
saugustine added reviewers for D59561: Make __cpu_model a hidden symbol, to match libgcc.: asbirlea, echristo.
Mar 19 2019, 2:05 PM · Restricted Project
saugustine committed rG6271606969e2: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2] (authored by saugustine).
Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]
Mar 19 2019, 1:01 PM
saugustine committed rC356508: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]
Mar 19 2019, 1:01 PM
saugustine committed rL356508: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]
Mar 19 2019, 1:01 PM
saugustine closed D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Mar 19 2019, 1:00 PM · Restricted Project
saugustine added inline comments to D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Mar 19 2019, 12:57 PM · Restricted Project

Mar 18 2019

saugustine added a comment to D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].

I have now switched it to use --unwindlib=[libgcc|libunwind]

Mar 18 2019, 2:25 PM · Restricted Project
saugustine updated the diff for D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
  • Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]
  • Change option argument --unwindlib= from "compiler-rt" to "libunwind".
  • Fix tests syntax and driver checks for --unwindlib=
Mar 18 2019, 2:19 PM · Restricted Project
saugustine updated the diff for D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
  • Undo cpu model change.
Mar 18 2019, 11:31 AM · Restricted Project
saugustine updated the diff for D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Mar 18 2019, 11:25 AM · Restricted Project

Mar 14 2019

saugustine accepted D59387: Make getFullyQualifiedName qualify both the pointee and class type for member ptr types.

This looks correct to me, thanks for the fix.

Mar 14 2019, 2:54 PM · Restricted Project, Restricted Project