- User Since
- Nov 6 2015, 10:28 AM (230 w, 4 d)
Nice catch. Probably should wait for an unwind owner to accept though.
Thu, Apr 2
Don't know why Phab thinks compnerd's accepting the revision March 1, at 9:54 left it in an unaccepted state. Happy to revert it if necessary, but I don't think so.
Tue, Mar 31
Mon, Mar 30
The harbormaster failures can't possibly be related. For example, the failure below has nothing whatever to do with this change.
Thanks for the comments, I think this catches them all.
updated for all comments.
Thu, Mar 26
Add missing file.
Add documentation and otherwise address upstream comments.
Wed, Mar 25
Tue, Mar 24
Remove short option. It only existed to be parallel to "-s", but conflicts
with options in gnu addr2line.
The clang-format recommendations would change the new options to not match the format of old ones. Not sure the best thing to do there.
Fri, Mar 20
Thu, Mar 19
Wed, Mar 18
Thu, Mar 12
Wed, Mar 11
Correct the "do not run" cases to match the logic in AddressSpace.hpp.
Update test to only run when relevant.
Add tests, and minor formatting changes.
Add missing comment.
Update for upstream comments.
Tue, Mar 10
I have some tests nearing completion, but want to get started with the feedback now.
This looks fine to me.
Mon, Mar 9
Update for upstream comments
Switch boolean to a more clear enum to make call site clearer.
Move initialization to in class.
Mar 6 2020
I don't know why the linter wants me to indent everything another level. That is clearly not right given the surrounding code.
Fixing last linter complaint (the indent of the switch case), would include either re-indenting other cases involved in this switch, or having the cases not aligned. I think the current situation is better.
Mar 5 2020
Minor formatting fixes.
Mar 4 2020
Sorry for the trouble. Trying again in D75637. There really doesn't seem to be a clean way of #ifdeffing this.
Mar 3 2020
Update for clang tidy.
The clang-tidy and clang-format failures are all pre-existing, but that is hard to tell from the refactor.
Fix small clang-tidy complaint.
Mar 2 2020
Feb 12 2020
Feb 11 2020
I think this fixes everything. OK to submit?
Address upstream comments.
Feb 7 2020
Update for comments.
Feb 6 2020
Rebase for split out changes, and add a test.