- User Since
- Nov 6 2015, 10:28 AM (412 w, 3 d)
Thu, Sep 14
I am unable to reproduce this failure inside the docker container. Neither with the base ABI nor the unstable ABI. It works fine as far as I can tell, at least with clang-18.
Wed, Sep 13
I would expect this to work with gdb 12, but I don't know if Ubuntu 22 actually did switch to dwarf 5, (some distros patched the switch out until all their dwarf consumers were updated.)
Tue, Sep 5
I believe it was the switch to dwarf5 by default that caused it.
I'm having trouble finding our original conversation about this, but the issue is that the version of gdb in the docker image is too old for all of the debug info that clang currently produces. It just so happens that this is the test that shows this. I'll look some more for the previous discussion.
Aug 23 2023
Adjust based on feedback
Aug 21 2023
Any last comments on this?
Aug 17 2023
Switch to _LIBUNWIND_SUPPORT_FRAME_APIS a build-time option
Aug 15 2023
What exactly do you recommend here? The situation is pretty messy.
Jul 14 2023
Switch to pure revert.
Jul 13 2023
Jul 12 2023
Jul 11 2023
Because assertions compile to empty when built in opt mode, EmulateUnsupportedFloats.cpp:82 had an unused variable. So I propagated that unused variable into the assert in 5671f023042b558d38c3b777ee4ae0ad037b1867.
Jun 8 2023
What other progress reporting needs rate limiting?
Jun 6 2023
May 26 2023
I'll let someone with a better understanding of the proper implementation take it from here.
May 25 2023
May 24 2023
Any more thoughts on this from the reviewers?
May 23 2023
This change is causing some link failures on an internal project of the form below. The code is very old. What is the proper fix?
May 22 2023
This change causes an assertion failure on the following test case. The memset is important for some reason.
May 19 2023
Moved the rate-limiting to Debugger.[cpp|h]
May 17 2023
This update switches to a time-based approach as suggested by Jordan. However, the timing is about the same as the original. I believe because calling getCurrentTime every iteration is comparably slow as printing the progress report itself.
Switch rate-limiting to a time-based mechanism
Swtich rate-limiting to a time-based mechanism.
Apr 17 2023
Feb 16 2023
Thanks for the quick fix.
I don't think this necessarily matters or is a reason to revert, but we are seeing issues with this patch and swig 3.0.2, that disappear with swig 4.0.
Feb 15 2023
I don't see any vectors in that test...
This isn't the best reproducer, but it's as small as bugpoint can make it. Worth turning into a real test?
The fix does work. But I'm still trying to get a reproducer for the future.
I think it probably needs to also check if the type is Simple, because the exact assertion that fails is isSimple.
I have tracked an obscure failure down to this change. Still working on getting a reproducer suitable for public consumption, but the stack trace is below. It does go right through several of the places this commit touched.
Feb 13 2023
Committed as 5402110e0123ca323a5f6eaa3ed225027ce0179b
Dec 13 2022
Dec 4 2022
We are seeing constexpr failures with this change. They look like this:
Nov 30 2022
Oct 14 2022
The newly added test func-attr.c fails when run in opt mode. If it is expected to run only at a certain optimization level, it should probably include that level in the test itself. I don't think it seriously blocks anything, but would be good to fix.
This appears to cause some subtle misbehavior on Arm. I am working on the author to get a good testcase and will revert shortly.
Oct 13 2022
This is a straight forward change and I don't believe the libfuzzer failures are related.
Oct 11 2022
Committed as e4d5daaf91f6719626fa36c75e553e91778b94a9
Oct 10 2022
Circling back to this.
Aug 30 2022
Aug 29 2022
This is also largely mechanical, and the tests are thorough.
This is largely mechanical, so mostly looks good with a minor nit.
This is mostly mechanical, and the tests look correct to me. So ready.
Aug 26 2022
Aug 24 2022
Aug 23 2022
All very basic and straightforward. Not much to go wrong here.
Aug 22 2022
Aug 19 2022
As this is primarily boilerplate, mostly looks good. Just one minor fix.
I have access to an up-to-date copy of the isa book and can review these for technical correctness. I'm less familiar with style issues.
This patch is straightforward and correct.
OK with one minor change.
One minor nit, but otherwise this looks good.
Jul 11 2022
Why should these be different than the other constructors which don't take copies?
Jun 29 2022
Jun 21 2022
Jun 16 2022
I can't speak to the testing issues--perhaps it would be good to add them in a subsequent change. But getting correct code working again would be really good, and what is here addresses that.
It would be good to get this committed, as it fixes a previous break of otherwise correct source code and therefore anything testing against libc++ top of trunk.
Jun 14 2022
Jun 13 2022
I can't manage to get the buildbot environment working to test this. It consistently fails with
Apr 27 2022
Apr 14 2022