Page MenuHomePhabricator

saugustine (Sterling Augustine)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 6 2015, 10:28 AM (292 w, 6 d)

Recent Activity

Thu, Jun 10

saugustine committed rG1d3873d41eca: Move variable only used inside an assert into the assert. (authored by saugustine).
Move variable only used inside an assert into the assert.
Thu, Jun 10, 1:15 PM

Tue, Jun 8

saugustine committed rGe11b5b87bebf: Add Twine support for std::string_view. (authored by saugustine).
Add Twine support for std::string_view.
Tue, Jun 8, 8:30 PM
saugustine closed D103935: Add Twine support for std::string_view..
Tue, Jun 8, 8:30 PM · Restricted Project
saugustine added inline comments to D103935: Add Twine support for std::string_view..
Tue, Jun 8, 8:18 PM · Restricted Project
saugustine updated the diff for D103935: Add Twine support for std::string_view..

This addresses the upstream comments.

Tue, Jun 8, 7:51 PM · Restricted Project
saugustine added inline comments to D103935: Add Twine support for std::string_view..
Tue, Jun 8, 5:15 PM · Restricted Project
saugustine updated the diff for D103935: Add Twine support for std::string_view..

Small fix for prototype.

Tue, Jun 8, 5:10 PM · Restricted Project
saugustine added a reviewer for D103935: Add Twine support for std::string_view.: jyknight.
Tue, Jun 8, 5:06 PM · Restricted Project
saugustine updated the summary of D103935: Add Twine support for std::string_view..
Tue, Jun 8, 5:05 PM · Restricted Project
saugustine requested review of D103935: Add Twine support for std::string_view..
Tue, Jun 8, 5:03 PM · Restricted Project

Thu, Jun 3

saugustine added a comment to D103039: [AST] fully-qualify template args of outer types in getFullyQualifiedType.

Committed as 3e55f55048387a8efef01e445d46fc5cf100285d.

Thu, Jun 3, 10:52 AM · Restricted Project
saugustine committed rG3e55f5504838: Fully-qualify template args of outer types in getFullyQualifiedType (authored by victordk).
Fully-qualify template args of outer types in getFullyQualifiedType
Thu, Jun 3, 10:51 AM

Wed, Jun 2

saugustine accepted D103039: [AST] fully-qualify template args of outer types in getFullyQualifiedType.

This is a long-standing bug that needed to be fixed. Thank you!

Wed, Jun 2, 8:19 AM · Restricted Project

Thu, May 27

saugustine accepted D102359: [libc++] [test] Fix a few tests for 32-bit x86.
Thu, May 27, 2:20 PM · Restricted Project

Apr 26 2021

saugustine committed rGfe1555607716: Support leak sanitizer in libcxx. (authored by saugustine).
Support leak sanitizer in libcxx.
Apr 26 2021, 2:20 PM
saugustine committed rG0e8378032597: Don't fail the shared_ptr test if libc++ has insufficient debug info. (authored by saugustine).
Don't fail the shared_ptr test if libc++ has insufficient debug info.
Apr 26 2021, 2:20 PM
saugustine closed D100775: Support leak sanitizer in libcxx..
Apr 26 2021, 2:20 PM · Restricted Project

Apr 20 2021

saugustine committed rG55b7061116b5: Tolerate missing debug info in the shared_ptr pretty printer. (authored by saugustine).
Tolerate missing debug info in the shared_ptr pretty printer.
Apr 20 2021, 9:53 AM
saugustine closed D100610: Don't fail the shared_ptr test if libc++ has insufficient debug info..
Apr 20 2021, 9:53 AM · Restricted Project
saugustine added a comment to D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529).

The assumption is that memory still reachable at program termination, but not deallocated, has not leaked. And it is how all three of LSAN, Valgrind, and HeapLeakChecker define it.

Apr 20 2021, 8:51 AM · Restricted Project

Apr 19 2021

saugustine added a comment to D100610: Don't fail the shared_ptr test if libc++ has insufficient debug info..

Thanks for the review. I reworked to take a somewhat different approach--this improves the printer itself to tolerate the situation quite a bit better. But I have included your improved comment at the decision point.

Apr 19 2021, 3:28 PM · Restricted Project
saugustine updated the diff for D100610: Don't fail the shared_ptr test if libc++ has insufficient debug info..

Dramatically rework the last attempt.

Apr 19 2021, 3:26 PM · Restricted Project
saugustine requested review of D100775: Support leak sanitizer in libcxx..
Apr 19 2021, 10:57 AM · Restricted Project

Apr 15 2021

saugustine added a reviewer for D100610: Don't fail the shared_ptr test if libc++ has insufficient debug info.: dblaikie.
Apr 15 2021, 6:07 PM · Restricted Project
saugustine requested review of D100610: Don't fail the shared_ptr test if libc++ has insufficient debug info..
Apr 15 2021, 6:06 PM · Restricted Project
saugustine accepted D99532: [libcxx] Make the GDB pretty printer test less strict.
Apr 15 2021, 4:11 PM · Restricted Project
saugustine added a comment to D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529).

Let's see what happens in the discussion on llvm-dev before moving forward with this patch.

Apr 15 2021, 7:48 AM · Restricted Project

Apr 14 2021

saugustine added a reverting change for rG82f0e3d3ea6b: Simplify BitVector code: rG8f9477b067b0: Revert "Simplify BitVector code".
Apr 14 2021, 6:07 PM
saugustine committed rG8f9477b067b0: Revert "Simplify BitVector code" (authored by saugustine).
Revert "Simplify BitVector code"
Apr 14 2021, 6:07 PM
saugustine added a reverting change for D100387: Simplify BitVector code: rG8f9477b067b0: Revert "Simplify BitVector code".
Apr 14 2021, 6:07 PM · Restricted Project
saugustine added a comment to D100387: Simplify BitVector code.

I have tracked the asan build bot breakage to this change. See below.

Apr 14 2021, 6:05 PM · Restricted Project
saugustine committed rGd2bb3cbbf8bc: Make test runnable on read-only file systems. (authored by saugustine).
Make test runnable on read-only file systems.
Apr 14 2021, 1:30 PM
saugustine added a comment to D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529).

I have opened the discussion on llvm-dev. I do want to find a solution that everyone can live with, and I apologize that it felt like Google was stepping over its bounds.

Apr 14 2021, 9:44 AM · Restricted Project

Apr 13 2021

saugustine added a comment to D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529).

Another question to ask is:

Apr 13 2021, 10:05 PM · Restricted Project
saugustine added a comment to D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529).

I think it is a valid transformation.

Apr 13 2021, 10:02 PM · Restricted Project
saugustine added a comment to D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529).

I went ahead and reverted. We can discuss a plan--hopefully the internal cleanup to obviate this will go smoothly.

Apr 13 2021, 5:49 PM · Restricted Project
saugustine added a reverting change for rGdbc16ed199dc: [GlobalOpt] Revert valgrind hacks: rG32e264921b7a: Revert "[GlobalOpt] Revert valgrind hacks".
Apr 13 2021, 5:47 PM
saugustine committed rG32e264921b7a: Revert "[GlobalOpt] Revert valgrind hacks" (authored by saugustine).
Revert "[GlobalOpt] Revert valgrind hacks"
Apr 13 2021, 5:47 PM
saugustine added a reverting change for D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529): rG32e264921b7a: Revert "[GlobalOpt] Revert valgrind hacks".
Apr 13 2021, 5:47 PM · Restricted Project
saugustine added a comment to D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529).

I don't know why the various people you added didn't respond. This is unfortunate.

Apr 13 2021, 4:32 PM · Restricted Project

Apr 12 2021

saugustine added a comment to rGf2e4f3eff3c9: Reapply "[DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs….

I'm also having problems with this commit, only I'm seeing it without assertions. Working on a smaller repro, but will revert soon.

Apr 12 2021, 6:10 PM
saugustine added a reverting change for rG63bc9e443502: [clangd] Provide a way to disable external index: rGc2ad7c23707c: Revert "[clangd] Provide a way to disable external index".
Apr 12 2021, 2:40 PM
saugustine committed rGc2ad7c23707c: Revert "[clangd] Provide a way to disable external index" (authored by saugustine).
Revert "[clangd] Provide a way to disable external index"
Apr 12 2021, 2:40 PM
saugustine added a reverting change for D100106: [clangd] Provide a way to disable external index: rGc2ad7c23707c: Revert "[clangd] Provide a way to disable external index".
Apr 12 2021, 2:40 PM · Restricted Project
saugustine added a comment to D100106: [clangd] Provide a way to disable external index.

This change breaks llvm-project/clang-tools-extra/clangd/tool/ClangdMain.cpp:570:11: error: enumeration value 'None' not handled in switch [-Werror,-Wswitch]. I would fix forward, but the solution is not obvious to me.

Apr 12 2021, 2:17 PM · Restricted Project

Feb 18 2021

saugustine committed rGfc97a63db0d3: Move a second variable only used in an assert into the assert. (authored by saugustine).
Move a second variable only used in an assert into the assert.
Feb 18 2021, 1:26 PM
saugustine added a comment to D85176: [Coverage] Emit gap region after conditions when macro is present..

This commit introduced an unused variable warning when built without asserts. (CoverageMappingGen.cpp:984) I have fixed it with rG4544a63b7705.

Feb 18 2021, 1:17 PM · Restricted Project
saugustine committed rG4544a63b7705: Move variable only used in an assert into the assert. (authored by saugustine).
Move variable only used in an assert into the assert.
Feb 18 2021, 1:11 PM

Feb 17 2021

saugustine added a comment to rG05c64ea6722b: [DAG] Fold shuffle(bop(shuffle(x,y),shuffle(z,w)),bop(shuffle(a,b),shuffle(c….

Thanks for the quick fix.

Feb 17 2021, 8:57 AM

Feb 16 2021

saugustine added a comment to D96345: [DAG] Fold shuffle(bop(shuffle(x,y),shuffle(z,w)),bop(shuffle(a,b),shuffle(c,d))).

this is as small as llvm-reduce makes the ir:

Feb 16 2021, 2:14 PM · Restricted Project
saugustine added a comment to D96345: [DAG] Fold shuffle(bop(shuffle(x,y),shuffle(z,w)),bop(shuffle(a,b),shuffle(c,d))).

Reverted in 5aa8f4c0843a68a24cb37dce5c0248c849d7d476

Feb 16 2021, 12:50 PM · Restricted Project
saugustine added a reverting change for rG5dfba562dd24: [DAG] Fold shuffle(bop(shuffle(x,y),shuffle(z,w)),bop(shuffle(a,b),shuffle(c…: rG5aa8f4c0843a: Revert "[DAG] Fold shuffle(bop(shuffle(x,y),shuffle(z,w)),bop(shuffle(a,b)….
Feb 16 2021, 12:49 PM
saugustine committed rG5aa8f4c0843a: Revert "[DAG] Fold shuffle(bop(shuffle(x,y),shuffle(z,w)),bop(shuffle(a,b)… (authored by saugustine).
Revert "[DAG] Fold shuffle(bop(shuffle(x,y),shuffle(z,w)),bop(shuffle(a,b)…
Feb 16 2021, 12:49 PM
saugustine added a reverting change for D96345: [DAG] Fold shuffle(bop(shuffle(x,y),shuffle(z,w)),bop(shuffle(a,b),shuffle(c,d))): rG5aa8f4c0843a: Revert "[DAG] Fold shuffle(bop(shuffle(x,y),shuffle(z,w)),bop(shuffle(a,b)….
Feb 16 2021, 12:49 PM · Restricted Project
saugustine added a comment to D96345: [DAG] Fold shuffle(bop(shuffle(x,y),shuffle(z,w)),bop(shuffle(a,b),shuffle(c,d))).

Unfortunately, this commit causes a segfault with the test case below. I'm intend to revert it shortly.

Feb 16 2021, 12:47 PM · Restricted Project

Feb 5 2021

saugustine committed rGa34b8b879e34: Various minor fixes for python 3 (authored by saugustine).
Various minor fixes for python 3
Feb 5 2021, 1:02 PM
saugustine closed D96167: Various minor fixes for python 3.
Feb 5 2021, 1:02 PM · Restricted Project
saugustine added a comment to D96167: Various minor fixes for python 3.

Ok, now it's a definite improvement.

Still 4 sub-tests fail for me:

FAIL: /tmp/portage/sys-libs/libcxx-12.0.0_rc1/work/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp:611
GDB printed:
   'Traceback (most recent call last):\n  File "/tmp/portage/sys-libs/libcxx-12.0.0_rc1/work/libcxx/test/libcxx/gdb/../../../utils/gdb/libcxx/printers.py", line 315, in to_string\n    usecount = refcount["__shared_owners_"] + 1\ngdb.error: There is no member named __shared_owners_.\n'
Value should match:
   'std::shared_ptr<int> count 2, weak 0 containing = {__ptr_ = 0x[a-f0-9]+}'
FAIL: /tmp/portage/sys-libs/libcxx-12.0.0_rc1/work/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp:616
GDB printed:
   'Traceback (most recent call last):\n  File "/tmp/portage/sys-libs/libcxx-12.0.0_rc1/work/libcxx/test/libcxx/gdb/../../../utils/gdb/libcxx/printers.py", line 315, in to_string\n    usecount = refcount["__shared_owners_"] + 1\ngdb.error: There is no member named __shared_owners_.\n'
Value should match:
   'std::shared_ptr<int> count 3, weak 0 containing = {__ptr_ = 0x[a-f0-9]+}'
FAIL: /tmp/portage/sys-libs/libcxx-12.0.0_rc1/work/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp:622
GDB printed:
   'Traceback (most recent call last):\n  File "/tmp/portage/sys-libs/libcxx-12.0.0_rc1/work/libcxx/test/libcxx/gdb/../../../utils/gdb/libcxx/printers.py", line 315, in to_string\n    usecount = refcount["__shared_owners_"] + 1\ngdb.error: There is no member named __shared_owners_.\n'
Value should match:
   'std::shared_ptr<int> count 3, weak 1 containing = {__ptr_ = 0x[a-f0-9]+}'
FAIL: /tmp/portage/sys-libs/libcxx-12.0.0_rc1/work/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp:627
GDB printed:
   'Traceback (most recent call last):\n  File "/tmp/portage/sys-libs/libcxx-12.0.0_rc1/work/libcxx/test/libcxx/gdb/../../../utils/gdb/libcxx/printers.py", line 315, in to_string\n    usecount = refcount["__shared_owners_"] + 1\ngdb.error: There is no member named __shared_owners_.\n'
Value should match:
   'std::shared_ptr<int> count 3, weak 0 containing = {__ptr_ = 0x[a-f0-9]+}'
Feb 5 2021, 12:29 PM · Restricted Project
saugustine added a comment to D96167: Various minor fixes for python 3.

I haven't tested it on main but on top of 12.0.0-rc1:

Feb 5 2021, 12:19 PM · Restricted Project
saugustine updated the diff for D96167: Various minor fixes for python 3.

Undo an auto-lint fix that breaks the string.

Feb 5 2021, 12:17 PM · Restricted Project
saugustine added reviewers for D96167: Various minor fixes for python 3: mgorny, ldionne.
Feb 5 2021, 11:48 AM · Restricted Project
saugustine requested review of D96167: Various minor fixes for python 3.
Feb 5 2021, 11:47 AM · Restricted Project

Jan 19 2021

saugustine accepted D94481: [llvm-symbolizer][doc] Reorder --relativenames in options list.
Jan 19 2021, 8:22 AM · Restricted Project

Dec 21 2020

saugustine accepted D93327: [PowerPC] Restore stack ptr from base ptr when available.

This patch does fix several problems we noticed at Google that were created by the previous patch. I'm not qualified to judge the technical approach, without this, asan is completely broken on powerpc, so that speaks strongly in its favor.

Dec 21 2020, 11:41 AM · Restricted Project, Restricted Project

Dec 15 2020

saugustine added a comment to D93130: [libc++] Refactor allocate_shared to use an allocation guard.

This change appears to have dropped a constructor, or maybe two. I'm not familiar enough with all the requirements to know if that is correct or not. Here is a somewhat redacted version of the errors I get building a private application.
...

Is it possible that your custom Allocator has its converting copy constructor (from other specializations of Allocator) marked as explicit? We don't seem to have a test for that, I'll add one and fix this, but please confirm that it's the case.

Dec 15 2020, 8:45 AM · Restricted Project

Dec 14 2020

saugustine added a comment to D93130: [libc++] Refactor allocate_shared to use an allocation guard.

This change appears to have dropped a constructor, or maybe two. I'm not familiar enough with all the requirements to know if that is correct or not. Here is a somewhat redacted version of the errors I get building a private application.

Dec 14 2020, 10:06 PM · Restricted Project

Nov 13 2020

saugustine added a comment to D91434: [libc++] Move the GDB pretty printer tests to the DSL.

The reason this hasn't been run by default is due to python versioning issues with gdb, the system it runs on, and the tests themselves. There are certain cross-platform issues as well.

Nov 13 2020, 9:05 AM · Restricted Project

Nov 3 2020

saugustine accepted D90717: [llvm] Add a test for debug info generated with split functions..

I can't speak to its technical correctness, but this is exactly the test I requested and it looks good at a high level.

Nov 3 2020, 2:53 PM · Restricted Project

Oct 17 2020

saugustine added a comment to rG5415fef3abef: [InstCombine] matchFunnelShift - support non-uniform constant vector shift….

Filed https://bugs.llvm.org/show_bug.cgi?id=47891 to continue discussion.

Oct 17 2020, 9:33 AM
saugustine added a comment to D88420: [InstCombine] matchFunnelShift - support non-uniform constant vector shift amounts (PR46895).

Filed https://bugs.llvm.org/show_bug.cgi?id=47891 to continue discussion.

Oct 17 2020, 9:32 AM · Restricted Project
saugustine added a comment to D88420: [InstCombine] matchFunnelShift - support non-uniform constant vector shift amounts (PR46895).

Here is a relatively simple, self-contained testcase. Of interest is that the entire loop needs to be present, and completely unwound for this bug to show. It looks to me like either next_carry or carry is mis-calculated or stale on the ninth iteration which fills the second-to-last element.

Oct 17 2020, 9:08 AM · Restricted Project

Oct 16 2020

saugustine added a comment to D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..
Oct 16 2020, 4:55 PM · Restricted Project
saugustine added a comment to rG5415fef3abef: [InstCombine] matchFunnelShift - support non-uniform constant vector shift….

I spoke too soon. Disabling optimization on that function does fix the problem, but its input and output is all the same. So the miscompile must just not get tickled by that. Will dig a little deeper.

Oct 16 2020, 2:27 PM
saugustine added a comment to rG5415fef3abef: [InstCombine] matchFunnelShift - support non-uniform constant vector shift….
Oct 16 2020, 2:21 PM
saugustine added a comment to rG5415fef3abef: [InstCombine] matchFunnelShift - support non-uniform constant vector shift….

The miscompiled function is probably:

Oct 16 2020, 2:12 PM
saugustine added a comment to D88420: [InstCombine] matchFunnelShift - support non-uniform constant vector shift amounts (PR46895).

It is a miscompile--or, at least a fingerprint is being miscomputed. The failure check is here:

Oct 16 2020, 10:23 AM · Restricted Project

Oct 13 2020

saugustine added a comment to D88834: [InstCombine] matchRotate - add support for matching general funnel shifts with constant shift amounts (PR46896).

PowerPC still doesn't seem to be fixed as of 6713332fddb7. We have someone trying to narrow it down.

Oct 13 2020, 5:31 PM · Restricted Project

Oct 12 2020

saugustine added a comment to D88834: [InstCombine] matchRotate - add support for matching general funnel shifts with constant shift amounts (PR46896).

Google has tracked down a failure in openssl for powerpc to this change. (And the fix for the 32-bit vs 64-bit issue below doesn't seem to fix this.)

Oct 12 2020, 8:19 PM · Restricted Project

Oct 9 2020

saugustine added inline comments to D88201: [DAGCombiner] Add decomposition patterns for Mul-by-Imm..
Oct 9 2020, 6:48 PM · Restricted Project

Oct 7 2020

saugustine accepted D89022: Remove unused variables.
Oct 7 2020, 6:30 PM · Restricted Project

Oct 5 2020

saugustine added inline comments to D87494: Improve LSR debug-info.
Oct 5 2020, 12:24 PM · Restricted Project, debug-info

Sep 21 2020

saugustine accepted D87880: [libunwind] Combine dl_iterate_phdr codepaths for DWARF and EHABI.
Sep 21 2020, 10:56 AM · Restricted Project, Restricted Project
saugustine accepted D87881: [libunwind] Optimize dl_iterate_phdr's findUnwindSectionsByPhdr.
Sep 21 2020, 10:55 AM · Restricted Project, Restricted Project

Sep 10 2020

saugustine abandoned D85231: Protect against filenames with no extension at all..
Sep 10 2020, 9:46 AM · Restricted Project

Sep 2 2020

saugustine accepted D86768: [libunwind] Replace chain-of-ifdefs for dl_iterate_phdr.

I am going to accept this, since no one else seems to be able to review it. But the problem here is that no one really knows what a simplified ifdef chain with the same functionality looks like. I tried a couple of times and failed miserably.

Sep 2 2020, 5:03 PM · Restricted Project, Restricted Project

Aug 19 2020

saugustine accepted D86254: [libunwind] Minor fixes in libunwind.

Looks good from the FrameHeaderCache side.

Aug 19 2020, 5:19 PM · Restricted Project, Restricted Project

Aug 18 2020

saugustine committed rGa20f5fe70810: Default to disabling the libunwind frameheader cache. (authored by saugustine).
Default to disabling the libunwind frameheader cache.
Aug 18 2020, 2:38 PM
saugustine closed D86163: Default to disabling the libunwind frameheader cache.
Aug 18 2020, 2:38 PM · Restricted Project, Restricted Project
saugustine retitled D86163: Default to disabling the libunwind frameheader cache from Allow enabling the libunwind frameheader cache at configure time. to Default to disabling the libunwind frameheader cache.
Aug 18 2020, 2:36 PM · Restricted Project, Restricted Project
saugustine updated the diff for D86163: Default to disabling the libunwind frameheader cache.

Update for comment.

Aug 18 2020, 2:35 PM · Restricted Project, Restricted Project
saugustine added a comment to D86163: Default to disabling the libunwind frameheader cache.

Now just waiting on a libunwind group reviewer.

Aug 18 2020, 2:24 PM · Restricted Project, Restricted Project
saugustine updated the diff for D86163: Default to disabling the libunwind frameheader cache.

Rework to match bsd workaround.

Aug 18 2020, 2:18 PM · Restricted Project, Restricted Project
saugustine added reviewers for D86163: Default to disabling the libunwind frameheader cache: hans, jgorbe.
Aug 18 2020, 12:09 PM · Restricted Project, Restricted Project
saugustine requested review of D86163: Default to disabling the libunwind frameheader cache.
Aug 18 2020, 12:08 PM · Restricted Project, Restricted Project
saugustine added a comment to D75954: Cache uwnind frame headers as they are found..
In D75954#2219870, @dim wrote:

It looks like the need for some locking in this FrameHeaderCache was completely overlooked? Or at least, having a cache per thread would make locking unnecessary, but it would cost more memory.

Well, not _completely_ overlooked. Looks like glibc locks things and other libc's don't. Should be easy to add a lock here for non glibc targets.

Sterling, do you think this will be fixed soon so we can get it in the llvm 11 release?

Aug 18 2020, 9:25 AM · Restricted Project, Restricted Project, Restricted Project

Aug 16 2020

saugustine added a comment to D75954: Cache uwnind frame headers as they are found..
In D75954#2219870, @dim wrote:

It looks like the need for some locking in this FrameHeaderCache was completely overlooked? Or at least, having a cache per thread would make locking unnecessary, but it would cost more memory.

Aug 16 2020, 12:51 PM · Restricted Project, Restricted Project, Restricted Project

Aug 6 2020

saugustine added a comment to D85145: Use syntax highlighting also in gui mode.

This change has a subtle isse with wattr_get and friends: saved_opts isn't actually used, and the documentation for them says to always pass a nullptr. "The parameter opts is reserved for future use, applications must supply a null pointer."

Aug 6 2020, 10:26 AM · Restricted Project
saugustine committed rG9dbdaea9a0e6: Remove unused variable "saved_opts". (authored by saugustine).
Remove unused variable "saved_opts".
Aug 6 2020, 10:21 AM

Aug 4 2020

saugustine added a comment to D85231: Protect against filenames with no extension at all..

The darwin-dsymutil.c tests this code path right now on line 33. I found this error by running it under asan; otherwise it was fully latent.

Aug 4 2020, 1:42 PM · Restricted Project
saugustine requested review of D85231: Protect against filenames with no extension at all..
Aug 4 2020, 11:27 AM · Restricted Project