Page MenuHomePhabricator

saugustine (Sterling Augustine)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 6 2015, 10:28 AM (347 w, 4 d)

Recent Activity

Wed, Jun 29

saugustine accepted D128841: [Driver] Always use --as-needed with libunwind.
Wed, Jun 29, 11:18 AM · Restricted Project, Restricted Project

Tue, Jun 21

saugustine updated the diff for D124569: Re-enable libc++ gdb-pretty-printer tests for all versions of clang..

Rebased changes

Tue, Jun 21, 10:40 AM · Restricted Project, Restricted Project

Thu, Jun 16

saugustine accepted D127953: [libc++] Mark standard-mandated includes as such.

I can't speak to the testing issues--perhaps it would be good to add them in a subsequent change. But getting correct code working again would be really good, and what is here addresses that.

Thu, Jun 16, 2:58 PM · Restricted Project, Restricted Project
saugustine committed rGdf6087ee3794: Move debug-only code inside LLVM_DEUG to prevent unused variable warnings. (authored by saugustine).
Move debug-only code inside LLVM_DEUG to prevent unused variable warnings.
Thu, Jun 16, 2:02 PM · Restricted Project, Restricted Project
saugustine added a comment to D127953: [libc++] Mark standard-mandated includes as such.

It would be good to get this committed, as it breaks otherwise correct source code and therefore anything testing against libc++ top of trunk.

Thu, Jun 16, 12:14 PM · Restricted Project, Restricted Project

Tue, Jun 14

saugustine accepted D127528: [Clang] Let the linker choose shared or static libunwind unless specified.
Tue, Jun 14, 3:45 PM · Restricted Project, Restricted Project

Mon, Jun 13

saugustine added a comment to D124569: Re-enable libc++ gdb-pretty-printer tests for all versions of clang..

I can't manage to get the buildbot environment working to test this. It consistently fails with

Mon, Jun 13, 11:11 AM · Restricted Project, Restricted Project

Apr 27 2022

saugustine requested review of D124569: Re-enable libc++ gdb-pretty-printer tests for all versions of clang..
Apr 27 2022, 4:02 PM · Restricted Project, Restricted Project

Apr 14 2022

Herald added a project to D118067: [libc++][ci] Re-enable the bootstrapping build: Restricted Project.

Hi Louis,

Apr 14 2022, 4:58 PM · Restricted Project, Restricted Project

Mar 18 2022

saugustine committed rG61d5d12ca97b: Update llvm-config.h.cmake for 7b983917d4 (authored by saugustine).
Update llvm-config.h.cmake for 7b983917d4
Mar 18 2022, 12:59 PM · Restricted Project

Mar 17 2022

saugustine committed rG07998f6d750b: Correct and complete dependency sets after… (authored by saugustine).
Correct and complete dependency sets after…
Mar 17 2022, 7:53 PM · Restricted Project
saugustine closed D121974: Correct and complete dependency sets after 74b411d38c48513a125e67e049aca55452b9e855.
Mar 17 2022, 7:53 PM · Restricted Project, Restricted Project
saugustine added reviewers for D121974: Correct and complete dependency sets after 74b411d38c48513a125e67e049aca55452b9e855: sivachandra, michaelrj.
Mar 17 2022, 7:37 PM · Restricted Project, Restricted Project
saugustine requested review of D121974: Correct and complete dependency sets after 74b411d38c48513a125e67e049aca55452b9e855.
Mar 17 2022, 7:34 PM · Restricted Project, Restricted Project
saugustine committed rG9065dd143921: Fix invalid preprocessor directive. (authored by saugustine).
Fix invalid preprocessor directive.
Mar 17 2022, 7:13 PM · Restricted Project
saugustine committed rG6f958b6ff54b: Update llvm-config.h.cmake for LLVM_UNREACHABLE_OPTIMIZE (authored by saugustine).
Update llvm-config.h.cmake for LLVM_UNREACHABLE_OPTIMIZE
Mar 17 2022, 7:05 PM · Restricted Project
saugustine abandoned D121941: Include missing header to fix libstdc++ builds..
Mar 17 2022, 1:34 PM · Restricted Project, Restricted Project
saugustine requested review of D121941: Include missing header to fix libstdc++ builds..
Mar 17 2022, 12:22 PM · Restricted Project, Restricted Project
saugustine added a comment to D121922: Reland "Use a stable-sort when combining bases".

The pre-merge failures are all related to riscV, or timeouts, or other unrelated things.

Mar 17 2022, 11:36 AM · Restricted Project, Restricted Project
saugustine committed rGbd38234d7603: Reland "Use a stable-sort when combining bases" (authored by saugustine).
Reland "Use a stable-sort when combining bases"
Mar 17 2022, 11:32 AM · Restricted Project
saugustine closed D121922: Reland "Use a stable-sort when combining bases".
Mar 17 2022, 11:32 AM · Restricted Project, Restricted Project
saugustine requested review of D121932: Add missing dependency..
Mar 17 2022, 10:44 AM · Restricted Project, Restricted Project
saugustine requested review of D121922: Reland "Use a stable-sort when combining bases".
Mar 17 2022, 10:02 AM · Restricted Project, Restricted Project
saugustine added a reverting change for rG81417261a15f: Use a stable-sort when combining bases: rG84810e1f7467: Revert "Use a stable-sort when combining bases".
Mar 17 2022, 9:54 AM · Restricted Project
saugustine committed rG84810e1f7467: Revert "Use a stable-sort when combining bases" (authored by saugustine).
Revert "Use a stable-sort when combining bases"
Mar 17 2022, 9:54 AM · Restricted Project
saugustine added a reverting change for D121870: Use a stable-sort when combining bases: rG84810e1f7467: Revert "Use a stable-sort when combining bases".
Mar 17 2022, 9:54 AM · Restricted Project, Restricted Project
saugustine committed rG81417261a15f: Use a stable-sort when combining bases (authored by saugustine).
Use a stable-sort when combining bases
Mar 17 2022, 9:04 AM · Restricted Project
saugustine closed D121870: Use a stable-sort when combining bases.
Mar 17 2022, 9:04 AM · Restricted Project, Restricted Project

Mar 16 2022

saugustine added reviewers for D121870: Use a stable-sort when combining bases: dmgreen, sjarus.
Mar 16 2022, 4:43 PM · Restricted Project, Restricted Project
saugustine requested review of D121870: Use a stable-sort when combining bases.
Mar 16 2022, 4:40 PM · Restricted Project, Restricted Project
saugustine added a comment to D120296: [Attr] Fix a btf_type_tag AST generation bug.

This change ends up leaving some unhandled enum with switches inside lldb, and it isn't obvious to me how to fix them. Can you take a quick look?

Mar 16 2022, 10:32 AM · Restricted Project, Restricted Project

Mar 15 2022

saugustine committed rG103f23d63d36: Updated mlir-tablegen dependencies for f96a8675cd29776ca39bb76133ee9167f5001f17 (authored by saugustine).
Updated mlir-tablegen dependencies for f96a8675cd29776ca39bb76133ee9167f5001f17
Mar 15 2022, 8:01 PM · Restricted Project
saugustine closed D121764: Updated mlir-tablegen dependencies for f96a8675cd29776ca39bb76133ee9167f5001f17.
Mar 15 2022, 8:01 PM · Restricted Project, Restricted Project
saugustine requested review of D121764: Updated mlir-tablegen dependencies for f96a8675cd29776ca39bb76133ee9167f5001f17.
Mar 15 2022, 7:41 PM · Restricted Project, Restricted Project
saugustine added inline comments to D121732: Avoid using a variable-sized array for a tiny allocation..
Mar 15 2022, 2:05 PM · Restricted Project, Restricted Project
saugustine added a comment to D121408: Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size .

Fix for the variable-sized-array issue in rG7518e0ff63cd

Mar 15 2022, 1:06 PM · Restricted Project, Restricted Project
saugustine committed rG7518e0ff63cd: Avoid using a variable-sized array for a tiny allocation. (authored by saugustine).
Avoid using a variable-sized array for a tiny allocation.
Mar 15 2022, 1:04 PM · Restricted Project
saugustine closed D121732: Avoid using a variable-sized array for a tiny allocation..
Mar 15 2022, 1:04 PM · Restricted Project, Restricted Project
saugustine requested review of D121732: Avoid using a variable-sized array for a tiny allocation..
Mar 15 2022, 12:57 PM · Restricted Project, Restricted Project
saugustine added a comment to D121408: Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size .

This change uses a variable-sized array, which is c99 only:

Mar 15 2022, 12:45 PM · Restricted Project, Restricted Project

Mar 14 2022

saugustine added a comment to D121638: [lld-macho] Avoid using bump-alloc in TrieBuider.

Reverted with ee7a286cd3e4364d2f7d5b6ba4b8a6fc0d524854

Mar 14 2022, 3:24 PM · Restricted Project, Restricted Project, Restricted Project
saugustine added a reverting change for rGe049a87f04cf: [lld-macho] Avoid using bump-alloc in TrieBuider: rGee7a286cd3e4: Revert "[lld-macho] Avoid using bump-alloc in TrieBuider".
Mar 14 2022, 3:24 PM · Restricted Project
saugustine committed rGee7a286cd3e4: Revert "[lld-macho] Avoid using bump-alloc in TrieBuider" (authored by saugustine).
Revert "[lld-macho] Avoid using bump-alloc in TrieBuider"
Mar 14 2022, 3:23 PM · Restricted Project
saugustine added a reverting change for D121638: [lld-macho] Avoid using bump-alloc in TrieBuider: rGee7a286cd3e4: Revert "[lld-macho] Avoid using bump-alloc in TrieBuider".
Mar 14 2022, 3:23 PM · Restricted Project, Restricted Project, Restricted Project
saugustine added a comment to D121638: [lld-macho] Avoid using bump-alloc in TrieBuider.

Or, if you prefer the cmake version:

Mar 14 2022, 3:16 PM · Restricted Project, Restricted Project, Restricted Project
saugustine added a comment to D121638: [lld-macho] Avoid using bump-alloc in TrieBuider.

This change breaks the lld build with:

ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ac6467df252ff017b0d6ba076db369db/external/llvm-project/lld/BUILD.bazel:191:11: Compiling lld/MachO/ExportTrie.cpp failed: (Exit 1): clang failed: error executing command /usr/local/bin/clang -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -fcolor-diagnostics -fno-omit-frame-pointer '-std=c++0x' -MD -MF ... (remaining 81 argument(s) skipped)
external/llvm-project/lld/MachO/ExportTrie.cpp:148:11: error: definition of implicitly declared destructor
TrieNode::~TrieNode() {
          ^
external/llvm-project/lld/MachO/ExportTrie.cpp:149:25: error: use of undeclared identifier 'nodes'; did you mean 'node'?
  for (TrieNode *node : nodes)
                        ^~~~~
                        node
external/llvm-project/lld/MachO/ExportTrie.cpp:149:18: note: 'node' declared here
  for (TrieNode *node : nodes)
                 ^
external/llvm-project/lld/MachO/ExportTrie.cpp:149:23: error: invalid range expression of type 'lld::macho::TrieNode *'; no viable 'begin' function available
  for (TrieNode *node : nodes)
                      ^ ~~~~~
3 errors generated.
Mar 14 2022, 3:15 PM · Restricted Project, Restricted Project, Restricted Project
saugustine added a comment to D121349: [WebAssembly] Second phase of implementing extended const proposal..

This patch triggers a bunch of uninitialized memory under msan errors when running llvm-project/lld/test/wasm:data-layout.s (and several others) as below:

exit status 2
==1915==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x55e0ff9ca683 in (anonymous namespace)::WasmDumper::dump() /llvm-project/llvm/tools/obj2yaml/wasm2yaml.cpp:374:13
    #1 0x55e0ff9c1b87 in wasm2yaml(llvm::raw_ostream&, llvm::object::WasmObjectFile const&) llvm-project/llvm/tools/obj2yaml/wasm2yaml.cpp:411:50
    #2 0x55e0ff9be3c9 in dumpObject llvm-project/llvm/tools/obj2yaml/obj2yaml.cpp:40:29
    #3 0x55e0ff9be3c9 in dumpInput llvm-project/llvm/tools/obj2yaml/obj2yaml.cpp:67:12
    #4 0x55e0ff9be3c9 in main llvm-project/llvm/tools/obj2yaml/obj2yaml.cpp:89:19
    #5 0x7f7a5befc8d2 in __libc_start_main (/usr/grte/v5/lib64/libc.so.6+0x628d2) (BuildId: 7cfed7708e5ab7fcb286b373de21ee76)
    #6 0x55e0ff798429 in _start /usr/grte/v5/debug-src/src/csu/../sysdeps/x86_64/start.S:120
Mar 14 2022, 2:34 PM · Restricted Project, Restricted Project

Nov 30 2021

saugustine added inline comments to D113244: Simplify the libcxx std::string_view gdb pretty printer.
Nov 30 2021, 1:12 PM · Restricted Project

Nov 29 2021

saugustine accepted D113244: Simplify the libcxx std::string_view gdb pretty printer.

Seems like using it as a sub-printer for Cords is a good idea. So I'll accept this.

Nov 29 2021, 1:47 PM · Restricted Project

Nov 19 2021

saugustine added a comment to D113244: Simplify the libcxx std::string_view gdb pretty printer.

The google internal absl::string_view printer included the length prior to the standardization of string_view, and we didn't contribute those pretty printers to libstdc++ when it was standardized, so some of this is simply an old choice that didn't get propagated to libstdc++. The original formatting is useful to see that you are working with a non-null terminated string_view.

Nov 19 2021, 2:59 PM · Restricted Project

Oct 26 2021

saugustine accepted rG082d2ad015bd: [libFuzzer] Improve corpus replacement unit test..
Oct 26 2021, 8:58 AM

Oct 20 2021

saugustine committed rG6b6564fcf9f5: Fix unused variable warning. (authored by saugustine).
Fix unused variable warning.
Oct 20 2021, 10:00 AM

Oct 8 2021

saugustine added a comment to D111138: [libcxx][pretty printers] Correct locale for u16/u32 string tests.

I spent some time today trying to reproduce this in as many ways as I could think of, to no avail.

Oct 8 2021, 2:52 PM · Restricted Project

Oct 6 2021

saugustine accepted D111138: [libcxx][pretty printers] Correct locale for u16/u32 string tests.

Great change. Thanks--especially for fixing the u16_string test.

Oct 6 2021, 8:34 AM · Restricted Project

Oct 5 2021

saugustine added a comment to D111138: [libcxx][pretty printers] Correct locale for u16/u32 string tests.

Changing my current locale to POSIX from en_US.utf-8 reproduces this problem. I just use the default ubuntu locale normally. I don't have ANSI_X3.4-1968 installed, but I suspect the issue is the same. I expect the tests will pass if you switch LANG=en_US.utf-8--but would be good to check.

Oct 5 2021, 10:08 AM · Restricted Project
saugustine added a comment to D111138: [libcxx][pretty printers] Correct locale for u16/u32 string tests.

This looks very much like a locale issue to me. Do you happen to know which one is live in your test bed?

Oct 5 2021, 8:29 AM · Restricted Project

Oct 4 2021

saugustine accepted D110936: [libcxx][pretty printers] Report not being able to trace test program.
Oct 4 2021, 10:27 AM · Restricted Project

Sep 28 2021

saugustine added a comment to D109963: [AArch64] Split bitmask immediate of bitwise AND operation.

Since we have a reproducer, I have reverted this change with rGc07f7099690e.

Sep 28 2021, 6:03 PM · Restricted Project
saugustine added a reverting change for rG73a196a11c0e: Recommit "[AArch64] Split bitmask immediate of bitwise AND operation": rGc07f7099690e: Revert "Recommit "[AArch64] Split bitmask immediate of bitwise AND operation"".
Sep 28 2021, 6:03 PM
saugustine committed rGc07f7099690e: Revert "Recommit "[AArch64] Split bitmask immediate of bitwise AND operation"" (authored by saugustine).
Revert "Recommit "[AArch64] Split bitmask immediate of bitwise AND operation""
Sep 28 2021, 6:03 PM
saugustine added a comment to D109963: [AArch64] Split bitmask immediate of bitwise AND operation.

Hi, I have tracked a crash down to this patch. This cases passes at f701505c45c7 and fails at this change. The target is aarch64 and the case is run at -O1.

Sep 28 2021, 5:24 PM · Restricted Project

Sep 2 2021

saugustine accepted D109204: [libc++][NFC] Mark values in gdb pretty print comparison functions as live to prevent values being optimized out..
Sep 2 2021, 4:07 PM · Restricted Project

Aug 6 2021

saugustine added a comment to D107660: [lldb] Upstream support for Foundation constant classes.

Some people complain if I revert without notification. So I always notify as soon as I find the patch with the problem. Some reverts are more complicated than others too.

Aug 6 2021, 5:09 PM · Restricted Project
saugustine added a comment to D107660: [lldb] Upstream support for Foundation constant classes.

Thanks for looking. Reverted with 4e5af6ef48590e7248e344ddabf245bb3de71c51.

Aug 6 2021, 4:58 PM · Restricted Project
saugustine added a reverting change for rG34d78b6a6755: [lldb] Upstream support for Foundation constant classes: rG4e5af6ef4859: Revert "[lldb] Upstream support for Foundation constant classes".
Aug 6 2021, 4:57 PM
saugustine committed rG4e5af6ef4859: Revert "[lldb] Upstream support for Foundation constant classes" (authored by saugustine).
Revert "[lldb] Upstream support for Foundation constant classes"
Aug 6 2021, 4:57 PM
saugustine added a reverting change for D107660: [lldb] Upstream support for Foundation constant classes: rG4e5af6ef4859: Revert "[lldb] Upstream support for Foundation constant classes".
Aug 6 2021, 4:57 PM · Restricted Project
saugustine added a comment to D107660: [lldb] Upstream support for Foundation constant classes.

This change breaks various build bots with a missing file. See below. Reverting shortly.

Aug 6 2021, 4:52 PM · Restricted Project
saugustine added a comment to rGdbce6a8d9d7c: [ARM] Fold insert_subvector to concat_vectors.

Thanks for the quick fix. That worked.

Aug 6 2021, 9:43 AM

Aug 5 2021

saugustine added a comment to D107068: [DAG] DAGCombiner::visitVECTOR_SHUFFLE - recognise INSERT_SUBVECTOR patterns..

I have tracked down an assertion failure in a Halide pipeline that targets armeabi-v7a to this change. I don't think it is Halide per-se, but rather codegen that happens to be exposed by this pipeline. I'm working on extracting it. My sense is that this target needs work similar to the others, but to get started, here is the assertion:

Aug 5 2021, 5:12 PM · Restricted Project

Aug 4 2021

saugustine added a comment to D107344: [SLP]Do not emit extra shuffle for insertelements vectorization..

As this change is causing miscompiles on halide, I think it wise to revert until fixed. Any objections?

Aug 4 2021, 11:03 AM · Restricted Project

Aug 3 2021

saugustine accepted D107397: [GlobalOpt] Fix the load types when OptimizeGlobalAddressOfMalloc.

I need to test a little more extensively, but this does appear to fix the issue I had reported, which is good news. Thanks.

Aug 3 2021, 2:42 PM · Restricted Project

Aug 2 2021

saugustine added a comment to D106589: [GlobalOpt] support ConstantExpr use of global address for OptimizeGlobalAddressOfMalloc.

This patch caused the following error for me:

Aug 2 2021, 1:27 PM · Restricted Project

Jul 20 2021

saugustine committed rGedfdb5fcd107: Consolidate string types into ptr and length representations. (authored by saugustine).
Consolidate string types into ptr and length representations.
Jul 20 2021, 1:30 PM
saugustine closed D106381: Consolidate string types into ptr and length representations..
Jul 20 2021, 1:30 PM · Restricted Project
saugustine requested review of D106381: Consolidate string types into ptr and length representations..
Jul 20 2021, 10:32 AM · Restricted Project
saugustine committed rGbbbc4f110e35: Avoid keeping internal string_views in Twine. (authored by saugustine).
Avoid keeping internal string_views in Twine.
Jul 20 2021, 8:47 AM
saugustine closed D106186: Avoid keeping internal string_views in Twine..
Jul 20 2021, 8:47 AM · Restricted Project

Jul 16 2021

saugustine updated the diff for D106186: Avoid keeping internal string_views in Twine..

This revision switches from a StringRef to an explicit pointer
and length.

Jul 16 2021, 4:48 PM · Restricted Project
saugustine added a comment to D106186: Avoid keeping internal string_views in Twine..

Can you verify that this fixes your issue?

Jul 16 2021, 1:28 PM · Restricted Project
saugustine added a comment to D103935: Add Twine support for std::string_view..

https://reviews.llvm.org/D106186 should fix.

Jul 16 2021, 1:28 PM · Restricted Project
saugustine requested review of D106186: Avoid keeping internal string_views in Twine..
Jul 16 2021, 1:27 PM · Restricted Project
saugustine added a comment to D103935: Add Twine support for std::string_view..

I will implement dblaikie's idea, which should unblock in the short term, but I think a larger conversation about the level of support that the project wants for this would be good to have.

Jul 16 2021, 10:30 AM · Restricted Project

Jul 15 2021

saugustine added a comment to D103935: Add Twine support for std::string_view..

Reverting this patch might help in the instant case, but the odds of something similar happening, where the data structure is different across different versions of the standard is very hard to guarantee. And also hard to test for.

Jul 15 2021, 5:50 PM · Restricted Project
saugustine added a comment to D103935: Add Twine support for std::string_view..

Seems like valid/important use case to me!

Jul 15 2021, 4:12 PM · Restricted Project
saugustine added a comment to D103935: Add Twine support for std::string_view..

I'm not sure removing the ifdef guards around the enum value is better.

Jul 15 2021, 9:45 AM · Restricted Project

Jul 14 2021

saugustine accepted D105954: [scudo] Don't enabled MTE for small alignment.
Jul 14 2021, 11:41 AM · Restricted Project

Jun 10 2021

saugustine committed rG1d3873d41eca: Move variable only used inside an assert into the assert. (authored by saugustine).
Move variable only used inside an assert into the assert.
Jun 10 2021, 1:15 PM

Jun 8 2021

saugustine committed rGe11b5b87bebf: Add Twine support for std::string_view. (authored by saugustine).
Add Twine support for std::string_view.
Jun 8 2021, 8:30 PM
saugustine closed D103935: Add Twine support for std::string_view..
Jun 8 2021, 8:30 PM · Restricted Project
saugustine added inline comments to D103935: Add Twine support for std::string_view..
Jun 8 2021, 8:18 PM · Restricted Project
saugustine updated the diff for D103935: Add Twine support for std::string_view..

This addresses the upstream comments.

Jun 8 2021, 7:51 PM · Restricted Project
saugustine added inline comments to D103935: Add Twine support for std::string_view..
Jun 8 2021, 5:15 PM · Restricted Project
saugustine updated the diff for D103935: Add Twine support for std::string_view..

Small fix for prototype.

Jun 8 2021, 5:10 PM · Restricted Project
saugustine added a reviewer for D103935: Add Twine support for std::string_view.: jyknight.
Jun 8 2021, 5:06 PM · Restricted Project
saugustine updated the summary of D103935: Add Twine support for std::string_view..
Jun 8 2021, 5:05 PM · Restricted Project
saugustine requested review of D103935: Add Twine support for std::string_view..
Jun 8 2021, 5:03 PM · Restricted Project

Jun 3 2021

saugustine added a comment to D103039: [AST] fully-qualify template args of outer types in getFullyQualifiedType.

Committed as 3e55f55048387a8efef01e445d46fc5cf100285d.

Jun 3 2021, 10:52 AM · Restricted Project
saugustine committed rG3e55f5504838: Fully-qualify template args of outer types in getFullyQualifiedType (authored by victordk).
Fully-qualify template args of outer types in getFullyQualifiedType
Jun 3 2021, 10:51 AM

Jun 2 2021

saugustine accepted D103039: [AST] fully-qualify template args of outer types in getFullyQualifiedType.

This is a long-standing bug that needed to be fixed. Thank you!

Jun 2 2021, 8:19 AM · Restricted Project