Page MenuHomePhabricator

saugustine (Sterling Augustine)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 6 2015, 10:28 AM (193 w, 2 d)

Recent Activity

Sat, Jul 13

saugustine added a comment to D64062: Remove __VERSION__.

From the failure mode I was seeing, any value at all for VERSION will be fine, as long as it is a valid preprocessor string.

Sat, Jul 13, 10:43 AM · Restricted Project, Restricted Project

Fri, Jul 12

saugustine added reviewers for D64687: [clang] Revert "Remove __VERSION__": rnk, dexonsmith, sylvestre.ledru.
Fri, Jul 12, 7:46 PM · Restricted Project
saugustine added a comment to D64062: Remove __VERSION__.

The revert is at https://reviews.llvm.org/D64687, which I will commit shortly if there are no objections.

Fri, Jul 12, 7:46 PM · Restricted Project, Restricted Project
saugustine created D64687: [clang] Revert "Remove __VERSION__".
Fri, Jul 12, 7:46 PM · Restricted Project
saugustine added a comment to D64062: Remove __VERSION__.

This revision breaks python 2.7.16 builds, which are still supported by upstream python for a few more months. I'm preparing a revert.

Fri, Jul 12, 7:28 PM · Restricted Project, Restricted Project
saugustine added a comment to rL365920: [IndVars] Use exit count reasoning to discharge obviously untaken exits.

After this revision lib/Transforms/Scalar/IndVarSimplify.cpp:2630 defines "Latch" which is only used inside an assert. This makes builds with -DNDEBUG fail with unused variable warnings.

Fri, Jul 12, 11:53 AM
saugustine committed rG6d75a9e87365: The variable "Latch" is only used in an assert, which makes builds that use "… (authored by saugustine).
The variable "Latch" is only used in an assert, which makes builds that use "…
Fri, Jul 12, 11:52 AM
saugustine committed rL365943: The variable "Latch" is only used in an assert, which makes builds that use "….
The variable "Latch" is only used in an assert, which makes builds that use "…
Fri, Jul 12, 11:50 AM
saugustine closed D64654: The variable "Latch" is only used in an assert, which makes builds that use "-DNDEBUG" fail with unused variable messages..
Fri, Jul 12, 11:50 AM · Restricted Project
saugustine created D64654: The variable "Latch" is only used in an assert, which makes builds that use "-DNDEBUG" fail with unused variable messages..
Fri, Jul 12, 11:50 AM · Restricted Project

Wed, Jul 10

saugustine committed rG05630a37455f: rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h… (authored by saugustine).
rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h…
Wed, Jul 10, 4:39 PM
saugustine added a comment to D64541: rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h:108 but CompilationDatabase is only forward declared. This makes the header not compile standalone, because unique_ptrs expect to have the full-definition of the....

Committed as r365713.

Wed, Jul 10, 4:38 PM · Restricted Project
saugustine committed rL365713: rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h….
rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h…
Wed, Jul 10, 4:37 PM
saugustine updated the diff for D64541: rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h:108 but CompilationDatabase is only forward declared. This makes the header not compile standalone, because unique_ptrs expect to have the full-definition of the....

Remove other forward declaration also in the added header.

Wed, Jul 10, 4:33 PM · Restricted Project
saugustine added a reviewer for D64541: rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h:108 but CompilationDatabase is only forward declared. This makes the header not compile standalone, because unique_ptrs expect to have the full-definition of the...: sammccall.
Wed, Jul 10, 4:18 PM · Restricted Project
saugustine created D64541: rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h:108 but CompilationDatabase is only forward declared. This makes the header not compile standalone, because unique_ptrs expect to have the full-definition of the....
Wed, Jul 10, 4:14 PM · Restricted Project

Tue, Jul 9

saugustine added a comment to D64197: [HardwareLoops] NFC - move hardware loop checking code to isHardwareLoopProfitable().

This revision violates some rules about the build structure.

Tue, Jul 9, 10:42 AM · Restricted Project

Jun 10 2019

saugustine added a comment to D62088: [compiler-rt][builtins] Scaled Integer log10().

I am absolutely not the right person to review the math. I think we need to trust that the author has it correct. The logic looks reasonable and the tests look basically thorough. I am inclined to accept it.

Jun 10 2019, 5:31 PM · Restricted Project, Restricted Project

May 30 2019

saugustine added a comment to D62088: [compiler-rt][builtins] Scaled Integer log10().

The number is the argument count plus one for return value. So this function should be named

May 30 2019, 1:47 PM · Restricted Project, Restricted Project
saugustine added a comment to D62088: [compiler-rt][builtins] Scaled Integer log10().

I can't speak to how useful this would be and for whom, but I'm not opposed to including it if Fuschia has a use for it.

May 30 2019, 1:43 PM · Restricted Project, Restricted Project

May 21 2019

saugustine accepted D59841: [Gnu Driver] Let -static-pie win if it is specified along with -pie or -static..
May 21 2019, 1:35 PM · Restricted Project

May 13 2019

saugustine committed rUNW360610: Add a new LIBUNWIND_WEAK_PTHREAD Cmake option to force.
Add a new LIBUNWIND_WEAK_PTHREAD Cmake option to force
May 13 2019, 12:26 PM
saugustine committed rG7981a28d9d30: Add a new LIBUNWIND_WEAK_PTHREAD Cmake option to force calls into the pthread… (authored by saugustine).
Add a new LIBUNWIND_WEAK_PTHREAD Cmake option to force calls into the pthread…
May 13 2019, 11:45 AM
saugustine committed rL360610: Add a new LIBUNWIND_WEAK_PTHREAD Cmake option to force.
Add a new LIBUNWIND_WEAK_PTHREAD Cmake option to force
May 13 2019, 11:44 AM
saugustine closed D60285: Make calls into the pthread library use weak symbols..
May 13 2019, 11:44 AM · Restricted Project

May 10 2019

saugustine added a comment to D60285: Make calls into the pthread library use weak symbols..

Any of the previous reviewers have a comment before I commit?

May 10 2019, 2:45 PM · Restricted Project

May 9 2019

saugustine updated the diff for D60285: Make calls into the pthread library use weak symbols..
  • Make LIBUNWIND_WEAK_PTHREAD a formal Cmake option.
May 9 2019, 3:38 PM · Restricted Project

May 8 2019

saugustine accepted D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++.
May 8 2019, 3:09 PM · Restricted Project, Restricted Project, Restricted Project
saugustine added a comment to D60285: Make calls into the pthread library use weak symbols..

I've now put the weak-reference version behind a non-default build option. Is this acceptable?

May 8 2019, 1:41 PM · Restricted Project
saugustine updated the diff for D60285: Make calls into the pthread library use weak symbols..
  • Add an option to make pthread symbol references weak.
May 8 2019, 1:40 PM · Restricted Project

Apr 23 2019

saugustine added a comment to D60285: Make calls into the pthread library use weak symbols..

Hi Nick--hope your vacation was good.

Apr 23 2019, 3:59 PM · Restricted Project

Apr 15 2019

saugustine added a comment to D60285: Make calls into the pthread library use weak symbols..

@kledzik

Nick, what do you think about adding weak symbols just for achieving this?

Apr 15 2019, 2:07 PM · Restricted Project

Apr 9 2019

saugustine added a comment to D60285: Make calls into the pthread library use weak symbols..

ping?

Apr 9 2019, 4:14 PM · Restricted Project

Apr 5 2019

saugustine added inline comments to D60285: Make calls into the pthread library use weak symbols..
Apr 5 2019, 1:51 PM · Restricted Project
saugustine added a comment to D60285: Make calls into the pthread library use weak symbols..

This is better than a no-op RWMutex because then the same binary works both when the application is multi-threaded and when it isn't. Therefore the build doesn't have to distinguish between the two cases.

Apr 5 2019, 11:26 AM · Restricted Project

Apr 4 2019

saugustine created D60285: Make calls into the pthread library use weak symbols..
Apr 4 2019, 2:10 PM · Restricted Project

Mar 26 2019

saugustine added inline comments to D59841: [Gnu Driver] Let -static-pie win if it is specified along with -pie or -static..
Mar 26 2019, 2:06 PM · Restricted Project

Mar 21 2019

saugustine committed rG7642289780b3: This test assumes that -rtlib defaults to libgcc. But that isn't true in the… (authored by saugustine).
This test assumes that -rtlib defaults to libgcc. But that isn't true in the…
Mar 21 2019, 4:30 PM
saugustine committed rC356724: This test assumes that -rtlib defaults to libgcc. But that isn't true in the….
This test assumes that -rtlib defaults to libgcc. But that isn't true in the…
Mar 21 2019, 4:29 PM
saugustine committed rL356724: This test assumes that -rtlib defaults to libgcc. But that isn't true in the….
This test assumes that -rtlib defaults to libgcc. But that isn't true in the…
Mar 21 2019, 4:29 PM
saugustine closed D59674: This test assumes that -rtlib defaults to libgcc. But that isn't true in the face of -DCLANG_DEFAULT_RTLIB=compiler-rt..
Mar 21 2019, 4:29 PM · Restricted Project
saugustine added a reviewer for D59674: This test assumes that -rtlib defaults to libgcc. But that isn't true in the face of -DCLANG_DEFAULT_RTLIB=compiler-rt.: rdhindsa.
Mar 21 2019, 4:29 PM · Restricted Project
saugustine created D59674: This test assumes that -rtlib defaults to libgcc. But that isn't true in the face of -DCLANG_DEFAULT_RTLIB=compiler-rt..
Mar 21 2019, 4:14 PM · Restricted Project

Mar 20 2019

saugustine committed rG86724e40bfa5: Make __cpu_model a hidden symbol, to match libgcc. Also hide… (authored by saugustine).
Make __cpu_model a hidden symbol, to match libgcc. Also hide…
Mar 20 2019, 10:37 AM
saugustine committed rCRT356581: Make __cpu_model a hidden symbol, to match libgcc..
Make __cpu_model a hidden symbol, to match libgcc.
Mar 20 2019, 10:37 AM
saugustine committed rL356581: Make __cpu_model a hidden symbol, to match libgcc..
Make __cpu_model a hidden symbol, to match libgcc.
Mar 20 2019, 10:37 AM
saugustine closed D59561: Make __cpu_model a hidden symbol, to match libgcc..
Mar 20 2019, 10:37 AM · Restricted Project
saugustine added a comment to D59561: Make __cpu_model a hidden symbol, to match libgcc..

Thanks. I've hidden a couple more symbols Please take another look.

Mar 20 2019, 10:10 AM · Restricted Project
saugustine updated the diff for D59561: Make __cpu_model a hidden symbol, to match libgcc..

Make cpu_model a hidden symbol, to match libgcc.
Also
cpu_features2 and __cpu_indicator_init.

Mar 20 2019, 10:10 AM · Restricted Project
saugustine updated the diff for D59561: Make __cpu_model a hidden symbol, to match libgcc..
  • Also hide __cpu_inicator_init for similar reasons.
Mar 20 2019, 9:52 AM · Restricted Project

Mar 19 2019

saugustine created D59561: Make __cpu_model a hidden symbol, to match libgcc..
Mar 19 2019, 2:05 PM · Restricted Project
saugustine added reviewers for D59561: Make __cpu_model a hidden symbol, to match libgcc.: asbirlea, echristo.
Mar 19 2019, 2:05 PM · Restricted Project
saugustine committed rG6271606969e2: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2] (authored by saugustine).
Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]
Mar 19 2019, 1:01 PM
saugustine committed rC356508: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]
Mar 19 2019, 1:01 PM
saugustine committed rL356508: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]
Mar 19 2019, 1:01 PM
saugustine closed D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Mar 19 2019, 1:00 PM · Restricted Project
saugustine added inline comments to D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Mar 19 2019, 12:57 PM · Restricted Project

Mar 18 2019

saugustine added a comment to D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].

I have now switched it to use --unwindlib=[libgcc|libunwind]

Mar 18 2019, 2:25 PM · Restricted Project
saugustine updated the diff for D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
  • Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]
  • Change option argument --unwindlib= from "compiler-rt" to "libunwind".
  • Fix tests syntax and driver checks for --unwindlib=
Mar 18 2019, 2:19 PM · Restricted Project
saugustine updated the diff for D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
  • Undo cpu model change.
Mar 18 2019, 11:31 AM · Restricted Project
saugustine updated the diff for D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Mar 18 2019, 11:25 AM · Restricted Project

Mar 14 2019

saugustine accepted D59387: Make getFullyQualifiedName qualify both the pointee and class type for member ptr types.

This looks correct to me, thanks for the fix.

Mar 14 2019, 2:54 PM · Restricted Project, Restricted Project

Mar 13 2019

saugustine added a comment to D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].

rsmith: Do you have any comments on the naming here?

Mar 13 2019, 10:08 AM · Restricted Project

Mar 11 2019

saugustine added inline comments to D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Mar 11 2019, 3:37 PM · Restricted Project

Mar 8 2019

saugustine added inline comments to D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Mar 8 2019, 11:32 AM · Restricted Project

Mar 7 2019

saugustine added reviewers for D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]: rsmith, phosek, kristina, mstorsjo, uabelho.
Mar 7 2019, 2:13 PM · Restricted Project
saugustine created D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Mar 7 2019, 2:06 PM · Restricted Project

Feb 20 2019

saugustine accepted D58307: [Clang Driver] Add support for "-static-pie" argument to the Clang driver..
Feb 20 2019, 10:39 AM · Restricted Project, Restricted Project

Jan 29 2019

saugustine committed rL352524: Rollback unwindlib patch..
Rollback unwindlib patch.
Jan 29 2019, 10:29 AM
saugustine committed rC352524: Rollback unwindlib patch..
Rollback unwindlib patch.
Jan 29 2019, 10:29 AM
saugustine added a comment to D57128: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=.

This was rolled back with r352524. I'll work out something better.

Jan 29 2019, 10:29 AM
saugustine added a comment to D57128: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=.

Sorry for the breakage everyone, I'm preparing a rollback now.

Jan 29 2019, 8:50 AM

Jan 28 2019

saugustine committed rL352405: Correct help text for --unwindlib options..
Correct help text for --unwindlib options.
Jan 28 2019, 10:56 AM
saugustine committed rC352405: Correct help text for --unwindlib options..
Correct help text for --unwindlib options.
Jan 28 2019, 10:56 AM
saugustine committed rL352404: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=.
Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=
Jan 28 2019, 10:56 AM
saugustine committed rC352404: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=.
Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=
Jan 28 2019, 10:56 AM
saugustine closed D57128: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=.
Jan 28 2019, 10:56 AM

Jan 25 2019

saugustine added inline comments to D57128: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=.
Jan 25 2019, 3:07 PM
saugustine updated the diff for D57128: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=.
  • Correct help text for --unwindlib options.
Jan 25 2019, 3:07 PM

Jan 23 2019

saugustine created D57128: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=.
Jan 23 2019, 5:07 PM

Jan 10 2019

saugustine committed rC350900: Properly support -shared-libgcc..
Properly support -shared-libgcc.
Jan 10 2019, 2:30 PM
saugustine committed rL350900: Properly support -shared-libgcc..
Properly support -shared-libgcc.
Jan 10 2019, 2:30 PM
saugustine closed D55016: Correctly support -shared-libgcc..

Committed with r350900.

Jan 10 2019, 2:30 PM

Nov 28 2018

saugustine created D55016: Correctly support -shared-libgcc..
Nov 28 2018, 12:00 PM

Nov 26 2018

saugustine closed D54492: Notify the linker when a TU compiled with split-stack has a functionwithout a prologue.There is more context here:https://go-review.googlesource.com/c/go/+/148819/.
Nov 26 2018, 3:30 PM
saugustine added a comment to D54492: Notify the linker when a TU compiled with split-stack has a functionwithout a prologue.There is more context here:https://go-review.googlesource.com/c/go/+/148819/.

Committed as r347614.

Nov 26 2018, 3:29 PM
saugustine committed rL347614: Notify the linker when a TU compiled with split-stack has a function without a….
Notify the linker when a TU compiled with split-stack has a function without a…
Nov 26 2018, 3:29 PM
saugustine updated the diff for D54492: Notify the linker when a TU compiled with split-stack has a functionwithout a prologue.There is more context here:https://go-review.googlesource.com/c/go/+/148819/.

Add a test case.

Nov 26 2018, 3:18 PM

Nov 15 2018

saugustine added inline comments to D54497: [ELF] --gdb-index: extract entities from .debug_info when .debug_gnu_pubnames is absent.
Nov 15 2018, 11:06 AM

Nov 13 2018

saugustine retitled D54492: Notify the linker when a TU compiled with split-stack has a functionwithout a prologue.There is more context here:https://go-review.googlesource.com/c/go/+/148819/ from Notify the linker when a TU compiled with split-stack has a function without a prologue. There is more context here: https://go-review.googlesource.com/c/go/+/148819/ to Notify the linker when a TU compiled with split-stack has a functionwithout a prologue.There is more context here:https://go-review.googlesource.com/c/go/+/148819/.
Nov 13 2018, 1:25 PM
saugustine created D54492: Notify the linker when a TU compiled with split-stack has a functionwithout a prologue.There is more context here:https://go-review.googlesource.com/c/go/+/148819/.
Nov 13 2018, 1:20 PM

Sep 4 2018

saugustine committed rL341408: When a relocation to an undefined symbol is an R_X86_64_PC32, an input.
When a relocation to an undefined symbol is an R_X86_64_PC32, an input
Sep 4 2018, 2:09 PM
saugustine committed rLLD341408: When a relocation to an undefined symbol is an R_X86_64_PC32, an input.
When a relocation to an undefined symbol is an R_X86_64_PC32, an input
Sep 4 2018, 2:09 PM

Aug 31 2018

saugustine committed rC341231: Refactor Addlibgcc to make the when and what logic more straightfoward..
Refactor Addlibgcc to make the when and what logic more straightfoward.
Aug 31 2018, 11:02 AM
saugustine committed rL341231: Refactor Addlibgcc to make the when and what logic more straightfoward..
Refactor Addlibgcc to make the when and what logic more straightfoward.
Aug 31 2018, 11:02 AM
saugustine closed D51521: Refactor Addlibgcc to make the when and what logic more straightfoward..

commited as r341231.

Aug 31 2018, 11:01 AM

Aug 30 2018

saugustine created D51521: Refactor Addlibgcc to make the when and what logic more straightfoward..
Aug 30 2018, 3:59 PM
saugustine committed rL341114: Revert r341107. That change breaks lto-android in a way is untested..
Revert r341107. That change breaks lto-android in a way is untested.
Aug 30 2018, 1:44 PM
saugustine committed rC341114: Revert r341107. That change breaks lto-android in a way is untested..
Revert r341107. That change breaks lto-android in a way is untested.
Aug 30 2018, 1:43 PM
saugustine committed rL341107: Refactor Addlibgcc to make the when and what logic more straightfoward..
Refactor Addlibgcc to make the when and what logic more straightfoward.
Aug 30 2018, 1:08 PM