- User Since
- Nov 6 2015, 10:28 AM (201 w, 6 d)
I fixed our problem with r372366.
Committed as r372366.
- Tighten up the test case.
Just a note that Google is seeing problems with this patch and may need to revert it. I'm working to get a sharable test case.
Wed, Sep 18
When running test/Transforms/SimplifyCFG/merge-cond-stores-2.ll.test under address sanitizer, this revision creates a stack-use-after-scope failure at llvm/lib/Transforms/Utils/SimplifyCFG.cpp:3008:13:
Thanks so much for fixing this. Really appreciate it.
Mon, Sep 16
I believe this change caused the failure below, but I think because the test should be updated, rather than a problem with the code. I would fix it, but I'm not sure what the right fix is.
Thu, Sep 5
Committed as r371131.
Thanks. Committed as r371120.
Wed, Sep 4
Fri, Aug 30
Reverted because it broke some buildbots. Looking into why.
Thanks. Commited as r370551
Mon, Aug 26
Would someone please accept this patch, or let me know what else there is to be done?
Aug 12 2019
Anyone have any remaining thoughts?
Aug 5 2019
- Run a pep8 formatter.
- Address other comments from code review.
Aug 1 2019
Jul 13 2019
From the failure mode I was seeing, any value at all for VERSION will be fine, as long as it is a valid preprocessor string.
Jul 12 2019
The revert is at https://reviews.llvm.org/D64687, which I will commit shortly if there are no objections.
This revision breaks python 2.7.16 builds, which are still supported by upstream python for a few more months. I'm preparing a revert.
After this revision lib/Transforms/Scalar/IndVarSimplify.cpp:2630 defines "Latch" which is only used inside an assert. This makes builds with -DNDEBUG fail with unused variable warnings.
Jul 10 2019
Committed as r365713.
Remove other forward declaration also in the added header.
Jul 9 2019
This revision violates some rules about the build structure.
Jun 10 2019
I am absolutely not the right person to review the math. I think we need to trust that the author has it correct. The logic looks reasonable and the tests look basically thorough. I am inclined to accept it.
May 30 2019
The number is the argument count plus one for return value. So this function should be named
I can't speak to how useful this would be and for whom, but I'm not opposed to including it if Fuschia has a use for it.
May 21 2019
May 13 2019
May 10 2019
Any of the previous reviewers have a comment before I commit?
May 9 2019
- Make LIBUNWIND_WEAK_PTHREAD a formal Cmake option.
May 8 2019
I've now put the weak-reference version behind a non-default build option. Is this acceptable?
- Add an option to make pthread symbol references weak.
Apr 23 2019
Hi Nick--hope your vacation was good.
Apr 15 2019
Apr 9 2019
Apr 5 2019
This is better than a no-op RWMutex because then the same binary works both when the application is multi-threaded and when it isn't. Therefore the build doesn't have to distinguish between the two cases.
Apr 4 2019
Mar 26 2019
Mar 21 2019
Mar 20 2019
Thanks. I've hidden a couple more symbols Please take another look.
Make cpu_model a hidden symbol, to match libgcc.
Also cpu_features2 and __cpu_indicator_init.
- Also hide __cpu_inicator_init for similar reasons.
Mar 19 2019
Mar 18 2019
I have now switched it to use --unwindlib=[libgcc|libunwind]
- Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]
- Change option argument --unwindlib= from "compiler-rt" to "libunwind".
- Fix tests syntax and driver checks for --unwindlib=
- Undo cpu model change.
Mar 14 2019
This looks correct to me, thanks for the fix.