Page MenuHomePhabricator

saugustine (Sterling Augustine)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 6 2015, 10:28 AM (219 w, 20 h)

Recent Activity

Thu, Jan 2

saugustine committed rG108daf76118e: Check for aarch64 when not using .init_arrays (authored by saugustine).
Check for aarch64 when not using .init_arrays
Thu, Jan 2, 10:27 AM
saugustine closed D72005: Check for aarch64 when not using .init_arrays.

Committed as 108daf76118e5b97696f58386d0b48d4b858ffad

Thu, Jan 2, 10:26 AM · Restricted Project, Restricted Project

Mon, Dec 30

saugustine added a comment to D71944: Support powerpc and sparc when building without init_array..

Would you update the patch and avoid displaying of those error messages for other platforms?

Mon, Dec 30, 8:22 AM · Restricted Project, Restricted Project
saugustine created D72005: Check for aarch64 when not using .init_arrays.
Mon, Dec 30, 8:22 AM · Restricted Project, Restricted Project

Fri, Dec 27

saugustine committed rG1d891a32cf43: Support powerpc and sparc when building without init_array. (authored by saugustine).
Support powerpc and sparc when building without init_array.
Fri, Dec 27, 1:06 PM
saugustine closed D71944: Support powerpc and sparc when building without init_array..

Submitted as 1d891a32cf433e205b5d30697beb265dc0e1f248

Fri, Dec 27, 1:06 PM · Restricted Project, Restricted Project
saugustine created D71944: Support powerpc and sparc when building without init_array..
Fri, Dec 27, 11:58 AM · Restricted Project, Restricted Project

Dec 18 2019

saugustine committed rG5789e83dedb9: Support powerpc when builing without init_array. (authored by saugustine).
Support powerpc when builing without init_array.
Dec 18 2019, 1:41 PM
saugustine closed D71670: Support powerpc when builing without init_array..

Landed as 5789e83dedb97588ad75cca36d01ba6c5142d6d3

Dec 18 2019, 1:41 PM · Restricted Project, Restricted Project
saugustine added reviewers for D71670: Support powerpc when builing without init_array.: jgorbe, rdhindsa.
Dec 18 2019, 11:26 AM · Restricted Project, Restricted Project
saugustine created D71670: Support powerpc when builing without init_array..
Dec 18 2019, 11:26 AM · Restricted Project, Restricted Project

Dec 6 2019

saugustine committed rGaa3c877fb58d: Move variable only used in an assert into the assert itself. (authored by saugustine).
Move variable only used in an assert into the assert itself.
Dec 6 2019, 5:12 PM
saugustine added a comment to D71153: [AArch64][GlobalISel] Add support for selection of vector G_SHL with immediates..

Committed aa3c877fb58db238a86e734511bdeed9bc40086c to fix the unused variable warning at AArch64InstructionSelector.cpp:1013

Dec 6 2019, 5:11 PM · Restricted Project
saugustine added a comment to D71153: [AArch64][GlobalISel] Add support for selection of vector G_SHL with immediates..

This change fails to build when assertions are turned off, due to the variable Ty at Arch64InstructionSelector.cpp:1013 not being used anywhere but an assertion. I'm testing a patch to fix.

Dec 6 2019, 5:11 PM · Restricted Project

Dec 5 2019

saugustine committed rG6470497817ea: Revert "[AST] Traverse the class type loc inside the member type loc." (authored by saugustine).
Revert "[AST] Traverse the class type loc inside the member type loc."
Dec 5 2019, 4:52 PM
saugustine added a reverting change for rG7f93cb62280a: [AST] Traverse the class type loc inside the member type loc.: rG6470497817ea: Revert "[AST] Traverse the class type loc inside the member type loc.".
Dec 5 2019, 4:52 PM
saugustine added inline comments to D70849: [AST] Traverse the class type loc inside the member pointer type loc..
Dec 5 2019, 4:23 PM · Restricted Project
saugustine added a comment to D71005: [AST] Enable expression of OpenCL language address spaces an attribute.

When I try to run tablegen on this file for clang/docs (as described in clang/docs/InternalsManual.rst), I get an error, introduced by this change:

Dec 5 2019, 11:49 AM · Restricted Project

Dec 4 2019

saugustine added a comment to D70635: Reland [AArch64][MachineOutliner] Return address signing for outlined functions.

@saugustine Thanks, I was just about to fix it with this patch but running the asan tests locally took longer than expected.

Do I need new review for this?

Dec 4 2019, 5:10 PM · Restricted Project
saugustine added a comment to D70635: Reland [AArch64][MachineOutliner] Return address signing for outlined functions.

I have reverted this due to the asan failures. f65267e is the commit.

Dec 4 2019, 4:42 PM · Restricted Project
saugustine committed rGf65267ee16fb: Revert "Reland [AArch64][MachineOutliner] Return address signing for outlined… (authored by saugustine).
Revert "Reland [AArch64][MachineOutliner] Return address signing for outlined…
Dec 4 2019, 4:41 PM
saugustine added a reverting change for rG02760b750b2f: Reland [AArch64][MachineOutliner] Return address signing for outlined functions: rGf65267ee16fb: Revert "Reland [AArch64][MachineOutliner] Return address signing for outlined….
Dec 4 2019, 4:41 PM
saugustine added a comment to rG8b0780f795eb: Revert "[DebugInfo] Recover debug intrinsics when killing duplicated/empty….

I have provided a very reduced test case on the original patch.

Dec 4 2019, 3:45 PM
saugustine added a comment to rG72ce759928e6: [DebugInfo] Recover debug intrinsics when killing duplicated/empty basic blocks.

Here is the very reduced test case:

Dec 4 2019, 3:45 PM
saugustine added a comment to rG72ce759928e6: [DebugInfo] Recover debug intrinsics when killing duplicated/empty basic blocks.

This change is causing clang to crash on some internal tests we have.

Dec 4 2019, 1:04 PM

Dec 2 2019

saugustine accepted D70815: Enable `-funwind-tables` flag when building libunwind.

I'm not a cmake expert and have very little sense of the mechanics here, but this change is necessary and at least looks correct to me, so accepting.

Dec 2 2019, 10:16 AM · Restricted Project
saugustine added a comment to D70397: [libunwind] Adjust the signal_frame test for Arm.

I don't know signal frame but I think the purpose of that assert is to check unw_step return value > 0 from main if that is a signal frame. Adding another frame will make that assert always be true, regardless of signal frame, thus it is not testing signal frame anymore.

That might not be the case. unw_is_signal_frame works after the stepping out of the signal frame, i.e. we need to call unw_step anyway. @saugustine is the author of the test and he approved my patch, so presumably the test should not depend on whether the signal_frame function is main() or not.

Dec 2 2019, 9:49 AM · Restricted Project

Nov 22 2019

saugustine accepted D70416: [Driver] Make -static-libgcc imply static libunwind.
Nov 22 2019, 10:43 AM · Restricted Project

Nov 19 2019

saugustine added a comment to D70416: [Driver] Make -static-libgcc imply static libunwind.

This is normally done by using -Bstatic/-Bdynamic around the library. See tools::addOpenMPRuntime.

Nov 19 2019, 9:11 AM · Restricted Project

Nov 18 2019

saugustine accepted D70397: [libunwind] Adjust the signal_frame test for Arm.
Nov 18 2019, 1:44 PM · Restricted Project

Nov 12 2019

saugustine committed rG38c356176b53: Fix include guard and properly order __deregister_frame_info. (authored by saugustine).
Fix include guard and properly order __deregister_frame_info.
Nov 12 2019, 3:00 PM
saugustine updated the diff for D70034: Fix include guard and properly order __deregister_frame_info..

Move prototypes for the frame info functions as requested.

Nov 12 2019, 2:41 PM · Restricted Project, Restricted Project
saugustine added a comment to D70034: Fix include guard and properly order __deregister_frame_info..

...and finally, after some off line feedback, someone pointed out to me that we really do want using the frame registry to be configurable. Not the least of which because llvm-libunwind does nothing inside __register_frame_info.

Nov 12 2019, 12:38 PM · Restricted Project, Restricted Project
saugustine updated the summary of D70034: Fix include guard and properly order __deregister_frame_info..
Nov 12 2019, 12:29 PM · Restricted Project, Restricted Project
saugustine updated the diff for D70034: Fix include guard and properly order __deregister_frame_info..
  • Make using the eh_frame registry a configure-time option.
Nov 12 2019, 12:20 PM · Restricted Project, Restricted Project

Nov 11 2019

saugustine updated the diff for D70034: Fix include guard and properly order __deregister_frame_info..
  • Fix space.
Nov 11 2019, 5:13 PM · Restricted Project, Restricted Project
saugustine updated the diff for D70034: Fix include guard and properly order __deregister_frame_info..

In the original code, register_frame_info was always called. But in the original version of this patch, I awkwardly tied it to CRT_USE_INITFINI_ARRAY, which would make it uncalled in certain circumstances. Also, we agreed that tying the two things together didn't make a lot of sense.

Nov 11 2019, 5:13 PM · Restricted Project, Restricted Project
saugustine added a comment to D70034: Fix include guard and properly order __deregister_frame_info..

Thanks for these fixes! Personally, I'd be fine making a hard transition and making EH_USE_FRAME_REGISTRY independent from CRT_HAS_INITFINI_ARRAY, at least in our case it shouldn't cause any issue and I'd be surprised if anyone relied on the current behavior which is clearly a bug and not something I did intentionally.

Regarding the test, I think it'd be still useful to include it, but the dependency on libunwind might be a problem for actually running it, we might need to include a special check to only run that test when libunwind is being available.

Nov 11 2019, 12:21 PM · Restricted Project, Restricted Project
saugustine updated the diff for D70034: Fix include guard and properly order __deregister_frame_info..
  • Make USE_FRAME_REGISTRY completely independent of CRT_HAS_INITFINI_ARRAY,
Nov 11 2019, 12:12 PM · Restricted Project, Restricted Project
saugustine updated the diff for D70034: Fix include guard and properly order __deregister_frame_info..
  • Address upstream comments. Move backward compatibility handling to CMakeLists.
Nov 11 2019, 12:02 PM · Restricted Project, Restricted Project

Nov 8 2019

saugustine created D70034: Fix include guard and properly order __deregister_frame_info..
Nov 8 2019, 4:15 PM · Restricted Project, Restricted Project

Nov 7 2019

saugustine committed rGd3c744313c3c: Correctly update isSignalFrame when unwinding the stack via dwarf. (authored by saugustine).
Correctly update isSignalFrame when unwinding the stack via dwarf.
Nov 7 2019, 2:55 PM
saugustine closed D69677: Correctly update isSignalFrame when unwinding the stack via dwarf..
Nov 7 2019, 2:55 PM · Restricted Project
saugustine added a comment to D69677: Correctly update isSignalFrame when unwinding the stack via dwarf..

Updated for all comments, and committing shortly.

Nov 7 2019, 2:26 PM · Restricted Project
saugustine updated the diff for D69677: Correctly update isSignalFrame when unwinding the stack via dwarf..
  • Add file header and explanatory comment.
Nov 7 2019, 2:26 PM · Restricted Project
saugustine updated the summary of D69677: Correctly update isSignalFrame when unwinding the stack via dwarf..
Nov 7 2019, 10:28 AM · Restricted Project

Nov 6 2019

saugustine added a comment to D69677: Correctly update isSignalFrame when unwinding the stack via dwarf..

Looks sane to me, but I'm not a cfi_signal_frame expert.

Do you know the ipBefore == isSignalFrame relationship is true on all platforms?

Nov 6 2019, 3:35 PM · Restricted Project

Nov 5 2019

saugustine added reviewers for D69677: Correctly update isSignalFrame when unwinding the stack via dwarf.: mstorsjo, ldionne.
Nov 5 2019, 3:33 PM · Restricted Project

Nov 1 2019

saugustine added a reviewer for D69677: Correctly update isSignalFrame when unwinding the stack via dwarf.: MaskRay.
Nov 1 2019, 1:54 PM · Restricted Project

Oct 31 2019

saugustine closed D69313: Handle more crt*.o filename variants..

Committed in rG118ceea5c364, with the git transition obscuring the auto-reporting.

Oct 31 2019, 1:45 PM · Restricted Project
saugustine created D69677: Correctly update isSignalFrame when unwinding the stack via dwarf..
Oct 31 2019, 12:47 PM · Restricted Project

Oct 25 2019

saugustine committed rG118ceea5c364: Crt files are special cased by name when dealing with ctor and dtor sections… (authored by saugustine).
Crt files are special cased by name when dealing with ctor and dtor sections…
Oct 25 2019, 11:12 AM
saugustine updated the diff for D69313: Handle more crt*.o filename variants..

Switch to new repo.

Oct 25 2019, 11:02 AM · Restricted Project

Oct 24 2019

saugustine updated the diff for D69313: Handle more crt*.o filename variants..
  • Avoid a string copy.
Oct 24 2019, 12:48 PM · Restricted Project
saugustine updated the diff for D69313: Handle more crt*.o filename variants..
  • Add test. Address other comments.
  • remove llvm namespace.
Oct 24 2019, 12:18 PM · Restricted Project
saugustine added a comment to D69313: Handle more crt*.o filename variants..

All comments addressed. Please take another look when you get a chance.

Oct 24 2019, 9:46 AM · Restricted Project
saugustine updated the diff for D69313: Handle more crt*.o filename variants..
  • Address additional comments.
Oct 24 2019, 9:46 AM · Restricted Project

Oct 22 2019

saugustine added a comment to D69313: Handle more crt*.o filename variants..

Thanks. Please take another look.

Oct 22 2019, 3:18 PM · Restricted Project
saugustine updated the diff for D69313: Handle more crt*.o filename variants..
  • Switch crt file matching to regular expressions.
Oct 22 2019, 3:17 PM · Restricted Project
saugustine added inline comments to D69313: Handle more crt*.o filename variants..
Oct 22 2019, 1:17 PM · Restricted Project
saugustine created D69313: Handle more crt*.o filename variants..
Oct 22 2019, 11:05 AM · Restricted Project

Oct 17 2019

saugustine committed rGbbbc873f83e4: (NFC) Delete variable made unused by llvm-svn: 375160 (authored by saugustine).
(NFC) Delete variable made unused by llvm-svn: 375160
Oct 17 2019, 2:47 PM
saugustine closed D69143: (NFC) Delete variable made unused by llvm-svn: 375160.
Oct 17 2019, 2:46 PM · Restricted Project, Restricted Project
saugustine added a comment to D69143: (NFC) Delete variable made unused by llvm-svn: 375160.

Committed. as r375174.

Oct 17 2019, 2:46 PM · Restricted Project, Restricted Project
saugustine committed rL375174: (NFC) Delete variable made unused by llvm-svn: 375160.
(NFC) Delete variable made unused by llvm-svn: 375160
Oct 17 2019, 2:37 PM
saugustine added a comment to rG1ad655e25509: Modernize the rest of the Find.* API (NFC).

This will be fixed by https://reviews.llvm.org/D69143

Oct 17 2019, 2:37 PM
saugustine created D69143: (NFC) Delete variable made unused by llvm-svn: 375160.
Oct 17 2019, 2:37 PM · Restricted Project, Restricted Project
saugustine added a comment to D69119: Modernize the rest of the Find.* API (NFC).

This breaks the build due to lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:1355:8: error: unused variable 'old_size' [-Werror,-Wunused-variable]

Oct 17 2019, 2:18 PM · Restricted Project
saugustine committed rG05c3d90248db: NFC: Fix variable only used in asserts by propagating the value. (authored by saugustine).
NFC: Fix variable only used in asserts by propagating the value.
Oct 17 2019, 11:11 AM
saugustine closed D69123: NFC: Fix variable only used in asserts by propagating the value..
Oct 17 2019, 11:11 AM · Restricted Project
saugustine committed rL375148: NFC: Fix variable only used in asserts by propagating the value..
NFC: Fix variable only used in asserts by propagating the value.
Oct 17 2019, 11:11 AM
saugustine added a comment to D69123: NFC: Fix variable only used in asserts by propagating the value..

Committed as r375148.

Oct 17 2019, 11:11 AM · Restricted Project
saugustine added a comment to D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.

https://reviews.llvm.org/D69123 fixes this break.

Oct 17 2019, 11:11 AM · Restricted Project
saugustine added reviewers for D69123: NFC: Fix variable only used in asserts by propagating the value.: Xiangling_L, hubert.reinterpretcast, jasonliu.
Oct 17 2019, 11:02 AM · Restricted Project
saugustine created D69123: NFC: Fix variable only used in asserts by propagating the value..
Oct 17 2019, 11:02 AM · Restricted Project
saugustine added a comment to D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.

This revision breaks builds with assertions disabled because IsPPC64 (introduced on line 539 of PPCAsmPrinter.cpp is unused when assertions are turned off.

Oct 17 2019, 10:42 AM · Restricted Project

Oct 4 2019

saugustine committed rGb3e3934347f2: Add an off-by-default option to enable testing for gdb pretty printers. (authored by saugustine).
Add an off-by-default option to enable testing for gdb pretty printers.
Oct 4 2019, 3:16 PM
saugustine committed rL373796: Add an off-by-default option to enable testing for gdb pretty printers..
Add an off-by-default option to enable testing for gdb pretty printers.
Oct 4 2019, 3:15 PM
saugustine closed D68477: Add an off-by-default option to enable testing for gdb pretty printers..
Oct 4 2019, 3:15 PM · Restricted Project
saugustine created D68477: Add an off-by-default option to enable testing for gdb pretty printers..
Oct 4 2019, 12:00 PM · Restricted Project

Oct 3 2019

saugustine accepted D68380: [Driver] NFC: Remove duplicate call to getLibGccType.
Oct 3 2019, 9:27 AM · Restricted Project, Restricted Project

Oct 2 2019

saugustine added a comment to rL373452: Fix libc++ pretty printer test for Python 3 after D67238.

Yvan Roux had been working on this (python 3 compatibility), and even showed me a brief patch off line. I don't know what happened there. I will cc him now.

Oct 2 2019, 9:30 AM

Oct 1 2019

saugustine committed rG9b36c1cf278b: Determine endianness at a time when it doesn't inadvertantly clear gdb's… (authored by saugustine).
Determine endianness at a time when it doesn't inadvertantly clear gdb's…
Oct 1 2019, 3:42 PM
saugustine committed rL373402: Determine endianness at a time when it doesn't inadvertantly clear gdb's….
Determine endianness at a time when it doesn't inadvertantly clear gdb's…
Oct 1 2019, 3:40 PM
saugustine closed D68306: Determine endianness at a time when it doesn't inadvertantly clear gdb's wrap_buffer via gdb.execute..
Oct 1 2019, 3:40 PM · Restricted Project
saugustine updated the summary of D68306: Determine endianness at a time when it doesn't inadvertantly clear gdb's wrap_buffer via gdb.execute..
Oct 1 2019, 3:27 PM · Restricted Project
saugustine created D68306: Determine endianness at a time when it doesn't inadvertantly clear gdb's wrap_buffer via gdb.execute..
Oct 1 2019, 3:27 PM · Restricted Project

Sep 20 2019

saugustine committed rG4a58936716e5: Fix missed case of switching getConstant to getTargetConstant. Try 2. (authored by saugustine).
Fix missed case of switching getConstant to getTargetConstant. Try 2.
Sep 20 2019, 3:26 PM
saugustine closed D67850: Fix missed case of switching getConstant to getTargetConstant. Try 2..
Sep 20 2019, 3:25 PM · Restricted Project
saugustine committed rL372434: Fix missed case of switching getConstant to getTargetConstant. Try 2..
Fix missed case of switching getConstant to getTargetConstant. Try 2.
Sep 20 2019, 3:25 PM
saugustine added a comment to D67850: Fix missed case of switching getConstant to getTargetConstant. Try 2..

We've been blocked on this for a day now, so going ahead and checking it in. Will wait and watch for problems.

Sep 20 2019, 3:25 PM · Restricted Project
saugustine updated the diff for D67850: Fix missed case of switching getConstant to getTargetConstant. Try 2..

Move test case out of GlobalISel.

Sep 20 2019, 12:22 PM · Restricted Project
saugustine added inline comments to D67850: Fix missed case of switching getConstant to getTargetConstant. Try 2..
Sep 20 2019, 11:52 AM · Restricted Project
saugustine updated the diff for D67850: Fix missed case of switching getConstant to getTargetConstant. Try 2..

Addressing comments.

Sep 20 2019, 11:52 AM · Restricted Project
saugustine abandoned D67785: Use getTargetConstant for BLENDI, and add a test to catch it..

Trying again in https://reviews.llvm.org/D67850

Sep 20 2019, 11:25 AM · Restricted Project
saugustine created D67850: Fix missed case of switching getConstant to getTargetConstant. Try 2..
Sep 20 2019, 11:20 AM · Restricted Project

Sep 19 2019

saugustine closed D67785: Use getTargetConstant for BLENDI, and add a test to catch it..
Sep 19 2019, 7:38 PM · Restricted Project
saugustine committed rG52621307bcab: Use getTargetConstant for BLENDI, and add a test to catch it. (authored by saugustine).
Use getTargetConstant for BLENDI, and add a test to catch it.
Sep 19 2019, 7:37 PM
saugustine committed rL372366: Use getTargetConstant for BLENDI, and add a test to catch it..
Use getTargetConstant for BLENDI, and add a test to catch it.
Sep 19 2019, 7:35 PM
saugustine added a comment to rL372338: Reapply r372285 "GlobalISel: Don't materialize immarg arguments to intrinsics".

I fixed our problem with r372366.

Sep 19 2019, 7:32 PM