Page MenuHomePhabricator

saugustine (Sterling Augustine)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 6 2015, 10:28 AM (230 w, 4 d)

Recent Activity

Today

saugustine accepted D77679: [libunwind] Fix UB in EHHeaderParser::findFDE.

Nice catch. Probably should wait for an unwind owner to accept though.

Tue, Apr 7, 2:42 PM · Unknown Object (Project), Restricted Project

Thu, Apr 2

saugustine added a comment to D77099: Exit unwinding early when at the top of the stack and additional info won't be found..

Don't know why Phab thinks compnerd's accepting the revision March 1, at 9:54 left it in an unaccepted state. Happy to revert it if necessary, but I don't think so.

Thu, Apr 2, 12:28 PM · Unknown Object (Project), Restricted Project
saugustine committed rG71fbd6e40632: Exit unwinding early when at the top of the stack and additional info won't be… (authored by saugustine).
Exit unwinding early when at the top of the stack and additional info won't be…
Thu, Apr 2, 11:23 AM
saugustine closed D77099: Exit unwinding early when at the top of the stack and additional info won't be found..
Thu, Apr 2, 11:23 AM · Unknown Object (Project), Restricted Project

Tue, Mar 31

saugustine committed rG21d9d0855be1: New symbolizer option to print files relative to the compilation directory. (authored by saugustine).
New symbolizer option to print files relative to the compilation directory.
Tue, Mar 31, 10:00 AM
saugustine closed D76733: New symbolizer option to print files relative to the compilation directory..
Tue, Mar 31, 10:00 AM · Restricted Project

Mon, Mar 30

saugustine added a comment to D77099: Exit unwinding early when at the top of the stack and additional info won't be found..

The harbormaster failures can't possibly be related. For example, the failure below has nothing whatever to do with this change.

Mon, Mar 30, 4:57 PM · Unknown Object (Project), Restricted Project
saugustine updated the diff for D76733: New symbolizer option to print files relative to the compilation directory..

Thanks for the comments, I think this catches them all.

Mon, Mar 30, 4:24 PM · Restricted Project
saugustine added a comment to D76733: New symbolizer option to print files relative to the compilation directory..

updated for all comments.

Mon, Mar 30, 4:24 PM · Restricted Project
saugustine added reviewers for D77099: Exit unwinding early when at the top of the stack and additional info won't be found.: jgorbe, mstorsjo, compnerd, miyuki, mclow.lists.
Mon, Mar 30, 3:51 PM · Unknown Object (Project), Restricted Project
saugustine created D77099: Exit unwinding early when at the top of the stack and additional info won't be found..
Mon, Mar 30, 3:51 PM · Unknown Object (Project), Restricted Project

Thu, Mar 26

saugustine updated the diff for D76733: New symbolizer option to print files relative to the compilation directory..

clang-format fix

Thu, Mar 26, 3:47 PM · Restricted Project
saugustine updated the diff for D76733: New symbolizer option to print files relative to the compilation directory..

Add missing file.

Thu, Mar 26, 2:42 PM · Restricted Project
saugustine updated the diff for D76733: New symbolizer option to print files relative to the compilation directory..

Add documentation and otherwise address upstream comments.

Thu, Mar 26, 2:08 PM · Restricted Project
saugustine committed rG6c6fba8808e6: Correctly handle using foo = std::foo inside namespaces. (authored by saugustine).
Correctly handle using foo = std::foo inside namespaces.
Thu, Mar 26, 11:26 AM
saugustine closed D76816: Correctly handle using foo = std::foo inside namespaces..
Thu, Mar 26, 11:25 AM · Restricted Project

Wed, Mar 25

saugustine created D76816: Correctly handle using foo = std::foo inside namespaces..
Wed, Mar 25, 6:25 PM · Restricted Project
saugustine added a reviewer for D76816: Correctly handle using foo = std::foo inside namespaces.: EricWF.
Wed, Mar 25, 6:25 PM · Restricted Project

Tue, Mar 24

saugustine updated the diff for D76733: New symbolizer option to print files relative to the compilation directory..

Remove short option. It only existed to be parallel to "-s", but conflicts
with options in gnu addr2line.

Tue, Mar 24, 5:30 PM · Restricted Project
saugustine added a comment to D76733: New symbolizer option to print files relative to the compilation directory..

The clang-format recommendations would change the new options to not match the format of old ones. Not sure the best thing to do there.

Tue, Mar 24, 3:39 PM · Restricted Project
saugustine added a comment to D76733: New symbolizer option to print files relative to the compilation directory..

This change looks good to me. My mere concern is about the option naming. In GNU addr2line, -r has a different meaning, and llvm-symbolizer can be used as llvm-addr2line (it is a crunched executable). If it does not cause too much inconvenience, I will hope we can make llvm-symbolizer and llvm-addr2line have consistent option names.

Tue, Mar 24, 3:39 PM · Restricted Project
saugustine created D76733: New symbolizer option to print files relative to the compilation directory..
Tue, Mar 24, 3:06 PM · Restricted Project

Fri, Mar 20

saugustine committed rG5de4ba1770f4: Cleanup the plumbing for DILineInfoSpecifier. [NFC - Try 2] (authored by saugustine).
Cleanup the plumbing for DILineInfoSpecifier. [NFC - Try 2]
Fri, Mar 20, 10:51 AM

Thu, Mar 19

saugustine committed rG6343526d6400: Revert "Cleanup the plumbing for DILineInfoSpecifier. [NFC]" (authored by saugustine).
Revert "Cleanup the plumbing for DILineInfoSpecifier. [NFC]"
Thu, Mar 19, 5:35 PM
saugustine added a reverting change for rG98ff6eb679cd: Cleanup the plumbing for DILineInfoSpecifier. [NFC]: rG6343526d6400: Revert "Cleanup the plumbing for DILineInfoSpecifier. [NFC]".
Thu, Mar 19, 5:35 PM
saugustine committed rG98ff6eb679cd: Cleanup the plumbing for DILineInfoSpecifier. [NFC] (authored by saugustine).
Cleanup the plumbing for DILineInfoSpecifier. [NFC]
Thu, Mar 19, 5:02 PM
saugustine closed D76394: Cleanup the plumbing for DILineInfoSpecifier. [NFC].
Thu, Mar 19, 5:02 PM · Restricted Project

Wed, Mar 18

saugustine created D76394: Cleanup the plumbing for DILineInfoSpecifier. [NFC].
Wed, Mar 18, 4:19 PM · Restricted Project

Thu, Mar 12

saugustine committed rG3758b858ef3b: Only run frameheader_cache_test.pass.cpp on x86_64. (authored by saugustine).
Only run frameheader_cache_test.pass.cpp on x86_64.
Thu, Mar 12, 6:21 PM
saugustine committed rG3eef58991b26: Add a catch-all else case so any unanticipated configs pass this test. (authored by saugustine).
Add a catch-all else case so any unanticipated configs pass this test.
Thu, Mar 12, 11:59 AM
saugustine committed rGc53c2058ffb8: Cache uwnind frame headers as they are found. (authored by saugustine).
Cache uwnind frame headers as they are found.
Thu, Mar 12, 11:24 AM
saugustine closed D75954: Cache uwnind frame headers as they are found..
Thu, Mar 12, 11:24 AM · Restricted Project, Restricted Project
saugustine updated the diff for D75954: Cache uwnind frame headers as they are found..

fix comment

Thu, Mar 12, 9:13 AM · Restricted Project, Restricted Project

Wed, Mar 11

saugustine updated the diff for D75954: Cache uwnind frame headers as they are found..

Correct the "do not run" cases to match the logic in AddressSpace.hpp.

Wed, Mar 11, 3:32 PM · Restricted Project, Restricted Project
saugustine updated the diff for D75954: Cache uwnind frame headers as they are found..

Update test to only run when relevant.

Wed, Mar 11, 3:22 PM · Restricted Project, Restricted Project
saugustine updated the diff for D75954: Cache uwnind frame headers as they are found..

Add tests, and minor formatting changes.

Wed, Mar 11, 3:20 PM · Restricted Project, Restricted Project
saugustine added a comment to D75954: Cache uwnind frame headers as they are found..

I think it looks good now. My only issue is that it seems to rely on a couple of glibc-specific features: glibc modifying the fields adds and subs in dl_phdr_info when loading/unloading libraries (which this patch uses to know when to invalidate the cache), and dl_iterate_phdr holding a lock (which the patch relies on to avoid races while accessing the cache). What other libc implementations do we support? Do they share these behaviors we rely on here?

Wed, Mar 11, 11:52 AM · Restricted Project, Restricted Project
saugustine updated the diff for D75954: Cache uwnind frame headers as they are found..

Add missing comment.

Wed, Mar 11, 10:45 AM · Restricted Project, Restricted Project
saugustine committed rG8ffdabdb61e1: Lazily save initialState of registers during unwind. (authored by saugustine).
Lazily save initialState of registers during unwind.
Wed, Mar 11, 10:14 AM
saugustine closed D75692: Lazily save initialState of registers during unwind..
Wed, Mar 11, 10:14 AM · Restricted Project
saugustine added inline comments to D75954: Cache uwnind frame headers as they are found..
Wed, Mar 11, 10:09 AM · Restricted Project, Restricted Project
saugustine updated the diff for D75954: Cache uwnind frame headers as they are found..

Update for upstream comments.

Wed, Mar 11, 10:09 AM · Restricted Project, Restricted Project

Tue, Mar 10

saugustine added reviewers for D75954: Cache uwnind frame headers as they are found.: miyuki, mstorsjo, compnerd, jgorbe.
Tue, Mar 10, 2:13 PM · Restricted Project, Restricted Project
saugustine added a comment to D75954: Cache uwnind frame headers as they are found..

I have some tests nearing completion, but want to get started with the feedback now.

Tue, Mar 10, 2:13 PM · Restricted Project, Restricted Project
saugustine accepted D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting.

This looks fine to me.

Tue, Mar 10, 1:06 PM · Restricted Project, Restricted Project
saugustine created D75954: Cache uwnind frame headers as they are found..
Tue, Mar 10, 12:33 PM · Restricted Project, Restricted Project
saugustine committed rGd67cf7a0a970: Rework findUnwindSectionsByPhdr to be more optimal. (authored by saugustine).
Rework findUnwindSectionsByPhdr to be more optimal.
Tue, Mar 10, 10:54 AM
saugustine closed D75781: Rework findUnwindSectionsByPhdr to be more optimal..
Tue, Mar 10, 10:53 AM · Restricted Project

Mon, Mar 9

saugustine updated the diff for D75781: Rework findUnwindSectionsByPhdr to be more optimal..

Update for upstream comments

Mon, Mar 9, 5:50 PM · Restricted Project
saugustine added inline comments to D75781: Rework findUnwindSectionsByPhdr to be more optimal..
Mon, Mar 9, 5:49 PM · Restricted Project
saugustine added inline comments to D75781: Rework findUnwindSectionsByPhdr to be more optimal..
Mon, Mar 9, 4:45 PM · Restricted Project
saugustine updated the diff for D75692: Lazily save initialState of registers during unwind..

Switch boolean to a more clear enum to make call site clearer.

Mon, Mar 9, 4:45 PM · Restricted Project
saugustine added a reviewer for D75692: Lazily save initialState of registers during unwind.: jgorbe.
Mon, Mar 9, 2:35 PM · Restricted Project
saugustine updated the summary of D75781: Rework findUnwindSectionsByPhdr to be more optimal..
Mon, Mar 9, 12:25 PM · Restricted Project
saugustine updated the diff for D75692: Lazily save initialState of registers during unwind..

Move initialization to in class.

Mon, Mar 9, 11:21 AM · Restricted Project

Mar 6 2020

saugustine created D75781: Rework findUnwindSectionsByPhdr to be more optimal..
Mar 6 2020, 4:02 PM · Restricted Project
saugustine committed rGeb755df5c27f: Split findUnwindSectionsByPhdr into target-specific functions. (authored by saugustine).
Split findUnwindSectionsByPhdr into target-specific functions.
Mar 6 2020, 1:50 PM
saugustine closed D75705: Split findUnwindSectionsByPhdr into target-specific functions..
Mar 6 2020, 1:49 PM · Restricted Project
saugustine added a comment to D75705: Split findUnwindSectionsByPhdr into target-specific functions..

I don't know why the linter wants me to indent everything another level. That is clearly not right given the surrounding code.

Mar 6 2020, 12:08 PM · Restricted Project
saugustine added a comment to D75692: Lazily save initialState of registers during unwind..

Fixing last linter complaint (the indent of the switch case), would include either re-indenting other cases involved in this switch, or having the cases not aligned. I think the current situation is better.

Mar 6 2020, 11:35 AM · Restricted Project
saugustine updated the diff for D75692: Lazily save initialState of registers during unwind..

Formating fixes

Mar 6 2020, 10:28 AM · Restricted Project

Mar 5 2020

saugustine updated the diff for D75692: Lazily save initialState of registers during unwind..

Minor formatting fixes.

Mar 5 2020, 2:17 PM · Restricted Project
saugustine created D75705: Split findUnwindSectionsByPhdr into target-specific functions..
Mar 5 2020, 12:07 PM · Restricted Project
saugustine updated the summary of D75692: Lazily save initialState of registers during unwind..
Mar 5 2020, 10:22 AM · Restricted Project
saugustine created D75692: Lazily save initialState of registers during unwind..
Mar 5 2020, 9:50 AM · Restricted Project
saugustine retitled D75691: Convert RegisterSaveLocation from array of structs to struct of arrays from Lazily save initialState of registers during unwind. to Convert RegisterSaveLocation from array of structs to struct of arrays.
Mar 5 2020, 9:50 AM · Restricted Project
saugustine abandoned D75691: Convert RegisterSaveLocation from array of structs to struct of arrays.
Mar 5 2020, 9:50 AM · Restricted Project
saugustine committed rG470f995a517f: Promote nameless lambda used by dl_iterate_phdr to named function. (authored by saugustine).
Promote nameless lambda used by dl_iterate_phdr to named function.
Mar 5 2020, 9:18 AM
saugustine closed D75637: Promote nameless lambda used by dl_iterate_phdr to named function..
Mar 5 2020, 9:18 AM · Restricted Project
saugustine created D75691: Convert RegisterSaveLocation from array of structs to struct of arrays.
Mar 5 2020, 9:18 AM · Restricted Project

Mar 4 2020

saugustine abandoned D75541: Split findUnwindSectionByPhdr by targets--arm eabi and others..
Mar 4 2020, 12:57 PM · Restricted Project
saugustine added a comment to D75480: Promote nameless lambda used by dl_iterate_phdr to named function to clean up control flow inside findUnwindSections. Also, expose the data structureto allow use by a future replacment function..

Sorry for the trouble. Trying again in D75637. There really doesn't seem to be a clean way of #ifdeffing this.

Mar 4 2020, 12:57 PM · Restricted Project
saugustine created D75637: Promote nameless lambda used by dl_iterate_phdr to named function..
Mar 4 2020, 12:57 PM · Restricted Project

Mar 3 2020

saugustine updated the diff for D75541: Split findUnwindSectionByPhdr by targets--arm eabi and others..

Update for clang tidy.

Mar 3 2020, 11:17 AM · Restricted Project
saugustine added a comment to D75541: Split findUnwindSectionByPhdr by targets--arm eabi and others..

The clang-tidy and clang-format failures are all pre-existing, but that is hard to tell from the refactor.

Mar 3 2020, 10:56 AM · Restricted Project
saugustine updated the diff for D75541: Split findUnwindSectionByPhdr by targets--arm eabi and others..

Fix small clang-tidy complaint.

Mar 3 2020, 10:56 AM · Restricted Project
saugustine created D75541: Split findUnwindSectionByPhdr by targets--arm eabi and others..
Mar 3 2020, 9:59 AM · Restricted Project
saugustine committed rGd93371238e7f: Promote nameless lambda used by dl_iterate_phdr to named function to clean up… (authored by saugustine).
Promote nameless lambda used by dl_iterate_phdr to named function to clean up…
Mar 3 2020, 9:41 AM
saugustine closed D75480: Promote nameless lambda used by dl_iterate_phdr to named function to clean up control flow inside findUnwindSections. Also, expose the data structureto allow use by a future replacment function..
Mar 3 2020, 9:41 AM · Restricted Project

Mar 2 2020

saugustine added a reviewer for D75480: Promote nameless lambda used by dl_iterate_phdr to named function to clean up control flow inside findUnwindSections. Also, expose the data structureto allow use by a future replacment function.: MaskRay.
Mar 2 2020, 2:56 PM · Restricted Project
saugustine added a reviewer for D75480: Promote nameless lambda used by dl_iterate_phdr to named function to clean up control flow inside findUnwindSections. Also, expose the data structureto allow use by a future replacment function.: kledzik.
Mar 2 2020, 2:56 PM · Restricted Project
saugustine retitled D75480: Promote nameless lambda used by dl_iterate_phdr to named function to clean up control flow inside findUnwindSections. Also, expose the data structureto allow use by a future replacment function. from Promote nameless lambda used by dl_iterate_phdr to named function to clean up control flow inside findUnwindSections. Also, expose the data structure to allow use by a future replacment function. to Promote nameless lambda used by dl_iterate_phdr to named function to clean up control flow inside findUnwindSections. Also, expose the data structureto allow use by a future replacment function..
Mar 2 2020, 2:56 PM · Restricted Project
saugustine created D75480: Promote nameless lambda used by dl_iterate_phdr to named function to clean up control flow inside findUnwindSections. Also, expose the data structureto allow use by a future replacment function..
Mar 2 2020, 2:56 PM · Restricted Project

Feb 12 2020

saugustine committed rGa7ecf4c324eb: Explicitly state the output file. (authored by saugustine).
Explicitly state the output file.
Feb 12 2020, 9:37 PM
saugustine closed D74523: Explicitly state the output file..
Feb 12 2020, 9:37 PM · Restricted Project
saugustine created D74523: Explicitly state the output file..
Feb 12 2020, 9:28 PM · Restricted Project

Feb 11 2020

saugustine committed rG257e412762e3: Update test for windows. (authored by saugustine).
Update test for windows.
Feb 11 2020, 12:42 PM
saugustine committed rG417375d785b8: Allow retrieving source files relative to the compilation directory. (authored by saugustine).
Allow retrieving source files relative to the compilation directory.
Feb 11 2020, 11:47 AM
saugustine closed D73383: [Debuginfo] Allow retrieving source files relative to the compilation directory..
Feb 11 2020, 11:47 AM · Restricted Project
saugustine added a comment to D73383: [Debuginfo] Allow retrieving source files relative to the compilation directory..

I think this fixes everything. OK to submit?

Feb 11 2020, 10:51 AM · Restricted Project
saugustine updated the diff for D73383: [Debuginfo] Allow retrieving source files relative to the compilation directory..

Address upstream comments.

Feb 11 2020, 10:51 AM · Restricted Project

Feb 7 2020

saugustine updated the summary of D73383: [Debuginfo] Allow retrieving source files relative to the compilation directory..
Feb 7 2020, 3:29 PM · Restricted Project
saugustine added inline comments to D73383: [Debuginfo] Allow retrieving source files relative to the compilation directory..
Feb 7 2020, 3:28 PM · Restricted Project
saugustine updated the diff for D73383: [Debuginfo] Allow retrieving source files relative to the compilation directory..

Update for comments.

Feb 7 2020, 3:28 PM · Restricted Project
saugustine added a comment to D74249: [DebugInfo] Support file-level include directories when generating Dwarf5 LineTable prologues..

It'd be helpful to add something that exercises the new functionality along with the functionality (not necessarily a test /for/ the functionality (since this is test functionality, and then you get in the infinite rabbit hole of testing testing) - but potentially in some libDEbugInfo unit test that uses this functionality and wouldn't be possible without it?)

Feb 7 2020, 2:16 PM · Restricted Project
saugustine added a reviewer for D74249: [DebugInfo] Support file-level include directories when generating Dwarf5 LineTable prologues.: dblaikie.
Feb 7 2020, 12:35 PM · Restricted Project
saugustine created D74249: [DebugInfo] Support file-level include directories when generating Dwarf5 LineTable prologues..
Feb 7 2020, 12:26 PM · Restricted Project

Feb 6 2020

saugustine updated the diff for D73383: [Debuginfo] Allow retrieving source files relative to the compilation directory..

Rebase for split out changes, and add a test.

Feb 6 2020, 4:25 PM · Restricted Project

Jan 29 2020

saugustine committed rGc64b56617da2: Print discriminators when printing .debug_line in GNU style. (authored by saugustine).
Print discriminators when printing .debug_line in GNU style.
Jan 29 2020, 12:26 PM
saugustine closed D73318: Print discriminators when printing .debug_line in GNU style..
Jan 29 2020, 12:26 PM · Restricted Project