ivanbaev (Ivan Baev)Email Not Verified
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 10 2015, 8:26 AM (136 w, 2 d)

Recent Activity

Feb 17 2016

ivanbaev updated subscribers of D17337: __builtin_object_size problem with pointer as argument.
Feb 17 2016, 9:18 AM

Feb 3 2016

ivanbaev added a comment to D13363: [DeadStoreElimination] Add support for non-local DSE.

Hi Mitch,

Feb 3 2016, 7:22 PM

Jan 19 2016

ivanbaev added a comment to D14888: Indirect call optimization.

Hi David, Diego, thanks for the comments. Sorry for the delayed response.

Jan 19 2016, 1:23 AM

Dec 10 2015

ivanbaev added a comment to D13363: [DeadStoreElimination] Add support for non-local DSE.

Agree, but this depends what tests/apps we are concerned about. LNT tests didn't show many outliers.
In addition to Chromium, which applications have been known as outliers in terms of DSE compile-time contribution in the past?

Dec 10 2015, 6:44 PM
ivanbaev added a comment to D13363: [DeadStoreElimination] Add support for non-local DSE.

Hi Chad, thanks for helping with that. Is compile-time increase the remaining problem?
One quick fix could be to change 100 to 10 for the max number on non-local attempts in a function:

static const unsigned MaxNonLocalAttempts = 100;

We've chosen 100 arbitrarily. The newly added DSE tests should pass with 10.

Dec 10 2015, 5:50 PM

Dec 9 2015

ivanbaev added a comment to D13363: [DeadStoreElimination] Add support for non-local DSE.

LGTM

Dec 9 2015, 6:19 PM

Dec 5 2015

ivanbaev added a comment to D13363: [DeadStoreElimination] Add support for non-local DSE.

Thanks, Chad. Can we commit the patch at this point?
It solves one DSE enhancement known for several years.
I believe the patch has been thoroughly reviewed and tested.

Dec 5 2015, 12:34 PM

Nov 20 2015

ivanbaev retitled D14888: Indirect call optimization from to Indirect call optimization.
Nov 20 2015, 1:52 PM

Nov 19 2015

ivanbaev added a comment to D13363: [DeadStoreElimination] Add support for non-local DSE.

Mitch, I added a relevant comment above DT->dominates(BB, Pred).

Nov 19 2015, 5:13 PM
ivanbaev updated the diff for D13363: [DeadStoreElimination] Add support for non-local DSE.

Added a comment to clarify avoidance of blocks (to search for redundant stores) that form a cycle with BB, as requested by Mitch.
Update to ToT is not necessary because the recent changes to DeadStoreElimination.cpp has been reverted.

Nov 19 2015, 5:10 PM

Nov 18 2015

ivanbaev added a comment to D13363: [DeadStoreElimination] Add support for non-local DSE.

ping?

Nov 18 2015, 5:12 PM

Nov 17 2015

ivanbaev added a comment to D13363: [DeadStoreElimination] Add support for non-local DSE.

Could someone with commit access commit this patch, if there is no objection from reviewers?

Nov 17 2015, 1:52 PM

Nov 16 2015

ivanbaev added a comment to D13363: [DeadStoreElimination] Add support for non-local DSE.

Hi Bruno,

Nov 16 2015, 1:30 PM

Nov 15 2015

ivanbaev added a comment to D13363: [DeadStoreElimination] Add support for non-local DSE.

Any objection to commit this patch?

Nov 15 2015, 11:54 AM

Nov 12 2015

ivanbaev updated the diff for D13363: [DeadStoreElimination] Add support for non-local DSE.

Added option -enable-nonlocal-dse to enable/disable the feature.

Nov 12 2015, 8:26 PM

Nov 6 2015

ivanbaev added a comment to D13363: [DeadStoreElimination] Add support for non-local DSE.

Hi Bruno,

Nov 6 2015, 8:55 AM

Nov 4 2015

ivanbaev added a comment to D13363: [DeadStoreElimination] Add support for non-local DSE.

Hi Bruno, the patch has been rebased, and should apply cleanly on ToT.

Nov 4 2015, 6:53 PM
ivanbaev updated the diff for D13363: [DeadStoreElimination] Add support for non-local DSE.

Rebased.
Address Mitch's comments.

Nov 4 2015, 6:23 PM

Nov 2 2015

ivanbaev added a comment to D13363: [DeadStoreElimination] Add support for non-local DSE.

Thanks, Bruno. If necessary we need to balance non-local DSE for compile-time and run-time performance.

Nov 2 2015, 7:19 PM

Nov 1 2015

ivanbaev added inline comments to D13363: [DeadStoreElimination] Add support for non-local DSE.
Nov 1 2015, 4:31 PM
ivanbaev updated the diff for D13363: [DeadStoreElimination] Add support for non-local DSE.

addressed two comments by Mitch

Nov 1 2015, 4:06 PM

Oct 28 2015

ivanbaev added a comment to D13363: [DeadStoreElimination] Add support for non-local DSE.

Hi Bruno,

Oct 28 2015, 3:30 PM
ivanbaev added a comment to D13363: [DeadStoreElimination] Add support for non-local DSE.

Hi Mitch, thanks for the thoughtful comments; we are making a good progress.
I will make the two changes: using successor iterator and adding the comment, in the next revision.

Oct 28 2015, 12:17 PM

Oct 27 2015

ivanbaev added a comment to D13363: [DeadStoreElimination] Add support for non-local DSE.

ping?

Oct 27 2015, 4:38 PM

Oct 24 2015

ivanbaev added inline comments to D13363: [DeadStoreElimination] Add support for non-local DSE.
Oct 24 2015, 5:45 PM
ivanbaev updated the diff for D13363: [DeadStoreElimination] Add support for non-local DSE.
Oct 24 2015, 5:28 PM

Oct 22 2015

ivanbaev added inline comments to D13363: [DeadStoreElimination] Add support for non-local DSE.
Oct 22 2015, 9:58 AM

Oct 20 2015

ivanbaev added a comment to D13363: [DeadStoreElimination] Add support for non-local DSE.

ping?

Oct 20 2015, 6:45 PM

Oct 19 2015

ivanbaev updated the diff for D13363: [DeadStoreElimination] Add support for non-local DSE.

changes for style and coding standards

Oct 19 2015, 7:24 PM

Oct 18 2015

ivanbaev added a comment to D13363: [DeadStoreElimination] Add support for non-local DSE.

Thanks for suggestions/comments, Mitch. My responses are inlined below.

Oct 18 2015, 7:50 PM
ivanbaev updated the diff for D13363: [DeadStoreElimination] Add support for non-local DSE.

The new version now handles a redundant store in the if-block in if-then-else - based on a suggestion by Mitch. We use SafeBlocks set, which is initialized and updated in DSE::HandleNonLocalDependency() and used in helper FindSafePreds(). SafeBlocks keeps track of all predecessor blocks that are safe to search through. A new test - ifthenelse.ll - has been added.

Oct 18 2015, 5:23 PM

Oct 13 2015

ivanbaev added a comment to D13363: [DeadStoreElimination] Add support for non-local DSE.

ping?

Oct 13 2015, 8:19 AM

Oct 9 2015

ivanbaev updated the diff for D13363: [DeadStoreElimination] Add support for non-local DSE.

Addressed Erik's comments:
*) Your algorithm has quadratic complexity in worst case. I know this is the same as for the single block algorithm, but extending it to multiple blocks might worsen the situation. Maybe you add some sort of upper bound for the number of dependency checks?

Oct 9 2015, 3:52 PM

Oct 6 2015

ivanbaev added reviewers for D13363: [DeadStoreElimination] Add support for non-local DSE: karthikthecool, hfinkel.
Oct 6 2015, 6:29 AM

Oct 1 2015

ivanbaev added a comment to D13363: [DeadStoreElimination] Add support for non-local DSE.

Note that the code for BB DSE stays the same, it is just indented two spaces to the right.
The new code begins at:

// DSE across BB
else if (InstDep.isNonLocal()) { ...

and it includes helper FindUncondPredsIncludingSimpleLoops().

Oct 1 2015, 1:25 PM
ivanbaev retitled D13363: [DeadStoreElimination] Add support for non-local DSE from to [DeadStoreElimination] Add support for DSE across blocks.
Oct 1 2015, 1:16 PM