This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][CodeGen] Support Zdinx on RV64 codegen
ClosedPublic

Authored by sunshaoce on May 2 2023, 10:16 AM.

Diff Detail

Event Timeline

sunshaoce created this revision.May 2 2023, 10:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 2 2023, 10:16 AM
sunshaoce requested review of this revision.May 2 2023, 10:16 AM
craig.topper added inline comments.May 2 2023, 1:40 PM
llvm/docs/RISCVUsage.rst
104

Can we keep this on one line and write something like

Assembly Support for RV32. Full support for RV64.

llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp
893–897

Is -> Has

sunshaoce updated this revision to Diff 519039.May 3 2023, 5:32 AM
sunshaoce marked 2 inline comments as done.

Address @craig.topper's comment.

LGTM with the RV32 specific pattern moved to the other patch.

llvm/lib/Target/RISCV/RISCVInstrInfoD.td
238

This should be in the RV32 patch.

sunshaoce updated this revision to Diff 519149.May 3 2023, 10:16 AM
sunshaoce marked an inline comment as done.

Remove PseudoQuietFLE_D_IN32X

This revision is now accepted and ready to land.May 3 2023, 5:40 PM
This revision was automatically updated to reflect the committed changes.