User Details
- User Since
- Sep 17 2020, 7:09 AM (93 w, 4 d)
Yesterday
I would like to ask a question, is this patch to reduce code size?
Wed, Jun 29
Thanks all.
Tue, Jun 28
I try to build lldb with the patch, but fail:
Mon, Jun 27
LGTM, thanks
Sun, Jun 26
The patch : fix crash for rv32 vget intrinsics
Mon, Jun 20
Sun, Jun 19
address craig.topper's comments and thanks
Thu, Jun 16
Don't we need to qualify Opcode?
After a series of @reames's patches, no crash, thanks.
warning:
llvm-project/llvm/lib/Target/AMDGPU/AMDGPUPerfHintAnalysis.cpp:339:6: warning: ‘bool {anonymous}::AMDGPUPerfHint::isConstantAddr(const llvm::Value*) const’ defined but not used [-Wunused-function] 339 | bool AMDGPUPerfHint::isConstantAddr(const Value *V) const { | ^~~~~~~~~~~~~~
warning:
llvm-project/llvm/lib/IR/Core.cpp:90:18: warning: cast between incompatible function types from ‘LLVMDiagnosticHandler’ {aka ‘void (*)(LLVMOpaqueDiagnosticInfo*, void*)’} to ‘llvm::DiagnosticHandler::DiagnosticHandlerTy’ {aka ‘void (*)(const llvm::DiagnosticInfo&, void*)’} [-Wcast-function-type] 90 | Handler), | ^
Wed, Jun 15
The asm of testcase before this patch:
Jun 3 2022
Jun 2 2022
Address @craig.topper's comment.
Jun 1 2022
May 27 2022
- Add a illegal checks. Invalid types will crash.
if(!isTypeLegal(VTy)) return BaseT::getArithmeticReductionCost(Opcode, VTy, FMF, CostKind);
- Remove deadcode.
May 25 2022
Maybe we can not return invalid costs. Just reference D123799.
May 24 2022
When I test tsvc.
thanks craig.topper, testcases add +experimental-zvfh.
change LT.first + 1 to LT.first * 2
May 23 2022
Address reames's comments. rebase
These new testcases are placed to the end of the file, and rebase
May 20 2022
May 19 2022
Why do D125866 need loop vectorization? Is the performance improved?
May 17 2022
May 9 2022
LGTM, thanks
The testcase already has arch attribute, so assemble disassemble are work fine as past, the difference is disassembler using RISCVISAInfo to parse arch string from ELF attribute.
May 8 2022
Does this test case need to be updated? llvm/test/MC/RISCV/attribute-with-insts.s
Apr 28 2022
Thanks craig.topper for the quick fix. rebase
Apr 27 2022
Apr 20 2022
Apr 18 2022
I would like to ask a question:
Apr 10 2022
Thanks Kito. Rebase
Mar 31 2022
This function assumes fixed-width vectors and cannot be used for scalable vectors. I'm not sure what returning 'Invalid' here would really fix, other than the compiler not crashing for a use-case that should not have occurred in the first place, because an overloaded cost function should have been implemented. Whether the compiler falls into the assert from cast<FixedVectorType>, or whether it returns an Invalid cost, in either case you'll need to implement a memory-op-cost function for your target. And because you'll need to implement a cost-function anyway, returning Invalid doesn't really make a difference, because then this code will never be hit. Otherwise, you would have been able to write a test-case for it.
Mar 30 2022
Can adding a cost model for llvm.cttz.nxv1i8 solve this problem? I would like to try.
Mar 15 2022
https://reviews.llvm.org/D119529 maybe this patch , try to fix the same issue
I try to support scalable vectors in getGatherScatterOpCost, but I don't know how to support scalable vectors.
Mar 8 2022
Mar 2 2022
Feb 23 2022
Jan 27 2022
The scalar crypto v1.0 builtins/intrinsics is still under discussion. Maybe we should wait for the final results?
Jan 25 2022
Jan 24 2022
clang Zbkc patch: https://reviews.llvm.org/D112774, If there are any mistakes, you can help to point them out
Jan 23 2022
Do you add intrinsic?
Jan 4 2022
Dec 9 2021
Oct 10 2021
Mar 31 2021
LGTM
Mar 29 2021
LGTM, thanks
Mar 25 2021
Mar 24 2021
Mar 23 2021
LGTM, thanks
Mar 4 2021
Is there a missing test for fcvt.h.d in the test case?