Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

realqhc (QIHAN CAI)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 20 2022, 3:12 PM (97 w, 5 d)

Recent Activity

Aug 18 2023

realqhc retitled D158261: [RISCV][NFC] Rename CVROR, NFC from [RISCV][NFC]Rename CVROR, NFC to [RISCV][NFC] Rename CVROR, NFC.
Aug 18 2023, 2:16 AM · Restricted Project, Restricted Project
realqhc requested review of D158261: [RISCV][NFC] Rename CVROR, NFC.
Aug 18 2023, 2:16 AM · Restricted Project, Restricted Project

Jul 27 2023

realqhc committed rG092e60a3fcb6: [RISCV] Add support for XCValu extension in CV32E40P (authored by Qihan Cai <qcai8733@uni.sydney.edu.au>).
[RISCV] Add support for XCValu extension in CV32E40P
Jul 27 2023, 8:38 PM · Restricted Project, Restricted Project
realqhc closed D153748: [RISCV] Add support for XCValu extension in CV32E40P.
Jul 27 2023, 8:37 PM · Restricted Project, Restricted Project
realqhc updated the diff for D153748: [RISCV] Add support for XCValu extension in CV32E40P.

move xcvalu in RISCVUsage.rst so that it is with other XCV extensions

Jul 27 2023, 11:08 AM · Restricted Project, Restricted Project
realqhc updated the diff for D153748: [RISCV] Add support for XCValu extension in CV32E40P.

Simplify tablegen for alu

Jul 27 2023, 11:04 AM · Restricted Project, Restricted Project

Jul 24 2023

realqhc updated the diff for D153748: [RISCV] Add support for XCValu extension in CV32E40P.

remove Opcode to reflect changes

Jul 24 2023, 9:16 PM · Restricted Project, Restricted Project

Jul 20 2023

realqhc added inline comments to D153748: [RISCV] Add support for XCValu extension in CV32E40P.
Jul 20 2023, 12:09 AM · Restricted Project, Restricted Project
realqhc updated the diff for D153748: [RISCV] Add support for XCValu extension in CV32E40P.

applied general cleanup like in D155283, rebase.

Jul 20 2023, 12:05 AM · Restricted Project, Restricted Project

Jul 11 2023

realqhc updated the diff for D153748: [RISCV] Add support for XCValu extension in CV32E40P.

fix previous errorneus update

Jul 11 2023, 2:03 AM · Restricted Project, Restricted Project

Jul 7 2023

realqhc updated the diff for D153748: [RISCV] Add support for XCValu extension in CV32E40P.

fix the problem of code being wrongly wrapped to 120 columns

Jul 7 2023, 10:28 PM · Restricted Project, Restricted Project
realqhc updated the diff for D153748: [RISCV] Add support for XCValu extension in CV32E40P.

update ISA version accordingly

Jul 7 2023, 2:32 AM · Restricted Project, Restricted Project

Jul 6 2023

realqhc updated the diff for D153748: [RISCV] Add support for XCValu extension in CV32E40P.

update tests

Jul 6 2023, 2:16 AM · Restricted Project, Restricted Project

Jul 4 2023

realqhc updated the diff for D153748: [RISCV] Add support for XCValu extension in CV32E40P.

rename RVInst to CVInst, add core-v to instruction description, use RVInstR to simplify CVInstALU_rr and CVInstAlu_r

Jul 4 2023, 7:35 PM · Restricted Project, Restricted Project
realqhc added a comment to D153748: [RISCV] Add support for XCValu extension in CV32E40P.

You might need to add extension in RISCVISAInfo.cpp for -march support?

We plan to add extension to RISCVISAInfo.cpp in the second batch of upstreaming patches along with the LLVM Intrinsics for the extension.

I think the assembler also needs to RISCVISAInfo.cpp changes to print the correct version for the ELF attributes to list what extensions are enabled in the binary.

Thanks for the suggesion, will get the versioning updated after discussion with core-v.

Jul 4 2023, 6:56 PM · Restricted Project, Restricted Project
realqhc updated the diff for D153748: [RISCV] Add support for XCValu extension in CV32E40P.

fix error in riscvusage.rst to reflect actual prefix of XCValu extension instructions.

Jul 4 2023, 2:26 AM · Restricted Project, Restricted Project
realqhc added inline comments to D153748: [RISCV] Add support for XCValu extension in CV32E40P.
Jul 4 2023, 2:12 AM · Restricted Project, Restricted Project
realqhc abandoned D121774: [RISCV] support fcmp in zfinx,zdinx,zhinx.
Jul 4 2023, 1:55 AM · Restricted Project, Restricted Project
realqhc added a comment to D153748: [RISCV] Add support for XCValu extension in CV32E40P.

You might need to add extension in RISCVISAInfo.cpp for -march support?

Jul 4 2023, 1:33 AM · Restricted Project, Restricted Project
realqhc added inline comments to D153748: [RISCV] Add support for XCValu extension in CV32E40P.
Jul 4 2023, 1:11 AM · Restricted Project, Restricted Project

Jul 3 2023

realqhc updated the summary of D153748: [RISCV] Add support for XCValu extension in CV32E40P.
Jul 3 2023, 1:01 AM · Restricted Project, Restricted Project

Jun 26 2023

realqhc requested review of D153748: [RISCV] Add support for XCValu extension in CV32E40P.
Jun 26 2023, 1:45 AM · Restricted Project, Restricted Project

Jun 21 2023

realqhc committed rGe219dd88d1b6: [RISCV] Add support for XCVmac extension in CV32E40P (authored by Qihan Cai <qcai8733@uni.sydney.edu.au>).
[RISCV] Add support for XCVmac extension in CV32E40P
Jun 21 2023, 8:09 AM · Restricted Project, Restricted Project
realqhc closed D152821: [RISCV] Add support for XCVmac extension in CV32E40P.
Jun 21 2023, 8:08 AM · Restricted Project, Restricted Project
realqhc updated the diff for D152821: [RISCV] Add support for XCVmac extension in CV32E40P.

rebase

Jun 21 2023, 12:19 AM · Restricted Project, Restricted Project

Jun 16 2023

realqhc updated the diff for D152821: [RISCV] Add support for XCVmac extension in CV32E40P.

add test for objdump

Jun 16 2023, 5:34 PM · Restricted Project, Restricted Project
realqhc updated the summary of D152821: [RISCV] Add support for XCVmac extension in CV32E40P.
Jun 16 2023, 1:07 AM · Restricted Project, Restricted Project
realqhc updated the summary of D152821: [RISCV] Add support for XCVmac extension in CV32E40P.
Jun 16 2023, 12:57 AM · Restricted Project, Restricted Project

Jun 14 2023

realqhc updated the diff for D152821: [RISCV] Add support for XCVmac extension in CV32E40P.

fix header

Jun 14 2023, 9:10 AM · Restricted Project, Restricted Project
realqhc updated the diff for D152821: [RISCV] Add support for XCVmac extension in CV32E40P.

re-name the file to RISCVInstrInfoXCV so that future Core-V extensions can be added in the same file.

Jun 14 2023, 9:06 AM · Restricted Project, Restricted Project
realqhc updated the diff for D152821: [RISCV] Add support for XCVmac extension in CV32E40P.

make disassembler decoder table description more consistent.

Jun 14 2023, 3:23 AM · Restricted Project, Restricted Project
realqhc retitled D152821: [RISCV] Add support for XCVmac extension in CV32E40P from [RISCV] Add support for Xcvmac extension in CV32E40P to [RISCV] Add support for XCVmac extension in CV32E40P.
Jun 14 2023, 3:17 AM · Restricted Project, Restricted Project
realqhc updated the diff for D152821: [RISCV] Add support for XCVmac extension in CV32E40P.

implement naming change XCvmac->XCVmac, make error message consistent with naming.

Jun 14 2023, 3:16 AM · Restricted Project, Restricted Project
realqhc updated the diff for D152821: [RISCV] Add support for XCVmac extension in CV32E40P.

address reviewers' concerns, restrict the instructions to RV32, remove unnecessary emit=0 and add -riscv-no-aliases for tests instead.

Jun 14 2023, 1:35 AM · Restricted Project, Restricted Project
realqhc updated the diff for D152821: [RISCV] Add support for XCVmac extension in CV32E40P.

restrict the instruction to rv32 only, edit the documentations

Jun 14 2023, 1:15 AM · Restricted Project, Restricted Project

Jun 13 2023

realqhc added inline comments to D152821: [RISCV] Add support for XCVmac extension in CV32E40P.
Jun 13 2023, 11:20 PM · Restricted Project, Restricted Project
realqhc updated the diff for D152821: [RISCV] Add support for XCVmac extension in CV32E40P.

address reviewer's concerns, fixed format on RISCVInstrInfoXCvmac.td, reorganized the tests, and added checks for newline in error messages.

Jun 13 2023, 2:48 PM · Restricted Project, Restricted Project
realqhc requested review of D152821: [RISCV] Add support for XCVmac extension in CV32E40P.
Jun 13 2023, 8:46 AM · Restricted Project, Restricted Project

May 9 2023

realqhc updated the diff for D149811: [RISCV][CodeGen] Support Zhinx and Zhinxmin.

remove the dependency on rv32zdinx patch

May 9 2023, 9:09 PM · Restricted Project, Restricted Project
realqhc updated the diff for D149811: [RISCV][CodeGen] Support Zhinx and Zhinxmin.

run clang-format

May 9 2023, 8:50 PM · Restricted Project, Restricted Project
realqhc added a comment to D149811: [RISCV][CodeGen] Support Zhinx and Zhinxmin.

Can we make this patch not depend on Zdinx RV32 support? That patch needs more work and I don't want it to block Zhinx.

May 9 2023, 8:26 PM · Restricted Project, Restricted Project

May 8 2023

realqhc added inline comments to D149811: [RISCV][CodeGen] Support Zhinx and Zhinxmin.
May 8 2023, 6:26 PM · Restricted Project, Restricted Project
realqhc updated the diff for D149811: [RISCV][CodeGen] Support Zhinx and Zhinxmin.

restore the unintentionally removed test cases, it was caused by wrongly defined check prefix in zhinxmin

May 8 2023, 6:25 PM · Restricted Project, Restricted Project
realqhc added a comment to D149811: [RISCV][CodeGen] Support Zhinx and Zhinxmin.
May 8 2023, 6:20 PM · Restricted Project, Restricted Project
realqhc updated the diff for D149811: [RISCV][CodeGen] Support Zhinx and Zhinxmin.

add missing changes in RISCVInstrInfo.cpp regarding FSGNJ_H_INX

May 8 2023, 6:02 PM · Restricted Project, Restricted Project
realqhc added a comment to D149811: [RISCV][CodeGen] Support Zhinx and Zhinxmin.

Do we need to update RISCVInstrInfo::storeRegToStackSlot and RISCVInstrInfo::loadRegFromStackSlot`?

May 8 2023, 5:58 PM · Restricted Project, Restricted Project

May 3 2023

realqhc added reviewers for D149811: [RISCV][CodeGen] Support Zhinx and Zhinxmin: craig.topper, jrtc27, asb, rogfer01, luismarques, frasercrmck, kito-cheng, arcbbb.
May 3 2023, 8:15 PM · Restricted Project, Restricted Project
realqhc updated the diff for D149811: [RISCV][CodeGen] Support Zhinx and Zhinxmin.

rebase

May 3 2023, 8:06 PM · Restricted Project, Restricted Project
realqhc requested review of D149811: [RISCV][CodeGen] Support Zhinx and Zhinxmin.
May 3 2023, 8:04 PM · Restricted Project, Restricted Project

Dec 4 2022

realqhc updated the diff for D138743: [flang] Diagnostic for shape argument in c_f_pointer.

run clang-format

Dec 4 2022, 6:14 PM · Restricted Project, Restricted Project

Dec 2 2022

realqhc added inline comments to D138743: [flang] Diagnostic for shape argument in c_f_pointer.
Dec 2 2022, 7:55 AM · Restricted Project, Restricted Project
realqhc updated the diff for D138743: [flang] Diagnostic for shape argument in c_f_pointer.

add check for size= array rank

Dec 2 2022, 7:50 AM · Restricted Project, Restricted Project
realqhc added inline comments to D138743: [flang] Diagnostic for shape argument in c_f_pointer.
Dec 2 2022, 7:37 AM · Restricted Project, Restricted Project

Dec 1 2022

realqhc updated the diff for D138743: [flang] Diagnostic for shape argument in c_f_pointer.

add back the ERROR prefix for the test case

Dec 1 2022, 2:06 PM · Restricted Project, Restricted Project
realqhc updated the diff for D138743: [flang] Diagnostic for shape argument in c_f_pointer.

fix test case

Dec 1 2022, 2:04 PM · Restricted Project, Restricted Project
realqhc updated the diff for D138743: [flang] Diagnostic for shape argument in c_f_pointer.

replace redundant if statements by GetConstantShape, change argument is GetConstantShape call, rewrite error message

Dec 1 2022, 1:43 PM · Restricted Project, Restricted Project

Nov 29 2022

realqhc updated the diff for D138743: [flang] Diagnostic for shape argument in c_f_pointer.

run clang-format

Nov 29 2022, 2:45 AM · Restricted Project, Restricted Project

Nov 28 2022

realqhc added a reviewer for D138503: [flang] Enable RISC-V for x86CompatibleBehavior in floating point flag: vzakhari.
Nov 28 2022, 2:52 PM · Restricted Project, Restricted Project
realqhc updated the diff for D136547: [flang] Add RISCV-64 support to Optimizer/CodeGen/Target.cpp.

rebase

Nov 28 2022, 2:22 PM · Restricted Project, Restricted Project
realqhc updated the diff for D138743: [flang] Diagnostic for shape argument in c_f_pointer.

fix conflicting naming with previous part in the function

Nov 28 2022, 11:00 AM · Restricted Project, Restricted Project
realqhc updated the diff for D138743: [flang] Diagnostic for shape argument in c_f_pointer.

fix the commit to correctly compare size of array against rank, note that expr->Rank() ==1 is required to fix a potential issue when a non-scalar shape is passed into the function, the program crashes after context.message

Nov 28 2022, 10:54 AM · Restricted Project, Restricted Project

Nov 27 2022

realqhc added reviewers for D138743: [flang] Diagnostic for shape argument in c_f_pointer: peixin, clementval, jeanPerier.
Nov 27 2022, 11:28 PM · Restricted Project, Restricted Project

Nov 26 2022

realqhc requested review of D138743: [flang] Diagnostic for shape argument in c_f_pointer.
Nov 26 2022, 2:47 AM · Restricted Project, Restricted Project

Nov 22 2022

realqhc added a comment to D136547: [flang] Add RISCV-64 support to Optimizer/CodeGen/Target.cpp.

ping.

Failed Tests (1):

flang-OldUnit :: Evaluate/real.test

FAIL: flang-OldUnit :: Evaluate/real.test (1044 of 1652)

  • TEST 'flang-OldUnit :: Evaluate/real.test' FAILED ****

.../llvm-project/flang/unittests/Evaluate/real.cpp:504: FAIL: FlagsToBits(prod.flags) == 0x18, not 0x10
0 0x800001 * 0xbf7ffffe

The only test failed was not due to this patch and it is caused by risc-v not flagging for underflow.

Nov 22 2022, 8:16 AM · Restricted Project, Restricted Project
realqhc added reviewers for D138503: [flang] Enable RISC-V for x86CompatibleBehavior in floating point flag: rovka, schweitz, brad, LemonBoy, dcederman.
Nov 22 2022, 8:15 AM · Restricted Project, Restricted Project
realqhc requested review of D138503: [flang] Enable RISC-V for x86CompatibleBehavior in floating point flag.
Nov 22 2022, 8:13 AM · Restricted Project, Restricted Project
realqhc updated the diff for D136547: [flang] Add RISCV-64 support to Optimizer/CodeGen/Target.cpp.

change the argument type to match clang behaviors

Nov 22 2022, 4:31 AM · Restricted Project, Restricted Project
realqhc added a comment to D136547: [flang] Add RISCV-64 support to Optimizer/CodeGen/Target.cpp.

ping.

Nov 22 2022, 12:03 AM · Restricted Project, Restricted Project

Nov 21 2022

realqhc added inline comments to D136547: [flang] Add RISCV-64 support to Optimizer/CodeGen/Target.cpp.
Nov 21 2022, 10:22 PM · Restricted Project, Restricted Project

Nov 4 2022

realqhc updated the diff for D136547: [flang] Add RISCV-64 support to Optimizer/CodeGen/Target.cpp.

run clang-format to fix it

Nov 4 2022, 2:16 AM · Restricted Project, Restricted Project

Oct 31 2022

realqhc updated the diff for D136547: [flang] Add RISCV-64 support to Optimizer/CodeGen/Target.cpp.

rebase commit to up to date main

Oct 31 2022, 10:11 PM · Restricted Project, Restricted Project
realqhc updated the diff for D136547: [flang] Add RISCV-64 support to Optimizer/CodeGen/Target.cpp.

rebase the commit

Oct 31 2022, 6:21 AM · Restricted Project, Restricted Project
realqhc added a comment to D136547: [flang] Add RISCV-64 support to Optimizer/CodeGen/Target.cpp.

Do you have a buildbot that test this target for Flang?

Ping.

Oct 31 2022, 1:11 AM · Restricted Project, Restricted Project

Oct 30 2022

realqhc added reviewers for D136547: [flang] Add RISCV-64 support to Optimizer/CodeGen/Target.cpp: rovka, schweitz, brad, LemonBoy.
Oct 30 2022, 11:28 PM · Restricted Project, Restricted Project

Oct 24 2022

realqhc updated the diff for D136547: [flang] Add RISCV-64 support to Optimizer/CodeGen/Target.cpp.

Run clang-format on the patch

Oct 24 2022, 12:21 AM · Restricted Project, Restricted Project

Oct 23 2022

realqhc requested review of D136547: [flang] Add RISCV-64 support to Optimizer/CodeGen/Target.cpp.
Oct 23 2022, 12:53 AM · Restricted Project, Restricted Project

Mar 23 2022

realqhc updated the diff for D121774: [RISCV] support fcmp in zfinx,zdinx,zhinx.

revert changes to splitpairf64pesudo, remove SplitPairF64Pseudo_INX

Mar 23 2022, 11:15 PM · Restricted Project, Restricted Project
realqhc updated the diff for D121774: [RISCV] support fcmp in zfinx,zdinx,zhinx.

revert changes to buildpairf64pesudo, fix test for rv32 zdinx

Mar 23 2022, 11:00 PM · Restricted Project, Restricted Project
realqhc updated the diff for D121774: [RISCV] support fcmp in zfinx,zdinx,zhinx.

address concerns, add test for rv32

Mar 23 2022, 10:28 PM · Restricted Project, Restricted Project

Mar 16 2022

realqhc added reviewers for D121774: [RISCV] support fcmp in zfinx,zdinx,zhinx: craig.topper, asb, jrtc27.
Mar 16 2022, 9:11 PM · Restricted Project, Restricted Project
realqhc updated the summary of D121774: [RISCV] support fcmp in zfinx,zdinx,zhinx.
Mar 16 2022, 4:42 AM · Restricted Project, Restricted Project
realqhc updated the diff for D121774: [RISCV] support fcmp in zfinx,zdinx,zhinx.

[RISCV] revert target-abi test and abi error string format

Mar 16 2022, 4:39 AM · Restricted Project, Restricted Project
realqhc updated the diff for D121774: [RISCV] support fcmp in zfinx,zdinx,zhinx.

[RISCV] remove strict_fcmp and arith

Mar 16 2022, 3:55 AM · Restricted Project, Restricted Project
realqhc updated the diff for D121774: [RISCV] support fcmp in zfinx,zdinx,zhinx.

[RISCV] Remove fcmp-strict instructions in zfinx, zdinx, and zhinx

Mar 16 2022, 1:07 AM · Restricted Project, Restricted Project
realqhc requested review of D121774: [RISCV] support fcmp in zfinx,zdinx,zhinx.
Mar 16 2022, 12:41 AM · Restricted Project, Restricted Project

Feb 24 2022

realqhc added reviewers for D120525: [RISCV] Change rvv version to 1.0 and remove ratify notice: frasercrmck, HsiangKai.
Feb 24 2022, 4:34 PM · Restricted Project
realqhc updated the summary of D120525: [RISCV] Change rvv version to 1.0 and remove ratify notice.
Feb 24 2022, 4:29 PM · Restricted Project
realqhc retitled D120525: [RISCV] Change rvv version to 1.0 and remove ratify notice from change rvv version to 1.0 and remove ratify notice to [RISCV] Change rvv version to 1.0 and remove ratify notice.
Feb 24 2022, 4:26 PM · Restricted Project
realqhc requested review of D120525: [RISCV] Change rvv version to 1.0 and remove ratify notice.
Feb 24 2022, 4:24 PM · Restricted Project