This patch implements support for the &, |, ^, and ~ operators on sizeless SVE
types.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Looking reasonable to me, one comment.
clang/lib/Sema/SemaExpr.cpp | ||
---|---|---|
10468 | There is a saying that booleans are often inferior to enums in arguments. I think this might be one of those cases, could you use the enum ArithConvKind instead? As a side effect call sites will be clear without the need for a comment string: CheckSizelessVectorOperands(LHS, RHS, Loc, ACK_Arithmetic); ... and it will be extensible to other kinds, which I presume are likely to creep in here as more operators are added. |
There is a saying that booleans are often inferior to enums in arguments. I think this might be one of those cases, could you use the enum ArithConvKind instead?
As a side effect call sites will be clear without the need for a comment string:
... and it will be extensible to other kinds, which I presume are likely to creep in here as more operators are added.