I'd like to see one-liner comments on each test explaining the spirit of what is being tested.

Suggesting a few small tweaks. Otherwise LGTM when @rnk is happy.

Update for review comment.

Attempting to update commit message with arc diff --verbatim.

I've taken over the differential.

Update patch for clang-format

Tweak message to address review comment.

LGTM.

Tried to break it, wasn't able to. Looks straightforward.

Suggestion: Where referencing sections you could include the title "3.7.3.3. Behavior specific to SVE vectors" instead of "3.7.3.3" for example. I think this makes it easier to spot misreferences and gives future souls a better chance to understand the context without indirection.

fixed_float64_t appears in the commit message but also is unused.

Nit: I think the commit message could be improved such that the benefit is clear? Something referencing the fact you're modifying the behaviour of TBZ.

Put back subject [tags] stripped by git am.

Address review comments:

• Update llc test using utils/update_llc_test_checks.py.
• Pass vector as operand to function to shrink test.

Address review comments.

In D89701#2338897, @david-arm wrote:

Is it perhaps worth renaming the test to have sve in the name, i.e. sve-redundant-stores.ll? We've been following this convention for other tests.

LGTM, thanks!

@thakis: I've marked the test unsupported in c75cd3c7f0f. Hopefully that makes your builder happy! I'll figure out what is going on and fix it.

I've thought about it for a moment and I'm currently at a loss to quickly explain why this would only fail on darwin. In my patch, the change to LookupTypeForExtension should prevent clang from reaching this state where it complains about a preprocessed input.

@thakis: I found the thread at https://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20120430/057199.html

Thanks for chiming in.

Sorry, I had missed the RfC, but it looks like there wasn't a lot of discussion on it anyways.

In D63607#1726895, @teemperor wrote:

Could we have the clang/test/Driver/flang/flang.F90 and clang/test/Driver/flang/flang.f90 files in different directories please? As macOS's FS is case-insensitive, those two files have the same path from macOS perspective which is causing a whole bunch of issues (including breaking git even with 'core.ignorecase').

Submitted in 6bf55804924d5a1d902925ad080b1a2b57c5c75c.

Revoking my previous request: I now have commit access and I intend to submit this shortly.

I'm still awaiting commit access, please can someone submit this on my behalf?

I have rebased the patch for conflicts to master and all the tests are passing.

Friendly ping to everybody watching. I'd like to get this in soon if possible.

Hi All, I'm going on leave for two weeks, returning October 14th. I can plausibly respond to comments until 14:00 UTC tomorrow (Thu 25th Sept).

Thanks everyone for your comments.

• Fixed spurious comma
• Fixed incorrect comment and changed comment wrapping.

Updated comment for IsFlangMode.

Updated for review comments and spotted a couple of things myself.

Fixed assertion message "Input output." => "Invalid output". The erroneous text came was copied from: https://github.com/llvm/llvm-project/blob/6b9df910d04fae62dacc22c1c84f66c0f126cde0/clang/lib/Driver/ToolChains/Clang.cpp#L3849

I updated this "prototype" revision into the real thing I would like to submit. Please let me know if that was the wrong thing to do and I will resubmit it.

I do not have submit permissions, please can someone submit on my behalf?

Updated for code review comment.

Add target triple to test.

Include full context.

Note: In case you see this early, the email isn't yet sent to the list. I'll link it here when it is, likely tomorrow.