Page MenuHomePhabricator

peterwaller-arm (Peter Waller)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 20 2019, 2:39 AM (158 w, 1 d)

Recent Activity

Yesterday

peterwaller-arm accepted D127209: [SVE][AArch64] Refine hasSVEArgsOrReturn.
Thu, Jun 30, 3:30 AM · Restricted Project, Restricted Project
peterwaller-arm added inline comments to D127209: [SVE][AArch64] Refine hasSVEArgsOrReturn.
Thu, Jun 30, 1:59 AM · Restricted Project, Restricted Project

Mon, Jun 27

peterwaller-arm added a comment to D128642: [AArch64][SVE] Use SVE for VLS fcopysign for wide vectors.

FYI, if I add -mattr=+sve2 to your test arguments, I get:

Mon, Jun 27, 7:47 AM · Restricted Project, Restricted Project
peterwaller-arm added inline comments to D128503: [AArch64][SVE] Lower aarch64_sve_dupq_lane to ld1rq.
Mon, Jun 27, 1:24 AM · Restricted Project, Restricted Project

Wed, Jun 22

peterwaller-arm added inline comments to D127209: [SVE][AArch64] Refine hasSVEArgsOrReturn.
Wed, Jun 22, 2:38 AM · Restricted Project, Restricted Project

Mon, Jun 20

peterwaller-arm accepted D128199: [NFC][SVE] Simplify SUBR_ZI isel patterns..
Mon, Jun 20, 7:23 AM · Restricted Project, Restricted Project

May 30 2022

peterwaller-arm added reviewers for D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))': aaron.ballman, qiucf, rjmccall.
May 30 2022, 4:47 AM · Restricted Project, Restricted Project
peterwaller-arm accepted D126487: [SVE] Fixed custom lowering of ISD::INSERT_SUBVECTOR..

An observation: nounwind only appears to affect output for 5 tests, in case there is an appetite to remove it elsewhere: insert_v2i64_nxv2i64_idx2 / insert_v4i32_nxv4i32_idx4 / insert_v16i8_nxv16i8_idx16 / insert_nxv8f16_nxv2f16 / insert_nxv4bf16_v4bf16.

May 30 2022, 4:35 AM · Restricted Project, Restricted Project

May 25 2022

peterwaller-arm added a comment to D126415: [gn build] Set llvm_have_mallinfo2 to true by default.

For anyone wandering the internet in search of an answer to all their woes (probably future me, Hi future me!), this is the relevant error.

FAILED: obj/llvm/lib/Support/Support.Process.o
clang++ -MMD -MF obj/llvm/lib/Support/Support.Process.o.d -o obj/llvm/lib/Support/Support.Process.o -c ../../llvm/lib/Support/Process.cpp  -I../../llvm/lib/Support/Unix -I../../llvm/lib/Support/Windows -I../../llvm/include -Igen/llvm/include -O3 -fdiagnostics-color -Wall -Wextra -Wno-unused-parameter -Wdelete-non-virtual-dtor -Wstring-conversion -no-canonical-prefixes -Werror=date-time -fPIC -Wcovered-switch-default -std=c++14 -fvisibility-inlines-hidden -fno-exceptions -fno-rtti
In file included from ../../llvm/lib/Support/Process.cpp:107:
../../llvm/lib/Support/Unix/Process.inc:93:20: error: variable has incomplete type 'struct mallinfo2'
  struct mallinfo2 mi;
                   ^
../../llvm/lib/Support/Unix/Process.inc:93:10: note: forward declaration of 'mallinfo2'
  struct mallinfo2 mi;
         ^
../../llvm/lib/Support/Unix/Process.inc:94:10: error: no member named 'mallinfo2' in the global namespace
  mi = ::mallinfo2();
       ~~^
2 errors generated.
May 25 2022, 1:52 PM · Restricted Project, Restricted Project
peterwaller-arm accepted D126415: [gn build] Set llvm_have_mallinfo2 to true by default.

Thanks for the note, I appreciate it.

May 25 2022, 1:50 PM · Restricted Project, Restricted Project

May 23 2022

peterwaller-arm planned changes to D125956: [NOT YET FOR REVIEW][AArch64][LV] Implement AArch64TTIImpl::getRegisterClassForType.

Forgot to press the abandon button, and changed my mind, I'll leave it in changes planned for a bit since there are no reviewers tagged yet.

May 23 2022, 2:23 AM · Restricted Project, Restricted Project
peterwaller-arm added a comment to D125956: [NOT YET FOR REVIEW][AArch64][LV] Implement AArch64TTIImpl::getRegisterClassForType.

I'm going to abandon this for now, though I may take another swipe at this later. I've identified while testing other types that this patch is wrong because it's not returning VectorRC when it should.

May 23 2022, 2:22 AM · Restricted Project, Restricted Project
peterwaller-arm committed rGade47bdc317b: [LV] Improve register pressure estimate at high VFs (authored by peterwaller-arm).
[LV] Improve register pressure estimate at high VFs
May 23 2022, 1:02 AM · Restricted Project, Restricted Project
peterwaller-arm closed D125918: [LV] Improve register pressure estimate at high VFs.
May 23 2022, 1:01 AM · Restricted Project, Restricted Project
peterwaller-arm updated the diff for D125918: [LV] Improve register pressure estimate at high VFs.
  • Remove target-features test attribute per review and rebase.
May 23 2022, 12:59 AM · Restricted Project, Restricted Project

May 19 2022

peterwaller-arm added a comment to D125956: [NOT YET FOR REVIEW][AArch64][LV] Implement AArch64TTIImpl::getRegisterClassForType.

On the effect of this patch: there are 10 translation units out of ~2,000 in the LNT benchmarks which have differing codegen as a consequence. I'll check for any performance effect next week before proposing this.

May 19 2022, 8:01 AM · Restricted Project, Restricted Project
peterwaller-arm added a comment to D125956: [NOT YET FOR REVIEW][AArch64][LV] Implement AArch64TTIImpl::getRegisterClassForType.

A fair point on the vector/fp overlap, will consider.

May 19 2022, 5:03 AM · Restricted Project, Restricted Project
peterwaller-arm added inline comments to D125918: [LV] Improve register pressure estimate at high VFs.
May 19 2022, 2:38 AM · Restricted Project, Restricted Project
peterwaller-arm requested review of D125956: [NOT YET FOR REVIEW][AArch64][LV] Implement AArch64TTIImpl::getRegisterClassForType.
May 19 2022, 2:36 AM · Restricted Project, Restricted Project
peterwaller-arm updated the diff for D125918: [LV] Improve register pressure estimate at high VFs.
  • Address Paul's suggestion: make getRegUsageForType return unsigned and simplify.
May 19 2022, 2:24 AM · Restricted Project, Restricted Project

May 18 2022

peterwaller-arm requested review of D125918: [LV] Improve register pressure estimate at high VFs.
May 18 2022, 12:04 PM · Restricted Project, Restricted Project

May 17 2022

peterwaller-arm added inline comments to D125016: [LV] Widen freeze instead of scalarizing it.
May 17 2022, 2:08 AM · Restricted Project, Restricted Project

May 12 2022

peterwaller-arm added inline comments to D124860: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations.
May 12 2022, 1:53 AM · Restricted Project, Restricted Project

May 11 2022

peterwaller-arm added inline comments to D124836: [AArch64] Add support for -fzero-call-used-regs.
May 11 2022, 12:36 PM · Restricted Project, Restricted Project, Restricted Project

May 9 2022

peterwaller-arm added a comment to D124860: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations.

Looking pretty good. A couple of test cases to consider:

May 9 2022, 1:48 AM · Restricted Project, Restricted Project
peterwaller-arm added inline comments to D124836: [AArch64] Add support for -fzero-call-used-regs.
May 9 2022, 1:29 AM · Restricted Project, Restricted Project, Restricted Project

May 5 2022

peterwaller-arm added inline comments to D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang.
May 5 2022, 5:55 AM · Restricted Project, Restricted Project
peterwaller-arm accepted D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang.

Looks good to me with minor nits.

May 5 2022, 5:45 AM · Restricted Project, Restricted Project
peterwaller-arm committed rG75f9e83ace52: [AArch64] Add -aarch64-insert-extract-base-cost (authored by peterwaller-arm).
[AArch64] Add -aarch64-insert-extract-base-cost
May 5 2022, 3:37 AM · Restricted Project, Restricted Project
peterwaller-arm closed D124835: [AArch64] Add -aarch64-insert-extract-base-cost.
May 5 2022, 3:37 AM · Restricted Project, Restricted Project
peterwaller-arm accepted D124908: [SVE] Optimize new cases for lowerConvertToSVBool.

LGTM with a naming nit, please leave others time to chime in before submitting as usual.

May 5 2022, 1:50 AM · Restricted Project, Restricted Project

May 4 2022

peterwaller-arm added inline comments to D124836: [AArch64] Add support for -fzero-call-used-regs.
May 4 2022, 1:32 AM · Restricted Project, Restricted Project, Restricted Project

May 3 2022

peterwaller-arm added inline comments to D124835: [AArch64] Add -aarch64-insert-extract-base-cost.
May 3 2022, 6:58 AM · Restricted Project, Restricted Project
peterwaller-arm updated the diff for D124835: [AArch64] Add -aarch64-insert-extract-base-cost.
  • Drop unneeded braces.
  • Drop unneeded default argument.
May 3 2022, 6:57 AM · Restricted Project, Restricted Project
peterwaller-arm updated the diff for D124835: [AArch64] Add -aarch64-insert-extract-base-cost.

In the previous patch I missed that the choice of CPU can override the default
value, and by chance this continued to work. Add a test and fix this.

May 3 2022, 5:48 AM · Restricted Project, Restricted Project
peterwaller-arm updated the diff for D124835: [AArch64] Add -aarch64-insert-extract-base-cost.
  • Make the flag absolute, per review comment (-aarch64-insert-extract-cost-adjustment => -aarch64-insert-extract-base-cost)
May 3 2022, 5:31 AM · Restricted Project, Restricted Project
peterwaller-arm updated the diff for D124835: [AArch64] Add -aarch64-insert-extract-base-cost.
  • Add tests:
    • Switch to utils/update_analyze_test_checks.py
    • Increasing
    • Decreasing
    • Underflow
    • FP
May 3 2022, 4:24 AM · Restricted Project, Restricted Project
peterwaller-arm requested review of D124835: [AArch64] Add -aarch64-insert-extract-base-cost.
May 3 2022, 2:48 AM · Restricted Project, Restricted Project

Apr 28 2022

peterwaller-arm accepted D124091: [clang][AArch64][SVE] Implement conditional operator for SVE vectors.
Apr 28 2022, 9:07 AM · Restricted Project, Restricted Project

Apr 26 2022

peterwaller-arm added inline comments to D124091: [clang][AArch64][SVE] Implement conditional operator for SVE vectors.
Apr 26 2022, 2:18 AM · Restricted Project, Restricted Project

Apr 4 2022

peterwaller-arm accepted D122896: [InstCombine] Extend support for folding select + masked gathers.

Accept with some nits in the tests which need fixing.

Apr 4 2022, 4:15 AM · Restricted Project, Restricted Project

Mar 31 2022

peterwaller-arm committed rGf1cb816f9085: [AArch64][SVE] Mark {CNT*,RDVL,INDEX} as materializable (authored by peterwaller-arm).
[AArch64][SVE] Mark {CNT*,RDVL,INDEX} as materializable
Mar 31 2022, 8:33 AM · Restricted Project, Restricted Project
peterwaller-arm closed D122731: [AArch64][SVE] Mark {CNT*,RDVL,INDEX} as materializable.
Mar 31 2022, 8:33 AM · Restricted Project, Restricted Project

Mar 30 2022

peterwaller-arm requested review of D122731: [AArch64][SVE] Mark {CNT*,RDVL,INDEX} as materializable.
Mar 30 2022, 8:12 AM · Restricted Project, Restricted Project
peterwaller-arm accepted D122404: [clang][AArc64][SVE] Add support for comparison operators on SVE types.

LGTM, looks like the formatter might have hit some lines you didn't intend to change -- if it's not too invasive perhaps worth a seperate NFC patch to format the file?

Mar 30 2022, 2:16 AM · Restricted Project, Restricted Project

Mar 21 2022

peterwaller-arm accepted D121829: [clang][AArc64][SVE] Implement vector-scalar operators.
Mar 21 2022, 5:40 AM · Restricted Project, Restricted Project
peterwaller-arm accepted D122013: [InstCombine] Fold abs of known negative operand when source is sub.

Seems reasonable to me.

Mar 21 2022, 4:16 AM · Restricted Project, Restricted Project
peterwaller-arm added inline comments to D122013: [InstCombine] Fold abs of known negative operand when source is sub.
Mar 21 2022, 3:13 AM · Restricted Project, Restricted Project

Mar 17 2022

peterwaller-arm added a comment to D121792: [AArch64][SVE] InstCombine llvm.aarch64.sve.sel to select.

Why do we have llvm.aarch64.sve.sel if we are always going to replace it with a select? Why not remove llvm.aarch64.sve.sel entirely?

Mar 17 2022, 2:13 AM · Restricted Project, Restricted Project, Restricted Project

Mar 16 2022

peterwaller-arm accepted D121119: [clang][SVE] Add support for bitwise operators on SVE types.

LGTM, modulo that the require lines look like they need fixing.

Mar 16 2022, 6:12 AM · Restricted Project, Restricted Project

Mar 9 2022

peterwaller-arm added a comment to D121119: [clang][SVE] Add support for bitwise operators on SVE types.

Looking reasonable to me, one comment.

Mar 9 2022, 5:49 AM · Restricted Project, Restricted Project

Mar 7 2022

peterwaller-arm accepted D120323: [clang][SVE] Add support for arithmetic operators on SVE types.
Mar 7 2022, 2:49 AM · Restricted Project, Restricted Project

Mar 3 2022

peterwaller-arm raised a concern with rG15ba588d6d42: [test] Migrate '-analyze -cost-model' to '-passes=print<cost-model>'.

@aeubanks FYI this patch breaks test autogeneration. The reason is that changes the print header such that the regular expressions in update_analyze_test_checks.py no longer match.

Mar 3 2022, 9:26 AM

Feb 23 2022

peterwaller-arm added inline comments to D119926: [Clang][AArch64] Enable _Float16 _Complex type.
Feb 23 2022, 5:43 AM · Restricted Project

Feb 16 2022

peterwaller-arm accepted D119926: [Clang][AArch64] Enable _Float16 _Complex type.

LGTM.

Feb 16 2022, 7:48 AM · Restricted Project
peterwaller-arm accepted D119424: [AArch64][SVE] Invert VSelect operand order and condition for predicated arithmetic operations.
Feb 16 2022, 3:02 AM · Restricted Project
peterwaller-arm added a comment to D119926: [Clang][AArch64] Enable _Float16 _Complex type.

Some comments.

Feb 16 2022, 2:57 AM · Restricted Project
peterwaller-arm added inline comments to D119336: [AArch64][SVE] Avoid multiple PTRUE values for SETCC..
Feb 16 2022, 2:45 AM · Restricted Project, Restricted Project

Feb 15 2022

peterwaller-arm added a comment to D119424: [AArch64][SVE] Invert VSelect operand order and condition for predicated arithmetic operations.

Functionally I think it's looking reasonable to me. A few more stylistic nits.

Feb 15 2022, 8:51 AM · Restricted Project

Feb 14 2022

peterwaller-arm accepted D119453: [AArch64] Suggest b.nfrst if the user tries b.nfirst..

LGTM with one more consistency tweak.

Feb 14 2022, 8:39 AM · Restricted Project
peterwaller-arm added inline comments to D119424: [AArch64][SVE] Invert VSelect operand order and condition for predicated arithmetic operations.
Feb 14 2022, 8:31 AM · Restricted Project
peterwaller-arm committed rG7f41643ef06d: [gn build] Add host_cpu=arm64 & current_os=linux => aarch64-unknown-linux-gnu (authored by peterwaller-arm).
[gn build] Add host_cpu=arm64 & current_os=linux => aarch64-unknown-linux-gnu
Feb 14 2022, 2:55 AM
peterwaller-arm closed D119331: [gn build] Add host_cpu=arm64 & current_os=linux => aarch64-unknown-linux-gnu.
Feb 14 2022, 2:55 AM · Restricted Project

Feb 9 2022

peterwaller-arm requested review of D119331: [gn build] Add host_cpu=arm64 & current_os=linux => aarch64-unknown-linux-gnu.
Feb 9 2022, 6:18 AM · Restricted Project

Feb 3 2022

peterwaller-arm added inline comments to D118617: [AArch64][SVE] Remove false register dependency for unary FP convert operations.
Feb 3 2022, 6:49 AM · Restricted Project
peterwaller-arm accepted D118394: [AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP.

LGTM. I see the one additional instruction in the NOFP16 case which is an artefact of how the BSP node is defined, which is not changed in this patch. We've discussed it and attempted to remove it, but failed for now.

Feb 3 2022, 6:14 AM · Restricted Project
peterwaller-arm added a reviewer for D118617: [AArch64][SVE] Remove false register dependency for unary FP convert operations: sdesmalen.
Feb 3 2022, 2:34 AM · Restricted Project

Feb 2 2022

peterwaller-arm added a comment to D118617: [AArch64][SVE] Remove false register dependency for unary FP convert operations.

Getting there, thanks for the improvements. I've picked up on a few more things, but I think this is close to ready.

Feb 2 2022, 4:49 AM · Restricted Project
peterwaller-arm accepted D117689: [AArch64][SVE] Fold vselect into predicated fmul, fsub and fadd.
Feb 2 2022, 1:27 AM · Restricted Project

Feb 1 2022

peterwaller-arm added inline comments to D118394: [AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP.
Feb 1 2022, 7:07 AM · Restricted Project
peterwaller-arm added a comment to D118617: [AArch64][SVE] Remove false register dependency for unary FP convert operations.

Thanks for the patch, I think this is looking reasonable to my knowledge. I've spotted the cause of the issues you've mentioned.

Feb 1 2022, 4:20 AM · Restricted Project

Jan 26 2022

peterwaller-arm accepted D118269: [gn build] Make HAVE_MALLINFO2 a gn arg, default to false.

Looks like the build is broken due to PPC_LINUX_DEFAULT_IEEELONGDOUBLE, but reverting 08e535a50797, this differential fixes it.

Jan 26 2022, 10:14 AM · Restricted Project, Restricted Project
peterwaller-arm added inline comments to D117689: [AArch64][SVE] Fold vselect into predicated fmul, fsub and fadd.
Jan 26 2022, 8:36 AM · Restricted Project
peterwaller-arm added inline comments to D117689: [AArch64][SVE] Fold vselect into predicated fmul, fsub and fadd.
Jan 26 2022, 8:32 AM · Restricted Project
peterwaller-arm added inline comments to D118145: [AArch64][SVE] Avoid using ptrue for ptest in VECREDUCE_OR..
Jan 26 2022, 7:29 AM · Restricted Project
peterwaller-arm added inline comments to D117689: [AArch64][SVE] Fold vselect into predicated fmul, fsub and fadd.
Jan 26 2022, 7:27 AM · Restricted Project
peterwaller-arm added inline comments to D117689: [AArch64][SVE] Fold vselect into predicated fmul, fsub and fadd.
Jan 26 2022, 7:27 AM · Restricted Project
peterwaller-arm accepted D118139: [AArch64][SVE][VLS] Move extends into arguments of comparisons.
Jan 26 2022, 7:07 AM · Restricted Project
peterwaller-arm added a comment to D117916: [gn build] Set HAVE_MALLINFO2=1.

Heads up, this did break my dev build and switching out libc is a nontrivial prospect for me for now. A configurable would be nice to have.

Jan 26 2022, 5:47 AM · Restricted Project

Jan 20 2022

peterwaller-arm added a reverting change for rGdb04d3e30b38: [AArch64][SVE][VLS] Move extends into arguments of comparisons: rGd4a6bf4d1a91: Revert "[AArch64][SVE][VLS] Move extends into arguments of comparisons".
Jan 20 2022, 4:02 AM
peterwaller-arm committed rGd4a6bf4d1a91: Revert "[AArch64][SVE][VLS] Move extends into arguments of comparisons" (authored by peterwaller-arm).
Revert "[AArch64][SVE][VLS] Move extends into arguments of comparisons"
Jan 20 2022, 4:02 AM
peterwaller-arm added a reverting change for D116812: [AArch64][SVE][VLS] Move extends into arguments of comparisons: rGd4a6bf4d1a91: Revert "[AArch64][SVE][VLS] Move extends into arguments of comparisons".
Jan 20 2022, 4:02 AM · Restricted Project

Jan 19 2022

peterwaller-arm added a reviewer for D117689: [AArch64][SVE] Fold vselect into predicated fmul, fsub and fadd: kmclaughlin.
Jan 19 2022, 9:07 AM · Restricted Project
peterwaller-arm accepted D117675: [LangRef] Mangle all vector operands in insert/extract intrinsics.

LGTM. Thanks for taking the time to fix this.

Jan 19 2022, 6:47 AM · Restricted Project
peterwaller-arm added a reviewer for D116812: [AArch64][SVE][VLS] Move extends into arguments of comparisons: sdesmalen.
Jan 19 2022, 3:18 AM · Restricted Project

Jan 18 2022

peterwaller-arm added inline comments to D116812: [AArch64][SVE][VLS] Move extends into arguments of comparisons.
Jan 18 2022, 5:26 AM · Restricted Project
peterwaller-arm accepted D116812: [AArch64][SVE][VLS] Move extends into arguments of comparisons.
Jan 18 2022, 2:12 AM · Restricted Project

Jan 13 2022

peterwaller-arm added a comment to D116812: [AArch64][SVE][VLS] Move extends into arguments of comparisons.

Looks reasonable to me. A suggestion inline.

Jan 13 2022, 7:49 AM · Restricted Project
peterwaller-arm accepted D116730: [AArch64][SVE] Remove Redundant aarch64.sve.convert.to.svbool.

LGTM with some editorial suggestions.

Jan 13 2022, 4:03 AM · Restricted Project

Jan 6 2022

peterwaller-arm accepted D116737: [DAG][AArch64][SVE] Fix VLS mulh code generation.
Jan 6 2022, 8:47 AM · Restricted Project
peterwaller-arm added a comment to D116730: [AArch64][SVE] Remove Redundant aarch64.sve.convert.to.svbool.

A couple of initial comments. It also looks like the code needs formatting.

Jan 6 2022, 3:08 AM · Restricted Project

Jan 4 2022

peterwaller-arm accepted D116227: [SVE] Add ISel for fabs(fsub(a,b)) ==> FABD..
Jan 4 2022, 2:12 AM · Restricted Project

Dec 13 2021

peterwaller-arm accepted D115641: [AArch64][SVE] Replace mask pointers in fixed-length-fp-vselect test.
Dec 13 2021, 9:23 AM · Restricted Project
peterwaller-arm accepted D115448: [AArch64][SVE] Instcombine SDIV to ASRD.

LGTM with a nit.

Dec 13 2021, 7:16 AM · Restricted Project
peterwaller-arm accepted D111221: [AArch64][SVE] Improve code generation for VLS i1 masks.
Dec 13 2021, 7:03 AM · Restricted Project
peterwaller-arm accepted D108115: [DAG][sve] Lowering for VLS masked truncating stores.
Dec 13 2021, 7:01 AM · Restricted Project
peterwaller-arm committed rG921e89c59a71: [SVE] Only combine (fneg (fma)) => FNMLA with nsz (authored by peterwaller-arm).
[SVE] Only combine (fneg (fma)) => FNMLA with nsz
Dec 13 2021, 3:35 AM
peterwaller-arm closed D109525: [SVE] Only combine (fneg (fma)) => FNMLA with nsz.
Dec 13 2021, 3:35 AM · Restricted Project

Dec 9 2021

peterwaller-arm added inline comments to D111221: [AArch64][SVE] Improve code generation for VLS i1 masks.
Dec 9 2021, 8:47 AM · Restricted Project
peterwaller-arm added inline comments to D115448: [AArch64][SVE] Instcombine SDIV to ASRD.
Dec 9 2021, 8:06 AM · Restricted Project