- User Since
- Jun 20 2019, 2:39 AM (83 w, 5 d)
Mon, Jan 11
I'd like to see one-liner comments on each test explaining the spirit of what is being tested.
Thu, Jan 7
Suggesting a few small tweaks. Otherwise LGTM when @rnk is happy.
Wed, Jan 6
Tue, Jan 5
Update for review comment.
Mon, Jan 4
Dec 15 2020
Dec 14 2020
Attempting to update commit message with arc diff --verbatim.
I've taken over the differential.
Dec 10 2020
Dec 8 2020
Update patch for clang-format
Dec 2 2020
Tweak message to address review comment.
Nov 25 2020
Tried to break it, wasn't able to. Looks straightforward.
Nov 16 2020
Nov 9 2020
Suggestion: Where referencing sections you could include the title "22.214.171.124. Behavior specific to SVE vectors" instead of "126.96.36.199" for example. I think this makes it easier to spot misreferences and gives future souls a better chance to understand the context without indirection.
fixed_float64_t appears in the commit message but also is unused.
Nov 3 2020
Nit: I think the commit message could be improved such that the benefit is clear? Something referencing the fact you're modifying the behaviour of TBZ.
Oct 28 2020
Oct 26 2020
Oct 20 2020
Put back subject [tags] stripped by git am.
Address review comments:
- Update llc test using utils/update_llc_test_checks.py.
- Pass vector as operand to function to shrink test.
Oct 19 2020
Address review comments.
Apr 9 2020
Oct 31 2019
Oct 30 2019
I've thought about it for a moment and I'm currently at a loss to quickly explain why this would only fail on darwin. In my patch, the change to LookupTypeForExtension should prevent clang from reaching this state where it complains about a preprocessed input.
@thakis: I found the thread at https://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20120430/057199.html
Thanks for chiming in.
Sorry, I had missed the RfC, but it looks like there wasn't a lot of discussion on it anyways.
Submitted in 6bf55804924d5a1d902925ad080b1a2b57c5c75c.
Revoking my previous request: I now have commit access and I intend to submit this shortly.
Oct 29 2019
I'm still awaiting commit access, please can someone submit this on my behalf?
Oct 24 2019
I have rebased the patch for conflicts to master and all the tests are passing.
Oct 15 2019
Friendly ping to everybody watching. I'd like to get this in soon if possible.
Sep 25 2019
Hi All, I'm going on leave for two weeks, returning October 14th. I can plausibly respond to comments until 14:00 UTC tomorrow (Thu 25th Sept).
Sep 19 2019
Thanks everyone for your comments.
Sep 18 2019
- Fixed spurious comma
- Fixed incorrect comment and changed comment wrapping.
Updated comment for IsFlangMode.
Updated for review comments and spotted a couple of things myself.
Sep 11 2019
Fixed assertion message "Input output." => "Invalid output". The erroneous text came was copied from: https://github.com/llvm/llvm-project/blob/6b9df910d04fae62dacc22c1c84f66c0f126cde0/clang/lib/Driver/ToolChains/Clang.cpp#L3849
Sep 10 2019
I updated this "prototype" revision into the real thing I would like to submit. Please let me know if that was the wrong thing to do and I will resubmit it.
Aug 20 2019
I do not have submit permissions, please can someone submit on my behalf?
Aug 19 2019
Updated for code review comment.
Add target triple to test.
Aug 14 2019
Aug 12 2019
Jun 24 2019
Include full context.
Jun 20 2019
Note: In case you see this early, the email isn't yet sent to the list. I'll link it here when it is, likely tomorrow.