Page MenuHomePhabricator

peterwaller-arm (Peter Waller)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 20 2019, 2:39 AM (65 w, 6 d)

Recent Activity

Apr 9 2020

GitHub <noreply@github.com> committed rG42cc44fbc8dc: [flang] Add script to flatten git history for llvm monorepo submission (flang… (authored by peterwaller-arm).
[flang] Add script to flatten git history for llvm monorepo submission (flang…
Apr 9 2020, 12:57 PM
peterwaller-arm committed rGc9944df916e4: [flang] Revert "Remove needless braces" (authored by peterwaller-arm).
[flang] Revert "Remove needless braces"
Apr 9 2020, 11:18 AM

Oct 31 2019

peterwaller-arm accepted D69636: Make flang driver stuff work on macOS.

LGTM, thanks!

Oct 31 2019, 2:21 AM · Restricted Project

Oct 30 2019

peterwaller-arm added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

@thakis: I've marked the test unsupported in c75cd3c7f0f. Hopefully that makes your builder happy! I'll figure out what is going on and fix it.

Oct 30 2019, 10:07 AM · Restricted Project
peterwaller-arm committed rGc75cd3c7f0f9: [clang][driver][flang] Mark test as unsupported on darwin (authored by peterwaller-arm).
[clang][driver][flang] Mark test as unsupported on darwin
Oct 30 2019, 10:03 AM
peterwaller-arm added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

I've thought about it for a moment and I'm currently at a loss to quickly explain why this would only fail on darwin. In my patch, the change to LookupTypeForExtension should prevent clang from reaching this state where it complains about a preprocessed input.

Oct 30 2019, 9:43 AM · Restricted Project
peterwaller-arm added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

@thakis: I found the thread at https://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20120430/057199.html

Oct 30 2019, 9:02 AM · Restricted Project
peterwaller-arm added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Thanks for chiming in.

Sorry, I had missed the RfC, but it looks like there wasn't a lot of discussion on it anyways.

Oct 30 2019, 7:28 AM · Restricted Project
peterwaller-arm added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Could we have the clang/test/Driver/flang/flang.F90 and clang/test/Driver/flang/flang.f90 files in different directories please? As macOS's FS is case-insensitive, those two files have the same path from macOS perspective which is causing a whole bunch of issues (including breaking git even with 'core.ignorecase').

Oct 30 2019, 6:51 AM · Restricted Project
peterwaller-arm committed rG6bf55804924d: [clang][driver] Add basic --driver-mode=flang support for fortran (authored by peterwaller-arm).
[clang][driver] Add basic --driver-mode=flang support for fortran
Oct 30 2019, 3:45 AM
peterwaller-arm closed D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Submitted in 6bf55804924d5a1d902925ad080b1a2b57c5c75c.

Oct 30 2019, 3:45 AM · Restricted Project
peterwaller-arm added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Revoking my previous request: I now have commit access and I intend to submit this shortly.

Oct 30 2019, 3:17 AM · Restricted Project

Oct 29 2019

peterwaller-arm added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

I'm still awaiting commit access, please can someone submit this on my behalf?

Oct 29 2019, 4:23 AM · Restricted Project

Oct 24 2019

peterwaller-arm added inline comments to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.
Oct 24 2019, 8:48 AM · Restricted Project
peterwaller-arm updated the diff for D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

I have rebased the patch for conflicts to master and all the tests are passing.

Oct 24 2019, 8:48 AM · Restricted Project

Oct 15 2019

peterwaller-arm added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Friendly ping to everybody watching. I'd like to get this in soon if possible.

Oct 15 2019, 3:58 AM · Restricted Project

Sep 25 2019

peterwaller-arm added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Hi All, I'm going on leave for two weeks, returning October 14th. I can plausibly respond to comments until 14:00 UTC tomorrow (Thu 25th Sept).

Sep 25 2019, 5:44 AM · Restricted Project

Sep 19 2019

peterwaller-arm added inline comments to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.
Sep 19 2019, 6:21 AM · Restricted Project
peterwaller-arm updated the diff for D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Thanks everyone for your comments.

Sep 19 2019, 6:21 AM · Restricted Project

Sep 18 2019

peterwaller-arm updated the diff for D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.
  • Fixed spurious comma
  • Fixed incorrect comment and changed comment wrapping.
Sep 18 2019, 8:40 AM · Restricted Project
peterwaller-arm updated the diff for D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Updated comment for IsFlangMode.

Sep 18 2019, 3:54 AM · Restricted Project
peterwaller-arm added inline comments to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.
Sep 18 2019, 3:32 AM · Restricted Project
peterwaller-arm updated the diff for D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Updated for review comments and spotted a couple of things myself.

Sep 18 2019, 3:31 AM · Restricted Project

Sep 11 2019

peterwaller-arm updated the diff for D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Fixed assertion message "Input output." => "Invalid output". The erroneous text came was copied from: https://github.com/llvm/llvm-project/blob/6b9df910d04fae62dacc22c1c84f66c0f126cde0/clang/lib/Driver/ToolChains/Clang.cpp#L3849

Sep 11 2019, 12:51 AM · Restricted Project

Sep 10 2019

peterwaller-arm updated the diff for D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

I updated this "prototype" revision into the real thing I would like to submit. Please let me know if that was the wrong thing to do and I will resubmit it.

Sep 10 2019, 6:56 AM · Restricted Project
peterwaller-arm retitled D63607: [clang][driver] Add basic --driver-mode=flang support for fortran from [DO NOT SUBMIT] [clang][driver] Prototype --driver-mode=fortran support for new flang to [clang][driver] Prototype --driver-mode=fortran support for new flang.
Sep 10 2019, 6:50 AM · Restricted Project

Aug 20 2019

peterwaller-arm added a comment to D66077: [GlobalISel] Handle multiple registers in dbg.value intrinsic.

I do not have submit permissions, please can someone submit on my behalf?

Aug 20 2019, 7:14 AM · Restricted Project

Aug 19 2019

peterwaller-arm added a comment to D66077: [GlobalISel] Handle multiple registers in dbg.value intrinsic.

Updated for code review comment.

Aug 19 2019, 2:31 AM · Restricted Project
peterwaller-arm updated the diff for D66077: [GlobalISel] Handle multiple registers in dbg.value intrinsic.

Add target triple to test.

Aug 19 2019, 2:30 AM · Restricted Project

Aug 14 2019

peterwaller-arm added a reviewer for D66077: [GlobalISel] Handle multiple registers in dbg.value intrinsic: aemerson.
Aug 14 2019, 7:51 AM · Restricted Project

Aug 12 2019

peterwaller-arm created D66077: [GlobalISel] Handle multiple registers in dbg.value intrinsic.
Aug 12 2019, 3:01 AM · Restricted Project

Jun 24 2019

peterwaller-arm updated the diff for D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Include full context.

Jun 24 2019, 2:28 AM · Restricted Project

Jun 20 2019

peterwaller-arm added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Note: In case you see this early, the email isn't yet sent to the list. I'll link it here when it is, likely tomorrow.

Jun 20 2019, 9:54 AM · Restricted Project
peterwaller-arm created D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.
Jun 20 2019, 8:59 AM · Restricted Project