Page MenuHomePhabricator

peterwaller-arm (Peter Waller)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 20 2019, 2:39 AM (83 w, 5 d)

Recent Activity

Today

peterwaller-arm requested review of D95435: [clang][aarch64][WOA64][docs] Release note for longjmp crash with /guard:cf.
Tue, Jan 26, 3:59 AM · Restricted Project

Mon, Jan 11

peterwaller-arm accepted D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.
Mon, Jan 11, 12:33 PM · Restricted Project, Restricted Project
peterwaller-arm added a comment to D94230: [AArch64][SVE] Add SVE IR pass to coalesce ptrue instrinsic calls.

I'd like to see one-liner comments on each test explaining the spirit of what is being tested.

Mon, Jan 11, 9:21 AM · Restricted Project
peterwaller-arm added inline comments to D94230: [AArch64][SVE] Add SVE IR pass to coalesce ptrue instrinsic calls.
Mon, Jan 11, 4:00 AM · Restricted Project
peterwaller-arm added inline comments to D94230: [AArch64][SVE] Add SVE IR pass to coalesce ptrue instrinsic calls.
Mon, Jan 11, 2:27 AM · Restricted Project

Thu, Jan 7

peterwaller-arm added a comment to D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.

Suggesting a few small tweaks. Otherwise LGTM when @rnk is happy.

Thu, Jan 7, 1:20 AM · Restricted Project, Restricted Project

Wed, Jan 6

peterwaller-arm committed rG3e357ecd44a6: [llvm][NFC] Disallow all warnings in TypeSize tests (authored by peterwaller-arm).
[llvm][NFC] Disallow all warnings in TypeSize tests
Wed, Jan 6, 9:17 AM
peterwaller-arm closed D94161: [llvm][NFC] Disallow all warnings in TypeSize tests.
Wed, Jan 6, 9:17 AM · Restricted Project
peterwaller-arm committed rGdfd3384feeca: [InstCombine] Update valueCoversEntireFragment to use TypeSize (authored by fpetrogalli).
[InstCombine] Update valueCoversEntireFragment to use TypeSize
Wed, Jan 6, 9:16 AM
peterwaller-arm closed D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize.
Wed, Jan 6, 9:16 AM · Restricted Project, Restricted Project
peterwaller-arm added reviewers for D94161: [llvm][NFC] Disallow all warnings in TypeSize tests: aprantl, sdesmalen.
Wed, Jan 6, 2:21 AM · Restricted Project
peterwaller-arm requested review of D94161: [llvm][NFC] Disallow all warnings in TypeSize tests.
Wed, Jan 6, 2:20 AM · Restricted Project

Tue, Jan 5

peterwaller-arm added inline comments to D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize.
Tue, Jan 5, 8:39 AM · Restricted Project, Restricted Project
peterwaller-arm updated the diff for D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize.

Update for review comment.

Tue, Jan 5, 8:37 AM · Restricted Project, Restricted Project

Mon, Jan 4

peterwaller-arm added inline comments to D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize.
Mon, Jan 4, 2:25 AM · Restricted Project, Restricted Project

Dec 15 2020

peterwaller-arm added reviewers for D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize: huihuiz, aprantl.
Dec 15 2020, 9:01 AM · Restricted Project, Restricted Project

Dec 14 2020

peterwaller-arm updated the diff for D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize.

Attempting to update commit message with arc diff --verbatim.

Dec 14 2020, 8:54 AM · Restricted Project, Restricted Project
peterwaller-arm updated the diff for D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize.

I've taken over the differential.

Dec 14 2020, 8:49 AM · Restricted Project, Restricted Project
peterwaller-arm commandeered D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize.
Dec 14 2020, 8:48 AM · Restricted Project, Restricted Project

Dec 10 2020

peterwaller-arm committed rG2315e9874c92: [AArch64][Driver][SVE] Push missing SVE feature error from driver to frontend (authored by peterwaller-arm).
[AArch64][Driver][SVE] Push missing SVE feature error from driver to frontend
Dec 10 2020, 4:43 AM
peterwaller-arm closed D92487: [AArch64][Driver][SVE] Push missing SVE feature error from driver to frontend.
Dec 10 2020, 4:43 AM · Restricted Project

Dec 8 2020

peterwaller-arm updated the diff for D92487: [AArch64][Driver][SVE] Push missing SVE feature error from driver to frontend.

Update patch for clang-format

Dec 8 2020, 7:49 AM · Restricted Project

Dec 2 2020

peterwaller-arm updated the summary of D92487: [AArch64][Driver][SVE] Push missing SVE feature error from driver to frontend.
Dec 2 2020, 9:16 AM · Restricted Project
peterwaller-arm updated the diff for D92487: [AArch64][Driver][SVE] Push missing SVE feature error from driver to frontend.

Tweak message to address review comment.

Dec 2 2020, 9:11 AM · Restricted Project
peterwaller-arm added reviewers for D92487: [AArch64][Driver][SVE] Push missing SVE feature error from driver to frontend: c-rhodes, paulwalker-arm, sdesmalen.
Dec 2 2020, 8:03 AM · Restricted Project
peterwaller-arm requested review of D92487: [AArch64][Driver][SVE] Push missing SVE feature error from driver to frontend.
Dec 2 2020, 7:58 AM · Restricted Project
peterwaller-arm accepted D92392: [DAGCombine] Fix TypeSize warning in DAGCombine::visitLIFETIME_END.

LGTM.

Dec 2 2020, 5:35 AM · Restricted Project

Nov 25 2020

peterwaller-arm accepted D92020: [AllocaInst] Update `getAllocationSizeInBits` to return `TypeSize`..

Tried to break it, wasn't able to. Looks straightforward.

Nov 25 2020, 7:04 AM · Restricted Project

Nov 16 2020

peterwaller-arm added inline comments to D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors.
Nov 16 2020, 2:30 AM · Restricted Project
peterwaller-arm added inline comments to D91362: [SelectionDAG] Add llvm.vector.{extract,insert} intrinsics.
Nov 16 2020, 2:30 AM · Restricted Project

Nov 9 2020

peterwaller-arm added a comment to D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`..

Suggestion: Where referencing sections you could include the title "3.7.3.3. Behavior specific to SVE vectors" instead of "3.7.3.3" for example. I think this makes it easier to spot misreferences and gives future souls a better chance to understand the context without indirection.

Nov 9 2020, 4:27 AM · Restricted Project
peterwaller-arm added inline comments to D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`..
Nov 9 2020, 4:18 AM · Restricted Project
peterwaller-arm added a comment to D91067: [AArch64][SVE] Support implicit lax vector conversions for SVE types.

fixed_float64_t appears in the commit message but also is unused.

Nov 9 2020, 4:17 AM · Restricted Project

Nov 3 2020

peterwaller-arm added a comment to D90606: [llvm][AArch64] Allow TB(N)Z to drop signext for sign bit tests..

Nit: I think the commit message could be improved such that the benefit is clear? Something referencing the fact you're modifying the behaviour of TBZ.

Nov 3 2020, 5:10 AM · Restricted Project

Oct 28 2020

peterwaller-arm added inline comments to D90162: [llvm][AArch64] Prevent spurious zero extension..
Oct 28 2020, 9:22 AM · Restricted Project
peterwaller-arm added inline comments to D90162: [llvm][AArch64] Prevent spurious zero extension..
Oct 28 2020, 7:34 AM · Restricted Project

Oct 26 2020

peterwaller-arm committed rG5b742a0c106f: [SVE][CodeGen][DAGCombiner] Fix TypeSize warning in redundant store elimination (authored by peterwaller-arm).
[SVE][CodeGen][DAGCombiner] Fix TypeSize warning in redundant store elimination
Oct 26 2020, 9:38 AM
peterwaller-arm added a reverting change for rG4604441386dc: [SVE][CodeGen][DAGCombiner] Fix TypeSize warning in redundant store elimination: rG6536d6040f5c: Revert "[SVE][CodeGen][DAGCombiner] Fix TypeSize warning in redundant store….
Oct 26 2020, 9:38 AM
peterwaller-arm committed rG6536d6040f5c: Revert "[SVE][CodeGen][DAGCombiner] Fix TypeSize warning in redundant store… (authored by peterwaller-arm).
Revert "[SVE][CodeGen][DAGCombiner] Fix TypeSize warning in redundant store…
Oct 26 2020, 9:38 AM
peterwaller-arm closed D89701: [SVE][CodeGen][DAGCombiner] Fix TypeSize warning in redundant store elimination.
Oct 26 2020, 9:38 AM · Restricted Project

Oct 20 2020

peterwaller-arm retitled D89701: [SVE][CodeGen][DAGCombiner] Fix TypeSize warning in redundant store elimination from Fix TypeSize warning in redundant store elimination to [SVE][CodeGen][DAGCombiner] Fix TypeSize warning in redundant store elimination.
Oct 20 2020, 10:20 AM · Restricted Project
peterwaller-arm updated the diff for D89701: [SVE][CodeGen][DAGCombiner] Fix TypeSize warning in redundant store elimination.

Put back subject [tags] stripped by git am.

Oct 20 2020, 10:19 AM · Restricted Project
peterwaller-arm updated the diff for D89701: [SVE][CodeGen][DAGCombiner] Fix TypeSize warning in redundant store elimination.

Address review comments:

  • Update llc test using utils/update_llc_test_checks.py.
  • Pass vector as operand to function to shrink test.
Oct 20 2020, 10:16 AM · Restricted Project
peterwaller-arm added inline comments to D89798: [SVE][AArch64] Fix TypeSize warning in loop vectorization legality.
Oct 20 2020, 10:14 AM · Restricted Project
peterwaller-arm added inline comments to D89798: [SVE][AArch64] Fix TypeSize warning in loop vectorization legality.
Oct 20 2020, 10:11 AM · Restricted Project
peterwaller-arm added inline comments to D89798: [SVE][AArch64] Fix TypeSize warning in loop vectorization legality.
Oct 20 2020, 8:46 AM · Restricted Project

Oct 19 2020

peterwaller-arm updated the diff for D89701: [SVE][CodeGen][DAGCombiner] Fix TypeSize warning in redundant store elimination.

Address review comments.

Oct 19 2020, 9:49 AM · Restricted Project
peterwaller-arm added a comment to D89701: [SVE][CodeGen][DAGCombiner] Fix TypeSize warning in redundant store elimination.

Is it perhaps worth renaming the test to have sve in the name, i.e. sve-redundant-stores.ll? We've been following this convention for other tests.

Oct 19 2020, 8:50 AM · Restricted Project
peterwaller-arm requested review of D89701: [SVE][CodeGen][DAGCombiner] Fix TypeSize warning in redundant store elimination.
Oct 19 2020, 7:30 AM · Restricted Project

Apr 9 2020

GitHub <noreply@github.com> committed rG42cc44fbc8dc: [flang] Add script to flatten git history for llvm monorepo submission (flang… (authored by peterwaller-arm).
[flang] Add script to flatten git history for llvm monorepo submission (flang…
Apr 9 2020, 12:57 PM
peterwaller-arm committed rGc9944df916e4: [flang] Revert "Remove needless braces" (authored by peterwaller-arm).
[flang] Revert "Remove needless braces"
Apr 9 2020, 11:18 AM

Oct 31 2019

peterwaller-arm accepted D69636: Make flang driver stuff work on macOS.

LGTM, thanks!

Oct 31 2019, 2:21 AM · Restricted Project

Oct 30 2019

peterwaller-arm added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

@thakis: I've marked the test unsupported in c75cd3c7f0f. Hopefully that makes your builder happy! I'll figure out what is going on and fix it.

Oct 30 2019, 10:07 AM · Restricted Project
peterwaller-arm committed rGc75cd3c7f0f9: [clang][driver][flang] Mark test as unsupported on darwin (authored by peterwaller-arm).
[clang][driver][flang] Mark test as unsupported on darwin
Oct 30 2019, 10:03 AM
peterwaller-arm added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

I've thought about it for a moment and I'm currently at a loss to quickly explain why this would only fail on darwin. In my patch, the change to LookupTypeForExtension should prevent clang from reaching this state where it complains about a preprocessed input.

Oct 30 2019, 9:43 AM · Restricted Project
peterwaller-arm added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

@thakis: I found the thread at https://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20120430/057199.html

Oct 30 2019, 9:02 AM · Restricted Project
peterwaller-arm added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Thanks for chiming in.

Sorry, I had missed the RfC, but it looks like there wasn't a lot of discussion on it anyways.

Oct 30 2019, 7:28 AM · Restricted Project
peterwaller-arm added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Could we have the clang/test/Driver/flang/flang.F90 and clang/test/Driver/flang/flang.f90 files in different directories please? As macOS's FS is case-insensitive, those two files have the same path from macOS perspective which is causing a whole bunch of issues (including breaking git even with 'core.ignorecase').

Oct 30 2019, 6:51 AM · Restricted Project
peterwaller-arm committed rG6bf55804924d: [clang][driver] Add basic --driver-mode=flang support for fortran (authored by peterwaller-arm).
[clang][driver] Add basic --driver-mode=flang support for fortran
Oct 30 2019, 3:45 AM
peterwaller-arm closed D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Submitted in 6bf55804924d5a1d902925ad080b1a2b57c5c75c.

Oct 30 2019, 3:45 AM · Restricted Project
peterwaller-arm added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Revoking my previous request: I now have commit access and I intend to submit this shortly.

Oct 30 2019, 3:17 AM · Restricted Project

Oct 29 2019

peterwaller-arm added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

I'm still awaiting commit access, please can someone submit this on my behalf?

Oct 29 2019, 4:23 AM · Restricted Project

Oct 24 2019

peterwaller-arm added inline comments to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.
Oct 24 2019, 8:48 AM · Restricted Project
peterwaller-arm updated the diff for D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

I have rebased the patch for conflicts to master and all the tests are passing.

Oct 24 2019, 8:48 AM · Restricted Project

Oct 15 2019

peterwaller-arm added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Friendly ping to everybody watching. I'd like to get this in soon if possible.

Oct 15 2019, 3:58 AM · Restricted Project

Sep 25 2019

peterwaller-arm added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Hi All, I'm going on leave for two weeks, returning October 14th. I can plausibly respond to comments until 14:00 UTC tomorrow (Thu 25th Sept).

Sep 25 2019, 5:44 AM · Restricted Project

Sep 19 2019

peterwaller-arm added inline comments to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.
Sep 19 2019, 6:21 AM · Restricted Project
peterwaller-arm updated the diff for D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Thanks everyone for your comments.

Sep 19 2019, 6:21 AM · Restricted Project

Sep 18 2019

peterwaller-arm updated the diff for D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.
  • Fixed spurious comma
  • Fixed incorrect comment and changed comment wrapping.
Sep 18 2019, 8:40 AM · Restricted Project
peterwaller-arm updated the diff for D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Updated comment for IsFlangMode.

Sep 18 2019, 3:54 AM · Restricted Project
peterwaller-arm added inline comments to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.
Sep 18 2019, 3:32 AM · Restricted Project
peterwaller-arm updated the diff for D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Updated for review comments and spotted a couple of things myself.

Sep 18 2019, 3:31 AM · Restricted Project

Sep 11 2019

peterwaller-arm updated the diff for D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Fixed assertion message "Input output." => "Invalid output". The erroneous text came was copied from: https://github.com/llvm/llvm-project/blob/6b9df910d04fae62dacc22c1c84f66c0f126cde0/clang/lib/Driver/ToolChains/Clang.cpp#L3849

Sep 11 2019, 12:51 AM · Restricted Project

Sep 10 2019

peterwaller-arm updated the diff for D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

I updated this "prototype" revision into the real thing I would like to submit. Please let me know if that was the wrong thing to do and I will resubmit it.

Sep 10 2019, 6:56 AM · Restricted Project
peterwaller-arm retitled D63607: [clang][driver] Add basic --driver-mode=flang support for fortran from [DO NOT SUBMIT] [clang][driver] Prototype --driver-mode=fortran support for new flang to [clang][driver] Prototype --driver-mode=fortran support for new flang.
Sep 10 2019, 6:50 AM · Restricted Project

Aug 20 2019

peterwaller-arm added a comment to D66077: [GlobalISel] Handle multiple registers in dbg.value intrinsic.

I do not have submit permissions, please can someone submit on my behalf?

Aug 20 2019, 7:14 AM · Restricted Project

Aug 19 2019

peterwaller-arm added a comment to D66077: [GlobalISel] Handle multiple registers in dbg.value intrinsic.

Updated for code review comment.

Aug 19 2019, 2:31 AM · Restricted Project
peterwaller-arm updated the diff for D66077: [GlobalISel] Handle multiple registers in dbg.value intrinsic.

Add target triple to test.

Aug 19 2019, 2:30 AM · Restricted Project

Aug 14 2019

peterwaller-arm added a reviewer for D66077: [GlobalISel] Handle multiple registers in dbg.value intrinsic: aemerson.
Aug 14 2019, 7:51 AM · Restricted Project

Aug 12 2019

peterwaller-arm created D66077: [GlobalISel] Handle multiple registers in dbg.value intrinsic.
Aug 12 2019, 3:01 AM · Restricted Project

Jun 24 2019

peterwaller-arm updated the diff for D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Include full context.

Jun 24 2019, 2:28 AM · Restricted Project

Jun 20 2019

peterwaller-arm added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Note: In case you see this early, the email isn't yet sent to the list. I'll link it here when it is, likely tomorrow.

Jun 20 2019, 9:54 AM · Restricted Project
peterwaller-arm created D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.
Jun 20 2019, 8:59 AM · Restricted Project