Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

peterwaller-arm (Peter Waller)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 20 2019, 2:39 AM (232 w, 3 d)

Recent Activity

Jul 17 2023

peterwaller-arm resigned from D155459: [AArch64] Change the cost of vector insert/extract to 2.

I'm not currently the right person to review this, resigning.

Jul 17 2023, 7:34 AM · Restricted Project, Restricted Project

May 19 2023

peterwaller-arm added a comment to D146918: [CMake] Don't set absolute paths as install runpaths on ELF platforms in llvm_setup_rpath().

First off, thanks for the discourse!

May 19 2023, 1:31 AM · Restricted Project, Restricted Project, Restricted Project

May 18 2023

peterwaller-arm added a comment to D146918: [CMake] Don't set absolute paths as install runpaths on ELF platforms in llvm_setup_rpath().

Sure, simply run the readelf commands from this commit message or something similar on the clang toolchain you built, both in your build and install directories, and perhaps with this commit reverted too.

May 18 2023, 11:48 AM · Restricted Project, Restricted Project, Restricted Project
peterwaller-arm added a comment to D146918: [CMake] Don't set absolute paths as install runpaths on ELF platforms in llvm_setup_rpath().

Looks like my previous message was truncated. I think it is 'not incorrect' for the rpath to point to LLVM_LIBRARY_DIR, which is the install path at least for the nixpkgs llvm install. In this case, the prefix clang is installed to differs from the one LLVM is installed to. If the rpath isn't set for clang there, it can't find libLLVM.

May 18 2023, 9:21 AM · Restricted Project, Restricted Project, Restricted Project
peterwaller-arm added a comment to D146918: [CMake] Don't set absolute paths as install runpaths on ELF platforms in llvm_setup_rpath().

If any LLVM subprojects are built separately, the LLVM build directory LLVM_LIBRARY_DIR is added to both the build and install runpaths in llvm_setup_rpath(), which is incorrect when installed.

May 18 2023, 4:58 AM · Restricted Project, Restricted Project, Restricted Project

Apr 17 2023

peterwaller-arm added a comment to D142895: [VPlan] Move mayHaveSideeffects for FORs check to VPlan..

Doesn't build for me, tried against main (8bf7f86d7966) and your latest commit to vplan (668045eb7762).

Apr 17 2023, 2:25 AM · Restricted Project, Restricted Project

Mar 7 2023

peterwaller-arm accepted D145497: [AArch64] Allocate emergency spillslot when using fixed-length SVE..

Makes sense to me, one minor suggestion. I note that this introduces a few loads/stores to the stack for fixed length vectorization, but having it work correctly is the priority, those may be possible to remove later.

Mar 7 2023, 7:21 AM · Restricted Project, Restricted Project

Feb 27 2023

peterwaller-arm added a comment to D142895: [VPlan] Move mayHaveSideeffects for FORs check to VPlan..

Are there other parent revisions? The base isn't a valid commit and the patch doesn't apply to main nor commits from the end of January, for example CompareByComesBefore isn't in the patch context but is on main and is old.

Feb 27 2023, 6:58 AM · Restricted Project, Restricted Project

Jan 25 2023

peterwaller-arm accepted D142065: [SVE] Fix incorrect lowering of predicate permute builtins..
Jan 25 2023, 6:30 AM · Restricted Project, Restricted Project, Restricted Project

Jan 24 2023

peterwaller-arm added inline comments to D142065: [SVE] Fix incorrect lowering of predicate permute builtins..
Jan 24 2023, 7:41 AM · Restricted Project, Restricted Project, Restricted Project
peterwaller-arm accepted D142122: [SVE][InstrFormats] Explcitly set hasSideEffects for all SVE instructions..

I've been down the list of MCA output changes and agree those look good, and your reasoning seems good to me. Accepting as-is, since we think represents an improvement.

Jan 24 2023, 2:45 AM · Restricted Project, Restricted Project

Jan 23 2023

peterwaller-arm accepted D142303: [SVE] Fix invalid INSERT_SUBVECTOR creation when lowering fixed length fp-int conversions..
Jan 23 2023, 4:03 AM · Restricted Project, Restricted Project

Jan 18 2023

peterwaller-arm accepted D141846: [AArch64] Allow poison elements of fixed-vectors to be duplicated as a widened element.
Jan 18 2023, 7:53 AM · Restricted Project, Restricted Project
peterwaller-arm accepted D141936: [AArch64][SVE2p1] Add SVE2.1 while (predicate-pair) intrinsics.

LGTM!

Jan 18 2023, 7:18 AM · Restricted Project, Restricted Project

Dec 21 2022

peterwaller-arm abandoned D138581: [AArch64][SVE] Add DAG combine for load + dup_merge_passthru -> replicating load.

An alternate route to implementation landed via D139637, D139850.

Dec 21 2022, 6:25 AM · Restricted Project, Restricted Project
peterwaller-arm committed rG6d877e6717ee: [AArch64][SVE][CodeGen] Prefer ld1r* over indexed-load when consumed by a splat (authored by peterwaller-arm).
[AArch64][SVE][CodeGen] Prefer ld1r* over indexed-load when consumed by a splat
Dec 21 2022, 6:24 AM · Restricted Project, Restricted Project
peterwaller-arm closed D139850: [AArch64][SVE][CodeGen] Prefer ld1r* over indexed-load when consumed by a splat.
Dec 21 2022, 6:24 AM · Restricted Project, Restricted Project
peterwaller-arm abandoned D137159: [LoopVectorize] Introduce CanSinkMemoryInstrs to isFixedOrderRecurrence.

Wrong action selected... :)

Dec 21 2022, 12:57 AM · Restricted Project, Restricted Project
peterwaller-arm accepted D137159: [LoopVectorize] Introduce CanSinkMemoryInstrs to isFixedOrderRecurrence.

Thanks for the input Florian!

Dec 21 2022, 12:56 AM · Restricted Project, Restricted Project
peterwaller-arm abandoned D137158: [NFCI][LoopVectorize] Add MemoryDependenceAnalysis infrastructure.

As @fhahn mentioned in D137159, the MemoryDependenceAnalysis infrastructure is considered deprecated, so this is not viable.

Dec 21 2022, 12:56 AM · Restricted Project, Restricted Project

Dec 20 2022

peterwaller-arm added inline comments to D139850: [AArch64][SVE][CodeGen] Prefer ld1r* over indexed-load when consumed by a splat.
Dec 20 2022, 7:35 AM · Restricted Project, Restricted Project
peterwaller-arm updated the diff for D139850: [AArch64][SVE][CodeGen] Prefer ld1r* over indexed-load when consumed by a splat.
  • Fix test naming.
  • Also cover the zero passthru case.
Dec 20 2022, 7:34 AM · Restricted Project, Restricted Project
peterwaller-arm updated the diff for D139850: [AArch64][SVE][CodeGen] Prefer ld1r* over indexed-load when consumed by a splat.

Address review comments:

  • Remove superflous braces.
  • Prefer indexed operations in the presence of a non-undef passthrough to a dup.
Dec 20 2022, 7:28 AM · Restricted Project, Restricted Project

Dec 14 2022

peterwaller-arm abandoned D125956: [NOT YET FOR REVIEW][AArch64][LV] Implement AArch64TTIImpl::getRegisterClassForType.
Dec 14 2022, 6:28 AM · Restricted Project, Restricted Project
peterwaller-arm committed rG15406d2cd692: [AArch64][SVE][ISel] Combine dup of load to replicating load (authored by peterwaller-arm).
[AArch64][SVE][ISel] Combine dup of load to replicating load
Dec 14 2022, 2:38 AM · Restricted Project, Restricted Project
peterwaller-arm closed D139637: [AArch64][SVE][ISel] Combine dup of load to replicating load.
Dec 14 2022, 2:38 AM · Restricted Project, Restricted Project

Dec 13 2022

peterwaller-arm added a reviewer for D138203: [AArch64][InstCombine] Simplify repeated complex patterns in dupqlane: sdesmalen.
Dec 13 2022, 1:26 AM · Restricted Project, Restricted Project
peterwaller-arm accepted D138203: [AArch64][InstCombine] Simplify repeated complex patterns in dupqlane.

LGTM, but please address the comment about poison and allow time for other reviewers to chime in.

Dec 13 2022, 1:26 AM · Restricted Project, Restricted Project

Dec 12 2022

peterwaller-arm updated the diff for D139850: [AArch64][SVE][CodeGen] Prefer ld1r* over indexed-load when consumed by a splat.
  • Update a test name (an old one crept in)
Dec 12 2022, 8:34 AM · Restricted Project, Restricted Project
peterwaller-arm requested review of D139850: [AArch64][SVE][CodeGen] Prefer ld1r* over indexed-load when consumed by a splat.
Dec 12 2022, 8:31 AM · Restricted Project, Restricted Project
peterwaller-arm updated the diff for D139637: [AArch64][SVE][ISel] Combine dup of load to replicating load.
  • Remove 'q' accidentally copied into the test names.
Dec 12 2022, 7:34 AM · Restricted Project, Restricted Project
peterwaller-arm committed rG8812b6eed7b2: [AArch64][SVE][Fixed length] Fix div miscompile (authored by peterwaller-arm).
[AArch64][SVE][Fixed length] Fix div miscompile
Dec 12 2022, 3:33 AM · Restricted Project, Restricted Project
peterwaller-arm closed D139618: [AArch64][SVE][Fixed length] Fix div miscompile.
Dec 12 2022, 3:33 AM · Restricted Project, Restricted Project
peterwaller-arm updated the diff for D139637: [AArch64][SVE][ISel] Combine dup of load to replicating load.
  • Test zext/sext.
  • Test unpacked forms (no negative tests, since dup with unpacked types is not specifically supported currently as there is currently no known way to get a DUP_MERGE_PASSTHRU from C/C++ code).
  • Drop immediate tests since those are covered.
Dec 12 2022, 3:25 AM · Restricted Project, Restricted Project

Dec 8 2022

peterwaller-arm added inline comments to D139637: [AArch64][SVE][ISel] Combine dup of load to replicating load.
Dec 8 2022, 11:05 AM · Restricted Project, Restricted Project
peterwaller-arm updated the diff for D139637: [AArch64][SVE][ISel] Combine dup of load to replicating load.
Dec 8 2022, 11:04 AM · Restricted Project, Restricted Project
peterwaller-arm added reviewers for D139637: [AArch64][SVE][ISel] Combine dup of load to replicating load: paulwalker-arm, sdesmalen.
Dec 8 2022, 8:57 AM · Restricted Project, Restricted Project
peterwaller-arm updated the diff for D139618: [AArch64][SVE][Fixed length] Fix div miscompile.
  • Address review comments: Move comment down and rename BisectExtendVector => HalveAndExtendVector.
Dec 8 2022, 8:45 AM · Restricted Project, Restricted Project
peterwaller-arm requested review of D139637: [AArch64][SVE][ISel] Combine dup of load to replicating load.
Dec 8 2022, 8:36 AM · Restricted Project, Restricted Project
peterwaller-arm added inline comments to D139618: [AArch64][SVE][Fixed length] Fix div miscompile.
Dec 8 2022, 6:50 AM · Restricted Project, Restricted Project
peterwaller-arm requested review of D139618: [AArch64][SVE][Fixed length] Fix div miscompile.
Dec 8 2022, 3:34 AM · Restricted Project, Restricted Project

Dec 7 2022

peterwaller-arm planned changes to D138581: [AArch64][SVE] Add DAG combine for load + dup_merge_passthru -> replicating load.
Dec 7 2022, 3:36 AM · Restricted Project, Restricted Project
peterwaller-arm commandeered D138581: [AArch64][SVE] Add DAG combine for load + dup_merge_passthru -> replicating load.

Thanks Bradley -- I'll continue this one in the near future though your input is welcomed.

Dec 7 2022, 3:36 AM · Restricted Project, Restricted Project

Nov 28 2022

peterwaller-arm accepted D138581: [AArch64][SVE] Add DAG combine for load + dup_merge_passthru -> replicating load.

LGTM with minor comments.

Nov 28 2022, 4:05 AM · Restricted Project, Restricted Project

Nov 23 2022

peterwaller-arm added reviewers for D138575: [AArch64] Add hasSVEorSME() helper and fix some incorrect checks: sdesmalen, paulwalker-arm.
Nov 23 2022, 7:32 AM · Restricted Project, Restricted Project
peterwaller-arm accepted D138575: [AArch64] Add hasSVEorSME() helper and fix some incorrect checks.
Nov 23 2022, 7:31 AM · Restricted Project, Restricted Project

Nov 21 2022

peterwaller-arm committed rGb2505bfbaef4: [AArch64][SVE] Precommit tests for VSCALE/SVE CNTx demanded bits (authored by benmxwl-arm).
[AArch64][SVE] Precommit tests for VSCALE/SVE CNTx demanded bits
Nov 21 2022, 5:45 AM · Restricted Project, Restricted Project

Nov 14 2022

peterwaller-arm added inline comments to D137844: [DAG] Allow folding AND of anyext masked_load with >1 user to zext version.
Nov 14 2022, 7:41 AM · Restricted Project, Restricted Project
peterwaller-arm accepted D137433: [AArch64][CodeGen] Remove redundant vector negations before concat.

LGTM, Thanks for trying the path of making it generic and thanks for the input from the other reviewers!

Nov 14 2022, 1:52 AM · Restricted Project, Restricted Project

Nov 10 2022

peterwaller-arm accepted D133116: [AArch64][SVE] Optimise repeated floating-point complex patterns to splat.

One suggestion inline.

Nov 10 2022, 8:30 AM · Restricted Project, Restricted Project
peterwaller-arm requested changes to D133116: [AArch64][SVE] Optimise repeated floating-point complex patterns to splat.
Nov 10 2022, 4:08 AM · Restricted Project, Restricted Project

Nov 8 2022

peterwaller-arm added inline comments to D137547: [AArch64][SVE] Use PTRUE instruction for get_active_lane_mask intrinsic if the range is appropriate for predicator constant.
Nov 8 2022, 4:49 AM · Restricted Project, Restricted Project

Nov 7 2022

peterwaller-arm added inline comments to D137547: [AArch64][SVE] Use PTRUE instruction for get_active_lane_mask intrinsic if the range is appropriate for predicator constant.
Nov 7 2022, 8:59 AM · Restricted Project, Restricted Project
peterwaller-arm added inline comments to D137547: [AArch64][SVE] Use PTRUE instruction for get_active_lane_mask intrinsic if the range is appropriate for predicator constant.
Nov 7 2022, 8:34 AM · Restricted Project, Restricted Project
peterwaller-arm accepted D137433: [AArch64][CodeGen] Remove redundant vector negations before concat.

LGTM, but adding other reviewers for visibility. The predictable ask is to make it a target-agnostic combine: reviewers, thoughts?

Nov 7 2022, 5:46 AM · Restricted Project, Restricted Project
peterwaller-arm added reviewers for D137433: [AArch64][CodeGen] Remove redundant vector negations before concat: efriedma, spatel, RKSimon.
Nov 7 2022, 5:43 AM · Restricted Project, Restricted Project

Nov 3 2022

peterwaller-arm added inline comments to D135876: [InstCombine] Remove redundant splats in InstCombineVectorOps.
Nov 3 2022, 3:54 AM · Restricted Project, Restricted Project
peterwaller-arm added a reverting change for rG957eed0b1af2: [InstCombine] Remove redundant splats in InstCombineVectorOps: rGe1790c8c290d: Revert "[InstCombine] Remove redundant splats in InstCombineVectorOps".
Nov 3 2022, 1:01 AM · Restricted Project, Restricted Project
peterwaller-arm committed rGe1790c8c290d: Revert "[InstCombine] Remove redundant splats in InstCombineVectorOps" (authored by peterwaller-arm).
Revert "[InstCombine] Remove redundant splats in InstCombineVectorOps"
Nov 3 2022, 1:01 AM · Restricted Project, Restricted Project
peterwaller-arm committed rG8cb9e3c3ce1e: [AArch64] Install arm_neon_sve_bridge.h (authored by peterwaller-arm).
[AArch64] Install arm_neon_sve_bridge.h
Nov 3 2022, 1:01 AM · Restricted Project, Restricted Project
peterwaller-arm added a reverting change for D135876: [InstCombine] Remove redundant splats in InstCombineVectorOps: rGe1790c8c290d: Revert "[InstCombine] Remove redundant splats in InstCombineVectorOps".
Nov 3 2022, 1:01 AM · Restricted Project, Restricted Project
peterwaller-arm added a comment to D135876: [InstCombine] Remove redundant splats in InstCombineVectorOps.

Hi @dyung, thanks for the report and reproducer. Matt's away today so I've applied a revert in e1790c8c290d773cd5b1fc79f80b7a23dceb7589.

Nov 3 2022, 1:01 AM · Restricted Project, Restricted Project
peterwaller-arm closed D137239: [AArch64] Install arm_neon_sve_bridge.h.
Nov 3 2022, 1:01 AM · Restricted Project, Restricted Project

Nov 2 2022

peterwaller-arm added inline comments to D133955: [AArch64][CostModel] Add costs for fixed operations when using fixed vectors over SVE.
Nov 2 2022, 6:18 AM · Restricted Project, Restricted Project
peterwaller-arm added inline comments to D133955: [AArch64][CostModel] Add costs for fixed operations when using fixed vectors over SVE.
Nov 2 2022, 6:06 AM · Restricted Project, Restricted Project
peterwaller-arm added a comment to D137159: [LoopVectorize] Introduce CanSinkMemoryInstrs to isFixedOrderRecurrence.

This is my first gambit, and I'm relatively new to making changes to LoopVectorize. Please don't hold back if this is the wrong approach, I'm happy to put legwork in to finding the right route to making this work.

Nov 2 2022, 3:37 AM · Restricted Project, Restricted Project
peterwaller-arm added reviewers for D137159: [LoopVectorize] Introduce CanSinkMemoryInstrs to isFixedOrderRecurrence: Ayal, fhahn, spatel.
Nov 2 2022, 3:30 AM · Restricted Project, Restricted Project
peterwaller-arm requested review of D137239: [AArch64] Install arm_neon_sve_bridge.h.
Nov 2 2022, 3:23 AM · Restricted Project, Restricted Project

Nov 1 2022

peterwaller-arm added inline comments to D133955: [AArch64][CostModel] Add costs for fixed operations when using fixed vectors over SVE.
Nov 1 2022, 9:44 AM · Restricted Project, Restricted Project
peterwaller-arm accepted D136438: [AArch64][SVE] Extend PTEST_ANY(X=OP(PG,...), X) -> PTEST_ANY(PG, X)) instcombine.

LGTM, with one minor nit.

Nov 1 2022, 9:05 AM · Restricted Project, Restricted Project
peterwaller-arm updated the summary of D137159: [LoopVectorize] Introduce CanSinkMemoryInstrs to isFixedOrderRecurrence.
Nov 1 2022, 6:39 AM · Restricted Project, Restricted Project
peterwaller-arm updated subscribers of D137159: [LoopVectorize] Introduce CanSinkMemoryInstrs to isFixedOrderRecurrence.
Nov 1 2022, 6:38 AM · Restricted Project, Restricted Project
peterwaller-arm requested review of D137159: [LoopVectorize] Introduce CanSinkMemoryInstrs to isFixedOrderRecurrence.
Nov 1 2022, 6:33 AM · Restricted Project, Restricted Project
peterwaller-arm requested review of D137158: [NFCI][LoopVectorize] Add MemoryDependenceAnalysis infrastructure.
Nov 1 2022, 6:33 AM · Restricted Project, Restricted Project

Oct 24 2022

peterwaller-arm accepted D136083: [AArch64][SVE] Use more flag-setting instructions.

LGTM, one nit.

Oct 24 2022, 6:46 AM · Restricted Project, Restricted Project
peterwaller-arm accepted D136161: [AArch64][SVE] NFC: extend tests for flag-setting predicate instructions.
Oct 24 2022, 6:33 AM · Restricted Project, Restricted Project
peterwaller-arm accepted D136517: [InstCombine] Explicitly check for scalable TypeSize..

LGTM. (With the fix) I've tested this produces the expected output.

Oct 24 2022, 4:08 AM · Restricted Project, Restricted Project

Oct 18 2022

peterwaller-arm accepted D135656: [IR] Add nocapture to pointer parameters of masked stores/loads.

Looks good to me, with one minor suggestion.

Oct 18 2022, 5:00 AM · Restricted Project, Restricted Project, Restricted Project

Oct 11 2022

peterwaller-arm added a comment to D135656: [IR] Add nocapture to pointer parameters of masked stores/loads.

(Full disclosure: Ben is a new colleague of mine)

Oct 11 2022, 3:36 AM · Restricted Project, Restricted Project, Restricted Project

Sep 22 2022

peterwaller-arm accepted D133484: [AArch64][SVE] Fix AArch64_SVE_VectorCall calling convention.
Sep 22 2022, 2:06 AM · Restricted Project, Restricted Project

Sep 8 2022

peterwaller-arm added inline comments to D133484: [AArch64][SVE] Fix AArch64_SVE_VectorCall calling convention.
Sep 8 2022, 5:48 AM · Restricted Project, Restricted Project

Aug 15 2022

peterwaller-arm committed rG6e85db729300: [DAGCombine] Combine signext_inreg of extract-extend (authored by peterwaller-arm).
[DAGCombine] Combine signext_inreg of extract-extend
Aug 15 2022, 4:09 AM · Restricted Project, Restricted Project
peterwaller-arm closed D131503: [DAGCombine] Combine signext_inreg of extract-extend.
Aug 15 2022, 4:09 AM · Restricted Project, Restricted Project

Aug 11 2022

peterwaller-arm added a comment to D131503: [DAGCombine] Combine signext_inreg of extract-extend.

I will submit first thing next week unless there are further comments.

Aug 11 2022, 7:43 AM · Restricted Project, Restricted Project
peterwaller-arm updated the diff for D131503: [DAGCombine] Combine signext_inreg of extract-extend.
Aug 11 2022, 7:42 AM · Restricted Project, Restricted Project
peterwaller-arm committed rG898699831b54: [DAGCombine] Check zext legality in zext-extract-extend combine (authored by peterwaller-arm).
[DAGCombine] Check zext legality in zext-extract-extend combine
Aug 11 2022, 7:31 AM · Restricted Project, Restricted Project
peterwaller-arm updated the diff for D131503: [DAGCombine] Combine signext_inreg of extract-extend.
  • Fix copy-paste error for the legality check for the ZERO_EXTEND case.
Aug 11 2022, 5:43 AM · Restricted Project, Restricted Project
peterwaller-arm updated the diff for D131503: [DAGCombine] Combine signext_inreg of extract-extend.

Ihanks @RKSimon. The tests are unaffected. I've opted to follow your suggestion.

Aug 11 2022, 5:40 AM · Restricted Project, Restricted Project

Aug 10 2022

peterwaller-arm accepted D131573: [clang][AArch64][SVE] Change SVE_VECTOR_OPERATORS macro for VLA vectors.
Aug 10 2022, 8:16 AM · Restricted Project, Restricted Project
peterwaller-arm requested changes to D131573: [clang][AArch64][SVE] Change SVE_VECTOR_OPERATORS macro for VLA vectors.
Aug 10 2022, 8:13 AM · Restricted Project, Restricted Project
peterwaller-arm accepted D131573: [clang][AArch64][SVE] Change SVE_VECTOR_OPERATORS macro for VLA vectors.
Aug 10 2022, 8:12 AM · Restricted Project, Restricted Project
peterwaller-arm added inline comments to D131503: [DAGCombine] Combine signext_inreg of extract-extend.
Aug 10 2022, 4:57 AM · Restricted Project, Restricted Project

Aug 9 2022

peterwaller-arm updated the diff for D131503: [DAGCombine] Combine signext_inreg of extract-extend.

Thanks for the review comments, Simon!

Aug 9 2022, 9:33 AM · Restricted Project, Restricted Project
peterwaller-arm abandoned D130700: [AArch64][DAGCombine] Add pushSignExtendThroughExtractSubvector.

New patch at https://reviews.llvm.org/D131503

Aug 9 2022, 8:49 AM · Restricted Project, Restricted Project
peterwaller-arm requested review of D131503: [DAGCombine] Combine signext_inreg of extract-extend.
Aug 9 2022, 8:49 AM · Restricted Project, Restricted Project
peterwaller-arm committed rG310962f25ec1: [DAGCombine][NFC] Precommit extract-subvec-combine sext tests (authored by peterwaller-arm).
[DAGCombine][NFC] Precommit extract-subvec-combine sext tests
Aug 9 2022, 8:45 AM · Restricted Project, Restricted Project
peterwaller-arm accepted D128642: [AArch64][SVE] Use SVE for VLS fcopysign for wide vectors.
Aug 9 2022, 4:00 AM · Restricted Project, Restricted Project

Aug 8 2022

peterwaller-arm planned changes to D130700: [AArch64][DAGCombine] Add pushSignExtendThroughExtractSubvector.
Aug 8 2022, 4:39 AM · Restricted Project, Restricted Project
peterwaller-arm abandoned D130699: [AArch64][DAGCombine] Add pushAndThroughExtractSubvector.
Aug 8 2022, 4:38 AM · Restricted Project, Restricted Project

Jul 28 2022

peterwaller-arm updated the diff for D130700: [AArch64][DAGCombine] Add pushSignExtendThroughExtractSubvector.
  • Stylistic changes to shrink the code a little.
  • Add check for signext_inreg type.
  • Update tests.
Jul 28 2022, 8:56 AM · Restricted Project, Restricted Project