Page MenuHomePhabricator

ctetreau (Christopher Tetreault)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2019, 12:14 PM (33 w, 6 d)

Recent Activity

Today

ctetreau added a child revision for D81201: [SVE] Eliminate calls to default-false VectorType::get() from llvm-stress: D80342: [SVE] Remove default false from VectorType::get(Type *, unsigned, bool).
Thu, Jun 4, 4:37 PM · Restricted Project
ctetreau added a parent revision for D80342: [SVE] Remove default false from VectorType::get(Type *, unsigned, bool): D81201: [SVE] Eliminate calls to default-false VectorType::get() from llvm-stress.
Thu, Jun 4, 4:37 PM · Restricted Project
ctetreau added reviewers for D81201: [SVE] Eliminate calls to default-false VectorType::get() from llvm-stress: kmclaughlin, sdesmalen, MaskRay, JDevlieghere.
Thu, Jun 4, 4:37 PM · Restricted Project
ctetreau created D81201: [SVE] Eliminate calls to default-false VectorType::get() from llvm-stress.
Thu, Jun 4, 4:36 PM · Restricted Project
ctetreau committed rGc2625f330f48: [SVE] Eliminate calls to default-false VectorType::get() from SystemZ (authored by ctetreau).
[SVE] Eliminate calls to default-false VectorType::get() from SystemZ
Thu, Jun 4, 10:27 AM
ctetreau closed D80329: [SVE] Eliminate calls to default-false VectorType::get() from SystemZ.
Thu, Jun 4, 10:27 AM · Restricted Project

Yesterday

ctetreau updated the diff for D80235: [SVE] Eliminate calls to VectorType::getNumElements from BasicTTIImpl.h.

rebase

Wed, Jun 3, 4:35 PM · Restricted Project
ctetreau added reviewers for D80313: [SVE] Eliminate calls to default-false VectorType::get() from CodeGen: aqjune, paquette, arsenm, gchatelet.
Wed, Jun 3, 4:35 PM · Restricted Project
ctetreau added reviewers for D80336: [SVE] Eliminate calls to default-false VectorType::get() from Scalar: bkramer, anna, gchatelet.
Wed, Jun 3, 4:02 PM · Restricted Project
ctetreau abandoned D81041: Use existing path sep style in clang::FileManager::FixupRelativePath.

After some further investigation, I have come to believe that the root cause of the issue I am seeing is on line 783 of clang/lib/Lex/HeaderSearch.cpp. A path is constructed using string concatenation (dir + '/' + file), which is obviously not robust to the various issues in path construction. A fix had been committed and reverted back in 2015. Upon restoring the fix, I see that it causes several other test failures. Unfortunately, I do not have the bandwidth to fully resolve this issue myself, so I have opened a bug for it: https://bugs.llvm.org/show_bug.cgi?id=46187

Wed, Jun 3, 4:02 PM · Restricted Project
ctetreau abandoned D81117: Fix path separator issue on Windows.
Wed, Jun 3, 4:02 PM · Restricted Project
ctetreau committed rG900f78a714c5: [SVE] Eliminate calls to default-false VectorType::get() from IR (authored by ctetreau).
[SVE] Eliminate calls to default-false VectorType::get() from IR
Wed, Jun 3, 2:22 PM
ctetreau closed D80261: [SVE] Eliminate calls to default-false VectorType::get() from IR.
Wed, Jun 3, 2:21 PM · Restricted Project
ctetreau added a reviewer for D80325: [SVE] Eliminate calls to default-false VectorType::get() from FuzzMutate: chandlerc.
Wed, Jun 3, 2:20 PM · Restricted Project
ctetreau added reviewers for D80329: [SVE] Eliminate calls to default-false VectorType::get() from SystemZ: samparker, uweigand.
Wed, Jun 3, 2:20 PM · Restricted Project
ctetreau created D81117: Fix path separator issue on Windows.
Wed, Jun 3, 1:46 PM · Restricted Project
ctetreau added a comment to D81041: Use existing path sep style in clang::FileManager::FixupRelativePath.

The assert that I am getting is at line 1701 of VirtualFileSystem.cpp:

Wed, Jun 3, 10:25 AM · Restricted Project

Tue, Jun 2

ctetreau added reviewers for D81041: Use existing path sep style in clang::FileManager::FixupRelativePath: efriedma, apazos, zzheng, dexonsmith, rnk.
Tue, Jun 2, 3:56 PM · Restricted Project
ctetreau created D81041: Use existing path sep style in clang::FileManager::FixupRelativePath.
Tue, Jun 2, 3:56 PM · Restricted Project

Mon, Jun 1

ctetreau added a comment to D80261: [SVE] Eliminate calls to default-false VectorType::get() from IR.

ping?

Mon, Jun 1, 10:45 AM · Restricted Project
ctetreau added a comment to D80329: [SVE] Eliminate calls to default-false VectorType::get() from SystemZ.

ping?

Mon, Jun 1, 10:45 AM · Restricted Project
ctetreau added a comment to D80325: [SVE] Eliminate calls to default-false VectorType::get() from FuzzMutate.

ping?

Mon, Jun 1, 10:45 AM · Restricted Project
ctetreau committed rG796898172c48: [SVE] Eliminate calls to default-false VectorType::get() from Clang (authored by ctetreau).
[SVE] Eliminate calls to default-false VectorType::get() from Clang
Mon, Jun 1, 10:13 AM
ctetreau closed D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang.
Mon, Jun 1, 10:13 AM · Restricted Project

Fri, May 29

ctetreau committed rGaad936548247: [SVE] Eliminate calls to default-false VectorType::get() from AMDGPU (authored by ctetreau).
[SVE] Eliminate calls to default-false VectorType::get() from AMDGPU
Fri, May 29, 6:03 PM
ctetreau committed rG77b1ed4b4a49: [SVE] Eliminate calls to default-false VectorType::get() from Linker (authored by ctetreau).
[SVE] Eliminate calls to default-false VectorType::get() from Linker
Fri, May 29, 6:03 PM
ctetreau closed D80328: [SVE] Eliminate calls to default-false VectorType::get() from AMDGPU.
Fri, May 29, 6:02 PM · Restricted Project
ctetreau closed D80326: [SVE] Eliminate calls to default-false VectorType::get() from Linker.
Fri, May 29, 6:02 PM · Restricted Project
ctetreau committed rG5a99ec10f5df: [SVE] Eliminate calls to default-false VectorType::get() from X86 (authored by ctetreau).
[SVE] Eliminate calls to default-false VectorType::get() from X86
Fri, May 29, 4:26 PM
ctetreau closed D80331: [SVE] Eliminate calls to default-false VectorType::get() from X86.
Fri, May 29, 4:26 PM · Restricted Project
ctetreau committed rGe6cf402e8364: [SVE] Eliminate calls to default-false VectorType::get() from… (authored by ctetreau).
[SVE] Eliminate calls to default-false VectorType::get() from…
Fri, May 29, 3:54 PM
ctetreau committed rG56eb7556e75c: [SVE] Eliminate calls to default-false VectorType::get() from AArch64 (authored by ctetreau).
[SVE] Eliminate calls to default-false VectorType::get() from AArch64
Fri, May 29, 3:54 PM
ctetreau closed D80332: [SVE] Eliminate calls to default-false VectorType::get() from AggressiveInstCombine.
Fri, May 29, 3:54 PM · Restricted Project
ctetreau closed D80327: [SVE] Eliminate calls to default-false VectorType::get() from AArch64.
Fri, May 29, 3:53 PM · Restricted Project
ctetreau committed rG8f8029b4587e: [SVE] Eliminate calls to default-false VectorType::get() from InstCombine (authored by ctetreau).
[SVE] Eliminate calls to default-false VectorType::get() from InstCombine
Fri, May 29, 3:53 PM
ctetreau closed D80334: [SVE] Eliminate calls to default-false VectorType::get() from InstCombine.
Fri, May 29, 3:53 PM · Restricted Project
ctetreau committed rGe4d2037a5ccb: [SVE] Eliminate calls to default-false VectorType::get() from Instrumentation (authored by ctetreau).
[SVE] Eliminate calls to default-false VectorType::get() from Instrumentation
Fri, May 29, 3:53 PM
ctetreau closed D80335: [SVE] Eliminate calls to default-false VectorType::get() from Instrumentation.
Fri, May 29, 3:53 PM · Restricted Project
ctetreau committed rGc8f1aca316c2: [SVE] Eliminate calls to default-false VectorType::get() from Utils (authored by ctetreau).
[SVE] Eliminate calls to default-false VectorType::get() from Utils
Fri, May 29, 3:20 PM
ctetreau closed D80337: [SVE] Eliminate calls to default-false VectorType::get() from Utils.
Fri, May 29, 3:20 PM · Restricted Project
ctetreau updated the diff for D80235: [SVE] Eliminate calls to VectorType::getNumElements from BasicTTIImpl.h.

Before attempting to dyn_cast to FixedVectorType, assert that the type is not a scalable vector.

Fri, May 29, 1:06 PM · Restricted Project
ctetreau committed rGd2befc66336d: [SVE] Eliminate calls to default-false VectorType::get() from Vectorize (authored by ctetreau).
[SVE] Eliminate calls to default-false VectorType::get() from Vectorize
Fri, May 29, 12:01 PM
ctetreau closed D80339: [SVE] Eliminate calls to default-false VectorType::get() from Vectorize.
Fri, May 29, 12:01 PM · Restricted Project
ctetreau planned changes to D78127: [SVE] Move VectorType::getNumElements() into FixedVectorType.

Per recent discussions on the mailing lists, I'll be deprecating VectorType::getNumElements() rather than deleting it now.

Fri, May 29, 12:00 PM · Restricted Project
ctetreau abandoned D78599: [SVE] Add Scalable vector support to C api.
Fri, May 29, 12:00 PM · Restricted Project
ctetreau planned changes to D80342: [SVE] Remove default false from VectorType::get(Type *, unsigned, bool).

Per recent discussions about the pace of this effort, I'll be adding a deprecated overload rather than just deleting the parameter.

Fri, May 29, 12:00 PM · Restricted Project
ctetreau committed rGb82a95f8bc91: [SVE] Eliminate calls to default-false VectorType::get() from polly (authored by ctetreau).
[SVE] Eliminate calls to default-false VectorType::get() from polly
Fri, May 29, 10:23 AM
ctetreau closed D80341: [SVE] Eliminate calls to default-false VectorType::get() from polly.
Fri, May 29, 10:23 AM · Restricted Project
ctetreau updated the diff for D80336: [SVE] Eliminate calls to default-false VectorType::get() from Scalar.

rebase

Fri, May 29, 10:21 AM · Restricted Project
ctetreau updated the diff for D80313: [SVE] Eliminate calls to default-false VectorType::get() from CodeGen.

fix rebase issue

Fri, May 29, 9:49 AM · Restricted Project
ctetreau added a comment to D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang.

@rjmccall Given the outcome of the call yesterday, may I merge this patch?

Fri, May 29, 9:14 AM · Restricted Project

Thu, May 28

ctetreau committed rGa9c7b498621b: [SVE] Eliminate calls to default-false VectorType::get() from mlir (authored by ctetreau).
[SVE] Eliminate calls to default-false VectorType::get() from mlir
Thu, May 28, 2:54 PM
ctetreau closed D80340: [SVE] Eliminate calls to default-false VectorType::get() from mlir.
Thu, May 28, 2:54 PM · Restricted Project
ctetreau committed rG434d122e94a7: [SVE] Eliminate calls to default-false VectorType::get() from Analysis (authored by ctetreau).
[SVE] Eliminate calls to default-false VectorType::get() from Analysis
Thu, May 28, 2:53 PM
ctetreau closed D80324: [SVE] Eliminate calls to default-false VectorType::get() from Analysis.
Thu, May 28, 2:53 PM · Restricted Project
ctetreau updated the diff for D80341: [SVE] Eliminate calls to default-false VectorType::get() from polly.

Oh gosh, it's like that everywhere

Thu, May 28, 2:52 PM · Restricted Project
ctetreau updated the diff for D80341: [SVE] Eliminate calls to default-false VectorType::get() from polly.

address code review issues

Thu, May 28, 2:52 PM · Restricted Project
ctetreau added inline comments to D80341: [SVE] Eliminate calls to default-false VectorType::get() from polly.
Thu, May 28, 2:52 PM · Restricted Project
ctetreau updated the diff for D80341: [SVE] Eliminate calls to default-false VectorType::get() from polly.

rebase

Thu, May 28, 1:45 PM · Restricted Project
ctetreau updated the diff for D80340: [SVE] Eliminate calls to default-false VectorType::get() from mlir.

rebase

Thu, May 28, 1:14 PM · Restricted Project
ctetreau updated the diff for D80339: [SVE] Eliminate calls to default-false VectorType::get() from Vectorize.

rebase

Thu, May 28, 1:13 PM · Restricted Project
ctetreau updated the diff for D80335: [SVE] Eliminate calls to default-false VectorType::get() from Instrumentation.

rebase

Thu, May 28, 1:13 PM · Restricted Project
ctetreau updated the diff for D80337: [SVE] Eliminate calls to default-false VectorType::get() from Utils.

rebase

Thu, May 28, 1:13 PM · Restricted Project
ctetreau updated the diff for D80336: [SVE] Eliminate calls to default-false VectorType::get() from Scalar.

rebase

Thu, May 28, 1:13 PM · Restricted Project
ctetreau updated the diff for D80334: [SVE] Eliminate calls to default-false VectorType::get() from InstCombine.

rebase

Thu, May 28, 1:13 PM · Restricted Project
ctetreau updated the diff for D80332: [SVE] Eliminate calls to default-false VectorType::get() from AggressiveInstCombine.

rebase

Thu, May 28, 1:13 PM · Restricted Project
ctetreau updated the diff for D80329: [SVE] Eliminate calls to default-false VectorType::get() from SystemZ.

rebase

Thu, May 28, 1:13 PM · Restricted Project
ctetreau updated the diff for D80331: [SVE] Eliminate calls to default-false VectorType::get() from X86.

rebase

Thu, May 28, 1:13 PM · Restricted Project
ctetreau updated the diff for D80328: [SVE] Eliminate calls to default-false VectorType::get() from AMDGPU.

rebase

Thu, May 28, 1:13 PM · Restricted Project
ctetreau updated the diff for D80326: [SVE] Eliminate calls to default-false VectorType::get() from Linker.

rebase

Thu, May 28, 1:13 PM · Restricted Project
ctetreau updated the diff for D80327: [SVE] Eliminate calls to default-false VectorType::get() from AArch64.

rebase

Thu, May 28, 1:13 PM · Restricted Project
ctetreau updated the diff for D80325: [SVE] Eliminate calls to default-false VectorType::get() from FuzzMutate.

rebase

Thu, May 28, 1:13 PM · Restricted Project
ctetreau updated the diff for D80324: [SVE] Eliminate calls to default-false VectorType::get() from Analysis.

rebase

Thu, May 28, 1:13 PM · Restricted Project
ctetreau updated the diff for D80313: [SVE] Eliminate calls to default-false VectorType::get() from CodeGen.

rebase

Thu, May 28, 1:13 PM · Restricted Project
ctetreau updated the diff for D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang.

rebase

Thu, May 28, 1:13 PM · Restricted Project
ctetreau updated the diff for D80313: [SVE] Eliminate calls to default-false VectorType::get() from CodeGen.

rebase

Thu, May 28, 1:13 PM · Restricted Project
ctetreau updated the diff for D80262: [SVE] Eliminate bad VectorType::getNumElements() calls from ConstantFold.

rebase

Thu, May 28, 1:13 PM · Restricted Project
ctetreau updated the diff for D80261: [SVE] Eliminate calls to default-false VectorType::get() from IR.

rebase

Thu, May 28, 1:13 PM · Restricted Project
ctetreau updated the diff for D80235: [SVE] Eliminate calls to VectorType::getNumElements from BasicTTIImpl.h.

rebase

Thu, May 28, 1:13 PM · Restricted Project

Thu, May 21

ctetreau updated the diff for D80336: [SVE] Eliminate calls to default-false VectorType::get() from Scalar.

rebase

Thu, May 21, 11:21 AM · Restricted Project
ctetreau updated the diff for D80339: [SVE] Eliminate calls to default-false VectorType::get() from Vectorize.

rebase

Thu, May 21, 11:21 AM · Restricted Project
ctetreau updated the diff for D80326: [SVE] Eliminate calls to default-false VectorType::get() from Linker.

address code review issues

Thu, May 21, 11:21 AM · Restricted Project
ctetreau updated the diff for D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang.

address code review issues

Thu, May 21, 10:49 AM · Restricted Project
ctetreau updated the diff for D80313: [SVE] Eliminate calls to default-false VectorType::get() from CodeGen.

address code reveiw issues

Thu, May 21, 10:48 AM · Restricted Project
ctetreau updated the diff for D80313: [SVE] Eliminate calls to default-false VectorType::get() from CodeGen.

rebase

Thu, May 21, 10:47 AM · Restricted Project
ctetreau updated the diff for D80261: [SVE] Eliminate calls to default-false VectorType::get() from IR.

rebase

Thu, May 21, 10:15 AM · Restricted Project
ctetreau added a comment to D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang.

I'm sympathetic to wanting to get rid of the boolean flag, but this is a really invasive change for pretty minimal benefit. Why not leave VectorType::get as meaning a non-scalable vector type and come up with a different method name to get a scalable vector?

Thu, May 21, 10:15 AM · Restricted Project

Wed, May 20

ctetreau added inline comments to D80326: [SVE] Eliminate calls to default-false VectorType::get() from Linker.
Wed, May 20, 5:08 PM · Restricted Project
ctetreau added a child revision for D80341: [SVE] Eliminate calls to default-false VectorType::get() from polly: D80342: [SVE] Remove default false from VectorType::get(Type *, unsigned, bool).
Wed, May 20, 5:07 PM · Restricted Project
ctetreau added a child revision for D80337: [SVE] Eliminate calls to default-false VectorType::get() from Utils: D80342: [SVE] Remove default false from VectorType::get(Type *, unsigned, bool).
Wed, May 20, 5:07 PM · Restricted Project
ctetreau added a child revision for D80340: [SVE] Eliminate calls to default-false VectorType::get() from mlir: D80342: [SVE] Remove default false from VectorType::get(Type *, unsigned, bool).
Wed, May 20, 5:07 PM · Restricted Project
ctetreau added a parent revision for D80342: [SVE] Remove default false from VectorType::get(Type *, unsigned, bool): D80340: [SVE] Eliminate calls to default-false VectorType::get() from mlir.
Wed, May 20, 5:07 PM · Restricted Project
ctetreau added a parent revision for D80342: [SVE] Remove default false from VectorType::get(Type *, unsigned, bool): D80341: [SVE] Eliminate calls to default-false VectorType::get() from polly.
Wed, May 20, 5:07 PM · Restricted Project
ctetreau added a child revision for D80339: [SVE] Eliminate calls to default-false VectorType::get() from Vectorize: D80342: [SVE] Remove default false from VectorType::get(Type *, unsigned, bool).
Wed, May 20, 5:07 PM · Restricted Project
ctetreau added a parent revision for D80342: [SVE] Remove default false from VectorType::get(Type *, unsigned, bool): D80339: [SVE] Eliminate calls to default-false VectorType::get() from Vectorize.
Wed, May 20, 5:07 PM · Restricted Project
ctetreau added a parent revision for D80342: [SVE] Remove default false from VectorType::get(Type *, unsigned, bool): D80325: [SVE] Eliminate calls to default-false VectorType::get() from FuzzMutate.
Wed, May 20, 5:07 PM · Restricted Project
ctetreau added a child revision for D80324: [SVE] Eliminate calls to default-false VectorType::get() from Analysis: D80342: [SVE] Remove default false from VectorType::get(Type *, unsigned, bool).
Wed, May 20, 5:07 PM · Restricted Project
ctetreau added a child revision for D80325: [SVE] Eliminate calls to default-false VectorType::get() from FuzzMutate: D80342: [SVE] Remove default false from VectorType::get(Type *, unsigned, bool).
Wed, May 20, 5:07 PM · Restricted Project
ctetreau added a child revision for D80336: [SVE] Eliminate calls to default-false VectorType::get() from Scalar: D80342: [SVE] Remove default false from VectorType::get(Type *, unsigned, bool).
Wed, May 20, 5:07 PM · Restricted Project
ctetreau added a parent revision for D80342: [SVE] Remove default false from VectorType::get(Type *, unsigned, bool): D80337: [SVE] Eliminate calls to default-false VectorType::get() from Utils.
Wed, May 20, 5:07 PM · Restricted Project