Page MenuHomePhabricator

ctetreau (User is inactive)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2019, 12:14 PM (136 w, 6 d)

Recent Activity

Feb 3 2022

ctetreau updated ctetreau.
Feb 3 2022, 11:32 AM

Nov 2 2021

ctetreau committed rG5718b9f128ba: [NFC] Reformat VerifyPreservedCFG for non-CPP-aware syntax highlighters (authored by ctetreau).
[NFC] Reformat VerifyPreservedCFG for non-CPP-aware syntax highlighters
Nov 2 2021, 11:36 AM

Oct 14 2021

ctetreau added a comment to D110976: docs: Document workaround for arcanist failures.

OK, thanks for the update!

Oct 14 2021, 12:56 PM · Restricted Project

Oct 13 2021

ctetreau added a comment to D110976: docs: Document workaround for arcanist failures.

Any news on this? As @mehdi_amini mentions, we have a fork. I would think that the ideal solution is to just merge that PR into our fork, then update the instructions to say to use our repo for arcanist. If our fork of phabricator is not long for this world, I don't think this would make getting rid of it in the future significantly harder.

Oct 13 2021, 9:48 AM · Restricted Project
ctetreau added a reviewer for D110976: docs: Document workaround for arcanist failures: ctetreau.
Oct 13 2021, 9:44 AM · Restricted Project

Oct 5 2021

ctetreau closed D110894: [NFC] Fix build failure in ScopDetection.
Oct 5 2021, 8:59 AM · Restricted Project

Oct 4 2021

ctetreau added a comment to D110594: [SimpleLoopUnswitch] Allow threshold to be specified zero or more times.

@aeubanks Sorry, I accidentally pushed this commit. Personally, I think it's fine and obvious (meeting the standards of merging without review), but if you still object let me know and I can revert it.

Oct 4 2021, 9:42 AM · Restricted Project
ctetreau committed rG67acc772d094: [NFC] Fix build failure in ScopDetection (authored by ctetreau).
[NFC] Fix build failure in ScopDetection
Oct 4 2021, 9:36 AM
ctetreau committed rGdf1f03280c4f: [SimpleLoopUnswitch] Allow threshold to be specified zero or more times (authored by ctetreau).
[SimpleLoopUnswitch] Allow threshold to be specified zero or more times
Oct 4 2021, 9:36 AM
ctetreau closed D110594: [SimpleLoopUnswitch] Allow threshold to be specified zero or more times.
Oct 4 2021, 9:36 AM · Restricted Project

Oct 1 2021

ctetreau added a comment to D110976: docs: Document workaround for arcanist failures.

Would we want to put up the commit in a fork that we control, so that we're not relying on someone else's fork (which may go away in the future)?

Oct 1 2021, 2:56 PM · Restricted Project
ctetreau added inline comments to D110890: [GlobalISel] Port the udiv -> mul by constant combine..
Oct 1 2021, 1:25 PM · Restricted Project
ctetreau closed D110747: [NFC] Restore magic and magicu to a globally visible location.
Oct 1 2021, 9:29 AM · Restricted Project
ctetreau added inline comments to D110747: [NFC] Restore magic and magicu to a globally visible location.
Oct 1 2021, 9:28 AM · Restricted Project

Sep 30 2021

ctetreau committed rG3077bc90de8d: [NFC] Restore magic and magicu to a globally visible location (authored by ctetreau).
[NFC] Restore magic and magicu to a globally visible location
Sep 30 2021, 5:43 PM
ctetreau added a comment to D110894: [NFC] Fix build failure in ScopDetection.

The old code works for me with visual studio 2019, but fails with clang 7 and clang 12.1.

Sep 30 2021, 4:50 PM · Restricted Project
ctetreau added reviewers for D110894: [NFC] Fix build failure in ScopDetection: Meinersbur, efriedma.
Sep 30 2021, 4:47 PM · Restricted Project
ctetreau requested review of D110894: [NFC] Fix build failure in ScopDetection.
Sep 30 2021, 4:47 PM · Restricted Project
ctetreau updated the summary of D110747: [NFC] Restore magic and magicu to a globally visible location.
Sep 30 2021, 9:27 AM · Restricted Project

Sep 29 2021

ctetreau updated the diff for D110747: [NFC] Restore magic and magicu to a globally visible location.

address code review issues:

  • fix include guard
  • rename mag to Retval
  • also, make all the variables PascalCase to silence clang-tidy
Sep 29 2021, 3:36 PM · Restricted Project
ctetreau updated the diff for D110747: [NFC] Restore magic and magicu to a globally visible location.

address code review issues; clean up the interface

Sep 29 2021, 2:59 PM · Restricted Project
ctetreau updated the diff for D110747: [NFC] Restore magic and magicu to a globally visible location.

add include guard

Sep 29 2021, 12:40 PM · Restricted Project
ctetreau added inline comments to D110747: [NFC] Restore magic and magicu to a globally visible location.
Sep 29 2021, 12:33 PM · Restricted Project
ctetreau added a comment to D110747: [NFC] Restore magic and magicu to a globally visible location.

I decided to create a new file in llvm/Support rather than take one of the suggestions in Chris's diff thread because:

Sep 29 2021, 11:46 AM · Restricted Project
ctetreau added a comment to D109476: [APInt.h] Reduce the APInt header file interface a bit. NFC.

This patch actually broke my downstream as well. I uploaded a patch to move this to a new file in Support: https://reviews.llvm.org/D110747

Sep 29 2021, 11:40 AM · Restricted Project
ctetreau added reviewers for D110747: [NFC] Restore magic and magicu to a globally visible location: lattner, craig.topper, dsanders, efriedma.
Sep 29 2021, 11:38 AM · Restricted Project
ctetreau requested review of D110747: [NFC] Restore magic and magicu to a globally visible location.
Sep 29 2021, 11:37 AM · Restricted Project

Sep 27 2021

ctetreau added a comment to D110594: [SimpleLoopUnswitch] Allow threshold to be specified zero or more times.

What's the motivation behind this?
In general I don't think we support this sort of -mllvm behavior.

Sep 27 2021, 3:40 PM · Restricted Project
ctetreau added reviewers for D110594: [SimpleLoopUnswitch] Allow threshold to be specified zero or more times: aeubanks, jaykang10, chandlerc, efriedma.
Sep 27 2021, 2:44 PM · Restricted Project
ctetreau requested review of D110594: [SimpleLoopUnswitch] Allow threshold to be specified zero or more times.
Sep 27 2021, 2:40 PM · Restricted Project

Aug 23 2021

ctetreau added a comment to D108472: [test] Update some test cases to use -passes when specifying the pipeline.

I'm not sure doing this is a good idea. The nice thing about the current way of testing is that it works both for the new pass manager and the legacy pass manager. That is, people can flip ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER to false, run the test suite, and get good test coverage for the legacy pass manager. Switching to NewPM-only syntax removes that ability.

Aug 23 2021, 9:44 AM · Restricted Project

Aug 18 2021

ctetreau committed rG2afb9394a745: [hwasan] Flag stack safety check as requiring aarch64 (authored by ctetreau).
[hwasan] Flag stack safety check as requiring aarch64
Aug 18 2021, 11:14 AM
ctetreau closed D108241: [hwasan] Flag stack safety check as requiring aarch64.
Aug 18 2021, 11:14 AM · Restricted Project
ctetreau added reviewers for D108241: [hwasan] Flag stack safety check as requiring aarch64: fmayer, vitalybuka, eugenis.
Aug 18 2021, 9:17 AM · Restricted Project

Aug 17 2021

ctetreau requested review of D108241: [hwasan] Flag stack safety check as requiring aarch64.
Aug 17 2021, 2:17 PM · Restricted Project

Apr 23 2021

ctetreau added a comment to D99718: [LoopVectorize] Simplify scalar cost calculation in getInstructionCost.

I prefer an assert, but so long as the compiler produces correct results in the assertion failure case, I guess it's fine for now. I'll not block your patch over it.

Apr 23 2021, 4:49 PM · Restricted Project, Restricted Project

Apr 19 2021

ctetreau added a comment to D99718: [LoopVectorize] Simplify scalar cost calculation in getInstructionCost.

I'm not sure I follow why the logic would be far too complicated for an assert? There are asserts that verify the whole dominator tree or the whole function, which seems much more complicated :) Also, IIUC the assert caught a case that was missing from the comment/explanation in the initial patch, so it seems like it was doing what it was supposed to be?

Apr 19 2021, 10:06 AM · Restricted Project, Restricted Project
ctetreau added inline comments to D99718: [LoopVectorize] Simplify scalar cost calculation in getInstructionCost.
Apr 19 2021, 10:04 AM · Restricted Project, Restricted Project
ctetreau added a comment to D100565: [TTI] NFC: Change getIntImmCost[Inst|Intrin] to return InstructionCost.

Assuming @c-rhodes is satisfied, this change looks good to me.

Apr 19 2021, 9:45 AM · Restricted Project

Mar 30 2021

ctetreau accepted D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed..
Mar 30 2021, 4:05 PM · Restricted Project, Restricted Project

Mar 25 2021

ctetreau added a comment to D99305: [docs] Document our norms around reverts.

I think it's good to write this down. A revert could be interpreted as a hostile action, so the fact that they happen all the time around here should be written down.

Mar 25 2021, 8:25 AM · Restricted Project

Mar 22 2021

ctetreau added inline comments to D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed..
Mar 22 2021, 9:15 AM · Restricted Project, Restricted Project

Mar 19 2021

ctetreau added inline comments to D98715: [LoopVectorize] Add support for scalable vectorization of induction variables.
Mar 19 2021, 9:48 AM · Restricted Project
ctetreau accepted D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed..

lgtm

Mar 19 2021, 9:41 AM · Restricted Project, Restricted Project

Mar 16 2021

ctetreau added inline comments to D98715: [LoopVectorize] Add support for scalable vectorization of induction variables.
Mar 16 2021, 9:23 AM · Restricted Project

Mar 15 2021

ctetreau committed rG39970764af39: [CMake] Require python 3.6 if enabling LLVM test targets (authored by ctetreau).
[CMake] Require python 3.6 if enabling LLVM test targets
Mar 15 2021, 9:51 AM
ctetreau closed D95635: [CMake] Require python 3.6 if enabling LLVM test targets.
Mar 15 2021, 9:51 AM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2021

ctetreau added a comment to D95635: [CMake] Require python 3.6 if enabling LLVM test targets.

would it make sense to syndicate the minimal version in a single variable, say LLVM_MINIMAL_PYTHON_VERSION, and use it in several place instead of hard-coding the value across multiple files?

Mar 11 2021, 3:04 PM · Restricted Project, Restricted Project, Restricted Project
ctetreau updated the diff for D95635: [CMake] Require python 3.6 if enabling LLVM test targets.

set a var for the minimum bound

Mar 11 2021, 3:03 PM · Restricted Project, Restricted Project, Restricted Project
ctetreau requested review of D95635: [CMake] Require python 3.6 if enabling LLVM test targets.

Ping

Mar 11 2021, 7:46 AM · Restricted Project, Restricted Project, Restricted Project
ctetreau retitled D95635: [CMake] Require python 3.6 if enabling LLVM test targets from [CMake] Actually require python 3.6 or greater to [CMake] Require python 3.6 if enabling LLVM test targets.
Mar 11 2021, 7:45 AM · Restricted Project, Restricted Project, Restricted Project
ctetreau updated the diff for D95635: [CMake] Require python 3.6 if enabling LLVM test targets.

Only require if adding test suite targets

Mar 11 2021, 7:44 AM · Restricted Project, Restricted Project, Restricted Project
ctetreau planned changes to D95635: [CMake] Require python 3.6 if enabling LLVM test targets.

I plan to revive this patch. I will try to rig it to only require 3.6 or above is testing is enabled using LLVM_INCLUDE_TESTS. Hopefully if any build bots haven't been fixed by now, they will not be setting this variable to ON (since they clearly aren't running tests)

Mar 11 2021, 6:55 AM · Restricted Project, Restricted Project, Restricted Project

Mar 8 2021

ctetreau added a comment to D97299: [IR][SVE] Add new llvm.experimental.stepvector intrinsic.

@ctetreau: We've followed the same route as for llvm.vscale() -> ISD::VSCALE so yes the code generation side is more complete/convenient. Considering we're expecting llvm.experimental.stepvector() to be redundant once there's time to push for the preferred ConstantVector solution, we feel it's better to keep the intrinsic as simple as possible.

Mar 8 2021, 12:30 PM · Restricted Project
ctetreau added inline comments to D97382: NFC: Migrate PartialInlining to work on InstructionCost.
Mar 8 2021, 9:26 AM · Restricted Project

Mar 5 2021

ctetreau accepted D97861: [LoopVectorize][NFC] Refactor code to use IRBuilder::CreateStepVector.

lgtm

Mar 5 2021, 12:26 PM · Restricted Project

Mar 4 2021

ctetreau added inline comments to D97382: NFC: Migrate PartialInlining to work on InstructionCost.
Mar 4 2021, 2:23 PM · Restricted Project
ctetreau added a comment to D97382: NFC: Migrate PartialInlining to work on InstructionCost.

Aside from the function signature for InstructionCost::map, this patch looks good to me.

Mar 4 2021, 2:23 PM · Restricted Project
ctetreau added a comment to D97299: [IR][SVE] Add new llvm.experimental.stepvector intrinsic.

If the ISD node is going to get an argument for the step, why not let the new intrinsic have this same argument?

Mar 4 2021, 8:49 AM · Restricted Project
ctetreau added inline comments to D97861: [LoopVectorize][NFC] Refactor code to use IRBuilder::CreateStepVector.
Mar 4 2021, 8:44 AM · Restricted Project
ctetreau added inline comments to D97861: [LoopVectorize][NFC] Refactor code to use IRBuilder::CreateStepVector.
Mar 4 2021, 8:20 AM · Restricted Project

Mar 3 2021

ctetreau added inline comments to D97861: [LoopVectorize][NFC] Refactor code to use IRBuilder::CreateStepVector.
Mar 3 2021, 9:56 AM · Restricted Project

Mar 2 2021

ctetreau added inline comments to D97382: NFC: Migrate PartialInlining to work on InstructionCost.
Mar 2 2021, 10:05 AM · Restricted Project
ctetreau accepted D97466: NFC: Change getUserCost to return InstructionCost.

Assuming everybody else is satisfied, LGTM

Mar 2 2021, 9:33 AM · Restricted Project

Feb 26 2021

ctetreau added a comment to D97466: NFC: Change getUserCost to return InstructionCost.

Does changing the -1's to invalid's constitute a functional change? Are they always checked for? If they are just blindly added to other costs, then they would result in valid costs becoming invalid costs.

Feb 26 2021, 12:26 PM · Restricted Project
ctetreau added inline comments to D97382: NFC: Migrate PartialInlining to work on InstructionCost.
Feb 26 2021, 12:20 PM · Restricted Project

Feb 25 2021

ctetreau added inline comments to D97382: NFC: Migrate PartialInlining to work on InstructionCost.
Feb 25 2021, 7:23 AM · Restricted Project

Feb 24 2021

ctetreau added inline comments to D97382: NFC: Migrate PartialInlining to work on InstructionCost.
Feb 24 2021, 9:56 AM · Restricted Project

Feb 19 2021

ctetreau committed rG55448ab540de: [AArch64] Adding Neon Polynomial vadd Intrinsics (authored by ctetreau).
[AArch64] Adding Neon Polynomial vadd Intrinsics
Feb 19 2021, 2:48 PM
ctetreau closed D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics.
Feb 19 2021, 2:48 PM · Restricted Project
ctetreau accepted D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics.

LGTM. I'll land it for you.

Feb 19 2021, 2:45 PM · Restricted Project

Feb 5 2021

ctetreau closed D95803: Ensure that InstructionCost actually implements a total ordering.

the reland has landed

Feb 5 2021, 1:56 PM · Restricted Project

Feb 4 2021

ctetreau added inline comments to D95803: Ensure that InstructionCost actually implements a total ordering.
Feb 4 2021, 11:37 AM · Restricted Project
ctetreau added a reverting change for rGff1147c36356: Revert "Ensure that InstructionCost actually implements a total ordering": rGb8b054aa8aac: Reland "Ensure that InstructionCost actually implements a total ordering".
Feb 4 2021, 10:07 AM
ctetreau committed rGb8b054aa8aac: Reland "Ensure that InstructionCost actually implements a total ordering" (authored by ctetreau).
Reland "Ensure that InstructionCost actually implements a total ordering"
Feb 4 2021, 10:07 AM
ctetreau added inline comments to D95803: Ensure that InstructionCost actually implements a total ordering.
Feb 4 2021, 10:01 AM · Restricted Project
ctetreau updated the diff for D95803: Ensure that InstructionCost actually implements a total ordering.

Fix test, add comment

Feb 4 2021, 10:01 AM · Restricted Project
ctetreau updated the diff for D95803: Ensure that InstructionCost actually implements a total ordering.

address code review issues

Feb 4 2021, 9:56 AM · Restricted Project

Feb 3 2021

ctetreau added a comment to D95803: Ensure that InstructionCost actually implements a total ordering.

I just checked that this passes the expensive checks on my machine, so I think it should be good to go now.

Feb 3 2021, 12:10 PM · Restricted Project
ctetreau accepted D92238: [SCEVExpander] Migrate costAndCollectOperands to use InstructionCost..

This version LGTM

Feb 3 2021, 8:49 AM · Restricted Project
ctetreau added inline comments to D95803: Ensure that InstructionCost actually implements a total ordering.
Feb 3 2021, 7:00 AM · Restricted Project
ctetreau updated the diff for D95803: Ensure that InstructionCost actually implements a total ordering.

Fix operator<

Feb 3 2021, 6:59 AM · Restricted Project

Feb 2 2021

ctetreau planned changes to D95803: Ensure that InstructionCost actually implements a total ordering.
Feb 2 2021, 4:56 PM · Restricted Project
ctetreau reopened D95803: Ensure that InstructionCost actually implements a total ordering.
Feb 2 2021, 4:56 PM · Restricted Project
ctetreau added inline comments to D95803: Ensure that InstructionCost actually implements a total ordering.
Feb 2 2021, 4:56 PM · Restricted Project
ctetreau added a comment to D95803: Ensure that InstructionCost actually implements a total ordering.

A reasonable way ahead would be to just take the change to operator==, but not the change to operator<. We could explicitly codify "all invalid costs are considered to be equal", and this would basically be equivalent to Optional<int>.

Feb 2 2021, 3:08 PM · Restricted Project
ctetreau added a comment to D95803: Ensure that InstructionCost actually implements a total ordering.

Unfortunately, this breaks the build. Apparently several crashes and test failures result from this with the expensive checks. Unfortunately, things are very busy at work, so I don't have time to look into this for the time being.

Feb 2 2021, 3:07 PM · Restricted Project
ctetreau added a reverting change for rGb481cd519e07: Ensure that InstructionCost actually implements a total ordering: rGff1147c36356: Revert "Ensure that InstructionCost actually implements a total ordering".
Feb 2 2021, 12:12 PM
ctetreau committed rGff1147c36356: Revert "Ensure that InstructionCost actually implements a total ordering" (authored by ctetreau).
Revert "Ensure that InstructionCost actually implements a total ordering"
Feb 2 2021, 12:12 PM
ctetreau added a reverting change for D95803: Ensure that InstructionCost actually implements a total ordering: rGff1147c36356: Revert "Ensure that InstructionCost actually implements a total ordering".
Feb 2 2021, 12:12 PM · Restricted Project
ctetreau committed rGb481cd519e07: Ensure that InstructionCost actually implements a total ordering (authored by ctetreau).
Ensure that InstructionCost actually implements a total ordering
Feb 2 2021, 11:49 AM
ctetreau closed D95803: Ensure that InstructionCost actually implements a total ordering.
Feb 2 2021, 11:49 AM · Restricted Project

Feb 1 2021

ctetreau added inline comments to D95803: Ensure that InstructionCost actually implements a total ordering.
Feb 1 2021, 1:16 PM · Restricted Project
ctetreau updated the diff for D95803: Ensure that InstructionCost actually implements a total ordering.

address code review issues

Feb 1 2021, 1:14 PM · Restricted Project
ctetreau added inline comments to D95803: Ensure that InstructionCost actually implements a total ordering.
Feb 1 2021, 1:01 PM · Restricted Project
ctetreau added reviewers for D95803: Ensure that InstructionCost actually implements a total ordering: david-arm, sdesmalen, RKSimon, CarolineConcatto, efriedma.
Feb 1 2021, 10:56 AM · Restricted Project
ctetreau requested review of D95803: Ensure that InstructionCost actually implements a total ordering.
Feb 1 2021, 10:52 AM · Restricted Project
ctetreau resigned from D90344: [POC][LoopVectorizer] Allow invariant loads/stores using masked gather/scatter for a scalable VF..
Feb 1 2021, 9:54 AM · Restricted Project
ctetreau accepted D95353: NFC: Migrate SpeculateAroundPHIs to work on InstructionCost.

Aside from the nit, this looks good to me.

Feb 1 2021, 9:54 AM · Restricted Project

Jan 29 2021

ctetreau added a comment to D78203: [VP,Integer,#2] ExpandVectorPredication pass.

This all seams fairly reasonable to me, just some minor nitpicks. I'm not confident in giving this the final approval, but hopefully this can serve as a ping to those who are.

Jan 29 2021, 4:36 PM · Restricted Project, Restricted Project