Page MenuHomePhabricator

DavidTruby (David Truby)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 3 2018, 7:41 AM (195 w, 2 d)

Recent Activity

Wed, Jun 29

DavidTruby updated the diff for D128642: [AArch64][SVE] Use SVE for VLS fcopysign for wide vectors.

Rework patch to use VLA lowering for the VLS types.

Wed, Jun 29, 6:52 AM · Restricted Project, Restricted Project

Mon, Jun 27

DavidTruby updated the diff for D128642: [AArch64][SVE] Use SVE for VLS fcopysign for wide vectors.

Fix expansion for VLS on SVE2

Mon, Jun 27, 10:12 AM · Restricted Project, Restricted Project
DavidTruby added reviewers for D128642: [AArch64][SVE] Use SVE for VLS fcopysign for wide vectors: paulwalker-arm, peterwaller-arm, bsmith, c-rhodes, dtemirbulatov, MattDevereau.
Mon, Jun 27, 7:03 AM · Restricted Project, Restricted Project
DavidTruby requested review of D128642: [AArch64][SVE] Use SVE for VLS fcopysign for wide vectors.
Mon, Jun 27, 7:02 AM · Restricted Project, Restricted Project

Mon, Jun 13

DavidTruby committed rGb4f2f7bebd29: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations (authored by DavidTruby).
[clang][AArch64][SVE] Implicit conversions for vector-scalar operations
Mon, Jun 13, 3:22 AM · Restricted Project, Restricted Project
DavidTruby closed D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations.
Mon, Jun 13, 3:22 AM · Restricted Project, Restricted Project

Thu, Jun 9

DavidTruby added inline comments to D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations.
Thu, Jun 9, 9:01 AM · Restricted Project, Restricted Project
DavidTruby added inline comments to D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations.
Thu, Jun 9, 7:53 AM · Restricted Project, Restricted Project
DavidTruby updated the diff for D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations.

Remove redundant code

Thu, Jun 9, 7:52 AM · Restricted Project, Restricted Project

Wed, Jun 8

DavidTruby committed rGd261d3e4a76e: [clang][NFC][SVE] Add tests for operators on VLS vectors (authored by DavidTruby).
[clang][NFC][SVE] Add tests for operators on VLS vectors
Wed, Jun 8, 8:07 AM · Restricted Project, Restricted Project

Tue, Jun 7

DavidTruby committed rG133a5f22d325: [clang][AArch64][SVE] Improve diagnostics for SVE operators (authored by DavidTruby).
[clang][AArch64][SVE] Improve diagnostics for SVE operators
Tue, Jun 7, 7:36 AM · Restricted Project, Restricted Project
DavidTruby closed D126377: [clang][AArch64][SVE] Improve diagnostics for SVE operators.
Tue, Jun 7, 7:35 AM · Restricted Project, Restricted Project

Mon, Jun 6

DavidTruby updated the diff for D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations.

Clean up code based on review comments
Move additional tests to existing file

Mon, Jun 6, 5:39 AM · Restricted Project, Restricted Project
DavidTruby added inline comments to D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations.
Mon, Jun 6, 5:34 AM · Restricted Project, Restricted Project
DavidTruby updated the diff for D126377: [clang][AArch64][SVE] Improve diagnostics for SVE operators.

add tests for vector non-scalar diagnostic

Mon, Jun 6, 4:48 AM · Restricted Project, Restricted Project

May 26 2022

DavidTruby added inline comments to D126377: [clang][AArch64][SVE] Improve diagnostics for SVE operators.
May 26 2022, 6:22 AM · Restricted Project, Restricted Project
DavidTruby added inline comments to D126377: [clang][AArch64][SVE] Improve diagnostics for SVE operators.
May 26 2022, 6:21 AM · Restricted Project, Restricted Project

May 25 2022

DavidTruby added reviewers for D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations: c-rhodes, peterwaller-arm.
May 25 2022, 7:34 AM · Restricted Project, Restricted Project
DavidTruby abandoned D124860: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations.

I've resubmitted this split from the diagnostic changes as D126380

May 25 2022, 7:33 AM · Restricted Project, Restricted Project
DavidTruby requested review of D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations.
May 25 2022, 7:33 AM · Restricted Project, Restricted Project
DavidTruby updated the diff for D126377: [clang][AArch64][SVE] Improve diagnostics for SVE operators.

Bug fix

May 25 2022, 7:09 AM · Restricted Project, Restricted Project
DavidTruby added a comment to D124860: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations.

can the diagnostics improvements be broke out into separate patches? I think it would make this easier to review

May 25 2022, 6:51 AM · Restricted Project, Restricted Project
DavidTruby added reviewers for D126377: [clang][AArch64][SVE] Improve diagnostics for SVE operators: peterwaller-arm, c-rhodes.
May 25 2022, 6:50 AM · Restricted Project, Restricted Project
DavidTruby requested review of D126377: [clang][AArch64][SVE] Improve diagnostics for SVE operators.
May 25 2022, 6:50 AM · Restricted Project, Restricted Project

May 23 2022

DavidTruby updated the diff for D124860: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations.

Add additional tests and fix bugs associated with new tests

May 23 2022, 7:33 AM · Restricted Project, Restricted Project

May 12 2022

DavidTruby added a comment to D124860: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations.

I think this needs more tests to ensure every diagnostic is being triggered correctly so I will be adding those in another patch, but I wanted to put up the fix for the original issue as soon as possible!

May 12 2022, 8:46 AM · Restricted Project, Restricted Project
DavidTruby updated the diff for D124860: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations.

Fix assertion failures

May 12 2022, 8:44 AM · Restricted Project, Restricted Project

May 10 2022

DavidTruby updated the diff for D124860: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations.

Improved diagnostics

May 10 2022, 9:23 AM · Restricted Project, Restricted Project

May 3 2022

DavidTruby added reviewers for D124860: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations: paulwalker-arm, peterwaller-arm, MattDevereau, dtemirbulatov, bsmith.
May 3 2022, 9:34 AM · Restricted Project, Restricted Project
DavidTruby requested review of D124860: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations.
May 3 2022, 9:32 AM · Restricted Project, Restricted Project
DavidTruby committed rG8bc29d14273b: [clang][AArch64][SVE] Implement conditional operator for SVE vectors (authored by DavidTruby).
[clang][AArch64][SVE] Implement conditional operator for SVE vectors
May 3 2022, 6:11 AM · Restricted Project, Restricted Project
DavidTruby closed D124091: [clang][AArch64][SVE] Implement conditional operator for SVE vectors.
May 3 2022, 6:10 AM · Restricted Project, Restricted Project

Apr 27 2022

DavidTruby updated the diff for D124091: [clang][AArch64][SVE] Implement conditional operator for SVE vectors.

Fix crash where condition and splatted result don't have the same width

Apr 27 2022, 9:34 AM · Restricted Project, Restricted Project

Apr 21 2022

DavidTruby updated the diff for D124091: [clang][AArch64][SVE] Implement conditional operator for SVE vectors.

Add additional tests for vector splats

Apr 21 2022, 7:07 AM · Restricted Project, Restricted Project

Apr 20 2022

DavidTruby added reviewers for D124091: [clang][AArch64][SVE] Implement conditional operator for SVE vectors: peterwaller-arm, paulwalker-arm, bsmith, dtemirbulatov, MattDevereau.
Apr 20 2022, 7:00 AM · Restricted Project, Restricted Project
DavidTruby requested review of D124091: [clang][AArch64][SVE] Implement conditional operator for SVE vectors.
Apr 20 2022, 7:00 AM · Restricted Project, Restricted Project

Apr 14 2022

DavidTruby committed rG66c44b20b4a5: [Clang][AArch64][SVE] Add shift operators for SVE vector types (authored by DavidTruby).
[Clang][AArch64][SVE] Add shift operators for SVE vector types
Apr 14 2022, 5:21 AM · Restricted Project, Restricted Project
DavidTruby committed rG53fd8db79192: [Clang][AArch64][SVE] Allow subscript operator for SVE types (authored by DavidTruby).
[Clang][AArch64][SVE] Allow subscript operator for SVE types
Apr 14 2022, 5:21 AM · Restricted Project, Restricted Project
DavidTruby closed D123303: [Clang][AArch64][SVE] Add shift operators for SVE vector types.
Apr 14 2022, 5:21 AM · Restricted Project, Restricted Project
DavidTruby closed D122732: [Clang][AArch64][SVE] Allow subscript operator for SVE types.
Apr 14 2022, 5:21 AM · Restricted Project, Restricted Project

Apr 7 2022

DavidTruby added reviewers for D123303: [Clang][AArch64][SVE] Add shift operators for SVE vector types: peterwaller-arm, paulwalker-arm, bsmith, dtemirbulatov, MattDevereau.
Apr 7 2022, 6:01 AM · Restricted Project, Restricted Project
DavidTruby requested review of D123303: [Clang][AArch64][SVE] Add shift operators for SVE vector types.
Apr 7 2022, 6:00 AM · Restricted Project, Restricted Project

Apr 5 2022

DavidTruby committed rG4be1ec9fb5ca: [clang][AArc64][SVE] Add support for comparison operators on SVE types (authored by DavidTruby).
[clang][AArc64][SVE] Add support for comparison operators on SVE types
Apr 5 2022, 5:56 AM · Restricted Project, Restricted Project
DavidTruby closed D122404: [clang][AArc64][SVE] Add support for comparison operators on SVE types.
Apr 5 2022, 5:56 AM · Restricted Project, Restricted Project

Mar 31 2022

DavidTruby updated the summary of D122732: [Clang][AArch64][SVE] Allow subscript operator for SVE types.
Mar 31 2022, 6:18 AM · Restricted Project, Restricted Project
DavidTruby added a comment to D122732: [Clang][AArch64][SVE] Allow subscript operator for SVE types.

Not sure what you mean by this; LLVM supports extractelement on <vscale x 16 x i1> vectors. I guess the fact that it's a "vscale x 16" element vector might not be intuitive?

Mar 31 2022, 6:17 AM · Restricted Project, Restricted Project

Mar 30 2022

DavidTruby added reviewers for D122732: [Clang][AArch64][SVE] Allow subscript operator for SVE types: paulwalker-arm, peterwaller-arm, MattDevereau, bsmith, sdesmalen.
Mar 30 2022, 8:21 AM · Restricted Project, Restricted Project
DavidTruby requested review of D122732: [Clang][AArch64][SVE] Allow subscript operator for SVE types.
Mar 30 2022, 8:20 AM · Restricted Project, Restricted Project

Mar 24 2022

DavidTruby added reviewers for D122404: [clang][AArc64][SVE] Add support for comparison operators on SVE types: peterwaller-arm, paulwalker-arm, bsmith, MattDevereau, fpetrogalli.
Mar 24 2022, 8:01 AM · Restricted Project, Restricted Project
DavidTruby requested review of D122404: [clang][AArc64][SVE] Add support for comparison operators on SVE types.
Mar 24 2022, 7:59 AM · Restricted Project, Restricted Project

Mar 23 2022

DavidTruby committed rG683fc6203cfa: [clang][AArc64][SVE] Implement vector-scalar operators (authored by DavidTruby).
[clang][AArc64][SVE] Implement vector-scalar operators
Mar 23 2022, 7:21 AM · Restricted Project
DavidTruby closed D121829: [clang][AArc64][SVE] Implement vector-scalar operators.
Mar 23 2022, 7:21 AM · Restricted Project, Restricted Project

Mar 21 2022

DavidTruby updated the diff for D121829: [clang][AArc64][SVE] Implement vector-scalar operators.

Rebase

Mar 21 2022, 4:14 AM · Restricted Project, Restricted Project

Mar 18 2022

DavidTruby committed rGf47e7e4a3480: [clang][SVE] Add support for bitwise operators on SVE types (authored by DavidTruby).
[clang][SVE] Add support for bitwise operators on SVE types
Mar 18 2022, 7:07 AM · Restricted Project
DavidTruby closed D121119: [clang][SVE] Add support for bitwise operators on SVE types.
Mar 18 2022, 7:07 AM · Restricted Project, Restricted Project
DavidTruby updated the diff for D121829: [clang][AArc64][SVE] Implement vector-scalar operators.

Fix non-valid operation diagnostics
Add correct float tests
Add negative tests for invalid types

Mar 18 2022, 6:49 AM · Restricted Project, Restricted Project

Mar 17 2022

DavidTruby planned changes to D121829: [clang][AArc64][SVE] Implement vector-scalar operators.

When updating the float tests it seems this is causing some issues with fp16 support, which I am investigating.

Mar 17 2022, 9:20 AM · Restricted Project, Restricted Project

Mar 16 2022

DavidTruby added a comment to D121829: [clang][AArc64][SVE] Implement vector-scalar operators.

It looks like the issue you fixed for the integer tests also need fixing for the floating point variants.

Mar 16 2022, 3:09 PM · Restricted Project, Restricted Project
DavidTruby updated the diff for D121829: [clang][AArc64][SVE] Implement vector-scalar operators.

Fix mistake in unsigned tests

Mar 16 2022, 10:19 AM · Restricted Project, Restricted Project
DavidTruby added reviewers for D121829: [clang][AArc64][SVE] Implement vector-scalar operators: peterwaller-arm, paulwalker-arm, bsmith, c-rhodes, MattDevereau.
Mar 16 2022, 10:15 AM · Restricted Project, Restricted Project
DavidTruby requested review of D121829: [clang][AArc64][SVE] Implement vector-scalar operators.
Mar 16 2022, 10:14 AM · Restricted Project, Restricted Project
DavidTruby committed rGd38c9d38348f: [NFC][clang][SVE] Auto-generate SVE operator tests. (authored by DavidTruby).
[NFC][clang][SVE] Auto-generate SVE operator tests.
Mar 16 2022, 9:41 AM · Restricted Project
DavidTruby updated the diff for D121119: [clang][SVE] Add support for bitwise operators on SVE types.

Auto-generate tests

Mar 16 2022, 9:02 AM · Restricted Project, Restricted Project

Mar 14 2022

DavidTruby updated the diff for D121119: [clang][SVE] Add support for bitwise operators on SVE types.

Use ArithConvKind enum instead of boolean

Mar 14 2022, 8:42 AM · Restricted Project, Restricted Project

Mar 11 2022

DavidTruby committed rG058c92f2a4e8: [clang][SVE] Add aarch64-registered-target to sve vector op tests (authored by DavidTruby).
[clang][SVE] Add aarch64-registered-target to sve vector op tests
Mar 11 2022, 8:02 AM · Restricted Project
DavidTruby committed rG3aca0ffd5092: [clang][SVE] Add support for arithmetic operators on SVE types (authored by DavidTruby).
[clang][SVE] Add support for arithmetic operators on SVE types
Mar 11 2022, 7:40 AM · Restricted Project
DavidTruby closed D120323: [clang][SVE] Add support for arithmetic operators on SVE types.
Mar 11 2022, 7:40 AM · Restricted Project, Restricted Project

Mar 7 2022

DavidTruby added reviewers for D121119: [clang][SVE] Add support for bitwise operators on SVE types: peterwaller-arm, bsmith, paulwalker-arm, fpetrogalli.
Mar 7 2022, 7:35 AM · Restricted Project, Restricted Project
DavidTruby requested review of D121119: [clang][SVE] Add support for bitwise operators on SVE types.
Mar 7 2022, 7:35 AM · Restricted Project, Restricted Project
DavidTruby updated the diff for D120323: [clang][SVE] Add support for arithmetic operators on SVE types.

Add tests for in-place operators

Mar 7 2022, 7:29 AM · Restricted Project, Restricted Project

Feb 25 2022

DavidTruby added a comment to D120323: [clang][SVE] Add support for arithmetic operators on SVE types.

Is there a corresponding ARM specification update for this?

Feb 25 2022, 7:47 AM · Restricted Project, Restricted Project

Feb 22 2022

DavidTruby added reviewers for D120323: [clang][SVE] Add support for arithmetic operators on SVE types: peterwaller-arm, paulwalker-arm, bsmith, c-rhodes, sdesmalen.
Feb 22 2022, 6:47 AM · Restricted Project, Restricted Project
DavidTruby requested review of D120323: [clang][SVE] Add support for arithmetic operators on SVE types.
Feb 22 2022, 6:44 AM · Restricted Project, Restricted Project

Feb 7 2022

DavidTruby committed rGbe826cf4f71a: [AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP (authored by DavidTruby).
[AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP
Feb 7 2022, 6:36 AM
DavidTruby closed D118394: [AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP.
Feb 7 2022, 6:35 AM · Restricted Project

Feb 2 2022

DavidTruby updated the diff for D118394: [AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP.

Add back special f64 handling for NEON to avoid going through integer register

Feb 2 2022, 9:09 AM · Restricted Project

Feb 1 2022

DavidTruby updated the diff for D118394: [AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP.

Rebase on main

Feb 1 2022, 9:23 AM · Restricted Project
DavidTruby updated the diff for D118394: [AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP.

Remove special f64 handling which was erroneous and no longer necessary after previous change.

Feb 1 2022, 7:16 AM · Restricted Project
DavidTruby added inline comments to D118394: [AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP.
Feb 1 2022, 7:12 AM · Restricted Project
DavidTruby added inline comments to D118394: [AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP.
Feb 1 2022, 6:38 AM · Restricted Project
DavidTruby added inline comments to D118394: [AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP.
Feb 1 2022, 6:36 AM · Restricted Project
DavidTruby updated the diff for D118394: [AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP.

Reorder the operands and flip bit mask.
This changes the mask to select all the bits other than the sign from the first
operand and then only the sign from the second, making this match the operand order for std::copysign which should be more beneficial.

Feb 1 2022, 6:23 AM · Restricted Project

Jan 31 2022

DavidTruby accepted D118615: [AArch64] Bail out for float operands in SetCC optimization..

LGTM

Jan 31 2022, 8:53 AM · Restricted Project
DavidTruby updated the diff for D118394: [AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP.

Fix SVE2 lowering. BSL argument ordering is different for SVE2 and NEON, my mistake!

Jan 31 2022, 7:55 AM · Restricted Project
DavidTruby added a comment to D118394: [AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP.

Apologies to reviewers for the confusion above, I believe this patch should now be correct in all the given cases.

Jan 31 2022, 6:51 AM · Restricted Project
DavidTruby updated the diff for D118394: [AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP.

Fix operand ordering in all cases

Jan 31 2022, 6:46 AM · Restricted Project
DavidTruby added a comment to D118394: [AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP.

There's currently a bug in the output for scalars here that I am investigating

Jan 31 2022, 4:07 AM · Restricted Project
DavidTruby planned changes to D118394: [AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP.
Jan 31 2022, 3:28 AM · Restricted Project
DavidTruby updated the diff for D118394: [AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP.

Fix operand ordering mistake

Jan 31 2022, 3:26 AM · Restricted Project

Jan 28 2022

DavidTruby updated the diff for D118394: [AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP.

Add missing SVE2 tests

Jan 28 2022, 6:16 AM · Restricted Project
DavidTruby committed rG81bd67e18ae6: [AArch64][SVE][VLS] Move extends into arguments of comparisons (authored by DavidTruby).
[AArch64][SVE][VLS] Move extends into arguments of comparisons
Jan 28 2022, 6:16 AM
DavidTruby closed D118139: [AArch64][SVE][VLS] Move extends into arguments of comparisons.
Jan 28 2022, 6:16 AM · Restricted Project

Jan 27 2022

DavidTruby added reviewers for D118394: [AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP: peterwaller-arm, paulwalker-arm, bsmith, MattDevereau, sdesmalen.
Jan 27 2022, 9:42 AM · Restricted Project
DavidTruby requested review of D118394: [AArch64][NEON][SVE] Lower FCOPYSIGN using AArch64ISD::BSP.
Jan 27 2022, 9:41 AM · Restricted Project

Jan 26 2022

DavidTruby added inline comments to D118139: [AArch64][SVE][VLS] Move extends into arguments of comparisons.
Jan 26 2022, 7:34 AM · Restricted Project
DavidTruby updated the diff for D118139: [AArch64][SVE][VLS] Move extends into arguments of comparisons.

Use isSignedIntSetCC to check which extend to perform.
Add tests for signed and unsigned comparisons.

Jan 26 2022, 7:00 AM · Restricted Project

Jan 25 2022

DavidTruby abandoned D112536: [DAG] Add functionality for masked truncating store actions.

When we come around to doing this, it should be done sufficiently differently to this anyway, so abandoning for now.

Jan 25 2022, 6:51 AM · Restricted Project
DavidTruby updated the summary of D118139: [AArch64][SVE][VLS] Move extends into arguments of comparisons.
Jan 25 2022, 6:19 AM · Restricted Project
DavidTruby added reviewers for D118139: [AArch64][SVE][VLS] Move extends into arguments of comparisons: paulwalker-arm, peterwaller-arm, sdesmalen, bsmith, MattDevereau.
Jan 25 2022, 6:18 AM · Restricted Project
DavidTruby updated the diff for D118139: [AArch64][SVE][VLS] Move extends into arguments of comparisons.

Fix warnings related to switch statement.

Jan 25 2022, 6:17 AM · Restricted Project