Page MenuHomePhabricator

DavidTruby (David Truby)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 3 2018, 7:41 AM (79 w, 1 d)

Recent Activity

Yesterday

DavidTruby accepted D72416: [Flang] add flang as a new subproject in cmake.

LGTM

Wed, Apr 8, 10:18 AM · Restricted Project, Unknown Object (Project)

Mar 9 2020

DavidTruby added a comment to D72416: [Flang] add flang as a new subproject in cmake.

https://reviews.llvm.org/differential/diff/249126/ this works for me
Although I just spotted I've left an OR ${proj} in there which shouldn't be there. If you ignore that then it works!

Mar 9 2020, 9:41 AM · Restricted Project, Unknown Object (Project)
DavidTruby updated subscribers of D72416: [Flang] add flang as a new subproject in cmake.

@hfinkel suggested we make an LLVM_EXTRA_PROJECTS and add that to the logic to search for projects. I have a patch to do that, I'll just link it here when I work out how to!

Mar 9 2020, 9:09 AM · Restricted Project, Unknown Object (Project)
DavidTruby requested changes to D72416: [Flang] add flang as a new subproject in cmake.

This doesn't seem to be sufficient to build Flang for me. My process was as follows:

Mar 9 2020, 6:57 AM · Restricted Project, Unknown Object (Project)

Mar 4 2020

DavidTruby added a comment to D72416: [Flang] add flang as a new subproject in cmake.

My current plan is to add this as the first commit on top of the flang merge and push that all together. That way although there will be commits that don't build in the history (which is unavoidable) there won't actually be a time at which this causes build issues. Does that sound reasonable?

Mar 4 2020, 3:26 AM · Restricted Project, Unknown Object (Project)

Mar 2 2020

DavidTruby created D75451: [CMake] Install llvm-lit when LLVM_INSTALL_UTILS is enabled..
Mar 2 2020, 6:35 AM · Restricted Project

Feb 13 2020

DavidTruby accepted D73951: [Clang] [Driver]Add logic to search for flang frontend.

LGTM but wait for someone else to approve

Feb 13 2020, 5:31 AM · Restricted Project

Feb 4 2020

DavidTruby requested changes to D73951: [Clang] [Driver]Add logic to search for flang frontend.

If what I've suggested above doesn't work then the patch lgtm as is

Feb 4 2020, 7:00 AM · Restricted Project

Jan 29 2020

DavidTruby added a comment to D72400: [MLIR] Add OpenMP dialect with barrier operation.

I've committed and pushed this after fixing the nits, please revert if I misunderstood or if the discourse discussion decides this doesn't want to be here.
Thanks!

Jan 29 2020, 3:49 AM · Restricted Project
DavidTruby committed rG63c8972562a4: [MLIR] Add OpenMP dialect with barrier operation (authored by DavidTruby).
[MLIR] Add OpenMP dialect with barrier operation
Jan 29 2020, 3:40 AM
DavidTruby closed D72400: [MLIR] Add OpenMP dialect with barrier operation.
Jan 29 2020, 3:40 AM · Restricted Project

Jan 24 2020

Herald added a reviewer for D72400: [MLIR] Add OpenMP dialect with barrier operation: nicolasvasilache.

gentle ping

Jan 24 2020, 2:52 AM · Restricted Project

Jan 13 2020

DavidTruby updated the diff for D72400: [MLIR] Add OpenMP dialect with barrier operation.

Small corrections for review.

Jan 13 2020, 2:25 AM · Restricted Project

Jan 9 2020

DavidTruby added inline comments to D72400: [MLIR] Add OpenMP dialect with barrier operation.
Jan 9 2020, 2:29 AM · Restricted Project
DavidTruby updated the diff for D72400: [MLIR] Add OpenMP dialect with barrier operation.

Added top-level file comments.

Jan 9 2020, 2:26 AM · Restricted Project
DavidTruby updated the diff for D72400: [MLIR] Add OpenMP dialect with barrier operation.

Address various review comments

Jan 9 2020, 2:17 AM · Restricted Project

Jan 8 2020

DavidTruby updated the diff for D72400: [MLIR] Add OpenMP dialect with barrier operation.

Renamed openmp namespace to omp

Jan 8 2020, 8:18 AM · Restricted Project
DavidTruby added reviewers for D72400: [MLIR] Add OpenMP dialect with barrier operation: mehdi_amini, bondhugula.
Jan 8 2020, 7:21 AM · Restricted Project
DavidTruby retitled D72400: [MLIR] Add OpenMP dialect with barrier operation from Add OpenMP dialect with barrier operation to [MLIR] Add OpenMP dialect with barrier operation.
Jan 8 2020, 7:21 AM · Restricted Project
DavidTruby created D72400: [MLIR] Add OpenMP dialect with barrier operation.
Jan 8 2020, 7:12 AM · Restricted Project

Dec 23 2019

A. Unique TensorFlower <gardener@tensorflow.org> committed rG18aec3e2e5b6: Add OpenMP dialect to the dialect registry (authored by DavidTruby).
Add OpenMP dialect to the dialect registry
Dec 23 2019, 9:17 PM

Jul 11 2019

DavidTruby added a comment to D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions.

I don't have commit access so can't commit this myself, could you do it for me? Thanks

Jul 11 2019, 5:41 AM · Restricted Project, Restricted Project
DavidTruby updated the diff for D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions.

Moved common VarLVal initialisation out of the if/else statement

Jul 11 2019, 5:30 AM · Restricted Project, Restricted Project
DavidTruby created D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions.
Jul 11 2019, 5:02 AM · Restricted Project, Restricted Project

Oct 3 2018

DavidTruby added a comment to D51107: [LIBOMPTARGET] Add support for mapping of lambda captures..

Sorry, I've only just become aware of this discussion,
I had already implemented the lambda mapping change in the clang-ykt branch (and for that I did use MEMBER_OF and PTR_AND_OBJ which worked as expected).
Could we possibly reuse (some of?) that implementation?
I've tested that on a few different applications and it works quite well.
I'm not that familiar with the difference between clang-ykt and upstream so it's probable that I'm missing something.

Oct 3 2018, 7:48 AM