Page MenuHomePhabricator

fpetrogalli (Francesco Petrogalli)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 12 2016, 4:50 AM (235 w, 6 d)

Recent Activity

Nov 27 2020

fpetrogalli updated the diff for D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize.

Reverted getFragmentSizeInBits to return an integral type and not TypeSize, because scalable variables cannot be part of structs/arrays - hence they cannot be pointed by fragments.

Nov 27 2020, 9:40 AM · Restricted Project, Restricted Project
fpetrogalli committed rG8e0148dff703: [AllocaInst] Update `getAllocationSizeInBits` to return `TypeSize`. (authored by fpetrogalli).
[AllocaInst] Update `getAllocationSizeInBits` to return `TypeSize`.
Nov 27 2020, 8:41 AM
fpetrogalli closed D92020: [AllocaInst] Update `getAllocationSizeInBits` to return `TypeSize`..
Nov 27 2020, 8:41 AM · Restricted Project
fpetrogalli updated the diff for D92096: [SelectionDAGBuilder] Update signature of `getRegsAndSizes()`..

NFC. Rename declare in test.

Nov 27 2020, 8:31 AM · Restricted Project
fpetrogalli added inline comments to D92020: [AllocaInst] Update `getAllocationSizeInBits` to return `TypeSize`..
Nov 27 2020, 3:23 AM · Restricted Project
fpetrogalli updated the diff for D92020: [AllocaInst] Update `getAllocationSizeInBits` to return `TypeSize`..

I reverted the return type of the lambda function to be integral type instead of TypeSize.

Nov 27 2020, 3:23 AM · Restricted Project
fpetrogalli updated the diff for D92096: [SelectionDAGBuilder] Update signature of `getRegsAndSizes()`..

NFC: fix code formatting.

Nov 27 2020, 2:27 AM · Restricted Project
fpetrogalli added inline comments to D92096: [SelectionDAGBuilder] Update signature of `getRegsAndSizes()`..
Nov 27 2020, 1:39 AM · Restricted Project
fpetrogalli updated the diff for D92096: [SelectionDAGBuilder] Update signature of `getRegsAndSizes()`..

Rename test file. NFC.

Nov 27 2020, 1:37 AM · Restricted Project

Nov 25 2020

fpetrogalli updated the diff for D92096: [SelectionDAGBuilder] Update signature of `getRegsAndSizes()`..

Fix formatting in test. NFC

Nov 25 2020, 6:03 AM · Restricted Project
fpetrogalli added a reviewer for D92096: [SelectionDAGBuilder] Update signature of `getRegsAndSizes()`.: arsenm.
Nov 25 2020, 6:00 AM · Restricted Project
fpetrogalli requested review of D92096: [SelectionDAGBuilder] Update signature of `getRegsAndSizes()`..
Nov 25 2020, 5:58 AM · Restricted Project
fpetrogalli committed rGe592dde6889b: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`. (authored by fpetrogalli).
[clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`.
Nov 25 2020, 2:18 AM
fpetrogalli closed D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`..
Nov 25 2020, 2:17 AM · Restricted Project

Nov 24 2020

fpetrogalli added a comment to D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize.

I have extracted D92020 to implement only the change of interface for AllocaInst::getAllocationSizeInBits.

Nov 24 2020, 6:37 AM · Restricted Project, Restricted Project
fpetrogalli updated the summary of D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize.
Nov 24 2020, 6:16 AM · Restricted Project, Restricted Project
fpetrogalli updated the diff for D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize.

Add comment to DbgVariableIntrinsic::getFragmentSizeInBits(). NFC

Nov 24 2020, 6:15 AM · Restricted Project, Restricted Project
fpetrogalli updated the diff for D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize.

Rebase on top of D92020. NFC.

Nov 24 2020, 3:42 AM · Restricted Project, Restricted Project
fpetrogalli requested review of D92020: [AllocaInst] Update `getAllocationSizeInBits` to return `TypeSize`..
Nov 24 2020, 3:37 AM · Restricted Project

Nov 20 2020

fpetrogalli added inline comments to D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize.
Nov 20 2020, 9:33 AM · Restricted Project, Restricted Project
fpetrogalli updated the diff for D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize.

I have added assertions around before TypeSize comparisons where it made sense to do so, but not in the lambda used in the sort invocation.

Nov 20 2020, 9:32 AM · Restricted Project, Restricted Project
fpetrogalli added a comment to D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize.

Thank you for the review @sdesmalen

Nov 20 2020, 8:39 AM · Restricted Project, Restricted Project
fpetrogalli retitled D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize from [SVE] Remove warnings from release notes example on SVE ACLE. to [SVE] Remove warning from debug info on scalable vector..
Nov 20 2020, 7:04 AM · Restricted Project, Restricted Project
fpetrogalli updated the diff for D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize.

I have removed the C test, as the LL test is enough to test the changes I have done in Local.cpp.

Nov 20 2020, 7:00 AM · Restricted Project, Restricted Project
fpetrogalli updated the diff for D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize.

This last change is trying to remove the failure at https://reviews.llvm.org/harbormaster/unit/view/196974/
I haven’t been able to reproduce such failure on my dev machine, so I just changed the RUN lines in the test (added -c, used 2>%t) to see if the bot is going to be happy with the new invocation.

Nov 20 2020, 3:19 AM · Restricted Project, Restricted Project
fpetrogalli added a comment to D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize.

FYI: I am trying to figure out this failure that does not appear on my machine: https://reviews.llvm.org/harbormaster/unit/view/196974/

Nov 20 2020, 2:44 AM · Restricted Project, Restricted Project
fpetrogalli updated the diff for D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize.

I updated the RUN lines of the .ll test to prevent the failure at https://reviews.llvm.org/harbormaster/unit/view/196899/.

Nov 20 2020, 1:56 AM · Restricted Project, Restricted Project

Nov 19 2020

fpetrogalli requested review of D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize.
Nov 19 2020, 10:10 AM · Restricted Project, Restricted Project

Nov 18 2020

fpetrogalli accepted D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors.

This LGTM. May I ask to extend the commit message to add a reference to the paragraph in section "3.7.3.3", item 2 on page 23 of the specs version 00bet6?

Nov 18 2020, 4:46 AM · Restricted Project

Nov 17 2020

fpetrogalli accepted D91642: [AArch64][SVE] Add tests for VLST -> VLAT lax conversions.

HI @joechrisellis - thank you. This LGTM.

Nov 17 2020, 9:36 AM · Restricted Project
fpetrogalli planned changes to D90162: [llvm][AArch64] Prevent spurious zero extension..

Parking this for the moment, as we need to refine the heuristic to decide when to prevent the spurious zero extension.

Nov 17 2020, 5:22 AM · Restricted Project

Nov 16 2020

fpetrogalli committed rG02bdbdc76021: [clang][SveEmitter] Fix enum declarations. [NFCI] (authored by fpetrogalli).
[clang][SveEmitter] Fix enum declarations. [NFCI]
Nov 16 2020, 6:51 AM
fpetrogalli closed D91333: [clang][SveEmitter] Fix enum declarations. [NFCI].
Nov 16 2020, 6:50 AM · Restricted Project

Nov 12 2020

fpetrogalli updated the diff for D91333: [clang][SveEmitter] Fix enum declarations. [NFCI].

Improve comment in test.

Nov 12 2020, 12:50 PM · Restricted Project
fpetrogalli requested review of D91333: [clang][SveEmitter] Fix enum declarations. [NFCI].
Nov 12 2020, 3:25 AM · Restricted Project

Nov 11 2020

fpetrogalli added inline comments to D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors.
Nov 11 2020, 8:37 AM · Restricted Project
fpetrogalli added a reviewer for D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`.: rsandifo-arm.
Nov 11 2020, 7:08 AM · Restricted Project
fpetrogalli added a comment to D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`..

@rengolin - thank you for looking into this. The patch has changed quite a bit since you approved it (faulty codegen for one of the macros, which I have removed from this patch). You might want to re-look at it.

Nov 11 2020, 5:13 AM · Restricted Project
fpetrogalli accepted D91067: [AArch64][SVE] Support implicit lax vector conversions for SVE types.

Thank you @joechrisellis - LGTM!

Nov 11 2020, 5:09 AM · Restricted Project
fpetrogalli updated the diff for D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`..

I have added more test coverage for the codegen of the examples mentioned in section 3.7.3.3 of the SVE ACLE. The tests are generic to work for -msve-vector-bits=128|...|2048.

Nov 11 2020, 4:09 AM · Restricted Project

Nov 10 2020

fpetrogalli added a comment to D91067: [AArch64][SVE] Support implicit lax vector conversions for SVE types.

Hi @joechrisellis - thank you for this patch!

Nov 10 2020, 8:29 AM · Restricted Project

Nov 9 2020

fpetrogalli committed rG9f61931e077d: [llvm][AArch64] Allow TB(N)Z to drop signext for sign bit tests. (authored by fpetrogalli).
[llvm][AArch64] Allow TB(N)Z to drop signext for sign bit tests.
Nov 9 2020, 10:27 AM
fpetrogalli closed D90606: [llvm][AArch64] Allow TB(N)Z to drop signext for sign bit tests..
Nov 9 2020, 10:27 AM · Restricted Project
fpetrogalli updated the diff for D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`..

In the last update I removed the tests for __ARM_FEATURE_SVE_PREDICATE_OPERATORSbut forgot to remove the code that generates and tests the macro.

Nov 9 2020, 9:53 AM · Restricted Project
fpetrogalli retitled D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`. from [clang][SVE] Additional macros implied by `-msve-vector-bits=<N>`. to [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`..
Nov 9 2020, 9:49 AM · Restricted Project
fpetrogalli updated the diff for D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`..

I removed the enablement of __ARM_FEATURE_SVE_PREDICATE_OPERATORS as the codegen is incorrect.

Nov 9 2020, 9:47 AM · Restricted Project
fpetrogalli accepted D90685: [SVE][AArch64] Improve specificity of vectorization legality TypeSize test.

LGTM, thanks for explaining!

Nov 9 2020, 7:17 AM · Restricted Project
fpetrogalli updated the summary of D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`..
Nov 9 2020, 5:41 AM · Restricted Project
fpetrogalli added a comment to D90685: [SVE][AArch64] Improve specificity of vectorization legality TypeSize test.

LGTM - but can you explain in the commit why you are doing this? In particular, can you state that the test case still fails without the fix that removed the warning?

Nov 9 2020, 5:33 AM · Restricted Project
fpetrogalli committed rGfc2fe6817e19: [llvm][AArch64] Simplify (and (sign_extend..) #bitmask). (authored by fpetrogalli).
[llvm][AArch64] Simplify (and (sign_extend..) #bitmask).
Nov 9 2020, 4:53 AM
fpetrogalli closed D90605: [llvm][AArch64] Simplify (and (sign_extend..) #bitmask)..
Nov 9 2020, 4:53 AM · Restricted Project
fpetrogalli updated the diff for D90605: [llvm][AArch64] Simplify (and (sign_extend..) #bitmask)..

NFC: rebase on top of master.

Nov 9 2020, 3:37 AM · Restricted Project
fpetrogalli updated the diff for D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`..

NFC: update tests to use %clang_cc1 instead of %clang to prevent errors for missing includes: https://reviews.llvm.org/B77907

Nov 9 2020, 3:04 AM · Restricted Project

Nov 6 2020

fpetrogalli requested review of D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`..
Nov 6 2020, 9:24 AM · Restricted Project

Nov 3 2020

fpetrogalli updated the diff for D90606: [llvm][AArch64] Allow TB(N)Z to drop signext for sign bit tests..

Fix typo in comment.

Nov 3 2020, 5:58 AM · Restricted Project
fpetrogalli retitled D90606: [llvm][AArch64] Allow TB(N)Z to drop signext for sign bit tests. from [llvm][AArch64] Check the sign bit of a sign extended value before sign extension. to [llvm][AArch64] Allow TB(N)Z to drop signext for sign bit tests..
Nov 3 2020, 5:34 AM · Restricted Project
fpetrogalli updated the diff for D90605: [llvm][AArch64] Simplify (and (sign_extend..) #bitmask)..

Thank you for your review @resistor. I simplified the logic in the
lambda function as suggested in your comment.

Nov 3 2020, 4:58 AM · Restricted Project
fpetrogalli updated the diff for D90606: [llvm][AArch64] Allow TB(N)Z to drop signext for sign bit tests..

Thank you for the review @resistor. I have implememted the
optimization also looking through a sign_extend node. Tests to cover
this have been added, but only for extending i32 into i64 because
illegal values like i8 are always sign extended inreg.

Nov 3 2020, 2:22 AM · Restricted Project

Nov 2 2020

fpetrogalli added inline comments to D90162: [llvm][AArch64] Prevent spurious zero extension..
Nov 2 2020, 8:00 AM · Restricted Project
fpetrogalli updated the summary of D90162: [llvm][AArch64] Prevent spurious zero extension..
Nov 2 2020, 6:45 AM · Restricted Project
fpetrogalli requested review of D90606: [llvm][AArch64] Allow TB(N)Z to drop signext for sign bit tests..
Nov 2 2020, 6:02 AM · Restricted Project
fpetrogalli requested review of D90605: [llvm][AArch64] Simplify (and (sign_extend..) #bitmask)..
Nov 2 2020, 6:01 AM · Restricted Project
fpetrogalli updated the diff for D90162: [llvm][AArch64] Prevent spurious zero extension..

Updating the patch after splitting it in three patches. I'll link the remeining here after publishing them.

Nov 2 2020, 5:59 AM · Restricted Project

Oct 29 2020

fpetrogalli added inline comments to D90162: [llvm][AArch64] Prevent spurious zero extension..
Oct 29 2020, 11:13 AM · Restricted Project
fpetrogalli updated the diff for D90162: [llvm][AArch64] Prevent spurious zero extension..

s/Mask/SignBitPos/ in the code I changed. Revert the change in a place were Mask was accidentally renamed.

Oct 29 2020, 11:08 AM · Restricted Project
fpetrogalli updated the diff for D90162: [llvm][AArch64] Prevent spurious zero extension..
  1. fixed typo
  2. described tests
Oct 29 2020, 11:03 AM · Restricted Project
fpetrogalli accepted D88233: [clang][aarch64] Address various fixed-length SVE vector operations.

LGTM, thank you!

Oct 29 2020, 10:31 AM · Restricted Project
fpetrogalli updated the diff for D90162: [llvm][AArch64] Prevent spurious zero extension..

I have addressed the comment from @samparker about making the check in
UsesDifferInSignExtension independent on the order of the uses. The
code now uses llvm::any_of on all uses.

Oct 29 2020, 9:22 AM · Restricted Project
fpetrogalli updated the summary of D90162: [llvm][AArch64] Prevent spurious zero extension..
Oct 29 2020, 9:15 AM · Restricted Project

Oct 28 2020

fpetrogalli updated the diff for D90162: [llvm][AArch64] Prevent spurious zero extension..

Address all review comments but one (still working on the version of UsesDifferInSignExtension that doesn't care about the order of the uses).

Oct 28 2020, 8:28 AM · Restricted Project
fpetrogalli retitled D90162: [llvm][AArch64] Prevent spurious zero extension. from [llvm][AArch64] Prevent spurious zero extention. to [llvm][AArch64] Prevent spurious zero extension..
Oct 28 2020, 8:27 AM · Restricted Project
fpetrogalli added inline comments to D90162: [llvm][AArch64] Prevent spurious zero extension..
Oct 28 2020, 8:27 AM · Restricted Project
fpetrogalli added a comment to D88233: [clang][aarch64] Address various fixed-length SVE vector operations.

Hi @c-rhodes, Peter asked me to take a look at this. LGTM, I only have minor stuff.

Oct 28 2020, 6:59 AM · Restricted Project
fpetrogalli added inline comments to D90162: [llvm][AArch64] Prevent spurious zero extension..
Oct 28 2020, 3:36 AM · Restricted Project
fpetrogalli updated the diff for D90162: [llvm][AArch64] Prevent spurious zero extension..

I have removed the method SelectionDAG::isZeroExtendInReg in favour of using the machinery already available in DAGCombiner.

Oct 28 2020, 3:36 AM · Restricted Project

Oct 27 2020

fpetrogalli added reviewers for D90162: [llvm][AArch64] Prevent spurious zero extension.: samparker, spatel.
Oct 27 2020, 3:14 AM · Restricted Project

Oct 26 2020

fpetrogalli updated the summary of D90162: [llvm][AArch64] Prevent spurious zero extension..
Oct 26 2020, 8:43 AM · Restricted Project
fpetrogalli requested review of D90162: [llvm][AArch64] Prevent spurious zero extension..
Oct 26 2020, 8:39 AM · Restricted Project

Oct 23 2020

fpetrogalli accepted D89968: [SVE][InstCombine] Fix TypeSize warning in canReplaceGEPIdxWithZero.

LGTM! Thanks.

Oct 23 2020, 6:22 AM · Restricted Project

Oct 22 2020

fpetrogalli accepted D89872: [SVE][AArch64] Fix TypeSize warning in GEP cost analysis.
Oct 22 2020, 12:53 AM · Restricted Project

Oct 21 2020

fpetrogalli added inline comments to D89872: [SVE][AArch64] Fix TypeSize warning in GEP cost analysis.
Oct 21 2020, 8:40 AM · Restricted Project
fpetrogalli added inline comments to D89872: [SVE][AArch64] Fix TypeSize warning in GEP cost analysis.
Oct 21 2020, 7:53 AM · Restricted Project

Oct 16 2020

fpetrogalli added a comment to D88154: Initial support for vectorization using Libmvec (GLIBC vector math library)..

LGTM from the perspective of making sure that this solution can be extended to any of the architectures that libmvec supports.

Oct 16 2020, 6:23 AM · Restricted Project, Restricted Project

Oct 13 2020

fpetrogalli added a comment to D88154: Initial support for vectorization using Libmvec (GLIBC vector math library)..

Thank you for modifying the implementation to facilitate the extension to other targets.

Oct 13 2020, 4:19 AM · Restricted Project, Restricted Project

Oct 8 2020

fpetrogalli added inline comments to D88154: Initial support for vectorization using Libmvec (GLIBC vector math library)..
Oct 8 2020, 7:17 AM · Restricted Project, Restricted Project
fpetrogalli added inline comments to D88154: Initial support for vectorization using Libmvec (GLIBC vector math library)..
Oct 8 2020, 1:47 AM · Restricted Project, Restricted Project

Sep 16 2020

fpetrogalli committed rG15e9a6c2118f: [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on… (authored by fpetrogalli).
[llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on…
Sep 16 2020, 9:03 AM
fpetrogalli closed D86249: [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on scalable vectors..
Sep 16 2020, 9:03 AM · Restricted Project
fpetrogalli updated the diff for D86249: [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on scalable vectors..

Fix typo.

Sep 16 2020, 8:57 AM · Restricted Project

Sep 14 2020

fpetrogalli added a reviewer for D86249: [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on scalable vectors.: sdesmalen.
Sep 14 2020, 3:20 AM · Restricted Project

Sep 11 2020

fpetrogalli updated the diff for D86249: [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on scalable vectors..

@sdesmalen - I have moved the check outside the switch statement as discussed in our phone call.

Sep 11 2020, 4:45 AM · Restricted Project

Sep 7 2020

fpetrogalli retitled D86249: [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on scalable vectors. from [llvm][sve] Make `llvm.masked.[gather|scatter]` legal for SVE. to [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on scalable vectors..
Sep 7 2020, 8:43 AM · Restricted Project
fpetrogalli added inline comments to D86249: [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on scalable vectors..
Sep 7 2020, 8:15 AM · Restricted Project

Aug 28 2020

fpetrogalli added inline comments to D86249: [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on scalable vectors..
Aug 28 2020, 12:42 PM · Restricted Project
fpetrogalli accepted D78127: [SVE] Mark VectorType::getNumElements() deprecated.

Nit: there is a typo in the commit message: whre -> where.

Aug 28 2020, 12:25 PM · Restricted Project

Aug 26 2020

fpetrogalli committed rG61dfa009579f: [MC][SVE] Fix data operand for instruction alias of `st1d`. (authored by fpetrogalli).
[MC][SVE] Fix data operand for instruction alias of `st1d`.
Aug 26 2020, 11:23 AM
fpetrogalli closed D86633: [MC][SVE] Fix data operand for instruction alias of `st1d`..
Aug 26 2020, 11:23 AM · Restricted Project
fpetrogalli updated the summary of D86633: [MC][SVE] Fix data operand for instruction alias of `st1d`..
Aug 26 2020, 10:21 AM · Restricted Project
fpetrogalli updated the diff for D86633: [MC][SVE] Fix data operand for instruction alias of `st1d`..

I have added test coverage for st1[bhwd] for both .s and .d version of the alias for [<Za>.<T>, #0].

Aug 26 2020, 10:19 AM · Restricted Project
fpetrogalli requested review of D86633: [MC][SVE] Fix data operand for instruction alias of `st1d`..
Aug 26 2020, 8:57 AM · Restricted Project