fpetrogalli (Francesco Petrogalli)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 12 2016, 4:50 AM (49 w, 2 d)

Recent Activity

Fri, Sep 1

fpetrogalli added inline comments to D22792: VecClone Pass.
Fri, Sep 1, 3:46 AM
fpetrogalli added a comment to D22792: VecClone Pass.

Hello again,

Fri, Sep 1, 3:34 AM
fpetrogalli added inline comments to D22792: VecClone Pass.
Fri, Sep 1, 3:15 AM

Tue, Aug 29

fpetrogalli accepted D37064: [InstCombine] Fold insert sequence if first ins has multiple users..

This LGTM now.

Tue, Aug 29, 3:41 AM

Thu, Aug 24

fpetrogalli added inline comments to D37064: [InstCombine] Fold insert sequence if first ins has multiple users..
Thu, Aug 24, 2:25 AM

Apr 7 2017

fpetrogalli added a comment to D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD..

thank you for reviewing this. If you don't mind, I will wait applying the changes you requested, Unfortunately I am not ready yet to send out an update as I am still working on the vector ABI. I will ping you when ready.

Apr 7 2017, 1:23 AM

Mar 28 2017

fpetrogalli added a comment to D31417: [OpenMP] Add support for omp simd pragmas without runtime.

Hi Graham,

Mar 28 2017, 4:43 AM

Mar 23 2017

fpetrogalli planned changes to D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD..

Dear all,

Mar 23 2017, 10:29 AM

Mar 21 2017

fpetrogalli added a comment to D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD..

Thanks, I do not have commit rights, can anyone commit this?

Mar 21 2017, 6:23 AM
fpetrogalli added a comment to D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD..

In principal looks good to me although I'm not really familiar with this part. Does that work for you if you have the declare simd in a header file and the implementation in another file? On x86_64 I currently get:

Mar 21 2017, 6:13 AM

Mar 15 2017

fpetrogalli added inline comments to D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD..
Mar 15 2017, 6:46 AM
fpetrogalli added a comment to D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD..

Gentle ping.

Mar 15 2017, 6:25 AM
fpetrogalli updated subscribers of D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD..
Mar 15 2017, 6:24 AM

Mar 14 2017

fpetrogalli added a comment to D30897: [WIP] New AsmPrinterHandler that is able to interleave source code.

Hi Roger,

Mar 14 2017, 2:09 AM

Mar 8 2017

fpetrogalli updated the diff for D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD..
  • fixed formatting;
  • added two tests that were missing.
Mar 8 2017, 9:32 AM
fpetrogalli updated the summary of D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD..
Mar 8 2017, 8:19 AM
fpetrogalli created D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD..
Mar 8 2017, 8:15 AM

Jan 23 2017

fpetrogalli added a comment to D27249: [LoopVectorize] Use OpenMP vector routines..

All, as we discussed, we agree to follow the GCC VectorABI and be GCC VectorABI compatible, right? It could be happened, I am looking at an old patch. Thanks.

Jan 23 2017, 7:10 AM
fpetrogalli updated the diff for D27249: [LoopVectorize] Use OpenMP vector routines..

This is just a rebase with a recent llvm codebase.

Jan 23 2017, 6:50 AM
fpetrogalli updated the diff for D27250: [OpenMP] TargetLibraryInfo from "declare simd"..

I have updated the patch to use the name mangling scheme we agreed - compatible with the GCC name mangling scheme.

Jan 23 2017, 6:49 AM

Dec 12 2016

fpetrogalli updated the diff for D27250: [OpenMP] TargetLibraryInfo from "declare simd"..

I have updated the name mangling of the associated vector function.

Dec 12 2016, 5:39 AM
fpetrogalli updated the diff for D27249: [LoopVectorize] Use OpenMP vector routines..
  1. rebase
  2. Fix bug in copy constructor of the TargetLibraryInfoImpl class - I have missed copying out the multimap needed in the algorithm
  3. Fix bug in the TLII::mangle method (now it returns a std::string instead of a StringRef)
Dec 12 2016, 5:32 AM

Dec 9 2016

fpetrogalli added a comment to D27249: [LoopVectorize] Use OpenMP vector routines..

I have removed all reviewers, this is not intended for code review.

Dec 9 2016, 7:13 AM
fpetrogalli added a comment to D27250: [OpenMP] TargetLibraryInfo from "declare simd"..

I have removed all reviewer, this is not intended for code review.

Dec 9 2016, 7:12 AM
fpetrogalli removed reviewers for D27250: [OpenMP] TargetLibraryInfo from "declare simd".: ABataev, hfinkel, cfe-commits.
Dec 9 2016, 7:11 AM
fpetrogalli removed reviewers for D27249: [LoopVectorize] Use OpenMP vector routines.: mzolotukhin, hfinkel, llvm-commits.
Dec 9 2016, 6:56 AM

Dec 5 2016

fpetrogalli added a comment to D27249: [LoopVectorize] Use OpenMP vector routines..

Just a high level question: why can't this extend the same insert mechanism we already use for the other vectorised functions, instead of creating a new one for OpenMP?

Dec 5 2016, 2:49 AM

Nov 30 2016

fpetrogalli added a comment to D27250: [OpenMP] TargetLibraryInfo from "declare simd"..

You did just some minor changes. The main questions are still unanswered.

Nov 30 2016, 7:41 AM
fpetrogalli added a comment to D27250: [OpenMP] TargetLibraryInfo from "declare simd"..
Nov 30 2016, 7:41 AM
fpetrogalli added a comment to D27250: [OpenMP] TargetLibraryInfo from "declare simd"..

I updated the comments related to code formatting.

Nov 30 2016, 7:05 AM
fpetrogalli updated the diff for D27249: [LoopVectorize] Use OpenMP vector routines..

Rebase plus clang format.

Nov 30 2016, 7:01 AM
fpetrogalli updated the diff for D27250: [OpenMP] TargetLibraryInfo from "declare simd"..

Rebase plus apply clang format.

Nov 30 2016, 6:57 AM
fpetrogalli added a comment to D27256: [ARM] Add ARM contributions agreement..

If that's there already, why add a new one on the root of the project?

Nov 30 2016, 4:57 AM
fpetrogalli added a comment to D27256: [ARM] Add ARM contributions agreement..

Er, will we need one of those per company? Odd...

Nov 30 2016, 4:33 AM
fpetrogalli retitled D27256: [ARM] Add ARM contributions agreement. from to [ARM] Add ARM contributions agreement..
Nov 30 2016, 4:10 AM
fpetrogalli added reviewers for D27249: [LoopVectorize] Use OpenMP vector routines.: hfinkel, mzolotukhin.
Nov 30 2016, 3:39 AM
fpetrogalli updated subscribers of D27249: [LoopVectorize] Use OpenMP vector routines..
Nov 30 2016, 2:32 AM
fpetrogalli added reviewers for D27250: [OpenMP] TargetLibraryInfo from "declare simd".: ABataev, hfinkel.
Nov 30 2016, 2:30 AM
fpetrogalli retitled D27250: [OpenMP] TargetLibraryInfo from "declare simd". from to [OpenMP] TargetLibraryInfo from "declare simd"..
Nov 30 2016, 2:21 AM
fpetrogalli added a reviewer for D27249: [LoopVectorize] Use OpenMP vector routines.: llvm-commits.
Nov 30 2016, 2:15 AM
fpetrogalli retitled D27249: [LoopVectorize] Use OpenMP vector routines. from to [LoopVectorize] Use OpenMP vector routines..
Nov 30 2016, 1:53 AM

Oct 12 2016

fpetrogalli added a comment to D24951: Import/adapt the SLEEF vector math-function library as an LLVM runtime.

The library name has been updated to be vmath. The function names now all look like:

__llvm_<func>_<type>[_<abi>]

So, for example, for sin the library contains on my x86_64 system:

__llvm_sin_f64
__llvm_sin_u1_f64
__llvm_sin_f32
__llvm_sin_u1_f32
__llvm_sin_u1_v2f64_sse2
__llvm_sin_v2f64_sse2
__llvm_sin_u1_v4f32_sse2
__llvm_sin_v4f32_sse2
__llvm_sin_u1_v4f64_avx
__llvm_sin_v4f64_avx
__llvm_sin_u1_v8f32_avx
__llvm_sin_v8f32_avx
__llvm_sin_u1_v4f64_avx2
__llvm_sin_v4f64_avx2
__llvm_sin_u1_v8f32_avx2
__llvm_sin_v8f32_avx2
Oct 12 2016, 4:55 AM