- User Since
- Oct 12 2016, 4:50 AM (170 w, 3 d)
I have rephrased the first paragraph to avoid mentioning the the term scalar function.
Thu, Jan 16
Update text according to review.
Wed, Jan 15
I have removed the LangRef changes. I'll create a separate patch for that.
Tue, Jan 14
Reworked in https://reviews.llvm.org/D72734
@uabelho , let me know if the introduction of isTLIScalarize prevents the regressions you have seen in your out-of-tree compiler.
Mon, Jan 13
I am working on a solution for the problem you reported.
Dec 13 2019
Dec 12 2019
Dec 11 2019
Dec 10 2019
Dec 9 2019
Dec 6 2019
Dec 5 2019
Dec 4 2019
Address review comments from @ABataev.
Gentle ping after the merge of https://reviews.llvm.org/D70513.
Address review comments from @sdesmalen.
Allow GlobalPredicate parameters in any position of the signature.
Dec 2 2019
Nov 22 2019
Nov 21 2019
I have addressed the comments (some of the changes relative to the VFShape API are reflected in https://reviews.llvm.org/D70513).
Update (and rename) the get method to use ElementCount instead of VF
and IsScalable separately.
Nov 20 2019
In this update I have removed empty statements in the tests. (facepalm)
In this last update I have:
In this patch I have achieved better unit tests granularity by moving
the EXPECT_* macros from the test fixture class into the actual
test, so that in case of failure the log message points at the right
line in the code (otherwise it always points at the EXPECT_* in the
method used to run the check in the class definition of the test
Fully implement and test the API.
Remove commented code...
I have optimized the getVFABIMappings method of VFDatabase with an
early exit if the VFABI attribute is empty.
Address review comments from @sdesmalen. Thank you!
Nov 18 2019
In this patch:
Nov 15 2019
Down to two failures.
I have rebased the changes after the addition of the pass for injecting the TLI calls.
Update according to last round of review from @jdoerfert.
Nov 14 2019
Address last round of reviews.
Nov 13 2019
Self approving a NFC, as suggested in https://reviews.llvm.org/D70107#inline-632467
Thank you all for the review. The pass is now fuctional, working for
the libraries supported by the TLI: SVML, Accelerate and MASSV.
Nov 12 2019
This is an update in which I have tried to add the legacy pass manager.
Cosmetic changes to comments and commit message. [NFC]
I have updated the way we represent the token for the internal name ISA used by LLVM. The token is used only in a VFABI context, so I moved it in the VFABI namespace. In there, the name can be simplified to _LLVM_ as the VFABI namespace specializes the name already.
I have changed LLVM_VF to LLVM in the VFISAKind enum class.
Nov 11 2019
This patch is not functional yet, but I have added it here to show in the test what I intend to do.
Internal vector function mangling for TLI added at https://reviews.llvm.org/D70089