- User Since
- Oct 12 2016, 4:50 AM (180 w, 6 d)
Rebase on top of master.
Fri, Mar 27
Rebasing on top of master. [NFC]
Fixed the typo in the comment.
I have further simplified the code according to your comments.
Thu, Mar 26
Last but not least, I have renamed [Src|Dst]Length into [Src|Dst]EC as the variables now hold ElementCount and not unsigned.
thank you for your review!
Wed, Mar 25
I have updated the whole method CastInst::castISValid to correctly
support scalable vectors.
Tue, Mar 24
I removed an instance of the isNonZero method, as the patch relates
only to the isZero method. I'll create a separate patch for that.
Thu, Mar 19
I think that in this patch we are missing tests that check the output code in situations in which the tuple.get operates on tuple that are passed to the definition of the function, as in the following example:
Thank you @andwar , this makes totally sense to me. Ship it!
Wed, Mar 18
Tue, Mar 17
Cosmetic changes to the formatting of the codegen pattern defs. NFC
I have added CHECK-NEXT where needed.
Thank you for your review @andwar.
Mon, Mar 16
thank you for working on this. I am basing the addressing mode optimization for ldN on this patch, I just wanted to point out a couple of minor remarks!
Thank you for the review @andwar !
Remove unused parameter from test case, and remove empty line.
Sun, Mar 15
Fri, Mar 13
I have reorder the operands as requested by @sdesmalen.
Thu, Mar 12
Thank you for your reviews.
Wed, Mar 11
Tue, Mar 10
Mon, Mar 9
Wed, Mar 4
Tue, Mar 3
this patch is breaking shared libs builds (cmake path/to/llvm -DBUILD_SHARED_LIBS=ON).
Mon, Mar 2
LGTM, thank you @huntergr !
Feb 28 2020
As @pjeeva01 said, I need to add a test to see if the vectorized function is called in presence of the vector library option.
My bad, vectorization is what needs to be tested, not the generation of the attribute.
Hi @masoud.ataei , thank you for taking care of this.
Feb 25 2020
Hello @nemanjai , thank you for the exhaustive explanation.
Feb 24 2020
Feb 21 2020
thank you for working on this.
Hi @thegameg, this commit is breaking the shared libs builds. Could you please make sure you code works when configuring with -DBUILD_SHARED_LIBS=On?
Address code review from @sdesmalen.
Update code as requested by @sdesmalen.
thank you for updating the code.
Hi @andwar, I have updated the comments. I have also fixed the sve-gep.ll test, as the changes in the combiner are now folding the multiplying constant inside the vscale node.
LGTM, thank you @fhahn !
Hi @nemanjai , thank you for pointing this out! I didn't realize that my code was creating this problem.