Page MenuHomePhabricator

fpetrogalli (Francesco Petrogalli)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 12 2016, 4:50 AM (205 w, 4 d)

Recent Activity

Wed, Sep 16

fpetrogalli committed rG15e9a6c2118f: [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on… (authored by fpetrogalli).
[llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on…
Wed, Sep 16, 9:03 AM
fpetrogalli closed D86249: [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on scalable vectors..
Wed, Sep 16, 9:03 AM · Restricted Project
fpetrogalli updated the diff for D86249: [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on scalable vectors..

Fix typo.

Wed, Sep 16, 8:57 AM · Restricted Project

Mon, Sep 14

fpetrogalli added a reviewer for D86249: [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on scalable vectors.: sdesmalen.
Mon, Sep 14, 3:20 AM · Restricted Project

Fri, Sep 11

fpetrogalli updated the diff for D86249: [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on scalable vectors..

@sdesmalen - I have moved the check outside the switch statement as discussed in our phone call.

Fri, Sep 11, 4:45 AM · Restricted Project

Mon, Sep 7

fpetrogalli retitled D86249: [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on scalable vectors. from [llvm][sve] Make `llvm.masked.[gather|scatter]` legal for SVE. to [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on scalable vectors..
Mon, Sep 7, 8:43 AM · Restricted Project
fpetrogalli added inline comments to D86249: [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on scalable vectors..
Mon, Sep 7, 8:15 AM · Restricted Project

Fri, Aug 28

fpetrogalli added inline comments to D86249: [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on scalable vectors..
Fri, Aug 28, 12:42 PM · Restricted Project
fpetrogalli accepted D78127: [SVE] Mark VectorType::getNumElements() deprecated.

Nit: there is a typo in the commit message: whre -> where.

Fri, Aug 28, 12:25 PM · Restricted Project

Wed, Aug 26

fpetrogalli committed rG61dfa009579f: [MC][SVE] Fix data operand for instruction alias of `st1d`. (authored by fpetrogalli).
[MC][SVE] Fix data operand for instruction alias of `st1d`.
Wed, Aug 26, 11:23 AM
fpetrogalli closed D86633: [MC][SVE] Fix data operand for instruction alias of `st1d`..
Wed, Aug 26, 11:23 AM · Restricted Project
fpetrogalli updated the summary of D86633: [MC][SVE] Fix data operand for instruction alias of `st1d`..
Wed, Aug 26, 10:21 AM · Restricted Project
fpetrogalli updated the diff for D86633: [MC][SVE] Fix data operand for instruction alias of `st1d`..

I have added test coverage for st1[bhwd] for both .s and .d version of the alias for [<Za>.<T>, #0].

Wed, Aug 26, 10:19 AM · Restricted Project
fpetrogalli requested review of D86633: [MC][SVE] Fix data operand for instruction alias of `st1d`..
Wed, Aug 26, 8:57 AM · Restricted Project

Tue, Aug 25

fpetrogalli added a comment to D86065: [SVE] Make ElementCount members private.

Hi @fpetrogalli, if you don't mind I think I'll stick with Paul's idea for ogt because this matches the IR neatly, i.e. "fcmp ogt". Also, for me personally it's much simpler and more intuitive.

Tue, Aug 25, 7:21 AM · Restricted Project, Restricted Project

Mon, Aug 24

fpetrogalli added inline comments to D86065: [SVE] Make ElementCount members private.
Mon, Aug 24, 10:09 AM · Restricted Project, Restricted Project
fpetrogalli updated the diff for D86249: [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on scalable vectors..

I lifted the implemementation to the target-agnostic part of the scalarize pass.

Mon, Aug 24, 7:45 AM · Restricted Project
fpetrogalli committed rG5a34b3ab95b5: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI] (authored by fpetrogalli).
[llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI]
Mon, Aug 24, 6:55 AM
fpetrogalli added a reverting change for rGc8d2b065b98f: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI]: rGbad7d6b3735d: Revert "[llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI]".
Mon, Aug 24, 6:51 AM
fpetrogalli committed rGbad7d6b3735d: Revert "[llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI]" (authored by fpetrogalli).
Revert "[llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI]"
Mon, Aug 24, 6:51 AM
fpetrogalli added a reverting change for D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI]: rGbad7d6b3735d: Revert "[llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI]".
Mon, Aug 24, 6:51 AM · Restricted Project
fpetrogalli committed rGc8d2b065b98f: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI] (authored by fpetrogalli).
[llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI]
Mon, Aug 24, 6:40 AM
fpetrogalli closed D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].
Mon, Aug 24, 6:40 AM · Restricted Project
fpetrogalli accepted D86432: [SVE] Fix TypeSize related warnings with IR truncates of scalable vectors.
Mon, Aug 24, 6:38 AM · Restricted Project
fpetrogalli added inline comments to D86432: [SVE] Fix TypeSize related warnings with IR truncates of scalable vectors.
Mon, Aug 24, 6:20 AM · Restricted Project

Aug 20 2020

fpetrogalli added a comment to D86249: [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on scalable vectors..

ScalarizeMaskedMemIntrin can't scalarize scalable vectors on any target; would it make sense to check there?

Aug 20 2020, 9:15 AM · Restricted Project
fpetrogalli added a comment to D86120: [NFC][llvm] Make the constructors of `ElementCount` private..

Why were static "get" methods preferred over simply marking the constructor explicit? For example, if the constructor is marked explicit, then this is what users see:

    llvm::ElementCount EC = {vector->getNumElements(), /*scalable*/ false};
                       ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/dave/s/n/llvm/include/llvm/Support/TypeSize.h:37:12: note: explicit constructor declared here
  explicit ElementCount(unsigned Min, bool Scalable) : Min(Min), Scalable(Scalable) {}
           ^
1 error generated.
Aug 20 2020, 8:48 AM · Restricted Project

Aug 19 2020

fpetrogalli requested review of D86249: [llvm][CodeGen] Do not scalarize `llvm.masked.[gather|scatter]` operating on scalable vectors..
Aug 19 2020, 2:57 PM · Restricted Project
fpetrogalli committed rGdac0b1d33088: [llvm] Add default constructor of `llvm::ElementCount`. (authored by fpetrogalli).
[llvm] Add default constructor of `llvm::ElementCount`.
Aug 19 2020, 2:40 PM
fpetrogalli closed D86240: [llvm] Add default constructor of `llvm::ElementCount`..
Aug 19 2020, 2:40 PM · Restricted Project
fpetrogalli added a comment to D86240: [llvm] Add default constructor of `llvm::ElementCount`..

This builds on Windows. Do the comments need to be updated?

Aug 19 2020, 1:54 PM · Restricted Project
fpetrogalli updated the summary of D86240: [llvm] Add default constructor of `llvm::ElementCount`..
Aug 19 2020, 1:53 PM · Restricted Project
fpetrogalli retitled D86240: [llvm] Add default constructor of `llvm::ElementCount`. from [llvm] Do not delete default constructor of `llvm::ElementCount`. to [llvm] Add default constructor of `llvm::ElementCount`..
Aug 19 2020, 1:53 PM · Restricted Project
fpetrogalli added inline comments to D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].
Aug 19 2020, 1:52 PM · Restricted Project
fpetrogalli updated the diff for D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].

Thank you @rengolin, I have addressed your feedback.

Aug 19 2020, 1:52 PM · Restricted Project
fpetrogalli updated the diff for D86240: [llvm] Add default constructor of `llvm::ElementCount`..

I re-enabled the default contructor so that the code actually builds on linux.

Aug 19 2020, 1:14 PM · Restricted Project
fpetrogalli requested review of D86240: [llvm] Add default constructor of `llvm::ElementCount`..
Aug 19 2020, 1:00 PM · Restricted Project
fpetrogalli updated the diff for D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].

I fixed one assertion message that I missed in last patch update.

Aug 19 2020, 12:01 PM · Restricted Project
fpetrogalli updated subscribers of D86120: [NFC][llvm] Make the constructors of `ElementCount` private..

@ftynse @mehdi_amini @JDevlieghere - apologies for breaking your workflows, and thank you for acting so quickly. I started doing the revert myself as soon as I saw the bombing from buildbot but by the time I was ready to push my revert your fixes were already pouring in.

Aug 19 2020, 11:11 AM · Restricted Project
fpetrogalli committed rG264afb9e6aeb: [NFC][llvm] Make the contructors of `ElementCount` private. (authored by fpetrogalli).
[NFC][llvm] Make the contructors of `ElementCount` private.
Aug 19 2020, 9:27 AM
fpetrogalli closed D86120: [NFC][llvm] Make the constructors of `ElementCount` private..
Aug 19 2020, 9:27 AM · Restricted Project
fpetrogalli retitled D86120: [NFC][llvm] Make the constructors of `ElementCount` private. from [NFC][llvm] Make the contructors of `ElementCount` private. to [NFC][llvm] Make the constructors of `ElementCount` private..
Aug 19 2020, 9:04 AM · Restricted Project
fpetrogalli added inline comments to D86120: [NFC][llvm] Make the constructors of `ElementCount` private..
Aug 19 2020, 8:58 AM · Restricted Project
fpetrogalli updated the diff for D86120: [NFC][llvm] Make the constructors of `ElementCount` private..

Thank you for the review @david-arm.

Aug 19 2020, 8:58 AM · Restricted Project

Aug 18 2020

fpetrogalli added a comment to D85977: [release][docs] Update contributions to LLVM 11 for SVE..

I merged it in the release branch as https://github.com/llvm/llvm-project/commit/7e6bf0bfe6de9e0d0e58764a66f93210f296bbfa

Aug 18 2020, 2:19 PM · Restricted Project, Restricted Project
fpetrogalli added reviewers for D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI]: david-arm, ctetreau, efriedma.
Aug 18 2020, 1:23 PM · Restricted Project
fpetrogalli added inline comments to D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].
Aug 18 2020, 1:17 PM · Restricted Project
fpetrogalli updated the diff for D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].

Thank you for the review, @ctetreau.

Aug 18 2020, 1:17 PM · Restricted Project
fpetrogalli updated the diff for D86120: [NFC][llvm] Make the constructors of `ElementCount` private..

Fix typo.

Aug 18 2020, 11:59 AM · Restricted Project
fpetrogalli added inline comments to D86120: [NFC][llvm] Make the constructors of `ElementCount` private..
Aug 18 2020, 10:05 AM · Restricted Project
fpetrogalli updated the diff for D86120: [NFC][llvm] Make the constructors of `ElementCount` private..

Thank you for the code review @ctetreau.

Aug 18 2020, 10:05 AM · Restricted Project
fpetrogalli retitled D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI] from [WIP][llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI] to [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].
Aug 18 2020, 9:49 AM · Restricted Project
fpetrogalli updated the summary of D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].
Aug 18 2020, 9:36 AM · Restricted Project
fpetrogalli updated the diff for D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].

I have updated the changes on top of https://reviews.llvm.org/D86120 (no constructors for ElementCount).

Aug 18 2020, 9:34 AM · Restricted Project

Aug 17 2020

fpetrogalli added a comment to D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].

@ctetreau - I had made the constructor of ElementCount private in https://reviews.llvm.org/D86120.

Aug 17 2020, 4:38 PM · Restricted Project
fpetrogalli requested review of D86120: [NFC][llvm] Make the constructors of `ElementCount` private..
Aug 17 2020, 4:11 PM · Restricted Project
fpetrogalli updated the summary of D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].
Aug 17 2020, 2:35 PM · Restricted Project
fpetrogalli added inline comments to D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].
Aug 17 2020, 2:30 PM · Restricted Project
fpetrogalli updated the diff for D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].

Thank you again for the review. In the last update I have:

Aug 17 2020, 2:30 PM · Restricted Project
fpetrogalli updated the diff for D85977: [release][docs] Update contributions to LLVM 11 for SVE..

Thank you for the review @david-arm.

Aug 17 2020, 10:03 AM · Restricted Project, Restricted Project
fpetrogalli added inline comments to D86065: [SVE] Make ElementCount members private.
Aug 17 2020, 8:53 AM · Restricted Project, Restricted Project

Aug 14 2020

fpetrogalli updated the diff for D85977: [release][docs] Update contributions to LLVM 11 for SVE..

Fix indentation of the code exmaple.

Aug 14 2020, 12:27 PM · Restricted Project, Restricted Project
fpetrogalli updated the summary of D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].
Aug 14 2020, 12:22 PM · Restricted Project
fpetrogalli updated the diff for D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].

I have removed the ordering function of ElementCount. It required replacing the uses of llvm::SmallSet<ElementCount,...> with llvm::SmallSetVector<ElementCount, ...>.

Aug 14 2020, 12:21 PM · Restricted Project
fpetrogalli added inline comments to D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].
Aug 14 2020, 12:06 PM · Restricted Project
fpetrogalli added inline comments to D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].
Aug 14 2020, 11:53 AM · Restricted Project
fpetrogalli updated the diff for D85977: [release][docs] Update contributions to LLVM 11 for SVE..

Added context to the diff.

Aug 14 2020, 9:54 AM · Restricted Project, Restricted Project
fpetrogalli added reviewers for D85977: [release][docs] Update contributions to LLVM 11 for SVE.: paulwalker-arm, david-arm.
Aug 14 2020, 9:52 AM · Restricted Project, Restricted Project
fpetrogalli requested review of D85977: [release][docs] Update contributions to LLVM 11 for SVE..
Aug 14 2020, 9:36 AM · Restricted Project, Restricted Project
fpetrogalli added inline comments to D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].
Aug 14 2020, 6:47 AM · Restricted Project

Aug 13 2020

fpetrogalli added a comment to D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].

Out of curiosity, what is your approach? Carrying around a bool Scalable flag?

We keep some state around that tells us if we're in a scalable mode. But this doesn't work if we want to be able to vectorize both for fixed size or scalable at the same time for the same target. Not sure if you're considering this scenario (e.g. Advanced SIMD + SVE-256)

Aug 13 2020, 2:10 PM · Restricted Project
fpetrogalli updated the diff for D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].

Thank you for the reviews.

Aug 13 2020, 2:08 PM · Restricted Project
fpetrogalli added inline comments to D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].
Aug 13 2020, 1:43 PM · Restricted Project

Aug 12 2020

fpetrogalli committed rGc561f4d2ec19: [SVE][VLS] Don't combine logical AND. (authored by fpetrogalli).
[SVE][VLS] Don't combine logical AND.
Aug 12 2020, 12:04 PM
fpetrogalli closed D85479: [SVE][VLS] Don't combine logical AND..
Aug 12 2020, 12:04 PM · Restricted Project
fpetrogalli accepted D82218: [SVE] Remove calls to VectorType::getNumElements from AggressiveInstCombine.

thank you for explaining. Sorry it took so long to realize I needed to come back to you on this.

Aug 12 2020, 11:40 AM · Restricted Project
fpetrogalli updated the diff for D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].

Thank you @rengolin and @rogfer01 for the review.

Aug 12 2020, 10:34 AM · Restricted Project
fpetrogalli added a comment to D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].

I think this is a good direction, too.

I don't like implicit assumptions or magic constants, especially when the two (bool scalable and int min) are not linearly independent.

Aug 12 2020, 10:00 AM · Restricted Project
fpetrogalli added a comment to D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].
Aug 12 2020, 9:58 AM · Restricted Project
fpetrogalli updated the diff for D85479: [SVE][VLS] Don't combine logical AND..

Thank you for the review @paulwalker-arm.

Aug 12 2020, 9:08 AM · Restricted Project

Aug 11 2020

fpetrogalli retitled D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI] from [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI] to [WIP][llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].
Aug 11 2020, 3:59 PM · Restricted Project
fpetrogalli requested review of D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].
Aug 11 2020, 3:38 PM · Restricted Project

Aug 7 2020

fpetrogalli updated the summary of D85479: [SVE][VLS] Don't combine logical AND..
Aug 7 2020, 9:49 AM · Restricted Project
fpetrogalli updated the diff for D85479: [SVE][VLS] Don't combine logical AND..

I have updated the tests to make sure they are related to the code that has been modified.

Aug 7 2020, 9:46 AM · Restricted Project

Aug 6 2020

fpetrogalli requested review of D85479: [SVE][VLS] Don't combine logical AND..
Aug 6 2020, 3:24 PM · Restricted Project

Jul 27 2020

fpetrogalli committed rGadb28e0fb2b0: [llvm][CodeGen] Addressing modes for SVE ldN. (authored by fpetrogalli).
[llvm][CodeGen] Addressing modes for SVE ldN.
Jul 27 2020, 3:29 PM
fpetrogalli closed D77251: [llvm][CodeGen] Addressing modes for SVE ldN..
Jul 27 2020, 3:29 PM · Restricted Project
fpetrogalli added inline comments to D77251: [llvm][CodeGen] Addressing modes for SVE ldN..
Jul 27 2020, 10:11 AM · Restricted Project
fpetrogalli updated the diff for D77251: [llvm][CodeGen] Addressing modes for SVE ldN..

Address last feedback on template parameters.

Jul 27 2020, 10:11 AM · Restricted Project
fpetrogalli committed rGdbeb184b7f54: [NFC][AArch64] Replace some template methods/invocations... (authored by fpetrogalli).
[NFC][AArch64] Replace some template methods/invocations...
Jul 27 2020, 9:53 AM

Jul 24 2020

fpetrogalli committed rG809600d66427: [llvm][sve] Reg + Imm addressing mode for ld1ro. (authored by fpetrogalli).
[llvm][sve] Reg + Imm addressing mode for ld1ro.
Jul 24 2020, 10:50 AM
fpetrogalli closed D83357: [llvm][sve] Reg + Imm addressing mode for ld1ro..
Jul 24 2020, 10:49 AM · Restricted Project
fpetrogalli updated the diff for D83357: [llvm][sve] Reg + Imm addressing mode for ld1ro..

I replaced cast with static_cast to fix build failures.

Jul 24 2020, 9:23 AM · Restricted Project
fpetrogalli added inline comments to D83357: [llvm][sve] Reg + Imm addressing mode for ld1ro..
Jul 24 2020, 9:19 AM · Restricted Project
fpetrogalli updated the diff for D77251: [llvm][CodeGen] Addressing modes for SVE ldN..

I have modified the testing of the reg+imm addressing mode to use upper and lower bound instead of strictly in-range values.

Jul 24 2020, 9:06 AM · Restricted Project

Jul 23 2020

fpetrogalli added inline comments to D77251: [llvm][CodeGen] Addressing modes for SVE ldN..
Jul 23 2020, 3:06 PM · Restricted Project
fpetrogalli updated the diff for D77251: [llvm][CodeGen] Addressing modes for SVE ldN..

I have addressed your feedback. Thank you @sdesmalen.

Jul 23 2020, 2:57 PM · Restricted Project
fpetrogalli added a comment to D83357: [llvm][sve] Reg + Imm addressing mode for ld1ro..

Adding some text here as phab doesn't allow me to submit empty comments!

Jul 23 2020, 2:13 PM · Restricted Project
fpetrogalli updated the diff for D83357: [llvm][sve] Reg + Imm addressing mode for ld1ro..

Thank you for the review @sdesmalen, I have addressed all your comments.

Jul 23 2020, 2:13 PM · Restricted Project

Jul 20 2020

fpetrogalli updated the diff for D77251: [llvm][CodeGen] Addressing modes for SVE ldN..

Thank you for your review @sdesmalen!

Jul 20 2020, 9:16 PM · Restricted Project