Page MenuHomePhabricator

bsmith (Bradley Smith)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 12 2013, 6:57 AM (305 w, 5 d)

Recent Activity

Mar 3 2016

bsmith closed D15283: [ARMv8-M] Add Clang targeting for ARMv8-M Baseline/Mainline.

Committed as r262619.

Mar 3 2016, 5:57 AM
bsmith accepted D15283: [ARMv8-M] Add Clang targeting for ARMv8-M Baseline/Mainline.
Mar 3 2016, 5:57 AM

Mar 1 2016

bsmith added a comment to D15283: [ARMv8-M] Add Clang targeting for ARMv8-M Baseline/Mainline.

Ping. This change has been waiting for review for over a month now, it would be great to get this committed. Thanks.

Mar 1 2016, 2:29 AM

Feb 16 2016

bsmith added a comment to D15283: [ARMv8-M] Add Clang targeting for ARMv8-M Baseline/Mainline.

Ping, it would be nice to get this committed to complete ARMv8-M support.

Feb 16 2016, 3:53 AM

Feb 2 2016

bsmith added a comment to D15283: [ARMv8-M] Add Clang targeting for ARMv8-M Baseline/Mainline.

Ping.

Feb 2 2016, 2:16 AM

Feb 1 2016

bsmith accepted D16677: Removed incorrect FeatureVFPOnlySP for Cortex-R7.

The default configuration of a Cortex-R7 is to implement the VFPv3-D16 architecture, the feature line as it is is too restrictive. I believe the intention of the targets in this file is to have them as maximal, hence this change looks good it me.

Feb 1 2016, 9:11 AM

Jan 26 2016

bsmith added a comment to D15283: [ARMv8-M] Add Clang targeting for ARMv8-M Baseline/Mainline.

Now that the LLVM side of this is committed, it would be great to get this reviewed also, thanks.

Jan 26 2016, 2:19 AM

Jan 15 2016

bsmith closed D15282: [ARMv8-M] [9/9] Add DSP build attribute and extension targeting.

Thanks, committed as r257885.

Jan 15 2016, 2:35 AM
bsmith closed D15281: [ARMv8-M] [8/9] Add new system registers to ARMv8-M Baseline/Mainline.

Thanks, committed as r257884.

Jan 15 2016, 2:35 AM
bsmith closed D15280: [ARMv8-M] [7/9] Add ARMv8-M security extension instructions to ARMv8-M Baseline/Mainline.

Thanks, committed as r257883.

Jan 15 2016, 2:35 AM
bsmith closed D15279: [ARMv8-M] [6/9] Add ARMv8-A semaphore/atomic instructions to ARMv8-M Baseline/Mainline.

Thanks, committed as r257882.

Jan 15 2016, 2:35 AM
bsmith closed D15278: [ARMv8-M] [5/9] Add B.W and CBZ instructions to ARMv8-M Baseline.

Thanks, committed as r257881.

Jan 15 2016, 2:34 AM
bsmith closed D15277: [ARMv8-M] [4/9] Add SDIV/UDIV instructions to ARMv8-M Baseline.

Thanks, committed as r257880.

Jan 15 2016, 2:34 AM
bsmith closed D15276: [ARMv8-M] [3/9] Add MOVW/MOVT instructions to ARMv8-M Baseline/Mainline.

Thanks, committed as r257879.

Jan 15 2016, 2:33 AM
bsmith closed D15275: [ARMv8-M] [2/9] Add ARMv8-M Baseline/Mainline LLVM targeting.

Thanks, committed as r257878.

Jan 15 2016, 2:33 AM
bsmith closed D15274: [ARMv8-M] [1/9] Split out ARMv8-A semaphores and atomics and ARMv7-M exclusives as separate features.

Thanks, committed as r257877.

Jan 15 2016, 2:33 AM

Jan 14 2016

bsmith updated the diff for D15281: [ARMv8-M] [8/9] Add new system registers to ARMv8-M Baseline/Mainline.

Fixup logic handling basepri_max{_ns,} field splitting so as to not allow basepri_maxns.

Jan 14 2016, 7:41 AM
bsmith updated the diff for D15280: [ARMv8-M] [7/9] Add ARMv8-M security extension instructions to ARMv8-M Baseline/Mainline.

Add missing HasV8SecExt to VLLDM/VLSTM instructions.

Jan 14 2016, 7:39 AM
bsmith added inline comments to D15281: [ARMv8-M] [8/9] Add new system registers to ARMv8-M Baseline/Mainline.
Jan 14 2016, 7:26 AM
bsmith added inline comments to D15280: [ARMv8-M] [7/9] Add ARMv8-M security extension instructions to ARMv8-M Baseline/Mainline.
Jan 14 2016, 7:13 AM
bsmith updated the diff for D15278: [ARMv8-M] [5/9] Add B.W and CBZ instructions to ARMv8-M Baseline.

Remove redundancy in condition check !isThumb1Only() && hasV8MBaselineOps(), all Thumb-2 targets will have hasV8MBaselineOps() set, so the first condition can simply be !isThumb().

Jan 14 2016, 5:50 AM
bsmith updated the diff for D15279: [ARMv8-M] [6/9] Add ARMv8-A semaphore/atomic instructions to ARMv8-M Baseline/Mainline.

Fix subtarget checks for codegen of atomics such that ARMv8-M Baseline correctly uses these instructions, also add testing for it.

Jan 14 2016, 5:45 AM
bsmith updated the diff for D15280: [ARMv8-M] [7/9] Add ARMv8-M security extension instructions to ARMv8-M Baseline/Mainline.

Add missing mayLoad/mayStore/hasSideEffects flags to added intructions

Jan 14 2016, 5:42 AM
bsmith added inline comments to D15281: [ARMv8-M] [8/9] Add new system registers to ARMv8-M Baseline/Mainline.
Jan 14 2016, 5:32 AM
bsmith added inline comments to D15280: [ARMv8-M] [7/9] Add ARMv8-M security extension instructions to ARMv8-M Baseline/Mainline.
Jan 14 2016, 3:27 AM

Jan 12 2016

bsmith added a comment to D15275: [ARMv8-M] [2/9] Add ARMv8-M Baseline/Mainline LLVM targeting.

Ping (for this and the others in this series).

Jan 12 2016, 2:17 AM

Jan 6 2016

bsmith added a comment to D15279: [ARMv8-M] [6/9] Add ARMv8-A semaphore/atomic instructions to ARMv8-M Baseline/Mainline.

I'm waiting on the rest of the patches to be reviewed since I want to land all patches together (more or less, or at least the dependent ones). The main one being D15275 which I made changes to on Monday.

Jan 6 2016, 7:31 AM

Jan 4 2016

bsmith updated the diff for D15283: [ARMv8-M] Add Clang targeting for ARMv8-M Baseline/Mainline.

Rebase patch against latest changes made to ARMv8-M targeting, specifically the removal of 'B' as a profile.

Jan 4 2016, 6:22 AM
bsmith updated the diff for D15282: [ARMv8-M] [9/9] Add DSP build attribute and extension targeting.

Rebase patch against latest trunk changes.

Jan 4 2016, 6:21 AM
bsmith updated the diff for D15281: [ARMv8-M] [8/9] Add new system registers to ARMv8-M Baseline/Mainline.

Rebase patch against latest trunk changes.

Jan 4 2016, 6:21 AM
bsmith updated the diff for D15280: [ARMv8-M] [7/9] Add ARMv8-M security extension instructions to ARMv8-M Baseline/Mainline.

Rebase patch against latest trunk changes.

Jan 4 2016, 6:20 AM
bsmith requested review of D15279: [ARMv8-M] [6/9] Add ARMv8-A semaphore/atomic instructions to ARMv8-M Baseline/Mainline.
Jan 4 2016, 6:20 AM
bsmith updated the diff for D15279: [ARMv8-M] [6/9] Add ARMv8-A semaphore/atomic instructions to ARMv8-M Baseline/Mainline.

Rebase patch against latest trunk changes.

Jan 4 2016, 6:19 AM
bsmith updated the diff for D15278: [ARMv8-M] [5/9] Add B.W and CBZ instructions to ARMv8-M Baseline.

Rebase patch against latest trunk changes.

Jan 4 2016, 6:19 AM
bsmith updated the diff for D15277: [ARMv8-M] [4/9] Add SDIV/UDIV instructions to ARMv8-M Baseline.

Rebase patch against latest trunk changes.

Jan 4 2016, 6:18 AM
bsmith updated the diff for D15276: [ARMv8-M] [3/9] Add MOVW/MOVT instructions to ARMv8-M Baseline/Mainline.

Rebase patch against latest trunk changes.

Jan 4 2016, 6:17 AM
bsmith requested review of D15275: [ARMv8-M] [2/9] Add ARMv8-M Baseline/Mainline LLVM targeting.
Jan 4 2016, 6:16 AM
bsmith updated the diff for D15275: [ARMv8-M] [2/9] Add ARMv8-M Baseline/Mainline LLVM targeting.

Rebase patch against latest trunk changes. Also adjust build attributes following some changes in this area, this is how the attributes look in GCC. That is:

Jan 4 2016, 6:16 AM
bsmith set the repository for D15274: [ARMv8-M] [1/9] Split out ARMv8-A semaphores and atomics and ARMv7-M exclusives as separate features to rL LLVM.
Jan 4 2016, 6:11 AM
bsmith updated the diff for D15274: [ARMv8-M] [1/9] Split out ARMv8-A semaphores and atomics and ARMv7-M exclusives as separate features.

Rebase patch against latest trunk changes.

Jan 4 2016, 6:10 AM

Dec 8 2015

bsmith updated the diff for D15282: [ARMv8-M] [9/9] Add DSP build attribute and extension targeting.

Rebase onto changes done in D15275.

Dec 8 2015, 3:48 AM
bsmith updated the diff for D15278: [ARMv8-M] [5/9] Add B.W and CBZ instructions to ARMv8-M Baseline.

Rebase onto changes done in D15275.

Dec 8 2015, 3:46 AM
bsmith updated the diff for D15277: [ARMv8-M] [4/9] Add SDIV/UDIV instructions to ARMv8-M Baseline.

Rebase onto changes done in D15275.

Dec 8 2015, 3:45 AM
bsmith updated the diff for D15276: [ARMv8-M] [3/9] Add MOVW/MOVT instructions to ARMv8-M Baseline/Mainline.

Rebase onto changes done in D15275.

Dec 8 2015, 3:44 AM
bsmith updated the diff for D15275: [ARMv8-M] [2/9] Add ARMv8-M Baseline/Mainline LLVM targeting.

Add testing for FeatureDB and FeatureNoARM.

Dec 8 2015, 3:43 AM
bsmith added inline comments to D15275: [ARMv8-M] [2/9] Add ARMv8-M Baseline/Mainline LLVM targeting.
Dec 8 2015, 3:00 AM

Dec 7 2015

bsmith added inline comments to D15275: [ARMv8-M] [2/9] Add ARMv8-M Baseline/Mainline LLVM targeting.
Dec 7 2015, 7:17 AM
bsmith retitled D15283: [ARMv8-M] Add Clang targeting for ARMv8-M Baseline/Mainline from to [ARMv8-M] Add Clang targeting for ARMv8-M Baseline/Mainline.
Dec 7 2015, 3:21 AM
bsmith retitled D15282: [ARMv8-M] [9/9] Add DSP build attribute and extension targeting from to [ARMv8-M] [9/9] Add DSP build attribute and extension targeting.
Dec 7 2015, 3:19 AM
bsmith retitled D15281: [ARMv8-M] [8/9] Add new system registers to ARMv8-M Baseline/Mainline from to [ARMv8-M] [8/9] Add new system registers to ARMv8-M Baseline/Mainline.
Dec 7 2015, 3:17 AM
bsmith retitled D15280: [ARMv8-M] [7/9] Add ARMv8-M security extension instructions to ARMv8-M Baseline/Mainline from to [ARMv8-M] [7/9] Add ARMv8-M security extension instructions to ARMv8-M Baseline/Mainline.
Dec 7 2015, 3:16 AM
bsmith retitled D15279: [ARMv8-M] [6/9] Add ARMv8-A semaphore/atomic instructions to ARMv8-M Baseline/Mainline from to [ARMv8-M] [6/9] Add ARMv8-A semaphore/atomic instructions to ARMv8-M Baseline/Mainline.
Dec 7 2015, 3:14 AM
bsmith retitled D15278: [ARMv8-M] [5/9] Add B.W and CBZ instructions to ARMv8-M Baseline from to [ARMv8-M] [5/9] Add B.W and CBZ instructions to ARMv8-M Baseline.
Dec 7 2015, 3:13 AM
bsmith retitled D15277: [ARMv8-M] [4/9] Add SDIV/UDIV instructions to ARMv8-M Baseline from to [ARMv8-M] [4/9] Add SDIV/UDIV instructions to ARMv8-M Baseline.
Dec 7 2015, 3:11 AM
bsmith retitled D15276: [ARMv8-M] [3/9] Add MOVW/MOVT instructions to ARMv8-M Baseline/Mainline from to [ARMv8-M] [3/9] Add MOVW/MOVT instructions to ARMv8-M Baseline/Mainline.
Dec 7 2015, 3:10 AM
bsmith retitled D15275: [ARMv8-M] [2/9] Add ARMv8-M Baseline/Mainline LLVM targeting from to [ARMv8-M] [2/9] Add ARMv8-M Baseline/Mainline LLVM targeting.
Dec 7 2015, 3:08 AM
bsmith retitled D15274: [ARMv8-M] [1/9] Split out ARMv8-A semaphores and atomics and ARMv7-M exclusives as separate features from to [ARMv8-M] [1/9] Split out ARMv8-A semaphores and atomics and ARMv7-M exclusives as separate features.
Dec 7 2015, 3:06 AM
bsmith closed D15234: [ARM] Flag vcvt{t,b} with an f16 type specifier as part of the FP16 extension. .

Thanks, committed as r254900.

Dec 7 2015, 2:57 AM

Dec 4 2015

bsmith retitled D15234: [ARM] Flag vcvt{t,b} with an f16 type specifier as part of the FP16 extension. from to [ARM] Flag vcvt{t,b} with an f16 type specifier as part of the FP16 extension. .
Dec 4 2015, 8:55 AM

Nov 27 2015

bsmith added inline comments to D15040: [ARM] Add command-line options for ARMv8.2-A.
Nov 27 2015, 5:38 AM

Nov 18 2015

bsmith closed D14773: [ARM] Support +feature targeting in -mcpu/-march.

Thanks, committed as r253471.

Nov 18 2015, 8:36 AM
bsmith closed D14774: [ARM] Add +feature names to TargetParser extensions table.

Thanks, committed as r253470.

Nov 18 2015, 8:35 AM
bsmith updated the diff for D14773: [ARM] Support +feature targeting in -mcpu/-march.

Add +crypto to testing.

Nov 18 2015, 8:24 AM
bsmith updated the diff for D14774: [ARM] Add +feature names to TargetParser extensions table.

Only call getName/getNegName if the respective feature name is not nullptr. Also enable use of +crypto, I had originally omitted this due to it being specified in -mfpu, but I see no reason why it can't be here also.

Nov 18 2015, 8:23 AM
bsmith retitled D14774: [ARM] Add +feature names to TargetParser extensions table from to [ARM] Add +feature names to TargetParser extensions table.
Nov 18 2015, 6:47 AM
bsmith retitled D14773: [ARM] Support +feature targeting in -mcpu/-march from to [ARM] Support +feature targeting in -mcpu/-march.
Nov 18 2015, 6:46 AM

Nov 16 2015

bsmith closed D14662: [ARM] Pass architecture to TargetParser defaulting to cope with API change.

Thanks, committed as r253199.

Nov 16 2015, 3:19 AM
bsmith closed D14661: [ARM] Allow TargetParser to accurately target architectures.
Nov 16 2015, 3:19 AM
bsmith added a comment to D14661: [ARM] Allow TargetParser to accurately target architectures.

Thanks, committed as r253198.

Nov 16 2015, 3:18 AM
bsmith closed D14660: [ARM] Introduce subtarget features per ARM architecture.

Thanks all! Committed as r253196.

Nov 16 2015, 3:13 AM

Nov 13 2015

bsmith retitled D14662: [ARM] Pass architecture to TargetParser defaulting to cope with API change from to [ARM] Pass architecture to TargetParser defaulting to cope with API change.
Nov 13 2015, 9:36 AM
bsmith retitled D14661: [ARM] Allow TargetParser to accurately target architectures from to [ARM] Allow TargetParser to accurately target architectures.
Nov 13 2015, 9:32 AM
bsmith retitled D14660: [ARM] Introduce subtarget features per ARM architecture from to [ARM] Introduce subtarget features per ARM architecture.
Nov 13 2015, 9:29 AM

May 12 2015

bsmith abandoned D6247: [ARM/AArch64] Add ACLE special register intrinsics (10.1).
May 12 2015, 9:36 AM

Apr 28 2015

bsmith closed D9297: [ARM/AArch64] Enforce alignment for bitfielded structs.

Thanks, committed as r235976 (with redundant line removed).

Apr 28 2015, 4:28 AM
bsmith updated the diff for D9297: [ARM/AArch64] Enforce alignment for bitfielded structs.

Added testcase and removed triple check in favour of a TargetInfo query.

Apr 28 2015, 3:55 AM

Apr 27 2015

bsmith retitled D9297: [ARM/AArch64] Enforce alignment for bitfielded structs from to [ARM/AArch64] Enforce alignment for bitfielded structs.
Apr 27 2015, 9:35 AM

Apr 14 2015

bsmith closed D9012: [AArch64] Allow non-standard INS/DUP encodings.

Thanks, committed as r234896.

Apr 14 2015, 8:10 AM
bsmith retitled D9012: [AArch64] Allow non-standard INS/DUP encodings from to [AArch64] Allow non-standard INS/DUP encodings.
Apr 14 2015, 4:17 AM

Mar 23 2015

bsmith closed D8546: [ARM] Add more pattern matching for f16 <-> f64 conversions.

Thanks, committed as r232954.

Mar 23 2015, 9:02 AM
bsmith retitled D8546: [ARM] Add more pattern matching for f16 <-> f64 conversions from to [ARM] Add more pattern matching for f16 <-> f64 conversions.
Mar 23 2015, 8:12 AM

Feb 18 2015

bsmith closed D7669: [ARM] Add missing M/R class CPUs.

Committed as 229661.

Feb 18 2015, 2:36 AM
bsmith closed D7668: [ARM] Add missing M/R class CPUs.

Committed as 229660.

Feb 18 2015, 2:35 AM

Feb 17 2015

bsmith added a comment to D7668: [ARM] Add missing M/R class CPUs.

I've had a play with using defm etc for this, and whilst it does work it ends up being rather messy and unclear (especially when applied to all CPUs). I think in an ideal world the way I would structure this would be to model architectures rather than CPUs. That is, have subtarget features that represent architectures and enable the correct set of features for each, then have the CPUs inherit their architecture + extra bits rather than a full set of features. However as I mentioned, this cannot be done yet due to almost reaching the subtarget feature limit.

Feb 17 2015, 7:23 AM
bsmith added a comment to D7668: [ARM] Add missing M/R class CPUs.

Some of them will end up with the same feature set (the sc* CPUs for example) so maybe aliases would be best. That said, how do you do aliases and still have them targetable in LLVM? (the only way I know of is to do it at the clang side).

Feb 17 2015, 2:55 AM

Feb 16 2015

bsmith retitled D7669: [ARM] Add missing M/R class CPUs from to [ARM] Add missing M/R class CPUs.
Feb 16 2015, 7:15 AM
bsmith retitled D7668: [ARM] Add missing M/R class CPUs from to [ARM] Add missing M/R class CPUs.
Feb 16 2015, 7:13 AM

Feb 10 2015

bsmith closed D7505: [ARM] Add tests for armv6s[-]m being an alias to armv6[-]m.
Feb 10 2015, 7:18 AM
bsmith accepted D7505: [ARM] Add tests for armv6s[-]m being an alias to armv6[-]m.
Feb 10 2015, 7:18 AM
bsmith closed D7504: [ARM] Add armv6s[-]m as an alias to armv6[-]m.

Thanks, committed as r228696.

Feb 10 2015, 7:17 AM
bsmith updated the diff for D7504: [ARM] Add armv6s[-]m as an alias to armv6[-]m.

Add extra tests for armv6s[-]m target.

Feb 10 2015, 3:19 AM

Feb 9 2015

bsmith added a comment to D7504: [ARM] Add armv6s[-]m as an alias to armv6[-]m.

Testcases under D7505.

Feb 9 2015, 8:26 AM
bsmith retitled D7505: [ARM] Add tests for armv6s[-]m being an alias to armv6[-]m from to [ARM] Add tests for armv6s[-]m being an alias to armv6[-]m.
Feb 9 2015, 8:26 AM
bsmith retitled D7504: [ARM] Add armv6s[-]m as an alias to armv6[-]m from to [ARM] Add armv6s[-]m as an alias to armv6[-]m.
Feb 9 2015, 8:24 AM

Feb 4 2015

bsmith closed D7408: [ARM] Fix subtarget feature set truncation when using .cpu directive.

Thanks, committed as 228151 (with the tweak).

Feb 4 2015, 8:26 AM
bsmith retitled D7408: [ARM] Fix subtarget feature set truncation when using .cpu directive from to [ARM] Fix subtarget feature set truncation when using .cpu directive.
Feb 4 2015, 7:03 AM

Jan 19 2015

bsmith closed D7056: [ARM] SSAT/USAT with an 'asr #32' shift should result in an undefined encoding rather than unpredictable.

Thanks, committed as r226469.

Jan 19 2015, 8:38 AM
bsmith closed D7057: [ARM] Fixup sign extend instruction availability w.r.t. DSP extension.

The positive tests already exist in test/MC/ARM/basic-{arm,thumb2}-instructions.s.

Jan 19 2015, 8:37 AM
bsmith retitled D7057: [ARM] Fixup sign extend instruction availability w.r.t. DSP extension from to [ARM] Fixup sign extend instruction availability w.r.t. DSP extension.
Jan 19 2015, 8:20 AM
bsmith retitled D7056: [ARM] SSAT/USAT with an 'asr #32' shift should result in an undefined encoding rather than unpredictable from to [ARM] SSAT/USAT with an 'asr #32' shift should result in an undefined encoding rather than unpredictable.
Jan 19 2015, 8:13 AM