This is because GlobalVariable objects' section fields were almost never set except for user-defined section names. So here we always set the section field.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Can you upload the full diff (git diff -U100000 or arc diff --update D116852) and fix the clang-format check?
Comment Actions
We need some kind of test coverage.
llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp | ||
---|---|---|
590 | I'm not very familiar with this code, but altering const variables like this doesn't seem like a good idea - is there any kind of existing 'fixup' call that we can use instead? |
Comment Actions
Please provide a test case to show what is the problem and how the patch addressed the problem, so reviewers can check whether this is the best approach to fix the problem or not.
clang-format: please reformat the code