Page MenuHomePhabricator

LemonBoy (LemonBoy)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 10 2016, 2:52 PM (230 w, 3 d)

Recent Activity

Yesterday

LemonBoy updated the diff for D99754: [LLD][ELF][AVR] Propagate ELF flags to the linked image.

Clean up. To be applied on top of D100250.

Sun, Apr 11, 3:26 AM · Restricted Project, lld
LemonBoy updated the diff for D100250: [yaml2obj/obj2yaml/llvm-readobj] Support printing and parsing AVR-specific e_flags.

Fix one more test case.

Sun, Apr 11, 2:43 AM · Restricted Project

Sat, Apr 10

LemonBoy requested review of D100250: [yaml2obj/obj2yaml/llvm-readobj] Support printing and parsing AVR-specific e_flags.
Sat, Apr 10, 12:30 PM · Restricted Project

Fri, Apr 9

LemonBoy added a comment to D99754: [LLD][ELF][AVR] Propagate ELF flags to the linked image.

llvm/BinaryFormat/ELF.h is typically added along with tests to llvm-readobj/yaml2obj/obj2yaml. See D95728 for an example.

Fri, Apr 9, 1:12 AM · Restricted Project, lld

Thu, Apr 8

LemonBoy committed rGedb18ea5a913: [AsmParser] Recognize more escaped characters between single quotes (authored by LemonBoy).
[AsmParser] Recognize more escaped characters between single quotes
Thu, Apr 8, 1:00 AM
LemonBoy closed D99609: [AsmParser] Recognize more escaped characters between single quotes.
Thu, Apr 8, 12:59 AM · Restricted Project
LemonBoy updated the diff for D99609: [AsmParser] Recognize more escaped characters between single quotes.

Use CHECK-NEXT in more places.

Thu, Apr 8, 12:56 AM · Restricted Project

Wed, Apr 7

LemonBoy updated the diff for D99754: [LLD][ELF][AVR] Propagate ELF flags to the linked image.

Ping (& fix one small style issue pointed out by clang-tidy)

Wed, Apr 7, 12:01 PM · Restricted Project, lld
LemonBoy added a reviewer for D99609: [AsmParser] Recognize more escaped characters between single quotes: MaskRay.
Wed, Apr 7, 11:54 AM · Restricted Project
LemonBoy committed rG03f7b13d4452: [X86] Initialize TargetOptions::StackProtectorGuardOffset member to its default… (authored by LemonBoy).
[X86] Initialize TargetOptions::StackProtectorGuardOffset member to its default…
Wed, Apr 7, 12:04 AM
LemonBoy closed D99952: [X86] Initialize TargetOptions::StackProtectorGuardOffset member to its default value.
Wed, Apr 7, 12:04 AM · Restricted Project

Tue, Apr 6

LemonBoy added inline comments to D99952: [X86] Initialize TargetOptions::StackProtectorGuardOffset member to its default value.
Tue, Apr 6, 11:07 AM · Restricted Project
LemonBoy updated the diff for D99952: [X86] Initialize TargetOptions::StackProtectorGuardOffset member to its default value.

Use suffix instead of an explicit cast.

Tue, Apr 6, 11:06 AM · Restricted Project
LemonBoy added inline comments to D99952: [X86] Initialize TargetOptions::StackProtectorGuardOffset member to its default value.
Tue, Apr 6, 10:58 AM · Restricted Project
LemonBoy requested review of D99952: [X86] Initialize TargetOptions::StackProtectorGuardOffset member to its default value.
Tue, Apr 6, 6:31 AM · Restricted Project

Thu, Apr 1

LemonBoy requested review of D99754: [LLD][ELF][AVR] Propagate ELF flags to the linked image.
Thu, Apr 1, 11:13 AM · Restricted Project, lld

Tue, Mar 30

LemonBoy added a reviewer for D99609: [AsmParser] Recognize more escaped characters between single quotes: thakis.
Tue, Mar 30, 10:22 AM · Restricted Project
LemonBoy requested review of D99609: [AsmParser] Recognize more escaped characters between single quotes.
Tue, Mar 30, 10:12 AM · Restricted Project

Sun, Mar 28

LemonBoy abandoned D99465: [Clang][X86] Mark some VAES builtins as conditionally defined.
Sun, Mar 28, 11:37 AM · Restricted Project
LemonBoy added a comment to D99465: [Clang][X86] Mark some VAES builtins as conditionally defined.

We can't use preprocessor defines in the intrinsic header files. It prevents being able to use the intrinsics with attribute(target("avx512f,vaes")). What's preventing __m512i from being defined?

Sun, Mar 28, 11:09 AM · Restricted Project
LemonBoy requested review of D99465: [Clang][X86] Mark some VAES builtins as conditionally defined.
Sun, Mar 28, 3:28 AM · Restricted Project

Sat, Mar 27

LemonBoy updated the diff for D99435: [SROA] Avoid splitting loads/stores with irregular type.

Run clang-format on the modified line.

Sat, Mar 27, 3:46 AM · Restricted Project

Fri, Mar 26

LemonBoy requested review of D99435: [SROA] Avoid splitting loads/stores with irregular type.
Fri, Mar 26, 12:31 PM · Restricted Project

Sat, Mar 20

LemonBoy updated the diff for D98882: [LoopVectorize] Support widening memory ops with irregular types.

Rebase to main.

Sat, Mar 20, 3:09 AM · Restricted Project

Thu, Mar 18

LemonBoy requested review of D98882: [LoopVectorize] Support widening memory ops with irregular types.
Thu, Mar 18, 11:33 AM · Restricted Project

Wed, Mar 17

LemonBoy committed rG4f024938e4c9: [LoopVectorize] Refine hasIrregularType predicate (authored by LemonBoy).
[LoopVectorize] Refine hasIrregularType predicate
Wed, Mar 17, 9:05 AM
LemonBoy closed D97465: [LoopVectorize] Refine hasIrregularType predicate.
Wed, Mar 17, 9:05 AM · Restricted Project
LemonBoy added inline comments to D97465: [LoopVectorize] Refine hasIrregularType predicate.
Wed, Mar 17, 4:31 AM · Restricted Project

Tue, Mar 16

LemonBoy added a comment to D97465: [LoopVectorize] Refine hasIrregularType predicate.

Ping ?

Tue, Mar 16, 12:54 PM · Restricted Project

Mar 11 2021

LemonBoy committed rGcfe69c8efd1c: [SelectionDAG] Improve scalarization of irregular vector types (authored by LemonBoy).
[SelectionDAG] Improve scalarization of irregular vector types
Mar 11 2021, 10:57 AM
LemonBoy closed D98273: [SelectionDAG] Improve scalarization of irregular vector types.
Mar 11 2021, 10:57 AM · Restricted Project
LemonBoy committed rGcc999c9546e5: [MIPS] Fix lowering of irregular vector arguments (authored by LemonBoy).
[MIPS] Fix lowering of irregular vector arguments
Mar 11 2021, 10:56 AM
LemonBoy closed D98189: [MIPS] Fix lowering of irregular vector arguments.
Mar 11 2021, 10:56 AM · Restricted Project

Mar 9 2021

LemonBoy retitled D98189: [MIPS] Fix lowering of irregular vector arguments from [MIPS] Fix lowering of vectors of non-power-of-two elements to [MIPS] Fix lowering of irregular vector arguments.
Mar 9 2021, 11:03 AM · Restricted Project
LemonBoy updated the diff for D98189: [MIPS] Fix lowering of irregular vector arguments.

Split this patch, the SelectionDAG part is in D98273

Mar 9 2021, 10:58 AM · Restricted Project
LemonBoy requested review of D98273: [SelectionDAG] Improve scalarization of irregular vector types.
Mar 9 2021, 10:56 AM · Restricted Project
LemonBoy added a comment to D98189: [MIPS] Fix lowering of irregular vector arguments.

Sure. I'll have the first one introduce the SelectionDAG rules and the second one introduce the fixes for the MIPS codegen together with the various tests.

Mar 9 2021, 8:14 AM · Restricted Project
LemonBoy added a comment to D98189: [MIPS] Fix lowering of irregular vector arguments.

I have not checked the patch carefully yet. But it looks like some tests was removed. For example MIPS64R5EL-LABEL: i8_2... Is it intended?

Mar 9 2021, 7:47 AM · Restricted Project

Mar 8 2021

LemonBoy updated the diff for D98189: [MIPS] Fix lowering of irregular vector arguments.

Apply the TRUNCATE + BITCAST strategy everywhere, at least on MIPS the generated code is noticeably better.

Mar 8 2021, 9:57 AM · Restricted Project
LemonBoy updated the diff for D98189: [MIPS] Fix lowering of irregular vector arguments.

Apply clang-format

Mar 8 2021, 9:12 AM · Restricted Project
LemonBoy requested review of D98189: [MIPS] Fix lowering of irregular vector arguments.
Mar 8 2021, 8:52 AM · Restricted Project

Mar 6 2021

LemonBoy added a reviewer for D97465: [LoopVectorize] Refine hasIrregularType predicate: david-arm.
Mar 6 2021, 12:11 AM · Restricted Project

Mar 5 2021

LemonBoy committed rG2ec43e416734: [LegalizeDAG] Implement promotion rules for SELECT_CC (authored by LemonBoy).
[LegalizeDAG] Implement promotion rules for SELECT_CC
Mar 5 2021, 9:23 AM
LemonBoy closed D97859: [LegalizeDAG] Implement promotion rules for SELECT_CC.
Mar 5 2021, 9:23 AM · Restricted Project
LemonBoy committed rG8725b24c6d4a: [AArch64] Legalize horizontal fmax/fmin reductions on f16 vectors (authored by LemonBoy).
[AArch64] Legalize horizontal fmax/fmin reductions on f16 vectors
Mar 5 2021, 7:09 AM
LemonBoy closed D97840: [AArch64] Legalize horizontal fmax/fmin reductions on f16 vectors.
Mar 5 2021, 7:09 AM · Restricted Project

Mar 4 2021

LemonBoy added inline comments to D97859: [LegalizeDAG] Implement promotion rules for SELECT_CC.
Mar 4 2021, 10:09 AM · Restricted Project
LemonBoy updated the diff for D97859: [LegalizeDAG] Implement promotion rules for SELECT_CC.

Assert all the operand types are the same.

Mar 4 2021, 10:09 AM · Restricted Project
LemonBoy updated the diff for D97859: [LegalizeDAG] Implement promotion rules for SELECT_CC.

Properly handle cases where the true/false operand have different types than the comparison ones.

Mar 4 2021, 3:25 AM · Restricted Project
LemonBoy added a comment to D97665: [InstSimplify] Don't fold comparisons of non-inbounds GEPs.

But, I'm rather curious about how the miscompilation happened from this optimization. A gep with such offset isn't common, unless a programmer writes a code that subtracts a pointer from null (which is already fishy)?
It would be great if I can see the input that causes miscompilation.

Mar 4 2021, 1:45 AM · Restricted Project

Mar 3 2021

LemonBoy added inline comments to D97859: [LegalizeDAG] Implement promotion rules for SELECT_CC.
Mar 3 2021, 10:57 AM · Restricted Project
LemonBoy added inline comments to D97859: [LegalizeDAG] Implement promotion rules for SELECT_CC.
Mar 3 2021, 10:03 AM · Restricted Project
LemonBoy requested review of D97859: [LegalizeDAG] Implement promotion rules for SELECT_CC.
Mar 3 2021, 7:25 AM · Restricted Project
LemonBoy added inline comments to D97840: [AArch64] Legalize horizontal fmax/fmin reductions on f16 vectors.
Mar 3 2021, 3:11 AM · Restricted Project
LemonBoy updated the diff for D97840: [AArch64] Legalize horizontal fmax/fmin reductions on f16 vectors.

Don't mark the fmin/fmax ops as legal if fullfp16 is not available.
Update test cases.

Mar 3 2021, 3:08 AM · Restricted Project
LemonBoy added inline comments to D97840: [AArch64] Legalize horizontal fmax/fmin reductions on f16 vectors.
Mar 3 2021, 1:36 AM · Restricted Project
LemonBoy requested review of D97840: [AArch64] Legalize horizontal fmax/fmin reductions on f16 vectors.
Mar 3 2021, 1:14 AM · Restricted Project

Mar 2 2021

LemonBoy updated the diff for D97465: [LoopVectorize] Refine hasIrregularType predicate.

Update some documentation comments.

Mar 2 2021, 10:03 AM · Restricted Project
LemonBoy updated subscribers of D97465: [LoopVectorize] Refine hasIrregularType predicate.
Mar 2 2021, 4:14 AM · Restricted Project

Mar 1 2021

LemonBoy added inline comments to D97665: [InstSimplify] Don't fold comparisons of non-inbounds GEPs.
Mar 1 2021, 1:14 AM · Restricted Project
LemonBoy requested review of D97665: [InstSimplify] Don't fold comparisons of non-inbounds GEPs.
Mar 1 2021, 1:14 AM · Restricted Project

Feb 25 2021

LemonBoy added inline comments to D97465: [LoopVectorize] Refine hasIrregularType predicate.
Feb 25 2021, 1:50 PM · Restricted Project
LemonBoy updated the diff for D97465: [LoopVectorize] Refine hasIrregularType predicate.

Remove unused parameter.

Feb 25 2021, 1:50 PM · Restricted Project
LemonBoy requested review of D97465: [LoopVectorize] Refine hasIrregularType predicate.
Feb 25 2021, 5:56 AM · Restricted Project

Jan 13 2021

LemonBoy updated the diff for D94345: [SPARC] Fix fp128 load/stores.

Rebased after changes in master, feel free to land the changes right away as I have no commit access (yet?).

Jan 13 2021, 2:00 PM · Restricted Project

Jan 9 2021

LemonBoy added a comment to D94345: [SPARC] Fix fp128 load/stores.

You can use "-stop-after=finalize-isel" and check the MIR output which should print the memory operands. I think maybe update_mir_test_checks.py can generate the check lines for MIR output from a .ll test.

Jan 9 2021, 6:58 AM · Restricted Project
LemonBoy updated the diff for D94345: [SPARC] Fix fp128 load/stores.
  • Add MIR test
  • Replace dyn_cast<> with cast<>
Jan 9 2021, 6:56 AM · Restricted Project

Jan 8 2021

LemonBoy updated the diff for D77737: [SPARC] Recognize and handle the %lm(sym) operator.

Roll back to something simpler, let's only implement %lm and its encoding.

Jan 8 2021, 3:46 PM · Restricted Project
LemonBoy added a comment to D94345: [SPARC] Fix fp128 load/stores.

The test is not so solid (is it?), ideally we should check the MI to make sure the load ops have the correct offset but I have no idea of what kind of test does that.

Jan 8 2021, 3:28 PM · Restricted Project
LemonBoy requested review of D94345: [SPARC] Fix fp128 load/stores.
Jan 8 2021, 3:22 PM · Restricted Project

Dec 14 2020

LemonBoy added a comment to D92931: lld/ELF: Parse MSP430 BFD/emulation names.

As usual please merge if no more reviews are needed.

Dec 14 2020, 6:25 AM · Restricted Project, lld

Dec 9 2020

LemonBoy requested review of D92931: lld/ELF: Parse MSP430 BFD/emulation names.
Dec 9 2020, 4:14 AM · Restricted Project, lld

Nov 28 2020

LemonBoy added a comment to D90305: Correctly parse and print Tag_THUMB_ISA_use=3.

@MaskRay Is this ready to go now?

Nov 28 2020, 11:38 AM · Restricted Project

Nov 19 2020

LemonBoy added a comment to D90305: Correctly parse and print Tag_THUMB_ISA_use=3.

I am once again asking for your financial support.
@MaskRay would you mind landing this now that it got another approval mark?

Nov 19 2020, 12:29 AM · Restricted Project

Nov 9 2020

LemonBoy added a comment to D89628: Fix constant-folding of overflowing arithmetic ops on vectors.

sigh
Ping?

Nov 9 2020, 3:36 AM · Restricted Project

Nov 6 2020

LemonBoy added inline comments to D90305: Correctly parse and print Tag_THUMB_ISA_use=3.
Nov 6 2020, 9:10 AM · Restricted Project
LemonBoy added reviewers for D90305: Correctly parse and print Tag_THUMB_ISA_use=3: compnerd, MaskRay.
Nov 6 2020, 12:26 AM · Restricted Project

Nov 3 2020

LemonBoy added a comment to D90305: Correctly parse and print Tag_THUMB_ISA_use=3.

Ping?

Nov 3 2020, 3:16 AM · Restricted Project

Oct 31 2020

LemonBoy added inline comments to D89628: Fix constant-folding of overflowing arithmetic ops on vectors.
Oct 31 2020, 10:15 AM · Restricted Project
LemonBoy retitled D89628: Fix constant-folding of overflowing arithmetic ops on vectors from Don't fold overflowing arithmetic ops on vectors to Fix constant-folding of overflowing arithmetic ops on vectors.
Oct 31 2020, 6:45 AM · Restricted Project

Oct 28 2020

LemonBoy updated the diff for D78193: [Sparc] Fixes for the internal assembler.
Oct 28 2020, 4:02 PM · Restricted Project
LemonBoy added a comment to D78193: [Sparc] Fixes for the internal assembler.

It tries to fix a couple of things, so it would probably been better to divide it up into more than one patch and add some more tests, but this is fine. I compared the result with GAS for V8 and it matches.

Oct 28 2020, 11:35 AM · Restricted Project
LemonBoy added a comment to D89628: Fix constant-folding of overflowing arithmetic ops on vectors.

Looks good to me, thanks.

Great, can you commit this on my behalf? I have no commit access.

@hans Is it too early to request this patch to be included in 11.0.1?

Please specify the Author: name <e@ma.il> to be used for the commit.

Oct 28 2020, 6:52 AM · Restricted Project
LemonBoy added a comment to D89628: Fix constant-folding of overflowing arithmetic ops on vectors.

Ping?

Oct 28 2020, 6:31 AM · Restricted Project
LemonBoy requested review of D90305: Correctly parse and print Tag_THUMB_ISA_use=3.
Oct 28 2020, 6:30 AM · Restricted Project

Oct 20 2020

LemonBoy updated subscribers of D89628: Fix constant-folding of overflowing arithmetic ops on vectors.

Looks good to me, thanks.

Oct 20 2020, 1:40 PM · Restricted Project
LemonBoy updated the diff for D89628: Fix constant-folding of overflowing arithmetic ops on vectors.

Cleaned up the true/false building parts.
Added a note about LLVM not detecting if signed multiplication overflow, not much of a problem and can be fixed later.

Oct 20 2020, 11:20 AM · Restricted Project
LemonBoy added a comment to D78658: [clang][Frontend] Add missing error handling.

Looks good to me - thanks!

Oct 20 2020, 12:48 AM · Restricted Project

Oct 17 2020

LemonBoy added a comment to D89628: Fix constant-folding of overflowing arithmetic ops on vectors.

Doesn't the same issue apply to the isNeutralValue branch?

Oct 17 2020, 1:33 PM · Restricted Project
LemonBoy updated the diff for D89628: Fix constant-folding of overflowing arithmetic ops on vectors.

Fix the neutral value code path too.

Oct 17 2020, 1:30 PM · Restricted Project
LemonBoy updated the diff for D89628: Fix constant-folding of overflowing arithmetic ops on vectors.

Oh well, it turns out the results are evaluated according to all the elements so it's ok to splat it.

Oct 17 2020, 12:03 PM · Restricted Project
LemonBoy requested review of D89628: Fix constant-folding of overflowing arithmetic ops on vectors.
Oct 17 2020, 10:42 AM · Restricted Project

Oct 14 2020

LemonBoy updated the diff for D78658: [clang][Frontend] Add missing error handling.
Oct 14 2020, 6:01 AM · Restricted Project

Oct 13 2020

LemonBoy updated the diff for D78658: [clang][Frontend] Add missing error handling.

Use ScopeExit instead of a bare lambda.

Oct 13 2020, 2:29 PM · Restricted Project
LemonBoy added a comment to D78658: [clang][Frontend] Add missing error handling.

Perhaps this'd be more robust with ScopeExit?

Oct 13 2020, 7:19 AM · Restricted Project

Oct 10 2020

LemonBoy added a comment to D78658: [clang][Frontend] Add missing error handling.

Ping with some more reviewers, hoping to land this in time for LLVM 99.

Oct 10 2020, 8:39 AM · Restricted Project
LemonBoy added reviewers for D78658: [clang][Frontend] Add missing error handling: dblaikie, bkramer, JDevlieghere, dexonsmith.
Oct 10 2020, 8:38 AM · Restricted Project

Sep 24 2020

LemonBoy accepted D88261: [CodeGen] Do not call `emitGlobalConstantLargeInt` for constant requires 8 bytes to store.

LGTM, I typo'ed the comparison operator when I removed the switch. Sorry about that.

Sep 24 2020, 2:25 PM · Restricted Project

Jun 30 2020

LemonBoy added a comment to D78741: [LLD][ELF][AVR] Implement the missing relocation types.

@LemonBoy from your previous comment it looks like you don't intend to work on this further, is that correct? If so, are you okay with me taking over this patch, thus uploading this new patch for example?

Jun 30 2020, 2:08 AM · Restricted Project, lld

May 31 2020

LemonBoy added a comment to D78741: [LLD][ELF][AVR] Implement the missing relocation types.

I won't have time to update this diff in the near future so feel free to add the value range checks in a follow-up commit/patch.

May 31 2020, 1:02 PM · Restricted Project, lld