Page MenuHomePhabricator

LemonBoy (LemonBoy)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 10 2016, 2:52 PM (206 w, 4 d)

Recent Activity

Tue, Oct 20

LemonBoy updated subscribers of D89628: Don't fold overflowing arithmetic ops on vectors.

Looks good to me, thanks.

Tue, Oct 20, 1:40 PM · Restricted Project
LemonBoy updated the diff for D89628: Don't fold overflowing arithmetic ops on vectors.

Cleaned up the true/false building parts.
Added a note about LLVM not detecting if signed multiplication overflow, not much of a problem and can be fixed later.

Tue, Oct 20, 11:20 AM · Restricted Project
LemonBoy added a comment to D78658: [clang][Frontend] Add missing error handling.

Looks good to me - thanks!

Tue, Oct 20, 12:48 AM · Restricted Project

Sat, Oct 17

LemonBoy added a comment to D89628: Don't fold overflowing arithmetic ops on vectors.

Doesn't the same issue apply to the isNeutralValue branch?

Sat, Oct 17, 1:33 PM · Restricted Project
LemonBoy updated the diff for D89628: Don't fold overflowing arithmetic ops on vectors.

Fix the neutral value code path too.

Sat, Oct 17, 1:30 PM · Restricted Project
LemonBoy updated the diff for D89628: Don't fold overflowing arithmetic ops on vectors.

Oh well, it turns out the results are evaluated according to all the elements so it's ok to splat it.

Sat, Oct 17, 12:03 PM · Restricted Project
LemonBoy requested review of D89628: Don't fold overflowing arithmetic ops on vectors.
Sat, Oct 17, 10:42 AM · Restricted Project

Wed, Oct 14

LemonBoy updated the diff for D78658: [clang][Frontend] Add missing error handling.
Wed, Oct 14, 6:01 AM · Restricted Project

Tue, Oct 13

LemonBoy updated the diff for D78658: [clang][Frontend] Add missing error handling.

Use ScopeExit instead of a bare lambda.

Tue, Oct 13, 2:29 PM · Restricted Project
LemonBoy added a comment to D78658: [clang][Frontend] Add missing error handling.

Perhaps this'd be more robust with ScopeExit?

Tue, Oct 13, 7:19 AM · Restricted Project

Sat, Oct 10

LemonBoy added a comment to D78658: [clang][Frontend] Add missing error handling.

Ping with some more reviewers, hoping to land this in time for LLVM 99.

Sat, Oct 10, 8:39 AM · Restricted Project
LemonBoy added reviewers for D78658: [clang][Frontend] Add missing error handling: dblaikie, bkramer, JDevlieghere, dexonsmith.
Sat, Oct 10, 8:38 AM · Restricted Project

Sep 24 2020

LemonBoy accepted D88261: [CodeGen] Do not call `emitGlobalConstantLargeInt` for constant requires 8 bytes to store.

LGTM, I typo'ed the comparison operator when I removed the switch. Sorry about that.

Sep 24 2020, 2:25 PM · Restricted Project

Jun 30 2020

LemonBoy added a comment to D78741: [LLD][ELF][AVR] Implement the missing relocation types.

@LemonBoy from your previous comment it looks like you don't intend to work on this further, is that correct? If so, are you okay with me taking over this patch, thus uploading this new patch for example?

Jun 30 2020, 2:08 AM · Restricted Project, lld

May 31 2020

LemonBoy added a comment to D78741: [LLD][ELF][AVR] Implement the missing relocation types.

I won't have time to update this diff in the near future so feel free to add the value range checks in a follow-up commit/patch.

May 31 2020, 1:02 PM · Restricted Project, lld
LemonBoy abandoned D79038: [objcopy][ELF] Handle sections not contained in PT_LOAD segments.
May 31 2020, 1:02 PM · Restricted Project

May 20 2020

LemonBoy added a comment to D78658: [clang][Frontend] Add missing error handling.

Ping?

May 20 2020, 3:45 AM · Restricted Project

May 12 2020

LemonBoy added a comment to D79038: [objcopy][ELF] Handle sections not contained in PT_LOAD segments.

test does not make sense: .bss is not covered by a PT_LOAD.

That's the whole point of this patch, the binary that ptomptrd me to investigate why the binary image was so big has a single PT_LOAD segment covering only .text.

The description is also wrong now. I may say something like:

Sure thing, I actually forgot to update it.

Why does your executable have a .bss not covered by a PT_LOAD? I think it is invalid but I am open to justifications.

An alternative is to apply D74755. Last time I checked D74755 would fix your problem as well.

May 12 2020, 1:27 PM · Restricted Project

May 11 2020

LemonBoy added a comment to D78658: [clang][Frontend] Add missing error handling.

Ping?

May 11 2020, 2:38 AM · Restricted Project
LemonBoy added a comment to D78721: [LLVM][AVR] Support for R_AVR_6 fixup.

Nice work @LemonBoy, thanks for the patch.

May 11 2020, 12:29 AM · Restricted Project

May 9 2020

LemonBoy added a comment to D79038: [objcopy][ELF] Handle sections not contained in PT_LOAD segments.

Ping?

May 9 2020, 3:09 AM · Restricted Project

May 6 2020

LemonBoy added a comment to D79405: [SelectionDAG] Fix assertion failure with big shift amounts.

LGTM

May 6 2020, 7:30 AM · Restricted Project

May 5 2020

LemonBoy added a comment to D79405: [SelectionDAG] Fix assertion failure with big shift amounts.

Does the same issue exist in scalarizeVectorStore path?

May 5 2020, 11:20 AM · Restricted Project
LemonBoy created D79405: [SelectionDAG] Fix assertion failure with big shift amounts.
May 5 2020, 4:48 AM · Restricted Project
LemonBoy added a comment to D79096: [SelectionDAG] Unify scalarizeVectorLoad and VectorLegalizer::ExpandLoad.

@LemonBoy Please can you take a look at this fuzz regression, it looks like it appeared due to this patch: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22005

May 5 2020, 3:11 AM · Restricted Project

May 4 2020

LemonBoy added a comment to D78721: [LLVM][AVR] Support for R_AVR_6 fixup.

Ping?

May 4 2020, 9:37 AM · Restricted Project
LemonBoy added a comment to D78658: [clang][Frontend] Add missing error handling.

Ping?

May 4 2020, 9:37 AM · Restricted Project

May 3 2020

LemonBoy abandoned D78480: [SelectionDAG] Fix legalization of non-byte-sized vector.

Abandoned in favor of the already-merged D79096

May 3 2020, 12:13 PM · Restricted Project

May 1 2020

LemonBoy added a comment to D79038: [objcopy][ELF] Handle sections not contained in PT_LOAD segments.

test does not make sense: .bss is not covered by a PT_LOAD.

May 1 2020, 11:57 PM · Restricted Project
LemonBoy added a comment to D79096: [SelectionDAG] Unify scalarizeVectorLoad and VectorLegalizer::ExpandLoad.

I forgot you were going to reword that comment.

May 1 2020, 5:10 PM · Restricted Project
LemonBoy retitled D79038: [objcopy][ELF] Handle sections not contained in PT_LOAD segments from [objdump][ELF] Handle sections not contained in PT_LOAD segments to [objcopy][ELF] Handle sections not contained in PT_LOAD segments.
May 1 2020, 5:10 PM · Restricted Project
LemonBoy updated the diff for D79096: [SelectionDAG] Unify scalarizeVectorLoad and VectorLegalizer::ExpandLoad.

Amend a comment.

May 1 2020, 5:10 PM · Restricted Project
LemonBoy added a comment to D79038: [objcopy][ELF] Handle sections not contained in PT_LOAD segments.

with one comment nit

May 1 2020, 5:10 PM · Restricted Project

Apr 30 2020

LemonBoy updated the diff for D79038: [objcopy][ELF] Handle sections not contained in PT_LOAD segments.

Minor touchups for the test case.

Apr 30 2020, 3:06 PM · Restricted Project
LemonBoy added a comment to D79096: [SelectionDAG] Unify scalarizeVectorLoad and VectorLegalizer::ExpandLoad.

Its ok that they are garbage. Type legalization inserted the anyextend which allowed them to be garbage. Type legalization in the caller that consumes the vector result is responsible for clearing them if it needs to.

Apr 30 2020, 3:06 PM · Restricted Project
LemonBoy added inline comments to D79096: [SelectionDAG] Unify scalarizeVectorLoad and VectorLegalizer::ExpandLoad.
Apr 30 2020, 1:26 PM · Restricted Project
LemonBoy updated the diff for D79038: [objcopy][ELF] Handle sections not contained in PT_LOAD segments.

Simplify the patch by making sure PT_GNU_STACK segments cannot be considered parents of any section.

Apr 30 2020, 12:21 PM · Restricted Project
LemonBoy added inline comments to D79096: [SelectionDAG] Unify scalarizeVectorLoad and VectorLegalizer::ExpandLoad.
Apr 30 2020, 11:14 AM · Restricted Project
LemonBoy added a comment to D79038: [objcopy][ELF] Handle sections not contained in PT_LOAD segments.

What is actually the difference between them here?

Apr 30 2020, 9:35 AM · Restricted Project

Apr 29 2020

LemonBoy updated the diff for D79038: [objcopy][ELF] Handle sections not contained in PT_LOAD segments.

Fix a typo in the address calculation formula and fix the hexdump in the test case.

Apr 29 2020, 1:27 PM · Restricted Project
LemonBoy created D79096: [SelectionDAG] Unify scalarizeVectorLoad and VectorLegalizer::ExpandLoad.
Apr 29 2020, 9:06 AM · Restricted Project
LemonBoy added a comment to D79038: [objcopy][ELF] Handle sections not contained in PT_LOAD segments.

I don't understand the issue here personally

Apr 29 2020, 12:29 AM · Restricted Project

Apr 28 2020

LemonBoy created D79038: [objcopy][ELF] Handle sections not contained in PT_LOAD segments.
Apr 28 2020, 2:02 PM · Restricted Project

Apr 27 2020

LemonBoy added a comment to D77569: Lower fp16 ops to libcalls for SPARC targets.

Ping?

Apr 27 2020, 1:01 AM · Restricted Project
LemonBoy added a comment to D78658: [clang][Frontend] Add missing error handling.

Ping?

Apr 27 2020, 12:29 AM · Restricted Project

Apr 24 2020

LemonBoy added a comment to D78011: [AsmPrinter] Fix emission of non-standard integer constants for BE targets.

Yeah, that's fine

Apr 24 2020, 2:07 PM · Restricted Project
LemonBoy added a comment to D78011: [AsmPrinter] Fix emission of non-standard integer constants for BE targets.

Ping?

Apr 24 2020, 9:43 AM · Restricted Project
LemonBoy updated the summary of D78480: [SelectionDAG] Fix legalization of non-byte-sized vector.
Apr 24 2020, 3:45 AM · Restricted Project
LemonBoy updated the diff for D78480: [SelectionDAG] Fix legalization of non-byte-sized vector.

Something less invasive that doesn't affect the codegen while fixing the problem.

Apr 24 2020, 3:13 AM · Restricted Project

Apr 23 2020

LemonBoy added a comment to D78741: [LLD][ELF][AVR] Implement the missing relocation types.

Similar question: where can we find the psABI?

Apr 23 2020, 1:33 PM · Restricted Project, lld
LemonBoy created D78741: [LLD][ELF][AVR] Implement the missing relocation types.
Apr 23 2020, 12:28 PM · Restricted Project, lld
LemonBoy created D78721: [LLVM][AVR] Support for R_AVR_6 fixup.
Apr 23 2020, 9:11 AM · Restricted Project

Apr 22 2020

LemonBoy updated the diff for D78658: [clang][Frontend] Add missing error handling.

Fix a C&P error in the attached test case.

Apr 22 2020, 1:37 PM · Restricted Project
LemonBoy created D78658: [clang][Frontend] Add missing error handling.
Apr 22 2020, 11:58 AM · Restricted Project

Apr 20 2020

LemonBoy created D78480: [SelectionDAG] Fix legalization of non-byte-sized vector.
Apr 20 2020, 3:43 AM · Restricted Project

Apr 17 2020

LemonBoy added a comment to D62475: [DebugInfo] Change DIEnumerator payload type from int64_t to APInt.

Since I have no commit access feel free to land this patch if you're satisfied with its current state.

Apr 17 2020, 12:25 PM · debug-info, Restricted Project
LemonBoy updated the summary of D62475: [DebugInfo] Change DIEnumerator payload type from int64_t to APInt.
Apr 17 2020, 11:55 AM · debug-info, Restricted Project
LemonBoy added a comment to D77946: [PowerPC] Don't use rldicl when targeting 32bit CPUs.

Can you (or anyone) commit this on my behalf? I don't have commit access.

Apr 17 2020, 4:17 AM · Restricted Project
LemonBoy added a comment to D77672: [ELF] Support a few more SPARCv9 relocations.

Can you (or anyone) commit this on my behalf? I don't have commit access.

Apr 17 2020, 4:17 AM · Restricted Project
LemonBoy updated the diff for D62475: [DebugInfo] Change DIEnumerator payload type from int64_t to APInt.
  • Added an bc upgrade test
  • Cleaned up some code according to the review comments
  • Cleaned up some test cases
Apr 17 2020, 4:17 AM · debug-info, Restricted Project
LemonBoy added a comment to D78011: [AsmPrinter] Fix emission of non-standard integer constants for BE targets.

Can you (or anyone) commit this on my behalf? I don't have commit access.

Apr 17 2020, 4:17 AM · Restricted Project

Apr 16 2020

LemonBoy added inline comments to D62475: [DebugInfo] Change DIEnumerator payload type from int64_t to APInt.
Apr 16 2020, 3:56 AM · debug-info, Restricted Project
LemonBoy added a reviewer for D77946: [PowerPC] Don't use rldicl when targeting 32bit CPUs: hfinkel.
Apr 16 2020, 12:47 AM · Restricted Project

Apr 15 2020

LemonBoy updated the diff for D78193: [Sparc] Fixes for the internal assembler.
Apr 15 2020, 9:16 AM · Restricted Project
LemonBoy created D78193: [Sparc] Fixes for the internal assembler.
Apr 15 2020, 4:20 AM · Restricted Project
LemonBoy added a reviewer for D78011: [AsmPrinter] Fix emission of non-standard integer constants for BE targets: qcolombet.
Apr 15 2020, 2:08 AM · Restricted Project

Apr 14 2020

LemonBoy updated the diff for D77672: [ELF] Support a few more SPARCv9 relocations.

Minor changes to the test case.

Apr 14 2020, 11:57 PM · Restricted Project
LemonBoy updated the diff for D77672: [ELF] Support a few more SPARCv9 relocations.

I really hate phabricator

Apr 14 2020, 12:24 PM · Restricted Project
LemonBoy updated the diff for D77672: [ELF] Support a few more SPARCv9 relocations.
Apr 14 2020, 12:24 PM · Restricted Project

Apr 13 2020

LemonBoy set the repository for D77946: [PowerPC] Don't use rldicl when targeting 32bit CPUs to rG LLVM Github Monorepo.
Apr 13 2020, 3:44 AM · Restricted Project
LemonBoy set the repository for D78011: [AsmPrinter] Fix emission of non-standard integer constants for BE targets to rG LLVM Github Monorepo.
Apr 13 2020, 3:44 AM · Restricted Project
LemonBoy created D78011: [AsmPrinter] Fix emission of non-standard integer constants for BE targets.
Apr 13 2020, 3:44 AM · Restricted Project

Apr 12 2020

LemonBoy added a reviewer for D77569: Lower fp16 ops to libcalls for SPARC targets: jyknight.
Apr 12 2020, 2:39 AM · Restricted Project

Apr 11 2020

LemonBoy added a comment to D77672: [ELF] Support a few more SPARCv9 relocations.

Can you refer me to the sparc psABI so that I can verify the implementation?

Apr 11 2020, 3:28 PM · Restricted Project
LemonBoy created D77946: [PowerPC] Don't use rldicl when targeting 32bit CPUs.
Apr 11 2020, 9:35 AM · Restricted Project
LemonBoy added a comment to D68237: [PowerPC] Handle f16 as a storage type only.

Ping? Is this ready to land?

Apr 11 2020, 12:30 AM · Restricted Project

Apr 10 2020

LemonBoy updated the diff for D77672: [ELF] Support a few more SPARCv9 relocations.
Apr 10 2020, 2:40 AM · Restricted Project

Apr 8 2020

LemonBoy updated the diff for D77737: [SPARC] Recognize and handle the %lm(sym) operator.

Applied the suggested clang-format diff.

Apr 8 2020, 10:18 AM · Restricted Project
LemonBoy created D77737: [SPARC] Recognize and handle the %lm(sym) operator.
Apr 8 2020, 9:12 AM · Restricted Project
LemonBoy updated the diff for D77672: [ELF] Support a few more SPARCv9 relocations.

I've added a few tests that cover the newly-added relocations plus a few more, R_SPARC_LM22 is not yet tested because LLVM as doesn't recognize it but I already have a patch ready for that.

Apr 8 2020, 3:12 AM · Restricted Project
LemonBoy updated the diff for D77672: [ELF] Support a few more SPARCv9 relocations.
Apr 8 2020, 3:12 AM · Restricted Project

Apr 7 2020

LemonBoy created D77672: [ELF] Support a few more SPARCv9 relocations.
Apr 7 2020, 12:31 PM · Restricted Project

Apr 6 2020

LemonBoy created D77569: Lower fp16 ops to libcalls for SPARC targets.
Apr 6 2020, 10:18 AM · Restricted Project

Dec 28 2019

LemonBoy added a comment to D71942: Update LLVMCallConv.

Is there any chance to backport this into LLVM 9.0.1?

Dec 28 2019, 2:13 PM · Restricted Project

Dec 27 2019

LemonBoy created D71942: Update LLVMCallConv.
Dec 27 2019, 10:53 AM · Restricted Project

May 30 2019

LemonBoy added a comment to D62185: [mach-o] Extend LC_DATA_IN_CODE support to x86_64.

Friendly ping after ~1week

May 30 2019, 1:22 PM · Restricted Project

May 27 2019

LemonBoy updated the diff for D62475: [DebugInfo] Change DIEnumerator payload type from int64_t to APInt.

Oops, I had attached the wrong .patch file.

May 27 2019, 5:48 AM · debug-info, Restricted Project
LemonBoy created D62475: [DebugInfo] Change DIEnumerator payload type from int64_t to APInt.
May 27 2019, 2:14 AM · debug-info, Restricted Project

May 21 2019

LemonBoy added a reviewer for D62185: [mach-o] Extend LC_DATA_IN_CODE support to x86_64: kledzik.
May 21 2019, 5:55 AM · Restricted Project
LemonBoy created D62185: [mach-o] Extend LC_DATA_IN_CODE support to x86_64.
May 21 2019, 3:53 AM · Restricted Project

Dec 8 2016

LemonBoy added inline comments to D26581: Make WholeProgramDevirt understand ConstStruct vtables..
Dec 8 2016, 12:04 PM
LemonBoy updated the diff for D26581: Make WholeProgramDevirt understand ConstStruct vtables..
Dec 8 2016, 12:02 PM

Nov 28 2016

LemonBoy updated the diff for D26581: Make WholeProgramDevirt understand ConstStruct vtables..
Nov 28 2016, 2:19 PM
LemonBoy added inline comments to D26581: Make WholeProgramDevirt understand ConstStruct vtables..
Nov 28 2016, 2:10 PM
LemonBoy updated the diff for D26581: Make WholeProgramDevirt understand ConstStruct vtables..
Nov 28 2016, 2:08 PM

Nov 13 2016

LemonBoy added a reviewer for D26581: Make WholeProgramDevirt understand ConstStruct vtables.: pcc.
Nov 13 2016, 2:48 AM

Nov 12 2016

LemonBoy retitled D26581: Make WholeProgramDevirt understand ConstStruct vtables. from to Make WholeProgramDevirt understand ConstStruct vtables..
Nov 12 2016, 7:04 AM