Page MenuHomePhabricator

iii (Ilya Leoshkevich)
Linux on IBM Z development

Projects

User does not belong to any projects.

User Details

User Since
Oct 24 2019, 7:17 AM (31 w, 7 h)

Recent Activity

Apr 22 2020

iii created D78644: [LSan] Enable for SystemZ.
Apr 22 2020, 8:38 AM · Restricted Project, Restricted Project

Apr 16 2020

iii committed rG921009e66798: [MSan] Enable for SystemZ (authored by iii).
[MSan] Enable for SystemZ
Apr 16 2020, 3:24 AM
iii closed D76358: [MSan] Enable for SystemZ.
Apr 16 2020, 3:23 AM · Restricted Project

Apr 15 2020

iii updated the summary of D76358: [MSan] Enable for SystemZ.
Apr 15 2020, 5:26 AM · Restricted Project
iii added a comment to D76358: [MSan] Enable for SystemZ.

@eugenis I slightly improved the tests - could you have another look please?

Apr 15 2020, 3:47 AM · Restricted Project

Apr 14 2020

iii updated the diff for D76358: [MSan] Enable for SystemZ.

Instead of checking only top frame, compile tests with
-mbackchain, like we already do for ASan and UBSan.

Apr 14 2020, 4:45 AM · Restricted Project

Apr 10 2020

iii committed rG3bc439bdff8b: [MSan] Add instrumentation for SystemZ (authored by iii).
[MSan] Add instrumentation for SystemZ
Apr 10 2020, 7:56 AM
iii closed D76624: [MSan] Add instrumentation for SystemZ.
Apr 10 2020, 7:56 AM · Restricted Project

Apr 9 2020

iii added inline comments to D76624: [MSan] Add instrumentation for SystemZ.
Apr 9 2020, 12:14 PM · Restricted Project
iii added a comment to D76624: [MSan] Add instrumentation for SystemZ.

@eugenis now that VarArgSystemZHelper part seems to be in order, could you please have another look?

Apr 9 2020, 5:23 AM · Restricted Project
iii updated the diff for D76624: [MSan] Add instrumentation for SystemZ.

Introduced ArgKind::Indirect.

Apr 9 2020, 4:18 AM · Restricted Project
iii updated the diff for D76624: [MSan] Add instrumentation for SystemZ.

Added i128 handling and a test for it.

Apr 9 2020, 2:40 AM · Restricted Project

Apr 8 2020

iii updated the diff for D76624: [MSan] Add instrumentation for SystemZ.

Added fp128 handling and a test for it.

Apr 8 2020, 2:41 PM · Restricted Project
iii committed rGaaba9a776150: [compiler-rt] Don't use __libc_stack_end on ARM (authored by iii).
[compiler-rt] Don't use __libc_stack_end on ARM
Apr 8 2020, 5:56 AM
iii closed D77400: [compiler-rt] Don't use __libc_stack_end on ARM.
Apr 8 2020, 5:56 AM · Restricted Project

Apr 4 2020

iii removed a child revision for D76358: [MSan] Enable for SystemZ: D77400: [compiler-rt] Don't use __libc_stack_end on ARM.
Apr 4 2020, 2:22 PM · Restricted Project
iii removed a parent revision for D77400: [compiler-rt] Don't use __libc_stack_end on ARM: D76358: [MSan] Enable for SystemZ.
Apr 4 2020, 2:22 PM · Restricted Project
iii updated the diff for D77400: [compiler-rt] Don't use __libc_stack_end on ARM.

Applied the formatting fix, got rid of bogus D76358 dependency.

Apr 4 2020, 2:22 PM · Restricted Project
iii updated the summary of D77400: [compiler-rt] Don't use __libc_stack_end on ARM.
Apr 4 2020, 2:22 PM · Restricted Project

Apr 3 2020

iii committed rG6897111231e7: [MSan] Add COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED (authored by iii).
[MSan] Add COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED
Apr 3 2020, 8:36 AM
iii closed D76969: [MSan] Add COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED.
Apr 3 2020, 8:36 AM · Restricted Project
iii created D77400: [compiler-rt] Don't use __libc_stack_end on ARM.
Apr 3 2020, 8:02 AM · Restricted Project
iii added a child revision for D76358: [MSan] Enable for SystemZ: D77400: [compiler-rt] Don't use __libc_stack_end on ARM.
Apr 3 2020, 8:02 AM · Restricted Project

Apr 2 2020

iii updated the diff for D76624: [MSan] Add instrumentation for SystemZ.

Resolved shadow zext/sext TODO using CreateShadowCast.
Resolved softfloat TODO using getFnAttribute("use-soft-float").
Added shadow propagation checks to tests.

Apr 2 2020, 3:11 PM · Restricted Project

Apr 1 2020

iii updated the diff for D76624: [MSan] Add instrumentation for SystemZ.

Implemented Ulrich's suggestions.

Apr 1 2020, 5:27 PM · Restricted Project
iii added inline comments to D76624: [MSan] Add instrumentation for SystemZ.
Apr 1 2020, 5:26 PM · Restricted Project

Mar 27 2020

iii created D76969: [MSan] Add COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED.
Mar 27 2020, 8:23 PM · Restricted Project
iii committed rGfad47d222561: [compiler-rt] Fall back to internal_uname() when called early (authored by iii).
[compiler-rt] Fall back to internal_uname() when called early
Mar 27 2020, 7:19 PM
iii closed D76919: [compiler-rt] Fall back to internal_uname() when called early.
Mar 27 2020, 7:19 PM · Restricted Project
iii added a comment to D76919: [compiler-rt] Fall back to internal_uname() when called early.

internal_uname() is available only on Linux right now. I thought it's ok to postpone adding macOS/*BSD/etc implementations until that is really necessary.

Mar 27 2020, 3:27 PM · Restricted Project
iii added a comment to D76919: [compiler-rt] Fall back to internal_uname() when called early.

msan does not call Symbolizer::LateInitialize(), which is Symbolizer::GetOrInit() + InitializeSwiftDemangler(). It calls only Symbolizer::GetOrInit(), and it's exactly InitializeSwiftDemangler() that triggers dlerror(). So for now it looks safe, but not particularly future-proof. #define COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED (!msan_inited) might be a good idea. Should I try to do this here, or separately?

Mar 27 2020, 12:01 PM · Restricted Project
iii created D76919: [compiler-rt] Fall back to internal_uname() when called early.
Mar 27 2020, 5:24 AM · Restricted Project

Mar 26 2020

iii added a comment to D76578: [compiler-rt] Intercept the uname() function.

I've installed stretch and hit the following issue:

Mar 26 2020, 7:37 PM · Restricted Project
iii added a comment to D76578: [compiler-rt] Intercept the uname() function.

I'll check. I was hoping this was already fixed by https://reviews.llvm.org/D76776, but the last build http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/26367 already contains that commit, and yet it still fails with the same symptoms.

Mar 26 2020, 1:02 PM · Restricted Project

Mar 25 2020

iii retitled D76776: [compiler-rt] Use uname syscall in GetKernelAreaSize() from [compiler-rt] Use real uname() in GetKernelAreaSize() to [compiler-rt] Use uname syscall in GetKernelAreaSize().
Mar 25 2020, 1:32 PM · Restricted Project
iii updated the diff for D76776: [compiler-rt] Use uname syscall in GetKernelAreaSize().

Use uname syscall. Don't try olduname and oldolduname fallbacks until we know we need them.

Mar 25 2020, 1:32 PM · Restricted Project
iii added a comment to D76776: [compiler-rt] Use uname syscall in GetKernelAreaSize().

Ok, I can do that.

Mar 25 2020, 1:32 PM · Restricted Project
iii created D76776: [compiler-rt] Use uname syscall in GetKernelAreaSize().
Mar 25 2020, 8:04 AM · Restricted Project

Mar 24 2020

iii updated the diff for D76624: [MSan] Add instrumentation for SystemZ.

Fixed a typo in vararg.ll test.

Mar 24 2020, 2:00 PM · Restricted Project
iii updated the summary of D76624: [MSan] Add instrumentation for SystemZ.
Mar 24 2020, 11:50 AM · Restricted Project
iii updated the diff for D76624: [MSan] Add instrumentation for SystemZ.

Added a test for zext attribute to msan_basic.ll, added missing CHECK-LABEL: @many_args.

Mar 24 2020, 11:49 AM · Restricted Project
iii added a comment to D76576: [asan] Fix read_binary_name_regtest.c test dying with SIGPIPE.

Come to think of it, the most important thing actually must be that this is with -DBUILD_SHARED_LIBS=ON. I don't think static builds are affected.

Mar 24 2020, 10:45 AM · Restricted Project
iii added a comment to D76576: [asan] Fix read_binary_name_regtest.c test dying with SIGPIPE.

It fails for me both on x86_64 and s390x.
I think there might be a race: if we manage to write CODE lines before llvm-symbolizer exits, we just get a "Failed to use and restart external symbolizer" message.
However, if we write at a later point in time, we get a SIGPIPE.

Mar 24 2020, 10:11 AM · Restricted Project

Mar 23 2020

iii retitled D76358: [MSan] Enable for SystemZ from [MSan] Enable MSAN for SystemZ to [MSan] Enable for SystemZ.
Mar 23 2020, 9:48 AM · Restricted Project
iii updated the diff for D76358: [MSan] Enable for SystemZ.

Split out mmap (already landed), uname and instrumentation
changes.

Mar 23 2020, 9:48 AM · Restricted Project
iii created D76624: [MSan] Add instrumentation for SystemZ.
Mar 23 2020, 9:48 AM · Restricted Project
iii updated the diff for D76578: [compiler-rt] Intercept the uname() function.

Introduced SANITIZER_INTERCEPT___XUNAME

Mar 23 2020, 4:20 AM · Restricted Project

Mar 22 2020

iii created D76578: [compiler-rt] Intercept the uname() function.
Mar 22 2020, 4:06 PM · Restricted Project
iii created D76576: [asan] Fix read_binary_name_regtest.c test dying with SIGPIPE.
Mar 22 2020, 3:34 PM · Restricted Project

Mar 19 2020

iii added inline comments to D76358: [MSan] Enable for SystemZ.
Mar 19 2020, 5:00 PM · Restricted Project
iii added inline comments to D76358: [MSan] Enable for SystemZ.
Mar 19 2020, 1:09 PM · Restricted Project
iii added a comment to D76426: [MSan] Simulate OOM in mmap_interceptor().

Thanks for reviewing! I don't think I have commit access - may I ask you to commit this one for me?

Mar 19 2020, 1:09 PM · Restricted Project
iii added inline comments to D76358: [MSan] Enable for SystemZ.
Mar 19 2020, 5:21 AM · Restricted Project
iii created D76426: [MSan] Simulate OOM in mmap_interceptor().
Mar 19 2020, 5:21 AM · Restricted Project

Mar 18 2020

iii created D76358: [MSan] Enable for SystemZ.
Mar 18 2020, 6:30 AM · Restricted Project