Page MenuHomePhabricator

iii (Ilya Leoshkevich)
Linux on IBM Z development

Projects

User does not belong to any projects.

User Details

User Since
Oct 24 2019, 7:17 AM (146 w, 2 d)

Recent Activity

Fri, Jul 22

iii committed rG0d89963df354: [Lit] Pass through DFLTCC from the surrounding environment (authored by iii).
[Lit] Pass through DFLTCC from the surrounding environment
Fri, Jul 22, 4:39 PM · Restricted Project, Restricted Project
iii closed D130253: [Lit] Pass through DFLTCC from the surrounding environment.
Fri, Jul 22, 4:39 PM · Restricted Project, Restricted Project

Thu, Jul 21

iii requested review of D130253: [Lit] Pass through DFLTCC from the surrounding environment.
Thu, Jul 21, 5:02 AM · Restricted Project, Restricted Project

May 12 2022

iii added a comment to D125454: [compiler-rt] Add missing NO_EXEC_STACK_DIRECTIVE to tsan_rtl_s390x.S.

I don't think so. First of all, this is on another architecture; and then I tried running this test on both x86_64 and s390x with your change, and it succeeded in both cases for me.

May 12 2022, 3:19 PM · Restricted Project, Restricted Project
iii accepted D125454: [compiler-rt] Add missing NO_EXEC_STACK_DIRECTIVE to tsan_rtl_s390x.S.

Thanks for catching this! LGTM.

May 12 2022, 5:03 AM · Restricted Project, Restricted Project

May 2 2022

iii committed rG7070c6a96b41: [SystemZ] Accept (. - 0x100000000) PCRel32 constants (authored by iii).
[SystemZ] Accept (. - 0x100000000) PCRel32 constants
May 2 2022, 11:58 AM · Restricted Project, Restricted Project
iii closed D124780: [SystemZ] Accept (. - 0x100000000) PCRel32 constants.
May 2 2022, 11:58 AM · Restricted Project, Restricted Project
iii requested review of D124780: [SystemZ] Accept (. - 0x100000000) PCRel32 constants.
May 2 2022, 9:42 AM · Restricted Project, Restricted Project

Jul 15 2021

iii added a comment to D100048: [lldb][Editline] Fix crash when navigating through empty command history..

lldb-arm-ubuntu (https://lab.llvm.org/buildbot/#/builders/17/builds/9015) fails with:

Jul 15 2021, 4:13 AM · Restricted Project
iii added a comment to D105806: [LV] Print remark when loop cannot be vectorized due to invalid costs..

llvm-clang-x86_64-expensive-checks-debian (https://lab.llvm.org/buildbot/#/builders/16/builds/13741) fails with:

Jul 15 2021, 3:39 AM · Restricted Project
iii committed rG9bf2e7eeebbd: [TSan] Add SystemZ SANITIZER_GO support (authored by iii).
[TSan] Add SystemZ SANITIZER_GO support
Jul 15 2021, 3:20 AM
iii committed rGe34078f121a5: [TSan] Enable SystemZ support (authored by iii).
[TSan] Enable SystemZ support
Jul 15 2021, 3:20 AM
iii committed rG937242cecc13: [TSan] Adjust tests for SystemZ (authored by iii).
[TSan] Adjust tests for SystemZ
Jul 15 2021, 3:20 AM
iii committed rGbd77f742d656: [TSan] Intercept __tls_get_addr_internal and __tls_get_offset on SystemZ (authored by iii).
[TSan] Intercept __tls_get_addr_internal and __tls_get_offset on SystemZ
Jul 15 2021, 3:20 AM
iii committed rGb17673816d7f: [TSan] Disable __TSAN_HAS_INT128 on SystemZ (authored by iii).
[TSan] Disable __TSAN_HAS_INT128 on SystemZ
Jul 15 2021, 3:20 AM
iii committed rG402fc790eb48: [TSan] Add SystemZ longjmp support (authored by iii).
[TSan] Add SystemZ longjmp support
Jul 15 2021, 3:20 AM
iii committed rG96a29df0b166: [TSan] Define C/C++ address ranges for SystemZ (authored by iii).
[TSan] Define C/C++ address ranges for SystemZ
Jul 15 2021, 3:19 AM
iii committed rGfab044045b63: [TSan] Define PTHREAD_ABI_BASE for SystemZ (authored by iii).
[TSan] Define PTHREAD_ABI_BASE for SystemZ
Jul 15 2021, 3:19 AM
iii committed rGd5c34ee5b666: [TSan] Build ignore_lib{0,1,5} tests with -fno-builtin (authored by iii).
[TSan] Build ignore_lib{0,1,5} tests with -fno-builtin
Jul 15 2021, 3:19 AM
iii committed rG3845f2cd940b: [TSan] Use zeroext for function parameters (authored by iii).
[TSan] Use zeroext for function parameters
Jul 15 2021, 3:19 AM
iii committed rGcadbb9241627: [TSan] Align thread_registry_placeholder (authored by iii).
[TSan] Align thread_registry_placeholder
Jul 15 2021, 3:19 AM
iii committed rG54128b73f833: [sanitizer] Force TLS allocation on s390 (authored by iii).
[sanitizer] Force TLS allocation on s390
Jul 15 2021, 3:19 AM
iii committed rGacf0a6428681: [sanitizer] Fix __sanitizer_kernel_sigset_t endianness issue (authored by iii).
[sanitizer] Fix __sanitizer_kernel_sigset_t endianness issue
Jul 15 2021, 3:19 AM
iii closed D105629: [TSan] Add SystemZ support.
Jul 15 2021, 3:19 AM · Restricted Project, Restricted Project, Restricted Project

Jul 13 2021

iii updated the diff for D105629: [TSan] Add SystemZ support.
  • Fix style issues (seems like arc diff is linting only the top commit?).
Jul 13 2021, 2:48 PM · Restricted Project, Restricted Project, Restricted Project
iii updated the diff for D105629: [TSan] Add SystemZ support.

Based on Ulrich's feedback I tested the series on RHEL7, which, in
addition to an old kernel, contains an old glibc and an old toolchain.
This uncovered a few extra issues, which are fixed here:

Jul 13 2021, 11:19 AM · Restricted Project, Restricted Project, Restricted Project
iii added inline comments to D105629: [TSan] Add SystemZ support.
Jul 13 2021, 3:31 AM · Restricted Project, Restricted Project, Restricted Project
iii added inline comments to D105629: [TSan] Add SystemZ support.
Jul 13 2021, 2:41 AM · Restricted Project, Restricted Project, Restricted Project

Jul 12 2021

iii added a comment to D105629: [TSan] Add SystemZ support.

Regarding the openmp test failures: I tried check-openmp on a x86_64 machine, and they occur both with and without this patch series, so must be unrelated.

Jul 12 2021, 6:00 AM · Restricted Project, Restricted Project, Restricted Project
iii added inline comments to D105629: [TSan] Add SystemZ support.
Jul 12 2021, 4:02 AM · Restricted Project, Restricted Project, Restricted Project
iii updated the diff for D105629: [TSan] Add SystemZ support.
  • Fix a local variable naming issue CheckAndProtect().
Jul 12 2021, 3:55 AM · Restricted Project, Restricted Project, Restricted Project

Jul 9 2021

iii updated the diff for D105629: [TSan] Add SystemZ support.
  • Reserve the address space "tail" in the "[TSan] Define C/C++ address ranges for SystemZ" patch.
  • Drop the "[TSan] Simulate OOM in mmap_interceptor()" patch.
  • Group "[TSan] Use zeroext for function parameters" with the common code patches.
Jul 9 2021, 3:59 AM · Restricted Project, Restricted Project, Restricted Project

Jul 8 2021

iii updated subscribers of D105629: [TSan] Add SystemZ support.
Jul 8 2021, 7:32 AM · Restricted Project, Restricted Project, Restricted Project
iii requested review of D105629: [TSan] Add SystemZ support.
Jul 8 2021, 7:05 AM · Restricted Project, Restricted Project, Restricted Project

Mar 5 2021

iii committed rGa7137b238a07: [BPF] Add support for floats and doubles (authored by iii).
[BPF] Add support for floats and doubles
Mar 5 2021, 6:11 AM
iii closed D83289: [BPF] Add support for floats and doubles.
Mar 5 2021, 6:11 AM · Restricted Project

Feb 15 2021

iii retitled D83289: [BPF] Add support for floats and doubles from [BPF] Emit unknown types as byte arrays to [BPF] Add support for floats and doubles.
Feb 15 2021, 5:21 PM · Restricted Project
iii updated the diff for D83289: [BPF] Add support for floats and doubles.

Removed an unnecessary trailing u32.

Feb 15 2021, 5:02 PM · Restricted Project

Feb 8 2021

iii updated the diff for D83289: [BPF] Add support for floats and doubles.

Hi, it has been a long time, but I've finally implemented the support
for the floating-point types in BTF. Here are the other pieces:

Feb 8 2021, 10:08 AM · Restricted Project

Dec 8 2020

iii committed rGd58f112ce038: Prevent FENTRY_CALL reordering (authored by iii).
Prevent FENTRY_CALL reordering
Dec 8 2020, 4:02 PM
iii closed D91218: Prevent FENTRY_CALL reordering.
Dec 8 2020, 4:01 PM · Restricted Project

Nov 30 2020

iii added a comment to D91218: Prevent FENTRY_CALL reordering.

Ping.

Nov 30 2020, 4:39 AM · Restricted Project

Nov 23 2020

iii updated the diff for D91218: Prevent FENTRY_CALL reordering.
  • Fixed a typo in a comment.
  • Rebased.
Nov 23 2020, 6:23 AM · Restricted Project

Nov 11 2020

iii updated the diff for D91218: Prevent FENTRY_CALL reordering.
  • Do not use FileCheck in fentry-debug-info.ll.
Nov 11 2020, 10:27 AM · Restricted Project
iii updated the summary of D91218: Prevent FENTRY_CALL reordering.
Nov 11 2020, 8:52 AM · Restricted Project
iii updated the diff for D91218: Prevent FENTRY_CALL reordering.
  • Don't put FENTRY_CALL in a separate MBB.
Nov 11 2020, 8:52 AM · Restricted Project
iii added a comment to D91218: Prevent FENTRY_CALL reordering.

I guess you are right - cross-bb optimizations can still mess with it they want to. Let's do just isCall here and solve other problems when/if they arise.

Nov 11 2020, 7:18 AM · Restricted Project
iii added a comment to D91218: Prevent FENTRY_CALL reordering.
In D91218#2388401, @iii wrote:
  • Add isCall to FENTRY_CALL in Target.td.

Do you still need to create the extra basic block?

Nov 11 2020, 6:25 AM · Restricted Project
iii retitled D91218: Prevent FENTRY_CALL reordering from [SystemZ] Prevent fentry reordering to Prevent FENTRY_CALL reordering.
Nov 11 2020, 4:54 AM · Restricted Project
iii updated the diff for D91218: Prevent FENTRY_CALL reordering.
  • Add isCall to FENTRY_CALL in Target.td.
Nov 11 2020, 4:53 AM · Restricted Project
iii added reviewers for D91218: Prevent FENTRY_CALL reordering: niravd, hfinkel, craig.topper.
Nov 11 2020, 4:35 AM · Restricted Project
iii added a comment to D91218: Prevent FENTRY_CALL reordering.

An alternative fix would be to modify isSchedulingBoundary() to accept FENTRY_CALL, but this would have questionable semantics.

Did you try to add the isCall flag to the instruction in Target.td? That should make it a scheduling boundary...

Nov 11 2020, 4:30 AM · Restricted Project

Nov 10 2020

iii updated subscribers of D91218: Prevent FENTRY_CALL reordering.
Nov 10 2020, 4:13 PM · Restricted Project
iii requested review of D91218: Prevent FENTRY_CALL reordering.
Nov 10 2020, 3:53 PM · Restricted Project

Aug 25 2020

iii committed rG151f60319966: [libFuzzer] Un-XFAIL msan.test on SystemZ (authored by iii).
[libFuzzer] Un-XFAIL msan.test on SystemZ
Aug 25 2020, 6:02 AM
iii closed D86184: [libFuzzer] Un-XFAIL msan.test on SystemZ.
Aug 25 2020, 6:02 AM · Restricted Project

Aug 24 2020

iii retitled D86184: [libFuzzer] Un-XFAIL msan.test on SystemZ from [libFuzzer] Use 100m runs for SimpleCmpTest in msan.test to [libFuzzer] Un-XFAIL msan.test on SystemZ.
Aug 24 2020, 12:48 PM · Restricted Project
iii updated the diff for D86184: [libFuzzer] Un-XFAIL msan.test on SystemZ.
  • D86382 works - so changing the patch to simply un-XFAIL the test.
Aug 24 2020, 12:19 PM · Restricted Project

Aug 19 2020

iii added a comment to D86184: [libFuzzer] Un-XFAIL msan.test on SystemZ.

Hm, it actually looks fairly simple as is: just a bunch of comparisons of unmodified ints from the input buffer with constants. So I would expect Mutate_AddWordFromTORC to help solving it this fairly quickly. Do you have an idea why this might not be happening? Maybe it could be worth looking into it a bit deeper.

Aug 19 2020, 5:45 PM · Restricted Project

Aug 18 2020

iii requested review of D86184: [libFuzzer] Un-XFAIL msan.test on SystemZ.
Aug 18 2020, 6:01 PM · Restricted Project

Aug 12 2020

iii committed rGeca4b4007d6b: [Sanitizer] Fix segfaults during unwinding on SystemZ (authored by iii).
[Sanitizer] Fix segfaults during unwinding on SystemZ
Aug 12 2020, 1:25 PM
iii closed D85822: [Sanitizer] Fix segfaults during unwinding on SystemZ.
Aug 12 2020, 1:24 PM · Restricted Project
iii committed rGf5a252ed681c: [SanitizerCoverage] Use zeroext for cmp parameters on all targets (authored by iii).
[SanitizerCoverage] Use zeroext for cmp parameters on all targets
Aug 12 2020, 9:38 AM
iii closed D85689: [SanitizerCoverage] Use zeroext for cmp parameters on all targets.
Aug 12 2020, 9:38 AM · Restricted Project, Restricted Project
iii added a reviewer for D85689: [SanitizerCoverage] Use zeroext for cmp parameters on all targets: morehouse.
Aug 12 2020, 2:25 AM · Restricted Project, Restricted Project
iii added a comment to D85689: [SanitizerCoverage] Use zeroext for cmp parameters on all targets.

All 3 test failures here are in unrelated areas and must be preexisting.

Aug 12 2020, 2:24 AM · Restricted Project, Restricted Project
iii requested review of D85822: [Sanitizer] Fix segfaults during unwinding on SystemZ.
Aug 12 2020, 2:23 AM · Restricted Project

Aug 11 2020

iii committed rG9df7ee34e1b5: [libFuzzer] Fix minimizing timeouts (authored by iii).
[libFuzzer] Fix minimizing timeouts
Aug 11 2020, 1:17 PM
iii closed D85359: [libFuzzer] Fix minimizing timeouts.
Aug 11 2020, 1:16 PM · Restricted Project

Aug 10 2020

iii added a comment to D85359: [libFuzzer] Fix minimizing timeouts.

The failing test is libFuzzer :: cleanse.test, but I don't think this is due to my patch - it doesn't fail locally, and it didn't fail the last time. I wonder if build machines do parallel builds? If yes, then the following code might be the culprit:

Aug 10 2020, 3:02 PM · Restricted Project
iii requested review of D85689: [SanitizerCoverage] Use zeroext for cmp parameters on all targets.
Aug 10 2020, 2:22 PM · Restricted Project, Restricted Project
iii updated the diff for D85359: [libFuzzer] Fix minimizing timeouts.
  • Added a test.
  • Moved Alrm after Abrt in order to maintain the alphabetic order.
Aug 10 2020, 4:11 AM · Restricted Project

Aug 5 2020

iii requested review of D85359: [libFuzzer] Fix minimizing timeouts.
Aug 5 2020, 1:57 PM · Restricted Project

Aug 4 2020

iii closed D84913: [libFuzzer] Enable for SystemZ.

I've committed with HostToLE, since it matches the existing code style.

Aug 4 2020, 1:00 PM · Restricted Project, Restricted Project
iii committed rGea9b82da4180: [libFuzzer] Enable for SystemZ (authored by iii).
[libFuzzer] Enable for SystemZ
Aug 4 2020, 12:53 PM
iii committed rG153df1373e5d: [SanitizerCoverage] Fix types of __stop* and __start* symbols (authored by iii).
[SanitizerCoverage] Fix types of __stop* and __start* symbols
Aug 4 2020, 12:53 PM
iii committed rGa4e537d9c47a: [libFuzzer] Fix endianness issue in ForEachNonZeroByte() (authored by iii).
[libFuzzer] Fix endianness issue in ForEachNonZeroByte()
Aug 4 2020, 12:53 PM
iii added inline comments to D84913: [libFuzzer] Enable for SystemZ.
Aug 4 2020, 12:39 PM · Restricted Project, Restricted Project
iii added inline comments to D84913: [libFuzzer] Enable for SystemZ.
Aug 4 2020, 11:28 AM · Restricted Project, Restricted Project
iii updated the diff for D84913: [libFuzzer] Enable for SystemZ.
  • Remove unnecessary {}
  • htole -> HostToLE
Aug 4 2020, 11:27 AM · Restricted Project, Restricted Project
iii added a comment to D84913: [libFuzzer] Enable for SystemZ.

@kcc Could you have another look please?

Aug 4 2020, 10:20 AM · Restricted Project, Restricted Project

Jul 31 2020

iii updated the diff for D84913: [libFuzzer] Enable for SystemZ.
  • Htole -> htole (I missed clang-tidy suggestion)
  • [libFuzzer] -> [SanitizerCoverage] in the 2nd patch title
Jul 31 2020, 3:48 AM · Restricted Project, Restricted Project

Jul 30 2020

iii updated the diff for D84913: [libFuzzer] Enable for SystemZ.

Two minor fixes:

  • Remove unneeded <endian.h> include.
  • Make clang-tidy happy by renaming HToLE to Htole.
Jul 30 2020, 2:19 PM · Restricted Project, Restricted Project
iii updated the diff for D84913: [libFuzzer] Enable for SystemZ.
  • [libFuzzer] Fix endianness issue in ForEachNonZeroByte()
  • [libFuzzer] Fix types of stop* and start* symbols
  • [libFuzzer] Enable for SystemZ
Jul 30 2020, 11:12 AM · Restricted Project, Restricted Project
iii updated the diff for D84913: [libFuzzer] Enable for SystemZ.

arc which origin/master tells me that arc diff origin/master will
send all the 3 commits. Fingers crossed.

Jul 30 2020, 11:03 AM · Restricted Project, Restricted Project
iii updated the diff for D84913: [libFuzzer] Enable for SystemZ.

Second attempt to push all 3 commits with arcanist. Sorry for the noise
if it doesn't work out :-/

Jul 30 2020, 10:55 AM · Restricted Project, Restricted Project
iii updated the diff for D84913: [libFuzzer] Enable for SystemZ.

Split in three commits, removed #ifdef from ForEachNonZeroByte() body.

Jul 30 2020, 10:48 AM · Restricted Project, Restricted Project
iii added inline comments to D84913: [libFuzzer] Enable for SystemZ.
Jul 30 2020, 9:28 AM · Restricted Project, Restricted Project
iii added a comment to D84913: [libFuzzer] Enable for SystemZ.

Ok, I'll split the patch.

Jul 30 2020, 9:12 AM · Restricted Project, Restricted Project
iii added reviewers for D84913: [libFuzzer] Enable for SystemZ: kcc, morehouse, uweigand, jonpa.
Jul 30 2020, 12:54 AM · Restricted Project, Restricted Project
iii updated the summary of D84913: [libFuzzer] Enable for SystemZ.
Jul 30 2020, 12:53 AM · Restricted Project, Restricted Project
iii updated the diff for D84913: [libFuzzer] Enable for SystemZ.

Fixed Reviewers: tag.

Jul 30 2020, 12:52 AM · Restricted Project, Restricted Project
iii requested review of D84913: [libFuzzer] Enable for SystemZ.
Jul 30 2020, 12:51 AM · Restricted Project, Restricted Project

Jul 15 2020

iii added a comment to D83289: [BPF] Add support for floats and doubles.

@yonghong-song Sure, I will give it a try.

Jul 15 2020, 2:48 PM · Restricted Project

Jul 13 2020

iii abandoned D83289: [BPF] Add support for floats and doubles.

I'll close this change now. Thanks for the discussion; looking forward to the proper floating point support in BTF!

Jul 13 2020, 2:40 AM · Restricted Project

Jul 10 2020

iii updated the diff for D83289: [BPF] Add support for floats and doubles.

I've added the warning. On my s390 it looks like this when building
kselftests:

Jul 10 2020, 5:53 AM · Restricted Project

Jul 9 2020

iii updated the diff for D83289: [BPF] Add support for floats and doubles.

Thanks for the review!

Jul 9 2020, 4:45 AM · Restricted Project

Jul 7 2020

Herald added a project to D83289: [BPF] Add support for floats and doubles: Restricted Project.
Jul 7 2020, 3:23 AM · Restricted Project

Jun 30 2020

iii committed rG6764869548a2: [SystemZ] Add NoMerge MIFlag (authored by iii).
[SystemZ] Add NoMerge MIFlag
Jun 30 2020, 3:47 AM
iii closed D82794: [SystemZ] Add NoMerge MIFlag.
Jun 30 2020, 3:46 AM · Restricted Project