Page MenuHomePhabricator

iii (Ilya Leoshkevich)
Linux on IBM Z development

Projects

User does not belong to any projects.

User Details

User Since
Oct 24 2019, 7:17 AM (76 w, 5 d)

Recent Activity

Mar 5 2021

iii committed rGa7137b238a07: [BPF] Add support for floats and doubles (authored by iii).
[BPF] Add support for floats and doubles
Mar 5 2021, 6:11 AM
iii closed D83289: [BPF] Add support for floats and doubles.
Mar 5 2021, 6:11 AM · Restricted Project

Feb 15 2021

iii retitled D83289: [BPF] Add support for floats and doubles from [BPF] Emit unknown types as byte arrays to [BPF] Add support for floats and doubles.
Feb 15 2021, 5:21 PM · Restricted Project
iii updated the diff for D83289: [BPF] Add support for floats and doubles.

Removed an unnecessary trailing u32.

Feb 15 2021, 5:02 PM · Restricted Project

Feb 8 2021

iii updated the diff for D83289: [BPF] Add support for floats and doubles.

Hi, it has been a long time, but I've finally implemented the support
for the floating-point types in BTF. Here are the other pieces:

Feb 8 2021, 10:08 AM · Restricted Project

Dec 8 2020

iii committed rGd58f112ce038: Prevent FENTRY_CALL reordering (authored by iii).
Prevent FENTRY_CALL reordering
Dec 8 2020, 4:02 PM
iii closed D91218: Prevent FENTRY_CALL reordering.
Dec 8 2020, 4:01 PM · Restricted Project

Nov 30 2020

iii added a comment to D91218: Prevent FENTRY_CALL reordering.

Ping.

Nov 30 2020, 4:39 AM · Restricted Project

Nov 23 2020

iii updated the diff for D91218: Prevent FENTRY_CALL reordering.
  • Fixed a typo in a comment.
  • Rebased.
Nov 23 2020, 6:23 AM · Restricted Project

Nov 11 2020

iii updated the diff for D91218: Prevent FENTRY_CALL reordering.
  • Do not use FileCheck in fentry-debug-info.ll.
Nov 11 2020, 10:27 AM · Restricted Project
iii updated the summary of D91218: Prevent FENTRY_CALL reordering.
Nov 11 2020, 8:52 AM · Restricted Project
iii updated the diff for D91218: Prevent FENTRY_CALL reordering.
  • Don't put FENTRY_CALL in a separate MBB.
Nov 11 2020, 8:52 AM · Restricted Project
iii added a comment to D91218: Prevent FENTRY_CALL reordering.

I guess you are right - cross-bb optimizations can still mess with it they want to. Let's do just isCall here and solve other problems when/if they arise.

Nov 11 2020, 7:18 AM · Restricted Project
iii added a comment to D91218: Prevent FENTRY_CALL reordering.
In D91218#2388401, @iii wrote:
  • Add isCall to FENTRY_CALL in Target.td.

Do you still need to create the extra basic block?

Nov 11 2020, 6:25 AM · Restricted Project
iii retitled D91218: Prevent FENTRY_CALL reordering from [SystemZ] Prevent fentry reordering to Prevent FENTRY_CALL reordering.
Nov 11 2020, 4:54 AM · Restricted Project
iii updated the diff for D91218: Prevent FENTRY_CALL reordering.
  • Add isCall to FENTRY_CALL in Target.td.
Nov 11 2020, 4:53 AM · Restricted Project
iii added reviewers for D91218: Prevent FENTRY_CALL reordering: niravd, hfinkel, craig.topper.
Nov 11 2020, 4:35 AM · Restricted Project
iii added a comment to D91218: Prevent FENTRY_CALL reordering.

An alternative fix would be to modify isSchedulingBoundary() to accept FENTRY_CALL, but this would have questionable semantics.

Did you try to add the isCall flag to the instruction in Target.td? That should make it a scheduling boundary...

Nov 11 2020, 4:30 AM · Restricted Project

Nov 10 2020

iii updated subscribers of D91218: Prevent FENTRY_CALL reordering.
Nov 10 2020, 4:13 PM · Restricted Project
iii requested review of D91218: Prevent FENTRY_CALL reordering.
Nov 10 2020, 3:53 PM · Restricted Project

Aug 25 2020

iii committed rG151f60319966: [libFuzzer] Un-XFAIL msan.test on SystemZ (authored by iii).
[libFuzzer] Un-XFAIL msan.test on SystemZ
Aug 25 2020, 6:02 AM
iii closed D86184: [libFuzzer] Un-XFAIL msan.test on SystemZ.
Aug 25 2020, 6:02 AM · Restricted Project

Aug 24 2020

iii retitled D86184: [libFuzzer] Un-XFAIL msan.test on SystemZ from [libFuzzer] Use 100m runs for SimpleCmpTest in msan.test to [libFuzzer] Un-XFAIL msan.test on SystemZ.
Aug 24 2020, 12:48 PM · Restricted Project
iii updated the diff for D86184: [libFuzzer] Un-XFAIL msan.test on SystemZ.
  • D86382 works - so changing the patch to simply un-XFAIL the test.
Aug 24 2020, 12:19 PM · Restricted Project

Aug 19 2020

iii added a comment to D86184: [libFuzzer] Un-XFAIL msan.test on SystemZ.

Hm, it actually looks fairly simple as is: just a bunch of comparisons of unmodified ints from the input buffer with constants. So I would expect Mutate_AddWordFromTORC to help solving it this fairly quickly. Do you have an idea why this might not be happening? Maybe it could be worth looking into it a bit deeper.

Aug 19 2020, 5:45 PM · Restricted Project

Aug 18 2020

iii requested review of D86184: [libFuzzer] Un-XFAIL msan.test on SystemZ.
Aug 18 2020, 6:01 PM · Restricted Project

Aug 12 2020

iii committed rGeca4b4007d6b: [Sanitizer] Fix segfaults during unwinding on SystemZ (authored by iii).
[Sanitizer] Fix segfaults during unwinding on SystemZ
Aug 12 2020, 1:25 PM
iii closed D85822: [Sanitizer] Fix segfaults during unwinding on SystemZ.
Aug 12 2020, 1:24 PM · Restricted Project
iii committed rGf5a252ed681c: [SanitizerCoverage] Use zeroext for cmp parameters on all targets (authored by iii).
[SanitizerCoverage] Use zeroext for cmp parameters on all targets
Aug 12 2020, 9:38 AM
iii closed D85689: [SanitizerCoverage] Use zeroext for cmp parameters on all targets.
Aug 12 2020, 9:38 AM · Restricted Project, Restricted Project
iii added a reviewer for D85689: [SanitizerCoverage] Use zeroext for cmp parameters on all targets: morehouse.
Aug 12 2020, 2:25 AM · Restricted Project, Restricted Project
iii added a comment to D85689: [SanitizerCoverage] Use zeroext for cmp parameters on all targets.

All 3 test failures here are in unrelated areas and must be preexisting.

Aug 12 2020, 2:24 AM · Restricted Project, Restricted Project
iii requested review of D85822: [Sanitizer] Fix segfaults during unwinding on SystemZ.
Aug 12 2020, 2:23 AM · Restricted Project

Aug 11 2020

iii committed rG9df7ee34e1b5: [libFuzzer] Fix minimizing timeouts (authored by iii).
[libFuzzer] Fix minimizing timeouts
Aug 11 2020, 1:17 PM
iii closed D85359: [libFuzzer] Fix minimizing timeouts.
Aug 11 2020, 1:16 PM · Restricted Project

Aug 10 2020

iii added a comment to D85359: [libFuzzer] Fix minimizing timeouts.

The failing test is libFuzzer :: cleanse.test, but I don't think this is due to my patch - it doesn't fail locally, and it didn't fail the last time. I wonder if build machines do parallel builds? If yes, then the following code might be the culprit:

Aug 10 2020, 3:02 PM · Restricted Project
iii requested review of D85689: [SanitizerCoverage] Use zeroext for cmp parameters on all targets.
Aug 10 2020, 2:22 PM · Restricted Project, Restricted Project
iii updated the diff for D85359: [libFuzzer] Fix minimizing timeouts.
  • Added a test.
  • Moved Alrm after Abrt in order to maintain the alphabetic order.
Aug 10 2020, 4:11 AM · Restricted Project

Aug 5 2020

iii requested review of D85359: [libFuzzer] Fix minimizing timeouts.
Aug 5 2020, 1:57 PM · Restricted Project

Aug 4 2020

iii closed D84913: [libFuzzer] Enable for SystemZ.

I've committed with HostToLE, since it matches the existing code style.

Aug 4 2020, 1:00 PM · Restricted Project, Restricted Project
iii committed rGea9b82da4180: [libFuzzer] Enable for SystemZ (authored by iii).
[libFuzzer] Enable for SystemZ
Aug 4 2020, 12:53 PM
iii committed rG153df1373e5d: [SanitizerCoverage] Fix types of __stop* and __start* symbols (authored by iii).
[SanitizerCoverage] Fix types of __stop* and __start* symbols
Aug 4 2020, 12:53 PM
iii committed rGa4e537d9c47a: [libFuzzer] Fix endianness issue in ForEachNonZeroByte() (authored by iii).
[libFuzzer] Fix endianness issue in ForEachNonZeroByte()
Aug 4 2020, 12:53 PM
iii added inline comments to D84913: [libFuzzer] Enable for SystemZ.
Aug 4 2020, 12:39 PM · Restricted Project, Restricted Project
iii added inline comments to D84913: [libFuzzer] Enable for SystemZ.
Aug 4 2020, 11:28 AM · Restricted Project, Restricted Project
iii updated the diff for D84913: [libFuzzer] Enable for SystemZ.
  • Remove unnecessary {}
  • htole -> HostToLE
Aug 4 2020, 11:27 AM · Restricted Project, Restricted Project
iii added a comment to D84913: [libFuzzer] Enable for SystemZ.

@kcc Could you have another look please?

Aug 4 2020, 10:20 AM · Restricted Project, Restricted Project

Jul 31 2020

iii updated the diff for D84913: [libFuzzer] Enable for SystemZ.
  • Htole -> htole (I missed clang-tidy suggestion)
  • [libFuzzer] -> [SanitizerCoverage] in the 2nd patch title
Jul 31 2020, 3:48 AM · Restricted Project, Restricted Project

Jul 30 2020

iii updated the diff for D84913: [libFuzzer] Enable for SystemZ.

Two minor fixes:

  • Remove unneeded <endian.h> include.
  • Make clang-tidy happy by renaming HToLE to Htole.
Jul 30 2020, 2:19 PM · Restricted Project, Restricted Project
iii updated the diff for D84913: [libFuzzer] Enable for SystemZ.
  • [libFuzzer] Fix endianness issue in ForEachNonZeroByte()
  • [libFuzzer] Fix types of stop* and start* symbols
  • [libFuzzer] Enable for SystemZ
Jul 30 2020, 11:12 AM · Restricted Project, Restricted Project
iii updated the diff for D84913: [libFuzzer] Enable for SystemZ.

arc which origin/master tells me that arc diff origin/master will
send all the 3 commits. Fingers crossed.

Jul 30 2020, 11:03 AM · Restricted Project, Restricted Project
iii updated the diff for D84913: [libFuzzer] Enable for SystemZ.

Second attempt to push all 3 commits with arcanist. Sorry for the noise
if it doesn't work out :-/

Jul 30 2020, 10:55 AM · Restricted Project, Restricted Project
iii updated the diff for D84913: [libFuzzer] Enable for SystemZ.

Split in three commits, removed #ifdef from ForEachNonZeroByte() body.

Jul 30 2020, 10:48 AM · Restricted Project, Restricted Project
iii added inline comments to D84913: [libFuzzer] Enable for SystemZ.
Jul 30 2020, 9:28 AM · Restricted Project, Restricted Project
iii added a comment to D84913: [libFuzzer] Enable for SystemZ.

Ok, I'll split the patch.

Jul 30 2020, 9:12 AM · Restricted Project, Restricted Project
iii added reviewers for D84913: [libFuzzer] Enable for SystemZ: kcc, morehouse, uweigand, jonpa.
Jul 30 2020, 12:54 AM · Restricted Project, Restricted Project
iii updated the summary of D84913: [libFuzzer] Enable for SystemZ.
Jul 30 2020, 12:53 AM · Restricted Project, Restricted Project
iii updated the diff for D84913: [libFuzzer] Enable for SystemZ.

Fixed Reviewers: tag.

Jul 30 2020, 12:52 AM · Restricted Project, Restricted Project
iii requested review of D84913: [libFuzzer] Enable for SystemZ.
Jul 30 2020, 12:51 AM · Restricted Project, Restricted Project

Jul 15 2020

iii added a comment to D83289: [BPF] Add support for floats and doubles.

@yonghong-song Sure, I will give it a try.

Jul 15 2020, 2:48 PM · Restricted Project

Jul 13 2020

iii abandoned D83289: [BPF] Add support for floats and doubles.

I'll close this change now. Thanks for the discussion; looking forward to the proper floating point support in BTF!

Jul 13 2020, 2:40 AM · Restricted Project

Jul 10 2020

iii updated the diff for D83289: [BPF] Add support for floats and doubles.

I've added the warning. On my s390 it looks like this when building
kselftests:

Jul 10 2020, 5:53 AM · Restricted Project

Jul 9 2020

iii updated the diff for D83289: [BPF] Add support for floats and doubles.

Thanks for the review!

Jul 9 2020, 4:45 AM · Restricted Project

Jul 7 2020

Herald added a project to D83289: [BPF] Add support for floats and doubles: Restricted Project.
Jul 7 2020, 3:23 AM · Restricted Project

Jun 30 2020

iii committed rG6764869548a2: [SystemZ] Add NoMerge MIFlag (authored by iii).
[SystemZ] Add NoMerge MIFlag
Jun 30 2020, 3:47 AM
iii closed D82794: [SystemZ] Add NoMerge MIFlag.
Jun 30 2020, 3:46 AM · Restricted Project

Jun 29 2020

iii created D82794: [SystemZ] Add NoMerge MIFlag.
Jun 29 2020, 11:21 AM · Restricted Project

Jun 16 2020

iii committed rGccd8b7b10347: [LSan] Enable for SystemZ (authored by iii).
[LSan] Enable for SystemZ
Jun 16 2020, 4:58 AM
iii closed D78644: [LSan] Enable for SystemZ.
Jun 16 2020, 4:58 AM · Restricted Project, Restricted Project

Jun 15 2020

iii updated the diff for D78644: [LSan] Enable for SystemZ.

Rebased.

Jun 15 2020, 9:13 AM · Restricted Project, Restricted Project

Apr 22 2020

iii created D78644: [LSan] Enable for SystemZ.
Apr 22 2020, 8:38 AM · Restricted Project, Restricted Project

Apr 16 2020

iii committed rG921009e66798: [MSan] Enable for SystemZ (authored by iii).
[MSan] Enable for SystemZ
Apr 16 2020, 3:24 AM
iii closed D76358: [MSan] Enable for SystemZ.
Apr 16 2020, 3:23 AM · Restricted Project

Apr 15 2020

iii updated the summary of D76358: [MSan] Enable for SystemZ.
Apr 15 2020, 5:26 AM · Restricted Project
iii added a comment to D76358: [MSan] Enable for SystemZ.

@eugenis I slightly improved the tests - could you have another look please?

Apr 15 2020, 3:47 AM · Restricted Project

Apr 14 2020

iii updated the diff for D76358: [MSan] Enable for SystemZ.

Instead of checking only top frame, compile tests with
-mbackchain, like we already do for ASan and UBSan.

Apr 14 2020, 4:45 AM · Restricted Project

Apr 10 2020

iii committed rG3bc439bdff8b: [MSan] Add instrumentation for SystemZ (authored by iii).
[MSan] Add instrumentation for SystemZ
Apr 10 2020, 7:56 AM
iii closed D76624: [MSan] Add instrumentation for SystemZ.
Apr 10 2020, 7:56 AM · Restricted Project

Apr 9 2020

iii added inline comments to D76624: [MSan] Add instrumentation for SystemZ.
Apr 9 2020, 12:14 PM · Restricted Project
iii added a comment to D76624: [MSan] Add instrumentation for SystemZ.

@eugenis now that VarArgSystemZHelper part seems to be in order, could you please have another look?

Apr 9 2020, 5:23 AM · Restricted Project
iii updated the diff for D76624: [MSan] Add instrumentation for SystemZ.

Introduced ArgKind::Indirect.

Apr 9 2020, 4:18 AM · Restricted Project
iii updated the diff for D76624: [MSan] Add instrumentation for SystemZ.

Added i128 handling and a test for it.

Apr 9 2020, 2:40 AM · Restricted Project

Apr 8 2020

iii updated the diff for D76624: [MSan] Add instrumentation for SystemZ.

Added fp128 handling and a test for it.

Apr 8 2020, 2:41 PM · Restricted Project
iii committed rGaaba9a776150: [compiler-rt] Don't use __libc_stack_end on ARM (authored by iii).
[compiler-rt] Don't use __libc_stack_end on ARM
Apr 8 2020, 5:56 AM
iii closed D77400: [compiler-rt] Don't use __libc_stack_end on ARM.
Apr 8 2020, 5:56 AM · Restricted Project

Apr 4 2020

iii updated the diff for D77400: [compiler-rt] Don't use __libc_stack_end on ARM.

Applied the formatting fix, got rid of bogus D76358 dependency.

Apr 4 2020, 2:22 PM · Restricted Project
iii updated the summary of D77400: [compiler-rt] Don't use __libc_stack_end on ARM.
Apr 4 2020, 2:22 PM · Restricted Project

Apr 3 2020

iii committed rG6897111231e7: [MSan] Add COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED (authored by iii).
[MSan] Add COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED
Apr 3 2020, 8:36 AM
iii closed D76969: [MSan] Add COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED.
Apr 3 2020, 8:36 AM · Restricted Project
iii created D77400: [compiler-rt] Don't use __libc_stack_end on ARM.
Apr 3 2020, 8:02 AM · Restricted Project

Apr 2 2020

iii updated the diff for D76624: [MSan] Add instrumentation for SystemZ.

Resolved shadow zext/sext TODO using CreateShadowCast.
Resolved softfloat TODO using getFnAttribute("use-soft-float").
Added shadow propagation checks to tests.

Apr 2 2020, 3:11 PM · Restricted Project

Apr 1 2020

iii updated the diff for D76624: [MSan] Add instrumentation for SystemZ.

Implemented Ulrich's suggestions.

Apr 1 2020, 5:27 PM · Restricted Project
iii added inline comments to D76624: [MSan] Add instrumentation for SystemZ.
Apr 1 2020, 5:26 PM · Restricted Project

Mar 27 2020

iii created D76969: [MSan] Add COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED.
Mar 27 2020, 8:23 PM · Restricted Project
iii committed rGfad47d222561: [compiler-rt] Fall back to internal_uname() when called early (authored by iii).
[compiler-rt] Fall back to internal_uname() when called early
Mar 27 2020, 7:19 PM
iii closed D76919: [compiler-rt] Fall back to internal_uname() when called early.
Mar 27 2020, 7:19 PM · Restricted Project
iii added a comment to D76919: [compiler-rt] Fall back to internal_uname() when called early.

internal_uname() is available only on Linux right now. I thought it's ok to postpone adding macOS/*BSD/etc implementations until that is really necessary.

Mar 27 2020, 3:27 PM · Restricted Project
iii added a comment to D76919: [compiler-rt] Fall back to internal_uname() when called early.

msan does not call Symbolizer::LateInitialize(), which is Symbolizer::GetOrInit() + InitializeSwiftDemangler(). It calls only Symbolizer::GetOrInit(), and it's exactly InitializeSwiftDemangler() that triggers dlerror(). So for now it looks safe, but not particularly future-proof. #define COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED (!msan_inited) might be a good idea. Should I try to do this here, or separately?

Mar 27 2020, 12:01 PM · Restricted Project
iii created D76919: [compiler-rt] Fall back to internal_uname() when called early.
Mar 27 2020, 5:24 AM · Restricted Project

Mar 26 2020

iii added a comment to D76578: [compiler-rt] Intercept the uname() function.

I've installed stretch and hit the following issue:

Mar 26 2020, 7:37 PM · Restricted Project