Page MenuHomePhabricator

vtjnash (Jameson Nash)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 21 2013, 6:34 AM (475 w, 2 d)

Recent Activity

Jul 6 2022

vtjnash added inline comments to D128670: [SimplifyCFG] teach simplifycfg not to introduce ptrtoint for NI pointers.
Jul 6 2022, 12:04 PM · Restricted Project, Restricted Project
vtjnash added inline comments to D128670: [SimplifyCFG] teach simplifycfg not to introduce ptrtoint for NI pointers.
Jul 6 2022, 12:02 PM · Restricted Project, Restricted Project

Jul 1 2022

vtjnash added inline comments to D128670: [SimplifyCFG] teach simplifycfg not to introduce ptrtoint for NI pointers.
Jul 1 2022, 11:55 AM · Restricted Project, Restricted Project
vtjnash updated the diff for D128670: [SimplifyCFG] teach simplifycfg not to introduce ptrtoint for NI pointers.

run tests once

Jul 1 2022, 11:54 AM · Restricted Project, Restricted Project

Jun 27 2022

vtjnash updated the summary of D128670: [SimplifyCFG] teach simplifycfg not to introduce ptrtoint for NI pointers.
Jun 27 2022, 10:42 AM · Restricted Project, Restricted Project
vtjnash requested review of D128670: [SimplifyCFG] teach simplifycfg not to introduce ptrtoint for NI pointers.
Jun 27 2022, 10:39 AM · Restricted Project, Restricted Project

May 3 2022

vtjnash added a comment to D120575: avoid constructing an incomplete TTI in InlineCostAnnotationPrinterPass.

bump? this should be an easy obvious bugfix

May 3 2022, 1:19 PM · Restricted Project, Restricted Project
Herald added a project to D120585: make TargetMachine visible from TargetTransformInfo: Restricted Project.

I would be supportive of a patch that added a TTI function that returned the contents of the target-attribute when it is present or the TargetMachine attributes when it is not.

May 3 2022, 1:18 PM · Restricted Project, Restricted Project, Restricted Project

Apr 14 2022

vtjnash committed rG753aabeaae65: [X86] Fix test case for SoftPromoteHalf of STRICT_FP_EXTEND/STRICT_FP_ROUND. (authored by vtjnash).
[X86] Fix test case for SoftPromoteHalf of STRICT_FP_EXTEND/STRICT_FP_ROUND.
Apr 14 2022, 1:22 PM · Restricted Project, Restricted Project
vtjnash closed D123739: [X86] Fix test case for SoftPromoteHalf of STRICT_FP_EXTEND/STRICT_FP_ROUND..
Apr 14 2022, 1:22 PM · Restricted Project, Restricted Project

Apr 13 2022

vtjnash added a comment to D123739: [X86] Fix test case for SoftPromoteHalf of STRICT_FP_EXTEND/STRICT_FP_ROUND..

I noticed the first 2 RUN statements in the file were accidentally identical, so I fixed one and reran the update_llc_test_checks.py to fix the tests

Apr 13 2022, 2:54 PM · Restricted Project, Restricted Project
vtjnash added a reviewer for D123739: [X86] Fix test case for SoftPromoteHalf of STRICT_FP_EXTEND/STRICT_FP_ROUND.: craig.topper.
Apr 13 2022, 2:52 PM · Restricted Project, Restricted Project
vtjnash requested review of D123739: [X86] Fix test case for SoftPromoteHalf of STRICT_FP_EXTEND/STRICT_FP_ROUND..
Apr 13 2022, 2:51 PM · Restricted Project, Restricted Project

Apr 12 2022

Herald added a project to D105263: [X86] AVX512FP16 instructions enabling 1/6: Restricted Project.

I was tracking back a recent ABI break (also failing now in gcc 12, so maybe this irregularity is intentional), and was concerned that this commit is observed to cause the platform ABI to change depending on the feature flags of the current compilation unit. Prior to this change, f16 was always treated as i16 for the purpose of the calling-convention (e.g. returned in %ax). But after this change, the ABI of the value is now inconsistent between compile units. I made a small change to one of the existing tests to show this. Note how the callq result was in %ax without this mattr flag, and in %xmm0 with this mattr flag added. But the function known as "identity.half" is external, and did not change between those two calls to the llvm.

Apr 12 2022, 3:41 PM · Restricted Project, Restricted Project, Restricted Project

Mar 8 2022

Herald added a project to D120575: avoid constructing an incomplete TTI in InlineCostAnnotationPrinterPass: Restricted Project.

bump?

Mar 8 2022, 1:57 PM · Restricted Project, Restricted Project
Herald added a project to D120580: [bugpoint] construct a plausible TargetMachine for simplifyCFG: Restricted Project.

bump?

Mar 8 2022, 1:57 PM · Restricted Project, Restricted Project

Feb 28 2022

vtjnash added a comment to D120585: make TargetMachine visible from TargetTransformInfo.

Hm, I am actually not 100% certain, since I think that might be a current bug now that I think about it, which was caused by failing to expose this information about the TargetMachine. It looks some passes are adding flags there (e.g. +thumb/-thumb) with the implied assumption that they should be inheriting the global TargetMachine flags for anything left unspecified, while other passes (e.g. msan) are checking only the Function's flags, with the implied assumption that the configured TargetMachine does not specify target-features, and yet other passes (MIR/Codegen) are probably assuming that the "target-features" flag should entirely replace and override the TargetMachine's feature set. These assumptions seem currently incompatible.

Feb 28 2022, 12:14 PM · Restricted Project, Restricted Project, Restricted Project
vtjnash added a comment to D120585: make TargetMachine visible from TargetTransformInfo.

It can matter in what ways the the "target-attribute" is different. Just grepping the source tree reveals there are several existing IR passes that depend on examining this function attribute, and are already altering their behavior based on the value. For example, it appears that the msan pass should be falling back to examining the TTI's notion of the target machine to locate the function arguments correctly, if I am reading the source comments here correctly:

Feb 28 2022, 11:07 AM · Restricted Project, Restricted Project, Restricted Project
vtjnash added a comment to D120585: make TargetMachine visible from TargetTransformInfo.

TargetMachine is nearly always a required argument here, so clearly the analysis already does depend on the the TargetMachine. Sometimes the information we (aka JuliaLang) need is available in the "target-features" function attribute (which is always available), but we want to compare that against the TargetMachine's notion of the TargetFeatures during optimization. Those together are then nearly the complete set of arguments to the TargetMachine, so it seemed more logical to me to expose the TM directly, rather than separately exposing all of the information needed to reconstruct a copy of it. I don't think we should obfuscate this just for the sake of obfuscation, do you?

Feb 28 2022, 10:21 AM · Restricted Project, Restricted Project, Restricted Project

Feb 25 2022

vtjnash added inline comments to D120585: make TargetMachine visible from TargetTransformInfo.
Feb 25 2022, 7:22 PM · Restricted Project, Restricted Project, Restricted Project
vtjnash committed rGd25a4b5485ab: Enable tests from rG8e67982384d4a11892c04d16c2d10d7533e56094 that seem to work… (authored by vtjnash).
Enable tests from rG8e67982384d4a11892c04d16c2d10d7533e56094 that seem to work…
Feb 25 2022, 12:29 PM
vtjnash closed D115377: Enable tests from rG8e67982384d4a11892c04d16c2d10d7533e56094 that seem to work now.
Feb 25 2022, 12:29 PM · Restricted Project
vtjnash added reviewers for D120585: make TargetMachine visible from TargetTransformInfo: wsmoses, ychen.
Feb 25 2022, 12:06 PM · Restricted Project, Restricted Project, Restricted Project
vtjnash requested review of D120585: make TargetMachine visible from TargetTransformInfo.
Feb 25 2022, 12:01 PM · Restricted Project, Restricted Project, Restricted Project
vtjnash added a comment to D115377: Enable tests from rG8e67982384d4a11892c04d16c2d10d7533e56094 that seem to work now.

ping @fhahn

Feb 25 2022, 11:38 AM · Restricted Project
vtjnash abandoned D111100: enable plugins for clang-tidy.
Feb 25 2022, 11:38 AM · Restricted Project
vtjnash updated subscribers of D120301: clang-tools-extra: Make test dependency on LLVMHello optional.

Seems extra complexity, and less desirable to lose test coverage, when it seems the option may already be unreliable and soon to be deprecated by https://reviews.llvm.org/D119383. @MaskRay is that accurate?

Feb 25 2022, 11:36 AM · Restricted Project, Restricted Project
vtjnash committed rGc4b1a63a1b03: mark getTargetTransformInfo and getTargetIRAnalysis as const (authored by vtjnash).
mark getTargetTransformInfo and getTargetIRAnalysis as const
Feb 25 2022, 11:31 AM
vtjnash closed D120518: const correctness for getTargetTransformInfo.
Feb 25 2022, 11:31 AM · Restricted Project
vtjnash updated the summary of D120580: [bugpoint] construct a plausible TargetMachine for simplifyCFG.
Feb 25 2022, 11:20 AM · Restricted Project, Restricted Project
vtjnash updated the summary of D120580: [bugpoint] construct a plausible TargetMachine for simplifyCFG.
Feb 25 2022, 11:19 AM · Restricted Project, Restricted Project
vtjnash updated the diff for D120580: [bugpoint] construct a plausible TargetMachine for simplifyCFG.

fix

Feb 25 2022, 11:19 AM · Restricted Project, Restricted Project
vtjnash requested review of D120580: [bugpoint] construct a plausible TargetMachine for simplifyCFG.
Feb 25 2022, 11:15 AM · Restricted Project, Restricted Project
vtjnash updated the summary of D120575: avoid constructing an incomplete TTI in InlineCostAnnotationPrinterPass.
Feb 25 2022, 10:59 AM · Restricted Project, Restricted Project
vtjnash added a comment to D120518: const correctness for getTargetTransformInfo.

this is adding a new restriction

Feb 25 2022, 10:58 AM · Restricted Project
vtjnash requested review of D120575: avoid constructing an incomplete TTI in InlineCostAnnotationPrinterPass.
Feb 25 2022, 10:50 AM · Restricted Project, Restricted Project

Feb 24 2022

vtjnash updated the summary of D120518: const correctness for getTargetTransformInfo.
Feb 24 2022, 2:13 PM · Restricted Project
vtjnash requested review of D120518: const correctness for getTargetTransformInfo.
Feb 24 2022, 2:11 PM · Restricted Project

Feb 22 2022

vtjnash added a comment to D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests.

Is that a bug in clang or in MSVC2019? We expected that CLANG_PLUGIN_SUPPORT=ON can expose problems with the Windows linker, and we add new tests here for verifying that configuration is functioning as expected. You might need to disable CLANG_PLUGIN_SUPPORT on that target?

Feb 22 2022, 7:18 AM · Restricted Project, Restricted Project

Feb 17 2022

vtjnash added inline comments to D111100: enable plugins for clang-tidy.
Feb 17 2022, 10:03 AM · Restricted Project

Feb 16 2022

vtjnash committed rG9d59cfc67ead: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also (authored by vtjnash).
clang-analyzer plugins require LLVM_ENABLE_PLUGINS also
Feb 16 2022, 9:00 AM
vtjnash closed D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also.
Feb 16 2022, 9:00 AM · Restricted Project
vtjnash added a comment to D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also.

Okay, this should work now for those cases! Sorry, I kept thinking it was clang/examples that was broken, and missed that it was clang/test that was failing, so I failed to see what I needed to fix there too, so that we were not trying to build the tests in configurations where the functionality is disabled.

Feb 16 2022, 7:29 AM · Restricted Project
vtjnash updated the diff for D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also.

add one more missing case to check

Feb 16 2022, 7:25 AM · Restricted Project

Feb 14 2022

vtjnash updated the diff for D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also.

fixup

Feb 14 2022, 10:36 AM · Restricted Project
vtjnash added a comment to D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also.

We are not going to start exporting plugin support if the user explicitly disabled it with CLANG_PLUGIN_SUPPORT=OFF, but why is it trying to read that directory at all, when it should be disallowed by this PR unless CLANG_PLUGIN_SUPPORT=ON

Feb 14 2022, 10:23 AM · Restricted Project
vtjnash updated the diff for D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also.

cleanup

Feb 14 2022, 10:23 AM · Restricted Project

Feb 11 2022

vtjnash updated the summary of D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also.
Feb 11 2022, 1:47 PM · Restricted Project
vtjnash requested review of D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also.
Feb 11 2022, 1:45 PM · Restricted Project

Feb 9 2022

vtjnash added a comment to D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests.

Thanks, if you encounter more issues next week, let me know, and I will continue trying to adjust it to work for all config option combinations.

Feb 9 2022, 2:33 PM · Restricted Project, Restricted Project
vtjnash committed rG76cad51ba700: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests (authored by vtjnash).
replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests
Feb 9 2022, 2:32 PM
vtjnash closed D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests.
Feb 9 2022, 2:32 PM · Restricted Project, Restricted Project
vtjnash added a comment to D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests.

@cristian.adam Is this good now? You are blocking merging this, but I think it is ready to land, and I would like to not hold it up for other people if it is fixing their issues (and the issues you discovered too)

Feb 9 2022, 1:55 PM · Restricted Project, Restricted Project

Feb 8 2022

vtjnash updated the diff for D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests.
ensure CLANG_PLUGIN_SUPPORT setting is compatible with llvm_add_library
Feb 8 2022, 8:40 AM · Restricted Project, Restricted Project

Feb 7 2022

vtjnash updated the summary of D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests.
Feb 7 2022, 3:50 PM · Restricted Project, Restricted Project
vtjnash added reviewers for D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests: thakis, mgorny.
Feb 7 2022, 3:49 PM · Restricted Project, Restricted Project
vtjnash accepted D111100: enable plugins for clang-tidy.

Fixed by D119199

Feb 7 2022, 3:48 PM · Restricted Project
vtjnash requested review of D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests.
Feb 7 2022, 3:48 PM · Restricted Project, Restricted Project
vtjnash added a comment to D111100: enable plugins for clang-tidy.

Ah, this looks annoying: there are apparently two flags, CLANG_PLUGIN_SUPPORT and LLVM_ENABLE_PLUGINS, but the existing build for clang uses CLANG_PLUGIN_SUPPORT to turn off the build support and LLVM_ENABLE_PLUGINS to turn off the tests (you might not have noticed this existing issue since you turned off CLANG_ENABLE_STATIC_ANALYZER support, and CLANG_BUILD_EXAMPLES is off by default, which looks like it would disable all of the existing tests for this functionality). This might fix this particular test?

diff --git a/clang-tools-extra/test/CMakeLists.txt b/clang-tools-extra/test/CMakeLists.txt
index 9321457ae1a3..c98ec90a179b 100644
--- a/clang-tools-extra/test/CMakeLists.txt
+++ b/clang-tools-extra/test/CMakeLists.txt
@@ -17,7 +17,7 @@ string(REPLACE ${CMAKE_CFG_INTDIR} ${LLVM_BUILD_MODE} CLANG_TOOLS_DIR ${LLVM_RUN
Feb 7 2022, 2:37 PM · Restricted Project
vtjnash added a comment to D111100: enable plugins for clang-tidy.

It is a somewhat worthless test IMO, and might belong better in LLVM itself (where this functionality is defined), but there does not appear to be any other like it currently, and it was requested by a previous reviewer. Comparing to the code in LLVMTestingSupport, does this fix it for you:

diff --git a/clang-tools-extra/test/CMakeLists.txt b/clang-tools-extra/test/CMakeLists.txt
index 9321457ae1a3..17cc12473565 100644
--- a/clang-tools-extra/test/CMakeLists.txt
+++ b/clang-tools-extra/test/CMakeLists.txt
@@ -87,6 +87,15 @@ if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
       PLUGIN_TOOL clang-tidy
       DEPENDS clang-tidy-headers)
Feb 7 2022, 12:54 PM · Restricted Project

Feb 2 2022

vtjnash added a comment to D118541: export MachineModuleAnalysis to the new pass manager.

TargetTransformInfo does not currently have what I need, but if I can add it there, it would also satisfy my needs. I wanted it for an optimization pass (to pre-populate some codegen decisions earlier in the pipeline for better performance), but it looks like all current in-tree consumers are codegen-related.

Feb 2 2022, 8:39 PM · Restricted Project, Restricted Project

Feb 1 2022

vtjnash closed D111100: enable plugins for clang-tidy.

Closed by rG84f137a590e7de25c4105303e5938c40566c2dfb

Feb 1 2022, 2:42 PM · Restricted Project
vtjnash updated the diff for D111100: enable plugins for clang-tidy.

rebase

Feb 1 2022, 2:40 PM · Restricted Project
vtjnash added a reverting change for rGab3b89855c53: Revert "enable plugins for clang-tidy": rG84f137a590e7: Reland "enable plugins for clang-tidy".
Feb 1 2022, 2:39 PM
vtjnash committed rG84f137a590e7: Reland "enable plugins for clang-tidy" (authored by vtjnash).
Reland "enable plugins for clang-tidy"
Feb 1 2022, 2:39 PM
vtjnash added a comment to D115377: Enable tests from rG8e67982384d4a11892c04d16c2d10d7533e56094 that seem to work now.

@fhahn You added these test failures recently, but they are working now. Does this look good to you to enable them?

Feb 1 2022, 10:56 AM · Restricted Project
vtjnash updated the diff for D115377: Enable tests from rG8e67982384d4a11892c04d16c2d10d7533e56094 that seem to work now.
rebase on main branch
Feb 1 2022, 10:54 AM · Restricted Project
vtjnash added a comment to D118541: export MachineModuleAnalysis to the new pass manager.

I don't know the plan specifics, but I am just exposing an existing analysis pass to the command line that already has been converted, not changing it to define any new passes.

Feb 1 2022, 10:33 AM · Restricted Project, Restricted Project
vtjnash added a comment to D111100: enable plugins for clang-tidy.

I decided it made the most sense to me to go with option 3, so this should be ready to land again.

Feb 1 2022, 10:29 AM · Restricted Project
vtjnash updated the diff for D111100: enable plugins for clang-tidy.
  • Reland "enable plugins for clang-tidy"
  • fixup! Reland "enable plugins for clang-tidy": Disable the test if the user has disabled support for building it.
Feb 1 2022, 10:28 AM · Restricted Project
vtjnash reopened D111100: enable plugins for clang-tidy.
Feb 1 2022, 10:28 AM · Restricted Project
vtjnash accepted D118672: [cmake][NFC] Configuration for libLLVM.so symbol versioning.
Feb 1 2022, 8:58 AM · Restricted Project, Restricted Project

Jan 31 2022

vtjnash added a comment to D111100: enable plugins for clang-tidy.

It looks like this is probably the first time that a test was written for a PLUGIN_TOOL, outside of the docs, so we are likely in new territory here :/

Jan 31 2022, 8:24 AM · Restricted Project

Jan 30 2022

vtjnash added a comment to D111100: enable plugins for clang-tidy.

Yes, please push a revert so I can look later. Do you have a link to the buildbot configuration, so I can reproduce that?

Jan 30 2022, 6:02 AM · Restricted Project

Jan 29 2022

vtjnash updated the summary of D118541: export MachineModuleAnalysis to the new pass manager.
Jan 29 2022, 12:50 PM · Restricted Project, Restricted Project
vtjnash requested review of D118541: export MachineModuleAnalysis to the new pass manager.
Jan 29 2022, 12:22 PM · Restricted Project, Restricted Project
vtjnash committed rG36892727e4f1: enable plugins for clang-tidy (authored by vtjnash).
enable plugins for clang-tidy
Jan 29 2022, 11:58 AM
vtjnash closed D111100: enable plugins for clang-tidy.
Jan 29 2022, 11:57 AM · Restricted Project

Jan 26 2022

vtjnash added a comment to D111100: enable plugins for clang-tidy.

@aaron.ballman I think I incorporated all of your feedback. Is this okay for me to merge to main? I would like to get it in before the feature branch.

Jan 26 2022, 8:45 AM · Restricted Project

Jan 21 2022

vtjnash abandoned D117895: address review feedback.

arc error

Jan 21 2022, 8:25 AM · Restricted Project
vtjnash updated the diff for D111100: enable plugins for clang-tidy.

address review feedback

Jan 21 2022, 8:25 AM · Restricted Project
vtjnash requested review of D117895: address review feedback.
Jan 21 2022, 8:24 AM · Restricted Project

Jan 7 2022

vtjnash added a comment to D116852: bugfix: bpf: DATASEC names might be wrong in the BTF data.

Can you upload the full diff (git diff -U100000 or arc diff --update D116852) and fix the clang-format check?

Jan 7 2022, 11:56 PM · Restricted Project

Dec 16 2021

vtjnash added a comment to D111100: enable plugins for clang-tidy.

Thanks! I will work on making those changes

Dec 16 2021, 1:01 PM · Restricted Project

Dec 8 2021

vtjnash updated the diff for D115377: Enable tests from rG8e67982384d4a11892c04d16c2d10d7533e56094 that seem to work now.
remove accidental commit added by arc
Dec 8 2021, 12:44 PM · Restricted Project
vtjnash updated the diff for D115377: Enable tests from rG8e67982384d4a11892c04d16c2d10d7533e56094 that seem to work now.

run update_test_checks.py on these files too

Dec 8 2021, 12:44 PM · Restricted Project
vtjnash updated the summary of D115377: Enable tests from rG8e67982384d4a11892c04d16c2d10d7533e56094 that seem to work now.
Dec 8 2021, 12:35 PM · Restricted Project
vtjnash requested review of D115377: Enable tests from rG8e67982384d4a11892c04d16c2d10d7533e56094 that seem to work now.
Dec 8 2021, 12:33 PM · Restricted Project
vtjnash updated the diff for D90705: [GVN] permit forwarding to non-byte-sized loads.

The work had already pretty much been done before (for GVN), we just needed to
allow it to use that work here for NewGVN, and use bits directly rather than
bytes/8*8 for the output computation.

Dec 8 2021, 12:17 PM · Restricted Project
vtjnash updated the diff for D90703: [GVN] Make handling of zeros more consistent.

rebase onto LLVM main, allowing it to handle null values everywhere, and not just for non-integral pointers

Dec 8 2021, 11:30 AM · Restricted Project
vtjnash updated the diff for D111100: enable plugins for clang-tidy.
fix cmake
Dec 8 2021, 10:58 AM · Restricted Project

Nov 30 2021

vtjnash committed rG18308e171b5b: AArch64 GIsel: legalize lshr operands, even if it is poison (authored by vtjnash).
AArch64 GIsel: legalize lshr operands, even if it is poison
Nov 30 2021, 12:30 PM
vtjnash closed D114389: AArch64 GIsel: legalize lshr operands, even if it is poison.
Nov 30 2021, 12:30 PM · Restricted Project, Restricted Project
vtjnash added a comment to D111100: enable plugins for clang-tidy.

There is clearly some more work to do to get the cmake file to be correct, but was hoping to check this looked like the direction you thought looked right for adding this test, since there isn't an obvious example to follow.

Nov 30 2021, 12:08 PM · Restricted Project
vtjnash committed rG2e114e3fda4f: fix inverted logic for HideUnrelatedOptions (authored by vtjnash).
fix inverted logic for HideUnrelatedOptions
Nov 30 2021, 11:59 AM
vtjnash closed D114572: fix inverted logic for HideUnrelatedOptions?.
Nov 30 2021, 11:59 AM · Restricted Project

Nov 27 2021

vtjnash added a comment to D114572: fix inverted logic for HideUnrelatedOptions?.

I couldn't think of an example where you'd want to make sure all of the assigned categories were related to the command being used, instead of showing the option if at least one was related to it. Currently it hides the option as soon as any don't match, whereas it seems like you'd want to hide the option only if all categories don't match.

Nov 27 2021, 1:45 PM · Restricted Project

Nov 24 2021

vtjnash retitled D114572: fix inverted logic for HideUnrelatedOptions? from fix inverted logic for HideUnrelatedOptions to fix inverted logic for HideUnrelatedOptions?.
Nov 24 2021, 9:34 PM · Restricted Project
vtjnash updated the diff for D114572: fix inverted logic for HideUnrelatedOptions?.

update

Nov 24 2021, 9:19 PM · Restricted Project
vtjnash requested review of D114572: fix inverted logic for HideUnrelatedOptions?.
Nov 24 2021, 9:17 PM · Restricted Project