Page MenuHomePhabricator

vtjnash (Jameson Nash)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 21 2013, 6:34 AM (424 w, 13 h)

Recent Activity

Tue, Nov 30

vtjnash committed rG18308e171b5b: AArch64 GIsel: legalize lshr operands, even if it is poison (authored by vtjnash).
AArch64 GIsel: legalize lshr operands, even if it is poison
Tue, Nov 30, 12:30 PM
vtjnash closed D114389: AArch64 GIsel: legalize lshr operands, even if it is poison.
Tue, Nov 30, 12:30 PM · Restricted Project, Restricted Project
vtjnash added a comment to D111100: enable plugins for clang-tidy.

There is clearly some more work to do to get the cmake file to be correct, but was hoping to check this looked like the direction you thought looked right for adding this test, since there isn't an obvious example to follow.

Tue, Nov 30, 12:08 PM · Restricted Project
vtjnash committed rG2e114e3fda4f: fix inverted logic for HideUnrelatedOptions (authored by vtjnash).
fix inverted logic for HideUnrelatedOptions
Tue, Nov 30, 11:59 AM
vtjnash closed D114572: fix inverted logic for HideUnrelatedOptions?.
Tue, Nov 30, 11:59 AM · Restricted Project

Sat, Nov 27

vtjnash added a comment to D114572: fix inverted logic for HideUnrelatedOptions?.

I couldn't think of an example where you'd want to make sure all of the assigned categories were related to the command being used, instead of showing the option if at least one was related to it. Currently it hides the option as soon as any don't match, whereas it seems like you'd want to hide the option only if all categories don't match.

Sat, Nov 27, 1:45 PM · Restricted Project

Wed, Nov 24

vtjnash retitled D114572: fix inverted logic for HideUnrelatedOptions? from fix inverted logic for HideUnrelatedOptions to fix inverted logic for HideUnrelatedOptions?.
Wed, Nov 24, 9:34 PM · Restricted Project
vtjnash updated the diff for D114572: fix inverted logic for HideUnrelatedOptions?.

update

Wed, Nov 24, 9:19 PM · Restricted Project
vtjnash requested review of D114572: fix inverted logic for HideUnrelatedOptions?.
Wed, Nov 24, 9:17 PM · Restricted Project
vtjnash abandoned D114571: add release notes, docs mention, and test example.
Wed, Nov 24, 9:17 PM · Restricted Project
vtjnash added a comment to D111100: enable plugins for clang-tidy.

This is probably just a draft, but please let me know what you think

Wed, Nov 24, 9:03 PM · Restricted Project
vtjnash updated the diff for D111100: enable plugins for clang-tidy.

enable help

Wed, Nov 24, 9:03 PM · Restricted Project
vtjnash updated the diff for D111100: enable plugins for clang-tidy.

oops

Wed, Nov 24, 8:29 PM · Restricted Project
vtjnash updated the diff for D111100: enable plugins for clang-tidy.

oops

Wed, Nov 24, 8:29 PM · Restricted Project
vtjnash updated the diff for D111100: enable plugins for clang-tidy.

add release notes, docs mention, and test example

Wed, Nov 24, 8:15 PM · Restricted Project
vtjnash updated the diff for D111100: enable plugins for clang-tidy.

add release notes, docs mention, and test example

Wed, Nov 24, 8:14 PM · Restricted Project
vtjnash requested review of D114571: add release notes, docs mention, and test example.
Wed, Nov 24, 8:13 PM · Restricted Project
vtjnash committed rG0332d105b9ad: GlobalISel: remove assert that memcpy Src and Dst addrspace must be identical (authored by vtjnash).
GlobalISel: remove assert that memcpy Src and Dst addrspace must be identical
Wed, Nov 24, 5:24 PM
vtjnash closed D93154: GlobalISel: remove assert that memcpy Src and Dst addrspace must be identical.
Wed, Nov 24, 5:24 PM · Restricted Project
vtjnash updated the diff for D93154: GlobalISel: remove assert that memcpy Src and Dst addrspace must be identical.

Rename LoadTy to SrcTy and StoreTy to DstTy

Wed, Nov 24, 2:43 PM · Restricted Project

Mon, Nov 22

vtjnash updated the summary of D114389: AArch64 GIsel: legalize lshr operands, even if it is poison.
Mon, Nov 22, 1:05 PM · Restricted Project, Restricted Project
vtjnash requested review of D114389: AArch64 GIsel: legalize lshr operands, even if it is poison.
Mon, Nov 22, 1:01 PM · Restricted Project, Restricted Project

Tue, Nov 16

vtjnash added a comment to D111100: enable plugins for clang-tidy.

Yes, this header does everything

Tue, Nov 16, 10:42 AM · Restricted Project

Nov 3 2021

vtjnash added a comment to D93154: GlobalISel: remove assert that memcpy Src and Dst addrspace must be identical.

@aemerson are you happy with this test for approval and merge now?

Nov 3 2021, 8:40 AM · Restricted Project
vtjnash added a comment to D111100: enable plugins for clang-tidy.

bump? tagging some more people who seemed like possible reviewers. I realized my original list of candidates might have mostly been inactive people.

Nov 3 2021, 8:39 AM · Restricted Project
vtjnash added reviewers for D111100: enable plugins for clang-tidy: segoon, thakis, mgorny, carlosgalvezp.
Nov 3 2021, 8:37 AM · Restricted Project

Oct 21 2021

vtjnash updated the diff for D93154: GlobalISel: remove assert that memcpy Src and Dst addrspace must be identical.

adding test

Oct 21 2021, 11:53 AM · Restricted Project
vtjnash added a comment to D111100: enable plugins for clang-tidy.

bump?

Oct 21 2021, 8:12 AM · Restricted Project

Oct 14 2021

vtjnash added a comment to D111100: enable plugins for clang-tidy.

bump?

Oct 14 2021, 1:09 PM · Restricted Project

Oct 4 2021

vtjnash updated the summary of D111100: enable plugins for clang-tidy.
Oct 4 2021, 3:50 PM · Restricted Project
vtjnash requested review of D111100: enable plugins for clang-tidy.
Oct 4 2021, 3:43 PM · Restricted Project

Oct 2 2021

vtjnash committed rGe8806d748643: Re-apply the fix on DwarfEHPrepare and add a test (authored by tkf).
Re-apply the fix on DwarfEHPrepare and add a test
Oct 2 2021, 6:52 PM
vtjnash closed D110979: Re-apply the fix on DwarfEHPrepare and add a test.
Oct 2 2021, 6:51 PM · Restricted Project, Restricted Project

Sep 27 2021

vtjnash committed rGe27a6db5298f: Bad SLPVectorization shufflevector replacement, resulting in write to wrong… (authored by vtjnash).
Bad SLPVectorization shufflevector replacement, resulting in write to wrong…
Sep 27 2021, 11:10 AM
vtjnash closed D106613: Bad SLPVectorization shufflevector replacement, resulting in write to wrong memory location.
Sep 27 2021, 11:09 AM · Restricted Project, Restricted Project

Sep 25 2021

vtjnash updated the diff for D106613: Bad SLPVectorization shufflevector replacement, resulting in write to wrong memory location.

fix test

Sep 25 2021, 11:43 AM · Restricted Project, Restricted Project
vtjnash added a comment to D110413: [X86] Fix handling of i128<->fp on Windows.

Looks similar to my previous patch (rG4a406d32e97b1748c4eed6674a2c1819b9cf98ea), so this makes sense to me.

Sep 25 2021, 11:30 AM · Restricted Project
vtjnash added a comment to D106613: Bad SLPVectorization shufflevector replacement, resulting in write to wrong memory location.

I don't have a test, but it sounded like you did?

Sep 25 2021, 11:14 AM · Restricted Project, Restricted Project
vtjnash updated the diff for D106613: Bad SLPVectorization shufflevector replacement, resulting in write to wrong memory location.

clang-format

Sep 25 2021, 11:09 AM · Restricted Project, Restricted Project

Sep 21 2021

vtjnash added a comment to D106613: Bad SLPVectorization shufflevector replacement, resulting in write to wrong memory location.

Thanks!

Sep 21 2021, 12:45 PM · Restricted Project, Restricted Project
vtjnash added a comment to D106613: Bad SLPVectorization shufflevector replacement, resulting in write to wrong memory location.

The output looks to be missing a llvm.masked.gather.v2i64.v2p0i64 call. Did you remember to revert 0d74fd3fdf50? I can push a branch to github with this current commit, if that would be helpful.

Sep 21 2021, 12:32 PM · Restricted Project, Restricted Project

Sep 14 2021

vtjnash added a comment to D106613: Bad SLPVectorization shufflevector replacement, resulting in write to wrong memory location.

bump

Sep 14 2021, 1:15 PM · Restricted Project, Restricted Project

Sep 9 2021

vtjnash committed rGe20f69f612dd: [Aarch64] Correct register class for pseudo instructions (authored by vtjnash).
[Aarch64] Correct register class for pseudo instructions
Sep 9 2021, 11:34 AM
vtjnash closed D97435: [Aarch64] Correct register class for pseudo instructions.
Sep 9 2021, 11:33 AM · Restricted Project, Restricted Project

Sep 7 2021

vtjnash committed rGae8507b0df73: [X86] Don't clobber EBX in stackprobes (authored by staticfloat).
[X86] Don't clobber EBX in stackprobes
Sep 7 2021, 12:01 PM
vtjnash closed D109203: [X86] Don't clobber EBX in stackprobes.
Sep 7 2021, 12:01 PM · Restricted Project
vtjnash updated the diff for D109203: [X86] Don't clobber EBX in stackprobes.

rebase on main

Sep 7 2021, 7:41 AM · Restricted Project

Sep 2 2021

vtjnash added a comment to D109203: [X86] Don't clobber EBX in stackprobes.

Need a test fix, but lgtm

Sep 2 2021, 7:58 PM · Restricted Project

Sep 1 2021

vtjnash updated the diff for D97435: [Aarch64] Correct register class for pseudo instructions.

fix another missed test update

Sep 1 2021, 12:18 PM · Restricted Project, Restricted Project
vtjnash updated the diff for D97435: [Aarch64] Correct register class for pseudo instructions.

rebase onto master

Sep 1 2021, 12:06 PM · Restricted Project, Restricted Project

Aug 30 2021

vtjnash committed rGea8539111d44: [COFF] Force Symbols containing '.' to be quoted (authored by loladiro).
[COFF] Force Symbols containing '.' to be quoted
Aug 30 2021, 2:31 PM
vtjnash closed D100359: [COFF] Force Symbols containing '.' to be quoted.
Aug 30 2021, 2:31 PM · Restricted Project

Aug 29 2021

vtjnash requested changes to D75072: [SCEV] Record NI types in add exprs.

The complexity of this design appears to have been rendered mostly irrelevant by 141e845da5dda6743a09f858b4aec0133a931453, so only the new flag is needed, and not the new subclass.

Aug 29 2021, 6:38 PM · Restricted Project, Restricted Project

Aug 28 2021

vtjnash added a comment to D106613: Bad SLPVectorization shufflevector replacement, resulting in write to wrong memory location.

The full reproducer is in the commit message on phabricator for this review, though I don't know how to link to the text of a commit specifically. Here's the text of that:

Aug 28 2021, 1:16 PM · Restricted Project, Restricted Project

Aug 19 2021

vtjnash added inline comments to D106613: Bad SLPVectorization shufflevector replacement, resulting in write to wrong memory location.
Aug 19 2021, 11:30 AM · Restricted Project, Restricted Project

Jul 26 2021

vtjnash updated the diff for D100359: [COFF] Force Symbols containing '.' to be quoted.

adding test

Jul 26 2021, 2:22 PM · Restricted Project

Jul 23 2021

vtjnash added inline comments to D106613: Bad SLPVectorization shufflevector replacement, resulting in write to wrong memory location.
Jul 23 2021, 10:29 AM · Restricted Project, Restricted Project
vtjnash updated subscribers of D106613: Bad SLPVectorization shufflevector replacement, resulting in write to wrong memory location.
Jul 23 2021, 10:16 AM · Restricted Project, Restricted Project

Jul 22 2021

vtjnash retitled D106613: Bad SLPVectorization shufflevector replacement, resulting in write to wrong memory location from Bad SLPVectorization shufflevector replacement to Bad SLPVectorization shufflevector replacement, resulting in write to wrong memory location.
Jul 22 2021, 4:56 PM · Restricted Project, Restricted Project
vtjnash requested review of D106613: Bad SLPVectorization shufflevector replacement, resulting in write to wrong memory location.
Jul 22 2021, 4:48 PM · Restricted Project, Restricted Project
vtjnash added inline comments to D105042: [SLP][COST][X86]Improve cost model for masked gather..
Jul 22 2021, 2:53 PM · Restricted Project

Jul 19 2021

vtjnash added a comment to D106206: Remove the NotUnderValgrind caching flag.

There doesn't seem to be a reason to make the VALGRIND_DISCARD_TRANSLATIONS call conditional. The macro is already a specific sequence of bytes (e.g. rol instructions) that are a no-op if valgrind is not running the particular segment of code inside its own JIT

Jul 19 2021, 10:57 AM · Restricted Project, Restricted Project

Mar 18 2021

vtjnash added a comment to D75967: Work around somes register/spill/liveness issues relating to returnTwice aka setjmp.

It appears another subset of this might have been merged in https://reviews.llvm.org/D77767 also?

Mar 18 2021, 2:21 PM · Restricted Project, Restricted Project

Feb 10 2021

vtjnash committed rGa7db68018382: Renovate CMake files in the `llvm-exegesis` tool. (authored by vtjnash).
Renovate CMake files in the `llvm-exegesis` tool.
Feb 10 2021, 11:25 AM
vtjnash closed D90970: Renovate CMake files in the `llvm-exegesis` tool..
Feb 10 2021, 11:24 AM · Restricted Project

Feb 8 2021

vtjnash added a comment to rG8172ed91f8ff: [X86] Speculatively fix to X86AvoidStoreForwardingBlocks not deference a….

This looks like the bug I reported in https://bugs.llvm.org/show_bug.cgi?id=41629. Should I close it, or did you want to add that as a test?

Feb 8 2021, 8:33 PM
vtjnash updated the diff for D90970: Renovate CMake files in the `llvm-exegesis` tool..

On second thought, since the SHARED build is now fixed, there is no reason to disable it (and it helps eliminate more missing link problems).

Feb 8 2021, 6:33 PM · Restricted Project
vtjnash updated the diff for D90970: Renovate CMake files in the `llvm-exegesis` tool..

Okay, the first problem is because add_llvm_library doesn't support STATIC, so we need to use llvm_add_library instead (though it is also fixed by adding the missing Support dependency). The second problem is also missing dependency (for CommonTableGen).

Feb 8 2021, 6:05 PM · Restricted Project
vtjnash reopened D90970: Renovate CMake files in the `llvm-exegesis` tool..

Reverted. Seems that something is going wrong with -DBUILD_SHARED_LIBS=ON with this.

Feb 8 2021, 4:23 PM · Restricted Project
vtjnash added a reverting change for rG549a1e2e5950: Renovate CMake files in the `llvm-exegesis` tool.: rG10c1d290d92f: Revert "Renovate CMake files in the `llvm-exegesis` tool.".
Feb 8 2021, 4:12 PM
vtjnash committed rG10c1d290d92f: Revert "Renovate CMake files in the `llvm-exegesis` tool." (authored by vtjnash).
Revert "Renovate CMake files in the `llvm-exegesis` tool."
Feb 8 2021, 4:12 PM
vtjnash added a reverting change for D90970: Renovate CMake files in the `llvm-exegesis` tool.: rG10c1d290d92f: Revert "Renovate CMake files in the `llvm-exegesis` tool.".
Feb 8 2021, 4:12 PM · Restricted Project
vtjnash accepted D94813: [MergeICmps] Don't merge icmps derived from pointers with addressspaces.

LGTM, modulo comments from previous reviewer

Feb 8 2021, 3:29 PM · Restricted Project
vtjnash committed rG16e7973c5d8f: Renovate CMake file for the `llvm-cfi-verify` tool (authored by vtjnash).
Renovate CMake file for the `llvm-cfi-verify` tool
Feb 8 2021, 3:27 PM
vtjnash committed rG549a1e2e5950: Renovate CMake files in the `llvm-exegesis` tool. (authored by vtjnash).
Renovate CMake files in the `llvm-exegesis` tool.
Feb 8 2021, 3:27 PM
vtjnash closed D90969: Renovate CMake file for the `llvm-cfi-verify` tool.
Feb 8 2021, 3:27 PM · Restricted Project
vtjnash closed D90970: Renovate CMake files in the `llvm-exegesis` tool..
Feb 8 2021, 3:27 PM · Restricted Project

Dec 11 2020

vtjnash updated the diff for D93154: GlobalISel: remove assert that memcpy Src and Dst addrspace must be identical.

needed for memmove too

Dec 11 2020, 10:11 PM · Restricted Project
vtjnash updated subscribers of D93154: GlobalISel: remove assert that memcpy Src and Dst addrspace must be identical.
Dec 11 2020, 10:04 PM · Restricted Project
vtjnash requested review of D93154: GlobalISel: remove assert that memcpy Src and Dst addrspace must be identical.
Dec 11 2020, 10:03 PM · Restricted Project

Dec 3 2020

vtjnash committed rGc01fb6449e17: repair cygwin build (authored by vtjnash).
repair cygwin build
Dec 3 2020, 8:50 AM
vtjnash closed D92336: repair cygwin build.
Dec 3 2020, 8:50 AM · Restricted Project
vtjnash added a comment to D92336: repair cygwin build.

I think with the move to newer C++ standards, some of the missing functionality in C could be replicated (or use the _WIN32 code paths for __CYGWIN__ in more places). I tried that for a bit, but it was pieces like struct sigaction, realpath, and getsid missing, which are very platform-specific.

Dec 3 2020, 7:21 AM · Restricted Project

Nov 30 2020

vtjnash updated the summary of D92336: repair cygwin build.
Nov 30 2020, 11:16 AM · Restricted Project
vtjnash added a reviewer for D92336: repair cygwin build: compnerd.
Nov 30 2020, 11:15 AM · Restricted Project
vtjnash requested review of D92336: repair cygwin build.
Nov 30 2020, 11:14 AM · Restricted Project

Nov 23 2020

vtjnash added a reviewer for D90705: [GVN] permit forwarding to non-byte-sized loads: kuba.
Nov 23 2020, 5:32 PM · Restricted Project
vtjnash added reviewers for D90969: Renovate CMake file for the `llvm-cfi-verify` tool: stephenneuendorffer, tstellar.
Nov 23 2020, 5:30 PM · Restricted Project
vtjnash added reviewers for D90970: Renovate CMake files in the `llvm-exegesis` tool.: tstellar, stephenneuendorffer.
Nov 23 2020, 5:29 PM · Restricted Project
vtjnash committed rG8f1e0dcbb090: fix some Wundef warnings in public headers (authored by vtjnash).
fix some Wundef warnings in public headers
Nov 23 2020, 5:19 PM
vtjnash closed D91094: fix some Wundef warnings in public headers.
Nov 23 2020, 5:19 PM · Restricted Project

Nov 16 2020

vtjnash added a reverting change for rG105ed27ed80d: Revert "[AsmPrinter] fix -disable-debug-info option": rGbf6ed355c8d1: Reland "[AsmPrinter] fix -disable-debug-info option".
Nov 16 2020, 10:35 AM
vtjnash committed rGbf6ed355c8d1: Reland "[AsmPrinter] fix -disable-debug-info option" (authored by vtjnash).
Reland "[AsmPrinter] fix -disable-debug-info option"
Nov 16 2020, 10:35 AM
vtjnash added a comment to D88138: [NPM] Add target specific hook to add passes for New Pass Manager.

I think this, and similar recent commits, are causing the shared library builds to fail some tests if this code gets linked into libLLVM.so: https://bugs.llvm.org/show_bug.cgi?id=48181. I assume it might actually a bug in ld (GNU Binutils for Ubuntu 2.34), as I don't understand the linker behavior there?

Nov 16 2020, 10:24 AM · Restricted Project, Restricted Project

Nov 14 2020

vtjnash added a comment to D91083: [AsmPrinter] fix -disable-debug-info option.

Thanks for identifying that. I think I can re-land just without that part of the test. It is not essential, I added it just to try to check all of the dwarf-related output.

Nov 14 2020, 10:59 AM · Restricted Project

Nov 12 2020

vtjnash committed rG9606ef03f039: [AsmPrinter] fix -disable-debug-info option (authored by vtjnash).
[AsmPrinter] fix -disable-debug-info option
Nov 12 2020, 9:59 PM
vtjnash closed D91083: [AsmPrinter] fix -disable-debug-info option.
Nov 12 2020, 9:59 PM · Restricted Project

Nov 9 2020

vtjnash added a reviewer for D91094: fix some Wundef warnings in public headers: bob.wilson.
Nov 9 2020, 11:01 AM · Restricted Project
vtjnash requested review of D91094: fix some Wundef warnings in public headers.
Nov 9 2020, 11:01 AM · Restricted Project
vtjnash added a reviewer for D90969: Renovate CMake file for the `llvm-cfi-verify` tool: chapuni.
Nov 9 2020, 10:25 AM · Restricted Project