Page MenuHomePhabricator

vtjnash (Jameson Nash)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 21 2013, 6:34 AM (308 w, 2 d)

Recent Activity

Mon, Sep 16

vtjnash added a comment to D65057: [ConstantFolding] Use FoldBitCast correctly.

bump? please review/merge this bugfix?

Mon, Sep 16, 6:31 AM · Restricted Project

Tue, Sep 10

vtjnash added a comment to D65057: [ConstantFolding] Use FoldBitCast correctly.

bump

Tue, Sep 10, 9:28 AM · Restricted Project

Wed, Aug 21

vtjnash added a comment to D65057: [ConstantFolding] Use FoldBitCast correctly.

Bump again? It's just a tiny bugfix that reames told me is needed (https://reviews.llvm.org/D59730?id=196652#inline-570528)

Wed, Aug 21, 1:55 PM · Restricted Project

Aug 14 2019

vtjnash added a comment to D65057: [ConstantFolding] Use FoldBitCast correctly.

bump again? (I don't have commit rights.)

Aug 14 2019, 7:04 AM · Restricted Project

Aug 5 2019

vtjnash added inline comments to D65057: [ConstantFolding] Use FoldBitCast correctly.
Aug 5 2019, 1:50 PM · Restricted Project
vtjnash added a comment to D65057: [ConstantFolding] Use FoldBitCast correctly.

bump.

Aug 5 2019, 1:40 PM · Restricted Project
vtjnash added a reviewer for D65057: [ConstantFolding] Use FoldBitCast correctly: majnemer.
Aug 5 2019, 1:40 PM · Restricted Project

Jul 26 2019

vtjnash added a comment to D65057: [ConstantFolding] Use FoldBitCast correctly.

Friendly bump.

Jul 26 2019, 6:53 AM · Restricted Project

Jul 21 2019

vtjnash added inline comments to D59730: [GVN] teach ConstantFolding correct handling of non-integral addrspace casts.
Jul 21 2019, 9:39 AM · Restricted Project
vtjnash added a comment to D65057: [ConstantFolding] Use FoldBitCast correctly.

The added assertion will detect this:

[109/110] Running lit suite /data/vtjnash/julia/deps/srccache/llvm-svn/test/Transforms                                                                                       [19/519]
FAIL: LLVM :: Transforms/InstSimplify/vector_ptr_bitcast.ll (2527 of 4814)
******************** TEST 'LLVM :: Transforms/InstSimplify/vector_ptr_bitcast.ll' FAILED ********************
Script:
--
: 'RUN: at line 1';   /data/vtjnash/julia/deps/scratch/llvm-svn/build_Release+Asserts/bin/opt -S -instsimplify < /data/vtjnash/julia/deps/srccache/llvm-svn/test/Transforms/InstSimpl
ify/vector_ptr_bitcast.ll | /data/vtjnash/julia/deps/scratch/llvm-svn/build_Release+Asserts/bin/FileCheck /data/vtjnash/julia/deps/srccache/llvm-svn/test/Transforms/InstSimplify/vec
tor_ptr_bitcast.ll
--
Exit Code: 2
Jul 21 2019, 9:35 AM · Restricted Project
vtjnash updated the diff for D59730: [GVN] teach ConstantFolding correct handling of non-integral addrspace casts.

[GVN] teach ConstantFolding correct handling of non-integral addrspace casts

Jul 21 2019, 9:31 AM · Restricted Project
vtjnash updated the diff for D59730: [GVN] teach ConstantFolding correct handling of non-integral addrspace casts.

[GVN] teach ConstantFolding correct handling of non-integral addrspace casts

Jul 21 2019, 9:31 AM · Restricted Project
vtjnash added a child revision for D65057: [ConstantFolding] Use FoldBitCast correctly: D59730: [GVN] teach ConstantFolding correct handling of non-integral addrspace casts.
Jul 21 2019, 9:11 AM · Restricted Project
vtjnash added a parent revision for D59730: [GVN] teach ConstantFolding correct handling of non-integral addrspace casts: D65057: [ConstantFolding] Use FoldBitCast correctly.
Jul 21 2019, 9:11 AM · Restricted Project
vtjnash added reviewers for D65057: [ConstantFolding] Use FoldBitCast correctly: reames, loladiro.
Jul 21 2019, 9:07 AM · Restricted Project
vtjnash created D65057: [ConstantFolding] Use FoldBitCast correctly.
Jul 21 2019, 9:04 AM · Restricted Project

Jul 15 2019

vtjnash added a comment to D59730: [GVN] teach ConstantFolding correct handling of non-integral addrspace casts.

Bump. Fixed the other bug in handling vectors that you noted, and added an assert to catch that misuse.

Jul 15 2019, 11:54 AM · Restricted Project

Jun 29 2019

vtjnash added inline comments to D59730: [GVN] teach ConstantFolding correct handling of non-integral addrspace casts.
Jun 29 2019, 12:32 PM · Restricted Project
vtjnash updated the diff for D59730: [GVN] teach ConstantFolding correct handling of non-integral addrspace casts.

FoldBitCast was being instructed to create invalid IR in several test cases. We happened to fold away them away before the verifier noticed, so this adds an explicit check, and corrects the caller FoldReinterpretLoadFromConstPtr to form valid IR when handling vectors of pointers with this method.

Jun 29 2019, 12:28 PM · Restricted Project

Jun 13 2019

vtjnash added a comment to D59730: [GVN] teach ConstantFolding correct handling of non-integral addrspace casts.

bump. please review, thanks!

Jun 13 2019, 10:35 AM · Restricted Project

Jun 7 2019

vtjnash added a comment to D59729: [GVN] non-functional code movement.

@loladiro can you land this for me?

Jun 7 2019, 11:45 AM · Restricted Project

May 7 2019

vtjnash added inline comments to D59729: [GVN] non-functional code movement.
May 7 2019, 9:09 AM · Restricted Project

May 2 2019

vtjnash updated subscribers of D59730: [GVN] teach ConstantFolding correct handling of non-integral addrspace casts.
May 2 2019, 10:25 AM · Restricted Project
vtjnash updated subscribers of D59729: [GVN] non-functional code movement.
May 2 2019, 10:25 AM · Restricted Project

Apr 26 2019

Herald added a project to D46460: [LoopInfo] Don't bail out early in getLoopID: Restricted Project.

@loladiro bump. It sounds like this was approved, but it doesn't apply cleanly now.

Apr 26 2019, 10:16 AM · Restricted Project

Apr 25 2019

vtjnash added a comment to D44650: Fix build of llvm-cfi-verify on mingw32.

Is this OK to land?

Apr 25 2019, 10:58 AM · Restricted Project
Herald added a project to D44650: Fix build of llvm-cfi-verify on mingw32: Restricted Project.
Apr 25 2019, 10:58 AM · Restricted Project
vtjnash updated the diff for D59661: [GVN] Try to be more principled about non-integral pointers.
Apr 25 2019, 9:21 AM · Restricted Project
vtjnash updated the diff for D59730: [GVN] teach ConstantFolding correct handling of non-integral addrspace casts.
Apr 25 2019, 9:20 AM · Restricted Project
vtjnash updated the diff for D59729: [GVN] non-functional code movement.

remove change that could result in a functional difference

Apr 25 2019, 9:20 AM · Restricted Project

Mar 26 2019

vtjnash added inline comments to D59729: [GVN] non-functional code movement.
Mar 26 2019, 6:18 PM · Restricted Project

Mar 22 2019

vtjnash abandoned D7976: fix X86Disassembler Address parameter.
Mar 22 2019, 6:27 PM · Restricted Project
vtjnash closed D1998: 128-bit ABI for x86_64-w64-mingw32 incorrectly generated.
Mar 22 2019, 6:27 PM
vtjnash accepted D1998: 128-bit ABI for x86_64-w64-mingw32 incorrectly generated.
Mar 22 2019, 6:14 PM
vtjnash added a comment to D59661: [GVN] Try to be more principled about non-integral pointers.

Thanks @reames, I appreciate what you've already done here. I had started this a long time ago, where more of it was a functional change, then discovered you had recently already made most of the essential fixes and written the necessary tests. I've changed this into a stack of 3 commits that touch slightly different areas.

Mar 22 2019, 6:11 PM · Restricted Project
vtjnash updated the diff for D59661: [GVN] Try to be more principled about non-integral pointers.

Split out part of the changes into two parent commits.

Mar 22 2019, 6:00 PM · Restricted Project
vtjnash added a parent revision for D59661: [GVN] Try to be more principled about non-integral pointers: D59730: [GVN] teach ConstantFolding correct handling of non-integral addrspace casts.
Mar 22 2019, 5:57 PM · Restricted Project
vtjnash added a child revision for D59730: [GVN] teach ConstantFolding correct handling of non-integral addrspace casts: D59661: [GVN] Try to be more principled about non-integral pointers.
Mar 22 2019, 5:57 PM · Restricted Project
vtjnash added a child revision for D59729: [GVN] non-functional code movement: D59730: [GVN] teach ConstantFolding correct handling of non-integral addrspace casts.
Mar 22 2019, 5:57 PM · Restricted Project
vtjnash added a parent revision for D59730: [GVN] teach ConstantFolding correct handling of non-integral addrspace casts: D59729: [GVN] non-functional code movement.
Mar 22 2019, 5:57 PM · Restricted Project
vtjnash created D59730: [GVN] teach ConstantFolding correct handling of non-integral addrspace casts.
Mar 22 2019, 5:57 PM · Restricted Project
vtjnash created D59729: [GVN] non-functional code movement.
Mar 22 2019, 5:01 PM · Restricted Project

Mar 21 2019

vtjnash created D59661: [GVN] Try to be more principled about non-integral pointers.
Mar 21 2019, 12:04 PM · Restricted Project

Dec 7 2016

vtjnash added a comment to D21731: fix bug 15393: invalid dwarf info on Win64.

the warnings in that test are from a different, related bug. An approximate correction for that is:

diff --git a/lib/CodeGen/AsmPrinter/DIE.cpp b/lib/CodeGen/AsmPrinter/DIE.cpp
index a328851..73977f2 100644
--- a/lib/CodeGen/AsmPrinter/DIE.cpp
+++ b/lib/CodeGen/AsmPrinter/DIE.cpp
@@ -495,7 +495,8 @@ void DIELabel::EmitValue(const AsmPrinter *AP, dwarf::Form Form) const {
   AP->EmitLabelReference(Label, SizeOf(AP, Form),
                          Form == dwarf::DW_FORM_strp ||
                              Form == dwarf::DW_FORM_sec_offset ||
-                             Form == dwarf::DW_FORM_ref_addr);
+                             Form == dwarf::DW_FORM_ref_addr ||
+                             Form == dwarf::DW_FORM_data4);
 }
Dec 7 2016, 9:46 PM

Nov 22 2016

vtjnash updated the diff for D21731: fix bug 15393: invalid dwarf info on Win64.

address review comments

Nov 22 2016, 7:00 PM

Nov 21 2016

vtjnash updated the diff for D21731: fix bug 15393: invalid dwarf info on Win64.

This updates the ref_addr_relocation test to have better coverage of the various combinations of DWARF versions and architectures. Because the debug info framework in LLVM expects that .secrel32 .debug_info + offset exists (and LLVM also tests that the debug info isn't using labels that would be supported everywhere: "test that we don't create useless labels"), this also makes that a real relocation type and handles the printing and parsing of it.

Nov 21 2016, 6:11 PM

Jun 28 2016

vtjnash added inline comments to D16505: ScalarEvolutionExpander step scaling bug.
Jun 28 2016, 9:40 AM

Jun 25 2016

vtjnash retitled D21731: fix bug 15393: invalid dwarf info on Win64 from to fix bug 15393: invalid dwarf info on Win64.
Jun 25 2016, 8:40 PM

Jun 9 2016

vtjnash added a comment to D16505: ScalarEvolutionExpander step scaling bug.

bump

Jun 9 2016, 12:02 PM

Jun 1 2016

vtjnash added a comment to D16505: ScalarEvolutionExpander step scaling bug.

I couldn't get Keno's testcase to work for me (it shows the patch, but not the bug), so I re-extracted it with bugpoint and simplified it a bit more by hand.

Jun 1 2016, 11:39 AM
vtjnash updated the diff for D16505: ScalarEvolutionExpander step scaling bug.
Jun 1 2016, 11:37 AM
vtjnash updated the diff for D20802: fix PPC64 SUBFC8 Defs list.
Jun 1 2016, 9:44 AM
vtjnash added inline comments to D20802: fix PPC64 SUBFC8 Defs list.
Jun 1 2016, 9:13 AM

May 31 2016

vtjnash updated the diff for D20802: fix PPC64 SUBFC8 Defs list.
May 31 2016, 9:57 AM
vtjnash added a comment to D20802: fix PPC64 SUBFC8 Defs list.

I don't think the correct approach is to change the definition of this instruction to no longer implicitly define "CARRY". The correct approach would probably be for it to implicitly define both of the special registers that it sets (CARRY, CR0).

May 31 2016, 9:55 AM

May 30 2016

vtjnash retitled D20802: fix PPC64 SUBFC8 Defs list from to fix PPC64 SUBFC8 Defs list.
May 30 2016, 9:34 PM

Feb 3 2016

vtjnash updated the diff for D16505: ScalarEvolutionExpander step scaling bug.

full context diff

Feb 3 2016, 1:40 PM

Jan 27 2016

vtjnash added a comment to D7976: fix X86Disassembler Address parameter.

it looks like the other disassembler targets also ignore Address and simply read the first N bytes from "Bytes", so i assume that was an intentional change in llvm3.5?

Jan 27 2016, 11:11 PM · Restricted Project
vtjnash added a comment to D16505: ScalarEvolutionExpander step scaling bug.

i don't know how to reduce the test case, but in the attached IR, the "loop-reduce" pass does an invalid transform for the computation of %57 from %25 from %"#s13.0"

Jan 27 2016, 10:51 PM

Jan 23 2016

vtjnash updated subscribers of D16505: ScalarEvolutionExpander step scaling bug.
Jan 23 2016, 1:15 AM
vtjnash retitled D16505: ScalarEvolutionExpander step scaling bug from to ScalarEvolutionExpander step scaling bug.
Jan 23 2016, 1:13 AM

Sep 24 2015

vtjnash added inline comments to D8815: [RuntimeDyld] Initial limited TLS support.
Sep 24 2015, 10:39 PM

Mar 6 2015

vtjnash updated subscribers of D6961: Make it easier to use DwarfContext with MCJIT.
Mar 6 2015, 8:25 PM

Feb 28 2015

vtjnash updated subscribers of D7976: fix X86Disassembler Address parameter.
Feb 28 2015, 4:26 PM · Restricted Project
vtjnash retitled D7976: fix X86Disassembler Address parameter from fix X86Disassembler to fix X86Disassembler Address parameter.
Feb 28 2015, 3:25 PM · Restricted Project
vtjnash retitled D7976: fix X86Disassembler Address parameter from to fix X86Disassembler.
Feb 28 2015, 3:24 PM · Restricted Project

May 5 2014

vtjnash added a comment to D1998: 128-bit ABI for x86_64-w64-mingw32 incorrectly generated.

@rnk I have updated the diff based on your comments (although I did not manage to locate a copy of clang-format). As suggested, I strengthened all of the conditional checks to assertions. The original code to retest the conditional was copied from the ARM code example and was not needed here.

May 5 2014, 5:26 PM
vtjnash updated the diff for D1998: 128-bit ABI for x86_64-w64-mingw32 incorrectly generated.

reformat per comments

May 5 2014, 5:21 PM