This reverts commit 40d5eeac6cd89a2360c3ba997cbaa816abca828c.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/MC/MCStreamer.cpp | ||
---|---|---|
1343–1345 | This was broken in the original change, because we were blindly dereferencing an Optional without checking whether it had a value. | |
llvm/unittests/Support/Host.cpp | ||
408–409 | This was broken in the original change. Because it's wrapped in "#if defined(APPLE)", I'm not sure how to test it prior to commit. |
Don't use the preprocessor to hide test cases, so we can at least tell if it compiles when testing on platforms other than Apple and AIX.
Either this or D115139 broke check-llvm on arm macs: http://45.33.8.238/macm1/23120/step_11.txt
getMacOSHostVersion sounds kind of triple-related, so I'm guessing it's this one.
Please take a look, and revert for now if it takes a while to fix.
Oh, it's already reverted, apologies. We'll know if that fixed that bot in 15 min or so then. Something to keep in mind for relanding though :)
Yeah, I'm currently trying to build and test on my Mac laptop. It's not ARM tho, so if the test passes there I'm not sure what my next steps are to land this change.
It seems to also fail on other arm bots. Chances are it'll fail locally on intel machines if you run cmake with -DLLVM_DEFAULT_TARGET_TRIPLE=arm64-apple-darwin (or some other arm triple). Does that help? (I haven't tried it in this case, but most of the time that's sufficient to repro arm-host issues on non-host machines.)
This was broken in the original change, because we were blindly dereferencing an Optional without checking whether it had a value.