Page MenuHomePhabricator

jamesfarrell (James Farrell)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 16 2021, 1:39 PM (9 w, 4 h)

Recent Activity

Dec 8 2021

jamesfarrell added a comment to D115254: Use VersionTuple for parsing versions in Triple.

commit 219672b8dd06c4765185fa3161c98437d49b4a1b says Revert "Revert "...""

For such commits, it is customary to use "Reland " and the commit message should include the original message (people don't like chasing through several commits to obtain the important original message) and a short note about what was fixed, so that people doing archaeology can know better what's going on.

Dec 8 2021, 6:42 AM · Restricted Project, Restricted Project

Dec 7 2021

jamesfarrell added a reverting change for rG63a6348cad6c: Revert "Use VersionTuple for parsing versions in Triple, fixing issues that…: rG219672b8dd06: Revert "Revert "Use VersionTuple for parsing versions in Triple, fixing issues….
Dec 7 2021, 3:15 PM
jamesfarrell committed rG219672b8dd06: Revert "Revert "Use VersionTuple for parsing versions in Triple, fixing issues… (authored by jamesfarrell).
Revert "Revert "Use VersionTuple for parsing versions in Triple, fixing issues…
Dec 7 2021, 3:15 PM
jamesfarrell closed D115254: Use VersionTuple for parsing versions in Triple.
Dec 7 2021, 3:15 PM · Restricted Project, Restricted Project
jamesfarrell updated the summary of D115254: Use VersionTuple for parsing versions in Triple.
Dec 7 2021, 2:19 PM · Restricted Project, Restricted Project
jamesfarrell retitled D115254: Use VersionTuple for parsing versions in Triple from Revert "Revert "Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible."" to Use VersionTuple for parsing versions in Triple.
Dec 7 2021, 12:36 PM · Restricted Project, Restricted Project
jamesfarrell added reviewers for D115254: Use VersionTuple for parsing versions in Triple: arphaman, thakis.
Dec 7 2021, 8:21 AM · Restricted Project, Restricted Project
jamesfarrell added a comment to D115254: Use VersionTuple for parsing versions in Triple.

Only change from previous attempt is to call rtrim() on the output of the commands in the unit tests, since the new version parsing code fails if there are leftover characters like \n.

Dec 7 2021, 8:19 AM · Restricted Project, Restricted Project
jamesfarrell added a reviewer for D115254: Use VersionTuple for parsing versions in Triple: danalbert.
Dec 7 2021, 8:18 AM · Restricted Project, Restricted Project
jamesfarrell added a reverting change for rG63a6348cad6c: Revert "Use VersionTuple for parsing versions in Triple, fixing issues that…: D115254: Use VersionTuple for parsing versions in Triple.
Dec 7 2021, 8:18 AM
jamesfarrell requested review of D115254: Use VersionTuple for parsing versions in Triple.
Dec 7 2021, 8:18 AM · Restricted Project, Restricted Project

Dec 6 2021

jamesfarrell added a comment to D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible..

Oh, it's already reverted, apologies. We'll know if that fixed that bot in 15 min or so then. Something to keep in mind for relanding though :)

Dec 6 2021, 10:37 AM · Restricted Project, Restricted Project
jamesfarrell added a reverting change for rG50324670342d: Use VersionTuple for parsing versions in Triple, fixing issues that caused the…: rG63a6348cad6c: Revert "Use VersionTuple for parsing versions in Triple, fixing issues that….
Dec 6 2021, 9:36 AM
jamesfarrell added a reverting change for D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.: rG63a6348cad6c: Revert "Use VersionTuple for parsing versions in Triple, fixing issues that….
Dec 6 2021, 9:36 AM · Restricted Project, Restricted Project
jamesfarrell committed rG63a6348cad6c: Revert "Use VersionTuple for parsing versions in Triple, fixing issues that… (authored by jamesfarrell).
Revert "Use VersionTuple for parsing versions in Triple, fixing issues that…
Dec 6 2021, 9:36 AM
jamesfarrell added a reverting change for rG40d5eeac6cd8: Revert "Use VersionTuple for parsing versions in Triple. This makes it possible…: rG50324670342d: Use VersionTuple for parsing versions in Triple, fixing issues that caused the….
Dec 6 2021, 6:58 AM
jamesfarrell committed rG50324670342d: Use VersionTuple for parsing versions in Triple, fixing issues that caused the… (authored by jamesfarrell).
Use VersionTuple for parsing versions in Triple, fixing issues that caused the…
Dec 6 2021, 6:58 AM
jamesfarrell closed D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible..
Dec 6 2021, 6:58 AM · Restricted Project, Restricted Project

Dec 2 2021

jamesfarrell updated the diff for D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible..

Don't use the preprocessor to hide test cases, so we can at least tell if it compiles when testing on platforms other than Apple and AIX.

Dec 2 2021, 7:26 AM · Restricted Project, Restricted Project

Dec 1 2021

jamesfarrell added inline comments to D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible..
Dec 1 2021, 9:02 AM · Restricted Project, Restricted Project
jamesfarrell added reviewers for D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.: danalbert, arphaman.
Dec 1 2021, 8:59 AM · Restricted Project, Restricted Project
jamesfarrell added a reverting change for rG40d5eeac6cd8: Revert "Use VersionTuple for parsing versions in Triple. This makes it possible…: D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible..
Dec 1 2021, 8:57 AM
jamesfarrell requested review of D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible..
Dec 1 2021, 8:57 AM · Restricted Project, Restricted Project

Nov 30 2021

jamesfarrell added a comment to D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible..

FYI I reverted this due to test failures -- one specific assertion failure is mentioned in https://reviews.llvm.org/rG40d5eeac6cd8.

Nov 30 2021, 9:57 AM · Restricted Project, Restricted Project
jamesfarrell committed rG1e8286467036: Use VersionTuple for parsing versions in Triple. This makes it possible to… (authored by jamesfarrell).
Use VersionTuple for parsing versions in Triple. This makes it possible to…
Nov 30 2021, 7:45 AM
jamesfarrell closed D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible..
Nov 30 2021, 7:44 AM · Restricted Project, Restricted Project
jamesfarrell added a comment to D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible..

Sorry for delay, this LGTM. Thanks for doing this cleanup!

Nov 30 2021, 7:14 AM · Restricted Project, Restricted Project

Nov 20 2021

jamesfarrell added inline comments to D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible..
Nov 20 2021, 7:33 AM · Restricted Project, Restricted Project
jamesfarrell added a comment to D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible..

Nice, that's a lot of code cleaned up! LGTM, but probably should wait for someone from Apple to weigh in. I think the new formatting for those error messages is better for them too but that's not my call :)

Nov 20 2021, 7:30 AM · Restricted Project, Restricted Project

Nov 18 2021

jamesfarrell added a reviewer for D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.: t.p.northover.
Nov 18 2021, 10:19 AM · Restricted Project, Restricted Project
jamesfarrell updated the diff for D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible..

Remove an include that's no longer needed.

Nov 18 2021, 7:32 AM · Restricted Project, Restricted Project
jamesfarrell updated the diff for D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible..

Cleanup Triple::getMacOSXVersion.

Nov 18 2021, 7:29 AM · Restricted Project, Restricted Project
jamesfarrell retitled D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible. from Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible. See also https://github.com/android/ndk/issues/1455. to Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.See also https://github.com/android/ndk/issues/1455..
Nov 18 2021, 6:55 AM · Restricted Project, Restricted Project
jamesfarrell requested review of D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible..
Nov 18 2021, 6:54 AM · Restricted Project, Restricted Project

Nov 17 2021

jamesfarrell committed rGa340a491b255: Add Android test case for -Wpartial-availability. Also update Android… (authored by jamesfarrell).
Add Android test case for -Wpartial-availability. Also update Android…
Nov 17 2021, 2:53 PM
jamesfarrell closed D114036: Add Android test case for -Wpartial-availability. Also update Android availability tests to match on the whole string, so we can distinguish between "Android 16" and "Android 16.0.0" at the end of warning messages..
Nov 17 2021, 2:53 PM · Restricted Project

Nov 16 2021

jamesfarrell added reviewers for D114036: Add Android test case for -Wpartial-availability. Also update Android availability tests to match on the whole string, so we can distinguish between "Android 16" and "Android 16.0.0" at the end of warning messages.: danalbert, ZijunZhao.
Nov 16 2021, 2:47 PM · Restricted Project
jamesfarrell requested review of D114036: Add Android test case for -Wpartial-availability. Also update Android availability tests to match on the whole string, so we can distinguish between "Android 16" and "Android 16.0.0" at the end of warning messages..
Nov 16 2021, 2:46 PM · Restricted Project
jamesfarrell abandoned D114031: Full matching for version numbers..
Nov 16 2021, 1:56 PM · Restricted Project
jamesfarrell requested review of D114031: Full matching for version numbers..
Nov 16 2021, 1:50 PM · Restricted Project