Page MenuHomePhabricator

danalbert (Dan Albert)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 19 2014, 10:59 AM (327 w, 3 d)

Recent Activity

Wed, Sep 23

danalbert requested review of D88189: [libc++abi] Add an option to avoid demangling in terminate..
Wed, Sep 23, 4:08 PM · Restricted Project

Aug 20 2020

danalbert accepted D86321: Fix test for D77924..
Aug 20 2020, 4:04 PM · Restricted Project

Jun 17 2020

danalbert accepted D81622: [Clang] Search computed sysroot for libc++ header paths.

While this doesn't look wrong to me -- and the correctness of this depends entirely on where vendors decide to put their headers so it's hard for me to verify -- I'm wondering why not all toolchains use this mechanism. We seem to be adding an abstraction that's used only by some toolchains, but not all. I think it would be great to have a single canonical way of representing the system root.

Jun 17 2020, 3:40 PM · Restricted Project

Jun 1 2020

danalbert accepted D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer.
Jun 1 2020, 3:11 PM · Restricted Project, Restricted Project

May 21 2020

danalbert added a comment to D56456: [Driver] Default to -fno-addrsig on Android..

The NDK still supports linkers other than LLD, but we are changing the default to LLD in the next release. I'd prefer to keep this for the time being, but don't feel strongly about it.

May 21 2020, 12:59 PM

Apr 29 2020

danalbert committed rG2e090e4884d0: Reset another globalMemCounter. (authored by danalbert).
Reset another globalMemCounter.
Apr 29 2020, 5:51 PM
danalbert committed rG0a78e42b1f9d: Revert "[lld] Remove special cases from default ld driver mode." (authored by danalbert).
Revert "[lld] Remove special cases from default ld driver mode."
Apr 29 2020, 2:34 PM
danalbert added a reverting change for rGda093c388fc9: [lld] Remove special cases from default ld driver mode.: rG0a78e42b1f9d: Revert "[lld] Remove special cases from default ld driver mode.".
Apr 29 2020, 2:34 PM
danalbert committed rGda093c388fc9: [lld] Remove special cases from default ld driver mode. (authored by danalbert).
[lld] Remove special cases from default ld driver mode.
Apr 29 2020, 12:56 PM
danalbert closed D78837: [lld] Remove special cases from default ld driver mode..
Apr 29 2020, 12:55 PM · Restricted Project, lld

Apr 24 2020

danalbert added a comment to D76452: Use LLD by default for Android..

Yes, I was referring to that question too :) I'm working on the new lld-macho implementation, under the DarwinNew flavor. I'm not sure if anything depends on the old Darwin flavor, which is why we haven't removed it yet, though we plan to do that once we get the new implementation to a more mature stage.

Ah, gotcha :) Thanks! Will wait for @ruiu to chime in.

I vote for deleting the #ifdef __APPLE__ chunk so we don't have to add more code to either clang or lld....
The code owner of the existing lld darwin has explicitly expressed that we can drop the existing Darwin flavor at any time.

SGTM. Abandoning this. I'll send a patch to remove the LLD side shortly.

Apr 24 2020, 4:48 PM · Restricted Project
danalbert created D78837: [lld] Remove special cases from default ld driver mode..
Apr 24 2020, 4:48 PM · Restricted Project, lld
danalbert abandoned D76452: Use LLD by default for Android..

Yes, I was referring to that question too :) I'm working on the new lld-macho implementation, under the DarwinNew flavor. I'm not sure if anything depends on the old Darwin flavor, which is why we haven't removed it yet, though we plan to do that once we get the new implementation to a more mature stage.

Ah, gotcha :) Thanks! Will wait for @ruiu to chime in.

I vote for deleting the #ifdef __APPLE__ chunk so we don't have to add more code to either clang or lld....
The code owner of the existing lld darwin has explicitly expressed that we can drop the existing Darwin flavor at any time.

Apr 24 2020, 4:18 PM · Restricted Project
danalbert added a comment to D76452: Use LLD by default for Android..

Yes, I was referring to that question too :) I'm working on the new lld-macho implementation, under the DarwinNew flavor. I'm not sure if anything depends on the old Darwin flavor, which is why we haven't removed it yet, though we plan to do that once we get the new implementation to a more mature stage.

Apr 24 2020, 3:44 PM · Restricted Project
danalbert added a comment to D76452: Use LLD by default for Android..

I don't think I have enough context here to answer the question, but I'm pretty sure that change wouldn't affect what I'm working on

Apr 24 2020, 2:39 PM · Restricted Project
danalbert added a comment to D76452: Use LLD by default for Android..

Can we use -DCLANG_DEFAULT_LINKER=lld to configure AOSP's distribution of LLD, then require the use of -fuse-ld=<whatever the host linker is on OSX that is currently used> when targeting OSX host tools?

Apr 24 2020, 12:26 PM · Restricted Project

Apr 23 2020

danalbert updated subscribers of D78787: [libcxx][libcxxabi][libunwind] Use libgcc on Android.

@srhines to confirm that this won't break our toolchain build, and @rprichard because he's the one looking more closely at libunwind these days.

Apr 23 2020, 11:57 PM · Restricted Project, Restricted Project, Restricted Project

Apr 16 2020

danalbert added inline comments to D78328: [lld] Infer the driver mode from the target..
Apr 16 2020, 3:04 PM · Restricted Project, lld
danalbert added a comment to D76452: Use LLD by default for Android..

Option 4 was (at least on the surface) super easy: https://reviews.llvm.org/D78328. lmk if you'd prefer that approach. I'm slightly less confident in it since it affects non-Android platforms as well.

Apr 16 2020, 2:31 PM · Restricted Project
danalbert created D78328: [lld] Infer the driver mode from the target..
Apr 16 2020, 2:31 PM · Restricted Project, lld
danalbert committed rG75c440865375: Reland: Don't expose unavailable cstdio functions. (authored by danalbert).
Reland: Don't expose unavailable cstdio functions.
Apr 16 2020, 1:26 PM
danalbert added a comment to D76452: Use LLD by default for Android..

@MaskRay Any other ideas, or should I submit this? Reviewing all our options:

Apr 16 2020, 1:23 PM · Restricted Project

Apr 7 2020

danalbert committed rG0b43db5202ee: Reset more globalMemCounters. (authored by danalbert).
Reset more globalMemCounters.
Apr 7 2020, 4:56 PM
danalbert closed D77681: Reset more globalMemCounters..
Apr 7 2020, 4:55 PM · Restricted Project
danalbert committed rG50280c18958b: Revert "Don't expose unavailable cstdio functions." (authored by danalbert).
Revert "Don't expose unavailable cstdio functions."
Apr 7 2020, 3:50 PM
danalbert added a reverting change for rGff87813715ec: Don't expose unavailable cstdio functions.: rG50280c18958b: Revert "Don't expose unavailable cstdio functions.".
Apr 7 2020, 3:50 PM
danalbert committed rGff87813715ec: Don't expose unavailable cstdio functions. (authored by danalbert).
Don't expose unavailable cstdio functions.
Apr 7 2020, 3:17 PM
danalbert closed D76093: Don't expose unavailable cstdio functions..
Apr 7 2020, 3:17 PM · Restricted Project
danalbert created D77681: Reset more globalMemCounters..
Apr 7 2020, 3:16 PM · Restricted Project
danalbert updated the diff for D76093: Don't expose unavailable cstdio functions..

Added missing copyright header and moved into the libcxx specific test directory.

Apr 7 2020, 2:42 PM · Restricted Project

Apr 6 2020

danalbert committed rGcbf1904a3e05: Upstream Bionic definitions of ctype_base/regex. (authored by danalbert).
Upstream Bionic definitions of ctype_base/regex.
Apr 6 2020, 1:40 PM
danalbert closed D76171: Upstream Bionic definitions of ctype_base/regex..
Apr 6 2020, 1:39 PM · Restricted Project
danalbert added inline comments to D76171: Upstream Bionic definitions of ctype_base/regex..
Apr 6 2020, 1:37 PM · Restricted Project

Mar 30 2020

danalbert added a comment to D76452: Use LLD by default for Android..

To cross build ELF object on macOS, another alternative is a wrapper named ld which invokes lld -flavor gnu "$@"

@danalbert Would this kind of idea work with your other reverted patch? I'm not sure exactly what broke on those builds.

Mar 30 2020, 11:56 AM · Restricted Project

Mar 26 2020

danalbert reclaimed D76452: Use LLD by default for Android..

It seems I'd goofed something in my testing earlier (I think I still had -fuse-ld=lld force on in my build system). While Clang will find ld in the driver directory and prefer it, LLD defaults to the Darwin driver mode when argv[0] is ld when run on Darwin. We need GNU mode, and the best way to get this behavior is to have Clang invoke ld.lld instead.

Mar 26 2020, 12:29 PM · Restricted Project

Mar 20 2020

danalbert abandoned D76452: Use LLD by default for Android..

Looks like we don't actually need this. Can achieve the same effect by installing ld.lld to the same directory as Clang as ld and it'll be preferred over the other locations.

Mar 20 2020, 4:18 PM · Restricted Project

Mar 19 2020

danalbert added a comment to D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.

Thanks for fixing this 👍

Mar 19 2020, 5:00 PM · Restricted Project
danalbert updated the diff for D76452: Use LLD by default for Android..
Mar 19 2020, 4:27 PM · Restricted Project
danalbert created D76452: Use LLD by default for Android..
Mar 19 2020, 1:42 PM · Restricted Project

Mar 17 2020

danalbert added a comment to D76093: Don't expose unavailable cstdio functions..

Ping.

Mar 17 2020, 12:23 PM · Restricted Project

Mar 13 2020

danalbert created D76171: Upstream Bionic definitions of ctype_base/regex..
Mar 13 2020, 6:22 PM · Restricted Project
danalbert updated the diff for D76093: Don't expose unavailable cstdio functions..
Mar 13 2020, 6:22 PM · Restricted Project
danalbert updated the diff for D76093: Don't expose unavailable cstdio functions..

(remove some trailing whitespace that snuck in)

Mar 13 2020, 6:22 PM · Restricted Project
danalbert updated the diff for D76093: Don't expose unavailable cstdio functions..

Add .fail test, merge into single macro.

Mar 13 2020, 5:49 PM · Restricted Project
danalbert closed D76091: Move more tests to globalMemCounter and reset..
Mar 13 2020, 5:49 PM · Restricted Project
danalbert committed rG9c5d0ea6784b: Revert "Revert "Move more tests to globalMemCounter and reset."" (authored by danalbert).
Revert "Revert "Move more tests to globalMemCounter and reset.""
Mar 13 2020, 5:18 PM
danalbert added inline comments to D76091: Move more tests to globalMemCounter and reset..
Mar 13 2020, 5:17 PM · Restricted Project
danalbert committed rG05749acfd36d: Revert "Move more tests to globalMemCounter and reset." (authored by danalbert).
Revert "Move more tests to globalMemCounter and reset."
Mar 13 2020, 1:30 PM
danalbert added a reverting change for rG4a792965de08: Move more tests to globalMemCounter and reset.: rG05749acfd36d: Revert "Move more tests to globalMemCounter and reset.".
Mar 13 2020, 1:30 PM
danalbert added a comment to D76091: Move more tests to globalMemCounter and reset..

Some of the changes in this patch are not correct. Please revert them in a follow up commit.

Mar 13 2020, 1:29 PM · Restricted Project
danalbert committed rG14d2d8c9761b: Allow site-specific test_exec_root. (authored by danalbert).
Allow site-specific test_exec_root.
Mar 13 2020, 12:25 PM
danalbert closed D76092: Allow site-specific test_exec_root..
Mar 13 2020, 12:24 PM · Restricted Project
danalbert committed rGadefcc8ab5be: Revert "Revert "Update system_error tests for more platforms."" (authored by danalbert).
Revert "Revert "Update system_error tests for more platforms.""
Mar 13 2020, 12:24 PM
danalbert added a reverting change for rGd4a8c3f2511f: Revert "Update system_error tests for more platforms.": rGadefcc8ab5be: Revert "Revert "Update system_error tests for more platforms."".
Mar 13 2020, 12:24 PM
danalbert updated the diff for D76093: Don't expose unavailable cstdio functions..

Yep, good point. I think we don't run the full libc++ test suite for the broken configuration. Fixed.

Mar 13 2020, 12:23 PM · Restricted Project

Mar 12 2020

danalbert committed rGd4a8c3f2511f: Revert "Update system_error tests for more platforms." (authored by danalbert).
Revert "Update system_error tests for more platforms."
Mar 12 2020, 6:21 PM
danalbert added a reverting change for rGa9740ff1585a: Update system_error tests for more platforms.: rGd4a8c3f2511f: Revert "Update system_error tests for more platforms.".
Mar 12 2020, 6:21 PM
danalbert committed rGa9740ff1585a: Update system_error tests for more platforms. (authored by danalbert).
Update system_error tests for more platforms.
Mar 12 2020, 5:43 PM
danalbert closed D35732: Update system_error tests for more platforms..
Mar 12 2020, 5:43 PM · Restricted Project
danalbert committed rG4a792965de08: Move more tests to globalMemCounter and reset. (authored by danalbert).
Move more tests to globalMemCounter and reset.
Mar 12 2020, 5:43 PM
danalbert closed D76091: Move more tests to globalMemCounter and reset..
Mar 12 2020, 5:43 PM · Restricted Project
danalbert added inline comments to D76092: Allow site-specific test_exec_root..
Mar 12 2020, 5:42 PM · Restricted Project
danalbert updated the diff for D76093: Don't expose unavailable cstdio functions..
Mar 12 2020, 5:23 PM · Restricted Project
danalbert added inline comments to D76093: Don't expose unavailable cstdio functions..
Mar 12 2020, 5:23 PM · Restricted Project
danalbert created D76093: Don't expose unavailable cstdio functions..
Mar 12 2020, 12:28 PM · Restricted Project
danalbert created D76091: Move more tests to globalMemCounter and reset..
Mar 12 2020, 12:28 PM · Restricted Project
danalbert created D76092: Allow site-specific test_exec_root..
Mar 12 2020, 12:28 PM · Restricted Project
danalbert updated the diff for D35732: Update system_error tests for more platforms..

PTAL

Mar 12 2020, 11:23 AM · Restricted Project
danalbert updated the summary of D35732: Update system_error tests for more platforms..
Mar 12 2020, 11:23 AM · Restricted Project

Jan 28 2020

danalbert accepted D73516: [libcxx] Link against android_support when needed.
Jan 28 2020, 12:58 PM · Restricted Project
danalbert added inline comments to D73516: [libcxx] Link against android_support when needed.
Jan 28 2020, 10:21 AM · Restricted Project
danalbert added a comment to D73516: [libcxx] Link against android_support when needed.

We don't build the NDK's libc++ with CMake. What's the motivation for this?

Jan 28 2020, 9:40 AM · Restricted Project

Jan 6 2020

danalbert accepted D71848: Allow the discovery of Android NDK's triple-prefixed binaries..

Just to clarify, this is needed for the triple-prefixed tools, but the triple-specific directory worked fine before this patch? If I'm understanding that correctly then LGTM, otherwise I'm confused as to why I haven't seen this problem before.

Jan 6 2020, 9:47 AM · Restricted Project

Dec 6 2019

danalbert accepted D71154: Driver: Don't look for libc++ headers in the install directory on Android..
Dec 6 2019, 5:11 PM · Restricted Project
danalbert requested changes to D71154: Driver: Don't look for libc++ headers in the install directory on Android..
Dec 6 2019, 4:53 PM · Restricted Project

Nov 18 2019

danalbert committed rG19fd9039ca24: Fix _LIBCPP_HAS_ definitions for Android. (authored by danalbert).
Fix _LIBCPP_HAS_ definitions for Android.
Nov 18 2019, 12:30 PM
danalbert closed D69929: Fix _LIBCPP_HAS_ definitions for Android..

https://github.com/llvm/llvm-project/commit/19fd9039ca242f408493b5c662f9d908eab8555e

Nov 18 2019, 12:30 PM · Restricted Project
danalbert committed rG626260cfe3c7: Update the docs for building libc++. (authored by danalbert).
Update the docs for building libc++.
Nov 18 2019, 12:21 PM
danalbert closed D69917: Update the docs for building libc++..

https://github.com/llvm/llvm-project/commit/626260cfe3c7a5d9747f0bf13d87fa1855eb74bb

Nov 18 2019, 12:21 PM · Restricted Project

Nov 6 2019

danalbert accepted D69929: Fix _LIBCPP_HAS_ definitions for Android..

LGTM

Nov 6 2019, 11:01 PM · Restricted Project
danalbert added a reviewer for D69929: Fix _LIBCPP_HAS_ definitions for Android.: EricWF.
Nov 6 2019, 11:01 PM · Restricted Project
danalbert updated the diff for D69917: Update the docs for building libc++..

Fix a couple missing bits in the instructions.

Nov 6 2019, 2:01 PM · Restricted Project
danalbert created D69917: Update the docs for building libc++..
Nov 6 2019, 12:29 PM · Restricted Project

Oct 17 2019

danalbert updated subscribers of D68968: [android/process info] Introduce display_name.

Independently, I am wondering if there's a better way to link the process id to a bundle. Using argv[0] might be ok if we're using it just for display purposes, but if we're going to be doing other stuff based on that identifier, it would be better to get it from a more reliable source. Unfortunately, I was not able to find a more "reasonable source", but maybe @danalbert has an idea.

Oct 17 2019, 12:54 PM · Restricted Project

Oct 15 2019

danalbert accepted D68972: [libunwind][Android] Fix findUnwindSections for ARM EHABI Bionic.
Oct 15 2019, 9:16 PM · Restricted Project, Restricted Project, Restricted Project

Oct 4 2019

danalbert added a comment to D68269: [libc++abi] Do not define new/delete by default.

The alternative would be to only provide new/delete inside libc++abi, not in libc++ (by default). So, vendors (@phosek @srhines @danalbert @dim @emaste), are you OK with the default becoming that libc++abi provides new/delete, and libc++ DOES NOT (by default). If you want to keep shipping new/delete as part of libc++, you'll need to specify -DLIBCXX_ENABLE_NEW_DELETE_DEFINITIONS=ON at CMake configure time.

Oct 4 2019, 1:54 PM · Restricted Project

Oct 3 2019

danalbert added a comment to D68269: [libc++abi] Do not define new/delete by default.

If the Android and FreeBSD folks are ok with this, I'm fine with it

Oct 3 2019, 12:55 PM · Restricted Project
danalbert updated subscribers of D68269: [libc++abi] Do not define new/delete by default.
Oct 3 2019, 12:55 PM · Restricted Project

Sep 26 2019

danalbert added a reviewer for D68048: [WIP][RFC] Improve fetching the process list on the android platform: emrekultursay.
Sep 26 2019, 12:28 PM · Restricted Project

Sep 18 2019

danalbert committed rG85e26f56cbf3: Revert "Revert "Implement std::condition_variable via pthread_cond_clockwait()… (authored by danalbert).
Revert "Revert "Implement std::condition_variable via pthread_cond_clockwait()…
Sep 18 2019, 11:17 AM
danalbert added a reverting change for rGc1c519d2f1a6: Revert "Implement std::condition_variable via pthread_cond_clockwait() where…: rG85e26f56cbf3: Revert "Revert "Implement std::condition_variable via pthread_cond_clockwait()….
Sep 18 2019, 11:17 AM
danalbert committed rL372242: Revert "Revert "Implement std::condition_variable via pthread_cond_clockwait()….
Revert "Revert "Implement std::condition_variable via pthread_cond_clockwait()…
Sep 18 2019, 11:16 AM

Sep 16 2019

danalbert updated subscribers of rL372016: Implement std::condition_variable via pthread_cond_clockwait() where available.

Thanks for the heads up. I've reverted the patch.

Sep 16 2019, 2:27 PM
danalbert committed rGc1c519d2f1a6: Revert "Implement std::condition_variable via pthread_cond_clockwait() where… (authored by danalbert).
Revert "Implement std::condition_variable via pthread_cond_clockwait() where…
Sep 16 2019, 2:27 PM
danalbert added a reverting change for rG5e37d7f9ff25: Implement std::condition_variable via pthread_cond_clockwait() where available: rGc1c519d2f1a6: Revert "Implement std::condition_variable via pthread_cond_clockwait() where….
Sep 16 2019, 2:26 PM
danalbert committed rL372034: Revert "Implement std::condition_variable via pthread_cond_clockwait() where….
Revert "Implement std::condition_variable via pthread_cond_clockwait() where…
Sep 16 2019, 2:19 PM
danalbert committed rGa7e9059967c4: Open fstream files in O_CLOEXEC mode when possible. (authored by danalbert).
Open fstream files in O_CLOEXEC mode when possible.
Sep 16 2019, 12:30 PM
danalbert committed rL372027: Open fstream files in O_CLOEXEC mode when possible..
Open fstream files in O_CLOEXEC mode when possible.
Sep 16 2019, 12:30 PM
danalbert closed D59839: Open fstream files in O_CLOEXEC mode when possible..
Sep 16 2019, 12:30 PM · Restricted Project, Restricted Project
danalbert closed D65339: Implement std::condition_variable via pthread_cond_clockwait() where available.

Closed by https://reviews.llvm.org/rL372016

Sep 16 2019, 11:07 AM