Page MenuHomePhabricator

danalbert (Dan Albert)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 19 2014, 10:59 AM (261 w, 4 d)

Recent Activity

May 6 2019

danalbert added a comment to D59839: Open fstream files in O_CLOEXEC mode when possible..

@EricWF ping

May 6 2019, 11:16 AM · Restricted Project

May 1 2019

danalbert committed rGdfa7af5b6b15: Add missing locale requirement to test. (authored by danalbert).
Add missing locale requirement to test.
May 1 2019, 2:02 PM
danalbert committed rL359726: Add missing locale requirement to test..
Add missing locale requirement to test.
May 1 2019, 2:02 PM
danalbert committed rCXX359726: Add missing locale requirement to test..
Add missing locale requirement to test.
May 1 2019, 2:02 PM

Apr 16 2019

danalbert added a comment to D59839: Open fstream files in O_CLOEXEC mode when possible..

@EricWF Any concerns, or can I merge this?

Apr 16 2019, 1:41 PM · Restricted Project

Apr 2 2019

danalbert added inline comments to D59839: Open fstream files in O_CLOEXEC mode when possible..
Apr 2 2019, 12:43 PM · Restricted Project
danalbert updated the diff for D59839: Open fstream files in O_CLOEXEC mode when possible..

Only opt-in for bionic

Apr 2 2019, 12:43 PM · Restricted Project

Apr 1 2019

danalbert added a comment to D59839: Open fstream files in O_CLOEXEC mode when possible..

I'm not really sure who speaks for glibc platforms. @EricWF? Like I said, if we're not comfortable making this change for glibc I don't have a problem backing that out, but I do think this is a more useful default behavior. It's fairly convoluted to pass a file descriptor from an fstream across an exec boundary intentionally so I somewhat doubt anyone is doing so intentionally. Anyone doing so unintentionally is just leaking an fd and any use of it on the other side of the exec is probably a bug.

Apr 1 2019, 1:46 PM · Restricted Project
danalbert updated the diff for D59839: Open fstream files in O_CLOEXEC mode when possible..

Add a comment explaining _LIBCPP_FOPEN_CLOEXEC_MODE.

Apr 1 2019, 1:27 PM · Restricted Project
danalbert added a comment to D59839: Open fstream files in O_CLOEXEC mode when possible..

Ping?

Apr 1 2019, 11:19 AM · Restricted Project

Mar 29 2019

danalbert added a comment to D60005: [libc++abi] Don't set POSITION_INDEPENDENT_CODE when building static library.

Android maintains its own build scripts, so this won't harm us, but I think the problem in general remains. Seems like it would be better for the webasm target to opt out of the behavior than for all targets to do it (or maybe just provide an option so maintainers can choose what they want for their platform).

Mar 29 2019, 4:33 PM · Restricted Project, Restricted Project
danalbert committed rG50e18a250fbe: [Driver] Use --warn-shared-textrel for Android. (authored by danalbert).
[Driver] Use --warn-shared-textrel for Android.
Mar 29 2019, 11:33 AM
danalbert committed rL357296: [Driver] Use --warn-shared-textrel for Android..
[Driver] Use --warn-shared-textrel for Android.
Mar 29 2019, 11:33 AM
danalbert committed rC357296: [Driver] Use --warn-shared-textrel for Android..
[Driver] Use --warn-shared-textrel for Android.
Mar 29 2019, 11:33 AM
danalbert closed D53344: [Driver] Use --warn-shared-textrel for Android..
Mar 29 2019, 11:33 AM · Restricted Project
danalbert added a reviewer for D53344: [Driver] Use --warn-shared-textrel for Android.: pirama.
Mar 29 2019, 10:35 AM · Restricted Project

Mar 28 2019

danalbert committed rG2715b2871653: [Driver] Default Android toolchains to noexecstack. (authored by danalbert).
[Driver] Default Android toolchains to noexecstack.
Mar 28 2019, 11:11 AM
danalbert committed rL357197: [Driver] Default Android toolchains to noexecstack..
[Driver] Default Android toolchains to noexecstack.
Mar 28 2019, 11:11 AM
danalbert committed rC357197: [Driver] Default Android toolchains to noexecstack..
[Driver] Default Android toolchains to noexecstack.
Mar 28 2019, 11:11 AM
danalbert closed D53343: [Driver] Default Android toolchains to noexecstack..
Mar 28 2019, 11:11 AM · Restricted Project

Mar 27 2019

danalbert added a comment to D59839: Open fstream files in O_CLOEXEC mode when possible..

I'm mostly worried about the change in behavior breaking existing programs.

Mar 27 2019, 1:14 PM · Restricted Project

Mar 26 2019

danalbert added a comment to D59839: Open fstream files in O_CLOEXEC mode when possible..

How did you decide which modes fell into "when possible"?

Mar 26 2019, 2:56 PM · Restricted Project
danalbert created D59839: Open fstream files in O_CLOEXEC mode when possible..
Mar 26 2019, 1:12 PM · Restricted Project

Feb 21 2019

danalbert committed rG475042d5b1be: [Driver] Fix float ABI default for Android ARMv8. (authored by danalbert).
[Driver] Fix float ABI default for Android ARMv8.
Feb 21 2019, 1:13 PM
danalbert committed rC354622: [Driver] Fix float ABI default for Android ARMv8..
[Driver] Fix float ABI default for Android ARMv8.
Feb 21 2019, 1:13 PM
danalbert committed rL354622: [Driver] Fix float ABI default for Android ARMv8..
[Driver] Fix float ABI default for Android ARMv8.
Feb 21 2019, 1:13 PM
danalbert closed D58477: [Driver] Fix float ABI default for Android ARMv8..
Feb 21 2019, 1:13 PM · Restricted Project, Restricted Project
danalbert added inline comments to D58314: [Driver] Sync ARM behavior between clang-as and gas..
Feb 21 2019, 12:53 PM · Restricted Project

Feb 20 2019

danalbert created D58477: [Driver] Fix float ABI default for Android ARMv8..
Feb 20 2019, 2:14 PM · Restricted Project, Restricted Project
danalbert added inline comments to D58314: [Driver] Sync ARM behavior between clang-as and gas..
Feb 20 2019, 1:56 PM · Restricted Project
danalbert updated the diff for D58314: [Driver] Sync ARM behavior between clang-as and gas..

Updated to address some review comments:

Feb 20 2019, 1:56 PM · Restricted Project

Feb 15 2019

danalbert created D58314: [Driver] Sync ARM behavior between clang-as and gas..
Feb 15 2019, 5:00 PM · Restricted Project
danalbert committed rGdf89c6ffa373: [Driver] Default all Android ARM targets to NEON. (authored by danalbert).
[Driver] Default all Android ARM targets to NEON.
Feb 15 2019, 12:32 PM
danalbert committed rC354166: [Driver] Default all Android ARM targets to NEON..
[Driver] Default all Android ARM targets to NEON.
Feb 15 2019, 12:31 PM
danalbert committed rL354166: [Driver] Default all Android ARM targets to NEON..
[Driver] Default all Android ARM targets to NEON.
Feb 15 2019, 12:31 PM
danalbert closed D58153: [Driver] Default all Android ARM targets to NEON..
Feb 15 2019, 12:31 PM · Restricted Project, Restricted Project

Feb 13 2019

danalbert added a comment to D58153: [Driver] Default all Android ARM targets to NEON..

The official documentation still says "Your app must perform runtime detection to confirm that NEON-capable machine code can be run on the target device" (https://developer.android.com/ndk/guides/cpu-arm-neon#runtime_detection). Is that wrong?

Feb 13 2019, 12:31 PM · Restricted Project, Restricted Project

Feb 12 2019

danalbert created D58153: [Driver] Default all Android ARM targets to NEON..
Feb 12 2019, 3:25 PM · Restricted Project, Restricted Project

Jan 15 2019

danalbert added inline comments to D38430: Enable -pie and --enable-new-dtags by default on Android..
Jan 15 2019, 4:07 PM
danalbert committed rCXX351226: Fix size_t/off_t mixup in std::filesystem..
Fix size_t/off_t mixup in std::filesystem.
Jan 15 2019, 11:20 AM
danalbert committed rL351226: Fix size_t/off_t mixup in std::filesystem..
Fix size_t/off_t mixup in std::filesystem.
Jan 15 2019, 11:20 AM
danalbert closed D56578: Fix size_t/off_t mixup in std::filesystem..
Jan 15 2019, 11:20 AM
danalbert committed rCXX351225: Add large file support to create_file for 32-bit..
Add large file support to create_file for 32-bit.
Jan 15 2019, 11:18 AM
danalbert committed rL351225: Add large file support to create_file for 32-bit..
Add large file support to create_file for 32-bit.
Jan 15 2019, 11:18 AM
danalbert closed D56619: Add large file support to create_file for 32-bit..
Jan 15 2019, 11:18 AM

Jan 11 2019

danalbert created D56619: Add large file support to create_file for 32-bit..
Jan 11 2019, 2:03 PM
danalbert updated the diff for D56578: Fix size_t/off_t mixup in std::filesystem..

Added reference to spec in comment.

Jan 11 2019, 10:25 AM

Jan 10 2019

danalbert created D56578: Fix size_t/off_t mixup in std::filesystem..
Jan 10 2019, 9:40 PM

Jan 8 2019

danalbert committed rC350668: [Driver] Default to -fno-addrsig on Android..
[Driver] Default to -fno-addrsig on Android.
Jan 8 2019, 2:38 PM
danalbert committed rL350668: [Driver] Default to -fno-addrsig on Android..
[Driver] Default to -fno-addrsig on Android.
Jan 8 2019, 2:37 PM
danalbert closed D56456: [Driver] Default to -fno-addrsig on Android..
Jan 8 2019, 2:37 PM
danalbert committed rL350664: Android is not GNU, so don't claim that it is..
Android is not GNU, so don't claim that it is.
Jan 8 2019, 2:35 PM
danalbert committed rC350664: Android is not GNU, so don't claim that it is..
Android is not GNU, so don't claim that it is.
Jan 8 2019, 2:35 PM
danalbert closed D55953: Android is not GNU, so don't claim that it is..
Jan 8 2019, 2:35 PM
danalbert created D56456: [Driver] Default to -fno-addrsig on Android..
Jan 8 2019, 2:25 PM

Dec 20 2018

danalbert created D55953: Android is not GNU, so don't claim that it is..
Dec 20 2018, 1:21 PM

Dec 18 2018

danalbert committed rC349570: [Driver] Also obey -nostdlib++ when rewriting -lstdc++..
[Driver] Also obey -nostdlib++ when rewriting -lstdc++.
Dec 18 2018, 3:33 PM
danalbert committed rL349570: [Driver] Also obey -nostdlib++ when rewriting -lstdc++..
[Driver] Also obey -nostdlib++ when rewriting -lstdc++.
Dec 18 2018, 3:33 PM
danalbert closed D55856: [Driver] Also obey -nostdlib++ when rewriting -lstdc++..
Dec 18 2018, 3:32 PM
danalbert updated the diff for D55856: [Driver] Also obey -nostdlib++ when rewriting -lstdc++..
Dec 18 2018, 3:32 PM
danalbert created D55856: [Driver] Also obey -nostdlib++ when rewriting -lstdc++..
Dec 18 2018, 3:02 PM

Nov 5 2018

danalbert committed rC346167: [Driver] Reland again again: Default Android toolchains to libc++..
[Driver] Reland again again: Default Android toolchains to libc++.
Nov 5 2018, 1:01 PM
danalbert committed rL346167: [Driver] Reland again again: Default Android toolchains to libc++..
[Driver] Reland again again: Default Android toolchains to libc++.
Nov 5 2018, 1:01 PM

Nov 2 2018

danalbert closed D53711: [compiler-rt] Workaround using new Clang with an old NDK..

r346051

Nov 2 2018, 4:01 PM
danalbert committed rL346051: Workaround using new Clang with an old NDK..
Workaround using new Clang with an old NDK.
Nov 2 2018, 4:00 PM
danalbert committed rCRT346051: Workaround using new Clang with an old NDK..
Workaround using new Clang with an old NDK.
Nov 2 2018, 4:00 PM
danalbert added a comment to D53711: [compiler-rt] Workaround using new Clang with an old NDK..

Thanks, hadn't found that file. Much cleaner.

Nov 2 2018, 2:51 PM
danalbert updated the diff for D53711: [compiler-rt] Workaround using new Clang with an old NDK..
Nov 2 2018, 2:50 PM

Nov 1 2018

danalbert committed rL345900: Fix test assumption that Linux implies glibc..
Fix test assumption that Linux implies glibc.
Nov 1 2018, 3:38 PM
danalbert committed rCXX345900: Fix test assumption that Linux implies glibc..
Fix test assumption that Linux implies glibc.
Nov 1 2018, 3:38 PM
danalbert closed D53956: Fix test assumption that Linux implies glibc..
Nov 1 2018, 3:38 PM

Oct 31 2018

danalbert created D53956: Fix test assumption that Linux implies glibc..
Oct 31 2018, 3:52 PM

Oct 25 2018

danalbert created D53711: [compiler-rt] Workaround using new Clang with an old NDK..
Oct 25 2018, 9:35 AM

Oct 22 2018

danalbert committed rL344963: Revert "[Driver] Reland again: Default Android toolchains to libc++.".
Revert "[Driver] Reland again: Default Android toolchains to libc++."
Oct 22 2018, 3:01 PM
danalbert committed rC344963: Revert "[Driver] Reland again: Default Android toolchains to libc++.".
Revert "[Driver] Reland again: Default Android toolchains to libc++."
Oct 22 2018, 3:01 PM
danalbert committed rC344946: [Driver] Reland again: Default Android toolchains to libc++..
[Driver] Reland again: Default Android toolchains to libc++.
Oct 22 2018, 1:18 PM
danalbert committed rL344946: [Driver] Reland again: Default Android toolchains to libc++..
[Driver] Reland again: Default Android toolchains to libc++.
Oct 22 2018, 1:18 PM
danalbert accepted D53463: [Driver] allow Android triples to alias for non Android targets.

LGTM

Oct 22 2018, 12:28 PM

Oct 19 2018

danalbert committed rL344806: Revert "[Driver] Reland: Default Android toolchains to libc++.".
Revert "[Driver] Reland: Default Android toolchains to libc++."
Oct 19 2018, 12:25 PM
danalbert committed rC344806: Revert "[Driver] Reland: Default Android toolchains to libc++.".
Revert "[Driver] Reland: Default Android toolchains to libc++."
Oct 19 2018, 12:25 PM
danalbert committed rC344795: [Driver] Reland: Default Android toolchains to libc++..
[Driver] Reland: Default Android toolchains to libc++.
Oct 19 2018, 11:08 AM
danalbert committed rL344795: [Driver] Reland: Default Android toolchains to libc++..
[Driver] Reland: Default Android toolchains to libc++.
Oct 19 2018, 11:08 AM

Oct 18 2018

danalbert committed rL344753: [Zorg] Reland "Fix Android sanitizer flags.".
[Zorg] Reland "Fix Android sanitizer flags."
Oct 18 2018, 12:36 PM
danalbert committed rCRT344751: [compiler-rt] Don't explicitly set CMAKE_CXX_FLAGS..
[compiler-rt] Don't explicitly set CMAKE_CXX_FLAGS.
Oct 18 2018, 11:08 AM
danalbert committed rL344751: [compiler-rt] Don't explicitly set CMAKE_CXX_FLAGS..
[compiler-rt] Don't explicitly set CMAKE_CXX_FLAGS.
Oct 18 2018, 11:06 AM
danalbert closed D53335: [compiler-rt] Don't explicitly set CMAKE_CXX_FLAGS..
Oct 18 2018, 11:06 AM

Oct 16 2018

danalbert created D53344: [Driver] Use --warn-shared-textrel for Android..
Oct 16 2018, 3:32 PM · Restricted Project
danalbert created D53343: [Driver] Default Android toolchains to noexecstack..
Oct 16 2018, 3:19 PM · Restricted Project
danalbert created D53335: [compiler-rt] Don't explicitly set CMAKE_CXX_FLAGS..
Oct 16 2018, 12:09 PM
danalbert committed rL344640: [Zorg] Use CMAKE_ASM_FLAGS with compiler-rt..
[Zorg] Use CMAKE_ASM_FLAGS with compiler-rt.
Oct 16 2018, 12:08 PM
danalbert closed D53301: [Zorg] Use CMAKE_ASM_FLAGS with compiler-rt..
Oct 16 2018, 12:08 PM · Restricted Project

Oct 15 2018

danalbert updated the diff for D53301: [Zorg] Use CMAKE_ASM_FLAGS with compiler-rt..

Accidentally uploaded the patch with an underlying revert that included step 2. Pulled that out.

Oct 15 2018, 4:09 PM · Restricted Project
danalbert created D53301: [Zorg] Use CMAKE_ASM_FLAGS with compiler-rt..
Oct 15 2018, 2:59 PM · Restricted Project

Oct 12 2018

danalbert committed rL344420: Revert "[Zorg] Explicitly use `-stdlib=libstdc++` for Android.".
Revert "[Zorg] Explicitly use `-stdlib=libstdc++` for Android."
Oct 12 2018, 2:40 PM
danalbert committed rL344419: Revert "[Zorg] Fix Android sanitizer flags.".
Revert "[Zorg] Fix Android sanitizer flags."
Oct 12 2018, 2:40 PM
danalbert committed rL344380: [Zorg] Fix Android sanitizer flags..
[Zorg] Fix Android sanitizer flags.
Oct 12 2018, 10:42 AM
danalbert committed rL344370: [Zorg] Explicitly use `-stdlib=libstdc++` for Android..
[Zorg] Explicitly use `-stdlib=libstdc++` for Android.
Oct 12 2018, 10:15 AM
danalbert closed D53182: [Zorg] Explicitly use `-stdlib=libstdc++` for Android..
Oct 12 2018, 10:15 AM · Restricted Project
danalbert committed rL344367: [Driver] Add defaults for Android ARM FPUs..
[Driver] Add defaults for Android ARM FPUs.
Oct 12 2018, 10:08 AM
danalbert committed rC344367: [Driver] Add defaults for Android ARM FPUs..
[Driver] Add defaults for Android ARM FPUs.
Oct 12 2018, 10:08 AM