♟ danalbert

Add missing locale requirement to test.

@EricWF Any concerns, or can I merge this?

Only opt-in for bionic

I'm not really sure who speaks for glibc platforms. @EricWF? Like I said, if we're not comfortable making this change for glibc I don't have a problem backing that out, but I do think this is a more useful default behavior. It's fairly convoluted to pass a file descriptor from an fstream across an exec boundary intentionally so I somewhat doubt anyone is doing so intentionally. Anyone doing so unintentionally is just leaking an fd and any use of it on the other side of the exec is probably a bug.

Add a comment explaining _LIBCPP_FOPEN_CLOEXEC_MODE.

Android maintains its own build scripts, so this won't harm us, but I think the problem in general remains. Seems like it would be better for the webasm target to opt out of the behavior than for all targets to do it (or maybe just provide an option so maintainers can choose what they want for their platform).

[Driver] Use --warn-shared-textrel for Android.

[Driver] Default Android toolchains to noexecstack.

In D59839#1444061, @mclow.lists wrote:

I'm mostly worried about the change in behavior breaking existing programs.

In D59839#1443731, @mclow.lists wrote:

How did you decide which modes fell into "when possible"?

[Driver] Fix float ABI default for Android ARMv8.

Updated to address some review comments:

[Driver] Default all Android ARM targets to NEON.

In D58153#1395601, @efriedma wrote:

The official documentation still says "Your app must perform runtime detection to confirm that NEON-capable machine code can be run on the target device" (https://developer.android.com/ndk/guides/cpu-arm-neon#runtime_detection). Is that wrong?

Fix size_t/off_t mixup in std::filesystem.

Add large file support to create_file for 32-bit.

Added reference to spec in comment.

[Driver] Default to -fno-addrsig on Android.

Android is not GNU, so don't claim that it is.

[Driver] Also obey -nostdlib++ when rewriting -lstdc++.

[Driver] Reland again again: Default Android toolchains to libc++.

Workaround using new Clang with an old NDK.

Thanks, hadn't found that file. Much cleaner.

Fix test assumption that Linux implies glibc.

Revert "[Driver] Reland again: Default Android toolchains to libc++."

[Driver] Reland again: Default Android toolchains to libc++.

Revert "[Driver] Reland: Default Android toolchains to libc++."

[Driver] Reland: Default Android toolchains to libc++.

[Zorg] Reland "Fix Android sanitizer flags."

[compiler-rt] Don't explicitly set CMAKE_CXX_FLAGS.

[Zorg] Use CMAKE_ASM_FLAGS with compiler-rt.

Accidentally uploaded the patch with an underlying revert that included step 2. Pulled that out.

Revert "[Zorg] Explicitly use `-stdlib=libstdc++` for Android."

Revert "[Zorg] Fix Android sanitizer flags."

[Zorg] Fix Android sanitizer flags.

[Zorg] Explicitly use `-stdlib=libstdc++` for Android.

[Driver] Add defaults for Android ARM FPUs.

danalbert (Dan Albert)
User

Projects

User Details

Recent Activity
View All

May 6 2019

May 1 2019

Apr 16 2019

Apr 2 2019

Apr 1 2019

Mar 29 2019

Mar 28 2019

Mar 27 2019

Mar 26 2019

Feb 21 2019

Feb 20 2019

Feb 15 2019

Feb 13 2019

Feb 12 2019

Jan 15 2019

Jan 11 2019

Jan 10 2019

Jan 8 2019

Dec 20 2018

Dec 18 2018

Nov 5 2018

Nov 2 2018

Nov 1 2018

Oct 31 2018

Oct 25 2018

Oct 22 2018

Oct 19 2018

Oct 18 2018

Oct 16 2018

Oct 15 2018

Oct 12 2018

danalbert (Dan Albert)User