- User Since
- Jun 19 2014, 10:59 AM (484 w, 3 d)
Aug 31 2023
Jun 20 2023
I see that libcxx only supports the last two stable releases of Clang (15 and 16), but the latest NDK is r25c, which is between Clang 13 and 14. NDK r26 should be released sometime this year with a compiler newer than Clang 16.
How often are Android NDKs released? I would like to know how often we Android uses compilers we no longer officially support.
May 5 2023
Apr 17 2023
The rest of us are just echoing rprichard since he's the expert, but done :)
Apr 10 2023
+1, but I'd like @rprichard to be the one to actually sign off since he'll be the one to know if there are any caveats.
Feb 15 2023
+1, but like @eugenis says, it needs a test.
Dec 7 2022
LGTM, but note that rprichard is going to be a better POC for Android libc++ in the future :)
Dec 6 2022
Would you be able to report this as a bug to Android? Perhaps the struct can be removed when a macro is provided and they can start some sort of deprecation path?
Oct 14 2022
BIonic supports it, but the sanitizer cannot use it for Android because sanitizers are shared libraries on Android, and preinit array only works for excutables.
Oct 13 2022
What would you suggest for solving [differing exported symbols between debug and release builds]?
Okay. Unfortunately it's unrealistic that I'll ever have the time to chase every build bot, so unless someone else can volunteer to do that I don't think this default will ever improve.
Why was an LLD patch reverted as a result of GNU ld not supporting a flag?
Oct 12 2022
Oct 6 2022
Remove man doc for default behavior.
Please update lld/docs/ReleaseNotes.rst and flip lld/docs/ld.lld.1 to use --undefined-version instead.
Aug 12 2022
Apr 5 2022
Jan 19 2022
Jan 18 2022
Jan 10 2022
OS_NAME MATCHES "Darwin|Linux|FreeBSD|Android|NetBSD" AND ANDROID_PLATFORM_LEVEL GREATER 23
Dec 10 2021
LGTM once the comments are addressed. (I'd also approve the alternative approach discussed in the thread of searching each older API level directory, but have no preference one way or the other)
Dec 7 2021
Dec 3 2021
Dec 2 2021
Dec 1 2021
Nov 30 2021
Doesn't seem like we use this for Android, but @pirama just in case.
Nov 19 2021
Nice, that's a lot of code cleaned up! LGTM, but probably should wait for someone from Apple to weigh in. I think the new formatting for those error messages is better for them too but that's not my call :)
Nov 17 2021
Fine by me if this is the default for LLD.
Nov 16 2021
Nov 10 2021
Nov 8 2021
Oct 1 2021
Odd. Thanks for confirming. We'll revert while we try to figure out what it is in that builders config that is uncovering the bug. I don't think the default config uses libc++, so probably that?
Are you sure that's caused by this change? We didn't see that error.
Sep 29 2021
LGTM. @vitalybuka, do you want to have one last look, or are we clear to merge?
Sep 28 2021
Sep 27 2021
Sep 17 2021
LGTM but we should wait for @vitalybuka.
Sep 16 2021
Sep 10 2021
I think this is probably fine from the NDK perspective. Even before Clang defaulted to C++11 or newer, our build system did that when using libc++. Other build systems may not have, but unfortunately I'm not currently able to get at the data to get a concrete answer.
Sep 2 2021
Sep 1 2021
(I'd still like to hear what vitalybuka/eugenis have to say, but LGTM)
Aug 19 2021
A couple stray pieces snuck in. Could you revert those and update the change? It looks like you also missed the mailing list, but we can fix that once the patch is fixed.
Aug 17 2021
Jul 30 2021
LGTM, but @rprichard knows this area better than I do so he should probably weigh in before submitting :)
May 19 2021
Fix remaining tests for the deferred test configuration.
May 13 2021
Adds XFAIL-BUILD to deal with the deferred-run cases that fail to build.
May 12 2021
Initial pass at my suggestion of deferring XFAIL handling to the bundler. This is incomplete because we'll need to differentiate XFAIL-BUILD and XFAIL-RUN in tests (running this as-is makes any test that is XFAIL because it doesn't _build_ turn to FAIL, but things that fail to _run_ are handled correctly), but it's enough to get feedback on the idea.
May 4 2021
Re problems 1 and 2 (xfail handling), my idea what that we'd add --xfail to the bundler interface and delegate to the test runner to handle that. For Android I need to fit these tests into tradefed, so our bundler would work by creating the test config files for tradefed and would let it handle xfails. We don't have much reason to interact with LIT again after the tests are built. This more or less matches how we've been running libc++ tests for years, though with some improvements (xfail info is currently manually tracked rather than being given by LIT). I've been carrying a local patch that adds a --build-only flag which just ignores xfail annotations and defers all the execution and interpretation to our test runner.
Mar 5 2021
Feb 19 2021
It sounds like everyone is happy here but the tools. Could we get a libunwind reviewer (preferably @compnerd, since his review is the red one) to LGTM this?
Feb 10 2021
Feb 3 2021
We've since added -fuse-ld=lld to the three CMAKE_*_FLAGS so I think we're likely set on our end.
Jan 29 2021
Jan 28 2021
Jan 27 2021
Jan 26 2021
Jan 21 2021
Thanks! Has been up for a while and I haven't heard any objections. Will submit and we can revert if issues are found.
Dec 14 2020
Dec 2 2020
Nov 17 2020
Nov 6 2020
Oct 28 2020
Oct 27 2020
Oct 26 2020
Oct 12 2020
LGTM for Android.
Sep 23 2020
Aug 20 2020
Jun 17 2020
Jun 1 2020
May 21 2020
The NDK still supports linkers other than LLD, but we are changing the default to LLD in the next release. I'd prefer to keep this for the time being, but don't feel strongly about it.