Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM aside from some minor nits.
clang/include/clang/AST/Decl.h | ||
---|---|---|
1078 | You changed the definition of isLegalForFunction() to use a switch statement rather than use <= -- should this one be changed to a switch or the other one changed back to <= (or is there a reason to not be consistent)? | |
clang/lib/Serialization/ASTReaderDecl.cpp | ||
1416 | Is there a benefit to the two-layer of casts as opposed to storing the read value directly into SClass? |
You changed the definition of isLegalForFunction() to use a switch statement rather than use <= -- should this one be changed to a switch or the other one changed back to <= (or is there a reason to not be consistent)?