User Details
- User Since
- Nov 12 2012, 12:47 PM (327 w, 13 h)
Apr 25 2018
Apr 24 2018
Apr 4 2018
LGTM - can you commit?
Thank you!
Thanks Erik!
Apr 3 2018
Thanks for working on this fairly embarrassing bug (let's fix this before the week is over :)
Mar 14 2018
I discussed this briefly w Hubert - and i'm planning on modifying this patch slightly so that it flows through ParseDeclSpecifier and handles attributes and other invalid decl-specifiers such as static etc. more gracefully on a concept decl. I have this partially implemented - my hope is to get this done v soonish so feel free to ping me if you don't hear anything about this in a week or so ...
Jan 1 2018
Dec 31 2017
Dec 30 2017
Dec 29 2017
Dec 28 2017
Dec 27 2017
Dec 25 2017
Dec 24 2017
I think this looks good enough to commit - do you have commit privileges - or do you need one of us to commit it for you?
thank you!
Dec 23 2017
Dec 21 2017
Added via https://reviews.llvm.org/rC321339
Dec 20 2017
Miyuki - please take a look at the patch and let me know if you agree with the changes - or have any concerns...
Sounds good - if I don't get this done over the next seven days - would you mind just pinging me!
Dec 19 2017
Hmm - I think i might make some tweaks to this patch (to be largely symmetric with the similar handling of invalid decl-specifiers on function parameters in Sema::Actions.ActOnParamDeclarator)...
Dec 17 2017
Otherwise, I think this looks good enough to commit.
Thanks for working on this! :)
Dec 16 2017
Dec 1 2017
Nov 11 2017
Just added an additional bit-field to FunctionDecl in https://reviews.llvm.org/rL317984
Oct 25 2017
Incorporated Aaron's feedback (although not sure if I caugh tall the white space issues).
Oct 22 2017
Oct 15 2017
committed as r315840.
https://reviews.llvm.org/rL315840
Oct 14 2017
Oct 2 2017
Sep 30 2017
Sep 28 2017
Sorry about the break - But thank you for the fix :)
Sep 27 2017
Sep 17 2017
OK. It appears to be something along these lines:
Could you please update the documentation (and let me know) here (http://clang.llvm.org/hacking.html) on how to use the updated configuration to run the tests.
Aug 28 2017
Aug 27 2017
Aug 26 2017
Aug 25 2017
OK - I'll commit this on sunday if no one blocks it by then. (I'll add the fixme's).
Aug 22 2017
I don't think this approach is entirely correct for at least the following reasons:
- in the lambda case the machinery that diagnoses capture failures should be the machinery erroring on the lambda (when the parameter is odr-used)
- in the unevaluated case, once you disable the error, the instantiation machinery will fail to find the corresponding instantiated parmvardecl.
Aug 21 2017
In regards to representing this in the AST - I think (based on precedence) that the number of explicit template parameters should be stored in LambdaDefinitionData - and the interface exposed through LambdaExpr (where the source information of the template parameter list should be stored too i think - Richard you agree?).