Make the kind of cost explicit throughout the cost model which, apart from making the cost clear, will allow the generic parts to calculate better costs. It will also allow some backends to approximate and correlate the different costs if they wish. Another benefit is that it will also help simplify the cost model around immediate and intrinsic costs, where we currently have multiple APIs.
RFC thread: http://lists.llvm.org/pipermail/llvm-dev/2020-April/141263.html
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
(Nit) Could you link the RFC in the message?
llvm/include/llvm/Analysis/TargetTransformInfo.h | ||
---|---|---|
933 | Why not also default value CostKind here, too? |
Comment Actions
llvm/include/llvm/Analysis/TargetTransformInfo.h | ||
---|---|---|
933 | Just because I really wasn't sure what it should be. |
Comment Actions
Thanks - I meant in the commit message, so folks can readily reference it when they git log, for instance. Anyway, just a nit.
llvm/include/llvm/Analysis/TargetTransformInfo.h | ||
---|---|---|
933 | Looking at the uses of the API, it seems users pass TCK_RecipThroughput, which I think is the default for the other APIs. |
Why not also default value CostKind here, too?