User Details
- User Since
- May 11 2015, 7:59 AM (410 w, 8 h)
Fri, Mar 17
Okay, thanks.
Mon, Mar 6
Sorry for the delay in replying.
Tue, Feb 28
Hi @asmok-g I will be leaving it reverted, I think the case I was interested in is that just generally broken :)
Thu, Feb 23
Wed, Feb 22
The patch is certainly triggering on IR though, twice. I will look into it.
Er, I can't read X86 machine code. And I also don't consider a 4K line IR file as a reduced reproducer....
I'm preparing a reduced, verified case.
Okay, great, thanks.
Tue, Feb 21
Do those figures include using wasm-opt after linking?
Feb 15 2023
Feb 13 2023
No worries!
Feb 10 2023
Right, thanks. My next question was going to be whether you're building libc++ :) - thanks!
Hmmm, would you be able to send post the .ll file?
Feb 9 2023
Hi @bgraur Thanks for the reproducer, but I'm unable to reproduce the issue on my x64 box... What platform were you targeting? Could you please confirm that the reproducer still demonstrates the bug?
Feb 8 2023
Okay, thanks!
Any update on that reproducer @bgraur?
Feb 7 2023
Taking D141926 as a base, this transform brings the total code size of my local benchmarks down from 7982KB to 7970KB.
How is code size affected?
Using wasi-sdk-19, the total code size of my suite is 7985 KB. With this patch it's reduced slightly to 7982 KB.
Feb 6 2023
Modified, and now using, isKnownNeverZeroFloat.
Ping?
- Added check for no signed zeros.
- Fixed up vector support.
- Added arm tests.
Feb 3 2023
Feb 2 2023
Can you preserve the match with nsz?
Thanks for doing this.
Feb 1 2023
Jan 30 2023
Added SETNE as well.
Jan 27 2023
Thanks for the reproducer, I'll revert for now.
Jan 26 2023
Added setugt and setult support.
Jan 25 2023
Added support for checking against SETLT and SETGT nodes too. X86 and Arm test changes look rather noisey...
Thanks, extracted the bitwidth calculation into APFloatBase.
Jan 24 2023
Jan 23 2023
Rebased and added comment.
Avoiding integer comparison warning.
Using semanticsMaxExponent, so hopefully correct now...
Jan 20 2023
Removed non-poison input restriction for fptosi.
If you want to add some more, the initial set is in: https://github.com/llvm/llvm-project/commit/714286f9e641209411609deaf80dd865aa2198c5
Okay, great. Thanks for clarification on both fronts. I'm just about to commit some tests.
it should be sufficient to have the intermediate integer width be one more than the minimum required type width, so "%i = fptoui half %x to i17".
Jan 19 2023
Now only checking for poison/undef for the signed case.
Jan 18 2023
Jan 17 2023
Jan 12 2023
Added extra preserved analyses, though omitting MemorySSA for now.
Jan 4 2023
Jan 3 2023
Thanks for the quick review! I will be porting hardware-loops and mve-tail-predication as well.
Fixed typo.