LGTM. I think returning Expensive is the only reasonable thing we can do for a default implementation. It's more realistic than Basic and for anything else more complicated, it should be up to a target to override.

LGTM!

Remove alias analysis and added at -O3 opt pipeline test.

Sorry, I went on holiday and forgot about this... marked the constructor as deleted.

I've rebased from D59257. I've also removed isProfitable and changed the remove-duplicate test to just an llc test.

Updated some existing tests.

I've re-written the vldm test so that at least a couple of vldmia are generated. Also added a todo because there seems to still be some inefficiencies there.

This happens because of unroll and jam and I had tried to run cse after that... but doing the more obvious option of running it before parallel dsp solves the problem! I'll do that instead. Thanks.

This looks okay to me now.

Cheers Dave, that's far nicer.

Thanks Sanjay, a simple search works for us too. I've updated to check the immediate successors.

I agree this looks cleaner. LGTM.

Okay, rebased.

LGTM, cheers!

Hi Dave,

Thanks, I've now removed Formula from the class.

Updated the test labels. The AND that is used to convert the trunc still becomes a uxtb, so we just need to check that there's one after the division.

Cheers Dave!

I've opted for putting the pattern in ARMInstrInfo once everything has been included. Also added encodings to the test to ensure we're now using the correct movw.

Well, I'll still have the problem that tSUBrr is defined in the other file =/

Before I put this in ISelDAGToDAG, is there a way to reference machine instructions from across different tablegen files..?

Updated tests.

Thanks to you both.

Will do. Thanks for the review!

Added doxygen comment.

Removed the setter and instead changed the subtarget map key.

updated member description

Added method setOptMinSize which is set in getSubtargetImpl.

Ah yes, good point! I'll make the change.

Hi Florian,

Made some simplifications:

• reset isProfitableChain.
• reset FinalizeChain so that the tail is added to the chain again.
• removed the CollapseUnrolled option because with the reset in changes, it wasn't really interesting.

LGTM

Cheers, LGTM.

I like that idea, I think moving the logic into ARMISelLowering would be good as we already use similar logic there too.

Hi Max,

LGTM with one comment.

It looks like APInt doesn't function the way I expected, nor in the way that the other authors of this area would have expected. I've posted a query: http://lists.llvm.org/pipermail/llvm-dev/2019-January/129781.html

Some tests to follow...

Hi Florian,

Changed the builtins to use W instead of LL. I've also updated the tests, adding a test for rbitl.

Hi Hal,

ping

Cheers, added some comments and removed whitespace.

Thanks for your suggestion Eli, that works for me.