Page MenuHomePhabricator

samparker (Sam Parker)
part-timer

Projects

User does not belong to any projects.

User Details

User Since
May 11 2015, 7:59 AM (245 w, 6 d)

Recent Activity

Today

samparker created D73460: [RDA][ARM] Move functionality into RDA.
Mon, Jan 27, 3:38 AM · Restricted Project
samparker abandoned D71696: [CodeGen] MachinePostRAUpdater.

I've extracted the immediately useful changes into D73460, but it doesn't include the RDA initialisation changes. With those changes, I think being able to re-run the analysis is also likely to make this wrapper redundant.

Mon, Jan 27, 3:38 AM · Restricted Project
samparker committed rG6c2df5d14f7a: [ARM][LowOverheadLoops] Dont ignore VCTP (authored by samparker).
[ARM][LowOverheadLoops] Dont ignore VCTP
Mon, Jan 27, 3:03 AM
samparker closed D73275: [ARM][LowOverheadLoops] Don't ignore VCTP.
Mon, Jan 27, 3:02 AM · Restricted Project
samparker accepted D73198: [ARM][MVE] Tail-predication: support constant trip count.

Nice. LGTM.

Mon, Jan 27, 3:02 AM · Restricted Project

Fri, Jan 24

samparker retitled D71696: [CodeGen] MachinePostRAUpdater from [CodeGen] WIP MachinePostRAUpdater to [CodeGen] MachinePostRAUpdater.
Fri, Jan 24, 7:37 AM · Restricted Project
samparker updated the diff for D71696: [CodeGen] MachinePostRAUpdater.
  • Rebased.
  • Broke up some of the initialisation code in RDA so we can re-run after finalization.
Fri, Jan 24, 7:35 AM · Restricted Project
samparker added inline comments to D73198: [ARM][MVE] Tail-predication: support constant trip count.
Fri, Jan 24, 7:26 AM · Restricted Project
samparker committed rG0ae13766ffd8: [NFC][ARM] Add test (authored by samparker).
[NFC][ARM] Add test
Fri, Jan 24, 3:13 AM
samparker committed rGddbc077895ba: [NFC][ARM] Make some params members instead. (authored by samparker).
[NFC][ARM] Make some params members instead.
Fri, Jan 24, 2:24 AM

Thu, Jan 23

samparker committed rG05532575e88a: [RDA] Skip debug values (authored by samparker).
[RDA] Skip debug values
Thu, Jan 23, 9:07 AM
samparker closed D73273: [RDA] Skip debug values .
Thu, Jan 23, 9:06 AM · Restricted Project
samparker updated the diff for D73273: [RDA] Skip debug values .

Reduced test case.

Thu, Jan 23, 8:47 AM · Restricted Project
samparker committed rG0c943c611774: [NFC][ARM] Add test (authored by samparker).
[NFC][ARM] Add test
Thu, Jan 23, 8:25 AM
samparker created D73275: [ARM][LowOverheadLoops] Don't ignore VCTP.
Thu, Jan 23, 8:10 AM · Restricted Project
samparker updated the diff for D73273: [RDA] Skip debug values .

Using isDebugInstr instead.

Thu, Jan 23, 7:43 AM · Restricted Project
samparker created D73273: [RDA] Skip debug values .
Thu, Jan 23, 7:07 AM · Restricted Project
samparker added inline comments to D73198: [ARM][MVE] Tail-predication: support constant trip count.
Thu, Jan 23, 7:07 AM · Restricted Project
samparker committed rG0d1468db5853: [NFC][RDA] Make the interface const (authored by samparker).
[NFC][RDA] Make the interface const
Thu, Jan 23, 5:35 AM

Wed, Jan 22

samparker added inline comments to D73198: [ARM][MVE] Tail-predication: support constant trip count.
Wed, Jan 22, 8:40 AM · Restricted Project
samparker committed rGc04b9ba59580: [ARM][MVE] Clear MaskedInsts vector (authored by samparker).
[ARM][MVE] Clear MaskedInsts vector
Wed, Jan 22, 1:31 AM
samparker closed D73048: [ARM][MVE] Clear MaskedInsts vector.
Wed, Jan 22, 1:31 AM · Restricted Project
samparker added a comment to D73117: [ARM] Mark MVE loads/store as not having side effects.

Why isn't this handled properly by the scheduling infrastructure instead? This sounds a bit like a hack...

Wed, Jan 22, 1:22 AM · Restricted Project
samparker added a comment to D73117: [ARM] Mark MVE loads/store as not having side effects.

Why isn't this handled properly by the scheduling infrastructure instead? This sounds a bit like a hack...

Wed, Jan 22, 1:00 AM · Restricted Project
samparker updated the diff for D72916: [JumpThreading] Reduce duplicate threshold at Oz.

Changing the threshold within the pass.

Wed, Jan 22, 12:35 AM · Restricted Project

Tue, Jan 21

samparker added a comment to D72916: [JumpThreading] Reduce duplicate threshold at Oz.

I will proceed with getting some tests together and upload a patch for controlling the threshold. The numbers look even nicer for thumb2 targets:

Tue, Jan 21, 8:07 AM · Restricted Project

Mon, Jan 20

samparker created D73048: [ARM][MVE] Clear MaskedInsts vector.
Mon, Jan 20, 7:53 AM · Restricted Project

Sat, Jan 18

samparker added a comment to D72916: [JumpThreading] Reduce duplicate threshold at Oz.

Thanks, you both are indeed right that it can reduce code size... I've now tried reducing BBDuplicateThreshold and it looks like halving this to 3 is the best option (for aarch64 at least). There's a couple of outliers, but most changes are -0.1%:
test-suite...otout/Shootout-nestedloop.test 484 468 -3.3%
test-suite...+/Shootout-C++-nestedloop.test 532 516 -3.0%
test-suite...Olden/perimeter/perimeter.test 2108 2148 1.9%
test-suite...urce/Applications/aha/aha.test 2964 2932 -1.1%
test-suite...ce/Benchmarks/PAQ8p/paq8p.test 53748 53964 0.4%
test-suite...ch/g721/g721encode/encode.test 5468 5452 -0.3%
test-suite...marks/Ptrdist/yacr2/yacr2.test 15204 15236 0.2%
test-suite...ications/JM/ldecod/ldecod.test 161116 160788 -0.2%
test-suite...marks/7zip/7zip-benchmark.test 469784 470728 0.2%
test-suite...chmarks/MallocBench/gs/gs.test 104228 104428 0.2%
test-suite...oxyApps-C/miniAMR/miniAMR.test 34260 34196 -0.2%
test-suite...ications/JM/lencod/lencod.test 380324 380996 0.2%
test-suite...plications/d/make_dparser.test 62816 62912 0.2%
test-suite...s-C/Pathfinder/PathFinder.test 15996 15972 -0.2%
test-suite...ks/Prolangs-C++/city/city.test 5428 5436 0.1%
test-suite.../Benchmarks/Ptrdist/bc/bc.test 27300 27260 -0.1%
test-suite...pplications/oggenc/oggenc.test 105776 105632 -0.1%
test-suite...-typeset/consumer-typeset.test 327944 327520 -0.1%
test-suite...lications/sqlite3/sqlite3.test 244704 244400 -0.1%
test-suite...tions/lambda-0.1.3/lambda.test 20092 20068 -0.1%
test-suite.../Prolangs-C/bison/mybison.test 35828 35788 -0.1%
test-suite...peg2/mpeg2dec/mpeg2decode.test 29916 29884 -0.1%
test-suite.../Applications/SPASS/SPASS.test 287832 288136 0.1%
test-suite...arching-flt/Searching-flt.test 8292 8284 -0.1%
test-suite...arching-dbl/Searching-dbl.test 8500 8492 -0.1%
test-suite...C/Packing-flt/Packing-flt.test 8548 8540 -0.1%
test-suite...ences-flt/Recurrences-flt.test 8644 8636 -0.1%
test-suite...t/StatementReordering-flt.test 8660 8652 -0.1%
test-suite...encode/alacconvert-encode.test 26044 26020 -0.1%
test-suite...decode/alacconvert-decode.test 26044 26020 -0.1%
test-suite...C/Packing-dbl/Packing-dbl.test 8756 8748 -0.1%
test-suite...lications/SIBsim4/SIBsim4.test 26476 26500 0.1%
test-suite...ences-dbl/Recurrences-dbl.test 8852 8844 -0.1%
test-suite...l/StatementReordering-dbl.test 8868 8860 -0.1%
test-suite...ing-flt/LoopRerolling-flt.test 9116 9108 -0.1%
test-suite...ing-flt/Equivalencing-flt.test 9268 9260 -0.1%
test-suite...ing-flt/NodeSplitting-flt.test 9276 9268 -0.1%
test-suite...ing-dbl/LoopRerolling-dbl.test 9340 9332 -0.1%
test-suite...mbolics-flt/Symbolics-flt.test 9364 9356 -0.1%
test-suite...ing-dbl/Equivalencing-dbl.test 9420 9412 -0.1%
test-suite...ing-dbl/NodeSplitting-dbl.test 9476 9468 -0.1%
test-suite...mbolics-dbl/Symbolics-dbl.test 9588 9580 -0.1%
test-suite...lt/IndirectAddressing-flt.test 9708 9700 -0.1%
test-suite...bl/IndirectAddressing-dbl.test 9924 9916 -0.1%
test-suite...lt/CrossingThresholds-flt.test 9940 9932 -0.1%
test-suite...cations/hexxagon/hexxagon.test 10124 10132 0.1%
test-suite...bl/CrossingThresholds-dbl.test 10148 10140 -0.1%
test-suite...flt/InductionVariable-flt.test 10204 10196 -0.1%
test-suite...flt/LoopRestructuring-flt.test 10436 10428 -0.1%
test-suite...ow-flt/GlobalDataFlow-flt.test 10452 10444 -0.1%
test-suite...dbl/InductionVariable-dbl.test 10468 10460 -0.1%
test-suite...oops-flt/ControlLoops-flt.test 10588 10580 -0.1%
test-suite...dbl/LoopRestructuring-dbl.test 10644 10636 -0.1%
test-suite...ow-dbl/GlobalDataFlow-dbl.test 10660 10652 -0.1%
test-suite...oops-dbl/ControlLoops-dbl.test 10780 10772 -0.1%
test-suite...pansion-flt/Expansion-flt.test 10996 10988 -0.1%
test-suite...-flt/LinearDependence-flt.test 11148 11140 -0.1%
test-suite...pansion-dbl/Expansion-dbl.test 11196 11188 -0.1%
test-suite...ctions-flt/Reductions-flt.test 11316 11308 -0.1%
test-suite...-dbl/LinearDependence-dbl.test 11364 11356 -0.1%
test-suite...ctions-dbl/Reductions-dbl.test 11524 11516 -0.1%
test-suite...sc-C++/stepanov_container.test 13132 13140 0.1%
test-suite...lFlow-flt/ControlFlow-flt.test 13764 13756 -0.1%
test-suite...lFlow-dbl/ControlFlow-dbl.test 13972 13964 -0.1%
Geomean difference -0.0%

default-results    threshold-3        diff

count 310.000000 310.000000 310.000000
mean 26375.587097 26377.445161 -0.000273
std 65478.305060 65501.068235 0.002870
min 460.000000 460.000000 -0.033058
25% 1286.000000 1286.000000 0.000000
50% 3128.000000 3128.000000 0.000000
75% 11262.000000 11260.000000 0.000000
max 469784.000000 470728.000000 0.018975

Sat, Jan 18, 2:46 AM · Restricted Project

Fri, Jan 17

samparker committed rG42350cd893a9: [ARM][MVE] Tail Predicate IsSafeToRemove (authored by samparker).
[ARM][MVE] Tail Predicate IsSafeToRemove
Fri, Jan 17, 5:23 AM
samparker closed D71837: [ARM][MVE] Tail Predicate IsSafeToRemove.
Fri, Jan 17, 5:22 AM · Restricted Project
samparker added inline comments to D71837: [ARM][MVE] Tail Predicate IsSafeToRemove.
Fri, Jan 17, 5:04 AM · Restricted Project
samparker created D72916: [JumpThreading] Reduce duplicate threshold at Oz.
Fri, Jan 17, 5:03 AM · Restricted Project
samparker accepted D72714: [ARM][MVE] Tail-Predication: rematerialise iteration count in exit blocks.

LGTM, but please address nits before committing.

Fri, Jan 17, 1:18 AM · Restricted Project
samparker updated the diff for D71837: [ARM][MVE] Tail Predicate IsSafeToRemove.

Removed some accidentally added files.

Fri, Jan 17, 12:59 AM · Restricted Project
samparker updated the diff for D71837: [ARM][MVE] Tail Predicate IsSafeToRemove.

Rebased, cleaned up some tests and addressed comments.

Fri, Jan 17, 12:55 AM · Restricted Project
samparker added inline comments to D71837: [ARM][MVE] Tail Predicate IsSafeToRemove.
Fri, Jan 17, 12:50 AM · Restricted Project

Thu, Jan 16

samparker abandoned D72441: [CodeGen] Store LiveRegs in SetVector.
Thu, Jan 16, 8:09 AM · Restricted Project
samparker committed rG760b1751097f: [ARM][LowOverheadLoops] Update liveness info (authored by samparker).
[ARM][LowOverheadLoops] Update liveness info
Thu, Jan 16, 8:00 AM
samparker closed D72131: [ARM][LowOverheadLoops] Update liveness info.
Thu, Jan 16, 7:59 AM · Restricted Project
samparker added a comment to D72441: [CodeGen] Store LiveRegs in SetVector.

Ah, thanks, then maybe I need to look elsewhere. I appear to be running into const issues when trying to sort in print and dump.

Thu, Jan 16, 6:25 AM · Restricted Project
samparker added a comment to D71992: [ARM] Unrestrict Armv8 IT blocks.

Ok, I'll get some test suite numbers across some cores. I would hope long latency instructions, such as div, would be predicated in the same way as armv7 so the performance would be comparable... I definitely share your concern there though, it will be the main source of the performance changes.

Thu, Jan 16, 2:17 AM · Restricted Project

Wed, Jan 15

samparker added a comment to D72714: [ARM][MVE] Tail-Predication: rematerialise iteration count in exit blocks.

Good to see those looks finally loosing those subs and movs!

Wed, Jan 15, 7:47 AM · Restricted Project
samparker added a comment to D71992: [ARM] Unrestrict Armv8 IT blocks.

Are there any cores where we don't want FeatureDontRestrictIT?

How would you feel about unrestricting by default..? One of the GCC guys I was talking too also said it's hampering performance compared to armv7. I've got little bandwidth and I want to get some more numbers, and I'm not quite trusting my chromebook at the minute... but its' A72/A53 and I'm seeing good improvements on my data set of 1 (coremark) of 14% improvement.

Wed, Jan 15, 6:57 AM · Restricted Project
samparker added inline comments to D72714: [ARM][MVE] Tail-Predication: rematerialise iteration count in exit blocks.
Wed, Jan 15, 12:36 AM · Restricted Project
samparker added a comment to D72714: [ARM][MVE] Tail-Predication: rematerialise iteration count in exit blocks.

I vaguely remember something that will go through and remove the one operand phis too, but I'm not sure what that is called (other than instcombine).

I'm hoping that this close to codegen, the phis won't be a problem..?

Wed, Jan 15, 12:27 AM · Restricted Project

Tue, Jan 14

samparker added a comment to D72713: [ARM][MVE] Check LowOverheadLoop live outs.

Please ignore the RDA and BaseInstrInfo changes, I've just copied them from the parent.

Tue, Jan 14, 8:59 AM · Restricted Project
samparker created D72713: [ARM][MVE] Check LowOverheadLoop live outs.
Tue, Jan 14, 8:59 AM · Restricted Project
samparker added a child revision for D71837: [ARM][MVE] Tail Predicate IsSafeToRemove: D72713: [ARM][MVE] Check LowOverheadLoop live outs.
Tue, Jan 14, 8:59 AM · Restricted Project
samparker added a parent revision for D72713: [ARM][MVE] Check LowOverheadLoop live outs: D71837: [ARM][MVE] Tail Predicate IsSafeToRemove.
Tue, Jan 14, 8:59 AM · Restricted Project
samparker accepted D72699: [ARM][MVE] VTP Block fix.

Cheers.

Tue, Jan 14, 7:52 AM · Restricted Project
samparker committed rGe27632c30263: [ARM][LowOverheadLoops] Allow all MVE instrs. (authored by samparker).
[ARM][LowOverheadLoops] Allow all MVE instrs.
Tue, Jan 14, 4:10 AM
samparker closed D72509: [ARM][LowOverheadLoops] Allow all MVE instrs..
Tue, Jan 14, 4:10 AM · Restricted Project
samparker committed rGbad6032bc15f: [ARM][LowOverheadLoops] Change predicate inspection (authored by samparker).
[ARM][LowOverheadLoops] Change predicate inspection
Tue, Jan 14, 3:51 AM
samparker closed D72504: [ARM][LowOverheadLoops] Change predicate inspection.
Tue, Jan 14, 3:50 AM · Restricted Project
samparker committed rGe73b20c57dc7: [ARM][MVE] Disallow VPSEL for tail predication (authored by samparker).
[ARM][MVE] Disallow VPSEL for tail predication
Tue, Jan 14, 3:43 AM
samparker closed D72629: [ARM][MVE] Disallow VPSEL for tail predication.
Tue, Jan 14, 3:42 AM · Restricted Project
samparker updated the diff for D72629: [ARM][MVE] Disallow VPSEL for tail predication.
  • Added explicit check for VPNOT.
  • Added TODO comment.
  • Removed duplicate test.
  • Added comments to tests and had a small shuffle around of one of them.
Tue, Jan 14, 3:06 AM · Restricted Project
samparker added inline comments to D72509: [ARM][LowOverheadLoops] Allow all MVE instrs..
Tue, Jan 14, 1:51 AM · Restricted Project
samparker added a comment to D72441: [CodeGen] Store LiveRegs in SetVector.

Ping.

Tue, Jan 14, 1:42 AM · Restricted Project
samparker added a comment to D72629: [ARM][MVE] Disallow VPSEL for tail predication.

Does VPNOT not need to be explicitly excluded because they are def's anyway?

It's actually the multiple vpr uses which prevent them from being included. I think I'll explicitly disallow them for now, as well as adding the comment.

Tue, Jan 14, 1:42 AM · Restricted Project

Mon, Jan 13

samparker added a child revision for D72504: [ARM][LowOverheadLoops] Change predicate inspection: D72629: [ARM][MVE] Disallow VPSEL for tail predication.
Mon, Jan 13, 9:18 AM · Restricted Project
samparker added parent revisions for D72629: [ARM][MVE] Disallow VPSEL for tail predication: D72509: [ARM][LowOverheadLoops] Allow all MVE instrs., D72504: [ARM][LowOverheadLoops] Change predicate inspection.
Mon, Jan 13, 9:18 AM · Restricted Project
samparker added a child revision for D72509: [ARM][LowOverheadLoops] Allow all MVE instrs.: D72629: [ARM][MVE] Disallow VPSEL for tail predication.
Mon, Jan 13, 9:18 AM · Restricted Project
samparker created D72629: [ARM][MVE] Disallow VPSEL for tail predication.
Mon, Jan 13, 9:18 AM · Restricted Project
samparker added inline comments to D72509: [ARM][LowOverheadLoops] Allow all MVE instrs..
Mon, Jan 13, 7:06 AM · Restricted Project
samparker committed rG9d3e78e704fa: [NFC] Update loop.decrement.reg intrinsic comment (authored by samparker).
[NFC] Update loop.decrement.reg intrinsic comment
Mon, Jan 13, 1:21 AM

Fri, Jan 10

samparker added a comment to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

Even if you only decrease the size you can have a distance increase due to aligment constraints

Ah... thanks for raising this. I'll look into it.

Fri, Jan 10, 7:52 AM · Restricted Project, Restricted Project
samparker created D72509: [ARM][LowOverheadLoops] Allow all MVE instrs..
Fri, Jan 10, 7:46 AM · Restricted Project
samparker added a parent revision for D72509: [ARM][LowOverheadLoops] Allow all MVE instrs.: D72504: [ARM][LowOverheadLoops] Change predicate inspection.
Fri, Jan 10, 7:46 AM · Restricted Project
samparker added a child revision for D72504: [ARM][LowOverheadLoops] Change predicate inspection: D72509: [ARM][LowOverheadLoops] Allow all MVE instrs..
Fri, Jan 10, 7:46 AM · Restricted Project
samparker created D72504: [ARM][LowOverheadLoops] Change predicate inspection.
Fri, Jan 10, 6:55 AM · Restricted Project
samparker committed rG3772ea9dd936: [ARM][MVE] Tail predicate VMAX,VMAXA,VMIN,VMINA (authored by samparker).
[ARM][MVE] Tail predicate VMAX,VMAXA,VMIN,VMINA
Fri, Jan 10, 6:27 AM
samparker closed D72502: [ARM][MVE] Tail predicate VMAX,VMAXA,VMIN,VMINA.
Fri, Jan 10, 6:27 AM · Restricted Project
samparker created D72502: [ARM][MVE] Tail predicate VMAX,VMAXA,VMIN,VMINA.
Fri, Jan 10, 5:16 AM · Restricted Project

Thu, Jan 9

samparker accepted D71563: [SCEV] Recognise the hardwareloop "loop.decrement.reg" intrinsic.

I reckon adding something to that unroll test that would consistently drive the unroller, like a triple, should be added. Otherwise, LGTM.

Thu, Jan 9, 8:49 AM · Restricted Project
samparker reopened D72131: [ARM][LowOverheadLoops] Update liveness info.

I had to revert this due to buildbot failures. It seems the print order of liveins is non-deterministic... D72441 hopefully addresses this.

Thu, Jan 9, 5:01 AM · Restricted Project
samparker committed rG9c91d79dadc6: [NFC][ARM] LowOverheadLoop comments (authored by samparker).
[NFC][ARM] LowOverheadLoop comments
Thu, Jan 9, 4:55 AM
samparker added a comment to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

I can add liveness info into the outlined function, but we will need to do the same on AArch64 even if is not necessary.

Hmm, would it be possible to pass a bool to the pass which will control whether liveness is updated? The other, suboptimal, option would be to not do outlining when we have the LOB extension.

Thu, Jan 9, 4:08 AM · Restricted Project, Restricted Project
samparker committed rG15c7fa4d11ee: [ARM][MVE] Don't unroll intrinsic loops. (authored by samparker).
[ARM][MVE] Don't unroll intrinsic loops.
Thu, Jan 9, 3:59 AM
samparker closed D72440: [ARM][MVE] Don't unroll intrinsic loops..
Thu, Jan 9, 3:59 AM · Restricted Project
samparker created D72441: [CodeGen] Store LiveRegs in SetVector.
Thu, Jan 9, 2:58 AM · Restricted Project
samparker created D72440: [ARM][MVE] Don't unroll intrinsic loops..
Thu, Jan 9, 2:39 AM · Restricted Project
samparker committed rG1cba2612399e: Revert "[ARM][LowOverheadLoops] Update liveness info" (authored by samparker).
Revert "[ARM][LowOverheadLoops] Update liveness info"
Thu, Jan 9, 1:23 AM
samparker added a reverting change for rGe93e0d413f3a: [ARM][LowOverheadLoops] Update liveness info: rG1cba2612399e: Revert "[ARM][LowOverheadLoops] Update liveness info".
Thu, Jan 9, 1:23 AM
samparker committed rGe93e0d413f3a: [ARM][LowOverheadLoops] Update liveness info (authored by samparker).
[ARM][LowOverheadLoops] Update liveness info
Thu, Jan 9, 12:53 AM
samparker closed D72131: [ARM][LowOverheadLoops] Update liveness info.
Thu, Jan 9, 12:53 AM · Restricted Project
samparker accepted D72324: [LV] Still vectorise when tail-folding can't find a primary inducation variable.

LGTM

Thu, Jan 9, 12:45 AM · Restricted Project
samparker added a comment to D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

It might be possible to rearrange Low Overhead Loops to run before ConstantIslands, but you'd probably need to do more to make it work properly. I don't think ConstantIslands knows how to handle the branches generated by LowOverheadLoop.

Thu, Jan 9, 12:25 AM · Restricted Project, Restricted Project

Wed, Jan 8

samparker added a comment to D71563: [SCEV] Recognise the hardwareloop "loop.decrement.reg" intrinsic.

It's currently the backends responsibility to lower and handle any of the intrinsics that are inserted for hardware loops, so I don't think we should be concerned with other transforms triggering. I think the benefit of SCEV still working for these loops far outweighs the codegen effort - especially since this effort already has to be done because of isel and machine optimisations. That said, it probably wouldn't hurt to add some tests for common transforms especially ones where the loop body would be duplicated.

Wed, Jan 8, 8:09 AM · Restricted Project
samparker added inline comments to D72324: [LV] Still vectorise when tail-folding can't find a primary inducation variable.
Wed, Jan 8, 7:31 AM · Restricted Project
samparker updated the diff for D71837: [ARM][MVE] Tail Predicate IsSafeToRemove.

A couple of changes to RDA:

  • It how has getLiveInUses which collects all the users of a live-in register.
  • It now has getAllUses, which collects locals users and users in the successor blocks (using getLiveInUses).
Wed, Jan 8, 3:30 AM · Restricted Project
samparker committed rG96d2d96b03ff: [NFC][ARM] Update tests (authored by samparker).
[NFC][ARM] Update tests
Wed, Jan 8, 3:11 AM
samparker accepted D72257: [ARM] Use reduction intrinsics for larger than legal reductions.

LGTM

Wed, Jan 8, 12:50 AM · Restricted Project
samparker added inline comments to D72324: [LV] Still vectorise when tail-folding can't find a primary inducation variable.
Wed, Jan 8, 12:41 AM · Restricted Project
samparker updated the diff for D72131: [ARM][LowOverheadLoops] Update liveness info.

Regenerated the disjoint vcmp test.

Wed, Jan 8, 12:15 AM · Restricted Project

Tue, Jan 7

samparker added inline comments to D72131: [ARM][LowOverheadLoops] Update liveness info.
Tue, Jan 7, 11:47 PM · Restricted Project
samparker added inline comments to D72330: [ARM][MVE] Enable masked gathers from base + vector of offsets.
Tue, Jan 7, 7:42 AM · Restricted Project
samparker committed rG3c7f740f2842: [TypePromotion] Use SetVectors instead of PtrSets (authored by samparker).
[TypePromotion] Use SetVectors instead of PtrSets
Tue, Jan 7, 6:56 AM
samparker closed D72322: [TypePromotion] Use vectors instead of sets.
Tue, Jan 7, 6:56 AM · Restricted Project
samparker created D72322: [TypePromotion] Use vectors instead of sets.
Tue, Jan 7, 3:41 AM · Restricted Project