Page MenuHomePhabricator

samparker (Sam Parker)
User

Projects

User does not belong to any projects.

User Details

User Since
May 11 2015, 7:59 AM (206 w, 1 d)

Recent Activity

Today

samparker created D61020: [ARM][ParallelDSP] Relax alias checks.
Tue, Apr 23, 8:25 AM

Mar 19 2019

samparker accepted D59252: [TTI] getMemcpyCost.

LGTM. I think returning Expensive is the only reasonable thing we can do for a default implementation. It's more realistic than Basic and for anything else more complicated, it should be up to a target to override.

Mar 19 2019, 12:07 AM · Restricted Project

Mar 15 2019

samparker committed rGf82d4ed771a0: [ARM] Remove EarlyCSE from backend (authored by samparker).
[ARM] Remove EarlyCSE from backend
Mar 15 2019, 6:37 AM
samparker created D59410: [ARM] Remove EarlyCSE from backend.
Mar 15 2019, 6:00 AM · Restricted Project
samparker committed rG9e73020bfaef: [ARM][ParallelDSP] Disable for big-endian (authored by samparker).
[ARM][ParallelDSP] Disable for big-endian
Mar 15 2019, 3:20 AM

Mar 14 2019

samparker accepted D59317: [ARM] Search backwards for CMP when combining into CBZ.

LGTM!

Mar 14 2019, 8:55 AM · Restricted Project
samparker created D59368: [ARM][ParallelDSP] Disable for big-endian.
Mar 14 2019, 8:55 AM · Restricted Project
samparker committed rG0a833d0ad202: [NFC][ARM] Update test (authored by samparker).
[NFC][ARM] Update test
Mar 14 2019, 8:36 AM
samparker committed rGa86ff8640d9c: Fix for buildbots (authored by samparker).
Fix for buildbots
Mar 14 2019, 4:39 AM
samparker committed rG4c4ff13d3c81: [ARM][ParallelDSP] Enable multiple uses of loads (authored by samparker).
[ARM][ParallelDSP] Enable multiple uses of loads
Mar 14 2019, 4:14 AM
samparker committed rGeb0b8019e892: [NFC][LSR] Cleanup Cost API (authored by samparker).
[NFC][LSR] Cleanup Cost API
Mar 14 2019, 4:09 AM
samparker committed rG3b2ba20afd4c: [ARM] Run ARMParallelDSP in the IRPasses phase (authored by samparker).
[ARM] Run ARMParallelDSP in the IRPasses phase
Mar 14 2019, 3:57 AM
samparker added inline comments to D59317: [ARM] Search backwards for CMP when combining into CBZ.
Mar 14 2019, 3:49 AM · Restricted Project
samparker updated the diff for D59257: [ARM] Run ARMParallelDSP in the IRPasses phase.

Remove alias analysis and added at -O3 opt pipeline test.

Mar 14 2019, 3:14 AM · Restricted Project
samparker added inline comments to D59257: [ARM] Run ARMParallelDSP in the IRPasses phase.
Mar 14 2019, 3:06 AM · Restricted Project
samparker updated the diff for D58389: [NFC][LSR] Cleanup Cost API.

Sorry, I went on holiday and forgot about this... marked the constructor as deleted.

Mar 14 2019, 2:06 AM · Restricted Project

Mar 13 2019

samparker added inline comments to D59215: [ARM][ParallelDSP] Enable multiple uses of loads.
Mar 13 2019, 8:18 AM · Restricted Project
samparker updated the diff for D59215: [ARM][ParallelDSP] Enable multiple uses of loads.

I've rebased from D59257. I've also removed isProfitable and changed the remove-duplicate test to just an llc test.

Mar 13 2019, 8:17 AM · Restricted Project
samparker updated the diff for D59257: [ARM] Run ARMParallelDSP in the IRPasses phase.

Updated some existing tests.

Mar 13 2019, 7:49 AM · Restricted Project
samparker updated the diff for D59257: [ARM] Run ARMParallelDSP in the IRPasses phase.

I've re-written the vldm test so that at least a couple of vldmia are generated. Also added a todo because there seems to still be some inefficiencies there.

Mar 13 2019, 4:32 AM · Restricted Project

Mar 12 2019

samparker added inline comments to D59257: [ARM] Run ARMParallelDSP in the IRPasses phase.
Mar 12 2019, 9:01 AM · Restricted Project
samparker added inline comments to D59215: [ARM][ParallelDSP] Enable multiple uses of loads.
Mar 12 2019, 8:55 AM · Restricted Project
samparker created D59257: [ARM] Run ARMParallelDSP in the IRPasses phase.
Mar 12 2019, 8:13 AM · Restricted Project
samparker committed rGa7ae60ac9353: [ARM][NFC] Delete original smlad tests (authored by samparker).
[ARM][NFC] Delete original smlad tests
Mar 12 2019, 4:06 AM
samparker committed rG28e46e58db0d: [ARM][NFC] Move smlad tests (authored by samparker).
[ARM][NFC] Move smlad tests
Mar 12 2019, 4:02 AM
samparker abandoned D59207: [ARM] Remove duplicates in ParallelDSP.

This happens because of unroll and jam and I had tried to run cse after that... but doing the more obvious option of running it before parallel dsp solves the problem! I'll do that instead. Thanks.

Mar 12 2019, 3:57 AM

Mar 11 2019

samparker added a parent revision for D59215: [ARM][ParallelDSP] Enable multiple uses of loads: D59207: [ARM] Remove duplicates in ParallelDSP.
Mar 11 2019, 9:14 AM · Restricted Project
samparker added a child revision for D59207: [ARM] Remove duplicates in ParallelDSP: D59215: [ARM][ParallelDSP] Enable multiple uses of loads.
Mar 11 2019, 9:14 AM
samparker created D59215: [ARM][ParallelDSP] Enable multiple uses of loads.
Mar 11 2019, 9:14 AM · Restricted Project
samparker committed rG52760bf43525: [CGP] Limit distance between overflow math and cmp (authored by samparker).
[CGP] Limit distance between overflow math and cmp
Mar 11 2019, 6:20 AM
samparker created D59207: [ARM] Remove duplicates in ParallelDSP.
Mar 11 2019, 4:28 AM
samparker accepted D59014: [TTI] Enable analysis of clib functions in getIntrinsicCosts. NFCI..

This looks okay to me now.

Mar 11 2019, 4:08 AM · Restricted Project
samparker updated the diff for D59024: [CGP] Limit distance between overflow math and cmp.

Cheers Dave, that's far nicer.

Mar 11 2019, 4:00 AM · Restricted Project
samparker updated the diff for D59024: [CGP] Limit distance between overflow math and cmp.

Thanks Sanjay, a simple search works for us too. I've updated to check the immediate successors.

Mar 11 2019, 2:28 AM · Restricted Project

Mar 8 2019

samparker added inline comments to D59024: [CGP] Limit distance between overflow math and cmp.
Mar 8 2019, 2:44 AM · Restricted Project

Mar 7 2019

samparker added inline comments to D59014: [TTI] Enable analysis of clib functions in getIntrinsicCosts. NFCI..
Mar 7 2019, 9:02 AM · Restricted Project
samparker accepted D58770: [LSR] Attempt to increase the accuracy of LSR's setup cost.

I agree this looks cleaner. LGTM.

Mar 7 2019, 4:20 AM · Restricted Project

Mar 6 2019

samparker updated the diff for D59024: [CGP] Limit distance between overflow math and cmp.

Okay, rebased.

Mar 6 2019, 7:21 AM · Restricted Project
samparker created D59024: [CGP] Limit distance between overflow math and cmp.
Mar 6 2019, 7:03 AM · Restricted Project

Mar 5 2019

samparker accepted D58063: [ARM] Sink zext/sext operands for add and sub to enable vsubl generation..

LGTM, cheers!

Mar 5 2019, 2:13 AM · Restricted Project
samparker added inline comments to D58770: [LSR] Attempt to increase the accuracy of LSR's setup cost.
Mar 5 2019, 12:05 AM · Restricted Project

Mar 1 2019

samparker added a comment to D58770: [LSR] Attempt to increase the accuracy of LSR's setup cost.

Hi Dave,

Mar 1 2019, 1:21 AM · Restricted Project

Feb 21 2019

samparker updated the diff for D58389: [NFC][LSR] Cleanup Cost API.

Thanks, I've now removed Formula from the class.

Feb 21 2019, 2:01 AM · Restricted Project
samparker committed rG6ed47bee2757: [ARM] Negative constants mishandled in ARM CGP (authored by samparker).
[ARM] Negative constants mishandled in ARM CGP
Feb 21 2019, 1:36 AM

Feb 20 2019

samparker created D58452: [ARM] Negative constants mishandled in ARM CGP.
Feb 20 2019, 7:59 AM · Restricted Project

Feb 19 2019

samparker created D58389: [NFC][LSR] Cleanup Cost API.
Feb 19 2019, 8:39 AM · Restricted Project

Feb 15 2019

samparker committed rG0b53e8454b11: [BPI] Look through bitcasts in calcZeroHeuristic (authored by samparker).
[BPI] Look through bitcasts in calcZeroHeuristic
Feb 15 2019, 3:50 AM
samparker committed rG3c17cb7bc430: [ARM CGP] Fix ConvertTruncs (authored by samparker).
[ARM CGP] Fix ConvertTruncs
Feb 15 2019, 1:10 AM

Feb 14 2019

samparker updated the diff for D57686: [ARM CGP] Fix ConvertTruncs.

Updated the test labels. The AND that is used to convert the trunc still becomes a uxtb, so we just need to check that there's one after the division.

Feb 14 2019, 5:26 AM · Restricted Project

Feb 13 2019

samparker added inline comments to D57686: [ARM CGP] Fix ConvertTruncs.
Feb 13 2019, 6:12 AM · Restricted Project
samparker created D58166: [BPI] Look through bitcasts in calcZeroHeuristic.
Feb 13 2019, 12:21 AM · Restricted Project

Feb 12 2019

samparker added inline comments to D58063: [ARM] Sink zext/sext operands for add and sub to enable vsubl generation..
Feb 12 2019, 5:18 AM · Restricted Project

Feb 11 2019

samparker committed rG8ff143033a77: [ARM] Add v8m.base pattern for add negative imm (authored by samparker).
[ARM] Add v8m.base pattern for add negative imm
Feb 11 2019, 3:36 AM
samparker updated the diff for D57942: [ARM] Add v8m.base pattern for add negative imm.

Cheers Dave!

Feb 11 2019, 3:14 AM · Restricted Project
samparker committed rG3fbacd4964ed: [NFC][ARM] Simplify loop-indexing codegen test (authored by samparker).
[NFC][ARM] Simplify loop-indexing codegen test
Feb 11 2019, 2:54 AM

Feb 8 2019

samparker updated the diff for D57942: [ARM] Add v8m.base pattern for add negative imm.

I've opted for putting the pattern in ARMInstrInfo once everything has been included. Also added encodings to the test to ensure we're now using the correct movw.

Feb 8 2019, 7:26 AM · Restricted Project
samparker added a comment to D57942: [ARM] Add v8m.base pattern for add negative imm.

Well, I'll still have the problem that tSUBrr is defined in the other file =/

Feb 8 2019, 6:13 AM · Restricted Project
samparker added a comment to D57942: [ARM] Add v8m.base pattern for add negative imm.

Before I put this in ISelDAGToDAG, is there a way to reference machine instructions from across different tablegen files..?

Feb 8 2019, 5:38 AM · Restricted Project
samparker added inline comments to D57942: [ARM] Add v8m.base pattern for add negative imm.
Feb 8 2019, 5:29 AM · Restricted Project
samparker updated the diff for D57942: [ARM] Add v8m.base pattern for add negative imm.

Updated tests.

Feb 8 2019, 4:53 AM · Restricted Project
samparker added inline comments to D57942: [ARM] Add v8m.base pattern for add negative imm.
Feb 8 2019, 4:42 AM · Restricted Project
samparker created D57942: [ARM] Add v8m.base pattern for add negative imm.
Feb 8 2019, 2:53 AM · Restricted Project

Feb 7 2019

samparker committed rG5b09834bc364: [ARM] Add OptMinSize to ARMSubtarget (authored by samparker).
[ARM] Add OptMinSize to ARMSubtarget
Feb 7 2019, 11:58 PM
samparker added a comment to D57812: [ARM] Add OptMinSize Subtarget feature.

Thanks to you both.

Feb 7 2019, 11:23 PM · Restricted Project
samparker removed a reviewer for D49229: [AggressiveInstCombine] Fold redundant masking operations of shifted value: samparker.
Feb 7 2019, 8:38 AM
samparker committed rG67756c09f21a: [LSR] Generate cross iteration indexes (authored by samparker).
[LSR] Generate cross iteration indexes
Feb 7 2019, 5:34 AM
samparker added a comment to D55373: [LSR] Generate formulae to enable more indexed accesses.

Will do. Thanks for the review!

Feb 7 2019, 4:50 AM · Restricted Project
samparker added inline comments to D55373: [LSR] Generate formulae to enable more indexed accesses.
Feb 7 2019, 2:58 AM · Restricted Project
samparker updated the diff for D55373: [LSR] Generate formulae to enable more indexed accesses.

Added doxygen comment.

Feb 7 2019, 1:42 AM · Restricted Project
samparker added inline comments to D55373: [LSR] Generate formulae to enable more indexed accesses.
Feb 7 2019, 1:36 AM · Restricted Project
samparker updated the diff for D57812: [ARM] Add OptMinSize Subtarget feature.

Removed the setter and instead changed the subtarget map key.

Feb 7 2019, 1:26 AM · Restricted Project

Feb 6 2019

samparker added inline comments to D57812: [ARM] Add OptMinSize Subtarget feature.
Feb 6 2019, 9:04 AM · Restricted Project
samparker updated the diff for D57812: [ARM] Add OptMinSize Subtarget feature.

updated member description

Feb 6 2019, 6:20 AM · Restricted Project
samparker added inline comments to D57812: [ARM] Add OptMinSize Subtarget feature.
Feb 6 2019, 6:20 AM · Restricted Project
samparker updated the diff for D57812: [ARM] Add OptMinSize Subtarget feature.

Added method setOptMinSize which is set in getSubtargetImpl.

Feb 6 2019, 3:53 AM · Restricted Project
samparker added a comment to D57812: [ARM] Add OptMinSize Subtarget feature.

Ah yes, good point! I'll make the change.

Feb 6 2019, 3:44 AM · Restricted Project
samparker added a comment to D57812: [ARM] Add OptMinSize Subtarget feature.

Hi Florian,

Feb 6 2019, 3:22 AM · Restricted Project
samparker created D57812: [ARM] Add OptMinSize Subtarget feature.
Feb 6 2019, 2:49 AM · Restricted Project

Feb 5 2019

samparker added a comment to D55373: [LSR] Generate formulae to enable more indexed accesses.

Feb 5 2019, 3:14 AM · Restricted Project
samparker updated the diff for D55373: [LSR] Generate formulae to enable more indexed accesses.

Made some simplifications:

  • reset isProfitableChain.
  • reset FinalizeChain so that the tail is added to the chain again.
  • removed the CollapseUnrolled option because with the reset in changes, it wasn't really interesting.
Feb 5 2019, 3:13 AM · Restricted Project

Feb 4 2019

samparker created D57686: [ARM CGP] Fix ConvertTruncs.
Feb 4 2019, 6:30 AM · Restricted Project
samparker added inline comments to D55373: [LSR] Generate formulae to enable more indexed accesses.
Feb 4 2019, 3:37 AM · Restricted Project
samparker accepted D57671: [ARM] Mark 255 and 65535 as cheap for Thumb1 "And".

LGTM

Feb 4 2019, 3:05 AM · Restricted Project
samparker accepted D57565: [LSR] Check SCEV on isZero() after extend. PR40514.

Cheers, LGTM.

Feb 4 2019, 3:03 AM · Restricted Project

Feb 1 2019

samparker added a comment to D57445: [ARM] Fix TTI IntImmCost.

I like that idea, I think moving the logic into ARMISelLowering would be good as we already use similar logic there too.

Feb 1 2019, 3:22 AM
samparker added a comment to D57565: [LSR] Check SCEV on isZero() after extend. PR40514.

Hi Max,

Feb 1 2019, 3:03 AM · Restricted Project

Jan 31 2019

samparker added inline comments to D57445: [ARM] Fix TTI IntImmCost.
Jan 31 2019, 6:33 AM
samparker accepted D57377: [CGP] Add support for sinking operands to their users, if they are free..

LGTM with one comment.

Jan 31 2019, 6:27 AM · Restricted Project
samparker added a comment to D57445: [ARM] Fix TTI IntImmCost.

It looks like APInt doesn't function the way I expected, nor in the way that the other authors of this area would have expected. I've posted a query: http://lists.llvm.org/pipermail/llvm-dev/2019-January/129781.html

Jan 31 2019, 5:26 AM

Jan 30 2019

samparker added a comment to D57445: [ARM] Fix TTI IntImmCost.

Some tests to follow...

Jan 30 2019, 5:42 AM
samparker created D57445: [ARM] Fix TTI IntImmCost.
Jan 30 2019, 4:27 AM
samparker added a comment to D57377: [CGP] Add support for sinking operands to their users, if they are free..

Hi Florian,

Jan 30 2019, 1:35 AM · Restricted Project

Jan 29 2019

samparker added inline comments to D55373: [LSR] Generate formulae to enable more indexed accesses.
Jan 29 2019, 1:20 AM · Restricted Project

Jan 28 2019

samparker updated the diff for D56852: [AArch64] Use LL for 64-bit arguments.

Changed the builtins to use W instead of LL. I've also updated the tests, adding a test for rbitl.

Jan 28 2019, 3:40 AM
samparker reopened D56852: [AArch64] Use LL for 64-bit arguments.
Jan 28 2019, 3:37 AM

Jan 24 2019

samparker added a comment to D55373: [LSR] Generate formulae to enable more indexed accesses.

Hi Hal,

Jan 24 2019, 7:43 AM · Restricted Project

Jan 23 2019

samparker added a comment to D55373: [LSR] Generate formulae to enable more indexed accesses.

ping

Jan 23 2019, 2:17 AM · Restricted Project

Jan 22 2019

samparker updated the diff for D57041: [ARM][CGP] Check trunc value size before replacing.

Cheers, added some comments and removed whitespace.

Jan 22 2019, 3:17 AM
samparker updated the diff for D56719: [DAGCombine] Enable more pre-indexed stores.

Thanks for your suggestion Eli, that works for me.

Jan 22 2019, 2:59 AM
samparker created D57041: [ARM][CGP] Check trunc value size before replacing.
Jan 22 2019, 1:36 AM