Page MenuHomePhabricator

samparker (Sam Parker)
part-timer

Projects

User does not belong to any projects.

User Details

User Since
May 11 2015, 7:59 AM (410 w, 8 h)

Recent Activity

Fri, Mar 17

samparker accepted D146277: add assert to confirm input is valid for pass HardwareLoops.

Okay, thanks.

Fri, Mar 17, 3:15 AM · Restricted Project, Restricted Project

Mon, Mar 6

samparker added a comment to D141926: [WebAssembly] Add passes for GEP lowering.

Sorry for the delay in replying.

Mon, Mar 6, 8:21 AM · Restricted Project, Restricted Project

Tue, Feb 28

samparker added a comment to D142535: [DAGCombine] Fold redundant select.

Hi @asmok-g I will be leaving it reverted, I think the case I was interested in is that just generally broken :)

Tue, Feb 28, 9:48 AM · Restricted Project, Restricted Project

Thu, Feb 23

samparker added a reverting change for rGc7f9344d0f8f: [DAGCombine] Fold redundant select: rGf48d3b6f4649: Revert "[DAGCombine] Fold redundant select".
Thu, Feb 23, 10:00 AM · Restricted Project, Restricted Project
samparker added a reverting change for D142535: [DAGCombine] Fold redundant select: rGf48d3b6f4649: Revert "[DAGCombine] Fold redundant select".
Thu, Feb 23, 10:00 AM · Restricted Project, Restricted Project
samparker committed rGf48d3b6f4649: Revert "[DAGCombine] Fold redundant select" (authored by samparker).
Revert "[DAGCombine] Fold redundant select"
Thu, Feb 23, 10:00 AM · Restricted Project, Restricted Project

Wed, Feb 22

samparker added a comment to D142535: [DAGCombine] Fold redundant select.

The patch is certainly triggering on IR though, twice. I will look into it.

Wed, Feb 22, 7:00 AM · Restricted Project, Restricted Project
samparker added a comment to D142535: [DAGCombine] Fold redundant select.

Er, I can't read X86 machine code. And I also don't consider a 4K line IR file as a reduced reproducer....

Wed, Feb 22, 6:45 AM · Restricted Project, Restricted Project
samparker added a comment to D142535: [DAGCombine] Fold redundant select.

I'm preparing a reduced, verified case.

Okay, great, thanks.

Wed, Feb 22, 3:12 AM · Restricted Project, Restricted Project
samparker committed rG28ee6040710f: [WebAssembly] pmin/pmax fixes (authored by samparker).
[WebAssembly] pmin/pmax fixes
Wed, Feb 22, 2:03 AM · Restricted Project, Restricted Project
samparker closed D144466: [WebAssembly] Revert result operand ordering for pmin/pmax.
Wed, Feb 22, 2:02 AM · Restricted Project, Restricted Project

Tue, Feb 21

samparker added a comment to D141926: [WebAssembly] Add passes for GEP lowering.

Do those figures include using wasm-opt after linking?

Tue, Feb 21, 3:17 AM · Restricted Project, Restricted Project
samparker requested review of D144466: [WebAssembly] Revert result operand ordering for pmin/pmax.
Tue, Feb 21, 2:59 AM · Restricted Project, Restricted Project

Feb 15 2023

samparker committed rGc7f9344d0f8f: [DAGCombine] Fold redundant select (authored by samparker).
[DAGCombine] Fold redundant select
Feb 15 2023, 2:34 AM · Restricted Project, Restricted Project

Feb 13 2023

samparker added a comment to D140982: [HardwareLoops] NewPM support.

No worries!

Feb 13 2023, 4:58 AM · Restricted Project, Restricted Project, Restricted Project
samparker committed rG8f104a3f9ae2: [ARM] O3-pipeline fix (authored by samparker).
[ARM] O3-pipeline fix
Feb 13 2023, 3:01 AM · Restricted Project, Restricted Project
samparker committed rG2a58be423963: [HardwareLoops] NewPM support. (authored by samparker).
[HardwareLoops] NewPM support.
Feb 13 2023, 1:47 AM · Restricted Project, Restricted Project, Restricted Project
samparker closed D140982: [HardwareLoops] NewPM support.
Feb 13 2023, 1:47 AM · Restricted Project, Restricted Project, Restricted Project

Feb 10 2023

samparker added a comment to D142535: [DAGCombine] Fold redundant select.

Right, thanks. My next question was going to be whether you're building libc++ :) - thanks!

Feb 10 2023, 6:05 AM · Restricted Project, Restricted Project
samparker added a comment to D142535: [DAGCombine] Fold redundant select.

Hmmm, would you be able to send post the .ll file?

Feb 10 2023, 3:26 AM · Restricted Project, Restricted Project
samparker committed rGa674a12dd57e: [WebAssembly] Additional patterns for pmin/pax (authored by samparker).
[WebAssembly] Additional patterns for pmin/pax
Feb 10 2023, 1:55 AM · Restricted Project, Restricted Project
samparker closed D143581: [WebAssembly] Additional patterns for pmin/pax.
Feb 10 2023, 1:55 AM · Restricted Project, Restricted Project

Feb 9 2023

samparker added a comment to D142535: [DAGCombine] Fold redundant select.

Hi @bgraur Thanks for the reproducer, but I'm unable to reproduce the issue on my x64 box... What platform were you targeting? Could you please confirm that the reproducer still demonstrates the bug?

Feb 9 2023, 7:00 AM · Restricted Project, Restricted Project

Feb 8 2023

samparker requested review of D143581: [WebAssembly] Additional patterns for pmin/pax.
Feb 8 2023, 6:32 AM · Restricted Project, Restricted Project
samparker added a comment to D142535: [DAGCombine] Fold redundant select.

Okay, thanks!

Feb 8 2023, 6:26 AM · Restricted Project, Restricted Project
samparker added a comment to D142535: [DAGCombine] Fold redundant select.

Any update on that reproducer @bgraur?

Feb 8 2023, 6:07 AM · Restricted Project, Restricted Project

Feb 7 2023

samparker added a comment to D139415: [RFC][WebAssembly] Optimize GEPs.

Taking D141926 as a base, this transform brings the total code size of my local benchmarks down from 7982KB to 7970KB.

Feb 7 2023, 4:02 AM · Restricted Project, Restricted Project
samparker added a comment to D141926: [WebAssembly] Add passes for GEP lowering.

How is code size affected?

Using wasi-sdk-19, the total code size of my suite is 7985 KB. With this patch it's reduced slightly to 7982 KB.

Feb 7 2023, 3:31 AM · Restricted Project, Restricted Project
samparker committed rG7bff37783f72: [SDAG] Check fminnum/fmaxnum for non-zero operand. (authored by samparker).
[SDAG] Check fminnum/fmaxnum for non-zero operand.
Feb 7 2023, 2:55 AM · Restricted Project, Restricted Project
samparker closed D143256: [SDAG] Check fminnum for non zero operand..
Feb 7 2023, 2:55 AM · Restricted Project, Restricted Project
samparker committed rGa7de5c82bbbc: [NFC] minnum/maxnum intrinsic tests (authored by samparker).
[NFC] minnum/maxnum intrinsic tests
Feb 7 2023, 2:48 AM · Restricted Project, Restricted Project
samparker added a reverting change for rGbbdf24357932: [DAGCombine] Fold redundant select: rG91f8289ff040: Revert "[DAGCombine] Fold redundant select".
Feb 7 2023, 2:37 AM · Restricted Project, Restricted Project
samparker committed rG91f8289ff040: Revert "[DAGCombine] Fold redundant select" (authored by samparker).
Revert "[DAGCombine] Fold redundant select"
Feb 7 2023, 2:37 AM · Restricted Project, Restricted Project
samparker added a reverting change for D142535: [DAGCombine] Fold redundant select: rG91f8289ff040: Revert "[DAGCombine] Fold redundant select".
Feb 7 2023, 2:37 AM · Restricted Project, Restricted Project

Feb 6 2023

samparker updated the diff for D143256: [SDAG] Check fminnum for non zero operand..

Modified, and now using, isKnownNeverZeroFloat.

Feb 6 2023, 7:35 AM · Restricted Project, Restricted Project
samparker added inline comments to D143256: [SDAG] Check fminnum for non zero operand..
Feb 6 2023, 7:24 AM · Restricted Project, Restricted Project
samparker added inline comments to D143256: [SDAG] Check fminnum for non zero operand..
Feb 6 2023, 6:37 AM · Restricted Project, Restricted Project
samparker added a comment to D140982: [HardwareLoops] NewPM support.

Ping?

Feb 6 2023, 5:18 AM · Restricted Project, Restricted Project, Restricted Project
samparker updated the diff for D143256: [SDAG] Check fminnum for non zero operand..
  • Added check for no signed zeros.
  • Fixed up vector support.
  • Added arm tests.
Feb 6 2023, 4:13 AM · Restricted Project, Restricted Project

Feb 3 2023

samparker updated the summary of D141926: [WebAssembly] Add passes for GEP lowering.
Feb 3 2023, 7:04 AM · Restricted Project, Restricted Project
samparker updated the diff for D141926: [WebAssembly] Add passes for GEP lowering.

Hopefully the FP clamping and min/max idiom misses have now been fixed in D142093, D142481, D142535, D143106 and D143256.

Feb 3 2023, 7:01 AM · Restricted Project, Restricted Project
samparker requested review of D143256: [SDAG] Check fminnum for non zero operand..
Feb 3 2023, 2:38 AM · Restricted Project, Restricted Project

Feb 2 2023

samparker added a comment to D143106: [SDAG] fix miscompiles caused by using ValueTracking matchSelectPattern to create FMINIMUM/FMAXIMUM.

Can you preserve the match with nsz?

Feb 2 2023, 5:16 AM · Restricted Project, Restricted Project
samparker accepted D143106: [SDAG] fix miscompiles caused by using ValueTracking matchSelectPattern to create FMINIMUM/FMAXIMUM.

Thanks for doing this.

Feb 2 2023, 2:09 AM · Restricted Project, Restricted Project
samparker committed rGbbdf24357932: [DAGCombine] Fold redundant select (authored by samparker).
[DAGCombine] Fold redundant select
Feb 2 2023, 1:44 AM · Restricted Project, Restricted Project
samparker closed D142535: [DAGCombine] Fold redundant select.
Feb 2 2023, 1:43 AM · Restricted Project, Restricted Project
samparker abandoned D143056: [RFC][IR] llvm.minimum/maximum NaN propagation..
Feb 2 2023, 1:41 AM · Restricted Project, Restricted Project

Feb 1 2023

samparker added inline comments to D143056: [RFC][IR] llvm.minimum/maximum NaN propagation..
Feb 1 2023, 3:30 AM · Restricted Project, Restricted Project
samparker requested review of D143056: [RFC][IR] llvm.minimum/maximum NaN propagation..
Feb 1 2023, 2:00 AM · Restricted Project, Restricted Project

Jan 30 2023

samparker committed rG038f7debfda0: [DAGCombine] fp_to_sint isSaturatingMinMax (authored by samparker).
[DAGCombine] fp_to_sint isSaturatingMinMax
Jan 30 2023, 4:25 AM · Restricted Project, Restricted Project
samparker updated the diff for D142535: [DAGCombine] Fold redundant select.

Added SETNE as well.

Jan 30 2023, 1:39 AM · Restricted Project, Restricted Project
samparker added inline comments to D142535: [DAGCombine] Fold redundant select.
Jan 30 2023, 1:23 AM · Restricted Project, Restricted Project

Jan 27 2023

samparker added a reverting change for rG85395af27241: [DAGCombine] fp_to_sint isSaturatingMinMax: rGe60b91df1357: Revert "[DAGCombine] fp_to_sint isSaturatingMinMax".
Jan 27 2023, 7:43 AM · Restricted Project, Restricted Project
samparker committed rGe60b91df1357: Revert "[DAGCombine] fp_to_sint isSaturatingMinMax" (authored by samparker).
Revert "[DAGCombine] fp_to_sint isSaturatingMinMax"
Jan 27 2023, 7:43 AM · Restricted Project, Restricted Project
samparker added a reverting change for D142481: [DAGCombine] fp_to_sint isSaturatingMinMax: rGe60b91df1357: Revert "[DAGCombine] fp_to_sint isSaturatingMinMax".
Jan 27 2023, 7:43 AM · Restricted Project, Restricted Project
samparker added a comment to D142481: [DAGCombine] fp_to_sint isSaturatingMinMax.

Thanks for the reproducer, I'll revert for now.

Jan 27 2023, 7:30 AM · Restricted Project, Restricted Project

Jan 26 2023

samparker committed rG79649eacbc11: [WebAssembly] Trying to fix expensive buildbot (authored by samparker).
[WebAssembly] Trying to fix expensive buildbot
Jan 26 2023, 6:31 AM · Restricted Project, Restricted Project
samparker committed rG85395af27241: [DAGCombine] fp_to_sint isSaturatingMinMax (authored by samparker).
[DAGCombine] fp_to_sint isSaturatingMinMax
Jan 26 2023, 4:46 AM · Restricted Project, Restricted Project
samparker closed D142481: [DAGCombine] fp_to_sint isSaturatingMinMax.
Jan 26 2023, 4:46 AM · Restricted Project, Restricted Project
samparker committed rG41080b2fdd4b: [NFC][WebAssembly] Updated tests (authored by samparker).
[NFC][WebAssembly] Updated tests
Jan 26 2023, 2:30 AM · Restricted Project, Restricted Project
samparker updated the diff for D142535: [DAGCombine] Fold redundant select.

Added setugt and setult support.

Jan 26 2023, 1:31 AM · Restricted Project, Restricted Project

Jan 25 2023

samparker added a reviewer for D142535: [DAGCombine] Fold redundant select: dmgreen.
Jan 25 2023, 8:24 AM · Restricted Project, Restricted Project
samparker updated the diff for D142535: [DAGCombine] Fold redundant select.

Added support for checking against SETLT and SETGT nodes too. X86 and Arm test changes look rather noisey...

Jan 25 2023, 8:10 AM · Restricted Project, Restricted Project
samparker added a reviewer for D142535: [DAGCombine] Fold redundant select: sbc100.
Jan 25 2023, 6:11 AM · Restricted Project, Restricted Project
samparker requested review of D142535: [DAGCombine] Fold redundant select.
Jan 25 2023, 6:09 AM · Restricted Project, Restricted Project
samparker committed rG430bdb121571: [NFC][WebAssembly] More fpclamptosat tests (authored by samparker).
[NFC][WebAssembly] More fpclamptosat tests
Jan 25 2023, 2:25 AM · Restricted Project, Restricted Project
samparker updated the diff for D142481: [DAGCombine] fp_to_sint isSaturatingMinMax.

Thanks, extracted the bitwidth calculation into APFloatBase.

Jan 25 2023, 1:33 AM · Restricted Project, Restricted Project

Jan 24 2023

samparker requested review of D142481: [DAGCombine] fp_to_sint isSaturatingMinMax.
Jan 24 2023, 8:44 AM · Restricted Project, Restricted Project
samparker committed rGb1b7fb6f20b0: [InstCombine] trunc (fptoui|fptosi) (authored by samparker).
[InstCombine] trunc (fptoui|fptosi)
Jan 24 2023, 1:16 AM · Restricted Project, Restricted Project
samparker closed D142093: [InstCombine] trunc (fptoui|fptosi).
Jan 24 2023, 1:16 AM · Restricted Project, Restricted Project

Jan 23 2023

samparker updated the diff for D142093: [InstCombine] trunc (fptoui|fptosi).

Rebased and added comment.

Jan 23 2023, 6:20 AM · Restricted Project, Restricted Project
samparker committed rG6dc8e215dbba: [NFC][Instcombine] More trunc fp-to-int tests. (authored by samparker).
[NFC][Instcombine] More trunc fp-to-int tests.
Jan 23 2023, 6:11 AM · Restricted Project, Restricted Project
samparker updated the diff for D142093: [InstCombine] trunc (fptoui|fptosi).

Avoiding integer comparison warning.

Jan 23 2023, 5:46 AM · Restricted Project, Restricted Project
samparker updated the diff for D142093: [InstCombine] trunc (fptoui|fptosi).

Using semanticsMaxExponent, so hopefully correct now...

Jan 23 2023, 5:03 AM · Restricted Project, Restricted Project

Jan 20 2023

samparker updated the diff for D142093: [InstCombine] trunc (fptoui|fptosi).

Removed non-poison input restriction for fptosi.

Jan 20 2023, 7:18 AM · Restricted Project, Restricted Project
samparker added a comment to D142093: [InstCombine] trunc (fptoui|fptosi).

If you want to add some more, the initial set is in: https://github.com/llvm/llvm-project/commit/714286f9e641209411609deaf80dd865aa2198c5

Jan 20 2023, 5:18 AM · Restricted Project, Restricted Project
samparker committed rG714286f9e641: [NFC] Precommit tests (authored by samparker).
[NFC] Precommit tests
Jan 20 2023, 5:18 AM · Restricted Project, Restricted Project
samparker added a comment to D142093: [InstCombine] trunc (fptoui|fptosi).

Okay, great. Thanks for clarification on both fronts. I'm just about to commit some tests.

Jan 20 2023, 5:15 AM · Restricted Project, Restricted Project
samparker added inline comments to D142093: [InstCombine] trunc (fptoui|fptosi).
Jan 20 2023, 4:14 AM · Restricted Project, Restricted Project
samparker added a comment to D142093: [InstCombine] trunc (fptoui|fptosi).

it should be sufficient to have the intermediate integer width be one more than the minimum required type width, so "%i = fptoui half %x to i17".

Jan 20 2023, 3:22 AM · Restricted Project, Restricted Project

Jan 19 2023

samparker added inline comments to D142093: [InstCombine] trunc (fptoui|fptosi).
Jan 19 2023, 3:33 AM · Restricted Project, Restricted Project
samparker updated the diff for D142093: [InstCombine] trunc (fptoui|fptosi).

Now only checking for poison/undef for the signed case.

Jan 19 2023, 3:09 AM · Restricted Project, Restricted Project
samparker requested review of D142093: [InstCombine] trunc (fptoui|fptosi).
Jan 19 2023, 2:03 AM · Restricted Project, Restricted Project

Jan 18 2023

samparker committed rG32af26744749: [NFC][WebAssembly] Add tests (authored by samparker).
[NFC][WebAssembly] Add tests
Jan 18 2023, 5:38 AM · Restricted Project, Restricted Project

Jan 17 2023

samparker added inline comments to D141926: [WebAssembly] Add passes for GEP lowering.
Jan 17 2023, 8:46 AM · Restricted Project, Restricted Project
samparker added inline comments to D141926: [WebAssembly] Add passes for GEP lowering.
Jan 17 2023, 7:54 AM · Restricted Project, Restricted Project
samparker updated the summary of D141926: [WebAssembly] Add passes for GEP lowering.
Jan 17 2023, 6:01 AM · Restricted Project, Restricted Project
samparker requested review of D141926: [WebAssembly] Add passes for GEP lowering.
Jan 17 2023, 6:00 AM · Restricted Project, Restricted Project
samparker committed rGbba9221d9ffe: [NFC][WebAssembly] Update test (authored by samparker).
[NFC][WebAssembly] Update test
Jan 17 2023, 2:41 AM · Restricted Project, Restricted Project

Jan 12 2023

samparker updated the diff for D140982: [HardwareLoops] NewPM support.

Added extra preserved analyses, though omitting MemorySSA for now.

Jan 12 2023, 9:47 PM · Restricted Project, Restricted Project, Restricted Project
samparker added inline comments to D140982: [HardwareLoops] NewPM support.
Jan 12 2023, 9:15 PM · Restricted Project, Restricted Project, Restricted Project
samparker abandoned D86346: [SimplifyCFG] Accumulate cost against budget.
Jan 12 2023, 9:04 PM · Restricted Project, Restricted Project
samparker abandoned D86347: [SimplifyCFG] Two entry phi select costs.
Jan 12 2023, 9:04 PM · Restricted Project, Restricted Project
samparker added inline comments to D140982: [HardwareLoops] NewPM support.
Jan 12 2023, 2:01 AM · Restricted Project, Restricted Project, Restricted Project

Jan 4 2023

samparker requested review of D140982: [HardwareLoops] NewPM support.
Jan 4 2023, 6:29 AM · Restricted Project, Restricted Project, Restricted Project

Jan 3 2023

samparker committed rG615333bc09c4: [TypePromotion] NewPM support. (authored by samparker).
[TypePromotion] NewPM support.
Jan 3 2023, 7:13 AM · Restricted Project, Restricted Project
samparker closed D140893: [TypePromotion] NewPM support..
Jan 3 2023, 7:12 AM · Restricted Project, Restricted Project
samparker added a comment to D140893: [TypePromotion] NewPM support..

Thanks for the quick review! I will be porting hardware-loops and mve-tail-predication as well.

Jan 3 2023, 7:10 AM · Restricted Project, Restricted Project
samparker committed rGd1390aa04508: [NFC] Formatting (authored by samparker).
[NFC] Formatting
Jan 3 2023, 7:08 AM · Restricted Project, Restricted Project
samparker updated the diff for D140893: [TypePromotion] NewPM support..

Fixed typo.

Jan 3 2023, 6:43 AM · Restricted Project, Restricted Project