Page MenuHomePhabricator

uweigand (Ulrich Weigand)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 14 2013, 11:48 AM (480 w, 4 d)

Recent Activity

Yesterday

uweigand accepted D128910: [SystemZ] Add support for tune-cpu attribute.

LGTM, thanks!

Thu, Jun 30, 7:58 AM · Restricted Project, Restricted Project

Wed, Jun 29

uweigand closed D128819: Enable ccache for s390x builders.
Wed, Jun 29, 10:56 AM · Restricted Project
uweigand committed rZORG343fe274e86e: Enable ccache for s390x builders (authored by uweigand).
Enable ccache for s390x builders
Wed, Jun 29, 10:56 AM · Restricted Project
uweigand requested review of D128819: Enable ccache for s390x builders.
Wed, Jun 29, 6:38 AM · Restricted Project

Mon, Jun 13

uweigand added inline comments to D127645: [docs] Adding table of object file formats.
Mon, Jun 13, 2:02 PM · Restricted Project, Restricted Project

Sun, Jun 12

uweigand committed rG7095a1ff82b9: Fix endian conversion of sub-byte types (authored by uweigand).
Fix endian conversion of sub-byte types
Sun, Jun 12, 7:09 AM · Restricted Project, Restricted Project
uweigand closed D125676: [mlir] Fix endian conversion of sub-byte types.
Sun, Jun 12, 7:08 AM · Restricted Project, Restricted Project

Fri, Jun 10

uweigand accepted D127498: [SystemZ/z/OS] Set DWARF version to 4 for z/OS..

LGTM

Fri, Jun 10, 8:51 AM · Restricted Project, Restricted Project
uweigand added a comment to D125676: [mlir] Fix endian conversion of sub-byte types.

Does this also show with an i4 test case? (i1 is special in a few ways, so having other sub CHAR_BIT test case would be good)

Fri, Jun 10, 8:49 AM · Restricted Project, Restricted Project
uweigand updated the diff for D125676: [mlir] Fix endian conversion of sub-byte types.

Add test case.

Fri, Jun 10, 8:48 AM · Restricted Project, Restricted Project
uweigand updated subscribers of D127328: [Systemz/z/OS] Introduce CCAssignToRegAndStack to calling convention.

FYI @nemanjai

Fri, Jun 10, 5:39 AM · Restricted Project, Restricted Project
uweigand updated subscribers of D127328: [Systemz/z/OS] Introduce CCAssignToRegAndStack to calling convention.

From a SystemZ perspective this looks good to me (and a clear readability enhancement). I'd still like to hear comments from other backend maintainers whether this common tablegen feature might be useful to them as well ...

Fri, Jun 10, 5:37 AM · Restricted Project, Restricted Project
uweigand added a comment to D127254: [SelectionDAGISel] Chain any mayRaiseFPException instruction created from a strict FP node.

From a SystemZ perspective this looks good to me.

Fri, Jun 10, 5:30 AM · Restricted Project, Restricted Project
uweigand added inline comments to D77804: [DAG] Enable ISD::SRL SimplifyMultipleUseDemandedBits handling inside SimplifyDemandedBits (WIP).
Fri, Jun 10, 5:23 AM · Restricted Project, Restricted Project

Thu, Jun 9

uweigand accepted D127412: [Systemz/z/OS] Add llvm.read_register() intrinsic support for zOS.

LGTM.

Thu, Jun 9, 9:15 AM · Restricted Project, Restricted Project

Wed, Jun 8

uweigand accepted D126900: [SystemZ] Fix check for zero size when lowering memcmp..

LGTM, thanks!

Wed, Jun 8, 7:24 AM · Restricted Project, Restricted Project

Tue, Jun 7

uweigand added a comment to D125676: [mlir] Fix endian conversion of sub-byte types.

Ping? The mlir build bot on s390x is still red because of this problem.

Tue, Jun 7, 6:32 AM · Restricted Project, Restricted Project

May 22 2022

uweigand accepted D125982: [SystemZ] Bugfix for symbolic displacments..

LGTM, thanks!

May 22 2022, 7:22 AM · Restricted Project, Restricted Project

May 18 2022

uweigand accepted D125881: [SystemZ] Bugfix in SystemZTargetLowering::combineINT_TO_FP().

LGTM, thanks!

May 18 2022, 6:40 AM · Restricted Project, Restricted Project

May 17 2022

uweigand accepted D115406: [SystemZ] Improve eliminateFrameIndex() to use STDY/STEY/LDY for VR32/VR64 when possible..

LGTM, thanks!

May 17 2022, 8:59 AM · Restricted Project, Restricted Project
uweigand accepted D125725: [SystemZ][z/OS] Add PPA1 support.

LGTM, thanks!

May 17 2022, 3:15 AM · Restricted Project, Restricted Project

May 16 2022

uweigand requested review of D125676: [mlir] Fix endian conversion of sub-byte types.
May 16 2022, 3:05 AM · Restricted Project, Restricted Project

May 15 2022

uweigand added a comment to D125607: [DAG] Fold (shl (srl x, c), c) -> and(x, m) even if srl has other uses.

SystemZ part LGTM.

May 15 2022, 5:17 AM · Restricted Project, Restricted Project

May 13 2022

uweigand added a comment to D124839: [DAG] Enable ISD::SHL SimplifyMultipleUseDemandedBits handling inside SimplifyDemandedBits.

SystemZ changes LGTM.

May 13 2022, 6:29 AM · Restricted Project, Restricted Project

May 11 2022

uweigand added a comment to D122925: [mlir] Fix printer when it is a DenseElementsAttr of i1.

Indeed, the following patch fixes the problem for me:

diff --git a/mlir/lib/IR/BuiltinAttributes.cpp b/mlir/lib/IR/BuiltinAttributes.cpp
index 0004fe90fe87..d887fafc2059 100644
--- a/mlir/lib/IR/BuiltinAttributes.cpp
+++ b/mlir/lib/IR/BuiltinAttributes.cpp
@@ -1157,8 +1157,11 @@ void DenseIntOrFPElementsAttr::convertEndianOfArrayRefForBEmachine(
   size_t elementBitWidth = getDenseElementStorageWidth(elementType);
   assert(numElements * elementBitWidth == inRawData.size() * CHAR_BIT &&
          inRawData.size() <= outRawData.size());
-  convertEndianOfCharForBEmachine(inRawData.begin(), outRawData.begin(),
-                                  elementBitWidth, numElements);
+  if (elementBitWidth <= CHAR_BIT)
+    std::memcpy(outRawData.begin(), inRawData.begin(), inRawData.size());
+  else
+    convertEndianOfCharForBEmachine(inRawData.begin(), outRawData.begin(),
+                                    elementBitWidth, numElements);
 }
May 11 2022, 6:26 AM · Restricted Project, Restricted Project
uweigand added a comment to D122925: [mlir] Fix printer when it is a DenseElementsAttr of i1.

It seems the value after const folding is wrong, it should be dense<"0xFF000000FF000000FF000000FF000000FF000000">, not a splat const dense<false>.

May 11 2022, 5:08 AM · Restricted Project, Restricted Project

May 9 2022

uweigand accepted D125230: [SystemZ] Fix argument type of tdc instruction..

LGTM, thanks!

May 9 2022, 8:03 AM · Restricted Project, Restricted Project

May 6 2022

uweigand added a comment to D122925: [mlir] Fix printer when it is a DenseElementsAttr of i1.

Looks like this new test case fails on s390x, causing the build bot to go red:
https://lab.llvm.org/buildbot/#/builders/199/builds/5139

May 6 2022, 7:13 AM · Restricted Project, Restricted Project
uweigand accepted D125044: [SystemZ] [z/OS] Use assignCalleeSavedSpillSlots() to mark handle special registers in CSR list instead of determineCalleeSaves.

LGTM, thanks!

May 6 2022, 2:25 AM · Restricted Project, Restricted Project

May 5 2022

uweigand added a comment to D124696: [SelectionDAG] Constant fold (sext_inreg undef, VT) to 0 instead of undef..

SystemZ test change LGTM, thanks!

May 5 2022, 12:02 AM · Restricted Project, Restricted Project

May 4 2022

uweigand committed rG71672375fe91: [libunwind][SystemZ] Unwind out of signal handlers (authored by uweigand).
[libunwind][SystemZ] Unwind out of signal handlers
May 4 2022, 1:45 AM · Restricted Project
uweigand closed D124765: [libunwind][SystemZ] Unwind out of signal handlers.
May 4 2022, 1:45 AM · Restricted Project, Restricted Project, Restricted Project

May 3 2022

uweigand updated the diff for D124765: [libunwind][SystemZ] Unwind out of signal handlers.

Address review comments.

May 3 2022, 12:37 AM · Restricted Project, Restricted Project, Restricted Project
uweigand added inline comments to D124765: [libunwind][SystemZ] Unwind out of signal handlers.
May 3 2022, 12:36 AM · Restricted Project, Restricted Project, Restricted Project

May 2 2022

uweigand accepted D124780: [SystemZ] Accept (. - 0x100000000) PCRel32 constants.

LGTM, thanks!

May 2 2022, 10:12 AM · Restricted Project, Restricted Project
uweigand added a comment to D124765: [libunwind][SystemZ] Unwind out of signal handlers.

some tests from libcxxabi could be enabled for SystemZ too e.g. libcxxabi/test/forced*

May 2 2022, 6:43 AM · Restricted Project, Restricted Project, Restricted Project
uweigand updated the diff for D124765: [libunwind][SystemZ] Unwind out of signal handlers.

Address review comment.

May 2 2022, 6:40 AM · Restricted Project, Restricted Project, Restricted Project
uweigand requested review of D124765: [libunwind][SystemZ] Unwind out of signal handlers.
May 2 2022, 5:46 AM · Restricted Project, Restricted Project, Restricted Project
uweigand committed rG364c5023d2ce: [libunwind] Add SystemZ support (authored by uweigand).
[libunwind] Add SystemZ support
May 2 2022, 5:38 AM · Restricted Project
uweigand closed D124248: [libunwind] Add SystemZ support.
May 2 2022, 5:38 AM · Restricted Project, Restricted Project, Restricted Project
uweigand added a comment to D124212: [sanitizer] Use canonical syscalls everywhere.

LGTM for SystemZ.

May 2 2022, 5:02 AM · Restricted Project, Restricted Project
uweigand updated subscribers of D124696: [SelectionDAG] Constant fold (sext_inreg undef, VT) to 0 instead of undef..

Not sure if the SystemZ test is still testing the same thing it was before.

May 2 2022, 3:28 AM · Restricted Project, Restricted Project
uweigand accepted D122105: [SystemZ] Patchset for expanding memcpy/memset using at most 2 stores..

This version LGTM, assuming the performance results are good. Thanks!

May 2 2022, 2:57 AM · Restricted Project, Restricted Project

Apr 29 2022

uweigand updated the diff for D124248: [libunwind] Add SystemZ support.

Address coding style comment.

Apr 29 2022, 8:56 AM · Restricted Project, Restricted Project, Restricted Project
uweigand added a comment to D122105: [SystemZ] Patchset for expanding memcpy/memset using at most 2 stores..

Looks good to me in principle, just a couple suggestions for refactoring inline. Before committing this, we should confirm the performance impact.

Apr 29 2022, 6:08 AM · Restricted Project, Restricted Project

Apr 28 2022

uweigand added a comment to D124212: [sanitizer] Use canonical syscalls everywhere.

Thanks. Ulrich, could you help me with the s390 failures? I can reland with a #define SANITIZER_USES_CANONICAL_LINUX_SYSCALLS !SANITIZER_S390 for now, but it would be great to remove the non-canonical code path completely.

Apr 28 2022, 9:46 AM · Restricted Project, Restricted Project

Apr 26 2022

uweigand added inline comments to D122421: [z/OS] Clean up some z/OS testcases..
Apr 26 2022, 6:59 AM · Restricted Project, Restricted Project
uweigand accepted D122388: [SystemZ] Fix C++ ABI for passing args of structs containing zero width bitfield..

Not yet sure about what diagnostic should be emitted and when.

Apr 26 2022, 6:52 AM · Restricted Project, Restricted Project

Apr 25 2022

uweigand added a comment to D124212: [sanitizer] Use canonical syscalls everywhere.

This seems to have broken the s390x build bots, there are now >500 failing sanitizer test cases:
https://lab.llvm.org/buildbot/#/builders/94/builds/8761

Apr 25 2022, 7:33 AM · Restricted Project, Restricted Project

Apr 22 2022

uweigand requested review of D124248: [libunwind] Add SystemZ support.
Apr 22 2022, 4:35 AM · Restricted Project, Restricted Project, Restricted Project

Apr 21 2022

uweigand committed rG9778ec057cf4: [SystemZ] Add z16 scheduler description (authored by uweigand).
[SystemZ] Add z16 scheduler description
Apr 21 2022, 11:39 AM · Restricted Project, Restricted Project
uweigand committed rG1283ccb610fe: Support z16 processor name (authored by uweigand).
Support z16 processor name
Apr 21 2022, 10:59 AM · Restricted Project, Restricted Project, Restricted Project
uweigand committed rGe4085a012c04: [sanitizer] Fix prctl unit test on non-SMT systems (authored by uweigand).
[sanitizer] Fix prctl unit test on non-SMT systems
Apr 21 2022, 10:32 AM · Restricted Project, Restricted Project

Apr 19 2022

uweigand accepted D110267: [InlineAsm, SystemZ] Handle inline assembly address operands..

LGTM, thanks!

Apr 19 2022, 7:25 AM · Restricted Project, Restricted Project, Restricted Project

Apr 14 2022

uweigand added a comment to D123627: Correctly diagnose prototype redeclaration errors in C.

Thank you for letting me know -- I've speculatively fixed the issue in 726901d06aab2f92d684d28507711308368c29d6

Apr 14 2022, 12:31 PM · Restricted Project, Restricted Project
uweigand added a comment to D123627: Correctly diagnose prototype redeclaration errors in C.

It looks like this caused the LNT build bot to fail (at least on s390x), because one of the test cases now triggers this error:
https://lab.llvm.org/buildbot/#/builders/45/builds/6787

Apr 14 2022, 3:20 AM · Restricted Project, Restricted Project

Apr 13 2022

uweigand accepted D121341: [SystemZ] implement adjustInliningThreshold().

See inline comment. Otherwise LGTM. Thanks!

Apr 13 2022, 4:56 AM · Restricted Project, Restricted Project

Apr 12 2022

uweigand added a comment to D122220: [InlineAsm] Add support for address operands ("p")..

The SystemZ parts LGTM as well. Thanks!

Apr 12 2022, 9:01 AM · Restricted Project, Restricted Project, Restricted Project

Apr 11 2022

uweigand committed rGf018a5f6e0d1: [compiler-rt][SystemZ] Skip fuzzer/coverage.test (authored by uweigand).
[compiler-rt][SystemZ] Skip fuzzer/coverage.test
Apr 11 2022, 7:18 AM · Restricted Project, Restricted Project

Mar 10 2022

uweigand added inline comments to D121341: [SystemZ] implement adjustInliningThreshold().
Mar 10 2022, 4:27 AM · Restricted Project, Restricted Project

Mar 9 2022

uweigand accepted D121341: [SystemZ] implement adjustInliningThreshold().

LGTM, thanks!

Mar 9 2022, 2:25 PM · Restricted Project, Restricted Project
uweigand added a comment to D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.

The test is failing on s390x as well:

Mar 9 2022, 9:39 AM · Restricted Project, Restricted Project

Mar 4 2022

Herald added a project to D120531: [SystemZ] Use VREP for storing replicated regs/immediates.: Restricted Project.

I agree that this looks like the right thing to do. However, this really should use the SystemZVectorConstantInfo mechanism. (You'll probably have to add an APInt constructor there in addition to the APFloat one - currently this is only used for floating-point and vector constants, but now we also need it for integer constants. But that should be straightforward.)

Mar 4 2022, 5:06 AM · Restricted Project, Restricted Project

Feb 25 2022

uweigand added a comment to D120472: [sanitizer_common] Enable trace pc guard coverage test on PPC64/s390x/MIPS.

So it seems it doesn't even recognize the .sancov files as coverage files. Not sure if they were written incorrectly or if this is a problem on the reader side ...

Feb 25 2022, 7:39 AM · Restricted Project
uweigand added a comment to D120472: [sanitizer_common] Enable trace pc guard coverage test on PPC64/s390x/MIPS.

There is already a fix,

In any case, I think this should remain XFAILed until the underlying problem is fixed, so get the CI green again.

There is already a fix, https://reviews.llvm.org/D120541

do you think it is OK ? I will commit it if you accept it.

Feb 25 2022, 4:56 AM · Restricted Project
uweigand accepted D120541: [sanitizer] Disable pc guard coverage test on PPC64/s390x.

LGTM, thanks!

Feb 25 2022, 4:56 AM · Restricted Project
uweigand added a comment to D120472: [sanitizer_common] Enable trace pc guard coverage test on PPC64/s390x/MIPS.

In any case, I think this should remain XFAILed until the underlying problem is fixed, so get the CI green again.

Feb 25 2022, 4:29 AM · Restricted Project
uweigand added a comment to D120472: [sanitizer_common] Enable trace pc guard coverage test on PPC64/s390x/MIPS.

@uweigand @ro
I found the following logs, the test failure might caused by none __sanitizer_cov* functions on s390x.

sanitizer_coverage_trace_pc_guard-dso.cpp:71:18: error: CHECK-SANCOV: expected string not found in input
// CHECK-SANCOV: Ignoring {{.*}}_1.so and its coverage because __sanitizer_cov* functions were not found.
Feb 25 2022, 4:28 AM · Restricted Project
uweigand added a comment to D120472: [sanitizer_common] Enable trace pc guard coverage test on PPC64/s390x/MIPS.

These test now all seem to fail on s390x:
https://lab.llvm.org/buildbot/#/builders/94/builds/7962

Feb 25 2022, 1:26 AM · Restricted Project

Feb 24 2022

uweigand added inline comments to D120094: [CallingConv] Generate isCCArgumentReg() predicate via tablegen.
Feb 24 2022, 2:24 AM · Restricted Project, Restricted Project
uweigand accepted D120450: [SystemZ] [z/OS] Add support for generating huge (1 MiB) stack frames in XPLINK64.

LGTM, thanks!

Feb 24 2022, 2:23 AM · Restricted Project

Feb 23 2022

uweigand accepted D120432: [sanitizer][sancov] Use pc-1 for s390x.

See inline comment. Otherwise LGTM. Thanks for the quick fix.

Feb 23 2022, 12:54 PM · Restricted Project, Restricted Project
uweigand added a comment to D120362: [sanitizer][sancov] Refactor GetNextInstructionPc/GetPreviousInstructionPc.

This seems to have caused build bot failures on s390x: https://lab.llvm.org/buildbot/#/builders/94/builds/7935.

Feb 23 2022, 12:30 PM · Restricted Project, Restricted Project
uweigand added inline comments to D120094: [CallingConv] Generate isCCArgumentReg() predicate via tablegen.
Feb 23 2022, 2:19 AM · Restricted Project, Restricted Project

Feb 22 2022

uweigand added inline comments to D120094: [CallingConv] Generate isCCArgumentReg() predicate via tablegen.
Feb 22 2022, 1:42 AM · Restricted Project, Restricted Project

Feb 21 2022

uweigand accepted D120148: [SystemZ/z/OS] Add va intrinsics for XPLINK.

LGTM, thanks!

Feb 21 2022, 3:13 AM · Restricted Project

Feb 18 2022

uweigand added a comment to D120094: [CallingConv] Generate isCCArgumentReg() predicate via tablegen.

This seems to add a large amount of code that may duplicate information already available elsewhere. It's hard to say, in particular because I don't quite understand the exact semantics of the new isCallingConvReg. For what registers exactly should this return true? Those that may hold (part of) an argument or return value? Those that hold some platform-specific value like a GOT pointer? Those that may be clobbered by the call?

Feb 18 2022, 4:57 AM · Restricted Project, Restricted Project

Feb 16 2022

uweigand added a comment to D64746: Add constrained intrinsics for lrint and lround.

This matches my understanding. (Though I must admit I'm not 100% confident I fully understand the precise distinction between "undefined behavior", a poison value, and an undef value ... It's certainly one of those :-) But from my reading of the IR reference, "poison" does indeed look correct here.)

OK, thank you!
It's poison. UB would be too strong. I've put on my todo list to fix LangRef as well.

Feb 16 2022, 1:48 AM · Restricted Project

Feb 15 2022

uweigand accepted D119868: [SystemZ][z/OS] Fix f32 variadic argument assertion.

LGTM, thanks!

Feb 15 2022, 12:29 PM · Restricted Project
uweigand added a comment to D64746: Add constrained intrinsics for lrint and lround.

I believe the quoted statement above is both correct and also identical to the semantics of the rounding mode argument of all other constrained intrinsics. For all of them, the rounding mode argument is a promise by the user to the compiler, not an instruction to the compiler to change anything about the rounding mode. All of these operations will actually use the current default rounding mode, but the presence of a constrained rounding mode argument is an implicit promise by the user to the compiler that the current rounding mode has been set up in a particular way, and the compiler (e.g. for optimization purposes) may rely on that promise.

Thank you.
Can I read what you wrote as "if the rounding mode argument is not !dynamic and if it differs from the run-time rounding mode, the intrinsic returns poison"?

Essentially you want to allow the compiler to use the given rounding mode for optimizations, but still be able to lower the intrinsic to a single libcall that will use the run-time rounding mode, not the one given as argument.

Feb 15 2022, 12:28 PM · Restricted Project
uweigand added a comment to D64746: Add constrained intrinsics for lrint and lround.

Hi,

The semantics described by patch for lrint regarding the rounding mode is a bit peculiar and different from all the other constrained FP instrinsics.
It says:

The rounding mode is described, not determined, by the rounding mode argument. The actual rounding mode is determined by the runtime floating-point environment. The rounding mode argument is only intended as information to the compiler.

So does this means that the only accepted rounding mode is !dynamic? Why is lrint different from the remaining intrinsics?

I was trying to implement the semantics of lrint in Alive2 and came across this discrepancy.

Thanks!

Feb 15 2022, 11:06 AM · Restricted Project

Feb 14 2022

uweigand accepted D119732: [SystemZ/z/OS] Add XPLINK dynamic stack allocation.

LGTM, thanks!

Feb 14 2022, 9:24 AM · Restricted Project
uweigand accepted D119557: [Systemz/z/OS] Centralize emitting the call type information.

See inline comment. Otherwise this LGTM.

Feb 14 2022, 5:49 AM · Restricted Project

Feb 11 2022

uweigand accepted D119437: [SystemZ/z/OS] Add alias for XPLINK return.

LGTM, thanks!

Feb 11 2022, 6:24 AM · Restricted Project

Jan 27 2022

uweigand accepted D117927: [SystemZ] Don't shrink FP constants.

LGTM, thanks!

Jan 27 2022, 11:53 AM · Restricted Project
uweigand accepted D115690: [SystemZ] Implement orderFrameObjects()..

LGTM, thanks!

Jan 27 2022, 11:52 AM · Restricted Project

Jan 24 2022

uweigand added inline comments to D117927: [SystemZ] Don't shrink FP constants.
Jan 24 2022, 5:02 AM · Restricted Project
uweigand added a comment to D115690: [SystemZ] Implement orderFrameObjects()..

Agreed that this version looks much more reasonable. A few remaining comments inline.

Jan 24 2022, 4:57 AM · Restricted Project

Jan 21 2022

uweigand accepted D117823: [SystemZ] Properly register machine passes..
Jan 21 2022, 2:12 AM · Restricted Project

Jan 20 2022

uweigand accepted D117823: [SystemZ] Properly register machine passes..

LGTM, thanks!

Jan 20 2022, 11:35 AM · Restricted Project

Dec 16 2021

uweigand accepted D115269: [SystemZ][z/OS] Add entry point marker to PPA.

LGTM.

Dec 16 2021, 7:31 AM · Restricted Project

Dec 15 2021

uweigand added a comment to D114457: [z/OS] Implement prologue and epilogue generation for z/OS target..

LGTM, please commit again.

Dec 15 2021, 10:02 AM · Restricted Project
uweigand added inline comments to D114457: [z/OS] Implement prologue and epilogue generation for z/OS target..
Dec 15 2021, 12:08 AM · Restricted Project

Dec 9 2021

uweigand accepted D115269: [SystemZ][z/OS] Add entry point marker to PPA.

LGTM, but should be merged after https://reviews.llvm.org/D114457 (see inline comment).

Dec 9 2021, 9:35 AM · Restricted Project

Dec 8 2021

uweigand accepted D114457: [z/OS] Implement prologue and epilogue generation for z/OS target..

LGTM.

Dec 8 2021, 3:00 AM · Restricted Project

Dec 7 2021

uweigand added inline comments to D114457: [z/OS] Implement prologue and epilogue generation for z/OS target..
Dec 7 2021, 10:48 AM · Restricted Project
uweigand added a comment to D114457: [z/OS] Implement prologue and epilogue generation for z/OS target..

Well, thinking about all this I guess the best way forward is:

  • not using the LocalAreaOffset, because it has a different semantic
  • get rid of getAllocatedStackSize()
  • use "incoming SP + stackbias" as base for all stack offset calculations, because that is more obvious
Dec 7 2021, 3:19 AM · Restricted Project
uweigand added a comment to D114194: [SystemZ] Add range checks for PC-relative fixups.

One final comment inline, otherwise this LGTM. Thanks!

Dec 7 2021, 12:56 AM · Restricted Project

Dec 6 2021

uweigand added a comment to D114457: [z/OS] Implement prologue and epilogue generation for z/OS target..

Pulling out the getFrameIndexReference discussion into the main comments.

Dec 6 2021, 6:33 AM · Restricted Project
uweigand accepted D114695: [SystemZ] Custom lowering of llvm.is_fpclass.

LGTM, thanks!

Dec 6 2021, 3:47 AM · Restricted Project, Restricted Project