- User Since
- Aug 28 2018, 7:55 AM (265 w, 6 d)
May 25 2023
May 21 2023
May 3 2023
Apr 25 2023
Please wait couple days in case @RKSimon has some more comments/concerns
Apr 21 2023
This change is caused https://github.com/llvm/llvm-project/issues/62286
Or simply exhibited existing problem in BUILD_VECTOR lowering on X86
Apr 18 2023
Would be nice to have few dedicated tests. All existing test changes are noisy
Feb 8 2023
Jan 25 2023
Jan 20 2023
I'll wait for a few days before landing it to let other reviewers speak up.
LGTM after assertion fix.
I'll take care of landing
Jan 18 2023
Please make a separate NFC review with GCStrategy changes. Besides being common llvm review practice it will allow downstream projects to handle this API change without breakage.
With separate reviews/commit we will have time to update our downstream strategies before RS4GC starts using new API.
If they come in single commit, it will immediately break all existing RS4GC users.
Jan 17 2023
@znix : I suggest you to remove GCStrategy cache from this patch (and use llvm::getGCStrategy() instead where necessary). I think it will unblock review.
We can figure out caching later/separately.
Jan 13 2023
I think yes. Even though Legacy PM is deprecated, supporting it is just several extra lines.
Jan 12 2023
Added couple folks who should be interested in this stuff :-)
Jan 9 2023
BTW, there is no need to create new revision to reflect trunk changes. You could simply rebase your local branch and then update diffs for the existing review. This works well and is common practice.
Jan 3 2023
Jan 2 2023
Dec 30 2022
OK, go ahead.
Dec 27 2022
Dec 26 2022
LGTM, but clean test up before committing.
Dec 22 2022
Tried your patch together with my old uncommitted change which utilizes GCStrategy in IR Verifier and it works fine now. So LGTM.
Please wait few days for other reviewers to have a chance to comment.
Dec 21 2022
Address review comments (fix typos).
Dec 13 2022
Address review comments.
Also include changes for pre-committed tests
I like it more that original fix, but I don't feel qualified to review :-)
Would be great if @qcolombet can have a look..
Rebase on tip after D138910 has been landed.
Dec 12 2022
Get rid of temporary ChainToBase vector as suggested in review.
Dec 9 2022
Rebase on tip
Nov 29 2022
Oct 21 2022
(We perhaps should have removed RegA completely from MRI, LiveVariables etc, but I did not find interface for this. Are Registers append-only?)
Sep 6 2022
I did a quick testing downstream (on X86) and did not encounter any issues. Looks good to me.
Aug 29 2022
Aug 23 2022
Aug 22 2022
Rebase on top of relanded test.
Added TODO about recomputation of live range/liveness instead of bailing out.
Aug 19 2022
Rebase on top of precommitted test
Aug 8 2022
Aug 5 2022
Jul 7 2022
Jun 20 2022
In general looks OK to me (modulo few style nits).
But I'm not an ISEL type legalization expert. Would be nice to have LGTM from someone else as well.
Jun 16 2022
Idea is being able to push something like these though upstream:
From our downstream point of view they look reasonable, but we've encountered upstream resistance on first (so most likely will see it on second as well if we do it unconditionally)
Jun 15 2022
Jun 14 2022
Jun 9 2022
Fix spaces in test to minimize differences
Rebase on top of precommitted test
Jun 8 2022
Jun 1 2022
May 30 2022
May 25 2022
May 19 2022
Looks like this has to live downstream. Still I think if upstream provides some public api (CallBase::getParamElementType) it should be available to all users
May 18 2022
No, Statepoint does not use this function.
May 16 2022
Intrinsics allow to specify element type of its pointer arguments via elementtype attribute.
Atomic memory intrinsics hide this possibility behind quite complicated hierarchy. This patch makes it accessible for any interested party. I don't see what's wrong with that?
May 13 2022
May 12 2022
@MatzeB Matthias, is test statepoint-vreg-twoaddr.mir looks meaningful? If yes, I can precommit it to make changes more obvious. Also, any suggestion on improving description?
(Yes, I know that IR part in .mir test is redundant, but I find it handy when I occasionally have to modify tests)
Apr 29 2022
Added test to show changes in TwoAddress pass.