- User Since
- Aug 28 2018, 7:55 AM (74 w, 8 h)
Fix clang-format error
Fri, Jan 24
Get rid of IsAvailableOnEntry, as supposedly, loop invariant value
should be available on loop entry already.
(But again, was it really needed in original version?
PHI operand should be available. Can its SCEV be not?)
Thu, Jan 23
Rework patch to actually reqiure PHI backedge value to be loop invariant,
as original comment stated.
Introduced lambda according to comments.
- Check that PHI's input is the PHI from the same block(loop);
- Add comment to test explaining its complexity
Wed, Jan 22
- Changed source code comment
- Ran test case through update_test_checks
Please excuse me for hijacking the review, but what is _exact_ meaning of BBSkipFirstBlockPair?
(I asked on llvm-dev@, but got no answer). Does it marks BB where query starts? Or first block where we've found something relevant? Anything else?
Tue, Jan 21
Mon, Jan 20
PseudoSourceValues are uniqued, and directly changing FixedStackPseudoSource value in one MachineMemOperand will change all of them in the whole MachineFunction, which may be incorrect.
Proper way of handling this is to use PseudoSourceValueManager , like this:
Dec 19 2019
@Ayal : Thanks! Could you commit it for me, as I have no commit access yet?
Fixed final nits
- removed unsused function
- updated tests
- added short circuit compare to LoopExitInstr
Dec 18 2019
Moved all reduction flag stuff into single procedure (I had to make
it member of InnerLoopVectorizer).
Dec 17 2019
Dec 16 2019
Dec 9 2019
Addressed @Ayal's comments
Dec 2 2019
Fixed bad formatting
Removed debug leftovers...
Update according to @Ayal's comments.
Nov 28 2019
Nov 22 2019
If we're done, could you approve it and commit it for me? I have no commit access yet :-/
Nov 17 2019
@lebedev.ri : did I addressed your comments?
Nov 9 2019
Nov 5 2019
Oct 29 2019
Oct 15 2019
Oct 14 2019
Sure, but it will take some time to minimize it etc.
Meantime, my original comment was wrong - basically, I have these DAG nodes:
May 29 2019
Apr 10 2019
I don't have commit access. Brendon, could you do it for me?
Apr 8 2019
Apr 2 2019
Mar 20 2019
Mar 18 2019
Yes, please. I still have no commit access bit...
Mar 15 2019
Mar 14 2019
Mar 11 2019
I do not have commit access. Pete, could you push it for me?
Mar 7 2019
Mar 6 2019
- Removed redundant braces
- Renamed RINFO parameter to more common MRI name
- Added a handful of disassembler tests