When generating XCOFF, the compiler generates a csect with an internal name. Each function results in a label within the csect. This patch replaces the internal name ".text" with an empty string "". This avoids adding special code to handle a function text() in the source file, and works better with some XCOFF tools that are confused when the csect and the first function have the same address.
Details
Diff Detail
Event Timeline
llvm/lib/MC/MCObjectFileInfo.cpp | ||
---|---|---|
923–924 | Comment wording suggestion. | |
llvm/test/CodeGen/PowerPC/aix-pgo-function-sections.ll | ||
123 | It is somewhat unfortunate that the default tool outputs for empty names is especially bad, but I don't want to hold up this patch on changing that. | |
llvm/test/CodeGen/PowerPC/aix-text.ll | ||
3 | Since this is a new test, I think we should use --symbol-description (same for other case below). | |
41 | I think it should be possible to remove this (and the directive referring to this). Please try to remove the other metadata and attributes (and their uses) as well. |
llvm/test/CodeGen/PowerPC/aix-text.ll | ||
---|---|---|
3 | @stephenpeckham, while the case where text() is defined needs function-sections to exhibit the failure, there is another case where text() is an external reference that does not need function-sections. I suggest adding that additional test as well. |
llvm/test/CodeGen/PowerPC/aix-pgo-function-sections.ll | ||
---|---|---|
123 | A change to llvm-objdump that prints a visible string for empty names could be done in another patch. |
llvm/test/CodeGen/PowerPC/aix-pgo-function-sections.ll | ||
---|---|---|
123 | Sounds good. Such a future patch should probably update all of the cases changed here too (although most of them will continue to pass even without such a future update). | |
llvm/test/CodeGen/PowerPC/aix-text.ll | ||
3 | This test (where text is defined as a function) needs function-sections to exhibit the problem. | |
31–32 | I expect we will see these named with the storage mapping class? | |
35–36 | Same comment. |
LGTM with some minor nits
llvm/test/CodeGen/PowerPC/aix-text-ref.ll | ||
---|---|---|
6–8 ↗ | (On Diff #540010) | nit: you can remove all this metadata, since it doesn't affect the test. The defaults will be supplied by your llc invocation. |
20–24 ↗ | (On Diff #540010) | nit: ditto the earlier comment, you can strip all this metadata out to simplify the test |
llvm/test/CodeGen/PowerPC/aix-text.ll | ||
11 | nit: ditto the metadata comments about the other test file. |
Comment wording suggestion.