Page MenuHomePhabricator

Esme (Esme Yi)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 7 2020, 12:06 AM (154 w, 5 d)

Recent Activity

Thu, Mar 23

Esme committed rG49dcd08c3d96: [XCOFF] support the ref directive for object generation. (authored by Esme).
[XCOFF] support the ref directive for object generation.
Thu, Mar 23, 2:11 AM · Restricted Project, Restricted Project
Esme closed D144356: [XCOFF] support the ref directive for object generation..
Thu, Mar 23, 2:11 AM · Restricted Project, Restricted Project

Wed, Mar 22

Esme added inline comments to D144356: [XCOFF] support the ref directive for object generation..
Wed, Mar 22, 9:33 PM · Restricted Project, Restricted Project

Sun, Mar 19

Esme updated the diff for D144356: [XCOFF] support the ref directive for object generation..

Address comment -- use fixup_ppc_nofixup instead of FK_NONE to tie the ref symbol.

Sun, Mar 19, 8:40 PM · Restricted Project, Restricted Project

Thu, Mar 16

Esme added inline comments to D144356: [XCOFF] support the ref directive for object generation..
Thu, Mar 16, 1:46 AM · Restricted Project, Restricted Project

Wed, Mar 8

Esme updated the diff for D144356: [XCOFF] support the ref directive for object generation..

Add a Fixup of kind FK_NONE to later record a relocation of type R_REF.

Wed, Mar 8, 10:01 PM · Restricted Project, Restricted Project

Tue, Mar 7

Esme committed rG5541f47326e0: [PowerPC] Check if the latch block is in the value list for the PHI before get… (authored by Esme).
[PowerPC] Check if the latch block is in the value list for the PHI before get…
Tue, Mar 7, 11:21 PM · Restricted Project, Restricted Project
Esme closed D145350: [PowerPC] Check if the latch block is in the value list for the PHI before get the incoming value..
Tue, Mar 7, 11:21 PM · Restricted Project, Restricted Project
Esme updated the summary of D145350: [PowerPC] Check if the latch block is in the value list for the PHI before get the incoming value..
Tue, Mar 7, 11:19 PM · Restricted Project, Restricted Project

Mon, Mar 6

Esme updated the diff for D145350: [PowerPC] Check if the latch block is in the value list for the PHI before get the incoming value..

Address comment.

Mon, Mar 6, 10:07 PM · Restricted Project, Restricted Project

Sun, Mar 5

Esme requested review of D145350: [PowerPC] Check if the latch block is in the value list for the PHI before get the incoming value..
Sun, Mar 5, 8:44 PM · Restricted Project, Restricted Project

Mon, Feb 27

Esme accepted D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.

Thanks for fixing the failure. The changes LGTM.

Mon, Feb 27, 11:26 PM · Restricted Project, Restricted Project

Feb 23 2023

Esme added a reviewer for D144356: [XCOFF] support the ref directive for object generation.: stephenpeckham.
Feb 23 2023, 1:43 AM · Restricted Project, Restricted Project

Feb 20 2023

Esme committed rGfd226142fcff: [AIX] Lower some memory intrinsics to millicode functions on AIX (authored by Esme).
[AIX] Lower some memory intrinsics to millicode functions on AIX
Feb 20 2023, 7:26 PM · Restricted Project, Restricted Project
Esme closed D143997: [AIX] Lower some memory intrinsics to millicode functions on AIX.
Feb 20 2023, 7:26 PM · Restricted Project, Restricted Project

Feb 19 2023

Esme requested review of D144356: [XCOFF] support the ref directive for object generation..
Feb 19 2023, 5:59 PM · Restricted Project, Restricted Project

Feb 14 2023

Esme added a comment to D143725: [llvm-objdump][ARM] support --symbolize-operands for ARM/ELF.

Please include as much context as possible with your diff. https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Feb 14 2023, 7:25 PM · Restricted Project, Restricted Project
Esme requested review of D143997: [AIX] Lower some memory intrinsics to millicode functions on AIX.
Feb 14 2023, 3:15 AM · Restricted Project, Restricted Project

Feb 12 2023

Esme updated the diff for D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..

Rebase.
LIT, LNT and Bootstrap are clean.

Feb 12 2023, 6:18 PM · Restricted Project, Restricted Project

Feb 7 2023

Esme planned changes to D117447: [llvm-objdump] Annotate symbol names under `--symbolize-operands`..
Feb 7 2023, 11:46 PM · Restricted Project, Restricted Project

Jan 31 2023

Esme committed rG2224b53f064a: [PowerPC] Improve materialization for immediates which is almost a 32 bit splat. (authored by Esme).
[PowerPC] Improve materialization for immediates which is almost a 32 bit splat.
Jan 31 2023, 3:03 AM · Restricted Project, Restricted Project
Esme closed D139813: [PowerPC] Improve materialization for immediates which is almost a 32 bit splat..
Jan 31 2023, 3:03 AM · Restricted Project, Restricted Project

Jan 11 2023

Esme committed rG5ce0a26bd1cd: [XCOFF] handle the toc-data for object file generation. (authored by Esme).
[XCOFF] handle the toc-data for object file generation.
Jan 11 2023, 8:28 PM · Restricted Project, Restricted Project
Esme closed D139516: [XCOFF] handle the toc-data for object file generation..
Jan 11 2023, 8:28 PM · Restricted Project, Restricted Project
Esme updated the diff for D139813: [PowerPC] Improve materialization for immediates which is almost a 32 bit splat..

Addressed comments.

Jan 11 2023, 9:54 AM · Restricted Project, Restricted Project

Jan 10 2023

Esme committed rGdb5b7b3fe28d: [XCOFF] Fix the offset error of dwarf sections caused by D137819. (authored by Esme).
[XCOFF] Fix the offset error of dwarf sections caused by D137819.
Jan 10 2023, 9:33 AM · Restricted Project, Restricted Project
Esme committed rG2aa4b69bd60c: [XCOFF][NFC] Update the test aix-xcoff-huge-relocs.ll (authored by Esme).
[XCOFF][NFC] Update the test aix-xcoff-huge-relocs.ll
Jan 10 2023, 2:19 AM · Restricted Project, Restricted Project

Jan 9 2023

Esme committed rGea6dec1b3a56: [XCOFF] support the overflow section (only relocation overflow is handled). (authored by Esme).
[XCOFF] support the overflow section (only relocation overflow is handled).
Jan 9 2023, 11:39 PM · Restricted Project, Restricted Project
Esme closed D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..
Jan 9 2023, 11:39 PM · Restricted Project, Restricted Project

Jan 8 2023

Esme updated the diff for D139516: [XCOFF] handle the toc-data for object file generation..

Addressed comments.
Changed the Fixup Value for TOC direct external symbols and added test lines for it in toc-data-const.ll.

Jan 8 2023, 9:06 PM · Restricted Project, Restricted Project
Esme added inline comments to D139813: [PowerPC] Improve materialization for immediates which is almost a 32 bit splat..
Jan 8 2023, 5:35 PM · Restricted Project, Restricted Project
Esme updated the diff for D139813: [PowerPC] Improve materialization for immediates which is almost a 32 bit splat..

Addressed comments and verified the materialization results.
However, I can't find a proper instruction to turn 0xABCD ADDD ABCD ADDD into 0xABCD ABCD ABCD ADDD, ie. modify Lo16OfHi32 (bits 32...47), so I didn't handle the pattern like 0xABCD ABCD ABCD ADDD.

Jan 8 2023, 5:24 PM · Restricted Project, Restricted Project

Jan 4 2023

Esme added inline comments to D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..
Jan 4 2023, 8:30 PM · Restricted Project, Restricted Project
Esme added inline comments to D139516: [XCOFF] handle the toc-data for object file generation..
Jan 4 2023, 8:29 PM · Restricted Project, Restricted Project
Esme updated the diff for D139516: [XCOFF] handle the toc-data for object file generation..

Addressed comments except for the FixupValue for external TOC data.

Jan 4 2023, 8:29 PM · Restricted Project, Restricted Project

Dec 21 2022

Esme added a comment to D139813: [PowerPC] Improve materialization for immediates which is almost a 32 bit splat..

ping

Dec 21 2022, 7:07 AM · Restricted Project, Restricted Project
Esme added inline comments to D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..
Dec 21 2022, 2:38 AM · Restricted Project, Restricted Project
Esme updated the diff for D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..

Addressed comments.
Didn't find a better way instead of looping through to find the corresponding overflow section.

Dec 21 2022, 2:38 AM · Restricted Project, Restricted Project

Dec 14 2022

Esme committed rG2e8c7f652776: [XCOFF] adjust the Fixedvalue for R_RBR relocations. (authored by Esme).
[XCOFF] adjust the Fixedvalue for R_RBR relocations.
Dec 14 2022, 10:57 PM · Restricted Project, Restricted Project
Esme closed D138982: [XCOFF] adjust the Fixedvalue for R_RBR relocations..
Dec 14 2022, 10:57 PM · Restricted Project, Restricted Project
Esme added inline comments to D138982: [XCOFF] adjust the Fixedvalue for R_RBR relocations..
Dec 14 2022, 9:27 PM · Restricted Project, Restricted Project
Esme updated the diff for D138982: [XCOFF] adjust the Fixedvalue for R_RBR relocations..
Dec 14 2022, 9:27 PM · Restricted Project, Restricted Project
Esme added inline comments to D138982: [XCOFF] adjust the Fixedvalue for R_RBR relocations..
Dec 14 2022, 7:33 PM · Restricted Project, Restricted Project
Esme added inline comments to D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..
Dec 14 2022, 7:05 PM · Restricted Project, Restricted Project
Esme added inline comments to D138982: [XCOFF] adjust the Fixedvalue for R_RBR relocations..
Dec 14 2022, 6:39 PM · Restricted Project, Restricted Project
Esme updated the diff for D138982: [XCOFF] adjust the Fixedvalue for R_RBR relocations..
Dec 14 2022, 6:39 PM · Restricted Project, Restricted Project

Dec 12 2022

Esme committed rGd4fd2758962c: [NFC][PowerPC] Add tests for 64-bit constants that require 5 instructions to… (authored by Esme).
[NFC][PowerPC] Add tests for 64-bit constants that require 5 instructions to…
Dec 12 2022, 11:46 PM · Restricted Project, Restricted Project
Esme closed D139914: [NFC][PowerPC] Add tests for 64-bit constants that require 5 instructions to materialize..
Dec 12 2022, 11:46 PM · Restricted Project, Restricted Project
Esme updated the diff for D139813: [PowerPC] Improve materialization for immediates which is almost a 32 bit splat..

Address comments.

Dec 12 2022, 11:29 PM · Restricted Project, Restricted Project
Esme requested review of D139914: [NFC][PowerPC] Add tests for 64-bit constants that require 5 instructions to materialize..
Dec 12 2022, 11:22 PM · Restricted Project, Restricted Project
Esme requested review of D139813: [PowerPC] Improve materialization for immediates which is almost a 32 bit splat..
Dec 12 2022, 12:28 AM · Restricted Project, Restricted Project

Dec 11 2022

Esme accepted D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj.

LGTM. Thanks!

Dec 11 2022, 9:37 PM · Restricted Project, Restricted Project
Esme added a comment to D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj.
Dec 11 2022, 9:37 PM · Restricted Project, Restricted Project

Dec 9 2022

Esme accepted D138985: [AIX][BigArchive][NFC] Add test case that list members of archive with free list in it.

LGTM. Thx.

Dec 9 2022, 8:41 AM · Restricted Project, Restricted Project
Esme accepted D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.

LGTM. Thank you for fixing it.

Dec 9 2022, 8:40 AM · Restricted Project, Restricted Project

Dec 8 2022

Esme added inline comments to D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Dec 8 2022, 12:39 AM · Restricted Project, Restricted Project

Dec 7 2022

Esme updated the diff for D138982: [XCOFF] adjust the Fixedvalue for R_RBR relocations..

Addressed comments. Thanks @DiggerLin and @shchenz

Dec 7 2022, 9:32 PM · Restricted Project, Restricted Project
Esme added a comment to D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj.
Dec 7 2022, 6:55 PM · Restricted Project, Restricted Project
Esme added a comment to D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj.

Btw. Do you have any plans to implement an option like "--loader-section" to embrace all this loader section related information?

Dec 7 2022, 2:35 AM · Restricted Project, Restricted Project
Esme added a comment to D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj.

Feel sorry that i'm just getting started to review this patch.
I've applied the patch and test the functionality and it looks good overall. Thanks.
However, considering the printing format of relocations in llvm-readobj, when --expand-relocs is not specified, we usually print relocations in this format:

vaddr     section    type   symbol
20000294    2       POS   .data
2000029c    2       POS   0

Only when --expand-relocs is specified, we print relocations like the format in this patch.
The --dyn-relocations option also follows such rule.

Dec 7 2022, 2:31 AM · Restricted Project, Restricted Project
Esme requested review of D139516: [XCOFF] handle the toc-data for object file generation..
Dec 7 2022, 1:19 AM · Restricted Project, Restricted Project

Dec 6 2022

Esme updated the diff for D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..

Update the comments.

Dec 6 2022, 10:43 PM · Restricted Project, Restricted Project
Esme added a comment to D138982: [XCOFF] adjust the Fixedvalue for R_RBR relocations..

Hi @DiggerLin, thank you for your review. I'm also confused by the description from the doc, if my understanding is correct, according to the doc, the FixedValue will ignore the value of Fixup.getOffset(), because the address of the csect containing the branch instruction to be modified equals to SectionMap[ParentSec]->Address + Layout.getFragmentOffset(Fragment). This is obviously incorrect. I have tested LNT and bootstrap for this patch under the options of -fintegrated-as -ffunction-sections, and both are clean.

Dec 6 2022, 6:17 AM · Restricted Project, Restricted Project

Dec 5 2022

Esme added inline comments to D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..
Dec 5 2022, 8:48 PM · Restricted Project, Restricted Project
Esme updated the diff for D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..
Dec 5 2022, 8:47 PM · Restricted Project, Restricted Project
Esme added a comment to D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..

I'm okay with an NFC reformatting patch if it's needed, rather than trying to bundle together the changes in with functional changes.

Dec 5 2022, 1:17 AM · Restricted Project, Restricted Project
Esme updated the diff for D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..

Addressed comments.

Dec 5 2022, 1:14 AM · Restricted Project, Restricted Project

Dec 4 2022

Esme updated the diff for D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..

Rebase on latest commit.

Dec 4 2022, 9:12 PM · Restricted Project, Restricted Project
Esme added a comment to D134195: [PowerPC] XCOFF exception section support on the integrated assembler path.

FYI. I committed an NFC patch rG664cbfaf07e0 to format this patch.

Dec 4 2022, 9:02 PM · Restricted Project, Restricted Project
Esme committed rG664cbfaf07e0: [NFC][XCOFF] format `XCOFFObjectWriter.cpp` (authored by Esme).
[NFC][XCOFF] format `XCOFFObjectWriter.cpp`
Dec 4 2022, 8:59 PM · Restricted Project, Restricted Project
Esme retitled D137819: [XCOFF] support the overflow section (only relocation overflow is handled). from [XCOFF] support the overflow section (only relocation overflow are handled). to [XCOFF] support the overflow section (only relocation overflow is handled)..
Dec 4 2022, 7:55 AM · Restricted Project, Restricted Project
Esme added a comment to D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..

change the description to 'support the relocation overflow section."

As the doc says, the overflow section is required when either of the relocation entries or the line number entries exceeds 65,534. As long as one of the counts exceeds 65,534, the other one will also be set to 65535 in the primary section header, and then the overflow section will record actual counts for both relocation entries and line number entries, where the s_paddr for relocation entries and s_vaddr for line number entries.
Therefore I reckon there's no need to identify whether it's a relocation overflow section or line number overflow section.

if one day, you want to add the functionality patch of overflow section for line number , what title  you want to use for that new patch?
Dec 4 2022, 7:54 AM · Restricted Project, Restricted Project
Esme added inline comments to D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..
Dec 4 2022, 7:52 AM · Restricted Project, Restricted Project
Esme updated the summary of D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..
Dec 4 2022, 7:52 AM · Restricted Project, Restricted Project
Esme updated the diff for D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..

Addressed comments.

Dec 4 2022, 7:51 AM · Restricted Project, Restricted Project

Nov 29 2022

Esme requested review of D138982: [XCOFF] adjust the Fixedvalue for R_RBR relocations..
Nov 29 2022, 11:47 PM · Restricted Project, Restricted Project

Nov 22 2022

Esme committed rGc7c7ef8bda1f: [XCOFF] set fragment for XMC_PR csects. (authored by Esme).
[XCOFF] set fragment for XMC_PR csects.
Nov 22 2022, 4:18 AM · Restricted Project, Restricted Project
Esme closed D137230: [XCOFF] set fragment for XMC_PR csects..
Nov 22 2022, 4:18 AM · Restricted Project, Restricted Project

Nov 20 2022

Esme updated the diff for D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..
Nov 20 2022, 8:13 AM · Restricted Project, Restricted Project
Esme added a comment to D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..

change the description to 'support the relocation overflow section."

Nov 20 2022, 8:10 AM · Restricted Project, Restricted Project
Esme updated the diff for D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..
Nov 20 2022, 8:09 AM · Restricted Project, Restricted Project

Nov 15 2022

Esme retitled D137230: [XCOFF] set fragment for XMC_PR csects. from [XCOFF] avoid unnecessary Fixups when -function-sections is enabled. to [XCOFF] set fragment for XMC_PR csects..
Nov 15 2022, 6:30 PM · Restricted Project, Restricted Project

Nov 13 2022

Esme updated the diff for D137230: [XCOFF] set fragment for XMC_PR csects..

Addressed comments.
Thx @hubert.reinterpretcast and @DiggerLin

Nov 13 2022, 11:29 PM · Restricted Project, Restricted Project

Nov 11 2022

Esme updated the diff for D137230: [XCOFF] set fragment for XMC_PR csects..

Addressed comments.
Thx @DiggerLin

Nov 11 2022, 2:05 AM · Restricted Project, Restricted Project
Esme requested review of D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..
Nov 11 2022, 1:12 AM · Restricted Project, Restricted Project

Nov 6 2022

Esme updated the diff for D137230: [XCOFF] set fragment for XMC_PR csects..
Nov 6 2022, 9:24 PM · Restricted Project, Restricted Project

Nov 3 2022

Esme updated the diff for D137230: [XCOFF] set fragment for XMC_PR csects..

Clean test failure.

Nov 3 2022, 2:00 AM · Restricted Project, Restricted Project

Nov 2 2022

Esme requested review of D137230: [XCOFF] set fragment for XMC_PR csects..
Nov 2 2022, 12:53 AM · Restricted Project, Restricted Project

Oct 30 2022

Esme committed rGd1115c2b84d4: [PowerPC] Optimize compare by using record form in post-RA. (authored by Esme).
[PowerPC] Optimize compare by using record form in post-RA.
Oct 30 2022, 10:35 PM · Restricted Project, Restricted Project
Esme closed D131873: [PowerPC] Optimize compare by using record form in post-RA..
Oct 30 2022, 10:35 PM · Restricted Project, Restricted Project

Oct 28 2022

Esme added a comment to D135887: [XCOFF] llvm-readobj support display symbol table of loader section of xcoff object file..

Sorry for the late reply, in fact I'm not quite sure about using the existing --dyn-syms option or adding an XCOFF specific one, so I wait to see what others think.
I noticed that the objdump from AIX system tool kits prints the loader section (together with its symbols and relocations) with the XCOFF specific option -P loader:

Oct 28 2022, 2:31 AM · Restricted Project, Restricted Project

Oct 26 2022

Esme added a comment to D131873: [PowerPC] Optimize compare by using record form in post-RA..

Compared with previous versions, to me, seems some valid transformations are gone now because of the new bail out case Subtarget.isPPC64() && Opc == PPC::CMPWI. Maybe we can have a further check why PPC64 generates CMPWI 0 for some cases. For these cases, I guess CMPDI 0 should also be ok, so that there will be more record form opportunities here. But we can do that in another patch.

Oct 26 2022, 8:07 PM · Restricted Project, Restricted Project
Esme updated the diff for D131873: [PowerPC] Optimize compare by using record form in post-RA..
Oct 26 2022, 8:07 PM · Restricted Project, Restricted Project

Oct 24 2022

Esme updated the diff for D131873: [PowerPC] Optimize compare by using record form in post-RA..

Update comments.

Oct 24 2022, 8:19 PM · Restricted Project, Restricted Project

Oct 23 2022

Esme updated the diff for D131873: [PowerPC] Optimize compare by using record form in post-RA..

The bootstrap test is clean.

Oct 23 2022, 7:11 PM · Restricted Project, Restricted Project

Oct 20 2022

Esme added a comment to D135887: [XCOFF] llvm-readobj support display symbol table of loader section of xcoff object file..

The symbols in the loader section should be the dynamic symbols in the general definition, so is it possible to use the original option --dyn-syms, and then implement the defined interface XCOFFDumper::printDynamicSymbols()?

Oct 20 2022, 8:50 PM · Restricted Project, Restricted Project
Esme accepted D134883: [XCOFF] llvm-readobj support decoding the loader section header field for XCOFF object file..

LGTM. Thanks for your work.

Oct 20 2022, 8:20 PM · Restricted Project, Restricted Project
Esme added a comment to D134883: [XCOFF] llvm-readobj support decoding the loader section header field for XCOFF object file..
Oct 20 2022, 8:19 PM · Restricted Project, Restricted Project

Sep 28 2022

Esme updated the diff for D131873: [PowerPC] Optimize compare by using record form in post-RA..

Apologize for the late update due to some compiler-rt errors occurred. I'm working on fixing it.

Sep 28 2022, 10:54 PM · Restricted Project, Restricted Project

Sep 20 2022

Esme accepted D134280: [NFC] refactor XCOFFObjectFile::getImportFileTable..

LGTM. Thx!

Sep 20 2022, 7:52 PM · Restricted Project, Restricted Project