Page MenuHomePhabricator

Esme (Esme Yi)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 7 2020, 12:06 AM (111 w, 4 d)

Recent Activity

Tue, May 24

Esme updated the diff for D124654: [AIX] Handling the label alignment of a global variable with its multiple aliases..

Addresses comments.

Tue, May 24, 6:52 PM · Restricted Project, Restricted Project

Wed, May 18

Esme added a comment to D124654: [AIX] Handling the label alignment of a global variable with its multiple aliases..

Gentle ping.

Wed, May 18, 6:54 PM · Restricted Project, Restricted Project

Tue, May 17

Esme committed rG8d6e2c3e3db1: [XCOFF] support writing sections, relocations and symbols for XCOFF64. (authored by Esme).
[XCOFF] support writing sections, relocations and symbols for XCOFF64.
Tue, May 17, 1:28 AM · Restricted Project, Restricted Project
Esme closed D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64..
Tue, May 17, 1:28 AM · Restricted Project, Restricted Project

Mon, May 16

Esme updated the diff for D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64..

Rebase.
Clean the failure in test llvm/test/CodeGen/PowerPC/aix-xcoff-visibility.ll.

Mon, May 16, 12:49 AM · Restricted Project, Restricted Project

Thu, May 5

Esme updated the diff for D124654: [AIX] Handling the label alignment of a global variable with its multiple aliases..

Addressed @DiggerLin's comments, THX.

Thu, May 5, 5:00 AM · Restricted Project, Restricted Project
Esme updated the diff for D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64..
  1. Simplify tests.
  2. Test dwarf64.
Thu, May 5, 4:03 AM · Restricted Project, Restricted Project

Thu, Apr 28

Esme requested review of D124654: [AIX] Handling the label alignment of a global variable with its multiple aliases..
Thu, Apr 28, 8:58 PM · Restricted Project, Restricted Project

Apr 26 2022

Esme added inline comments to D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64..
Apr 26 2022, 9:12 PM · Restricted Project, Restricted Project
Esme added inline comments to D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64..
Apr 26 2022, 9:09 PM · Restricted Project, Restricted Project
Esme updated the diff for D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64..

Addressed comments and improved tests.

Apr 26 2022, 9:09 PM · Restricted Project, Restricted Project

Apr 17 2022

Esme updated the diff for D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64..

Hi @DiggerLin, Sorry for the late update, I have verified that the SignAndSize value should be 15 for both fixup_ppc_half16ds and fixup_ppc_half16dq. Although there are zeros being implied, the totally size should be a 16-bit fixup. I confirmed this by testing LIT and test-suite, and the test-suite passes only if the value is 15, otherwise there will be an error like this

Relocation overflow in reference to: L..CPI168_7 (entry 3199)
        Address: 0x00082c12; RLD type: R_TOC; RLD length: 14
Apr 17 2022, 10:13 PM · Restricted Project, Restricted Project

Apr 1 2022

Esme added inline comments to D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64..
Apr 1 2022, 12:07 AM · Restricted Project, Restricted Project

Mar 30 2022

Esme updated the diff for D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64..

Improved the format of run lines in tests.

Mar 30 2022, 11:26 PM · Restricted Project, Restricted Project

Mar 29 2022

Esme added inline comments to D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64..
Mar 29 2022, 9:53 PM · Restricted Project, Restricted Project
Esme updated the diff for D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64..

Addressed @DiggerLin 's comments.

Mar 29 2022, 9:53 PM · Restricted Project, Restricted Project
Esme updated the diff for D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64..

Thanks for your comments! @jhenderson
It seems inappropriate to support the symbol table before the sections and relocations, due to their offset order, or some other reasons. So I enabled all these fields in this patch and also modified related test cases.

Mar 29 2022, 9:17 AM · Restricted Project, Restricted Project

Mar 22 2022

Esme requested review of D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64..
Mar 22 2022, 10:13 PM · Restricted Project, Restricted Project

Mar 20 2022

Esme committed rGde20a3b67752: [XCOFF] support XCOFFObjectWriter for fileHeader and sectionHeaders in 64-bit… (authored by Esme).
[XCOFF] support XCOFFObjectWriter for fileHeader and sectionHeaders in 64-bit…
Mar 20 2022, 6:32 AM · Restricted Project
Esme closed D120861: [XCOFF][1/3] support fileHeader and sectionHeaders in 64-bit XCOFF..
Mar 20 2022, 6:32 AM · Restricted Project, Restricted Project

Mar 18 2022

Esme updated the diff for D120861: [XCOFF][1/3] support fileHeader and sectionHeaders in 64-bit XCOFF..

Addressed comments.

Mar 18 2022, 12:00 AM · Restricted Project, Restricted Project

Mar 15 2022

Esme updated the diff for D120861: [XCOFF][1/3] support fileHeader and sectionHeaders in 64-bit XCOFF..

Addressed @DiggerLin 's comments, ie. auxiliaryHeaderSize() is kept.

Mar 15 2022, 8:18 PM · Restricted Project, Restricted Project

Mar 14 2022

Esme committed rG6143ec2961d1: [NFC][XCOFF] Refactor and format XCOFFObjectWriter.cpp. (authored by Esme).
[NFC][XCOFF] Refactor and format XCOFFObjectWriter.cpp.
Mar 14 2022, 11:41 PM · Restricted Project
Esme closed D120858: [NFC][XCOFF] Refactor and format XCOFFObjectWriter.cpp..
Mar 14 2022, 11:41 PM · Restricted Project, Restricted Project
Esme added inline comments to D120861: [XCOFF][1/3] support fileHeader and sectionHeaders in 64-bit XCOFF..
Mar 14 2022, 8:51 PM · Restricted Project, Restricted Project

Mar 11 2022

Esme updated the diff for D120861: [XCOFF][1/3] support fileHeader and sectionHeaders in 64-bit XCOFF..

Addressed comments.

Mar 11 2022, 12:33 AM · Restricted Project, Restricted Project

Mar 10 2022

Esme updated the diff for D120858: [NFC][XCOFF] Refactor and format XCOFFObjectWriter.cpp..

Addressed comments.

Mar 10 2022, 9:54 PM · Restricted Project, Restricted Project

Mar 8 2022

Esme updated the diff for D120858: [NFC][XCOFF] Refactor and format XCOFFObjectWriter.cpp..

Updated comments for consistency with parameters' names.

Mar 8 2022, 9:41 PM · Restricted Project, Restricted Project
Esme updated the diff for D120858: [NFC][XCOFF] Refactor and format XCOFFObjectWriter.cpp..

Addressed @DiggerLin and @jhenderson 's comments. Thanks!

Mar 8 2022, 9:14 PM · Restricted Project, Restricted Project

Mar 6 2022

Esme added inline comments to D120858: [NFC][XCOFF] Refactor and format XCOFFObjectWriter.cpp..
Mar 6 2022, 9:17 PM · Restricted Project, Restricted Project
Esme updated the diff for D120858: [NFC][XCOFF] Refactor and format XCOFFObjectWriter.cpp..

Addressed @DiggerLin 's comments. Thanks

Mar 6 2022, 9:17 PM · Restricted Project, Restricted Project

Mar 2 2022

Esme requested review of D120861: [XCOFF][1/3] support fileHeader and sectionHeaders in 64-bit XCOFF..
Mar 2 2022, 5:54 PM · Restricted Project, Restricted Project
Esme updated the diff for D120858: [NFC][XCOFF] Refactor and format XCOFFObjectWriter.cpp..
Mar 2 2022, 5:39 PM · Restricted Project, Restricted Project
Esme requested review of D120858: [NFC][XCOFF] Refactor and format XCOFFObjectWriter.cpp..
Mar 2 2022, 5:34 PM · Restricted Project, Restricted Project

Feb 28 2022

Esme committed rG61835d19a848: [llvm-objcopy] Initial XCOFF32 support. (authored by Esme).
[llvm-objcopy] Initial XCOFF32 support.
Feb 28 2022, 2:00 AM
Esme closed D97656: [llvm-objcopy] Initial XCOFF32 support..
Feb 28 2022, 2:00 AM · Restricted Project

Feb 27 2022

Esme added a comment to D97656: [llvm-objcopy] Initial XCOFF32 support..

LGTM with one nit. Thanks for adding this support.

Have you tried this patch with objects generated by other tools, like XLC?

Feb 27 2022, 9:29 PM · Restricted Project

Feb 22 2022

Esme updated the diff for D97656: [llvm-objcopy] Initial XCOFF32 support..

Revised this patch on @avl 's work, i.e. D88827, D120345, D114664 and D114429.

Feb 22 2022, 7:28 PM · Restricted Project

Feb 20 2022

Esme committed rG7b67d2e39886: Reland [XCOFF][llvm-objdump] change the priority of symbols with the same… (authored by Esme).
Reland [XCOFF][llvm-objdump] change the priority of symbols with the same…
Feb 20 2022, 6:54 PM

Feb 18 2022

Esme added a reverting change for rG2ad662172cbb: [XCOFF][llvm-objdump] change the priority of symbols with: rG0bf3fec4cd95: Revert "[XCOFF][llvm-objdump] change the priority of symbols with".
Feb 18 2022, 1:13 AM
Esme committed rG0bf3fec4cd95: Revert "[XCOFF][llvm-objdump] change the priority of symbols with" (authored by Esme).
Revert "[XCOFF][llvm-objdump] change the priority of symbols with"
Feb 18 2022, 1:13 AM
Esme added a reverting change for D117642: [XCOFF][llvm-objdump] change the priority of symbols with the same address by symbol types.: rG0bf3fec4cd95: Revert "[XCOFF][llvm-objdump] change the priority of symbols with".
Feb 18 2022, 1:13 AM · Restricted Project

Feb 17 2022

Esme committed rG2ad662172cbb: [XCOFF][llvm-objdump] change the priority of symbols with (authored by Esme).
[XCOFF][llvm-objdump] change the priority of symbols with
Feb 17 2022, 9:31 PM
Esme closed D117642: [XCOFF][llvm-objdump] change the priority of symbols with the same address by symbol types..
Feb 17 2022, 9:30 PM · Restricted Project
Esme added inline comments to D97656: [llvm-objcopy] Initial XCOFF32 support..
Feb 17 2022, 8:21 PM · Restricted Project
Esme updated the diff for D97656: [llvm-objcopy] Initial XCOFF32 support..

Addressed comments.

Feb 17 2022, 8:21 PM · Restricted Project

Feb 16 2022

Esme updated the diff for D117642: [XCOFF][llvm-objdump] change the priority of symbols with the same address by symbol types..

Make the SymbolRef::Type in a convenient symbol-priority order.

Feb 16 2022, 9:29 PM · Restricted Project
Esme added a comment to D117642: [XCOFF][llvm-objdump] change the priority of symbols with the same address by symbol types..

The problem is, as I understand it, that the XCOFF symbol type enum isn't ordered in a convenient symbol-priority order, right?

Feb 16 2022, 9:27 PM · Restricted Project
Esme added inline comments to D97656: [llvm-objcopy] Initial XCOFF32 support..
Feb 16 2022, 8:31 PM · Restricted Project
Esme updated the diff for D97656: [llvm-objcopy] Initial XCOFF32 support..
Feb 16 2022, 8:30 PM · Restricted Project

Jan 23 2022

Esme updated the diff for D117642: [XCOFF][llvm-objdump] change the priority of symbols with the same address by symbol types..
Jan 23 2022, 8:44 PM · Restricted Project

Jan 19 2022

Esme committed rGb9d85a52317e: [NFC][XCOFF] remove the tool name `yaml2obj` in the test. (authored by Esme).
[NFC][XCOFF] remove the tool name `yaml2obj` in the test.
Jan 19 2022, 1:12 AM
Esme committed rG05fffac1f9ad: [NFC][XCOFF] commit tests for D113552. (authored by Esme).
[NFC][XCOFF] commit tests for D113552.
Jan 19 2022, 1:08 AM
Esme updated the summary of D117642: [XCOFF][llvm-objdump] change the priority of symbols with the same address by symbol types..
Jan 19 2022, 12:52 AM · Restricted Project
Esme requested review of D117642: [XCOFF][llvm-objdump] change the priority of symbols with the same address by symbol types..
Jan 19 2022, 12:03 AM · Restricted Project

Jan 16 2022

Esme committed rG61106ca75256: Reland https://reviews.llvm.org/D113825 after fixing the test expectations. (authored by Esme).
Reland https://reviews.llvm.org/D113825 after fixing the test expectations.
Jan 16 2022, 9:30 PM
Esme updated the diff for D97656: [llvm-objcopy] Initial XCOFF32 support..
  1. Addressed comments.
  2. Replaced binary inputs with YAMLs for testing.
  3. Updated tests for error paths.
Jan 16 2022, 9:25 PM · Restricted Project
Esme requested review of D117447: [llvm-objdump] Annotate symbol names under `--symbolize-operands`..
Jan 16 2022, 6:13 PM · Restricted Project

Jan 11 2022

Esme committed rGaad49c8eb984: [llvm-readobj][XCOFF] dump auxiliary symbols. (authored by Esme).
[llvm-readobj][XCOFF] dump auxiliary symbols.
Jan 11 2022, 11:19 PM
Esme closed D113825: [llvm-readobj][XCOFF] dump auxiliary symbols..
Jan 11 2022, 11:19 PM · Restricted Project

Jan 10 2022

Esme committed rGb28e8abfd069: [NFC][XCOFF][llvm-readobj] replace binaries with YAMLs (only tests for Symbols). (authored by Esme).
[NFC][XCOFF][llvm-readobj] replace binaries with YAMLs (only tests for Symbols).
Jan 10 2022, 10:18 PM
Esme closed D114434: [NFC][XCOFF] [llvm-readobj] replace binaries with YAMLs (only tests for Symbols).
Jan 10 2022, 10:18 PM · Restricted Project
Esme added inline comments to D82549: [AIX][XCOFF] parsing xcoff object file auxiliary header.
Jan 10 2022, 1:00 AM · Restricted Project

Jan 9 2022

Esme committed rG817936408bad: [yaml2obj][XCOFF] parsing auxiliary symbols. (authored by Esme).
[yaml2obj][XCOFF] parsing auxiliary symbols.
Jan 9 2022, 6:39 PM
Esme closed D113552: [yaml2obj][XCOFF] parsing auxiliary symbols..
Jan 9 2022, 6:39 PM · Restricted Project

Dec 28 2021

Esme added a comment to D113552: [yaml2obj][XCOFF] parsing auxiliary symbols..

Gently ping.

Dec 28 2021, 10:10 PM · Restricted Project

Dec 20 2021

Esme committed rGb66328701a52: [PowerPC][llvm-objdump] enable --symbolize-operands for PowerPC ELF/XCOFF. (authored by Esme).
[PowerPC][llvm-objdump] enable --symbolize-operands for PowerPC ELF/XCOFF.
Dec 20 2021, 8:18 PM
Esme closed D114492: [PowerPC][llvm-objdump] enable --symbolize-operands for PowerPC ELF/XCOFF..
Dec 20 2021, 8:18 PM · Restricted Project
Esme added inline comments to D114492: [PowerPC][llvm-objdump] enable --symbolize-operands for PowerPC ELF/XCOFF..
Dec 20 2021, 12:22 AM · Restricted Project
Esme updated the diff for D114492: [PowerPC][llvm-objdump] enable --symbolize-operands for PowerPC ELF/XCOFF..
Dec 20 2021, 12:22 AM · Restricted Project

Dec 19 2021

Esme updated the diff for D113552: [yaml2obj][XCOFF] parsing auxiliary symbols..
Dec 19 2021, 10:16 PM · Restricted Project
Esme added a comment to D113552: [yaml2obj][XCOFF] parsing auxiliary symbols..

the x_auxtype is only for 64bits. in the implement, it means we always need to specific the AUX_type no matter it is 32bit or 64bits.

Dec 19 2021, 10:12 PM · Restricted Project
Esme updated the diff for D113552: [yaml2obj][XCOFF] parsing auxiliary symbols..

Thanks! @jhenderson @DiggerLin @Higuoxing
Address comments.

Dec 19 2021, 10:10 PM · Restricted Project
Esme committed rG18f087c21cdb: [DebugInfo][Clang] record the access flag for class/struct/union types. (authored by Esme).
[DebugInfo][Clang] record the access flag for class/struct/union types.
Dec 19 2021, 6:41 PM
Esme closed D115503: [DebugInfo][Clang] record the access flag for class/struct/union types..
Dec 19 2021, 6:41 PM · Restricted Project, Restricted Project

Dec 17 2021

Esme added a comment to D115503: [DebugInfo][Clang] record the access flag for class/struct/union types..

Ah, cool - could you include % growth on those rows

Dec 17 2021, 2:24 AM · Restricted Project, Restricted Project
Esme added inline comments to D114492: [PowerPC][llvm-objdump] enable --symbolize-operands for PowerPC ELF/XCOFF..
Dec 17 2021, 12:07 AM · Restricted Project
Esme updated the diff for D114492: [PowerPC][llvm-objdump] enable --symbolize-operands for PowerPC ELF/XCOFF..

Address comments.

Dec 17 2021, 12:07 AM · Restricted Project

Dec 15 2021

Esme added a reviewer for D113552: [yaml2obj][XCOFF] parsing auxiliary symbols.: jsji.
Dec 15 2021, 2:29 AM · Restricted Project
Esme added a comment to D113552: [yaml2obj][XCOFF] parsing auxiliary symbols..

Thank you so much for your reviewing. @jhenderson @Higuoxing
Do you have more comments for this patch?
Btw. there are 2 accepted patches (D113825 and D114434) depends on this patch.

Dec 15 2021, 2:29 AM · Restricted Project
Esme updated the diff for D114492: [PowerPC][llvm-objdump] enable --symbolize-operands for PowerPC ELF/XCOFF..
  1. Address comments.
  2. Skip recording branches for function calls in collectLocalBranchTargets();
Dec 15 2021, 2:24 AM · Restricted Project

Dec 14 2021

Esme committed rGc0529efc95e3: [DebugInfo][DWARF] emit DW_AT_accessibility attribute for class/struct/union… (authored by Esme).
[DebugInfo][DWARF] emit DW_AT_accessibility attribute for class/struct/union…
Dec 14 2021, 11:39 PM
Esme closed D115606: [DebugInfo][DWARF] emit DW_AT_accessibility attribute for class/struct/union types..
Dec 14 2021, 11:38 PM · Restricted Project
Esme added a comment to D115503: [DebugInfo][Clang] record the access flag for class/struct/union types..

Thanks for the data - looks good to me. Maybe include some of that data (summary of total binary size change/total debug info size change - and if you could include the flags (was this an -O0 -g build? Optimized (at what level)? Compressed debug info (-gz)? etc) that'd be helpful to better understand the comparison.

Dec 14 2021, 7:32 PM · Restricted Project, Restricted Project

Dec 13 2021

Esme updated the diff for D115606: [DebugInfo][DWARF] emit DW_AT_accessibility attribute for class/struct/union types..

Address comment.

Dec 13 2021, 10:37 PM · Restricted Project
Esme added a comment to D115503: [DebugInfo][Clang] record the access flag for class/struct/union types..

Got any data on how much this (combined with the LLVM patch) increases debug info size of, say, a clang self-host build? I assume not much, but wouldn't hurt to know.

Dec 13 2021, 8:26 PM · Restricted Project, Restricted Project

Dec 12 2021

Esme added inline comments to D115503: [DebugInfo][Clang] record the access flag for class/struct/union types..
Dec 12 2021, 10:53 PM · Restricted Project, Restricted Project
Esme updated the diff for D115503: [DebugInfo][Clang] record the access flag for class/struct/union types..

Add a case to show that the default access flag is not recorded.

Dec 12 2021, 10:53 PM · Restricted Project, Restricted Project
Esme requested review of D115606: [DebugInfo][DWARF] emit DW_AT_accessibility attribute for class/struct/union types..
Dec 12 2021, 6:29 PM · Restricted Project
Esme updated the diff for D115503: [DebugInfo][Clang] record the access flag for class/struct/union types..

Thanks! @dblaikie
Separate into Clang part (this patch) and LLVM part (D115606).

Dec 12 2021, 6:24 PM · Restricted Project, Restricted Project

Dec 10 2021

Esme requested review of D115503: [DebugInfo][Clang] record the access flag for class/struct/union types..
Dec 10 2021, 2:55 AM · Restricted Project, Restricted Project

Dec 7 2021

Esme updated the diff for D114492: [PowerPC][llvm-objdump] enable --symbolize-operands for PowerPC ELF/XCOFF..

Address comments.

Dec 7 2021, 7:28 PM · Restricted Project

Dec 6 2021

Esme updated the diff for D113825: [llvm-readobj][XCOFF] dump auxiliary symbols..

Address comments.

Dec 6 2021, 1:45 AM · Restricted Project

Dec 2 2021

Esme added a comment to D114684: Add ScopedPrinter unit tests.

Should unit tests be added for to_hexString(), to_string() and enumToString() (from D114840)? Although they are not part of the ScopedPrinter class but just in ScopedPrinter.h.

Dec 2 2021, 10:35 PM · Restricted Project
Esme committed rG62c74d496bb4: [NFC] move GNUELFDumper::printEnum() into a common header for reuse. (authored by Esme).
[NFC] move GNUELFDumper::printEnum() into a common header for reuse.
Dec 2 2021, 10:34 PM
Esme closed D114840: [NFC] move GNUELFDumper::printEnum() into a common header for reuse..
Dec 2 2021, 10:34 PM · Restricted Project

Nov 30 2021

Esme updated the diff for D113825: [llvm-readobj][XCOFF] dump auxiliary symbols..

Address comments.

Nov 30 2021, 9:21 PM · Restricted Project
Esme requested review of D114840: [NFC] move GNUELFDumper::printEnum() into a common header for reuse..
Nov 30 2021, 8:19 PM · Restricted Project
Esme updated the diff for D113552: [yaml2obj][XCOFF] parsing auxiliary symbols..

Address comments.

Nov 30 2021, 1:20 AM · Restricted Project

Nov 29 2021

Esme updated the diff for D113825: [llvm-readobj][XCOFF] dump auxiliary symbols..

Address comments.

Nov 29 2021, 10:05 PM · Restricted Project