User Details
- User Since
- Apr 7 2020, 12:06 AM (111 w, 4 d)
Tue, May 24
Addresses comments.
Wed, May 18
Gentle ping.
Tue, May 17
Mon, May 16
Rebase.
Clean the failure in test llvm/test/CodeGen/PowerPC/aix-xcoff-visibility.ll.
Thu, May 5
Addressed @DiggerLin's comments, THX.
- Simplify tests.
- Test dwarf64.
Thu, Apr 28
Apr 26 2022
Addressed comments and improved tests.
Apr 17 2022
Hi @DiggerLin, Sorry for the late update, I have verified that the SignAndSize value should be 15 for both fixup_ppc_half16ds and fixup_ppc_half16dq. Although there are zeros being implied, the totally size should be a 16-bit fixup. I confirmed this by testing LIT and test-suite, and the test-suite passes only if the value is 15, otherwise there will be an error like this
Relocation overflow in reference to: L..CPI168_7 (entry 3199) Address: 0x00082c12; RLD type: R_TOC; RLD length: 14
Apr 1 2022
Mar 30 2022
Improved the format of run lines in tests.
Mar 29 2022
Addressed @DiggerLin 's comments.
Thanks for your comments! @jhenderson
It seems inappropriate to support the symbol table before the sections and relocations, due to their offset order, or some other reasons. So I enabled all these fields in this patch and also modified related test cases.
Mar 22 2022
Mar 20 2022
Mar 18 2022
Addressed comments.
Mar 15 2022
Addressed @DiggerLin 's comments, ie. auxiliaryHeaderSize() is kept.
Mar 14 2022
Mar 11 2022
Addressed comments.
Mar 10 2022
Addressed comments.
Mar 8 2022
Updated comments for consistency with parameters' names.
Addressed @DiggerLin and @jhenderson 's comments. Thanks!
Mar 6 2022
Addressed @DiggerLin 's comments. Thanks
Mar 2 2022
Feb 28 2022
Feb 27 2022
Feb 22 2022
Feb 20 2022
Feb 18 2022
Feb 17 2022
Addressed comments.
Feb 16 2022
Make the SymbolRef::Type in a convenient symbol-priority order.
Jan 23 2022
Jan 19 2022
Jan 16 2022
- Addressed comments.
- Replaced binary inputs with YAMLs for testing.
- Updated tests for error paths.
Jan 11 2022
Jan 10 2022
Jan 9 2022
Dec 28 2021
Gently ping.
Dec 20 2021
Dec 19 2021
Thanks! @jhenderson @DiggerLin @Higuoxing
Address comments.
Dec 17 2021
Address comments.
Dec 15 2021
Thank you so much for your reviewing. @jhenderson @Higuoxing
Do you have more comments for this patch?
Btw. there are 2 accepted patches (D113825 and D114434) depends on this patch.
- Address comments.
- Skip recording branches for function calls in collectLocalBranchTargets();
Dec 14 2021
Dec 13 2021
Address comment.
Dec 12 2021
Add a case to show that the default access flag is not recorded.
Dec 10 2021
Dec 7 2021
Address comments.
Dec 6 2021
Address comments.
Dec 2 2021
Should unit tests be added for to_hexString(), to_string() and enumToString() (from D114840)? Although they are not part of the ScopedPrinter class but just in ScopedPrinter.h.
Nov 30 2021
Address comments.
Address comments.
Nov 29 2021
Address comments.