Page MenuHomePhabricator

Esme (EsmeYi)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 7 2020, 12:06 AM (53 w, 9 h)

Recent Activity

Today

Esme requested review of D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..
Tue, Apr 13, 3:24 AM · Restricted Project

Yesterday

Esme added a reverting change for rGc965e14a1295: Revert "[DebugInfo] Fix the mismatching between C++ language tags and Dwarf…: rGdff922f39b9b: Reland [DebugInfo] Fix the mismatching between C++ language tags and Dwarf….
Mon, Apr 12, 4:07 AM
Esme committed rGdff922f39b9b: Reland [DebugInfo] Fix the mismatching between C++ language tags and Dwarf… (authored by Esme).
Reland [DebugInfo] Fix the mismatching between C++ language tags and Dwarf…
Mon, Apr 12, 4:07 AM
Esme added a comment to D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions..

This change has caused a test failure in lldb. On our Arm bots: http://lab.llvm.org:8011/#/builders/96/builds/6582
Also on Linux x86_64: http://lab.llvm.org:8011/#/builders/68/builds/10277

Not windows though because test/API/commands/frame/language/TestGuessLanguage.py is an expected failure there already.

Is there a mapping in lldb that needs to be updated as well?

Mon, Apr 12, 3:37 AM · debug-info, Restricted Project
Esme added a reverting change for rG62fa9b9388aa: [DebugInfo] Fix the mismatching between C++ language tags and Dwarf versions.: rGc965e14a1295: Revert "[DebugInfo] Fix the mismatching between C++ language tags and Dwarf….
Mon, Apr 12, 3:37 AM
Esme committed rGc965e14a1295: Revert "[DebugInfo] Fix the mismatching between C++ language tags and Dwarf… (authored by Esme).
Revert "[DebugInfo] Fix the mismatching between C++ language tags and Dwarf…
Mon, Apr 12, 3:37 AM
Esme added a reverting change for D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.: rGc965e14a1295: Revert "[DebugInfo] Fix the mismatching between C++ language tags and Dwarf….
Mon, Apr 12, 3:37 AM · debug-info, Restricted Project
Esme committed rG62fa9b9388aa: [DebugInfo] Fix the mismatching between C++ language tags and Dwarf versions. (authored by Esme).
[DebugInfo] Fix the mismatching between C++ language tags and Dwarf versions.
Mon, Apr 12, 12:43 AM
Esme closed D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions..
Mon, Apr 12, 12:43 AM · debug-info, Restricted Project

Thu, Apr 8

Esme committed rG79cade52ed94: [debug-info][NFC] Set -mtriple to avoid the test failure under other targets. (authored by Esme).
[debug-info][NFC] Set -mtriple to avoid the test failure under other targets.
Thu, Apr 8, 9:57 PM
Esme added a comment to D97656: [llvm-objcopy] Initial XCOFF32 support..

Good catch, thanks!

Seems the functionality of the llvm-objcopy is not right. Could you please help to check? And maybe we need to add some other tests for the file format.

1:

$ llvm-objcopy 32.o copy_nodebug.o
$ dump -X32 -tv copy_nodebug.o      
...
dump: copy_nodebug.o: dump: 0654-103 Cannot read from the specified file.
[6]     m   0x00000000     undef     1  extern                    **Invalid Symbol Name**
Thu, Apr 8, 2:12 AM · Restricted Project
Esme committed rG0c36da722aa5: [Debug-Info] Use inlined strings in .dwinfo section by default for DBX. (authored by Esme).
[Debug-Info] Use inlined strings in .dwinfo section by default for DBX.
Thu, Apr 8, 12:21 AM
Esme closed D99933: [Debug-Info] Use inlined strings in .dwinfo section by default for DBX..
Thu, Apr 8, 12:21 AM · Restricted Project

Wed, Apr 7

Esme added a comment to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Gentle ping.

Wed, Apr 7, 7:21 PM · Restricted Project
Esme updated the diff for D99933: [Debug-Info] Use inlined strings in .dwinfo section by default for DBX..

Removed unnecessary checks.

Wed, Apr 7, 7:11 PM · Restricted Project
Esme added inline comments to D99933: [Debug-Info] Use inlined strings in .dwinfo section by default for DBX..
Wed, Apr 7, 4:27 AM · Restricted Project
Esme updated the diff for D99933: [Debug-Info] Use inlined strings in .dwinfo section by default for DBX..

Addressed comments.

Wed, Apr 7, 4:27 AM · Restricted Project

Tue, Apr 6

Esme added inline comments to D99933: [Debug-Info] Use inlined strings in .dwinfo section by default for DBX..
Tue, Apr 6, 9:24 AM · Restricted Project
Esme updated the diff for D99933: [Debug-Info] Use inlined strings in .dwinfo section by default for DBX..
Tue, Apr 6, 9:11 AM · Restricted Project
Esme added a comment to D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions..

If there are no more comments, I'll commit the patch soon.
What do you think? @aprantl

Tue, Apr 6, 7:13 AM · debug-info, Restricted Project
Esme requested review of D99933: [Debug-Info] Use inlined strings in .dwinfo section by default for DBX..
Tue, Apr 6, 2:56 AM · Restricted Project

Thu, Apr 1

Esme added inline comments to D97656: [llvm-objcopy] Initial XCOFF32 support..
Thu, Apr 1, 12:10 AM · Restricted Project
Esme updated the diff for D97656: [llvm-objcopy] Initial XCOFF32 support..

Addressed @shchenz's comments and replace Buffe with streams based on D91028.

Thu, Apr 1, 12:08 AM · Restricted Project

Tue, Mar 30

Esme added inline comments to D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions..
Tue, Mar 30, 11:24 PM · debug-info, Restricted Project
Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Added const

Tue, Mar 30, 1:33 AM · Restricted Project

Mon, Mar 29

Esme added inline comments to D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions..
Mon, Mar 29, 11:40 PM · debug-info, Restricted Project
Esme updated the diff for D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions..

Addressed Zheng's comments.
Thank you all for your comments.
Since no DWARF consumers has dialect-specific behavior, the patch will proceed.

Mon, Mar 29, 11:40 PM · debug-info, Restricted Project
Esme added inline comments to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
Mon, Mar 29, 11:24 PM · Restricted Project
Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Thank you for your review! @jhenderson and @Higuoxing.
Looking forward to more comments from @hubert.reinterpretcast and MaskRay

Mon, Mar 29, 11:23 PM · Restricted Project

Wed, Mar 24

Esme added inline comments to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
Wed, Mar 24, 10:16 PM · Restricted Project
Esme added inline comments to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
Wed, Mar 24, 10:12 PM · Restricted Project
Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Addressed James's comments.

Wed, Mar 24, 10:12 PM · Restricted Project
Esme added a comment to D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions..

Thx! @aprantl The motivation of the patch came from the crash of tag name mismatching when using DBX under AIX. And modifying the debugger doesn't seem to make sense?

Wed, Mar 24, 7:32 PM · debug-info, Restricted Project
Esme retitled D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions. from [DebugInfo] Fix the C++ language tags for Dwarf versions. to [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions..
Wed, Mar 24, 2:52 AM · debug-info, Restricted Project
Esme requested review of D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions..
Wed, Mar 24, 2:48 AM · debug-info, Restricted Project

Tue, Mar 23

Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Only the .text, .data, .tdata, and STYP_DWARF sections have relocations.

Tue, Mar 23, 10:21 PM · Restricted Project
Esme updated the diff for D98003: [obj2yaml] Implement parsing sections and auxiliary entries of XCOFF..
Tue, Mar 23, 10:17 PM · Restricted Project
Esme requested review of D99164: [llvm-readobj] dump auxiliary entries for the C_DWARF, C_BLOCK and C_FCN symbols..
Tue, Mar 23, 3:02 AM · Restricted Project
Esme added inline comments to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
Tue, Mar 23, 2:27 AM · Restricted Project
Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Addressed jhenderson's comments.

Tue, Mar 23, 2:21 AM · Restricted Project

Thu, Mar 18

Esme added a comment to D98003: [obj2yaml] Implement parsing sections and auxiliary entries of XCOFF..

Gently ping.

Thu, Mar 18, 12:04 AM · Restricted Project
Esme added a comment to D97656: [llvm-objcopy] Initial XCOFF32 support..

Gently ping.

Thu, Mar 18, 12:02 AM · Restricted Project
Esme added a comment to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Gently ping.

Thu, Mar 18, 12:01 AM · Restricted Project

Mar 11 2021

Esme committed rGfafbdfe63bb0: [Debug-Info] Add names for the debug line prologue. (authored by Esme).
[Debug-Info] Add names for the debug line prologue.
Mar 11 2021, 8:47 PM
Esme closed D98383: [Debug-Info] Add names for the debug line prologue..
Mar 11 2021, 8:46 PM · Restricted Project

Mar 10 2021

Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Addressed @jhenderson 's comments.

Mar 10 2021, 7:20 PM · Restricted Project
Esme requested review of D98383: [Debug-Info] Add names for the debug line prologue..
Mar 10 2021, 7:18 PM · Restricted Project

Mar 8 2021

Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Update the parsing of address and flag of Section.

Mar 8 2021, 12:10 AM · Restricted Project

Mar 7 2021

Esme updated the diff for D97656: [llvm-objcopy] Initial XCOFF32 support..

Updated the test case.

Mar 7 2021, 6:56 PM · Restricted Project

Mar 4 2021

Esme added a reviewer for D98003: [obj2yaml] Implement parsing sections and auxiliary entries of XCOFF.: Restricted Project.
Mar 4 2021, 8:02 PM · Restricted Project
Esme requested review of D98003: [obj2yaml] Implement parsing sections and auxiliary entries of XCOFF..
Mar 4 2021, 8:01 PM · Restricted Project

Feb 28 2021

Esme requested review of D97656: [llvm-objcopy] Initial XCOFF32 support..
Feb 28 2021, 7:07 PM · Restricted Project

Feb 25 2021

Esme added a comment to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Thank you so much for your comments! @jhenderson They are very useful.

Feb 25 2021, 4:06 AM · Restricted Project
Esme updated the summary of D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
Feb 25 2021, 3:46 AM · Restricted Project
Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Addressed James's comments.

Feb 25 2021, 3:43 AM · Restricted Project

Feb 22 2021

Esme added a comment to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Thank you so much for reviewing this patch @jhenderson @MaskRay @hubert.reinterpretcast and sorry for the late reply. I was on vacation the last few weeks.
Here is the doc about the structure of XCOFF files: https://www.ibm.com/support/knowledgecenter/ssw_aix_72/filesreference/XCOFF.html
I am working on adding 64-bit support but the other tools this patch may depend on do not support 64-bit for now. All of this has to be done step by step.

Feb 22 2021, 10:13 PM · Restricted Project
Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
  1. Make more fields as possible optional.
  2. Test the behaviours when the key is omitted.
  3. Use the larger type for 32-bit and 64-bit.
Feb 22 2021, 9:43 PM · Restricted Project

Jan 27 2021

Esme retitled D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj. from [yaml2obj] Enable 32 bit XCOFF support. to [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
Jan 27 2021, 5:46 PM · Restricted Project

Jan 26 2021

Esme requested review of D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
Jan 26 2021, 9:31 PM · Restricted Project

Jan 13 2021

Esme committed rGff40fb07ad63: [PowerPC] Try to fold sqrt/sdiv test results with the branch. (authored by Esme).
[PowerPC] Try to fold sqrt/sdiv test results with the branch.
Jan 13 2021, 6:16 PM
Esme closed D94054: [PowerPC] Try to fold sqrt/sdiv test results with the branch..
Jan 13 2021, 6:16 PM · Restricted Project

Jan 11 2021

Esme updated the summary of D94054: [PowerPC] Try to fold sqrt/sdiv test results with the branch..
Jan 11 2021, 10:05 PM · Restricted Project

Jan 10 2021

Esme committed rGffa67873a3f9: [PowerPC] Add variants of 64-bit vector types for vec_sel. (authored by Esme).
[PowerPC] Add variants of 64-bit vector types for vec_sel.
Jan 10 2021, 7:56 PM
Esme closed D94162: [PowerPC] Add variants of 64-bit vector types for vec_sel..
Jan 10 2021, 7:56 PM · Restricted Project

Jan 6 2021

Esme requested review of D94162: [PowerPC] Add variants of 64-bit vector types for vec_sel..
Jan 6 2021, 2:28 AM · Restricted Project

Jan 5 2021

Esme added a comment to D94054: [PowerPC] Try to fold sqrt/sdiv test results with the branch..

It seems like this patch depends on another patch. Please don't forget to add the dependencies to the Phabricator reviews.

Jan 5 2021, 11:21 PM · Restricted Project
Esme updated the diff for D94054: [PowerPC] Try to fold sqrt/sdiv test results with the branch..

Addressed nemanjai's comments. :)

Jan 5 2021, 11:09 PM · Restricted Project
Esme abandoned D71891: [PowerPC] Exploit the rlwinm + rlwinm when "and" with constant.

D93894 covers this patch.

Jan 5 2021, 7:12 PM · Restricted Project
Esme abandoned D71893: [PowerPC] Exploit the rldicl + rldicr when "and" with constant.

D93894 covers this patch.

Jan 5 2021, 7:12 PM · Restricted Project
Esme added inline comments to D94054: [PowerPC] Try to fold sqrt/sdiv test results with the branch..
Jan 5 2021, 2:25 AM · Restricted Project
Esme updated the diff for D94054: [PowerPC] Try to fold sqrt/sdiv test results with the branch..

Leave the ISel of intrinsics to td.

Jan 5 2021, 2:25 AM · Restricted Project

Jan 4 2021

Esme requested review of D94054: [PowerPC] Try to fold sqrt/sdiv test results with the branch..
Jan 4 2021, 6:19 PM · Restricted Project

Dec 29 2020

Esme requested review of D93894: [PowerPC] Expand BitPermutation to handle cases of the single immediate 'and'..
Dec 29 2020, 2:27 AM · Restricted Project

Dec 23 2020

Esme added inline comments to D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..
Dec 23 2020, 12:06 AM · Restricted Project
Esme updated the diff for D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..

Addressed nemanjai's comments.

Dec 23 2020, 12:06 AM · Restricted Project

Dec 20 2020

Esme committed rG26d378b801fa: [PowerPC][NFC] Added assertion of shift exponent is too large for 'uint64_t'. (authored by Esme).
[PowerPC][NFC] Added assertion of shift exponent is too large for 'uint64_t'.
Dec 20 2020, 10:19 PM
Esme committed rG29eb3dcfe628: [PowerPC] Materialize i64 constants by enumerated patterns. (authored by Esme).
[PowerPC] Materialize i64 constants by enumerated patterns.
Dec 20 2020, 9:22 PM
Esme closed D92089: [PowerPC] Materialize i64 constants by enumerated patterns..
Dec 20 2020, 9:22 PM · Restricted Project
Esme requested review of D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..
Dec 20 2020, 7:28 PM · Restricted Project
Esme reopened D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..
Dec 20 2020, 7:27 PM · Restricted Project
Esme updated the diff for D90131: [PowerPC] Add folding patterns for rlwinm + andi_rec..

Rebase on D89855.

Dec 20 2020, 7:27 PM · Restricted Project
Esme updated the diff for D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..

Check if the register used can be forward.

Dec 20 2020, 6:29 PM · Restricted Project

Dec 19 2020

Esme added inline comments to D92089: [PowerPC] Materialize i64 constants by enumerated patterns..
Dec 19 2020, 1:54 AM · Restricted Project

Dec 18 2020

Esme added a comment to D90131: [PowerPC] Add folding patterns for rlwinm + andi_rec..

Ping.

Dec 18 2020, 1:27 AM · Restricted Project

Dec 16 2020

Esme added a reverting change for rG1c0941e1524f: [PowerPC] Extend folding RLWINM + RLWINM to post-RA.: rG2ea7210e3946: Revert "[PowerPC] Extend folding RLWINM + RLWINM to post-RA.".
Dec 16 2020, 9:13 AM
Esme committed rG2ea7210e3946: Revert "[PowerPC] Extend folding RLWINM + RLWINM to post-RA." (authored by Esme).
Revert "[PowerPC] Extend folding RLWINM + RLWINM to post-RA."
Dec 16 2020, 9:13 AM
Esme added a reverting change for D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA.: rG2ea7210e3946: Revert "[PowerPC] Extend folding RLWINM + RLWINM to post-RA.".
Dec 16 2020, 9:13 AM · Restricted Project

Dec 15 2020

Esme added inline comments to D92089: [PowerPC] Materialize i64 constants by enumerated patterns..
Dec 15 2020, 6:13 PM · Restricted Project
Esme updated the diff for D92089: [PowerPC] Materialize i64 constants by enumerated patterns..

Replaced some checks by isInt<>().

Dec 15 2020, 6:08 PM · Restricted Project

Dec 13 2020

Esme updated the diff for D92089: [PowerPC] Materialize i64 constants by enumerated patterns..

Updated documentations.

Dec 13 2020, 6:55 AM · Restricted Project

Dec 10 2020

Esme added inline comments to D92089: [PowerPC] Materialize i64 constants by enumerated patterns..
Dec 10 2020, 7:18 PM · Restricted Project
Esme added inline comments to D92089: [PowerPC] Materialize i64 constants by enumerated patterns..
Dec 10 2020, 4:44 AM · Restricted Project

Dec 9 2020

Esme added inline comments to D92089: [PowerPC] Materialize i64 constants by enumerated patterns..
Dec 9 2020, 6:27 AM · Restricted Project
Esme added inline comments to D92089: [PowerPC] Materialize i64 constants by enumerated patterns..
Dec 9 2020, 12:54 AM · Restricted Project

Dec 8 2020

Esme added a comment to D92089: [PowerPC] Materialize i64 constants by enumerated patterns..

I see most of the benefit is from llvm/test/CodeGen/PowerPC/constants-i64.ll. Does the benefit come from the same pattern or several ? And you'd better visit all the f64 and compare the new algorithm with old to make sure that, there is no deg.

Dec 8 2020, 9:36 PM · Restricted Project

Dec 7 2020

Esme committed rG49599cb1a20c: [PowerPC] Correct the bit-width definition for some imm operand in td. (authored by Esme).
[PowerPC] Correct the bit-width definition for some imm operand in td.
Dec 7 2020, 7:20 PM
Esme closed D91603: [PowerPC] Correct the bit-width definition for some imm operand in td..
Dec 7 2020, 7:20 PM · Restricted Project

Dec 6 2020

Esme committed rG28fdeea9522f: [PowerPC] Add support for intrinsics dcbfps and dcbstps in P10. (authored by Esme).
[PowerPC] Add support for intrinsics dcbfps and dcbstps in P10.
Dec 6 2020, 9:20 PM
Esme closed D91323: [PowerPC] Add support for intrinsics dcbfps and dcbstps in P10..
Dec 6 2020, 9:20 PM · Restricted Project
Esme added inline comments to D92089: [PowerPC] Materialize i64 constants by enumerated patterns..
Dec 6 2020, 7:06 PM · Restricted Project