Page MenuHomePhabricator

Esme (EsmeYi)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 7 2020, 12:06 AM (33 w, 2 d)

Recent Activity

Today

Esme planned changes to D90131: [PowerPC] Add folding patterns for rlwinm + andi_rec..
Thu, Nov 26, 10:23 PM · Restricted Project
Esme updated the diff for D90131: [PowerPC] Add folding patterns for rlwinm + andi_rec..

Added the situation of Mask == 0.

Thu, Nov 26, 7:55 PM · Restricted Project

Yesterday

Esme abandoned D88538: [PowerPC] Materialize the immediate that is Uint32 but not Int32..

Patch D92089 can cover this.

Wed, Nov 25, 6:04 PM · Restricted Project
Esme abandoned D88539: [PowerPC] Handle the constant with many trailing ones..

The patch D92089 can cover this.

Wed, Nov 25, 6:03 PM · Restricted Project
Esme updated the diff for D92089: [PowerPC] Materialize i64 constants by enumerated patterns..
Wed, Nov 25, 3:33 AM · Restricted Project
Esme requested review of D92089: [PowerPC] Materialize i64 constants by enumerated patterns..
Wed, Nov 25, 3:21 AM · Restricted Project

Tue, Nov 24

Esme added a comment to D91323: [PowerPC] Add support for intrinsics dcbfps and dcbstps in P10..

@steven.zhang I still have some doubts about the properties setting. According to the behavior described by ISA, it also includes the write operation?

Tue, Nov 24, 10:46 PM · Restricted Project
Esme updated the diff for D90131: [PowerPC] Add folding patterns for rlwinm + andi_rec..
Tue, Nov 24, 6:46 PM · Restricted Project

Mon, Nov 23

Esme updated the diff for D91323: [PowerPC] Add support for intrinsics dcbfps and dcbstps in P10..

According to ISA,

DCBF (Data Cache Block Flush) is treated as a Load, except that reference and change recording need not be done.

it is appropriate to set IntrReadMem, IntrArgMemOnly for these dcbf_ instructions.

Mon, Nov 23, 8:03 PM · Restricted Project
Esme updated the diff for D91603: [PowerPC] Correct the bit-width definition for some imm operand in td..
Mon, Nov 23, 5:36 AM · Restricted Project

Sat, Nov 21

Esme committed rG1c0941e1524f: [PowerPC] Extend folding RLWINM + RLWINM to post-RA. (authored by Esme).
[PowerPC] Extend folding RLWINM + RLWINM to post-RA.
Sat, Nov 21, 11:38 PM
Esme closed D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..
Sat, Nov 21, 11:38 PM · Restricted Project

Fri, Nov 20

Esme updated the diff for D91603: [PowerPC] Correct the bit-width definition for some imm operand in td..

Added test cases.

Fri, Nov 20, 12:34 AM · Restricted Project

Thu, Nov 19

Esme updated the diff for D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..

Updated as Zheng's suggestions.

Thu, Nov 19, 7:31 PM · Restricted Project

Wed, Nov 18

Esme committed rG163929d7a620: [NFC][POwerPC] Added testcases of constant-i64. (authored by Esme).
[NFC][POwerPC] Added testcases of constant-i64.
Wed, Nov 18, 2:15 AM

Tue, Nov 17

Esme requested review of D91603: [PowerPC] Correct the bit-width definition for some imm operand in td..
Tue, Nov 17, 1:45 AM · Restricted Project
Esme added a comment to D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..

I saw some testcases are removed compared with your committed version. Is there any reason?

Tue, Nov 17, 1:44 AM · Restricted Project

Mon, Nov 16

Esme committed rG8063905b0415: [NFC][PowerPC] Add testcase of constant-i64. (authored by Esme).
[NFC][PowerPC] Add testcase of constant-i64.
Mon, Nov 16, 8:50 PM
Esme added inline comments to D91323: [PowerPC] Add support for intrinsics dcbfps and dcbstps in P10..
Mon, Nov 16, 7:23 PM · Restricted Project

Fri, Nov 13

Esme planned changes to D88539: [PowerPC] Handle the constant with many trailing ones..
Fri, Nov 13, 12:43 AM · Restricted Project
Esme planned changes to D88538: [PowerPC] Materialize the immediate that is Uint32 but not Int32..
Fri, Nov 13, 12:43 AM · Restricted Project

Thu, Nov 12

Esme requested review of D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..
Thu, Nov 12, 9:41 PM · Restricted Project
Esme updated the diff for D91323: [PowerPC] Add support for intrinsics dcbfps and dcbstps in P10..

Added a BE line in the test.

Thu, Nov 12, 9:09 PM · Restricted Project
Esme added a reviewer for D91323: [PowerPC] Add support for intrinsics dcbfps and dcbstps in P10.: Restricted Project.
Thu, Nov 12, 12:23 AM · Restricted Project
Esme requested review of D91323: [PowerPC] Add support for intrinsics dcbfps and dcbstps in P10..
Thu, Nov 12, 12:23 AM · Restricted Project

Tue, Nov 10

Esme reopened D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..
Tue, Nov 10, 11:40 PM · Restricted Project
Esme updated the diff for D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..

In post-RA, if SrcMI also defines the register to be forwarded, we can only do the folding if SrcMI is going to be erased.
For example, SrcMI and MI can't not be folded in the scenario:

$r3 = RLWINM_rec $r3, 27, 5, 10, implicit-def $cr0
dead renamable $r3 = RLWINM_rec killed renamable $r3, 8, 5, 10, implicit-def $cr0
BLR8 implicit $lr8, implicit $rm, implicit killed $cr0

I've run the bootstrap-test as well as SEPC.

Tue, Nov 10, 11:39 PM · Restricted Project

Mon, Nov 9

Esme committed rG6e0ad5bc8c34: [PowerPC] Add an ISEL pattern for Mul with Imm. (authored by Esme).
[PowerPC] Add an ISEL pattern for Mul with Imm.
Mon, Nov 9, 10:54 PM
Esme closed D87384: [PowerPC] Add ISEL patterns for Mul with Imm..
Mon, Nov 9, 10:53 PM · Restricted Project

Thu, Nov 5

Esme added a comment to D87384: [PowerPC] Add ISEL patterns for Mul with Imm..

ping

Thu, Nov 5, 10:08 PM · Restricted Project

Tue, Nov 3

Esme added a reverting change for rG119ab2181e6e: [PowerPC] Extend folding RLWINM + RLWINM to post-RA.: rG5053eab89074: Revert "[PowerPC] Extend folding RLWINM + RLWINM to post-RA.".
Tue, Nov 3, 8:34 AM
Esme committed rG5053eab89074: Revert "[PowerPC] Extend folding RLWINM + RLWINM to post-RA." (authored by Esme).
Revert "[PowerPC] Extend folding RLWINM + RLWINM to post-RA."
Tue, Nov 3, 8:34 AM
Esme added a reverting change for D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA.: rG5053eab89074: Revert "[PowerPC] Extend folding RLWINM + RLWINM to post-RA.".
Tue, Nov 3, 8:34 AM · Restricted Project

Mon, Nov 2

Esme committed rG119ab2181e6e: [PowerPC] Extend folding RLWINM + RLWINM to post-RA. (authored by Esme).
[PowerPC] Extend folding RLWINM + RLWINM to post-RA.
Mon, Nov 2, 11:45 PM
Esme closed D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..
Mon, Nov 2, 11:44 PM · Restricted Project
Esme added a comment to D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..

Thanks for your reviews, and I apologize for not responding in time. I will commit this patch after all tests done.

Mon, Nov 2, 11:25 PM · Restricted Project
Esme committed rGb969dfe26f41: [NFC][PowerPC] Move the folding RLWINMs from ppc-mi-peephole to PPCInstrInfo. (authored by Esme).
[NFC][PowerPC] Move the folding RLWINMs from ppc-mi-peephole to PPCInstrInfo.
Mon, Nov 2, 10:30 PM
Esme closed D89846: [NFC][PowerPC] Move the folding RLWINMs from ppc-mi-peephole to PPCInstrInfo..
Mon, Nov 2, 10:30 PM · Restricted Project

Oct 25 2020

Esme requested review of D90131: [PowerPC] Add folding patterns for rlwinm + andi_rec..
Oct 25 2020, 9:48 PM · Restricted Project
Esme updated the diff for D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..
Oct 25 2020, 9:37 PM · Restricted Project
Esme added inline comments to D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..
Oct 25 2020, 8:45 PM · Restricted Project
Esme added inline comments to D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..
Oct 25 2020, 7:04 PM · Restricted Project
Esme updated the diff for D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..
Oct 25 2020, 6:48 PM · Restricted Project

Oct 23 2020

Esme updated the diff for D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..
Oct 23 2020, 12:30 AM · Restricted Project

Oct 22 2020

Esme updated the diff for D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..

Updated as Steven's comments.

Oct 22 2020, 12:15 AM · Restricted Project

Oct 21 2020

Esme updated the diff for D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..
Oct 21 2020, 10:27 PM · Restricted Project
Esme updated the diff for D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..
Oct 21 2020, 9:42 PM · Restricted Project
Esme requested review of D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..
Oct 21 2020, 12:51 AM · Restricted Project
Esme updated the diff for D89846: [NFC][PowerPC] Move the folding RLWINMs from ppc-mi-peephole to PPCInstrInfo..
Oct 21 2020, 12:30 AM · Restricted Project

Oct 20 2020

Esme committed rG9fbb060418e0: [NFC][PowerPC]Add tests for folding RLWINM before and after RA. (authored by Esme).
[NFC][PowerPC]Add tests for folding RLWINM before and after RA.
Oct 20 2020, 11:39 PM
Esme added a reviewer for D89846: [NFC][PowerPC] Move the folding RLWINMs from ppc-mi-peephole to PPCInstrInfo.: Restricted Project.
Oct 20 2020, 9:54 PM · Restricted Project
Esme requested review of D89846: [NFC][PowerPC] Move the folding RLWINMs from ppc-mi-peephole to PPCInstrInfo..
Oct 20 2020, 9:44 PM · Restricted Project

Oct 9 2020

Esme committed rGe9fd8823baf5: [DAGCombiner] Add decomposition patterns for Mul-by-Imm. (authored by Esme).
[DAGCombiner] Add decomposition patterns for Mul-by-Imm.
Oct 9 2020, 1:52 AM
Esme closed D88201: [DAGCombiner] Add decomposition patterns for Mul-by-Imm..
Oct 9 2020, 1:52 AM · Restricted Project

Oct 8 2020

Esme committed rGed956b46b078: [NFC][PowerPC] Supplement test cases for D88274. (authored by Esme).
[NFC][PowerPC] Supplement test cases for D88274.
Oct 8 2020, 7:33 PM

Oct 4 2020

Esme added inline comments to D88201: [DAGCombiner] Add decomposition patterns for Mul-by-Imm..
Oct 4 2020, 10:21 AM · Restricted Project
Esme committed rGe3475f5b91c8: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp). (authored by Esme).
[PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).
Oct 4 2020, 9:27 AM
Esme closed D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp)..
Oct 4 2020, 9:26 AM · Restricted Project, Restricted Project

Oct 1 2020

Esme updated the diff for D88201: [DAGCombiner] Add decomposition patterns for Mul-by-Imm..

@RKSimon Thanks. Updated.

Oct 1 2020, 8:02 PM · Restricted Project
Esme added inline comments to D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp)..
Oct 1 2020, 6:30 PM · Restricted Project, Restricted Project
Esme committed rGc4690b007743: [PowerPC] Put the CR field in low bits of GRC during copying CRRC to GRC. (authored by Esme).
[PowerPC] Put the CR field in low bits of GRC during copying CRRC to GRC.
Oct 1 2020, 6:27 PM
Esme closed D88274: [PowerPC] Put the CR field in low bits of GRC during copying CRRC to GRC..
Oct 1 2020, 6:27 PM · Restricted Project
Esme added a comment to D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp)..

Overall I think this LGTM.

Please correct me if I am wrong but I think the description of the functions need to be updated to:

int vec_test_swdiv(vector double v1, vector double v2);
int vec_test_swdivs(vector float v1, vector float v2);
int vec_test_swsqrt(vector double v1);
int vec_test_swsqrts(vector float v1);
Oct 1 2020, 6:24 PM · Restricted Project, Restricted Project
Esme updated the summary of D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp)..
Oct 1 2020, 6:22 PM · Restricted Project, Restricted Project
Esme added a comment to D87384: [PowerPC] Add ISEL patterns for Mul with Imm..

Looking forward to your further comments :) @jsji @nemanjai

Oct 1 2020, 9:30 AM · Restricted Project
Esme added a comment to D88274: [PowerPC] Put the CR field in low bits of GRC during copying CRRC to GRC..

LGTM too. Thanks for sharing the background. Before committing this, it's better to update the description for later reference like @nemanjai pointed out?

Oct 1 2020, 9:11 AM · Restricted Project
Esme updated the summary of D88274: [PowerPC] Put the CR field in low bits of GRC during copying CRRC to GRC..
Oct 1 2020, 9:07 AM · Restricted Project
Esme updated the summary of D88274: [PowerPC] Put the CR field in low bits of GRC during copying CRRC to GRC..
Oct 1 2020, 8:56 AM · Restricted Project

Sep 30 2020

Esme requested review of D88539: [PowerPC] Handle the constant with many trailing ones..
Sep 30 2020, 1:25 AM · Restricted Project
Esme requested review of D88538: [PowerPC] Materialize the immediate that is Uint32 but not Int32..
Sep 30 2020, 1:11 AM · Restricted Project

Sep 29 2020

Esme added a reviewer for D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).: nemanjai.
Sep 29 2020, 7:26 PM · Restricted Project, Restricted Project
Esme added a comment to D88274: [PowerPC] Put the CR field in low bits of GRC during copying CRRC to GRC..

LGTM. The code here is correct, but I do have a couple of questions:

  1. Do these copies come up in real code? And if so, under which circumstances. We don't have copies in the other direction implemented, so that makes me wonder when these ever come up.
  2. Does this solve a problem seen in real code? If so, is there a bugzilla report? At the very least, the conditions under which this causes a problem should be added to the description.
  3. Is there any follow up required/planned for this?
Sep 29 2020, 7:25 PM · Restricted Project
Esme added reviewers for D88201: [DAGCombiner] Add decomposition patterns for Mul-by-Imm.: lebedev.ri, arsenm, craig.topper.
Sep 29 2020, 3:28 AM · Restricted Project

Sep 28 2020

Esme updated the diff for D88274: [PowerPC] Put the CR field in low bits of GRC during copying CRRC to GRC..

Skip rotation if CR7.

Sep 28 2020, 11:12 PM · Restricted Project

Sep 24 2020

Esme added a reviewer for D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).: Restricted Project.
Sep 24 2020, 10:42 PM · Restricted Project, Restricted Project
Esme requested review of D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp)..
Sep 24 2020, 10:41 PM · Restricted Project, Restricted Project
Esme updated the summary of D88274: [PowerPC] Put the CR field in low bits of GRC during copying CRRC to GRC..
Sep 24 2020, 7:55 PM · Restricted Project
Esme requested review of D88274: [PowerPC] Put the CR field in low bits of GRC during copying CRRC to GRC..
Sep 24 2020, 7:54 PM · Restricted Project
Esme updated the diff for D87384: [PowerPC] Add ISEL patterns for Mul with Imm..

Format.

Sep 24 2020, 3:08 AM · Restricted Project
Esme retitled D88201: [DAGCombiner] Add decomposition patterns for Mul-by-Imm. from [PowerPC] Add patterns for Mul-by-Imm in DAGCombiner. to [DAGCombiner][PowerPC] Add decomposition patterns for Mul-by-Imm..
Sep 24 2020, 1:38 AM · Restricted Project
Esme added a comment to D87384: [PowerPC] Add ISEL patterns for Mul with Imm..

Thank you so much for your comments. :D @jsji @nemanjai
I have post another patch D88201 to handle scenario 2 and 3 in DAGCombiner.

Sep 24 2020, 1:36 AM · Restricted Project
Esme updated the diff for D87384: [PowerPC] Add ISEL patterns for Mul with Imm..
Sep 24 2020, 1:32 AM · Restricted Project
Esme requested review of D88201: [DAGCombiner] Add decomposition patterns for Mul-by-Imm..
Sep 24 2020, 12:54 AM · Restricted Project
Esme updated the summary of D87384: [PowerPC] Add ISEL patterns for Mul with Imm..
Sep 24 2020, 12:29 AM · Restricted Project
Esme updated the diff for D87384: [PowerPC] Add ISEL patterns for Mul with Imm..

Update comments.

Sep 24 2020, 12:29 AM · Restricted Project

Sep 23 2020

Esme added a comment to D87384: [PowerPC] Add ISEL patterns for Mul with Imm..

Hi @jsji An infinite loop will occur if we handle the scenario 1 (mul X, c2 << c1) -> (shl (mul X, c2), c1) in DAGCombiner, because there exists a reverse conversion (shl (mul x, c1), c2) -> (mul x, c1 << c2).

Sep 23 2020, 12:55 AM · Restricted Project

Sep 22 2020

Esme updated the diff for D87384: [PowerPC] Add ISEL patterns for Mul with Imm..

Keep the scenario 1 implemented in ISEL.
For scenario 2 and 3, I will post another patch to implement them in DAGCombiner.

Sep 22 2020, 4:01 AM · Restricted Project
Esme committed rGc7ff6e0fe1cd: [NFC][PowerPC]Add tests for multiply-by-constant. (authored by Esme).
[NFC][PowerPC]Add tests for multiply-by-constant.
Sep 22 2020, 3:26 AM

Sep 21 2020

Esme added a comment to D87384: [PowerPC] Add ISEL patterns for Mul with Imm..

Thank you for your comments! @jsji @nemanjai

Sep 21 2020, 8:32 PM · Restricted Project

Sep 11 2020

Esme committed rG525c83cee00a: [NFC][PowerPC] Add tests of constants-i64. (authored by Esme).
[NFC][PowerPC] Add tests of constants-i64.
Sep 11 2020, 12:18 AM

Sep 9 2020

Esme commandeered D81819: [PowerPC] Add InstAlias for those Rotate Instructions.
Sep 9 2020, 11:41 PM · Restricted Project
Esme updated the summary of D87384: [PowerPC] Add ISEL patterns for Mul with Imm..
Sep 9 2020, 7:45 PM · Restricted Project
Esme requested review of D87384: [PowerPC] Add ISEL patterns for Mul with Imm..
Sep 9 2020, 8:12 AM · Restricted Project

Sep 7 2020

Esme committed rGa5046f7acece: [NFC][PowerPC] Add tests in constants-i64.ll. (authored by Esme).
[NFC][PowerPC] Add tests in constants-i64.ll.
Sep 7 2020, 6:15 AM
Esme committed rGee68b66d94b5: [NFC][PowerPC] Add tests for `mul` with big constants. (authored by Esme).
[NFC][PowerPC] Add tests for `mul` with big constants.
Sep 7 2020, 2:46 AM

Jul 30 2020

Esme committed rG141b64a340a4: [NFC] Failed cases for some patterns defined in DAGCombiner.cpp (authored by Esme).
[NFC] Failed cases for some patterns defined in DAGCombiner.cpp
Jul 30 2020, 3:09 AM

Jul 6 2020

Esme committed rG0607c8df7faf: [PowerPC] Legalize SREM/UREM directly on P9. (authored by Esme).
[PowerPC] Legalize SREM/UREM directly on P9.
Jul 6 2020, 4:48 AM
Esme closed D82145: [PowerPC] Legalize SREM/UREM directly on P9..
Jul 6 2020, 4:48 AM · Restricted Project
Esme retitled D82145: [PowerPC] Legalize SREM/UREM directly on P9. from [NFC][PowerPC] Legalize SREM/UREM directly on P9. to [PowerPC] Legalize SREM/UREM directly on P9..
Jul 6 2020, 3:37 AM · Restricted Project

Jun 28 2020

Esme updated the diff for D82145: [PowerPC] Legalize SREM/UREM directly on P9..

Update predictions for test cases.

Jun 28 2020, 7:48 PM · Restricted Project