User Details
- User Since
- Apr 7 2020, 12:06 AM (154 w, 5 d)
Thu, Mar 23
Wed, Mar 22
Sun, Mar 19
Address comment -- use fixup_ppc_nofixup instead of FK_NONE to tie the ref symbol.
Thu, Mar 16
Wed, Mar 8
Add a Fixup of kind FK_NONE to later record a relocation of type R_REF.
Tue, Mar 7
Mon, Mar 6
Address comment.
Sun, Mar 5
Mon, Feb 27
Thanks for fixing the failure. The changes LGTM.
Feb 23 2023
Feb 20 2023
Feb 19 2023
Feb 14 2023
Please include as much context as possible with your diff. https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
Feb 12 2023
Rebase.
LIT, LNT and Bootstrap are clean.
Feb 7 2023
Jan 31 2023
Jan 11 2023
Addressed comments.
Jan 10 2023
Jan 9 2023
Jan 8 2023
Addressed comments.
Changed the Fixup Value for TOC direct external symbols and added test lines for it in toc-data-const.ll.
Addressed comments and verified the materialization results.
However, I can't find a proper instruction to turn 0xABCD ADDD ABCD ADDD into 0xABCD ABCD ABCD ADDD, ie. modify Lo16OfHi32 (bits 32...47), so I didn't handle the pattern like 0xABCD ABCD ABCD ADDD.
Jan 4 2023
Addressed comments except for the FixupValue for external TOC data.
Dec 21 2022
ping
Addressed comments.
Didn't find a better way instead of looping through to find the corresponding overflow section.
Dec 14 2022
Dec 12 2022
Address comments.
Dec 11 2022
LGTM. Thanks!
Dec 9 2022
LGTM. Thx.
LGTM. Thank you for fixing it.
Dec 8 2022
Dec 7 2022
Addressed comments. Thanks @DiggerLin and @shchenz
Btw. Do you have any plans to implement an option like "--loader-section" to embrace all this loader section related information?
Feel sorry that i'm just getting started to review this patch.
I've applied the patch and test the functionality and it looks good overall. Thanks.
However, considering the printing format of relocations in llvm-readobj, when --expand-relocs is not specified, we usually print relocations in this format:
vaddr section type symbol 20000294 2 POS .data 2000029c 2 POS 0
Only when --expand-relocs is specified, we print relocations like the format in this patch.
The --dyn-relocations option also follows such rule.
Dec 6 2022
Update the comments.
Hi @DiggerLin, thank you for your review. I'm also confused by the description from the doc, if my understanding is correct, according to the doc, the FixedValue will ignore the value of Fixup.getOffset(), because the address of the csect containing the branch instruction to be modified equals to SectionMap[ParentSec]->Address + Layout.getFragmentOffset(Fragment). This is obviously incorrect. I have tested LNT and bootstrap for this patch under the options of -fintegrated-as -ffunction-sections, and both are clean.
Dec 5 2022
Addressed comments.
Dec 4 2022
Rebase on latest commit.
FYI. I committed an NFC patch rG664cbfaf07e0 to format this patch.
Addressed comments.
Nov 29 2022
Nov 22 2022
Nov 20 2022
Nov 15 2022
Nov 13 2022
Addressed comments.
Thx @hubert.reinterpretcast and @DiggerLin
Nov 11 2022
Addressed comments.
Thx @DiggerLin
Nov 6 2022
Nov 3 2022
Clean test failure.
Nov 2 2022
Oct 30 2022
Oct 28 2022
Sorry for the late reply, in fact I'm not quite sure about using the existing --dyn-syms option or adding an XCOFF specific one, so I wait to see what others think.
I noticed that the objdump from AIX system tool kits prints the loader section (together with its symbols and relocations) with the XCOFF specific option -P loader:
Oct 26 2022
Oct 24 2022
Update comments.
Oct 23 2022
The bootstrap test is clean.
Oct 20 2022
The symbols in the loader section should be the dynamic symbols in the general definition, so is it possible to use the original option --dyn-syms, and then implement the defined interface XCOFFDumper::printDynamicSymbols()?
LGTM. Thanks for your work.
Sep 28 2022
Apologize for the late update due to some compiler-rt errors occurred. I'm working on fixing it.
Sep 20 2022
LGTM. Thx!