Page MenuHomePhabricator

daltenty (David Tenty)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 4 2019, 2:54 PM (163 w, 3 d)

Recent Activity

Fri, May 20

daltenty accepted D125923: [libc++][CI] fixed convert_thousands_sep_ru_RU for Russian in the libcxx/test/support/locale_helpers.h for AIX.

LGTM, thanks!

Fri, May 20, 12:23 PM · Restricted Project, Restricted Project

Wed, May 18

daltenty accepted D125801: [libc++][CI] fixed a return curr_symbol() for Russian in the libcxx/test/support/locale_helpers.h for AIX.

LGTM, thanks!

Wed, May 18, 6:40 AM · Restricted Project, Restricted Project

Wed, May 11

daltenty added a reverting change for rGf5a9b5cc1265: [NFC][tests][AIX] XFAIL test for lack of visibility support: rG9519dacab7b8: Revert "[NFC][tests][AIX] XFAIL test for lack of visibility support".
Wed, May 11, 5:49 PM · Restricted Project, Restricted Project
daltenty committed rG9519dacab7b8: Revert "[NFC][tests][AIX] XFAIL test for lack of visibility support" (authored by daltenty).
Revert "[NFC][tests][AIX] XFAIL test for lack of visibility support"
Wed, May 11, 5:49 PM · Restricted Project, Restricted Project
daltenty added a reverting change for D122519: [NFC][tests][AIX] XFAIL test for lack of visibility support: rG9519dacab7b8: Revert "[NFC][tests][AIX] XFAIL test for lack of visibility support".
Wed, May 11, 5:48 PM · Restricted Project, Restricted Project
daltenty added a comment to D122519: [NFC][tests][AIX] XFAIL test for lack of visibility support.

Resolved by https://reviews.llvm.org/D125141

Wed, May 11, 5:46 PM · Restricted Project, Restricted Project
daltenty added a comment to D125141: [clang][AIX] Don't ignore XCOFF visibility by default.
Wed, May 11, 5:46 PM · Restricted Project, Restricted Project
daltenty committed rGd9c1d3cbcb97: [clang][AIX] Don't ignore XCOFF visibility by default (authored by daltenty).
[clang][AIX] Don't ignore XCOFF visibility by default
Wed, May 11, 10:29 AM · Restricted Project, Restricted Project
daltenty closed D125141: [clang][AIX] Don't ignore XCOFF visibility by default.
Wed, May 11, 10:28 AM · Restricted Project, Restricted Project

Fri, May 6

daltenty added reviewers for D125141: [clang][AIX] Don't ignore XCOFF visibility by default: hubert.reinterpretcast, cebowleratibm, DiggerLin.
Fri, May 6, 4:20 PM · Restricted Project, Restricted Project
daltenty updated the diff for D125141: [clang][AIX] Don't ignore XCOFF visibility by default.

Differentiate between inlines hidden and regular visibility in test

Fri, May 6, 4:19 PM · Restricted Project, Restricted Project
daltenty requested review of D125141: [clang][AIX] Don't ignore XCOFF visibility by default.
Fri, May 6, 3:56 PM · Restricted Project, Restricted Project
daltenty accepted D124227: [libcxx] Remove static inline and make use of _LIBCPP_HIDE_FROM_ABI in __support headers.

Any guidance as to how I should proceed?

Fri, May 6, 2:48 PM · Restricted Project, Restricted Project

Thu, Apr 28

daltenty committed rGa70cf56d20b9: Reland: [clang] Adding Platform/Architecture Specific Resource Header… (authored by qiongsiwu1).
Reland: [clang] Adding Platform/Architecture Specific Resource Header…
Thu, Apr 28, 9:04 PM · Restricted Project, Restricted Project
daltenty committed rG8042699a3088: [LLVM] Add exported visibility style for XCOFF (authored by daltenty).
[LLVM] Add exported visibility style for XCOFF
Thu, Apr 28, 11:57 AM · Restricted Project, Restricted Project
daltenty closed D123951: [LLVM][AIX] Implement XCOFF exported visibility.
Thu, Apr 28, 11:56 AM · Restricted Project, Restricted Project
daltenty updated the diff for D123951: [LLVM][AIX] Implement XCOFF exported visibility.

Make assert for mixed non-export visibility and dllexport a fatal error

Thu, Apr 28, 11:51 AM · Restricted Project, Restricted Project
daltenty updated the summary of D123951: [LLVM][AIX] Implement XCOFF exported visibility.
Thu, Apr 28, 6:48 AM · Restricted Project, Restricted Project
daltenty updated the summary of D123951: [LLVM][AIX] Implement XCOFF exported visibility.
Thu, Apr 28, 6:47 AM · Restricted Project, Restricted Project

Wed, Apr 27

daltenty accepted D124519: [libcxx] Switch __cxx_contention_t to int32_t on 32 bit AIX.

LGTM, we haven't shipped any of the C++17 and up interfaces on AIX yet, so this seem fine to me.

Wed, Apr 27, 7:15 AM · Restricted Project, Restricted Project
daltenty committed rG6e8dda047fe0: [NFC] XFAIL tests which need visibility in XCOFF objectwriting (authored by daltenty).
[NFC] XFAIL tests which need visibility in XCOFF objectwriting
Wed, Apr 27, 6:32 AM · Restricted Project, Restricted Project

Tue, Apr 26

daltenty committed rGf6d209b3ec4c: [AIX][XCOFF] error on emit symbol visibility for XCOFF object file (authored by daltenty).
[AIX][XCOFF] error on emit symbol visibility for XCOFF object file
Tue, Apr 26, 4:23 PM · Restricted Project, Restricted Project
daltenty closed D124392: [AIX][XCOFF] error on emit symbol visibility for XCOFF object file .
Tue, Apr 26, 4:23 PM · Restricted Project, Restricted Project
daltenty added a comment to D124375: [runtimes] [cmake] Fix -Werror detection in common build configs.

@daltenty - what do you want to do about it? Add LIBCXX_ENABLE_WERROR=OFF in the AIX build config (which also would affect the 64 bit build), do silence it differently somehow?

Tue, Apr 26, 3:09 PM · Restricted Project, Restricted Project, Restricted Project
daltenty added a comment to D124165: [libcxx][AIX] Enable ABI list checking for XCOFF.

@ldionne It's worth noting what's in this patch right now won't be our final ABI lists unfortunately. Our build compiler currently doesn't implement visibility support, so _LIBCPP_HIDE_FROM_ABI and friends don't have the intended effect. We're actively working on visibility for LLVM 15, but until that is all in we won't have a build compiler that can generate a stable ABI.

Tue, Apr 26, 2:24 PM · Restricted Project, Restricted Project

Mon, Apr 25

daltenty added a comment to D124227: [libcxx] Remove static inline and make use of _LIBCPP_HIDE_FROM_ABI in __support headers.

This change seems ok in principal, but these functions are extern 'C", so now that they're no longer internal linkage they'll provide the same symbol as the real thing. Adding such functions with linkable POSIX reserved names into user program seems like we are asking for trouble. Can we get these moved into some kind of namespace or at least with some kind of double underscore prefix?

Mon, Apr 25, 8:31 PM · Restricted Project, Restricted Project
daltenty updated the diff for D123951: [LLVM][AIX] Implement XCOFF exported visibility.

Make MCWasmStreamer ignore MCSA_Exported

Mon, Apr 25, 8:56 AM · Restricted Project, Restricted Project
daltenty requested review of D124392: [AIX][XCOFF] error on emit symbol visibility for XCOFF object file .
Mon, Apr 25, 8:01 AM · Restricted Project, Restricted Project

Apr 22 2022

daltenty updated the diff for D123951: [LLVM][AIX] Implement XCOFF exported visibility.

Update the patch based on feedback on the RFC (https://discourse.llvm.org/t/rfc-adding-exported-visibility-style-to-the-ir-to-model-xcoff-exported-visibility/61853/8). There seem to be limited visibility bits, and the implementation has kind of reserved space for internal, so adding exported may cause problems. On the other hand dllexport appears to match the semantic and currently only be used as a marker to indicate to some passes that we should preserve the symbol since it will be exported from shared objects (which is exactly what we want too), so I've updated the implementation as suggested to use dllexport instead.

Apr 22 2022, 10:40 AM · Restricted Project, Restricted Project
daltenty retitled D123951: [LLVM][AIX] Implement XCOFF exported visibility from [LLVM] Add exported visibility-style to IR for XCOFF to [LLVM][AIX] Implement XCOFF exported visibility.
Apr 22 2022, 10:37 AM · Restricted Project, Restricted Project

Apr 21 2022

daltenty added a comment to D122983: [C11/C2x] Change the behavior of the implicit function declaration warning.

Hi, we also have a failure on AIX with test-suite call to undeclared library function '%0' with type %1; ISO C99 and later https://lab.llvm.org/buildbot/#/builders/214/builds/825/steps/9/logs/stdio

Thanks for letting me know, this should now be fixed.

Apr 21 2022, 9:31 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
daltenty added a comment to D124165: [libcxx][AIX] Enable ABI list checking for XCOFF.

It's something unique to AIX that we add shared objects to archives for our usual shared library implementation. I'm guessing with this implementation of the patch, we'll end up dumping all symbols together regardless of what archive member they belong to?

Apr 21 2022, 7:38 AM · Restricted Project, Restricted Project
daltenty accepted D124174: [libc++][CI] added XFAIL LIBCXX-AIX-FIXME to new runnning test cases after install locale on AIX OS..

LGTM, thanks!

Apr 21 2022, 7:31 AM · Restricted Project, Restricted Project

Apr 20 2022

daltenty added a comment to D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins..

Thanks for getting this fixed this so quickly and sorry for the messy revert.

Apr 20 2022, 6:45 PM · Restricted Project, Restricted Project
daltenty committed rGaa643f455a53: Fixup D123950 to address revert of D123345 (authored by daltenty).
Fixup D123950 to address revert of D123345
Apr 20 2022, 4:59 PM · Restricted Project, Restricted Project
daltenty added a reverting change for rGb27430f9f46b: Treat `std::move`, `forward`, etc. as builtins.: rG98d911e01f3a: Revert "Treat `std::move`, `forward`, etc. as builtins.".
Apr 20 2022, 4:15 PM · Restricted Project, Restricted Project
daltenty committed rG98d911e01f3a: Revert "Treat `std::move`, `forward`, etc. as builtins." (authored by daltenty).
Revert "Treat `std::move`, `forward`, etc. as builtins."
Apr 20 2022, 4:15 PM · Restricted Project, Restricted Project
daltenty added a reverting change for rGe43c93dd63cc: Don't treat 'T &forward(T&&)' as builtin.: rGde6ddaeef3aa: Revert "Don't treat 'T &forward(T&&)' as builtin.".
Apr 20 2022, 4:15 PM · Restricted Project, Restricted Project, Restricted Project
daltenty committed rGde6ddaeef3aa: Revert "Don't treat 'T &forward(T&&)' as builtin." (authored by daltenty).
Revert "Don't treat 'T &forward(T&&)' as builtin."
Apr 20 2022, 4:15 PM · Restricted Project, Restricted Project, Restricted Project
daltenty added a reverting change for D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.: rG98d911e01f3a: Revert "Treat `std::move`, `forward`, etc. as builtins.".
Apr 20 2022, 4:15 PM · Restricted Project, Restricted Project
daltenty added a comment to D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins..

Hi, unfortunately there's a build failure on AIX: https://lab.llvm.org/buildbot/#/builders/214/builds/779/steps/9/logs/stdio. Could you take a look?

Apr 20 2022, 2:30 PM · Restricted Project, Restricted Project

Apr 19 2022

daltenty updated the diff for D123951: [LLVM][AIX] Implement XCOFF exported visibility.

Address review comments

Apr 19 2022, 3:52 PM · Restricted Project, Restricted Project
daltenty added inline comments to D123951: [LLVM][AIX] Implement XCOFF exported visibility.
Apr 19 2022, 3:51 PM · Restricted Project, Restricted Project
daltenty committed rG2512a875ccac: [clang] Adding Platform/Architecture Specific Resource Header Installation… (authored by qiongsiwu1).
[clang] Adding Platform/Architecture Specific Resource Header Installation…
Apr 19 2022, 7:10 AM · Restricted Project, Restricted Project
daltenty closed D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets.
Apr 19 2022, 7:10 AM · Restricted Project, Restricted Project

Apr 18 2022

daltenty requested review of D123951: [LLVM][AIX] Implement XCOFF exported visibility.
Apr 18 2022, 10:57 AM · Restricted Project, Restricted Project

Mar 23 2022

daltenty accepted D122316: Guard visibility variables on AIX.

LGTM as an interm fix. We'll revert and replace this once we have a fix in Google Benchmark.

Mar 23 2022, 11:46 AM · Restricted Project
daltenty added a comment to D122316: Guard visibility variables on AIX.

Right. But that's not the question i asked, i believe?

Mar 23 2022, 8:41 AM · Restricted Project
daltenty added a comment to D122316: Guard visibility variables on AIX.

Please can you submit this upstream first?

Mar 23 2022, 7:59 AM · Restricted Project

Mar 15 2022

daltenty accepted D121709: [NFC][AIX] Disable precompiled module file test on AIX.

LGTM, thanks!

Mar 15 2022, 11:11 AM · Restricted Project, Restricted Project

Mar 7 2022

daltenty accepted D121140: [libc++][AIX] AIX allows for changing permissions of symlinks.

LGTM, similarly to the other platforms indicated the bits can be set through the filesystem interface (though our chmod -h is a no-op)

Mar 7 2022, 2:15 PM · Restricted Project, Restricted Project
daltenty added a comment to D120162: [libcxx][test] Test visibility option before using it.

We could pass the linker an export list with the desired visibility for the functions in test on AIX if we need the visibility for the test. This is likely what we'll have to do in other places in libc++ until clang on AIX has real visibility support.

Mar 7 2022, 10:15 AM · Restricted Project, Restricted Project
daltenty accepted D121081: [libcxx][AIX] Remove `LIBCXX-AIX-FIXME` in isalwayslockfree check after 86478c7ad8a7.
Mar 7 2022, 10:05 AM · Restricted Project, Restricted Project
daltenty updated the diff for D114805: [NFC][libc++] Recognize int128 as an ABI affecting property.

Rename remaining ABI lists

Mar 7 2022, 9:41 AM · Restricted Project, Restricted Project

Mar 4 2022

daltenty updated the diff for D114805: [NFC][libc++] Recognize int128 as an ABI affecting property.

Rebase to trigger CI

Mar 4 2022, 8:41 PM · Restricted Project, Restricted Project
daltenty added a comment to D114805: [NFC][libc++] Recognize int128 as an ABI affecting property.

I trust that you're right when you say it affects the ABI, but do you have an example (I'm sure there's many, I just can't think of one right now).

Mar 4 2022, 8:39 PM · Restricted Project, Restricted Project
Herald added a project to D114805: [NFC][libc++] Recognize int128 as an ABI affecting property: Restricted Project.

Gentle ping

Mar 4 2022, 8:36 AM · Restricted Project, Restricted Project

Mar 1 2022

daltenty committed rGf642436cc213: [libc++][AIX] Use C++ overloads from libc++'s math.h (authored by daltenty).
[libc++][AIX] Use C++ overloads from libc++'s math.h
Mar 1 2022, 12:54 PM · Restricted Project
daltenty closed D102172: [libc++][AIX] Use C++ overloads from libc++'s math.h.
Mar 1 2022, 12:54 PM · Restricted Project, Restricted Project
daltenty updated the diff for D102172: [libc++][AIX] Use C++ overloads from libc++'s math.h.

Rebase to retrigger CI

Mar 1 2022, 11:29 AM · Restricted Project, Restricted Project
daltenty added a comment to D102172: [libc++][AIX] Use C++ overloads from libc++'s math.h.

Gentle ping

Mar 1 2022, 7:54 AM · Restricted Project, Restricted Project

Feb 25 2022

daltenty added inline comments to D119109: [clang][AIX] Enable LTO and teach the driver to pass options to the plugin.
Feb 25 2022, 3:12 PM · Restricted Project
daltenty updated the diff for D119109: [clang][AIX] Enable LTO and teach the driver to pass options to the plugin.

clang-format

Feb 25 2022, 1:05 PM · Restricted Project
daltenty added a reviewer for D119109: [clang][AIX] Enable LTO and teach the driver to pass options to the plugin: w2yehia.
Feb 25 2022, 11:50 AM · Restricted Project
daltenty updated the diff for D119109: [clang][AIX] Enable LTO and teach the driver to pass options to the plugin.

clang-format

Feb 25 2022, 11:27 AM · Restricted Project

Feb 24 2022

daltenty accepted D119770: [libcxx] Fix the type in __estimate_column_width.
Feb 24 2022, 10:49 AM · Restricted Project

Feb 17 2022

daltenty accepted D119982: [libc++][AIX] Add AIX error message as expected output.

LGTM, just copying the longer rational why the message is expected on AIX.

Feb 17 2022, 8:53 AM · Restricted Project

Feb 16 2022

daltenty accepted D119952: [libc++][AIX] Fix trivial_abi return tests for unique_ptr/weak_ptr.

LGTM, thanks!

Feb 16 2022, 11:03 AM · Restricted Project
daltenty updated the diff for D119109: [clang][AIX] Enable LTO and teach the driver to pass options to the plugin.

Add back in CmdArgs.push_back(Args.MakeArgString(Plugin)) that got accidentally removed

Feb 16 2022, 7:33 AM · Restricted Project

Feb 15 2022

daltenty updated the diff for D119109: [clang][AIX] Enable LTO and teach the driver to pass options to the plugin.
  • Rebase
  • incorporate suggestion from review
  • add fuse-ld=ld to debugger tuning test, to make it invariant when running on platforms that might use ldd by default
Feb 15 2022, 9:19 PM · Restricted Project
daltenty added a comment to D102172: [libc++][AIX] Use C++ overloads from libc++'s math.h.

@ldionne gentle ping. I think we've addressed your previous concerns here. We've moved responsibility for setting the macro to suppress the AIX libc definitions to the compiler side as you suggested in D109078, so this patch should hopefully be non-controversial now.

Feb 15 2022, 10:59 AM · Restricted Project, Restricted Project
daltenty updated the diff for D119107: [NFCI][clang][driver] Identify LTO plugin types and refine opt passing.

clang-format

Feb 15 2022, 9:28 AM
daltenty added inline comments to D119109: [clang][AIX] Enable LTO and teach the driver to pass options to the plugin.
Feb 15 2022, 7:41 AM · Restricted Project
daltenty added a reviewer for D119107: [NFCI][clang][driver] Identify LTO plugin types and refine opt passing: MaskRay.
Feb 15 2022, 7:13 AM
daltenty updated the diff for D119107: [NFCI][clang][driver] Identify LTO plugin types and refine opt passing.

Add missing semicolon

Feb 15 2022, 7:01 AM

Feb 14 2022

daltenty updated the diff for D119107: [NFCI][clang][driver] Identify LTO plugin types and refine opt passing.

Change seperator option type to bool

Feb 14 2022, 8:36 AM
daltenty added inline comments to D119107: [NFCI][clang][driver] Identify LTO plugin types and refine opt passing.
Feb 14 2022, 8:34 AM

Feb 8 2022

daltenty updated the summary of D102172: [libc++][AIX] Use C++ overloads from libc++'s math.h.
Feb 8 2022, 3:03 PM · Restricted Project, Restricted Project
daltenty updated the diff for D102172: [libc++][AIX] Use C++ overloads from libc++'s math.h.

Add additional context

Feb 8 2022, 10:41 AM · Restricted Project, Restricted Project
daltenty added a comment to D102172: [libc++][AIX] Use C++ overloads from libc++'s math.h.

@daltenty Can you please update the patch to include more *Context*, looks like the Context not available. Or use arc to update it. Thanks.

In case it's needed: The command I use to get context in my diffs (without using arc) is git show -U999 HEAD >filetoupload.diff (or replace HEAD with whatever-commit-hash).

Feb 8 2022, 10:40 AM · Restricted Project, Restricted Project

Feb 7 2022

daltenty edited reviewers for D102172: [libc++][AIX] Use C++ overloads from libc++'s math.h, added: jsji; removed: jasonliu.
Feb 7 2022, 9:13 PM · Restricted Project, Restricted Project
daltenty updated the diff for D102172: [libc++][AIX] Use C++ overloads from libc++'s math.h.

Update to a new version that requires the compiler to define the __LIBC_NO_CPP_MATH_OVERLOADS__ macro (which clang does).

Feb 7 2022, 9:12 PM · Restricted Project, Restricted Project
daltenty updated the summary of D102172: [libc++][AIX] Use C++ overloads from libc++'s math.h.
Feb 7 2022, 9:10 PM · Restricted Project, Restricted Project
daltenty updated the diff for D119107: [NFCI][clang][driver] Identify LTO plugin types and refine opt passing.

Remove whitespace change

Feb 7 2022, 2:18 PM
daltenty updated the diff for D119107: [NFCI][clang][driver] Identify LTO plugin types and refine opt passing.

Run clang-format

Feb 7 2022, 2:16 PM

Feb 6 2022

daltenty updated the summary of D119109: [clang][AIX] Enable LTO and teach the driver to pass options to the plugin.
Feb 6 2022, 11:28 PM · Restricted Project
daltenty requested review of D119109: [clang][AIX] Enable LTO and teach the driver to pass options to the plugin.
Feb 6 2022, 11:27 PM · Restricted Project
daltenty requested review of D119107: [NFCI][clang][driver] Identify LTO plugin types and refine opt passing.
Feb 6 2022, 11:11 PM

Feb 1 2022

daltenty committed rZORG81c93a749d18: [clang-ppc64-aix] Set OBJECT_MODE as an builder wide env (authored by daltenty).
[clang-ppc64-aix] Set OBJECT_MODE as an builder wide env
Feb 1 2022, 11:37 AM
daltenty closed D118710: [clang-ppc64-aix] Set OBJECT_MODE an a builder wide env.
Feb 1 2022, 11:37 AM
daltenty updated the diff for D118710: [clang-ppc64-aix] Set OBJECT_MODE an a builder wide env.

Slightly tweak whitespace formatting

Feb 1 2022, 9:31 AM
daltenty updated the diff for D118710: [clang-ppc64-aix] Set OBJECT_MODE an a builder wide env.

Fix missing context on diff

Feb 1 2022, 9:29 AM
daltenty set the repository for D118710: [clang-ppc64-aix] Set OBJECT_MODE an a builder wide env to rZORG LLVM Github Zorg.
Feb 1 2022, 9:18 AM
daltenty updated the summary of D118710: [clang-ppc64-aix] Set OBJECT_MODE an a builder wide env.
Feb 1 2022, 8:56 AM
daltenty requested review of D118710: [clang-ppc64-aix] Set OBJECT_MODE an a builder wide env.
Feb 1 2022, 8:56 AM

Jan 31 2022

daltenty accepted D118639: Disable benchmarks that require _ALL_SOURCE on AIX.

Confirming LGTM, thanks!

Jan 31 2022, 1:07 PM
daltenty accepted D118639: Disable benchmarks that require _ALL_SOURCE on AIX.

LGTM with minor nit. We'll see how we can better remediate some on on AIX these later, but looking at the existing CMake, we're not the only ones skipping some of these.

Jan 31 2022, 12:15 PM
daltenty accepted D118622: Workaround _ALL_SOURCE issue on AIX.

LGTM, with minor nit

Jan 31 2022, 11:34 AM

Jan 29 2022

daltenty added a comment to D118134: [libc++] Fix TOCTOU issue with std::filesystem::remove_all.

Thanks for pinging us on this. After taking a look at the AIX test failure, and dumping the error_code we get back from the new implementation, I think this is actually due to some ambiguity in the expected errno when the combination of O_DIRECTORY and O_NOFOLLOW is used and the path is a symlink.

Jan 29 2022, 12:03 AM · Restricted Project

Jan 28 2022

daltenty committed rG27ee91162dd3: [AIX][clang] include_next through clang provided float.h (authored by daltenty).
[AIX][clang] include_next through clang provided float.h
Jan 28 2022, 10:27 AM