Page MenuHomePhabricator

daltenty (David Tenty)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 4 2019, 2:54 PM (208 w, 1 d)

Recent Activity

Wed, Mar 29

daltenty added a reviewer for D147184: [clang][CodeGenCXX] Improve handling of itanium ABI member function alignment requirements: MikeStump.
Wed, Mar 29, 2:11 PM · Restricted Project
daltenty requested review of D147184: [clang][CodeGenCXX] Improve handling of itanium ABI member function alignment requirements.
Wed, Mar 29, 2:05 PM · Restricted Project

Tue, Mar 28

daltenty committed rG2fe49ea0d07d: [clang][PowerPC] Remove remaining Darwin support (authored by daltenty).
[clang][PowerPC] Remove remaining Darwin support
Tue, Mar 28, 2:14 PM · Restricted Project, Restricted Project
daltenty closed D146459: [clang][PowerPC] Remove remaining Darwin support.
Tue, Mar 28, 2:14 PM · Restricted Project, Restricted Project

Mon, Mar 27

daltenty added reviewers for D147016: [PowerPC] Add function pointer alignment to DataLayout: nemanjai, hubert.reinterpretcast.
Mon, Mar 27, 6:06 PM · Restricted Project, Restricted Project
daltenty added a reviewer for D147016: [PowerPC] Add function pointer alignment to DataLayout: Restricted Project.
Mon, Mar 27, 6:05 PM · Restricted Project, Restricted Project
daltenty requested review of D147016: [PowerPC] Add function pointer alignment to DataLayout.
Mon, Mar 27, 6:05 PM · Restricted Project, Restricted Project
daltenty accepted D146431: [AIX][Driver] Implement -mxcoff-build-id option..

LGTM, thanks!

Mon, Mar 27, 7:48 AM · Restricted Project, Restricted Project

Fri, Mar 24

daltenty added a comment to D146431: [AIX][Driver] Implement -mxcoff-build-id option..

Let's document the option as well under: https://clang.llvm.org/docs/ClangCommandLineReference.html#powerpc

Fri, Mar 24, 12:22 PM · Restricted Project, Restricted Project

Wed, Mar 22

daltenty accepted D146374: [test-suite] Disable CLAMR fmemopen() substitute function on FreeBSD / OpenBSD and AIX.

Thanks, LGTM from the AIX perspective (noting though this benchmark was actually disabled for AIX by https://reviews.llvm.org/D103063 for other source issues)

Wed, Mar 22, 9:49 PM · Restricted Project

Mon, Mar 20

daltenty added a reviewer for D146459: [clang][PowerPC] Remove remaining Darwin support: Restricted Project.
Mon, Mar 20, 3:04 PM · Restricted Project, Restricted Project
daltenty requested review of D146459: [clang][PowerPC] Remove remaining Darwin support.
Mon, Mar 20, 3:03 PM · Restricted Project, Restricted Project
daltenty added a comment to D145899: [AIX][Clang] Respect -r when invoking the linker.

LGTM, with a small nit about the test that should be addressed before committing

Mon, Mar 20, 6:59 AM · Restricted Project, Restricted Project

Fri, Mar 17

daltenty added inline comments to D145899: [AIX][Clang] Respect -r when invoking the linker.
Fri, Mar 17, 8:01 AM · Restricted Project, Restricted Project
daltenty added inline comments to D145899: [AIX][Clang] Respect -r when invoking the linker.
Fri, Mar 17, 8:00 AM · Restricted Project, Restricted Project

Tue, Mar 14

daltenty added a comment to D145021: [Clang][AIX][p] Manually claim -p in front end.

Reopen since this was reverted

Tue, Mar 14, 11:11 AM · Restricted Project, Restricted Project

Mon, Mar 13

daltenty committed rG9a733e8a2c58: [clang][driver] accept maix32/maix64 gcc compat options (authored by daltenty).
[clang][driver] accept maix32/maix64 gcc compat options
Mon, Mar 13, 2:06 PM · Restricted Project, Restricted Project
daltenty closed D145610: [clang][driver][AIX] accept maix32/maix64 gcc compat options.
Mon, Mar 13, 2:06 PM · Restricted Project, Restricted Project
daltenty added a comment to D126122: Fix RUNPATH not accounting for LLVM_ENABLE_PER_TARGET_RUNTIME_DIR.

@daltenty I applied the same exclusion logic llvm_setup_rpath in AddLLVM.cmake and the build is now fully passing.

Mon, Mar 13, 7:53 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Thu, Mar 9

daltenty updated the diff for D145610: [clang][driver][AIX] accept maix32/maix64 gcc compat options.

Produce a diagnostic if the options are used with non-AIX targets

Thu, Mar 9, 4:40 PM · Restricted Project, Restricted Project

Wed, Mar 8

daltenty requested review of D145610: [clang][driver][AIX] accept maix32/maix64 gcc compat options.
Wed, Mar 8, 1:42 PM · Restricted Project, Restricted Project
daltenty added a comment to D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.

Since https://reviews.llvm.org/D142842 still needs some revision to be ABI-safe, and this was already good to go, we'll proceed with this patch and D142842 can rebase against it if there are no objections.

Wed, Mar 8, 6:57 AM · Restricted Project, Restricted Project

Mon, Mar 6

daltenty requested changes to D126122: Fix RUNPATH not accounting for LLVM_ENABLE_PER_TARGET_RUNTIME_DIR.

This patch is failing in the libc++ precommit CI attached to this revision as the -rpath option is unsupported on AIX:

Mon, Mar 6, 11:08 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 1 2023

daltenty added inline comments to D145021: [Clang][AIX][p] Manually claim -p in front end.
Mar 1 2023, 8:57 AM · Restricted Project, Restricted Project
daltenty accepted D145021: [Clang][AIX][p] Manually claim -p in front end.

LGTM, thanks!

Mar 1 2023, 8:55 AM · Restricted Project, Restricted Project

Feb 28 2023

daltenty planned changes to D144877: [llvm][XCOFF] Don't seperate mergable strings by alignment.

It seems there's actually some work going on at the present time to re-work how constant data like this is structured in the XCOFF codegen (e.g. to do some pooling). This patch is likely to conflict and/or be superseded by that approach, so I'm going to put this on hold for the moment till that refactoring lands and we see whether this is still relevant.

Feb 28 2023, 3:00 PM · Restricted Project, Restricted Project
daltenty accepted D140343: [libc++] Update supported system versions.

LGTM for AIX

Feb 28 2023, 2:28 PM · Restricted Project, Restricted Project

Feb 27 2023

daltenty requested review of D144877: [llvm][XCOFF] Don't seperate mergable strings by alignment.
Feb 27 2023, 7:55 AM · Restricted Project, Restricted Project
daltenty added a comment to D134282: [CGP] Add generic TargetLowering::shouldAlignPointerArgs() implementation.

Not that I know of without negative side-effects. For example, if we access using a TOC entry for a label for the individual string, we would end up with more TOC entries which, in turn, can lead to TOC overflow.

Looking at a case with more than one string, it seems we currently have separate csects and TOC entries for each string anyway. I am not sure that is a state we want to stay in though.

Feb 27 2023, 7:47 AM · Restricted Project, Restricted Project

Feb 24 2023

daltenty added a comment to D134282: [CGP] Add generic TargetLowering::shouldAlignPointerArgs() implementation.

Is there any way we can make AIX targets more resilient handling this kind of alignment change? If we have to, we can choose a point after which passes aren't allowed to increase the alignment of globals, and move this transform before that. But I'd like to avoid that if possible.

Not that I know of without negative side-effects. For example, if we access using a TOC entry for a label for the individual string, we would end up with more TOC entries which, in turn, can lead to TOC overflow.

Feb 24 2023, 1:28 PM · Restricted Project, Restricted Project

Feb 23 2023

daltenty added a comment to D134282: [CGP] Add generic TargetLowering::shouldAlignPointerArgs() implementation.

Here's an IR only example which will exhibit the invalid AIX assembly after this change:

target datalayout = "E-m:a-i64:64-n32:64-S128-v256:256:256-v512:512:512"
target triple = "powerpc64-ibm-aix"
Feb 23 2023, 10:01 AM · Restricted Project, Restricted Project

Feb 21 2023

daltenty added a comment to D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.

Sorry for chiming in so late, but I've got D142842 to remove _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION. IIUC that should also fix your problem, right?

Feb 21 2023, 9:38 AM · Restricted Project, Restricted Project
daltenty requested changes to D142842: [libc++] Remove _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.

Unfortunately, some of this doesn't really work on AIX linkage model. Specifically, the linker doesn't follow the resolution semantic of trying to resolve weak references locally first that you see on other platforms (we have an option -bweaklocal to enable that), so we prefer the strong def we see in the library. This means this assumption doesn't hold on AIX:

Feb 21 2023, 9:18 AM · Restricted Project, Restricted Project

Feb 2 2023

daltenty accepted D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.

Latest format changes LGTM. Small nit about the test comment.

Feb 2 2023, 5:21 PM · Restricted Project, Restricted Project
daltenty added inline comments to D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.
Feb 2 2023, 1:37 PM · Restricted Project, Restricted Project
daltenty added inline comments to D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.
Feb 2 2023, 1:08 PM · Restricted Project, Restricted Project
daltenty accepted D143010: [libc++abi][AIX] Skip non-C++ EH aware frames when retrieving exception object.

LGTM, with a minor tweak

Feb 2 2023, 8:29 AM · Restricted Project, Restricted Project, Restricted Project
daltenty accepted D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.

LGTM, with some minor nits to address before commit. Updated the description to describe the details of the issue.

Feb 2 2023, 8:19 AM · Restricted Project, Restricted Project
daltenty retitled D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION from [AIX] Fix libc++ Symbol Visibility on AIX to [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.
Feb 2 2023, 8:17 AM · Restricted Project, Restricted Project

Feb 1 2023

daltenty added inline comments to D143010: [libc++abi][AIX] Skip non-C++ EH aware frames when retrieving exception object.
Feb 1 2023, 10:59 AM · Restricted Project, Restricted Project, Restricted Project

Jan 30 2023

daltenty committed rG11066449d49e: [AIX][CMake] Use top-level tools in llvm_ExternalProject_Add (authored by daltenty).
[AIX][CMake] Use top-level tools in llvm_ExternalProject_Add
Jan 30 2023, 1:58 PM · Restricted Project, Restricted Project
daltenty closed D142727: [AIX][CMake] Use top-level tools in llvm_ExternalProject_Add.
Jan 30 2023, 1:58 PM · Restricted Project, Restricted Project
daltenty added a comment to D142727: [AIX][CMake] Use top-level tools in llvm_ExternalProject_Add.

you means that if there is no define of -DCMAKE_RANLIB= , the CMake (versions >= 3.22) will use llvm-ranlib by default?

Jan 30 2023, 1:16 PM · Restricted Project, Restricted Project

Jan 27 2023

daltenty requested review of D142727: [AIX][CMake] Use top-level tools in llvm_ExternalProject_Add.
Jan 27 2023, 7:56 AM · Restricted Project, Restricted Project

Jan 26 2023

daltenty added inline comments to D140343: [libc++] Update supported system versions.
Jan 26 2023, 10:55 AM · Restricted Project, Restricted Project

Jan 25 2023

daltenty accepted D137753: [Clang][AIX][p]Enable -p Functionality.

LGTM, with small nit to address before commit

Jan 25 2023, 12:41 PM · Restricted Project, Restricted Project

Jan 24 2023

daltenty added inline comments to D137753: [Clang][AIX][p]Enable -p Functionality.
Jan 24 2023, 10:50 AM · Restricted Project, Restricted Project
daltenty added inline comments to D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.
Jan 24 2023, 10:37 AM · Restricted Project, Restricted Project

Jan 23 2023

daltenty added inline comments to D142358: Opting out of Clang 16 ABI Changes for AIX and z/OS.
Jan 23 2023, 7:33 AM · Restricted Project, Restricted Project

Jan 19 2023

daltenty accepted D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified.

Some minor nits about how we can shorten the test, but otherwise LGTM

Jan 19 2023, 8:44 AM · Restricted Project, Restricted Project, Restricted Project
daltenty added a comment to D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.

Looking better, still needs a test though.

Jan 19 2023, 7:12 AM · Restricted Project, Restricted Project

Jan 16 2023

daltenty added a comment to D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified.

Needs a test, I think we should add a couple of -fopenmp=foo run lines to clang/test/Driver/aix-ld.c to verify that the correct linker options are produced for each.

Jan 16 2023, 12:17 PM · Restricted Project, Restricted Project, Restricted Project

Jan 6 2023

daltenty committed rTde2e530ed27d: Reland "Enable Fortran testsuite/language when TEST_SUITE_SUBDIRS=Fortran is… (authored by pscoro).
Reland "Enable Fortran testsuite/language when TEST_SUITE_SUBDIRS=Fortran is…
Jan 6 2023, 11:45 AM · Restricted Project
daltenty closed D139633: Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran.
Jan 6 2023, 11:45 AM · Restricted Project
daltenty accepted D139633: Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran.

LGTM with new IN_LIST update

Jan 6 2023, 10:50 AM · Restricted Project
daltenty added inline comments to D139633: Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran.
Jan 6 2023, 8:25 AM · Restricted Project

Dec 13 2022

daltenty committed rG2ee308ceea88: [CMake] Setting the LLVM_TARGET_TRIPLE macro based on the… (authored by nicolerabjohn).
[CMake] Setting the LLVM_TARGET_TRIPLE macro based on the…
Dec 13 2022, 5:05 PM · Restricted Project, Restricted Project, Restricted Project
daltenty closed D138864: Setting the LLVM_TARGET_TRIPLE macro based on the LLVM_DEFAULT_TARGET_TRIPLE.
Dec 13 2022, 5:05 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
daltenty added a comment to D138864: Setting the LLVM_TARGET_TRIPLE macro based on the LLVM_DEFAULT_TARGET_TRIPLE.

The discussion about the meanings of these things should be taken to Discourse, not buried in a couple of patch reviews, in any case.

Dec 13 2022, 1:46 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 12 2022

daltenty added a comment to D138864: Setting the LLVM_TARGET_TRIPLE macro based on the LLVM_DEFAULT_TARGET_TRIPLE.

I believe @phosek documents the intended semantic here in https://reviews.llvm.org/D137451:

Dec 12 2022, 1:45 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
daltenty committed rT8c18b1433474: Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran (authored by pscoro).
Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran
Dec 12 2022, 1:43 PM · Restricted Project
daltenty closed D139633: Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran.
Dec 12 2022, 1:43 PM · Restricted Project
daltenty retitled D139633: Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran from Enable Fortran testsuite in CMakeLists to Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran.
Dec 12 2022, 12:59 PM · Restricted Project
daltenty accepted D139633: Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran.

LGTM, thanks!

Dec 12 2022, 12:58 PM · Restricted Project
daltenty added a comment to D138864: Setting the LLVM_TARGET_TRIPLE macro based on the LLVM_DEFAULT_TARGET_TRIPLE.
Dec 12 2022, 11:00 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
daltenty added inline comments to D139633: Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran.
Dec 12 2022, 7:40 AM · Restricted Project

Dec 9 2022

daltenty accepted D138864: Setting the LLVM_TARGET_TRIPLE macro based on the LLVM_DEFAULT_TARGET_TRIPLE.
Dec 9 2022, 12:29 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
daltenty added a comment to D138864: Setting the LLVM_TARGET_TRIPLE macro based on the LLVM_DEFAULT_TARGET_TRIPLE.

LGTM. Some paths in compiler-rt still require LLVM_TARGET_TRIPLE, so commoning the setup makes sense

Dec 9 2022, 12:29 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
daltenty added a comment to D138864: Setting the LLVM_TARGET_TRIPLE macro based on the LLVM_DEFAULT_TARGET_TRIPLE.

What's the issue you're trying to address? I just landed D137451, does it address your issue?

Dec 9 2022, 12:10 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 7 2022

daltenty added a reverting change for rG8482e95f75d0: [libunwind] Use .irp directives. NFC: rGc9aff5d2f9d9: Revert "[libunwind] Use .irp directives. NFC".
Dec 7 2022, 12:41 PM · Restricted Project
daltenty committed rGc9aff5d2f9d9: Revert "[libunwind] Use .irp directives. NFC" (authored by daltenty).
Revert "[libunwind] Use .irp directives. NFC"
Dec 7 2022, 12:41 PM · Restricted Project
daltenty added a reverting change for D139368: [libunwind] Use .irp directives. NFC: rGc9aff5d2f9d9: Revert "[libunwind] Use .irp directives. NFC".
Dec 7 2022, 12:41 PM · Restricted Project, Restricted Project, Restricted Project
daltenty added a comment to D139368: [libunwind] Use .irp directives. NFC.

This broke the AIX CI: https://buildkite.com/llvm-project/libcxx-ci/builds/15656#0184eac6-521b-4d1e-8502-c226673e0ece. Unfortunately it seems the .irp directive isn't supported by the AIX assembler.

Dec 7 2022, 7:41 AM · Restricted Project, Restricted Project, Restricted Project
daltenty accepted D128223: [clang] Cached linkage assertion for static locals of static function.

New revision LGTM, VisibleNoLinkage is typical reserved for types from inline functions so it doesn't seem sensible to return. Looking at the C++ standard, I'm not even convinced this is guaranteed to be the same object if the function doesn't have external linkage, so I think the guard is sensible.

Dec 7 2022, 7:22 AM · Restricted Project, Restricted Project

Nov 29 2022

daltenty added a comment to D137451: [CMake] Use LLVM_RUNTIME_TRIPLE in runtimes.

This patch seem to do a bit more than it's description implies. It makes LLVM_DEFAULT_TARGET_TRIPLE no longer an valid option on the runtimes path:

CMake Warning:
  Manually-specified variables were not used by the project:
Nov 29 2022, 8:23 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 24 2022

daltenty committed rG194ab73a419c: [libc++][AIX] Add AIX buildbot owners (authored by daltenty).
[libc++][AIX] Add AIX buildbot owners
Nov 24 2022, 8:46 AM · Restricted Project, Restricted Project
daltenty closed D138580: [libc++][AIX] Add AIX buildbot owners.
Nov 24 2022, 8:46 AM · Restricted Project, Restricted Project

Nov 23 2022

daltenty requested review of D138580: [libc++][AIX] Add AIX buildbot owners.
Nov 23 2022, 8:20 AM · Restricted Project, Restricted Project

Nov 22 2022

daltenty committed rG2edc54edede4: [lit][AIX] Add LIBPATH to pass through env vars (authored by daltenty).
[lit][AIX] Add LIBPATH to pass through env vars
Nov 22 2022, 2:25 PM · Restricted Project, Restricted Project
daltenty closed D138510: [lit][AIX] Add LIBPATH to pass through env vars.
Nov 22 2022, 2:25 PM · Restricted Project, Restricted Project
daltenty added a comment to D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing..

@vsapsai hi Volodymyr Sapsai , test case clang/test/Modules/hidden-duplicates.m is failing on our llvm community AIX box https://lab.llvm.org/buildbot/#/builders/214/builds/4442/steps/6/logs/FAIL__Clang__hidden-duplicates_m , it gives exit code 70 without detail error message, can you help fix it as soon as possible. Thanks

Does AIX have support for compiling Objective-C? I'm not entirely sure that's the right fix but many tests have // UNSUPPORTED: -zos, -aix, so I'm inclined to disable the test for AIX.

Nov 22 2022, 2:11 PM · Restricted Project, Restricted Project
daltenty committed rGb888cafcbc0a: XFAIL hidden-duplicates.m for AIX and zOS (authored by NancyWang2222).
XFAIL hidden-duplicates.m for AIX and zOS
Nov 22 2022, 1:26 PM · Restricted Project, Restricted Project
daltenty requested review of D138510: [lit][AIX] Add LIBPATH to pass through env vars.
Nov 22 2022, 10:14 AM · Restricted Project, Restricted Project

Nov 18 2022

daltenty accepted D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode.

LGTM, thanks!

Nov 18 2022, 7:55 AM · Restricted Project, Restricted Project, Restricted Project

Nov 16 2022

daltenty added inline comments to D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode.
Nov 16 2022, 9:06 AM · Restricted Project, Restricted Project, Restricted Project

Nov 8 2022

daltenty added a comment to D137110: [libc++] Option to specify a different compiler for testing.

But first, I'd like to understand why you're not setting CMAKE_CXX_COMPILER to the compiler you're trying to run the tests with?

Is my understanding correct that changing CMAKE_CXX_COMPILER also changes the build compiler for the shared libraries?
The intention is to build using a "stable" compiler, but still allow testing with a compiler under development.

Why can't you compile the library with the experimental compiler? If it can't properly compile that, it surely can't run the test suite.

Nov 8 2022, 7:04 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 28 2022

daltenty accepted D128223: [clang] Cached linkage assertion for static locals of static function.

LGTM. Doing the inner computation while observing visibility seems like the right thing to do in this case.

Oct 28 2022, 4:48 PM · Restricted Project, Restricted Project

Oct 13 2022

daltenty abandoned D119109: [clang][AIX] Enable LTO and teach the driver to pass options to the plugin.

We've rolled the tests added by this into https://reviews.llvm.org/D135885 instead, so abandoning this.

Oct 13 2022, 8:35 AM · Restricted Project

Oct 12 2022

daltenty committed rG1379899518b0: [libc++] Replace some _LIBCPP_HIDDEN with _LIBCPP_HIDE_FROM_ABI (authored by daltenty).
[libc++] Replace some _LIBCPP_HIDDEN with _LIBCPP_HIDE_FROM_ABI
Oct 12 2022, 1:47 PM · Restricted Project, Restricted Project
daltenty closed D135504: [libc++] Replace some _LIBCPP_HIDDEN with _LIBCPP_HIDE_FROM_ABI.
Oct 12 2022, 1:47 PM · Restricted Project, Restricted Project
daltenty abandoned D135699: [libc++][AIX] Unique the static library names.

These adjustments were added in https://reviews.llvm.org/D134221

Oct 12 2022, 7:12 AM · Restricted Project
daltenty added a comment to D124569: Re-enable libc++ gdb-pretty-printer tests for all versions of clang..

Seems like this is breaking in the libc++ CI: https://buildkite.com/llvm-project/libcxx-ci/builds/14027

Oct 12 2022, 6:33 AM · Restricted Project, Restricted Project

Oct 11 2022

daltenty updated the diff for D135504: [libc++] Replace some _LIBCPP_HIDDEN with _LIBCPP_HIDE_FROM_ABI.

Remove __gcd from the patch, as the always_inline we use in the macro for gcc causes problems in this recursive case.

Oct 11 2022, 3:36 PM · Restricted Project, Restricted Project
daltenty accepted D134221: [runtimes] Always define the cxx_shared, cxx_static & other targets.

Rebase and address AIX issues.

@daltenty I already had this update ready to go before you created D135699, but let me know if you'd
rather go with yours instead, which is in a separate patch. I have no preference but I did find that
my comment explaining the issue was a bit more detailed.

Oct 11 2022, 2:00 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
daltenty updated the summary of D135699: [libc++][AIX] Unique the static library names.
Oct 11 2022, 10:59 AM · Restricted Project
daltenty updated the diff for D135699: [libc++][AIX] Unique the static library names.

Add newline to end of file

Oct 11 2022, 10:59 AM · Restricted Project
daltenty requested review of D135699: [libc++][AIX] Unique the static library names.
Oct 11 2022, 10:57 AM · Restricted Project
daltenty accepted D135669: [runtimes] Add the ability to customize the output name of libc++, libc++abi and libunwind.

LGTM, thanks for accommodating this change. Should help solve some problems for us.

Oct 11 2022, 8:37 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 7 2022

daltenty requested review of D135504: [libc++] Replace some _LIBCPP_HIDDEN with _LIBCPP_HIDE_FROM_ABI.
Oct 7 2022, 6:55 PM · Restricted Project, Restricted Project

Oct 4 2022

daltenty added a comment to D134221: [runtimes] Always define the cxx_shared, cxx_static & other targets.

Do you mean that both unwind_shared and unwind_static both create a target named libunwind.a?

Oct 4 2022, 8:23 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project