Page MenuHomePhabricator

daltenty (David Tenty)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 4 2019, 2:54 PM (76 w, 2 d)

Recent Activity

Fri, Sep 18

daltenty added reviewers for D87927: [AIX][clang][driver] Make sure ctri.o is linked in C++ mode: stevewan, hubert.reinterpretcast, xingxue.
Fri, Sep 18, 12:02 PM · Restricted Project
daltenty requested review of D87927: [AIX][clang][driver] Make sure ctri.o is linked in C++ mode.
Fri, Sep 18, 11:59 AM · Restricted Project
daltenty added reviewers for D87914: [AIX][Clang][Driver] Add handling of shared option: Xiangling_L, hubert.reinterpretcast, xingxue.
Fri, Sep 18, 9:14 AM · Restricted Project
daltenty requested review of D87914: [AIX][Clang][Driver] Add handling of shared option.
Fri, Sep 18, 9:10 AM · Restricted Project
daltenty committed rG5d1f8395be94: [AIX] Enable large code model when building with clang (authored by daltenty).
[AIX] Enable large code model when building with clang
Fri, Sep 18, 8:06 AM
daltenty added reviewers for D87904: [AIX][Clang][Driver] Add handling of nostartfiles option: stevewan, Xiangling_L, hubert.reinterpretcast.
Fri, Sep 18, 7:20 AM · Restricted Project
daltenty requested review of D87904: [AIX][Clang][Driver] Add handling of nostartfiles option.
Fri, Sep 18, 7:18 AM · Restricted Project
daltenty added a comment to D87114: [AIX][ExecutionEngine] Disable eh frame support when building with Clang on AIX.

Do we want to take advantage of this patch to move those checks into the cmake configure so we don't need to duplicate the logic in 2 files as @sfertile mentioned previously?

Fri, Sep 18, 7:04 AM · Restricted Project

Thu, Sep 17

daltenty updated the diff for D87113: [AIX][compiler-rt] Use the AR/ranlib mode flag for 32-bit and 64-bit mode.
  • Fix whitespace and indentation
Thu, Sep 17, 10:39 AM · Restricted Project
daltenty added a comment to D87113: [AIX][compiler-rt] Use the AR/ranlib mode flag for 32-bit and 64-bit mode.

since we will be building both 32-bit and 64-bit compiler-rt builtins
from a single configuration.

@daltenty, from the limited context of this patch, this sounds questionable in terms of avoiding silent errors now and in the future. If the idea is to configure once and then run twice in the same build tree, then some things may get cached either in CMake or in generated headers, etc.

Thu, Sep 17, 10:15 AM · Restricted Project

Wed, Sep 9

daltenty requested review of D87383: [compiler-rt][AIX] Add CMake support for 32-bit Power builds.
Wed, Sep 9, 8:01 AM · Restricted Project

Tue, Sep 8

daltenty updated the diff for D87114: [AIX][ExecutionEngine] Disable eh frame support when building with Clang on AIX.
  • Adjust so we don't alter the MVS case
Tue, Sep 8, 7:08 AM · Restricted Project

Fri, Sep 4

daltenty accepted D87122: [test][MC] Rehabilitate llvm/test/MC/COFF/bigobj.py.

LGTM

Fri, Sep 4, 3:22 PM · Restricted Project
daltenty updated the diff for D87113: [AIX][compiler-rt] Use the AR/ranlib mode flag for 32-bit and 64-bit mode.
  • Add AR flags to the builtins CMake too since it may be used as a toplevel by the runtimes build
Fri, Sep 4, 8:19 AM · Restricted Project

Thu, Sep 3

daltenty requested review of D87114: [AIX][ExecutionEngine] Disable eh frame support when building with Clang on AIX.
Thu, Sep 3, 3:05 PM · Restricted Project
daltenty requested review of D87113: [AIX][compiler-rt] Use the AR/ranlib mode flag for 32-bit and 64-bit mode.
Thu, Sep 3, 2:54 PM · Restricted Project

Tue, Aug 25

daltenty committed rGf8454d60b829: [AIX][compiler-rt][builtins] Don't add ppc builtin implementations that require… (authored by daltenty).
[AIX][compiler-rt][builtins] Don't add ppc builtin implementations that require…
Tue, Aug 25, 8:36 AM
daltenty closed D85972: [AIX][compiler-rt][builtins] Don't add ppc builtin implementations that require __int128 on AIX.
Tue, Aug 25, 8:35 AM · Restricted Project

Aug 14 2020

daltenty updated the diff for D85972: [AIX][compiler-rt][builtins] Don't add ppc builtin implementations that require __int128 on AIX.
  • Fix comment.
Aug 14 2020, 6:59 AM · Restricted Project
daltenty retitled D85972: [AIX][compiler-rt][builtins] Don't add ppc builtin implementations that require __int128 on AIX from [AIX][compiler-rt] Don't add ppc builtin implementations that require __int128 on AIX to [AIX][compiler-rt][builtins] Don't add ppc builtin implementations that require __int128 on AIX.
Aug 14 2020, 6:58 AM · Restricted Project
daltenty requested review of D85972: [AIX][compiler-rt][builtins] Don't add ppc builtin implementations that require __int128 on AIX.
Aug 14 2020, 6:55 AM · Restricted Project

Aug 11 2020

daltenty added a comment to D85329: [AIX] Try to not use LLVM tools while building runtimes.

Fixed variable expansion syntax in TOOLCHAIN_TOOLS

Aug 11 2020, 1:18 PM · Restricted Project

Aug 10 2020

daltenty committed rG50dd75c8e0b8: [AIX] Try to not use LLVM tools while building runtimes (authored by daltenty).
[AIX] Try to not use LLVM tools while building runtimes
Aug 10 2020, 1:12 PM
daltenty closed D85329: [AIX] Try to not use LLVM tools while building runtimes.
Aug 10 2020, 1:11 PM · Restricted Project

Aug 7 2020

daltenty added a comment to D85329: [AIX] Try to not use LLVM tools while building runtimes.

@daltenty, if these tools happened to be on the user's $PATH, then would they get picked up? Is that the desired behaviour?

(summarizing offline discussion)

Aug 7 2020, 7:46 AM · Restricted Project
daltenty accepted D85317: [XCOFF] Adjust .rename emission sequence.

LGTM, thanks!

Aug 7 2020, 7:27 AM · Restricted Project

Aug 5 2020

daltenty requested review of D85329: [AIX] Try to not use LLVM tools while building runtimes.
Aug 5 2020, 10:25 AM · Restricted Project

Jul 29 2020

daltenty accepted D84880: [AIX] Temporarily disable IncrementalProcessingTest partially.

LGTM, thanks!

Jul 29 2020, 12:37 PM · Restricted Project

Jul 23 2020

daltenty accepted D84363: [XCOFF][AIX] Handle llvm.used and llvm.compiler.used global array.

LGTM, thanks!

Jul 23 2020, 9:15 AM · Restricted Project

Jul 17 2020

daltenty committed rG8dea7f3202a7: [z/OS][AIX] Move lambda definition to fix build problem (authored by daltenty).
[z/OS][AIX] Move lambda definition to fix build problem
Jul 17 2020, 7:09 AM

Jul 16 2020

daltenty added inline comments to D83866: [SystemZ/ZOS] Additions to the build system..
Jul 16 2020, 1:02 PM · Restricted Project

Jul 15 2020

daltenty committed rGeed19bd84424: [NFC] [AIX] [z/OS] Fix build failure on AIX and z/OS (authored by abhina.sreeskantharajan).
[NFC] [AIX] [z/OS] Fix build failure on AIX and z/OS
Jul 15 2020, 1:07 PM
daltenty closed D83889: [NFC] [AIX] [z/OS] Fix build failure on AIX and z/OS.
Jul 15 2020, 1:07 PM · Restricted Project
daltenty accepted D83889: [NFC] [AIX] [z/OS] Fix build failure on AIX and z/OS.

LGTM

Jul 15 2020, 10:59 AM · Restricted Project

Jul 14 2020

daltenty added inline comments to D81958: [clangd] Add library to semantically strip flags by name..
Jul 14 2020, 7:56 AM · Restricted Project

Jul 9 2020

daltenty committed rG25ec96d91a3a: [Clang][Driver] Recognize the AIX OBJECT_MODE environment setting (authored by daltenty).
[Clang][Driver] Recognize the AIX OBJECT_MODE environment setting
Jul 9 2020, 12:15 PM
daltenty closed D82476: [Clang][Driver] Recognize the AIX OBJECT_MODE environment setting.
Jul 9 2020, 12:15 PM · Restricted Project

Jul 7 2020

daltenty committed rG1a2f4824cb2d: [Clang] Handle AIX Include management in the driver (authored by ShuhongL).
[Clang] Handle AIX Include management in the driver
Jul 7 2020, 8:15 AM
daltenty closed D82677: [Clang] Handle AIX Include management in the driver.
Jul 7 2020, 8:15 AM · Restricted Project

Jul 6 2020

daltenty committed rG2402f9385e85: [AIX] Add system-aix to lit config file (authored by ShuhongL).
[AIX] Add system-aix to lit config file
Jul 6 2020, 9:54 AM
daltenty closed D82905: [AIX] Add system-aix to lit config file.
Jul 6 2020, 9:54 AM · Restricted Project

Jul 3 2020

daltenty accepted D82677: [Clang] Handle AIX Include management in the driver.

LGTM

Jul 3 2020, 2:09 PM · Restricted Project

Jul 2 2020

daltenty committed rG670dbad47327: [DebugInfo] Fix LineTest byteswap for cross-targeting builds (authored by daltenty).
[DebugInfo] Fix LineTest byteswap for cross-targeting builds
Jul 2 2020, 11:54 AM
daltenty closed D82827: [DebugInfo] Fix LineTest byteswap for cross-targeting builds.
Jul 2 2020, 11:53 AM · Restricted Project
daltenty requested changes to D82677: [Clang] Handle AIX Include management in the driver.
Jul 2 2020, 11:21 AM · Restricted Project
daltenty updated the summary of D82827: [DebugInfo] Fix LineTest byteswap for cross-targeting builds.
Jul 2 2020, 8:37 AM · Restricted Project
daltenty added inline comments to D82827: [DebugInfo] Fix LineTest byteswap for cross-targeting builds.
Jul 2 2020, 8:37 AM · Restricted Project
daltenty updated the diff for D82827: [DebugInfo] Fix LineTest byteswap for cross-targeting builds.
  • Use symmetrical constants instead
Jul 2 2020, 8:37 AM · Restricted Project
daltenty accepted D82677: [Clang] Handle AIX Include management in the driver.

LGTM other than minor nit

Jul 2 2020, 8:37 AM · Restricted Project

Jun 30 2020

daltenty added inline comments to D80953: [AIX] asm output: use character literals in byte lists for strings.
Jun 30 2020, 3:13 PM · Restricted Project
daltenty added a comment to D82827: [DebugInfo] Fix LineTest byteswap for cross-targeting builds.

The patch looks appropriate, but now I think that maybe it would have been enough to simply use symmetrical constants for these particular tests?

Testing endianness behaviour of the code under test is not what the original change was about, so getting rid of this byte-swapping code entirely would make the testing simpler, I agree. @daltenty, are you happy to do that? It should be a fairly straightforward change, I believe.

That makes sense to me, I will update to remove the byteswap and add a set of symmetrical constants for the big-endian case.

Jun 30 2020, 2:41 PM · Restricted Project
daltenty updated the diff for D82827: [DebugInfo] Fix LineTest byteswap for cross-targeting builds.
  • Use an Optional big-endian output string rather than trying to byte swap
Jun 30 2020, 2:41 PM · Restricted Project
daltenty added inline comments to D82677: [Clang] Handle AIX Include management in the driver.
Jun 30 2020, 1:03 PM · Restricted Project
daltenty added a reviewer for D82905: [AIX] Add system-aix to lit config file: hubert.reinterpretcast.
Jun 30 2020, 1:03 PM · Restricted Project
daltenty retitled D82905: [AIX] Add system-aix to lit config file from [AIX] Add system-aix to config file to [AIX] Add system-aix to lit config file.
Jun 30 2020, 1:03 PM · Restricted Project
daltenty added inline comments to D82677: [Clang] Handle AIX Include management in the driver.
Jun 30 2020, 7:34 AM · Restricted Project
daltenty added a comment to D82827: [DebugInfo] Fix LineTest byteswap for cross-targeting builds.

The patch looks appropriate, but now I think that maybe it would have been enough to simply use symmetrical constants for these particular tests?

Testing endianness behaviour of the code under test is not what the original change was about, so getting rid of this byte-swapping code entirely would make the testing simpler, I agree. @daltenty, are you happy to do that? It should be a fairly straightforward change, I believe.

Jun 30 2020, 7:33 AM · Restricted Project

Jun 29 2020

daltenty added a comment to rG01fee8dce549: [DebugInfo][test] Attempt to fix big endian build bots.

This fix has some problems on cross-compiling builds (i.e. big endian host targeting little), created D82827

Jun 29 2020, 5:48 PM
daltenty created D82827: [DebugInfo] Fix LineTest byteswap for cross-targeting builds.
Jun 29 2020, 5:47 PM · Restricted Project

Jun 26 2020

daltenty committed rG16dae81edc24: [NFCI] Cleanup range checks in Register/MCRegister (authored by daltenty).
[NFCI] Cleanup range checks in Register/MCRegister
Jun 26 2020, 12:03 PM
daltenty closed D82197: [NFCI] Cleanup range checks in Register/MCRegister.
Jun 26 2020, 12:03 PM · Restricted Project
daltenty added inline comments to D82193: [OpenMPOpt] ICV macro definitions.
Jun 26 2020, 11:29 AM · Restricted Project
daltenty added inline comments to D82193: [OpenMPOpt] ICV macro definitions.
Jun 26 2020, 7:37 AM · Restricted Project

Jun 25 2020

daltenty added inline comments to D82481: [XCOFF][AIX] Give symbol an internal name when desired symbol name contains invalid character(s).
Jun 25 2020, 2:44 PM · Restricted Project
daltenty accepted D82282: [Support][AIX] Implement wait4 wrapper to fix build.

Confirming wrapper LGTM

Jun 25 2020, 8:00 AM · Restricted Project

Jun 24 2020

daltenty created D82476: [Clang][Driver] Recognize the AIX OBJECT_MODE environment setting.
Jun 24 2020, 9:42 AM · Restricted Project
daltenty accepted D82321: [AIX] [test-suite] Enable standard compatable mode on AIX.

LGTM other than minor nit

Jun 24 2020, 9:09 AM

Jun 22 2020

daltenty updated the diff for D82197: [NFCI] Cleanup range checks in Register/MCRegister.
  • Address comments round 1
    • Use numeric_limits for static assert
    • Use bit mask interpretation for VirtualRegFlag
    • Add range assert for index to virtual reg conversion
Jun 22 2020, 5:45 PM · Restricted Project
daltenty accepted D82282: [Support][AIX] Implement wait4 wrapper to fix build.

LGTM apart from minor nit

Jun 22 2020, 4:39 PM · Restricted Project
daltenty added inline comments to D82197: [NFCI] Cleanup range checks in Register/MCRegister.
Jun 22 2020, 8:02 AM · Restricted Project

Jun 19 2020

daltenty added a reviewer for D82197: [NFCI] Cleanup range checks in Register/MCRegister: hubert.reinterpretcast.
Jun 19 2020, 8:37 AM · Restricted Project
daltenty retitled D82197: [NFCI] Cleanup range checks in Register/MCRegister from Revert "[FileCheck, unittest] Improve readability of ExpressionFormat" to [NFCI] Cleanup range checks in Register/MCRegister.
Jun 19 2020, 8:37 AM · Restricted Project
daltenty added a reverting change for rGcd2553de77f2: [FileCheck, unittest] Improve readability of ExpressionFormat: D82197: [NFCI] Cleanup range checks in Register/MCRegister.
Jun 19 2020, 8:08 AM
daltenty created D82197: [NFCI] Cleanup range checks in Register/MCRegister.
Jun 19 2020, 8:07 AM · Restricted Project

Jun 18 2020

daltenty committed rGaf8aee7c073b: [AIX] Split lit test shtest-format into two separate tests and add AIX as… (authored by ShuhongL).
[AIX] Split lit test shtest-format into two separate tests and add AIX as…
Jun 18 2020, 2:16 PM
daltenty closed D82100: [AIX] Split lit test shtest-format into two separate tests and add AIX as UNSUPPORTED for shtest-format-argv0.
Jun 18 2020, 2:15 PM · Restricted Project
daltenty updated the summary of D82100: [AIX] Split lit test shtest-format into two separate tests and add AIX as UNSUPPORTED for shtest-format-argv0.
Jun 18 2020, 2:14 PM · Restricted Project
daltenty updated the summary of D82100: [AIX] Split lit test shtest-format into two separate tests and add AIX as UNSUPPORTED for shtest-format-argv0.
Jun 18 2020, 2:14 PM · Restricted Project
daltenty accepted D82052: Remove unsupported case "AtomicOps" from AIX test list..

LGTM

Jun 18 2020, 1:08 PM

Jun 16 2020

daltenty committed rG8aef01eed41b: [AIX][compiler-rt] Pick the right form of COMPILER_RT_ALIAS for AIX (authored by daltenty).
[AIX][compiler-rt] Pick the right form of COMPILER_RT_ALIAS for AIX
Jun 16 2020, 11:33 AM
daltenty closed D81120: [AIX][compiler-rt] Pick the right form of COMPILER_RT_ALIAS for AIX.
Jun 16 2020, 11:33 AM · Restricted Project

Jun 11 2020

daltenty added a comment to D81120: [AIX][compiler-rt] Pick the right form of COMPILER_RT_ALIAS for AIX.

xlclang alias.c -c
alias.c:2:35: warning: 1540-2990 The attribute " attribute((alias("oldname")))" is not supported. The attribute is ignored.
extern int newname attribute((alias("oldname")));

Do we know whether the macro is used on variables?

Jun 11 2020, 1:47 PM · Restricted Project

Jun 8 2020

daltenty added a comment to D81270: [XCOFF][AIX] Use 'L..' instead of '.L' for getPrivateGlobalPrefix in DataLayout.

Based on the result of the pre-merge checks, do we need to include the clang change in the scope here?

Jun 8 2020, 7:38 AM · Restricted Project, Restricted Project
daltenty accepted D81104: [XCOFF][AIX] report_fatal_error when an overflow section is needed.

LGTM

Jun 8 2020, 7:38 AM · Restricted Project

Jun 5 2020

daltenty accepted D80953: [AIX] asm output: use character literals in byte lists for strings.

LGTM

Jun 5 2020, 8:18 AM · Restricted Project

Jun 4 2020

daltenty added inline comments to D81104: [XCOFF][AIX] report_fatal_error when an overflow section is needed.
Jun 4 2020, 7:41 AM · Restricted Project

Jun 3 2020

daltenty added inline comments to D80953: [AIX] asm output: use character literals in byte lists for strings.
Jun 3 2020, 8:53 PM · Restricted Project
daltenty created D81120: [AIX][compiler-rt] Pick the right form of COMPILER_RT_ALIAS for AIX.
Jun 3 2020, 2:56 PM · Restricted Project
daltenty committed rGd20fdcabf82f: [AIX] Update data directives for AIX assembly (authored by daltenty).
[AIX] Update data directives for AIX assembly
Jun 3 2020, 8:13 AM
daltenty closed D80934: [AIX] Update data directives for AIX assembly.
Jun 3 2020, 8:13 AM · Restricted Project
daltenty updated the diff for D80934: [AIX] Update data directives for AIX assembly.
  • Fix directive spacing
Jun 3 2020, 7:38 AM · Restricted Project

Jun 2 2020

daltenty updated the diff for D80934: [AIX] Update data directives for AIX assembly.
  • Move directives in AsmInfo into base class order
Jun 2 2020, 1:43 PM · Restricted Project
daltenty added inline comments to D80934: [AIX] Update data directives for AIX assembly.
Jun 2 2020, 1:43 PM · Restricted Project
daltenty added a comment to D80953: [AIX] asm output: use character literals in byte lists for strings.

I'm sure this may have been considered, but given that .byte also supports a limited string syntax (given with the limitation that it can support ), is there a reason we can't just glue consecutive runs of printable characters together?

Jun 2 2020, 11:32 AM · Restricted Project
daltenty updated the diff for D80934: [AIX] Update data directives for AIX assembly.
  • Update comments
  • Add unpacked struct case and add tests
  • Fix asm whitespace and block spacing in tests
Jun 2 2020, 8:46 AM · Restricted Project

Jun 1 2020

daltenty added inline comments to D80934: [AIX] Update data directives for AIX assembly.
Jun 1 2020, 4:16 PM · Restricted Project
daltenty accepted D80831: [XCOFF][AIX] Use 'L..' instead of 'L' for PrivateGlobalPrefix.

LGTM

Jun 1 2020, 2:39 PM · Restricted Project
daltenty updated the summary of D80934: [AIX] Update data directives for AIX assembly.
Jun 1 2020, 10:46 AM · Restricted Project
daltenty created D80934: [AIX] Update data directives for AIX assembly.
Jun 1 2020, 9:06 AM · Restricted Project

May 25 2020

daltenty committed rGc8b7c73c57f0: Add AIX to the test macro-same-context XFAIL list (authored by ShuhongL).
Add AIX to the test macro-same-context XFAIL list
May 25 2020, 7:29 AM