Page MenuHomePhabricator

daltenty (David Tenty)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 4 2019, 2:54 PM (19 w, 6 d)

Recent Activity

Fri, Aug 16

daltenty added inline comments to D66256: [AIX] For XL, pick GCC-compatible std & default warning options.
Fri, Aug 16, 8:50 AM · Restricted Project

Tue, Aug 13

daltenty added inline comments to D66032: [AIX][MC][NFC] Explicitly set containing csects on XCOFF Symbols.
Tue, Aug 13, 10:42 AM · Restricted Project
daltenty committed rG9bf01e53a39f: [NFC][AIX] Use assert instead of llvm_unreachable (authored by daltenty).
[NFC][AIX] Use assert instead of llvm_unreachable
Tue, Aug 13, 10:05 AM
daltenty committed rL368720: [NFC][AIX] Use assert instead of llvm_unreachable.
[NFC][AIX] Use assert instead of llvm_unreachable
Tue, Aug 13, 10:04 AM

Mon, Aug 12

daltenty added a parent revision for D66097: Handle local commons for XCOFF object file writing: D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Mon, Aug 12, 11:55 AM · Restricted Project
daltenty added a child revision for D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files.: D66097: Handle local commons for XCOFF object file writing.
Mon, Aug 12, 11:55 AM · Restricted Project
daltenty created D66097: Handle local commons for XCOFF object file writing.
Mon, Aug 12, 10:52 AM · Restricted Project

Fri, Aug 9

daltenty retitled D66032: [AIX][MC][NFC] Explicitly set containing csects on XCOFF Symbols from [AIX][MC] Explicitly set containing csects on XCOFF Symbols to [AIX][MC][NFC] Explicitly set containing csects on XCOFF Symbols.
Fri, Aug 9, 2:20 PM · Restricted Project
daltenty added a parent revision for D66032: [AIX][MC][NFC] Explicitly set containing csects on XCOFF Symbols: D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Fri, Aug 9, 2:11 PM · Restricted Project
daltenty added a child revision for D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files.: D66032: [AIX][MC][NFC] Explicitly set containing csects on XCOFF Symbols.
Fri, Aug 9, 2:11 PM · Restricted Project
daltenty created D66032: [AIX][MC][NFC] Explicitly set containing csects on XCOFF Symbols.
Fri, Aug 9, 2:10 PM · Restricted Project
daltenty accepted D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..

LGTM

Fri, Aug 9, 12:53 PM · Restricted Project

Thu, Aug 8

daltenty added a comment to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..

I think this patch needs to be rebased again now that D64825 has landed

Thu, Aug 8, 10:39 AM · Restricted Project
daltenty committed rG8558aac82cd2: Enable assembly output of local commons for AIX (authored by daltenty).
Enable assembly output of local commons for AIX
Thu, Aug 8, 8:42 AM
daltenty committed rL368306: Enable assembly output of local commons for AIX.
Enable assembly output of local commons for AIX
Thu, Aug 8, 8:42 AM
daltenty closed D64825: Enable assembly output of local commons for AIX.
Thu, Aug 8, 8:42 AM · Restricted Project

Wed, Aug 7

daltenty updated the diff for D64825: Enable assembly output of local commons for AIX.
  • Add missing other cases of isBSSLocal
  • Update unreachable error message to reflect this is an internal error
Wed, Aug 7, 2:18 PM · Restricted Project
daltenty updated the diff for D64825: Enable assembly output of local commons for AIX.
Address comments:
  - Limit to local bss
Wed, Aug 7, 1:15 PM · Restricted Project
daltenty updated the diff for D64825: Enable assembly output of local commons for AIX.

Rebase after commit of dependencies

Wed, Aug 7, 11:51 AM · Restricted Project

Tue, Aug 6

daltenty accepted D65688: [AIX][test/Index] Set/propagate AIXTHREAD_STK for AIX.

LGTM

Tue, Aug 6, 12:34 PM · Restricted Project, Restricted Project
daltenty accepted D65669: [CMake] Add mapping for IBM XL -qnoeh and -qnortti.

LGTM

Tue, Aug 6, 6:02 AM · Restricted Project

Wed, Jul 24

daltenty committed rGb9179ff8576d: [AIX][lit] Don't depend on psutil on AIX (authored by daltenty).
[AIX][lit] Don't depend on psutil on AIX
Wed, Jul 24, 8:06 AM
daltenty committed rL366912: [AIX][lit] Don't depend on psutil on AIX.
[AIX][lit] Don't depend on psutil on AIX
Wed, Jul 24, 8:05 AM
daltenty closed D64251: Don't depend on psutil on AIX.
Wed, Jul 24, 8:05 AM · Restricted Project, Restricted Project, Restricted Project
daltenty updated the summary of D64251: Don't depend on psutil on AIX.
Wed, Jul 24, 7:53 AM · Restricted Project, Restricted Project, Restricted Project
daltenty updated the summary of D64251: Don't depend on psutil on AIX.
Wed, Jul 24, 7:50 AM · Restricted Project, Restricted Project, Restricted Project

Jul 23 2019

daltenty added a comment to D64251: Don't depend on psutil on AIX.

Ping for an explicit acceptance.

Jul 23 2019, 7:52 AM · Restricted Project, Restricted Project, Restricted Project

Jul 22 2019

daltenty updated the diff for D64251: Don't depend on psutil on AIX.
  • Fix typo in comment
Jul 22 2019, 8:10 AM · Restricted Project, Restricted Project, Restricted Project

Jul 16 2019

daltenty added a child revision for D64652: [AIX] Add a TargetLoweringObjectFile for XCOFF and add support for common variables.: D64825: Enable assembly output of local commons for AIX.
Jul 16 2019, 3:01 PM · Restricted Project
daltenty added a parent revision for D64825: Enable assembly output of local commons for AIX: D64652: [AIX] Add a TargetLoweringObjectFile for XCOFF and add support for common variables..
Jul 16 2019, 3:01 PM · Restricted Project
daltenty created D64825: Enable assembly output of local commons for AIX.
Jul 16 2019, 3:01 PM · Restricted Project

Jul 15 2019

daltenty accepted D64652: [AIX] Add a TargetLoweringObjectFile for XCOFF and add support for common variables..

LGTM

Jul 15 2019, 10:13 AM · Restricted Project

Jul 12 2019

daltenty updated the diff for D64251: Don't depend on psutil on AIX.
  • Add a space to warning in LLDB lit config
Jul 12 2019, 3:30 PM · Restricted Project, Restricted Project, Restricted Project
daltenty updated the diff for D64251: Don't depend on psutil on AIX.
  • Address review comments round 3
Jul 12 2019, 3:29 PM · Restricted Project, Restricted Project, Restricted Project
daltenty added inline comments to D64251: Don't depend on psutil on AIX.
Jul 12 2019, 3:27 PM · Restricted Project, Restricted Project, Restricted Project
daltenty committed rGae79a2c3900c: Fix missing use of defined() in include guard (authored by daltenty).
Fix missing use of defined() in include guard
Jul 12 2019, 1:13 PM
daltenty committed rL365952: Fix missing use of defined() in include guard.
Fix missing use of defined() in include guard
Jul 12 2019, 1:13 PM
daltenty closed D64657: Fix missing use of defined() in include guard in AMDGPU target.
Jul 12 2019, 1:13 PM · Restricted Project
daltenty retitled D64657: Fix missing use of defined() in include guard in AMDGPU target from Fix missing use of defined() in include guard to Fix missing use of defined() in include guard in AMDGPU target.
Jul 12 2019, 12:15 PM · Restricted Project
daltenty created D64657: Fix missing use of defined() in include guard in AMDGPU target.
Jul 12 2019, 12:09 PM · Restricted Project

Jul 11 2019

daltenty updated the diff for D64251: Don't depend on psutil on AIX.
  • Address review comments round 2
Jul 11 2019, 8:43 PM · Restricted Project, Restricted Project, Restricted Project

Jul 10 2019

daltenty committed rGa2681296e0d0: [NFC]Fix IR/MC depency issue for function descriptor SDAG implementation (authored by daltenty).
[NFC]Fix IR/MC depency issue for function descriptor SDAG implementation
Jul 10 2019, 3:19 PM
daltenty committed rL365701: [NFC]Fix IR/MC depency issue for function descriptor SDAG implementation.
[NFC]Fix IR/MC depency issue for function descriptor SDAG implementation
Jul 10 2019, 3:14 PM
daltenty closed D64445: [NFC]Fix IR/MC depency issue for function descriptor SDAG implementation.
Jul 10 2019, 3:14 PM · Restricted Project
daltenty added a comment to D64251: Don't depend on psutil on AIX.

This is adding a fair amount of complexity on something that just works fine on basically every platform but AIX.
If AIX has issue with psutil, maybe the fix should be submitted to psutil upstream instead of having this dance here?

Jul 10 2019, 3:06 PM · Restricted Project, Restricted Project, Restricted Project

Jul 9 2019

daltenty updated the diff for D64251: Don't depend on psutil on AIX.
  • Use subprocess.call instead of importing it
  • Create killProcessAndChildrenIsSupported check and rewrite things to use it
Jul 9 2019, 2:06 PM · Restricted Project, Restricted Project, Restricted Project

Jul 5 2019

daltenty updated the summary of D64251: Don't depend on psutil on AIX.
Jul 5 2019, 1:46 PM · Restricted Project, Restricted Project, Restricted Project
daltenty added reviewers for D64251: Don't depend on psutil on AIX: hubert.reinterpretcast, andusy.
Jul 5 2019, 8:48 AM · Restricted Project, Restricted Project, Restricted Project
daltenty created D64251: Don't depend on psutil on AIX.
Jul 5 2019, 8:48 AM · Restricted Project, Restricted Project, Restricted Project

Jun 7 2019

daltenty committed rGa8d13df41278: Build with _XOPEN_SOURCE defined on AIX (authored by daltenty).
Build with _XOPEN_SOURCE defined on AIX
Jun 7 2019, 8:43 AM
daltenty committed rL362808: Build with _XOPEN_SOURCE defined on AIX.
Build with _XOPEN_SOURCE defined on AIX
Jun 7 2019, 8:42 AM
daltenty closed D62533: Build with _XOPEN_SOURCE defined on AIX.
Jun 7 2019, 8:42 AM · Restricted Project, Restricted Project

Jun 6 2019

daltenty committed rGb82ea52b78e8: [NFC] Test commit, whitespace change (authored by daltenty).
[NFC] Test commit, whitespace change
Jun 6 2019, 3:05 PM
daltenty committed rL362753: [NFC] Test commit, whitespace change.
[NFC] Test commit, whitespace change
Jun 6 2019, 3:05 PM

Jun 3 2019

daltenty updated the diff for D62533: Build with _XOPEN_SOURCE defined on AIX.

Fix grammar in comments. Fix up the way we define the macros for Google Test.

Jun 3 2019, 4:35 PM · Restricted Project, Restricted Project

May 28 2019

daltenty updated the diff for D62084: Fix DWARF DebugInfo unit test errors when cross-compiling.

Respond to comments round 1.

May 28 2019, 10:41 AM · Restricted Project
daltenty created D62533: Build with _XOPEN_SOURCE defined on AIX.
May 28 2019, 10:20 AM · Restricted Project, Restricted Project

May 24 2019

daltenty accepted D61532: implement of the parsing symbol table for xcoffobjfile and output as yaml format.

LGTM (with addition of comment @hubert.reinterpretcast suggested above)

May 24 2019, 1:46 PM · Restricted Project

May 23 2019

daltenty requested changes to D61532: implement of the parsing symbol table for xcoffobjfile and output as yaml format.
May 23 2019, 8:08 AM · Restricted Project

May 21 2019

daltenty created D62203: Disable EHFrameSupport in JITLink/RuntimeDyld on AIX .
May 21 2019, 8:28 AM · Restricted Project

May 17 2019

daltenty created D62084: Fix DWARF DebugInfo unit test errors when cross-compiling.
May 17 2019, 2:31 PM · Restricted Project

May 15 2019

daltenty added inline comments to D61326: Fixes for builds that require strict X/Open and POSIX compatiblity.
May 15 2019, 1:38 PM · Restricted Project
daltenty updated the diff for D61326: Fixes for builds that require strict X/Open and POSIX compatiblity.
  • Fix loop on strtok_r
May 15 2019, 1:37 PM · Restricted Project

May 14 2019

daltenty updated the diff for D61326: Fixes for builds that require strict X/Open and POSIX compatiblity.

Fix style

May 14 2019, 3:00 PM · Restricted Project

May 10 2019

daltenty updated the diff for D61326: Fixes for builds that require strict X/Open and POSIX compatiblity.
May 10 2019, 6:12 PM · Restricted Project
daltenty added inline comments to D61326: Fixes for builds that require strict X/Open and POSIX compatiblity.
May 10 2019, 6:10 PM · Restricted Project

May 2 2019

daltenty updated the diff for D61326: Fixes for builds that require strict X/Open and POSIX compatiblity.
  • Address formatting comments
  • Revert to using MAP_ANON
  • Close the file descriptor on all return paths in Memory::allocateMappedMemory
  • Cleanup the pointers we keep in getprogpath
May 2 2019, 2:55 PM · Restricted Project
daltenty updated the summary of D61326: Fixes for builds that require strict X/Open and POSIX compatiblity.
May 2 2019, 10:23 AM · Restricted Project

Apr 30 2019

daltenty created D61326: Fixes for builds that require strict X/Open and POSIX compatiblity.
Apr 30 2019, 10:58 AM · Restricted Project

Apr 23 2019

daltenty accepted D60878: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj.

Retested with binaries. Looks good to me.

Apr 23 2019, 11:54 AM · Restricted Project
daltenty requested changes to D60878: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj.

The format of the binaries included in the patch don't seem correct, they create empty files. As a result the corresponding test are failing.

Apr 23 2019, 8:12 AM · Restricted Project

Apr 22 2019

daltenty added a reviewer for D60878: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj: daltenty.
Apr 22 2019, 1:16 PM · Restricted Project