Page MenuHomePhabricator

daltenty (David Tenty)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 4 2019, 2:54 PM (36 w, 13 h)

Recent Activity

Wed, Dec 11

daltenty committed rG70d14255dfcd: Don't call export_symbols.py with duplicate libs (authored by daltenty).
Don't call export_symbols.py with duplicate libs
Wed, Dec 11, 2:30 PM
daltenty closed D70918: Don't call export_symbols.py with duplicate libs.
Wed, Dec 11, 2:29 PM · Restricted Project

Tue, Dec 10

daltenty added inline comments to D71144: Not emit correct Assembly for Global Function pointer initiated with function..
Tue, Dec 10, 10:27 AM · Restricted Project
daltenty added inline comments to D71125: [AIX] Avoid unset csect assert for functions defined after their use in TOC.
Tue, Dec 10, 10:09 AM · Restricted Project
daltenty accepted D70859: [BUG-FIX][XCOFF] fixed a bug of XCOFFObjectFile.cpp when there is padding at the last csect of a sections.

Other than minor nit, LGTM

Tue, Dec 10, 8:10 AM · Restricted Project

Fri, Dec 6

daltenty added inline comments to D70859: [BUG-FIX][XCOFF] fixed a bug of XCOFFObjectFile.cpp when there is padding at the last csect of a sections.
Fri, Dec 6, 1:58 PM · Restricted Project
daltenty updated the diff for D70918: Don't call export_symbols.py with duplicate libs.
  • Move the deduplication after the loop, so we also cover the transitive dependencies
Fri, Dec 6, 1:39 PM · Restricted Project
daltenty accepted D71120: [NFC][AIX][XCOFF] if the size of Csect is zero, the Csect do not need write any data into sections.

LGTM

Fri, Dec 6, 9:18 AM · Restricted Project
daltenty added reviewers for D71125: [AIX] Avoid unset csect assert for functions defined after their use in TOC: Xiangling_L, DiggerLin, jasonliu.
Fri, Dec 6, 8:57 AM · Restricted Project
daltenty created D71125: [AIX] Avoid unset csect assert for functions defined after their use in TOC.
Fri, Dec 6, 8:57 AM · Restricted Project
daltenty accepted D71119: [NFC][AIX][XCOFF] fixed compile warning on the strncpy..

LGTM (previous discussion in D70859)

Fri, Dec 6, 7:52 AM · Restricted Project

Thu, Dec 5

daltenty accepted D70719: created a test case to verify the raw text section of xcoffobject file.

LGTM with minor nit

Thu, Dec 5, 12:38 PM · Restricted Project
daltenty committed rG1ea1e053f6a1: [AIX] Make sure to use QualNames for external global objects (authored by daltenty).
[AIX] Make sure to use QualNames for external global objects
Thu, Dec 5, 12:26 PM
daltenty closed D71032: [AIX] Make sure to use QualNames for external global objects.
Thu, Dec 5, 12:26 PM · Restricted Project
daltenty updated the diff for D71032: [AIX] Make sure to use QualNames for external global objects.
  • Remove redundant return
Thu, Dec 5, 8:09 AM · Restricted Project
daltenty updated the diff for D71032: [AIX] Make sure to use QualNames for external global objects.
  • Add comment
Thu, Dec 5, 7:34 AM · Restricted Project

Wed, Dec 4

daltenty added inline comments to D71032: [AIX] Make sure to use QualNames for external global objects.
Wed, Dec 4, 8:16 PM · Restricted Project
daltenty created D71032: [AIX] Make sure to use QualNames for external global objects.
Wed, Dec 4, 2:00 PM · Restricted Project
daltenty added reviewers for D71032: [AIX] Make sure to use QualNames for external global objects: jasonliu, DiggerLin, stevewan.
Wed, Dec 4, 2:00 PM · Restricted Project

Tue, Dec 3

daltenty accepted D70798: [XCOFF][AIX] Emit TOC entries for object file generation.

LGTM

Tue, Dec 3, 1:30 PM · Restricted Project
daltenty added reviewers for D70972: [AIX] Make sure we use export lists for plugins: jasonliu, DiggerLin, stevewan.
Tue, Dec 3, 11:01 AM · Restricted Project
daltenty created D70972: [AIX] Make sure we use export lists for plugins.
Tue, Dec 3, 11:01 AM · Restricted Project
daltenty added inline comments to D70719: created a test case to verify the raw text section of xcoffobject file.
Tue, Dec 3, 9:09 AM · Restricted Project
daltenty requested changes to D70859: [BUG-FIX][XCOFF] fixed a bug of XCOFFObjectFile.cpp when there is padding at the last csect of a sections.

I really think this should probably be split, at least definitely for the commits, as there are a few separate issues going on here that don't seem related.

Tue, Dec 3, 8:32 AM · Restricted Project

Mon, Dec 2

daltenty added a reviewer for D70918: Don't call export_symbols.py with duplicate libs: john.brawn.
Mon, Dec 2, 12:15 PM · Restricted Project
daltenty created D70918: Don't call export_symbols.py with duplicate libs.
Mon, Dec 2, 12:00 PM · Restricted Project
daltenty added a reverting change for rG19daa21f841a: [clangd] Rethink how SelectionTree deals with macros and #includes.: Unknown Object (Differential Revision).
Mon, Dec 2, 11:57 AM
daltenty added a reverting change for rG19daa21f841a: [clangd] Rethink how SelectionTree deals with macros and #includes.: Unknown Object (Differential Revision).
Mon, Dec 2, 11:56 AM
daltenty committed rG3ebfab709583: Add AIX assembler support (authored by stevewan).
Add AIX assembler support
Mon, Dec 2, 8:35 AM
daltenty closed D69620: Add AIX assembler support.
Mon, Dec 2, 8:34 AM · Restricted Project
daltenty accepted D69620: Add AIX assembler support.
Mon, Dec 2, 8:34 AM · Restricted Project

Fri, Nov 29

daltenty added inline comments to D70798: [XCOFF][AIX] Emit TOC entries for object file generation.
Fri, Nov 29, 1:35 PM · Restricted Project
daltenty accepted D69620: Add AIX assembler support.

Other than minor nit, LGTM

Fri, Nov 29, 6:14 AM · Restricted Project

Wed, Nov 27

daltenty committed rG98740643f794: [AIX] Emit TOC entries for ASM printing (authored by daltenty).
[AIX] Emit TOC entries for ASM printing
Wed, Nov 27, 2:27 PM
daltenty closed D70461: [AIX] Emit TOC entries for ASM printing.
Wed, Nov 27, 2:27 PM · Restricted Project
daltenty added inline comments to D70461: [AIX] Emit TOC entries for ASM printing.
Wed, Nov 27, 1:14 PM · Restricted Project
daltenty updated the diff for D70461: [AIX] Emit TOC entries for ASM printing.
  • Move early return.
  • Address other comments.
Wed, Nov 27, 1:14 PM · Restricted Project
daltenty updated the diff for D70461: [AIX] Emit TOC entries for ASM printing.
  • Remove unneeded header
Wed, Nov 27, 9:04 AM · Restricted Project
daltenty updated the diff for D70461: [AIX] Emit TOC entries for ASM printing.

Address review comments round 2 including:

  • Minor edits
  • Don't change the emitTCEntry interface
  • Refactor getMCSymbolForTOCPseudoMO
Wed, Nov 27, 8:55 AM · Restricted Project
daltenty added inline comments to D70461: [AIX] Emit TOC entries for ASM printing.
Wed, Nov 27, 8:55 AM · Restricted Project

Tue, Nov 26

daltenty added inline comments to D70461: [AIX] Emit TOC entries for ASM printing.
Tue, Nov 26, 2:36 PM · Restricted Project
daltenty committed rGa38fc6164879: [AIX] Disable clang python binding tests (authored by daltenty).
[AIX] Disable clang python binding tests
Tue, Nov 26, 12:31 PM
daltenty closed D70675: [AIX] Disable clang python binding tests.
Tue, Nov 26, 12:31 PM · Restricted Project
daltenty added inline comments to D70461: [AIX] Emit TOC entries for ASM printing.
Tue, Nov 26, 11:45 AM · Restricted Project
daltenty added inline comments to D70461: [AIX] Emit TOC entries for ASM printing.
Tue, Nov 26, 8:43 AM · Restricted Project

Mon, Nov 25

daltenty added reviewers for D70675: [AIX] Disable clang python binding tests: stevewan, jasonliu, hubert.reinterpretcast, mgorny.
Mon, Nov 25, 9:23 AM · Restricted Project
daltenty created D70675: [AIX] Disable clang python binding tests.
Mon, Nov 25, 9:19 AM · Restricted Project

Fri, Nov 22

daltenty added inline comments to D70461: [AIX] Emit TOC entries for ASM printing.
Fri, Nov 22, 11:02 AM · Restricted Project
daltenty updated the diff for D70461: [AIX] Emit TOC entries for ASM printing.

Address review comments, including:

Fri, Nov 22, 10:55 AM · Restricted Project
daltenty accepted D70443: [AIX][XCOFF] Generate undefined symbol in symbol table for external function call.

LGTM

Fri, Nov 22, 8:34 AM · Restricted Project

Thu, Nov 21

daltenty added inline comments to D70461: [AIX] Emit TOC entries for ASM printing.
Thu, Nov 21, 8:16 AM · Restricted Project
daltenty accepted D70455: [XCOFF][AIX] Read-only data section object file generation.

Other than minor nit, LGTM

Thu, Nov 21, 7:12 AM · Restricted Project

Tue, Nov 19

daltenty added inline comments to D70443: [AIX][XCOFF] Generate undefined symbol in symbol table for external function call.
Tue, Nov 19, 2:24 PM · Restricted Project
daltenty added a parent revision for D70461: [AIX] Emit TOC entries for ASM printing: D70443: [AIX][XCOFF] Generate undefined symbol in symbol table for external function call.
Tue, Nov 19, 1:56 PM · Restricted Project
daltenty added a child revision for D70443: [AIX][XCOFF] Generate undefined symbol in symbol table for external function call: D70461: [AIX] Emit TOC entries for ASM printing.
Tue, Nov 19, 1:56 PM · Restricted Project
daltenty updated the summary of D70461: [AIX] Emit TOC entries for ASM printing.
Tue, Nov 19, 1:56 PM · Restricted Project
daltenty created D70461: [AIX] Emit TOC entries for ASM printing.
Tue, Nov 19, 1:56 PM · Restricted Project

Mon, Nov 18

daltenty accepted D70310: [AIX][XCOFF] Add support for generating assembly code for one-byte mergable strings.

LGTM

Mon, Nov 18, 8:44 AM · Restricted Project
daltenty added inline comments to D69620: Add AIX assembler support.
Mon, Nov 18, 7:07 AM · Restricted Project

Fri, Nov 15

daltenty added a comment to D70271: [AIX][XCOFF] Write Function descriptors and TOC base to data section.

Do we care about asserting the uniqueness of the TOC anchor somewhere?

Fri, Nov 15, 8:09 AM · Restricted Project

Thu, Nov 14

daltenty accepted D70182: Add read-only data assembly writing.

LGTM

Thu, Nov 14, 12:52 PM · Restricted Project

Wed, Nov 13

daltenty added inline comments to D70182: Add read-only data assembly writing.
Wed, Nov 13, 1:47 PM · Restricted Project
daltenty committed rG8b2b2c08d994: Don't set LLVM_NO_DEAD_STRIP on AIX (authored by daltenty).
Don't set LLVM_NO_DEAD_STRIP on AIX
Wed, Nov 13, 9:05 AM
daltenty closed D70130: Don't set LLVM_NO_DEAD_STRIP on AIX.
Wed, Nov 13, 9:05 AM · Restricted Project

Nov 12 2019

daltenty added reviewers for D70130: Don't set LLVM_NO_DEAD_STRIP on AIX: xingxue, DiggerLin.
Nov 12 2019, 11:32 AM · Restricted Project
daltenty created D70130: Don't set LLVM_NO_DEAD_STRIP on AIX.
Nov 12 2019, 9:14 AM · Restricted Project
daltenty added reviewers for D70130: Don't set LLVM_NO_DEAD_STRIP on AIX: stevewan, sfertile, jasonliu.
Nov 12 2019, 9:14 AM · Restricted Project

Nov 8 2019

daltenty committed rG0dc0572b48ed: [XCOFF][AIX] Differentiate usage of label symbol and csect symbol (authored by jasonliu).
[XCOFF][AIX] Differentiate usage of label symbol and csect symbol
Nov 8 2019, 6:34 AM
daltenty closed D69633: [XCOFF][AIX] Differentiate usage of label symbol and csect symbol.
Nov 8 2019, 6:34 AM · Restricted Project
daltenty accepted D69633: [XCOFF][AIX] Differentiate usage of label symbol and csect symbol.

LGTM

Nov 8 2019, 6:25 AM · Restricted Project

Nov 6 2019

daltenty committed rG6740a88dc18d: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable() (authored by daltenty).
[NFC] Add SUPPORT_PLUGINS to add_llvm_executable()
Nov 6 2019, 11:34 AM
daltenty added a reverting change for D69356: [NFC] Rename LLVM_NO_DEAD_STRIP: rG6740a88dc18d: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable().
Nov 6 2019, 11:33 AM · Restricted Project, Restricted Project
daltenty closed D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable().
Nov 6 2019, 11:33 AM · Restricted Project, Restricted Project

Nov 1 2019

daltenty accepted D69528: [PowerPC][XCOFF] Add assembly support for zero initalized global values..

LGTM

Nov 1 2019, 12:16 PM · Restricted Project
daltenty updated the diff for D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable().
  • Rebase
Nov 1 2019, 9:04 AM · Restricted Project, Restricted Project
daltenty updated the diff for D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable().
  • Address review comments round 1
Nov 1 2019, 8:59 AM · Restricted Project, Restricted Project

Oct 30 2019

daltenty added a reverting change for D69356: [NFC] Rename LLVM_NO_DEAD_STRIP: D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable().
Oct 30 2019, 1:34 PM · Restricted Project, Restricted Project
daltenty added a comment to D69356: [NFC] Rename LLVM_NO_DEAD_STRIP.

Revised direction in https://reviews.llvm.org/D69638

Oct 30 2019, 1:34 PM · Restricted Project, Restricted Project
daltenty updated the summary of D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable().
Oct 30 2019, 1:34 PM · Restricted Project, Restricted Project
daltenty created D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable().
Oct 30 2019, 1:34 PM · Restricted Project, Restricted Project
daltenty added a reverting change for rG11c2a85db884: [NFC] Rename LLVM_NO_DEAD_STRIP: rG23df0c783c70: Revert "[NFC] Rename LLVM_NO_DEAD_STRIP".
Oct 30 2019, 12:00 PM
daltenty committed rG23df0c783c70: Revert "[NFC] Rename LLVM_NO_DEAD_STRIP" (authored by daltenty).
Revert "[NFC] Rename LLVM_NO_DEAD_STRIP"
Oct 30 2019, 12:00 PM
daltenty added a comment to D69356: [NFC] Rename LLVM_NO_DEAD_STRIP.

We should not be adding more variables that are passed around by CMake's scope inheritance. Instead if we need to change this we should do it correctly.

Just to clarify, the actions to take are to restore LLVM_NO_DEAD_STRIP in order to support other uses and then to replace its use as an internal variable? Given that direction, I agree the first course of action is to revert this patch and then to pursue a patch to do the replacement separately.

Oct 30 2019, 12:00 PM · Restricted Project, Restricted Project
daltenty added a comment to D69356: [NFC] Rename LLVM_NO_DEAD_STRIP.

I'm actually opposed to that happening, on two fronts.
(2) we already have LLVM_ENABLE_PLUGINS why do we also need LLVM_SUPPORT_PLUGINS seems like duplication and bad design.

Oct 30 2019, 11:02 AM · Restricted Project, Restricted Project
daltenty added a comment to D69356: [NFC] Rename LLVM_NO_DEAD_STRIP.
Oct 30 2019, 10:31 AM · Restricted Project, Restricted Project

Oct 29 2019

daltenty accepted D67125: [PowerPC][AIX] Adds support for writing the data section in object files.

Other than the minor test cleanup proposed by @sfertile, LGTM

Oct 29 2019, 8:35 AM · Restricted Project
daltenty added a comment to D67125: [PowerPC][AIX] Adds support for writing the data section in object files.

I don't think that initialized global data should be coming out as label symbols (everything appears to be contained in a ".data" csect). As I understand it only static data should be glob'd into one big csect, as per the XCOFF spec "An initialized definition for a global data scalar or structure ... is contained in its own csect". So each of these globals should have their own csect, which is the behavior exhibited by XLC.

I've observed that GCC on AIX is currently exhibiting this initalized-globals-in-one-csect behavior, but as we might expect, it interferes with the linkers ability to garbage collect unneeded global data.

I believe this is also an issue in the assembly path in D66154

Oct 29 2019, 8:34 AM · Restricted Project
daltenty requested changes to D67125: [PowerPC][AIX] Adds support for writing the data section in object files.

I don't think that initialized global data should be coming out as label symbols (everything appears to be contained in a ".data" csect). As I understand it only static data should be glob'd into one big csect, as per the XCOFF spec "An initialized definition for a global data scalar or structure ... is contained in its own csect". So each of these globals should have their own csect, which is the behavior exhibited by XLC.

Oct 29 2019, 7:39 AM · Restricted Project

Oct 28 2019

daltenty added inline comments to D67125: [PowerPC][AIX] Adds support for writing the data section in object files.
Oct 28 2019, 8:10 AM · Restricted Project
daltenty accepted D69447: [NFCI][XCOFF][AIX] Skip empty Section during object file generation.

LGTM

Oct 28 2019, 7:03 AM · Restricted Project

Oct 25 2019

daltenty committed rG0e4d41531157: Update version number in llvm python bindings (authored by daltenty).
Update version number in llvm python bindings
Oct 25 2019, 2:20 PM
daltenty closed D69436: Update version number in llvm python bindings.
Oct 25 2019, 2:20 PM · Restricted Project
daltenty added inline comments to D69447: [NFCI][XCOFF][AIX] Skip empty Section during object file generation.
Oct 25 2019, 2:10 PM · Restricted Project
daltenty added a reviewer for D69436: Update version number in llvm python bindings: abhina.sree.
Oct 25 2019, 10:53 AM · Restricted Project
daltenty added a reviewer for D69436: Update version number in llvm python bindings: AustinWells.
Oct 25 2019, 9:57 AM · Restricted Project
daltenty created D69436: Update version number in llvm python bindings.
Oct 25 2019, 9:48 AM · Restricted Project
daltenty committed rG11c2a85db884: [NFC] Rename LLVM_NO_DEAD_STRIP (authored by daltenty).
[NFC] Rename LLVM_NO_DEAD_STRIP
Oct 25 2019, 6:41 AM
daltenty closed D69356: [NFC] Rename LLVM_NO_DEAD_STRIP.
Oct 25 2019, 6:41 AM · Restricted Project, Restricted Project

Oct 24 2019

daltenty committed rG201ed14aea8c: Follow on to Namespace fixup for D68340 (authored by daltenty).
Follow on to Namespace fixup for D68340
Oct 24 2019, 2:04 PM
daltenty updated the diff for D69356: [NFC] Rename LLVM_NO_DEAD_STRIP.

Address comments round 1

Oct 24 2019, 1:25 PM · Restricted Project, Restricted Project