Page MenuHomePhabricator

daltenty (David Tenty)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 4 2019, 2:54 PM (106 w, 6 d)

Recent Activity

Mon, Apr 12

daltenty committed rG0788cdf2e3e9: [AIX] Tweak test XFAIL from D99815 (authored by daltenty).
[AIX] Tweak test XFAIL from D99815
Mon, Apr 12, 11:50 AM

Thu, Apr 8

daltenty committed rT592770622fc5: Add csum fallback to HashProgramOutput.sh (authored by daltenty).
Add csum fallback to HashProgramOutput.sh
Thu, Apr 8, 2:28 PM
daltenty closed D100071: Add csum fallback to HashProgramOutput.sh.
Thu, Apr 8, 2:28 PM
daltenty updated the diff for D100071: Add csum fallback to HashProgramOutput.sh.
  • Change is_md5sum to is_md5
Thu, Apr 8, 2:19 PM
daltenty updated the diff for D100071: Add csum fallback to HashProgramOutput.sh.
  • Correct the options we pass to csum
Thu, Apr 8, 10:54 AM
daltenty updated the diff for D100071: Add csum fallback to HashProgramOutput.sh.
  • Fix typo
Thu, Apr 8, 6:14 AM

Wed, Apr 7

daltenty accepted D99752: [AIX][test-suite] Fix 32-bit test-suite build on AIX.

(hopefully someday we can set this based on something internal to the CMake configuration rather than OBJECT_MODE, but that's all we have for now)

Wed, Apr 7, 3:50 PM
daltenty added inline comments to D99752: [AIX][test-suite] Fix 32-bit test-suite build on AIX.
Wed, Apr 7, 3:47 PM
daltenty requested review of D100071: Add csum fallback to HashProgramOutput.sh.
Wed, Apr 7, 3:18 PM

Sun, Mar 28

daltenty added reviewers for D99483: [clang][AIX] Define __STDC_NO_ATOMICS__ for c11 and above: hubert.reinterpretcast, ZarkoCA, cebowleratibm.
Sun, Mar 28, 9:48 PM · Restricted Project
daltenty requested review of D99483: [clang][AIX] Define __STDC_NO_ATOMICS__ for c11 and above.
Sun, Mar 28, 9:46 PM · Restricted Project

Mar 18 2021

daltenty added a reviewer for D98901: [AIX] Update rpath for BUILD_SHARED_LIBS: Xiangling_L.
Mar 18 2021, 3:03 PM · Restricted Project
daltenty planned changes to D97588: [AIX] Disable $ORIGIN rpath.
Mar 18 2021, 11:01 AM · Restricted Project

Mar 15 2021

daltenty accepted D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default..
Mar 15 2021, 2:06 PM · Restricted Project
daltenty added inline comments to D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default..
Mar 15 2021, 1:58 PM · Restricted Project
daltenty committed rGc05990a0ccb0: [PATCH] fix location of test case (authored by w2yehia).
[PATCH] fix location of test case
Mar 15 2021, 6:35 AM

Mar 10 2021

daltenty committed rGbe646e31487b: llvm-lto: default Relocation Model should be selected by the TargetMachine. (authored by w2yehia).
llvm-lto: default Relocation Model should be selected by the TargetMachine.
Mar 10 2021, 2:31 PM
daltenty closed D97507: llvm-lto: default Relocation Model should be selected by the TargetMachine..
Mar 10 2021, 2:31 PM · Restricted Project

Mar 9 2021

daltenty removed a reviewer for D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX: Xiangling_L.
Mar 9 2021, 8:48 AM · Restricted Project
daltenty added a reviewer for D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX: Xiangling_L.
Mar 9 2021, 8:47 AM · Restricted Project

Mar 5 2021

daltenty added inline comments to D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility.
Mar 5 2021, 3:26 PM · Restricted Project

Mar 4 2021

daltenty added inline comments to D97948: [AIX][TLS] Generate 32-bit general-dynamic access code sequence.
Mar 4 2021, 3:21 PM · Restricted Project
daltenty added inline comments to D97948: [AIX][TLS] Generate 32-bit general-dynamic access code sequence.
Mar 4 2021, 7:43 AM · Restricted Project

Mar 3 2021

daltenty accepted D96282: [CMake][AIX] Adjust plugin library externsion used on AIX.

LGTM, thanks!

Mar 3 2021, 10:13 AM · Restricted Project
daltenty committed rG66799bf0e281: [AIX][clang][driver] Restrict /usr/lib to internal library search paths (authored by daltenty).
[AIX][clang][driver] Restrict /usr/lib to internal library search paths
Mar 3 2021, 7:49 AM
daltenty closed D97574: [AIX][clang][driver] Restrict /usr/lib to internal library search paths.
Mar 3 2021, 7:48 AM · Restricted Project

Mar 2 2021

daltenty added inline comments to D96184: [AIX][TLS] Generate TLS variables in assembly files.
Mar 2 2021, 10:22 AM · Restricted Project, Restricted Project
daltenty accepted D96184: [AIX][TLS] Generate TLS variables in assembly files.

LGTM with minor comment and naming fixes

Mar 2 2021, 7:32 AM · Restricted Project, Restricted Project

Mar 1 2021

daltenty accepted D97326: [zorg] Adjust libcxx buildbot config on AIX.

LGTM, thanks!

Mar 1 2021, 11:30 AM

Feb 26 2021

daltenty added a reviewer for D97588: [AIX] Disable $ORIGIN rpath: hubert.reinterpretcast.
Feb 26 2021, 3:01 PM · Restricted Project
daltenty requested review of D97588: [AIX] Disable $ORIGIN rpath.
Feb 26 2021, 3:01 PM · Restricted Project
daltenty requested review of D97574: [AIX][clang][driver] Restrict /usr/lib to internal library search paths.
Feb 26 2021, 12:50 PM · Restricted Project
daltenty added inline comments to D97326: [zorg] Adjust libcxx buildbot config on AIX.
Feb 26 2021, 11:17 AM
daltenty updated the summary of D97326: [zorg] Adjust libcxx buildbot config on AIX.
Feb 26 2021, 11:11 AM
daltenty accepted D97507: llvm-lto: default Relocation Model should be selected by the TargetMachine..

Noting this is to fix assertions in llvm/test/LTO/X86/remangle_intrinsics.ll on AIX.

Feb 26 2021, 8:19 AM · Restricted Project

Feb 23 2021

daltenty accepted D97222: [zorg] Rename cross-targeting buildbot on AIX.
Feb 23 2021, 8:24 AM

Feb 22 2021

daltenty added inline comments to D96184: [AIX][TLS] Generate TLS variables in assembly files.
Feb 22 2021, 3:49 PM · Restricted Project, Restricted Project
daltenty added inline comments to D96184: [AIX][TLS] Generate TLS variables in assembly files.
Feb 22 2021, 3:47 PM · Restricted Project, Restricted Project

Feb 18 2021

daltenty added inline comments to D96184: [AIX][TLS] Generate TLS variables in assembly files.
Feb 18 2021, 3:27 PM · Restricted Project, Restricted Project

Feb 12 2021

daltenty added inline comments to D96184: [AIX][TLS] Generate TLS variables in assembly files.
Feb 12 2021, 3:07 PM · Restricted Project, Restricted Project

Feb 11 2021

daltenty accepted D96526: [zorg] Remove redundant '\'.

Thanks, LGTM

Feb 11 2021, 10:49 AM

Feb 9 2021

daltenty requested changes to D96184: [AIX][TLS] Generate TLS variables in assembly files.
Feb 9 2021, 8:06 PM · Restricted Project, Restricted Project
daltenty accepted D96184: [AIX][TLS] Generate TLS variables in assembly files.

LGTM, with minor nit

Feb 9 2021, 7:30 PM · Restricted Project, Restricted Project
daltenty added inline comments to D96184: [AIX][TLS] Generate TLS variables in assembly files.
Feb 9 2021, 7:12 PM · Restricted Project, Restricted Project
daltenty added inline comments to D96184: [AIX][TLS] Generate TLS variables in assembly files.
Feb 9 2021, 6:28 PM · Restricted Project, Restricted Project
daltenty committed rG318ed9014482: [AIX][llvm][support] Implement getHostCPUName (authored by daltenty).
[AIX][llvm][support] Implement getHostCPUName
Feb 9 2021, 1:30 PM
daltenty closed D95966: [AIX][llvm][support] Implement getHostCPUName.
Feb 9 2021, 1:30 PM · Restricted Project
daltenty retitled D95966: [AIX][llvm][support] Implement getHostCPUName from [AIX][support] Implement getHostCPUName to [AIX][llvm][support] Implement getHostCPUName.
Feb 9 2021, 1:28 PM · Restricted Project
daltenty updated the diff for D95966: [AIX][llvm][support] Implement getHostCPUName.
  • Address comments
Feb 9 2021, 12:58 PM · Restricted Project
daltenty added inline comments to D95966: [AIX][llvm][support] Implement getHostCPUName.
Feb 9 2021, 10:43 AM · Restricted Project

Feb 8 2021

daltenty updated the diff for D95966: [AIX][llvm][support] Implement getHostCPUName.
  • Fix formatting
Feb 8 2021, 11:48 AM · Restricted Project
daltenty updated the diff for D95966: [AIX][llvm][support] Implement getHostCPUName.
  • Handle specialized cases for pwr 4/5/6
Feb 8 2021, 11:00 AM · Restricted Project

Feb 5 2021

daltenty added inline comments to D95966: [AIX][llvm][support] Implement getHostCPUName.
Feb 5 2021, 8:13 AM · Restricted Project
daltenty added inline comments to D95966: [AIX][llvm][support] Implement getHostCPUName.
Feb 5 2021, 7:13 AM · Restricted Project

Feb 4 2021

daltenty updated the diff for D95966: [AIX][llvm][support] Implement getHostCPUName.
  • Simplify
  • Comment
Feb 4 2021, 1:31 PM · Restricted Project
daltenty added inline comments to D95966: [AIX][llvm][support] Implement getHostCPUName.
Feb 4 2021, 1:30 PM · Restricted Project
daltenty updated the diff for D95966: [AIX][llvm][support] Implement getHostCPUName.
  • Remove stray program.h
Feb 4 2021, 8:08 AM · Restricted Project
daltenty updated the summary of D95966: [AIX][llvm][support] Implement getHostCPUName.
Feb 4 2021, 8:02 AM · Restricted Project
daltenty updated the diff for D95966: [AIX][llvm][support] Implement getHostCPUName.
  • Use systemcfg interfaces instead. Move the getsysttype call to the test.
Feb 4 2021, 8:01 AM · Restricted Project

Feb 3 2021

daltenty planned changes to D95966: [AIX][llvm][support] Implement getHostCPUName.
Feb 3 2021, 1:43 PM · Restricted Project
daltenty updated the summary of D95966: [AIX][llvm][support] Implement getHostCPUName.
Feb 3 2021, 12:50 PM · Restricted Project
daltenty added reviewers for D95966: [AIX][llvm][support] Implement getHostCPUName: ZarkoCA, hubert.reinterpretcast, stevewan.
Feb 3 2021, 12:09 PM · Restricted Project
daltenty requested review of D95966: [AIX][llvm][support] Implement getHostCPUName.
Feb 3 2021, 12:06 PM · Restricted Project

Feb 2 2021

daltenty added inline comments to D95528: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX.
Feb 2 2021, 3:26 PM
daltenty added inline comments to D95528: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX.
Feb 2 2021, 9:03 AM

Jan 18 2021

daltenty added inline comments to D94872: [NFC][AIX][XCOFF] Fix compile warning on strncpy.
Jan 18 2021, 9:32 AM · Restricted Project

Dec 15 2020

daltenty accepted D92766: [XCOFF][AIX] Emit EH information in traceback table.

LGTM

Dec 15 2020, 5:21 PM · Restricted Project

Dec 8 2020

daltenty added inline comments to D92766: [XCOFF][AIX] Emit EH information in traceback table.
Dec 8 2020, 8:39 AM · Restricted Project

Dec 1 2020

daltenty accepted D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX.

LGTM

Dec 1 2020, 9:53 AM · Restricted Project, Restricted Project
daltenty added inline comments to D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX.
Dec 1 2020, 8:43 AM · Restricted Project, Restricted Project

Nov 30 2020

daltenty added inline comments to D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX.
Nov 30 2020, 6:33 PM · Restricted Project, Restricted Project
daltenty added inline comments to D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX.
Nov 30 2020, 11:41 AM · Restricted Project, Restricted Project
daltenty added inline comments to D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX.
Nov 30 2020, 11:04 AM · Restricted Project, Restricted Project

Nov 23 2020

daltenty added a comment to D89049: [AIX][XCOFF] print out the traceback info .

The traceback decode format here is quite different from what binutils objdump would generate on AIX:

Nov 23 2020, 2:35 PM · Restricted Project

Nov 13 2020

daltenty accepted D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default.

LGTM, thanks!

Nov 13 2020, 8:44 AM · Restricted Project

Nov 12 2020

daltenty added inline comments to D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default.
Nov 12 2020, 6:56 PM · Restricted Project
daltenty added inline comments to D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default.
Nov 12 2020, 12:59 PM · Restricted Project

Nov 11 2020

daltenty added inline comments to D91112: [compiler-rt][tests] Fix plugin support detection when no ld.gold.
Nov 11 2020, 8:35 PM · Restricted Project

Nov 10 2020

daltenty committed rGae032e271467: [CMake][ExecutionEngine] add HAVE_(DE)REGISTER_FRAME as a config.h macros (authored by daltenty).
[CMake][ExecutionEngine] add HAVE_(DE)REGISTER_FRAME as a config.h macros
Nov 10 2020, 10:11 AM
daltenty closed D87114: [CMake][ExecutionEngine] add HAVE_(DE)REGISTER_FRAME as a config.h macros.
Nov 10 2020, 10:11 AM · Restricted Project
daltenty updated the diff for D87114: [CMake][ExecutionEngine] add HAVE_(DE)REGISTER_FRAME as a config.h macros.
  • Suppress linter warnings for header stub
Nov 10 2020, 9:04 AM · Restricted Project
daltenty updated the diff for D87114: [CMake][ExecutionEngine] add HAVE_(DE)REGISTER_FRAME as a config.h macros.
  • Prefer cmakedefine to cmakedefine01 because the later doesn't work with defined() macro checks
Nov 10 2020, 7:05 AM · Restricted Project

Nov 5 2020

daltenty added inline comments to D87114: [CMake][ExecutionEngine] add HAVE_(DE)REGISTER_FRAME as a config.h macros.
Nov 5 2020, 3:17 PM · Restricted Project
daltenty updated the diff for D87114: [CMake][ExecutionEngine] add HAVE_(DE)REGISTER_FRAME as a config.h macros.
  • Add back in SEH and SJLJ eh guards
Nov 5 2020, 8:09 AM · Restricted Project
daltenty added inline comments to D87114: [CMake][ExecutionEngine] add HAVE_(DE)REGISTER_FRAME as a config.h macros.
Nov 5 2020, 8:09 AM · Restricted Project

Oct 30 2020

daltenty added a comment to D70744: [compiler-rt] Split the builtins CMake build to a separate file.

Just a note on status: This patch is potentially being replaced by https://reviews.llvm.org/D89492

Oct 30 2020, 11:38 AM · Restricted Project, Restricted Project
daltenty updated the summary of D87114: [CMake][ExecutionEngine] add HAVE_(DE)REGISTER_FRAME as a config.h macros.
Oct 30 2020, 8:09 AM · Restricted Project
daltenty retitled D87114: [CMake][ExecutionEngine] add HAVE_(DE)REGISTER_FRAME as a config.h macros from [CMake][ExecutionEngine] convert HAVE_EHTABLES_SUPPORT to a real config.h macro to [CMake][ExecutionEngine] add HAVE_(DE)REGISTER_FRAME as a config.h macros.
Oct 30 2020, 8:08 AM · Restricted Project
daltenty updated the diff for D87114: [CMake][ExecutionEngine] add HAVE_(DE)REGISTER_FRAME as a config.h macros.
  • Cut out the middle man of 'HAVE_EHTABLE_SUPPORT' and just say what we mean.
Oct 30 2020, 8:04 AM · Restricted Project
daltenty added inline comments to D87114: [CMake][ExecutionEngine] add HAVE_(DE)REGISTER_FRAME as a config.h macros.
Oct 30 2020, 8:03 AM · Restricted Project

Oct 23 2020

daltenty added inline comments to D90041: [AIX][cmake] Adjust management of `-G` for linking.
Oct 23 2020, 12:54 PM · Restricted Project
daltenty accepted D90041: [AIX][cmake] Adjust management of `-G` for linking.

LGTM, thanks!

Oct 23 2020, 10:54 AM · Restricted Project
daltenty requested changes to D89492: [compiler-rt] Enable building builtins using top-level CMake file.
Oct 23 2020, 7:43 AM · Restricted Project, Restricted Project

Oct 21 2020

daltenty accepted D89904: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts.

Thanks! I've verified this fixes the test on AIX.

Oct 21 2020, 1:56 PM · Restricted Project
daltenty added a comment to D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts.

@daltenty Do you think this will fix the problem on AIX?

It's not just AIX that will have this problem I suspect. If you configure any cross-compiling build with a 64-bit host, targeting a 32-bit arch, your going to run into the problem. I think checking against a list of known 64-bit arches is good enough for the purposes here, but the check still needs to be against the target, not the host.

Also, the frontend diagnostic looks like it is off for the same reason:

else if (getArchPtrSize(T) != getArchPtrSize(TT))
  Diags.Report(diag::err_drv_incompatible_omp_arch)

T seems to be the target triple, not the host, but the diagnostic reads: pointer size is incompatible with host.

TT is the target triple, otherwise the error message would be backwards, x86 is the OpenMP target architecture and PPC is the host architecture. I'm not sure what you mean by checking the target rather than the host. The target is set explicitly by -fopenmp-targets=<triple>, since it's being set in the test file we try to make sure that the host matches it. If this was just a frontend test we could just specify the host Triple and be done with it. Maybe we could add some CMake options for which offloading libraries were built?

Oct 21 2020, 9:46 AM · Restricted Project
daltenty added a comment to D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts.

@daltenty Do you think this will fix the problem on AIX?

Oct 21 2020, 8:25 AM · Restricted Project
daltenty updated subscribers of D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts.
Oct 21 2020, 7:49 AM · Restricted Project

Oct 20 2020

daltenty added inline comments to D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts.
Oct 20 2020, 3:57 PM · Restricted Project

Oct 19 2020

daltenty accepted D89492: [compiler-rt] Enable building builtins using top-level CMake file.

LGTM, with slight adjustment. Though I will note that this requires a clean build because CMake will complain about the change in source directory in cache:

Oct 19 2020, 3:11 PM · Restricted Project, Restricted Project

Oct 15 2020

daltenty added a comment to D89492: [compiler-rt] Enable building builtins using top-level CMake file.

This is an alternative to D70744. I'm not a fan of introducing compiler-rt/builtins as a new top-level CMake, so I was trying to come up with an alternative and this is what I came up with, let me know what you think.

Oct 15 2020, 5:41 PM · Restricted Project, Restricted Project