- User Since
- Apr 4 2019, 2:54 PM (208 w, 1 d)
Wed, Mar 29
Tue, Mar 28
Mon, Mar 27
Fri, Mar 24
Let's document the option as well under: https://clang.llvm.org/docs/ClangCommandLineReference.html#powerpc
Wed, Mar 22
Thanks, LGTM from the AIX perspective (noting though this benchmark was actually disabled for AIX by https://reviews.llvm.org/D103063 for other source issues)
Mon, Mar 20
LGTM, with a small nit about the test that should be addressed before committing
Fri, Mar 17
Tue, Mar 14
Reopen since this was reverted
Mon, Mar 13
Thu, Mar 9
Produce a diagnostic if the options are used with non-AIX targets
Wed, Mar 8
Since https://reviews.llvm.org/D142842 still needs some revision to be ABI-safe, and this was already good to go, we'll proceed with this patch and D142842 can rebase against it if there are no objections.
Mon, Mar 6
This patch is failing in the libc++ precommit CI attached to this revision as the -rpath option is unsupported on AIX:
Mar 1 2023
Feb 28 2023
It seems there's actually some work going on at the present time to re-work how constant data like this is structured in the XCOFF codegen (e.g. to do some pooling). This patch is likely to conflict and/or be superseded by that approach, so I'm going to put this on hold for the moment till that refactoring lands and we see whether this is still relevant.
LGTM for AIX
Feb 27 2023
Feb 24 2023
Feb 23 2023
Here's an IR only example which will exhibit the invalid AIX assembly after this change:
target datalayout = "E-m:a-i64:64-n32:64-S128-v256:256:256-v512:512:512" target triple = "powerpc64-ibm-aix"
Feb 21 2023
Unfortunately, some of this doesn't really work on AIX linkage model. Specifically, the linker doesn't follow the resolution semantic of trying to resolve weak references locally first that you see on other platforms (we have an option -bweaklocal to enable that), so we prefer the strong def we see in the library. This means this assumption doesn't hold on AIX:
Feb 2 2023
Latest format changes LGTM. Small nit about the test comment.
LGTM, with a minor tweak
LGTM, with some minor nits to address before commit. Updated the description to describe the details of the issue.
Feb 1 2023
Jan 30 2023
Jan 27 2023
Jan 26 2023
Jan 25 2023
LGTM, with small nit to address before commit
Jan 24 2023
Jan 23 2023
Jan 19 2023
Some minor nits about how we can shorten the test, but otherwise LGTM
Looking better, still needs a test though.
Jan 16 2023
Needs a test, I think we should add a couple of -fopenmp=foo run lines to clang/test/Driver/aix-ld.c to verify that the correct linker options are produced for each.
Jan 6 2023
LGTM with new IN_LIST update
Dec 13 2022
The discussion about the meanings of these things should be taken to Discourse, not buried in a couple of patch reviews, in any case.
Dec 12 2022
I believe @phosek documents the intended semantic here in https://reviews.llvm.org/D137451:
Dec 9 2022
LGTM. Some paths in compiler-rt still require LLVM_TARGET_TRIPLE, so commoning the setup makes sense
Dec 7 2022
This broke the AIX CI: https://buildkite.com/llvm-project/libcxx-ci/builds/15656#0184eac6-521b-4d1e-8502-c226673e0ece. Unfortunately it seems the .irp directive isn't supported by the AIX assembler.
New revision LGTM, VisibleNoLinkage is typical reserved for types from inline functions so it doesn't seem sensible to return. Looking at the C++ standard, I'm not even convinced this is guaranteed to be the same object if the function doesn't have external linkage, so I think the guard is sensible.
Nov 29 2022
This patch seem to do a bit more than it's description implies. It makes LLVM_DEFAULT_TARGET_TRIPLE no longer an valid option on the runtimes path:
CMake Warning: Manually-specified variables were not used by the project:
Nov 24 2022
Nov 23 2022
Nov 22 2022
Nov 18 2022
Nov 16 2022
Nov 8 2022
Oct 28 2022
LGTM. Doing the inner computation while observing visibility seems like the right thing to do in this case.
Oct 13 2022
We've rolled the tests added by this into https://reviews.llvm.org/D135885 instead, so abandoning this.
Oct 12 2022
These adjustments were added in https://reviews.llvm.org/D134221
Seems like this is breaking in the libc++ CI: https://buildkite.com/llvm-project/libcxx-ci/builds/14027
Oct 11 2022
Remove __gcd from the patch, as the always_inline we use in the macro for gcc causes problems in this recursive case.
Add newline to end of file
LGTM, thanks for accommodating this change. Should help solve some problems for us.
Oct 7 2022
Oct 4 2022
Do you mean that both unwind_shared and unwind_static both create a target named libunwind.a?