Page MenuHomePhabricator

daltenty (David Tenty)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 4 2019, 2:54 PM (52 w, 4 d)

Recent Activity

Today

daltenty updated the diff for D77235: [NFC][PowerPC] Cleanup 64-bit and Darwin CalleeSavedRegs.
  • Remove VIACopy changes and fix formating
Mon, Apr 6, 7:32 AM · Restricted Project

Thu, Apr 2

daltenty accepted D77080: [NFC][XCOFF][AIX] Refactor get/setContainingCsect.

LGTM

Thu, Apr 2, 9:41 PM · Restricted Project
daltenty retitled D77235: [NFC][PowerPC] Cleanup 64-bit and Darwin CalleeSavedRegs from [NFC][PowerPC] Cleanup AIX 64 and Darwin CalleeSavedRegs to [NFC][PowerPC] Cleanup 64-bit and Darwin CalleeSavedRegs.
Thu, Apr 2, 12:28 PM · Restricted Project
daltenty updated the summary of D77235: [NFC][PowerPC] Cleanup 64-bit and Darwin CalleeSavedRegs.
Thu, Apr 2, 12:28 PM · Restricted Project
daltenty added inline comments to D77235: [NFC][PowerPC] Cleanup 64-bit and Darwin CalleeSavedRegs.
Thu, Apr 2, 12:28 PM · Restricted Project
daltenty updated the diff for D77235: [NFC][PowerPC] Cleanup 64-bit and Darwin CalleeSavedRegs.
  • Rename CSR_SRV4 to CSR_PPC64
Thu, Apr 2, 12:28 PM · Restricted Project

Wed, Apr 1

daltenty added inline comments to D77080: [NFC][XCOFF][AIX] Refactor get/setContainingCsect.
Wed, Apr 1, 5:26 PM · Restricted Project
daltenty added a comment to D77101: [AIX] Return the correct set of callee saved regs.

Posted the NFC patch suggested as D77235

Wed, Apr 1, 12:22 PM · Restricted Project
daltenty created D77235: [NFC][PowerPC] Cleanup 64-bit and Darwin CalleeSavedRegs.
Wed, Apr 1, 12:22 PM · Restricted Project
daltenty planned changes to D77101: [AIX] Return the correct set of callee saved regs.
Wed, Apr 1, 9:20 AM · Restricted Project

Mon, Mar 30

daltenty updated the diff for D77101: [AIX] Return the correct set of callee saved regs.
  • Add newline to test
Mon, Mar 30, 3:51 PM · Restricted Project
daltenty created D77101: [AIX] Return the correct set of callee saved regs.
Mon, Mar 30, 3:51 PM · Restricted Project

Thu, Mar 12

daltenty committed rG3e53bf5781e0: [PowerPC32] Fix the `setcc` inconsistent result type problem (authored by Xiangling_L).
[PowerPC32] Fix the `setcc` inconsistent result type problem
Thu, Mar 12, 8:09 AM
daltenty closed D75702: [PowerPC32] Fix the `setcc` inconsistent result type problem.
Thu, Mar 12, 8:09 AM · Restricted Project
daltenty commandeered D75702: [PowerPC32] Fix the `setcc` inconsistent result type problem.
Thu, Mar 12, 8:08 AM · Restricted Project

Wed, Mar 11

daltenty added a comment to D75866: [AIX] supporting the visibility attribute for aix assembly.

Are we forgetting the case of commons? They also have visibility as part of the assembler directive on AIX.

Wed, Mar 11, 9:37 AM · Restricted Project
daltenty added a comment to D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation.

On AIX and PPC LE Linux after this change we are seeing invalid accesses when the backend asserts/fatal_errors. Looks like the driver and CC1 now share some global TimerGroup state that points to Timers which got created by CC1 but didn't get cleanup after the assert. Reported as: https://bugs.llvm.org/show_bug.cgi?id=45164

Wed, Mar 11, 7:24 AM · Restricted Project, Restricted Project

Feb 27 2020

daltenty committed rGd32fa59fa007: [XCOFF] Don't emit non-external labels in the symbol table and handle… (authored by daltenty).
[XCOFF] Don't emit non-external labels in the symbol table and handle…
Feb 27 2020, 10:37 AM
daltenty closed D74968: [XCOFF] Don't emit non-external labels in the symbol table and handle MCSA_LGlobal.
Feb 27 2020, 10:37 AM · Restricted Project
daltenty updated the diff for D74968: [XCOFF] Don't emit non-external labels in the symbol table and handle MCSA_LGlobal.

Rebase

Feb 27 2020, 8:07 AM · Restricted Project

Feb 25 2020

daltenty retitled D74968: [XCOFF] Don't emit non-external labels in the symbol table and handle MCSA_LGlobal from [XCOFF] Don't emit non-external labels and handle MCSA_LGlobal in emitSymbolAttribute to [XCOFF] Don't emit non-external labels in the symbol table and handle MCSA_LGlobal.
Feb 25 2020, 2:45 PM · Restricted Project
daltenty retitled D74968: [XCOFF] Don't emit non-external labels in the symbol table and handle MCSA_LGlobal from [XCOFF] Handle MCSA_LGlobal in emitSymbolAttribute to [XCOFF] Don't emit non-external labels and handle MCSA_LGlobal in emitSymbolAttribute.
Feb 25 2020, 2:45 PM · Restricted Project
daltenty updated the diff for D74968: [XCOFF] Don't emit non-external labels in the symbol table and handle MCSA_LGlobal.
  • Update comment
Feb 25 2020, 2:36 PM · Restricted Project
daltenty added inline comments to D74968: [XCOFF] Don't emit non-external labels in the symbol table and handle MCSA_LGlobal.
Feb 25 2020, 2:30 PM · Restricted Project
daltenty updated the diff for D74968: [XCOFF] Don't emit non-external labels in the symbol table and handle MCSA_LGlobal.
  • Update tests with labels that shouldn't be in the objectfile
Feb 25 2020, 2:26 PM · Restricted Project
daltenty planned changes to D74968: [XCOFF] Don't emit non-external labels in the symbol table and handle MCSA_LGlobal.
Feb 25 2020, 12:22 PM · Restricted Project
daltenty accepted D75075: [AIX] Remove whitelist checking for ExternalSymbolSDNodes.

LGTM

Feb 25 2020, 11:05 AM · Restricted Project
daltenty added inline comments to D74968: [XCOFF] Don't emit non-external labels in the symbol table and handle MCSA_LGlobal.
Feb 25 2020, 9:51 AM · Restricted Project
daltenty updated the diff for D74968: [XCOFF] Don't emit non-external labels in the symbol table and handle MCSA_LGlobal.
  • Use external to determine if we should emit the symbol table entry
  • Revert to not emitting linkage on the descriptor if it's a static
  • Update test to refer to csect
Feb 25 2020, 9:43 AM · Restricted Project
daltenty added inline comments to D74968: [XCOFF] Don't emit non-external labels in the symbol table and handle MCSA_LGlobal.
Feb 25 2020, 9:42 AM · Restricted Project

Feb 24 2020

daltenty added inline comments to D74968: [XCOFF] Don't emit non-external labels in the symbol table and handle MCSA_LGlobal.
Feb 24 2020, 8:40 AM · Restricted Project
daltenty accepted D71845: [AIX][XCOFF] Fix XCOFFObjectWriter assertion failure with alignment-related gap and improve text section output testing.

Minor nit, but otherwise LGTM

Feb 24 2020, 7:17 AM · Restricted Project
daltenty planned changes to D74968: [XCOFF] Don't emit non-external labels in the symbol table and handle MCSA_LGlobal.
Feb 24 2020, 6:31 AM · Restricted Project

Feb 21 2020

daltenty added inline comments to D74968: [XCOFF] Don't emit non-external labels in the symbol table and handle MCSA_LGlobal.
Feb 21 2020, 1:15 PM · Restricted Project
daltenty accepted D74974: [XCOFF][AIX] Fix incorrect alignment for function descriptor csect.

LGTM

Feb 21 2020, 11:00 AM · Restricted Project
daltenty accepted D74924: [XCOFF][AIX] Put undefined symbol name into StringTable when neccessary.

LGTM

Feb 21 2020, 8:41 AM · Restricted Project
daltenty updated the diff for D74968: [XCOFF] Don't emit non-external labels in the symbol table and handle MCSA_LGlobal.
  • Add missing newline
Feb 21 2020, 8:32 AM · Restricted Project
daltenty created D74968: [XCOFF] Don't emit non-external labels in the symbol table and handle MCSA_LGlobal.
Feb 21 2020, 8:23 AM · Restricted Project

Feb 20 2020

daltenty committed rG9e0c95572e5a: [AIX] Improve 32/64-bit build configuration (authored by daltenty).
[AIX] Improve 32/64-bit build configuration
Feb 20 2020, 12:48 PM
daltenty closed D74256: [AIX] Improve 32/64-bit build configuration.
Feb 20 2020, 12:48 PM · Restricted Project
daltenty committed rG967eeb109bed: [AIX] Pack BasicBlockBits (authored by daltenty).
[AIX] Pack BasicBlockBits
Feb 20 2020, 11:33 AM
daltenty closed D74911: [AIX] Pack BasicBlockBits.
Feb 20 2020, 11:33 AM · Restricted Project
daltenty added a comment to D74911: [AIX] Pack BasicBlockBits.

Would it make sense to move the logic that defines BEGIN_TWO_BYTE_PACK and END_TWO_BYTE_PACK into cmake now that its done in more then one place?

Feb 20 2020, 11:24 AM · Restricted Project
daltenty updated the diff for D74911: [AIX] Pack BasicBlockBits.
  • Fix formating
Feb 20 2020, 11:15 AM · Restricted Project
daltenty updated the summary of D74911: [AIX] Pack BasicBlockBits.
Feb 20 2020, 9:43 AM · Restricted Project
daltenty created D74911: [AIX] Pack BasicBlockBits.
Feb 20 2020, 9:43 AM · Restricted Project

Feb 19 2020

daltenty added inline comments to D70972: [AIX] Make sure we use export lists for plugins.
Feb 19 2020, 7:02 AM · Restricted Project
daltenty updated the diff for D70972: [AIX] Make sure we use export lists for plugins.
  • Update comment
Feb 19 2020, 7:02 AM · Restricted Project

Feb 18 2020

daltenty committed rG58817a0783ca: [clang][XCOFF] Indicate that XCOFF does not support COMDATs (authored by daltenty).
[clang][XCOFF] Indicate that XCOFF does not support COMDATs
Feb 18 2020, 1:12 PM
daltenty closed D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs.
Feb 18 2020, 1:12 PM · Restricted Project, Restricted Project
daltenty updated the diff for D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs.
  • Update lang doc to indicate XCOFF doesn't support COMDAT
Feb 18 2020, 10:26 AM · Restricted Project, Restricted Project
daltenty planned changes to D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs.
Feb 18 2020, 8:07 AM · Restricted Project, Restricted Project
daltenty added a comment to D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs.
  1. We should probably update the COMDAT section of the lang ref to mention XCOFF doesn't support COMDATS.
Feb 18 2020, 8:07 AM · Restricted Project, Restricted Project

Feb 14 2020

daltenty updated the diff for D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs.
  • Add missing newline
Feb 14 2020, 10:39 AM · Restricted Project, Restricted Project
daltenty created D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs.
Feb 14 2020, 10:39 AM · Restricted Project, Restricted Project
daltenty accepted D74622: [AsmPrinter] Use the McASMInfo to determine if we need descriptors..

LGTM

Feb 14 2020, 10:03 AM · Restricted Project
daltenty updated the summary of D74256: [AIX] Improve 32/64-bit build configuration.
Feb 14 2020, 8:32 AM · Restricted Project
daltenty updated the summary of D74256: [AIX] Improve 32/64-bit build configuration.
Feb 14 2020, 8:32 AM · Restricted Project
daltenty updated the diff for D74256: [AIX] Improve 32/64-bit build configuration.
  • Don't present the LLVM_BUILD_32_BITS option on AIX
Feb 14 2020, 8:23 AM · Restricted Project
daltenty added a comment to D73115: [AIX] Minor cleanup in AsmPrinter. [NFC].

This change regresses a whole bunch of lit tests when running on AIX, which change just the march and then stumble into the assert(MAI->needsFunctionDescriptors() && "AIX ABI is descriptor based.");, for example test/CodeGen/XCore/section-name.ll. Perhaps this should live in the PPC target printer instead?

Feb 14 2020, 7:00 AM · Restricted Project

Feb 13 2020

daltenty updated the summary of D74256: [AIX] Improve 32/64-bit build configuration.
Feb 13 2020, 11:46 AM · Restricted Project
daltenty retitled D74256: [AIX] Improve 32/64-bit build configuration from [AIX] Change host detection to return correct 32/64-bit triple to [AIX] Improve 32/64-bit build configuration.
Feb 13 2020, 11:46 AM · Restricted Project
daltenty added inline comments to D74256: [AIX] Improve 32/64-bit build configuration.
Feb 13 2020, 11:28 AM · Restricted Project
daltenty requested changes to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

Please add an option to control this output change.

Feb 13 2020, 9:01 AM · Restricted Project

Feb 11 2020

daltenty added inline comments to D74256: [AIX] Improve 32/64-bit build configuration.
Feb 11 2020, 1:37 PM · Restricted Project
daltenty updated the diff for D74256: [AIX] Improve 32/64-bit build configuration.
  • Don't set -q64 in the CMakeLists, we should use OBJECT_MODE instead on AIX if we are planning to build 64-bit so CMake knows what we are up to.
  • Restore comment
Feb 11 2020, 9:12 AM · Restricted Project
daltenty added inline comments to D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate.
Feb 11 2020, 7:24 AM · Restricted Project, Restricted Project
daltenty added a reviewer for D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate: daltenty.
Feb 11 2020, 7:14 AM · Restricted Project, Restricted Project

Feb 10 2020

daltenty accepted D74240: [NFC] Refactor the tuple of symbol information with structure for llvm-objdump.

LGTM (with note about later follow on)

Feb 10 2020, 12:36 PM · Restricted Project
daltenty added inline comments to D74240: [NFC] Refactor the tuple of symbol information with structure for llvm-objdump.
Feb 10 2020, 10:55 AM · Restricted Project
daltenty added inline comments to D74164: [AIX][XCOFF] Support Mergeable2ByteCString and Mergeable4ByteCString.
Feb 10 2020, 8:52 AM · Restricted Project
daltenty accepted D74164: [AIX][XCOFF] Support Mergeable2ByteCString and Mergeable4ByteCString.

LGTM with minor nit

Feb 10 2020, 8:52 AM · Restricted Project
daltenty added inline comments to D74240: [NFC] Refactor the tuple of symbol information with structure for llvm-objdump.
Feb 10 2020, 8:16 AM · Restricted Project
daltenty retitled D74240: [NFC] Refactor the tuple of symbol information with structure for llvm-objdump from refactor the tuple of symbol information with structure for llvm-objdump to [NFC] Refactor the tuple of symbol information with structure for llvm-objdump.
Feb 10 2020, 6:49 AM · Restricted Project

Feb 7 2020

daltenty added inline comments to D74164: [AIX][XCOFF] Support Mergeable2ByteCString and Mergeable4ByteCString.
Feb 7 2020, 2:16 PM · Restricted Project
daltenty added reviewers for D74256: [AIX] Improve 32/64-bit build configuration: hubert.reinterpretcast, DiggerLin, stevewan.
Feb 7 2020, 2:16 PM · Restricted Project
daltenty created D74256: [AIX] Improve 32/64-bit build configuration.
Feb 7 2020, 2:16 PM · Restricted Project

Feb 4 2020

daltenty added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Feb 4 2020, 8:49 AM · Restricted Project

Feb 3 2020

daltenty committed rG77e71c521726: [AIX] Don't use a zero fill with a second parameter (authored by daltenty).
[AIX] Don't use a zero fill with a second parameter
Feb 3 2020, 12:17 PM
daltenty closed D73554: [AIX] Don't use a zero fill with a second parameter.
Feb 3 2020, 12:17 PM · Restricted Project

Jan 31 2020

daltenty updated the diff for D73554: [AIX] Don't use a zero fill with a second parameter.
  • Update comment
  • Change assertion into report fatal error
  • Address comments
Jan 31 2020, 2:25 PM · Restricted Project
daltenty updated the diff for D70972: [AIX] Make sure we use export lists for plugins.
  • Check for -Wl, form of passing -G
Jan 31 2020, 7:50 AM · Restricted Project

Jan 30 2020

daltenty committed rG809c872aae7c: [NFC] Fix check prefix add in fcanonicalize-elimination.ll (authored by daltenty).
[NFC] Fix check prefix add in fcanonicalize-elimination.ll
Jan 30 2020, 2:22 PM
daltenty updated the diff for D73554: [AIX] Don't use a zero fill with a second parameter.
  • Use IntNumBytes to get the length of fill
Jan 30 2020, 9:10 AM · Restricted Project
daltenty added inline comments to D73554: [AIX] Don't use a zero fill with a second parameter.
Jan 30 2020, 9:10 AM · Restricted Project
daltenty added a reviewer for D70972: [AIX] Make sure we use export lists for plugins: hubert.reinterpretcast.
Jan 30 2020, 8:14 AM · Restricted Project
daltenty added inline comments to D70972: [AIX] Make sure we use export lists for plugins.
Jan 30 2020, 8:04 AM · Restricted Project
daltenty updated the diff for D70972: [AIX] Make sure we use export lists for plugins.
  • Leave -G on for modules and brtl for executables that load them
  • Use REGEX replace to filter flags
  • Guard flags and make sure to add brtl if needed
Jan 30 2020, 7:55 AM · Restricted Project

Jan 29 2020

daltenty accepted D72027: [XCOFF][AIX] Support basic relocation type on AIX.

Other than minor nit, LGTM

Jan 29 2020, 9:58 AM · Restricted Project

Jan 28 2020

daltenty updated the diff for D73554: [AIX] Don't use a zero fill with a second parameter.
  • Remove erroneously emiting fill length
Jan 28 2020, 9:31 AM · Restricted Project
daltenty updated the diff for D73554: [AIX] Don't use a zero fill with a second parameter.
  • Update test to add byte splat
  • Rename MAI query to doesZeroDirectiveSupportNonZeroValue()
Jan 28 2020, 9:26 AM · Restricted Project
daltenty added inline comments to D73554: [AIX] Don't use a zero fill with a second parameter.
Jan 28 2020, 9:26 AM · Restricted Project
daltenty added reviewers for D73554: [AIX] Don't use a zero fill with a second parameter: stevewan, sfertile, DiggerLin, jasonliu.
Jan 28 2020, 7:29 AM · Restricted Project
daltenty updated the diff for D73554: [AIX] Don't use a zero fill with a second parameter.
  • Remove include addition
Jan 28 2020, 7:26 AM · Restricted Project
daltenty created D73554: [AIX] Don't use a zero fill with a second parameter.
Jan 28 2020, 7:26 AM · Restricted Project

Jan 23 2020

daltenty added inline comments to D72027: [XCOFF][AIX] Support basic relocation type on AIX.
Jan 23 2020, 8:19 AM · Restricted Project

Jan 22 2020

daltenty added inline comments to D72027: [XCOFF][AIX] Support basic relocation type on AIX.
Jan 22 2020, 2:22 PM · Restricted Project
daltenty committed rG45a4aaea7fdf: [NFC][XCOFF] Refactor Csect creation into TargetLoweringObjectFile (authored by daltenty).
[NFC][XCOFF] Refactor Csect creation into TargetLoweringObjectFile
Jan 22 2020, 9:09 AM
daltenty closed D72347: [NFC][XCOFF] Refactor Csect creation into TargetLoweringObjectFile.
Jan 22 2020, 9:09 AM · Restricted Project

Jan 20 2020

daltenty added inline comments to D72347: [NFC][XCOFF] Refactor Csect creation into TargetLoweringObjectFile.
Jan 20 2020, 2:18 PM · Restricted Project