Page MenuHomePhabricator

lkail (Kai Luo)
User

Projects

User does not belong to any projects.

User Details

User Since
May 15 2019, 8:43 PM (109 w, 4 d)

Recent Activity

Yesterday

lkail added inline comments to D103501: [clang][AIX] Enable inlined quadword atomic operations.
Sun, Jun 20, 10:07 PM · Restricted Project
lkail updated the diff for D103501: [clang][AIX] Enable inlined quadword atomic operations.

Address comments.

Sun, Jun 20, 10:03 PM · Restricted Project

Thu, Jun 17

lkail added a reviewer for D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64le with no hw watchpoints: nemanjai.
Thu, Jun 17, 10:27 PM · Restricted Project
lkail added a comment to D104394: [MachineCopyPropagation] Fix differences in code gen when compiling with -g.

There is a patch https://reviews.llvm.org/D98401 doing the same. As discussed in D98401, the register in DBG_VALUE should be also updated. I think backward mcp is missing tracking usage when MO.isDebug() like forward mcp does.

Thu, Jun 17, 4:54 AM · Restricted Project
lkail edited reviewers for D104394: [MachineCopyPropagation] Fix differences in code gen when compiling with -g, added: jmorse, condy, qcolombet, efriedma; removed: lattner.
Thu, Jun 17, 4:51 AM · Restricted Project
lkail added inline comments to D98659: [MachineCopyPropagation] Do more backward copy propagations.
Thu, Jun 17, 4:36 AM · Restricted Project

Tue, Jun 15

lkail added a reviewer for D104349: [compiler-rt][atomics][RFC] Enable __atomic_exchange handling case when `val == old`: efriedma.
Tue, Jun 15, 7:52 PM · Restricted Project
lkail requested review of D104349: [compiler-rt][atomics][RFC] Enable __atomic_exchange handling case when `val == old`.
Tue, Jun 15, 7:50 PM · Restricted Project

Mon, Jun 14

lkail committed rG1c450c3d7ec0: [PowerPC] Export 16 byte load-store instructions (authored by lkail).
[PowerPC] Export 16 byte load-store instructions
Mon, Jun 14, 6:56 PM
lkail closed D103010: [PowerPC] Export 16 byte load-store instructions.
Mon, Jun 14, 6:56 PM · Restricted Project

Fri, Jun 11

lkail committed rG6393164cf249: [AIX][compiler-rt] Fix cmake build of libatomic for cmake-3.16+ (authored by lkail).
[AIX][compiler-rt] Fix cmake build of libatomic for cmake-3.16+
Fri, Jun 11, 5:12 PM
lkail closed D103786: [AIX][compiler-rt] Fix cmake build of libatomic for cmake-3.16+.
Fri, Jun 11, 5:12 PM · Restricted Project
lkail added a comment to D103786: [AIX][compiler-rt] Fix cmake build of libatomic for cmake-3.16+.

Removed F_LOADONLY flag to get symbols visible to binder.

Fri, Jun 11, 1:42 AM · Restricted Project
lkail updated the diff for D103786: [AIX][compiler-rt] Fix cmake build of libatomic for cmake-3.16+.
Fri, Jun 11, 1:40 AM · Restricted Project

Thu, Jun 10

lkail updated the diff for D103010: [PowerPC] Export 16 byte load-store instructions.
Thu, Jun 10, 7:46 PM · Restricted Project
lkail added inline comments to D103010: [PowerPC] Export 16 byte load-store instructions.
Thu, Jun 10, 7:45 PM · Restricted Project

Wed, Jun 9

lkail updated the diff for D103010: [PowerPC] Export 16 byte load-store instructions.
Wed, Jun 9, 11:52 PM · Restricted Project
lkail updated the diff for D103010: [PowerPC] Export 16 byte load-store instructions.

Address comments.

Wed, Jun 9, 11:46 PM · Restricted Project
lkail added inline comments to D103010: [PowerPC] Export 16 byte load-store instructions.
Wed, Jun 9, 11:44 PM · Restricted Project
lkail added inline comments to D103010: [PowerPC] Export 16 byte load-store instructions.
Wed, Jun 9, 6:55 PM · Restricted Project
lkail updated the diff for D103786: [AIX][compiler-rt] Fix cmake build of libatomic for cmake-3.16+.

Address comments.

Wed, Jun 9, 1:40 AM · Restricted Project

Tue, Jun 8

lkail committed rGbf58600badb1: [PowerPC] Make sure the first probe is full size or is the last probe when… (authored by lkail).
[PowerPC] Make sure the first probe is full size or is the last probe when…
Tue, Jun 8, 11:36 PM
lkail closed D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned.
Tue, Jun 8, 11:35 PM · Restricted Project
lkail updated the diff for D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned.

Try to fix pre-merge build failure on windows.

Tue, Jun 8, 10:08 PM · Restricted Project
lkail added inline comments to D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned.
Tue, Jun 8, 7:53 PM · Restricted Project
lkail updated the diff for D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned.
Tue, Jun 8, 7:52 PM · Restricted Project
lkail committed rGc87c294397ea: [PowerPC][Dwarf] Assign MMA register's dwarf register number to negative value (authored by lkail).
[PowerPC][Dwarf] Assign MMA register's dwarf register number to negative value
Tue, Jun 8, 7:24 PM
lkail closed D103761: [PowerPC][Dwarf] Assign MMA register's dwarf register number to negative value.
Tue, Jun 8, 7:24 PM · Restricted Project

Mon, Jun 7

lkail added inline comments to D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned.
Mon, Jun 7, 9:07 PM · Restricted Project
lkail added inline comments to D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned.
Mon, Jun 7, 9:06 PM · Restricted Project
lkail updated the diff for D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned.

Address comments.

Mon, Jun 7, 9:04 PM · Restricted Project

Sun, Jun 6

lkail updated the summary of D103786: [AIX][compiler-rt] Fix cmake build of libatomic for cmake-3.16+.
Sun, Jun 6, 9:24 PM · Restricted Project
lkail requested review of D103786: [AIX][compiler-rt] Fix cmake build of libatomic for cmake-3.16+.
Sun, Jun 6, 9:22 PM · Restricted Project
lkail updated the diff for D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned.
Sun, Jun 6, 1:50 AM · Restricted Project
lkail updated the diff for D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned.

Rebased on https://reviews.llvm.org/D103761

Sun, Jun 6, 1:47 AM · Restricted Project
lkail requested review of D103761: [PowerPC][Dwarf] Assign MMA register's dwarf register number to negative value.
Sun, Jun 6, 12:15 AM · Restricted Project

Sat, Jun 5

lkail added inline comments to D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned.
Sat, Jun 5, 9:14 PM · Restricted Project
lkail updated the diff for D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned.
  1. Adjust comments
  2. Swap usage of r0 and r12
Sat, Jun 5, 9:06 PM · Restricted Project
lkail updated the summary of D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned.
Sat, Jun 5, 4:26 AM · Restricted Project

Thu, Jun 3

lkail planned changes to D103614: [PowerPC][AIX][RFC] Generate inlined quadword lock free atomic operations via AtomicExpand.

I wouldn't recommend using AtomicExpansionKind::LLSC for new code. It's been a source of problems on other targets that use/used it: most targets have a forward progress rule that imposes restrictions beyond the ll/sc instructions themselves, and normal code generation can violate them. For example, fast regalloc can insert spills inside the ll/sc loop, or the basic block layout could be rearranged. I think the only target that hasn't run into issues is Hexagon.

Thu, Jun 3, 6:17 PM · Restricted Project
lkail commandeered D91053: [PowerPC] Lump the constants to save one addis for each constant access.
Thu, Jun 3, 7:10 AM · Restricted Project
lkail requested review of D103614: [PowerPC][AIX][RFC] Generate inlined quadword lock free atomic operations via AtomicExpand.
Thu, Jun 3, 6:37 AM · Restricted Project

Tue, Jun 1

lkail requested review of D103501: [clang][AIX] Enable inlined quadword atomic operations.
Tue, Jun 1, 7:41 PM · Restricted Project
lkail updated the diff for D103445: [PowerPC][AIX][RFC] Generate inlined quadword lock free atomic operations.
Tue, Jun 1, 3:50 AM · Restricted Project
lkail requested review of D103445: [PowerPC][AIX][RFC] Generate inlined quadword lock free atomic operations.
Tue, Jun 1, 3:41 AM · Restricted Project

Fri, May 28

lkail updated the diff for D103010: [PowerPC] Export 16 byte load-store instructions.
Fri, May 28, 2:36 AM · Restricted Project
lkail updated the diff for D103010: [PowerPC] Export 16 byte load-store instructions.

Add encoding tests.

Fri, May 28, 2:18 AM · Restricted Project

Thu, May 27

lkail abandoned D100453: [MIR][NFC] Introduce a new method to check a MachineInstr contains implicit register.
Thu, May 27, 6:06 AM · Restricted Project
lkail updated the diff for D103010: [PowerPC] Export 16 byte load-store instructions.
  1. Use DForm to keep consistency
  2. Format fix
Thu, May 27, 4:11 AM · Restricted Project
lkail updated the diff for D103010: [PowerPC] Export 16 byte load-store instructions.
Thu, May 27, 3:08 AM · Restricted Project
lkail updated the diff for D103010: [PowerPC] Export 16 byte load-store instructions.
  1. Solve LQ register constraint RTp != RA by adding early-clobber on RTp
  2. Use doubleword load/store to perform quadword restore/spill
Thu, May 27, 2:59 AM · Restricted Project

Tue, May 25

lkail added a comment to D103010: [PowerPC] Export 16 byte load-store instructions.

we do have to devise a way to ensure RA doesn't allocate the same register to the base and result of LQ

Tue, May 25, 9:37 PM · Restricted Project
lkail added a comment to D103010: [PowerPC] Export 16 byte load-store instructions.

we do have to devise a way to ensure RA doesn't allocate the same register to the base and result of LQ

Tue, May 25, 8:23 PM · Restricted Project

Mon, May 24

lkail updated the diff for D103010: [PowerPC] Export 16 byte load-store instructions.

Fixed failed pre-merge tests.

Mon, May 24, 5:07 AM · Restricted Project
lkail updated the summary of D103010: [PowerPC] Export 16 byte load-store instructions.
Mon, May 24, 4:20 AM · Restricted Project
lkail requested review of D103010: [PowerPC] Export 16 byte load-store instructions.
Mon, May 24, 4:06 AM · Restricted Project

May 16 2021

lkail updated subscribers of D102155: [AIX][compiler-rt] Build and install standalone libatomic.
May 16 2021, 11:56 PM · Restricted Project
lkail committed rG06a9b0c6f445: [Utils] Fix indentation error in utils/wciia.py (authored by lkail).
[Utils] Fix indentation error in utils/wciia.py
May 16 2021, 7:39 AM

May 15 2021

lkail committed rGd56729b4a439: [AIX][compiler-rt] Build and install standalone libatomic (authored by lkail).
[AIX][compiler-rt] Build and install standalone libatomic
May 15 2021, 10:04 PM
lkail closed D102155: [AIX][compiler-rt] Build and install standalone libatomic.
May 15 2021, 10:04 PM · Restricted Project

May 12 2021

lkail updated the diff for D102155: [AIX][compiler-rt] Build and install standalone libatomic.
  • Put atomic.exp in ppc folder
  • Move set(BUILTIN_DEPS builtins) under AIX check
May 12 2021, 10:21 PM · Restricted Project
lkail updated the diff for D102155: [AIX][compiler-rt] Build and install standalone libatomic.
May 12 2021, 10:13 PM · Restricted Project
lkail updated the diff for D102155: [AIX][compiler-rt] Build and install standalone libatomic.
May 12 2021, 8:45 PM · Restricted Project
lkail updated the diff for D102155: [AIX][compiler-rt] Build and install standalone libatomic.
  • Introduce COMPILER_RT_LIBATOMIC_LINK_FLAGS
  • New file atomic.exp under compiler-rt/lib/builtins
  • Minor tweak of dependencies
May 12 2021, 8:44 PM · Restricted Project
lkail added inline comments to D102155: [AIX][compiler-rt] Build and install standalone libatomic.
May 12 2021, 8:01 PM · Restricted Project
lkail updated the diff for D102155: [AIX][compiler-rt] Build and install standalone libatomic.
May 12 2021, 6:16 AM · Restricted Project
lkail updated the diff for D102155: [AIX][compiler-rt] Build and install standalone libatomic.
May 12 2021, 6:01 AM · Restricted Project
lkail updated the summary of D102155: [AIX][compiler-rt] Build and install standalone libatomic.
May 12 2021, 1:18 AM · Restricted Project
lkail updated the summary of D102155: [AIX][compiler-rt] Build and install standalone libatomic.
May 12 2021, 1:17 AM · Restricted Project
lkail added a reviewer for D102155: [AIX][compiler-rt] Build and install standalone libatomic: efriedma.
May 12 2021, 1:08 AM · Restricted Project
lkail added inline comments to D102155: [AIX][compiler-rt] Build and install standalone libatomic.
May 12 2021, 12:59 AM · Restricted Project
lkail updated the diff for D102155: [AIX][compiler-rt] Build and install standalone libatomic.

Try to implement all in cmake.

May 12 2021, 12:54 AM · Restricted Project
lkail added a comment to D102155: [AIX][compiler-rt] Build and install standalone libatomic.

What do you think?

May 12 2021, 12:50 AM · Restricted Project

May 11 2021

lkail updated the diff for D102155: [AIX][compiler-rt] Build and install standalone libatomic.
May 11 2021, 3:26 AM · Restricted Project
lkail updated the diff for D102155: [AIX][compiler-rt] Build and install standalone libatomic.

Address comments by following method introduced by @daltenty in https://reviews.llvm.org/D101959. Now compiling shared atomic library is platform independent.

May 11 2021, 3:11 AM · Restricted Project

May 10 2021

lkail retitled D102155: [AIX][compiler-rt] Build and install standalone libatomic from [AIX][compiler-rt] Build and install libatomic.a to [AIX][compiler-rt] Add cmake module to build libatomic.a.
May 10 2021, 2:02 AM · Restricted Project
lkail updated subscribers of D102155: [AIX][compiler-rt] Build and install standalone libatomic.
May 10 2021, 1:47 AM · Restricted Project
lkail added a reviewer for D102155: [AIX][compiler-rt] Build and install standalone libatomic: samsonov.
May 10 2021, 1:42 AM · Restricted Project
lkail added a reviewer for D102155: [AIX][compiler-rt] Build and install standalone libatomic: howard.hinnant.
May 10 2021, 1:41 AM · Restricted Project
lkail retitled D102155: [AIX][compiler-rt] Build and install standalone libatomic from [AIX] Build and install libatomic.a to [AIX][compiler-rt] Build and install libatomic.a .
May 10 2021, 1:40 AM · Restricted Project
lkail requested review of D102155: [AIX][compiler-rt] Build and install standalone libatomic.
May 10 2021, 1:40 AM · Restricted Project

Apr 15 2021

lkail retitled D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned from [PowerPC] Make sure the first probe is full size or the last probe to [PowerPC] Make sure the first probe is full size or is the last probe.
Apr 15 2021, 1:10 AM · Restricted Project
lkail added inline comments to D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned.
Apr 15 2021, 12:59 AM · Restricted Project
lkail updated the diff for D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned.
Apr 15 2021, 12:57 AM · Restricted Project

Apr 14 2021

lkail planned changes to D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned.

Current solution hasn't guaranteed back-chain pointer is updated atomically, I have another solution for this to guarantee safety and atomic.

Apr 14 2021, 7:45 PM · Restricted Project
lkail requested review of D100453: [MIR][NFC] Introduce a new method to check a MachineInstr contains implicit register.
Apr 14 2021, 12:52 AM · Restricted Project

Apr 13 2021

lkail added a comment to D85288: [PowerPC] Remove implicit use register after transformToImmFormFedByLI().

implicit $x5 is in the explicit operand list.

Should it be an issue that the implicit $x5 should not be in the explicit operand list? Since when we have implicit $x5 as an explicit operand?

Apr 13 2021, 10:45 PM · Restricted Project

Apr 12 2021

lkail updated the diff for D100293: [PowerPC][AIX] Enable sibling call optimization on AIX.
Apr 12 2021, 3:18 AM · Restricted Project
lkail updated the summary of D100293: [PowerPC][AIX] Enable sibling call optimization on AIX.
Apr 12 2021, 3:03 AM · Restricted Project
lkail updated the summary of D100293: [PowerPC][AIX] Enable sibling call optimization on AIX.
Apr 12 2021, 3:01 AM · Restricted Project
lkail requested review of D100293: [PowerPC][AIX] Enable sibling call optimization on AIX.
Apr 12 2021, 3:01 AM · Restricted Project
lkail updated the diff for D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned.
Apr 12 2021, 2:43 AM · Restricted Project
lkail updated the diff for D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned.
Apr 12 2021, 2:30 AM · Restricted Project
lkail requested review of D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned.
Apr 12 2021, 2:08 AM · Restricted Project

Apr 9 2021

lkail added a comment to D85288: [PowerPC] Remove implicit use register after transformToImmFormFedByLI().

Ping

Apr 9 2021, 3:16 AM · Restricted Project
lkail added inline comments to D93191: [PowerPC] Fold select_cc constants when comparing zero into trivial ops.
Apr 9 2021, 3:15 AM · Restricted Project
lkail updated the diff for D93191: [PowerPC] Fold select_cc constants when comparing zero into trivial ops.

Adjust comments.

Apr 9 2021, 3:12 AM · Restricted Project
lkail updated the diff for D100167: [AIX] Adjust CSR order to avoid breaking ABI regarding traceback.
Apr 9 2021, 2:23 AM · Restricted Project
lkail updated the summary of D100167: [AIX] Adjust CSR order to avoid breaking ABI regarding traceback.
Apr 9 2021, 2:04 AM · Restricted Project
lkail updated the summary of D100167: [AIX] Adjust CSR order to avoid breaking ABI regarding traceback.
Apr 9 2021, 2:02 AM · Restricted Project