Page MenuHomePhabricator

lkail (Kai Luo)
User

Projects

User does not belong to any projects.

User Details

User Since
May 15 2019, 8:43 PM (36 w, 1 d)

Recent Activity

Mon, Jan 6

lkail accepted D72125: [NFC] Move InPQueue into normal argument in releaseNode.

LGTM.

Mon, Jan 6, 9:46 PM · Restricted Project
lkail abandoned D72311: [NFC] Add tests for `vshasigmaw`.

Bot works.

Mon, Jan 6, 7:11 PM · Restricted Project
lkail created D72311: [NFC] Add tests for `vshasigmaw`.
Mon, Jan 6, 7:10 PM · Restricted Project
lkail set the repository for D72250: [NFC][PowerPC] Refactor the tryAndWithMask() to rG LLVM Github Monorepo.
Mon, Jan 6, 7:10 PM · Restricted Project

Thu, Jan 2

lkail added inline comments to D72069: [NFC] Add explicit instantiation to releaseNode.
Thu, Jan 2, 3:11 AM · Restricted Project
lkail added a comment to D72069: [NFC] Add explicit instantiation to releaseNode.

Can you add more info about compilation errors and compiler version?

Thu, Jan 2, 12:44 AM · Restricted Project

Mon, Dec 30

lkail accepted D70758: [PowerPC][NFC] Rename record instructions to use _rec suffix instead of o.

LGTM. Given some verbosity can really help us to understand code quickly.

Mon, Dec 30, 6:22 PM · Restricted Project
lkail committed rGcd2a73a9f01b: [MCP] Add stats for backward copy propagation. NFC. (authored by lkail).
[MCP] Add stats for backward copy propagation. NFC.
Mon, Dec 30, 12:52 AM

Sun, Dec 29

lkail accepted D71940: [PowerPC] Legalize saturating vector add/sub.

LGTM with one nit.

Sun, Dec 29, 6:28 PM · Restricted Project

Thu, Dec 26

lkail added a reviewer for D71886: [NFC] Add test case for load-insert-store pattern in InstCombine: shchenz.
Thu, Dec 26, 11:02 PM · Restricted Project
lkail added inline comments to D71828: [InstCombine] Convert vector store to scalar store if only one element updated.
Thu, Dec 26, 12:06 AM · Restricted Project

Dec 23 2019

lkail added a comment to D71833: [PowerPC] if value type is changed after folding rlwinm, stop folding.

I would suggest to retitle it to be more descriptive about code behavior, like 'Add check' blah blah. Describe what bugs it can fix in summary field.

Dec 23 2019, 6:49 PM · Restricted Project

Dec 22 2019

lkail committed rG9681dc9627b1: [PowerPC] Exploit `vrl(b|h|w|d)` to perform vector rotation (authored by lkail).
[PowerPC] Exploit `vrl(b|h|w|d)` to perform vector rotation
Dec 22 2019, 7:09 PM
lkail closed D71324: [PowerPC] Exploit `vrl(b|h|w|d)` to perform vector rotation.
Dec 22 2019, 7:09 PM · Restricted Project

Dec 18 2019

lkail added inline comments to D71589: [PowerPC] Adding a match pattern to recognize the and mask with RLWINM8.
Dec 18 2019, 10:34 PM · Restricted Project
lkail added inline comments to D71589: [PowerPC] Adding a match pattern to recognize the and mask with RLWINM8.
Dec 18 2019, 9:35 PM · Restricted Project
lkail added a comment to D71589: [PowerPC] Adding a match pattern to recognize the and mask with RLWINM8.
Dec 18 2019, 9:26 PM · Restricted Project

Dec 17 2019

lkail updated the diff for D71324: [PowerPC] Exploit `vrl(b|h|w|d)` to perform vector rotation.
Dec 17 2019, 5:29 PM · Restricted Project

Dec 16 2019

lkail updated the diff for D71324: [PowerPC] Exploit `vrl(b|h|w|d)` to perform vector rotation.

Add indentation in RUN lines.

Dec 16 2019, 10:53 PM · Restricted Project
lkail added inline comments to D71324: [PowerPC] Exploit `vrl(b|h|w|d)` to perform vector rotation.
Dec 16 2019, 10:18 PM · Restricted Project

Dec 12 2019

lkail added a comment to D71391: [PowerPC] Modify the hasSideEffects of some VSX instructions from 1 to 0.
In D71391#1781219, @Jim wrote:

Hi @ZhangKang
You may follow @lkail 's suggestion is fine.
I am not a PowerPC guy. Just give some suggestions.

Dec 12 2019, 1:39 AM · Restricted Project
lkail added a comment to D71391: [PowerPC] Modify the hasSideEffects of some VSX instructions from 1 to 0.

Hi @Jim we currently prefer to set this flag at a fine grained granularity, it's the purpose of sending a series of patches to perform such cleanups.

Dec 12 2019, 1:04 AM · Restricted Project

Dec 11 2019

lkail added a comment to D71390: [PowerPC] Modify the hasSideEffects of MTLR and MFLR from 1 to 0.
Dec 11 2019, 11:12 PM · Restricted Project
lkail accepted D71391: [PowerPC] Modify the hasSideEffects of some VSX instructions from 1 to 0.

LGTM.

Dec 11 2019, 10:43 PM · Restricted Project
lkail requested changes to D70771: [PowerPC] Replace the PPCISD:: SExtVElems with ISD::SIGN_EXTEND_INREG to leverage the combine rules .

Can you provide tests to demonstrate how ISD::SIGN_EXTEND_INREG works on PowerPC?

Dec 11 2019, 1:48 AM · Restricted Project
lkail updated the diff for D71324: [PowerPC] Exploit `vrl(b|h|w|d)` to perform vector rotation.
Dec 11 2019, 1:25 AM · Restricted Project

Dec 10 2019

lkail created D71324: [PowerPC] Exploit `vrl(b|h|w|d)` to perform vector rotation.
Dec 10 2019, 7:49 PM · Restricted Project

Dec 9 2019

lkail added inline comments to D71002: [PowerPC] Exploitate the Vector Integer Average Instructions.
Dec 9 2019, 11:57 PM · Restricted Project
lkail added a comment to rG884351547da2: [PowerPC] Fix MI peephole optimization for splats.

@lkail When committing code for others, please follow the format described in Developer Policy. Thanks.
https://llvm.org/docs/DeveloperPolicy.html#attribution-of-changes

https://llvm.org/docs/DeveloperPolicy.html#commit-messages

Attribution of Changes should be in a separate line, after the end of the body, as simple as “Patch by John Doe.”. This is how we officially handle attribution, and there are automated processes that rely on this format.
Dec 9 2019, 4:07 PM
lkail added a comment to rG884351547da2: [PowerPC] Fix MI peephole optimization for splats.
Dec 9 2019, 4:07 PM

Dec 6 2019

lkail added a comment to D69497: [PowerPC] Fix MI peephole optimization for splats.

@vddvss Landed with https://reviews.llvm.org/rG884351547da27e76e14bef5fe20c3e3cb0e89acd, thanks for fixing it.

Dec 6 2019, 11:10 PM · Restricted Project
lkail committed rG884351547da2: [PowerPC] Fix MI peephole optimization for splats (authored by lkail).
[PowerPC] Fix MI peephole optimization for splats
Dec 6 2019, 11:02 PM
lkail closed D69497: [PowerPC] Fix MI peephole optimization for splats.
Dec 6 2019, 11:02 PM · Restricted Project

Dec 5 2019

lkail added a comment to D69497: [PowerPC] Fix MI peephole optimization for splats.

Hi @vddvss do you need help landing this patch?

Dec 5 2019, 9:19 PM · Restricted Project

Dec 4 2019

lkail committed rGb200c5180e8d: Reland [MachineCopyPropagation] Extend MCP to do trivial copy backward… (authored by lkail).
Reland [MachineCopyPropagation] Extend MCP to do trivial copy backward…
Dec 4 2019, 10:45 PM
lkail added a comment to rG75b3a1c318cc: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
clang-10: /home/buildslave/buildslave/clang-cmake-armv7-selfhost-neon/llvm/llvm/lib/CodeGen/MachineOperand.cpp:118: bool llvm::MachineOperand::isRenamable() const: Assertion `Register::isPhysicalRegister(getReg()) && "isRenamable should only be checked on physical registers"' failed.

It misses check if the register is zero before invoking isRenamable.

Dec 4 2019, 10:14 PM
lkail added a comment to rG75b3a1c318cc: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.

It breaks http://lab.llvm.org:8011/builders/clang-cmake-armv7-selfhost/builds/2747, reverted. I'll investigate it.

Dec 4 2019, 9:03 PM
lkail committed rG3882edbe191f: Revert "[MachineCopyPropagation] Extend MCP to do trivial copy backward… (authored by lkail).
Revert "[MachineCopyPropagation] Extend MCP to do trivial copy backward…
Dec 4 2019, 8:53 PM
lkail added a reverting change for rG75b3a1c318cc: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation: rG3882edbe191f: Revert "[MachineCopyPropagation] Extend MCP to do trivial copy backward….
Dec 4 2019, 8:53 PM
lkail committed rG75b3a1c318cc: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation (authored by lkail).
[MachineCopyPropagation] Extend MCP to do trivial copy backward propagation
Dec 4 2019, 7:10 PM
lkail closed D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Dec 4 2019, 7:10 PM · Restricted Project
lkail added a comment to D70758: [PowerPC][NFC] Rename record instructions to use _rec suffix instead of o.

As a newbie of PowerPC backend, I think what @jsji proposed will ease my mind burden when faced with o ended instructions. I have read ISA-3.0 and know

A period (.) as the last character of an instruction
mnemonic means that the instruction *records* sta-
tus information in certain fields of the Condition
Register as a side effect of execution.

I can directly react to the effect of record-form instruction if it ends with _record. If _record is too long, how about _rec, just like X86's _alt ended instructions?

Dec 4 2019, 1:49 AM · Restricted Project

Dec 3 2019

lkail added a comment to D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Dec 3 2019, 6:36 PM · Restricted Project
lkail added inline comments to D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Dec 3 2019, 6:36 PM · Restricted Project
lkail added inline comments to D65793: [UpdateTestChecks] Update tests option.
Dec 3 2019, 12:52 AM · Restricted Project
lkail added a comment to D65793: [UpdateTestChecks] Update tests option.
Dec 3 2019, 12:52 AM · Restricted Project

Dec 2 2019

lkail added inline comments to D65793: [UpdateTestChecks] Update tests option.
Dec 2 2019, 11:57 PM · Restricted Project
lkail updated the diff for D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.

Rebased and add comment for invalidateRegister.

Dec 2 2019, 6:59 PM · Restricted Project
lkail added inline comments to D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Dec 2 2019, 6:40 PM · Restricted Project
lkail accepted D70374: [PowerPC] combine rlwinm + rlwinm to rlwinm.

LGTM. Thanks for fixing it. Personally, I would recommend Alive to verify peephole optimizations.

Dec 2 2019, 1:37 AM · Restricted Project

Nov 29 2019

lkail updated the diff for D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Nov 29 2019, 1:10 AM · Restricted Project
lkail added a comment to D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.

The RISC-V test changes look good. (I do not intend to review the optimisation implementation or other backend test changes).

Nov 29 2019, 1:10 AM · Restricted Project
lkail updated the diff for D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.

Rebased and fixed broken tests. Ready to be reviewed.

Nov 29 2019, 1:10 AM · Restricted Project

Nov 28 2019

lkail planned changes to D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.

Rebased and get broken tests, I'll investigate it and change this patch.

Nov 28 2019, 6:16 AM · Restricted Project

Nov 24 2019

lkail added a comment to rG29f6f9b2b2bf: [PowerPC] combine rlwinm+rlwinm to rlwinm combine x3 = rlwinm x3, 27, 5, 31 x3….

What it broke seems to be tests on Power8.

Nov 24 2019, 6:30 PM

Nov 20 2019

lkail added inline comments to D67258: Out-of-tree machine IR passes.
Nov 20 2019, 11:45 PM · Restricted Project

Nov 19 2019

lkail accepted D69601: [Power9] Implement the vector extend sign instruction pattern match.

LGTM considering patterns added for SIGN_EXTENDED_INREG also follow its atomic semantics.

Nov 19 2019, 7:18 PM · Restricted Project
lkail added a comment to D70223: [DAGCombine] Split vector load-update-store into single element stores.

I plan to move the two changed swap-le tests into another NFC patch, since they're not related to the logic.

I think all test cases change should be reflected so that reviewers can have a look if they are regressions.

Nov 19 2019, 1:32 AM · Restricted Project

Nov 18 2019

lkail updated the diff for D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.

Add test case involving RegMask.

Nov 18 2019, 10:48 PM · Restricted Project
lkail added a comment to D70373: [NFC] [PowerPC] Add volatile flag to a swap optimization test.

My concern is store and store volatile are so different in semantics that it might break original test intention.

Nov 18 2019, 7:20 PM · Restricted Project
lkail committed rG6ae7315746f1: Revert "[Bindings][Go] Fix go.test failure due to missing argument" (authored by lkail).
Revert "[Bindings][Go] Fix go.test failure due to missing argument"
Nov 18 2019, 6:07 PM
lkail added a reverting change for rG88235812a71d: [Bindings][Go] Fix go.test failure due to missing argument go.test failed with…: rG6ae7315746f1: Revert "[Bindings][Go] Fix go.test failure due to missing argument".
Nov 18 2019, 6:07 PM
lkail added a comment to rG88235812a71d: [Bindings][Go] Fix go.test failure due to missing argument go.test failed with….

Since d27a16eb392f39f9ee04ff5194b1eff3e189e6f8 reverts previous changes, LLVMDIBuilderCreateTypedef's signature becomes what it was. I'll revert this commit.

Nov 18 2019, 5:31 PM
lkail committed rG88235812a71d: [Bindings][Go] Fix go.test failure due to missing argument go.test failed with… (authored by lkail).
[Bindings][Go] Fix go.test failure due to missing argument go.test failed with…
Nov 18 2019, 5:13 PM
lkail closed D70360: [Bindings][Go] Fix go.test failure due to missing argument.
Nov 18 2019, 5:13 PM · Restricted Project

Nov 17 2019

lkail added a reviewer for D70360: [Bindings][Go] Fix go.test failure due to missing argument: bkramer.
Nov 17 2019, 10:51 PM · Restricted Project
lkail added a reviewer for D70360: [Bindings][Go] Fix go.test failure due to missing argument: CodaFi.
Nov 17 2019, 10:43 PM · Restricted Project

Nov 16 2019

lkail updated the summary of D70360: [Bindings][Go] Fix go.test failure due to missing argument.
Nov 16 2019, 6:14 PM · Restricted Project
lkail created D70360: [Bindings][Go] Fix go.test failure due to missing argument.
Nov 16 2019, 6:06 PM · Restricted Project

Nov 15 2019

lkail updated the diff for D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Nov 15 2019, 4:48 AM · Restricted Project
lkail updated the diff for D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Nov 15 2019, 4:19 AM · Restricted Project
lkail updated the diff for D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Nov 15 2019, 3:59 AM · Restricted Project
lkail updated the diff for D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Nov 15 2019, 3:41 AM · Restricted Project
lkail updated the diff for D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.

Introduce CopyTracker::invalidateRegister, original markRegUnavailable and clobberRegister are not appropriate for backward copy propagation.

Nov 15 2019, 3:29 AM · Restricted Project
lkail updated the diff for D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.

Address @qcolombet's comment. @qcolombet I have no idea which is preferable to pass EnableBackwardCP option, target hook or cl::opt?

Nov 15 2019, 12:55 AM · Restricted Project

Nov 10 2019

lkail added a reviewer for D70000: [DAGCombine] Initialize the default operation action for SIGN_EXTEND_INREG for vector type as 'expand' instead of 'legal': kparzysz.
Nov 10 2019, 6:27 PM · Restricted Project
lkail accepted D69497: [PowerPC] Fix MI peephole optimization for splats.

LGTM.

Nov 10 2019, 5:33 PM · Restricted Project

Oct 31 2019

lkail planned changes to D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Oct 31 2019, 8:26 PM · Restricted Project

Oct 30 2019

lkail added a comment to D69497: [PowerPC] Fix MI peephole optimization for splats.

LGTM. I'll wait for @nemanjai if he has additional comments.

Oct 30 2019, 7:07 PM · Restricted Project
lkail added inline comments to D69497: [PowerPC] Fix MI peephole optimization for splats.
Oct 30 2019, 2:31 AM · Restricted Project
lkail added inline comments to D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Oct 30 2019, 12:58 AM · Restricted Project

Oct 29 2019

lkail added a comment to D32140: Global code motion of congruent computations.

Hi @hiraditya , thanks for your work. I want to test your patch on PowerPC, however current patch seems unable to be applied to current master branch.

Oct 29 2019, 2:32 AM · Restricted Project

Oct 28 2019

lkail added a comment to D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.

ping

Oct 28 2019, 1:20 AM · Restricted Project
lkail added a reviewer for D69483: [PowerPC]: Fix predicate handling with SPE: Restricted Project.
Oct 28 2019, 12:21 AM · Restricted Project

Oct 27 2019

lkail added inline comments to D69497: [PowerPC] Fix MI peephole optimization for splats.
Oct 27 2019, 9:38 PM · Restricted Project
lkail added a reviewer for D69497: [PowerPC] Fix MI peephole optimization for splats: Restricted Project.
Oct 27 2019, 7:42 PM · Restricted Project

Oct 24 2019

lkail committed rG81c2a5bb39c2: Test commit via git. (authored by lkail).
Test commit via git.
Oct 24 2019, 6:44 PM

Oct 21 2019

lkail added a comment to D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.

ping

Oct 21 2019, 8:50 PM · Restricted Project
lkail added a reviewer for D69168: [PowerPC] Fold redundant load immediates of zero and delete if possible: Restricted Project.
Oct 21 2019, 8:22 PM · Restricted Project

Oct 8 2019

lkail added a comment to D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.

ping

Oct 8 2019, 8:50 PM · Restricted Project

Sep 29 2019

lkail added a comment to D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.

Gentle ping

Sep 29 2019, 2:06 AM · Restricted Project

Sep 26 2019

lkail added a reviewer for D68035: [PowerPC] Extend custom lower of vector truncate to handle wider input: hfinkel.
Sep 26 2019, 5:57 AM · Restricted Project
lkail added a comment to rL366570: [MachineCSE][MachinePRE] Avoid hoisting code from code regions into hot BBs..

Hi @jgorbe , indeed we still get some enhance opportunity for this patch, such as considering register pressure. I'm wondering if the regression was caused by spilling.

Sep 26 2019, 2:12 AM

Sep 24 2019

lkail added a reviewer for D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation: qcolombet.
Sep 24 2019, 8:03 PM · Restricted Project

Sep 22 2019

lkail added a comment to D66991: [PowerPC] Fix SH field overflow issue.

I think the test can be simplified more, kinda like

# RUN: llc -O3 -mtriple=powerpc64le-unknown-linux-gnu -stop-after=ppc-pre-emit-peephole -verify-machineinstrs %s -o - | FileCheck %s
---                                                                                                                                                                           
name: foo                                                                                                                                                                   
alignment: 4                                                                                                                                                                  
tracksRegLiveness: true                                                                                                                                                       
body: |                                                                                                                                                                       
  bb.0.entry:                                                                                                                                                                 
    liveins: $r3                                                                                                                                                              
    renamable $r4 = LI 0                                                                                                                                                      
    renamable $r5 = SRW renamable $r3, renamable killed $r4                                                                                                                   
    $r3 = COPY renamable killed $r5                                                                                                                                           
    BLR implicit $lr, implicit $rm, implicit $r3                                                                                                                              
...

And a NFC patch to pre-commit the test would also be preferable.

Sep 22 2019, 8:19 PM · Restricted Project

Sep 19 2019

lkail added a reviewer for D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation: craig.topper.
Sep 19 2019, 10:39 PM · Restricted Project
lkail added reviewers for D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation: nemanjai, jsji.
Sep 19 2019, 10:39 PM · Restricted Project
lkail edited reviewers for D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation, added: efriedma; removed: eli.friedman.
Sep 19 2019, 10:30 PM · Restricted Project
lkail updated the summary of D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Sep 19 2019, 10:24 PM · Restricted Project
lkail updated the summary of D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Sep 19 2019, 10:23 PM · Restricted Project