Page MenuHomePhabricator

lkail (Kai Luo)
User

Projects

User does not belong to any projects.

User Details

User Since
May 15 2019, 8:43 PM (201 w, 3 d)

Recent Activity

Wed, Mar 8

lkail added a reviewer for D145632: [test] Remove occurences of br undef in CodeGen/PowerPC tests: nemanjai.
Wed, Mar 8, 4:48 PM · Restricted Project, Restricted Project

Mon, Mar 6

lkail committed rGc0d9e5a0a4b8: Reland [AIX][BigArchive] Treat the archive is empty if the first child member… (authored by lkail).
Reland [AIX][BigArchive] Treat the archive is empty if the first child member…
Mon, Mar 6, 12:34 AM · Restricted Project, Restricted Project
lkail closed D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Mon, Mar 6, 12:33 AM · Restricted Project, Restricted Project

Tue, Feb 28

lkail added a comment to D143977: [RFC][GlobalISel] Allow match against iPTR operand in leaf node.

Ping.

Tue, Feb 28, 11:28 PM · Restricted Project, Restricted Project

Feb 22 2023

lkail added a comment to D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.

Gentle ping.

Feb 22 2023, 6:58 PM · Restricted Project, Restricted Project

Feb 19 2023

lkail committed rGfd766ba2b1f1: [GISelEmitter][NFC] Correct path of GISel's td file in the comment. (authored by lkail).
[GISelEmitter][NFC] Correct path of GISel's td file in the comment.
Feb 19 2023, 6:08 PM · Restricted Project, Restricted Project

Feb 16 2023

lkail accepted D144235: [PowerPC][NFC] add const-splat-array-init.ll.

LG.

Feb 16 2023, 10:57 PM · Restricted Project, Restricted Project

Feb 15 2023

lkail abandoned D127563: [PowerPC] Fix llvm.ppc.cfence on float point types.

Already covered by https://reviews.llvm.org/D127609.

Feb 15 2023, 10:04 PM · Restricted Project, Restricted Project

Feb 14 2023

lkail added reviewers for D143813: [ClangFE] Check that __sync builtins are naturally aligned.: efriedma, jyknight.
Feb 14 2023, 2:24 AM · Restricted Project, Restricted Project

Feb 13 2023

lkail updated the diff for D143979: [GISel][PowerPC][WIP] Support G_ATOMICRMW_*.
Feb 13 2023, 10:24 PM · Restricted Project, Restricted Project
lkail updated the diff for D143979: [GISel][PowerPC][WIP] Support G_ATOMICRMW_*.
Feb 13 2023, 10:07 PM · Restricted Project, Restricted Project
lkail updated the diff for D143979: [GISel][PowerPC][WIP] Support G_ATOMICRMW_*.
Feb 13 2023, 9:53 PM · Restricted Project, Restricted Project
lkail updated the diff for D143979: [GISel][PowerPC][WIP] Support G_ATOMICRMW_*.
Feb 13 2023, 9:41 PM · Restricted Project, Restricted Project
lkail requested review of D143979: [GISel][PowerPC][WIP] Support G_ATOMICRMW_*.
Feb 13 2023, 9:26 PM · Restricted Project, Restricted Project
lkail retitled D143977: [RFC][GlobalISel] Allow match against iPTR operand in leaf node from [GISel]RFC] Allow match against iPTR operand in leaf node to [RFC][GlobalISel] Allow match against iPTR operand in leaf node.
Feb 13 2023, 9:04 PM · Restricted Project, Restricted Project
lkail added a reviewer for D143977: [RFC][GlobalISel] Allow match against iPTR operand in leaf node: aemerson.
Feb 13 2023, 9:03 PM · Restricted Project, Restricted Project
lkail retitled D143977: [RFC][GlobalISel] Allow match against iPTR operand in leaf node from [GISel]]RFC] Allow match against iPTR operand in leaf node to [GISel]RFC] Allow match against iPTR operand in leaf node.
Feb 13 2023, 8:58 PM · Restricted Project, Restricted Project
lkail requested review of D143977: [RFC][GlobalISel] Allow match against iPTR operand in leaf node.
Feb 13 2023, 8:52 PM · Restricted Project, Restricted Project

Feb 9 2023

lkail committed rG2db83b1b311b: [CMake] Fix -DBUILD_SHARED_LIBS=on builds after D137534 (authored by lkail).
[CMake] Fix -DBUILD_SHARED_LIBS=on builds after D137534
Feb 9 2023, 8:58 PM · Restricted Project, Restricted Project
lkail committed rG311ff227b432: [DwarfGenerator] Emit dwarf address section when dwarf version is not less than… (authored by lkail).
[DwarfGenerator] Emit dwarf address section when dwarf version is not less than…
Feb 9 2023, 7:18 PM · Restricted Project, Restricted Project
lkail closed D143561: [DwarfGenerator] Emit dwarf address section when dwarf version is not less than 4.
Feb 9 2023, 7:18 PM · Restricted Project, Restricted Project
lkail added a comment to D143561: [DwarfGenerator] Emit dwarf address section when dwarf version is not less than 4.

Is this an AIX only restriction or for all DWARF <= 4?

Feb 9 2023, 7:06 PM · Restricted Project, Restricted Project
lkail added a reviewer for D143561: [DwarfGenerator] Emit dwarf address section when dwarf version is not less than 4: Restricted Project.
Feb 9 2023, 7:05 AM · Restricted Project, Restricted Project

Feb 8 2023

lkail retitled D143561: [DwarfGenerator] Emit dwarf address section when dwarf version is not less than 4 from [DebugInfo] Emit dwarf address section when dwarf version is not less than 4 to [DwarfGenerator] Emit dwarf address section when dwarf version is not less than 4.
Feb 8 2023, 7:05 PM · Restricted Project, Restricted Project
lkail updated the diff for D143561: [DwarfGenerator] Emit dwarf address section when dwarf version is not less than 4.

Check dwarf version number per @benmxwl-arm 's suggestion.

Feb 8 2023, 6:43 PM · Restricted Project, Restricted Project
lkail updated the summary of D143561: [DwarfGenerator] Emit dwarf address section when dwarf version is not less than 4.
Feb 8 2023, 2:04 AM · Restricted Project, Restricted Project
lkail updated the summary of D143561: [DwarfGenerator] Emit dwarf address section when dwarf version is not less than 4.
Feb 8 2023, 2:00 AM · Restricted Project, Restricted Project
lkail requested review of D143561: [DwarfGenerator] Emit dwarf address section when dwarf version is not less than 4.
Feb 8 2023, 1:58 AM · Restricted Project, Restricted Project

Feb 7 2023

lkail added a comment to D135462: [SelectionDAG] Do not second-guess alignment for alloca.

Is there any progress with this patch? This patch can fix our downstream test failure which is caused by insistent alignment between IR and backend, thus affects alias analysis.

Feb 7 2023, 11:01 PM · Restricted Project, Restricted Project
lkail committed rG96aaebd12e73: [MachineCopyPropagation] Eliminate spillage copies that might be caused by… (authored by lkail).
[MachineCopyPropagation] Eliminate spillage copies that might be caused by…
Feb 7 2023, 7:34 PM · Restricted Project, Restricted Project
lkail closed D122118: [MachineCopyPropagation] Eliminate spillage copies that might be caused by eviction chain.
Feb 7 2023, 7:34 PM · Restricted Project, Restricted Project

Jan 31 2023

lkail added inline comments to D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Jan 31 2023, 6:33 AM · Restricted Project, Restricted Project
lkail updated the diff for D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.

Complete error messages.

Jan 31 2023, 6:32 AM · Restricted Project, Restricted Project
lkail abandoned D142883: [BigArchive][NFC] Enhance test cases introduced in D138986.

Changes are included in https://reviews.llvm.org/D138986.

Jan 31 2023, 6:15 AM · Restricted Project, Restricted Project
lkail requested review of D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Jan 31 2023, 5:48 AM · Restricted Project, Restricted Project
lkail updated the diff for D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.

Add more checks on buffer boundary.

Jan 31 2023, 5:48 AM · Restricted Project, Restricted Project
lkail added a reviewer for D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero: hctim.
Jan 31 2023, 2:59 AM · Restricted Project, Restricted Project
lkail added a comment to D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.

You can reproduce using the upstream buildbots (https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild), but a quick-asan-build that's hacked together might be easier for iterative testing:

Jan 31 2023, 2:59 AM · Restricted Project, Restricted Project
lkail planned changes to D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Jan 31 2023, 2:57 AM · Restricted Project, Restricted Project
lkail reopened D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.

Will add more check on buffer boundary when reading archive content.

Jan 31 2023, 2:57 AM · Restricted Project, Restricted Project

Jan 30 2023

lkail updated the diff for D142883: [BigArchive][NFC] Enhance test cases introduced in D138986.
Jan 30 2023, 3:59 AM · Restricted Project, Restricted Project
lkail added inline comments to D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Jan 30 2023, 3:57 AM · Restricted Project, Restricted Project
lkail requested review of D142883: [BigArchive][NFC] Enhance test cases introduced in D138986.
Jan 30 2023, 3:56 AM · Restricted Project, Restricted Project

Jan 29 2023

lkail committed rG7f0003c19c3a: [AIX][BigArchive] Treat the archive is empty if the first child member offset… (authored by lkail).
[AIX][BigArchive] Treat the archive is empty if the first child member offset…
Jan 29 2023, 10:07 PM · Restricted Project, Restricted Project
lkail closed D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Jan 29 2023, 10:07 PM · Restricted Project, Restricted Project

Jan 11 2023

lkail committed rGd9630c34f44d: [PowerPC][GISel] Select sync instructions required by atomic operations (authored by lkail).
[PowerPC][GISel] Select sync instructions required by atomic operations
Jan 11 2023, 12:26 AM · Restricted Project, Restricted Project
lkail closed D141360: [PowerPC][GISel] Select sync instructions required by atomic operations.
Jan 11 2023, 12:25 AM · Restricted Project, Restricted Project

Jan 10 2023

lkail updated the diff for D141360: [PowerPC][GISel] Select sync instructions required by atomic operations.
Jan 10 2023, 7:20 AM · Restricted Project, Restricted Project
lkail updated the diff for D141360: [PowerPC][GISel] Select sync instructions required by atomic operations.

@arsenm Much appreciated for the suggestion.

Jan 10 2023, 6:50 AM · Restricted Project, Restricted Project
lkail added a reviewer for D141360: [PowerPC][GISel] Select sync instructions required by atomic operations: arsenm.
Jan 10 2023, 12:35 AM · Restricted Project, Restricted Project
lkail requested review of D141360: [PowerPC][GISel] Select sync instructions required by atomic operations.
Jan 10 2023, 12:35 AM · Restricted Project, Restricted Project

Jan 8 2023

lkail abandoned D136126: [PowerPC][WIP] Recompute liveins after eliminating prime/unprime operations.

Will seek another method that's not hacky.

Jan 8 2023, 10:25 PM · Restricted Project, Restricted Project

Jan 4 2023

lkail added a comment to D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.

Ping.

Jan 4 2023, 9:34 PM · Restricted Project, Restricted Project

Jan 2 2023

lkail added a comment to D122118: [MachineCopyPropagation] Eliminate spillage copies that might be caused by eviction chain.
Jan 2 2023, 6:23 PM · Restricted Project, Restricted Project
lkail updated the diff for D122118: [MachineCopyPropagation] Eliminate spillage copies that might be caused by eviction chain.

Use range loop.

Jan 2 2023, 6:22 PM · Restricted Project, Restricted Project

Dec 28 2022

lkail updated the diff for D122118: [MachineCopyPropagation] Eliminate spillage copies that might be caused by eviction chain.
Dec 28 2022, 10:00 PM · Restricted Project, Restricted Project
lkail updated the diff for D122118: [MachineCopyPropagation] Eliminate spillage copies that might be caused by eviction chain.
Dec 28 2022, 2:41 AM · Restricted Project, Restricted Project
lkail added a comment to D122118: [MachineCopyPropagation] Eliminate spillage copies that might be caused by eviction chain.

Do you know on average how many chains we see per function?

Dec 28 2022, 2:15 AM · Restricted Project, Restricted Project
lkail updated the diff for D122118: [MachineCopyPropagation] Eliminate spillage copies that might be caused by eviction chain.

Add target hook and command line option.

Dec 28 2022, 12:23 AM · Restricted Project, Restricted Project
lkail updated the diff for D122118: [MachineCopyPropagation] Eliminate spillage copies that might be caused by eviction chain.
Dec 28 2022, 12:18 AM · Restricted Project, Restricted Project

Dec 21 2022

lkail added a reviewer for D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero: jhenderson.
Dec 21 2022, 7:04 PM · Restricted Project, Restricted Project
lkail requested review of D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Dec 21 2022, 7:03 PM · Restricted Project, Restricted Project
lkail updated the diff for D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.

Check if the offset of the first member is still in the buffer. Fixed asan errors.

Dec 21 2022, 7:03 PM · Restricted Project, Restricted Project

Dec 19 2022

lkail reopened D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.

Thanks for reverting it in time. I'll have a look at the failure and fix it.

Dec 19 2022, 2:41 PM · Restricted Project, Restricted Project

Dec 18 2022

lkail committed rGb26fe2a3e520: [AIX][BigArchive] Treat the archive is empty if the first child member offset… (authored by lkail).
[AIX][BigArchive] Treat the archive is empty if the first child member offset…
Dec 18 2022, 9:19 PM · Restricted Project, Restricted Project
lkail closed D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Dec 18 2022, 9:18 PM · Restricted Project, Restricted Project

Dec 15 2022

lkail committed rGbef10bf4e343: [AIX][BigArchive][NFC] Add test case that list members of archive with free… (authored by lkail).
[AIX][BigArchive][NFC] Add test case that list members of archive with free…
Dec 15 2022, 7:24 PM · Restricted Project, Restricted Project
lkail closed D138985: [AIX][BigArchive][NFC] Add test case that list members of archive with free list in it.
Dec 15 2022, 7:24 PM · Restricted Project, Restricted Project

Dec 14 2022

lkail updated the diff for D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Dec 14 2022, 3:33 AM · Restricted Project, Restricted Project
lkail updated the diff for D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.

Address comments.

Dec 14 2022, 3:26 AM · Restricted Project, Restricted Project

Dec 13 2022

lkail added a reviewer for D139993: [LoopFusion] Sorting of undominated FusionCandidates crashes: kbarton.
Dec 13 2022, 9:13 PM · Restricted Project, Restricted Project
lkail updated the diff for D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Dec 13 2022, 12:00 AM · Restricted Project, Restricted Project

Dec 12 2022

lkail added inline comments to D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Dec 12 2022, 11:57 PM · Restricted Project, Restricted Project
lkail updated the diff for D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Dec 12 2022, 11:57 PM · Restricted Project, Restricted Project
lkail updated the diff for D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Dec 12 2022, 11:34 PM · Restricted Project, Restricted Project
lkail updated the diff for D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Dec 12 2022, 11:32 PM · Restricted Project, Restricted Project

Dec 11 2022

lkail updated the diff for D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Dec 11 2022, 6:24 PM · Restricted Project, Restricted Project
lkail updated the diff for D138985: [AIX][BigArchive][NFC] Add test case that list members of archive with free list in it.
Dec 11 2022, 6:20 PM · Restricted Project, Restricted Project
lkail added inline comments to D138985: [AIX][BigArchive][NFC] Add test case that list members of archive with free list in it.
Dec 11 2022, 5:42 PM · Restricted Project, Restricted Project

Dec 9 2022

lkail updated the diff for D138985: [AIX][BigArchive][NFC] Add test case that list members of archive with free list in it.
Dec 9 2022, 1:54 AM · Restricted Project, Restricted Project
lkail updated the diff for D138985: [AIX][BigArchive][NFC] Add test case that list members of archive with free list in it.
Dec 9 2022, 1:11 AM · Restricted Project, Restricted Project
lkail updated the diff for D138985: [AIX][BigArchive][NFC] Add test case that list members of archive with free list in it.
Dec 9 2022, 1:08 AM · Restricted Project, Restricted Project
lkail added inline comments to D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Dec 9 2022, 12:52 AM · Restricted Project, Restricted Project
lkail updated the diff for D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Dec 9 2022, 12:52 AM · Restricted Project, Restricted Project
lkail updated the diff for D138985: [AIX][BigArchive][NFC] Add test case that list members of archive with free list in it.
Dec 9 2022, 12:49 AM · Restricted Project, Restricted Project

Dec 8 2022

lkail added a reviewer for D138331: ConstantFolding: Fix handling of canonicalize for ppc_fp128 0s: qiucf.
Dec 8 2022, 5:30 AM · Restricted Project, Restricted Project

Dec 6 2022

lkail added a reviewer for D138982: [XCOFF] adjust the Fixedvalue for R_RBR relocations.: stephenpeckham.
Dec 6 2022, 9:14 PM · Restricted Project, Restricted Project

Nov 30 2022

lkail accepted D138265: [PowerPC] move ctrloop pass before tail duplication.

LGTM. Though there might be some pseudo instruction expansion changed the CFG, they are not breaking assumptions PPCCTRLoop made.

Nov 30 2022, 6:29 PM · Restricted Project, Restricted Project
lkail added a comment to D138883: [PowerPC] find and reuse ConstantSplatVector to combine constant store into extract and store.

I would expect not only memset, some consecutive stores could also reuse the result of vector split, see https://godbolt.org/z/77aMvncb4.
For

void foo(long a[3]) {
    a[0] = 12;
    a[1] = 12;
    a[2] = 12;
}
Nov 30 2022, 6:18 PM · Restricted Project, Restricted Project
lkail retitled D138985: [AIX][BigArchive][NFC] Add test case that list members of archive with free list in it from [BigArchive][NFC] Add test case that list members of archive with free list in it to [AIX][BigArchive][NFC] Add test case that list members of archive with free list in it.
Nov 30 2022, 12:27 AM · Restricted Project, Restricted Project
lkail retitled D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero from [BigArchive] Treat the archive is empty if the first child member offset is zero to [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Nov 30 2022, 12:27 AM · Restricted Project, Restricted Project
lkail requested review of D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Nov 30 2022, 12:23 AM · Restricted Project, Restricted Project
lkail requested review of D138985: [AIX][BigArchive][NFC] Add test case that list members of archive with free list in it.
Nov 30 2022, 12:19 AM · Restricted Project, Restricted Project

Nov 29 2022

lkail added inline comments to D138973: [PowerPC] [NFC] add test for O0 pipeline.
Nov 29 2022, 7:15 PM · Restricted Project, Restricted Project
lkail accepted D138973: [PowerPC] [NFC] add test for O0 pipeline.

LGTM.

Nov 29 2022, 6:38 PM · Restricted Project, Restricted Project

Nov 28 2022

lkail requested review of D138897: [AIX] Append hex string of constant value to the end of constant symbol name.
Nov 28 2022, 10:51 PM · Restricted Project, Restricted Project
lkail added a reviewer for D138883: [PowerPC] find and reuse ConstantSplatVector to combine constant store into extract and store: RKSimon.
Nov 28 2022, 5:44 PM · Restricted Project, Restricted Project

Nov 24 2022

lkail added inline comments to D138265: [PowerPC] move ctrloop pass before tail duplication.
Nov 24 2022, 11:30 PM · Restricted Project, Restricted Project

Nov 23 2022

lkail added inline comments to D138551: [PowerPC] Mask constant operands in bit permutation calculation.
Nov 23 2022, 11:43 PM · Restricted Project, Restricted Project
lkail added inline comments to D138265: [PowerPC] move ctrloop pass before tail duplication.
Nov 23 2022, 11:16 PM · Restricted Project, Restricted Project