Page MenuHomePhabricator

lkail (Kai Luo)
User

Projects

User does not belong to any projects.

User Details

User Since
May 15 2019, 8:43 PM (71 w, 3 d)

Recent Activity

Yesterday

lkail updated the diff for D88078: [PowerPC] Probe the gap between stackptr and realigned stackptr.

Fix format and add more tests.

Sat, Sep 26, 7:02 PM · Restricted Project

Tue, Sep 22

lkail requested review of D88078: [PowerPC] Probe the gap between stackptr and realigned stackptr.
Tue, Sep 22, 2:35 AM · Restricted Project

Mon, Sep 21

lkail added inline comments to D84419: Fix interaction between stack alignment and inline-asm stack clash protection.
Mon, Sep 21, 9:34 PM · Restricted Project

Sun, Sep 20

lkail accepted D84419: Fix interaction between stack alignment and inline-asm stack clash protection.

LGTM. This solution probes the gap between [stackptr & mask, stackptr] when align is big.

Sun, Sep 20, 7:01 PM · Restricted Project

Wed, Sep 9

lkail commandeered D85288: [PowerPC] Remove implicit use register after transformToImmFormFedByLI().
Wed, Sep 9, 11:34 PM · Restricted Project
lkail commandeered D66576: [Regalloc][WIP] Increase CSR cost in RegAllocGreedy to favour splitting/spill over CSR first use.
Wed, Sep 9, 11:32 PM · Restricted Project

Fri, Aug 28

lkail committed rGb904324788a8: [DAGCombiner] Enhance (zext(setcc)) (authored by lkail).
[DAGCombiner] Enhance (zext(setcc))
Fri, Aug 28, 8:38 PM
lkail closed D86687: [DAGCombiner] Enhance (zext(setcc)).
Fri, Aug 28, 8:38 PM · Restricted Project
lkail edited reviewers for D86808: [MachineDCE] Delete missed dead instructions after deleting PHI, added: efriedma; removed: eli.friedman.
Fri, Aug 28, 4:45 PM · Restricted Project

Aug 28 2020

lkail updated the diff for D86687: [DAGCombiner] Enhance (zext(setcc)).

Updated comments again.

Aug 28 2020, 9:46 AM · Restricted Project
lkail added inline comments to D86687: [DAGCombiner] Enhance (zext(setcc)).
Aug 28 2020, 9:38 AM · Restricted Project
lkail updated the diff for D86687: [DAGCombiner] Enhance (zext(setcc)).

Adjust comments, leave function name unchanged.

Aug 28 2020, 9:34 AM · Restricted Project
lkail updated the summary of D86687: [DAGCombiner] Enhance (zext(setcc)).
Aug 28 2020, 8:50 AM · Restricted Project
lkail added inline comments to D86687: [DAGCombiner] Enhance (zext(setcc)).
Aug 28 2020, 8:45 AM · Restricted Project
lkail updated the diff for D86687: [DAGCombiner] Enhance (zext(setcc)).

Per @spatel 's comments.

Aug 28 2020, 8:43 AM · Restricted Project

Aug 27 2020

lkail committed rGcbea17568f43: [PowerPC] PPCBoolRetToInt: Don't translate Constant's operands (authored by lkail).
[PowerPC] PPCBoolRetToInt: Don't translate Constant's operands
Aug 27 2020, 6:58 PM
lkail closed D85007: [PowerPC] PPCBoolRetToInt: Don't translate Constant's operands.
Aug 27 2020, 6:58 PM · Restricted Project
lkail added reviewers for D86687: [DAGCombiner] Enhance (zext(setcc)): xbolva00, lebedev.ri.
Aug 27 2020, 1:26 AM · Restricted Project
lkail updated the summary of D86687: [DAGCombiner] Enhance (zext(setcc)).
Aug 27 2020, 1:20 AM · Restricted Project
lkail edited reviewers for D86687: [DAGCombiner] Enhance (zext(setcc)), added: steven.zhang; removed: qshanz.
Aug 27 2020, 1:19 AM · Restricted Project
lkail requested review of D86687: [DAGCombiner] Enhance (zext(setcc)).
Aug 27 2020, 1:19 AM · Restricted Project

Aug 26 2020

lkail added a comment to D85007: [PowerPC] PPCBoolRetToInt: Don't translate Constant's operands.

Updated Summary.

Aug 26 2020, 7:03 PM · Restricted Project
lkail updated the summary of D85007: [PowerPC] PPCBoolRetToInt: Don't translate Constant's operands.
Aug 26 2020, 7:00 PM · Restricted Project

Aug 25 2020

lkail updated the diff for D85007: [PowerPC] PPCBoolRetToInt: Don't translate Constant's operands.

@Carrot Thanks for your awesome solution.

Aug 25 2020, 12:02 AM · Restricted Project

Aug 24 2020

lkail added reviewers for D85007: [PowerPC] PPCBoolRetToInt: Don't translate Constant's operands: ZhangKang, steven.zhang.
Aug 24 2020, 8:57 PM · Restricted Project
lkail added a comment to D85007: [PowerPC] PPCBoolRetToInt: Don't translate Constant's operands.

Ping

Aug 24 2020, 8:54 PM · Restricted Project

Aug 16 2020

lkail added inline comments to D85659: [PowerPC] in fixupIsDeadOrKill before RA, get def instructions by calling getVRegDef .
Aug 16 2020, 7:53 PM · Restricted Project
lkail accepted D85659: [PowerPC] in fixupIsDeadOrKill before RA, get def instructions by calling getVRegDef .

LGTM with nits.

Aug 16 2020, 7:49 PM · Restricted Project
lkail accepted D84659: [PowerPC] Handle SUBFIC in reg+reg -> reg+imm transformation.

LGTM.

Aug 16 2020, 7:18 PM · Restricted Project

Aug 7 2020

lkail added a comment to D85007: [PowerPC] PPCBoolRetToInt: Don't translate Constant's operands.

Thanks Tom for testing it. Gentle ping reviewers.

Aug 7 2020, 7:43 PM · Restricted Project

Aug 6 2020

lkail updated subscribers of D85007: [PowerPC] PPCBoolRetToInt: Don't translate Constant's operands.
Aug 6 2020, 4:39 AM · Restricted Project

Aug 5 2020

lkail added a reviewer for D85391: [PPC] Rename bool-ret-to-int -> ppc-bool-ret-to-int: hfinkel.
Aug 5 2020, 11:39 PM · Restricted Project
lkail added reviewers for D85391: [PPC] Rename bool-ret-to-int -> ppc-bool-ret-to-int: Restricted Project, jsji, nemanjai.
Aug 5 2020, 8:07 PM · Restricted Project

Jul 31 2020

lkail updated the summary of D85007: [PowerPC] PPCBoolRetToInt: Don't translate Constant's operands.
Jul 31 2020, 12:57 AM · Restricted Project
lkail updated the summary of D85007: [PowerPC] PPCBoolRetToInt: Don't translate Constant's operands.
Jul 31 2020, 12:57 AM · Restricted Project
lkail requested review of D85007: [PowerPC] PPCBoolRetToInt: Don't translate Constant's operands.
Jul 31 2020, 12:49 AM · Restricted Project

Jul 30 2020

lkail accepted D78670: PowerPC: Fix SPE extloadf32 handling..

LGTM. Might need to rebase.

Jul 30 2020, 1:18 AM · Restricted Project

Jul 29 2020

lkail added a comment to D82638: [MachineCopyPropagation] BackwardPropagatableCopy: add check for hasOverlappingMultipleDef.

If the definition is earlyclobber, do we also need to check for overlapping uses?

Jul 29 2020, 8:27 AM · Restricted Project
lkail accepted D82638: [MachineCopyPropagation] BackwardPropagatableCopy: add check for hasOverlappingMultipleDef.

LGTM. Thanks for fixing it.

Jul 29 2020, 8:10 AM · Restricted Project
lkail added inline comments to D82638: [MachineCopyPropagation] BackwardPropagatableCopy: add check for hasOverlappingMultipleDef.
Jul 29 2020, 7:22 AM · Restricted Project

Jul 28 2020

lkail added a reviewer for D82638: [MachineCopyPropagation] BackwardPropagatableCopy: add check for hasOverlappingMultipleDef: lkail.
Jul 28 2020, 8:41 PM · Restricted Project
lkail added inline comments to D82638: [MachineCopyPropagation] BackwardPropagatableCopy: add check for hasOverlappingMultipleDef.
Jul 28 2020, 8:19 PM · Restricted Project
lkail added inline comments to D82638: [MachineCopyPropagation] BackwardPropagatableCopy: add check for hasOverlappingMultipleDef.
Jul 28 2020, 8:13 PM · Restricted Project

Jul 24 2020

lkail added inline comments to D84419: Fix interaction between stack alignment and inline-asm stack clash protection.
Jul 24 2020, 4:16 AM · Restricted Project

Jul 22 2020

lkail added a comment to D84152: [PowerPC] Fix wrong codegen when stack pointer has to realign performing dynalloc.

Was I cc'd because you want this cherry-picked to the 11.x branch?

Jul 22 2020, 6:52 AM · Restricted Project
lkail added a comment to D84218: [PowerPC] Fix wrong codegen when stack pointer has to realign in prologue.

Was I cc'd because you want this cherry-picked to the 11.x branch?

Jul 22 2020, 6:50 AM · Restricted Project

Jul 21 2020

lkail committed rGc3f9697f1f22: [PowerPC] Fix wrong codegen when stack pointer has to realign performing… (authored by lkail).
[PowerPC] Fix wrong codegen when stack pointer has to realign performing…
Jul 21 2020, 11:35 PM
lkail committed rG8912252252c8: [PowerPC] Fix wrong codegen when stack pointer has to realign in prologue (authored by lkail).
[PowerPC] Fix wrong codegen when stack pointer has to realign in prologue
Jul 21 2020, 11:35 PM
lkail closed D84152: [PowerPC] Fix wrong codegen when stack pointer has to realign performing dynalloc.
Jul 21 2020, 11:35 PM · Restricted Project
lkail closed D84218: [PowerPC] Fix wrong codegen when stack pointer has to realign in prologue.
Jul 21 2020, 11:35 PM · Restricted Project
lkail added inline comments to D84238: [PowerPC] Set v1i128 to expand for SETCC to avoid crash.
Jul 21 2020, 10:01 PM · Restricted Project
lkail updated the diff for D84152: [PowerPC] Fix wrong codegen when stack pointer has to realign performing dynalloc.

Simplified code according to @jsji 's comments.

Jul 21 2020, 8:40 PM · Restricted Project
lkail updated the diff for D84152: [PowerPC] Fix wrong codegen when stack pointer has to realign performing dynalloc.
Jul 21 2020, 8:31 PM · Restricted Project
lkail added inline comments to D84238: [PowerPC] Set v1i128 to expand for SETCC to avoid crash.
Jul 21 2020, 7:58 AM · Restricted Project

Jul 20 2020

Herald added a project to D84218: [PowerPC] Fix wrong codegen when stack pointer has to realign in prologue: Restricted Project.
Jul 20 2020, 9:16 PM · Restricted Project
lkail updated the diff for D84152: [PowerPC] Fix wrong codegen when stack pointer has to realign performing dynalloc.

Removed fix of wrong codegen in prologue, will post another patch to fix.

Jul 20 2020, 9:16 PM · Restricted Project
lkail updated the summary of D84152: [PowerPC] Fix wrong codegen when stack pointer has to realign performing dynalloc.
Jul 20 2020, 7:12 AM · Restricted Project
lkail updated the summary of D84152: [PowerPC] Fix wrong codegen when stack pointer has to realign performing dynalloc.
Jul 20 2020, 5:28 AM · Restricted Project
Herald added a project to D84152: [PowerPC] Fix wrong codegen when stack pointer has to realign performing dynalloc: Restricted Project.
Jul 20 2020, 5:27 AM · Restricted Project

Jul 17 2020

lkail committed rG817767abeec8: [PowerPC] Precommit test case for PR46759. NFC. (authored by lkail).
[PowerPC] Precommit test case for PR46759. NFC.
Jul 17 2020, 1:42 AM

Jul 16 2020

lkail added a reviewer for D83948: [PowerPC] Custom lowering for funnel shifts: Restricted Project.
Jul 16 2020, 7:12 AM · Restricted Project

Jul 13 2020

lkail committed rGd4e7d126b0c1: [PowerPC] Generate CFI directives when probing in prologue (authored by lkail).
[PowerPC] Generate CFI directives when probing in prologue
Jul 13 2020, 7:57 PM
lkail closed D83276: [PowerPC] Generate CFI directives when probing in prologue.
Jul 13 2020, 7:57 PM · Restricted Project

Jul 12 2020

lkail updated the diff for D83276: [PowerPC] Generate CFI directives when probing in prologue.
Jul 12 2020, 10:20 PM · Restricted Project
lkail updated the diff for D83276: [PowerPC] Generate CFI directives when probing in prologue.

Address @jsji 's comments.

Jul 12 2020, 9:59 PM · Restricted Project
lkail committed rGac8dc526c471: [PowerPC] Enhance tests for D83276. NFC. (authored by lkail).
[PowerPC] Enhance tests for D83276. NFC.
Jul 12 2020, 9:37 PM

Jul 9 2020

lkail added a comment to D82638: [MachineCopyPropagation] BackwardPropagatableCopy: add check for hasOverlappingMultipleDef.

I used your previous mcp-dest-regs-no-dup.ll and run

llc -simplify-mir -verify-machineinstrs -mtriple=arm-eabi -stop-before=machine-cp mcp-dest-regs-no-dup.ll -o mcp-dest-regs-no-dup.mir
Jul 9 2020, 4:06 AM · Restricted Project
lkail committed rGe2b93185b84b: [PowerPC] Only make copies of registers on stack in variadic function when… (authored by lkail).
[PowerPC] Only make copies of registers on stack in variadic function when…
Jul 9 2020, 12:40 AM
lkail closed D82361: [PowerPC] Only make copies of registers on stack in variadic function when va_start is called.
Jul 9 2020, 12:40 AM · Restricted Project

Jul 8 2020

lkail added a reviewer for D83437: [PowerPC] Enable default support of quad precision operations: steven.zhang.
Jul 8 2020, 6:13 PM · Restricted Project
lkail added a comment to D82638: [MachineCopyPropagation] BackwardPropagatableCopy: add check for hasOverlappingMultipleDef.

Hi @simonwallis2 , you can create an MIR test by

llc -simplify-mir -verify-machineinstrs -mtriple=arm-eabi -stop-before=machine-cp foo.ll -o foo.mir

and then add RUN line for it

RUN: llc -simplify-mir -verify-machineinstrs -mtriple=arm-eabi -run-pass=machine-cp %s -o - | FileCheck %s
Jul 8 2020, 7:42 AM · Restricted Project

Jul 6 2020

lkail updated the diff for D83276: [PowerPC] Generate CFI directives when probing in prologue.
Jul 6 2020, 10:55 PM · Restricted Project
lkail updated the diff for D83276: [PowerPC] Generate CFI directives when probing in prologue.
Jul 6 2020, 10:19 PM · Restricted Project
Herald added a project to D83276: [PowerPC] Generate CFI directives when probing in prologue: Restricted Project.
Jul 6 2020, 9:43 PM · Restricted Project

Jul 4 2020

lkail committed rG68e07da3e5d5: [clang][PowerPC] Enable -fstack-clash-protection option for ppc64 (authored by lkail).
[clang][PowerPC] Enable -fstack-clash-protection option for ppc64
Jul 4 2020, 9:34 PM
lkail closed D81355: [PowerPC] Enable -fstack-clash-protection option for ppc64.
Jul 4 2020, 9:34 PM · Restricted Project

Jul 3 2020

lkail committed rGc352e0885a6b: [PowerPC] Implement probing for prologue (authored by lkail).
[PowerPC] Implement probing for prologue
Jul 3 2020, 8:34 PM
lkail closed D81460: [PowerPC] Implement probing for prologue.
Jul 3 2020, 8:33 PM · Restricted Project

Jul 2 2020

lkail committed rG03828e38c3cf: [PowerPC] Implement probing for dynamic stack allocation (authored by lkail).
[PowerPC] Implement probing for dynamic stack allocation
Jul 2 2020, 11:57 PM
lkail closed D81358: [PowerPC] Implement probing for dynamic stack allocation.
Jul 2 2020, 11:57 PM · Restricted Project
lkail committed rGd8921a800525: [PowerPC][NFC] Prevent unused error when assertion is disabled. (authored by lkail).
[PowerPC][NFC] Prevent unused error when assertion is disabled.
Jul 2 2020, 9:35 PM
lkail committed rG40e9e0826be8: [PowerPC][NFC] Refactor lowerDynamicAlloc (authored by lkail).
[PowerPC][NFC] Refactor lowerDynamicAlloc
Jul 2 2020, 9:02 PM
lkail closed D81354: [PowerPC][NFC] Refactor lowerDynamicAlloc.
Jul 2 2020, 9:02 PM · Restricted Project

Jul 1 2020

lkail added a comment to D82145: [PowerPC] Legalize SREM/UREM directly on P9..

Please remove 'NFC' from the title when landing this patch.

Jul 1 2020, 11:57 PM · Restricted Project
lkail accepted D82145: [PowerPC] Legalize SREM/UREM directly on P9..

LGTM.

Jul 1 2020, 11:25 PM · Restricted Project

Jun 29 2020

lkail updated the diff for D82361: [PowerPC] Only make copies of registers on stack in variadic function when va_start is called.

Address @steven.zhang 's comment.

Jun 29 2020, 7:48 PM · Restricted Project
lkail updated the diff for D81460: [PowerPC] Implement probing for prologue.
Jun 29 2020, 4:49 AM · Restricted Project
lkail added inline comments to D81460: [PowerPC] Implement probing for prologue.
Jun 29 2020, 4:49 AM · Restricted Project
lkail updated the diff for D81460: [PowerPC] Implement probing for prologue.

Address @jsji 's comments.

Jun 29 2020, 4:49 AM · Restricted Project

Jun 28 2020

lkail added inline comments to D81358: [PowerPC] Implement probing for dynamic stack allocation.
Jun 28 2020, 8:20 PM · Restricted Project
lkail updated the diff for D81358: [PowerPC] Implement probing for dynamic stack allocation.

Address @jsji 's comments. Add test case for large probe size.

Jun 28 2020, 8:20 PM · Restricted Project

Jun 25 2020

lkail added a reviewer for D82527: [PowerPC] custom lowering for CNTPOP(i128): Restricted Project.
Jun 25 2020, 5:47 AM · Restricted Project

Jun 24 2020

lkail added a comment to D82145: [PowerPC] Legalize SREM/UREM directly on P9..

I am not sure whether this is preferable. If so, the predictions will change after making OperationAction Legal...

Jun 24 2020, 12:29 AM · Restricted Project

Jun 23 2020

lkail added a comment to D82145: [PowerPC] Legalize SREM/UREM directly on P9..

Better keep original RUN lines and adding new RUN with opt added and check prefix named like CHECK-DIV-REM-PAIRS.

Jun 23 2020, 8:31 PM · Restricted Project
lkail added a comment to D82145: [PowerPC] Legalize SREM/UREM directly on P9..

It looks not an NFC patch to me, the test predicates are changed

CHECK: modsw -> CHECK-NOT: modsw

I'm curious if it is unchanged that opt is added to RUN lines while the OperationAction keeps Custom. If so, adding opt to RUN lines can be an NFC patch, and making OperationAction Legal can be another FC patch.

Jun 23 2020, 7:26 PM · Restricted Project
lkail added inline comments to D81358: [PowerPC] Implement probing for dynamic stack allocation.
Jun 23 2020, 7:26 PM · Restricted Project
lkail updated the diff for D82361: [PowerPC] Only make copies of registers on stack in variadic function when va_start is called.
Jun 23 2020, 3:08 AM · Restricted Project
lkail created D82361: [PowerPC] Only make copies of registers on stack in variadic function when va_start is called.
Jun 23 2020, 3:08 AM · Restricted Project
lkail committed rGf09ef03e1c52: [PowerPC][NFC] Add tests for variadic functions on PPC64 (authored by lkail).
[PowerPC][NFC] Add tests for variadic functions on PPC64
Jun 23 2020, 2:36 AM

Jun 21 2020

lkail updated the diff for D81358: [PowerPC] Implement probing for dynamic stack allocation.

Rebased and address steven's comments.

Jun 21 2020, 9:09 PM · Restricted Project