Page MenuHomePhabricator

lkail (Kai Luo)
User

Projects

User does not belong to any projects.

User Details

User Since
May 15 2019, 8:43 PM (88 w, 4 d)

Recent Activity

Sun, Jan 10

lkail added reviewers for D94385: [NFC] Disallow unused prefixes in CodeGen/PowerPC tests.: nemanjai, Restricted Project.
Sun, Jan 10, 10:33 PM · Restricted Project

Sun, Jan 3

lkail committed rGf6515b05205d: [PowerPC] Do not fold `cmp(d|w)` and `subf` instruction to `subf.` if `nsw` is… (authored by lkail).
[PowerPC] Do not fold `cmp(d|w)` and `subf` instruction to `subf.` if `nsw` is…
Sun, Jan 3, 11:54 PM
lkail closed D90156: [PowerPC] Do not fold `cmp(d|w)` and `subf` instruction to `subf.` if `nsw` is not present.
Sun, Jan 3, 11:54 PM · Restricted Project

Tue, Dec 29

lkail updated the diff for D90156: [PowerPC] Do not fold `cmp(d|w)` and `subf` instruction to `subf.` if `nsw` is not present.
Tue, Dec 29, 7:03 PM · Restricted Project
lkail updated the diff for D90156: [PowerPC] Do not fold `cmp(d|w)` and `subf` instruction to `subf.` if `nsw` is not present.

Update comment and I've pre-commit a mir test https://github.com/llvm/llvm-project/commit/e3e25cfb44bc2a35e3b53d62d37c27b7d13157b6 to demonstrate the situation when `equality is true. The codegen of the test case doesn't change with this patch.

Tue, Dec 29, 6:56 PM · Restricted Project
lkail committed rGe3e25cfb44bc: [PowerPC] Add mir test to show effect of `optimizeCompareInstr` when… (authored by lkail).
[PowerPC] Add mir test to show effect of `optimizeCompareInstr` when…
Tue, Dec 29, 6:29 PM
lkail committed rGf904d50c29f2: [PowerPC] Remaining KnownBits should be constant when performing non-sign… (authored by lkail).
[PowerPC] Remaining KnownBits should be constant when performing non-sign…
Tue, Dec 29, 6:01 PM
lkail closed D93092: [PowerPC] Remaining KnownBits should be constant when performing non-sign comparison.
Tue, Dec 29, 6:01 PM · Restricted Project
lkail retitled D93092: [PowerPC] Remaining KnownBits should be constant when performing non-sign comparison from [PowerPC] KnownBits should be constant when performing non-sign comparison to [PowerPC] Remaining KnownBits should be constant when performing non-sign comparison.
Tue, Dec 29, 4:40 AM · Restricted Project
lkail updated the diff for D93092: [PowerPC] Remaining KnownBits should be constant when performing non-sign comparison.
Tue, Dec 29, 4:38 AM · Restricted Project
lkail updated the diff for D93092: [PowerPC] Remaining KnownBits should be constant when performing non-sign comparison.

@nemanjai 's solution can make code more compact. Thanks.

Tue, Dec 29, 4:36 AM · Restricted Project
lkail added inline comments to D93092: [PowerPC] Remaining KnownBits should be constant when performing non-sign comparison.
Tue, Dec 29, 4:08 AM · Restricted Project

Dec 23 2020

lkail abandoned D89084: [PowerPC] Combine select_cc (x, 0, t, f, lt) to avoid generating `isel`.

Functionality of this patch can be covered by https://reviews.llvm.org/D93191.

Dec 23 2020, 6:14 PM · Restricted Project

Dec 17 2020

lkail added inline comments to D92405: [VirtRegRewriter] Insert missing killed flags when tracking subregister liveness.
Dec 17 2020, 1:32 AM · Restricted Project
lkail added inline comments to D90349: [DAGCombiner] Improve shift by select of constant.
Dec 17 2020, 12:05 AM · Restricted Project

Dec 16 2020

lkail added inline comments to D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..
Dec 16 2020, 7:32 PM · Restricted Project
lkail added inline comments to D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..
Dec 16 2020, 6:44 PM · Restricted Project
lkail added inline comments to D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..
Dec 16 2020, 4:55 AM · Restricted Project, Restricted Project

Dec 13 2020

lkail requested review of D93191: [DAGCombine][PowerPC] Fold select_cc constants when comparing zero into trivial ops.
Dec 13 2020, 9:41 PM · Restricted Project

Dec 11 2020

lkail added a reviewer for D93092: [PowerPC] Remaining KnownBits should be constant when performing non-sign comparison: hfinkel.
Dec 11 2020, 12:49 AM · Restricted Project
lkail requested review of D93092: [PowerPC] Remaining KnownBits should be constant when performing non-sign comparison.
Dec 11 2020, 12:45 AM · Restricted Project

Dec 7 2020

lkail committed rG44bd8ea167f2: [DAGCombine][PowerPC] Simplify nabs by using legal `smin` operation (authored by lkail).
[DAGCombine][PowerPC] Simplify nabs by using legal `smin` operation
Dec 7 2020, 7:24 PM
lkail closed D92637: [DAGCombine][PowerPC] Simplify nabs by using legal `smin` operation.
Dec 7 2020, 7:24 PM · Restricted Project
lkail updated the diff for D92637: [DAGCombine][PowerPC] Simplify nabs by using legal `smin` operation.

Per @RKSimon 's suggestion.

Dec 7 2020, 1:59 AM · Restricted Project

Dec 4 2020

lkail requested review of D92637: [DAGCombine][PowerPC] Simplify nabs by using legal `smin` operation.
Dec 4 2020, 12:04 AM · Restricted Project

Dec 3 2020

lkail committed rGf5d52916ce34: [PowerPC] Pre-commit neg abs test for vector. NFC. (authored by lkail).
[PowerPC] Pre-commit neg abs test for vector. NFC.
Dec 3 2020, 10:53 PM

Dec 1 2020

lkail updated the summary of D90156: [PowerPC] Do not fold `cmp(d|w)` and `subf` instruction to `subf.` if `nsw` is not present.
Dec 1 2020, 1:47 AM · Restricted Project

Nov 25 2020

lkail added a reviewer for D92156: [PowerPC] Add support for "tlbiel" with two arguments: nemanjai.
Nov 25 2020, 11:11 PM · Restricted Project
lkail planned changes to D89084: [PowerPC] Combine select_cc (x, 0, t, f, lt) to avoid generating `isel`.

Gonna to add more patterns and refine current code.

Nov 25 2020, 9:52 PM · Restricted Project

Nov 24 2020

lkail committed rG97e7ce3b15cc: [PowerPC] Probe the gap between stackptr and realigned stackptr (authored by lkail).
[PowerPC] Probe the gap between stackptr and realigned stackptr
Nov 24 2020, 11:02 PM
lkail closed D88078: [PowerPC] Probe the gap between stackptr and realigned stackptr.
Nov 24 2020, 11:01 PM · Restricted Project
lkail updated the diff for D90156: [PowerPC] Do not fold `cmp(d|w)` and `subf` instruction to `subf.` if `nsw` is not present.

Rebased.

Nov 24 2020, 8:52 PM · Restricted Project
lkail committed rG8e6d92026c62: [DAG][PowerPC] Fix dropped `nsw` flag in `SimplifySetCC` by adding… (authored by lkail).
[DAG][PowerPC] Fix dropped `nsw` flag in `SimplifySetCC` by adding…
Nov 24 2020, 8:39 PM
lkail closed D89938: [DAG][PowerPC] Fix dropped `nsw` flag in `SimplifySetCC` by adding `doesNodeExist` helper.
Nov 24 2020, 8:39 PM · Restricted Project
lkail updated the diff for D89938: [DAG][PowerPC] Fix dropped `nsw` flag in `SimplifySetCC` by adding `doesNodeExist` helper.

Reformat code.

Nov 24 2020, 7:33 PM · Restricted Project
lkail updated the diff for D88078: [PowerPC] Probe the gap between stackptr and realigned stackptr.

Refined comments.

Nov 24 2020, 7:22 PM · Restricted Project
lkail added a comment to D89938: [DAG][PowerPC] Fix dropped `nsw` flag in `SimplifySetCC` by adding `doesNodeExist` helper.

Gentle ping.

Nov 24 2020, 1:52 AM · Restricted Project
lkail committed rG5931be60b523: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops (authored by lkail).
[DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops
Nov 24 2020, 1:44 AM
lkail closed D91120: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops.
Nov 24 2020, 1:43 AM · Restricted Project
lkail added a comment to D91120: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops.

Removed parent revision, since this patch doesn't rely on opt's abs canonicalization.

Nov 24 2020, 12:39 AM · Restricted Project

Nov 23 2020

lkail committed rGda3bc99bdd77: [PowerPC] Pre-commit more tests for `select` codegen. NFC. (authored by lkail).
[PowerPC] Pre-commit more tests for `select` codegen. NFC.
Nov 23 2020, 10:38 PM

Nov 19 2020

lkail updated the diff for D91120: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops.

Rebased on Simon's commit.

Nov 19 2020, 9:31 PM · Restricted Project

Nov 18 2020

lkail added inline comments to D91120: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops.
Nov 18 2020, 7:24 PM · Restricted Project
lkail updated the diff for D91120: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops.

Removed the hook and added test cases for other arch.

Nov 18 2020, 6:43 PM · Restricted Project
lkail committed rG5f0ae23e71df: [X86][AArch64][RISCV] Pre-commit negated abs test case. NFC. (authored by lkail).
[X86][AArch64][RISCV] Pre-commit negated abs test case. NFC.
Nov 18 2020, 6:32 PM

Nov 17 2020

lkail updated the diff for D91120: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops.
Nov 17 2020, 1:48 AM · Restricted Project
lkail committed rGc2460c3254a0: [PowerPC] Add negated abs test using llvm.abs intrinsic. NFC. (authored by lkail).
[PowerPC] Add negated abs test using llvm.abs intrinsic. NFC.
Nov 17 2020, 1:31 AM

Nov 13 2020

lkail updated the diff for D91120: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops.

Pre-committed test case and rebased.

Nov 13 2020, 12:14 AM · Restricted Project
lkail committed rG96ff53fbaead: [PowerPC] Add test case for negated abs. NFC. (authored by lkail).
[PowerPC] Add test case for negated abs. NFC.
Nov 13 2020, 12:07 AM

Nov 12 2020

lkail added a comment to D91120: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops.

Note that we are planning to canonicalize IR to the abs() intrinsic - D87188.
Assuming that comes through relatively soon (cc @nikic), should we hold off adding what would probably become dead code in the backend?

Nov 12 2020, 11:32 PM · Restricted Project

Nov 9 2020

lkail requested review of D91120: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops.
Nov 9 2020, 9:28 PM · Restricted Project

Nov 6 2020

lkail updated subscribers of D90901: [DAGCombiner] Don't fold ((fma (fneg X), Y, (fneg Z)) to fneg (fma X, Y, Z)).
Nov 6 2020, 1:24 AM · Restricted Project

Nov 5 2020

lkail added a comment to D89938: [DAG][PowerPC] Fix dropped `nsw` flag in `SimplifySetCC` by adding `doesNodeExist` helper.

Ping.

Nov 5 2020, 7:29 PM · Restricted Project

Nov 3 2020

lkail updated the diff for D89084: [PowerPC] Combine select_cc (x, 0, t, f, lt) to avoid generating `isel`.
Nov 3 2020, 9:28 PM · Restricted Project
lkail added a comment to D89084: [PowerPC] Combine select_cc (x, 0, t, f, lt) to avoid generating `isel`.

I guess this opt should also be profitable for opcode SELECT, is there any reason we don't do this?

Nov 3 2020, 9:26 PM · Restricted Project

Oct 26 2020

lkail requested review of D90156: [PowerPC] Do not fold `cmp(d|w)` and `subf` instruction to `subf.` if `nsw` is not present.
Oct 26 2020, 7:15 AM · Restricted Project
lkail committed rG82150dae8660: [PowerPC] Add test case for pr47830. NFC. (authored by lkail).
[PowerPC] Add test case for pr47830. NFC.
Oct 26 2020, 2:12 AM

Oct 25 2020

lkail updated the diff for D89938: [DAG][PowerPC] Fix dropped `nsw` flag in `SimplifySetCC` by adding `doesNodeExist` helper.
Oct 25 2020, 9:10 PM · Restricted Project
lkail updated the diff for D89938: [DAG][PowerPC] Fix dropped `nsw` flag in `SimplifySetCC` by adding `doesNodeExist` helper.

I think what @efriedma suggests is viable and eases the confusion mentioned by @qiucf .

Oct 25 2020, 7:56 PM · Restricted Project

Oct 22 2020

lkail requested review of D89938: [DAG][PowerPC] Fix dropped `nsw` flag in `SimplifySetCC` by adding `doesNodeExist` helper.
Oct 22 2020, 1:42 AM · Restricted Project

Oct 19 2020

lkail committed rG638fee625d43: [PowerPC] Add test case for missing `nsw` flag. NFC. (authored by lkail).
[PowerPC] Add test case for missing `nsw` flag. NFC.
Oct 19 2020, 8:49 PM

Oct 18 2020

lkail committed rG354d3106c6a9: [PowerPC] Skip combining (uint_to_fp x) if x is not simple type (authored by lkail).
[PowerPC] Skip combining (uint_to_fp x) if x is not simple type
Oct 18 2020, 10:24 PM
lkail closed D88388: [PowerPC] Skip combining (uint_to_fp x) if x is not simple type.
Oct 18 2020, 10:23 PM · Restricted Project

Oct 13 2020

lkail updated the diff for D89084: [PowerPC] Combine select_cc (x, 0, t, f, lt) to avoid generating `isel`.

Add tests to cover zext/trunc.

Oct 13 2020, 2:34 AM · Restricted Project

Oct 8 2020

lkail updated the diff for D89084: [PowerPC] Combine select_cc (x, 0, t, f, lt) to avoid generating `isel`.

Tune codegen.

Oct 8 2020, 11:13 PM · Restricted Project
lkail committed rG8a5858c8fd50: [TwoAddressInstruction][PowerPC] Call `regOverlapsSet` to find out real… (authored by lkail).
[TwoAddressInstruction][PowerPC] Call `regOverlapsSet` to find out real…
Oct 8 2020, 7:35 PM
lkail closed D88716: [TwoAddressInstruction][PowerPC] Call `regOverlapsSet` to find out real clobbers and uses.
Oct 8 2020, 7:35 PM · Restricted Project
lkail updated the diff for D89084: [PowerPC] Combine select_cc (x, 0, t, f, lt) to avoid generating `isel`.
Oct 8 2020, 6:24 PM · Restricted Project
lkail updated the diff for D89084: [PowerPC] Combine select_cc (x, 0, t, f, lt) to avoid generating `isel`.

Confirmed with https://alive2.llvm.org/ce/z/8pnUEb

Oct 8 2020, 6:01 PM · Restricted Project
lkail requested review of D89084: [PowerPC] Combine select_cc (x, 0, t, f, lt) to avoid generating `isel`.
Oct 8 2020, 5:44 PM · Restricted Project
lkail committed rG1c19900f9417: [PowerPC] Add RUN line for powerpc 32-bit. NFC. (authored by lkail).
[PowerPC] Add RUN line for powerpc 32-bit. NFC.
Oct 8 2020, 5:30 PM

Oct 1 2020

lkail updated the summary of D88716: [TwoAddressInstruction][PowerPC] Call `regOverlapsSet` to find out real clobbers and uses.
Oct 1 2020, 9:02 PM · Restricted Project
lkail updated the diff for D88716: [TwoAddressInstruction][PowerPC] Call `regOverlapsSet` to find out real clobbers and uses.
Oct 1 2020, 9:00 PM · Restricted Project
lkail edited reviewers for D88716: [TwoAddressInstruction][PowerPC] Call `regOverlapsSet` to find out real clobbers and uses, added: efriedma; removed: eli.friedman.
Oct 1 2020, 8:58 PM · Restricted Project
lkail requested review of D88716: [TwoAddressInstruction][PowerPC] Call `regOverlapsSet` to find out real clobbers and uses.
Oct 1 2020, 8:58 PM · Restricted Project

Sep 27 2020

lkail committed rGdd3ba7206680: [PowerPC] Add tests for `select` patterns. NFC. (authored by lkail).
[PowerPC] Add tests for `select` patterns. NFC.
Sep 27 2020, 11:14 PM
lkail requested review of D88388: [PowerPC] Skip combining (uint_to_fp x) if x is not simple type.
Sep 27 2020, 7:41 PM · Restricted Project

Sep 26 2020

lkail updated the diff for D88078: [PowerPC] Probe the gap between stackptr and realigned stackptr.

Fix format and add more tests.

Sep 26 2020, 7:02 PM · Restricted Project

Sep 22 2020

lkail requested review of D88078: [PowerPC] Probe the gap between stackptr and realigned stackptr.
Sep 22 2020, 2:35 AM · Restricted Project

Sep 21 2020

lkail added inline comments to D84419: Fix interaction between stack alignment and inline-asm stack clash protection.
Sep 21 2020, 9:34 PM · Restricted Project

Sep 20 2020

lkail accepted D84419: Fix interaction between stack alignment and inline-asm stack clash protection.

LGTM. This solution probes the gap between [stackptr & mask, stackptr] when align is big.

Sep 20 2020, 7:01 PM · Restricted Project

Sep 9 2020

lkail commandeered D85288: [PowerPC] Remove implicit use register after transformToImmFormFedByLI().
Sep 9 2020, 11:34 PM · Restricted Project
lkail commandeered D66576: [Regalloc][WIP] Increase CSR cost in RegAllocGreedy to favour splitting/spill over CSR first use.
Sep 9 2020, 11:32 PM · Restricted Project

Aug 28 2020

lkail committed rGb904324788a8: [DAGCombiner] Enhance (zext(setcc)) (authored by lkail).
[DAGCombiner] Enhance (zext(setcc))
Aug 28 2020, 8:38 PM
lkail closed D86687: [DAGCombiner] Enhance (zext(setcc)).
Aug 28 2020, 8:38 PM · Restricted Project
lkail edited reviewers for D86808: [MachineDCE] Delete missed dead instructions after deleting PHI, added: efriedma; removed: eli.friedman.
Aug 28 2020, 4:45 PM · Restricted Project
lkail updated the diff for D86687: [DAGCombiner] Enhance (zext(setcc)).

Updated comments again.

Aug 28 2020, 9:46 AM · Restricted Project
lkail added inline comments to D86687: [DAGCombiner] Enhance (zext(setcc)).
Aug 28 2020, 9:38 AM · Restricted Project
lkail updated the diff for D86687: [DAGCombiner] Enhance (zext(setcc)).

Adjust comments, leave function name unchanged.

Aug 28 2020, 9:34 AM · Restricted Project
lkail updated the summary of D86687: [DAGCombiner] Enhance (zext(setcc)).
Aug 28 2020, 8:50 AM · Restricted Project
lkail added inline comments to D86687: [DAGCombiner] Enhance (zext(setcc)).
Aug 28 2020, 8:45 AM · Restricted Project
lkail updated the diff for D86687: [DAGCombiner] Enhance (zext(setcc)).

Per @spatel 's comments.

Aug 28 2020, 8:43 AM · Restricted Project

Aug 27 2020

lkail committed rGcbea17568f43: [PowerPC] PPCBoolRetToInt: Don't translate Constant's operands (authored by lkail).
[PowerPC] PPCBoolRetToInt: Don't translate Constant's operands
Aug 27 2020, 6:58 PM
lkail closed D85007: [PowerPC] PPCBoolRetToInt: Don't translate Constant's operands.
Aug 27 2020, 6:58 PM · Restricted Project
lkail added reviewers for D86687: [DAGCombiner] Enhance (zext(setcc)): xbolva00, lebedev.ri.
Aug 27 2020, 1:26 AM · Restricted Project
lkail updated the summary of D86687: [DAGCombiner] Enhance (zext(setcc)).
Aug 27 2020, 1:20 AM · Restricted Project
lkail edited reviewers for D86687: [DAGCombiner] Enhance (zext(setcc)), added: steven.zhang; removed: qshanz.
Aug 27 2020, 1:19 AM · Restricted Project
lkail requested review of D86687: [DAGCombiner] Enhance (zext(setcc)).
Aug 27 2020, 1:19 AM · Restricted Project

Aug 26 2020

lkail added a comment to D85007: [PowerPC] PPCBoolRetToInt: Don't translate Constant's operands.

Updated Summary.

Aug 26 2020, 7:03 PM · Restricted Project
lkail updated the summary of D85007: [PowerPC] PPCBoolRetToInt: Don't translate Constant's operands.
Aug 26 2020, 7:00 PM · Restricted Project