Support for Code Generation of "#pragma loop bind" clause.
- bind(parallel)
- bind(teams)
- bind(thread)
Differential D144634
[Clang][OpenMP] Support for Code Generation of loop bind clause koops on Feb 23 2023, 3:14 AM. Authored by
Details
Diff Detail Event TimelineComment Actions bind(thread) is not working at present. I have uploaded this patch to obtain feedback mainly on this. Comment Actions We need tests.
Comment Actions
Comment Actions Removing changes from :
These were useful when the code was in CodeGen to handle the bind clause.
Comment Actions
Comment Actions But why need to drop it? It makes processing more complex. The bind clause itself should not be a problem, no?
Comment Actions
However, generic_loop_messages.cpp & generic_loop_ast_print.cpp are present and provide a good coverage. Comment Actions I rather doubt that these tests provide good coverage, since you're changing the directive kind here on the fly. This is a very new functionality, which was not tested before.
Comment Actions
In https://reviews.llvm.org/D145823 : Add codegen for combined 'loop' directives, I see the following code emitCommonOMPParallelDirective(*this, S, OMPD_for, CodeGen, emitEmptyBoundParameters); .... void CodeGenFunction::EmitOMPTeamsGenericLoopDirective() { CGF.CGM.getOpenMPRuntime().emitInlinedDirective(CGF, OMPD_distribute, CodeGenDistribute); .... Comment Actions
This comment was removed by koops.
|