Page MenuHomePhabricator

ronlieb (Ron Lieberman)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 24 2018, 5:18 PM (205 w, 2 d)

Recent Activity

Thu, Jun 2

ronlieb accepted D126906: AMDGPU: Move SpilledReg from MFI to SIRegisterInfo.

thx for fix.

Thu, Jun 2, 1:44 PM · Restricted Project, Restricted Project

May 8 2022

ronlieb added a comment to D115750: [SLP]Further improvement of the cost model for scalars used in buildvectors..

i am seeing the same assert on the amdgpu target

May 8 2022, 8:32 PM · Restricted Project, Restricted Project

May 6 2022

ronlieb added a comment to D122614: [CMake][libcxx] Use target_include_directories for libc++ headers.

Hi Peter

May 6 2022, 9:57 PM · Restricted Project, Restricted Project, Restricted Project

Apr 5 2022

ronlieb updated subscribers of D120662: [clang-offload-bundler] add -input/-output options.

@saiislam for awareness

Apr 5 2022, 5:15 AM · Restricted Project, Restricted Project

Apr 2 2022

ronlieb added a comment to rGcc2139524f77: [AMDPU][Sanitizer] Refactor sanitizer options handling for AMDGPU Toolchain.

i forwarded a couple buildbot failures to Amit to look into

Apr 2 2022, 6:29 AM · Restricted Project, Restricted Project
ronlieb added a reverting change for rGcc2139524f77: [AMDPU][Sanitizer] Refactor sanitizer options handling for AMDGPU Toolchain: rGf1e7ecaa18a7: Revert "[AMDPU][Sanitizer] Refactor sanitizer options handling for AMDGPU….
Apr 2 2022, 6:27 AM · Restricted Project, Restricted Project
ronlieb committed rGf1e7ecaa18a7: Revert "[AMDPU][Sanitizer] Refactor sanitizer options handling for AMDGPU… (authored by ronlieb).
Revert "[AMDPU][Sanitizer] Refactor sanitizer options handling for AMDGPU…
Apr 2 2022, 6:27 AM · Restricted Project, Restricted Project
ronlieb added a reverting change for D122781: Refactor sanitizer options handling for AMDGPU Toolchain: rGf1e7ecaa18a7: Revert "[AMDPU][Sanitizer] Refactor sanitizer options handling for AMDGPU….
Apr 2 2022, 6:27 AM · Restricted Project, Restricted Project
ronlieb added a comment to D122781: Refactor sanitizer options handling for AMDGPU Toolchain.

i pushed it in. will watch for build bot issues

Apr 2 2022, 4:03 AM · Restricted Project, Restricted Project
ronlieb committed rGcc2139524f77: [AMDPU][Sanitizer] Refactor sanitizer options handling for AMDGPU Toolchain (authored by ronlieb).
[AMDPU][Sanitizer] Refactor sanitizer options handling for AMDGPU Toolchain
Apr 2 2022, 4:03 AM · Restricted Project, Restricted Project
ronlieb closed D122781: Refactor sanitizer options handling for AMDGPU Toolchain.
Apr 2 2022, 4:03 AM · Restricted Project, Restricted Project

Mar 29 2022

ronlieb committed rG95eac4726054: [libomptarget] x86 offloading fails map_back_race.cpp intermittently (authored by ronlieb).
[libomptarget] x86 offloading fails map_back_race.cpp intermittently
Mar 29 2022, 9:02 AM · Restricted Project, Restricted Project
ronlieb closed D122658: [libomptarget] x86 offloading fails map_back_race.cpp intermittently.
Mar 29 2022, 9:01 AM · Restricted Project, Restricted Project
ronlieb added a comment to D122658: [libomptarget] x86 offloading fails map_back_race.cpp intermittently.

https://github.com/llvm/llvm-project/issues/54618

Mar 29 2022, 8:30 AM · Restricted Project, Restricted Project
ronlieb added a comment to D121058: [OpenMP][FIX] Avoid races in the handling of to be deleted mapping entries.

thanks for suggestion: https://reviews.llvm.org/D122658

Mar 29 2022, 7:58 AM · Restricted Project, Restricted Project
ronlieb requested review of D122658: [libomptarget] x86 offloading fails map_back_race.cpp intermittently.
Mar 29 2022, 7:58 AM · Restricted Project, Restricted Project
ronlieb abandoned D122652: [libomptarget][test] add return 0 to map_back_race.cpp.

having looked at the generated code for g++ and clang++ , i agree this does not and will not fix the underlying issue.
abandoning

Mar 29 2022, 7:16 AM · Restricted Project, Restricted Project
ronlieb requested review of D122652: [libomptarget][test] add return 0 to map_back_race.cpp.
Mar 29 2022, 6:15 AM · Restricted Project, Restricted Project
ronlieb added inline comments to D121058: [OpenMP][FIX] Avoid races in the handling of to be deleted mapping entries.
Mar 29 2022, 4:16 AM · Restricted Project, Restricted Project

Mar 23 2022

ronlieb added a comment to D122180: Cleanup include: codegen second round.

seeing some buildbot failures ...
https://lab.llvm.org/buildbot/#/builders/165/builds/18307
https://lab.llvm.org/buildbot/#/builders/193/builds/9008

Mar 23 2022, 6:20 AM · Restricted Project, Restricted Project

Mar 20 2022

ronlieb added a comment to D122091: [amdgpu] Elide module lds allocation in kernels with no callees.

The patch passed internal CI.

Mar 20 2022, 3:01 AM · Restricted Project, Restricted Project

Mar 17 2022

ronlieb added a comment to D121837: [OpenMP][FIX] Allow device constructors for AMD GPU.

i applied it locally and ran bot equiv, looks good to me

Mar 17 2022, 10:00 AM · Restricted Project, Restricted Project

Mar 16 2022

ronlieb added a comment to D121837: [OpenMP][FIX] Allow device constructors for AMD GPU.

Hi Johannes,
assert in two of the tests

Mar 16 2022, 3:14 PM · Restricted Project, Restricted Project
ronlieb added a comment to D121121: [SLP]Do not schedule instructions with constants/argument/phi operands and external users..

Hi Alexey
with this patch, i noticed an assert building one of our runtime files , the test case .c produced is around 24000 lines
would you like it as is? or reduced ?

Mar 16 2022, 1:51 PM · Restricted Project, Restricted Project

Mar 15 2022

ronlieb added a comment to D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra.

Hi Sam
i think this breaks our amdgpu buildbot
https://lab.llvm.org/buildbot/#/builders/193/builds/8513

Mar 15 2022, 4:48 PM · Restricted Project, Restricted Project, Restricted Project

Mar 14 2022

ronlieb added a comment to D121638: [lld-macho] Avoid using bump-alloc in TrieBuider.

breaking HIP and AMDGPU buildbots
https://lab.llvm.org/buildbot/#/builders/193/builds/8433
https://lab.llvm.org/buildbot/#/builders/165/builds/17691

Mar 14 2022, 2:53 PM · Restricted Project, Restricted Project, Restricted Project

Mar 7 2022

ronlieb added inline comments to rGff50e81b5008: [OpenMP][NFCI] Use RAII lock guards in libomptarget where possible.
Mar 7 2022, 8:38 AM · Restricted Project, Restricted Project

Mar 6 2022

ronlieb added a comment to rGff50e81b5008: [OpenMP][NFCI] Use RAII lock guards in libomptarget where possible.

FWIW, only the top commit causes the hangs, the 3 predecessor commits seem ok.
noticed it while i started looking in more detail.

Mar 6 2022, 7:56 PM · Restricted Project, Restricted Project
ronlieb reopened D121060: [OpenMP][NFCI] Use RAII lock guards in libomptarget where possible.

This set of commits seems to have broken the amdgpu buildbot, test(s) are hanging.
see

https://lab.llvm.org/buildbot/#/builders/193/builds/8002

and a force run to see if the previous hang was spurious, seems reproducible.

https://lab.llvm.org/buildbot/#/builders/193/builds/8003
Mar 6 2022, 6:52 PM · Restricted Project, Restricted Project

Mar 3 2022

ronlieb added a comment to D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions.

broke our hip buildbot as well.

Mar 3 2022, 10:32 AM · Restricted Project, Restricted Project

Feb 16 2022

ronlieb accepted D119911: AMDGPU: Always reserve VGPR for AGPR copies on gfx908.

lgtm

Feb 16 2022, 2:38 PM · Restricted Project
ronlieb added a comment to D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper.

Hi Joseph,
seems to have broken amdgpu buildbit,
please revert and fix ?
https://lab.llvm.org/buildbot/#/builders/193/builds/6939

Feb 16 2022, 8:52 AM · Restricted Project

Feb 8 2022

ronlieb added a comment to D119173: [libc++] Remove _LIBCPP_ABI_UNSTABLE.

Hi
Looks like hip buildbot breaks from this
https://lab.llvm.org/buildbot/#/builders/165/builds/15363

Feb 8 2022, 1:35 PM · Restricted Project
ronlieb added a comment to D119254: [Libomptarget] Add header files as a dependency to CMake target.

Thx
Much needed!

Feb 8 2022, 8:42 AM · Restricted Project

Feb 2 2022

ronlieb added a comment to D118707: [nfc][regalloc] Make the max inference cutoff configurable.

seeing same breakage on https://lab.llvm.org/buildbot/#/builders/165/builds/14870
and https://lab.llvm.org/buildbot/#/builders/193/builds/5889

Feb 2 2022, 7:36 AM · Restricted Project

Feb 1 2022

ronlieb accepted rG8b7e99c41d61: [openmp] Disable tests that presently hang on CI.
Feb 1 2022, 5:41 AM

Jan 27 2022

ronlieb added a reverting change for rG27c799ecc9e9: [OpenMP] Ensure broken assumptions print once, not thousands of times.: rG619f44b0edfd: Revert "[OpenMP] Ensure broken assumptions print once, not thousands of times.".
Jan 27 2022, 5:42 PM
ronlieb committed rG619f44b0edfd: Revert "[OpenMP] Ensure broken assumptions print once, not thousands of times." (authored by ronlieb).
Revert "[OpenMP] Ensure broken assumptions print once, not thousands of times."
Jan 27 2022, 5:41 PM
ronlieb added a reverting change for D112156: [OpenMP] Ensure broken assumptions print once, not thousands of times.: rG619f44b0edfd: Revert "[OpenMP] Ensure broken assumptions print once, not thousands of times.".
Jan 27 2022, 5:41 PM · Restricted Project

Jan 18 2022

ronlieb added a comment to D117526: [Libomptarget] Fix external visibility for internal variables.

i dont see the failures locally, so i am now getting on the buildbot system to see what happens

Jan 18 2022, 10:47 AM · Restricted Project
ronlieb added a comment to D117526: [Libomptarget] Fix external visibility for internal variables.

i will give it a try locally ...

Jan 18 2022, 10:24 AM · Restricted Project
ronlieb added a comment to D117526: [Libomptarget] Fix external visibility for internal variables.

Hi Joseph,
3 commits came in, one bot exited with a fail
https://lab.llvm.org/buildbot/#/builders/193/builds/4828

Jan 18 2022, 10:02 AM · Restricted Project

Jan 17 2022

ronlieb added a comment to D111889: [AIX] Support of Big archive (read).

seeing a buildbot failure on ;: https://lab.llvm.org/buildbot/#/builders/193/builds/4748

Jan 17 2022, 8:05 AM · Restricted Project
ronlieb accepted D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Jan 17 2022, 3:24 AM · Restricted Project, Restricted Project

Jan 13 2022

ronlieb accepted D117211: [openmp] Mark used variables as retain as well.

LGTM,

Jan 13 2022, 5:55 AM · Restricted Project

Jan 5 2022

ronlieb accepted D116716: [OpenMP][Offloading] Fixed a crash caused by dereferencing nullptr.

thx for quick fix

Jan 5 2022, 6:00 PM · Restricted Project
ronlieb added a comment to D104418: [OpenMP][Offloading] Fixed data race in libomptarget caused by async data movement.

Hi Shilei
seems like this broke our amdgpu openmp buildbot
https://lab.llvm.org/buildbot/#/builders/193/builds/4072

Jan 5 2022, 5:27 PM · Restricted Project
ronlieb added a comment to D116200: [instcombine] Allow sinking of calls with known writes to uses.

Hi Philip
This seems to break our amdgpu buildbot https://lab.llvm.org/buildbot/#/builders/193/builds/4050

Jan 5 2022, 10:53 AM · Restricted Project

Dec 22 2021

ronlieb updated subscribers of D102107: [OpenMP] Codegen aggregate for outlined function captures.

[AMD Official Use Only]

Dec 22 2021, 2:56 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ronlieb added a reverting change for rG9075009d1fd5: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved…: rG09b53296cf16: Revert "[AMDGPU] Move call clobbered return address registers s[30:31] to….
Dec 22 2021, 8:40 AM
ronlieb committed rG09b53296cf16: Revert "[AMDGPU] Move call clobbered return address registers s[30:31] to… (authored by ronlieb).
Revert "[AMDGPU] Move call clobbered return address registers s[30:31] to…
Dec 22 2021, 8:40 AM
ronlieb added a reverting change for D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range: rG09b53296cf16: Revert "[AMDGPU] Move call clobbered return address registers s[30:31] to….
Dec 22 2021, 8:40 AM · Restricted Project, Restricted Project
ronlieb added a comment to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.

hi Ram, landed patch breaks https://lab.llvm.org/buildbot/#/builders/193/builds/3514

Dec 22 2021, 7:55 AM · Restricted Project, Restricted Project

Dec 21 2021

ronlieb added a comment to D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm.

Our conclusion is that the /opt/rocm weak default needs to stay in place. Thus this patch should be abandoned in my opinion. MarkS and I are requesting the folks that requestedt his change within AMD, revisit it.

Dec 21 2021, 12:14 PM · Restricted Project, Restricted Project, Restricted Project
ronlieb requested changes to D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm.

This needs to be revisited.

Dec 21 2021, 12:01 PM · Restricted Project, Restricted Project, Restricted Project

Dec 16 2021

ronlieb added a reverting change for rG7ca355225d53: AMDGPU: Update pass pipeline test: rGf4420f522498: Revert "AMDGPU: Update pass pipeline test".
Dec 16 2021, 1:40 PM
ronlieb committed rGf4420f522498: Revert "AMDGPU: Update pass pipeline test" (authored by ronlieb).
Revert "AMDGPU: Update pass pipeline test"
Dec 16 2021, 1:40 PM
ronlieb committed rG8a85be807bd4: Revert "AMDGPU: Remove AMDGPUFixFunctionBitcasts pass" (authored by ronlieb).
Revert "AMDGPU: Remove AMDGPUFixFunctionBitcasts pass"
Dec 16 2021, 1:22 PM
ronlieb added a reverting change for rG2b4876157562: AMDGPU: Remove AMDGPUFixFunctionBitcasts pass: rG8a85be807bd4: Revert "AMDGPU: Remove AMDGPUFixFunctionBitcasts pass".
Dec 16 2021, 1:22 PM

Dec 15 2021

Herald added a reviewer for D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm: bondhugula.

@estewart08 thoughts on a good CMAKE variable to allow users to define equivalent of /opt/rocm ? and not use environment variable inside the cmake file.

Dec 15 2021, 6:42 AM · Restricted Project, Restricted Project, Restricted Project

Dec 10 2021

ronlieb added a comment to D113124: [OpenMP] Avoid costly shadow map traversals whenever possible.

i see the same failures in my local build, and when i revert this commit, and rebuild/test, failures go away

Dec 10 2021, 12:51 PM · Restricted Project

Dec 9 2021

ronlieb added a comment to D115413: [amdgpu] Drop lowering of LDS used by global variables.

LGTM, but needs Matt or Stas or Brian ...

Dec 9 2021, 6:13 AM · Restricted Project

Dec 6 2021

ronlieb added a comment to D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains.

fyi: if i remove the now 'dead' use of the CMAKE variable from my cmake , then i am able to build. so i see you reverted, thx. i guess some coordination amongst buildbot maintainers who might use this option

Dec 6 2021, 7:50 AM · Restricted Project
ronlieb added a comment to D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains.

Hi Simon,
i am seeing a failure in our amdgpu buildbot after this patch . https://lab.llvm.org/staging/#/builders/200/builds/1407
we do depend on the cmake flag you removed.
we specify this
-DCLANG_DEFAULT_LINKER=lld

Dec 6 2021, 7:10 AM · Restricted Project

Dec 4 2021

ronlieb accepted D115099: AMDGPU: Enable fixed function ABI by default.
Dec 4 2021, 7:13 AM · Restricted Project

Dec 2 2021

ronlieb committed rG8f4013ad465f: Restric xfail on openmp/libomptarget/test/mapping/reduction_implicit_map.cpp to… (authored by ronlieb).
Restric xfail on openmp/libomptarget/test/mapping/reduction_implicit_map.cpp to…
Dec 2 2021, 12:58 PM
ronlieb committed rGf87c2c637e78: xfail: libomptarget reduction_implicit_map.cpp after reapply of Start calling… (authored by ronlieb).
xfail: libomptarget reduction_implicit_map.cpp after reapply of Start calling…
Dec 2 2021, 12:44 PM
ronlieb added a reverting change for rG8b646f212e9c: xfail: reduction_implicit_map.cpp after reapply of Start calling…: rGef8e9bee1a9b: Revert "xfail: reduction_implicit_map.cpp after reapply of Start calling….
Dec 2 2021, 12:30 PM
ronlieb committed rGef8e9bee1a9b: Revert "xfail: reduction_implicit_map.cpp after reapply of Start calling… (authored by ronlieb).
Revert "xfail: reduction_implicit_map.cpp after reapply of Start calling…
Dec 2 2021, 12:30 PM
ronlieb committed rG8b646f212e9c: xfail: reduction_implicit_map.cpp after reapply of Start calling… (authored by ronlieb).
xfail: reduction_implicit_map.cpp after reapply of Start calling…
Dec 2 2021, 12:22 PM
ronlieb accepted D114965: [OpenMP] Remove the new runtime default for AMDGPU.
Dec 2 2021, 9:35 AM · Restricted Project
ronlieb added a comment to D114890: [OpenMP] Make the new device runtime the default.

yes, thanks, sounds good

Dec 2 2021, 8:29 AM · Restricted Project
ronlieb added a comment to D114890: [OpenMP] Make the new device runtime the default.

thx for trying it out, please revert so we can look into it more on the AMDGPU target

Dec 2 2021, 8:26 AM · Restricted Project

Dec 1 2021

ronlieb added a comment to D114890: [OpenMP] Make the new device runtime the default.

based on Shilei's last comment, do it in the morning ?

Dec 1 2021, 7:33 PM · Restricted Project
ronlieb accepted D114890: [OpenMP] Make the new device runtime the default.

works for me, i think Greg is ok with it too, we chatted internally an hour or so ago

Dec 1 2021, 7:28 PM · Restricted Project
ronlieb added a comment to D114890: [OpenMP] Make the new device runtime the default.

perhaps we can try this patch as is, and if it passes buildbot, let the new DeviceRTL be the default upstream for all targets.
if it fails the AMDGPU buildbot, then perhaps apply the above suggested change of leaving old runtime default for now for AMD.
or consider some other soultion.

Dec 1 2021, 6:06 PM · Restricted Project

Nov 25 2021

ronlieb added a comment to D114183: [ThreadPool] Support returning futures with results..

Both of our amdgpu buildbots are broken by this commit, when I revert it locally my build will pass.
https://lab.llvm.org/buildbot/#/builders/193
https://lab.llvm.org/buildbot/#/builders/165

Nov 25 2021, 11:45 AM · Restricted Project, Restricted Project

Nov 5 2021

ronlieb committed rZORGfbd934ea57a2: [builder][amdgpu][experimental] Tweak sollve flags for amdgpu (authored by ronlieb).
[builder][amdgpu][experimental] Tweak sollve flags for amdgpu
Nov 5 2021, 3:53 PM
ronlieb committed rZORGf3d7629581e2: [builder][amdgpu][experimental] enable testsuite (authored by ronlieb).
[builder][amdgpu][experimental] enable testsuite
Nov 5 2021, 7:29 AM

Nov 3 2021

ronlieb committed rZORGecce0d97a231: [zorg] Add Experimental Buildbot for OpenMP on AMDGPU (authored by david-salinas).
[zorg] Add Experimental Buildbot for OpenMP on AMDGPU
Nov 3 2021, 3:46 AM
ronlieb closed D112944: [zorg] Add Experimental Buildbot for OpenMP on AMDGPU.
Nov 3 2021, 3:46 AM

Oct 26 2021

ronlieb committed rGbe03ef3ed1d1: [openmp][lit] Add support to OpenMP lit.cfg for ROCR_VISIBLE_DEVICES env-var (authored by ronlieb).
[openmp][lit] Add support to OpenMP lit.cfg for ROCR_VISIBLE_DEVICES env-var
Oct 26 2021, 6:47 AM
ronlieb closed D112503: [openmp][lit] Add support to OpenMP lit.cfg for ROCR_VISIBLE_DEVICES env-var.
Oct 26 2021, 6:47 AM · Restricted Project

Oct 25 2021

ronlieb requested review of D112503: [openmp][lit] Add support to OpenMP lit.cfg for ROCR_VISIBLE_DEVICES env-var.
Oct 25 2021, 7:00 PM · Restricted Project
ronlieb added a comment to D108488: [OpenMP] [test] Fix intermittent omp_get_wtime.c test failures.

simpler approach like flang per MKruse does seem more attractive for this test. agree.

Oct 25 2021, 5:23 AM · Restricted Project

Oct 9 2021

ronlieb committed rGd022f39d9fa0: [libomptarget][amdgpu][NFC] tweak a comment (authored by ronlieb).
[libomptarget][amdgpu][NFC] tweak a comment
Oct 9 2021, 9:52 AM
ronlieb committed rZORG53501e40a871: Revert "[builder][amdgpu][openmp] disable use of ccache for now" (authored by ronlieb).
Revert "[builder][amdgpu][openmp] disable use of ccache for now"
Oct 9 2021, 4:37 AM
ronlieb added a reverting change for rZORG856646ccf14e: [builder][amdgpu][openmp] disable use of ccache for now: rZORG53501e40a871: Revert "[builder][amdgpu][openmp] disable use of ccache for now".
Oct 9 2021, 4:37 AM
ronlieb committed rZORG856646ccf14e: [builder][amdgpu][openmp] disable use of ccache for now (authored by ronlieb).
[builder][amdgpu][openmp] disable use of ccache for now
Oct 9 2021, 3:30 AM

Oct 7 2021

ronlieb committed rZORGf9363c718f8a: [builder][amdgpu] remove one builder - project, keep builder runtime (authored by ronlieb).
[builder][amdgpu] remove one builder - project, keep builder runtime
Oct 7 2021, 5:24 PM
ronlieb closed D111305: [builder][amdgpu] remove one builder - project, keep builder - runtime.
Oct 7 2021, 5:24 PM
ronlieb requested review of D111305: [builder][amdgpu] remove one builder - project, keep builder - runtime.
Oct 7 2021, 4:58 AM

Sep 28 2021

ronlieb added a comment to D102107: [OpenMP] Codegen aggregate for outlined function captures.

i backed up to your reverted patch, and applied this one.
I see some new errors

Sep 28 2021, 12:50 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ronlieb updated subscribers of D102107: [OpenMP] Codegen aggregate for outlined function captures.

[AMD Official Use Only]

Sep 28 2021, 11:15 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 27 2021

ronlieb updated subscribers of D110429: [OpenMP] Introduce a new worksharing RTL function for distribute.

[AMD Official Use Only]

Sep 27 2021, 9:11 AM · Restricted Project, Restricted Project
ronlieb added a comment to D110429: [OpenMP] Introduce a new worksharing RTL function for distribute.

looks like subsequent builders passed. we might have an issue where the runtime was not fully built when the test ran.
please disregard , your patch is fine.

Sep 27 2021, 9:05 AM · Restricted Project, Restricted Project
ronlieb added a comment to D110429: [OpenMP] Introduce a new worksharing RTL function for distribute.

lld: error: undefined symbol: __kmpc_distribute_static_init_4

referenced by /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(omp_outlined)
referenced by /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(omp_outlined)

lld: error: undefined symbol: __kmpc_distribute_static_fini

referenced by /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(omp_outlined)
referenced by /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(omp_outlined)
referenced by /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(__omp_outlined__.1)
referenced 1 more times

clang-14: error: amdgcn-link command failed with exit code 1 (use -v to see invocation)

Sep 27 2021, 9:03 AM · Restricted Project, Restricted Project
ronlieb added a comment to D110429: [OpenMP] Introduce a new worksharing RTL function for distribute.

apologies, that pasted very poorly ...

Sep 27 2021, 9:02 AM · Restricted Project, Restricted Project
ronlieb added a comment to D110429: [OpenMP] Introduce a new worksharing RTL function for distribute.

hi, we seem to have a link time error after this patch in our buildbot

Sep 27 2021, 9:01 AM · Restricted Project, Restricted Project

Sep 21 2021

ronlieb updated subscribers of D102107: [OpenMP] Codegen aggregate for outlined function captures.

@pdhaliwal
i will pass the problem over to Pushpinder Singh who should be waking up soon.

Sep 21 2021, 4:51 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project