Page MenuHomePhabricator

ronlieb (Ron Lieberman)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 24 2018, 5:18 PM (243 w, 5 d)

Recent Activity

Today

ronlieb accepted D146927: [OpenMP] Enable more tests.

i applied the patch to a gfx908 and a gfx906 system.
tests all passed , and the gfx906 should be the same as the amdgpu buildbot.

Sun, Mar 26, 5:07 PM · Restricted Project
ronlieb updated subscribers of D146927: [OpenMP] Enable more tests.

@doru1004 is interested in these tests being enabled.
thx for adding them.

Sun, Mar 26, 4:15 PM · Restricted Project

Fri, Mar 24

ronlieb added a comment to D146812: [OpenMP][libomptarget][NFC] Make private mapping test more explicit on failure.

In case folks are worried about this debug content:
this patch will have a short life span, once we see the dump from the BOT, we can revert it.

Fri, Mar 24, 8:35 AM · Restricted Project, Restricted Project
ronlieb added a comment to D146812: [OpenMP][libomptarget][NFC] Make private mapping test more explicit on failure.

when the test detects the error, can we dump out all the arrays data1, data2, data3, and sum . and then break ...

Fri, Mar 24, 7:39 AM · Restricted Project, Restricted Project

Thu, Mar 23

ronlieb accepted D146705: [OpenMP] Additional checks to AMDGPU OpenMP (experimetnal) buildbot.

LGTM

Thu, Mar 23, 3:54 AM · Restricted Project

Sat, Mar 18

ronlieb added a comment to D144503: [ADT] Allow `llvm::enumerate` to enumerate over multiple ranges.

also seeing similar error in downstream windows build of llvm.

Sat, Mar 18, 11:05 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 8

ronlieb added a comment to D145093: [OpenMP] Add map info for dereference pointer..

had not heard back , so reverted it for now
commit 8cf85a0cadb033fed3d96aa5283deb4bfbbaf2c8 (HEAD -> main, origin/main, origin/HEAD)
Author: Ron Lieberman <ron.lieberman@amd.com>
Date: Wed Mar 8 22:01:22 2023 -0600

Wed, Mar 8, 8:06 PM · Restricted Project, Restricted Project, Restricted Project
ronlieb added a reverting change for rG0f2f37842582: Add map info for dereference pointer.: rG8cf85a0cadb0: Revert "Add map info for dereference pointer.".
Wed, Mar 8, 8:06 PM · Restricted Project, Restricted Project, Restricted Project
ronlieb committed rG8cf85a0cadb0: Revert "Add map info for dereference pointer." (authored by ronlieb).
Revert "Add map info for dereference pointer."
Wed, Mar 8, 8:06 PM · Restricted Project, Restricted Project, Restricted Project
ronlieb added a reverting change for D145093: [OpenMP] Add map info for dereference pointer.: rG8cf85a0cadb0: Revert "Add map info for dereference pointer.".
Wed, Mar 8, 8:06 PM · Restricted Project, Restricted Project, Restricted Project
ronlieb added a comment to D145093: [OpenMP] Add map info for dereference pointer..

seems to fail amdgpu buildbot
https://lab.llvm.org/buildbot/#/builders/193/builds/27692

Wed, Mar 8, 6:06 PM · Restricted Project, Restricted Project, Restricted Project
ronlieb accepted D145572: [llvm][Uniformity] consistently handle uniform instructions.

LGTM, as this resolves our downstream assertions seen in our CI

Wed, Mar 8, 7:18 AM · Restricted Project, Restricted Project

Wed, Mar 1

ronlieb added a comment to D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause.

LIT Test ?

Wed, Mar 1, 1:32 PM · Restricted Project, Restricted Project

Feb 6 2023

ronlieb added a comment to D143401: [OpenMP][libomp] Remove false positive for memory sanitizer.

i reverted to unblock our bot

Feb 6 2023, 11:19 AM · Restricted Project, Restricted Project
ronlieb added a reverting change for rG402981ee25fe: [OpenMP][libomp] Remove false positive for memory sanitizer: rGc55d6f169b8b: Revert "[OpenMP][libomp] Remove false positive for memory sanitizer".
Feb 6 2023, 11:19 AM · Restricted Project, Restricted Project
ronlieb committed rGc55d6f169b8b: Revert "[OpenMP][libomp] Remove false positive for memory sanitizer" (authored by ronlieb).
Revert "[OpenMP][libomp] Remove false positive for memory sanitizer"
Feb 6 2023, 11:19 AM · Restricted Project, Restricted Project
ronlieb added a reverting change for D143401: [OpenMP][libomp] Remove false positive for memory sanitizer: rGc55d6f169b8b: Revert "[OpenMP][libomp] Remove false positive for memory sanitizer".
Feb 6 2023, 11:19 AM · Restricted Project, Restricted Project
ronlieb added a comment to D143401: [OpenMP][libomp] Remove false positive for memory sanitizer.

Hi Jonathon,
our amdgpu buildbot seems to have been broken by this patch
https://lab.llvm.org/buildbot/#/builders/193/builds/26173
could you fix quickly? or revert and fix ?

Feb 6 2023, 10:33 AM · Restricted Project, Restricted Project

Feb 3 2023

ronlieb added a comment to D140242: [AMDGPU] Modify adjustInliningThreshold to also consider the cost of passing function arguments through the stack.

Hi Janek, seeing buildbot failures: https://lab.llvm.org/buildbot/#/builders/193/builds/26047

Feb 3 2023, 10:20 AM · Restricted Project, Restricted Project

Jan 30 2023

ronlieb committed rZORG195338a7a5a3: correct spellinf of -DLIBOMPTARGET_FOUND_AMDGPU_GPU (authored by ronlieb).
correct spellinf of -DLIBOMPTARGET_FOUND_AMDGPU_GPU
Jan 30 2023, 8:08 PM · Restricted Project
ronlieb committed rZORG1e5b8c438e48: amdgpu experimental bbot: add -DCMAKE_LIBOMPTARGET_FOUND_AMDGPU_GPU=ON (authored by ronlieb).
amdgpu experimental bbot: add -DCMAKE_LIBOMPTARGET_FOUND_AMDGPU_GPU=ON
Jan 30 2023, 4:45 PM · Restricted Project

Jan 21 2023

ronlieb added a comment to D141232: [OpenMP] Modernize the kernel launching interface and APIs.

hi, breaks our amdgpu buildbot, please fix ASAP , or revert and fix. thx
3 patches: https://lab.llvm.org/buildbot/#/builders/193/builds/25299

Jan 21 2023, 12:59 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 15 2023

ronlieb added a comment to D133574: [C2x] reject type definitions in offsetof.

our nekbone app is failing from this patch.

Jan 15 2023, 6:26 PM · Restricted Project, Restricted Project

Jan 9 2023

ronlieb committed rGd179dfe8cee1: fix : add missing open brace [OpenMP][FIX] Avoid using an Error object after a… (authored by ronlieb).
fix : add missing open brace [OpenMP][FIX] Avoid using an Error object after a…
Jan 9 2023, 4:52 PM · Restricted Project, Restricted Project

Jan 3 2023

ronlieb accepted D140910: [OpenMP][Fix] Use type promotion legacy pass.

Thanks DOru, looks way better than my botched commit

Jan 3 2023, 10:32 AM · Restricted Project, Restricted Project
ronlieb added a comment to D140893: [TypePromotion] NewPM support..

sorry about that, reverted.
will push a different fix now.

Jan 3 2023, 10:27 AM · Restricted Project, Restricted Project
ronlieb added a reverting change for rG135f6a1ee8b2: [libomptarget][plugin-nextgen] fix for [TypePromotion] NewPM support.: rG750e1c8dbd93: Revert "[libomptarget][plugin-nextgen] fix for [TypePromotion] NewPM support.".
Jan 3 2023, 10:27 AM · Restricted Project, Restricted Project, Restricted Project
ronlieb committed rG750e1c8dbd93: Revert "[libomptarget][plugin-nextgen] fix for [TypePromotion] NewPM support." (authored by ronlieb).
Revert "[libomptarget][plugin-nextgen] fix for [TypePromotion] NewPM support."
Jan 3 2023, 10:27 AM · Restricted Project, Restricted Project, Restricted Project
ronlieb added a comment to D140893: [TypePromotion] NewPM support..

it does look simple :-) i pushed in a fix a while ago, (hour or so)

Jan 3 2023, 10:17 AM · Restricted Project, Restricted Project
ronlieb committed rG135f6a1ee8b2: [libomptarget][plugin-nextgen] fix for [TypePromotion] NewPM support. (authored by ronlieb).
[libomptarget][plugin-nextgen] fix for [TypePromotion] NewPM support.
Jan 3 2023, 9:04 AM · Restricted Project, Restricted Project, Restricted Project
ronlieb added a comment to D140893: [TypePromotion] NewPM support..

hi . bbot failure related to this patch https://lab.llvm.org/buildbot/#/builders/193/builds/24271

Jan 3 2023, 7:34 AM · Restricted Project, Restricted Project

Jan 2 2023

ronlieb accepted D140837: [AAPointerInfo] fix assertion at the pass-through use of a pointer.

lgtm, passed the 5 internal tests that failed.

Jan 2 2023, 10:05 AM · Restricted Project, Restricted Project
Herald added a project to D112680: [OpenMP] Lower printf to __llvm_omp_vprintf: Restricted Project.

@JonChesterfield i am seeing the testcase bug50022.cpp occasionally randomly failing in amdgpu bbot
most recently: https://lab.llvm.org/buildbot/#/builders/193/builds/24230

Jan 2 2023, 7:08 AM · Restricted Project, Restricted Project, Restricted Project

Dec 27 2022

ronlieb added a comment to D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading.

seems like this broke the amdgpu buildbot , plz resolve
https://lab.llvm.org/buildbot/#/builders/193/builds/24122

Dec 27 2022, 6:50 PM · Restricted Project, Restricted Project, Restricted Project

Dec 24 2022

ronlieb committed rZORG8a912708050b: [bbot][amdgpu][openmp] experimental: checkAll (authored by ronlieb).
[bbot][amdgpu][openmp] experimental: checkAll
Dec 24 2022, 6:53 AM · Restricted Project

Dec 23 2022

ronlieb committed rZORGd8256b1fd25b: [bbot][amdgpu][openmp] experimental: run all checks (authored by ronlieb).
[bbot][amdgpu][openmp] experimental: run all checks
Dec 23 2022, 9:52 AM · Restricted Project

Dec 19 2022

ronlieb added a comment to D140334: [OpenMP] Rename the `_OMP` namespace in the device runtime to `ompx`.

Hi, amdgpu buildbot failing this test after this patch landed

libomptarget :: amdgcn-amd-amdhsa :: api/omp_dynamic_shared_memory_amdgpu.c
Dec 19 2022, 4:01 PM · Restricted Project, Restricted Project

Dec 15 2022

ronlieb updated subscribers of D135462: [SelectionDAG] Do not second-guess alignment for alloca.

@jhuber6 please help with this one ? thanks

Dec 15 2022, 11:21 AM · Restricted Project, Restricted Project
ronlieb added a reverting change for rGffedf47d8b79: [SelectionDAG] Do not second-guess alignment for alloca: rG38f1abef8604: Revert "[SelectionDAG] Do not second-guess alignment for alloca".
Dec 15 2022, 8:56 AM · Restricted Project, Restricted Project
ronlieb committed rG38f1abef8604: Revert "[SelectionDAG] Do not second-guess alignment for alloca" (authored by ronlieb).
Revert "[SelectionDAG] Do not second-guess alignment for alloca"
Dec 15 2022, 8:56 AM · Restricted Project, Restricted Project
ronlieb added a reverting change for D135462: [SelectionDAG] Do not second-guess alignment for alloca: rG38f1abef8604: Revert "[SelectionDAG] Do not second-guess alignment for alloca".
Dec 15 2022, 8:55 AM · Restricted Project, Restricted Project
ronlieb added a comment to D135462: [SelectionDAG] Do not second-guess alignment for alloca.

hello , this commit is breaking our buildbot : could you address please ? https://lab.llvm.org/buildbot/#/builders/193

Dec 15 2022, 8:18 AM · Restricted Project, Restricted Project

Dec 8 2022

ronlieb added a comment to D135402: [LLD] Enable --no-undefined-version by default..

this patch when applied on top of a previous successful build, passes.
however, if i start with a fresh build directory and cmake/build it fails.
normally our amdgpu buildbot would not notice.

buildbot https://lab.llvm.org/staging/#/builders/183/builds/2704

unfortunately our buildbot died 3-4 days ago, and had to be reimaged yesterday and is still in staging.
when i restarted the buildbot yesterday it picked up this change and started failing.
I am not sure why patch from JPeyton did not resovle this. looking into... @jhuber6 ?

Joseph Huber pushed in a fix that gets our bot to go green. thx
[OpenMP][libomp] Fix version scripts after undefined version script changes

Dec 8 2022, 10:48 AM · Restricted Project, Restricted Project
ronlieb added a comment to D135402: [LLD] Enable --no-undefined-version by default..

this patch when applied on top of a previous successful build, passes.
however, if i start with a fresh build directory and cmake/build it fails.
normally our amdgpu buildbot would not notice.

buildbot https://lab.llvm.org/staging/#/builders/183/builds/2704
Dec 8 2022, 4:48 AM · Restricted Project, Restricted Project

Dec 4 2022

ronlieb committed rZORGcad6da1bcc99: Disable sollve: to make openmp-offload-amdgpu-runtime more like openmp-offload… (authored by ronlieb).
Disable sollve: to make openmp-offload-amdgpu-runtime more like openmp-offload…
Dec 4 2022, 6:45 PM · Restricted Project

Nov 29 2022

ronlieb added a reverting change for rGd882ba7aeac4: enable code-object-version=5: rGca856fff1c0f: Revert "enable code-object-version=5".
Nov 29 2022, 1:22 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ronlieb committed rGca856fff1c0f: Revert "enable code-object-version=5" (authored by ronlieb).
Revert "enable code-object-version=5"
Nov 29 2022, 1:22 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ronlieb added a reverting change for rG0b9350f3da7d: Add mean_anyway to hpc config: rGb09a5e5cb380: Revert "Add mean_anyway to hpc config".
Nov 29 2022, 1:21 PM · Restricted Project, Restricted Project
ronlieb committed rGb09a5e5cb380: Revert "Add mean_anyway to hpc config" (authored by ronlieb).
Revert "Add mean_anyway to hpc config"
Nov 29 2022, 1:21 PM · Restricted Project, Restricted Project
ronlieb committed rG0b9350f3da7d: Add mean_anyway to hpc config (authored by ronlieb).
Add mean_anyway to hpc config
Nov 29 2022, 1:12 PM · Restricted Project, Restricted Project
ronlieb committed rGd882ba7aeac4: enable code-object-version=5 (authored by ronlieb).
enable code-object-version=5
Nov 29 2022, 1:12 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ronlieb added a comment to D138555: Cache memory buffer's name length.

also breaks amdgpu hip and openmp buildbots

Nov 29 2022, 5:27 AM · Restricted Project, Restricted Project

Nov 28 2022

ronlieb committed rGa1066569b827: [check-openmp] fix bug49334 bot fails - temporary (authored by ronlieb).
[check-openmp] fix bug49334 bot fails - temporary
Nov 28 2022, 5:11 PM · Restricted Project, Restricted Project

Nov 16 2022

ronlieb requested changes to D129818: AMDGPU: Make default AMDHSA Code Object Version to be 5.

lets hold off landing for a few more days?
checking some internal related testing results

Nov 16 2022, 3:46 PM · Restricted Project, Restricted Project

Nov 15 2022

ronlieb added a comment to D138049: [OpenMP][libomp] Cleanup version script and exported symbols.

i applied the lld patch https://reviews.llvm.org/D135402 and this one, then ran the equivalent of our buildbot, all good, builds and passes.

Nov 15 2022, 2:46 PM · Restricted Project, Restricted Project

Nov 14 2022

ronlieb added a comment to D137915: [LegacyPM] Remove cl::opts controlling optimization pass manager passes.

thx for quick fix, much appreciated. love the color green!

Nov 14 2022, 9:50 AM · Restricted Project, Restricted Project
ronlieb added a comment to D137915: [LegacyPM] Remove cl::opts controlling optimization pass manager passes.

hello, couple of our bots broke:
amdgpu hip bot:
https://lab.llvm.org/buildbot/#/builders/165/builds/25535

Nov 14 2022, 9:44 AM · Restricted Project, Restricted Project

Nov 11 2022

ronlieb committed rG2f1c942f806e: for Vignesh: land changes to disable two recent ompd random fails (authored by ronlieb).
for Vignesh: land changes to disable two recent ompd random fails
Nov 11 2022, 5:12 AM · Restricted Project, Restricted Project
ronlieb closed D137831: Fix Configuration and test failures due to libompd test.
Nov 11 2022, 5:12 AM · Restricted Project, Restricted Project
ronlieb accepted D137831: Fix Configuration and test failures due to libompd test.
Nov 11 2022, 4:59 AM · Restricted Project, Restricted Project
Herald added a project to D100181: [OpenMP] [OMPD] [1/6] Implementation of OMPD debugging library - libompd. Code changes in openmp/runtime to support libompd.: Restricted Project.

I am seeing intermittent failures with the new test case on our amdgpu buildbot

FAIL: ompd-test::ompd_parallel.c
Nov 11 2022, 2:27 AM · Restricted Project, Restricted Project

Nov 9 2022

ronlieb added a comment to D135402: [LLD] Enable --no-undefined-version by default..

Please revert this change, so our bots can go green.
we are struggling to figure out how to fix openmp/runtime

Nov 9 2022, 3:56 AM · Restricted Project, Restricted Project

Nov 7 2022

ronlieb added a comment to D135402: [LLD] Enable --no-undefined-version by default..

my build systems have ROCm installed, which might make a difference.
since i can reproduce the issue locally

ld.lld: error: openmp/runtime/src/CMakeFiles/omp.dir/kmp_csupport.cpp.o: symbol ompc_set_affinity_format@@VERSION has undefined version VERSION
Nov 7 2022, 5:00 PM · Restricted Project, Restricted Project
ronlieb added a comment to D135402: [LLD] Enable --no-undefined-version by default..

This cmake recipe reproduces issue for me:

Nov 7 2022, 4:33 PM · Restricted Project, Restricted Project
ronlieb added a comment to D135402: [LLD] Enable --no-undefined-version by default..

https://lab.llvm.org/buildbot/#/builders/193/builds/21412

Nov 7 2022, 2:31 PM · Restricted Project, Restricted Project
ronlieb added a comment to D135402: [LLD] Enable --no-undefined-version by default..

amdgpu buildbot sees issues.

Nov 7 2022, 2:28 PM · Restricted Project, Restricted Project

Nov 4 2022

ronlieb added a comment to D137313: [NFC] Remove redundant loads when has_device_addr is used..

[AMD Official Use Only - General]

Nov 4 2022, 4:27 PM · Restricted Project, Restricted Project, Restricted Project

Oct 14 2022

ronlieb updated subscribers of D133145: Use u16 to store Count/MaxCount.

we are seeing the same issue compiling compiler-rt with these patches in trunk, are the various buildbots catching this also?
for awareness: @saiislam

Oct 14 2022, 4:10 AM · Restricted Project, Restricted Project

Oct 13 2022

ronlieb added a comment to D135402: [LLD] Enable --no-undefined-version by default..

hi, our amdgpu buildbot which uses lld has been failing since this commit landed
https://lab.llvm.org/buildbot/#/builders/193/builds/20055

Oct 13 2022, 4:03 AM · Restricted Project, Restricted Project

Oct 6 2022

ronlieb added a comment to D135107: [clang][NFC] Use enum for -fstrict-flex-arrays.

hi, seeing our amdgpu buildbot broken with this patch. please look into ?
let me know if you any help on our end.
https://lab.llvm.org/buildbot/#/builders/193/builds/19744

Oct 6 2022, 11:06 AM · Restricted Project, Restricted Project

Sep 22 2022

ronlieb accepted D134459: [OpenMP][NFC] Fix wavesize build warning in OMPGridValues.

LGTM

Sep 22 2022, 10:53 AM · Restricted Project, Restricted Project

Sep 19 2022

ronlieb added a reverting change for rG684f766431f3: [Clang][OpenMP] Codegen generation for has_device_addr claues.: rGd5b5289561a3: revert 684f76643 [Clang][OpenMP] Codegen generation for has_device_addr claues..
Sep 19 2022, 6:38 PM · Restricted Project, Restricted Project, Restricted Project
ronlieb committed rGd5b5289561a3: revert 684f76643 [Clang][OpenMP] Codegen generation for has_device_addr claues. (authored by ronlieb).
revert 684f76643 [Clang][OpenMP] Codegen generation for has_device_addr claues.
Sep 19 2022, 6:38 PM · Restricted Project, Restricted Project, Restricted Project
ronlieb added a reverting change for D134186: [Clang][OpenMP] Codegen generation for has_device_addr claues.: rGd5b5289561a3: revert 684f76643 [Clang][OpenMP] Codegen generation for has_device_addr claues..
Sep 19 2022, 6:38 PM · Restricted Project, Restricted Project, Restricted Project
ronlieb added a comment to D134186: [Clang][OpenMP] Codegen generation for has_device_addr claues..

seeing a buildbot failure on amdgpu bot
https://lab.llvm.org/buildbot/#/builders/193/builds/18788

Sep 19 2022, 4:34 PM · Restricted Project, Restricted Project, Restricted Project

Sep 8 2022

ronlieb added a comment to D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar.

emailed a hopeful reproducer to you

Sep 8 2022, 3:35 PM · Restricted Project, Restricted Project
ronlieb added a comment to D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar.

hopefully will fix this ?
invalid cast kind for complex value
UNREACHABLE executed at /clang/lib/AST/ExprConstant.cpp:14263!
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and as
sociated run script.

Sep 8 2022, 3:20 PM · Restricted Project, Restricted Project
ronlieb added a comment to D111509: [clang] use getCommonSugar in an assortment of places.

i am seeing similar issues in openmp buildbot failing with this patch

Sep 8 2022, 1:33 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 7 2022

ronlieb added a comment to D132408: [SimplifyCFG] accumulate bonus insts cost.

Do you have any numbers for the impact of this change? I suspect (but haven't checked) that it may be quite significant, because the current tiny bonus inst threshold (1) is tuned for the current implementation, and this patch will result in much less common dest folding than would be desirable.

For a synthetic benchmark geared towards loops with small workloads, we saw around 16% performance gain due to avoiding always executing 31 extra load instructions by not folding 31 basic blocks coming from an unrolled loop.

For typical HIP programs, I did not see significant performance differences before and after this change. This is because the original bonus instruction threshold 2 is very small. It only allows folding small basic blocks which only contain one instruction other than the cmp/branch instructions. In practical applications, such basic blocks are rare and usually are not performance bottlenecks. Only in special situations (e.g. a fully unrolled loop of large loop counts ends up with a large number of foldable basic blocks) the performance penalty becomes significant.

I am not sure what typical HIP programs mean here. Did you measure the impact on general CPU benchmarks?

No. Can you recommend a free CPU benchmark that is suitable for this purpose? Thanks.

I will try running the SPEC CPU benchmark. There are many sub-tests. Do you recommend any sub-tests that are most relevant to this patch? Thanks.

For SPEC, I usually run SPEC2017rate (both integer and fp subsets).

Sep 7 2022, 6:42 AM · Restricted Project, Restricted Project

Sep 5 2022

ronlieb added a comment to D133081: [libc++] Granularize __tuple.

seeing buildbot failures on hip, not sure if this patch caused it

Sep 5 2022, 8:27 AM · Restricted Project, Restricted Project

Aug 9 2022

ronlieb committed rG9ff0cc7e0fa7: [openmp] Fix enumeration build issue for openmp library (authored by ronlieb).
[openmp] Fix enumeration build issue for openmp library
Aug 9 2022, 3:27 AM · Restricted Project, Restricted Project
ronlieb closed D131477: [openmp] Fix enumeration build issue for openmp library .
Aug 9 2022, 3:27 AM · Restricted Project, Restricted Project
ronlieb requested review of D131477: [openmp] Fix enumeration build issue for openmp library .
Aug 9 2022, 3:03 AM · Restricted Project, Restricted Project

Aug 8 2022

ronlieb added a comment to D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values.

thanks for the analysis , i agree its a coding error in our library.

Aug 8 2022, 5:43 PM · Restricted Project, Restricted Project
ronlieb added a comment to D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values.

hi, latest commit seems to have broken buildbot for amdgpu
https://lab.llvm.org/buildbot/#/builders/193/builds/16651

Aug 8 2022, 4:35 PM · Restricted Project, Restricted Project
ronlieb committed rGaf28b27d31a5: Move openmp from -std=c++14 to -std=c++17 (authored by ronlieb).
Move openmp from -std=c++14 to -std=c++17
Aug 8 2022, 9:05 AM · Restricted Project, Restricted Project

Aug 5 2022

ronlieb updated subscribers of D131259: [libomptarget][amdgpu] fix memory leak in find_metadata.

@FabioLuporini might find this interesting, memory leak.

Aug 5 2022, 7:07 AM · Restricted Project

Aug 4 2022

ronlieb added a comment to D131182: [OpenMP][DeviceRTL] Implement libc function `memcmp`.

Will push a change to fix the printf issue on AMDGPU.

Aug 4 2022, 11:46 AM · Restricted Project, Restricted Project

Jul 30 2022

ronlieb accepted D130789: [Libomptarget] Disable testing map_back_race.cpp.
Jul 30 2022, 11:31 AM · Restricted Project, Restricted Project

Jul 22 2022

ronlieb added a reverting change for rG3e8d46921fbc: [Libomptarget] Stop testing CPU offloading with LTO: rG45a379ce2ff4: Revert "[Libomptarget] Stop testing CPU offloading with LTO".
Jul 22 2022, 5:11 AM · Restricted Project, Restricted Project
ronlieb committed rG45a379ce2ff4: Revert "[Libomptarget] Stop testing CPU offloading with LTO" (authored by ronlieb).
Revert "[Libomptarget] Stop testing CPU offloading with LTO"
Jul 22 2022, 5:11 AM · Restricted Project, Restricted Project

Jun 2 2022

ronlieb accepted D126906: AMDGPU: Move SpilledReg from MFI to SIRegisterInfo.

thx for fix.

Jun 2 2022, 1:44 PM · Restricted Project, Restricted Project

May 8 2022

ronlieb added a comment to D115750: [SLP]Further improvement of the cost model for scalars used in buildvectors..

i am seeing the same assert on the amdgpu target

May 8 2022, 8:32 PM · Restricted Project, Restricted Project

May 6 2022

ronlieb added a comment to D122614: [CMake][libcxx] Use target_include_directories for libc++ headers.

Hi Peter

May 6 2022, 9:57 PM · Restricted Project, Restricted Project, Restricted Project

Apr 5 2022

ronlieb updated subscribers of D120662: [clang-offload-bundler] add -input/-output options.

@saiislam for awareness

Apr 5 2022, 5:15 AM · Restricted Project, Restricted Project

Apr 2 2022

ronlieb added a comment to rGcc2139524f77: [AMDPU][Sanitizer] Refactor sanitizer options handling for AMDGPU Toolchain.

i forwarded a couple buildbot failures to Amit to look into

Apr 2 2022, 6:29 AM · Restricted Project, Restricted Project
ronlieb added a reverting change for rGcc2139524f77: [AMDPU][Sanitizer] Refactor sanitizer options handling for AMDGPU Toolchain: rGf1e7ecaa18a7: Revert "[AMDPU][Sanitizer] Refactor sanitizer options handling for AMDGPU….
Apr 2 2022, 6:27 AM · Restricted Project, Restricted Project
ronlieb committed rGf1e7ecaa18a7: Revert "[AMDPU][Sanitizer] Refactor sanitizer options handling for AMDGPU… (authored by ronlieb).
Revert "[AMDPU][Sanitizer] Refactor sanitizer options handling for AMDGPU…
Apr 2 2022, 6:27 AM · Restricted Project, Restricted Project
ronlieb added a reverting change for D122781: Refactor sanitizer options handling for AMDGPU Toolchain: rGf1e7ecaa18a7: Revert "[AMDPU][Sanitizer] Refactor sanitizer options handling for AMDGPU….
Apr 2 2022, 6:27 AM · Restricted Project, Restricted Project
ronlieb added a comment to D122781: Refactor sanitizer options handling for AMDGPU Toolchain.

i pushed it in. will watch for build bot issues

Apr 2 2022, 4:03 AM · Restricted Project, Restricted Project