User Details
- User Since
- May 29 2015, 9:24 AM (364 w, 3 d)
Apr 12 2022
LGTM, thanks for this.
Feb 18 2022
Feb 16 2022
Replace list of shadow pointer to be restored with simple synchronization.
Dec 17 2021
It looks like https://reviews.llvm.org/D115823 will take a bit longer to be merged. I will merge this in to fix the API error, as it can go in first.
Dec 16 2021
Add context.
LGTM
Dec 15 2021
Dec 14 2021
Dec 10 2021
Trying rebase again.
rebase onto main
Dec 9 2021
[OpenMP][NFC] Apply requested change: remove "nowait" from function name.
Add context (sorry about that!)
Dec 8 2021
[OpenMP] Add missing hsa declarations/definitions when building runtime without rocr (or hsa library) installed on the system
Dec 7 2021
@JonChesterfield thanks for the quick review. Would you mind merging this for me?
format
@JonChesterfield this looks more readable as a first step.
Abandoning this one for readability issues and moving to two separate patches.
First one:
https://reviews.llvm.org/D115267
Nov 17 2021
This is already a lot of code with parse+sema. I wonder if we should split the patch into two, i.e. 1. parse+sema; 2. code gen? @ABataev ?
It should simplify maintenance of the patch and allow time to extend the OpenMP IR builder.
Nov 3 2021
LGTM
Oct 25 2021
Oct 15 2021
Thanks for fixing this. It would be nice if you could add a comment where it is used at the beginning of parallel_51, stating what are the initial value of parallelLevel (kmpc_parallel_level) and those of kmpc_is_spmd_exec_mode in the two cases of generic and spmd modes (assuming generic spmd mode is handled as a spmd). Something like:
Oct 7 2021
Thanks for this. Do you think this could use a test?
I assume a test would be easier to write once this information is used somewhere, but it's hard to tell without context.
Sep 30 2021
LGTM
Sep 20 2021
Updated patch based on comments: add new map table entry field to track USM maps; use it to determine behavior in getTargetPointer and deallocTgtPtr; update var name and add explaining comments.
Sep 17 2021
Aug 26 2021
Thanks for uploading this.
Aug 23 2021
Update environment variable name to reflect comments and intended name
Jul 6 2021
I have very small comments. LGTM.
Jun 14 2021
@ABataev can you please merge this for me? I still have to ask for commit privileges.
[OpenMP] Add test for C language of target uses_allocators clause
Jun 8 2021
Ah! I forgot to add a reference to a filed bugzilla:
https://bugs.llvm.org/show_bug.cgi?id=50619
Feb 27 2018
Feb 22 2018
[OpenMP] Add regression test: this verifies that only one call to the runtime for reduction is done in a combined construct with distribute, without simd, and with at least one pragma accepting reduction as a clause.
Feb 20 2018
Feb 1 2018
That's correct, debug printfs were reporting zero threads to be used in SPMD region instead of the actual number used.
Jan 31 2018
Jan 3 2018
Committed revision 321759.
Dec 4 2017
Committed revision 319696.
Nov 20 2017
Committed revision 318692.
Nov 17 2017
Nov 10 2017
Committed revision 317893.
Oct 4 2017
Committed revision 314905.
Sep 28 2017
May 3 2017
Committed revision 302031.
Apr 25 2017
Re-Committed revision 301340.
Apr 24 2017
Committed revision 301223.
[OpenMP] Refactor after split of original patch in two patches (sema and cg). Transform lambdas to static functions, where possible, define default constructors, format, and update against trunk.
Apr 19 2017
Committed revision 300802.
Apr 7 2017
Also reported by bbot slave:
Feb 17 2017
Committed revision r295497
Feb 15 2017
Address comments on initial patch after splitting. Added a dependency with sema patch.
About this:
Feb 13 2017
Feb 7 2017
I will split this patch into smaller patches, but I will keep this open in case I need to refer back to it: some of the changes that can go into independent patches require a justification and this patch shows it.
Thanks for your comments!
[OpenMP] Updating the patch to show full context
Feb 6 2017
Committed revision r294195
Feb 3 2017
Committed to r294026
Jan 31 2017
Jan 3 2017
Commited r290898.
Jul 13 2016
Committed revision 275282.
Committed revision 275271.
Jul 12 2016
[OpenMP] Add regression test for ast, remove 'brief's, and rebase.
[OpenMP] Add regression test to check correctness of ast building, remove 'brief's, and rebase.
Jul 11 2016
[OpenMP] Remove generation of capture (move to codegen) and rebase.