Page MenuHomePhabricator

carlo.bertolli (Carlo Bertolli)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2015, 9:24 AM (211 w, 2 d)

Recent Activity

Feb 27 2018

carlo.bertolli created D43852: [OpenMP] Extend NVPTX SPMD implementation of combined constructs.
Feb 27 2018, 6:47 PM

Feb 22 2018

carlo.bertolli updated the diff for D43513: [OpenMP] Limit reduction support for pragma 'distribute' when combined with pragma 'simd'.

[OpenMP] Add regression test: this verifies that only one call to the runtime for reduction is done in a combined construct with distribute, without simd, and with at least one pragma accepting reduction as a clause.

Feb 22 2018, 8:01 AM

Feb 20 2018

carlo.bertolli created D43513: [OpenMP] Limit reduction support for pragma 'distribute' when combined with pragma 'simd'.
Feb 20 2018, 9:02 AM

Feb 1 2018

carlo.bertolli closed D42757: [OpenMP-RT] Fix debug string for NVPTX runtime library.

That's correct, debug printfs were reporting zero threads to be used in SPMD region instead of the actual number used.

Feb 1 2018, 8:16 AM

Jan 31 2018

carlo.bertolli created D42757: [OpenMP-RT] Fix debug string for NVPTX runtime library.
Jan 31 2018, 12:10 PM

Jan 3 2018

carlo.bertolli closed D41709: [OpenMP] Initial implementation of code generation for pragma 'target teams distribute parallel for' on host.

Committed revision 321759.

Jan 3 2018, 1:13 PM
carlo.bertolli created D41709: [OpenMP] Initial implementation of code generation for pragma 'target teams distribute parallel for' on host.
Jan 3 2018, 12:59 PM

Dec 4 2017

carlo.bertolli closed D40795: [OpenMP] Initial implementation of code generation for pragma 'teams distribute parallel for simd' on host.

Committed revision 319696.

Dec 4 2017, 12:57 PM
carlo.bertolli created D40795: [OpenMP] Initial implementation of code generation for pragma 'teams distribute parallel for simd' on host.
Dec 4 2017, 10:40 AM

Nov 20 2017

carlo.bertolli closed D40187: [OpenMP] Initial implementation of code generation for pragma 'teams distribute parallel for' on host.

Committed revision 318692.

Nov 20 2017, 3:55 PM

Nov 17 2017

carlo.bertolli created D40187: [OpenMP] Initial implementation of code generation for pragma 'teams distribute parallel for' on host.
Nov 17 2017, 10:28 AM
carlo.bertolli updated subscribers of D40187: [OpenMP] Initial implementation of code generation for pragma 'teams distribute parallel for' on host.
Nov 17 2017, 10:28 AM

Nov 10 2017

carlo.bertolli closed D39902: [OpenMP] Parse+Sema for copyin clause of 'teams distribute parallel for'.

Committed revision 317893.

Nov 10 2017, 8:06 AM
carlo.bertolli created D39902: [OpenMP] Parse+Sema for copyin clause of 'teams distribute parallel for'.
Nov 10 2017, 7:53 AM

Oct 4 2017

carlo.bertolli closed D38371: [OpenMP] Initial implementation of teams distribute code generation.

Committed revision 314905.

Oct 4 2017, 7:14 AM

Sep 28 2017

carlo.bertolli created D38371: [OpenMP] Initial implementation of teams distribute code generation.
Sep 28 2017, 10:58 AM

May 3 2017

carlo.bertolli closed D32807: [OpenMP] Extended parse for 'always' map modifier.

Committed revision 302031.

May 3 2017, 8:42 AM
carlo.bertolli created D32807: [OpenMP] Extended parse for 'always' map modifier.
May 3 2017, 8:20 AM

Apr 25 2017

carlo.bertolli added a comment to D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host.

Re-Committed revision 301340.

Apr 25 2017, 11:05 AM

Apr 24 2017

carlo.bertolli closed D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host.

Committed revision 301223.

Apr 24 2017, 12:39 PM
carlo.bertolli updated the summary of D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host.
Apr 24 2017, 10:39 AM
carlo.bertolli updated the diff for D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host.

[OpenMP] Refactor after split of original patch in two patches (sema and cg). Transform lambdas to static functions, where possible, define default constructors, format, and update against trunk.

Apr 24 2017, 8:54 AM

Apr 19 2017

carlo.bertolli closed D32237: [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for.

Committed revision 300802.

Apr 19 2017, 5:54 PM
carlo.bertolli added a child revision for D32237: [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for: D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host.
Apr 19 2017, 12:03 PM
carlo.bertolli added a parent revision for D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host: D32237: [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for.
Apr 19 2017, 12:03 PM
carlo.bertolli updated subscribers of D32237: [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for.
Apr 19 2017, 12:02 PM
carlo.bertolli created D32237: [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for.
Apr 19 2017, 12:02 PM

Apr 7 2017

carlo.bertolli added a comment to D31811: [compiler-rt] Add virtual destructor to base class to avoid warning.

Also reported by bbot slave:

Apr 7 2017, 8:31 AM
carlo.bertolli created D31811: [compiler-rt] Add virtual destructor to base class to avoid warning.
Apr 7 2017, 8:29 AM

Feb 17 2017

carlo.bertolli closed D29922: [OpenMP] Prepare Sema for initial implementation for pragma 'distribute parallel for'.

Committed revision r295497

Feb 17 2017, 2:31 PM

Feb 15 2017

carlo.bertolli added a parent revision for D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host: D29922: [OpenMP] Prepare Sema for initial implementation for pragma 'distribute parallel for'.
Feb 15 2017, 6:19 PM
carlo.bertolli added a child revision for D29922: [OpenMP] Prepare Sema for initial implementation for pragma 'distribute parallel for': D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host.
Feb 15 2017, 6:19 PM
carlo.bertolli updated the diff for D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host.

Address comments on initial patch after splitting. Added a dependency with sema patch.

Feb 15 2017, 6:18 PM
carlo.bertolli added a comment to D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host.

About this:

Feb 15 2017, 6:17 PM

Feb 13 2017

carlo.bertolli created D29922: [OpenMP] Prepare Sema for initial implementation for pragma 'distribute parallel for'.
Feb 13 2017, 6:54 PM

Feb 7 2017

carlo.bertolli added a comment to D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host.

I will split this patch into smaller patches, but I will keep this open in case I need to refer back to it: some of the changes that can go into independent patches require a justification and this patch shows it.
Thanks for your comments!

Feb 7 2017, 12:49 PM
carlo.bertolli updated the diff for D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host.

[OpenMP] Updating the patch to show full context

Feb 7 2017, 12:47 PM

Feb 6 2017

carlo.bertolli closed D29501: [OpenMP] Remove fixme comment in regression test and related unnecessary statement.

Committed revision r294195

Feb 6 2017, 8:15 AM

Feb 3 2017

carlo.bertolli created D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host.
Feb 3 2017, 12:52 PM
carlo.bertolli created D29501: [OpenMP] Remove fixme comment in regression test and related unnecessary statement.
Feb 3 2017, 11:28 AM
carlo.bertolli closed D28243: [OpenMP] Add missing regression test for pragma distribute, clause firstprivate.

Committed to r294026

Feb 3 2017, 11:21 AM

Jan 31 2017

carlo.bertolli added a reviewer for D29339: [OpenMP] Add support for auxiliary triple specification: hfinkel.
Jan 31 2017, 11:12 AM

Jan 3 2017

carlo.bertolli closed D17840: [OPENMP] Private, firstprivate, and lastprivate clauses for distribute, host code generation.

Commited r290898.

Jan 3 2017, 10:43 AM
carlo.bertolli retitled D28243: [OpenMP] Add missing regression test for pragma distribute, clause firstprivate from to [OpenMP] Add missing regression test for pragma distribute, clause firstprivate.
Jan 3 2017, 10:41 AM

Jul 13 2016

carlo.bertolli closed D22070: [OpenMP] Initial implementation of parse+sema for OpenMP clause 'is_device_ptr' of target.

Committed revision 275282.

Jul 13 2016, 10:24 AM
carlo.bertolli closed D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'.

Committed revision 275271.

Jul 13 2016, 8:50 AM

Jul 12 2016

carlo.bertolli updated the diff for D22070: [OpenMP] Initial implementation of parse+sema for OpenMP clause 'is_device_ptr' of target.

[OpenMP] Add regression test for ast, remove 'brief's, and rebase.

Jul 12 2016, 2:05 PM
carlo.bertolli added inline comments to D22070: [OpenMP] Initial implementation of parse+sema for OpenMP clause 'is_device_ptr' of target.
Jul 12 2016, 2:03 PM
carlo.bertolli updated the diff for D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'.

[OpenMP] Add regression test to check correctness of ast building, remove 'brief's, and rebase.

Jul 12 2016, 9:22 AM
carlo.bertolli added inline comments to D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'.
Jul 12 2016, 9:20 AM

Jul 11 2016

carlo.bertolli updated the diff for D22070: [OpenMP] Initial implementation of parse+sema for OpenMP clause 'is_device_ptr' of target.

[OpenMP] Remove generation of capture (move to codegen) and rebase.

Jul 11 2016, 7:26 PM
carlo.bertolli added a comment to D22070: [OpenMP] Initial implementation of parse+sema for OpenMP clause 'is_device_ptr' of target.
Jul 11 2016, 7:20 PM
carlo.bertolli updated the diff for D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'.

[OpenMP] Apply comments: remove creation of private variable and update regression tests to include references to pointers.

Jul 11 2016, 9:51 AM
carlo.bertolli added a comment to D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'.

No positive tests for the construct

Jul 11 2016, 9:49 AM

Jul 6 2016

carlo.bertolli retitled D22070: [OpenMP] Initial implementation of parse+sema for OpenMP clause 'is_device_ptr' of target from to [OpenMP] Initial implementation of parse+sema for OpenMP clause 'is_device_ptr' of target.
Jul 6 2016, 2:27 PM
carlo.bertolli updated the diff for D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'.

[OpenMP] Remove 'brief' comment tags and change error report to standard 'expected' form.

Jul 6 2016, 8:19 AM
carlo.bertolli added a comment to D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'.
Jul 6 2016, 8:06 AM

Jul 5 2016

carlo.bertolli updated the diff for D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'.

[OpenMP] Remove private variable creation from this patch as requested by comments and rebase.

Jul 5 2016, 7:45 PM

Jun 30 2016

carlo.bertolli added a comment to D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'.

I think that Kelvin is right. This is what that sentence refers to:
int * bla = ..;
#pragma omp target data use_device_ptr(bla)
{

.. bla .. // <-- this is the 'reference' that sentence is about

}

Jun 30 2016, 9:47 PM
carlo.bertolli updated subscribers of D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'.
Jun 30 2016, 4:28 PM
carlo.bertolli updated the diff for D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'.

[OpenMP] Delete trailing whitespaces in regression test file and rebase.

Jun 30 2016, 4:25 PM
carlo.bertolli retitled D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data' from to [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'.
Jun 30 2016, 12:41 PM
carlo.bertolli added a comment to D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx.

Yes, the purpose of these patches was to check correctness of code gen for the related clauses when targeting nvptx exclusively.
Since I wrote these tests, the base support changed to generate same code on host and any device type, and it seemed to me that the need for a differentiated regression test was not there any more (happy to be told otherwise).

Jun 30 2016, 12:30 PM

Jun 27 2016

carlo.bertolli added a comment to D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'.

Resubmitted at revision 273884 after fixes.

Jun 27 2016, 8:03 AM

Jun 24 2016

carlo.bertolli closed D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'.

Committed revision 273705.

Jun 24 2016, 12:04 PM
carlo.bertolli added a comment to D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'.

Thanks for the hint - I have updated the diff to use Context.getSizeType(). Please let me know if this is what you meant.

Jun 24 2016, 8:16 AM
carlo.bertolli updated the diff for D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'.

[OpenMP] Change type of distribute lower and upper bound fields to portable size_t (Context.getSizeType()).

Jun 24 2016, 8:13 AM

Jun 23 2016

carlo.bertolli added a comment to D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'.

Thanks for these further comments. I have just updated the diff applying the suggestions.

Jun 23 2016, 9:14 AM
carlo.bertolli updated the diff for D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'.

[OpenMP] Address comments: emit statements in code gen as an inlined directive (no actual code gen, just a placeholder); change type of parallel outlined function parameters to pointer to enable casting in code gen to the right type, instead of inferring value from loop analysis.

Jun 23 2016, 9:13 AM

Jun 22 2016

carlo.bertolli updated the diff for D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'.

[OpenMP] Update patch to trunk and to reflect comments. Remove fields from OMPDistributeParallelFor class and will add them to the related code gen patch.

Jun 22 2016, 7:46 AM
carlo.bertolli added a comment to D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'.

Thanks very much for the quick review. I am about to update the patch reflecting your comments and to the latest trunk.

Jun 22 2016, 7:44 AM

Jun 21 2016

carlo.bertolli updated the diff for D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'.

[OpenMP] Add regression test for distribute used as if-clause modifier and check that an error is generated

Jun 21 2016, 12:18 PM
carlo.bertolli retitled D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for' from to [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'.
Jun 21 2016, 12:09 PM

Jun 11 2016

carlo.bertolli abandoned D18470: [OPENMP] Remove unnecessary code generation of firstprivate clause for target directive in nvptx.

Codegen of region bodies should not be specialized based on target.

Jun 11 2016, 9:24 AM

Apr 28 2016

carlo.bertolli closed D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets.

Committed revision 267972.

Apr 28 2016, 6:43 PM

Apr 12 2016

carlo.bertolli updated the diff for D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets.

[OPENMP] Remove unnecessary templating of function.

Apr 12 2016, 10:27 AM
carlo.bertolli added a comment to D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets.

Great, thanks for the hint. I do much prefer your version of the function. I am updating the diff.

Apr 12 2016, 10:26 AM

Apr 11 2016

carlo.bertolli updated the diff for D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets.

[OPENMP] Remove template for intervening statement and only allow CompoundStmt.

Apr 11 2016, 10:54 AM
carlo.bertolli added a comment to D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets.

Thanks for the review. I addressed your comment in a new version of the revision.
Samuel already reviewed the patch, as you can see in the message exchange. I am very happy to apply any design change you can think of.

Apr 11 2016, 10:53 AM

Apr 4 2016

carlo.bertolli updated the diff for D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx.

[OPENMP] Rebase patch on new support for codegen for teams in nvptx target. private and firstprivate clauses are now dealt with in the teams patch and this one only becomes regression tests.

Apr 4 2016, 4:58 PM
carlo.bertolli closed D17963: [OPENMP] Codegen for teams directive for NVPTX.

Committed revision 265304.

Apr 4 2016, 9:00 AM
carlo.bertolli added a comment to D18110: [OpenMP] Fix SEMA bug in the capture of global variables in template functions..

Hi Alexey

Apr 4 2016, 8:35 AM

Apr 1 2016

carlo.bertolli updated the diff for D17963: [OPENMP] Codegen for teams directive for NVPTX.

[OPENMP] Even though this patch was already accepted in its previous form, comments on depending patch D18286 (http://reviews.llvm.org/D18286) revealed that a new approach for this patch was necessary. Instead of committing something that I have to change anyway later on, I decided to provide a new version of this base patch. Please review it again and let me know about any comments you may have.

Apr 1 2016, 1:28 PM
carlo.bertolli added a comment to D18110: [OpenMP] Fix SEMA bug in the capture of global variables in template functions..

If I understand correctly the problem, I would like to add something on top of Samuel's comment.
My understanding is that Alexey is suggesting that we pass a reference type to kernels for every pointer input parameter, regardless of the actual type and data sharing attribute of the related variable. Ignore the remained of this comment if this is not the case.

Apr 1 2016, 9:10 AM

Mar 30 2016

carlo.bertolli updated subscribers of D18542: [OPENMP] Parsing and Sema support for 'omp declare target' directive.
Mar 30 2016, 8:45 AM

Mar 25 2016

carlo.bertolli updated the diff for D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets.

Simplify the search function and generalize by using a template.

Mar 25 2016, 1:02 PM
carlo.bertolli added inline comments to D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets.
Mar 25 2016, 9:57 AM
carlo.bertolli updated subscribers of D18470: [OPENMP] Remove unnecessary code generation of firstprivate clause for target directive in nvptx.
Mar 25 2016, 9:07 AM
carlo.bertolli retitled D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets from to [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets.
Mar 25 2016, 9:06 AM

Mar 24 2016

carlo.bertolli retitled D18470: [OPENMP] Remove unnecessary code generation of firstprivate clause for target directive in nvptx from to [OPENMP] Remove unnecessary code generation of firstprivate clause for target directive in nvptx.
Mar 24 2016, 6:55 PM
carlo.bertolli added a comment to D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx.

Thinking more carefully, I believe you are right - no, it is not. I guess we would not call at all shouldEmitInlinedTeamsDirective for the case of paralle.

Mar 24 2016, 10:53 AM
carlo.bertolli added a comment to D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx.

Hi Jonas

Mar 24 2016, 9:46 AM

Mar 23 2016

carlo.bertolli removed a parent revision for D17963: [OPENMP] Codegen for teams directive for NVPTX: D18110: [OpenMP] Fix SEMA bug in the capture of global variables in template functions..
Mar 23 2016, 7:54 AM
carlo.bertolli removed a child revision for D18110: [OpenMP] Fix SEMA bug in the capture of global variables in template functions.: D17963: [OPENMP] Codegen for teams directive for NVPTX.
Mar 23 2016, 7:54 AM

Mar 22 2016

carlo.bertolli updated the diff for D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx.

To make clear my comment I an updating the patch following Alexey's comment and modifying it to make it work.
You can see that now we have the following check:
CGM.getTarget().getTriple().getArch() == llvm::Triple::nvptx ||
CGM.getTarget().getTriple().getArch() == llvm::Triple::nvptx64

Mar 22 2016, 7:31 AM
carlo.bertolli added a comment to D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx.

Hi Alexey

Mar 22 2016, 7:05 AM

Mar 18 2016

carlo.bertolli retitled D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx from to [OPENMP] private and firstprivate clauses of teams code generation for nvptx.
Mar 18 2016, 3:37 PM
carlo.bertolli closed D18203: [OPENMP] Implementation of codegen for firstprivate clause of target directive.

Committed revision 263837.

Mar 18 2016, 2:48 PM

Mar 16 2016

carlo.bertolli updated the diff for D18203: [OPENMP] Implementation of codegen for firstprivate clause of target directive.

Update against trunk as dependence was committed to trunk.

Mar 16 2016, 12:30 PM
carlo.bertolli closed D18105: [OPENMP] Support for codegen of private clause of target, host side.

Committed revision 263654.

Mar 16 2016, 12:09 PM