Page MenuHomePhabricator

carlo.bertolli (Carlo Bertolli)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2015, 9:24 AM (364 w, 3 d)

Recent Activity

Apr 12 2022

carlo.bertolli accepted D123527: [libomptarget][amdgpu] Add hidden_heap_v1 kernarg metadata.

LGTM, thanks for this.

Apr 12 2022, 11:15 AM · Restricted Project, Restricted Project

Feb 18 2022

carlo.bertolli committed rG7b731f4d0bfb: [OpenMP][libomptarget] Delay restore of shadow pointers in structs to after H2D… (authored by carlo.bertolli).
[OpenMP][libomptarget] Delay restore of shadow pointers in structs to after H2D…
Feb 18 2022, 8:09 AM
carlo.bertolli closed D119968: [OpenMP][libomptarget] Delay restore of shadow pointers in structs to after H2D memory copies are completed.
Feb 18 2022, 8:09 AM · Restricted Project

Feb 16 2022

carlo.bertolli updated the diff for D119968: [OpenMP][libomptarget] Delay restore of shadow pointers in structs to after H2D memory copies are completed.

Replace list of shadow pointer to be restored with simple synchronization.

Feb 16 2022, 6:48 PM · Restricted Project
carlo.bertolli added inline comments to D119968: [OpenMP][libomptarget] Delay restore of shadow pointers in structs to after H2D memory copies are completed.
Feb 16 2022, 1:01 PM · Restricted Project
carlo.bertolli requested review of D119968: [OpenMP][libomptarget] Delay restore of shadow pointers in structs to after H2D memory copies are completed.
Feb 16 2022, 12:42 PM · Restricted Project

Dec 17 2021

carlo.bertolli committed rGd3abb04e148b: [OpenMP][libomptarget] Fix __tgt_rtl_run_target_team_region_async API with… (authored by carlo.bertolli).
[OpenMP][libomptarget] Fix __tgt_rtl_run_target_team_region_async API with…
Dec 17 2021, 7:59 AM
carlo.bertolli closed D115887: [OpenMP][libomptarget] Fix __tgt_rtl_run_target_team_region_async API with missing parameter.
Dec 17 2021, 7:59 AM · Restricted Project
carlo.bertolli added a comment to D115887: [OpenMP][libomptarget] Fix __tgt_rtl_run_target_team_region_async API with missing parameter.

It looks like https://reviews.llvm.org/D115823 will take a bit longer to be merged. I will merge this in to fix the API error, as it can go in first.

Dec 17 2021, 7:48 AM · Restricted Project

Dec 16 2021

carlo.bertolli updated the diff for D115887: [OpenMP][libomptarget] Fix __tgt_rtl_run_target_team_region_async API with missing parameter.

Add context.

Dec 16 2021, 9:47 AM · Restricted Project
carlo.bertolli requested review of D115887: [OpenMP][libomptarget] Fix __tgt_rtl_run_target_team_region_async API with missing parameter.
Dec 16 2021, 9:47 AM · Restricted Project
carlo.bertolli accepted D115823: [openmp][libomptarget] Introduce and call createAsyncInfo.

LGTM

Dec 16 2021, 8:17 AM · Restricted Project

Dec 15 2021

carlo.bertolli committed rGd83dc4c64814: [OpenMP] Increase opportunity for parallel kernel launch in AMDGPUs: add… (authored by carlo.bertolli).
[OpenMP] Increase opportunity for parallel kernel launch in AMDGPUs: add…
Dec 15 2021, 7:35 AM
carlo.bertolli closed D115771: [OpenMP] Increase opportunity for parallel kernel launch in AMDGPUs: add multiple hsa queue's per device in plugin.
Dec 15 2021, 7:35 AM · Restricted Project

Dec 14 2021

carlo.bertolli requested review of D115771: [OpenMP] Increase opportunity for parallel kernel launch in AMDGPUs: add multiple hsa queue's per device in plugin.
Dec 14 2021, 5:47 PM · Restricted Project

Dec 10 2021

carlo.bertolli committed rG28309c543669: [OpenMP] Part 2 of At present, amdgpu plugin merges both asynchronous (authored by carlo.bertolli).
[OpenMP] Part 2 of At present, amdgpu plugin merges both asynchronous
Dec 10 2021, 11:21 AM
carlo.bertolli closed D115273: [NFC][OpenMP] Prepare amdgpu plugin for asynchronous implementation of target region launch.
Dec 10 2021, 11:21 AM · Restricted Project
carlo.bertolli updated the diff for D115273: [NFC][OpenMP] Prepare amdgpu plugin for asynchronous implementation of target region launch.

Trying rebase again.

Dec 10 2021, 8:29 AM · Restricted Project
carlo.bertolli updated the diff for D115273: [NFC][OpenMP] Prepare amdgpu plugin for asynchronous implementation of target region launch.

rebase onto main

Dec 10 2021, 8:25 AM · Restricted Project

Dec 9 2021

carlo.bertolli updated the diff for D115273: [NFC][OpenMP] Prepare amdgpu plugin for asynchronous implementation of target region launch.

[OpenMP][NFC] Apply requested change: remove "nowait" from function name.
Add context (sorry about that!)

Dec 9 2021, 10:36 AM · Restricted Project

Dec 8 2021

carlo.bertolli updated the diff for D115279: [OpenMP][AMDGPU] Switch host-device memory copy to asynchronous version.

[OpenMP] Add missing hsa declarations/definitions when building runtime without rocr (or hsa library) installed on the system

Dec 8 2021, 11:33 AM · Restricted Project
carlo.bertolli added a comment to D115279: [OpenMP][AMDGPU] Switch host-device memory copy to asynchronous version.

I know what happened to my machine. Some CMake change caused offload plugins are not compiled. Sign. broken upstream.
My intention is to check pinned status. Before the first lock(not pinned), after the first lock(pinned), after the offload region(pinned), after the unlock(unpinned).
Could you also verify with rocprof hsa trace that the lock and unlock are both called twice?

Dec 8 2021, 10:19 AM · Restricted Project
carlo.bertolli added a comment to D115279: [OpenMP][AMDGPU] Switch host-device memory copy to asynchronous version.

I failed to verify your first lock behaves as intended.

#include <hsa/hsa.h>
#include <hsa/hsa_ext_amd.h>
#include <omp.h>
#include <stdio.h>

#define N 100293

int checkLocked(void *ptr) {
  hsa_amd_pointer_info_t info;
  hsa_status_t herr;

  herr = hsa_amd_pointer_info(ptr, &info, NULL, NULL, NULL);
  if (herr != HSA_STATUS_SUCCESS) {
    printf("  hsa_amd_pointer_info failed\n");
    return 1;
  }

  if (info.type != HSA_EXT_POINTER_TYPE_LOCKED) {
    printf("  pointer is noooooooooooot locked\n");
    return 1;
  } else
    printf("  pointer is locked\n");

  return 0;
}

int main() {
  int n = N;
  int *a = new int[n];
  for (int i = 0; i < n; i++)
    a[i] = 0;

  int *a_locked = nullptr;
  hsa_status_t herr =
      hsa_amd_memory_lock(a, n * sizeof(int), nullptr, 0, (void **)&a_locked);
  if (herr != HSA_STATUS_SUCCESS) {
    printf("Locking failed\n");
    return 1;
  }

  checkLocked(a);

#pragma omp target parallel for map(tofrom : a_locked[:n])
  for (int i = 0; i < n; i++)
    a_locked[i] = i;

  herr = hsa_amd_memory_unlock(a);
  if (herr != HSA_STATUS_SUCCESS) {
    printf("Unlocking failed\n");
    return 1;
  }

  int err = 0;
  for (int i = 0; i < n; i++)
    if (a[i] != i) {
      err++;
      printf("Err at %d, got %d expected %d\n", i, a[i], i);
      if (err > 10)
        break;
    }

  delete[] a;

  return err;
}

I got failure at the first check with "hsa_amd_pointer_info failed". Could you take a look?

Dec 8 2021, 9:51 AM · Restricted Project
carlo.bertolli added a comment to D115279: [OpenMP][AMDGPU] Switch host-device memory copy to asynchronous version.

I have not tried with memory that has already been locked, but I will. In any case, with this patch, if locking fails, then we revert to malloc+lock+unlock+free. This is not ideal, and this case is added for other reasons, but it should be supporting the case.

It will be better skipping lock/free if the memory is known to HSA already. I think IBM XL skips its pinned memory optimization when it sees the pointer pinned already for CUDA.
I have code managing lock/unlock via HIP. Even if a lock call from the plugin succeeds, and then a plugin unlock call succeeds, the user unlock call fails.
For this reason, check memory info is required.
fallback to "malloc+lock+unlock+free" is the worst option.

Dec 8 2021, 8:40 AM · Restricted Project
carlo.bertolli added a comment to D115279: [OpenMP][AMDGPU] Switch host-device memory copy to asynchronous version.

Yes, should revert and update the dlopen HSA source. Apologies for not checking this builds before committing it.

I don't know whether there's more ritual to to around whether it's already pinned - @carlo.bertolli did you look into testing if the memory is already pinned before doing so? Particularly interested if already pinned is a reason for lock to fail

Dec 8 2021, 5:07 AM · Restricted Project

Dec 7 2021

carlo.bertolli requested review of D115279: [OpenMP][AMDGPU] Switch host-device memory copy to asynchronous version.
Dec 7 2021, 1:15 PM · Restricted Project
carlo.bertolli added a comment to D115267: [NFC][OpenMP] Prepare amdgpu plugin for asynchronous implementation of target region launch.

@JonChesterfield thanks for the quick review. Would you mind merging this for me?

Dec 7 2021, 12:57 PM · Restricted Project
carlo.bertolli added inline comments to D115267: [NFC][OpenMP] Prepare amdgpu plugin for asynchronous implementation of target region launch.
Dec 7 2021, 12:48 PM · Restricted Project
carlo.bertolli updated the diff for D115273: [NFC][OpenMP] Prepare amdgpu plugin for asynchronous implementation of target region launch.

format

Dec 7 2021, 12:47 PM · Restricted Project
carlo.bertolli requested review of D115273: [NFC][OpenMP] Prepare amdgpu plugin for asynchronous implementation of target region launch.
Dec 7 2021, 11:21 AM · Restricted Project
carlo.bertolli added a comment to D115267: [NFC][OpenMP] Prepare amdgpu plugin for asynchronous implementation of target region launch.

@JonChesterfield this looks more readable as a first step.

Dec 7 2021, 10:41 AM · Restricted Project
carlo.bertolli abandoned D115258: [NFC][OpenMP] Prepare amdgpu plugin for asynchronous implementation of target region launch.

Abandoning this one for readability issues and moving to two separate patches.
First one:
https://reviews.llvm.org/D115267

Dec 7 2021, 10:41 AM
carlo.bertolli requested review of D115267: [NFC][OpenMP] Prepare amdgpu plugin for asynchronous implementation of target region launch.
Dec 7 2021, 10:40 AM · Restricted Project
carlo.bertolli requested review of D115258: [NFC][OpenMP] Prepare amdgpu plugin for asynchronous implementation of target region launch.
Dec 7 2021, 8:50 AM

Nov 17 2021

carlo.bertolli added a comment to D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive.

This is already a lot of code with parse+sema. I wonder if we should split the patch into two, i.e. 1. parse+sema; 2. code gen? @ABataev ?
It should simplify maintenance of the patch and allow time to extend the OpenMP IR builder.

Nov 17 2021, 8:02 AM · Restricted Project, Restricted Project

Nov 3 2021

carlo.bertolli accepted D113111: [OpenMP] Build device runtimes for sm_86.

LGTM

Nov 3 2021, 8:31 AM · Restricted Project

Oct 25 2021

carlo.bertolli added a comment to D111280: [OpenMP] Avoid starting a kernel without work.

Thanks for this. Do you think this could use a test?
I assume a test would be easier to write once this information is used somewhere, but it's hard to tell without context.

How would a test look like? And what do you mean by "information is used somewhere"?
If we land this code it is "used" and will avoid execution of kernels with an associated loop trip count of 0.

Oct 25 2021, 6:39 PM

Oct 15 2021

carlo.bertolli accepted D111905: [OpenMP][deviceRTLs] Fix wrong return value of `__kmpc_is_spmd_exec_mode`.

Thanks for fixing this. It would be nice if you could add a comment where it is used at the beginning of parallel_51, stating what are the initial value of parallelLevel (kmpc_parallel_level) and those of kmpc_is_spmd_exec_mode in the two cases of generic and spmd modes (assuming generic spmd mode is handled as a spmd). Something like:

Oct 15 2021, 1:02 PM · Restricted Project

Oct 7 2021

carlo.bertolli added a comment to D111280: [OpenMP] Avoid starting a kernel without work.

Thanks for this. Do you think this could use a test?
I assume a test would be easier to write once this information is used somewhere, but it's hard to tell without context.

Oct 7 2021, 7:35 AM

Sep 30 2021

carlo.bertolli accepted D110845: [libomptarget] Apply D110029 to amdgpu.

LGTM

Sep 30 2021, 1:27 PM · Restricted Project

Sep 20 2021

carlo.bertolli updated the diff for D108569: [OpenMP] Enable map checks under unified_shared_memory mode.

Updated patch based on comments: add new map table entry field to track USM maps; use it to determine behavior in getTargetPointer and deallocTgtPtr; update var name and add explaining comments.

Sep 20 2021, 8:48 AM

Sep 17 2021

carlo.bertolli added a comment to D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive.

Another thing is how we deal with a corner case. Say the OpenMP code is written in the following way:

#pragma omp atomic compare
  x = e < x ? e : x;

That's how OpenMP spec defines the atomic operation. x is always in "else statement" of a conditional statement.

Now we need to lower it to LLVM IR, which is atomicrmw operation. Based on the LLVM IR reference, it only supports the atomic operations that x is in the "then statement". For example: x = x > e ? x : e. See the x here is before :. In order to lower the OpenMP statement, we have to do a transformation. In order to swap e and x, we need to transform it to x = e >= x : x : e, a.k.a. x = x <= e : x : e. However, we don't have an atomic operation for <=. We only have <. So if x != e, the result is good.

The incorrectness happens if x == e. Recall at the OpenMP statement, when x == e, the result should be x = x. But if we look at our lowered LLVM IR, x = x < e : x : e, when x == e, it becomes x = e, which doesn't conform with OpenMP spec.

What should we do here?

Sep 17 2021, 11:14 AM · Restricted Project, Restricted Project

Aug 26 2021

carlo.bertolli added a comment to D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive.

Thanks for uploading this.

Aug 26 2021, 10:33 AM · Restricted Project, Restricted Project

Aug 23 2021

carlo.bertolli updated the diff for D108569: [OpenMP] Enable map checks under unified_shared_memory mode.

Update environment variable name to reflect comments and intended name

Aug 23 2021, 11:34 AM
carlo.bertolli requested review of D108569: [OpenMP] Enable map checks under unified_shared_memory mode.
Aug 23 2021, 11:22 AM

Jul 6 2021

carlo.bertolli accepted D102307: [OpenMP] Detect SPMD compatible kernels and execute them as such.

I have very small comments. LGTM.

Jul 6 2021, 9:13 AM · Restricted Project

Jun 14 2021

carlo.bertolli added a comment to D103899: [OpenMP] Fix C-only clang assert on parsing use_allocator clause of target directive.

@ABataev can you please merge this for me? I still have to ask for commit privileges.

Jun 14 2021, 8:41 AM · Restricted Project
carlo.bertolli added a comment to D103899: [OpenMP] Fix C-only clang assert on parsing use_allocator clause of target directive.

Nice, thanks. I guess we already have an equivalent test in c++?

Jun 14 2021, 8:38 AM · Restricted Project
carlo.bertolli updated the diff for D103899: [OpenMP] Fix C-only clang assert on parsing use_allocator clause of target directive.

[OpenMP] Add test for C language of target uses_allocators clause

Jun 14 2021, 8:24 AM · Restricted Project

Jun 8 2021

carlo.bertolli added a comment to D103899: [OpenMP] Fix C-only clang assert on parsing use_allocator clause of target directive.

Ah! I forgot to add a reference to a filed bugzilla:
https://bugs.llvm.org/show_bug.cgi?id=50619

Jun 8 2021, 8:28 AM · Restricted Project
carlo.bertolli added a reviewer for D103899: [OpenMP] Fix C-only clang assert on parsing use_allocator clause of target directive: ABataev.
Jun 8 2021, 8:19 AM · Restricted Project
carlo.bertolli requested review of D103899: [OpenMP] Fix C-only clang assert on parsing use_allocator clause of target directive.
Jun 8 2021, 8:18 AM · Restricted Project

Feb 27 2018

carlo.bertolli created D43852: [OpenMP] Extend NVPTX SPMD implementation of combined constructs.
Feb 27 2018, 6:47 PM

Feb 22 2018

carlo.bertolli updated the diff for D43513: [OpenMP] Limit reduction support for pragma 'distribute' when combined with pragma 'simd'.

[OpenMP] Add regression test: this verifies that only one call to the runtime for reduction is done in a combined construct with distribute, without simd, and with at least one pragma accepting reduction as a clause.

Feb 22 2018, 8:01 AM

Feb 20 2018

carlo.bertolli created D43513: [OpenMP] Limit reduction support for pragma 'distribute' when combined with pragma 'simd'.
Feb 20 2018, 9:02 AM

Feb 1 2018

carlo.bertolli closed D42757: [OpenMP-RT] Fix debug string for NVPTX runtime library.

That's correct, debug printfs were reporting zero threads to be used in SPMD region instead of the actual number used.

Feb 1 2018, 8:16 AM

Jan 31 2018

carlo.bertolli created D42757: [OpenMP-RT] Fix debug string for NVPTX runtime library.
Jan 31 2018, 12:10 PM

Jan 3 2018

carlo.bertolli closed D41709: [OpenMP] Initial implementation of code generation for pragma 'target teams distribute parallel for' on host.

Committed revision 321759.

Jan 3 2018, 1:13 PM
carlo.bertolli created D41709: [OpenMP] Initial implementation of code generation for pragma 'target teams distribute parallel for' on host.
Jan 3 2018, 12:59 PM

Dec 4 2017

carlo.bertolli closed D40795: [OpenMP] Initial implementation of code generation for pragma 'teams distribute parallel for simd' on host.

Committed revision 319696.

Dec 4 2017, 12:57 PM
carlo.bertolli created D40795: [OpenMP] Initial implementation of code generation for pragma 'teams distribute parallel for simd' on host.
Dec 4 2017, 10:40 AM

Nov 20 2017

carlo.bertolli closed D40187: [OpenMP] Initial implementation of code generation for pragma 'teams distribute parallel for' on host.

Committed revision 318692.

Nov 20 2017, 3:55 PM

Nov 17 2017

carlo.bertolli created D40187: [OpenMP] Initial implementation of code generation for pragma 'teams distribute parallel for' on host.
Nov 17 2017, 10:28 AM
carlo.bertolli updated subscribers of D40187: [OpenMP] Initial implementation of code generation for pragma 'teams distribute parallel for' on host.
Nov 17 2017, 10:28 AM

Nov 10 2017

carlo.bertolli closed D39902: [OpenMP] Parse+Sema for copyin clause of 'teams distribute parallel for'.

Committed revision 317893.

Nov 10 2017, 8:06 AM
carlo.bertolli created D39902: [OpenMP] Parse+Sema for copyin clause of 'teams distribute parallel for'.
Nov 10 2017, 7:53 AM

Oct 4 2017

carlo.bertolli closed D38371: [OpenMP] Initial implementation of teams distribute code generation.

Committed revision 314905.

Oct 4 2017, 7:14 AM

Sep 28 2017

carlo.bertolli created D38371: [OpenMP] Initial implementation of teams distribute code generation.
Sep 28 2017, 10:58 AM

May 3 2017

carlo.bertolli closed D32807: [OpenMP] Extended parse for 'always' map modifier.

Committed revision 302031.

May 3 2017, 8:42 AM
carlo.bertolli created D32807: [OpenMP] Extended parse for 'always' map modifier.
May 3 2017, 8:20 AM

Apr 25 2017

carlo.bertolli added a comment to D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host.

Re-Committed revision 301340.

Apr 25 2017, 11:05 AM

Apr 24 2017

carlo.bertolli closed D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host.

Committed revision 301223.

Apr 24 2017, 12:39 PM
carlo.bertolli updated the summary of D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host.
Apr 24 2017, 10:39 AM
carlo.bertolli updated the diff for D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host.

[OpenMP] Refactor after split of original patch in two patches (sema and cg). Transform lambdas to static functions, where possible, define default constructors, format, and update against trunk.

Apr 24 2017, 8:54 AM

Apr 19 2017

carlo.bertolli closed D32237: [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for.

Committed revision 300802.

Apr 19 2017, 5:54 PM
carlo.bertolli updated subscribers of D32237: [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for.
Apr 19 2017, 12:02 PM
carlo.bertolli created D32237: [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for.
Apr 19 2017, 12:02 PM

Apr 7 2017

carlo.bertolli added a comment to D31811: [compiler-rt] Add virtual destructor to base class to avoid warning.

Also reported by bbot slave:

Apr 7 2017, 8:31 AM
carlo.bertolli created D31811: [compiler-rt] Add virtual destructor to base class to avoid warning.
Apr 7 2017, 8:29 AM

Feb 17 2017

carlo.bertolli closed D29922: [OpenMP] Prepare Sema for initial implementation for pragma 'distribute parallel for'.

Committed revision r295497

Feb 17 2017, 2:31 PM

Feb 15 2017

carlo.bertolli updated the diff for D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host.

Address comments on initial patch after splitting. Added a dependency with sema patch.

Feb 15 2017, 6:18 PM
carlo.bertolli added a comment to D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host.

About this:

Feb 15 2017, 6:17 PM

Feb 13 2017

carlo.bertolli created D29922: [OpenMP] Prepare Sema for initial implementation for pragma 'distribute parallel for'.
Feb 13 2017, 6:54 PM

Feb 7 2017

carlo.bertolli added a comment to D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host.

I will split this patch into smaller patches, but I will keep this open in case I need to refer back to it: some of the changes that can go into independent patches require a justification and this patch shows it.
Thanks for your comments!

Feb 7 2017, 12:49 PM
carlo.bertolli updated the diff for D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host.

[OpenMP] Updating the patch to show full context

Feb 7 2017, 12:47 PM

Feb 6 2017

carlo.bertolli closed D29501: [OpenMP] Remove fixme comment in regression test and related unnecessary statement.

Committed revision r294195

Feb 6 2017, 8:15 AM

Feb 3 2017

carlo.bertolli created D29508: [OpenMP] Initial implementation of code generation for pragma 'distribute parallel for' on host.
Feb 3 2017, 12:52 PM
carlo.bertolli created D29501: [OpenMP] Remove fixme comment in regression test and related unnecessary statement.
Feb 3 2017, 11:28 AM
carlo.bertolli closed D28243: [OpenMP] Add missing regression test for pragma distribute, clause firstprivate.

Committed to r294026

Feb 3 2017, 11:21 AM

Jan 31 2017

carlo.bertolli added a reviewer for D29339: [OpenMP] Add support for auxiliary triple specification: hfinkel.
Jan 31 2017, 11:12 AM

Jan 3 2017

carlo.bertolli closed D17840: [OPENMP] Private, firstprivate, and lastprivate clauses for distribute, host code generation.

Commited r290898.

Jan 3 2017, 10:43 AM
carlo.bertolli retitled D28243: [OpenMP] Add missing regression test for pragma distribute, clause firstprivate from to [OpenMP] Add missing regression test for pragma distribute, clause firstprivate.
Jan 3 2017, 10:41 AM

Jul 13 2016

carlo.bertolli closed D22070: [OpenMP] Initial implementation of parse+sema for OpenMP clause 'is_device_ptr' of target.

Committed revision 275282.

Jul 13 2016, 10:24 AM
carlo.bertolli closed D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'.

Committed revision 275271.

Jul 13 2016, 8:50 AM

Jul 12 2016

carlo.bertolli updated the diff for D22070: [OpenMP] Initial implementation of parse+sema for OpenMP clause 'is_device_ptr' of target.

[OpenMP] Add regression test for ast, remove 'brief's, and rebase.

Jul 12 2016, 2:05 PM
carlo.bertolli added inline comments to D22070: [OpenMP] Initial implementation of parse+sema for OpenMP clause 'is_device_ptr' of target.
Jul 12 2016, 2:03 PM
carlo.bertolli updated the diff for D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'.

[OpenMP] Add regression test to check correctness of ast building, remove 'brief's, and rebase.

Jul 12 2016, 9:22 AM
carlo.bertolli added inline comments to D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'.
Jul 12 2016, 9:20 AM

Jul 11 2016

carlo.bertolli updated the diff for D22070: [OpenMP] Initial implementation of parse+sema for OpenMP clause 'is_device_ptr' of target.

[OpenMP] Remove generation of capture (move to codegen) and rebase.

Jul 11 2016, 7:26 PM
carlo.bertolli added a comment to D22070: [OpenMP] Initial implementation of parse+sema for OpenMP clause 'is_device_ptr' of target.
Jul 11 2016, 7:20 PM