This is an archive of the discontinued LLVM Phabricator instance.

[AsmParser] Remove typed pointer auto-detection
ClosedPublic

Authored by nikic on Jan 17 2023, 3:38 AM.

Details

Summary

IR is now always parsed in opaque pointer mode, unless -opaque-pointers=0 is explicitly given. There is no automatic detection of typed pointers anymore.

The -opaque-pointers=0 option is added to any remaining IR tests that haven't been migrated yet.

Diff Detail

Event Timeline

nikic created this revision.Jan 17 2023, 3:38 AM
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a reviewer: ributzka. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
nikic requested review of this revision.Jan 17 2023, 3:38 AM
Herald added a reviewer: sstefan1. · View Herald Transcript
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
arsenm added inline comments.Jan 17 2023, 8:25 AM
llvm/test/CodeGen/AMDGPU/lower-kernel-lds.ll
2

The test diff is bigger than I expected, what is holding this set of tests back? For example these AMDGPU tests weren't converted with the others to avoid a merge conflict issue which we're past now

nikic added inline comments.Jan 17 2023, 8:42 AM
llvm/test/CodeGen/AMDGPU/lower-kernel-lds.ll
2

Just a matter of time. I want to land this change before LLVM 16 branches, and don't have time to convert all the remaining tests.

I haven't looked into AMDGPU tests in particular because I assumed that you are taking care of them.

aeubanks accepted this revision.Jan 17 2023, 10:09 AM
This revision is now accepted and ready to land.Jan 17 2023, 10:09 AM
fhahn accepted this revision.Jan 17 2023, 1:02 PM
fhahn added a subscriber: fhahn.

LGTM, thanks! This makes it also very easy to grep for tests that still need converting .

This revision was landed with ongoing or failed builds.Jan 18 2023, 12:58 AM
This revision was automatically updated to reflect the committed changes.