User Details
- User Since
- Oct 18 2013, 11:20 AM (379 w, 2 d)
Jun 30 2020
LGTM
Jun 8 2020
Apr 1 2020
LGTM
Feb 11 2020
LGTM
Jan 15 2020
SpareSet is deterministic given the same input order - similar to SetVector. Printing the result is not the common use case, so changing the print function to sort the output first might be more useful for testing purposes.
Nov 26 2019
Nov 21 2019
Oct 29 2019
Oct 7 2019
Thanks Cyndy. LGTM
Does nm print now all symbols - including the inlined ones? That would be an unexpected change, because we don't do the same for MachOs that have re-exported frameworks. I think this feature should be guarded by an option.
Sep 27 2019
Sep 24 2019
Sep 23 2019
Sep 18 2019
Sep 13 2019
xxhash64 is apparently faster than MD5 and SHA1, and produces good quality hashes. I am not sure about the hash quality of hash_code for this purpose.
LGTM
LGTM
Sep 12 2019
Sep 11 2019
Did you try xxHash64?
Sep 10 2019
LGTM
The motivation to add this to llvm-nm, is to get the same functionally back that we lost with adding TBD files. Using it for testing is a nice side benefit.
Sep 9 2019
Sep 6 2019
Sep 5 2019
LGTM
Sep 3 2019
Aug 20 2019
LGTM, but we should also wait for Lang's feedback.
Aug 14 2019
New version is tracked here: D66149
Aug 13 2019
Aug 12 2019
Sure, np
Hi Cyndy, thanks for catching this copy-past-o bug. LGTM
Jun 20 2019
If I recall correctly, then getIntImmCost(const APInt &Imm) predates the ConstantHoisting pass and is also used by other optimizations. The purpose of that hook is to calculate the materialization cost of a constant and is context free.
Apr 4 2019
Apr 3 2019
Thanks for catching this. LGTM.
Mar 22 2019
Nov 30 2018
LGTM
Nov 28 2018
- rename setArchitectures to addArchitectures
- fix comments
- use BitmaskEnum in several places to remove custom static_cast code.
Nov 26 2018
- Rebase patch on D53051
- Remove registry and add separate reader and writer classes
- Move everything into the MachO namespace and sub-folder
Nov 14 2018
Nov 12 2018
I will update the patch with more changes based on the feedback so far.
Nov 1 2018
Add missing license header.
Oct 31 2018
We do have that now. All TAPI files start now with "--- !tapi". It is only
that the first version doesn't have that marker and that is why we have to
fall back to this extra check.
Replace std::sort with llvm::sort and fix copy-paste-o bugs.
Sep 19 2018
Aug 23 2018
TAPI mostly cares about linkable symbols, so this shouldn't be a problem.
Sep 13 2017
Aug 28 2017
Thanks Chris.
Thanks Chris
gentle ping :-)
Aug 22 2017
Nice cleanup with the RuntimeLinkOptions enum. LGTM
Jul 27 2017
Updating D35908: [YAML] Use {Specific}BumpPtrAllocators for HNodes.