Page MenuHomePhabricator

ributzka (Juergen Ributzka)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 18 2013, 11:20 AM (448 w, 2 d)

Recent Activity

Apr 19 2022

ributzka added a comment to D123831: [clang][extract-api] Use relative includes.

we might not always want to transform an absolute path because the resulting relative include name might get remapped in a headermap, for example in test known_files_only_hmap.c. But how does it work with modules where we need relative includes? Is the setup in known_files_only_hmap even valid?

I think, in most cases, this shouldn't matter because if the header path input doesn't match the location stored in the header map, they should still have the same source content. The same should be true with header search resolution with modules & vfsoverlay

Agreed, I think it would be classified as a user error to remap to different source content via headermap.

Apr 19 2022, 9:49 AM · Restricted Project, Restricted Project

Mar 23 2022

ributzka accepted D122175: [clang][extract-api] Enable processing of multiple headers.

LGTM

Mar 23 2022, 9:32 AM · Restricted Project, Restricted Project

Mar 22 2022

ributzka added inline comments to D122175: [clang][extract-api] Enable processing of multiple headers.
Mar 22 2022, 5:58 PM · Restricted Project, Restricted Project

Mar 17 2022

ributzka added a comment to D121936: Ensure -extract-api handles multiple headers correctly.

Nice! Thank you for adding support for multiple headers. Is this a step towards the json input file list?

Mar 17 2022, 11:24 AM · Restricted Project, Restricted Project
ributzka added inline comments to D121936: Ensure -extract-api handles multiple headers correctly.
Mar 17 2022, 11:19 AM · Restricted Project, Restricted Project

Mar 9 2022

ributzka added inline comments to D119479: [clang][extract-api] Add global record support.
Mar 9 2022, 9:16 AM · Restricted Project, Restricted Project

Jan 21 2022

ributzka accepted D117809: [clang] Add an extract-api driver option.

LGTM. Just a few minor nits.

Jan 21 2022, 10:12 AM · Restricted Project

Jan 14 2022

ributzka accepted D117348: [Preprocessor] Reduce the memory overhead of `#define` directives.

LGTM

Jan 14 2022, 2:41 PM · Restricted Project

Jan 13 2022

ributzka committed rG3025c3ededf9: Replace PlatformKind with PlatformType. (authored by ributzka).
Replace PlatformKind with PlatformType.
Jan 13 2022, 9:24 AM
ributzka closed D117163: Replace PlatformKind with PlatformType..
Jan 13 2022, 9:24 AM · Restricted Project, Restricted Project
ributzka added a comment to D117163: Replace PlatformKind with PlatformType..

The unit test failure on Windows seems unrelated, because I have seen it in a previous pre-merge check too. Furthermore, this should be a NFC.

Jan 13 2022, 9:10 AM · Restricted Project, Restricted Project

Jan 12 2022

ributzka requested review of D117163: Replace PlatformKind with PlatformType..
Jan 12 2022, 3:01 PM · Restricted Project, Restricted Project

Dec 17 2021

ributzka accepted D115905: [llvm-tapi-diff] Replicate diff utility error handling.
Dec 17 2021, 12:24 PM · Restricted Project

Oct 6 2021

ributzka added a reviewer for D111205: [driver] Explicitly specify `-fbuild-session-timestamp` in seconds.: Bigcheese.
Oct 6 2021, 1:45 PM · Restricted Project

Jun 2 2021

ributzka accepted D101835: [llvm] llvm-tapi-diff.

LGTM

Jun 2 2021, 9:35 AM · Restricted Project

Apr 5 2021

ributzka accepted D99811: [TextAPI] move source code files out of subdirectory, NFC.

LGTM

Apr 5 2021, 9:13 AM · Restricted Project, Restricted Project, Restricted Project

Jun 30 2020

ributzka accepted D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option.

LGTM

Jun 30 2020, 9:12 AM · Restricted Project

Jun 8 2020

ributzka added inline comments to D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option.
Jun 8 2020, 10:29 AM · Restricted Project

Apr 1 2020

ributzka accepted D67646: [llvm][TextAPI] adding inlining reexported libraries support.

LGTM

Apr 1 2020, 8:50 AM · Restricted Project

Feb 11 2020

ributzka accepted D74416: [llvm][TextAPI] add simulators to output.

LGTM

Feb 11 2020, 10:14 AM · Restricted Project
ributzka added inline comments to D74416: [llvm][TextAPI] add simulators to output.
Feb 11 2020, 8:48 AM · Restricted Project
ributzka added inline comments to D74416: [llvm][TextAPI] add simulators to output.
Feb 11 2020, 8:38 AM · Restricted Project

Jan 15 2020

ributzka added a comment to D72441: [CodeGen] Store LiveRegs in SetVector.

SpareSet is deterministic given the same input order - similar to SetVector. Printing the result is not the common use case, so changing the print function to sort the output first might be more useful for testing purposes.

Jan 15 2020, 7:57 AM · Restricted Project

Nov 26 2019

ributzka added inline comments to D70669: [AArch64TTI] Compute imm materialization cost for AArch64 intrinsics.
Nov 26 2019, 3:50 PM · Restricted Project

Nov 21 2019

ributzka added reviewers for D70493: [StackMaps] Avoid crash when a call follows a patchpoint: lhames, aprantl.
Nov 21 2019, 2:39 PM · Restricted Project

Oct 29 2019

ributzka committed rGf5246fe96dcd: Merge branch 'master' of http://llvm.org/git/clang into upstream-with-swift (authored by ributzka).
Merge branch 'master' of http://llvm.org/git/clang into upstream-with-swift
Oct 29 2019, 3:13 PM
ributzka committed rG3fa85d5359df: Merge branch 'master' of http://llvm.org/git/clang into upstream-with-swift (authored by ributzka).
Merge branch 'master' of http://llvm.org/git/clang into upstream-with-swift
Oct 29 2019, 2:31 PM

Oct 7 2019

ributzka accepted D67529: [TextAPI] Introduce TBDv4.

Thanks Cyndy. LGTM

Oct 7 2019, 11:17 AM · Restricted Project
ributzka added a comment to D67646: [llvm][TextAPI] adding inlining reexported libraries support.

Does nm print now all symbols - including the inlined ones? That would be an unexpected change, because we don't do the same for MachOs that have re-exported frameworks. I think this feature should be guarded by an option.

Oct 7 2019, 9:58 AM · Restricted Project
ributzka added inline comments to D67529: [TextAPI] Introduce TBDv4.
Oct 7 2019, 9:55 AM · Restricted Project

Sep 27 2019

ributzka added inline comments to D67529: [TextAPI] Introduce TBDv4.
Sep 27 2019, 9:29 AM · Restricted Project

Sep 24 2019

ributzka added inline comments to D67529: [TextAPI] Introduce TBDv4.
Sep 24 2019, 10:31 AM · Restricted Project

Sep 23 2019

ributzka added inline comments to D67529: [TextAPI] Introduce TBDv4.
Sep 23 2019, 12:28 PM · Restricted Project

Sep 18 2019

ributzka added inline comments to D67529: [TextAPI] Introduce TBDv4.
Sep 18 2019, 11:30 AM · Restricted Project

Sep 13 2019

ributzka added a comment to D67249: [Modules][PCH] Hash input files content.

xxhash64 is apparently faster than MD5 and SHA1, and produces good quality hashes. I am not sure about the hash quality of hash_code for this purpose.

Sep 13 2019, 3:35 PM · Restricted Project
ributzka accepted D67527: [TextAPI] Arch&Platform to Target.

LGTM

Sep 13 2019, 10:33 AM · Restricted Project
ributzka accepted D67528: [TextAPI] Add New Supported Platforms.

LGTM

Sep 13 2019, 9:26 AM · Restricted Project
ributzka added inline comments to D67529: [TextAPI] Introduce TBDv4.
Sep 13 2019, 9:15 AM · Restricted Project

Sep 12 2019

ributzka added inline comments to D67529: [TextAPI] Introduce TBDv4.
Sep 12 2019, 5:00 PM · Restricted Project

Sep 11 2019

ributzka added a comment to D67249: [Modules][PCH] Hash input files content.

Did you try xxHash64?

Sep 11 2019, 4:17 PM · Restricted Project

Sep 10 2019

ributzka accepted D66160: [llvm-nm] Add tapi file support.

LGTM

Sep 10 2019, 3:06 PM · Restricted Project
ributzka added a comment to D66160: [llvm-nm] Add tapi file support.

The motivation to add this to llvm-nm, is to get the same functionally back that we lost with adding TBD files. Using it for testing is a nice side benefit.

Sep 10 2019, 9:30 AM · Restricted Project

Sep 9 2019

ributzka added a reviewer for D67249: [Modules][PCH] Hash input files content: ributzka.
Sep 9 2019, 2:56 PM · Restricted Project

Sep 6 2019

ributzka added inline comments to D67249: [Modules][PCH] Hash input files content.
Sep 6 2019, 3:42 PM · Restricted Project
ributzka added inline comments to D66160: [llvm-nm] Add tapi file support.
Sep 6 2019, 10:51 AM · Restricted Project

Sep 5 2019

ributzka accepted D67204: [TextAPI] update interface file for filtered iter.

LGTM

Sep 5 2019, 10:06 AM · Restricted Project

Sep 3 2019

ributzka committed rL370783: Request commit access for ributzka.
Request commit access for ributzka
Sep 3 2019, 10:01 AM

Aug 20 2019

ributzka added inline comments to D59945: [ObjCMetadata] Add support for reading Objective-C metadata.
Aug 20 2019, 11:02 AM · Restricted Project
ributzka accepted D66159: [Object] Add tapi files to object.

LGTM, but we should also wait for Lang's feedback.

Aug 20 2019, 10:27 AM · Restricted Project

Aug 14 2019

ributzka abandoned D37820: [BinaryFormat] Teach identify_magic about Tapi files..

New version is tracked here: D66149

Aug 14 2019, 9:59 AM · Restricted Project

Aug 13 2019

ributzka added inline comments to D66149: [BinaryFormat] Teach identify_magic about Tapi files..
Aug 13 2019, 5:18 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
ributzka added inline comments to D66149: [BinaryFormat] Teach identify_magic about Tapi files..
Aug 13 2019, 5:17 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
ributzka added inline comments to D66147: [TextAPI] Update reader to be supported by lib/Object.
Aug 13 2019, 2:01 PM · Restricted Project

Aug 12 2019

ributzka closed D66041: [TextAPI] Fix & Add tests for tbd files version 3..
Aug 12 2019, 4:01 PM · Restricted Project
ributzka committed rGb978c51ce4e9: [TextAPI] Fix & Add tests for tbd files version 3. (authored by ributzka).
[TextAPI] Fix & Add tests for tbd files version 3.
Aug 12 2019, 4:01 PM
ributzka committed rL368630: [TextAPI] Fix & Add tests for tbd files version 3..
[TextAPI] Fix & Add tests for tbd files version 3.
Aug 12 2019, 4:00 PM
ributzka added a comment to D66041: [TextAPI] Fix & Add tests for tbd files version 3..

Sure, np

Aug 12 2019, 3:42 PM · Restricted Project
ributzka committed rGd9bc9c816117: Revert "Disable MachO TBD write tests for Windows." (authored by ributzka).
Revert "Disable MachO TBD write tests for Windows."
Aug 12 2019, 12:52 PM
ributzka committed rL368611: Revert "Disable MachO TBD write tests for Windows.".
Revert "Disable MachO TBD write tests for Windows."
Aug 12 2019, 12:52 PM
ributzka accepted D66041: [TextAPI] Fix & Add tests for tbd files version 3..

Hi Cyndy, thanks for catching this copy-past-o bug. LGTM

Aug 12 2019, 9:08 AM · Restricted Project

Jun 20 2019

ributzka added a comment to D63433: [RISCV] Add RISCV-specific TargetTransformInfo.

If I recall correctly, then getIntImmCost(const APInt &Imm) predates the ConstantHoisting pass and is also used by other optimizations. The purpose of that hook is to calculate the materialization cost of a constant and is context free.

Jun 20 2019, 11:04 AM · Restricted Project

Apr 4 2019

ributzka committed rG875565e55931: [TextAPI] Prefix all architecture enums to fix the build on i386. (authored by ributzka).
[TextAPI] Prefix all architecture enums to fix the build on i386.
Apr 4 2019, 3:58 PM
ributzka committed rL357733: [TextAPI] Prefix all architecture enums to fix the build on i386..
[TextAPI] Prefix all architecture enums to fix the build on i386.
Apr 4 2019, 3:58 PM
ributzka closed D60241: [TextAPI] Prefix all architecture enums to fix the build on i386..
Apr 4 2019, 3:57 PM · Restricted Project

Apr 3 2019

ributzka created D60241: [TextAPI] Prefix all architecture enums to fix the build on i386..
Apr 3 2019, 5:25 PM · Restricted Project
ributzka accepted D60198: [TextAPI] Fix off-by-one error in the bit index extraction loop.

Thanks for catching this. LGTM.

Apr 3 2019, 8:39 AM · Restricted Project

Mar 22 2019

ributzka committed rG197ae2239382: Disable MachO TBD write tests for Windows. (authored by ributzka).
Disable MachO TBD write tests for Windows.
Mar 22 2019, 5:04 PM
ributzka committed rL356826: Disable MachO TBD write tests for Windows..
Disable MachO TBD write tests for Windows.
Mar 22 2019, 5:02 PM
ributzka committed rGb0ae52d814d7: Followup for r356820 to fix the bots. (authored by ributzka).
Followup for r356820 to fix the bots.
Mar 22 2019, 4:10 PM
ributzka committed rL356823: Followup for r356820 to fix the bots..
Followup for r356820 to fix the bots.
Mar 22 2019, 4:10 PM
ributzka committed rG32cb594177df: [TextAPI] TBD Reader/Writer (authored by ributzka).
[TextAPI] TBD Reader/Writer
Mar 22 2019, 3:46 PM
ributzka committed rL356820: [TextAPI] TBD Reader/Writer.
[TextAPI] TBD Reader/Writer
Mar 22 2019, 3:46 PM

Nov 30 2018

ributzka accepted D55151: [gcov/Darwin] Ensure external symbols are exported when using an export list.

LGTM

Nov 30 2018, 5:14 PM
ributzka added inline comments to D55151: [gcov/Darwin] Ensure external symbols are exported when using an export list.
Nov 30 2018, 5:06 PM

Nov 28 2018

ributzka committed rL347838: Revert "[TextAPI] Fix a memory leak in the TBD reader.".
Revert "[TextAPI] Fix a memory leak in the TBD reader."
Nov 28 2018, 10:36 PM
ributzka committed rL347837: [TextAPI] Fix a memory leak in the TBD reader..
[TextAPI] Fix a memory leak in the TBD reader.
Nov 28 2018, 10:19 PM
ributzka committed rL347836: [TextAPI] Switch back to a custom Platform enum..
[TextAPI] Switch back to a custom Platform enum.
Nov 28 2018, 9:59 PM
ributzka committed rL347827: [TextAPI] TBD Reader/Writer (bot fixes: take 2).
[TextAPI] TBD Reader/Writer (bot fixes: take 2)
Nov 28 2018, 6:31 PM
ributzka committed rL347824: [TextAPI] TBD Reader/Writer (bot fixes).
[TextAPI] TBD Reader/Writer (bot fixes)
Nov 28 2018, 5:58 PM
ributzka committed rL347823: [TextAPI] TBD Reader/Writer.
[TextAPI] TBD Reader/Writer
Nov 28 2018, 5:23 PM
ributzka committed rL347809: Revert "[TextAPI] TBD Reader/Writer".
Revert "[TextAPI] TBD Reader/Writer"
Nov 28 2018, 1:41 PM
ributzka closed D53945: [TextAPI] TBD Reader/Writer.
Nov 28 2018, 1:36 PM · Restricted Project
ributzka committed rL347808: [TextAPI] TBD Reader/Writer.
[TextAPI] TBD Reader/Writer
Nov 28 2018, 1:30 PM
ributzka added a comment to D53945: [TextAPI] TBD Reader/Writer.

Would there be an objection to using llvm::tapi::MachO or llvm::tapi::macho? At least for ELF it doesn't make much sense to put the tapi code in the same namespace as BinaryFormat/ELF so it would be nice to add the extra namespace. I'm not married to the idea however.

Nov 28 2018, 12:27 PM · Restricted Project
ributzka added inline comments to D53945: [TextAPI] TBD Reader/Writer.
Nov 28 2018, 11:49 AM · Restricted Project
ributzka updated the diff for D53945: [TextAPI] TBD Reader/Writer.
  • rename setArchitectures to addArchitectures
  • fix comments
  • use BitmaskEnum in several places to remove custom static_cast code.
Nov 28 2018, 11:48 AM · Restricted Project

Nov 26 2018

ributzka updated the diff for D53945: [TextAPI] TBD Reader/Writer.
  • Rebase patch on D53051
  • Remove registry and add separate reader and writer classes
  • Move everything into the MachO namespace and sub-folder
Nov 26 2018, 10:39 AM · Restricted Project

Nov 14 2018

ributzka added inline comments to D53051: [llvm-tapi] initial commit, supports ELF text stubs.
Nov 14 2018, 2:50 PM
ributzka added inline comments to D53051: [llvm-tapi] initial commit, supports ELF text stubs.
Nov 14 2018, 2:48 PM
ributzka accepted D53051: [llvm-tapi] initial commit, supports ELF text stubs.
Nov 14 2018, 9:20 AM

Nov 12 2018

ributzka added a comment to D53945: [TextAPI] TBD Reader/Writer.

I will update the patch with more changes based on the feedback so far.

Nov 12 2018, 10:46 AM · Restricted Project

Nov 1 2018

ributzka added inline comments to D53945: [TextAPI] TBD Reader/Writer.
Nov 1 2018, 4:01 PM · Restricted Project
ributzka updated the diff for D53945: [TextAPI] TBD Reader/Writer.

Add missing license header.

Nov 1 2018, 12:28 PM · Restricted Project

Oct 31 2018

ributzka updated subscribers of D37820: [BinaryFormat] Teach identify_magic about Tapi files..

We do have that now. All TAPI files start now with "--- !tapi". It is only
that the first version doesn't have that marker and that is why we have to
fall back to this extra check.

Oct 31 2018, 2:14 PM · Restricted Project
ributzka updated the diff for D53945: [TextAPI] TBD Reader/Writer.

Replace std::sort with llvm::sort and fix copy-paste-o bugs.

Oct 31 2018, 12:42 PM · Restricted Project
ributzka created D53945: [TextAPI] TBD Reader/Writer.
Oct 31 2018, 11:40 AM · Restricted Project

Sep 19 2018

ributzka committed rL342593: Fix the build when LLVM_TARGETS_TO_BUILD is empty..
Fix the build when LLVM_TARGETS_TO_BUILD is empty.
Sep 19 2018, 2:37 PM

Aug 23 2018

ributzka added a comment to D51189: [Sema][ObjC] Infer availability of +new from availability of -init.

TAPI mostly cares about linkable symbols, so this shouldn't be a problem.

Aug 23 2018, 6:37 PM

Sep 13 2017

ributzka set the repository for D37820: [BinaryFormat] Teach identify_magic about Tapi files. to rL LLVM.
Sep 13 2017, 12:04 PM · Restricted Project
ributzka created D37820: [BinaryFormat] Teach identify_magic about Tapi files..
Sep 13 2017, 12:03 PM · Restricted Project