User Details
- User Since
- Oct 18 2013, 11:20 AM (492 w, 2 d)
Tue, Mar 21
LGTM
Fri, Mar 17
Thu, Mar 16
Thanks for the prompt reviews
Feb 22 2023
LGTM
LGTM
LGTM
Feb 21 2023
Feb 20 2023
Jan 13 2023
If this can be fixed without affecting any potential clients, then I am all for it. In hindsight it might have been better to make a use case specific calling convention instead and not a generic one that everyone could depend on. Oen possible solution would be to make a Chromium specific calling convention and also name it as such. This would provide clear expectations what it is intended for and how is supposed to use it. Furthermore this would give you the option of changing it in the future if the need should arise.
Dec 13 2022
LGTM
Dec 12 2022
Test case?
Oct 20 2022
LGTM
Oct 19 2022
Oct 15 2022
We could invoke clang with the -stats option and compare the result against the expected number of stat calls.
Oct 11 2022
LGTM
Oct 5 2022
This doesn't affect any tests?
This makes sense. We shouldn't re-validate system headers when -fmodules-validate-once-per-build-session is passed too.
Aug 30 2022
Seems straightforward. LGTM.
Aug 29 2022
Aug 4 2022
RISCV is not my expertise, but LGTM with respect to constant hoisting.
Jun 15 2022
OpenMP pre-merge check issues seem unrelated to this change.
Thank you Pete
Jun 14 2022
Apr 19 2022
Mar 23 2022
LGTM
Mar 22 2022
Mar 17 2022
Nice! Thank you for adding support for multiple headers. Is this a step towards the json input file list?
Mar 9 2022
Jan 21 2022
LGTM. Just a few minor nits.
Jan 14 2022
LGTM
Jan 13 2022
The unit test failure on Windows seems unrelated, because I have seen it in a previous pre-merge check too. Furthermore, this should be a NFC.
Jan 12 2022
Dec 17 2021
Oct 6 2021
Jun 2 2021
Apr 5 2021
LGTM
Jun 30 2020
LGTM
Jun 8 2020
Apr 1 2020
LGTM
Feb 11 2020
LGTM
Jan 15 2020
SpareSet is deterministic given the same input order - similar to SetVector. Printing the result is not the common use case, so changing the print function to sort the output first might be more useful for testing purposes.
Nov 26 2019
Nov 21 2019
Oct 29 2019
Oct 7 2019
Thanks Cyndy. LGTM
Does nm print now all symbols - including the inlined ones? That would be an unexpected change, because we don't do the same for MachOs that have re-exported frameworks. I think this feature should be guarded by an option.
Sep 27 2019
Sep 24 2019
Sep 23 2019
Sep 18 2019
Sep 13 2019
xxhash64 is apparently faster than MD5 and SHA1, and produces good quality hashes. I am not sure about the hash quality of hash_code for this purpose.
LGTM
LGTM
Sep 12 2019
Sep 11 2019
Did you try xxHash64?
Sep 10 2019
LGTM
The motivation to add this to llvm-nm, is to get the same functionally back that we lost with adding TBD files. Using it for testing is a nice side benefit.
Sep 9 2019
Sep 6 2019
Sep 5 2019
LGTM
Sep 3 2019
Aug 20 2019
LGTM, but we should also wait for Lang's feedback.
Aug 14 2019
New version is tracked here: D66149
Aug 13 2019
Aug 12 2019
Sure, np
Hi Cyndy, thanks for catching this copy-past-o bug. LGTM
Jun 20 2019
If I recall correctly, then getIntImmCost(const APInt &Imm) predates the ConstantHoisting pass and is also used by other optimizations. The purpose of that hook is to calculate the materialization cost of a constant and is context free.
Apr 4 2019
Apr 3 2019
Thanks for catching this. LGTM.