Page MenuHomePhabricator

ributzka (Juergen Ributzka)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 18 2013, 11:20 AM (308 w, 6 d)

Recent Activity

Wed, Sep 18

ributzka added inline comments to D67529: [TextAPI] Introduce TBDv4.
Wed, Sep 18, 11:30 AM · Restricted Project

Fri, Sep 13

ributzka added a comment to D67249: [Modules][PCH] Hash input files content.

xxhash64 is apparently faster than MD5 and SHA1, and produces good quality hashes. I am not sure about the hash quality of hash_code for this purpose.

Fri, Sep 13, 3:35 PM · Restricted Project
ributzka accepted D67527: [TextAPI] Arch&Platform to Target.

LGTM

Fri, Sep 13, 10:33 AM · Restricted Project
ributzka accepted D67528: [TextAPI] Add New Supported Platforms.

LGTM

Fri, Sep 13, 9:26 AM · Restricted Project
ributzka added inline comments to D67529: [TextAPI] Introduce TBDv4.
Fri, Sep 13, 9:15 AM · Restricted Project

Thu, Sep 12

ributzka added inline comments to D67529: [TextAPI] Introduce TBDv4.
Thu, Sep 12, 5:00 PM · Restricted Project

Wed, Sep 11

ributzka added a comment to D67249: [Modules][PCH] Hash input files content.

Did you try xxHash64?

Wed, Sep 11, 4:17 PM · Restricted Project

Tue, Sep 10

ributzka accepted D66160: [llvm-nm] Add tapi file support.

LGTM

Tue, Sep 10, 3:06 PM · Restricted Project
ributzka added a comment to D66160: [llvm-nm] Add tapi file support.

The motivation to add this to llvm-nm, is to get the same functionally back that we lost with adding TBD files. Using it for testing is a nice side benefit.

Tue, Sep 10, 9:30 AM · Restricted Project

Mon, Sep 9

ributzka added a reviewer for D67249: [Modules][PCH] Hash input files content: ributzka.
Mon, Sep 9, 2:56 PM · Restricted Project

Fri, Sep 6

ributzka added inline comments to D67249: [Modules][PCH] Hash input files content.
Fri, Sep 6, 3:42 PM · Restricted Project
ributzka added inline comments to D66160: [llvm-nm] Add tapi file support.
Fri, Sep 6, 10:51 AM · Restricted Project

Thu, Sep 5

ributzka accepted D67204: [TextAPI] update interface file for filtered iter.

LGTM

Thu, Sep 5, 10:06 AM · Restricted Project

Tue, Sep 3

ributzka committed rL370783: Request commit access for ributzka.
Request commit access for ributzka
Tue, Sep 3, 10:01 AM

Aug 20 2019

ributzka added inline comments to D59945: [ObjCMetadata] Add support for reading Objective-C metadata.
Aug 20 2019, 11:02 AM · Restricted Project
ributzka accepted D66159: [Object] Add tapi files to object.

LGTM, but we should also wait for Lang's feedback.

Aug 20 2019, 10:27 AM · Restricted Project

Aug 14 2019

ributzka abandoned D37820: [BinaryFormat] Teach identify_magic about Tapi files..

New version is tracked here: D66149

Aug 14 2019, 9:59 AM · Restricted Project

Aug 13 2019

ributzka added inline comments to D66149: [BinaryFormat] Teach identify_magic about Tapi files..
Aug 13 2019, 5:18 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
ributzka added inline comments to D66149: [BinaryFormat] Teach identify_magic about Tapi files..
Aug 13 2019, 5:17 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
ributzka added inline comments to D66147: [TextAPI] Update reader to be supported by lib/Object.
Aug 13 2019, 2:01 PM · Restricted Project

Aug 12 2019

ributzka closed D66041: [TextAPI] Fix & Add tests for tbd files version 3..
Aug 12 2019, 4:01 PM · Restricted Project
ributzka committed rGb978c51ce4e9: [TextAPI] Fix & Add tests for tbd files version 3. (authored by ributzka).
[TextAPI] Fix & Add tests for tbd files version 3.
Aug 12 2019, 4:01 PM
ributzka committed rL368630: [TextAPI] Fix & Add tests for tbd files version 3..
[TextAPI] Fix & Add tests for tbd files version 3.
Aug 12 2019, 4:00 PM
ributzka added a comment to D66041: [TextAPI] Fix & Add tests for tbd files version 3..

Sure, np

Aug 12 2019, 3:42 PM · Restricted Project
ributzka committed rGd9bc9c816117: Revert "Disable MachO TBD write tests for Windows." (authored by ributzka).
Revert "Disable MachO TBD write tests for Windows."
Aug 12 2019, 12:52 PM
ributzka committed rL368611: Revert "Disable MachO TBD write tests for Windows.".
Revert "Disable MachO TBD write tests for Windows."
Aug 12 2019, 12:52 PM
ributzka accepted D66041: [TextAPI] Fix & Add tests for tbd files version 3..

Hi Cyndy, thanks for catching this copy-past-o bug. LGTM

Aug 12 2019, 9:08 AM · Restricted Project

Jun 20 2019

ributzka added a comment to D63433: [RISCV] Add RISCV-specific TargetTransformInfo.

If I recall correctly, then getIntImmCost(const APInt &Imm) predates the ConstantHoisting pass and is also used by other optimizations. The purpose of that hook is to calculate the materialization cost of a constant and is context free.

Jun 20 2019, 11:04 AM · Restricted Project

Apr 4 2019

ributzka committed rG875565e55931: [TextAPI] Prefix all architecture enums to fix the build on i386. (authored by ributzka).
[TextAPI] Prefix all architecture enums to fix the build on i386.
Apr 4 2019, 3:58 PM
ributzka committed rL357733: [TextAPI] Prefix all architecture enums to fix the build on i386..
[TextAPI] Prefix all architecture enums to fix the build on i386.
Apr 4 2019, 3:58 PM
ributzka closed D60241: [TextAPI] Prefix all architecture enums to fix the build on i386..
Apr 4 2019, 3:57 PM · Restricted Project

Apr 3 2019

ributzka created D60241: [TextAPI] Prefix all architecture enums to fix the build on i386..
Apr 3 2019, 5:25 PM · Restricted Project
ributzka accepted D60198: [TextAPI] Fix off-by-one error in the bit index extraction loop.

Thanks for catching this. LGTM.

Apr 3 2019, 8:39 AM · Restricted Project

Mar 22 2019

ributzka committed rG197ae2239382: Disable MachO TBD write tests for Windows. (authored by ributzka).
Disable MachO TBD write tests for Windows.
Mar 22 2019, 5:04 PM
ributzka committed rL356826: Disable MachO TBD write tests for Windows..
Disable MachO TBD write tests for Windows.
Mar 22 2019, 5:02 PM
ributzka committed rGb0ae52d814d7: Followup for r356820 to fix the bots. (authored by ributzka).
Followup for r356820 to fix the bots.
Mar 22 2019, 4:10 PM
ributzka committed rL356823: Followup for r356820 to fix the bots..
Followup for r356820 to fix the bots.
Mar 22 2019, 4:10 PM
ributzka committed rG32cb594177df: [TextAPI] TBD Reader/Writer (authored by ributzka).
[TextAPI] TBD Reader/Writer
Mar 22 2019, 3:46 PM
ributzka committed rL356820: [TextAPI] TBD Reader/Writer.
[TextAPI] TBD Reader/Writer
Mar 22 2019, 3:46 PM

Nov 30 2018

ributzka accepted D55151: [gcov/Darwin] Ensure external symbols are exported when using an export list.

LGTM

Nov 30 2018, 5:14 PM
ributzka added inline comments to D55151: [gcov/Darwin] Ensure external symbols are exported when using an export list.
Nov 30 2018, 5:06 PM

Nov 28 2018

ributzka committed rL347838: Revert "[TextAPI] Fix a memory leak in the TBD reader.".
Revert "[TextAPI] Fix a memory leak in the TBD reader."
Nov 28 2018, 10:36 PM
ributzka committed rL347837: [TextAPI] Fix a memory leak in the TBD reader..
[TextAPI] Fix a memory leak in the TBD reader.
Nov 28 2018, 10:19 PM
ributzka committed rL347836: [TextAPI] Switch back to a custom Platform enum..
[TextAPI] Switch back to a custom Platform enum.
Nov 28 2018, 9:59 PM
ributzka committed rL347827: [TextAPI] TBD Reader/Writer (bot fixes: take 2).
[TextAPI] TBD Reader/Writer (bot fixes: take 2)
Nov 28 2018, 6:31 PM
ributzka committed rL347824: [TextAPI] TBD Reader/Writer (bot fixes).
[TextAPI] TBD Reader/Writer (bot fixes)
Nov 28 2018, 5:58 PM
ributzka committed rL347823: [TextAPI] TBD Reader/Writer.
[TextAPI] TBD Reader/Writer
Nov 28 2018, 5:23 PM
ributzka committed rL347809: Revert "[TextAPI] TBD Reader/Writer".
Revert "[TextAPI] TBD Reader/Writer"
Nov 28 2018, 1:41 PM
ributzka closed D53945: [TextAPI] TBD Reader/Writer.
Nov 28 2018, 1:36 PM · Restricted Project
ributzka added an edge to rL347808: [TextAPI] TBD Reader/Writer: D53945: [TextAPI] TBD Reader/Writer.
Nov 28 2018, 1:35 PM
ributzka added 1 commit(s) for D53945: [TextAPI] TBD Reader/Writer: rL347808: [TextAPI] TBD Reader/Writer.
Nov 28 2018, 1:35 PM · Restricted Project
ributzka removed a parent revision for D53945: [TextAPI] TBD Reader/Writer: D53051: [llvm-tapi] initial commit, supports ELF text stubs.
Nov 28 2018, 1:33 PM · Restricted Project
ributzka removed a child revision for D53051: [llvm-tapi] initial commit, supports ELF text stubs: D53945: [TextAPI] TBD Reader/Writer.
Nov 28 2018, 1:33 PM
ributzka committed rL347808: [TextAPI] TBD Reader/Writer.
[TextAPI] TBD Reader/Writer
Nov 28 2018, 1:30 PM
ributzka added reviewers for D54674: [llvm-objcopy] First bits for MachO : lhames, pete.
Nov 28 2018, 12:58 PM · Restricted Project
ributzka added a comment to D53945: [TextAPI] TBD Reader/Writer.

Would there be an objection to using llvm::tapi::MachO or llvm::tapi::macho? At least for ELF it doesn't make much sense to put the tapi code in the same namespace as BinaryFormat/ELF so it would be nice to add the extra namespace. I'm not married to the idea however.

Nov 28 2018, 12:27 PM · Restricted Project
ributzka added inline comments to D53945: [TextAPI] TBD Reader/Writer.
Nov 28 2018, 11:49 AM · Restricted Project
ributzka updated the diff for D53945: [TextAPI] TBD Reader/Writer.
  • rename setArchitectures to addArchitectures
  • fix comments
  • use BitmaskEnum in several places to remove custom static_cast code.
Nov 28 2018, 11:48 AM · Restricted Project

Nov 26 2018

ributzka edited parent revisions for D53945: [TextAPI] TBD Reader/Writer, added: 1; removed: 1.
Nov 26 2018, 10:39 AM · Restricted Project
ributzka added a child revision for D53051: [llvm-tapi] initial commit, supports ELF text stubs: D53945: [TextAPI] TBD Reader/Writer.
Nov 26 2018, 10:39 AM
ributzka removed a child revision for D37820: [BinaryFormat] Teach identify_magic about Tapi files.: D53945: [TextAPI] TBD Reader/Writer.
Nov 26 2018, 10:39 AM · Restricted Project
ributzka updated the diff for D53945: [TextAPI] TBD Reader/Writer.
  • Rebase patch on D53051
  • Remove registry and add separate reader and writer classes
  • Move everything into the MachO namespace and sub-folder
Nov 26 2018, 10:39 AM · Restricted Project

Nov 14 2018

ributzka added inline comments to D53051: [llvm-tapi] initial commit, supports ELF text stubs.
Nov 14 2018, 2:50 PM
ributzka added inline comments to D53051: [llvm-tapi] initial commit, supports ELF text stubs.
Nov 14 2018, 2:48 PM
ributzka accepted D53051: [llvm-tapi] initial commit, supports ELF text stubs.
Nov 14 2018, 9:20 AM

Nov 12 2018

ributzka added a comment to D53945: [TextAPI] TBD Reader/Writer.

I will update the patch with more changes based on the feedback so far.

Nov 12 2018, 10:46 AM · Restricted Project

Nov 1 2018

ributzka added inline comments to D53945: [TextAPI] TBD Reader/Writer.
Nov 1 2018, 4:01 PM · Restricted Project
ributzka updated the diff for D53945: [TextAPI] TBD Reader/Writer.

Add missing license header.

Nov 1 2018, 12:28 PM · Restricted Project

Oct 31 2018

ributzka updated subscribers of D37820: [BinaryFormat] Teach identify_magic about Tapi files..

We do have that now. All TAPI files start now with "--- !tapi". It is only
that the first version doesn't have that marker and that is why we have to
fall back to this extra check.

Oct 31 2018, 2:14 PM · Restricted Project
ributzka updated the diff for D53945: [TextAPI] TBD Reader/Writer.

Replace std::sort with llvm::sort and fix copy-paste-o bugs.

Oct 31 2018, 12:42 PM · Restricted Project
ributzka added a child revision for D37820: [BinaryFormat] Teach identify_magic about Tapi files.: D53945: [TextAPI] TBD Reader/Writer.
Oct 31 2018, 11:41 AM · Restricted Project
ributzka added a parent revision for D53945: [TextAPI] TBD Reader/Writer: D37820: [BinaryFormat] Teach identify_magic about Tapi files..
Oct 31 2018, 11:41 AM · Restricted Project
ributzka created D53945: [TextAPI] TBD Reader/Writer.
Oct 31 2018, 11:40 AM · Restricted Project

Sep 19 2018

ributzka committed rL342593: Fix the build when LLVM_TARGETS_TO_BUILD is empty..
Fix the build when LLVM_TARGETS_TO_BUILD is empty.
Sep 19 2018, 2:37 PM

Aug 23 2018

ributzka added a comment to D51189: [Sema][ObjC] Infer availability of +new from availability of -init.

TAPI mostly cares about linkable symbols, so this shouldn't be a problem.

Aug 23 2018, 6:37 PM

Sep 13 2017

ributzka set the repository for D37820: [BinaryFormat] Teach identify_magic about Tapi files. to rL LLVM.
Sep 13 2017, 12:04 PM · Restricted Project
ributzka created D37820: [BinaryFormat] Teach identify_magic about Tapi files..
Sep 13 2017, 12:03 PM · Restricted Project

Aug 28 2017

ributzka committed rL311965: Re-apply "Fix cmake check for futimens when deploying to earlier macOS releases..
Re-apply "Fix cmake check for futimens when deploying to earlier macOS releases.
Aug 28 2017, 5:36 PM
ributzka committed rL311953: Revert "Fix cmake check for futimens when deploying to earlier macOS releases.".
Revert "Fix cmake check for futimens when deploying to earlier macOS releases."
Aug 28 2017, 4:25 PM
ributzka added a comment to D37027: Fix cmake check for futimens when deploying to earlier macOS releases..

Thanks Chris.

Aug 28 2017, 4:09 PM
ributzka added a comment to rL311949: Fix cmake check for futimens when deploying to earlier macOS releases..

Thanks Chris

Aug 28 2017, 4:09 PM
ributzka committed rL311949: Fix cmake check for futimens when deploying to earlier macOS releases..
Fix cmake check for futimens when deploying to earlier macOS releases.
Aug 28 2017, 4:06 PM
ributzka closed D37027: Fix cmake check for futimens when deploying to earlier macOS releases. by committing rL311949: Fix cmake check for futimens when deploying to earlier macOS releases..
Aug 28 2017, 4:06 PM
ributzka added a comment to D37027: Fix cmake check for futimens when deploying to earlier macOS releases..

gentle ping :-)

Aug 28 2017, 9:45 AM

Aug 22 2017

ributzka created D37027: Fix cmake check for futimens when deploying to earlier macOS releases..
Aug 22 2017, 2:36 PM
ributzka accepted D35385: [Driver] Darwin: Link in the profile runtime archive first.

Nice cleanup with the RuntimeLinkOptions enum. LGTM

Aug 22 2017, 11:52 AM

Jul 27 2017

ributzka added inline comments to D35908: [YAML] Use {Specific}BumpPtrAllocators for HNodes..
Jul 27 2017, 10:30 AM
ributzka updated the diff for D35908: [YAML] Use {Specific}BumpPtrAllocators for HNodes..

Updating D35908: [YAML] Use {Specific}BumpPtrAllocators for HNodes.

Jul 27 2017, 10:30 AM

Jul 26 2017

ributzka removed a reviewer for D35908: [YAML] Use {Specific}BumpPtrAllocators for HNodes.: llvm-commits.
Jul 26 2017, 1:26 PM
ributzka added a reviewer for D35908: [YAML] Use {Specific}BumpPtrAllocators for HNodes.: llvm-commits.
Jul 26 2017, 11:44 AM
ributzka created D35908: [YAML] Use {Specific}BumpPtrAllocators for HNodes..
Jul 26 2017, 11:43 AM

Jun 30 2017

ributzka committed rL306842: [DWARF] Don't include TestingSupport in LLVM_LINK_COMPONENTS..
[DWARF] Don't include TestingSupport in LLVM_LINK_COMPONENTS.
Jun 30 2017, 9:51 AM

Jun 26 2017

ributzka accepted D34576: [ConstantHoisting] Avoid hoisting constants in GEPs that index into a struct type..

Never mind. LGTM

Jun 26 2017, 10:55 AM
ributzka added a comment to D34576: [ConstantHoisting] Avoid hoisting constants in GEPs that index into a struct type..

Why not fix AddressingModeMatcher not to crash first?

Jun 26 2017, 10:30 AM

Apr 21 2017

ributzka committed rL300994: Remove empty and unused header file..
Remove empty and unused header file.
Apr 21 2017, 9:18 AM

Mar 30 2017

ributzka committed rL299104: [Object] Remove check for BIND_OPCODE_DONE/REBASE_OPCODE_DONE..
[Object] Remove check for BIND_OPCODE_DONE/REBASE_OPCODE_DONE.
Mar 30 2017, 1:09 PM

Mar 28 2017

ributzka committed rL298967: Revert "Added `applyAtomicChanges` function.".
Revert "Added `applyAtomicChanges` function."
Mar 28 2017, 5:37 PM
ributzka committed rL298966: Revert "Try to unbreak buildbots after r298913.".
Revert "Try to unbreak buildbots after r298913."
Mar 28 2017, 5:37 PM
ributzka committed rL298965: Revert "clangToolingRefactor: Add libdeps upon clangFormat in r298913.".
Revert "clangToolingRefactor: Add libdeps upon clangFormat in r298913."
Mar 28 2017, 5:36 PM

Mar 27 2017

ributzka committed rL298886: [libfuzzer] Remove XFAIL for OutOfMemory test..
[libfuzzer] Remove XFAIL for OutOfMemory test.
Mar 27 2017, 3:45 PM