Page MenuHomePhabricator

ributzka (Juergen Ributzka)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 18 2013, 11:20 AM (300 w, 2 d)

Recent Activity

Jun 20 2019

ributzka added a comment to D63433: [RISCV] Add RISCV-specific TargetTransformInfo.

If I recall correctly, then getIntImmCost(const APInt &Imm) predates the ConstantHoisting pass and is also used by other optimizations. The purpose of that hook is to calculate the materialization cost of a constant and is context free.

Jun 20 2019, 11:04 AM · Restricted Project

Apr 4 2019

ributzka committed rG875565e55931: [TextAPI] Prefix all architecture enums to fix the build on i386. (authored by ributzka).
[TextAPI] Prefix all architecture enums to fix the build on i386.
Apr 4 2019, 3:58 PM
ributzka committed rL357733: [TextAPI] Prefix all architecture enums to fix the build on i386..
[TextAPI] Prefix all architecture enums to fix the build on i386.
Apr 4 2019, 3:58 PM
ributzka closed D60241: [TextAPI] Prefix all architecture enums to fix the build on i386..
Apr 4 2019, 3:57 PM · Restricted Project

Apr 3 2019

ributzka created D60241: [TextAPI] Prefix all architecture enums to fix the build on i386..
Apr 3 2019, 5:25 PM · Restricted Project
ributzka accepted D60198: [TextAPI] Fix off-by-one error in the bit index extraction loop.

Thanks for catching this. LGTM.

Apr 3 2019, 8:39 AM · Restricted Project

Mar 22 2019

ributzka committed rG197ae2239382: Disable MachO TBD write tests for Windows. (authored by ributzka).
Disable MachO TBD write tests for Windows.
Mar 22 2019, 5:04 PM
ributzka committed rL356826: Disable MachO TBD write tests for Windows..
Disable MachO TBD write tests for Windows.
Mar 22 2019, 5:02 PM
ributzka committed rGb0ae52d814d7: Followup for r356820 to fix the bots. (authored by ributzka).
Followup for r356820 to fix the bots.
Mar 22 2019, 4:10 PM
ributzka committed rL356823: Followup for r356820 to fix the bots..
Followup for r356820 to fix the bots.
Mar 22 2019, 4:10 PM
ributzka committed rG32cb594177df: [TextAPI] TBD Reader/Writer (authored by ributzka).
[TextAPI] TBD Reader/Writer
Mar 22 2019, 3:46 PM
ributzka committed rL356820: [TextAPI] TBD Reader/Writer.
[TextAPI] TBD Reader/Writer
Mar 22 2019, 3:46 PM

Nov 30 2018

ributzka accepted D55151: [gcov/Darwin] Ensure external symbols are exported when using an export list.

LGTM

Nov 30 2018, 5:14 PM
ributzka added inline comments to D55151: [gcov/Darwin] Ensure external symbols are exported when using an export list.
Nov 30 2018, 5:06 PM

Nov 28 2018

ributzka committed rL347838: Revert "[TextAPI] Fix a memory leak in the TBD reader.".
Revert "[TextAPI] Fix a memory leak in the TBD reader."
Nov 28 2018, 10:36 PM
ributzka committed rL347837: [TextAPI] Fix a memory leak in the TBD reader..
[TextAPI] Fix a memory leak in the TBD reader.
Nov 28 2018, 10:19 PM
ributzka committed rL347836: [TextAPI] Switch back to a custom Platform enum..
[TextAPI] Switch back to a custom Platform enum.
Nov 28 2018, 9:59 PM
ributzka committed rL347827: [TextAPI] TBD Reader/Writer (bot fixes: take 2).
[TextAPI] TBD Reader/Writer (bot fixes: take 2)
Nov 28 2018, 6:31 PM
ributzka committed rL347824: [TextAPI] TBD Reader/Writer (bot fixes).
[TextAPI] TBD Reader/Writer (bot fixes)
Nov 28 2018, 5:58 PM
ributzka committed rL347823: [TextAPI] TBD Reader/Writer.
[TextAPI] TBD Reader/Writer
Nov 28 2018, 5:23 PM
ributzka committed rL347809: Revert "[TextAPI] TBD Reader/Writer".
Revert "[TextAPI] TBD Reader/Writer"
Nov 28 2018, 1:41 PM
ributzka closed D53945: [TextAPI] TBD Reader/Writer.
Nov 28 2018, 1:36 PM · Restricted Project
ributzka added an edge to rL347808: [TextAPI] TBD Reader/Writer: D53945: [TextAPI] TBD Reader/Writer.
Nov 28 2018, 1:35 PM
ributzka added 1 commit(s) for D53945: [TextAPI] TBD Reader/Writer: rL347808: [TextAPI] TBD Reader/Writer.
Nov 28 2018, 1:35 PM · Restricted Project
ributzka removed a parent revision for D53945: [TextAPI] TBD Reader/Writer: D53051: [llvm-tapi] initial commit, supports ELF text stubs.
Nov 28 2018, 1:33 PM · Restricted Project
ributzka removed a child revision for D53051: [llvm-tapi] initial commit, supports ELF text stubs: D53945: [TextAPI] TBD Reader/Writer.
Nov 28 2018, 1:33 PM
ributzka committed rL347808: [TextAPI] TBD Reader/Writer.
[TextAPI] TBD Reader/Writer
Nov 28 2018, 1:30 PM
ributzka added reviewers for D54674: [llvm-objcopy] First bits for MachO : lhames, pete.
Nov 28 2018, 12:58 PM · Restricted Project
ributzka added a comment to D53945: [TextAPI] TBD Reader/Writer.

Would there be an objection to using llvm::tapi::MachO or llvm::tapi::macho? At least for ELF it doesn't make much sense to put the tapi code in the same namespace as BinaryFormat/ELF so it would be nice to add the extra namespace. I'm not married to the idea however.

Nov 28 2018, 12:27 PM · Restricted Project
ributzka added inline comments to D53945: [TextAPI] TBD Reader/Writer.
Nov 28 2018, 11:49 AM · Restricted Project
ributzka updated the diff for D53945: [TextAPI] TBD Reader/Writer.
  • rename setArchitectures to addArchitectures
  • fix comments
  • use BitmaskEnum in several places to remove custom static_cast code.
Nov 28 2018, 11:48 AM · Restricted Project

Nov 26 2018

ributzka edited parent revisions for D53945: [TextAPI] TBD Reader/Writer, added: 1; removed: 1.
Nov 26 2018, 10:39 AM · Restricted Project
ributzka added a child revision for D53051: [llvm-tapi] initial commit, supports ELF text stubs: D53945: [TextAPI] TBD Reader/Writer.
Nov 26 2018, 10:39 AM
ributzka removed a child revision for D37820: [BinaryFormat] Teach identify_magic about Tapi files.: D53945: [TextAPI] TBD Reader/Writer.
Nov 26 2018, 10:39 AM
ributzka updated the diff for D53945: [TextAPI] TBD Reader/Writer.
  • Rebase patch on D53051
  • Remove registry and add separate reader and writer classes
  • Move everything into the MachO namespace and sub-folder
Nov 26 2018, 10:39 AM · Restricted Project

Nov 14 2018

ributzka added inline comments to D53051: [llvm-tapi] initial commit, supports ELF text stubs.
Nov 14 2018, 2:50 PM
ributzka added inline comments to D53051: [llvm-tapi] initial commit, supports ELF text stubs.
Nov 14 2018, 2:48 PM
ributzka accepted D53051: [llvm-tapi] initial commit, supports ELF text stubs.
Nov 14 2018, 9:20 AM

Nov 12 2018

ributzka added a comment to D53945: [TextAPI] TBD Reader/Writer.

I will update the patch with more changes based on the feedback so far.

Nov 12 2018, 10:46 AM · Restricted Project

Nov 1 2018

ributzka added inline comments to D53945: [TextAPI] TBD Reader/Writer.
Nov 1 2018, 4:01 PM · Restricted Project
ributzka updated the diff for D53945: [TextAPI] TBD Reader/Writer.

Add missing license header.

Nov 1 2018, 12:28 PM · Restricted Project

Oct 31 2018

ributzka updated subscribers of D37820: [BinaryFormat] Teach identify_magic about Tapi files..

We do have that now. All TAPI files start now with "--- !tapi". It is only
that the first version doesn't have that marker and that is why we have to
fall back to this extra check.

Oct 31 2018, 2:14 PM
ributzka updated the diff for D53945: [TextAPI] TBD Reader/Writer.

Replace std::sort with llvm::sort and fix copy-paste-o bugs.

Oct 31 2018, 12:42 PM · Restricted Project
ributzka added a child revision for D37820: [BinaryFormat] Teach identify_magic about Tapi files.: D53945: [TextAPI] TBD Reader/Writer.
Oct 31 2018, 11:41 AM
ributzka added a parent revision for D53945: [TextAPI] TBD Reader/Writer: D37820: [BinaryFormat] Teach identify_magic about Tapi files..
Oct 31 2018, 11:41 AM · Restricted Project
ributzka created D53945: [TextAPI] TBD Reader/Writer.
Oct 31 2018, 11:40 AM · Restricted Project

Sep 19 2018

ributzka committed rL342593: Fix the build when LLVM_TARGETS_TO_BUILD is empty..
Fix the build when LLVM_TARGETS_TO_BUILD is empty.
Sep 19 2018, 2:37 PM

Aug 23 2018

ributzka added a comment to D51189: [Sema][ObjC] Infer availability of +new from availability of -init.

TAPI mostly cares about linkable symbols, so this shouldn't be a problem.

Aug 23 2018, 6:37 PM

Sep 13 2017

ributzka set the repository for D37820: [BinaryFormat] Teach identify_magic about Tapi files. to rL LLVM.
Sep 13 2017, 12:04 PM
ributzka created D37820: [BinaryFormat] Teach identify_magic about Tapi files..
Sep 13 2017, 12:03 PM

Aug 28 2017

ributzka committed rL311965: Re-apply "Fix cmake check for futimens when deploying to earlier macOS releases..
Re-apply "Fix cmake check for futimens when deploying to earlier macOS releases.
Aug 28 2017, 5:36 PM
ributzka committed rL311953: Revert "Fix cmake check for futimens when deploying to earlier macOS releases.".
Revert "Fix cmake check for futimens when deploying to earlier macOS releases."
Aug 28 2017, 4:25 PM
ributzka added a comment to D37027: Fix cmake check for futimens when deploying to earlier macOS releases..

Thanks Chris.

Aug 28 2017, 4:09 PM
ributzka added a comment to rL311949: Fix cmake check for futimens when deploying to earlier macOS releases..

Thanks Chris

Aug 28 2017, 4:09 PM
ributzka committed rL311949: Fix cmake check for futimens when deploying to earlier macOS releases..
Fix cmake check for futimens when deploying to earlier macOS releases.
Aug 28 2017, 4:06 PM
ributzka closed D37027: Fix cmake check for futimens when deploying to earlier macOS releases. by committing rL311949: Fix cmake check for futimens when deploying to earlier macOS releases..
Aug 28 2017, 4:06 PM
ributzka added a comment to D37027: Fix cmake check for futimens when deploying to earlier macOS releases..

gentle ping :-)

Aug 28 2017, 9:45 AM

Aug 22 2017

ributzka created D37027: Fix cmake check for futimens when deploying to earlier macOS releases..
Aug 22 2017, 2:36 PM
ributzka accepted D35385: [Driver] Darwin: Link in the profile runtime archive first.

Nice cleanup with the RuntimeLinkOptions enum. LGTM

Aug 22 2017, 11:52 AM

Jul 27 2017

ributzka added inline comments to D35908: [YAML] Use {Specific}BumpPtrAllocators for HNodes..
Jul 27 2017, 10:30 AM
ributzka updated the diff for D35908: [YAML] Use {Specific}BumpPtrAllocators for HNodes..

Updating D35908: [YAML] Use {Specific}BumpPtrAllocators for HNodes.

Jul 27 2017, 10:30 AM

Jul 26 2017

ributzka removed a reviewer for D35908: [YAML] Use {Specific}BumpPtrAllocators for HNodes.: llvm-commits.
Jul 26 2017, 1:26 PM
ributzka added a reviewer for D35908: [YAML] Use {Specific}BumpPtrAllocators for HNodes.: llvm-commits.
Jul 26 2017, 11:44 AM
ributzka created D35908: [YAML] Use {Specific}BumpPtrAllocators for HNodes..
Jul 26 2017, 11:43 AM

Jun 30 2017

ributzka committed rL306842: [DWARF] Don't include TestingSupport in LLVM_LINK_COMPONENTS..
[DWARF] Don't include TestingSupport in LLVM_LINK_COMPONENTS.
Jun 30 2017, 9:51 AM

Jun 26 2017

ributzka accepted D34576: [ConstantHoisting] Avoid hoisting constants in GEPs that index into a struct type..

Never mind. LGTM

Jun 26 2017, 10:55 AM
ributzka added a comment to D34576: [ConstantHoisting] Avoid hoisting constants in GEPs that index into a struct type..

Why not fix AddressingModeMatcher not to crash first?

Jun 26 2017, 10:30 AM

Apr 21 2017

ributzka committed rL300994: Remove empty and unused header file..
Remove empty and unused header file.
Apr 21 2017, 9:18 AM

Mar 30 2017

ributzka committed rL299104: [Object] Remove check for BIND_OPCODE_DONE/REBASE_OPCODE_DONE..
[Object] Remove check for BIND_OPCODE_DONE/REBASE_OPCODE_DONE.
Mar 30 2017, 1:09 PM

Mar 28 2017

ributzka committed rL298967: Revert "Added `applyAtomicChanges` function.".
Revert "Added `applyAtomicChanges` function."
Mar 28 2017, 5:37 PM
ributzka committed rL298966: Revert "Try to unbreak buildbots after r298913.".
Revert "Try to unbreak buildbots after r298913."
Mar 28 2017, 5:37 PM
ributzka committed rL298965: Revert "clangToolingRefactor: Add libdeps upon clangFormat in r298913.".
Revert "clangToolingRefactor: Add libdeps upon clangFormat in r298913."
Mar 28 2017, 5:36 PM

Mar 27 2017

ributzka committed rL298886: [libfuzzer] Remove XFAIL for OutOfMemory test..
[libfuzzer] Remove XFAIL for OutOfMemory test.
Mar 27 2017, 3:45 PM
ributzka committed rL298868: Revert "[Compiler-rt][Builtins] Implement lit-test support (part 2 of 2)".
Revert "[Compiler-rt][Builtins] Implement lit-test support (part 2 of 2)"
Mar 27 2017, 11:21 AM

Mar 16 2017

ributzka committed rL298029: Revert "[PowerPC] Fix sanitizer frame unwind on 32-bit ABIs".
Revert "[PowerPC] Fix sanitizer frame unwind on 32-bit ABIs"
Mar 16 2017, 6:28 PM

Mar 14 2017

ributzka committed rL297767: [Support] Make the SystemZ bot happy by using make_error_code..
[Support] Make the SystemZ bot happy by using make_error_code.
Mar 14 2017, 11:50 AM
ributzka committed rL297759: Add more debugging code for the SystemZ bot..
Add more debugging code for the SystemZ bot.
Mar 14 2017, 10:58 AM

Mar 13 2017

ributzka committed rL297693: Reapply [VFS] Ignore broken symlinks in the directory iterator..
Reapply [VFS] Ignore broken symlinks in the directory iterator.
Mar 13 2017, 5:26 PM
ributzka committed rL297672: [Support] Follow-up for "Test directory iterators and recursive directory….
[Support] Follow-up for "Test directory iterators and recursive directory…
Mar 13 2017, 2:52 PM
ributzka committed rL297669: [Support] Test directory iterators and recursive directory iterators with….
[Support] Test directory iterators and recursive directory iterators with…
Mar 13 2017, 2:46 PM

Mar 10 2017

ributzka committed rL297533: Revert "Reapply [VFS] Ignore broken symlinks in the directory iterator.".
Revert "Reapply [VFS] Ignore broken symlinks in the directory iterator."
Mar 10 2017, 4:26 PM
ributzka committed rL297531: Adding debug output to investigate systemz bot issue..
Adding debug output to investigate systemz bot issue.
Mar 10 2017, 4:13 PM
ributzka committed rL297528: Reapply [VFS] Ignore broken symlinks in the directory iterator..
Reapply [VFS] Ignore broken symlinks in the directory iterator.
Mar 10 2017, 3:01 PM
ributzka committed rL297517: Revert r297510 "[VFS] Ignore broken symlinks in the directory iterator.".
Revert r297510 "[VFS] Ignore broken symlinks in the directory iterator."
Mar 10 2017, 1:59 PM
ributzka added a comment to D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator..

Thanks Bruno. Committed in r297510.

Mar 10 2017, 1:36 PM
ributzka committed rL297510: [VFS] Ignore broken symlinks in the directory iterator..
[VFS] Ignore broken symlinks in the directory iterator.
Mar 10 2017, 1:35 PM
ributzka committed rL297511: [VFS] Remove the Path variable from RealFSDirIter. NFC..
[VFS] Remove the Path variable from RealFSDirIter. NFC.
Mar 10 2017, 1:35 PM
ributzka closed D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator. by committing rL297510: [VFS] Ignore broken symlinks in the directory iterator..
Mar 10 2017, 1:35 PM
ributzka updated the diff for D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator..

Remove the EC check completely.

Mar 10 2017, 10:01 AM

Mar 9 2017

ributzka added inline comments to D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator..
Mar 9 2017, 4:40 PM
ributzka added inline comments to D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator..
Mar 9 2017, 2:28 PM

Mar 8 2017

ributzka created D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator..
Mar 8 2017, 5:19 PM

Nov 8 2016

ributzka added a comment to rL286290: [asan/win] Add init hooks to .CRT$XLAB.

This is failing the SanitizerLintCheck. See http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_check/9576/consoleFull#-15796076f80f5c9c-2aaa-47fb-b15d-be39b7128d72.

Nov 8 2016, 2:57 PM

Oct 28 2016

ributzka added a comment to rL285381: Revert "[DAGCombiner] Add vector demanded elements support to computeKnownBits".

Hi Simon,

Oct 28 2016, 4:46 PM
ributzka added a comment to rL285381: Revert "[DAGCombiner] Add vector demanded elements support to computeKnownBits".

Hi Simon,

Oct 28 2016, 3:45 PM

Oct 27 2016

ributzka committed rL285381: Revert "[DAGCombiner] Add vector demanded elements support to computeKnownBits".
Revert "[DAGCombiner] Add vector demanded elements support to computeKnownBits"
Oct 27 2016, 9:10 PM

Aug 31 2016

ributzka added a comment to D23487: [Stackmap] Added callsite counts to emitted function information..

I'm in favor of the latter too (though I'm interested in what
@ributzka thinks). I'd suggest sending a mail to llvm-dev stating
that you're bumping the stackmap version in a backward incompatible
manner and see if anyone objects.

FWIW, I don't think this should be a problem for us.

Aug 31 2016, 10:48 AM

Aug 22 2016

ributzka added a comment to D23487: [Stackmap] Added callsite counts to emitted function information..

If we have to rev the version, which we have to in this case, then I would prefer to have the useful fixes from D13110 in there too. Otherwise this change just feels like a hack on the existing format without addressing any of the other issues.

Aug 22 2016, 10:36 AM
ributzka added a comment to D23487: [Stackmap] Added callsite counts to emitted function information..

What about reviving the patch in https://reviews.llvm.org/D13110. Wouldn't that solve your problem too?

Aug 22 2016, 9:54 AM

Jul 13 2016

ributzka accepted D21183: Better selection of common base address in constant hoisting.

LGTM

Jul 13 2016, 9:37 AM