xxhash64 is apparently faster than MD5 and SHA1, and produces good quality hashes. I am not sure about the hash quality of hash_code for this purpose.

LGTM

LGTM

Did you try xxHash64?

LGTM

The motivation to add this to llvm-nm, is to get the same functionally back that we lost with adding TBD files. Using it for testing is a nice side benefit.

LGTM

LGTM, but we should also wait for Lang's feedback.

New version is tracked here: D66149

Sure, np

Hi Cyndy, thanks for catching this copy-past-o bug. LGTM

If I recall correctly, then getIntImmCost(const APInt &Imm) predates the ConstantHoisting pass and is also used by other optimizations. The purpose of that hook is to calculate the materialization cost of a constant and is context free.

Thanks for catching this. LGTM.

LGTM

In D53945#1310580, @jakehehrlich wrote:

Would there be an objection to using llvm::tapi::MachO or llvm::tapi::macho? At least for ELF it doesn't make much sense to put the tapi code in the same namespace as BinaryFormat/ELF so it would be nice to add the extra namespace. I'm not married to the idea however.

• rename setArchitectures to addArchitectures
• fix comments
• use BitmaskEnum in several places to remove custom static_cast code.

• Rebase patch on D53051
• Remove registry and add separate reader and writer classes
• Move everything into the MachO namespace and sub-folder

I will update the patch with more changes based on the feedback so far.

Add missing license header.

We do have that now. All TAPI files start now with "--- !tapi". It is only
that the first version doesn't have that marker and that is why we have to
fall back to this extra check.

Replace std::sort with llvm::sort and fix copy-paste-o bugs.

TAPI mostly cares about linkable symbols, so this shouldn't be a problem.

Thanks Chris.

Thanks Chris

gentle ping :-)

Nice cleanup with the RuntimeLinkOptions enum. LGTM

Updating D35908: [YAML] Use {Specific}BumpPtrAllocators for HNodes.

Never mind. LGTM

Why not fix AddressingModeMatcher not to crash first?