Page MenuHomePhabricator

stephenneuendorffer (Stephen Neuendorffer)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 25 2019, 11:07 AM (16 w, 2 d)

Recent Activity

Wed, Feb 12

stephenneuendorffer added a comment to D74461: Remove static registration for dialects, and the "alwayslink" hack for passes.

I think getting rid of whole_archive_link is a good thing, but I'm concerned that this actually makes it somewhat more complicated to get new Passes and Dialects into the system in a not error-prone way.

Wed, Feb 12, 9:47 AM · Restricted Project

Tue, Feb 11

stephenneuendorffer added inline comments to D73130: [mlir] Shared library support.
Tue, Feb 11, 4:02 PM · Restricted Project

Mon, Feb 10

stephenneuendorffer added inline comments to D73130: [mlir] Shared library support.
Mon, Feb 10, 2:24 PM · Restricted Project
stephenneuendorffer added a comment to D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .

This looks like a really great start! Thanks for sketching this out.

Mon, Feb 10, 1:39 PM · Restricted Project
stephenneuendorffer added inline comments to D73130: [mlir] Shared library support.
Mon, Feb 10, 11:25 AM · Restricted Project
stephenneuendorffer added a comment to D73932: [mlir] Register the GDB listener with ExecutionEngine to enable debugging JIT'd code.

This broke BUILD_SHARED_LIBS=on, and I have submitted a fix.

Mon, Feb 10, 10:55 AM · Restricted Project
stephenneuendorffer committed rG4468188db8ae: [MLIR] Fix lib/Dialect/Linalg/EDSC for BUILD_SHARED_LIBS=on (authored by stephenneuendorffer).
[MLIR] Fix lib/Dialect/Linalg/EDSC for BUILD_SHARED_LIBS=on
Mon, Feb 10, 10:29 AM
stephenneuendorffer committed rG1eba3f326c48: [MLIR] Fix lib/ExecutionEngine for BUILD_SHARED_LIBS=on (authored by stephenneuendorffer).
[MLIR] Fix lib/ExecutionEngine for BUILD_SHARED_LIBS=on
Mon, Feb 10, 10:28 AM
stephenneuendorffer committed rGed56633fb926: [MLIR][Standard] Implement constant folding for IndexCast (authored by stephenneuendorffer).
[MLIR][Standard] Implement constant folding for IndexCast
Mon, Feb 10, 10:28 AM
stephenneuendorffer committed rG12df427fb222: [MLIR][Standard] Add folding for indexCast(indexCast(x)) -> x (authored by stephenneuendorffer).
[MLIR][Standard] Add folding for indexCast(indexCast(x)) -> x
Mon, Feb 10, 10:28 AM
stephenneuendorffer closed D73672: [MLIR][Standard] Implement constant folding for IndexCast.
Mon, Feb 10, 10:28 AM · Restricted Project
stephenneuendorffer closed D73671: [MLIR][Standard] Add folding for indexCast(indexCast(x)) -> x.
Mon, Feb 10, 10:28 AM · Restricted Project
stephenneuendorffer committed rGb80a9ca8cbc1: [MLIR] Allow non-binary operations to be commutative (authored by stephenneuendorffer).
[MLIR] Allow non-binary operations to be commutative
Mon, Feb 10, 10:28 AM
stephenneuendorffer closed D73670: [MLIR] Allow non-binary operations to be commutative.
Mon, Feb 10, 10:28 AM · Restricted Project
stephenneuendorffer added a comment to rG75394e1301dd: [mlir][EDSC] Almost NFC - Refactor and untangle EDSC dependencies.

This breaks BUILD_SHARED_LIBS=on.

Mon, Feb 10, 10:23 AM
stephenneuendorffer updated the diff for D73672: [MLIR][Standard] Implement constant folding for IndexCast.
Mon, Feb 10, 10:18 AM · Restricted Project
stephenneuendorffer added a comment to rG75394e1301dd: [mlir][EDSC] Almost NFC - Refactor and untangle EDSC dependencies.

This breaks BUILD_SHARED_LIBS=on.

Mon, Feb 10, 10:09 AM
stephenneuendorffer updated the diff for D73672: [MLIR][Standard] Implement constant folding for IndexCast.
Mon, Feb 10, 10:00 AM · Restricted Project
stephenneuendorffer updated the diff for D73672: [MLIR][Standard] Implement constant folding for IndexCast.
Mon, Feb 10, 9:37 AM · Restricted Project
stephenneuendorffer updated the diff for D73671: [MLIR][Standard] Add folding for indexCast(indexCast(x)) -> x.
Mon, Feb 10, 9:37 AM · Restricted Project
stephenneuendorffer updated the diff for D73670: [MLIR] Allow non-binary operations to be commutative.
Mon, Feb 10, 9:37 AM · Restricted Project

Fri, Feb 7

stephenneuendorffer updated the diff for D73672: [MLIR][Standard] Implement constant folding for IndexCast.
Fri, Feb 7, 5:26 PM · Restricted Project
stephenneuendorffer updated the diff for D73671: [MLIR][Standard] Add folding for indexCast(indexCast(x)) -> x.
Fri, Feb 7, 5:26 PM · Restricted Project
stephenneuendorffer updated the diff for D73670: [MLIR] Allow non-binary operations to be commutative.
Fri, Feb 7, 5:26 PM · Restricted Project
stephenneuendorffer added a comment to D73670: [MLIR] Allow non-binary operations to be commutative.

Any more comments?

Fri, Feb 7, 5:17 PM · Restricted Project
stephenneuendorffer added a comment to D73672: [MLIR][Standard] Implement constant folding for IndexCast.

Any more comments?

Fri, Feb 7, 5:17 PM · Restricted Project

Thu, Feb 6

stephenneuendorffer added a comment to D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .

This looks like a really great start! Thanks for sketching this out.

Thu, Feb 6, 3:31 PM · Restricted Project
stephenneuendorffer updated the diff for D73672: [MLIR][Standard] Implement constant folding for IndexCast.
Thu, Feb 6, 11:09 AM · Restricted Project
stephenneuendorffer updated the diff for D73671: [MLIR][Standard] Add folding for indexCast(indexCast(x)) -> x.
Thu, Feb 6, 11:09 AM · Restricted Project
stephenneuendorffer updated the diff for D73670: [MLIR] Allow non-binary operations to be commutative.
Thu, Feb 6, 11:08 AM · Restricted Project

Wed, Feb 5

stephenneuendorffer accepted D74097: [mlir] Build fix for mlir-opt.

Yes...

Wed, Feb 5, 3:51 PM · Restricted Project
stephenneuendorffer updated the diff for D73672: [MLIR][Standard] Implement constant folding for IndexCast.
Wed, Feb 5, 3:02 PM · Restricted Project
stephenneuendorffer updated the diff for D73671: [MLIR][Standard] Add folding for indexCast(indexCast(x)) -> x.
Wed, Feb 5, 3:02 PM · Restricted Project
stephenneuendorffer updated the diff for D73670: [MLIR] Allow non-binary operations to be commutative.
Wed, Feb 5, 3:02 PM · Restricted Project
stephenneuendorffer added a comment to D73671: [MLIR][Standard] Add folding for indexCast(indexCast(x)) -> x.

Can you implement this as a fold instead? 'fold' is usable in many more places than canonicalization patterns, e.g. DialectConversion.

Wed, Feb 5, 2:43 PM · Restricted Project
stephenneuendorffer added a comment to D73671: [MLIR][Standard] Add folding for indexCast(indexCast(x)) -> x.

+1 to what River said.

QQ, I could also see i16 -> index -> i32 => i16 -> i32.
Would it make sense to put here or do we prefer a separate revision?

Wed, Feb 5, 2:16 PM · Restricted Project
stephenneuendorffer committed rG7b7e5058136b: [MLIR] Break cyclic dependencies with MLIRAnalysis (authored by stephenneuendorffer).
[MLIR] Break cyclic dependencies with MLIRAnalysis
Wed, Feb 5, 11:33 AM
stephenneuendorffer committed rGb692f43e424c: [MLIR] Rename MemRefBoundCheck.cpp -> TestMemRefBoundCheck.cpp (authored by stephenneuendorffer).
[MLIR] Rename MemRefBoundCheck.cpp -> TestMemRefBoundCheck.cpp
Wed, Feb 5, 11:33 AM
stephenneuendorffer closed D73655: [MLIR] Break cyclic dependencies with MLIRAnalysis.
Wed, Feb 5, 11:33 AM · Restricted Project
stephenneuendorffer committed rGb3dd31711ab9: [MLIR] Move test passes out of lib/Analysis (authored by stephenneuendorffer).
[MLIR] Move test passes out of lib/Analysis
Wed, Feb 5, 11:33 AM
stephenneuendorffer closed D74068: [MLIR] Rename MemRefBoundCheck.cpp -> TestMemRefBoundCheck.cpp.
Wed, Feb 5, 11:32 AM · Restricted Project
stephenneuendorffer closed D74067: [MLIR] Move test passes out of lib/Analysis.
Wed, Feb 5, 11:32 AM · Restricted Project
stephenneuendorffer abandoned D72585: [MLIR] Fixes for BUILD_SHARED_LIBS=on.

This landed in modified form as D73653

Wed, Feb 5, 11:32 AM · Restricted Project
stephenneuendorffer updated the diff for D74068: [MLIR] Rename MemRefBoundCheck.cpp -> TestMemRefBoundCheck.cpp.
Wed, Feb 5, 11:12 AM · Restricted Project
stephenneuendorffer updated the diff for D73655: [MLIR] Break cyclic dependencies with MLIRAnalysis.
Wed, Feb 5, 11:12 AM · Restricted Project
stephenneuendorffer updated the diff for D74067: [MLIR] Move test passes out of lib/Analysis.
Wed, Feb 5, 11:12 AM · Restricted Project
stephenneuendorffer added inline comments to D74068: [MLIR] Rename MemRefBoundCheck.cpp -> TestMemRefBoundCheck.cpp.
Wed, Feb 5, 10:34 AM · Restricted Project
stephenneuendorffer created D74068: [MLIR] Rename MemRefBoundCheck.cpp -> TestMemRefBoundCheck.cpp.
Wed, Feb 5, 9:27 AM · Restricted Project
stephenneuendorffer created D74067: [MLIR] Move test passes out of lib/Analysis.
Wed, Feb 5, 9:27 AM · Restricted Project
stephenneuendorffer added a child revision for D74067: [MLIR] Move test passes out of lib/Analysis: D74068: [MLIR] Rename MemRefBoundCheck.cpp -> TestMemRefBoundCheck.cpp.
Wed, Feb 5, 9:27 AM · Restricted Project
stephenneuendorffer accepted D74041: [MLIR][GPU] Fix build files for mlir-opt..

Thanks for this. I didn't realize I hadn't tested the GPU config.

Wed, Feb 5, 9:09 AM · Restricted Project

Tue, Feb 4

stephenneuendorffer committed rGfce1eefb467e: [clang] fix lib/ASTMatchers for BUILD_SHARED_LIBS=ON (authored by stephenneuendorffer).
[clang] fix lib/ASTMatchers for BUILD_SHARED_LIBS=ON
Tue, Feb 4, 10:03 AM
stephenneuendorffer committed rGd7cbef2714c9: [MLIR] Fixes for shared library dependencies. (authored by stephenneuendorffer).
[MLIR] Fixes for shared library dependencies.
Tue, Feb 4, 8:59 AM
stephenneuendorffer closed D73653: [MLIR] Fixes for shared library dependencies..
Tue, Feb 4, 8:58 AM · Restricted Project

Mon, Feb 3

stephenneuendorffer added inline comments to D73653: [MLIR] Fixes for shared library dependencies..
Mon, Feb 3, 10:34 PM · Restricted Project
stephenneuendorffer abandoned D73654: [MLIR] break cyclic dependency between VectorOps and Analysis.

With the current state of the code, these changes are no longer necessary.

Mon, Feb 3, 10:15 PM · Restricted Project
stephenneuendorffer updated the diff for D73655: [MLIR] Break cyclic dependencies with MLIRAnalysis.
Mon, Feb 3, 10:15 PM · Restricted Project
stephenneuendorffer updated the diff for D73653: [MLIR] Fixes for shared library dependencies..
Mon, Feb 3, 10:15 PM · Restricted Project
stephenneuendorffer added a comment to D73654: [MLIR] break cyclic dependency between VectorOps and Analysis.

@stephenneuendorffer do you have commit access or are you waiting for someone to land it for you?

Mon, Feb 3, 8:03 PM · Restricted Project
Herald updated subscribers of D73654: [MLIR] break cyclic dependency between VectorOps and Analysis.
Mon, Feb 3, 6:32 PM · Restricted Project
stephenneuendorffer added a comment to D73655: [MLIR] Break cyclic dependencies with MLIRAnalysis.

I think we can break the dependency by removing all of the "test" passes that are currently in the Analysis lib. They predate the Test dialect, and should really be moved out.

Mon, Feb 3, 6:31 PM · Restricted Project
stephenneuendorffer added a comment to D73653: [MLIR] Fixes for shared library dependencies..

A separate issue is that in cmake, dependencies between static libraries
are automatically included in dependencies. In the above example, if MLIBlib1
depends on MLIRlib2, then it is sufficient to have only MLIRlib1 in the
target_link_libraries. When compiling with shared libraries, it is necessary
to have both MLIRlib1 and MLIRlib2 specified.

I believe this is only an issue if the target is directly using symbols from MLIRlib2 though.
If it only needs symbols from MLIRLib1 then this shouldn't be an issue right?

Mon, Feb 3, 4:50 PM · Restricted Project

Wed, Jan 29

stephenneuendorffer updated the diff for D73672: [MLIR][Standard] Implement constant folding for IndexCast.
Wed, Jan 29, 4:50 PM · Restricted Project
stephenneuendorffer updated the diff for D73671: [MLIR][Standard] Add folding for indexCast(indexCast(x)) -> x.
Wed, Jan 29, 4:50 PM · Restricted Project
stephenneuendorffer updated the diff for D73670: [MLIR] Allow non-binary operations to be commutative.
Wed, Jan 29, 4:50 PM · Restricted Project
stephenneuendorffer created D73672: [MLIR][Standard] Implement constant folding for IndexCast.
Wed, Jan 29, 4:06 PM · Restricted Project
stephenneuendorffer created D73671: [MLIR][Standard] Add folding for indexCast(indexCast(x)) -> x.
Wed, Jan 29, 4:06 PM · Restricted Project
stephenneuendorffer created D73670: [MLIR] Allow non-binary operations to be commutative.
Wed, Jan 29, 4:06 PM · Restricted Project
stephenneuendorffer added a child revision for D73671: [MLIR][Standard] Add folding for indexCast(indexCast(x)) -> x: D73672: [MLIR][Standard] Implement constant folding for IndexCast.
Wed, Jan 29, 4:06 PM · Restricted Project
stephenneuendorffer added a child revision for D73670: [MLIR] Allow non-binary operations to be commutative: D73671: [MLIR][Standard] Add folding for indexCast(indexCast(x)) -> x.
Wed, Jan 29, 4:06 PM · Restricted Project
stephenneuendorffer added reviewers for D73653: [MLIR] Fixes for shared library dependencies.: vchuravy, inouehrs.
Wed, Jan 29, 11:49 AM · Restricted Project
stephenneuendorffer abandoned D72588: [examples] Fix CMakefiles for JITLink and OrcError library refactoring.

This has landed.

Wed, Jan 29, 11:40 AM · Restricted Project
stephenneuendorffer created D73655: [MLIR] Break cyclic dependencies with MLIRAnalysis.
Wed, Jan 29, 11:40 AM · Restricted Project
stephenneuendorffer added a child revision for D73654: [MLIR] break cyclic dependency between VectorOps and Analysis: D73655: [MLIR] Break cyclic dependencies with MLIRAnalysis.
Wed, Jan 29, 11:40 AM · Restricted Project
stephenneuendorffer added a child revision for D73653: [MLIR] Fixes for shared library dependencies.: D73654: [MLIR] break cyclic dependency between VectorOps and Analysis.
Wed, Jan 29, 11:40 AM · Restricted Project
stephenneuendorffer created D73654: [MLIR] break cyclic dependency between VectorOps and Analysis.
Wed, Jan 29, 11:40 AM · Restricted Project
stephenneuendorffer created D73653: [MLIR] Fixes for shared library dependencies..
Wed, Jan 29, 11:40 AM · Restricted Project

Mon, Jan 27

stephenneuendorffer committed rG27f2e9ab1c80: [examples] Fix CMakefiles for JITLink and OrcError library refactoring (authored by stephenneuendorffer).
[examples] Fix CMakefiles for JITLink and OrcError library refactoring
Mon, Jan 27, 1:59 PM

Tue, Jan 21

stephenneuendorffer added a comment to D73130: [mlir] Shared library support.

Thanks for looking into this!

Tue, Jan 21, 1:10 PM · Restricted Project

Sun, Jan 19

stephenneuendorffer updated the diff for D72585: [MLIR] Fixes for BUILD_SHARED_LIBS=on.

Don't change add_dependencies lines: we'll fix those later

Sun, Jan 19, 2:51 AM · Restricted Project
stephenneuendorffer added a comment to D72585: [MLIR] Fixes for BUILD_SHARED_LIBS=on.

Also, how does this patch compare to D72554 ?

Sun, Jan 19, 1:11 AM · Restricted Project
stephenneuendorffer added a comment to D72585: [MLIR] Fixes for BUILD_SHARED_LIBS=on.

The changes overall looks fine to me, but this patch does not seem enough to build with ENABLE_SHARED_LIB right? We still have a cyclic dependency to break first I believe.

Sun, Jan 19, 1:11 AM · Restricted Project
stephenneuendorffer added a child revision for D69440: [cmake] Add support for explicit STATIC libraries even when building mostly shared libraries.: D72585: [MLIR] Fixes for BUILD_SHARED_LIBS=on.
Sun, Jan 19, 1:02 AM · Restricted Project
stephenneuendorffer added a parent revision for D72585: [MLIR] Fixes for BUILD_SHARED_LIBS=on: D69440: [cmake] Add support for explicit STATIC libraries even when building mostly shared libraries..
Sun, Jan 19, 1:02 AM · Restricted Project

Jan 17 2020

stephenneuendorffer updated the diff for D72585: [MLIR] Fixes for BUILD_SHARED_LIBS=on.

Rebased. Also cleaned up the dependencies around mlir-opt. This is tested with BUILD_SHARED_LIBS=on and BUILD_SHARED_LIBS=off

Jan 17 2020, 8:05 AM · Restricted Project
stephenneuendorffer abandoned D72583: [cmake] Add support for explicit STATIC libraries even when building mostly shared libraries..
Jan 17 2020, 8:05 AM · Restricted Project
stephenneuendorffer added a comment to D72586: [MLIR] Move from add_llvm_library to add_llvm_component_library.

Are there other LLVM subproject who inject themselves into the global llvm shared library? Should we have a libMLIR.so instead?

Yes I think a libMLIR.so is the right choice, the only reason to go the other way would be if LLVM starts depending on MLIR. A libMLIR.so is a clearer separation and even LTO is split out into its own library.

Jan 17 2020, 7:27 AM · Restricted Project
stephenneuendorffer abandoned D72586: [MLIR] Move from add_llvm_library to add_llvm_component_library.
Jan 17 2020, 7:27 AM · Restricted Project
stephenneuendorffer abandoned D72584: [MLIR] Fix OpDefinition::classof check for shared libraries..
Jan 17 2020, 7:27 AM · Restricted Project
stephenneuendorffer added a comment to D72822: [mlir] Replace AbstractOperation::classof with a ClassID instance..

Thanks for this, it looks like a good solution to the problems I've seen, although I haven't tested it.

Jan 17 2020, 1:56 AM · Restricted Project
stephenneuendorffer added a comment to D72584: [MLIR] Fix OpDefinition::classof check for shared libraries..

I think River fixed it already in D72822 ?

Jan 17 2020, 1:56 AM · Restricted Project

Jan 16 2020

stephenneuendorffer added a comment to D69440: [cmake] Add support for explicit STATIC libraries even when building mostly shared libraries..

Now that MLIR is in tree, are there any specific objections to accepting this patch? We intend to eliminate the circular library dependence as well, however, there seems to be little reason to disallow this usage, as far as I can see.

Jan 16 2020, 9:44 AM · Restricted Project

Jan 13 2020

stephenneuendorffer added inline comments to D72554: [mlir] support building with BUILD_SHARED_LIBS=ON.
Jan 13 2020, 9:38 AM
stephenneuendorffer added reviewers for D72587: [MLIR] Mark application libraries as "BUILDTREE_ONLY": vchuravy, inouehrs.
Jan 13 2020, 12:15 AM · Restricted Project
stephenneuendorffer added reviewers for D72585: [MLIR] Fixes for BUILD_SHARED_LIBS=on: vchuravy, inouehrs.
Jan 13 2020, 12:15 AM · Restricted Project
stephenneuendorffer added reviewers for D72586: [MLIR] Move from add_llvm_library to add_llvm_component_library: vchuravy, inouehrs.
Jan 13 2020, 12:15 AM · Restricted Project
stephenneuendorffer added reviewers for D72584: [MLIR] Fix OpDefinition::classof check for shared libraries.: vchuravy, inouehrs.
Jan 13 2020, 12:15 AM · Restricted Project
stephenneuendorffer added a reviewer for D72587: [MLIR] Mark application libraries as "BUILDTREE_ONLY": mehdi_amini.
Jan 13 2020, 12:15 AM · Restricted Project
stephenneuendorffer created D72588: [examples] Fix CMakefiles for JITLink and OrcError library refactoring.
Jan 13 2020, 12:08 AM · Restricted Project
stephenneuendorffer created D72587: [MLIR] Mark application libraries as "BUILDTREE_ONLY".
Jan 13 2020, 12:08 AM · Restricted Project