Page MenuHomePhabricator

stephenneuendorffer (Stephen Neuendorffer)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 25 2019, 11:07 AM (140 w, 6 m)

Recent Activity

Sat, Jun 18

stephenneuendorffer added inline comments to D123774: Introduce a new Dense Array attribute.
Sat, Jun 18, 8:16 AM · Restricted Project, Restricted Project

Fri, Jun 10

stephenneuendorffer added inline comments to D127244: [mlir][AMDGPU] Add `mfma` operation to wrap mfma intrinsics..
Fri, Jun 10, 11:46 AM · Restricted Project, Restricted Project

May 27 2022

stephenneuendorffer accepted D126308: cmake: use llvm dir variables for clang/utils/hmaptool.
May 27 2022, 9:29 AM · Restricted Project, Restricted Project

May 25 2022

stephenneuendorffer added a comment to D126308: cmake: use llvm dir variables for clang/utils/hmaptool.

LGTM... Does LLVM_TOOLS_BINARY_DIR include CMAKE_CFG_INTDIR? Is this actually NFC?

May 25 2022, 11:54 AM · Restricted Project, Restricted Project

May 10 2022

stephenneuendorffer accepted D125182: [mlir] Experimental, simplified CMake auto-config for Python development..

Seems reasonable. If this works it would be nice to just hand it off to the cmake folks...

May 10 2022, 9:54 PM · Restricted Project, Restricted Project

Mar 30 2022

stephenneuendorffer updated the diff for D122758: DataLayout::getPointerSize() should always return a power of 2.
Mar 30 2022, 12:35 PM · Restricted Project, Restricted Project
stephenneuendorffer requested review of D122758: DataLayout::getPointerSize() should always return a power of 2.
Mar 30 2022, 12:34 PM · Restricted Project, Restricted Project

Feb 5 2022

stephenneuendorffer accepted D119069: [mlir] Do not use an empty source file when building aggregate libraries..
Feb 5 2022, 10:18 PM · Restricted Project

Feb 1 2022

stephenneuendorffer committed rG76f37d41b751: [cmake][NFC] Configuration for libLLVM.so symbol versioning (authored by stephenneuendorffer).
[cmake][NFC] Configuration for libLLVM.so symbol versioning
Feb 1 2022, 11:05 PM
stephenneuendorffer closed D118672: [cmake][NFC] Configuration for libLLVM.so symbol versioning.
Feb 1 2022, 11:05 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D118672: [cmake][NFC] Configuration for libLLVM.so symbol versioning.
Feb 1 2022, 10:16 PM · Restricted Project, Restricted Project

Jan 31 2022

stephenneuendorffer added reviewers for D118672: [cmake][NFC] Configuration for libLLVM.so symbol versioning: tstellar, vchuravy.
Jan 31 2022, 6:01 PM · Restricted Project, Restricted Project
stephenneuendorffer requested review of D118672: [cmake][NFC] Configuration for libLLVM.so symbol versioning.
Jan 31 2022, 6:01 PM · Restricted Project, Restricted Project

Jan 27 2022

stephenneuendorffer committed rG84fe34a0b7fd: [MLIR] Workaround for python detection problems. (authored by stephenneuendorffer).
[MLIR] Workaround for python detection problems.
Jan 27 2022, 1:32 PM
stephenneuendorffer closed D118148: [MLIR] Workaround for python detection problems..
Jan 27 2022, 1:32 PM · Restricted Project

Jan 25 2022

stephenneuendorffer added a comment to D118148: [MLIR] Workaround for python detection problems..

There have been so many permutations of this that I can't remember my expectation for issues here, but I feel like this was causing other issues. Have you tried this on a manylinux image? Iirc, that was where things went bad when module detection didn't work. (I can give this a shot if you haven't)

Jan 25 2022, 11:43 AM · Restricted Project
stephenneuendorffer added a reviewer for D118148: [MLIR] Workaround for python detection problems.: stellaraccident.
Jan 25 2022, 8:03 AM · Restricted Project
stephenneuendorffer requested review of D118148: [MLIR] Workaround for python detection problems..
Jan 25 2022, 8:01 AM · Restricted Project

Jan 21 2022

stephenneuendorffer accepted D117942: Add a `printTrailingComment` method on OpAsmOpInterface.
Jan 21 2022, 9:19 PM · Restricted Project
stephenneuendorffer added a comment to D117942: Add a `printTrailingComment` method on OpAsmOpInterface.

Thanks!

Jan 21 2022, 9:18 PM · Restricted Project
stephenneuendorffer added inline comments to D117761: Implement IR versioning through post-parsing upgrade through OpAsmDialectInterface.
Jan 21 2022, 8:41 AM · Restricted Project

Jan 14 2022

stephenneuendorffer added inline comments to D117287: Disable the MLIR ExecutionEngine library when the native target is not configured.
Jan 14 2022, 12:17 AM · Restricted Project
stephenneuendorffer accepted D117287: Disable the MLIR ExecutionEngine library when the native target is not configured.

Thanks for this!

Jan 14 2022, 12:13 AM · Restricted Project

Jan 9 2022

stephenneuendorffer committed rG3523876873b2: Fix exported MLIR_TABLEGEN_EXE (authored by stephenneuendorffer).
Fix exported MLIR_TABLEGEN_EXE
Jan 9 2022, 11:27 PM

Dec 31 2021

stephenneuendorffer accepted D115568: [lld][CMake] Use `GNUInstallDirs` to support custom installation dirs.

LGTM

Dec 31 2021, 1:30 AM · lld, Restricted Project
stephenneuendorffer accepted D115569: [flang] Use `GNUInstallDirs` to support custom installation dirs..

LGTM

Dec 31 2021, 1:28 AM · Restricted Project, Restricted Project

Dec 28 2021

stephenneuendorffer accepted D115746: [compiler-rt][cmake] Factor out extend_install_path function.

Seems like a reasonable refactoring to me.

Dec 28 2021, 8:41 PM · Restricted Project

Dec 7 2021

stephenneuendorffer committed rG0fcb16eeb228: Allow DataLayout to support arbitrary pointer sizes (authored by stephenneuendorffer).
Allow DataLayout to support arbitrary pointer sizes
Dec 7 2021, 11:20 PM
stephenneuendorffer closed D114141: Allow DataLayout to support arbitrary pointer sizes.
Dec 7 2021, 11:20 PM · Restricted Project
stephenneuendorffer updated the diff for D114141: Allow DataLayout to support arbitrary pointer sizes.
Dec 7 2021, 10:50 PM · Restricted Project

Dec 2 2021

stephenneuendorffer added inline comments to D114141: Allow DataLayout to support arbitrary pointer sizes.
Dec 2 2021, 3:51 PM · Restricted Project

Dec 1 2021

stephenneuendorffer added a reviewer for D114141: Allow DataLayout to support arbitrary pointer sizes: resistor.
Dec 1 2021, 11:00 PM · Restricted Project
stephenneuendorffer added a reviewer for D114141: Allow DataLayout to support arbitrary pointer sizes: craig.topper.
Dec 1 2021, 10:59 PM · Restricted Project
stephenneuendorffer updated the diff for D114141: Allow DataLayout to support arbitrary pointer sizes.
Dec 1 2021, 10:51 PM · Restricted Project
stephenneuendorffer updated the diff for D114141: Allow DataLayout to support arbitrary pointer sizes.
Dec 1 2021, 6:48 PM · Restricted Project

Nov 30 2021

stephenneuendorffer updated the diff for D114141: Allow DataLayout to support arbitrary pointer sizes.
Nov 30 2021, 4:03 PM · Restricted Project
stephenneuendorffer added a reverting change for D100444: [MLIR] Update Vector To LLVM conversion to be aware of assume_alignment: rG73863648892e: Revert "[MLIR] Update Vector To LLVM conversion to be aware of assume_alignment".
Nov 30 2021, 3:19 PM · Restricted Project
stephenneuendorffer added a reverting change for rG29a50c5864dd: [MLIR] Update Vector To LLVM conversion to be aware of assume_alignment: rG73863648892e: Revert "[MLIR] Update Vector To LLVM conversion to be aware of assume_alignment".
Nov 30 2021, 3:19 PM
stephenneuendorffer committed rG73863648892e: Revert "[MLIR] Update Vector To LLVM conversion to be aware of assume_alignment" (authored by stephenneuendorffer).
Revert "[MLIR] Update Vector To LLVM conversion to be aware of assume_alignment"
Nov 30 2021, 3:18 PM

Nov 18 2021

stephenneuendorffer updated the diff for D114141: Allow DataLayout to support arbitrary pointer sizes.
Nov 18 2021, 10:44 PM · Restricted Project
stephenneuendorffer updated the diff for D114141: Allow DataLayout to support arbitrary pointer sizes.
Nov 18 2021, 10:36 PM · Restricted Project
stephenneuendorffer updated the diff for D114141: Allow DataLayout to support arbitrary pointer sizes.
Nov 18 2021, 10:31 PM · Restricted Project
stephenneuendorffer updated the diff for D114141: Allow DataLayout to support arbitrary pointer sizes.
Nov 18 2021, 9:56 PM · Restricted Project
stephenneuendorffer updated the diff for D114141: Allow DataLayout to support arbitrary pointer sizes.
Nov 18 2021, 9:43 AM · Restricted Project

Nov 17 2021

stephenneuendorffer requested review of D114141: Allow DataLayout to support arbitrary pointer sizes.
Nov 17 2021, 11:33 PM · Restricted Project

Nov 14 2021

stephenneuendorffer accepted D113664: [cmake] use project relative paths when generating ASTNodeAPI.json.

LGTM

Nov 14 2021, 6:14 PM · Restricted Project

Nov 12 2021

stephenneuendorffer abandoned D111828: [mlir] Cleanup export of python extensions.

Rolled into D113732

Nov 12 2021, 1:55 PM · Restricted Project
stephenneuendorffer accepted D113732: Re-apply "[mlir] Allow out-of-tree python building from installed MLIR.".

Thanks!

Nov 12 2021, 1:55 PM · Restricted Project

Oct 14 2021

stephenneuendorffer added a reviewer for D111828: [mlir] Cleanup export of python extensions: stellaraccident.
Oct 14 2021, 12:10 PM · Restricted Project
stephenneuendorffer requested review of D111828: [mlir] Cleanup export of python extensions.
Oct 14 2021, 12:09 PM · Restricted Project

Oct 12 2021

stephenneuendorffer accepted D111513: [mlir] Allow out-of-tree python building from installed MLIR..
Oct 12 2021, 9:11 PM · Restricted Project
stephenneuendorffer accepted D111504: [mlir] Ability to build CAPI dylibs from out of tree projects against installed LLVM..

I think this can go in tree now.

Oct 12 2021, 9:09 PM · Restricted Project
stephenneuendorffer accepted D111689: [mlir][python] Add a warning for cmake version < 3.15..
Oct 12 2021, 8:13 PM · Restricted Project
stephenneuendorffer requested changes to D111504: [mlir] Ability to build CAPI dylibs from out of tree projects against installed LLVM..
Oct 12 2021, 12:47 PM · Restricted Project
stephenneuendorffer added inline comments to D111504: [mlir] Ability to build CAPI dylibs from out of tree projects against installed LLVM..
Oct 12 2021, 12:45 PM · Restricted Project

Oct 11 2021

stephenneuendorffer added inline comments to D111513: [mlir] Allow out-of-tree python building from installed MLIR..
Oct 11 2021, 8:46 PM · Restricted Project
stephenneuendorffer added inline comments to D111513: [mlir] Allow out-of-tree python building from installed MLIR..
Oct 11 2021, 7:26 PM · Restricted Project

Sep 29 2021

stephenneuendorffer added a comment to D110768: [MLIR] Introduce the type inference pass..

Have you tried this on any graph regions? I guess maybe the same question goes for ForwardDataflowAnalysis?

Sep 29 2021, 2:59 PM · Restricted Project
stephenneuendorffer added inline comments to D110768: [MLIR] Introduce the type inference pass..
Sep 29 2021, 2:44 PM · Restricted Project

Sep 17 2021

stephenneuendorffer accepted D108454: [MLIR][SCF] Add for-to-while loop transformation pass.

Thanks, Morten!

Sep 17 2021, 9:52 AM · Restricted Project

Aug 17 2021

stephenneuendorffer committed rGaf7818093677: [cmake] Properly support target properties. (authored by stephenneuendorffer).
[cmake] Properly support target properties.
Aug 17 2021, 2:08 PM
stephenneuendorffer closed D108098: [cmake] Properly support target properties..
Aug 17 2021, 2:08 PM · Restricted Project

Aug 16 2021

stephenneuendorffer updated the diff for D108098: [cmake] Properly support target properties..
Aug 16 2021, 1:28 PM · Restricted Project
stephenneuendorffer added a comment to D108098: [cmake] Properly support target properties..

Read my mind - was meaning to do this very change last week but ran out of time. How much further are you going? I'd ultimately like our targets to all have proper include/link directories defined so we don't need to do so much global munging.

Aug 16 2021, 1:21 PM · Restricted Project

Aug 15 2021

stephenneuendorffer added reviewers for D108098: [cmake] Properly support target properties.: bondhugula, stellaraccident.
Aug 15 2021, 5:21 PM · Restricted Project
stephenneuendorffer requested review of D108098: [cmake] Properly support target properties..
Aug 15 2021, 5:20 PM · Restricted Project

Aug 14 2021

stephenneuendorffer committed rG7776b19eed44: [MLIR] Move TestDialect to ::test namespace (authored by stephenneuendorffer).
[MLIR] Move TestDialect to ::test namespace
Aug 14 2021, 1:32 PM
stephenneuendorffer closed D88251: [MLIR] Move TestDialect to ::test namespace.
Aug 14 2021, 1:32 PM · Restricted Project
stephenneuendorffer updated the diff for D88251: [MLIR] Move TestDialect to ::test namespace.
Aug 14 2021, 1:31 PM · Restricted Project
stephenneuendorffer updated the diff for D88251: [MLIR] Move TestDialect to ::test namespace.
Aug 14 2021, 1:21 PM · Restricted Project
stephenneuendorffer updated the diff for D88251: [MLIR] Move TestDialect to ::test namespace.
Aug 14 2021, 12:08 PM · Restricted Project

Aug 4 2021

stephenneuendorffer added a comment to D88251: [MLIR] Move TestDialect to ::test namespace.

Yeah, still broken.

Aug 4 2021, 12:04 AM · Restricted Project
stephenneuendorffer updated the diff for D88251: [MLIR] Move TestDialect to ::test namespace.
Aug 4 2021, 12:03 AM · Restricted Project

Aug 3 2021

stephenneuendorffer abandoned D89060: [mlir] Add missing dependencies.

I think this is obsolete?

Aug 3 2021, 11:47 PM · Restricted Project
stephenneuendorffer added a comment to D103432: [mlir] Handle cases where transfer_read should turn into a scalar load.

Thanks for the reviews!

Aug 3 2021, 11:15 PM · Restricted Project
stephenneuendorffer committed rG432341d8a81a: [mlir] Handle cases where transfer_read should turn into a scalar load (authored by stephenneuendorffer).
[mlir] Handle cases where transfer_read should turn into a scalar load
Aug 3 2021, 11:12 PM
stephenneuendorffer closed D103432: [mlir] Handle cases where transfer_read should turn into a scalar load.
Aug 3 2021, 11:11 PM · Restricted Project
stephenneuendorffer updated the diff for D103432: [mlir] Handle cases where transfer_read should turn into a scalar load.
Aug 3 2021, 10:52 PM · Restricted Project
stephenneuendorffer accepted D105212: [MLIR] Support for compatible Dialect Builders.

This seems reasonable to me.

Aug 3 2021, 9:48 PM · Restricted Project

Jul 21 2021

stephenneuendorffer accepted D106419: Generalize a facility in MLIR CMake for producing aggregate shared and static libraries..

Generally speaking I like this approach... It's much simpler than the alternatives that I've seen. I think we should try to take it to the next step....

Jul 21 2021, 10:39 PM · Restricted Project
stephenneuendorffer added a comment to D106520: Re-engineer MLIR python build support..

if not installing into python/ anymore, can you document where things will get installed? I didn't quite parse it out of the code.

Jul 21 2021, 10:35 PM · Restricted Project
stephenneuendorffer added inline comments to D106419: Generalize a facility in MLIR CMake for producing aggregate shared and static libraries..
Jul 21 2021, 3:29 PM · Restricted Project

Jun 11 2021

stephenneuendorffer committed rG984e270a9a70: [mlir] make normalizeAffineFor public (authored by stephenneuendorffer).
[mlir] make normalizeAffineFor public
Jun 11 2021, 8:25 PM

Jun 2 2021

stephenneuendorffer added a comment to D98005: NFC: Glob all python sources in the MLIR Python bindings..

It looks like this change to create symlinks in the build area also results in those symlinks getting installed in the install area... This seems like a bad idea, since the install area ends up having symlinks back to the source tree. However, I don't see a simple way to change the install action to fix that. Any ideas here?

Jun 2 2021, 4:31 PM · Restricted Project

Jun 1 2021

stephenneuendorffer committed rGbbd399954b89: Convert TableGen assert to error (authored by stephenneuendorffer).
Convert TableGen assert to error
Jun 1 2021, 1:19 PM
stephenneuendorffer added inline comments to D102740: Convert TableGen assert to error.
Jun 1 2021, 1:18 PM · Restricted Project
stephenneuendorffer closed D102740: Convert TableGen assert to error.
Jun 1 2021, 1:18 PM · Restricted Project
stephenneuendorffer updated the diff for D102740: Convert TableGen assert to error.
Jun 1 2021, 1:17 PM · Restricted Project
stephenneuendorffer added a comment to D102740: Convert TableGen assert to error.

Seems fine, but is there a way to write this in tablegen that would trigger the assert?

Jun 1 2021, 12:58 PM · Restricted Project

May 31 2021

stephenneuendorffer added a comment to D102740: Convert TableGen assert to error.

Ping... in general is there an issue converting asserts() to proper error messages in tablegen?

May 31 2021, 11:09 PM · Restricted Project
stephenneuendorffer accepted D103276: [MLIR] Fix Standalone dialect test to work in out-of-tree builds.

Thanks for looking at this!

May 31 2021, 11:08 PM · Restricted Project
stephenneuendorffer added inline comments to D103384: [Dominators] Rewrite the dominator implementation for efficiency. NFC..
May 31 2021, 10:56 PM · Restricted Project
stephenneuendorffer requested review of D103432: [mlir] Handle cases where transfer_read should turn into a scalar load.
May 31 2021, 10:32 PM · Restricted Project

May 19 2021

stephenneuendorffer committed rG29a50c5864dd: [MLIR] Update Vector To LLVM conversion to be aware of assume_alignment (authored by stephenneuendorffer).
[MLIR] Update Vector To LLVM conversion to be aware of assume_alignment
May 19 2021, 10:51 AM
stephenneuendorffer closed D100444: [MLIR] Update Vector To LLVM conversion to be aware of assume_alignment.
May 19 2021, 10:51 AM · Restricted Project
stephenneuendorffer added inline comments to D100444: [MLIR] Update Vector To LLVM conversion to be aware of assume_alignment.
May 19 2021, 10:44 AM · Restricted Project
stephenneuendorffer updated the diff for D100444: [MLIR] Update Vector To LLVM conversion to be aware of assume_alignment.
May 19 2021, 10:43 AM · Restricted Project
stephenneuendorffer added inline comments to D100444: [MLIR] Update Vector To LLVM conversion to be aware of assume_alignment.
May 19 2021, 10:36 AM · Restricted Project
stephenneuendorffer added a comment to D100444: [MLIR] Update Vector To LLVM conversion to be aware of assume_alignment.

In incorporating your feedback, I decided to emit the proper alignment other loads and stores too. Thoughts?

May 19 2021, 12:20 AM · Restricted Project
stephenneuendorffer updated the diff for D100444: [MLIR] Update Vector To LLVM conversion to be aware of assume_alignment.
May 19 2021, 12:18 AM · Restricted Project