Page MenuHomePhabricator

stephenneuendorffer (Stephen Neuendorffer)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 25 2019, 11:07 AM (47 w, 2 d)

Recent Activity

Sun, Sep 6

stephenneuendorffer accepted D87221: Add a doc/tutorial on traversing the IR.

Love it. Thanks for adding this!

Sun, Sep 6, 11:22 PM · Restricted Project

Aug 19 2020

stephenneuendorffer accepted D86219: [llvm-zorg] Flang and MLIR PowerPC buildbot; removed double quoting.
Aug 19 2020, 9:56 AM

Aug 14 2020

stephenneuendorffer committed rG65049f9b7934: [examples][cmake] build fix for examples with BUILD_SHARED_LIBS=on (authored by stephenneuendorffer).
[examples][cmake] build fix for examples with BUILD_SHARED_LIBS=on
Aug 14 2020, 11:40 AM
stephenneuendorffer closed D85987: [examples][cmake] build fix for examples with BUILD_SHARED_LIBS=on.
Aug 14 2020, 11:40 AM · Restricted Project
stephenneuendorffer committed rG6ce8e4f46b7a: [mlir] build fix for gcc-5 (authored by stephenneuendorffer).
[mlir] build fix for gcc-5
Aug 14 2020, 11:40 AM
stephenneuendorffer closed D85986: [mlir] build fix for gcc-5.
Aug 14 2020, 11:40 AM · Restricted Project
stephenneuendorffer committed rG324ae458df7e: [mlir] Make mlir_check_link_libraries() work with interface libraries (authored by marbre).
[mlir] Make mlir_check_link_libraries() work with interface libraries
Aug 14 2020, 11:39 AM
stephenneuendorffer closed D85957: [mlir] Make mlir_check_link_libraries() work with interface libraries.
Aug 14 2020, 11:39 AM · Restricted Project
stephenneuendorffer requested review of D85987: [examples][cmake] build fix for examples with BUILD_SHARED_LIBS=on.
Aug 14 2020, 11:38 AM · Restricted Project
stephenneuendorffer requested review of D85986: [mlir] build fix for gcc-5.
Aug 14 2020, 11:27 AM · Restricted Project
stephenneuendorffer accepted D85957: [mlir] Make mlir_check_link_libraries() work with interface libraries.
Aug 14 2020, 10:51 AM · Restricted Project

Aug 7 2020

stephenneuendorffer accepted D84579: [mlir][PDL] Add a PDL Interpreter Dialect.
Aug 7 2020, 10:48 PM · Restricted Project
stephenneuendorffer accepted D84578: [mlir] Add a new "Pattern Descriptor Language" (PDL) dialect..
Aug 7 2020, 10:40 PM · Restricted Project

Aug 6 2020

stephenneuendorffer added a reviewer for D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects: mgorny.
Aug 6 2020, 12:56 PM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D85464: [MLIR] [CMake] Support building MLIR standalone.
Aug 6 2020, 12:55 PM · Restricted Project

Aug 4 2020

stephenneuendorffer added inline comments to D85167: [mlir][DialectConversion] Update the documentation for dialect conversion.
Aug 4 2020, 11:57 AM · Restricted Project

Aug 3 2020

stephenneuendorffer added a comment to D85167: [mlir][DialectConversion] Update the documentation for dialect conversion.

One thing I think is missing from this when and if failed type conversions result in failed patterns. I was debugging a case recently where a type conversion failed, but it wasn't obvious why this happened, and it was not reported separately, only as part of a failing pattern.

Aug 3 2020, 10:25 PM · Restricted Project
stephenneuendorffer accepted D85060: [MLIR][TableGen] Fix ambiguous build methods when inferring result types..

I'm happy with filing an issue about it.

Aug 3 2020, 11:40 AM · Restricted Project
stephenneuendorffer updated the diff for D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects.
Aug 3 2020, 11:24 AM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects.
Aug 3 2020, 11:17 AM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects.
Aug 3 2020, 10:57 AM · Restricted Project, Restricted Project
stephenneuendorffer added a comment to D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects.

Something you don't make very explicit in the description of this patch is that beyond a "refactoring" this is also changing the behavior by *duplicating* the options for each subproject.
For example building with -DLLVM_INCLUDE_EXAMPLES won't be enough to include the examples in MLIR, the user must also provide -DMLIR_INCLUDE_EXAMPLES. Same for every other options.

I can see how this provide more flexibility to the user configuring the build, but this flexibility comes also with a more complex surface. For example when building LLVM+MLIR, passing -DLLVM_INSTALL_TOOLCHAIN_ONLY=ON isn't enough and you need also -DMLIR_INSTALL_TOOLCHAIN_ONLY=ON.

Aug 3 2020, 10:55 AM · Restricted Project, Restricted Project
stephenneuendorffer added a comment to D85060: [MLIR][TableGen] Fix ambiguous build methods when inferring result types..

Seems like this will prevent the collision in the short term, but this solution doesn't seem like it will scale as builders get more complex. I'm not opposed to a special case here, but I'd feel more comfortable if there was a more general structure in place to prevent this from scaling to lots of special cases.

Aug 3 2020, 10:40 AM · Restricted Project
stephenneuendorffer added reviewers for D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects: silvas, stellaraccident, mehdi_amini.
Aug 3 2020, 9:59 AM · Restricted Project, Restricted Project
stephenneuendorffer requested review of D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects.
Aug 3 2020, 9:46 AM · Restricted Project, Restricted Project

Jul 27 2020

stephenneuendorffer added a comment to D84691: [CMake] Move find_package(ZLIB) to LLVMConfig.

Perfect! Thanks!

Jul 27 2020, 5:17 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 25 2020

stephenneuendorffer added inline comments to D79219: [CMake] Simplify CMake handling for zlib.
Jul 25 2020, 9:22 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 17 2020

stephenneuendorffer added inline comments to D83924: [mlir] Add update_mlir_test_checks.py.
Jul 17 2020, 12:05 AM · Restricted Project

Jul 16 2020

stephenneuendorffer added a comment to D83924: [mlir] Add update_mlir_test_checks.py.

[Drive by] tests?

Jul 16 2020, 6:06 PM · Restricted Project
stephenneuendorffer added a comment to D83924: [mlir] Add update_mlir_test_checks.py.

There seems to be a lot of hardcoding in here related to func. Given that func is not even the only function in upstream MLIR, and that for several dialects(existing and upcoming) func isn't even used at all, what is the story for those users?

Jul 16 2020, 12:48 PM · Restricted Project
stephenneuendorffer added inline comments to D83924: [mlir] Add update_mlir_test_checks.py.
Jul 16 2020, 12:31 PM · Restricted Project
stephenneuendorffer added a comment to D83924: [mlir] Add update_mlir_test_checks.py.

It's kind of confusing that this is in llvm/utils while generate-test-checks.py is in mlir/utils. Is there a plan to reconcile this difference?

Jul 16 2020, 12:28 PM · Restricted Project
stephenneuendorffer added inline comments to D83924: [mlir] Add update_mlir_test_checks.py.
Jul 16 2020, 9:35 AM · Restricted Project

Jul 15 2020

stephenneuendorffer added reviewers for D83924: [mlir] Add update_mlir_test_checks.py: timshen, silvas, jdoerfert.
Jul 15 2020, 6:54 PM · Restricted Project
Herald added a project to D83924: [mlir] Add update_mlir_test_checks.py: Restricted Project.
Jul 15 2020, 6:50 PM · Restricted Project
stephenneuendorffer committed rG628288658c5b: [MLIR] Add RegionKindInterface (authored by stephenneuendorffer).
[MLIR] Add RegionKindInterface
Jul 15 2020, 2:32 PM
stephenneuendorffer closed D80358: [MLIR] Add RegionKindInterface.
Jul 15 2020, 2:32 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jul 15 2020, 12:40 PM · Restricted Project, Restricted Project
stephenneuendorffer added a comment to D80358: [MLIR] Add RegionKindInterface.

Quick question: how do we know in printed IR if something is a graph region or an SSA one?

Jul 15 2020, 12:40 PM · Restricted Project, Restricted Project

Jul 14 2020

stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jul 14 2020, 3:20 PM · Restricted Project, Restricted Project
stephenneuendorffer added a comment to D80358: [MLIR] Add RegionKindInterface.

If there are no further comments, I'd like to commit this. @bondhugula @mehdi_amini Do you want to accept?

Jul 14 2020, 3:10 PM · Restricted Project, Restricted Project
stephenneuendorffer added a comment to D83599: [MLIR] Add argument related API to Region.

Looking at https://reviews.llvm.org/D80358, I don't see the definition of region arguments being entry block arguments changing.

Yeah I sync'd with Stephen today and there is no concern.

Jul 14 2020, 10:11 AM · Restricted Project

Jul 13 2020

stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jul 13 2020, 6:30 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jul 13 2020, 6:13 PM · Restricted Project, Restricted Project

Jul 11 2020

stephenneuendorffer committed rGd8c35031a39e: [examples] fix ExceptionDemo (authored by stephenneuendorffer).
[examples] fix ExceptionDemo
Jul 11 2020, 12:40 PM
stephenneuendorffer closed D83628: [examples] fix ExceptionDemo.
Jul 11 2020, 12:39 PM · Restricted Project
Herald added a project to D83628: [examples] fix ExceptionDemo: Restricted Project.
Jul 11 2020, 12:38 PM · Restricted Project

Jul 10 2020

stephenneuendorffer accepted D83604: [mlir][ODS] Add support for specifying the namespace of an interface..
Jul 10 2020, 9:30 PM · Restricted Project

Jul 8 2020

stephenneuendorffer accepted D83279: Initial boiler-plate for python bindings..
Jul 8 2020, 5:30 PM · Restricted Project
stephenneuendorffer accepted D83422: Create TestReducer pass.
Jul 8 2020, 2:32 PM · Restricted Project

Jul 6 2020

stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jul 6 2020, 11:27 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jul 6 2020, 11:07 PM · Restricted Project, Restricted Project
stephenneuendorffer added a comment to D82159: Add a cmake warning when someone tries to configure clang-tools-extra without clang.

I'd advocate for issuing a message (along the lines of "clang-tools-extra is enabled, which depends on 'clang'. Automatically enabling 'clang'." and 'doing the right thing' by enabling clang.
In fact, this seems to be a common enough paradigm that it should be handled in the cmake infrastructure.

Jul 6 2020, 12:59 PM · Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jul 6 2020, 9:59 AM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D80358: [MLIR] Add RegionKindInterface.
Jul 6 2020, 9:58 AM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D83182: Expand the LLVM Developer Policy to include new sections on adding a project to the LLVM Monorepo, and a second about the LLVM Incubator projects..
Jul 6 2020, 9:00 AM · Restricted Project

Jul 5 2020

stephenneuendorffer accepted D83182: Expand the LLVM Developer Policy to include new sections on adding a project to the LLVM Monorepo, and a second about the LLVM Incubator projects..

I suggested a few minor rewrites that bugged me more on a second reading.

Jul 5 2020, 2:24 PM · Restricted Project

Jul 1 2020

stephenneuendorffer accepted D83011: [mlir][OpFormatGen] Add support for resolving variadic types from non-variadic.

I don't see anything else obviously wrong, but I don't particularly grok what the code is doing either.

Jul 1 2020, 9:39 PM · Restricted Project

Jun 29 2020

stephenneuendorffer added inline comments to D80358: [MLIR] Add RegionKindInterface.
Jun 29 2020, 11:04 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jun 29 2020, 11:04 PM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D80358: [MLIR] Add RegionKindInterface.
Jun 29 2020, 5:48 PM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D80358: [MLIR] Add RegionKindInterface.
Jun 29 2020, 4:39 PM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D82803: Create the MLIR Reduce framework.
Jun 29 2020, 4:39 PM · Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jun 29 2020, 4:22 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jun 29 2020, 4:22 PM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D80358: [MLIR] Add RegionKindInterface.
Jun 29 2020, 4:22 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jun 29 2020, 4:06 PM · Restricted Project, Restricted Project

Jun 26 2020

stephenneuendorffer accepted D82666: [mlir] do not hardcode the name of the undefined function in the error message.
Jun 26 2020, 11:29 AM · Restricted Project

Jun 23 2020

stephenneuendorffer added a comment to D82371: [mlir] Avoid pontentially ambiguous class name.

Thanks.. I actually just ran into this the other day. I wonder if the standalone dialect example needs to get pushed into a separate namespace (I think it's still in mlir?) to find other places where there is an assumed namespace? I think all tablegen'd code would be alot safer if it always explicitly referred to MLIR classes through ::mlir.

Jun 23 2020, 12:21 PM · Restricted Project

Jun 18 2020

stephenneuendorffer added inline comments to D80358: [MLIR] Add RegionKindInterface.
Jun 18 2020, 8:40 AM · Restricted Project, Restricted Project

Jun 17 2020

stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jun 17 2020, 3:06 PM · Restricted Project, Restricted Project

Jun 16 2020

stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jun 16 2020, 7:11 PM · Restricted Project, Restricted Project
stephenneuendorffer added a comment to D80358: [MLIR] Add RegionKindInterface.

Update after review changes

Jun 16 2020, 7:10 PM · Restricted Project, Restricted Project

Jun 15 2020

stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jun 15 2020, 11:04 PM · Restricted Project, Restricted Project
stephenneuendorffer added a comment to D80358: [MLIR] Add RegionKindInterface.

Thanks for the careful reviews. It resulted in many updates in the documentation.

Jun 15 2020, 11:04 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jun 15 2020, 11:04 PM · Restricted Project, Restricted Project
stephenneuendorffer accepted D81626: [mlir] [integration-test] [VectorOps] Start an integration test directory for MLIR.

Thanks for this!

Jun 15 2020, 9:46 AM · Restricted Project

Jun 12 2020

stephenneuendorffer committed rG8dcf89c3a7ce: [MLIR][cmake] use add_mlir_interface() wherever possible (authored by stephenneuendorffer).
[MLIR][cmake] use add_mlir_interface() wherever possible
Jun 12 2020, 9:46 AM
stephenneuendorffer closed D81715: [MLIR][cmake] use add_mlir_interface() wherever possible.
Jun 12 2020, 9:46 AM · Restricted Project

Jun 11 2020

stephenneuendorffer created D81715: [MLIR][cmake] use add_mlir_interface() wherever possible.
Jun 11 2020, 11:25 PM · Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jun 11 2020, 11:01 PM · Restricted Project, Restricted Project
stephenneuendorffer accepted D81693: Install the MLIRTableGen static library..
Jun 11 2020, 3:59 PM · Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jun 11 2020, 3:59 PM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D81626: [mlir] [integration-test] [VectorOps] Start an integration test directory for MLIR.
Jun 11 2020, 10:27 AM · Restricted Project
stephenneuendorffer accepted D81545: [cmake] Don't pass -z discard-unused to Illumos ld.

Seems reasonable to me.

Jun 11 2020, 10:27 AM · Restricted Project
stephenneuendorffer added a comment to D81626: [mlir] [integration-test] [VectorOps] Start an integration test directory for MLIR.

LGTM. My main comment is that I don't know if I see the value of *LOTS* of integration tests. I'm used to using tests like this for design drivers, but it seems like you've tried to get some coverage of the vector dialect here?

Jun 11 2020, 12:01 AM · Restricted Project

Jun 9 2020

stephenneuendorffer abandoned D80760: [JitRunner] add support for i32 output.

Changes were merged in a separate diff.

Jun 9 2020, 11:05 PM · Restricted Project, Restricted Project
stephenneuendorffer committed rGd3ead060befa: [JitRunner] add support for i32 and i64 output (authored by stephenneuendorffer).
[JitRunner] add support for i32 and i64 output
Jun 9 2020, 10:34 PM
stephenneuendorffer committed rG698462336abb: [MLIR] expose applyCmpPredicate (authored by stephenneuendorffer).
[MLIR] expose applyCmpPredicate
Jun 9 2020, 10:34 PM
stephenneuendorffer closed D80675: [JitRunner] add support for i32 and i64 output.
Jun 9 2020, 10:34 PM · Restricted Project, Restricted Project
stephenneuendorffer closed D80609: [MLIR] expose applyCmpPredicate.
Jun 9 2020, 10:34 PM · Restricted Project, Restricted Project
stephenneuendorffer requested changes to D81526: [mlir] Build a native mlir-linalg-ods-gen when cross-compiling.

My sense is that this could be done more simply? Seems like complex code that shouldn't be proliferated in other places if we can avoid it.

Jun 9 2020, 9:29 PM · Restricted Project

May 28 2020

stephenneuendorffer updated the diff for D80675: [JitRunner] add support for i32 and i64 output.
May 28 2020, 5:05 PM · Restricted Project, Restricted Project
stephenneuendorffer added a reviewer for D80675: [JitRunner] add support for i32 and i64 output: ftynse.
May 28 2020, 2:52 PM · Restricted Project, Restricted Project
stephenneuendorffer committed rG3bff62d45f83: [mlir] Extend standalone example by standalone-translate (authored by marbre).
[mlir] Extend standalone example by standalone-translate
May 28 2020, 2:20 PM
stephenneuendorffer committed rG8b3155829a99: [MLIR] Fix build when NVPTX is not enabled (authored by stephenneuendorffer).
[MLIR] Fix build when NVPTX is not enabled
May 28 2020, 2:20 PM
stephenneuendorffer closed D80737: [mlir] Extend standalone example by standalone-translate.
May 28 2020, 2:20 PM · Restricted Project
stephenneuendorffer created D80760: [JitRunner] add support for i32 output.
May 28 2020, 2:20 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D80609: [MLIR] expose applyCmpPredicate.
May 28 2020, 2:19 PM · Restricted Project, Restricted Project
stephenneuendorffer added a comment to D80609: [MLIR] expose applyCmpPredicate.

Would it make sense to put them in the relevant Ops so as not to pollute the mlir:: namespace?

May 28 2020, 2:18 PM · Restricted Project, Restricted Project