Page MenuHomePhabricator
People aeubanks

aeubanks (Arthur Eubanks)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Feb 12 2020, 11:23 AM (162 w, 1 d)
Roles
Administrator

Recent Activity
View All

Today

aeubanks committed rGccd96b3e03e1: [builtins][test] Fix divmodti4_test.c on Windows (authored by aeubanks).
[builtins][test] Fix divmodti4_test.c on Windows
Thu, Mar 23, 7:09 PM · Restricted Project, Restricted Project
aeubanks closed D146667: [builtins][test] Fix divmodti4_test.c on Windows.
Thu, Mar 23, 7:09 PM · Restricted Project, Restricted Project
aeubanks added reviewers for D146764: [clang] Make predefined expressions string literals under -fms-extensions: hans, aaron.ballman.
Thu, Mar 23, 3:19 PM · Restricted Project, Restricted Project
aeubanks requested review of D146764: [clang] Make predefined expressions string literals under -fms-extensions.
Thu, Mar 23, 3:18 PM · Restricted Project, Restricted Project
aeubanks committed rG088da8a0e57a: [lldb][NFC] makeArrayRef -> ArrayRef (authored by aeubanks).
[lldb][NFC] makeArrayRef -> ArrayRef
Thu, Mar 23, 2:05 PM · Restricted Project

Yesterday

aeubanks updated the summary of D146667: [builtins][test] Fix divmodti4_test.c on Windows.
Wed, Mar 22, 3:57 PM · Restricted Project, Restricted Project
aeubanks requested review of D146667: [builtins][test] Fix divmodti4_test.c on Windows.
Wed, Mar 22, 3:57 PM · Restricted Project, Restricted Project
aeubanks added inline comments to D145265: [Pipeline] Remove GlobalCleanupPM.
Wed, Mar 22, 1:13 PM · Restricted Project, Restricted Project, Restricted Project
aeubanks retitled D145265: [Pipeline] Remove GlobalCleanupPM from [WIP][Pipeline] Remove GlobalCleanupPM to [Pipeline] Remove GlobalCleanupPM.
Wed, Mar 22, 1:12 PM · Restricted Project, Restricted Project, Restricted Project
aeubanks committed rG3f23c7f5bedc: [InstSimplify] Actually use NewOps for calls in simplifyInstructionWithOperands (authored by aeubanks).
[InstSimplify] Actually use NewOps for calls in simplifyInstructionWithOperands
Wed, Mar 22, 9:26 AM · Restricted Project, Restricted Project
aeubanks closed D146599: [InstSimplify] Actually use NewOps for calls in simplifyInstructionWithOperands.
Wed, Mar 22, 9:26 AM · Restricted Project, Restricted Project

Tue, Mar 21

aeubanks added reviewers for D146599: [InstSimplify] Actually use NewOps for calls in simplifyInstructionWithOperands: spatel, nikic, goldstein.w.n.
Tue, Mar 21, 8:00 PM · Restricted Project, Restricted Project
aeubanks requested review of D146599: [InstSimplify] Actually use NewOps for calls in simplifyInstructionWithOperands.
Tue, Mar 21, 7:59 PM · Restricted Project, Restricted Project
aeubanks added inline comments to D146267: [llvm] Handle duplicate call bases when applying branch funneling .
Tue, Mar 21, 4:48 PM · Restricted Project, Restricted Project
aeubanks committed rG852cfc2ed31b: [NFC] Fix incorrect comment for simplifyRightShift (authored by aeubanks).
[NFC] Fix incorrect comment for simplifyRightShift
Tue, Mar 21, 12:06 PM · Restricted Project, Restricted Project
aeubanks committed rGfa6ea7a419f3: [AlwaysInliner] Make legacy pass like the new pass (authored by aeubanks).
[AlwaysInliner] Make legacy pass like the new pass
Tue, Mar 21, 11:05 AM · Restricted Project, Restricted Project
aeubanks closed D146446: [AlwaysInliner] Make legacy pass like the new pass.
Tue, Mar 21, 11:04 AM · Restricted Project, Restricted Project
aeubanks updated the diff for D145265: [Pipeline] Remove GlobalCleanupPM.

rebase, update tests

Tue, Mar 21, 10:51 AM · Restricted Project, Restricted Project, Restricted Project
aeubanks updated the diff for D145403: [Pipeline] Don't run EarlyFPM in LTO post link.

assert not full lto postlink

Tue, Mar 21, 10:50 AM · Restricted Project, Restricted Project, Restricted Project
aeubanks committed rG2b34d59858d6: [test] Change DAG to NEXT in pipeline tests (authored by aeubanks).
[test] Change DAG to NEXT in pipeline tests
Tue, Mar 21, 10:45 AM · Restricted Project, Restricted Project
aeubanks committed rG006230e10de6: [test] Remove redundant check prefix from new-pm-thinlto-prelink-pgo-defaults.ll (authored by aeubanks).
[test] Remove redundant check prefix from new-pm-thinlto-prelink-pgo-defaults.ll
Tue, Mar 21, 10:14 AM · Restricted Project, Restricted Project
aeubanks committed rG511ddfe2650a: [test] Split up new-pm-thinlto-defaults.ll into prelink and postlink pipelines (authored by aeubanks).
[test] Split up new-pm-thinlto-defaults.ll into prelink and postlink pipelines
Tue, Mar 21, 9:18 AM · Restricted Project, Restricted Project
aeubanks closed D146486: [test] Split up new-pm-thinlto-defaults.ll into prelink and postlink pipelines.
Tue, Mar 21, 9:18 AM · Restricted Project, Restricted Project

Mon, Mar 20

aeubanks added a comment to D145403: [Pipeline] Don't run EarlyFPM in LTO post link.
In D145403#4175178, @tejohnson wrote:
In D145403#4172268, @aeubanks wrote:

still need to update tests and make sure this doesn't regress anything, but sending out to make sure that this makes sense to you

In theory this makes sense, certainly per the comment there. Did you see any surprising test changes?

Mon, Mar 20, 6:13 PM · Restricted Project, Restricted Project, Restricted Project
aeubanks updated the diff for D145403: [Pipeline] Don't run EarlyFPM in LTO post link.

update tests

Mon, Mar 20, 6:13 PM · Restricted Project, Restricted Project, Restricted Project
aeubanks requested review of D146486: [test] Split up new-pm-thinlto-defaults.ll into prelink and postlink pipelines.
Mon, Mar 20, 6:03 PM · Restricted Project, Restricted Project
aeubanks committed rGeecb8c5f0614: [SampleProfile] Use LazyCallGraph instead of CallGraph (authored by aeubanks).
[SampleProfile] Use LazyCallGraph instead of CallGraph
Mon, Mar 20, 1:44 PM · Restricted Project, Restricted Project
aeubanks added reviewers for D146446: [AlwaysInliner] Make legacy pass like the new pass: asbirlea, mtrofin.
Mon, Mar 20, 11:25 AM · Restricted Project, Restricted Project
aeubanks updated the diff for D146446: [AlwaysInliner] Make legacy pass like the new pass.

update

Mon, Mar 20, 11:24 AM · Restricted Project, Restricted Project
aeubanks requested review of D146446: [AlwaysInliner] Make legacy pass like the new pass.
Mon, Mar 20, 11:21 AM · Restricted Project, Restricted Project
aeubanks added a comment to D144958: [SLP]Initial support for reshuffling of non-starting buildvector/gather nodes..

a more succinct version: https://godbolt.org/z/7YTqP89Mv shows that slp-vectorizer introduces loads from poison

Mon, Mar 20, 10:44 AM · Restricted Project, Restricted Project
aeubanks committed rG313365add2fb: [Internalize] Don't claim to preserve CallGraph (authored by aeubanks).
[Internalize] Don't claim to preserve CallGraph
Mon, Mar 20, 9:26 AM · Restricted Project, Restricted Project
aeubanks committed rGc41c336ee065: [Internalize] Remove interaction with CallGraph (authored by aeubanks).
[Internalize] Remove interaction with CallGraph
Mon, Mar 20, 9:25 AM · Restricted Project, Restricted Project
aeubanks accepted D146383: [SimpleLoopUnswitch] Skip non-trivial unswitching of cold loop nests.

lgtm

Mon, Mar 20, 9:14 AM · Restricted Project, Restricted Project

Sun, Mar 19

aeubanks committed rG5558346c2b5b: [CGSCC] Allow creation of no-rerun CGSCC->function adaptor via textual pipeline (authored by aeubanks).
[CGSCC] Allow creation of no-rerun CGSCC->function adaptor via textual pipeline
Sun, Mar 19, 4:27 PM · Restricted Project, Restricted Project
aeubanks closed D145196: [CGSCC] Allow creation of no-rerun CGSCC->function adaptor via textual pipeline.
Sun, Mar 19, 4:26 PM · Restricted Project, Restricted Project
aeubanks abandoned D138857: [llvm-c] Remove legacy pass manager APIs.

done in another change

Sun, Mar 19, 3:25 PM · Restricted Project, Restricted Project
aeubanks added a comment to D145516: [Inliner] Avoid excessive inlining through devirtualised calls.

sorry for the slow response

Sun, Mar 19, 3:24 PM · Restricted Project, Restricted Project
aeubanks added a comment to D146383: [SimpleLoopUnswitch] Skip non-trivial unswitching of cold loop nests.

seems reasonable, just some nits

Sun, Mar 19, 1:12 PM · Restricted Project, Restricted Project

Fri, Mar 17

aeubanks added a comment to D146266: gn build: Fix Android build..

I'd like @thakis to review this change, he probably has more thoughts

Fri, Mar 17, 2:56 PM · Restricted Project, Restricted Project
aeubanks added a comment to D146283: [Passes] Add PassBuilderContext.

I've thought about doing this a couple of times, thanks for bring this up

Fri, Mar 17, 11:07 AM · Restricted Project, Restricted Project
aeubanks added inline comments to D146266: gn build: Fix Android build..
Fri, Mar 17, 10:33 AM · Restricted Project, Restricted Project
aeubanks added a comment to D146267: [llvm] Handle duplicate call bases when applying branch funneling .

any overlap with D104798?

Fri, Mar 17, 10:12 AM · Restricted Project, Restricted Project
aeubanks committed rG55140fbbcd65: [StandardInstrumentations] Check that module analyses are properly invalidated (authored by aeubanks).
[StandardInstrumentations] Check that module analyses are properly invalidated
Fri, Mar 17, 9:12 AM · Restricted Project, Restricted Project
aeubanks closed D146238: [StandardInstrumentations] Check that module analyses are properly invalidated.
Fri, Mar 17, 9:11 AM · Restricted Project, Restricted Project

Thu, Mar 16

aeubanks added a comment to D146266: gn build: Fix Android build..

yeah this was very confusing when I was looking at this

Thu, Mar 16, 5:21 PM · Restricted Project, Restricted Project
aeubanks added inline comments to D146238: [StandardInstrumentations] Check that module analyses are properly invalidated.
Thu, Mar 16, 4:11 PM · Restricted Project, Restricted Project
aeubanks resigned from D146163: Experimental new python bindings for clang/llvm based on Cython.

not familiar enough with python, but there should probably be an RFC for this

Thu, Mar 16, 12:52 PM · Restricted Project, Restricted Project, Restricted Project
aeubanks added inline comments to D146243: [docs] Mention removal of legacy optimization pipeline and inliner alloca merging.
Thu, Mar 16, 11:06 AM · Restricted Project, Restricted Project
aeubanks committed rGa63270cda814: [docs] Mention removal of legacy optimization pipeline and inliner alloca… (authored by aeubanks).
[docs] Mention removal of legacy optimization pipeline and inliner alloca…
Thu, Mar 16, 10:48 AM · Restricted Project, Restricted Project
aeubanks closed D146243: [docs] Mention removal of legacy optimization pipeline and inliner alloca merging.
Thu, Mar 16, 10:48 AM · Restricted Project, Restricted Project
aeubanks accepted D146206: [LAA] Fix transitive analysis invalidation bug by implementing LoopAccessInfoManager::invalidate.
Thu, Mar 16, 10:47 AM · Restricted Project, Restricted Project
aeubanks added a comment to D146091: [Inliner] Remove alloca merging.
In D146091#4197717, @asbirlea wrote:

Adding a line in release notes might be useful; next to a note with the removal of legacy PM pieces (e.g. PassManagerBuilder).

Thu, Mar 16, 10:06 AM · Restricted Project, Restricted Project
aeubanks requested review of D146243: [docs] Mention removal of legacy optimization pipeline and inliner alloca merging.
Thu, Mar 16, 10:06 AM · Restricted Project, Restricted Project
aeubanks committed rGcefbc2e0e794: [Inliner] Remove alloca merging (authored by aeubanks).
[Inliner] Remove alloca merging
Thu, Mar 16, 10:03 AM · Restricted Project, Restricted Project
aeubanks closed D146091: [Inliner] Remove alloca merging.
Thu, Mar 16, 10:03 AM · Restricted Project, Restricted Project
aeubanks requested review of D146238: [StandardInstrumentations] Check that module analyses are properly invalidated.
Thu, Mar 16, 9:59 AM · Restricted Project, Restricted Project
aeubanks committed rGc1b4240322bf: [opt] Rename -enable-new-pm -> -bugpoint-enable-legacy-pm (authored by aeubanks).
[opt] Rename -enable-new-pm -> -bugpoint-enable-legacy-pm
Thu, Mar 16, 9:57 AM · Restricted Project, Restricted Project
aeubanks closed D146103: [opt] Rename -enable-new-pm -> -bugpoint-enable-legacy-pm.
Thu, Mar 16, 9:57 AM · Restricted Project, Restricted Project
aeubanks committed rG4c8ee1ac8221: [Debugify] Use ModuleAnalysisManager in instrumentation (authored by aeubanks).
[Debugify] Use ModuleAnalysisManager in instrumentation
Thu, Mar 16, 9:50 AM · Restricted Project, Restricted Project, Restricted Project
aeubanks committed rG60ebe901ebba: [HWAsan] Fix returned PreservedAnalyses (authored by aeubanks).
[HWAsan] Fix returned PreservedAnalyses
Thu, Mar 16, 9:43 AM · Restricted Project, Restricted Project
aeubanks committed rG4b0b1052a5f7: [FunctionImport] Fix returned PreservedAnalyses (authored by aeubanks).
[FunctionImport] Fix returned PreservedAnalyses
Thu, Mar 16, 9:43 AM · Restricted Project, Restricted Project
aeubanks committed rGc0cb758ebd71: [Annotation2Metadata] Fix returned PreservedAnalyses (authored by aeubanks).
[Annotation2Metadata] Fix returned PreservedAnalyses
Thu, Mar 16, 9:42 AM · Restricted Project, Restricted Project
aeubanks committed rGac44122513c4: [AMDGPUCtorDtorLowering] Fix returned PreservedAnalyses (authored by aeubanks).
[AMDGPUCtorDtorLowering] Fix returned PreservedAnalyses
Thu, Mar 16, 9:36 AM · Restricted Project, Restricted Project
aeubanks accepted D146200: [PassBuilder] Support O0 in default pipelines.

yeah, the forced -O0 separation doesn't really make sense

Thu, Mar 16, 9:27 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
aeubanks added inline comments to D146206: [LAA] Fix transitive analysis invalidation bug by implementing LoopAccessInfoManager::invalidate.
Thu, Mar 16, 9:24 AM · Restricted Project, Restricted Project

Wed, Mar 15

aeubanks committed rG6a6994cc9bc0: Reland [StandardInstrumentations] Check function analysis invalidation in… (authored by aeubanks).
Reland [StandardInstrumentations] Check function analysis invalidation in…
Wed, Mar 15, 1:29 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
aeubanks added a reverting change for rGd6c0724eb158: [StandardInstrumentations] Check function analysis invalidation in module…: rG04d20195d6b3: Revert "[StandardInstrumentations] Check function analysis invalidation in….
Wed, Mar 15, 1:28 PM · Restricted Project, Restricted Project
aeubanks committed rG04d20195d6b3: Revert "[StandardInstrumentations] Check function analysis invalidation in… (authored by aeubanks).
Revert "[StandardInstrumentations] Check function analysis invalidation in…
Wed, Mar 15, 1:28 PM · Restricted Project, Restricted Project
aeubanks added a reverting change for D146160: [StandardInstrumentations] Check function analysis invalidation in module passes as well: rG04d20195d6b3: Revert "[StandardInstrumentations] Check function analysis invalidation in….
Wed, Mar 15, 1:28 PM · Restricted Project, Restricted Project
aeubanks abandoned D145729: [llvm-c] Remove pointee support from LLVMGetElementType.
Wed, Mar 15, 1:26 PM · Restricted Project, Restricted Project
aeubanks abandoned D145712: [llvm-c] Add LLVMPointerType2.
Wed, Mar 15, 1:26 PM · Restricted Project, Restricted Project
aeubanks committed rGd6c0724eb158: [StandardInstrumentations] Check function analysis invalidation in module… (authored by aeubanks).
[StandardInstrumentations] Check function analysis invalidation in module…
Wed, Mar 15, 1:24 PM · Restricted Project, Restricted Project
aeubanks closed D146160: [StandardInstrumentations] Check function analysis invalidation in module passes as well.
Wed, Mar 15, 1:23 PM · Restricted Project, Restricted Project
aeubanks committed rG20a7ea49f40e: [StandardInstrumentations] Verify function doesn't change if analyses are… (authored by aeubanks).
[StandardInstrumentations] Verify function doesn't change if analyses are…
Wed, Mar 15, 1:17 PM · Restricted Project, Restricted Project
aeubanks closed D146003: [StandardInstrumentations] Verify function doesn't change if analyses are preserved.
Wed, Mar 15, 1:17 PM · Restricted Project, Restricted Project, Restricted Project
aeubanks committed rG361cba22b201: [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-analysis… (authored by aeubanks).
[StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-analysis…
Wed, Mar 15, 1:13 PM · Restricted Project, Restricted Project, Restricted Project
aeubanks closed D146069: [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-analysis-invalidation.
Wed, Mar 15, 1:12 PM · Restricted Project, Restricted Project, Restricted Project
aeubanks requested review of D146160: [StandardInstrumentations] Check function analysis invalidation in module passes as well.
Wed, Mar 15, 11:55 AM · Restricted Project, Restricted Project
aeubanks committed rGe94b59ee75b2: [Debugify/Strip] Fix returned PreservedAnalyses (authored by aeubanks).
[Debugify/Strip] Fix returned PreservedAnalyses
Wed, Mar 15, 11:47 AM · Restricted Project, Restricted Project
aeubanks committed rG6a3fdcdd3885: [WPD] Fix PreservedAnalyses value after runForTesting() (authored by aeubanks).
[WPD] Fix PreservedAnalyses value after runForTesting()
Wed, Mar 15, 11:47 AM · Restricted Project, Restricted Project
aeubanks updated the diff for D146069: [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-analysis-invalidation.

update

Wed, Mar 15, 10:33 AM · Restricted Project, Restricted Project, Restricted Project
aeubanks updated the diff for D146069: [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-analysis-invalidation.

rename to verify-analysis-invalidation

Wed, Mar 15, 9:45 AM · Restricted Project, Restricted Project, Restricted Project
aeubanks added inline comments to D146003: [StandardInstrumentations] Verify function doesn't change if analyses are preserved.
Wed, Mar 15, 9:28 AM · Restricted Project, Restricted Project, Restricted Project
aeubanks updated the diff for D146003: [StandardInstrumentations] Verify function doesn't change if analyses are preserved.

rebase after cleanups
fix tests

Wed, Mar 15, 9:27 AM · Restricted Project, Restricted Project, Restricted Project
aeubanks added a reviewer for D146069: [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-analysis-invalidation: nikic.
Wed, Mar 15, 9:26 AM · Restricted Project, Restricted Project, Restricted Project
aeubanks committed rG6d7da41b80e0: [Debugify] Invalidate function analyses (authored by aeubanks).
[Debugify] Invalidate function analyses
Wed, Mar 15, 9:19 AM · Restricted Project, Restricted Project, Restricted Project
aeubanks committed rG22dce16ea764: [StandardInstrumentations] Only turn on -verify-cfg-preserved by default in… (authored by aeubanks).
[StandardInstrumentations] Only turn on -verify-cfg-preserved by default in…
Wed, Mar 15, 8:39 AM · Restricted Project, Restricted Project
aeubanks closed D146068: [StandardInstrumentations] Only turn on -verify-cfg-preserved by default in expensive checks builds.
Wed, Mar 15, 8:38 AM · Restricted Project, Restricted Project
aeubanks committed rGa312118a036d: [gn build] Manually port fe7b38 (authored by aeubanks).
[gn build] Manually port fe7b38
Wed, Mar 15, 8:37 AM · Restricted Project, Restricted Project
aeubanks committed rGbfc6590e66be: [PassManager] Run PassInstrumentation after analysis invalidation (authored by aeubanks).
[PassManager] Run PassInstrumentation after analysis invalidation
Wed, Mar 15, 8:36 AM · Restricted Project, Restricted Project
aeubanks closed D146096: [PassManager] Run PassInstrumentation after analysis invalidation.
Wed, Mar 15, 8:36 AM · Restricted Project, Restricted Project

Tue, Mar 14

aeubanks committed rG20ed9cebb605: [Pipeline] Remove early InstCombine in ThinLTO post link sample profile pipeline (authored by aeubanks).
[Pipeline] Remove early InstCombine in ThinLTO post link sample profile pipeline
Tue, Mar 14, 7:50 PM · Restricted Project, Restricted Project
aeubanks closed D146099: [Pipeline] Remove early InstCombine in ThinLTO post link sample profile pipeline.
Tue, Mar 14, 7:50 PM · Restricted Project, Restricted Project
aeubanks updated the diff for D146103: [opt] Rename -enable-new-pm -> -bugpoint-enable-legacy-pm.

update

Tue, Mar 14, 4:33 PM · Restricted Project, Restricted Project
aeubanks added reviewers for D146103: [opt] Rename -enable-new-pm -> -bugpoint-enable-legacy-pm: asbirlea, nikic.
Tue, Mar 14, 4:28 PM · Restricted Project, Restricted Project
aeubanks requested review of D146103: [opt] Rename -enable-new-pm -> -bugpoint-enable-legacy-pm.
Tue, Mar 14, 4:27 PM · Restricted Project, Restricted Project
aeubanks committed rG093b2640ea90: [SimplifyLibCalls] Return Value from optimizeSinCosPi when making change (authored by aeubanks).
[SimplifyLibCalls] Return Value from optimizeSinCosPi when making change
Tue, Mar 14, 3:17 PM · Restricted Project, Restricted Project
aeubanks closed D146064: [SimplifyLibCalls] Return Value from optimizeSinCosPi when making change.
Tue, Mar 14, 3:17 PM · Restricted Project, Restricted Project
aeubanks requested review of D146099: [Pipeline] Remove early InstCombine in ThinLTO post link sample profile pipeline.
Tue, Mar 14, 3:10 PM · Restricted Project, Restricted Project