Page MenuHomePhabricator

aeubanks (Arthur Eubanks)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Feb 12 2020, 11:23 AM (118 w, 4 d)
Roles
Administrator

Recent Activity

Today

aeubanks added a comment to D126228: [LowerTypeTests] Ignore llvm.assume users through phis.

as somebody unfamiliar with WPD/CFI, is it necessary that they use the same llvm.type.test mechanism?

Mon, May 23, 11:21 AM · Restricted Project, Restricted Project
aeubanks requested review of D126228: [LowerTypeTests] Ignore llvm.assume users through phis.
Mon, May 23, 11:10 AM · Restricted Project, Restricted Project
aeubanks accepted D126219: [gn build] Use -I= instead of explicitly handling sysroot.

what about setting $sysroot to $sdk_path in llvm/utils/gn/build/BUILD.gn?

Mon, May 23, 9:34 AM · Restricted Project, Restricted Project

Fri, May 20

aeubanks added inline comments to D126089: [WPD] Make sure type test is eliminated.
Fri, May 20, 4:06 PM · Restricted Project, Restricted Project
aeubanks added reviewers for D126089: [WPD] Make sure type test is eliminated: tejohnson, pcc.
Fri, May 20, 1:20 PM · Restricted Project, Restricted Project
aeubanks requested review of D126089: [WPD] Make sure type test is eliminated.
Fri, May 20, 1:19 PM · Restricted Project, Restricted Project
aeubanks accepted D125766: [llvm-reduce] improve bb removal.
Fri, May 20, 11:08 AM · Restricted Project, Restricted Project
aeubanks added a comment to D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types.

I'm still looking into a whole program devirtualization bug that only repros with opaque pointers, and there are still potential performance issues to look into

Fri, May 20, 10:56 AM · Restricted Project, Restricted Project, Restricted Project

Thu, May 19

aeubanks added a comment to D126035: [InstCombine] Changing constant-indexed GEP of GEP to i8* for merging.

also no need to mention the previous revision in the final commit message

Thu, May 19, 6:57 PM · Restricted Project, Restricted Project
aeubanks accepted D126035: [InstCombine] Changing constant-indexed GEP of GEP to i8* for merging.
Thu, May 19, 6:16 PM · Restricted Project, Restricted Project
aeubanks resigned from D125168: Add opaque ptr to the llvm-c.
Thu, May 19, 1:44 PM · Restricted Project, Restricted Project
aeubanks accepted D125983: [DeadArgElim] Use poison instead of undef as placeholder for dead arguments.
Thu, May 19, 9:05 AM · Restricted Project, Restricted Project, Restricted Project

Wed, May 18

aeubanks added a comment to D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types.

+1 to adding something to lto::Config.

Do we really need this for a temporary switch? Will this force us to keep supporting the new switch into the future for backwards compatibility in the commandline interface even when we dropped all references to typed pointers from LLVM?

Wed, May 18, 11:42 PM · Restricted Project, Restricted Project, Restricted Project
aeubanks added a comment to D125845: [InstCombine] Canonicalize GEP of GEP by swapping constant-indexed GEP to the back.

I think there's some git weirdness going on, could you apply this on top of main?

Wed, May 18, 6:51 PM · Restricted Project, Restricted Project
aeubanks added a comment to D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types.

Related bug report: https://github.com/llvm/llvm-project/issues/55377

I am not completely sure however how to deal with users specifying -Xclang -no-opaque-pointers explicitly. With this change they would end up using opaque-pointers anyway in LTO modes...

I believe the right way to do this is to add an OpaquePointers option to lto::Config, add -plugin-opt=no-opaque-pointers to LLD/LLVMgold.so, and then pass that from clang.

Alternatively we could just drop support for LTO with typed pointers :)

Wed, May 18, 9:39 AM · Restricted Project, Restricted Project, Restricted Project
aeubanks accepted D125766: [llvm-reduce] improve bb removal.

seems reasonable

Wed, May 18, 9:32 AM · Restricted Project, Restricted Project

Tue, May 17

aeubanks added a comment to D125259: [C11] Diagnose unreachable generic selection associations.
$ cat /tmp/a.cc
typedef struct Test {
} Test;
Tue, May 17, 9:59 AM · Restricted Project, Restricted Project
aeubanks committed rG470910c4ad8a: [OpaquePtr][BitcodeReader] Explicitly turn off opaque pointers if we see a… (authored by aeubanks).
[OpaquePtr][BitcodeReader] Explicitly turn off opaque pointers if we see a…
Tue, May 17, 8:45 AM · Restricted Project, Restricted Project
aeubanks closed D125736: [OpaquePtr][BitcodeReader] Explicitly turn off opaque pointers if we see a typed pointer.
Tue, May 17, 8:44 AM · Restricted Project, Restricted Project
aeubanks committed rGd2be4f95494e: [OpaquePtr][LLParser] Explicitly turn off opaque pointers if we see a star (authored by aeubanks).
[OpaquePtr][LLParser] Explicitly turn off opaque pointers if we see a star
Tue, May 17, 8:43 AM · Restricted Project, Restricted Project
aeubanks closed D125735: [OpaquePtr][LLParser] Explicitly turn off opaque pointers if we see a star.
Tue, May 17, 8:43 AM · Restricted Project, Restricted Project
aeubanks accepted D125751: [llvm-nm] Always use opaque pointers (PR55506).
Tue, May 17, 8:33 AM · Restricted Project, Restricted Project

Mon, May 16

aeubanks added a reviewer for D125736: [OpaquePtr][BitcodeReader] Explicitly turn off opaque pointers if we see a typed pointer: Restricted Project.
Mon, May 16, 5:51 PM · Restricted Project, Restricted Project
aeubanks requested review of D125736: [OpaquePtr][BitcodeReader] Explicitly turn off opaque pointers if we see a typed pointer.
Mon, May 16, 5:51 PM · Restricted Project, Restricted Project
aeubanks added a reviewer for D125735: [OpaquePtr][LLParser] Explicitly turn off opaque pointers if we see a star: Restricted Project.
Mon, May 16, 5:03 PM · Restricted Project, Restricted Project
aeubanks requested review of D125735: [OpaquePtr][LLParser] Explicitly turn off opaque pointers if we see a star.
Mon, May 16, 5:03 PM · Restricted Project, Restricted Project

Sat, May 14

aeubanks added a comment to D115750: [SLP]Further improvement of the cost model for scalars used in buildvectors..

another one :)

target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-android23"
Sat, May 14, 11:05 AM · Restricted Project, Restricted Project

Fri, May 13

aeubanks added inline comments to D125183: Add opaque pointers to the llvm-c API.
Fri, May 13, 2:39 PM · Restricted Project, Restricted Project
aeubanks accepted D125580: Resolve overload ambiguity on Mac OS when printing size_t in diagnostics.
Fri, May 13, 1:38 PM · Restricted Project, Restricted Project
aeubanks added inline comments to D125328: [BasicAA] Fix order in which we pass MemoryLocations to alias().
Fri, May 13, 10:46 AM · Restricted Project, Restricted Project
aeubanks added a comment to D115750: [SLP]Further improvement of the cost model for scalars used in buildvectors..

Another crash caused by this:

Fri, May 13, 9:30 AM · Restricted Project, Restricted Project

Thu, May 12

aeubanks added a comment to D125485: [ArgPromotion] Unify byval promotion with non-byval.

for the byval case, a store can change the value loaded by a later load, so it's not completely dead in that regard

Thu, May 12, 5:54 PM · Restricted Project, Restricted Project
aeubanks added a comment to D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis..

can you put the motivation in the description?

Thu, May 12, 1:36 PM · Restricted Project, Restricted Project

Wed, May 11

aeubanks added a comment to D100780: [Passes] Add extra LoopSimplifyCFG run after IndVarSimplify..

This could be done by either exposing a simplifyLoopCFG helper function ...

This variant sounds better, if possible.

Wed, May 11, 11:06 PM · Restricted Project, Restricted Project
aeubanks added a comment to rG0950d4060cd9: Recommit "[SLP] Make reordering aware of external vectorizable scalar stores.".

doesn't look like this has a test case for the crash, it'd be good to add one

Wed, May 11, 6:11 PM · Restricted Project, Restricted Project
aeubanks added a reverting change for rG71bcead98b2e: [SLP] Make reordering aware of external vectorizable scalar stores.: rGc2a7904aba46: Revert "[SLP] Make reordering aware of external vectorizable scalar stores.".
Wed, May 11, 3:31 PM · Restricted Project, Restricted Project
aeubanks committed rGc2a7904aba46: Revert "[SLP] Make reordering aware of external vectorizable scalar stores." (authored by aeubanks).
Revert "[SLP] Make reordering aware of external vectorizable scalar stores."
Wed, May 11, 3:31 PM · Restricted Project, Restricted Project
aeubanks added a reverting change for D125111: [SLP] Make reordering aware of external vectorizable scalar stores.: rGc2a7904aba46: Revert "[SLP] Make reordering aware of external vectorizable scalar stores.".
Wed, May 11, 3:31 PM · Restricted Project, Restricted Project
aeubanks added a comment to D125111: [SLP] Make reordering aware of external vectorizable scalar stores..

this is causing crashes

$ cat /tmp/d.ll
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
Wed, May 11, 3:27 PM · Restricted Project, Restricted Project
aeubanks committed rG8016a0e5a56b: Explicitly add -target for Windows builds in file_test_windows.c (authored by ayzhao).
Explicitly add -target for Windows builds in file_test_windows.c
Wed, May 11, 3:10 PM · Restricted Project, Restricted Project
aeubanks closed D125425: Explicitly add -target for Windows builds in file_test_windows.c.
Wed, May 11, 3:09 PM · Restricted Project, Restricted Project
aeubanks accepted D125425: Explicitly add -target for Windows builds in file_test_windows.c.
Wed, May 11, 3:05 PM · Restricted Project, Restricted Project
aeubanks committed rGf37e6faf523d: [gn build] Use llvm-ar when clang_base_path is specified (authored by aeubanks).
[gn build] Use llvm-ar when clang_base_path is specified
Wed, May 11, 10:41 AM · Restricted Project, Restricted Project
aeubanks closed D125399: [gn build] Use llvm-ar when clang_base_path is specified.
Wed, May 11, 10:41 AM · Restricted Project, Restricted Project
aeubanks requested review of D125399: [gn build] Use llvm-ar when clang_base_path is specified.
Wed, May 11, 9:20 AM · Restricted Project, Restricted Project

Tue, May 10

aeubanks committed rG7e0802aeb5b9: [BasicAA] Fix order in which we pass MemoryLocations to alias() (authored by aeubanks).
[BasicAA] Fix order in which we pass MemoryLocations to alias()
Tue, May 10, 12:10 PM · Restricted Project, Restricted Project
aeubanks closed D125328: [BasicAA] Fix order in which we pass MemoryLocations to alias().
Tue, May 10, 12:10 PM · Restricted Project, Restricted Project
aeubanks added a comment to D125328: [BasicAA] Fix order in which we pass MemoryLocations to alias().

looks like this isn't the only time this sort of thing has come up: D115927

Tue, May 10, 10:29 AM · Restricted Project, Restricted Project
aeubanks added reviewers for D125328: [BasicAA] Fix order in which we pass MemoryLocations to alias(): dfukalov, asbirlea, nikic.
Tue, May 10, 10:27 AM · Restricted Project, Restricted Project
aeubanks updated the diff for D125328: [BasicAA] Fix order in which we pass MemoryLocations to alias().

format

Tue, May 10, 10:27 AM · Restricted Project, Restricted Project
aeubanks requested review of D125328: [BasicAA] Fix order in which we pass MemoryLocations to alias().
Tue, May 10, 10:23 AM · Restricted Project, Restricted Project

Mon, May 9

aeubanks added a comment to D115750: [SLP]Further improvement of the cost model for scalars used in buildvectors..

(if you're interested in testing the recommit, consider running opt -O2 on the attached file)

Mon, May 9, 1:46 PM · Restricted Project, Restricted Project
aeubanks added a comment to D115750: [SLP]Further improvement of the cost model for scalars used in buildvectors..

another crash even with https://reviews.llvm.org/rGcce80bd8b74d54deb82b1b6ae0cbec1ab53c1dbb

Mon, May 9, 1:43 PM · Restricted Project, Restricted Project
aeubanks added a comment to D115750: [SLP]Further improvement of the cost model for scalars used in buildvectors..

another issue that repros at head

$ cat /tmp/a.ll
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
Mon, May 9, 1:17 PM · Restricted Project, Restricted Project
aeubanks committed rG431b23d20d5c: [opt] Error on `opt -O# --foo-pass` (authored by aeubanks).
[opt] Error on `opt -O# --foo-pass`
Mon, May 9, 9:53 AM · Restricted Project, Restricted Project
aeubanks closed D125196: [opt] Error on `opt -O# --foo-pass`.
Mon, May 9, 9:53 AM · Restricted Project, Restricted Project

Sun, May 8

aeubanks requested review of D125196: [opt] Error on `opt -O# --foo-pass`.
Sun, May 8, 5:25 PM · Restricted Project, Restricted Project

Wed, May 4

aeubanks accepted D124360: [Pipelines] Hoist CoroCleanup to avoid blocking optimizations.
Wed, May 4, 9:19 PM · Restricted Project, Restricted Project

Mon, May 2

aeubanks committed rGb07aab8fc108: [GlobalOpt] Iterate over replaced values deterministically to constprop (authored by aeubanks).
[GlobalOpt] Iterate over replaced values deterministically to constprop
Mon, May 2, 9:44 AM · Restricted Project, Restricted Project
aeubanks added a comment to D124514: [ArgPromotion] Make a non-byval promotion attempt first.

Change the test to use the legacy pass manager, unfortunately the buildbot doesn't accept tests with arguments for the opt tool in the following format: -passes=function(sroa),cgscc(argpromotion).

Mon, May 2, 9:27 AM · Restricted Project, Restricted Project

Fri, Apr 29

aeubanks added a comment to rG75881d8b023e: [NFC] const-ed the return type of FunctionPropertiesAnalysis.

many returned analyses can't be immutable, passes can either choose to invalidate them or manually keep them up to date, making them const wouldn't allow us to keep them up to date manually

Fri, Apr 29, 2:00 PM · Restricted Project, Restricted Project

Thu, Apr 28

aeubanks committed rG9197959e131e: [ArgPromotion] Move ArgPart and OffsetAndArgPart to anonymous namespace (authored by psamolysov).
[ArgPromotion] Move ArgPart and OffsetAndArgPart to anonymous namespace
Thu, Apr 28, 9:52 AM · Restricted Project, Restricted Project
aeubanks closed D124617: [ArgPromotion] Move ArgPart and OffsetAndArgPart to anonymous namespace.
Thu, Apr 28, 9:52 AM · Restricted Project, Restricted Project
aeubanks accepted D124617: [ArgPromotion] Move ArgPart and OffsetAndArgPart to anonymous namespace.
Thu, Apr 28, 9:51 AM · Restricted Project, Restricted Project
aeubanks committed rG6b825e50f7f4: [ArgPromotion] Change the condition to check the promotion limit (authored by psamolysov).
[ArgPromotion] Change the condition to check the promotion limit
Thu, Apr 28, 9:47 AM · Restricted Project, Restricted Project
aeubanks closed D124178: [ArgPromotion] Change the condition to check the promotion limit.
Thu, Apr 28, 9:47 AM · Restricted Project, Restricted Project

Wed, Apr 27

aeubanks committed rG4e65291837aa: [OpaquePtr][GlobalOpt] Don't attempt to evaluate global constructors with… (authored by aeubanks).
[OpaquePtr][GlobalOpt] Don't attempt to evaluate global constructors with…
Wed, Apr 27, 7:02 PM · Restricted Project, Restricted Project
aeubanks closed D124553: [OpaquePtr][GlobalOpt] Don't attempt to evaluate global constructors with arguments.
Wed, Apr 27, 7:02 PM · Restricted Project, Restricted Project
aeubanks added a reviewer for D124553: [OpaquePtr][GlobalOpt] Don't attempt to evaluate global constructors with arguments: Restricted Project.
Wed, Apr 27, 1:48 PM · Restricted Project, Restricted Project
aeubanks requested review of D124553: [OpaquePtr][GlobalOpt] Don't attempt to evaluate global constructors with arguments.
Wed, Apr 27, 1:48 PM · Restricted Project, Restricted Project
aeubanks accepted D124527: [GVN] Encode GEPs in offset representation.

but lg anyway

Wed, Apr 27, 9:53 AM · Restricted Project, Restricted Project
aeubanks added inline comments to D124527: [GVN] Encode GEPs in offset representation.
Wed, Apr 27, 9:45 AM · Restricted Project, Restricted Project
aeubanks accepted D124439: [JumpThreading][NFC][CompileTime] Do not recompute BPI/BFI analyzes.
Wed, Apr 27, 9:10 AM · Restricted Project, Restricted Project

Tue, Apr 26

aeubanks accepted D124459: [InstCombine] Combine opaque pointer GEPs with mismatching element types.
Tue, Apr 26, 11:17 AM · Restricted Project, Restricted Project
aeubanks added inline comments to D124459: [InstCombine] Combine opaque pointer GEPs with mismatching element types.
Tue, Apr 26, 11:17 AM · Restricted Project, Restricted Project
aeubanks accepted D124465: [AsmParser] Automatically declare and lex attribute keywords (NFC).
Tue, Apr 26, 10:02 AM · Restricted Project, Restricted Project
aeubanks added inline comments to D124439: [JumpThreading][NFC][CompileTime] Do not recompute BPI/BFI analyzes.
Tue, Apr 26, 9:54 AM · Restricted Project, Restricted Project

Mon, Apr 25

aeubanks accepted D124362: [NFC] [Pipelines] Hoist CoroCleanup as Module Pass (3/5).
Mon, Apr 25, 8:43 PM · Restricted Project, Restricted Project
aeubanks added a comment to D124364: [Pipelines] Enable EarlyCSE after CoroCleanup to avoid runtime performance losses (5/5).

would it make sense to put all of the coroutine lower passes right at the beginning of the pipeline? e.g. around LowerExpectIntrinsicPass? is there a reason CoroSplit is interleaved in the CGSCC pass manager?

I'd like to understand the constraints better before going forward with a solution that currently seems unprincipled to me

Mon, Apr 25, 10:12 AM · Restricted Project, Restricted Project
aeubanks added a comment to D124364: [Pipelines] Enable EarlyCSE after CoroCleanup to avoid runtime performance losses (5/5).

would it make sense to put all of the coroutine lower passes right at the beginning of the pipeline? e.g. around LowerExpectIntrinsicPass? is there a reason CoroSplit is interleaved in the CGSCC pass manager?

Mon, Apr 25, 10:11 AM · Restricted Project, Restricted Project
aeubanks added a comment to D124360: [Pipelines] Hoist CoroCleanup to avoid blocking optimizations.

would it make sense to put all of the coroutine lower passes right at the beginning of the pipeline? e.g. around LowerExpectIntrinsicPass? is there a reason CoroSplit is interleaved in the CGSCC pass manager?

Mon, Apr 25, 10:10 AM · Restricted Project, Restricted Project
aeubanks added a comment to D124360: [Pipelines] Hoist CoroCleanup to avoid blocking optimizations.

would it make sense to put all of the coroutine lower passes right at the beginning of the pipeline? e.g. around LowerExpectIntrinsicPass? is there a reason CoroSplit is interleaved in the CGSCC pass manager?

Mon, Apr 25, 10:08 AM · Restricted Project, Restricted Project
aeubanks committed rG6f73bd781305: [test] Remove legacy PM pipeline test (authored by aeubanks).
[test] Remove legacy PM pipeline test
Mon, Apr 25, 10:03 AM · Restricted Project, Restricted Project
aeubanks added a comment to D124376: [Passes] Remove legacy LoopUnswitch pass..

I've removed the failing opt-pipeline.ll test in 6f73bd781305266a747055875ce8352e5a36c809 since that's a legacy PM test

Mon, Apr 25, 10:03 AM · Restricted Project, Restricted Project
aeubanks added a comment to D124063: [LegacyPM] Rename and deprecate populateModulePassManager.

I'd first fix up as many in-tree users as nikic pointed out

Mon, Apr 25, 9:40 AM · Restricted Project, Restricted Project, Restricted Project
aeubanks added inline comments to D124178: [ArgPromotion] Change the condition to check the promotion limit.
Mon, Apr 25, 9:31 AM · Restricted Project, Restricted Project
aeubanks accepted D124376: [Passes] Remove legacy LoopUnswitch pass..
Mon, Apr 25, 9:05 AM · Restricted Project, Restricted Project
aeubanks added inline comments to D124362: [NFC] [Pipelines] Hoist CoroCleanup as Module Pass (3/5).
Mon, Apr 25, 8:24 AM · Restricted Project, Restricted Project

Apr 22 2022

aeubanks accepted D124259: [SimpleLoopUnswitch] Check if freeze is needed for partial unswitching..
Apr 22 2022, 9:38 AM · Restricted Project, Restricted Project

Apr 21 2022

aeubanks added a comment to D124209: [LegacyPM] Remove ThreadSanitizerLegacyPass.

the title should be "Remove" not "Rename"?

Apr 21 2022, 3:40 PM · Restricted Project, Restricted Project
aeubanks accepted D124178: [ArgPromotion] Change the condition to check the promotion limit.

looks good

Apr 21 2022, 11:57 AM · Restricted Project, Restricted Project

Apr 20 2022

aeubanks accepted D123942: llvm-reduce: Don't delete triple/datalayout.
Apr 20 2022, 3:04 PM · Restricted Project, Restricted Project
aeubanks added a comment to D123918: [Pipelines] Remove Legacy Passes in Coroutines.

I found there are some patches which removed legacy passes.

Yes. I have sent some after I saw nikic did for some.

An important user of us swiftshader uses createCoroCleanupLegacyPass. Would you mind giving us few days so that they can migrate away?

Of course!

Apr 20 2022, 12:56 PM · Restricted Project, Restricted Project, Restricted Project
aeubanks added a comment to rGe0736e742922: [ocaml bindings] Remove LTO bindings.

Sorry for the late response, but was the buildbot fixed with https://reviews.llvm.org/rGf2d955a8a420c6866dfc9e882c8aabf33775a3fc?

Apr 20 2022, 12:50 PM · Restricted Project, Restricted Project
aeubanks committed rG19884d62c44c: [clang-format] Don't skip PP lines if original line was a PP line when trying… (authored by aeubanks).
[clang-format] Don't skip PP lines if original line was a PP line when trying…
Apr 20 2022, 8:43 AM · Restricted Project, Restricted Project
aeubanks closed D124036: [clang-format] Don't skip PP lines if original line was a PP line when trying to merge lines.
Apr 20 2022, 8:43 AM · Restricted Project, Restricted Project
aeubanks updated the diff for D124036: [clang-format] Don't skip PP lines if original line was a PP line when trying to merge lines.

take suggestion

Apr 20 2022, 8:42 AM · Restricted Project, Restricted Project
aeubanks added inline comments to D124036: [clang-format] Don't skip PP lines if original line was a PP line when trying to merge lines.
Apr 20 2022, 8:42 AM · Restricted Project, Restricted Project

Apr 19 2022

aeubanks added reviewers for D124036: [clang-format] Don't skip PP lines if original line was a PP line when trying to merge lines: curdeius, owenpan, MyDeveloperDay.
Apr 19 2022, 1:07 PM · Restricted Project, Restricted Project
aeubanks added inline comments to D124036: [clang-format] Don't skip PP lines if original line was a PP line when trying to merge lines.
Apr 19 2022, 1:06 PM · Restricted Project, Restricted Project