In D66490#1638708, @hfinkel wrote:

In D66490#1638162, @rupprecht wrote:

We already know that we don't want this enabled for tsan builds due to https://bugs.llvm.org/show_bug.cgi?id=42877, but I don't even know if anyone else will hit it (it's only when building one particular library).

Under the circumstances, that seems like one particular library too many. PR42877 looks like a generic bug, so if we're hitting it here, I see no reason to suspect that others would not hit it elsewhere.

Specifically regarding
../../base/debug/close_handle_hook_win.cc(155,16): error: cast to smaller integer type 'unsigned long' from 'void *',
I sent out a change to fix that: https://chromium-review.googlesource.com/c/chromium/src/+/2091215, and tried compiling with ToT clang with the suppression removed, then there were no more errors.

• Format

I can push this for you and even give attribution (hooray, git!), but I think you have enough uploaded code reviews that you could request push access as described here:
https://llvm.org/docs/DeveloperPolicy.html#new-contributors
Link to all the phab issues you have opened to show contributions.

• Add tests for void *

• Skip preallocated in addRawAttributeValue()
• Add extra CHECK-NEXT in operand-bundles-bc-analyzer.ll

• Add preallocated attribute to function declaration parameters in tests
• Add preallocated attribute to attributes test
• Based on attribute test, found some places that I missed regarding reading/writing asm files
• Format

Fix arc diff

Fix typo

Fix bad arc diff

Add and enforce matching preallocated attribute in callee parameter

Add preallocated attribute, major cleanups

Simplify some code, add more tests, check operand bundle type instead of checking that the value is a ConstantTokenNone