Page MenuHomePhabricator

aeubanks (Arthur Eubanks)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 12 2020, 11:23 AM (7 w, 4 d)

Recent Activity

Thu, Apr 2

aeubanks added a comment to D66490: [NewPM] Enable the New Pass Manager by Default in Clang.

We already know that we don't want this enabled for tsan builds due to https://bugs.llvm.org/show_bug.cgi?id=42877, but I don't even know if anyone else will hit it (it's only when building one particular library).

Under the circumstances, that seems like one particular library too many. PR42877 looks like a generic bug, so if we're hitting it here, I see no reason to suspect that others would not hit it elsewhere.

Thu, Apr 2, 8:36 PM · Restricted Project

Mon, Mar 9

aeubanks committed rG3262319806d7: Fix typo in gn files (authored by aeubanks).
Fix typo in gn files
Mon, Mar 9, 2:04 PM
aeubanks abandoned D75752: [Sema] Move pointer to int cast warnings under -Wmicrosoft-cast.
Mon, Mar 9, 2:03 PM · Restricted Project
aeubanks committed rG51d7f645448b: Don't emit pointer to int cast warnings under -Wmicrosoft-cast (authored by aeubanks).
Don't emit pointer to int cast warnings under -Wmicrosoft-cast
Mon, Mar 9, 1:31 PM
aeubanks closed D75643: [Sema] Don't emit pointer to int cast warnings under -Wmicrosoft-cast.
Mon, Mar 9, 1:31 PM · Restricted Project

Fri, Mar 6

aeubanks added a comment to D75752: [Sema] Move pointer to int cast warnings under -Wmicrosoft-cast.

Specifically regarding
../../base/debug/close_handle_hook_win.cc(155,16): error: cast to smaller integer type 'unsigned long' from 'void *',
I sent out a change to fix that: https://chromium-review.googlesource.com/c/chromium/src/+/2091215, and tried compiling with ToT clang with the suppression removed, then there were no more errors.

Fri, Mar 6, 2:22 PM · Restricted Project

Mar 6 2020

aeubanks retitled D75752: [Sema] Move pointer to int cast warnings under -Wmicrosoft-cast from Move warnings added in https://reviews.llvm.org/D75708 under -Wmicrosoft-cast to [Sema] Move pointer to int cast warnings under -Wmicrosoft-cast.
Mar 6 2020, 8:46 AM · Restricted Project
aeubanks created D75752: [Sema] Move pointer to int cast warnings under -Wmicrosoft-cast.
Mar 6 2020, 8:46 AM · Restricted Project
aeubanks updated the summary of D75752: [Sema] Move pointer to int cast warnings under -Wmicrosoft-cast.
Mar 6 2020, 8:46 AM · Restricted Project

Mar 5 2020

aeubanks updated the diff for D75708: Add warnings for casting ptr -> smaller int for C++ in Microsoft mode.
  • Format
Mar 5 2020, 3:21 PM · Restricted Project
aeubanks added a comment to D75708: Add warnings for casting ptr -> smaller int for C++ in Microsoft mode.

I can push this for you and even give attribution (hooray, git!), but I think you have enough uploaded code reviews that you could request push access as described here:
https://llvm.org/docs/DeveloperPolicy.html#new-contributors
Link to all the phab issues you have opened to show contributions.

Mar 5 2020, 2:49 PM · Restricted Project
aeubanks updated the diff for D75708: Add warnings for casting ptr -> smaller int for C++ in Microsoft mode.
  • Add tests for void *
Mar 5 2020, 2:49 PM · Restricted Project
aeubanks created D75708: Add warnings for casting ptr -> smaller int for C++ in Microsoft mode.
Mar 5 2020, 1:44 PM · Restricted Project

Mar 4 2020

aeubanks retitled D75643: [Sema] Don't emit pointer to int cast warnings under -Wmicrosoft-cast from Don't emit pointer to int cast warnings under -Wmicrosoft-cast to [Sema] Don't emit pointer to int cast warnings under -Wmicrosoft-cast.
Mar 4 2020, 2:37 PM · Restricted Project
aeubanks added reviewers for D75643: [Sema] Don't emit pointer to int cast warnings under -Wmicrosoft-cast: rnk, thakis, Mordante.
Mar 4 2020, 2:05 PM · Restricted Project
aeubanks created D75643: [Sema] Don't emit pointer to int cast warnings under -Wmicrosoft-cast.
Mar 4 2020, 2:05 PM · Restricted Project

Mar 3 2020

aeubanks updated the diff for D74651: Add IR constructs for inalloca replacement llvm.call.setup.
  • Skip preallocated in addRawAttributeValue()
  • Add extra CHECK-NEXT in operand-bundles-bc-analyzer.ll
Mar 3 2020, 10:56 AM · Restricted Project

Mar 2 2020

aeubanks updated the diff for D74651: Add IR constructs for inalloca replacement llvm.call.setup.
  • Add preallocated attribute to function declaration parameters in tests
  • Add preallocated attribute to attributes test
  • Based on attribute test, found some places that I missed regarding reading/writing asm files
  • Format
Mar 2 2020, 4:38 PM · Restricted Project

Feb 28 2020

aeubanks updated the diff for D74651: Add IR constructs for inalloca replacement llvm.call.setup.

Fix arc diff

Feb 28 2020, 9:01 AM · Restricted Project
aeubanks updated the diff for D74651: Add IR constructs for inalloca replacement llvm.call.setup.

Fix typo

Feb 28 2020, 9:01 AM · Restricted Project

Feb 21 2020

aeubanks updated the diff for D74651: Add IR constructs for inalloca replacement llvm.call.setup.

Fix bad arc diff

Feb 21 2020, 3:35 PM · Restricted Project
aeubanks updated the diff for D74651: Add IR constructs for inalloca replacement llvm.call.setup.

Add and enforce matching preallocated attribute in callee parameter

Feb 21 2020, 3:16 PM · Restricted Project

Feb 20 2020

aeubanks added a reviewer for D74651: Add IR constructs for inalloca replacement llvm.call.setup: rnk.
Feb 20 2020, 9:07 AM · Restricted Project
aeubanks retitled D74651: Add IR constructs for inalloca replacement llvm.call.setup from [WIP] Add intrinsics and operand bundles for inalloca replacement llvm.call.setup to Add IR constructs for inalloca replacement llvm.call.setup.
Feb 20 2020, 9:06 AM · Restricted Project
aeubanks updated the diff for D74651: Add IR constructs for inalloca replacement llvm.call.setup.

Add preallocated attribute, major cleanups

Feb 20 2020, 9:06 AM · Restricted Project

Feb 18 2020

aeubanks added inline comments to D74651: Add IR constructs for inalloca replacement llvm.call.setup.
Feb 18 2020, 3:11 PM · Restricted Project
aeubanks updated the diff for D74651: Add IR constructs for inalloca replacement llvm.call.setup.

Simplify some code, add more tests, check operand bundle type instead of checking that the value is a ConstantTokenNone

Feb 18 2020, 3:11 PM · Restricted Project

Feb 14 2020

aeubanks retitled D74651: Add IR constructs for inalloca replacement llvm.call.setup from Add intrinsics and operand bundles for inalloca replacement llvm.call.setup to [WIP] Add intrinsics and operand bundles for inalloca replacement llvm.call.setup.
Feb 14 2020, 2:30 PM · Restricted Project
aeubanks created D74651: Add IR constructs for inalloca replacement llvm.call.setup.
Feb 14 2020, 2:20 PM · Restricted Project