For more details about these instructions, please refer to the latest ISE document: https://www.intel.com/content/www/us/en/develop/download/intel-architecture-instruction-set-extensions-programming-reference.html
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/test/CodeGen/avxvnniint8-builtins.c | ||
---|---|---|
2 | 32-bit test coverage? |
I'm out of machines next two days. Sorry for late address in advance... I'll update next Monday. Thanks for review!
clang/docs/ReleaseNotes.rst | ||
---|---|---|
637 | Please add a bullet list of the added intrinsics | |
clang/lib/Headers/avxvnniint8intrin.h | ||
33 | Please add doxygen descriptions for each intrinsic | |
llvm/test/MC/Disassembler/X86/avx-vnni_int8-att.txt | ||
1 ↗ | (On Diff #468144) | I think we'd be better off merging the att/intel test files and using --check-prefix |
llvm/test/MC/Disassembler/X86/avx-vnni_int8-att.txt | ||
---|---|---|
1 ↗ | (On Diff #468144) | I see many old tests split them into two files. What about remove 32bit att test and 64 bit intel test, it can also help reduce code base? |
Can you fix the MC + disasm test file names - drop att/intel and ensure you test both syntaxes for 32 and 64 bits.
Ideally the 32/64 bit names should be close to each other in a file list (e.g. avx-vnni-int8-32.s + avx-vnni-int8-64.s ?)
I get your point of "close to each other" and updated. And I merged the Disasm tests, while I didn't merge the MC tests because it is not so convenient to do. See latest updated.
Do we need to rename old tests to follow this rule? Old tests: https://github.com/llvm/llvm-project/tree/main/llvm/test/MC/X86 and https://github.com/llvm/llvm-project/tree/main/llvm/test/MC/Disassembler/X86
llvm/test/CodeGen/X86/avxvnniint8-intrinsics.ll | ||
---|---|---|
7 | Hi Craig, |
llvm/test/CodeGen/X86/avxvnniint8-intrinsics.ll | ||
---|---|---|
7 | See stack_fold_vpdpwssd_commuted in stack-folding-int-avxvnni.ll |
Address comment. Add commute tests.
llvm/test/CodeGen/X86/avxvnniint8-intrinsics.ll | ||
---|---|---|
7 | Got it. Thanks! |
Its not a priority, but if you are ever bored and want to do some cleaning then it help!
Its not a priority, but if you are ever bored and want to do some cleaning then it help!
I see. Then we are on the same side. I'll clean if I had time after landing these patches.
llvm/include/llvm/Support/X86TargetParser.def | ||
---|---|---|
206 | Move it after AVXVNNI to keep the dictionary order? | |
llvm/lib/Target/X86/X86InstrSSE.td | ||
8127–8131 | Could you unify the name converntion? e.g Captialize the first character for all parameters for this multiclass. | |
llvm/test/CodeGen/X86/stack-folding-int-avxvnniint8.ll | ||
5–6 | Could we remove these two lines? |
llvm/include/llvm/Support/X86TargetParser.def | ||
---|---|---|
206 | Better refine at another patch since it's not ordered already | |
llvm/lib/Target/X86/X86ISelLowering.h | ||
592 | Yes. A continued patch will support DAG combine like old VNNI instructions. https://reviews.llvm.org/D116039 |
Please add a bullet list of the added intrinsics