Page MenuHomePhabricator

LuoYuanke (LuoYuanke)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 24 2018, 10:28 PM (121 w, 3 d)

Recent Activity

Today

LuoYuanke added inline comments to D95136: [X86] Fix tile config register spill issue..
Fri, Jan 22, 12:42 AM · Restricted Project

Yesterday

LuoYuanke added reviewers for D95136: [X86] Fix tile config register spill issue.: wxiao3, xiangzhangllvm.
Thu, Jan 21, 4:27 PM · Restricted Project
LuoYuanke added a reverting change for rG20013d02f335: [X86][AMX] Fix tile config register spill issue.: rG64132f541edd: Revert "[X86][AMX] Fix tile config register spill issue.".
Thu, Jan 21, 2:12 AM
LuoYuanke committed rG64132f541edd: Revert "[X86][AMX] Fix tile config register spill issue." (authored by LuoYuanke).
Revert "[X86][AMX] Fix tile config register spill issue."
Thu, Jan 21, 2:12 AM
LuoYuanke added a reverting change for D94155: [X86] Fix tile config register spill issue.: rG64132f541edd: Revert "[X86][AMX] Fix tile config register spill issue.".
Thu, Jan 21, 2:12 AM · Restricted Project
LuoYuanke added a comment to D94155: [X86] Fix tile config register spill issue..
Thu, Jan 21, 2:11 AM · Restricted Project
LuoYuanke added inline comments to D94155: [X86] Fix tile config register spill issue..
Thu, Jan 21, 12:58 AM · Restricted Project
LuoYuanke added inline comments to D94155: [X86] Fix tile config register spill issue..
Thu, Jan 21, 12:38 AM · Restricted Project
LuoYuanke added a comment to D94155: [X86] Fix tile config register spill issue..
Thu, Jan 21, 12:26 AM · Restricted Project
LuoYuanke committed rG20013d02f335: [X86][AMX] Fix tile config register spill issue. (authored by LuoYuanke).
[X86][AMX] Fix tile config register spill issue.
Thu, Jan 21, 12:02 AM
LuoYuanke closed D94155: [X86] Fix tile config register spill issue..
Thu, Jan 21, 12:02 AM · Restricted Project

Tue, Jan 19

LuoYuanke added a comment to D94155: [X86] Fix tile config register spill issue..

LGTM, but let's wait for one day or two to see others' opinions.

Tue, Jan 19, 7:25 PM · Restricted Project
LuoYuanke updated the diff for D94155: [X86] Fix tile config register spill issue..

Rebase.

Tue, Jan 19, 5:01 AM · Restricted Project
LuoYuanke updated the diff for D94155: [X86] Fix tile config register spill issue..

Address Pengfei's comments.

Tue, Jan 19, 3:45 AM · Restricted Project
LuoYuanke added inline comments to D94155: [X86] Fix tile config register spill issue..
Tue, Jan 19, 3:45 AM · Restricted Project
LuoYuanke committed rG7e1d2224b42b: [X86][AMX] Fix the typo. (authored by LuoYuanke).
[X86][AMX] Fix the typo.
Tue, Jan 19, 12:58 AM
LuoYuanke closed D94943: [X86][AMX] Fix the typo..
Tue, Jan 19, 12:58 AM · Restricted Project

Mon, Jan 18

LuoYuanke added reviewers for D94943: [X86][AMX] Fix the typo.: pengfei, yubing, craig.topper.
Mon, Jan 18, 9:07 PM · Restricted Project
LuoYuanke requested review of D94943: [X86][AMX] Fix the typo..
Mon, Jan 18, 9:05 PM · Restricted Project
LuoYuanke committed rGe147eccafa15: [X86][AMX] Clear AMX lit test case. (authored by LuoYuanke).
[X86][AMX] Clear AMX lit test case.
Mon, Jan 18, 7:26 PM
LuoYuanke closed D94910: [X86][AMX] Clear AMX lit test case..
Mon, Jan 18, 7:26 PM · Restricted Project
LuoYuanke updated the diff for D94910: [X86][AMX] Clear AMX lit test case..

Address Pengfei's comments.

Mon, Jan 18, 6:59 PM · Restricted Project
LuoYuanke committed rGc535a7fdadb4: [X86] Fix tile spill merge issue. (authored by LuoYuanke).
[X86] Fix tile spill merge issue.
Mon, Jan 18, 6:52 PM
LuoYuanke closed D94772: [X86] Fix tile spill merge issue..
Mon, Jan 18, 6:52 PM · Restricted Project
LuoYuanke added reviewers for D94910: [X86][AMX] Clear AMX lit test case.: pengfei, craig.topper.
Mon, Jan 18, 5:27 AM · Restricted Project
LuoYuanke requested review of D94910: [X86][AMX] Clear AMX lit test case..
Mon, Jan 18, 5:26 AM · Restricted Project
LuoYuanke updated the diff for D94772: [X86] Fix tile spill merge issue..

Address Pengfei's comments.

Mon, Jan 18, 12:53 AM · Restricted Project
LuoYuanke added inline comments to D94772: [X86] Fix tile spill merge issue..
Mon, Jan 18, 12:40 AM · Restricted Project

Sat, Jan 16

LuoYuanke added inline comments to D94155: [X86] Fix tile config register spill issue..
Sat, Jan 16, 6:05 PM · Restricted Project
LuoYuanke updated the diff for D94155: [X86] Fix tile config register spill issue..

Address Xiang's comments.

Sat, Jan 16, 6:02 PM · Restricted Project
LuoYuanke updated the diff for D94155: [X86] Fix tile config register spill issue..

Make the logic more clean.

Sat, Jan 16, 1:41 AM · Restricted Project

Fri, Jan 15

LuoYuanke updated subscribers of D94772: [X86] Fix tile spill merge issue..
Fri, Jan 15, 6:02 AM · Restricted Project
LuoYuanke added reviewers for D94772: [X86] Fix tile spill merge issue.: wxiao3, pengfei, qcolombet, craig.topper.
Fri, Jan 15, 6:02 AM · Restricted Project
LuoYuanke requested review of D94772: [X86] Fix tile spill merge issue..
Fri, Jan 15, 6:00 AM · Restricted Project

Thu, Jan 14

LuoYuanke updated the diff for D94155: [X86] Fix tile config register spill issue..

Get tile register number from backend.

Thu, Jan 14, 5:42 AM · Restricted Project
LuoYuanke updated the summary of D94155: [X86] Fix tile config register spill issue..
Thu, Jan 14, 5:31 AM · Restricted Project
LuoYuanke updated the diff for D94155: [X86] Fix tile config register spill issue..

We also need check tile config register interference. Since we
don't model the config register we should check interference from the
ldtilecfg to each tile data register def.

      ldtilecfg
      /       \
    BB1      BB2
     /         \
    call       BB3
    /           \
%1=tileload   %2=tilezero

We can start from the instruction of each tile def, and backward to
ldtilecfg. If there is any call instruction, and tile data register is
not preserved, we should insert ldtilecfg after the call instruction.

Thu, Jan 14, 5:30 AM · Restricted Project

Wed, Jan 13

LuoYuanke added a reviewer for D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM: craig.topper.
Wed, Jan 13, 5:02 AM · Restricted Project
LuoYuanke updated the diff for D94155: [X86] Fix tile config register spill issue..

Address Pengfei's comments.

Wed, Jan 13, 4:16 AM · Restricted Project

Tue, Jan 12

LuoYuanke added inline comments to D94155: [X86] Fix tile config register spill issue..
Tue, Jan 12, 11:40 PM · Restricted Project
LuoYuanke updated subscribers of D93594: [X86] Pass to transform amx intrinsics to scalar operation..
Tue, Jan 12, 10:01 PM · Restricted Project
LuoYuanke updated the diff for D93594: [X86] Pass to transform amx intrinsics to scalar operation..

Support tile_zero and fix bugs for tile_load and tile_store.

Tue, Jan 12, 9:44 PM · Restricted Project
LuoYuanke committed rG055644cc459e: [X86][AMX] Prohibit pointer cast on load. (authored by LuoYuanke).
[X86][AMX] Prohibit pointer cast on load.
Tue, Jan 12, 5:40 PM
LuoYuanke closed D94372: [X86][AMX] Prohibit pointer cast on load..
Tue, Jan 12, 5:39 PM · Restricted Project
LuoYuanke added a comment to D94372: [X86][AMX] Prohibit pointer cast on load..

LGTM, but I'd like to see if @lebedev.ri has any objections.

Tue, Jan 12, 12:30 AM · Restricted Project

Mon, Jan 11

LuoYuanke updated the diff for D94372: [X86][AMX] Prohibit pointer cast on load..

Address Pengfei's comments.

Mon, Jan 11, 7:43 PM · Restricted Project
LuoYuanke added a comment to D94415: Fix minor build issue (NFC).

Thank David!

Mon, Jan 11, 3:56 PM · Restricted Project
LuoYuanke committed rGc5be0e0cc0e2: [X86] Fix tile register spill issue. (authored by LuoYuanke).
[X86] Fix tile register spill issue.
Mon, Jan 11, 2:36 AM
LuoYuanke closed D93898: [X86] Fix tile register spill issue..
Mon, Jan 11, 2:35 AM · Restricted Project

Sun, Jan 10

LuoYuanke added inline comments to D94372: [X86][AMX] Prohibit pointer cast on load..
Sun, Jan 10, 5:43 AM · Restricted Project
LuoYuanke added a comment to D94372: [X86][AMX] Prohibit pointer cast on load..

What specifically is having problems after that transformation?

Sun, Jan 10, 5:09 AM · Restricted Project
LuoYuanke updated the diff for D94372: [X86][AMX] Prohibit pointer cast on load..

Address Pengfei's comments.

Sun, Jan 10, 3:59 AM · Restricted Project
LuoYuanke added inline comments to D94372: [X86][AMX] Prohibit pointer cast on load..
Sun, Jan 10, 3:51 AM · Restricted Project
LuoYuanke updated the summary of D94372: [X86][AMX] Prohibit pointer cast on load..
Sun, Jan 10, 3:48 AM · Restricted Project

Sat, Jan 9

LuoYuanke updated the diff for D94372: [X86][AMX] Prohibit pointer cast on load..

Fix typo in the comments.

Sat, Jan 9, 10:14 PM · Restricted Project
LuoYuanke added reviewers for D94372: [X86][AMX] Prohibit pointer cast on load.: craig.topper, pengfei.
Sat, Jan 9, 10:12 PM · Restricted Project
LuoYuanke requested review of D94372: [X86][AMX] Prohibit pointer cast on load..
Sat, Jan 9, 10:10 PM · Restricted Project

Wed, Jan 6

LuoYuanke added a comment to D93898: [X86] Fix tile register spill issue..

LGTM. But I suggest you waiting for one or two days to see if @qcolombet or others object.

Wed, Jan 6, 9:04 PM · Restricted Project
LuoYuanke updated the diff for D94155: [X86] Fix tile config register spill issue..

Add test case for IPRA.

Wed, Jan 6, 12:38 AM · Restricted Project

Tue, Jan 5

LuoYuanke added inline comments to D94155: [X86] Fix tile config register spill issue..
Tue, Jan 5, 11:45 PM · Restricted Project
LuoYuanke added reviewers for D94155: [X86] Fix tile config register spill issue.: craig.topper, wxiao3, pengfei, qcolombet.
Tue, Jan 5, 11:19 PM · Restricted Project
LuoYuanke updated the diff for D94155: [X86] Fix tile config register spill issue..

Remove dead code.

Tue, Jan 5, 11:14 PM · Restricted Project
LuoYuanke requested review of D94155: [X86] Fix tile config register spill issue..
Tue, Jan 5, 10:55 PM · Restricted Project

Sun, Jan 3

LuoYuanke added inline comments to D93898: [X86] Fix tile register spill issue..
Sun, Jan 3, 8:36 PM · Restricted Project
LuoYuanke updated the diff for D93898: [X86] Fix tile register spill issue..

Address Wei's comments.

Sun, Jan 3, 8:32 PM · Restricted Project
LuoYuanke updated the diff for D93898: [X86] Fix tile register spill issue..

Rebase.

Sun, Jan 3, 4:20 PM · Restricted Project
LuoYuanke added inline comments to D93983: RegAllocFast: Do not free later early-clobbered registers..
Sun, Jan 3, 6:02 AM · Restricted Project

Wed, Dec 30

LuoYuanke committed rG08665b180568: Support tilezero intrinsic and c interface for AMX. (authored by LuoYuanke).
Support tilezero intrinsic and c interface for AMX.
Wed, Dec 30, 9:36 PM
LuoYuanke closed D92837: [X86] Support tilezero intrinsic and c interface for AMX..
Wed, Dec 30, 9:36 PM · Restricted Project, Restricted Project
LuoYuanke updated the diff for D92837: [X86] Support tilezero intrinsic and c interface for AMX..

Rebase.

Wed, Dec 30, 9:34 PM · Restricted Project, Restricted Project
LuoYuanke updated the diff for D92837: [X86] Support tilezero intrinsic and c interface for AMX..

Add avx512f in test case.

Wed, Dec 30, 6:00 PM · Restricted Project, Restricted Project
LuoYuanke added a comment to D91927: [X86] Add x86_amx type for intel AMX..

Thank @pengfei and @MaskRay.

Wed, Dec 30, 5:27 PM · Restricted Project, Restricted Project
LuoYuanke updated the diff for D92837: [X86] Support tilezero intrinsic and c interface for AMX..

Rebase.

Wed, Dec 30, 1:38 AM · Restricted Project, Restricted Project

Tue, Dec 29

LuoYuanke committed rG6e9755bb80c8: [X86] Refactor AMX test case, remove unnecessary code. (authored by LuoYuanke).
[X86] Refactor AMX test case, remove unnecessary code.
Tue, Dec 29, 11:44 PM
LuoYuanke closed D93792: [X86] Refactor AMX test case, remove unnecessary code..
Tue, Dec 29, 11:44 PM · Restricted Project
LuoYuanke updated the diff for D93792: [X86] Refactor AMX test case, remove unnecessary code..

Remove datalayout from test case.

Tue, Dec 29, 11:39 PM · Restricted Project
LuoYuanke updated the diff for D93792: [X86] Refactor AMX test case, remove unnecessary code..

Rebase

Tue, Dec 29, 11:23 PM · Restricted Project
LuoYuanke committed rG981a0bd85811: [X86] Add x86_amx type for intel AMX. (authored by LuoYuanke).
[X86] Add x86_amx type for intel AMX.
Tue, Dec 29, 9:52 PM
LuoYuanke closed D91927: [X86] Add x86_amx type for intel AMX..
Tue, Dec 29, 9:52 PM · Restricted Project, Restricted Project
LuoYuanke added reviewers for D93898: [X86] Fix tile register spill issue.: wxiao3, craig.topper, pengfei, qcolombet.
Tue, Dec 29, 4:16 AM · Restricted Project
LuoYuanke requested review of D93898: [X86] Fix tile register spill issue..
Tue, Dec 29, 4:08 AM · Restricted Project

Thu, Dec 24

LuoYuanke added a comment to D91927: [X86] Add x86_amx type for intel AMX..

LGTM. Thanks for the refactors. Maybe better to wait for a few days to see if others have objections.

Thu, Dec 24, 12:36 AM · Restricted Project, Restricted Project
LuoYuanke updated the diff for D91927: [X86] Add x86_amx type for intel AMX..

Refine comments.

Thu, Dec 24, 12:28 AM · Restricted Project, Restricted Project
LuoYuanke updated the diff for D91927: [X86] Add x86_amx type for intel AMX..

Address Pengfei's comments.

Thu, Dec 24, 12:13 AM · Restricted Project, Restricted Project

Wed, Dec 23

LuoYuanke added inline comments to D91927: [X86] Add x86_amx type for intel AMX..
Wed, Dec 23, 11:19 PM · Restricted Project, Restricted Project
LuoYuanke updated the diff for D93792: [X86] Refactor AMX test case, remove unnecessary code..

Address Pengfei's comments.

Wed, Dec 23, 10:50 PM · Restricted Project
LuoYuanke updated the summary of D93792: [X86] Refactor AMX test case, remove unnecessary code..
Wed, Dec 23, 7:39 PM · Restricted Project
LuoYuanke requested review of D93792: [X86] Refactor AMX test case, remove unnecessary code..
Wed, Dec 23, 7:37 PM · Restricted Project
LuoYuanke updated the diff for D91927: [X86] Add x86_amx type for intel AMX..

Improve the comments.

Wed, Dec 23, 6:19 PM · Restricted Project, Restricted Project
LuoYuanke requested review of D93788: [X86] Transform amx pointer..
Wed, Dec 23, 6:03 PM · Restricted Project
LuoYuanke updated the diff for D91927: [X86] Add x86_amx type for intel AMX..

Address Pengfei's comments.

Wed, Dec 23, 5:53 PM · Restricted Project, Restricted Project
LuoYuanke added a comment to D91927: [X86] Add x86_amx type for intel AMX..

In my test case, it is transformed after Combine redundant instructions.

Can we disable it for AMX type? The pointer to AMX type is meaningless and may result in bad perfomance.

Wed, Dec 23, 5:30 PM · Restricted Project, Restricted Project

Dec 22 2020

LuoYuanke updated the diff for D93594: [X86] Pass to transform amx intrinsics to scalar operation..

Scalarize tilestore.

Dec 22 2020, 11:48 PM · Restricted Project
LuoYuanke added inline comments to D91927: [X86] Add x86_amx type for intel AMX..
Dec 22 2020, 10:04 PM · Restricted Project, Restricted Project
LuoYuanke updated the diff for D93740: [X86] Canonicalize AMX bitcast instruction..

Move comments.

Dec 22 2020, 7:32 PM · Restricted Project
LuoYuanke updated the summary of D93740: [X86] Canonicalize AMX bitcast instruction..
Dec 22 2020, 6:30 PM · Restricted Project
LuoYuanke requested review of D93740: [X86] Canonicalize AMX bitcast instruction..
Dec 22 2020, 6:29 PM · Restricted Project
LuoYuanke updated the diff for D91927: [X86] Add x86_amx type for intel AMX..

Address Pengfei's comments.

Dec 22 2020, 5:44 PM · Restricted Project, Restricted Project
LuoYuanke added inline comments to D91927: [X86] Add x86_amx type for intel AMX..
Dec 22 2020, 3:20 PM · Restricted Project, Restricted Project
LuoYuanke updated the diff for D91927: [X86] Add x86_amx type for intel AMX..

Rebase and fix lit test case failure.

Dec 22 2020, 6:47 AM · Restricted Project, Restricted Project