User Details
User Details
- User Since
- Apr 23 2019, 8:52 PM (230 w, 6 d)
Fri, Sep 15
Fri, Sep 15
Wed, Sep 13
Wed, Sep 13
Herald added a project to D105466: [RuntimeDyld] Implemented relocation of TLS symbols in ELF: Restricted Project.
Wed, Sep 6
Wed, Sep 6
skan accepted D159250: [X86][RFC] Add new option `-m[no-]evex512` to disable ZMM and 64-bit mask instructions for AVX512 features.
LGTM
Sun, Sep 3
Sun, Sep 3
Sun, Aug 27
Sun, Aug 27
LGTM
Aug 18 2023
Aug 18 2023
skan accepted D158252: Fix regression of D157680.
LGTM
Aug 16 2023
Aug 16 2023
skan accepted D158137: Rename warn_drv_overriding_flag_option (-Woverriding-t-option) to warn_drv_overriding_flag_option (-Woverriding-option).
LGTM
LGTM
Aug 15 2023
Aug 15 2023
skan added inline comments to D157485: [X86][RFC] Support new feature AVX10.
skan added inline comments to D157485: [X86][RFC] Support new feature AVX10.
skan retitled D157948: [NFC] Fix possibly deref nullptr from Fix possibly deref nullptr to [NFC] Fix possibly deref nullptr.
LGTM
skan added inline comments to D157948: [NFC] Fix possibly deref nullptr.
skan added inline comments to D157948: [NFC] Fix possibly deref nullptr.
skan added a comment to D157948: [NFC] Fix possibly deref nullptr.
skan added a comment to D157948: [NFC] Fix possibly deref nullptr.
Aug 14 2023
Aug 14 2023
skan added a comment to D157948: [NFC] Fix possibly deref nullptr.
Is this a NFC change or a bug fix? If NFC, shouldn't we use assert?
skan committed rGf450fc3edbc9: Revert "[X86][NFC] Remove dead code in TD for ADCX/ADOX" (authored by skan).
Revert "[X86][NFC] Remove dead code in TD for ADCX/ADOX"
[X86][NFC] Remove dead code in TD for ADCX/ADOX
skan committed rGc23b1a0cb7b3: [X86][test] Add missing encoding tests for ADCX/ADOX (authored by skan).
[X86][test] Add missing encoding tests for ADCX/ADOX
Aug 13 2023
Aug 13 2023
skan added reviewers for D157835: [X86][test] Add missing encoding tests for ADCX/ADOX: pengfei, craig.topper, RKSimon.
skan requested review of D157835: [X86][test] Add missing encoding tests for ADCX/ADOX.
[X86][Codegen] Remove dead code for ADCX/ADOX
skan updated the summary of D157717: [X86][Codegen] Remove dead code for ADCX/ADOX.
skan added inline comments to D157717: [X86][Codegen] Remove dead code for ADCX/ADOX.
skan updated the diff for D157717: [X86][Codegen] Remove dead code for ADCX/ADOX.
Address review comments: keep the predicate
Aug 12 2023
Aug 12 2023
skan added inline comments to D157717: [X86][Codegen] Remove dead code for ADCX/ADOX.
Aug 11 2023
Aug 11 2023
skan added inline comments to D157680: [X86]Support options -mno-gather -mno-scatter.
skan added reviewers for D157717: [X86][Codegen] Remove dead code for ADCX/ADOX: pengfei, craig.topper, XinWang10.
skan requested review of D157717: [X86][Codegen] Remove dead code for ADCX/ADOX.
Aug 7 2023
Aug 7 2023
LGTM
Aug 2 2023
Aug 2 2023
LGTM
Jul 27 2023
Jul 27 2023
Jul 26 2023
Jul 26 2023
Jul 24 2023
Jul 24 2023
LGTM
Jul 24 2023, 6:11 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Jul 20 2023
Jul 20 2023
skan added a comment to D155784: [X86] Update features for sierraforest, grandridge.
LGTM
Jul 19 2023
Jul 19 2023
LGTM
skan added a comment to D155662: [X86] Promote VAES, SHA512, SM4 implied feature to AVX2.
Jul 18 2023
Jul 18 2023
skan added inline comments to D155662: [X86] Promote VAES, SHA512, SM4 implied feature to AVX2.
skan accepted D155148: [X86] Add SM4 instructions..
LGTM
Jul 17 2023
Jul 17 2023
skan accepted D155146: [X86] Add SHA512 instructions..
LGTM
Jul 16 2023
Jul 16 2023
skan accepted D155142: [X86] Add PBNDKB instruction..
LGTM
Jul 13 2023
Jul 13 2023
skan added inline comments to D155142: [X86] Add PBNDKB instruction..
skan added inline comments to D155142: [X86] Add PBNDKB instruction..
skan added inline comments to D155147: [X86] Add SM3 instructions..
skan added inline comments to D155148: [X86] Add SM4 instructions..
skan added inline comments to D155142: [X86] Add PBNDKB instruction..
Jul 6 2023
Jul 6 2023
LGTM
Jul 5 2023
Jul 5 2023
LGTM
Jul 4 2023
Jul 4 2023
skan added inline comments to D154193: [X86]Remove TEST in AND32ri+TEST16rr in peephole-opt.
skan added inline comments to D154193: [X86]Remove TEST in AND32ri+TEST16rr in peephole-opt.
skan added inline comments to D154193: [X86]Remove TEST in AND32ri+TEST16rr in peephole-opt.
Jul 3 2023
Jul 3 2023
skan added inline comments to D154193: [X86]Remove TEST in AND32ri+TEST16rr in peephole-opt.
skan added a comment to D154193: [X86]Remove TEST in AND32ri+TEST16rr in peephole-opt.
I think you update the revision incorrectly...
Jun 27 2023
Jun 27 2023
LGTM
skan accepted D152989: Pre-commit test for D151696..
LGTM
skan added inline comments to D152989: Pre-commit test for D151696..
skan added inline comments to D152989: Pre-commit test for D151696..
Jun 19 2023
Jun 19 2023
skan added a comment to D152231: [CodeGen] Disable default copy ctor and copy assignment operator for class Array.
Jun 18 2023
Jun 18 2023
LGTM for the MC part.
Jun 16 2023
Jun 16 2023
Jun 15 2023
Jun 15 2023
skan added inline comments to D152785: [COFF] Support -gsplit-dwarf for COFF on Windows.
skan added inline comments to D152785: [COFF] Support -gsplit-dwarf for COFF on Windows.
Jun 8 2023
Jun 8 2023
LGTM
Jun 7 2023
Jun 7 2023
LGTM
Jun 6 2023
Jun 6 2023
LGTM
skan added a comment to D152229: [NFC][COFF] Refine access specifiers for WinCOFFObjectWriter.
What's the motivation of reordering MCObjectWriter methods?
Jun 5 2023
Jun 5 2023
skan added a comment to D152229: [NFC][COFF] Refine access specifiers for WinCOFFObjectWriter.
Add a summary about what's refined?
Jun 4 2023
Jun 4 2023
skan added inline comments to D151863: [x86][MC] Fix movdir64b addressing.
skan added inline comments to D151863: [x86][MC] Fix movdir64b addressing.
skan added inline comments to D151863: [x86][MC] Fix movdir64b addressing.
skan added a comment to D151863: [x86][MC] Fix movdir64b addressing.
Replace the url of the picture in the summary with the plain text?
LGTM
Jun 2 2023
Jun 2 2023
LGTM with minor suggestion
skan added a comment to D151793: [NFC][COFF] Use COFFSection.MCSection when writeSection.
Add a NFC or NFCI in the title?
Jun 1 2023
Jun 1 2023
LGTM, thanks!
May 31 2023
May 31 2023
skan added a comment to D151863: [x86][MC] Fix movdir64b addressing.
skan added a comment to D151863: [x86][MC] Fix movdir64b addressing.
Maybe you need to add a test case and explain why we check AH here?
May 30 2023
May 30 2023
skan accepted D151695: [MC] Disable default copy ctor and copy assignment operator for CodeViewContext.
LGTM
May 29 2023
May 29 2023
LGTM
skan added a comment to D151652: [ms-inline asm] Add error check for `getAsInteger`.
Add a test?
May 28 2023
May 28 2023
LGTM
May 26 2023
May 26 2023
skan committed rGa919a3a1e739: [CodeGen][NFC] Declare copy constructor & copy assignment as deleted for… (authored by skan).
[CodeGen][NFC] Declare copy constructor & copy assignment as deleted for…
skan updated the diff for D151538: [CodeGen][NFC] Declare copy constructor & copy assignment as deleted for ScheduleDAG.
Address review comments: Add comments
LGTM
skan added a comment to D150024: use ref to avoid copy in range for-loop.
Could you help illustrate why "they're big obj copys"?
May 20 2023
May 20 2023
skan committed rG287dd0142c08: [X86][MC] Simplify some code in X86AsmBackend.cpp, NFCI (authored by skan).
[X86][MC] Simplify some code in X86AsmBackend.cpp, NFCI
skan committed rG3f1e9468f68d: [X86][MC][bolt] Share code between encoding optimization and assembler… (authored by skan).
[X86][MC][bolt] Share code between encoding optimization and assembler…