In D62115#1547698, @kimgr wrote:

This looks good to me, thanks!

In D62115#1538631, @kimgr wrote:

I think the test needs a bit more work. It's essentially checking the same thing twice to exercise the Windows path separators.

It looks like there's already a test for -H in FrontEnd/print-header-includes.c. That also demonstrates the use of --check-prefix to handle target-specific stuff. Maybe you could fold this into there?

move test case to print-header-includes.c

change mask paramater' s name from __M to __U in order to be consistent with other intrinsics in the file

make macro more compact

avoid implicit type conversion for intrinsic parameter

uploaded a unrelated patch last time

avoid implicit type conversion for intrinsic parameter

When target feature avx512bf16 is enabled, avx512vl is not enabled implicity for some reasons by now. But _mm_cvtness_sbh, _mm256_cvtpbh_ps , _mm256_maskz_cvtpbh_ps , _mm256_mask_cvtpbh_ps need avx512vl feature. So I move their definition from avx512bf16intrin to avx512vlbf16intrin.h, and move corresponding test cases from avx512bf16-builtins.c to avx512vlbf16-builtins.c.

RegClassOrRegBank is of one of the two classes, but it can still be nullptr, e.g., before regbankselect.
This patch has been reverted in llvm trunk.

ping

make comments for _mm_cvtsbh_ss and _mm_cvtness_sbh better

rm clang-format fix in this patch

make test case consider Windows path separators

In D62115#1511407, @kimgr wrote:

Also, consider ././Inputs/empty.h.

add a test for including headfile outside current directory.

In D62115#1509536, @kimgr wrote:

Should you also consider Windows path separators here?

fix the typo ("Register")

remove ";" and format the code

add "const" to pointer type description.