Page MenuHomePhabricator

skan (Kan Shengchen)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 23 2019, 8:52 PM (16 w, 4 d)

Recent Activity

Jun 18 2019

skan added a comment to D62115: fix a issue that clang is incompatible with gcc with -H option..

This looks good to me, thanks!

Jun 18 2019, 12:01 AM · Restricted Project

Jun 17 2019

skan added a comment to D62115: fix a issue that clang is incompatible with gcc with -H option..

I think the test needs a bit more work. It's essentially checking the same thing twice to exercise the Windows path separators.

It looks like there's already a test for -H in FrontEnd/print-header-includes.c. That also demonstrates the use of --check-prefix to handle target-specific stuff. Maybe you could fold this into there?

Jun 17 2019, 1:27 AM · Restricted Project
skan updated the diff for D62115: fix a issue that clang is incompatible with gcc with -H option..

move test case to print-header-includes.c

Jun 17 2019, 1:24 AM · Restricted Project

Jun 10 2019

skan requested review of D62115: fix a issue that clang is incompatible with gcc with -H option..
Jun 10 2019, 7:39 PM · Restricted Project

Jun 9 2019

skan updated the diff for D62363: [X86] Enable intrinsics that convert float and bf16 data to each other.

change mask paramater' s name from __M to __U in order to be consistent with other intrinsics in the file

Jun 9 2019, 7:00 PM · Restricted Project, Restricted Project

Jun 7 2019

skan updated the diff for D62115: fix a issue that clang is incompatible with gcc with -H option..

make macro more compact

Jun 7 2019, 7:09 PM · Restricted Project

Jun 6 2019

skan updated the diff for D62363: [X86] Enable intrinsics that convert float and bf16 data to each other.

avoid implicit type conversion for intrinsic parameter

Jun 6 2019, 4:17 AM · Restricted Project, Restricted Project
skan updated the diff for D62835: [X86] -march=cooperlake (clang).

uploaded a unrelated patch last time

Jun 6 2019, 4:13 AM · Restricted Project, Restricted Project
skan updated the diff for D62835: [X86] -march=cooperlake (clang).

avoid implicit type conversion for intrinsic parameter

Jun 6 2019, 3:50 AM · Restricted Project, Restricted Project

Jun 5 2019

skan updated the diff for D62363: [X86] Enable intrinsics that convert float and bf16 data to each other.

When target feature avx512bf16 is enabled, avx512vl is not enabled implicity for some reasons by now. But _mm_cvtness_sbh, _mm256_cvtpbh_ps , _mm256_maskz_cvtpbh_ps , _mm256_mask_cvtpbh_ps need avx512vl feature. So I move their definition from avx512bf16intrin to avx512vlbf16intrin.h, and move corresponding test cases from avx512bf16-builtins.c to avx512vlbf16-builtins.c.

Jun 5 2019, 9:13 AM · Restricted Project, Restricted Project

Jun 3 2019

skan created D62836: [X86] -march=cooperlake (llvm).
Jun 3 2019, 7:06 PM · Restricted Project
skan retitled D62835: [X86] -march=cooperlake (clang) from support -march=cooperlake (clang part) to [X86] -march=cooperlake (clang).
Jun 3 2019, 7:00 PM · Restricted Project, Restricted Project
skan created D62835: [X86] -march=cooperlake (clang).
Jun 3 2019, 6:59 PM · Restricted Project, Restricted Project

May 30 2019

skan abandoned D62006: Add "llvm_unreachable" for function RegisterBankInfo::getRegBank.

RegClassOrRegBank is of one of the two classes, but it can still be nullptr, e.g., before regbankselect.
This patch has been reverted in llvm trunk.

May 30 2019, 5:56 PM · Restricted Project

May 28 2019

skan updated subscribers of D62006: Add "llvm_unreachable" for function RegisterBankInfo::getRegBank.
May 28 2019, 5:54 PM · Restricted Project
skan added a comment to D62115: fix a issue that clang is incompatible with gcc with -H option..

ping

May 28 2019, 12:30 AM · Restricted Project

May 27 2019

skan updated the diff for D62363: [X86] Enable intrinsics that convert float and bf16 data to each other.

make comments for _mm_cvtsbh_ss and _mm_cvtness_sbh better

May 27 2019, 9:02 PM · Restricted Project, Restricted Project
skan added inline comments to D62363: [X86] Enable intrinsics that convert float and bf16 data to each other.
May 27 2019, 7:25 PM · Restricted Project, Restricted Project
skan added inline comments to D62363: [X86] Enable intrinsics that convert float and bf16 data to each other.
May 27 2019, 6:11 PM · Restricted Project, Restricted Project
skan updated the diff for D62363: [X86] Enable intrinsics that convert float and bf16 data to each other.

rm clang-format fix in this patch

May 27 2019, 6:08 PM · Restricted Project, Restricted Project

May 23 2019

skan created D62363: [X86] Enable intrinsics that convert float and bf16 data to each other.
May 23 2019, 6:17 PM · Restricted Project, Restricted Project
skan updated the diff for D62115: fix a issue that clang is incompatible with gcc with -H option..

make test case consider Windows path separators

May 23 2019, 12:29 AM · Restricted Project

May 22 2019

skan added a comment to D62115: fix a issue that clang is incompatible with gcc with -H option..

Also, consider ././Inputs/empty.h.

May 22 2019, 4:35 AM · Restricted Project

May 21 2019

skan added inline comments to D62115: fix a issue that clang is incompatible with gcc with -H option..
May 21 2019, 8:33 PM · Restricted Project
skan updated the diff for D62115: fix a issue that clang is incompatible with gcc with -H option..

add a test for including headfile outside current directory.

May 21 2019, 8:29 PM · Restricted Project
skan added inline comments to D62115: fix a issue that clang is incompatible with gcc with -H option..
May 21 2019, 6:04 AM · Restricted Project
skan added a comment to D62115: fix a issue that clang is incompatible with gcc with -H option..

Should you also consider Windows path separators here?

May 21 2019, 3:23 AM · Restricted Project

May 20 2019

skan added inline comments to D62115: fix a issue that clang is incompatible with gcc with -H option..
May 20 2019, 6:23 PM · Restricted Project
skan added inline comments to D62006: Add "llvm_unreachable" for function RegisterBankInfo::getRegBank.
May 20 2019, 6:12 PM · Restricted Project
skan updated the diff for D62006: Add "llvm_unreachable" for function RegisterBankInfo::getRegBank.

fix the typo ("Register")

May 20 2019, 6:12 PM · Restricted Project
skan added inline comments to D62115: fix a issue that clang is incompatible with gcc with -H option..
May 20 2019, 5:59 PM · Restricted Project
skan updated the diff for D62115: fix a issue that clang is incompatible with gcc with -H option..

remove ";" and format the code

May 20 2019, 12:39 AM · Restricted Project

May 19 2019

skan updated the diff for D62006: Add "llvm_unreachable" for function RegisterBankInfo::getRegBank.

add "const" to pointer type description.

May 19 2019, 9:31 PM · Restricted Project
skan created D62115: fix a issue that clang is incompatible with gcc with -H option..
May 19 2019, 6:50 PM · Restricted Project

May 16 2019

skan created D62006: Add "llvm_unreachable" for function RegisterBankInfo::getRegBank.
May 16 2019, 6:03 AM · Restricted Project

May 8 2019

skan created D61715: fix a null pointer deref issue.
May 8 2019, 7:42 PM · Restricted Project