Page MenuHomePhabricator

FreddyYe (Freddy, Ye)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 29 2020, 6:48 PM (151 w, 4 d)

Recent Activity

Jan 16 2023

FreddyYe committed rG61fa12d0c78b: [NFC][X86] clang-format change for avx512vlbwintrin.h (authored by FreddyYe).
[NFC][X86] clang-format change for avx512vlbwintrin.h
Jan 16 2023, 6:44 PM · Restricted Project, Restricted Project
FreddyYe committed rGdb711f79ef57: [X86] Prefer fpext(splat(X)) to splat(fpext(x)). (authored by FreddyYe).
[X86] Prefer fpext(splat(X)) to splat(fpext(x)).
Jan 16 2023, 6:49 AM · Restricted Project, Restricted Project
FreddyYe closed D141657: [X86] Prefer fpext(splat(X)) to splat(fpext(x))..
Jan 16 2023, 6:48 AM · Restricted Project, Restricted Project

Jan 15 2023

FreddyYe updated the diff for D141657: [X86] Prefer fpext(splat(X)) to splat(fpext(x))..

Rebase FP16 tests.

Jan 15 2023, 6:37 PM · Restricted Project, Restricted Project
FreddyYe committed rG2d73295c4344: [X86] Add AVX512FP16 test coverage to splat(fpext) tests. (authored by FreddyYe).
[X86] Add AVX512FP16 test coverage to splat(fpext) tests.
Jan 15 2023, 6:19 PM · Restricted Project, Restricted Project
FreddyYe updated the summary of D141657: [X86] Prefer fpext(splat(X)) to splat(fpext(x))..
Jan 15 2023, 6:06 PM · Restricted Project, Restricted Project
FreddyYe updated the diff for D141657: [X86] Prefer fpext(splat(X)) to splat(fpext(x))..

Rebase new pre-commit tests.

Jan 15 2023, 5:59 PM · Restricted Project, Restricted Project

Jan 13 2023

FreddyYe updated the diff for D141657: [X86] Prefer fpext(splat(X)) to splat(fpext(x))..

Rebase pre-commit test.

Jan 13 2023, 5:16 AM · Restricted Project, Restricted Project
FreddyYe committed rG53296d818a0a: [X86][test] Add pre-commit test for D141657. (authored by FreddyYe).
[X86][test] Add pre-commit test for D141657.
Jan 13 2023, 5:10 AM · Restricted Project, Restricted Project
FreddyYe closed D141677: [X86][test] Add pre-commit test for D141657..
Jan 13 2023, 5:10 AM · Restricted Project, Restricted Project
FreddyYe updated the diff for D141657: [X86] Prefer fpext(splat(X)) to splat(fpext(x))..

Address comments. THX for review!

Jan 13 2023, 4:52 AM · Restricted Project, Restricted Project
FreddyYe added reviewers for D141677: [X86][test] Add pre-commit test for D141657.: pengfei, RKSimon, skan, LuoYuanke.
Jan 13 2023, 4:49 AM · Restricted Project, Restricted Project
FreddyYe requested review of D141677: [X86][test] Add pre-commit test for D141657..
Jan 13 2023, 4:48 AM · Restricted Project, Restricted Project
FreddyYe updated the diff for D141657: [X86] Prefer fpext(splat(X)) to splat(fpext(x))..

Address comments. THX for review!

Jan 13 2023, 4:36 AM · Restricted Project, Restricted Project

Jan 12 2023

FreddyYe added reviewers for D141657: [X86] Prefer fpext(splat(X)) to splat(fpext(x)).: pengfei, RKSimon, LuoYuanke, skan.
Jan 12 2023, 10:40 PM · Restricted Project, Restricted Project
FreddyYe added a comment to D141657: [X86] Prefer fpext(splat(X)) to splat(fpext(x))..

This patch is to fix regression below: https://gcc.godbolt.org/z/v3nnbKP1j

Jan 12 2023, 10:39 PM · Restricted Project, Restricted Project
FreddyYe requested review of D141657: [X86] Prefer fpext(splat(X)) to splat(fpext(x))..
Jan 12 2023, 10:39 PM · Restricted Project, Restricted Project

Jan 5 2023

FreddyYe committed rG27b8f54f5174: [X86] Support -march=emeraldrapids (authored by FreddyYe).
[X86] Support -march=emeraldrapids
Jan 5 2023, 4:28 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
FreddyYe closed D140950: [X86] Support -march=emeraldrapids.
Jan 5 2023, 4:27 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
FreddyYe committed rGf2891086f4b6: [X86] Modify model value of meteorlake. (authored by FreddyYe).
[X86] Modify model value of meteorlake.
Jan 5 2023, 4:09 AM · Restricted Project, Restricted Project, Restricted Project
FreddyYe closed D140943: [X86] Modify model value of meteorlake..
Jan 5 2023, 4:08 AM · Restricted Project, Restricted Project, Restricted Project
FreddyYe added a comment to D140950: [X86] Support -march=emeraldrapids.

ping...

Jan 5 2023, 2:18 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
FreddyYe added a comment to D140943: [X86] Modify model value of meteorlake..

ping...

Jan 5 2023, 2:18 AM · Restricted Project, Restricted Project, Restricted Project

Jan 3 2023

FreddyYe updated the diff for D140950: [X86] Support -march=emeraldrapids.

Address comments. Thanks for review!

Jan 3 2023, 10:21 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
FreddyYe added reviewers for D140950: [X86] Support -march=emeraldrapids: pengfei, RKSimon, LuoYuanke, skan.
Jan 3 2023, 10:02 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
FreddyYe requested review of D140950: [X86] Support -march=emeraldrapids.
Jan 3 2023, 9:40 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
FreddyYe added a reviewer for D140943: [X86] Modify model value of meteorlake.: pengfei.
Jan 3 2023, 6:59 PM · Restricted Project, Restricted Project, Restricted Project
FreddyYe requested review of D140943: [X86] Modify model value of meteorlake..
Jan 3 2023, 6:59 PM · Restricted Project, Restricted Project, Restricted Project

Dec 28 2022

FreddyYe committed rG9816c1912d56: [X86] Rename CMPCCXADD intrinsics. (authored by FreddyYe).
[X86] Rename CMPCCXADD intrinsics.
Dec 28 2022, 12:46 AM · Restricted Project, Restricted Project
FreddyYe closed D140281: [X86] Rename CMPCCXADD intrinsics..
Dec 28 2022, 12:46 AM · Restricted Project, Restricted Project

Dec 22 2022

FreddyYe committed rG68a888012b12: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics. (authored by FreddyYe).
[X86] Add reduce_*_ep[i|u]8/16 series intrinsics.
Dec 22 2022, 10:55 PM · Restricted Project, Restricted Project
FreddyYe closed D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics..
Dec 22 2022, 10:55 PM · Restricted Project, Restricted Project
FreddyYe added inline comments to D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics..
Dec 22 2022, 7:16 PM · Restricted Project, Restricted Project
FreddyYe updated the diff for D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics..

Address comments.

Dec 22 2022, 7:16 PM · Restricted Project, Restricted Project
FreddyYe updated the diff for D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics..

Address comments.

Dec 22 2022, 5:40 PM · Restricted Project, Restricted Project
FreddyYe updated the diff for D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics..

Address comments.

Dec 22 2022, 3:01 AM · Restricted Project, Restricted Project
FreddyYe added inline comments to D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics..
Dec 22 2022, 1:48 AM · Restricted Project, Restricted Project
FreddyYe updated the diff for D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics..

Address comments.

Dec 22 2022, 1:47 AM · Restricted Project, Restricted Project
FreddyYe added reviewers for D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.: pengfei, LuoYuanke, skan.
Dec 22 2022, 1:23 AM · Restricted Project, Restricted Project
FreddyYe updated the diff for D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics..

Add release note.

Dec 22 2022, 1:23 AM · Restricted Project, Restricted Project
FreddyYe requested review of D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics..
Dec 22 2022, 1:19 AM · Restricted Project, Restricted Project

Dec 19 2022

FreddyYe updated the summary of D140281: [X86] Rename CMPCCXADD intrinsics..
Dec 19 2022, 5:28 PM · Restricted Project, Restricted Project
FreddyYe added a comment to D140281: [X86] Rename CMPCCXADD intrinsics..

This patch says what it does, but not why it does what it does.

Dec 19 2022, 5:25 PM · Restricted Project, Restricted Project

Dec 18 2022

FreddyYe added reviewers for D140281: [X86] Rename CMPCCXADD intrinsics.: LuoYuanke, pengfei, skan.
Dec 18 2022, 9:10 PM · Restricted Project, Restricted Project
FreddyYe requested review of D140281: [X86] Rename CMPCCXADD intrinsics..
Dec 18 2022, 9:10 PM · Restricted Project, Restricted Project

Dec 5 2022

FreddyYe committed rGdef720726b73: [X86][clang] Lift _BitInt() supported max width. (authored by FreddyYe).
[X86][clang] Lift _BitInt() supported max width.
Dec 5 2022, 7:03 PM · Restricted Project, Restricted Project
FreddyYe closed D139170: [X86][clang] Lift _BitInt() supported max width..
Dec 5 2022, 7:02 PM · Restricted Project, Restricted Project
FreddyYe added a comment to D139170: [X86][clang] Lift _BitInt() supported max width..

THX for review. I'll land!

Dec 5 2022, 6:18 PM · Restricted Project, Restricted Project
FreddyYe updated the diff for D139170: [X86][clang] Lift _BitInt() supported max width..

Rebase and add release note.

Dec 5 2022, 6:18 PM · Restricted Project, Restricted Project
FreddyYe updated the diff for D138261: [SingleSource] Add Regression C tests for Large Fp Convert..

Several updates:

  1. Use literal suffix "q" instead of "L" for "__float128" and removed related FIXME.
  2. Fixed one unsigned test.
  3. Add Fixme for some wrong behavior under O2 due to FE optimizations.
Dec 5 2022, 5:57 PM · Restricted Project

Dec 2 2022

FreddyYe added a comment to D139170: [X86][clang] Lift _BitInt() supported max width..

Do other targets not support > 128 bit integers, or is this PR only the first conservative step of lifting the limit?

I temporary only enabled > 128 bit FP conversion for X86 in https://reviews.llvm.org/D137241, since I highly relied on end-to-end tests to implement that pass and I don't have other targets' environment to verify. So same to this patch, I only lift the limit for X86. Hope other targets will follow us to enable for themselves. WDYT?

A right, I was confused because I saw llvm/test/CodeGen/AArch64/O0-pipeline.ll running the new pass on AArch64, but actually it doesn't do anything unless it's enabled in llvm/lib/Target/*/*ISelLowering.cpp. Got it, thanks!

Dec 2 2022, 12:34 AM · Restricted Project, Restricted Project
FreddyYe added a comment to D139170: [X86][clang] Lift _BitInt() supported max width..

Do other targets not support > 128 bit integers, or is this PR only the first conservative step of lifting the limit?

Dec 2 2022, 12:20 AM · Restricted Project, Restricted Project

Dec 1 2022

FreddyYe added reviewers for D139170: [X86][clang] Lift _BitInt() supported max width.: aaron.ballman, mgehre-amd, pengfei, LuoYuanke.
Dec 1 2022, 10:10 PM · Restricted Project, Restricted Project
FreddyYe added a comment to D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.

I think this was the last reason for restricting _BitInt to <= 128 by default in clang. Are you planning to create a PR to lift that restriction now?

Yes, I agree. The patch of tests also relies on lifting first. But I'm not sure if https://github.com/llvm/llvm-project/blob/450de8008bb0ccb5dfc9dd69b6f5b434158772bd/clang/include/clang/Basic/TargetInfo.h#L637 is the only place needs to change. @aaron.ballman WDYT?

Do *all* targets support > 128 now, or just x86 targets? If all targets support > 128, then that's the place to update (and we can consider starting to rip some of the target-specific machinery and command line option out). But if it's just x86, then we should override this function in the correct derived TargetInfo class.

Dec 1 2022, 10:10 PM · Restricted Project, Restricted Project
FreddyYe requested review of D139170: [X86][clang] Lift _BitInt() supported max width..
Dec 1 2022, 10:07 PM · Restricted Project, Restricted Project
FreddyYe added a comment to D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.

I think this was the last reason for restricting _BitInt to <= 128 by default in clang. Are you planning to create a PR to lift that restriction now?

Dec 1 2022, 5:06 AM · Restricted Project, Restricted Project

Nov 30 2022

FreddyYe added a comment to D138791: [AArch64][SME]: Generate streaming-compatible code for ld2-alloca..

Failed Tests (1):

LLVM :: CodeGen/AArch64/sve-streaming-mode-fixed-length-ld2-alloca.ll

Testing Time: 345.12s

Skipped          :    38
Unsupported      :  1357
Passed           : 88906
Expectedly Failed:   195
Failed           :     1
Nov 30 2022, 11:23 PM · Restricted Project, Restricted Project
FreddyYe committed rG89f36dd8f32f: [X86] Add ExpandLargeFpConvert Pass and enable for X86 (authored by FreddyYe).
[X86] Add ExpandLargeFpConvert Pass and enable for X86
Nov 30 2022, 9:48 PM · Restricted Project, Restricted Project
FreddyYe closed D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.
Nov 30 2022, 9:48 PM · Restricted Project, Restricted Project
FreddyYe updated the summary of D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.
Nov 30 2022, 9:33 PM · Restricted Project, Restricted Project
FreddyYe updated the summary of D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.
Nov 30 2022, 9:01 PM · Restricted Project, Restricted Project
FreddyYe added inline comments to D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.
Nov 30 2022, 5:47 PM · Restricted Project, Restricted Project
FreddyYe updated the diff for D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.

Address comments. THX for review!

Nov 30 2022, 5:46 PM · Restricted Project, Restricted Project

Nov 29 2022

FreddyYe added inline comments to D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.
Nov 29 2022, 10:57 PM · Restricted Project, Restricted Project
FreddyYe updated the diff for D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.

Address comments. THX for review!

Nov 29 2022, 10:53 PM · Restricted Project, Restricted Project
FreddyYe committed rG51679dc1c9d5: [X86] include cmpccxaddintrin.h from immintrin.h to x86gprintrin.h (authored by FreddyYe).
[X86] include cmpccxaddintrin.h from immintrin.h to x86gprintrin.h
Nov 29 2022, 6:41 PM · Restricted Project, Restricted Project
FreddyYe closed D138900: [X86] include cmpccxaddintrin.h from immintrin.h to x86gprintrin.h.
Nov 29 2022, 6:41 PM · Restricted Project, Restricted Project
FreddyYe updated the diff for D138900: [X86] include cmpccxaddintrin.h from immintrin.h to x86gprintrin.h.

minor fix.

Nov 29 2022, 6:39 PM · Restricted Project, Restricted Project
FreddyYe added inline comments to D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.
Nov 29 2022, 4:20 AM · Restricted Project, Restricted Project
FreddyYe updated the diff for D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.

Address comments. THX for review!

Nov 29 2022, 4:19 AM · Restricted Project, Restricted Project

Nov 28 2022

FreddyYe added reviewers for D138900: [X86] include cmpccxaddintrin.h from immintrin.h to x86gprintrin.h: LuoYuanke, pengfei.
Nov 28 2022, 11:14 PM · Restricted Project, Restricted Project
FreddyYe requested review of D138900: [X86] include cmpccxaddintrin.h from immintrin.h to x86gprintrin.h.
Nov 28 2022, 11:14 PM · Restricted Project, Restricted Project
FreddyYe committed rG67e253c35437: [NFC][X86] Correct _axor_i32 's pseudo code. (authored by FreddyYe).
[NFC][X86] Correct _axor_i32 's pseudo code.
Nov 28 2022, 11:09 PM · Restricted Project, Restricted Project

Nov 21 2022

FreddyYe updated the summary of D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.
Nov 21 2022, 11:50 PM · Restricted Project, Restricted Project
FreddyYe retitled D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86 from [WIP][X86] Add ExpandLargeFpConvert Pass and enable for X86 to [X86] Add ExpandLargeFpConvert Pass and enable for X86.
Nov 21 2022, 11:49 PM · Restricted Project, Restricted Project
FreddyYe updated the diff for D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.

Support unsigned expandIToFP() and add IR comments as refer.

Nov 21 2022, 11:41 PM · Restricted Project, Restricted Project
FreddyYe updated the diff for D138261: [SingleSource] Add Regression C tests for Large Fp Convert..

Some updates

Nov 21 2022, 11:12 PM · Restricted Project

Nov 18 2022

FreddyYe updated the summary of D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.
Nov 18 2022, 2:01 AM · Restricted Project, Restricted Project
FreddyYe updated the diff for D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.

rebase

Nov 18 2022, 12:08 AM · Restricted Project, Restricted Project
FreddyYe updated the summary of D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.
Nov 18 2022, 12:00 AM · Restricted Project, Restricted Project

Nov 17 2022

FreddyYe updated the summary of D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.
Nov 17 2022, 11:59 PM · Restricted Project, Restricted Project
FreddyYe updated the summary of D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.
Nov 17 2022, 11:57 PM · Restricted Project, Restricted Project
FreddyYe retitled D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86 from [WIP] Add ExpandLargeFpConvert Pass to [WIP][X86] Add ExpandLargeFpConvert Pass and enable for X86.
Nov 17 2022, 11:56 PM · Restricted Project, Restricted Project
FreddyYe updated the summary of D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.
Nov 17 2022, 11:44 PM · Restricted Project, Restricted Project
FreddyYe updated the diff for D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.

Complete the imple and split tests into another Phab.

Nov 17 2022, 11:44 PM · Restricted Project, Restricted Project
FreddyYe requested review of D138261: [SingleSource] Add Regression C tests for Large Fp Convert..
Nov 17 2022, 10:41 PM · Restricted Project

Nov 9 2022

FreddyYe added inline comments to D137695: [X86] Add missing Zen3 model subtypes.
Nov 9 2022, 5:54 PM · Restricted Project, Restricted Project, Restricted Project
FreddyYe added inline comments to D137695: [X86] Add missing Zen3 model subtypes.
Nov 9 2022, 1:27 AM · Restricted Project, Restricted Project, Restricted Project
FreddyYe committed rG84a18a260e46: [X86] Support -march=sierraforest, grandridge, graniterapids. (authored by FreddyYe).
[X86] Support -march=sierraforest, grandridge, graniterapids.
Nov 9 2022, 12:56 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
FreddyYe closed D137153: [X86] Support -march=sierraforest, grandridge, graniterapids..
Nov 9 2022, 12:56 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
FreddyYe updated the diff for D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86.

WIP update.

Nov 9 2022, 12:43 AM · Restricted Project, Restricted Project

Nov 8 2022

FreddyYe added inline comments to D137153: [X86] Support -march=sierraforest, grandridge, graniterapids..
Nov 8 2022, 10:15 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
FreddyYe updated the diff for D137153: [X86] Support -march=sierraforest, grandridge, graniterapids..

Address comments. THX fore review!

Nov 8 2022, 10:14 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
FreddyYe updated the diff for D137153: [X86] Support -march=sierraforest, grandridge, graniterapids..

Address comments. THX for review!

Nov 8 2022, 8:04 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
FreddyYe updated the diff for D137153: [X86] Support -march=sierraforest, grandridge, graniterapids..

Added ZHAOXIN_FAM7H.

Nov 8 2022, 6:42 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
FreddyYe added a comment to D137153: [X86] Support -march=sierraforest, grandridge, graniterapids..

gcc has landed related patch: Sierraforest, Graniterapids and Grandrdige. We can follow their CPU list order now.

Nov 8 2022, 6:38 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
FreddyYe added inline comments to D137153: [X86] Support -march=sierraforest, grandridge, graniterapids..
Nov 8 2022, 6:36 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
FreddyYe retitled D137153: [X86] Support -march=sierraforest, grandridge, graniterapids. from [WIP][X86] Support -march=sierraforest, grandridge, graniterapids. to [X86] Support -march=sierraforest, grandridge, graniterapids..
Nov 8 2022, 6:36 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
FreddyYe updated the diff for D137153: [X86] Support -march=sierraforest, grandridge, graniterapids..

Rebase and add missing supports in cpu_model.c

Nov 8 2022, 6:35 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
FreddyYe updated the diff for D137153: [X86] Support -march=sierraforest, grandridge, graniterapids..

Address comments.

Nov 8 2022, 5:58 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project