Page MenuHomePhabricator

FreddyYe (Freddy, Ye)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 29 2020, 6:48 PM (59 w, 5 d)

Recent Activity

Apr 12 2021

FreddyYe committed rGb28ec3fd18ae: [compiler-rt][X86] fix build fail after "[X86] Support -march=rocketlake" (authored by FreddyYe).
[compiler-rt][X86] fix build fail after "[X86] Support -march=rocketlake"
Apr 12 2021, 11:34 PM
FreddyYe committed rG3fc1fe8db830: [X86] Support -march=rocketlake (authored by FreddyYe).
[X86] Support -march=rocketlake
Apr 12 2021, 6:48 PM
FreddyYe closed D100085: [X86] Support -march=rocketlake.
Apr 12 2021, 6:48 PM · Restricted Project, Restricted Project, Restricted Project

Apr 11 2021

FreddyYe added a comment to D100085: [X86] Support -march=rocketlake.

Hi @MaskRay, @craig.topper, @skan, reviewers, I've addressed your comments. Any more concerns?

Apr 11 2021, 11:58 PM · Restricted Project, Restricted Project, Restricted Project
FreddyYe updated the diff for D100085: [X86] Support -march=rocketlake.

rebase

Apr 11 2021, 9:15 PM · Restricted Project, Restricted Project, Restricted Project
FreddyYe committed rG5cb47be41045: [X86] Remove FeatureCLWB from FeaturesICLClient (authored by FreddyYe).
[X86] Remove FeatureCLWB from FeaturesICLClient
Apr 11 2021, 9:09 PM
FreddyYe closed D100279: [X86] Remove FeatureCLWB from FeaturesICLClient.
Apr 11 2021, 9:09 PM · Restricted Project, Restricted Project
FreddyYe updated the diff for D100279: [X86] Remove FeatureCLWB from FeaturesICLClient.

update lit test

Apr 11 2021, 8:25 PM · Restricted Project, Restricted Project
FreddyYe added reviewers for D100279: [X86] Remove FeatureCLWB from FeaturesICLClient: craig.topper, LuoYuanke, pengfei, xiangzhangllvm.
Apr 11 2021, 7:43 PM · Restricted Project, Restricted Project
FreddyYe requested review of D100279: [X86] Remove FeatureCLWB from FeaturesICLClient.
Apr 11 2021, 7:42 PM · Restricted Project, Restricted Project
FreddyYe added a comment to D100085: [X86] Support -march=rocketlake.

Thanks. I also found this https://github.com/gcc-mirror/gcc/commit/c422e5f81f42a0fc197f0715f4fcd81f1be90bff can you create a new patch to do the same for llvm/clang and rebase this patch on top of it.

Apr 11 2021, 7:27 PM · Restricted Project, Restricted Project, Restricted Project
FreddyYe added inline comments to D100085: [X86] Support -march=rocketlake.
Apr 11 2021, 7:14 PM · Restricted Project, Restricted Project, Restricted Project
FreddyYe added inline comments to D100085: [X86] Support -march=rocketlake.
Apr 11 2021, 6:50 PM · Restricted Project, Restricted Project, Restricted Project
FreddyYe added inline comments to D100085: [X86] Support -march=rocketlake.
Apr 11 2021, 2:49 AM · Restricted Project, Restricted Project, Restricted Project

Apr 8 2021

FreddyYe added a comment to D100085: [X86] Support -march=rocketlake.

Hi @craig.topper and @skan , THX for review! I tested that deleting sgx indeed leads to not generating "+sgx" in 'target-features', didn't know before:)

Apr 8 2021, 8:23 PM · Restricted Project, Restricted Project, Restricted Project
FreddyYe updated the diff for D100085: [X86] Support -march=rocketlake.

revert clang-format and revert deleting FeatureSGX def.

Apr 8 2021, 8:19 PM · Restricted Project, Restricted Project, Restricted Project
FreddyYe updated the diff for D100085: [X86] Support -march=rocketlake.

cancel the clang-format in constexpr ProcInfo Processors[] = {}

Apr 8 2021, 8:01 PM · Restricted Project, Restricted Project, Restricted Project
FreddyYe updated the diff for D100085: [X86] Support -march=rocketlake.

delete FeatureSGX in the backend since there are no IR intrinsics for SGX.

Apr 8 2021, 7:24 PM · Restricted Project, Restricted Project, Restricted Project
FreddyYe added inline comments to D100085: [X86] Support -march=rocketlake.
Apr 8 2021, 7:05 PM · Restricted Project, Restricted Project, Restricted Project
FreddyYe added inline comments to D100085: [X86] Support -march=rocketlake.
Apr 8 2021, 6:58 PM · Restricted Project, Restricted Project, Restricted Project
FreddyYe added a comment to D100085: [X86] Support -march=rocketlake.

Hi @MaskRay , I tried to refactor the test file by assembling the common CHECKs. But I found it will lead to too many check-prefixes ine one RUN line. For example,

Apr 8 2021, 8:45 AM · Restricted Project, Restricted Project, Restricted Project
FreddyYe updated the diff for D100085: [X86] Support -march=rocketlake.

update lit test and clang-format

Apr 8 2021, 8:44 AM · Restricted Project, Restricted Project, Restricted Project
FreddyYe added a comment to D100085: [X86] Support -march=rocketlake.

Hi @MaskRay, I tried to refactor, but met some difficulties. Since these defines are dictionary ordered, a new #define may insert into a common CHECK. So it is difficult to let different RUN share common CHECKs.

Check prefixes of the same kind do not need to be contiguous.

// A:
// B:
// A:
Apr 8 2021, 12:17 AM · Restricted Project, Restricted Project, Restricted Project

Apr 7 2021

FreddyYe added a comment to D100085: [X86] Support -march=rocketlake.

Hi @MaskRay, I tried to refactor, but met some difficulties. Since these defines are dictionary ordered, a new #define may insert into a common CHECK. So it is difficult to let different RUN share common CHECKs.

Apr 7 2021, 11:08 PM · Restricted Project, Restricted Project, Restricted Project
FreddyYe updated the diff for D100085: [X86] Support -march=rocketlake.

Updating according to comments. Test refactoring not done.

Apr 7 2021, 11:00 PM · Restricted Project, Restricted Project, Restricted Project
FreddyYe added a comment to D100085: [X86] Support -march=rocketlake.

THX for review!

Apr 7 2021, 10:12 PM · Restricted Project, Restricted Project, Restricted Project
FreddyYe added reviewers for D100085: [X86] Support -march=rocketlake: LuoYuanke, pengfei, xiangzhangllvm, skan, LiuChen3, yubing, craig.topper.
Apr 7 2021, 8:31 PM · Restricted Project, Restricted Project, Restricted Project
FreddyYe requested review of D100085: [X86] Support -march=rocketlake.
Apr 7 2021, 8:28 PM · Restricted Project, Restricted Project, Restricted Project

Mar 7 2021

FreddyYe committed rG5f9489b75405: [X86] Refine "Support -march=alderlake" (authored by FreddyYe).
[X86] Refine "Support -march=alderlake"
Mar 7 2021, 9:28 PM
FreddyYe closed D97832: [X86] Refine "Support -march=alderlake".
Mar 7 2021, 9:28 PM · Restricted Project, Restricted Project
FreddyYe added a comment to D97832: [X86] Refine "Support -march=alderlake".

No more comments?

Mar 7 2021, 5:11 PM · Restricted Project, Restricted Project

Mar 3 2021

FreddyYe added a comment to D97832: [X86] Refine "Support -march=alderlake".

THX for review!

Mar 3 2021, 12:20 AM · Restricted Project, Restricted Project
FreddyYe updated the diff for D97832: [X86] Refine "Support -march=alderlake".

delete extra spaces. THX for review!

Mar 3 2021, 12:20 AM · Restricted Project, Restricted Project

Mar 2 2021

FreddyYe updated the summary of D97832: [X86] Refine "Support -march=alderlake".
Mar 2 2021, 10:56 PM · Restricted Project, Restricted Project
FreddyYe requested review of D97832: [X86] Refine "Support -march=alderlake".
Mar 2 2021, 10:36 PM · Restricted Project, Restricted Project

Feb 3 2021

FreddyYe added a comment to D93983: RegAllocFast: Do not free later early-clobbered registers..

Patch has solved this regression bug in Front End.

Feb 3 2021, 10:48 PM · Restricted Project
FreddyYe abandoned D93983: RegAllocFast: Do not free later early-clobbered registers..

Patch has solved this regression bug in Front End.

Feb 3 2021, 10:47 PM · Restricted Project

Jan 27 2021

FreddyYe committed rG1edb76cc91e7: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM (authored by FreddyYe).
[X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM
Jan 27 2021, 6:55 AM
FreddyYe closed D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM.
Jan 27 2021, 6:54 AM · Restricted Project

Jan 26 2021

FreddyYe updated the diff for D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM.

refine clang-format

Jan 26 2021, 6:26 AM · Restricted Project
FreddyYe updated the diff for D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM.

If Clobber is edx only, don't change "={eax}" to "=&{eax}".

Jan 26 2021, 6:23 AM · Restricted Project
FreddyYe added inline comments to D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM.
Jan 26 2021, 3:29 AM · Restricted Project
FreddyYe committed rGb3b0acdc6fb5: [NFC] Refine some uninitialized used variables. (authored by FreddyYe).
[NFC] Refine some uninitialized used variables.
Jan 26 2021, 12:52 AM
FreddyYe closed D95421: [NFC] Refine some uninitialized used variables..
Jan 26 2021, 12:52 AM · Restricted Project, Restricted Project

Jan 25 2021

FreddyYe added a comment to D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM.

Ping?

Jan 25 2021, 11:36 PM · Restricted Project
FreddyYe updated the diff for D95421: [NFC] Refine some uninitialized used variables..

refine according to Lint

Jan 25 2021, 11:09 PM · Restricted Project, Restricted Project
FreddyYe added reviewers for D95421: [NFC] Refine some uninitialized used variables.: pengfei, LuoYuanke.
Jan 25 2021, 10:24 PM · Restricted Project, Restricted Project
FreddyYe requested review of D95421: [NFC] Refine some uninitialized used variables..
Jan 25 2021, 10:23 PM · Restricted Project, Restricted Project

Jan 21 2021

FreddyYe updated the diff for D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM.

Fix Lint: Pre-merge checks

Jan 21 2021, 12:43 AM · Restricted Project

Jan 20 2021

FreddyYe updated the diff for D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM.

consider Clobber == "edx"

Jan 20 2021, 11:56 PM · Restricted Project

Jan 12 2021

FreddyYe added inline comments to D93983: RegAllocFast: Do not free later early-clobbered registers..
Jan 12 2021, 11:13 PM · Restricted Project
FreddyYe updated the diff for D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM.

consider "=A" into the patch

Jan 12 2021, 10:37 PM · Restricted Project
FreddyYe added a comment to D93983: RegAllocFast: Do not free later early-clobbered registers..

I uploaded another patch in front-end D94466. It also can fix this regression bug. Both solutions are reasonable to me, since for now clang is weak to deal with MS inline asm.

Jan 12 2021, 7:44 AM · Restricted Project
FreddyYe added a comment to D93983: RegAllocFast: Do not free later early-clobbered registers..

THX for review!

Jan 12 2021, 7:39 AM · Restricted Project
FreddyYe updated the diff for D93983: RegAllocFast: Do not free later early-clobbered registers..

simplify the MIR test

Jan 12 2021, 7:35 AM · Restricted Project

Jan 11 2021

FreddyYe added inline comments to D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM.
Jan 11 2021, 11:27 PM · Restricted Project
FreddyYe updated the summary of D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM.
Jan 11 2021, 9:25 PM · Restricted Project
FreddyYe requested review of D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM.
Jan 11 2021, 9:10 PM · Restricted Project

Jan 5 2021

FreddyYe added inline comments to D93983: RegAllocFast: Do not free later early-clobbered registers..
Jan 5 2021, 7:07 PM · Restricted Project
FreddyYe updated the diff for D93983: RegAllocFast: Do not free later early-clobbered registers..

Add MIR test

Jan 5 2021, 6:30 AM · Restricted Project

Jan 3 2021

FreddyYe added inline comments to D93983: RegAllocFast: Do not free later early-clobbered registers..
Jan 3 2021, 7:24 PM · Restricted Project
FreddyYe added inline comments to D93983: RegAllocFast: Do not free later early-clobbered registers..
Jan 3 2021, 6:48 PM · Restricted Project
FreddyYe added a comment to D93983: RegAllocFast: Do not free later early-clobbered registers..

This patch is to fix a regression bug (https://gcc.godbolt.org/z/GG44f6) on recent rewrite on RegAllocFast.cpp. The situation that implicit-def $eax and implicit-def early-clobber $eax both occur in MI is rare. But since old implement can handle it, so I add a some condition to check such MI.

Jan 3 2021, 2:10 AM · Restricted Project
FreddyYe added reviewers for D93983: RegAllocFast: Do not free later early-clobbered registers.: arsenm, LuoYuanke, pengfei.
Jan 3 2021, 2:00 AM · Restricted Project
FreddyYe requested review of D93983: RegAllocFast: Do not free later early-clobbered registers..
Jan 3 2021, 1:56 AM · Restricted Project

Nov 6 2020

FreddyYe committed rG5e312e004197: [X86] use macros to split GFNI intrinsics into different kinds (authored by FreddyYe).
[X86] use macros to split GFNI intrinsics into different kinds
Nov 6 2020, 12:17 AM
FreddyYe closed D90822: [X86] use macros to split GFNI intrinsics into different kinds.
Nov 6 2020, 12:17 AM · Restricted Project

Nov 5 2020

FreddyYe updated the diff for D90822: [X86] use macros to split GFNI intrinsics into different kinds.

Refine

Nov 5 2020, 4:56 AM · Restricted Project
FreddyYe added inline comments to D90822: [X86] use macros to split GFNI intrinsics into different kinds.
Nov 5 2020, 4:31 AM · Restricted Project
FreddyYe updated the diff for D90822: [X86] use macros to split GFNI intrinsics into different kinds.

Reorganize intrinsic orders to avoid using nested macros.

Nov 5 2020, 3:38 AM · Restricted Project

Nov 4 2020

FreddyYe updated the diff for D90822: [X86] use macros to split GFNI intrinsics into different kinds.

Use header file macros instead.

Nov 4 2020, 11:54 PM · Restricted Project
FreddyYe added a comment to D90822: [X86] use macros to split GFNI intrinsics into different kinds.

Craig's method sounds good.
@FreddyYe , Why we check AVX512BW instead of AVX512F. I saw SDM says it depends on AVX512F.

I was referring to the old implement and test case. Seems like a error introduced before.

Nov 4 2020, 11:40 PM · Restricted Project
FreddyYe added a comment to D90822: [X86] use macros to split GFNI intrinsics into different kinds.

The fails are all unknown type errors on Windows, since those typedefs are declared in other header files.
The error message goes like:

Nov 4 2020, 10:10 PM · Restricted Project
FreddyYe added reviewers for D90822: [X86] use macros to split GFNI intrinsics into different kinds: pengfei, LuoYuanke, craig.topper, RKSimon.
Nov 4 2020, 9:50 PM · Restricted Project
FreddyYe requested review of D90822: [X86] use macros to split GFNI intrinsics into different kinds.
Nov 4 2020, 9:48 PM · Restricted Project

Sep 23 2020

FreddyYe committed rGbc7f6c6dd825: [X86] Add TDX instructions. (authored by FreddyYe).
[X86] Add TDX instructions.
Sep 23 2020, 6:36 PM
FreddyYe closed D88006: [X86] Add TDX instructions..
Sep 23 2020, 6:36 PM · Restricted Project
FreddyYe added a comment to D88006: [X86] Add TDX instructions..

ping?

Sep 23 2020, 1:43 AM · Restricted Project

Sep 21 2020

FreddyYe added reviewers for D88006: [X86] Add TDX instructions.: craig.topper, LuoYuanke, pengfei.
Sep 21 2020, 1:53 AM · Restricted Project
FreddyYe requested review of D88006: [X86] Add TDX instructions..
Sep 21 2020, 1:52 AM · Restricted Project

Aug 24 2020

FreddyYe committed rGe02d081f2b60: [X86] Support -march=sapphirerapids (authored by FreddyYe).
[X86] Support -march=sapphirerapids
Aug 24 2020, 11:22 PM
FreddyYe closed D86503: [X86] Support -march=sapphirerapids.
Aug 24 2020, 11:22 PM · Restricted Project, Restricted Project, Restricted Project
FreddyYe added reviewers for D86503: [X86] Support -march=sapphirerapids: RKSimon, xiangzhangllvm.
Aug 24 2020, 6:59 PM · Restricted Project, Restricted Project, Restricted Project
FreddyYe requested review of D86503: [X86] Support -march=sapphirerapids.
Aug 24 2020, 6:58 PM · Restricted Project, Restricted Project, Restricted Project

May 7 2020

FreddyYe closed D79158: [X86] Bugfix on check function of _mm_mmask_i64gather_epi32 and _mm_mmask_i64gather_ps for rL349334.

Committed in https://github.com/llvm/llvm-test-suite/commit/33904171b17a6ecebb8822f1179fec559a7be9a1

May 7 2020, 8:36 PM

May 5 2020

FreddyYe added inline comments to D79158: [X86] Bugfix on check function of _mm_mmask_i64gather_epi32 and _mm_mmask_i64gather_ps for rL349334.
May 5 2020, 11:57 PM

Apr 30 2020

FreddyYe created D79158: [X86] Bugfix on check function of _mm_mmask_i64gather_epi32 and _mm_mmask_i64gather_ps for rL349334.
Apr 30 2020, 2:06 AM