Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-ceil-vp.ll | ||
---|---|---|
14 | This is using the wrong AVL and the mask has been ignored. |
llvm/docs/LangRef.rst | ||
---|---|---|
21230 | "ceil value" -> ceiling | |
21244 | "ceil value" -> ceiling | |
llvm/lib/Target/RISCV/RISCVISelLowering.cpp | ||
329 | VP_CEIL is only valid for vectors. MVT::f16 is a scalar. | |
661 | Isn't this already done by line 701 after updating FloatingPointVPOps? | |
906 | Already done by line 919? | |
1980 | Swap the if and else so IsVP doesn't need to be inverted | |
1981 | Use std::tie(Mask, VL) = getDefaultVLOps(VT, ContainerVT, DL, DAG, Subtarget) |
llvm/include/llvm/IR/VPIntrinsics.def | ||
---|---|---|
248 | This should be VP_FCEIL to match the naming of ISD::FCEIL. |
Missing test for scalable vectors.
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vp-ceil.ll | ||
---|---|---|
1 ↗ | (On Diff #462954) | This does not follow the established naming like fixed-vectors-vfadd-vp.ll |
Forgive me if I've missed something but you're adding support for widening and splitting in the legalizer without adding tests for that behaviour.
llvm/docs/LangRef.rst | ||
---|---|---|
21244 | Remove the word "value". I believe you copied "absolute value" and only changed the word "absolute". "absolute value" is the name of an operation "ceiling value" is not. |
There's a <vscale x 7 x double> <vscale x 16 x double>, <15 x double> and <32 x double> test. Does that cover it?
Yes, thanks. To my shame I didn't read through the whole tests before making that comment.
Received build failure message when generating llvm-sphinx-docs, investigating into this. Patch reverted for now.
"ceil value" -> ceiling