The patch modeled vp.fabs patch D132793.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
LGTM, but I'm still a bit unclear on this code, so please wait until someone else (e.g @craig.topper) has a chance to take a look.
llvm/docs/LangRef.rst | ||
---|---|---|
19221 | Can you be more explicit here about the result being undefined, not the behavior? i.e. that masked off lanes won't fault, etc.. |
llvm/docs/LangRef.rst | ||
---|---|---|
19219 | This does not perform "floating-point absolute value": | |
19221 | I would prefer that be done globally to all of the descriptions in a separate patch since this currently consistent with other operations. It does need "The operation is performed in the default floating-point environment." to match other arithmetic instructions though. |
This does not perform "floating-point absolute value":