Page MenuHomePhabricator

[VP][RISCV] Add vp.sqrt intrinsic and RISC-V support.
ClosedPublic

Authored by fakepaper56 on Sep 12 2022, 6:01 AM.

Diff Detail

Event Timeline

fakepaper56 created this revision.Sep 12 2022, 6:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2022, 6:01 AM
fakepaper56 requested review of this revision.Sep 12 2022, 6:01 AM

LGTM, but I'm still a bit unclear on this code, so please wait until someone else (e.g @craig.topper) has a chance to take a look.

llvm/docs/LangRef.rst
19228

Can you be more explicit here about the result being undefined, not the behavior? i.e. that masked off lanes won't fault, etc..

craig.topper added inline comments.Sep 12 2022, 12:11 PM
llvm/docs/LangRef.rst
19226

This does not perform "floating-point absolute value":

19228

I would prefer that be done globally to all of the descriptions in a separate patch since this currently consistent with other operations.

It does need "The operation is performed in the default floating-point environment." to match other arithmetic instructions though.

Fix typo.

llvm/docs/LangRef.rst
19226

Done. Thank you find the typo.

craig.topper retitled this revision from [VP][RISCV] Add vp.fsqrt intrinsic and RISC-V support. to [VP][RISCV] Add vp.sqrt intrinsic and RISC-V support..Sep 13 2022, 9:04 AM
craig.topper added inline comments.Sep 13 2022, 9:06 AM
llvm/docs/LangRef.rst
19226

Drop the word "value" here.

19228

Need to add "The operation is performed in the default floating-point environment." to match other arithmetic instructions though."

Fix typo and add more discription to address Craig's comment.

fakepaper56 marked 2 inline comments as done.Sep 13 2022, 7:36 PM
fakepaper56 added inline comments.
llvm/docs/LangRef.rst
19226

Done.

19228

Done.

This revision is now accepted and ready to land.Sep 22 2022, 5:04 PM
This revision was landed with ongoing or failed builds.Sep 25 2022, 7:47 PM
This revision was automatically updated to reflect the committed changes.
fakepaper56 marked 2 inline comments as done.