This is an archive of the discontinued LLVM Phabricator instance.

[VP][RISCV] Add vp.fabs intrinsic and RISC-V support.
ClosedPublic

Authored by craig.topper on Aug 27 2022, 10:21 AM.

Details

Summary

Mostly just modeled after vp.fneg except there is a
"functional instruction" for fneg while fabs is always an
intrinsic.

Diff Detail

Event Timeline

craig.topper created this revision.Aug 27 2022, 10:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 27 2022, 10:21 AM
craig.topper requested review of this revision.Aug 27 2022, 10:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 27 2022, 10:21 AM
fakepaper56 accepted this revision.Aug 28 2022, 11:45 PM
This revision is now accepted and ready to land.Aug 28 2022, 11:45 PM

Do we need a new test in expand-vp.ll? It seems that test has been forgotten about somewhat. There's no fneg in there. Maybe the expansion for that hasn't been implemented? Hard to keep track.

This revision was landed with ongoing or failed builds.Aug 29 2022, 9:38 AM
This revision was automatically updated to reflect the committed changes.

Do we need a new test in expand-vp.ll? It seems that test has been forgotten about somewhat. There's no fneg in there. Maybe the expansion for that hasn't been implemented? Hard to keep track.

Doesn't look like fneg has been implemented in the the expand pass. I don't see any code for unary operations.