Page MenuHomePhabricator

Meta directive runtime support
Needs ReviewPublic

Authored by abidmalikwaterloo on Mar 22 2022, 12:48 PM.

Details

Reviewers
jdoerfert
Summary

The patch extends the current implementation
for runtime support. The current patch build AST
of the when clauses in sorted order using the
context selector score

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2022, 12:48 PM
abidmalikwaterloo requested review of this revision.Mar 22 2022, 12:48 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript

This contains a lot of unrelated changes, leftover comments, etc. As you clean up the code, please also include tests. Clang format the patch, go over the new code and make sure you follow the coding style. Remove unneeded parts (e.g., a map into which you simply push objects then take them out to push them into a vector).

Also, have you seen D120573?

I quickly went through the D120573. There are many overlapping.

Is it okay if I can put comments on the patch?

Is it okay if I can put comments on the patch?

Not sure what you mean but feel free.

would it make sense to submit separate patches for when (OMPC_when) and otherwise (OMPC_otherwise) clauses? The D120573 also has OMPC_when support.

There should be an update to D122255. It should not create the new one.D123598
--->
I did the following :
arc patch D122255
"did something/cleaning"
git commit -a
arc diff
---->

I update it but it created a new patch D123598.
I marked it Abandon. Not sure how to delete it.
I am submitting it again after cleaning the codes
and adding some basic tests.

The last update removed all previous updates. Can you point me to the correct way to do it?
I did the following :
arc patch D122255
"did something/cleaning"
git commit -a --amend
arc diff

Cleaned the code and added tests.

Should I update the patch? I am waiting for quick feedback on the concept of handling conditions.