Page MenuHomePhabricator

Rakete1111 (Nicolas Lesser)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 30 2017, 7:17 AM (103 w, 1 d)

Recent Activity

May 27 2019

Rakete1111 added inline comments to D53847: [C++2a] P0634r3: Down with typename!.
May 27 2019, 1:51 AM · Restricted Project

May 22 2019

Rakete1111 added inline comments to D53847: [C++2a] P0634r3: Down with typename!.
May 22 2019, 8:54 AM · Restricted Project
Rakete1111 added inline comments to D53847: [C++2a] P0634r3: Down with typename!.
May 22 2019, 8:52 AM · Restricted Project
Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.
  • rebased
  • addressed review comments
May 22 2019, 8:52 AM · Restricted Project

May 21 2019

Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

Add support for implicit typenames of the form T::template U</*...*>

May 21 2019, 2:42 AM · Restricted Project
Rakete1111 added inline comments to D53847: [C++2a] P0634r3: Down with typename!.
May 21 2019, 1:36 AM · Restricted Project
Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.
  • Addressed review comments
May 21 2019, 1:32 AM · Restricted Project

May 19 2019

Rakete1111 committed rGe47ae69fa73a: Fix buildbot: Use correct Consume*() for braces. (authored by Rakete1111).
Fix buildbot: Use correct Consume*() for braces.
May 19 2019, 8:28 AM
Rakete1111 committed rC361120: Fix buildbot: Use correct Consume*() for braces..
Fix buildbot: Use correct Consume*() for braces.
May 19 2019, 8:28 AM
Rakete1111 committed rL361120: Fix buildbot: Use correct Consume*() for braces..
Fix buildbot: Use correct Consume*() for braces.
May 19 2019, 8:28 AM
Rakete1111 committed rGf53d1727107e: Added a better diagnostic when using the delete operator with lambdas (authored by Rakete1111).
Added a better diagnostic when using the delete operator with lambdas
May 19 2019, 8:08 AM
Rakete1111 committed rC361119: Added a better diagnostic when using the delete operator with lambdas.
Added a better diagnostic when using the delete operator with lambdas
May 19 2019, 8:05 AM
Rakete1111 committed rL361119: Added a better diagnostic when using the delete operator with lambdas.
Added a better diagnostic when using the delete operator with lambdas
May 19 2019, 8:05 AM
Rakete1111 closed D36357: Added a better diagnostic when using the delete operator with lambdas.
May 19 2019, 8:05 AM · Restricted Project, Restricted Project

May 15 2019

Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.
  • Use TryConsumeToken
May 15 2019, 2:16 AM · Restricted Project, Restricted Project
Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.
  • Fix crash with invalid postfix expr
  • Don't emit FixIt when using <
May 15 2019, 2:10 AM · Restricted Project, Restricted Project

May 14 2019

Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Nevermind, seems to be working fine even with.

May 14 2019, 3:58 PM · Restricted Project, Restricted Project
Rakete1111 added a comment to D36357: Added a better diagnostic when using the delete operator with lambdas.

How should I do this? Do I just skip to the next }, or also take into account any additional scopes? Also does this mean that I skip and then revert, because that seems pretty expensive?

It would be a little expensive, yes, but we'd only be doing it on codepaths where we're producing an error -- for an ill-formed program, it's OK to take more time in order to produce a better diagnostic. Skipping to the next } won't work, because SkipUntil will skip over pairs of brace-balanced tokens (so you'll skip past the } you're looking for), but skipping until the next { and then skipping to the } after it should work.

May 14 2019, 1:41 PM · Restricted Project, Restricted Project
Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.
  • Addressed review comments
May 14 2019, 2:24 AM · Restricted Project, Restricted Project
Rakete1111 added a comment to D36357: Added a better diagnostic when using the delete operator with lambdas.

we could perform a tentative parse and skip to the } of the lambda.

May 14 2019, 2:19 AM · Restricted Project, Restricted Project

May 6 2019

Rakete1111 added a comment to D60934: [clang] adding explicit(bool) from c++2a.

@Tyker This broke the Chromium build, could you investigate please? http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20190506/270340.html

May 6 2019, 4:25 AM · Restricted Project, Restricted Project

May 5 2019

Rakete1111 committed rG5125a02a032a: [clang] fixing -ast-print for variadic parameter pack in lambda capture (authored by Rakete1111).
[clang] fixing -ast-print for variadic parameter pack in lambda capture
May 5 2019, 5:34 AM
Rakete1111 committed rL359980: [clang] fixing -ast-print for variadic parameter pack in lambda capture.
[clang] fixing -ast-print for variadic parameter pack in lambda capture
May 5 2019, 5:34 AM
Rakete1111 committed rC359980: [clang] fixing -ast-print for variadic parameter pack in lambda capture.
[clang] fixing -ast-print for variadic parameter pack in lambda capture
May 5 2019, 5:34 AM
Rakete1111 closed D61556: [clang] fixing -ast-print for variadic parameter pack in lambda capture.
May 5 2019, 5:34 AM · Restricted Project
Rakete1111 added a comment to D61556: [clang] fixing -ast-print for variadic parameter pack in lambda capture.

You might want to consider getting commit access.

May 5 2019, 5:33 AM · Restricted Project
Rakete1111 committed rC359979: [C++] Interpret unknown identifier in parameter clause as unknown type.
[C++] Interpret unknown identifier in parameter clause as unknown type
May 5 2019, 5:17 AM
Rakete1111 committed rGee0571734f58: [C++] Interpret unknown identifier in parameter clause as unknown type (authored by Rakete1111).
[C++] Interpret unknown identifier in parameter clause as unknown type
May 5 2019, 5:17 AM
Rakete1111 committed rL359979: [C++] Interpret unknown identifier in parameter clause as unknown type.
[C++] Interpret unknown identifier in parameter clause as unknown type
May 5 2019, 5:17 AM
Rakete1111 added a comment to D36357: Added a better diagnostic when using the delete operator with lambdas.

Is this also okay?

May 5 2019, 3:28 AM · Restricted Project, Restricted Project
Rakete1111 added a comment to D36357: Added a better diagnostic when using the delete operator with lambdas.

@rsmith One last question: The fixit diagnostic seems to be inconsistent with the rest?

May 5 2019, 3:16 AM · Restricted Project, Restricted Project

May 4 2019

Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

friendly ping :)

May 4 2019, 8:21 AM · Restricted Project, Restricted Project
Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

Don't leak memory and friendly ping :)

May 4 2019, 7:27 AM · Restricted Project
Rakete1111 committed rG55dc751ef7ad: [NFC] Add parentheses to avoid -Wparentheses. (authored by Rakete1111).
[NFC] Add parentheses to avoid -Wparentheses.
May 4 2019, 4:27 AM
Rakete1111 committed rL359968: [NFC] Add parentheses to avoid -Wparentheses..
[NFC] Add parentheses to avoid -Wparentheses.
May 4 2019, 4:27 AM
Rakete1111 committed rC359968: [NFC] Add parentheses to avoid -Wparentheses..
[NFC] Add parentheses to avoid -Wparentheses.
May 4 2019, 4:27 AM
Rakete1111 committed rG9c32fa1b1f60: [lldb] Fix buildbot failure due to clang AST change. (authored by Rakete1111).
[lldb] Fix buildbot failure due to clang AST change.
May 4 2019, 3:22 AM
Rakete1111 committed rLLDB359966: [lldb] Fix buildbot failure due to clang AST change..
[lldb] Fix buildbot failure due to clang AST change.
May 4 2019, 3:20 AM
Rakete1111 committed rL359966: [lldb] Fix buildbot failure due to clang AST change..
[lldb] Fix buildbot failure due to clang AST change.
May 4 2019, 3:19 AM

May 3 2019

Rakete1111 committed rG5fe2ddbdf47d: [clang] adding explicit(bool) from c++2a (authored by Rakete1111).
[clang] adding explicit(bool) from c++2a
May 3 2019, 5:08 PM
Rakete1111 committed rL359949: [clang] adding explicit(bool) from c++2a.
[clang] adding explicit(bool) from c++2a
May 3 2019, 5:07 PM
Rakete1111 committed rC359949: [clang] adding explicit(bool) from c++2a.
[clang] adding explicit(bool) from c++2a
May 3 2019, 5:07 PM
Rakete1111 closed D60934: [clang] adding explicit(bool) from c++2a.
May 3 2019, 5:07 PM · Restricted Project, Restricted Project
Rakete1111 added a comment to D61522: Added an assertion to constant evaluation enty points that prohibits dependent expressions.

Can you add tests for the bugs you fixed? thanks

May 3 2019, 10:59 AM · Restricted Project, Restricted Project

May 1 2019

Rakete1111 added inline comments to D60934: [clang] adding explicit(bool) from c++2a.
May 1 2019, 12:23 PM · Restricted Project, Restricted Project

Apr 30 2019

Rakete1111 added inline comments to D60934: [clang] adding explicit(bool) from c++2a.
Apr 30 2019, 3:58 PM · Restricted Project, Restricted Project

Apr 25 2019

Rakete1111 added a comment to D60934: [clang] adding explicit(bool) from c++2a.

Thanks for working on this! :)

Apr 25 2019, 2:33 AM · Restricted Project, Restricted Project

Apr 12 2019

Rakete1111 committed rGb95559c96475: [NFC] Move the export attribute after extern "C". (authored by Rakete1111).
[NFC] Move the export attribute after extern "C".
Apr 12 2019, 11:33 AM
Rakete1111 committed rUNW358301: [NFC] Move the export attribute after extern "C"..
[NFC] Move the export attribute after extern "C".
Apr 12 2019, 11:33 AM
Rakete1111 committed rL358301: [NFC] Move the export attribute after extern "C"..
[NFC] Move the export attribute after extern "C".
Apr 12 2019, 11:33 AM

Mar 28 2019

Rakete1111 accepted D59900: [Sema] Fix a crash when nonnull checking.

Otherwise LGTM.

Mar 28 2019, 2:43 PM · Restricted Project, Restricted Project

Mar 26 2019

Rakete1111 added inline comments to D59754: [Sema] Add c++2a designated initializer warnings.
Mar 26 2019, 2:36 AM · Restricted Project

Mar 25 2019

Rakete1111 added inline comments to D59754: [Sema] Add c++2a designated initializer warnings.
Mar 25 2019, 3:03 PM · Restricted Project
Rakete1111 added inline comments to D59754: [Sema] Add c++2a designated initializer warnings.
Mar 25 2019, 2:17 PM · Restricted Project

Mar 13 2019

Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Rebase + friendly ping :).

Mar 13 2019, 9:43 AM · Restricted Project, Restricted Project

Mar 10 2019

Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

Don't relookup the qualified-id and use the cached one instead if possible.

Mar 10 2019, 11:27 AM · Restricted Project
Rakete1111 added a comment to D53847: [C++2a] P0634r3: Down with typename!.

rsmith:

Some thoughts on this:

  • Can this be unified with the lookup code in HandleDeclarator? This is really the same lookup, repeated in two places.

What I wrote:

Mar 10 2019, 10:37 AM · Restricted Project
Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

Fix a bug where T::value inside a functional cast in a template argument would be interpreted as a function type.

Mar 10 2019, 10:22 AM · Restricted Project

Feb 18 2019

Rakete1111 abandoned D57540: [C++17] Don't crash while diagnosing different access specifier of a deduction guide..

This revision has been superseded :)

Feb 18 2019, 6:04 PM · Restricted Project

Feb 2 2019

Rakete1111 added inline comments to D57540: [C++17] Don't crash while diagnosing different access specifier of a deduction guide..
Feb 2 2019, 4:55 AM · Restricted Project

Jan 31 2019

Rakete1111 created D57540: [C++17] Don't crash while diagnosing different access specifier of a deduction guide..
Jan 31 2019, 1:20 PM · Restricted Project

Jan 27 2019

Rakete1111 added a comment to D56974: [SemaCXX] Fix ICE with structure bindings to members of template.

Backporting to 8.0.0 is possibly possible, you'll need to ping Hans. I don't know about previous versions though.

Jan 27 2019, 11:24 AM · Restricted Project
Rakete1111 committed rC352323: [SemaCXX] Fix ICE with structure bindings to members of template.
[SemaCXX] Fix ICE with structure bindings to members of template
Jan 27 2019, 11:21 AM
Rakete1111 committed rL352323: [SemaCXX] Fix ICE with structure bindings to members of template.
[SemaCXX] Fix ICE with structure bindings to members of template
Jan 27 2019, 11:21 AM
Rakete1111 closed D56974: [SemaCXX] Fix ICE with structure bindings to members of template.
Jan 27 2019, 11:21 AM · Restricted Project

Jan 20 2019

Rakete1111 added a comment to D56974: [SemaCXX] Fix ICE with structure bindings to members of template.

Yeah, seems like we don't instantiate pair<int, int> at all in that specific case. LGTM but you might want to wait for someone else to confirm.

Jan 20 2019, 2:23 AM · Restricted Project

Jan 10 2019

Rakete1111 committed rC350874: Fix false positive unsequenced access and modification warning in array….
Fix false positive unsequenced access and modification warning in array…
Jan 10 2019, 11:09 AM
Rakete1111 committed rL350874: Fix false positive unsequenced access and modification warning in array….
Fix false positive unsequenced access and modification warning in array…
Jan 10 2019, 11:09 AM
Rakete1111 closed D50766: Fix false positive unsequenced access and modification warning in array subscript expression..
Jan 10 2019, 11:09 AM · Restricted Project

Dec 18 2018

Rakete1111 added a comment to D55039: [sema] Warn of mangling change if function parameters are noexcept..

Apart from the comments I think your patch LGTM, but I'll let someone else hav the final say.

Dec 18 2018, 2:27 AM

Dec 14 2018

Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

@rsmith do you have any more comments?

Dec 14 2018, 2:28 PM · Restricted Project

Dec 4 2018

Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

Rebase + friendly ping :)

Dec 4 2018, 12:04 AM · Restricted Project

Dec 3 2018

Rakete1111 added inline comments to D55039: [sema] Warn of mangling change if function parameters are noexcept..
Dec 3 2018, 11:56 PM

Nov 28 2018

Rakete1111 added a comment to D55039: [sema] Warn of mangling change if function parameters are noexcept..

You're missing the case of the function return type of a parameter.

Nov 28 2018, 10:32 PM

Nov 27 2018

Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

Rebase and friendly ping! :)

Nov 27 2018, 12:13 PM · Restricted Project

Nov 14 2018

Rakete1111 added inline comments to D53847: [C++2a] P0634r3: Down with typename!.
Nov 14 2018, 10:41 PM · Restricted Project
Rakete1111 added inline comments to D53847: [C++2a] P0634r3: Down with typename!.
Nov 14 2018, 10:39 PM · Restricted Project
Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

Addressed review comments :)

Nov 14 2018, 10:39 PM · Restricted Project

Nov 12 2018

Rakete1111 accepted D54414: [Sema] Make sure we substitute an instantiation-dependent default template parameter.

LGTM, thanks :)

Nov 12 2018, 6:57 AM

Nov 7 2018

Rakete1111 added a comment to D53847: [C++2a] P0634r3: Down with typename!.

I also found another diagnostic regression:

Nov 7 2018, 3:38 PM · Restricted Project
Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

Addressed review comments! :)

Nov 7 2018, 3:30 PM · Restricted Project

Nov 1 2018

Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

I'm pretty sure I implemented the rules correctly now :)

Nov 1 2018, 1:23 PM · Restricted Project
Rakete1111 added inline comments to D53847: [C++2a] P0634r3: Down with typename!.
Nov 1 2018, 11:16 AM · Restricted Project
Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

Remove spaces to be consistent.

Nov 1 2018, 9:24 AM · Restricted Project
Rakete1111 added inline comments to D53847: [C++2a] P0634r3: Down with typename!.
Nov 1 2018, 9:19 AM · Restricted Project
Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

Addressed review comments! :)

Nov 1 2018, 9:16 AM · Restricted Project

Oct 29 2018

Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

Fix easy errors in tests that I missed by adding explicit template instantations.

Oct 29 2018, 4:34 PM · Restricted Project
Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

Remove unneeded -Wc++2a-compat flag in tests.

Oct 29 2018, 4:22 PM · Restricted Project
Rakete1111 added inline comments to D53847: [C++2a] P0634r3: Down with typename!.
Oct 29 2018, 4:19 PM · Restricted Project
Rakete1111 created D53847: [C++2a] P0634r3: Down with typename!.
Oct 29 2018, 4:16 PM · Restricted Project

Oct 28 2018

Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Rebase and friendly ping :)

Oct 28 2018, 5:20 AM · Restricted Project, Restricted Project

Oct 25 2018

Rakete1111 committed rL345308: [C++17] Reject shadowing of capture by parameter in lambda.
[C++17] Reject shadowing of capture by parameter in lambda
Oct 25 2018, 1:17 PM
Rakete1111 committed rC345308: [C++17] Reject shadowing of capture by parameter in lambda.
[C++17] Reject shadowing of capture by parameter in lambda
Oct 25 2018, 1:17 PM
Rakete1111 closed D53595: [C++17] Reject shadowing of capture by parameter in lambda.
Oct 25 2018, 1:17 PM
Rakete1111 updated the diff for D53595: [C++17] Reject shadowing of capture by parameter in lambda.

Update DR list.

Oct 25 2018, 1:16 PM
Rakete1111 committed rC345303: Rebase defect report list..
Rebase defect report list.
Oct 25 2018, 12:30 PM
Rakete1111 committed rL345303: Rebase defect report list..
Rebase defect report list.
Oct 25 2018, 12:30 PM
Rakete1111 added a comment to D53595: [C++17] Reject shadowing of capture by parameter in lambda.

Addresed review comments :)

I updated the dr status file but a lot of unrelated changes made it in. Is this okay?

Please regenerate the file without your change and check that in as a separate commit prior to this.

Oct 25 2018, 12:19 PM

Oct 24 2018

Rakete1111 updated the diff for D53595: [C++17] Reject shadowing of capture by parameter in lambda.

Addresed review comments :)

Oct 24 2018, 1:45 AM

Oct 23 2018

Rakete1111 updated the diff for D53595: [C++17] Reject shadowing of capture by parameter in lambda.

Use correct clang and version spelling.

Oct 23 2018, 2:52 PM