Page MenuHomePhabricator

Rakete1111 (Nicolas Lesser)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 30 2017, 7:17 AM (72 w, 1 d)

Recent Activity

Fri, Dec 14

Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

@rsmith do you have any more comments?

Fri, Dec 14, 2:28 PM

Tue, Dec 4

Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

Rebase + friendly ping :)

Tue, Dec 4, 12:04 AM

Mon, Dec 3

Rakete1111 added inline comments to D55039: [sema] Warn of mangling change if function parameters are noexcept..
Mon, Dec 3, 11:56 PM

Wed, Nov 28

Rakete1111 added a comment to D55039: [sema] Warn of mangling change if function parameters are noexcept..

You're missing the case of the function return type of a parameter.

Wed, Nov 28, 10:32 PM

Tue, Nov 27

Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

Rebase and friendly ping! :)

Tue, Nov 27, 12:13 PM

Nov 14 2018

Rakete1111 added inline comments to D53847: [C++2a] P0634r3: Down with typename!.
Nov 14 2018, 10:41 PM
Rakete1111 added inline comments to D53847: [C++2a] P0634r3: Down with typename!.
Nov 14 2018, 10:39 PM
Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

Addressed review comments :)

Nov 14 2018, 10:39 PM

Nov 12 2018

Rakete1111 accepted D54414: [Sema] Make sure we substitute an instantiation-dependent default template parameter.

LGTM, thanks :)

Nov 12 2018, 6:57 AM

Nov 7 2018

Rakete1111 added a comment to D53847: [C++2a] P0634r3: Down with typename!.

I also found another diagnostic regression:

Nov 7 2018, 3:38 PM
Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

Addressed review comments! :)

Nov 7 2018, 3:30 PM

Nov 1 2018

Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

I'm pretty sure I implemented the rules correctly now :)

Nov 1 2018, 1:23 PM
Rakete1111 added inline comments to D53847: [C++2a] P0634r3: Down with typename!.
Nov 1 2018, 11:16 AM
Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

Remove spaces to be consistent.

Nov 1 2018, 9:24 AM
Rakete1111 added inline comments to D53847: [C++2a] P0634r3: Down with typename!.
Nov 1 2018, 9:19 AM
Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

Addressed review comments! :)

Nov 1 2018, 9:16 AM

Oct 29 2018

Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

Fix easy errors in tests that I missed by adding explicit template instantations.

Oct 29 2018, 4:34 PM
Rakete1111 updated the diff for D53847: [C++2a] P0634r3: Down with typename!.

Remove unneeded -Wc++2a-compat flag in tests.

Oct 29 2018, 4:22 PM
Rakete1111 added inline comments to D53847: [C++2a] P0634r3: Down with typename!.
Oct 29 2018, 4:19 PM
Rakete1111 created D53847: [C++2a] P0634r3: Down with typename!.
Oct 29 2018, 4:16 PM

Oct 28 2018

Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Rebase and friendly ping :)

Oct 28 2018, 5:20 AM · Unknown Object (Project)

Oct 25 2018

Rakete1111 committed rL345308: [C++17] Reject shadowing of capture by parameter in lambda.
[C++17] Reject shadowing of capture by parameter in lambda
Oct 25 2018, 1:17 PM
Rakete1111 committed rC345308: [C++17] Reject shadowing of capture by parameter in lambda.
[C++17] Reject shadowing of capture by parameter in lambda
Oct 25 2018, 1:17 PM
Rakete1111 closed D53595: [C++17] Reject shadowing of capture by parameter in lambda.
Oct 25 2018, 1:17 PM
Rakete1111 updated the diff for D53595: [C++17] Reject shadowing of capture by parameter in lambda.

Update DR list.

Oct 25 2018, 1:16 PM
Rakete1111 committed rC345303: Rebase defect report list..
Rebase defect report list.
Oct 25 2018, 12:30 PM
Rakete1111 committed rL345303: Rebase defect report list..
Rebase defect report list.
Oct 25 2018, 12:30 PM
Rakete1111 added a comment to D53595: [C++17] Reject shadowing of capture by parameter in lambda.

Addresed review comments :)

I updated the dr status file but a lot of unrelated changes made it in. Is this okay?

Please regenerate the file without your change and check that in as a separate commit prior to this.

Oct 25 2018, 12:19 PM

Oct 24 2018

Rakete1111 updated the diff for D53595: [C++17] Reject shadowing of capture by parameter in lambda.

Addresed review comments :)

Oct 24 2018, 1:45 AM

Oct 23 2018

Rakete1111 updated the diff for D53595: [C++17] Reject shadowing of capture by parameter in lambda.

Use correct clang and version spelling.

Oct 23 2018, 2:52 PM
Rakete1111 updated the diff for D53595: [C++17] Reject shadowing of capture by parameter in lambda.

Addressed review comments! :) Thanks

Oct 23 2018, 1:53 PM
Rakete1111 added inline comments to D53595: [C++17] Reject shadowing of capture by parameter in lambda.
Oct 23 2018, 12:31 PM
Rakete1111 created D53595: [C++17] Reject shadowing of capture by parameter in lambda.
Oct 23 2018, 11:32 AM

Oct 12 2018

Rakete1111 added a comment to D52750: [Diagnostics] Check for integer overflow in array size expressions .

This doesn't produce a warning in C++11 and up.

But see Richard's comment: https://reviews.llvm.org/D52750#125175 so I am not sure :/

Oct 12 2018, 8:39 AM
Rakete1111 added a comment to D52750: [Diagnostics] Check for integer overflow in array size expressions .

This doesn't produce a warning in C++11 and up.

Oct 12 2018, 8:30 AM

Oct 11 2018

Rakete1111 added a comment to D52750: [Diagnostics] Check for integer overflow in array size expressions .

Nah, you don't even need to call EvaluateForOverflow I believe. :) Have a look overflow evaluation is done.

Oct 11 2018, 4:36 AM
Rakete1111 added a comment to D52750: [Diagnostics] Check for integer overflow in array size expressions .

The array size is still evaluated twice. Try to incorporate the check in Sema::VerifyIntegerConstantExpression.

Oct 11 2018, 3:35 AM
Rakete1111 added inline comments to D50766: Fix false positive unsequenced access and modification warning in array subscript expression..
Oct 11 2018, 2:51 AM · Unknown Object (Project)

Oct 10 2018

Rakete1111 accepted D50766: Fix false positive unsequenced access and modification warning in array subscript expression..

Nevermind my last comment, I was tired. LGTM

Oct 10 2018, 3:32 PM · Unknown Object (Project)
Rakete1111 added a comment to D50766: Fix false positive unsequenced access and modification warning in array subscript expression..

Sorry, for some reason I didn't see your updates.

Oct 10 2018, 2:19 PM · Unknown Object (Project)

Oct 6 2018

Rakete1111 added inline comments to D52750: [Diagnostics] Check for integer overflow in array size expressions .
Oct 6 2018, 10:47 AM

Oct 3 2018

Rakete1111 added a comment to D52791: [Diagnostics] Check for misleading pointer declarations.

There's a false positive.

Oct 3 2018, 1:38 PM

Aug 26 2018

Rakete1111 added a comment to D50766: Fix false positive unsequenced access and modification warning in array subscript expression..

What do you think?

Aug 26 2018, 12:19 PM · Unknown Object (Project)

Aug 18 2018

Rakete1111 added inline comments to D41284: [Concepts] Associated constraints infrastructure..
Aug 18 2018, 4:12 PM

Aug 16 2018

Rakete1111 requested changes to D50766: Fix false positive unsequenced access and modification warning in array subscript expression..

Your patch breaks a lot of stuff in the test suite. For example:

Aug 16 2018, 8:15 PM · Unknown Object (Project)
Rakete1111 added a comment to D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)".

It would be nice to be able to diagnose X:

Aug 16 2018, 5:38 PM · Unknown Object (Project)

Aug 8 2018

Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Rebase + friendly ping :)

Aug 8 2018, 5:24 PM · Unknown Object (Project)

Aug 3 2018

Rakete1111 updated the diff for D50291: [C++] Delay checking of constexpr-ness for special members..

Add missing test cases. :)

Aug 3 2018, 9:33 PM
Rakete1111 created D50291: [C++] Delay checking of constexpr-ness for special members..
Aug 3 2018, 6:01 PM

Aug 2 2018

Rakete1111 added a reviewer for D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)": Rakete1111.
Aug 2 2018, 6:31 PM · Unknown Object (Project)
Rakete1111 committed rC338801: Fold two cast plus a cast in a loop into a variable..
Fold two cast plus a cast in a loop into a variable.
Aug 2 2018, 6:25 PM
Rakete1111 committed rL338801: Fold two cast plus a cast in a loop into a variable..
Fold two cast plus a cast in a loop into a variable.
Aug 2 2018, 6:25 PM
Rakete1111 added inline comments to D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)".
Aug 2 2018, 4:06 PM · Unknown Object (Project)
Rakete1111 added inline comments to D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)".
Aug 2 2018, 2:36 PM · Unknown Object (Project)
Rakete1111 added inline comments to D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)".
Aug 2 2018, 1:04 PM · Unknown Object (Project)

Aug 1 2018

Rakete1111 added inline comments to D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)".
Aug 1 2018, 10:14 PM · Unknown Object (Project)
Rakete1111 added a comment to D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)".
  • There's a bug in your implementation:
Aug 1 2018, 10:04 AM · Unknown Object (Project)

Jul 27 2018

Rakete1111 committed rC338170: Parse a possible trailing postfix expression suffix after a fold expression.
Parse a possible trailing postfix expression suffix after a fold expression
Jul 27 2018, 2:55 PM
Rakete1111 committed rL338170: Parse a possible trailing postfix expression suffix after a fold expression.
Parse a possible trailing postfix expression suffix after a fold expression
Jul 27 2018, 2:55 PM
Rakete1111 closed D49848: Parse a possible trailing postfix expression suffix after a fold expression.
Jul 27 2018, 2:55 PM
Rakete1111 updated the diff for D49848: Parse a possible trailing postfix expression suffix after a fold expression.

Addressed review comments :)

Jul 27 2018, 1:59 PM

Jul 26 2018

Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Addressed review comments.

Jul 26 2018, 9:42 PM · Unknown Object (Project)
Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Rebased + friendly ping

Jul 26 2018, 5:09 PM · Unknown Object (Project)
Rakete1111 updated the diff for D49848: Parse a possible trailing postfix expression suffix after a fold expression.

Add a test without any casts.

Jul 26 2018, 2:44 PM
Rakete1111 updated the diff for D49848: Parse a possible trailing postfix expression suffix after a fold expression.

@rsmith you're right, it should. But it doesn't, because the the fold expression is considered to be a cast expression by ParseParenExpression and which parses any postfix pieces immediately after a cast, but it doesn't do so for fold expression, because they don't (not surprisingly) involve a cast.

Jul 26 2018, 2:40 PM
Rakete1111 retitled D49848: Parse a possible trailing postfix expression suffix after a fold expression from Parse a possible trailing postsfix expression suffix after a fold expression to Parse a possible trailing postfix expression suffix after a fold expression.
Jul 26 2018, 5:37 AM
Rakete1111 created D49848: Parse a possible trailing postfix expression suffix after a fold expression.
Jul 26 2018, 5:36 AM

Jul 13 2018

Rakete1111 committed rC337017: Fix PR34668 - P0704R1 implementation is too permissive.
Fix PR34668 - P0704R1 implementation is too permissive
Jul 13 2018, 9:32 AM
Rakete1111 committed rL337017: Fix PR34668 - P0704R1 implementation is too permissive.
Fix PR34668 - P0704R1 implementation is too permissive
Jul 13 2018, 9:32 AM
Rakete1111 closed D38075: Fix PR34668 - P0704R1 implementation is too permissive.
Jul 13 2018, 9:32 AM · Unknown Object (Project)
Rakete1111 updated the diff for D38075: Fix PR34668 - P0704R1 implementation is too permissive.

Change error message to reflect the new update error message since the last revision.

Jul 13 2018, 9:31 AM · Unknown Object (Project)
Rakete1111 accepted D38075: Fix PR34668 - P0704R1 implementation is too permissive.

LGTM with a small change in the error message that needs fixing.

Jul 13 2018, 3:22 AM · Unknown Object (Project)
Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Addressed review comments.

Jul 13 2018, 2:54 AM · Unknown Object (Project)

Jul 12 2018

Rakete1111 committed rL336930: [C++17] Disallow lambdas in template parameters (PR33696)..
[C++17] Disallow lambdas in template parameters (PR33696).
Jul 12 2018, 11:51 AM
Rakete1111 committed rC336930: [C++17] Disallow lambdas in template parameters (PR33696)..
[C++17] Disallow lambdas in template parameters (PR33696).
Jul 12 2018, 11:51 AM
Rakete1111 closed D37442: [C++17] Disallow lambdas in template parameters (PR33696)..
Jul 12 2018, 11:51 AM
Rakete1111 closed D37442: [C++17] Disallow lambdas in template parameters (PR33696)..
Jul 12 2018, 11:50 AM
Rakete1111 updated the diff for D37442: [C++17] Disallow lambdas in template parameters (PR33696)..

Format lines longer than 80 characters correctly.

Jul 12 2018, 11:40 AM
Rakete1111 closed D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list.

Committed in r336922 :)

Jul 12 2018, 10:49 AM · Unknown Object (Project)
Rakete1111 committed rL336922: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference….
[C++11] Fix warning when dropping cv-qualifiers when assigning to a reference…
Jul 12 2018, 10:49 AM
Rakete1111 committed rC336922: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference….
[C++11] Fix warning when dropping cv-qualifiers when assigning to a reference…
Jul 12 2018, 10:48 AM

Jul 10 2018

Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Rebased + friendly ping :)

Jul 10 2018, 2:23 PM · Unknown Object (Project)
Rakete1111 updated the diff for D37442: [C++17] Disallow lambdas in template parameters (PR33696)..

Rebased + friendly ping

Jul 10 2018, 2:13 PM
Rakete1111 updated the diff for D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list.

Rebased + friendly ping :)

Jul 10 2018, 2:01 PM · Unknown Object (Project)

Jun 28 2018

Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Addressed review comments :)

Jun 28 2018, 1:49 AM · Unknown Object (Project)

Jun 27 2018

Rakete1111 updated the diff for D37442: [C++17] Disallow lambdas in template parameters (PR33696)..

Added expression evaluation context to TreeTransform :)

Jun 27 2018, 2:03 PM

Jun 22 2018

Rakete1111 updated the diff for D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list.

done :)
Could you commit it please, @rsmith ?

Jun 22 2018, 2:00 AM · Unknown Object (Project)

Jun 21 2018

Rakete1111 updated the diff for D37442: [C++17] Disallow lambdas in template parameters (PR33696)..

Rebased + friendly ping :)

Jun 21 2018, 1:53 PM
Rakete1111 updated the diff for D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list.

Rebased + friendly ping :)

Jun 21 2018, 1:38 PM · Unknown Object (Project)
Rakete1111 added a comment to D36357: Added a better diagnostic when using the delete operator with lambdas.

@rsmith Should I only check for an identifier, like only "int" and nothing else? Because parsing a full type specifier might be a bit expensive, no?

Jun 21 2018, 12:55 PM · Unknown Object (Project)

May 25 2018

Rakete1111 updated the diff for D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list.

Rebased + friendly ping :)

May 25 2018, 1:03 AM · Unknown Object (Project)
Rakete1111 updated the diff for D37442: [C++17] Disallow lambdas in template parameters (PR33696)..

Rebase and friendly ping :)

May 25 2018, 12:37 AM

Mar 18 2018

Rakete1111 updated the diff for D38216: [C++17] Fix class template argument deduction for default constructors without an initializer.

@lichray Ok done :) Thanks for reviewing

Mar 18 2018, 1:11 PM · Unknown Object (Project)

Mar 15 2018

Rakete1111 created D44534: Fix codegen for structured binding binding in conditions.
Mar 15 2018, 12:54 PM · Unknown Object (Project)

Mar 14 2018

Rakete1111 updated the diff for D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list.

Addressed review comments :)
I added a test case for the crashing code.

Mar 14 2018, 11:34 AM · Unknown Object (Project)
Rakete1111 added a comment to D40445: [C++17] Allow an empty expression in an if init statement.

@rsmith Can you commit please?

Mar 14 2018, 7:43 AM · Unknown Object (Project)
Rakete1111 updated the diff for D40445: [C++17] Allow an empty expression in an if init statement.

Rebase and ping :)

Mar 14 2018, 6:25 AM · Unknown Object (Project)
Rakete1111 updated the diff for D37442: [C++17] Disallow lambdas in template parameters (PR33696)..

Rebase and ping :)

Mar 14 2018, 6:05 AM
Rakete1111 added a comment to D36357: Added a better diagnostic when using the delete operator with lambdas.

@rsmith Which type specifiers should I test for? just T? Or also T*, T&, ...? Now I'm just checking for an identifier, but anything else would make the lookahead more complicated I think. Any ideas?

Mar 14 2018, 5:53 AM · Restricted Project
Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Did you forget to upload the updated patch? This looks unchanged compared to the prior version.

Mar 14 2018, 5:48 AM · Restricted Project