Rakete1111 (Nicolas Lesser)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 30 2017, 7:17 AM (63 w, 6 d)

Recent Activity

Fri, Oct 12

Rakete1111 added a comment to D52750: [Diagnostics] Check for integer overflow in array size expressions .

This doesn't produce a warning in C++11 and up.

But see Richard's comment: https://reviews.llvm.org/D52750#125175 so I am not sure :/

Fri, Oct 12, 8:39 AM
Rakete1111 added a comment to D52750: [Diagnostics] Check for integer overflow in array size expressions .

This doesn't produce a warning in C++11 and up.

Fri, Oct 12, 8:30 AM

Thu, Oct 11

Rakete1111 added a comment to D52750: [Diagnostics] Check for integer overflow in array size expressions .

Nah, you don't even need to call EvaluateForOverflow I believe. :) Have a look overflow evaluation is done.

Thu, Oct 11, 4:36 AM
Rakete1111 added a comment to D52750: [Diagnostics] Check for integer overflow in array size expressions .

The array size is still evaluated twice. Try to incorporate the check in Sema::VerifyIntegerConstantExpression.

Thu, Oct 11, 3:35 AM
Rakete1111 added inline comments to D50766: Fix false positive unsequenced access and modification warning in array subscript expression..
Thu, Oct 11, 2:51 AM · Unknown Object (Project)

Wed, Oct 10

Rakete1111 accepted D50766: Fix false positive unsequenced access and modification warning in array subscript expression..

Nevermind my last comment, I was tired. LGTM

Wed, Oct 10, 3:32 PM · Unknown Object (Project)
Rakete1111 added a comment to D50766: Fix false positive unsequenced access and modification warning in array subscript expression..

Sorry, for some reason I didn't see your updates.

Wed, Oct 10, 2:19 PM · Unknown Object (Project)

Sat, Oct 6

Rakete1111 added inline comments to D52750: [Diagnostics] Check for integer overflow in array size expressions .
Sat, Oct 6, 10:47 AM

Wed, Oct 3

Rakete1111 added a comment to D52791: [Diagnostics] Check for misleading pointer declarations.

There's a false positive.

Wed, Oct 3, 1:38 PM

Aug 26 2018

Rakete1111 added a comment to D50766: Fix false positive unsequenced access and modification warning in array subscript expression..

What do you think?

Aug 26 2018, 12:19 PM · Unknown Object (Project)

Aug 18 2018

Rakete1111 added inline comments to D41284: [Concepts] Associated constraints infrastructure..
Aug 18 2018, 4:12 PM

Aug 16 2018

Rakete1111 requested changes to D50766: Fix false positive unsequenced access and modification warning in array subscript expression..

Your patch breaks a lot of stuff in the test suite. For example:

Aug 16 2018, 8:15 PM · Unknown Object (Project)
Rakete1111 added a comment to D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)".

It would be nice to be able to diagnose X:

Aug 16 2018, 5:38 PM · Unknown Object (Project)

Aug 8 2018

Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Rebase + friendly ping :)

Aug 8 2018, 5:24 PM · Unknown Object (Project)

Aug 3 2018

Rakete1111 updated the diff for D50291: [C++] Delay checking of constexpr-ness for special members..

Add missing test cases. :)

Aug 3 2018, 9:33 PM
Rakete1111 created D50291: [C++] Delay checking of constexpr-ness for special members..
Aug 3 2018, 6:01 PM

Aug 2 2018

Rakete1111 added a reviewer for D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)": Rakete1111.
Aug 2 2018, 6:31 PM · Unknown Object (Project)
Rakete1111 committed rC338801: Fold two cast plus a cast in a loop into a variable..
Fold two cast plus a cast in a loop into a variable.
Aug 2 2018, 6:25 PM
Rakete1111 committed rL338801: Fold two cast plus a cast in a loop into a variable..
Fold two cast plus a cast in a loop into a variable.
Aug 2 2018, 6:25 PM
Rakete1111 added inline comments to D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)".
Aug 2 2018, 4:06 PM · Unknown Object (Project)
Rakete1111 added inline comments to D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)".
Aug 2 2018, 2:36 PM · Unknown Object (Project)
Rakete1111 added inline comments to D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)".
Aug 2 2018, 1:04 PM · Unknown Object (Project)

Aug 1 2018

Rakete1111 added inline comments to D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)".
Aug 1 2018, 10:14 PM · Unknown Object (Project)
Rakete1111 added a comment to D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)".
  • There's a bug in your implementation:
Aug 1 2018, 10:04 AM · Unknown Object (Project)

Jul 27 2018

Rakete1111 committed rC338170: Parse a possible trailing postfix expression suffix after a fold expression.
Parse a possible trailing postfix expression suffix after a fold expression
Jul 27 2018, 2:55 PM
Rakete1111 committed rL338170: Parse a possible trailing postfix expression suffix after a fold expression.
Parse a possible trailing postfix expression suffix after a fold expression
Jul 27 2018, 2:55 PM
Rakete1111 closed D49848: Parse a possible trailing postfix expression suffix after a fold expression.
Jul 27 2018, 2:55 PM
Rakete1111 updated the diff for D49848: Parse a possible trailing postfix expression suffix after a fold expression.

Addressed review comments :)

Jul 27 2018, 1:59 PM

Jul 26 2018

Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Addressed review comments.

Jul 26 2018, 9:42 PM · Unknown Object (Project)
Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Rebased + friendly ping

Jul 26 2018, 5:09 PM · Unknown Object (Project)
Rakete1111 updated the diff for D49848: Parse a possible trailing postfix expression suffix after a fold expression.

Add a test without any casts.

Jul 26 2018, 2:44 PM
Rakete1111 updated the diff for D49848: Parse a possible trailing postfix expression suffix after a fold expression.

@rsmith you're right, it should. But it doesn't, because the the fold expression is considered to be a cast expression by ParseParenExpression and which parses any postfix pieces immediately after a cast, but it doesn't do so for fold expression, because they don't (not surprisingly) involve a cast.

Jul 26 2018, 2:40 PM
Rakete1111 retitled D49848: Parse a possible trailing postfix expression suffix after a fold expression from Parse a possible trailing postsfix expression suffix after a fold expression to Parse a possible trailing postfix expression suffix after a fold expression.
Jul 26 2018, 5:37 AM
Rakete1111 created D49848: Parse a possible trailing postfix expression suffix after a fold expression.
Jul 26 2018, 5:36 AM

Jul 13 2018

Rakete1111 committed rC337017: Fix PR34668 - P0704R1 implementation is too permissive.
Fix PR34668 - P0704R1 implementation is too permissive
Jul 13 2018, 9:32 AM
Rakete1111 committed rL337017: Fix PR34668 - P0704R1 implementation is too permissive.
Fix PR34668 - P0704R1 implementation is too permissive
Jul 13 2018, 9:32 AM
Rakete1111 closed D38075: Fix PR34668 - P0704R1 implementation is too permissive.
Jul 13 2018, 9:32 AM · Unknown Object (Project)
Rakete1111 updated the diff for D38075: Fix PR34668 - P0704R1 implementation is too permissive.

Change error message to reflect the new update error message since the last revision.

Jul 13 2018, 9:31 AM · Unknown Object (Project)
Rakete1111 accepted D38075: Fix PR34668 - P0704R1 implementation is too permissive.

LGTM with a small change in the error message that needs fixing.

Jul 13 2018, 3:22 AM · Unknown Object (Project)
Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Addressed review comments.

Jul 13 2018, 2:54 AM · Unknown Object (Project)

Jul 12 2018

Rakete1111 committed rL336930: [C++17] Disallow lambdas in template parameters (PR33696)..
[C++17] Disallow lambdas in template parameters (PR33696).
Jul 12 2018, 11:51 AM
Rakete1111 committed rC336930: [C++17] Disallow lambdas in template parameters (PR33696)..
[C++17] Disallow lambdas in template parameters (PR33696).
Jul 12 2018, 11:51 AM
Rakete1111 closed D37442: [C++17] Disallow lambdas in template parameters (PR33696)..
Jul 12 2018, 11:51 AM
Rakete1111 closed D37442: [C++17] Disallow lambdas in template parameters (PR33696)..
Jul 12 2018, 11:50 AM
Rakete1111 updated the diff for D37442: [C++17] Disallow lambdas in template parameters (PR33696)..

Format lines longer than 80 characters correctly.

Jul 12 2018, 11:40 AM
Rakete1111 closed D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list.

Committed in r336922 :)

Jul 12 2018, 10:49 AM · Unknown Object (Project)
Rakete1111 committed rL336922: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference….
[C++11] Fix warning when dropping cv-qualifiers when assigning to a reference…
Jul 12 2018, 10:49 AM
Rakete1111 committed rC336922: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference….
[C++11] Fix warning when dropping cv-qualifiers when assigning to a reference…
Jul 12 2018, 10:48 AM

Jul 10 2018

Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Rebased + friendly ping :)

Jul 10 2018, 2:23 PM · Unknown Object (Project)
Rakete1111 updated the diff for D37442: [C++17] Disallow lambdas in template parameters (PR33696)..

Rebased + friendly ping

Jul 10 2018, 2:13 PM
Rakete1111 updated the diff for D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list.

Rebased + friendly ping :)

Jul 10 2018, 2:01 PM · Unknown Object (Project)

Jun 28 2018

Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Addressed review comments :)

Jun 28 2018, 1:49 AM · Unknown Object (Project)

Jun 27 2018

Rakete1111 updated the diff for D37442: [C++17] Disallow lambdas in template parameters (PR33696)..

Added expression evaluation context to TreeTransform :)

Jun 27 2018, 2:03 PM

Jun 22 2018

Rakete1111 updated the diff for D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list.

done :)
Could you commit it please, @rsmith ?

Jun 22 2018, 2:00 AM · Unknown Object (Project)

Jun 21 2018

Rakete1111 updated the diff for D37442: [C++17] Disallow lambdas in template parameters (PR33696)..

Rebased + friendly ping :)

Jun 21 2018, 1:53 PM
Rakete1111 updated the diff for D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list.

Rebased + friendly ping :)

Jun 21 2018, 1:38 PM · Unknown Object (Project)
Rakete1111 added a comment to D36357: Added a better diagnostic when using the delete operator with lambdas.

@rsmith Should I only check for an identifier, like only "int" and nothing else? Because parsing a full type specifier might be a bit expensive, no?

Jun 21 2018, 12:55 PM · Unknown Object (Project)

May 25 2018

Rakete1111 updated the diff for D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list.

Rebased + friendly ping :)

May 25 2018, 1:03 AM · Unknown Object (Project)
Rakete1111 updated the diff for D37442: [C++17] Disallow lambdas in template parameters (PR33696)..

Rebase and friendly ping :)

May 25 2018, 12:37 AM

Mar 18 2018

Rakete1111 updated the diff for D38216: [C++17] Fix class template argument deduction for default constructors without an initializer.

@lichray Ok done :) Thanks for reviewing

Mar 18 2018, 1:11 PM · Unknown Object (Project)

Mar 15 2018

Rakete1111 created D44534: Fix codegen for structured binding binding in conditions.
Mar 15 2018, 12:54 PM · Unknown Object (Project)

Mar 14 2018

Rakete1111 updated the diff for D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list.

Addressed review comments :)
I added a test case for the crashing code.

Mar 14 2018, 11:34 AM · Unknown Object (Project)
Rakete1111 added a comment to D40445: [C++17] Allow an empty expression in an if init statement.

@rsmith Can you commit please?

Mar 14 2018, 7:43 AM · Unknown Object (Project)
Rakete1111 updated the diff for D40445: [C++17] Allow an empty expression in an if init statement.

Rebase and ping :)

Mar 14 2018, 6:25 AM · Unknown Object (Project)
Rakete1111 updated the diff for D37442: [C++17] Disallow lambdas in template parameters (PR33696)..

Rebase and ping :)

Mar 14 2018, 6:05 AM
Rakete1111 added a comment to D36357: Added a better diagnostic when using the delete operator with lambdas.

@rsmith Which type specifiers should I test for? just T? Or also T*, T&, ...? Now I'm just checking for an identifier, but anything else would make the lookahead more complicated I think. Any ideas?

Mar 14 2018, 5:53 AM · Unknown Object (Project)
Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Did you forget to upload the updated patch? This looks unchanged compared to the prior version.

Mar 14 2018, 5:48 AM · Unknown Object (Project)

Mar 13 2018

Rakete1111 updated the diff for D38216: [C++17] Fix class template argument deduction for default constructors without an initializer.

Addressed review comments :)

Mar 13 2018, 7:38 AM · Unknown Object (Project)

Jan 16 2018

Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Addressed review comments :)

Jan 16 2018, 1:12 PM · Unknown Object (Project)
Rakete1111 updated the diff for D37442: [C++17] Disallow lambdas in template parameters (PR33696)..

I put the enum in ExpressionEvaluationContextRecord now, and fixed the Type -> Kind issue.

Jan 16 2018, 12:45 PM

Jan 5 2018

Rakete1111 added inline comments to D36357: Added a better diagnostic when using the delete operator with lambdas.
Jan 5 2018, 11:56 AM · Unknown Object (Project)
Rakete1111 updated the diff for D40445: [C++17] Allow an empty expression in an if init statement.

Addressed review comments. I'll write up a patch in the next coming days then :)

Jan 5 2018, 3:53 AM · Unknown Object (Project)

Jan 4 2018

Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Rebased + friendly 2018 ping :)

Jan 4 2018, 4:05 PM · Unknown Object (Project)
Rakete1111 updated the diff for D37442: [C++17] Disallow lambdas in template parameters (PR33696)..

Rebased + friendly 2018 ping

Jan 4 2018, 3:56 PM
Rakete1111 updated the diff for D38216: [C++17] Fix class template argument deduction for default constructors without an initializer.

Rebased + friendly 2018 ping

Jan 4 2018, 3:37 PM · Unknown Object (Project)
Rakete1111 updated the diff for D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list.

Rebased + friendly 2018 ping :)

Jan 4 2018, 3:25 PM · Unknown Object (Project)
Rakete1111 updated the diff for D40445: [C++17] Allow an empty expression in an if init statement.

Rebased + friendly 2018 ping :)

Jan 4 2018, 3:13 PM · Unknown Object (Project)

Dec 1 2017

Rakete1111 updated the summary of D36357: Added a better diagnostic when using the delete operator with lambdas.
Dec 1 2017, 11:59 AM · Unknown Object (Project)
Rakete1111 updated the diff for D36357: Added a better diagnostic when using the delete operator with lambdas.

Updated error message, added a FixItHint + a rebase and friendly ping :)

Dec 1 2017, 11:58 AM · Unknown Object (Project)

Nov 26 2017

Rakete1111 added inline comments to D40381: Parse concept definition.
Nov 26 2017, 4:52 AM

Nov 24 2017

Rakete1111 updated the diff for D40445: [C++17] Allow an empty expression in an if init statement.

Added more test coverage for compatibility warnings, and fixed a bug at the same time :).

Nov 24 2017, 1:42 PM · Unknown Object (Project)
Rakete1111 updated the diff for D40445: [C++17] Allow an empty expression in an if init statement.

Moved the while test outside of the #ifdef region for better coverage :)

Nov 24 2017, 12:24 PM · Unknown Object (Project)
Rakete1111 updated the diff for D40445: [C++17] Allow an empty expression in an if init statement.

Addressed final review comments by adding the appropriate warnings that were missing previously.

Nov 24 2017, 12:22 PM · Unknown Object (Project)
Rakete1111 updated the diff for D40445: [C++17] Allow an empty expression in an if init statement.

Added a test for the switch statement and added full context to the diff.

Nov 24 2017, 11:54 AM · Unknown Object (Project)
Rakete1111 created D40445: [C++17] Allow an empty expression in an if init statement.
Nov 24 2017, 9:40 AM · Unknown Object (Project)
Rakete1111 added inline comments to D40381: Parse concept definition.
Nov 24 2017, 4:46 AM

Nov 13 2017

Rakete1111 updated the diff for D38216: [C++17] Fix class template argument deduction for default constructors without an initializer.

Made DeduceInits empty instead of a workaround somewhere else. Is it still ok, @rsmith ?

Nov 13 2017, 1:01 PM · Unknown Object (Project)

Nov 11 2017

Rakete1111 added a comment to D38216: [C++17] Fix class template argument deduction for default constructors without an initializer.

@lichray Isn't [dcl.type.auto.deduct] only for auto and decltype(auto)? Class template argument deduction is in [dcl.type.class.deduct], which doesn't seem to disallow declarations without an initializer.

Nov 11 2017, 6:43 AM · Unknown Object (Project)
Rakete1111 updated the diff for D38216: [C++17] Fix class template argument deduction for default constructors without an initializer.

Slight change + rebased + friendly ping :)

Nov 11 2017, 4:03 AM · Unknown Object (Project)

Nov 6 2017

Rakete1111 updated the diff for D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list.
Nov 6 2017, 3:36 AM · Unknown Object (Project)
Rakete1111 created D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list.
Nov 6 2017, 3:35 AM · Unknown Object (Project)

Oct 31 2017

Rakete1111 updated the diff for D36101: Fix usage of right shift operator in fold expressions.

Added some more tests.
If this patch is still ok can you please commit it @rsmith ? Thanks!

Oct 31 2017, 6:37 AM · Unknown Object (Project)
Rakete1111 updated the diff for D36101: Fix usage of right shift operator in fold expressions.

Used Parser's GreaterThanIsOperator just to be sure. :)

Oct 31 2017, 5:55 AM · Unknown Object (Project)

Oct 27 2017

Rakete1111 abandoned D39360: [C++11] Don't put empty quotes in static_assert diagnostic..

@kimgr Well, mostly because they bother me a bit, don't know what others think though. I just thought it would be nice if they didn't appear, mainly because there is no need to show empty quotes in the error message. Hmm, you have a point though... Didn't think of that. Thanks +1

Oct 27 2017, 1:24 AM · Unknown Object (Project)

Oct 26 2017

Rakete1111 created D39360: [C++11] Don't put empty quotes in static_assert diagnostic..
Oct 26 2017, 10:34 PM · Unknown Object (Project)

Oct 23 2017

Rakete1111 added inline comments to D38954: [Sema] -Wzero-as-null-pointer-constant: don't warn for system macros other than NULL..
Oct 23 2017, 9:29 AM · Unknown Object (Project)

Oct 21 2017

Rakete1111 updated the diff for D36101: Fix usage of right shift operator in fold expressions.

Used the naming convention of LLVM + friendly ping. :)

Oct 21 2017, 11:32 AM · Unknown Object (Project)

Oct 20 2017

Rakete1111 added inline comments to D39122: [Sema] Fixes for enum handling for tautological comparison diagnostics.
Oct 20 2017, 12:27 PM · Unknown Object (Project)

Oct 14 2017

Rakete1111 updated the diff for D38216: [C++17] Fix class template argument deduction for default constructors without an initializer.

Rebased and friendly ping :)

Oct 14 2017, 11:22 AM · Restricted Project

Oct 6 2017

Rakete1111 added inline comments to D36918: [Sema] Take into account the current context when checking the accessibility of a member function pointer.
Oct 6 2017, 1:28 PM